Re: 2.6.24-rc6-mm1 - e1000 breakage

2007-12-26 Thread James Morris
On Wed, 26 Dec 2007, Andrew Morton wrote: > > (under current -mm, the e1000 driver doesn't find my ethernet card & the > > tcl tests won't run without an external interface). > > You might need to enable CONFIG_E1000E. Indeed, it works for me. - James --

Re: [PATCH] Exporting capability code/name pairs

2007-12-27 Thread James Morris
count); + if (rc) + return rc; + + *ppos += count; Use simple_read_from_buffer(). - James -- James Morris <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More m

Re: [PATCH] Exporting capability code/name pairs

2007-12-27 Thread James Morris
intf() and grab the return value. - James -- James Morris <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] Exporting capability code/name pairs

2007-12-28 Thread James Morris
&cap_entry_fops); > + if (!f_caps[i]) Ditto. Another issue is that securityfs depends on CONFIG_SECURITY, which might be undesirable, given that capabilities are a standard feature. - James -- James Morris <[EMAIL PROTECTED]> -

Re: [PATCH] security: remove security_sb_post_mountroot hook

2007-12-29 Thread James Morris
it/jmorris/selinux-2.6.git#for-akpm -- James Morris <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: 2.6.24-rc6-mm1 - git-lblnet.patch and networking horkage

2007-12-31 Thread James Morris
performance reasons in any case. > 2. Copy the ->iif field in __copy_skb_header() Seems valid. - James -- James Morris <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordom

Re: [PATCH] Exporting capability code/name pairs

2008-01-02 Thread James Morris
ilesystem is the best candidate? > I prefer procfs or sysfs instead. Sysfs makes more sense, as this information is system-wide and does not relate to specific processes. -- James Morris <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&

Re: Out of tree module using LSM

2007-11-28 Thread James Morris
tainability etc. That would be at least a useful first step in taking this issue seriously. Thanks, - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Out of tree module using LSM

2007-11-29 Thread James Morris
y have been accepted. - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Out of tree module using LSM

2007-11-30 Thread James Morris
been posted by Arjan (and acked by myself) for the case of valid out of tree users. The only case of this so far has been Multiadm, although there seems to be no reason for it to stay out of tree. - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the l

Re: Out of tree module using LSM

2007-11-30 Thread James Morris
articipation in the upstream process, rather than have upstream maintain stable kernel APIs which are naturally mismatched to the unknown requirements of out of tree users. - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe l

Re: [PATCH] VM/Security: add security hook to do_brk

2007-12-05 Thread James Morris
p_min_addr low memory protection. Add security checks > > in do_brk(). > > > > Signed-off-by: Eric Paris <[EMAIL PROTECTED]> > > ACK Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/selinux-2.6.git#for-akpm -- James Morris <[EMAIL PROTECTED]> -- To uns

Re: [TOMOYO #5 18/18] LSM expansion for TOMOYO Linux.

2007-11-19 Thread James Morris
th > skb_recv_datagram()/socket_post_accept()? > > If nobody has objection, I'd like to cut these > skb_recv_datagram()/socket_post_accept() changes > and submit to -mm tree. You should send anything which touches core networking to netdev, too, and get an ack from one of th

Re: [PATCH 57/59] security/selinux: Add missing "space"

2007-11-19 Thread James Morris
Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/selinux-2.6.git#for-akpm -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http:/

Re: [patch 1/1] selinux: do not clear f_op when removing entries

2007-11-21 Thread James Morris
On Wed, 21 Nov 2007, Stephen Smalley wrote: > Do not clear f_op when removing entries since it isn't safe to do. > > Signed-off-by: Stephen Smalley <[EMAIL PROTECTED]> Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/selinux-2.6.git#for-akpm -- James Morr

Re: [PATCH 3/3-v2] security: allow capable check to permit mmap or low vm space

2007-11-26 Thread James Morris
vm86 emulation can work even with mmap_min_addr set. > > Signed-off-by: Eric Paris <[EMAIL PROTECTED]> Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/selinux-2.6.git#for-akpm If nobody hollers, I'll push it to Linus when the next merge window opens. - James

Re: [PATCH -mm 2/2] do_wait: cleanup delay_group_leader() usage

2007-11-26 Thread James Morris
retval = wait_task_zombie(p, > (options & WNOWAIT), infop, > stat_addr, ru); > } else if (p->exit_state != EXIT_DEAD) { > -check_continued: >

Re: [PATCH 1/3] mmap: protect from stack expantion into low vm addresses

2007-11-26 Thread James Morris
he mmap_sem in read mode. We need the >* anon_vma lock to serialize against concurrent expand_stacks. >*/ > - address &= PAGE_MASK; > - error = 0; > > /* Somebody else might have raced and expanded it already */ > if (address < vma->vm_start) { >

Re: [PATCH 2/3 -v2] mmap: round mmap hint address above mmap_min_addr

2007-11-26 Thread James Morris
.c b/mm/nommu.c > index 35622c5..b989cb9 100644 > --- a/mm/nommu.c > +++ b/mm/nommu.c > @@ -829,6 +829,9 @@ unsigned long do_mmap_pgoff(struct file *file, > void *result; > int ret; > > + if (!(flags & MAP_FIXED)) > + addr = round_hint_to_min(addr); >

Re: [TOMOYO #6 retry 08/21] Utility functions and policy manipulationinterface.

2008-01-11 Thread James Morris
On Sat, 12 Jan 2008, Tetsuo Handa wrote: > Hello. > > James Morris wrote: > > > > TOMOYO Linux uses /sys/kernel/security/tomoyo interface for > > > > configuration. > > > > > > Why aren't you using securityfs for this? (It was designe

[PATCH][RFC] security: call security_file_permission from rw_verify_area

2008-01-12 Thread James Morris
Please review. Tested with SELinux in enforcing mode. --- All instances of rw_verify_area() are followed by a call to security_file_permission(), so just call the latter from the former. Signed-off-by: James Morris <[EMAIL PROTECTED]> --- fs/compat.c |4 --- fs/read_write.c

Re: [PATCH 00/26] Permit filesystem local caching

2008-01-15 Thread James Morris
supports unknown permission classes. Any recent distro policy should have this. - James -- James Morris <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vg

Re: [PATCH 08/26] Add a secctx_to_secid() LSM hook to go along with the existing

2008-01-15 Thread James Morris
kfree(secdata); > @@ -4937,6 +4942,7 @@ static struct security_operations selinux_ops = { > .setprocattr = selinux_setprocattr, > > .secid_to_secctx = selinux_secid_to_secctx, > + .secctx_to_secid = selinux_secctx_to_secid, >

Re: [PATCH 00/26] Permit filesystem local caching

2008-01-15 Thread James Morris
will need to go in after Paul Moore's labeled networking update (hopefully very soon after the next merge window opens). - James -- James Morris <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMA

Re: [PATCH 08/26] Add a secctx_to_secid() LSM hook to go along with the existing

2008-01-16 Thread James Morris
On Wed, 16 Jan 2008, Paul Moore wrote: > On Tuesday 15 January 2008 8:05:27 pm James Morris wrote: > > On Tue, 15 Jan 2008, David Howells wrote: > > > secid_to_secctx() LSM hook. This patch also includes the SELinux > > > implementation for this hook. > >

Re: [patch, rfc] mm.h, security.h, key.h and preventing namespace poisoning

2007-12-19 Thread James Morris
t;depend" on security.h not being included all over the place, as LSM does touch a lot of the kernel. Unecessarily including it is bad, of course. I'm not sure I understand your namespace pollution issue, either. In any case, I think the right solution is not to include security.h at all in

Re: [patch, rfc] mm.h, security.h, key.h and preventing namespace poisoning

2007-12-19 Thread James Morris
t; #include > > #include > > #include > > Fine by me. I'll queue it for -mm & 2.6.25. - James -- James Morris <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [AUDIT]: Increase skb->truesize in audit_expand

2008-01-28 Thread James Morris
anually. > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Acked-by: James Morris <[EMAIL PROTECTED]> (Candidate for stable ?) - James -- James Morris <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mess

Re: [2.6 patch] make selinux_set_mnt_opts() static

2008-01-28 Thread James Morris
int *flags, int num_opts) > { > int rc = 0, i; > struct task_security_struct *tsec = current->security; > -- James Morris <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PRO

Re: "Default Linux Capabilities" default in 2.6.24

2008-01-28 Thread James Morris
ies functionality. > > If you are unsure how to answer this question, answer Y. > > --- > > > > Does this seem incongruous? Also, what's the "question"? :) > > > > Thanks, > > Matt LaPlante > > Anyone? I think this should be default y.

Re: [patch 1/4] security/selinux/ss/policydb.c: fix sparse warnings

2005-03-19 Thread James Morris
On Sat, 19 Mar 2005 [EMAIL PROTECTED] wrote: > kj-domen/security/selinux/ss/policydb.c | 35 > ++-- > 1 files changed, 20 insertions(+), 15 deletions(-) Have you tested these changes? - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe

Re: [PATCH 01/04] Adding cipher mode context information to crypto_tfm

2005-02-08 Thread James Morris
from the calculations in > scatterwalk_start). Are these two conclusions correct, James? Yes, passing in an offset beyond the page size is wrong. Also, I don't know why PAGE_CACHE_SIZE is being used here instead of PAGE_SIZE. Even though they're always the same now, I would sug

Re: [PATCH 01/04] Adding cipher mode context information to crypto_tfm

2005-02-08 Thread James Morris
scatterlist *sg) { ... rest_of_page = PAGE_CACHE_SIZE - (sg->offset & (PAGE_CACHE_SIZE - 1)); walk->len_this_page = min(sg->length, rest_of_page); } rest_of_page should be just PAGE_SIZE - sg->offset (sg->offset should never extend beyond the page). And then how wou

Re: [PATCH 01/04] Adding cipher mode context information to crypto_tfm

2005-02-08 Thread James Morris
x17d/0x409 [esp4] [] xfrm4_rcv_encap+0x102/0x512 [] ip_local_deliver+0x9d/0x28c [] ip_rcv+0x251/0x508 [] netif_receive_skb+0x1f6/0x223 [] process_backlog+0x7c/0x10f [] net_rx_action+0x79/0xfb [] __do_softirq+0x62/0xcc [] do_softirq+0x57/0x5b - James -- James Morris <[EMAIL PROTECTED

Re: [PATCH 01/04] Adding cipher mode context information to crypto_tfm

2005-02-08 Thread James Morris
to something concrete in the existing kernel which would benefit from passing an arbitrary number of scatterlists in, just code for the case of processing two at once (input & output). - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "

Re: [PATCH 01/04] Adding cipher mode context information to crypto_tfm

2005-02-09 Thread James Morris
works beyond the test vectors. - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 01/04] Adding cipher mode context information to crypto_tfm

2005-02-09 Thread James Morris
oes not ever need to be kmapped. What you really need to do is use an array for the tweak (or possibly a structure which maintains state about it if needed). - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH 01/04] Adding cipher mode context information to crypto_tfm

2005-02-10 Thread James Morris
about my camelcase style in gfmulseq.c? My file isn't > even intended to be included by other files, unlike this include file. I don't know why the code is like that, but it is not an excuse to put more like it into the kernel. - James -- James Morris <[EMAIL PROTECTED]>

Re: [PATCH 01/04] Adding cipher mode context information to crypto_tfm

2005-02-10 Thread James Morris
linearly generated data fed into this process. It does not need to be kmapped. It is not discontiguous. There is no need for a third or Nth scatterlist. Making a generic N-way scatterlist processor is pointless overengineering, causing new problems with non-trivial solutions, for no bene

Re: [PATCH] 5/5: LSM hooks rework

2005-02-14 Thread James Morris
ressed in that area since then. - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: crypto algoritms failing?

2005-01-27 Thread James Morris
On Fri, 28 Jan 2005, Jasper Spaans wrote: > Is this supposed to happen? No. What is your kernel version? - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED]

Re: crypto algoritms failing?

2005-01-27 Thread James Morris
On Fri, 28 Jan 2005, Jasper Spaans wrote: > On Thu, Jan 27, 2005 at 07:38:43PM -0500, James Morris wrote: > > > Is this supposed to happen? > > > > No. What is your kernel version? > > Current bitkeeper + latest swsusp2 patches and hostap driver, however, those

Re: crypto algoritms failing?

2005-01-27 Thread James Morris
On Fri, 28 Jan 2005, Nigel Cunningham wrote: > You normally test cryptoapi functionality while booting? This happens if you link tcrypt statically into the kernel. - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-

Re: [PATCH 04/04] Add LRW

2005-01-30 Thread James Morris
.edu/~daw/papers/tweak-crypto02.pdf (Pointers to any critique of the system would be appreciated). - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH 04/04] Add LRW

2005-01-31 Thread James Morris
case, LRW should be made configurable and marked experimental. - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 01/04] Adding cipher mode context information to crypto_tfm

2005-02-02 Thread James Morris
ed here, given that this is not a fast path. I guess it doesn't do any harm. > + for(csg = walk_infos, cbuf = dispatch_list; csg->sw.sg; csg++, > cbuf++) { > + if(csg->ioflag == 1) for () if () > + for(csg = walk_infos;

Re: [PATCH 01/04] Adding cipher mode context information to crypto_tfm

2005-02-02 Thread James Morris
not needed for generic scatterwalk). - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH 01/04] Adding cipher mode context information to crypto_tfm

2005-02-02 Thread James Morris
hint for the compiler to do better jump > prediction and speculations. Remove? Correct, although I think this will get lost in the noise given that it's sitting in the middle of crypto processing. I'd remove it. - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe

Re: [PATCH 01/04] Adding cipher mode context information to crypto_tfm

2005-02-02 Thread James Morris
On Wed, 2 Feb 2005, James Morris wrote: > Correct, although I think this will get lost in the noise given that it's > sitting in the middle of crypto processing. I'd remove it. Dave just ok'd it, so take his advice over mine :-) - james -- James Morris <[EMAIL PROTEC

Re: [2.6 patch] better CRYPTO_AES <-> CRYPTO_AES_586 dependencies

2005-02-25 Thread James Morris
ES_586 or a new CRYPTO_AES_GENERIC option > depending on the platform. Good thinking, didn't think to chain selects. > BTW: Does CRYPTO_AES_586 work on an 386 or 486? >From memory it is generic i386 asm optimize for P5. - James -- James Morris <[EMAIL PROTECTED]> - To unsubs

Re: SELinux and sysfs

2005-02-27 Thread James Morris
he 'booleans' directory under the selinuxfs root. See http://www.tresys.com/Downloads/selinux-tools/README-COND.txt - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL P

Re: [PATCH] SELinux: null dereference in error path

2005-02-28 Thread James Morris
On Tue, 1 Mar 2005, Alexander Nyberg wrote: > The 'bad' label will call function that unconditionally dereferences > the NULL pointer. > > Found by the Coverity tool > > Signed-off-by: Alexander Nyberg <[EMAIL PROTECTED]> Signed-off-by: James Morris <

Re: [PATCH] SELinux: Leak in error path

2005-02-28 Thread James Morris
On Tue, 1 Mar 2005, Alexander Nyberg wrote: > There's a leak here in the first error path. > > Found by the Coverity tool. > > Signed-off-by: Alexander Nyberg <[EMAIL PROTECTED]> Signed-off-by: James Morris <[EMAIL PROTECTED]> -- James Morris <[EMAIL PROTE

New Kernel Crypto Maintainer

2005-03-04 Thread James Morris
fully stepped up to help. Hopefully things will now move forward more quickly in this area. - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More ma

Re: [PATCH] [request for inclusion] Realtime LSM

2005-03-08 Thread James Morris
not as a collection of miscellaneous features. In the case of this code, I would suggest integrating it into the core kernel, and providing an LSM hook to allow other LSMs to mediate it. As an example, see the vm_enough_memory hook. - James -- James Morris <[EMAIL PROTECTED]> - To

Re: Kernel Oops when using the Netfilter QUEUE target

2001-04-24 Thread James Morris
cket is a TCP packet; i have tried with ICMP and >UDP packets > also but this does not trigger any oops. I have tried to code on several computers >and they > all oops. The following description regards the case when submitting new packets >instead > of TCP packets. Please try t

Re: [PATCH][SELINUX] Add name_connect permission check

2005-04-03 Thread James Morris
updated policy to deal with it? You need an updated policy, which you can grab from rawhide for FC3 or via CVS at http://selinux.sourceforge.net/ - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH 1/2] CryptoAPI: prepare for processing multiple buffers at a time

2005-01-18 Thread James Morris
amework) to consider, if permission to dual license from the original authors can be obtained. - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at ht

[PATCH][SELINUX] Add Netlink message types for the TC action code.

2005-01-19 Thread James Morris
This patch adds Netlink message types related to the TC action code, allowing finer grained SELinux control of this. Please apply. Author: jamal <[EMAIL PROTECTED]> Signed-off-by: James Morris <[EMAIL PROTECTED]> Signed-off-by: Stephen Smalley <[EMAIL PROTECTED]> ---

Re: Announce loop-AES-v3.0b file/swap crypto package

2005-01-19 Thread James Morris
e generic scatterwalker solves the null encryption performance problem that was reported a little while back. - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More major

Re: [PATCH 1/2] CryptoAPI: prepare for processing multiple buffers at a time

2005-01-20 Thread James Morris
debugged and analyzed framework. - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Ple

Re: crypto/api.c: crypto_alg_available(): flags param not used.

2005-01-20 Thread James Morris
n example of why it's a bad idea to add infrastructure which isn't being used at the time. - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordom

Re: [PATCH 01/04] Adding cipher mode context information to crypto_tfm

2005-01-24 Thread James Morris
I'll review this in detail over the next day or so (still catching up on some backlog after vacation). Just wondering how much testing the generic scatterwalk code has had (I gather disk encryption has been tested, but what about ipsec?). - James -- James Morris <[EMAIL PROTECTED]&

Re: [PATCH 01/04] Adding cipher mode context information to crypto_tfm

2005-01-25 Thread James Morris
any cycles to work on implementing your ideas for more cleanly reworking Michal's multiblock code? Also, I would think this is more 2.6.12 material, at this stage. - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-ke

Re: [PATCH 01/04] Adding cipher mode context information to crypto_tfm

2005-01-25 Thread James Morris
ge. If we can get permission to use OCF, then we need to work out what's best. > And how - when there is more than one interface - are these projects > going to reuse code? I would imagine so. - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the

Re: [PATCH 2/3] mmap: round mmap hint address above mmap_min_addr

2007-11-16 Thread James Morris
On Fri, 16 Nov 2007, Eric Paris wrote: > On Sat, 2007-11-17 at 08:42 +1100, James Morris wrote: > > On Fri, 16 Nov 2007, Eric Paris wrote: > > > > > +#ifdef CONFIG_SECURITY > > > + /* > > > + * If a hint addr is less than mmap_min_addr change addr to

Re: [PATCH 2/3] mmap: round mmap hint address above mmap_min_addr

2007-11-16 Thread James Morris
t; mmap_min_addr)) > + addr = PAGE_ALIGN(mmap_min_addr); > +#endif > + > /* decide whether we should attempt the mapping, and if so what sort of >* mapping */ > ret = validate_mmap_request(file, addr, len, prot, flags, pgoff, > > -- James Morris

Re: [PATCH 3/3] security: allow capable check to permit mmap or low vm space

2007-11-16 Thread James Morris
at it is not done with !CONFIG_SECURITY ? - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Ple

Re: [PATCH 3/3] security: allow capable check to permit mmap or low vm space

2007-11-16 Thread James Morris
On Fri, 16 Nov 2007, Eric Paris wrote: > On Sat, 2007-11-17 at 08:47 +1100, James Morris wrote: > > On Fri, 16 Nov 2007, Eric Paris wrote: > > > > > On a kernel with CONFIG_SECURITY but without an LSM which implements > > > security_file_mmap it is impossible for

Re: [PATCH 3/3] security: allow capable check to permit mmap or low vm space

2007-11-16 Thread James Morris
ts > security is a win. (and remember, in kernel we still default this to > off so noone is going to 'accidentally' see and security checks in the > dummy hooks) If it's off by default and generally useful across LSMs, why not just put it in the base kernel code? - James --

Re: [AppArmor 34/45] Factor out sysctl pathname code

2007-10-26 Thread James Morris
On Thu, 25 Oct 2007, [EMAIL PROTECTED] wrote: > Convert the selinux sysctl pathname computation code into a standalone > function. > > Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> > Signed-off-by: John Johansen <[EMAIL PROTECTED]> Reviewed-by: Jam

Re: [PATCHv2] selinux: suppress a warning for 64k pages.

2007-10-31 Thread James Morris
security/selinux/xfrm.c | 13 +++-- > 1 files changed, 7 insertions(+), 6 deletions(-) > > This version suppresses the warning without ugly ifdefs. Thanks, Stephen. Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/selinux-2.6.git#for-linus -- James Morris &l

Re: [PATCH 02/10] Task Containers(V11): Add tasks file interface

2007-07-20 Thread James Morris
urrent->euid != tsk->uid) > + && (current->euid != tsk->suid)) { > + put_task_struct(tsk); > + return -EACCES; I wonder if we should allow CAP_SYS_ADMIN to do this, too. -- James Morris <[EMAIL PROT

Re: [PATCH][SELinux] Let us not leak memory in SELinux : security_netlbl_cache_add()

2007-07-20 Thread James Morris
tested. Thanks! Verified and applied to: git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/selinux-2.6.git#for-linus - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMA

Re: [PATCH 1/1] file capabilities: clear fcaps on inode change (v2)

2007-08-07 Thread James Morris
if (err) remove_privs(); with void remove_privs() { mutex_lock(); __remove_privs(); mutex_unlock(); } and then __remove_privs() handles the logic for all file privileges, including at this stage suid and the LSM call for file caps ? - James -- James

Re: [PATCH 1/1] file capabilities: clear fcaps on inode change (v2)

2007-08-07 Thread James Morris
On Tue, 7 Aug 2007, Serge E. Hallyn wrote: > Shall I resend without the LSM_NEED_LOCK, or do you still want a more > fundamental change? Removing the needlock is enough, the rest was just a query/suggestion. -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: s

Re: file capabilities: clear fcaps on inode change (v3)

2007-08-07 Thread James Morris
On Tue, 7 Aug 2007, Serge E. Hallyn wrote: > Yeah, I did that in v1, but didn't want to add two new security_ hooks. > But I'll send a v4 doing that. Yep, add what's actually needed. Continually having to jump through all of these hoops for LSM has gone beyond ridiculous.

Re: [PATCH] fix oops in __audit_signal_info()

2007-08-07 Thread James Morris
igned-off-by: Al Viro <[EMAIL PROTECTED]> Acked-by: James Morris <[EMAIL PROTECTED]> -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: file capabilities: clear fcaps on inode change (v3)

2007-08-08 Thread James Morris
On Wed, 8 Aug 2007, Serge E. Hallyn wrote: > Here is the next version. This one involved a bit more actual > switching of logic so was a bit more nerve-wracking, but it > seems to be working correctly now. Looks good to me. Acked-by: James Morris <[EMAIL PROTECTED]> -

Re: [PATCH 11/14] CacheFiles: Permit an inode's security ID to be obtained [try #2]

2007-08-09 Thread James Morris
On Thu, 9 Aug 2007, David Howells wrote: > + u32 (*inode_get_secid)(struct inode *inode); To maintain API consistency, please return an int which only acts as an error code, and returning the secid via a *u32 function parameter. - James -- James Morris <[EMAIL PROTECTED]

Re: [PATCH 11/14] CacheFiles: Permit an inode's security ID to be obtained [try #2]

2007-08-09 Thread James Morris
On Thu, 9 Aug 2007, David Howells wrote: > James Morris <[EMAIL PROTECTED]> wrote: > > > > + u32 (*inode_get_secid)(struct inode *inode); > > > > To maintain API consistency, please return an int which only acts as an > > error code, and returning

Re: [PATCH 11/14] CacheFiles: Permit an inode's security ID to be obtained [try #2]

2007-08-09 Thread James Morris
ld you instead simply pass the inode pointer around? (I know it's not always possible, but much preferred). - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 11/14] CacheFiles: Permit an inode's security ID to be obtained [try #2]

2007-08-09 Thread James Morris
On Thu, 9 Aug 2007, David Howells wrote: > James Morris <[EMAIL PROTECTED]> wrote: > > > David, I've looked at the code and can't see that you need to access the > > label itself outside the LSM. Could you instead simply pass the inode > > pointer aro

Re: [-mm patch] security/ cleanups

2007-07-30 Thread James Morris
required exit code > - remove a bunch of no longer used exports > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: James Morris <[EMAIL PROTECTED]> -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel&q

Re: [PATCH] [426/2many] MAINTAINERS - SELINUX SECURITY MODULE

2007-08-13 Thread James Morris
OTECTED] (subscribers-only) > W: http://www.nsa.gov/selinux > S: Supported > +F: include/linux/selinux* > +F: security/selinux/ Why are you changing descriptions of the maiking lists ? Nack. -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: sen

Re: [PATCH] [426/2many] MAINTAINERS - SELINUX SECURITY MODULE

2007-08-13 Thread James Morris
yOn Mon, 13 Aug 2007, Joe Perches wrote: > On Mon, 2007-08-13 at 05:13 -0700, James Morris wrote: > > On Sun, 12 Aug 2007, [EMAIL PROTECTED] wrote: > > > -L: linux-kernel@vger.kernel.org (kernel issues) > > > -L: [EMAIL PROTECTED] (subscribers-only, g

Re: System call interposition/unprotecting the table

2007-08-14 Thread James Morris
x27;s a debug aid at best. It clarifies to all developers that the syscall table should not be messed with. - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More ma

Re: + fix-null-pointer-dereference-in-__vm_enough_memory.patch added to -mm tree

2007-08-15 Thread James Morris
where we need > to pass the mm and the existing one is modified to pass current->mm to > avoid the need to change large amounts of code. > > (Thanks to Tobias for fixing rejects and testing) > > Signed-off-by: Alan Cox <[EMAIL PROTECTED]> > Cc: WU Fengguang <[EMAIL

Re: LSM conversion to static interface

2007-10-19 Thread James Morris
development practices, to not maintain unused infrastructure. - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: LSM conversion to static interface

2007-10-20 Thread James Morris
r upstream inclusion, which would be better at least in terms of upstream maintenance, as your code will be visible in the tree. - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: LSM conversion to static interface [revert patch]

2007-10-22 Thread James Morris
you also need to reinstate capability_exit and general modular bits for security/capability.c. - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 1/2] NetLabel: Introduce a new kernel configuration API for NetLabel - Version 11 (2.6.24-rc2) Smack: Simplified Mandatory Access Control Kernel

2007-11-09 Thread James Morris
; LSMs can perform their own configuration of the NetLabel subsystem without > > relying on assistance from userspace. > > > > Signed-off-by: Paul Moore <[EMAIL PROTECTED]> > > You sent it, so this patch needs a Signed-off-by:you, please. Also add Reviewed-by: J

Re: [Ksummit-2006-discuss] 2007 Linux Kernel Summit

2007-01-23 Thread James Morris
On Wed, 24 Jan 2007, Sunil Naidu wrote: > If Kernel community comes down to India...this would have a big impact > on the community + industry too. I think it's a good idea. > Any other reasons am missing here? Cost of flying 70 mainly US/European developers to India. - J

Re: [PATCH 09/29] selinux: tag avc cache alloc as non-critical

2007-02-21 Thread James Morris
On Wed, 21 Feb 2007, Peter Zijlstra wrote: > Failing to allocate a cache entry will only harm performance. > > Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> > --- > security/selinux/avc.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: James

Re: [PATCH 6c/10] lguest: the guest code

2007-02-09 Thread James Morris
enforced at > build-time? This is being disabled in the guest kernel only. The host and guest kernels are expected to be the same build. - James -- James Morris <[EMAIL PROTECTED]>

Re: [PATCH 4 of 7] lguest: Config and headers

2007-02-09 Thread James Morris
order from that via get_order(), as it should be 4 instead of 16; and this code is now both implying PAGE_SIZE while also using it for calculations. - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCH 4 of 7] lguest: Config and headers

2007-02-09 Thread James Morris
!hype_pages) + return -ENOMEM; This will try and allocate 2^16 pages. I guess we need a HYPERVISOR_PAGE_ORDER ? - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] M

Re: What will be in the x86-64/x86 2.6.21 merge

2007-02-12 Thread James Morris
On Sat, 10 Feb 2007, Andi Kleen wrote: > - lguest > * still seems heavily in development. Not sure it will be ready in time. How would you define ready? It's currently useful and stable, and features a lack of enterprise-class complexity. - James -- James Morris <[EMAIL PR

Re: What will be in the x86-64/x86 2.6.21 merge

2007-02-12 Thread James Morris
On Mon, 12 Feb 2007, Andi Kleen wrote: > > It's currently useful and stable, > > How do you know? I've been working on it for some weeks. At this stage, it's also useful for some simple kernel hacking. - James -- James Morris <[EMAIL PROTECTED]> - To uns

Re: [PATCH 1/8] lguest: Kconfig and headers

2007-02-12 Thread James Morris
FWIW, I've set up an unofficial git tree with these patches, and will try and track changes as they're posted. git://git.infradead.org/~jmorris/lguest-testing.git Use the 'current' branch. - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe fro

<    1   2   3   4   5   6   7   8   9   10   >