Considering where it failed and that 2.6.20.3 worked, I would be
extremely surprised if this wasn't one more report of
adjust-legacy-ide-resource-setting.patch breaking booting (and we
already have confirmed reports for this)...
But AFAIK we still don't understand how this patch managed to
I have to admit that I don't see the point here - I can't seem to make any
sense of the OR... Jan
Rusty Russell [EMAIL PROTECTED] 12.03.07 00:28
BUILD_BUG_ON_ZERO is named perfectly wrong, and BUILD_BUG_ON_RETURN_ZERO
is too long. Flip three bits, and the name is much more suitable.
Isn't defining these on i386 of at most historical value. The only consumer is
include/asm-generic/pgtable.h (ptep_clear_flush_{dirty,young}), and those are
already suppressed by __HAVE_ARCH_PTEP_CLEAR_{DIRTY,YOUNG}_FLUSH
being defined in include/asm-i386/pgtable.h. Or is there a particular need
While the kernel headers provide for this, there don't appear to be any
in-tree users (which seems contrary to general Linux policies). Would there
be objections to remove all of these?
Jan
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL
Jeremy Fitzhardinge [EMAIL PROTECTED] 16.03.07 06:10
Zachary Amsden wrote:
Well testing that is not so fun. I installed SUSE Pro 9.0, and
strings on ld.so contains the magic at_sysinfo assert! But it doesn't
install TLS libraries, so I'll have to install them by hand.
In works - in
Jeremy Fitzhardinge [EMAIL PROTECTED] 16.03.07 17:46
Jan Beulich wrote:
I have one, too (which is one reasone why I created the original Xen patch).
It's some version of SuSE 9, right? What glibc version?
Yes. 2.3.2.
Jan
-
To unsubscribe from this list: send the line unsubscribe linux
On Wed, Feb 07, 2007 at 09:32:54AM +0100, Christoph Hellwig wrote:
On Wed, Feb 07, 2007 at 07:59:18AM +, Linux Kernel Mailing List wrote:
[IA64] swiotlb abstraction (e.g. for Xen)
Add abstraction so that the file can be used by environments other than
IA64
and
If Jan actually had a goal with that except making the code utterly
unreadable he should try again with small patches that are well
explained and do one thing at a at time. (And cane be reviewed an
improved on if needed.
As the topic says - the goal is to support Xen.
Xen the linux
Andi Kleen [EMAIL PROTECTED] 10.02.07 12:50
From: Jeff Dike [EMAIL PROTECTED]
Kernel-mode traps on x86_64 can pollute the trap information for a previous
userspace trap for which the signal has not yet been delivered to the
process.
do_trap and do_general_protection set task-thread.error_code
Andi Kleen [EMAIL PROTECTED] 10.02.07 12:50
From: Bryan O'Sullivan [EMAIL PROTECTED]
This copy routine is memcpy-compatible, but on some architectures will use
cache-bypassing loads to avoid bringing the source data into the cache.
One case where this is useful is when a device issues a DMA
things work
again.
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
--- linux-2.6.20/arch/i386/kernel/sysenter.c2007-02-04 19:44:54.0
+0100
+++ 2.6.20/arch/i386/kernel/sysenter.c 2007-02-12 16:01:29.0 +0100
@@ -77,7 +77,7 @@ int __init sysenter_setup(void)
syscall_page
Yup. How does this patch look to you? We set error_code and trap_no
for userspace faults and kernel faults which call die(). We don't set
them for kernelspace faults which are fixed up.
That seems a reasonable approach.
Thanks, Jan
-
To unsubscribe from this list: send the line unsubscribe
Christoph Hellwig [EMAIL PROTECTED] 12.02.07 18:12
On Mon, Feb 12, 2007 at 07:30:55AM +, Jan Beulich wrote:
As the topic says - the goal is to support Xen. But yes, I was afraid
someone would
claim this make the code look ugly. And no, I currently don't have ideas to
address
any
Yup. How does this patch look to you? We set error_code and trap_no
for userspace faults and kernel faults which call die(). We don't set
them for kernelspace faults which are fixed up.
Actually, after a second round of thinking I believe there's still more to do
- your second patch missed
in high memory (which is specifically the case for all page
tables covering kernel space)
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
--- linux-2.6.20/arch/i386/mm/fault.c 2007-02-04 19:44:54.0 +0100
+++ 2.6.20-i386-page-fault-dump/arch/i386/mm/fault.c2007-02-14
08:31:38.0
Use mask_ack_irq() where possible.
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
--- linux-2.6.20/kernel/irq/chip.c 2007-02-04 19:44:54.0 +0100
+++ 2.6.20-irq-mask-ack/kernel/irq/chip.c 2007-02-09 10:17:26.0
+0100
@@ -534,10 +534,8 @@ __set_irq_handler(unsigned int irq
Whether a region is below 1Mb is determined by its start rather than
its end.
This hunk got erroneously dropped from a previous patch.
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
--- linux-2.6.20/arch/i386/kernel/cpu/mtrr/generic.c2007-02-04
19:44:54.0 +0100
+++ 2.6.20-x86-mtrr
/restore interrupts rather than disabling/
enabling them.
On x86-64, eliminate one function used here by folding it into its
single caller, convert to static, and rename for consistency with i386
(lkcd may like this).
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
--- linux-2.6.20/arch/i386/kernel/smp.c
Move inclusion of asm/fixmap.h to where it is really used rather than
where it may have been used long ago (requires a few other adjustments
to includes due to previous implicit dependencies).
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
--- linux-2.6.20/arch/x86_64/kernel/genapic.c 2007-02-04
Jeremy Fitzhardinge [EMAIL PROTECTED] 14.02.07 02:36
Dan Hecht wrote:
Why doesn't Xen allocate the shared_info page from the pseudo-physical
space? Doesn't it already have to steal pages from the
pseudo-physical space for e.g. initial page tables, console, etc? Why
not do the same for
@@ -528,7 +532,7 @@ ENTRY(_stext)
/*
* BSS section
*/
-.section .bss.page_aligned,w
+.section .bss.page_aligned
Why?
I got complaints about section attribute mismatches without it.
Then perhaps ... aw is meant?
+fastcall unsigned long long xen_pgd_val(pgd_t pgd)
+{
+
updated if possible.
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
--- linux-2.6.20/drivers/pci/probe.c2007-02-04 19:44:54.0 +0100
+++ 2.6.20-pci-ide-legacy/drivers/pci/probe.c 2007-02-14 15:54:58.0
+0100
@@ -639,7 +639,29 @@ static void pci_read_irq(struct pci_dev
Alan [EMAIL PROTECTED] 14.02.07 16:40
On Wed, 14 Feb 2007 15:05:24 +
Jan Beulich [EMAIL PROTECTED] wrote:
The change to force legacy mode IDE channels' resources to fixed
non-zero values confuses (at least some versions of) X, because the
values reported by the kernel and those readable
Jeff Dike [EMAIL PROTECTED] 14.02.07 18:51
On Tue, Feb 13, 2007 at 07:52:54AM +, Jan Beulich wrote:
Actually, after a second round of thinking I believe there's still more to do
- your second patch missed fixing i386's do_trap() similarly to x86-64's
and, vice versa, x86-64's
updated if possible.
(The only change to the original version is an added comment.)
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
--- linux-2.6.20/drivers/pci/probe.c2007-02-04 19:44:54.0 +0100
+++ 2.6.20-pci-ide-legacy/drivers/pci/probe.c 2007-02-15 08:54:58.0
+0100
Jeremy,
is there a particular reason for this?
Thanks, Jan
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
-off-by: Jan Beulich [EMAIL PROTECTED]
--- linux-2.6.20/arch/i386/mm/fault.c 2007-02-04 19:44:54.0 +0100
+++ 2.6.20-i386-page-fault-dump/arch/i386/mm/fault.c2007-02-14
08:31:38.0 +0100
@@ -20,6 +20,7 @@
#include linux/tty.h
#include linux/vt_kern.h
Greg KH [EMAIL PROTECTED] 25.03.07 18:11
On Sun, Mar 25, 2007 at 08:23:23AM -0700, Kevin P. Fleming wrote:
I just upgraded from 2.6.20.2 to 2.6.20.4 on my Compaq V6000 laptop,
which has an NVidia core chipset. It has the MCP51 and uses it for PATA
and SATA.
Booting the 2.6.20.4 kernel
that both mappings (kernel image and 1:1 mapping) get updated here.
(Not sure what the symbol 'stext' is good for; can it be removed?)
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
--- linux-2.6.21-rc5/arch/i386/kernel/vmlinux.lds.S 2007-03-26
15:20:02.0 +0200
+++ 2.6.21-rc5-x86-init-page
Based on replies to a respective query, remove the pci_dac_dma_...() APIs
(except for pci_dac_dma_supported() on Alpha, where this function is used
in non-DAC PCI DMA code).
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
Cc: Andi Kleen [EMAIL PROTECTED]
Cc: Jesse Barnes [EMAIL PROTECTED]
Cc
Chuck Ebbert [EMAIL PROTECTED] 18.02.07 22:33
Jan Beulich wrote:
Whether a region is below 1Mb is determined by its start rather than
its end.
This hunk got erroneously dropped from a previous patch.
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
--- linux-2.6.20/arch/i386/kernel/cpu
A change early last year reordered struct page so that ptl overlaps not only
private, but also mapping. Since spinlock_t can be much larger, I'm wondering
whether there's a reason to not also overlay the space index and lru take -
are these used for anything on page table pages?
Thanks, Jan
-
To
Ingo just raised this as an issue for paravirt_ops as well. I don't
quite follow what's going on there. My understanding is that there are
some old versions of glibc (which were unreleased CVS snapshots shipped
by some vendors) which don't use the vdso's ELF header, but instead have
their own
Andi Kleen [EMAIL PROTECTED] 28.03.07 21:07
+#ifdef CONFIG_HOTPLUG_CPU
+/* It must still be possible to apply SMP alternatives. */
+if (num_possible_cpus() = 1)
It would be better to temporarily change the pages where the alternatives
are applied while that is done and keep it
Under CONFIG_DISCONTIGMEM, assuming that a !pfn_valid() implies all
subsequent pfn-s are also invalid is wrong. Thus replace this by
explicitly checking against the E820 map.
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
Acked-by: Mark Langsdorf [EMAIL PROTECTED]
--- linux-2.6.21-rc5/arch/i386
.
Once at it, also eliminate false dependencies due to use of
...CONFIG_... identifiers.
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
--- linux-2.6.21-rc5/scripts/basic/fixdep.c 2007-02-04 19:44:54.0
+0100
+++ 2.6.21-rc5-fixdep-mod/scripts/basic/fixdep.c2007-03-29
11:11
it be removed?)
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
--- linux-2.6.21-rc5-ff/arch/i386/kernel/vmlinux.lds.S 2007-03-29
13:35:48.0 +0200
+++ 2.6.21-rc5-ff-x86-init-page-attribs/arch/i386/kernel/vmlinux.lds.S
2007-03-21 12:29:00.0 +0100
@@ -61,8 +61,6 @@ SECTIONS
Andi Kleen [EMAIL PROTECTED] 29.03.07 14:22
On Thursday 29 March 2007 14:01, Jan Beulich wrote:
On x86-64, kernel memory freed after init can be entirely unmapped instead
of just getting 'poisoned' by overwriting with a debug pattern.
On i386 and x86-64 (under CONFIG_DEBUG_RODATA), kernel
Randy Dunlap [EMAIL PROTECTED] 29.03.07 17:39
--- linux-2.6.21-rc5/scripts/basic/fixdep.c 2007-02-04 19:44:54.0
+0100
+++ 2.6.21-rc5-fixdep-mod/scripts/basic/fixdep.c 2007-03-29
11:11:10.0 +0200
@@ -29,8 +29,7 @@
* option which is mentioned in any of the listed
Randy Dunlap [EMAIL PROTECTED] 29.03.07 18:38
On Thu, 29 Mar 2007 17:06:24 +0100 Jan Beulich wrote:
Randy Dunlap [EMAIL PROTECTED] 29.03.07 17:39
--- linux-2.6.21-rc5/scripts/basic/fixdep.c 2007-02-04
19:44:54.0 +0100
+++ 2.6.21-rc5-fixdep-mod/scripts/basic/fixdep.c
Sam Ravnborg [EMAIL PROTECTED] 30.03.07 17:08
On Thu, Mar 29, 2007 at 10:27:14AM +0100, Jan Beulich wrote:
Commit 2e3646e51b2d6415549b310655df63e7e0d7a080 changed the way
the split config tree is built, but failed to also adjust fixdep
accordingly - if changing a config option from or to m
[c020c23e] __put_user_4+0x12/0x18
DWARF2 unwinder stuck at __put_user_4+0x12/0x18
Leftover inexact backtrace:
[c01040d6] ret_from_fork+0x6/0x1c
Hmpf. I saw it once in child_rip here too. Then I wanted to reproduce it to
report
properly and couldn't again. I had a few other backtraces that
mappings don't exist, the same change is done there, too, both for
consistency and because checking pte_present() before using various other
pte_XXX functions is a requirement anyway. At once, i386 code gets
adjusted to use pte_huge() instead of open coding this.
Signed-off-by: Jan Beulich [EMAIL
a redundant
conditional.
In ali-agp, add missing calls to global_flush_tlb().
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
--- linux-2.6.21-rc5/drivers/char/agp/ali-agp.c 2007-03-26 15:20:14.0
+0200
+++ 2.6.21-rc5-agp/drivers/char/agp/ali-agp.c 2007-03-30 13:33:03.0
+0200
Looking at both the i386 and x86-64 implementations I fail to understand why
there is an explicit requirement on calling global_flush_tlb() after
change_page_attr(), yet actual TLB flushing will not normally happen (on i386
it will happen if the CPU doesn't support clflush, but if it does, or on
+static __cpuinit void reloc_dyn(Elf32_Ehdr *ehdr, unsigned offset)
+{
+ Elf32_Dyn *dyn = (void *)ehdr + offset;
+
+ for(; dyn-d_tag != DT_NULL; dyn++)
+ switch(dyn-d_tag) {
+ case DT_PLTGOT:
+ case DT_HASH:
+ case DT_STRTAB:
+
Jeremy Fitzhardinge [EMAIL PROTECTED] 05.04.07 09:31
Jan Beulich wrote:
While there's a certain level of control on what DT_* may appear in the
vDSO, not even considering other than the above types seems fragile to
me. Since future additions to the set are supposedly following a fixed
scheme
+ for(; dyn-d_tag != DT_NULL; dyn++)
+ switch(dyn-d_tag) {
+ case DT_PLTGOT:
+ case DT_HASH:
+ case DT_STRTAB:
+ case DT_SYMTAB:
+ case DT_RELA:
+ case DT_INIT:
+ case DT_FINI:
+
Andi Kleen [EMAIL PROTECTED] 05.04.07 14:43
On Thursday 05 April 2007 11:32:49 Jan Beulich wrote:
Looking at both the i386 and x86-64 implementations I fail to understand why
there is an explicit requirement on calling global_flush_tlb() after
change_page_attr(), yet actual TLB flushing
Andrew Morton [EMAIL PROTECTED] 25.12.07 23:05
On Sun, 23 Dec 2007 12:26:21 + Christoph Hellwig [EMAIL PROTECTED] wrote:
On Thu, Dec 20, 2007 at 01:11:24PM +, Jan Beulich wrote:
With more and more sub-systems/sub-components leaving their footprint
in task handling functions
That change has been in the mainline tree for nearly three months. All
these affected parties have left it until the eve of 2.6.24 to actually
tell us about it. This is causing me sympathy problems :(
Not true - I complained about this on Dec 3rd (attached), with the result of
not getting a
That's somewhat ugly, as it will need to be undone/modified for Dom0 and
physical device access support. Jan
Jeremy Fitzhardinge [EMAIL PROTECTED] 08.01.08 23:00
The hypervisor doesn't allow PCD or PWT to be set on guest ptes, so
make sure they're masked out. Also, fix up some previous
The problem is a BUG() in pageattr_64.c:change_page_attr(), which to
me looks spurious. It arises because __PAGE_KERNEL_* doesn't contain
_PAGE_GLOBAL, but PAGE_KERNEL_* does. When ioremap()
change_page_attr(), it does so in a way that guarentees that the test
if (pgprot_val(prot) !=
+BLOCKING_NOTIFIER_HEAD(task_notifier_list);
+EXPORT_SYMBOL_GPL(task_notifier_list);
+ATOMIC_NOTIFIER_HEAD(atomic_task_notifier_list);
+EXPORT_SYMBOL_GPL(atomic_task_notifier_list);
+
When these global notifier lists were proposed years ago folks at SGI
loudly objected with concerns over
Am I to conclude then that there's no point in addressing the issues other
people pointed out? While I (obviously, since I submitted the patch
disagree),
I'm not certain how others feel. My main point for disagreement here is (I'm
sorry to repeat this) that as long as certain code isn't
No-one else is using these afaics.
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
---
include/linux/module.h | 17 -
kernel/module.c| 16 +++-
2 files changed, 15 insertions(+), 18 deletions(-)
--- linux-2.6.24-rc7/include/linux/module.h 2008-01-10 16
When the newer export flavors were added, it was apparently forgotten
to add respective code here.
In order to not double the (source) size of the function, add some
abstraction to reduce code duplication.
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
---
kernel/module.c | 37
Short of getting a reply on the query why the argument of fls() here is
missing the decrement, here's a patch to add it (reducing the resulting
size when the incoming size is an exact power of two).
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
Cc: James Bottomley [EMAIL PROTECTED]
---
mm
Remove the dead .text.lock. Move _etext and __{start,stop}___ex_table
into their sections.
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
---
arch/x86/kernel/vmlinux_64.lds.S | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
--- linux-2.6.24-rc7/arch/x86/kernel/vmlinux_64
2. I noticed the _PAGE_PCD|_PAGE_PWT combination being used a lot, so
I created _PAGE_NOCACHE to wrap them up. asm-x86/fb.h uses plain
_PAGE_PCD; should it be _PAGE_NOCACHE too?
Setting PCD but not PWT (or the other way around) is yielding not fully
defined behavior (model specific) as per the
' could have been
added as a result of the base structure changes, only where either the
change has a real effect (the module loader doesn't enforce read-only
section attributes at present, so only built-in files matter) or where
compiler warnings would result otherwise.
Signed-off-by: Jan Beulich
as a result of the base structure changes, only where the
change has a real effect (the module loader doesn't enforce read-only
section attributes at present, so only built-in files matter).
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
Cc: Tony Luck [EMAIL PROTECTED]
Cc: Ingo Molnar [EMAIL PROTECTED
attributes at present, so only built-in files matter)
or where compiler warnings would result otherwise.
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
Cc: Tony Luck [EMAIL PROTECTED]
Cc: Ingo Molnar [EMAIL PROTECTED]
Cc: Jens Axboe [EMAIL PROTECTED]
Cc: Greg Kroah-Hartman [EMAIL PROTECTED
consumer.
Patch 2 adds a number of x86 consumers of __cpuinitconst.
Patch 3 introduces __devinitconst and common code consumers.
Patch 4 adds a number of x86 consumers of __devinitconst.
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
--
To unsubscribe from this list: send the line unsubscribe
-by: Jan Beulich [EMAIL PROTECTED]
Cc: Len Brown [EMAIL PROTECTED]
Cc: Andi Kleen [EMAIL PROTECTED]
---
drivers/acpi/processor_idle.c |2 +-
include/linux/init.h |2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
--- 2.6.24-rc7-initconst.orig/drivers/acpi/processor_idle.c
-off-by: Jan Beulich [EMAIL PROTECTED]
Cc: Ingo Molnar [EMAIL PROTECTED]
---
arch/x86/kernel/cpu/amd.c |2 +-
arch/x86/kernel/cpu/centaur.c |2 +-
arch/x86/kernel/cpu/common.c | 14 +++---
arch/x86/kernel/cpu/cpu.h |8
arch
in an almost global fashion,
although drivers/ide/pci/ seems to be the most significant violator.
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
Cc: Greg Kroah-Hartman [EMAIL PROTECTED]
---
drivers/i2c/busses/i2c-piix4.c |4 ++--
drivers/ide/pci/piix.c |2 +-
drivers/video/aty
-off-by: Jan Beulich [EMAIL PROTECTED]
Cc: Ingo Molnar [EMAIL PROTECTED]
---
arch/x86/pci/acpi.c |2 +-
arch/x86/pci/common.c |2 +-
arch/x86/pci/fixup.c |4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
--- 2.6.24-rc7-initconst.orig/arch/x86/pci/acpi.c
+++ 2.6.24-rc7
ignore it and use the [faster] built-in.)
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
---
scripts/mkmakefile | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
--- linux-2.6.24-rc7/scripts/mkmakefile 2008-01-10 16:55:30.0 +0100
+++ 2.6.24-rc7-mkmakefile-objdir/scripts
the table, which would result in this code
possibly, but unintentionally screwing up other symbol names.
Besides that, the presented alternative is both smaller and faster.
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
---
arch/powerpc/kernel/module_64.c | 10 --
1 file changed, 4 insertions
.. allowing it to be write-protected just as other read-only data
under CONFIG_DEBUG_RODATA.
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
Cc: Linus Torvalds [EMAIL PROTECTED]
Cc: Ingo Molnar [EMAIL PROTECTED]
---
arch/x86/kernel/vmlinux_32.lds.S |7 ---
arch/x86/kernel/vmlinux_64.lds.S
interface expects the LDT address to be
virtual, not machine.
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
Cc: Ingo Molnar [EMAIL PROTECTED]
---
arch/x86/kernel/ldt_32.c |7 +++
arch/x86/kernel/ldt_64.c |7 +++
arch/x86/xen/enlighten.c |9 +
3 files changed, 7 insertions
--- linux-2.6.24-rc7/arch/x86/kernel/ldt_32.c2008-01-10
16:53:54.0 +0100
+++ 2.6.24-rc7-x86-xen-ldt/arch/x86/kernel/ldt_32.c 2008-01-09
13:59:50.0 +0100
[...]
@@ -73,7 +72,7 @@ static int alloc_ldt(mm_context_t *pc, u
if (oldsize*LDT_ENTRY_SIZE
Jeremy Fitzhardinge [EMAIL PROTECTED] 11.01.08 18:28
Jan Beulich wrote:
Don't rely on kmalloc(PAGE_SIZE) returning PAGE_SIZE aligned memory
(Xen requires GDT *and* LDT to be page-aligned).
Can kmalloc return non-page-aligned PAGE_SIZE allocations?
Documentation says it's to return pointer
--- 2.6.24-rc7-initconst.orig/include/linux/init.h
+++ 2.6.24-rc7-initconst/include/linux/init.h
@@ -269,11 +269,13 @@ void __init parse_early_param(void);
#ifdef CONFIG_HOTPLUG_CPU
#define __cpuinit
#define __cpuinitdata
+#define __cpuinitconst const
#define __cpuexit
#define
Sam Ravnborg [EMAIL PROTECTED] 13.01.08 22:42
And I found another small buglet too. I hope to post a complete
solution later today.
The modpost bits turned out to take longer than expected so
they are not done yet. The problem was the modpost structure
were not prepared for adding such
The one thing that I'm not sure is really consistent yet wrt. the
constification is that now you need to write e.g.
static const char __cpuinitcdata example[];
and (accidentally) omitting the 'const' (as it's really an apparently
redundant thing now) as in
static char __cpuinitcdata
Ingo Molnar [EMAIL PROTECTED] 14.01.08 16:48
* Jan Beulich [EMAIL PROTECTED] wrote:
Don't rely on kmalloc(PAGE_SIZE) returning PAGE_SIZE aligned memory
(Xen requires GDT *and* LDT to be page-aligned). Using the page
allocator interface also removes the (albeit small) slab allocator
+static unsigned short pat_bit[5] = {
Could be const and perhaps even local to cache_attr_changed()...
Jan
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
- /* clflush is still broken. Disable for now. */
- if (1 || !cpu_has_clflush)
+ if (a-full_flush)
asm volatile(wbinvd ::: memory);
- else list_for_each_entry(pg, l, lru) {
- void *adr = page_address(pg);
- clflush_cache_range(adr,
+ ref_prot = canon_pgprot(ref_prot);
+ prot = canon_pgprot(prot);
+
if (pgprot_val(prot) != pgprot_val(ref_prot)) {
...
} else if (level == 4) {
...
} else {
/*
* When you're here you either set the same page to PAGE_KERNEL
Doesn't
type (namely relevant for .rodata if it exceeds 2/4 Mb), allowing
to use a large page mapping in this case even for non-default mappings.
Apart from the other comments, the whole series
Acked-by: Jan Beulich [EMAIL PROTECTED]
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
Roman Zippel [EMAIL PROTECTED] 16.09.07 19:29
On Mon, 10 Sep 2007, Jan Beulich wrote:
--- linux-2.6.23-rc5/scripts/kconfig/menu.c 2007-09-07 16:48:23.0
+0200
+++ 2.6.23-rc5-tristate-choices/scripts/kconfig/menu.c 2007-09-03
10:29:41.0 +0200
@@ -235,16 +235,23
Andrew Morton [EMAIL PROTECTED] 16.09.07 12:18
On Mon, 10 Sep 2007 14:02:17 +0100 Jan Beulich [EMAIL PROTECTED] wrote:
.. as they're never written to.
arch/i386/kernel/traps.c: In function 'dump_trace':
arch/i386/kernel/traps.c:197: warning: initialization discards qualifiers from
pointer
-off-by: Jan Beulich [EMAIL PROTECTED]
arch/i386/mm/pgtable.c |3 +--
1 files changed, 1 insertion(+), 2 deletions(-)
--- linux-2.6.23-rc6/arch/i386/mm/pgtable.c 2007-09-14 17:38:47.0
+0200
+++ 2.6.23-rc6-i386-set-fixmap/arch/i386/mm/pgtable.c 2007-09-19
10:49:53.0 +0200
It doesn't seem to make sense to hide these, even if their counts
can't change at the point in time they're being displayed.
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
arch/i386/kernel/irq.c | 18 ++
arch/x86_64/kernel/irq.c | 18 ++
2 files changed, 28
, in the ideal
case allow just all the -Wa,* options to pass through.
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
---
Makefile| 15 ++--
scripts/Makefile.build | 51 +++-
scripts/Makefile.modinst|2 -
scripts/genksyms
tested with.
The patch also does away with the need to special case the kallsyms-
internal symbols by making them available even in the first linking
stage.
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
---
Makefile | 44 +---
init/Kconfig
Andi Kleen [EMAIL PROTECTED] 19.09.07 18:09
On Wednesday 19 September 2007 16:39:39 Jan Beulich wrote:
One more of these issues (which were considered fixed a few releases
back): Other than on x86-64, i386 allows set_fixmap() to replace
already present mappings. Consequently, on PAE, care
Ingo Molnar [EMAIL PROTECTED] 17.12.07 14:26
* Jan Beulich [EMAIL PROTECTED] wrote:
This generally allows better code to be generated, since the zero-
extension during 32-bit operations comes for free (needed when the
result is used as array index or similar), whereas sign extension must
Ingo Molnar [EMAIL PROTECTED] 17.12.07 14:28
* Jan Beulich [EMAIL PROTECTED] wrote:
When either calling change_page_attr() with the default attributes
pages in the direct mapping have and a page's attributes already were
set to the default or when changing the attributes from one
non
Ingo Molnar [EMAIL PROTECTED] 17.12.07 14:42
* Jan Beulich [EMAIL PROTECTED] wrote:
The patch introducing this left out x86-64, despite it also having
extra entries.
thanks, applied. Is there any 2.6.24 urgency for this?
While I haven't seen x86-64 to break due to this (it appears that 32
creation
and deletion.
Patch 2 switches delayacct to make use of the notifier.
Patch 3 makes the procevents/connector use the infrastructure and adds
additional notifiers needed there.
Patch 4 makes the security keys handling use this, too.
Signed-off-by: Jan Beulich [EMAIL PROTECTED
This is the base patch, adding notification for task creation and
deletion.
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
---
include/linux/sched.h |8 +++-
kernel/fork.c | 11 +++
2 files changed, 18 insertions(+), 1 deletion(-)
--- 2.6.24-rc5-notify-task.orig/include
This has the additional benefit of allowing the code to now be built
as a module (which made it necessary to add MODULE_xxx declarations).
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
Cc: Matt Helsley [EMAIL PROTECTED]
---
drivers/connector/Kconfig |5 +--
drivers/connector/cn_proc.c
Signed-off-by: Jan Beulich [EMAIL PROTECTED]
Cc: David Howells [EMAIL PROTECTED]
---
arch/mips/kernel/kspd.c |7 +++--
include/linux/key.h |4 ---
kernel/sys.c |8 --
security/keys/process_keys.c | 55 ++-
4
Yes, but why export variables? Wouldn't it be better to export
an API?
That simplifies the callers (they all pass current as task
and task_notifier_list as arguments).
It also prevents exposing internal variables (notifier lists
ARE internal variables) to modules.
What do you think?
Would
Thanks for catching this!
Dave Jones [EMAIL PROTECTED] 21.12.07 03:30
On Thu, Dec 20, 2007 at 04:14:05PM -0700, Eric W. Biederman wrote:
Remains the question whether it is intended that many, perhaps even
large, tables are compiled in without ever having a chance to get used,
i.e.
Eric W. Biederman [EMAIL PROTECTED] 21.12.07 00:05
Jan Beulich [EMAIL PROTECTED] writes:
Remains the question whether it is intended that many, perhaps even
large, tables are compiled in without ever having a chance to get used,
i.e. whether there shouldn't #ifdef CONFIG_xxx get added
Remains the question whether it is intended that many, perhaps even
large, tables are compiled in without ever having a chance to get used,
i.e. whether there shouldn't #ifdef CONFIG_xxx get added.
(Cut-n-paste mistake corrected, pointed out by Dave Jones.)
Signed-off-by: Jan Beulich [EMAIL
1 - 100 of 2685 matches
Mail list logo
