Re: [PATCH rebased] kbuild: rpm-pkg: Fix build with non-default MODLIB

2023-11-10 Thread Jan Engelhardt
On Friday 2023-11-10 18:44, Michal Suchánek wrote: >> It's a complicated mumble-jumble. Prior art exists as in: >> >> /opt/vendorThing/bin/... >> /usr/X11R6/lib/libXi.so.6 [host binary] >> /usr/x86_64-w64-mingw32/bin/as [host binary] >> /usr/x86_64-w64-mingw32/sys-root/mingw/bin/as.exe

Re: [PATCH kmod v5 5/5] libkmod, depmod, modprobe: Make directory for kernel modules configurable

2023-10-17 Thread Jan Engelhardt
On Tuesday 2023-10-17 19:50, Lucas De Marchi wrote: >> +AC_ARG_WITH([module_directory], >> +AS_HELP_STRING([--with-module-directory=DIR], [directory in which to >> look for kernel modules - typically '/lib/modules' or >> '${prefix}/lib/modules']), >> +[],

Re: [PATCH rebased] kbuild: rpm-pkg: Fix build with non-default MODLIB

2023-10-17 Thread Jan Engelhardt
On Tuesday 2023-10-17 17:10, Michal Suchánek wrote: > >> In my system (Ubuntu), I see the directory paths >> >> /usr/aarch64-linux-gnu/lib/ >> /usr/i686-linux-gnu/lib/ >> /usr/x86_64-linux-gnu/lib/ >> >> If there were such a crazy distro that supports multiple kernel arches >> within a single

Re: [PATCH rebased] kbuild: rpm-pkg: Fix build with non-default MODLIB

2023-10-09 Thread Jan Engelhardt
On Monday 2023-10-09 17:14, Masahiro Yamada wrote: > >Let me add more context to my question. > >I am interested in the timing when >'pkg-config --print-variables kmod | grep module_directory' >is executed. > >1. Build a SRPM on machine A >2. Copy the SRPM from machine A to machine B >3. Run

Re: k10temp: ZEN3 readings are broken

2020-12-23 Thread Jan Engelhardt
On Tuesday 2020-12-22 04:58, Guenter Roeck wrote: >On 12/21/20 5:45 PM, Gabriel C wrote: >> Hello Guenter, >> >> while trying to add ZEN3 support for zenpower out of tree modules, I find out >> the in-kernel k10temp driver is broken with ZEN3 ( and partially ZEN2 even ). > >[...] since I do not

Re: [PATCH v1 01/13] sparc32: Drop sun4m/sun4d support from head_32.S

2020-12-18 Thread Jan Engelhardt
On Friday 2020-12-18 19:43, Sam Ravnborg wrote: > notsup: >- .asciz "Sparc-Linux sun4/sun4c or MMU-less not supported\n\n" >- .align 4 >- >-sun4e_notsup: >-.asciz "Sparc-Linux sun4e support does not exist\n\n" >+ .asciz "Sparc-Linux sun4* or MMU-less not supported\n\n"

Re: remaining flexible-array conversions

2020-10-08 Thread Jan Engelhardt
On Friday 2020-04-24 14:15, Jason Gunthorpe wrote: >> ./usr/include/rdma/ib_user_verbs.h:436:34: warning: field 'base' with >> variable sized type 'struct ib_uverbs_create_cq_resp' not at the end of >> a struct or class is a GNU extension >> [-Wgnu-variable-sized-type-not-at-end] >>

Re: [PATCH 04/26] net: add a new sockptr_t type

2020-07-23 Thread Jan Engelhardt
On Thursday 2020-07-23 08:08, Christoph Hellwig wrote: >+typedef struct { >+ union { >+ void*kernel; >+ void __user *user; >+ }; >+ boolis_kernel : 1; >+} sockptr_t; >+ >+static inline bool sockptr_is_null(sockptr_t sockptr)

Re: Good idea to rename files in include/uapi/ ?

2020-06-22 Thread Jan Engelhardt
On Monday 2020-06-15 01:34, Alexander A. Klimov wrote: >> >> A header file rename is no problem. We even have dummy headers > Hmm.. if I understand all of you correctly, David, Stefano, Pablo and Al say > like no, not a good idea, but only you, Jan, say like should be no problem. > > Jan, do

Re: [PATCH] linux++, this: rename "struct notifier_block *this"

2020-06-19 Thread Jan Engelhardt
On Friday 2020-06-19 09:46, Christoph Hellwig wrote: >On Fri, Jun 19, 2020 at 12:06:45AM +0300, Alexey Dobriyan wrote: >> Rename >> struct notifier_block *this >> to >> struct notifier_block *nb >> >> "nb" is arguably a better name for notifier block. > >But not enough better to cause

Re: Good idea to rename files in include/uapi/ ?

2020-06-14 Thread Jan Engelhardt
On Sunday 2020-06-14 22:19, David Howells wrote: >Alexander A. Klimov wrote: > >> *Is it a good idea to rename files in include/uapi/ ?* > >Very likely not. If programs out there are going to be built on a >case-sensitive filesystem (which happens all the time), they're going to break >if you

Re: [RFC PATCH 0/4] DirectX on Linux

2020-05-20 Thread Jan Engelhardt
On Tuesday 2020-05-19 22:36, Sasha Levin wrote: > >> - Why DX12 on linux? Looking at this feels like classic divide and > > There is a single usecase for this: WSL2 developer who wants to run > machine learning on his GPU. The developer is working on his laptop, > which is running Windows and

Re: [PATCH] netfilter: fix make target xt_TCPMSS.o error.

2020-05-06 Thread Jan Engelhardt
On Wednesday 2020-05-06 08:50, Huang Qijun wrote: >When compiling netfilter, there will be an error >"No rule to make target 'net/netfilter/xt_TCPMSS.o'", >because the xt_TCPMSS.c in the makefile is uppercase, >and the file name of the source file (xt_tcpmss.c) is lowercase.

Re: [PATCH v9 00/13] arch/resctrl: AMD QoS support

2018-12-23 Thread Jan Engelhardt
On Nov 21 2018 20:28:23, Moger, Babu wrote: > >This series adds support for AMD64 architectural extensions for >Platform Quality of Service. The term "QoS" is already used for net/sched/. It will be bad naming to have QoS - and then an AMD QoS / Platform QoS as well. Preexisting, decade-old

Re: [PATCH 04/11] UAPI: bcache: Fix use of embedded flexible array

2018-10-09 Thread Jan Engelhardt
On Tuesday 2018-10-09 17:41, David Howells wrote: >Jan Engelhardt wrote: > >> """it [the array size expression] shall be a converted constant expression of >> type std::size_t and its value shall be greater than zero.""" >> —http://eel.is/c

Re: [PATCH 04/11] UAPI: bcache: Fix use of embedded flexible array

2018-10-09 Thread Jan Engelhardt
On Tuesday 2018-10-09 17:41, David Howells wrote: >Jan Engelhardt wrote: > >> """it [the array size expression] shall be a converted constant expression of >> type std::size_t and its value shall be greater than zero.""" >> —http://eel.is/c

Re: [PATCH 04/11] UAPI: bcache: Fix use of embedded flexible array

2018-10-02 Thread Jan Engelhardt
On Wed, 05 Sep 2018 16:55:03 +0100, David Howells wrote: > >The bkey struct defined by bcache is embedded in the jset struct. However, >this is illegal in C++ as there's a "flexible array" at the end of the struct. >Change this to be a 0-length struct instead. > >- __u64 ptr[]; >+

Re: [PATCH 04/11] UAPI: bcache: Fix use of embedded flexible array

2018-10-02 Thread Jan Engelhardt
On Wed, 05 Sep 2018 16:55:03 +0100, David Howells wrote: > >The bkey struct defined by bcache is embedded in the jset struct. However, >this is illegal in C++ as there's a "flexible array" at the end of the struct. >Change this to be a 0-length struct instead. > >- __u64 ptr[]; >+

Re: [netfilter-core] kernel panic: Out of memory and no killable processes... (2)

2018-01-29 Thread Jan Engelhardt
On Monday 2018-01-29 17:57, Florian Westphal wrote: >> > > vmalloc() once became killable by commit 5d17a73a2ebeb8d1 ("vmalloc: back >> > > off when the current task is killed") but then became unkillable by >> > > commit >> > > b8c8a338f75e052d ("Revert "vmalloc: back off when the current task

Re: [netfilter-core] kernel panic: Out of memory and no killable processes... (2)

2018-01-29 Thread Jan Engelhardt
On Monday 2018-01-29 17:57, Florian Westphal wrote: >> > > vmalloc() once became killable by commit 5d17a73a2ebeb8d1 ("vmalloc: back >> > > off when the current task is killed") but then became unkillable by >> > > commit >> > > b8c8a338f75e052d ("Revert "vmalloc: back off when the current task

Re: [PATCH] net: netfilter: Replace explicit NULL comparisons

2017-04-09 Thread Jan Engelhardt
On Sunday 2017-04-09 05:42, Arushi Singhal wrote: >On Sun, Apr 9, 2017 at 1:44 AM, Pablo Neira Ayuso <pa...@netfilter.org> wrote: > On Sat, Apr 08, 2017 at 08:21:56PM +0200, Jan Engelhardt wrote: > > On Saturday 2017-04-08 19:21, Arushi Singhal wrote: > > &g

Re: [PATCH] net: netfilter: Replace explicit NULL comparisons

2017-04-09 Thread Jan Engelhardt
On Sunday 2017-04-09 05:42, Arushi Singhal wrote: >On Sun, Apr 9, 2017 at 1:44 AM, Pablo Neira Ayuso wrote: > On Sat, Apr 08, 2017 at 08:21:56PM +0200, Jan Engelhardt wrote: > > On Saturday 2017-04-08 19:21, Arushi Singhal wrote: > > > > >Repla

Re: [PATCH] net: netfilter: Replace explicit NULL comparisons

2017-04-08 Thread Jan Engelhardt
On Saturday 2017-04-08 19:21, Arushi Singhal wrote: >Replace explicit NULL comparison with ! operator to simplify code. I still wouldn't do this, for the same reason as before. Comparing to NULL explicitly more or less gave an extra guarantee that the other operand was also a pointer.

Re: [PATCH] net: netfilter: Replace explicit NULL comparisons

2017-04-08 Thread Jan Engelhardt
On Saturday 2017-04-08 19:21, Arushi Singhal wrote: >Replace explicit NULL comparison with ! operator to simplify code. I still wouldn't do this, for the same reason as before. Comparing to NULL explicitly more or less gave an extra guarantee that the other operand was also a pointer.

Re: [PATCH v2] netfilter: Clean up tests if NULL returned on failure

2017-03-29 Thread Jan Engelhardt
On Wednesday 2017-03-29 11:15, SIMRAN SINGHAL wrote: >> dest = kzalloc(sizeof(struct ip_vs_dest), GFP_KERNEL); >>- if (dest == NULL) >>+ if (!dest) >> return -ENOMEM; > >But, according to me we should prefer !var over ( var ==NULL ) according to the

Re: [PATCH v2] netfilter: Clean up tests if NULL returned on failure

2017-03-29 Thread Jan Engelhardt
On Wednesday 2017-03-29 11:15, SIMRAN SINGHAL wrote: >> dest = kzalloc(sizeof(struct ip_vs_dest), GFP_KERNEL); >>- if (dest == NULL) >>+ if (!dest) >> return -ENOMEM; > >But, according to me we should prefer !var over ( var ==NULL ) according to the

Re: [PATCH v2] netfilter: Clean up tests if NULL returned on failure

2017-03-29 Thread Jan Engelhardt
On Tuesday 2017-03-28 18:23, SIMRAN SINGHAL wrote: >On Tue, Mar 28, 2017 at 7:24 PM, Jan Engelhardt <jeng...@inai.de> wrote: >> On Tuesday 2017-03-28 15:13, simran singhal wrote: >> >>>Some functions like kmalloc/kzalloc return NULL on failure. When NULL >>>

Re: [PATCH v2] netfilter: Clean up tests if NULL returned on failure

2017-03-29 Thread Jan Engelhardt
On Tuesday 2017-03-28 18:23, SIMRAN SINGHAL wrote: >On Tue, Mar 28, 2017 at 7:24 PM, Jan Engelhardt wrote: >> On Tuesday 2017-03-28 15:13, simran singhal wrote: >> >>>Some functions like kmalloc/kzalloc return NULL on failure. When NULL >>>repres

Re: [PATCH v2] netfilter: Clean up tests if NULL returned on failure

2017-03-28 Thread Jan Engelhardt
On Tuesday 2017-03-28 15:13, simran singhal wrote: >Some functions like kmalloc/kzalloc return NULL on failure. When NULL >represents failure, !x is commonly used. > >@@ -910,7 +910,7 @@ ip_vs_new_dest(struct ip_vs_service *svc, struct >ip_vs_dest_user_kern *udest, > } > > dest =

Re: [PATCH] netfilter: ipset: Use max macro instead of ternary operator

2017-03-28 Thread Jan Engelhardt
On Tuesday 2017-03-28 15:32, simran singhal wrote: >This patch replaces ternary operator with macro max as it shorter and >thus increases code readability. > >- return (ret < 0 ? 0 : ret); >+ return max(0, ret); While the two are functionally equivalent, "max" conveys a meaning of

Re: [PATCH v2] netfilter: Clean up tests if NULL returned on failure

2017-03-28 Thread Jan Engelhardt
On Tuesday 2017-03-28 15:13, simran singhal wrote: >Some functions like kmalloc/kzalloc return NULL on failure. When NULL >represents failure, !x is commonly used. > >@@ -910,7 +910,7 @@ ip_vs_new_dest(struct ip_vs_service *svc, struct >ip_vs_dest_user_kern *udest, > } > > dest =

Re: [PATCH] netfilter: ipset: Use max macro instead of ternary operator

2017-03-28 Thread Jan Engelhardt
On Tuesday 2017-03-28 15:32, simran singhal wrote: >This patch replaces ternary operator with macro max as it shorter and >thus increases code readability. > >- return (ret < 0 ? 0 : ret); >+ return max(0, ret); While the two are functionally equivalent, "max" conveys a meaning of

Re: [PATCH] net: Remove unnecessary cast on void pointer

2017-03-28 Thread Jan Engelhardt
On Tuesday 2017-03-28 14:50, simran singhal wrote: >The following Coccinelle script was used to detect this: >@r@ >expression x; >void* e; >type T; >identifier f; >@@ >( > *((T *)e) >| > ((T *)x)[...] >| > ((T*)x)->f >| > >- (T*) > e >) > >Signed-off-by: simran singhal

Re: [PATCH] net: Remove unnecessary cast on void pointer

2017-03-28 Thread Jan Engelhardt
On Tuesday 2017-03-28 14:50, simran singhal wrote: >The following Coccinelle script was used to detect this: >@r@ >expression x; >void* e; >type T; >identifier f; >@@ >( > *((T *)e) >| > ((T *)x)[...] >| > ((T*)x)->f >| > >- (T*) > e >) > >Signed-off-by: simran singhal >--- >

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-23 Thread Jan Engelhardt
On Monday 2017-01-23 18:26, Borislav Petkov wrote: >On Mon, Jan 23, 2017 at 09:21:03AM -0800, Christoph Hellwig wrote: >> Or keep the exported version as-is and never changed it, and use >> a different copy for the kernel itself. > >I guess we'll have to do that if something in userspace has put

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-23 Thread Jan Engelhardt
On Monday 2017-01-23 18:26, Borislav Petkov wrote: >On Mon, Jan 23, 2017 at 09:21:03AM -0800, Christoph Hellwig wrote: >> Or keep the exported version as-is and never changed it, and use >> a different copy for the kernel itself. > >I guess we'll have to do that if something in userspace has put

Re: [PATCH v2 7/7] uapi: export all headers under uapi directories

2017-01-12 Thread Jan Engelhardt
On Thursday 2017-01-12 16:52, Nicolas Dichtel wrote: >Le 09/01/2017 à 13:56, Christoph Hellwig a écrit : >> On Fri, Jan 06, 2017 at 10:43:59AM +0100, Nicolas Dichtel wrote: >>> Regularly, when a new header is created in include/uapi/, the developer >>> forgets to add it in the corresponding

Re: [PATCH v2 7/7] uapi: export all headers under uapi directories

2017-01-12 Thread Jan Engelhardt
On Thursday 2017-01-12 16:52, Nicolas Dichtel wrote: >Le 09/01/2017 à 13:56, Christoph Hellwig a écrit : >> On Fri, Jan 06, 2017 at 10:43:59AM +0100, Nicolas Dichtel wrote: >>> Regularly, when a new header is created in include/uapi/, the developer >>> forgets to add it in the corresponding

Re: [PATCH 1116/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Jan Engelhardt
On Tuesday 2016-08-02 14:17, Baole Ni wrote: >I find that the developers often just specified the numeric value >when calling a macro which is defined with a parameter for access permission. >As we know, these numeric value for access permission have had the >corresponding macro, >and that

Re: [PATCH 1116/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Jan Engelhardt
On Tuesday 2016-08-02 14:17, Baole Ni wrote: >I find that the developers often just specified the numeric value >when calling a macro which is defined with a parameter for access permission. >As we know, these numeric value for access permission have had the >corresponding macro, >and that

RE: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match

2015-11-23 Thread Jan Engelhardt
On Monday 2015-11-23 18:35, David Laight wrote: >From: Florian Westphal >> Sent: 21 November 2015 16:56 >> > +struct xt_cgroup_info_v1 { >> > + charpath[PATH_MAX]; >> > + __u32 classid; >> > + >> > + /* kernel internal data */ >> > + void*priv

RE: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match

2015-11-23 Thread Jan Engelhardt
On Monday 2015-11-23 18:35, David Laight wrote: >From: Florian Westphal >> Sent: 21 November 2015 16:56 >> > +struct xt_cgroup_info_v1 { >> > + charpath[PATH_MAX]; >> > + __u32 classid; >> > + >> > + /* kernel internal data */ >> > + void*priv

Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match

2015-11-21 Thread Jan Engelhardt
On Saturday 2015-11-21 19:54, Florian Westphal wrote: > >The only other question I have is wheter PATH_MAX might be a possible >ABI breaker in future. It would have to be guaranteed that this is the >same size forever, else you'd get strange errors on rule insertion if >the sizes of the kernel

Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match

2015-11-21 Thread Jan Engelhardt
On Saturday 2015-11-21 19:54, Florian Westphal wrote: > >The only other question I have is wheter PATH_MAX might be a possible >ABI breaker in future. It would have to be guaranteed that this is the >same size forever, else you'd get strange errors on rule insertion if >the sizes of the kernel

Re: [PATCH iptables] libxt_cgroup2: add support for cgroup2 path matching

2015-11-17 Thread Jan Engelhardt
On Tuesday 2015-11-17 20:42, Tejun Heo wrote: >+static void cgroup2_save(const void *ip, const struct xt_entry_match *match) >+{ >+ const struct xt_cgroup2_info *info = (void *)match->data; >+ >+ printf("%s --path %s", info->invert ? " !" : "", info->path); >+} Can cgroup path names

Re: [PATCH 5/5] netfilter: implement xt_cgroup2 match

2015-11-17 Thread Jan Engelhardt
On Tuesday 2015-11-17 20:40, Tejun Heo wrote: >@@ -0,0 +1,14 @@ >+#ifndef _XT_CGROUP2_H >+#define _XT_CGROUP2_H >+ >+#include >+ >+struct xt_cgroup2_info { >+ charpath[PATH_MAX]; >+ __u8invert; Should be included? (For PATH_MAX)

Re: [PATCH 1/5] cgroup: record ancestor IDs and reimplement cgroup_is_descendant() using it

2015-11-17 Thread Jan Engelhardt
On Tuesday 2015-11-17 20:40, Tejun Heo wrote: >+static inline bool cgroup_is_descendant(struct cgroup *cgrp, >+ struct cgroup *ancestor) (const struct group *cgrp, const struct group *ancestor) >+{ >+ if (cgrp->root != ancestor->root || cgrp->level <

Re: [PATCH 2/5] kernfs: implement kernfs_walk_and_get()

2015-11-17 Thread Jan Engelhardt
On Tuesday 2015-11-17 22:20, David Miller wrote: >> +static char path_buf[PATH_MAX]; /* protected by kernfs_mutex */ >> +int len = strlen(path); > ... >> +if (len >= PATH_MAX) >> +return NULL; >> + >> +memcpy(path_buf, path, len + 1); > > static char

Re: [PATCH 2/5] kernfs: implement kernfs_walk_and_get()

2015-11-17 Thread Jan Engelhardt
On Tuesday 2015-11-17 22:20, David Miller wrote: >> +static char path_buf[PATH_MAX]; /* protected by kernfs_mutex */ >> +int len = strlen(path); > ... >> +if (len >= PATH_MAX) >> +return NULL; >> + >> +memcpy(path_buf, path, len + 1); > > static char

Re: [PATCH iptables] libxt_cgroup2: add support for cgroup2 path matching

2015-11-17 Thread Jan Engelhardt
On Tuesday 2015-11-17 20:42, Tejun Heo wrote: >+static void cgroup2_save(const void *ip, const struct xt_entry_match *match) >+{ >+ const struct xt_cgroup2_info *info = (void *)match->data; >+ >+ printf("%s --path %s", info->invert ? " !" : "", info->path); >+} Can cgroup path names

Re: [PATCH 5/5] netfilter: implement xt_cgroup2 match

2015-11-17 Thread Jan Engelhardt
On Tuesday 2015-11-17 20:40, Tejun Heo wrote: >@@ -0,0 +1,14 @@ >+#ifndef _XT_CGROUP2_H >+#define _XT_CGROUP2_H >+ >+#include >+ >+struct xt_cgroup2_info { >+ charpath[PATH_MAX]; >+ __u8invert; Should be included? (For PATH_MAX)

Re: [PATCH 1/5] cgroup: record ancestor IDs and reimplement cgroup_is_descendant() using it

2015-11-17 Thread Jan Engelhardt
On Tuesday 2015-11-17 20:40, Tejun Heo wrote: >+static inline bool cgroup_is_descendant(struct cgroup *cgrp, >+ struct cgroup *ancestor) (const struct group *cgrp, const struct group *ancestor) >+{ >+ if (cgrp->root != ancestor->root || cgrp->level <

Retain all bits of the exit(2) status value

2015-07-09 Thread Jan Engelhardt
I was made aware of a suggested change to POSIX's exit function. Current issue 7: http://pubs.opengroup.org/onlinepubs/9699919799/functions/exit.html Proposed change: http://austingroupbugs.net/view.php?id=594#c1317 In summary: from "the least significant 8 bits (that is, status & 0377)" to

Retain all bits of the exit(2) status value

2015-07-09 Thread Jan Engelhardt
I was made aware of a suggested change to POSIX's exit function. Current issue 7: http://pubs.opengroup.org/onlinepubs/9699919799/functions/exit.html Proposed change: http://austingroupbugs.net/view.php?id=594#c1317 In summary: from the least significant 8 bits (that is, status 0377) to the

Re: [RFC] kernel random segmentation fault?

2015-05-06 Thread Jan Engelhardt
On Wednesday 2015-05-06 05:46, long.wanglong wrote: > >int main(int argc, char** argv) >{ >rlim.rlim_cur=20 MB; >rlim.rlim_max=20 MB; >ret = setrlimit(RLIMIT_AS, ); >[...] >char tmp[20 MB]; >for (i = 0; i < 20 MB; i++) >tmp[i]=1; if tmp already takes 20 MB, where

Re: [RFC] kernel random segmentation fault?

2015-05-06 Thread Jan Engelhardt
On Wednesday 2015-05-06 05:46, long.wanglong wrote: int main(int argc, char** argv) { rlim.rlim_cur=20 MB; rlim.rlim_max=20 MB; ret = setrlimit(RLIMIT_AS, rlim); [...] char tmp[20 MB]; for (i = 0; i 20 MB; i++) tmp[i]=1; if tmp already takes 20 MB, where will

Re: NULL deref around blkmq in v4.0-rc1–rc7

2015-04-11 Thread Jan Engelhardt
On Saturday 2015-04-11 19:46, Linus Torvalds wrote: >On Thu, Apr 9, 2015 at 5:07 PM, Linus Torvalds > wrote: >> On Thu, Apr 9, 2015 at 3:29 PM, Jan Engelhardt wrote: >>> >>> Yes, this seems to solve it for me. >> >> Can you humor me, and try t

Re: NULL deref around blkmq in v4.0-rc1–rc7

2015-04-11 Thread Jan Engelhardt
On Saturday 2015-04-11 19:46, Linus Torvalds wrote: On Thu, Apr 9, 2015 at 5:07 PM, Linus Torvalds torva...@linux-foundation.org wrote: On Thu, Apr 9, 2015 at 3:29 PM, Jan Engelhardt jeng...@inai.de wrote: Yes, this seems to solve it for me. Can you humor me, and try that patch on top

Re: NULL deref around blkmq in v4.0-rc1–rc7

2015-04-09 Thread Jan Engelhardt
On Thursday 2015-04-09 19:38, Linus Torvalds wrote: >> >> I reran bisect just to be sure. >> It now shows v4.0-rc1~9 is bad, v4.0-rc1~9^1 is ok, and v4.0-rc~9^2 is >> ok too. So this means that the combination of the both ~9 childs work >> badly together. > >Ok, that's just _odd_. >[...] >So I

Re: NULL deref around blkmq in v4.0-rc1–rc7

2015-04-09 Thread Jan Engelhardt
On Thursday 2015-04-09 19:38, Linus Torvalds wrote: I reran bisect just to be sure. It now shows v4.0-rc1~9 is bad, v4.0-rc1~9^1 is ok, and v4.0-rc~9^2 is ok too. So this means that the combination of the both ~9 childs work badly together. Ok, that's just _odd_. [...] So I get the feeling

Re: NULL deref around xfs in v4.0-rc1–rc7

2015-04-08 Thread Jan Engelhardt
On Wednesday 2015-04-08 15:41, Jan Engelhardt wrote: >Starting somewhere around v4.0-rc1 and persisting through commit >v4.0-rc7, there is a new NULL deference apparently happening in >conjunction with xfs. This inhibits this machine's booting, >as xfs is used for the root filesyst

NULL deref around xfs in v4.0-rc1–rc7

2015-04-08 Thread Jan Engelhardt
Starting somewhere around v4.0-rc1 and persisting through commit v4.0-rc7, there is a new NULL deference apparently happening in conjunction with xfs. This inhibits this machine's booting, as xfs is used for the root filesystem. First bisection points at first-bad commit v4.0-rc1~8, and since

NULL deref around xfs in v4.0-rc1–rc7

2015-04-08 Thread Jan Engelhardt
Starting somewhere around v4.0-rc1 and persisting through commit v4.0-rc7, there is a new NULL deference apparently happening in conjunction with xfs. This inhibits this machine's booting, as xfs is used for the root filesystem. First bisection points at first-bad commit v4.0-rc1~8, and since

Re: NULL deref around xfs in v4.0-rc1–rc7

2015-04-08 Thread Jan Engelhardt
On Wednesday 2015-04-08 15:41, Jan Engelhardt wrote: Starting somewhere around v4.0-rc1 and persisting through commit v4.0-rc7, there is a new NULL deference apparently happening in conjunction with xfs. This inhibits this machine's booting, as xfs is used for the root filesystem. First

Re: [PATCH 43/45] include/uapi/linux/netfilter_bridge.h: include if.h

2015-02-16 Thread Jan Engelhardt
On Tuesday 2015-02-17 00:05, Mikko Rapeli wrote: >Fixes userspace compilation errors like: > >error: field ‘in’ has incomplete type >struct in_addr in; > >+#include Patch 36/45 included linux/in.h instead of linux/if.h for addressing "in has incomplete type". Should this be used here too? --

Re: [PATCH 43/45] include/uapi/linux/netfilter_bridge.h: include if.h

2015-02-16 Thread Jan Engelhardt
On Tuesday 2015-02-17 00:05, Mikko Rapeli wrote: Fixes userspace compilation errors like: error: field ‘in’ has incomplete type struct in_addr in; +#include linux/if.h Patch 36/45 included linux/in.h instead of linux/if.h for addressing in has incomplete type. Should this be used here too?

Re: [PATCH 2/3] x_tables: Use also dev->ifalias for interface matching

2015-01-12 Thread Jan Engelhardt
On Monday 2015-01-12 17:04, Eric Dumazet wrote: > >iptables should have used ifindex [for interface matching], >it[']s sad we allowed the substring match in first place. How would you solve interface name wildcards with ifindices? (They come in handy if you have something like lots of tun+/veth+

Re: [PATCH 2/3] x_tables: Use also dev-ifalias for interface matching

2015-01-12 Thread Jan Engelhardt
On Monday 2015-01-12 17:04, Eric Dumazet wrote: iptables should have used ifindex [for interface matching], it[']s sad we allowed the substring match in first place. How would you solve interface name wildcards with ifindices? (They come in handy if you have something like lots of tun+/veth+

Re: [PATCH 3/3] x_tables: Factor out 16bit aligment ifname_compare()

2015-01-11 Thread Jan Engelhardt
On Sunday 2015-01-11 22:30, Richard Weinberger wrote: Perhaps this would be better as bool ifname_compare > >Anyway, I agree with Linus wrt. bool. >https://lkml.org/lkml/2013/8/31/138 Had the function return "bool", it would have been obvious enough what to do with its return type. A return

Bug at 3.19-rc3:mm/rmap.c:399

2015-01-11 Thread Jan Engelhardt
Preliminary report that Linux kernel 3.19-rc3 [eb74926920cfa756087a82e0b081df837177cb95] gives a bug dump. When exiting JOSM (running on openjdk-1.7), the java process would sometimes get shot down. Last known good was v3.18.1. I probably need to turn on some debuginfo… unless you beat me to

Bug at 3.19-rc3:mm/rmap.c:399

2015-01-11 Thread Jan Engelhardt
Preliminary report that Linux kernel 3.19-rc3 [eb74926920cfa756087a82e0b081df837177cb95] gives a bug dump. When exiting JOSM (running on openjdk-1.7), the java process would sometimes get shot down. Last known good was v3.18.1. I probably need to turn on some debuginfo… unless you beat me to

Re: [PATCH 3/3] x_tables: Factor out 16bit aligment ifname_compare()

2015-01-11 Thread Jan Engelhardt
On Sunday 2015-01-11 22:30, Richard Weinberger wrote: Perhaps this would be better as bool ifname_compare Anyway, I agree with Linus wrt. bool. https://lkml.org/lkml/2013/8/31/138 Had the function return bool, it would have been obvious enough what to do with its return type. A return type of

Re: [RFC PATCH 1/1] module: Make wait module's refcount to zero procedure as async

2014-01-25 Thread Jan Engelhardt
On Monday 2013-09-16 05:47, Rusty Russell wrote: > >Here's what I've got in my pending-rebases tree. > >@@ -842,6 +818,11 @@ SYSCALL_DEFINE2(delete_module, const char __user *, >name_user, > return -EFAULT; > name[MODULE_NAME_LEN-1] = '\0'; > >+ if (!(flags &

Re: [RFC PATCH 1/1] module: Make wait module's refcount to zero procedure as async

2014-01-25 Thread Jan Engelhardt
On Monday 2013-09-16 05:47, Rusty Russell wrote: Here's what I've got in my pending-rebases tree. @@ -842,6 +818,11 @@ SYSCALL_DEFINE2(delete_module, const char __user *, name_user, return -EFAULT; name[MODULE_NAME_LEN-1] = '\0'; + if (!(flags O_NONBLOCK)) { +

Re: i915: pipe state still does not match

2013-11-30 Thread Jan Engelhardt
On Friday 2013-11-29 11:48, Chris Wilson wrote: >> What I could collect so far: > >Thanks, I broke the handling of cropped XvImages along the fast paths. >It should be fixed by: > >commit fd007d9d465b9b3ddbbaf769931ec921a6f5ecb8 >Author: Chris Wilson >Date: Thu Nov 28 21:13:33 2013 + > >

Re: i915: pipe state still does not match

2013-11-30 Thread Jan Engelhardt
On Friday 2013-11-29 11:48, Chris Wilson wrote: What I could collect so far: Thanks, I broke the handling of cropped XvImages along the fast paths. It should be fixed by: commit fd007d9d465b9b3ddbbaf769931ec921a6f5ecb8 Author: Chris Wilson ch...@chris-wilson.co.uk Date: Thu Nov 28 21:13:33

i915: pipe state still does not match

2013-11-27 Thread Jan Engelhardt
Greetings. Despite the i915/drm fixes added in v3.11.8, the X server still terminates due to some pipe state bug in 3.11.9. I have a fb setup to span two crtcs in below's configuration, and the kernel problem is easily triggerable for me by moving an Xv window (such as by using mplayer) forth

i915: pipe state still does not match

2013-11-27 Thread Jan Engelhardt
Greetings. Despite the i915/drm fixes added in v3.11.8, the X server still terminates due to some pipe state bug in 3.11.9. I have a fb setup to span two crtcs in below's configuration, and the kernel problem is easily triggerable for me by moving an Xv window (such as by using mplayer) forth

Re: Linux 3.12 released .. and 4.0 plans?

2013-11-04 Thread Jan Engelhardt
On Monday 2013-11-04 01:10, Linus Torvalds wrote: > >Onto a totally different topic: we're getting to release numbers where >I have to take off my socks to count that high again. I'm ok with >3. [...] [4.0 "ok, after 3.19 (or whatever),"] What would you do when the major number becomes such an

Re: Linux 3.12 released .. and 4.0 plans?

2013-11-04 Thread Jan Engelhardt
On Monday 2013-11-04 01:10, Linus Torvalds wrote: Onto a totally different topic: we're getting to release numbers where I have to take off my socks to count that high again. I'm ok with 3.low teens [...] [4.0 ok, after 3.19 (or whatever),] What would you do when the major number becomes such

Re: [PATCH 11/12] netfilter: Remove extern from function prototypes

2013-09-28 Thread Jan Engelhardt
On Monday 2013-09-23 20:37, Joe Perches wrote: >There are a mix of function prototypes with and without extern >in the kernel sources. Standardize on not using extern for >function prototypes. > >Function prototypes don't need to be written with extern. >extern is assumed by the compiler. Its

Re: [PATCH 11/12] netfilter: Remove extern from function prototypes

2013-09-28 Thread Jan Engelhardt
On Monday 2013-09-23 20:37, Joe Perches wrote: There are a mix of function prototypes with and without extern in the kernel sources. Standardize on not using extern for function prototypes. Function prototypes don't need to be written with extern. extern is assumed by the compiler. Its use is

Re: Introducing libgadget 0.0.1

2013-09-11 Thread Jan Engelhardt
On Wednesday 2013-09-04 19:25, Matt Porter wrote: >With the move to configfs for creation of arbitrary USB composite gadgets, >I found myself wanting a simple C library to configure and parse gadgets >in a system. It has no other dependencies other than libc itself. > >It can be found at: > >

Re: Introducing libgadget 0.0.1

2013-09-11 Thread Jan Engelhardt
On Wednesday 2013-09-04 19:25, Matt Porter wrote: With the move to configfs for creation of arbitrary USB composite gadgets, I found myself wanting a simple C library to configure and parse gadgets in a system. It has no other dependencies other than libc itself. It can be found at:

fixdep ought to be compiled with -D_FILE_OFFSET_BITS

2013-08-29 Thread Jan Engelhardt
Because fixdep is compiled without -D_FILE_OFFSET_BITS=64, a 32-bit fixdep (in a chroot build root, for example) may fail to run on a 64-bit host system if any file has an inode larger than 2^32, which can easily happen (in my case, on xfs):

fixdep ought to be compiled with -D_FILE_OFFSET_BITS

2013-08-29 Thread Jan Engelhardt
Because fixdep is compiled without -D_FILE_OFFSET_BITS=64, a 32-bit fixdep (in a chroot build root, for example) may fail to run on a 64-bit host system if any file has an inode larger than 2^32, which can easily happen (in my case, on xfs):

Potentially missing "else"

2013-08-07 Thread Jan Engelhardt
to e4523541e7f26457cf7078d5f30e091d1b24e3a9: depmod: add missing "else" clause (2013-08-07 23:50:51 +0200) -------- Jan Engelhardt (1): depmod: add missing "else" clause libkmod/libkmod-config.c | 2 +- tools/depmod.c | 2 +-

[PATCH] depmod: add missing "else" clause

2013-08-07 Thread Jan Engelhardt
It occurred to an openSUSE user that our mkinitrd would throw a warning when used with kmod: libkmod: conf_files_list: unsupported file mode /dev/null: 0x21b6 Grepping for the error message revealed that there might be a missing "else" keyword here, since it is unusual to put an "if" directly

Potentially missing else

2013-08-07 Thread Jan Engelhardt
to e4523541e7f26457cf7078d5f30e091d1b24e3a9: depmod: add missing else clause (2013-08-07 23:50:51 +0200) Jan Engelhardt (1): depmod: add missing else clause libkmod/libkmod-config.c | 2 +- tools/depmod.c | 2 +- 2 files changed, 2 insertions

[PATCH] depmod: add missing else clause

2013-08-07 Thread Jan Engelhardt
It occurred to an openSUSE user that our mkinitrd would throw a warning when used with kmod: libkmod: conf_files_list: unsupported file mode /dev/null: 0x21b6 Grepping for the error message revealed that there might be a missing else keyword here, since it is unusual to put an if directly after

Re: Read I/O starvation with writeback RAID controller

2013-02-22 Thread Jan Engelhardt
On Friday 2013-02-22 20:28, Martin Svec wrote: > > Yes, I've already tried the ROW scheduler. It helped for some low iodepths > depending on quantum settings but generally didn't solve the problem. I think > the key issue is that none of the schedulers can throttle I/O according to > e.g. >

Re: [Announce] Checkpoint-restore tool v0.4

2013-02-22 Thread Jan Engelhardt
On Wednesday 2013-02-20 12:18, Pavel Emelyanov wrote: > >As was planned, the v0.4 of C/R tools is out, right after the Linux v3.8. > >The most valuable thing in this release, is that all the kernel patches >we had are now merged, and thus what crtools-v0.4 can do will work on >the upstream kernel

Re: [Announce] Checkpoint-restore tool v0.4

2013-02-22 Thread Jan Engelhardt
On Wednesday 2013-02-20 12:18, Pavel Emelyanov wrote: As was planned, the v0.4 of C/R tools is out, right after the Linux v3.8. The most valuable thing in this release, is that all the kernel patches we had are now merged, and thus what crtools-v0.4 can do will work on the upstream kernel

Re: Read I/O starvation with writeback RAID controller

2013-02-22 Thread Jan Engelhardt
On Friday 2013-02-22 20:28, Martin Svec wrote: Yes, I've already tried the ROW scheduler. It helped for some low iodepths depending on quantum settings but generally didn't solve the problem. I think the key issue is that none of the schedulers can throttle I/O according to e.g. average

Re: kconfig-frontends-3.8.0.0 release

2013-02-19 Thread Jan Engelhardt
On Wednesday 2013-02-20 00:21, Yann E. MORIN wrote: >> This seems to install >> /usr/bin/diff[...] > >By default, the binaries should all ne prefixed with 'kconfig-' to avoid >such name-clashing (as root, in a fresh debootstrap of squeeze here): Aha. Seems I hit a peculiarity in

Re: kconfig-frontends-3.8.0.0 release

2013-02-19 Thread Jan Engelhardt
On Tuesday 2013-02-19 23:14, Yann E. MORIN wrote: >I'm pleased to announce the release of kconfig-frontends 3.8.0.0! >Go download it there: > > http://ymorin.is-a-geek.org/download/kconfig-frontends/kconfig-frontends-3.8.0.0.tar.xz > >

Re: kconfig-frontends-3.8.0.0 release

2013-02-19 Thread Jan Engelhardt
On Tuesday 2013-02-19 23:14, Yann E. MORIN wrote: I'm pleased to announce the release of kconfig-frontends 3.8.0.0! Go download it there: http://ymorin.is-a-geek.org/download/kconfig-frontends/kconfig-frontends-3.8.0.0.tar.xz

Re: kconfig-frontends-3.8.0.0 release

2013-02-19 Thread Jan Engelhardt
On Wednesday 2013-02-20 00:21, Yann E. MORIN wrote: This seems to install /usr/bin/diff[...] By default, the binaries should all ne prefixed with 'kconfig-' to avoid such name-clashing (as root, in a fresh debootstrap of squeeze here): Aha. Seems I hit a peculiarity in rpmbuild.

Re: IPsec AH use of ahash

2013-01-30 Thread Jan Engelhardt
On Sunday 2013-01-20 14:54, Tom St Denis wrote: >> >> > You should really try running checkpatch.pl over code that's >> > already in the kernel before you call out new contributors on it. >> > >> > How is this supposed to not be adversarial when I can't even use >> > the Kernel source itself as

Re: IPsec AH use of ahash

2013-01-30 Thread Jan Engelhardt
On Sunday 2013-01-20 14:54, Tom St Denis wrote: You should really try running checkpatch.pl over code that's already in the kernel before you call out new contributors on it. How is this supposed to not be adversarial when I can't even use the Kernel source itself as a reference?

  1   2   3   4   5   6   7   8   9   10   >