Re: [PATCH 4/4] DMA: PL330: add device tree property for DMA_MEMCPY capability

2012-10-29 Thread Jassi Brar
On Mon, Oct 29, 2012 at 10:59 AM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: * Add device tree (DT) property (pl330,dma-memcpy) for DMA_MEMCPY capability and instead of setting this capability unconditionally in pl330_probe() do it only when property is present. Perhaps we

Re: [PATCH 1/4] DMA: PL330: fix locking in pl330_free_chan_resources()

2012-10-29 Thread Jassi Brar
+0xac/0xe0) from [c00102f8] (cpu_idle+0xac/0xf0) [ 368.49] [c00102f8] (cpu_idle+0xac/0xf0) from [c04796a0] (start_kernel+0x28c/0x294) Cc: Jassi Brar jassisinghb...@gmail.com Cc: Vinod Koul vinod.k...@linux.intel.com Cc: Tomasz Figa t.f...@samsung.com Signed-off-by: Bartlomiej

Re: [RFT/PATCH] serial: omap: prevent resume if device is not suspended.

2012-09-25 Thread Jassi Brar
On 19 September 2012 17:29, Felipe Balbi ba...@ti.com wrote: this is what I mean, actually. If we remove pm_runtime_get_sync() in exchange for pm_runtime_set_active() before pm_runtime_enable(), it works on PandaBoard, but breaks BeagleBoard. Perhaps it suggests that OMAP4 (PandaBoard) serial

Re: [PATCH 1/3] DMA: PL330: Free memory allocated for peripheral channels

2012-09-25 Thread Jassi Brar
On Tue, Sep 25, 2012 at 2:27 PM, Inderpal Singh inderpal.si...@linaro.org wrote: The allocated memory for peripheral channels is not being freed upon failure in probe and in module's remove funtion. It will lead to memory leakage. Hence free the allocated memory. Signed-off-by: Inderpal Singh

Re: [PATCH 2/3] DMA: PL330: Change allocation method to properly free DMA descriptors

2012-09-25 Thread Jassi Brar
On Tue, Sep 25, 2012 at 2:27 PM, Inderpal Singh inderpal.si...@linaro.org wrote: In probe, memory for multiple DMA descriptors were being allocated at once and then it was being split and added into DMA pool one by one. The address of this memory allocation is not being saved anywhere. To free

Re: [PATCH 3/3] DMA: PL330: Balance module remove function with probe

2012-09-25 Thread Jassi Brar
On Tue, Sep 25, 2012 at 2:27 PM, Inderpal Singh inderpal.si...@linaro.org wrote: Since peripheral channel resources are not being allocated at probe, no need to flush the channels and free the resources in remove function. Signed-off-by: Inderpal Singh inderpal.si...@linaro.org ---

Re: [PATCH 3/3] DMA: PL330: Balance module remove function with probe

2012-09-26 Thread Jassi Brar
On Wed, Sep 26, 2012 at 12:11 PM, Inderpal Singh inderpal.si...@linaro.org wrote: How about conditionally DMA_TERMINATE_ALL and free resources like below ? @@ -3017,9 +3017,11 @@ static int __devexit pl330_remove(struct amba_device *adev) /* Remove the channel */

Re: [PATCH 3/3] DMA: PL330: Balance module remove function with probe

2012-09-26 Thread Jassi Brar
On Wed, Sep 26, 2012 at 4:25 PM, Inderpal Singh inderpal.si...@linaro.org wrote: On 26 September 2012 15:02, Jassi Brar jassisinghb...@gmail.com wrote: On Wed, Sep 26, 2012 at 12:11 PM, Inderpal Singh inderpal.si...@linaro.org wrote: How about conditionally DMA_TERMINATE_ALL and free

Re: [PATCH 3/3] DMA: PL330: Balance module remove function with probe

2012-09-26 Thread Jassi Brar
On Thu, Sep 27, 2012 at 9:43 AM, Inderpal Singh inderpal.si...@linaro.org wrote: Don't you think free_chan_resource should be done __only if__ alloc_chan_resource was successful ? No, I don't think so. Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH 3/3] DMA: PL330: Balance module remove function with probe

2012-09-27 Thread Jassi Brar
On Thu, Sep 27, 2012 at 11:00 AM, Inderpal Singh inderpal.si...@linaro.org wrote: On 27 September 2012 10:35, Jassi Brar jassisinghb...@gmail.com wrote: On Thu, Sep 27, 2012 at 9:43 AM, Inderpal Singh inderpal.si...@linaro.org wrote: Don't you think free_chan_resource should be done __only

Re: [PATCH 3/3] DMA: PL330: Balance module remove function with probe

2012-09-27 Thread Jassi Brar
On Thu, Sep 27, 2012 at 9:11 PM, Inderpal Singh inderpal.si...@linaro.org wrote: On 27 September 2012 15:18, Vinod Koul vinod.k...@linux.intel.com wrote: On Wed, 2012-09-26 at 12:11 +0530, Inderpal Singh wrote: If we fail pl330_remove while some client is queued, the force unload will fail and

Re: [PATCH v2 0/4] DMA: PL330: Fix mem leaks and balance probe/remove

2012-10-13 Thread Jassi Brar
-by: Jassi Brar jassisinghb...@gmail.com Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 4/4] DMA: PL330: add device tree property for DMA_MEMCPY capability

2012-11-08 Thread Jassi Brar
On 30 October 2012 14:51, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: Hi, On Monday 29 October 2012 22:45:48 Jassi Brar wrote: On Mon, Oct 29, 2012 at 10:59 AM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: * Add device tree (DT) property (pl330,dma-memcpy

Re: [PATCH] dma: add new DMA control commands

2012-10-18 Thread Jassi Brar
On 18 October 2012 12:15, Huang Shijie b32...@freescale.com wrote: 于 2012年10月18日 14:18, Vinod Koul 写道: Why cant you do start (prepare clock etc) when you submit the descriptor to dmaengine. Can be done in tx_submit callback. Similarly remove the clock when dma transaction gets completed. I

Re: [PATCH] dma: add new DMA control commands

2012-10-18 Thread Jassi Brar
On 18 October 2012 20:48, Huang Shijie shij...@gmail.com wrote: On Thu, Oct 18, 2012 at 5:29 AM, Jassi Brar jaswinder.si...@linaro.org wrote: On 18 October 2012 12:15, Huang Shijie b32...@freescale.com wrote: 于 2012年10月18日 14:18, Vinod Koul 写道: Why cant you do start (prepare clock etc) when

Re: [PATCHv3 00/14] drivers: mailbox: framework creation

2013-04-20 Thread Jassi Brar
Hi Suman, [Resending with mailing-list CCed this time. For some reason LKML doesn't appear in reply-to despite this message being fwd'ed from there] On Wed, Mar 13, 2013 at 8:53 AM, Suman Anna s-a...@ti.com wrote: Hi, Please find the updated mailbox patch series for pulling into linux-next.

Re: [PATCH 2/2] DMA: PL330: Check the pointer returned by kzalloc

2012-09-17 Thread Jassi Brar
On Mon, Sep 17, 2012 at 3:20 PM, Sachin Kamat sachin.ka...@linaro.org wrote: kzalloc could return NULL. Hence add a check to avoid NULL pointer dereference. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Patch 1 and 2, both Acked-by: Jassi Brar jassisinghb...@gmail.com -- To unsubscribe

Re: [PATCH] DMA: PL330: return ENOMEM instead of 0 from pl330_alloc_chan_resources

2012-09-16 Thread Jassi Brar
On Mon, Sep 17, 2012 at 9:57 AM, Inderpal Singh inderpal.si...@linaro.org wrote: Since 0 is not considered as error at dmaengine level, return ENOMEM from pl330_alloc_chan_resources in case of failure. Signed-off-by: Inderpal Singh inderpal.si...@linaro.org Acked-by: Jassi Brar jassisinghb

Re: [PATCH v4 1/7] DMA: PL330: use prefix in reg names to build under x86

2012-12-10 Thread Jassi Brar
Acked-by: Giancarlo Asnaghi giancarlo.asna...@st.com [Davide Ciminaghi cimina...@gnudd.com: only registers prefixed] Signed-off-by: Davide Ciminaghi cimina...@gnudd.com --- Acked-by: Jassi Brar jassisinghb...@gmail.com Thanks. -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 1/8 v3] DMA: PL330: use prefix in reg names to build under x86

2012-11-23 Thread Jassi Brar
On 24 November 2012 06:23, Davide Ciminaghi cimina...@gnudd.com wrote: From: Alessandro Rubini rub...@gnudd.com This driver would not compile if ARM_AMBA is selected under x86, because CS and DS are already defined there. But AMBA is used in the x86 world by a PCI-to-AMBA bridge, to be

Re: [PATCH 1/8 v3] DMA: PL330: use prefix in reg names to build under x86

2012-11-24 Thread Jassi Brar
On 24 November 2012 12:33, Alessandro Rubini rub...@gnudd.com wrote: My patch: This driver would not compile if ARM_AMBA is selected under x86, because CS and DS are already defined there. But AMBA is used in the x86 world by a PCI-to-AMBA bridge, to be submitted. The patch just adds the

Re: [patch 00/16] sched: per-entity load-tracking

2012-11-26 Thread Jassi Brar
Hi Paul, On Thu, Aug 23, 2012 at 7:44 PM, p...@google.com wrote: Hi all, Please find attached the latest version for CFS load-tracking. It implements load-tracking on a per-sched_entity (currently SCHED_NORMAL, but could be extended to RT as well) basis. This results in a bottom-up

Re: [patch 00/16] sched: per-entity load-tracking

2012-12-20 Thread Jassi Brar
On Thu, Dec 20, 2012 at 1:09 PM, Stephen Boyd sb...@codeaurora.org wrote: On 11/26/2012 5:08 AM, Jassi Brar wrote: The patchset introduces 64-bit atomic ops, which would need init_atomic64_lock() already called, but that is an initcall made too late. Should we consider calling

Re: [PATCH 4/4] DMA: PL330: add device tree property for DMA_MEMCPY capability

2012-12-11 Thread Jassi Brar
is present (idea from Jassi Brar). It fixes the issue on ARM EXYNOS platforms using DT where pdma controller erroneously was used for DMA_MEMCPY operations instead of mdma one (it seems to work correctly but at the cost of worse performance). Sorry, we need to change it as per new generic dma

Re: [PATCH 3/3] DMA: PL330: Balance module remove function with probe

2012-09-28 Thread Jassi Brar
On Fri, Sep 28, 2012 at 10:03 AM, Inderpal Singh inderpal.si...@linaro.org wrote: Now, if we have to check if any client is using the channel and then decide. We will have to traverse the channel list twice once to check the usage and second time to delete the nodes from the list if we go

Re: linux-next: manual merge of the arm-soc tree with the mailbox tree

2013-06-21 Thread Jassi Brar
On 21 June 2013 12:42, Tony Lindgren t...@atomide.com wrote: Arnd pulled in tags/omap-for-v3.11/mailbox-signed, which is the branch that should get merged to the mainline tree while we're waiting for the generic mailbox framework from Jassi. FYKI I, Suman and Loic have been co-ordinating

Re: [PATCH] dma: pl330: ensure DMA descriptors are zero-initialised

2013-11-29 Thread Jassi Brar
initialisation. Cc: Jassi Brar jaswinder.si...@linaro.org Cc: Vinod Koul vinod.k...@intel.com Cc: Dan Williams dan.j.willi...@intel.com Signed-off-by: Will Deacon will.dea...@arm.com --- drivers/dma/pl330.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/dma

Re: [PATCH 2/2] arm64: dts: exynos: added mailbox node

2014-03-17 Thread Jassi Brar
On Mon, Mar 17, 2014 at 5:45 PM, Arnd Bergmann a...@arndb.de wrote: On Monday 17 March 2014 17:33:59 Girish K S wrote: +Samsung Mailbox Driver + +Required properties: +- compatible: Should be one of the following, + samsung,gh7-mailbox for +

Re: [PATCH v3 1/3] dma: Support multiple interleaved frames with non-contiguous memory

2014-02-23 Thread Jassi Brar
On 21 February 2014 23:37, Srikanth Thokala stho...@xilinx.com wrote: On Thu, Feb 20, 2014 at 3:23 PM, Jassi Brar jaswinder.si...@linaro.org wrote: On 20 February 2014 14:54, Srikanth Thokala stho...@xilinx.com wrote: On Wed, Feb 19, 2014 at 12:33 AM, Jassi Brar jaswinder.si...@linaro.org

Re: [PATCH v3 1/3] dma: Support multiple interleaved frames with non-contiguous memory

2014-02-26 Thread Jassi Brar
On 26 February 2014 23:21, Srikanth Thokala stho...@xilinx.com wrote: On Mon, Feb 24, 2014 at 7:39 AM, Jassi Brar jaswinder.si...@linaro.org wrote: On 21 February 2014 23:37, Srikanth Thokala stho...@xilinx.com wrote: On Thu, Feb 20, 2014 at 3:23 PM, Jassi Brar jaswinder.si...@linaro.org

Re: [PATCHv3] Generic Mailbox API

2014-03-05 Thread Jassi Brar
On Sun, Feb 16, 2014 at 2:22 AM, Jassi Brar jassisinghb...@gmail.com wrote: Hello, Here is what the generic mailbox api looks like after modifications to make it work with 5 different platforms. Major feedback from Suman Anna(TI), LeyFoon Tan(Intel), Craig McGeachie(Broadcom) and Loic

Re: [PATCH v4 2/2] dma: Add Xilinx AXI Video Direct Memory Access Engine driver support

2014-03-10 Thread Jassi Brar
On Thu, Mar 6, 2014 at 7:18 PM, Srikanth Thokala stho...@xilinx.com wrote: +static struct dma_async_tx_descriptor * +xilinx_vdma_dma_prep_interleaved(struct dma_chan *dchan, +struct dma_interleaved_template *xt, +unsigned long

Re: [PATCH v4 2/2] dma: Add Xilinx AXI Video Direct Memory Access Engine driver support

2014-03-11 Thread Jassi Brar
On 11 March 2014 00:00, Srikanth Thokala stho...@xilinx.com wrote: On Mon, Mar 10, 2014 at 9:30 PM, Jassi Brar jassisinghb...@gmail.com wrote: On Thu, Mar 6, 2014 at 7:18 PM, Srikanth Thokala stho...@xilinx.com wrote: +static struct dma_async_tx_descriptor * +xilinx_vdma_dma_prep_interleaved

Re: [RFC 0/6] mailbox: add common framework and port drivers

2014-02-14 Thread Jassi Brar
Hi, On 8 February 2014 06:20, Courtney Cavin courtney.ca...@sonymobile.com wrote: There is currently no common framework for mailbox drivers, so this is my attempt to come up with something suitable. There seems to be a need for making this generic, so I have attempted to do just that. Most

Re: [RFC 0/6] mailbox: add common framework and port drivers

2014-02-14 Thread Jassi Brar
On 15 February 2014 09:10, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Sat, Feb 15, 2014 at 09:02:07AM +0530, Jassi Brar wrote: Hi, On 8 February 2014 06:20, Courtney Cavin courtney.ca...@sonymobile.com wrote: There is currently no common framework for mailbox drivers, so

Re: [RFC 0/6] mailbox: add common framework and port drivers

2014-02-14 Thread Jassi Brar
On 15 February 2014 09:41, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Sat, Feb 15, 2014 at 09:27:48AM +0530, Jassi Brar wrote: On 15 February 2014 09:10, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Sat, Feb 15, 2014 at 09:02:07AM +0530, Jassi Brar wrote: Hi

[PATCHv3] Generic Mailbox API

2014-02-15 Thread Jassi Brar
Hello, Here is what the generic mailbox api looks like after modifications to make it work with 5 different platforms. Major feedback from Suman Anna(TI), LeyFoon Tan(Intel), Craig McGeachie(Broadcom) and Loic Pallardy(ST). Signed-off-by: Jassi Brar jaswinder.si...@linaro.org

[PATCHv3 1/6] mailbox: rename pl320-ipc specific mailbox.h

2014-02-15 Thread Jassi Brar
From: Suman Anna s-a...@ti.com The patch 30058677 ARM / highbank: add support for pl320 IPC added a pl320 IPC specific header file as a generic mailbox.h. This file has been renamed appropriately to allow the introduction of the generic mailbox API framework. Acked-by: Mark Langsdorf

[PATCHv3 2/6] mailbox: Introduce a new common API

2014-02-15 Thread Jassi Brar
should have a look at include/linux/mailbox_controller.h Signed-off-by: Jassi Brar jaswinder.si...@linaro.org --- drivers/mailbox/Makefile | 4 + drivers/mailbox/mailbox.c | 534 + include/linux/mailbox.h| 17 ++ include/linux

[PATCHv3 4/6] mailbox: Fix TX completion init

2014-02-15 Thread Jassi Brar
Signed-off-by: Jassi Brar jaswinder.si...@linaro.org --- drivers/mailbox/mailbox.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index 3082f08..f8b31da 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c

[PATCHv3 3/6] mailbox: pl320: Introduce common API driver

2014-02-15 Thread Jassi Brar
Convert the PL320 controller driver to work with the common mailbox API. Also convert the only user of PL320, highbank-cpufreq.c to work with thee API. Drop the obsoleted driver pl320-ipc.c Signed-off-by: Jassi Brar jaswinder.si...@linaro.org --- drivers/cpufreq/highbank-cpufreq.c | 22

[PATCHv3 6/6] mailbox: move the internal definitions into a private file

2014-02-15 Thread Jassi Brar
From: Suman Anna s-a...@ti.com This is needed for extracting the omap_mbox. The OMAP mailbox code has a need for exporting some pre-existing API to not break the current clients. Signed-off-by: Suman Anna s-a...@ti.com --- drivers/mailbox/mailbox.c | 62 +-

[PATCHv3 5/6] mailbox: Fix deleteing poll timer

2014-02-15 Thread Jassi Brar
From: LeyFoon Tan lftan.li...@gmail.com Try to delete the timer only if it was init/used. Signed-off-by: LeyFoon Tan lftan.li...@gmail.com Signed-off-by: Jassi Brar jaswinder.si...@linaro.org --- drivers/mailbox/mailbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCHv3 2/6] mailbox: Introduce a new common API

2014-02-15 Thread Jassi Brar
[merging replies in one post] On Sun, Feb 16, 2014 at 12:45 AM, Greg KH gre...@linuxfoundation.org wrote: On Sat, Feb 15, 2014 at 11:55:27PM +0530, Jassi Brar wrote: +/* + * Call for IPC controller drivers to register a controller, adding + * its channels/mailboxes to the global pool

Re: [PATCHv3 6/6] mailbox: move the internal definitions into a private file

2014-02-15 Thread Jassi Brar
On Sun, Feb 16, 2014 at 12:46 AM, Greg KH gre...@linuxfoundation.org wrote: On Sat, Feb 15, 2014 at 11:57:02PM +0530, Jassi Brar wrote: From: Suman Anna s-a...@ti.com This is needed for extracting the omap_mbox. The OMAP mailbox code has a need for exporting some pre-existing API

Re: [PATCHv3] Generic Mailbox API

2014-02-16 Thread Jassi Brar
On 17 February 2014 11:27, Craig McGeachie slap...@yahoo.com.au wrote: On 16/02/14 07:22, Jassi Brar wrote: Hello, Here is what the generic mailbox api looks like after modifications to make it work with 5 different platforms. Major feedback from Suman Anna(TI), LeyFoon Tan(Intel

Re: [PATCHv3] Generic Mailbox API

2014-02-16 Thread Jassi Brar
On Mon, Feb 17, 2014 at 11:33 AM, Craig McGeachie slap...@yahoo.com.au wrote: On 16/02/14 07:22, Jassi Brar wrote: Hello, Here is what the generic mailbox api looks like after modifications to make it work with 5 different platforms. Major feedback from Suman Anna(TI), LeyFoon Tan

Re: [PATCH v3 1/3] dma: Support multiple interleaved frames with non-contiguous memory

2014-02-17 Thread Jassi Brar
On 15 February 2014 17:30, Srikanth Thokala stho...@xilinx.com wrote: The current implementation of interleaved DMA API support multiple frames only when the memory is contiguous by incrementing src_start/ dst_start members of interleaved template. But, when the memory is non-contiguous it

Re: [PATCHv3 2/6] mailbox: Introduce a new common API

2014-02-17 Thread Jassi Brar
Hi Courtney, On 18 February 2014 06:22, Courtney Cavin courtney.ca...@sonymobile.com wrote: On Sat, Feb 15, 2014 at 07:25:27PM +0100, Jassi Brar wrote: +request_token_t ipc_send_message(void *channel, void *mssg) +{ + struct ipc_chan *chan = (struct ipc_chan *)channel

Re: [PATCH v3 1/3] dma: Support multiple interleaved frames with non-contiguous memory

2014-02-18 Thread Jassi Brar
On 18 February 2014 16:58, Srikanth Thokala stho...@xilinx.com wrote: On Mon, Feb 17, 2014 at 3:27 PM, Jassi Brar jaswinder.si...@linaro.org wrote: On 15 February 2014 17:30, Srikanth Thokala stho...@xilinx.com wrote: The current implementation of interleaved DMA API support multiple frames

Re: [PATCHv3 2/6] mailbox: Introduce a new common API

2014-02-18 Thread Jassi Brar
On Tue, Feb 18, 2014 at 11:00 PM, Bjorn Andersson bj...@kryo.se wrote: On Mon, Feb 17, 2014 at 11:06 PM, Jassi Brar jaswinder.si...@linaro.org wrote: Hi Courtney, On 18 February 2014 06:22, Courtney Cavin courtney.ca...@sonymobile.com wrote: On Sat, Feb 15, 2014 at 07:25:27PM +0100, Jassi

Re: [PATCH v3 1/3] dma: Support multiple interleaved frames with non-contiguous memory

2014-02-18 Thread Jassi Brar
On 18 February 2014 23:16, Srikanth Thokala stho...@xilinx.com wrote: On Tue, Feb 18, 2014 at 10:20 PM, Jassi Brar jaswinder.si...@linaro.org wrote: On 18 February 2014 16:58, Srikanth Thokala stho...@xilinx.com wrote: On Mon, Feb 17, 2014 at 3:27 PM, Jassi Brar jaswinder.si...@linaro.org

Re: [PATCHv3 2/6] mailbox: Introduce a new common API

2014-02-19 Thread Jassi Brar
Hi Kumar, On 19 February 2014 03:02, Kumar Gala ga...@codeaurora.org wrote: On Feb 15, 2014, at 12:25 PM, Jassi Brar jassisinghb...@gmail.com wrote: Introduce common framework for client/protocol drivers and controller drivers of Inter-Processor-Communication (IPC). Client driver

Re: [PATCHv3 2/6] mailbox: Introduce a new common API

2014-02-19 Thread Jassi Brar
On 19 February 2014 01:17, Courtney Cavin courtney.ca...@sonymobile.com wrote: On Tue, Feb 18, 2014 at 08:06:55AM +0100, Jassi Brar wrote: +void *ipc_request_channel(struct ipc_client *cl) +{ [...] + spin_lock_irqsave(chan-lock, flags); + chan

Re: [PATCH v3 1/3] dma: Support multiple interleaved frames with non-contiguous memory

2014-02-20 Thread Jassi Brar
On 20 February 2014 14:54, Srikanth Thokala stho...@xilinx.com wrote: On Wed, Feb 19, 2014 at 12:33 AM, Jassi Brar jaswinder.si...@linaro.org wrote: On 18 February 2014 23:16, Srikanth Thokala stho...@xilinx.com wrote: On Tue, Feb 18, 2014 at 10:20 PM, Jassi Brar jaswinder.si...@linaro.org

[PATCHv4 0/5] Common Mailbox Framework

2014-03-18 Thread Jassi Brar
Hi, Here is the next revision of Mailbox code. Changes since v3: o Change name of symbols from ipc to mbox o Return real types instead of void * o Align structures o Change some symbol names rxcb - rx_callback txcb - tx_done o Added kernel-doc for exported API o Dropped

[PATCHv4 3/5] mailbox: pl320: Introduce common API driver

2014-03-18 Thread Jassi Brar
Convert the PL320 controller driver to work with the common mailbox API. Also convert the only user of PL320, highbank-cpufreq.c to work with thee API. Drop the obsoleted driver pl320-ipc.c Signed-off-by: Jassi Brar jaswinder.si...@linaro.org --- drivers/cpufreq/highbank-cpufreq.c | 24

[PATCHv4 4/5] mailbox: Fix TX completion init

2014-03-18 Thread Jassi Brar
Signed-off-by: Jassi Brar jaswinder.si...@linaro.org --- drivers/mailbox/mailbox.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index 79d576e..cdf7d45 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c

[PATCHv4 2/5] mailbox: Introduce framework for mailbox

2014-03-18 Thread Jassi Brar
should have a look at include/linux/mailbox_controller.h Signed-off-by: Jassi Brar jaswinder.si...@linaro.org --- drivers/mailbox/Makefile | 4 + drivers/mailbox/mailbox.c | 589 + include/linux/mailbox.h| 18 ++ include/linux

[PATCHv4 1/5] mailbox: rename pl320-ipc specific mailbox.h

2014-03-18 Thread Jassi Brar
From: Suman Anna s-a...@ti.com The patch 30058677 ARM / highbank: add support for pl320 IPC added a pl320 IPC specific header file as a generic mailbox.h. This file has been renamed appropriately to allow the introduction of the generic mailbox API framework. Acked-by: Mark Langsdorf

[PATCHv4 5/5] mailbox: Fix deleteing poll timer

2014-03-18 Thread Jassi Brar
From: LeyFoon Tan lftan.li...@gmail.com Try to delete the timer only if it was init/used. Signed-off-by: LeyFoon Tan lftan.li...@gmail.com Signed-off-by: Jassi Brar jaswinder.si...@linaro.org --- drivers/mailbox/mailbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCHv4 2/5] mailbox: Introduce framework for mailbox

2014-03-18 Thread Jassi Brar
On 19 March 2014 09:30, Girish KS girishks2...@gmail.com wrote: On Wed, Mar 19, 2014 at 12:15 AM, Jassi Brar jassisinghb...@gmail.com wrote: +int mbox_send_message(struct mbox_chan *chan, void *mssg) +{ + int t; + + if (!chan || !chan-cl) + return -EINVAL

Re: [PATCHv4 3/5] mailbox: pl320: Introduce common API driver

2014-03-18 Thread Jassi Brar
On 19 March 2014 00:40, Rob Herring robherri...@gmail.com wrote: On Tue, Mar 18, 2014 at 1:45 PM, Jassi Brar jassisinghb...@gmail.com wrote: Convert the PL320 controller driver to work with the common mailbox API. Also convert the only user of PL320, highbank-cpufreq.c to work with thee API

Re: [PATCH 2/2] arm64: dts: exynos: added mailbox node

2014-03-20 Thread Jassi Brar
On Wed, Mar 19, 2014 at 11:16 PM, Arnd Bergmann a...@arndb.de wrote: On Monday 17 March 2014, Jassi Brar wrote: Perhaps the mailbox controller driver should name its links as it wants. By how the remote works with the mailbox links, the client driver asks for a specific mailbox link (which

Re: [PATCH 2/2] arm64: dts: exynos: added mailbox node

2014-03-20 Thread Jassi Brar
On Thu, Mar 20, 2014 at 9:42 PM, Arnd Bergmann a...@arndb.de wrote: On Thursday 20 March 2014 21:39:56 Jassi Brar wrote: On Wed, Mar 19, 2014 at 11:16 PM, Arnd Bergmann a...@arndb.de wrote: On Monday 17 March 2014, Jassi Brar wrote: Perhaps the mailbox controller driver should name its

Re: [RFC 2/3] mailbox: Introduce a new common API

2013-05-07 Thread Jassi Brar
Hi Suman, On 7 May 2013 05:15, Suman Anna s-a...@ti.com wrote: The client(s) can always generate TX requests at a rate greater than the API could transmit on the physical link. So as much as we dislike it, we have to buffer TX requests, otherwise N clients would. The current code doesn't

Re: [PATCHv2 3/4] mailbox: pl320: Introduce common API driver

2013-05-07 Thread Jassi Brar
On 7 May 2013 07:28, Rob Herring robherri...@gmail.com wrote: On 05/06/2013 02:24 AM, Jassi Brar wrote: Convert the PL320 controller driver to work with the common mailbox API. Also convert the only user of PL320, highbank-cpufreq.c to work with thee API. Drop the obsoleted driver pl320-ipc.c

Re: [RFC 2/3] mailbox: Introduce a new common API

2013-05-07 Thread Jassi Brar
On 8 May 2013 03:18, Suman Anna s-a...@ti.com wrote: Hi Jassi, On 7 May 2013 05:15, Suman Anna s-a...@ti.com wrote: The client(s) can always generate TX requests at a rate greater than the API could transmit on the physical link. So as much as we dislike it, we have to buffer TX requests,

Re: [RFC 2/3] mailbox: Introduce a new common API

2013-05-09 Thread Jassi Brar
Hi Suman, On 9 May 2013 06:55, Suman Anna s-a...@ti.com wrote: so it can't be driven by the controller. We could make it a Kconfig option. What do you suggest? I am saying controller/link because they are the ones that knows how the physical transport is, and it may vary from one to

Re: [PATCHv2 2/4] mailbox: Introduce a new common API

2013-05-09 Thread Jassi Brar
On 9 May 2013 22:01, Suman Anna s-a...@ti.com wrote: Hi Jassi, On 05/06/2013 02:24 AM, Jassi Brar wrote: +++ b/include/linux/mailbox_client.h @@ -0,0 +1,85 @@ +/* + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public

Re: [PATCHv2 2/4] mailbox: Introduce a new common API

2013-05-09 Thread Jassi Brar
On Thu, May 9, 2013 at 10:10 PM, Suman Anna s-a...@ti.com wrote: On 05/09/2013 11:41 AM, Jassi Brar wrote: On 9 May 2013 22:01, Suman Anna s-a...@ti.com wrote: Hi Jassi, On 05/06/2013 02:24 AM, Jassi Brar wrote: +++ b/include/linux/mailbox_client.h @@ -0,0 +1,85 @@ +/* + * This program

Re: [PATCHv2 2/4] mailbox: Introduce a new common API

2013-05-09 Thread Jassi Brar
On 9 May 2013 23:35, Suman Anna s-a...@ti.com wrote: Perhaps we should change the following void ipc_link_txdone(struct ipc_link *link, enum xfer_result r) to void ipc_link_txdone(struct ipc_link *link, enum xfer_result r, void *data) So that the API could pass that onto clients ?

Re: [PATCHv3 00/14] drivers: mailbox: framework creation

2013-04-29 Thread Jassi Brar
Hi On 29 April 2013 21:30, Suman Anna s-a...@ti.com wrote: Hi Jassi, On 04/26/2013 11:51 PM, Jassi Brar wrote: OK, I didn't think of a no RTR interrupt-based controller. I would thing that such a controller is very rudimentary. I wonder if there are any controllers like this out

Re: [RFC 3/3] mailbox: pl320: Introduce common API driver

2013-04-29 Thread Jassi Brar
On 29 April 2013 22:14, Suman Anna s-a...@ti.com wrote: On 04/27/2013 01:14 PM, jassisinghb...@gmail.com wrote: From: Jassi Brar jaswinder.si...@linaro.org Convert the PL320 controller driver to work with the common mailbox API. Also convert the only user of PL320, highbank-cpufreq.c to work

Re: [RFC 3/3] mailbox: pl320: Introduce common API driver

2013-04-29 Thread Jassi Brar
On 29 April 2013 22:36, Mark Langsdorf mark.langsd...@calxeda.com wrote: On 04/29/2013 11:57 AM, Jassi Brar wrote: On 29 April 2013 22:14, Suman Anna s-a...@ti.com wrote: On 04/27/2013 01:14 PM, jassisinghb...@gmail.com wrote: From: Jassi Brar jaswinder.si...@linaro.org Signed-off-by: Jassi

Re: [RFC 2/3] mailbox: Introduce a new common API

2013-05-04 Thread Jassi Brar
Hi Suman, On 4 May 2013 07:50, Suman Anna s-a...@ti.com wrote: Hi Jassi, On 04/27/2013 01:14 PM, jassisinghb...@gmail.com wrote: From: Jassi Brar jaswinder.si...@linaro.org Introduce common framework for client/protocol drivers and controller drivers of Inter-Processor-Communication (IPC

[PATCHv2 0/4] mailbox: Common API

2013-05-06 Thread Jassi Brar
Hello, I have made the implementation look more proper. Also made some changes suggested by Suman. Changes since V1: * Delete timer upon mailbox release * Filled in the stub ipc_links_unregister() * Check kzalloc return for errors. * Add the controller driver for OMAP2 class. I have taken the

[PATCHv2 1/4] mailbox: rename pl320-ipc specific mailbox.h

2013-05-06 Thread Jassi Brar
From: Suman Anna s-a...@ti.com The patch 30058677 ARM / highbank: add support for pl320 IPC added a pl320 IPC specific header file as a generic mailbox.h. This file has been renamed appropriately to allow the introduction of the generic mailbox API framework. Acked-by: Mark Langsdorf

[PATCHv2 2/4] mailbox: Introduce a new common API

2013-05-06 Thread Jassi Brar
should have a look at include/linux/mailbox_controller.h Signed-off-by: Jassi Brar jaswinder.si...@linaro.org --- drivers/mailbox/Makefile |4 + drivers/mailbox/mailbox.c | 494 include/linux/mailbox.h| 17 ++ include/linux

[PATCHv2 3/4] mailbox: pl320: Introduce common API driver

2013-05-06 Thread Jassi Brar
Convert the PL320 controller driver to work with the common mailbox API. Also convert the only user of PL320, highbank-cpufreq.c to work with thee API. Drop the obsoleted driver pl320-ipc.c Signed-off-by: Jassi Brar jaswinder.si...@linaro.org --- drivers/cpufreq/highbank-cpufreq.c | 22

[PATCHv2 4/4] mailbox: omap2: Introduce common API driver

2013-05-06 Thread Jassi Brar
A new driver conforming to the common API. Signed-off-by: Jassi Brar jaswinder.si...@linaro.org --- arch/arm/mach-omap2/omap_hwmod_2420_data.c | 12 + arch/arm/mach-omap2/omap_hwmod_2430_data.c | 11 + arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 11 + arch/arm/mach-omap2

Re: [PATCH] ARM: tegra: add basic SecureOS support

2013-06-06 Thread Jassi Brar
On Thu, Jun 6, 2013 at 12:58 PM, Alexandre Courbot acour...@nvidia.com wrote: Boot loaders on some Tegra devices can be unlocked but do not let the system operate without SecureOS. SecureOS prevents access to some registers and requires the operating system to perform certain operations

Re: [PATCH] ARM: tegra: add basic SecureOS support

2013-06-07 Thread Jassi Brar
On Fri, Jun 7, 2013 at 12:43 PM, Alexandre Courbot gnu...@gmail.com wrote: On Thu, Jun 6, 2013 at 9:26 PM, Jassi Brar jassisinghb...@gmail.com wrote: On Thu, Jun 6, 2013 at 12:58 PM, Alexandre Courbot acour...@nvidia.com wrote: Boot loaders on some Tegra devices can be unlocked but do not let

Re: [PATCHv3 00/14] drivers: mailbox: framework creation

2013-04-22 Thread Jassi Brar
Hi Suman, On Mon, Apr 22, 2013 at 9:26 PM, Anna, Suman s-a...@ti.com wrote: a) No documentation. Usually the header would have proper documentation of data structures and info for users of both side of the api. I will fix the documentation portion for 3.10. I will also add a TODO as part

Re: [PATCHv3 00/14] drivers: mailbox: framework creation

2013-04-23 Thread Jassi Brar
Hi Suman, [please limit replies to not more than 80 columns per line] On 24 April 2013 00:50, Anna, Suman s-a...@ti.com wrote: Documentation wise, we'd need documentation for what we finally wanna have, not the current implementation. There are also some desired features in a good API:-

Re: [PATCHv3 00/14] drivers: mailbox: framework creation

2013-04-24 Thread Jassi Brar
Hi Loic, On 24 April 2013 13:09, Loic PALLARDY loic.palla...@st.com wrote: Hi Jassi, Suman, Yes, the xxx_no_irq API has been introduced to answer some STE requirements. It must be possible to send some message under atomic context for different reasons (latency, during idle/suspend

Re: [PATCHv3 00/14] drivers: mailbox: framework creation

2013-04-24 Thread Jassi Brar
Hi - On 24 April 2013 13:38, Loic PALLARDY loic.palla...@st.com wrote: Hi Jassi, On 04/24/2013 06:39 AM, Jassi Brar wrote: The non-atomic API falls flat should just a single client comes with very low latency requirements. In fact there are different situations for the non/atomic

Re: [PATCHv3 00/14] drivers: mailbox: framework creation

2013-04-24 Thread Jassi Brar
On 25 April 2013 04:46, Suman Anna s-a...@ti.com wrote: On 04/24/2013 03:56 AM, Jassi Brar wrote: I think there are two things here - one is what the client needs to do upon sending/receiving a message, and the other is what the send API or the mailbox controller should do when a client

Re: [PATCHv3 00/14] drivers: mailbox: framework creation

2013-04-25 Thread Jassi Brar
Hi Suman, On 26 April 2013 03:59, Suman Anna s-a...@ti.com wrote: On 04/25/2013 12:20 AM, Jassi Brar wrote: tranmitting right away. OK, I thought you didn't want buffering, if that is not the case, then the buffering should be within the main driver code, like it is now, but configurable

Re: [PATCHv3 00/14] drivers: mailbox: framework creation

2013-04-26 Thread Jassi Brar
Hi Suman, On 26 April 2013 03:59, Suman Anna s-a...@ti.com wrote: On 04/25/2013 12:20 AM, Jassi Brar wrote: I never said no-buffering and I never said buffering should be in controller drivers. In fact I don't remember ever objecting to how buffering is done in TI's framework. A controller

Re: [RFC 2/3] mailbox: Introduce a new common API

2013-05-10 Thread Jassi Brar
Hello Suman, On 10 May 2013 05:48, Suman Anna s-a...@ti.com wrote: No, please. The controller driver should not implement any policy (of allowing/disallowing requests). It should simply try to do as directed. If the client screwed up even after getting info from platform_data/DT, let it

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-06-05 Thread Jassi Brar
On 5 June 2014 16:42, Matt Porter mpor...@linaro.org wrote: On Tue, Jun 03, 2014 at 03:51:55PM +0530, Jassi Brar wrote: BTW, here we at least have a hardware resource to specify in the DT node, there are examples in kernel where the DT nodes are purely virtual. For ex, grep for linux,spdif

Re: [PATCHv6 2/3] mailbox: Introduce framework for mailbox

2014-06-05 Thread Jassi Brar
On 5 June 2014 16:21, Matt Porter mpor...@linaro.org wrote: On Tue, Jun 03, 2014 at 12:01:24AM +0530, Jassi Brar wrote: Introduce common framework for client/protocol drivers and controller drivers of Inter-Processor-Communication (IPC). Client driver developers should have a look

[PATCHv7 0/5] Common Mailbox Framework

2014-06-12 Thread Jassi Brar
Hello, Here is the next revision of Mailbox framwork. Changes since v6: o Separate out generic DT bindings patch. o Discard unnecessary aligned attributes. Changes since v5: o Use standard error types instead of special type mbox_result. o Constify client struct in request_channel o Use

[PATCHv7 4/5] mailbox: Fix deleteing poll timer

2014-06-12 Thread Jassi Brar
From: LeyFoon Tan lftan.li...@gmail.com Try to delete the timer only if it was init/used. Signed-off-by: LeyFoon Tan lftan.li...@gmail.com Signed-off-by: Jassi Brar jaswinder.si...@linaro.org --- drivers/mailbox/mailbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCHv7 3/5] Mailbox: Generic: Specify mailbox api bindings

2014-06-12 Thread Jassi Brar
this binding specifies. Signed-off-by: Jassi Brar jaswinder.si...@linaro.org --- .../devicetree/bindings/mailbox/mailbox.txt| 33 ++ 1 file changed, 33 insertions(+) create mode 100644 Documentation/devicetree/bindings/mailbox/mailbox.txt diff --git a/Documentation/devicetree

[PATCHv7 1/5] mailbox: rename pl320-ipc specific mailbox.h

2014-06-12 Thread Jassi Brar
From: Suman Anna s-a...@ti.com The patch 30058677 ARM / highbank: add support for pl320 IPC added a pl320 IPC specific header file as a generic mailbox.h. This file has been renamed appropriately to allow the introduction of the generic mailbox API framework. Acked-by: Mark Langsdorf

[PATCHv7 2/5] mailbox: Introduce framework for mailbox

2014-06-12 Thread Jassi Brar
should have a look at include/linux/mailbox_controller.h Signed-off-by: Jassi Brar jaswinder.si...@linaro.org --- drivers/mailbox/Makefile | 4 + drivers/mailbox/mailbox.c | 487 + include/linux/mailbox_client.h | 45 include/linux

[PATCHv7 5/5] MAINTAINERS: Add maintainer entry for Mailbox API

2014-06-12 Thread Jassi Brar
Add myself as the maintainer of mailbox api Signed-off-by: Jassi Brar jaswinder.si...@linaro.org --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b4a66b9..7f6651b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5633,6 +5633,14 @@ S

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-05-20 Thread Jassi Brar
On Tue, May 20, 2014 at 1:25 AM, Bjorn Andersson bj...@kryo.se wrote: On Mon, May 19, 2014 at 11:03 AM, Jassi Brar jaswinder.si...@linaro.org wrote: On 19 May 2014 18:38, Arnd Bergmann a...@arndb.de wrote: On Friday 16 May 2014 19:03:25 Jassi Brar wrote: [...] Do you have an example

  1   2   3   4   5   6   7   8   9   10   >