The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
This patch adds support for the RTC and is based on a driver
added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow
and today's linux-next (20140818).
Doug Anderson (1):
rtc: max77686: Allow the max77686 rtc to wakeup the system
Javier Martinez Canillas (4):
rtc: max77686: Remove dead code for SMPL and WTSR.
rtc: max77686: Fail to probe if no RTC regmap irqchip is set
rtc: max77686: Remove unneded info log
instead of getting an OOPS.
Reported-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Fixes the issue reported by Krzystof in: https://lkml.org/lkml/2014/8/8/121
---
drivers/rtc/rtc-max77686.c | 6 ++
1 file changed, 6
the driver was original merged in
commit fca1dd03 (rtc: max77686: add Maxim 77686 driver).
So, since this code has never been built, let's just remove it.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
drivers/rtc
On 09/11/2014 09:33 PM, Mark Brown wrote:
On Thu, Sep 11, 2014 at 03:03:50PM +0200, Javier Martinez Canillas wrote:
This can be easily worked around (and probably why it never was an issue) if
the OF and SPI tables are kept in sync but I don't know if that is a hard
requirement for all use
Hello Kukjin,
On 09/12/2014 02:26 PM, kg...@kernel.org wrote:
This is a third version of th series that adds max77802 support for
the Peach Pit and Pi boards. The series also have all the pending
patches that were posted but depended on this support. I've picked
all the patches I found and
Hello Doug,
On 09/12/2014 05:12 PM, Doug Anderson wrote:
Hi,
On Fri, Sep 12, 2014 at 1:17 AM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
From: Doug Anderson diand...@chromium.org
The max77686 includes an RTC that keeps power during suspend. It's
convenient
[adding Sjoerd as cc who was the one that raised the module auto-loading issue]
Hello,
On Fri, Sep 12, 2014 at 3:46 PM, Wolfram Sang w...@the-dreams.de wrote:
Placing this firmly back on your plate. I truly hope we don't miss
another merge-window. This patch-set has the support of some
Hello Andrew,
Thanks a lot for taking a look to these patches!
On 09/13/2014 12:05 AM, Andrew Morton wrote:
On Fri, 12 Sep 2014 10:17:39 +0200 Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
From: Doug Anderson diand...@chromium.org
The max77686 includes an RTC
Hello Andrew,
On 09/13/2014 12:13 AM, Andrew Morton wrote:
On Fri, 12 Sep 2014 10:17:43 +0200 Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
This patch adds support for the RTC and is based on a driver
added
;
+ };
+ };
+ };
+ };
+
mmc@1255 {
num-slots = 1;
supports-highspeed;
Once those two issues are addressed, feel free to add my
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Best regards,
Javier
-to-RAM is working on my Exynos5420 Peach Pit Chromebook, so:
Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
/suspend.c|1 +
5 files changed, 45 insertions(+), 18 deletions(-)
create mode 100644 arch/arm/mach-exynos/exynos-pmu.h
Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
Hello Doug,
On 10/07/2014 07:48 PM, Doug Anderson wrote:
I don't have all the right patches to test this right now. Hopefully
you can point me at what we're using right now. I'd expect that this
will need the patches that Chanwoo and Javier are working on, so I've
added them to this.
to the ones supported by each hardware according to their
data-sheet.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Documentation/devicetree/bindings/regulator/regulator.txt | 8
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings
Device Tree source files can set a regulator operating mode to be
used as an initial default. Instead of using magic numbers, a header
file can be included that provides macro definitions for the opmodes.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
include/dt
-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 26 ++
arch/arm/boot/dts/exynos5800-peach-pi.dts | 26 ++
2 files changed, 52 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420
Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/regulator/of_regulator.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c
index 18236be..a076b7f 100644
--- a/drivers/regulator/of_regulator.c
+++ b/drivers
data-sheet.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/regulator/max77802.c | 32
1 file changed, 32 insertions(+)
diff --git a/drivers/regulator/max77802.c b/drivers/regulator/max77802.c
index d89792b..04ed5cf 100644
are complementary to solve the same general issue and to
avoid merge conflicts. But I can resend to just base on top of the regulator
for-next branch if that is easier for you.
The series is composed of the following patches:
Javier Martinez Canillas (5):
regulator: of: Add regulator-initial-mode parse
Hello Mark,
Thanks for the feedback.
On 10/08/2014 04:25 PM, Mark Brown wrote:
On Wed, Oct 08, 2014 at 03:44:03PM +0200, Javier Martinez Canillas wrote:
But currently there isn't a way to do the same with DeviceTrees. Argubly
the operating modes are Linux-specific so that information should
On 10/08/2014 04:34 PM, Mark Brown wrote:
On Wed, Oct 08, 2014 at 03:44:05PM +0200, Javier Martinez Canillas wrote:
+- regulator-initial-mode: initial regulator operating mode. One of
following:
+1: REGULATOR_MODE_FAST- Regulator can handle fast changes.
+2
On 10/08/2014 04:36 PM, Mark Brown wrote:
On Wed, Oct 08, 2014 at 03:44:06PM +0200, Javier Martinez Canillas wrote:
Add a function handler for the struct regulator_ops .set_mode so an
operating mode (opmode) can be set for regulators.
Regulators opmode are defined using the generic
On 10/08/2014 04:56 PM, Mark Brown wrote:
On Wed, Oct 08, 2014 at 03:44:07PM +0200, Javier Martinez Canillas wrote:
The regulator core now has support to choose a default initial
operating mode for regulators from DT. Set the initial opmode
for the max77802 PMIC regulators with the same
On 10/08/2014 05:12 PM, Mark Brown wrote:
On Wed, Oct 08, 2014 at 04:38:53PM +0200, Javier Martinez Canillas wrote:
On 10/08/2014 04:25 PM, Mark Brown wrote:
That doesn't mean that the definition of those modes is something we can
sensibly provide in generic code, especially
Hello Mark,
On 10/08/2014 09:51 PM, Mark Brown wrote:
On Wed, Oct 08, 2014 at 06:25:00PM +0200, Javier Martinez Canillas
What this series tried to solve is when you have to set a opmode on
boot to change how the physical suspend is managed by the PMIC.
Think about the consequences of what's
Hello Krzysztof,
Thanks a lot for your feedback.
On 10/09/2014 10:45 AM, Krzysztof Kozlowski wrote:
On śro, 2014-10-08 at 15:44 +0200, Javier Martinez Canillas wrote:
--- a/Documentation/devicetree/bindings/regulator/regulator.txt
+++ b/Documentation/devicetree/bindings/regulator
Hello Mark,
On 10/09/2014 12:27 PM, Mark Rutland wrote:
Well, is not fairly obvious to me. One can also say the opposite, why the
kernel is documenting a DT binding that is not (currently) implemented?
Checkpatch will complain regarding undocumented bindings, so from a
pragmatic point of
easier.
Document this convention since it may not be obvious.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Documentation/devicetree/bindings/submitting-patches.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/submitting
easier.
Document this convention since it may not be obvious.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v1:
- Small typo error, sorry for the noise.
Documentation/devicetree/bindings/submitting-patches.txt | 3 +++
1 file changed, 3 insertions
.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
arch/arm/configs/exynos_defconfig | 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/configs/exynos_defconfig
b/arch/arm/configs/exynos_defconfig
index b14d8c3..a36fe1c 100644
--- a/arch/arm/configs
Hello Arnd, Stephen,
On 10/02/2014 04:32 PM, Arnd Bergmann wrote:
On Thursday 02 October 2014 11:37:42 Stephen Rothwell wrote:
After merging the arm-soc tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:
arch/arm/boot/dts/exynos5250-snow.dts:13:46: fatal error:
Hello Russell,
On 10/03/2014 09:56 AM, Russell King - ARM Linux wrote:
On Fri, Oct 03, 2014 at 08:50:09AM +0200, Javier Martinez Canillas wrote:
Hello Arnd, Stephen,
I'm so sorry about the breakage, when I posted this patch I mentioned that
it was meant for the 3.18-rc cycle once 3.18-rc1
Exynos boards.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Acked-by: Kevin Hilman khil...@linaro.org
Tested-by: Kevin Hilman khil...@linaro.org
---
This patch supersedes [0] since commit ARM: exynos_defconfig: savedefconfig
is not present in linux-next anymore which
Hello Krzysztof,
On 10/27/2014 10:44 AM, Krzysztof Kozlowski wrote:
Some LDOs of Maxim 77686 PMIC support disabling during system suspend
(LDO{2,6,7,8,10,11,12,14,15,16}). This was already implemented as part
of set_suspend_mode function. In that case the mode was one of:
- disable,
-
On 10/27/2014 11:27 AM, Krzysztof Kozlowski wrote:
Storing opmode in non-shifted form is intuitive also to me. That's way I
slipped the bug in previous version.
Great.
I'll change this to non-shifted opmode. The patch will grow bigger but
the code should be more readable.
Maybe split
Hello Dan,
On 10/27/2014 11:45 AM, Dan Carpenter wrote:
The original test triggers a static checker warning. Javier Martinez
Canillas says that the ! is a typo and should be removed.
Fixes: 2e0eaa1aa008 ('regulator: max77802: Add set suspend mode for BUCKs and
simplify code')
Signed-off
. Additionally this will allow adding support LDOs to the
existing set_suspend_disable function.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Suggested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/regulator/max77686.c | 49
.c
+++ b/drivers/regulator/max77686.c
Looks good to me.
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
Martinez Canillas javier.marti...@collabora.co.uk
Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
Hello Krzysztof,
On 10/27/2014 04:03 PM, Krzysztof Kozlowski wrote:
The driver is used only on Exynos4 based boards with DTS support.
Convert the driver to DTS-only version.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
drivers/regulator/max77686.c | 51
/max77686.c
+++ b/drivers/mfd/max77686.c
As I said in Patch 2/8, I think this driver should depend on OF since
is now DT-only. Regulator drivers don't need to do this since they
already depend on MFD_MAX77686. With that change feel free to add:
Reviewed-by: Javier Martinez Canillas javier.marti
= {
MAX77686_OPMODE_BUCK234_SHIFT, \
}
-static struct regulator_desc regulators[] = {
+static const struct regulator_desc regulators[] = {
regulator_desc_ldo1_low(1),
regulator_desc_ldo_low(2),
regulator_desc_ldo(3),
Reviewed-by: Javier Martinez Canillas javier.marti
Hello Krzysztof,
On 10/27/2014 04:03 PM, Krzysztof Kozlowski wrote:
Minor nit: Initialize the opmode for each regulator to normal mode in a
readable explicit way.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Suggested-by: Javier Martinez Canillas javier.marti
Hello Krzysztof,
On 10/27/2014 04:03 PM, Krzysztof Kozlowski wrote:
@@ -85,6 +91,9 @@ struct max77686_data {
struct max77686_regulator_data *regulators;
int num_regulators;
+ /* Array of size num_regulators with GPIOs for external control. */
+ int *ext_control_gpio;
Hello Krzysztof,
On 10/27/2014 04:03 PM, Krzysztof Kozlowski wrote:
Document usage of gpio property which turns on external control over
regulator.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
Documentation/devicetree/bindings/mfd/max77686.txt | 3 +++
1 file changed, 3
Hello Krzysztof,
On 10/28/2014 09:45 AM, Krzysztof Kozlowski wrote:
Thanks! However Mark had some comments which will reorganize the patch
completely. I'll be sending next version and probably I would need your
ack and testing again.
Sure, I can test your patches if you don't have access
[adding Linus and Alexandre to the cc list]
Hello Krzysztof,
On 10/29/2014 11:42 AM, Krzysztof Kozlowski wrote:
On wto, 2014-10-28 at 13:11 +0100, Krzysztof Kozlowski wrote:
On wto, 2014-10-28 at 09:52 +0100, Krzysztof Kozlowski wrote:
On pon, 2014-10-27 at 21:03 +0100, Javier Martinez
Hello Krzysztof,
On 10/29/2014 11:44 AM, Krzysztof Kozlowski wrote:
On śro, 2014-10-29 at 10:31 +, Mark Brown wrote:
On Wed, Oct 29, 2014 at 11:18:54AM +0100, Krzysztof Kozlowski wrote:
On śro, 2014-10-29 at 10:01 +, Mark Brown wrote:
No, this isn't suspend enable control - this
explained, I understand this is the right thing to do.
Acked-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Hello Chris,
On 10/29/2014 04:40 PM, Doug Anderson wrote:
regulator-min-microvolt = 75;
regulator-max-microvolt = 130;
regulator-name = vdd_arm;
+
Hello Krzysztof,
On 10/29/2014 04:06 PM, Krzysztof Kozlowski wrote:
static int max77802_pmic_probe(struct platform_device *pdev)
{
struct max77686_dev *iodev = dev_get_drvdata(pdev-dev.parent);
- struct max77686_platform_data *pdata = dev_get_platdata(iodev-dev);
struct
Hello Doug,
On 10/29/2014 05:51 PM, Doug Anderson wrote:
In other words, do you want the core to call rk808_set_suspend_voltage() or
rk808_set_suspend_enable()? If the later then you can use Chanwoo's bindings:
regulator-state-mem {
regulator-on-in-suspend;
};
The rk808 has a
Hello Kukjin,
On Mon, Oct 20, 2014 at 11:05 PM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
The regulator framework has a set of helpers functions to be used when
the system is entering and leaving from suspend but these are not called
on Exynos platforms. This means
;
+ } else {
+ val = val shift MAX77802_OPMODE_MASK;
+ }
/*
* If the regulator is disabled and the system warm rebooted,
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Best regards,
Javier
Hello Krzysztof,
On 10/30/2014 12:20 PM, Krzysztof Kozlowski wrote:
static int max77802_pmic_probe(struct platform_device *pdev)
{
struct max77686_dev *iodev = dev_get_drvdata(pdev-dev.parent);
- struct max77686_platform_data *pdata = dev_get_platdata(iodev-dev);
struct
Hello Krzysztof,
On 10/30/2014 01:10 PM, Krzysztof Kozlowski wrote:
I may be missing something but I don't understand why a compatible string
for the regulators sub-node is needed. Isn't enough to just fill the
.regulators_node field in the struct regulator_desc? e.g:
.regulators_node
Hello Krzysztof,
On 10/30/2014 01:30 PM, Krzysztof Kozlowski wrote:
tor_of_get_init_data() function?
The regulator_of_get_init_data() searches from dev-of_node or its child
node.
But dev-of_node is NULL.
That's why of_compatible is needed.
Yes but regulator_register() does dev
Hello Krzysztof,
On 10/30/2014 01:53 PM, Krzysztof Kozlowski wrote:
To me a intuitive structure would be:
MFD device
|
- clock device
|
- clock1
- clock2
- regulator device
|
- LDO1
- LDO2
etc.
This also maps to structure in DTS. dev_err*
know if you expected the former.
Doug Anderson (1):
rtc: max77686: Allow the max77686 rtc to wakeup the system
Javier Martinez Canillas (5):
rtc: max77686: Remove dead code for SMPL and WTSR.
rtc: max77686: Fail to probe if no RTC regmap irqchip is set
rtc: max77686: Remove unneded info log
If devm_rtc_device_register() fails a dev_err() is already
reported so there is no need to do an additional dev_info().
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
drivers/rtc/rtc-max77686.c | 2 --
1 file
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
This patch adds support for the RTC and is based on a driver
added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow
the driver was original merged in
commit fca1dd03 (rtc: max77686: add Maxim 77686 driver).
So, since this code has never been built, let's just remove it.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
drivers/rtc
Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/rtc/rtc-max77686.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
index b177ba1..2659bd3 100644
--- a/drivers/rtc/rtc-max77686.c
+++ b/drivers/rtc/rtc
instead of getting an OOPS.
Reported-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
Fixes the issue reported by Krzystof in: https://lkml.org/lkml/2014/8/8/121
From: Doug Anderson diand...@chromium.org
The max77686 includes an RTC that keeps power during suspend. It's
convenient to be able to use it as a wakeup source.
Signed-off-by: Doug Anderson diand...@chromium.org
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed
Chromebook and I see
that of_syscon_register() is called for the PMU system controller with
compatible string samsung,exynos5420-pmu, syscon which does not
have a dedicated platform driver, so:
Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Best regards,
Javier
Hello Joe,
On 09/19/2014 04:39 PM, Joe Perches wrote:
On Fri, 2014-09-19 at 12:26 +0200, Javier Martinez Canillas wrote:
The function max77686_rtc_calculate_wday() is used to
calculate the day of the week to be filled in struct
rtc_time but that function only calculates the number
of bits
Hello Joe,
On 09/19/2014 09:52 PM, Joe Perches wrote:
On Fri, 2014-09-19 at 21:27 +0200, Javier Martinez Canillas wrote:
On 09/19/2014 04:39 PM, Joe Perches wrote:
On Fri, 2014-09-19 at 12:26 +0200, Javier Martinez Canillas wrote:
The function max77686_rtc_calculate_wday() is used
Hello Doug,
Thanks for your feedback.
On 11/18/2014 06:50 PM, Doug Anderson wrote:
This is common practice in the Chrome OS tree, but we've gotten
pushback from upstream questioning about whether spidev is really a
physical device. See:
Hello Kukjin,
On 11/19/2014 09:09 AM, Kukjin Kim wrote:
You say that you will apply this patch but I can't find it in any of
your branches.
Sorry for missing the patch in my tree. You can see it in a couple of
mins ;)
Great, thanks a lot!
Best regards,
Javier
--
To unsubscribe from
-phy
node.
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
Cc: Jingoo Han jg1@samsung.com
Reviewed-by: Jingoo Han jg1@samsung.com
Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Kukjin,
This patch is -rc material and is needed to have display working in
3.18
anyways.
Patch looks good to me though:
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Hello Andreas,
On 11/19/2014 04:56 PM, Andreas Färber wrote:
Spotted in the Chrome OS 3.8 based device tree.
Needs CONFIG_SENSORS_LM90.
Signed-off-by: Andreas Färber afaer...@suse.de
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Best regards,
Javier
Hello Andreas,
On 11/19/2014 04:56 PM, Andreas Färber wrote:
multi_v7_defconfig has it as Y already, so build it in here, too, for
consistency, and therefore build in HWMON as well.
Signed-off-by: Andreas Färber afaer...@suse.de
Reviewed-by: Javier Martinez Canillas javier.marti
Hello Andreas,
On 11/19/2014 04:56 PM, Andreas Färber wrote:
The HP Chromebook 11 uses an Atmel maXTouch as trackpad.
The keymap was found by trial-and-error.
Signed-off-by: Andreas Färber afaer...@suse.de
Patch looks good to me.
Reviewed-by: Javier Martinez Canillas javier.marti
Hello Doug,
On 11/19/2014 06:19 PM, Doug Anderson wrote:
I wonder how the spidev user-space interface is supposed to be used
when booting with Device Trees.
OK. Please don't take my comments as a NAK on this patch. I should
have done the same grep myself before sending--sorry. I just
Hello Mark,
On 11/19/2014 06:47 PM, Mark Brown wrote:
These are bugs. The device tree should describe the hardware, spidev is
a Linux implementation detail. Provide a compatible string for the
device that is there just as you would for any other device.
Thanks a lot for your explanation.
Hello Alan,
Thanks a lot for your feedback.
On 11/18/2014 06:00 PM, One Thousand Gnomes wrote:
+#ifdef CONFIG_COMPAT
+struct compat_cros_ec_command {
+uint32_t version;
+uint32_t command;
+compat_uptr_t outdata;
+uint32_t outsize;
+compat_uptr_t indata;
+uint32_t
Hello Olof,
On 11/19/2014 09:45 PM, Olof Johansson wrote:
Is true that this is a new API for mainline but there is a lot of ChromeOS
installations that depends on this API which means that just replacing the
kernel with a mainline one there, will break existing user-space programs.
I think
Hello Lee,
Thanks a lot for your feedback.
On 11/18/2014 03:18 PM, Lee Jones wrote:
+config MFD_CROS_EC_DEV
_DEV as a post-fix doesn't really describe the driver.
the _DEV is meant to denote (user-space device interface) but is true that
a better name can be used, I'll see what I can
Hello Lee,
On 11/18/2014 03:26 PM, Lee Jones wrote:
On Mon, 17 Nov 2014, Javier Martinez Canillas wrote:
From: Bill Richardson wfric...@chromium.org
This adds the first few sysfs attributes for the Chrome OS EC. These
controls are made available under /sys/devices/virtual/chromeos/cros_ec
Hello Lee,
On 11/18/2014 03:22 PM, Lee Jones wrote:
---
drivers/mfd/Makefile | 2 +-
drivers/mfd/cros_ec_dev.c | 2 +
drivers/mfd/cros_ec_dev.h | 3 +
drivers/mfd/cros_ec_lightbar.c | 347
+
By the sounds of the
Hello Lee,
On 11/20/2014 12:58 PM, Lee Jones wrote:
the printk.h header? to use the pr_* functions but I'll make sure that only
the needed headers are included.
Right, I think don't think you should be using those on a platform device.
Yes, I'll use dev_err() instead.
I prefer macros if
Hello,
On Thu, Nov 20, 2014 at 1:54 PM, Arnd Bergmann a...@arndb.de wrote:
On Monday 17 November 2014, Soren Brinkmann wrote:
This allows booting the kernel with systemd-based root file systems.
Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com
---
Hi,
I don't know whether I'm the
Hello Lee,
On 11/20/2014 02:27 PM, Lee Jones wrote:
By the sounds of the description, it doesn't seem as though this
driver lives in MFD. I suggest another home, such as drivers/led.
You are right. As I said in the other email, I'll move it to
drivers/platform/chrome/ which seems like
Hello Mike,
On 09/09/2014 10:57 PM, Mike Turquette wrote:
Quoting Javier Martinez Canillas (2014-09-07 23:49:28)
Since we are in 3.17-rc4 already, I'm afraid that this series may miss
3.18 again, is there anything else you need from me to pick this
series? It will obviously conflict
Hello Doug,
On 09/10/2014 06:42 AM, Doug Anderson wrote:
+
+ ldo35_reg: LDO35 {
+ regulator-name = ldo_35;
+ regulator-min-microvolt = 120;
+ regulator-max-microvolt = 120;
Hello Doug,
On 09/10/2014 06:45 AM, Doug Anderson wrote:
Reviewed-by: Doug Anderson diand...@chromium.org
Meant to add this to the v2. Sorry for the spam...
No worries, I've to re-spin anyways to fix the issue you pointed on Patch #1
so I'll include your Reviewed-by tag.
Best regards,
Hello Doug,
On 09/10/2014 06:52 AM, Doug Anderson wrote:
I would note that the downstream dts file has this i2c bus at 400kHz.
...but that's not a problem with your patch. Perhaps you could submit
that as a separate patch?
Indeed, I've to re-spin anyways so I'll include that on the next
From: Rahul Sharma rahul.sha...@samsung.com
Adding regulators for HDMI for Peach-pi board.
Signed-off-by: Rahul Sharma rahul.sha...@samsung.com
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed
Martinez Canillas javier.marti...@collabora.co.uk
---
arch/arm/configs/exynos_defconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/configs/exynos_defconfig
b/arch/arm/configs/exynos_defconfig
index 676c744..fbbac06 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm
-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Doug Anderson diand...@chromium.org
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 6 ++
arch/arm/boot/dts/exynos5800-peach-pi.dts | 6 ++
2 files changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts
by
Andreas Faerber.
The series is composed of the following patches:
Javier Martinez Canillas (3):
ARM: dts: Add Peach Pit and Pi dts entry for max77802 PMIC
ARM: dts: Add Peach Pit and Pi dts entry for ISL29018 sensor
ARM: dts: Set i2c7 clock at 400kHz for Peach boards
Naveen Krishna Chatradhi (1
The downstream ChromeOS 3.8 kernel sets the clock frequency
for the I2C bus 7 at 400kHz. Do the same change in mainline.
Suggested-by: Doug Anderson diand...@chromium.org
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 1
...@samsung.com
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Doug Anderson diand...@chromium.org
---
arch/arm/boot/dts/cros-adc-thermistors.dtsi | 44 +
arch/arm/boot/dts/exynos5420-peach-pit.dts | 6
arch/arm/boot/dts
From: Rahul Sharma rahul.sha...@samsung.com
Adding regulators for hdmi for peach-pit board.
Signed-off-by: Rahul Sharma rahul.sha...@samsung.com
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed
in the
the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Tested-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
Reviewed-by: Doug Anderson diand...@chromium.org
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 371
-by: Sjoerd Simons sjoerd.sim...@collabora.co.uk
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v3:
- Use KEY_RESERVED even for not reserved pins with a GPIO not hooked.
Suggested by Nick Dyer.
- Add a comment to specify the maXTouch chip version so is more
to be merged
through the linux-samsung tree. I'll post a separate series
to sync exynos_defconfig and multi_v7_defconfig so those can
be picked through the arm-soc tree.
This series must be merged after [0] to avoid merge conflicts.
Javier Martinez Canillas (2):
ARM: dts: Add Peach Pi dts entry
501 - 600 of 6991 matches
Mail list logo
