On Sun, Apr 27, 2014 at 12:29 PM, Julia Lawall wrote:
>
>
> On Sun, 27 Apr 2014, Javier Martinez Canillas wrote:
>
>> Using the BIT() macro instead of manually shifting bits
>> makes the code less error prone and also more readable.
>>
>> Signed-off-by: Javie
Using the BIT() macro instead of manually shifting bits
makes the code less error prone.
If is more readable is a matter of taste so only replace
if the file is already using this macro.
Signed-off-by: Javier Martinez Canillas
---
Changes since v1:
- Add a rule that checks if the file is
Hello Lars,
On Tue, Apr 29, 2014 at 6:18 PM, Lars-Peter Clausen wrote:
> On 04/27/2014 12:50 PM, Javier Martinez Canillas wrote:
>>
>> Using the BIT() macro instead of manually shifting bits
>> makes the code less error prone.
>>
>> If is more readable is a matt
On Tue, May 13, 2014 at 2:53 PM, Tom Rini wrote:
> On 05/12/2014 04:57 PM, Robert Nelson wrote:
Either case if fine with me. As who knows when the dtc "overlay" will
every truly make it mainline, as the capemgr was the only real kernel
user of the i2c/at24 eeprom information.
>>>
>
On Tue, May 13, 2014 at 4:22 PM, Matt Porter wrote:
> On Tue, May 13, 2014 at 04:06:02PM +0200, Javier Martinez Canillas wrote:
>> On Tue, May 13, 2014 at 2:53 PM, Tom Rini wrote:
>> > On 05/12/2014 04:57 PM, Robert Nelson wrote:
>> >>>> Either case if fine
Hello Pantelis,
On Tue, May 13, 2014 at 7:07 PM, Pantelis Antoniou
wrote:
> Hi Javier,
>
> On May 13, 2014, at 7:39 AM, Javier Martinez Canillas wrote:
>
>> On Tue, May 13, 2014 at 4:22 PM, Matt Porter wrote:
>>> On Tue, May 13, 2014 at 04:06:02PM +0200, Javier Marti
Hello Jhon,
On Wed, May 14, 2014 at 7:44 AM, John Syn wrote:
>
> On 5/13/14, 8:39 PM, "Pantelis Antoniou"
> wrote:
>
>>Hi John,
>>
>>On May 13, 2014, at 1:24 PM, John Syn wrote:
>>
>>>
>>> On 5/13/14, 10:51 AM, "Javier Mar
ality.
So this is an RFC patch-set to add a virtual table to be used by
GPIO chip controllers and consist of the following patches:
Javier Martinez Canillas (5):
gpio: add a vtable to abstract GPIO controller operations
gpiolib: set gpio_chip operations on add using a gpio_chip_ops
gpio:
: Javier Martinez Canillas
---
drivers/gpio/gpiolib.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 761013f..f0cc93a 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1188,6 +1188,25 @@ int gpiochip_add
All GPIO controller drivers have been migrated to use the struct
gpio_chip_ops virtual function table so the embeddeded function
pointers in struct gpio_chip can now be removed.
Signed-off-by: Javier Martinez Canillas
---
drivers/gpio/gpiolib.c | 83
pointers in
the object but there are some advantages on using the former approach.
This patch adds a struct gpio_chip_ops to be set by GPIO chip controllers.
Signed-off-by: Javier Martinez Canillas
---
include/linux/gpio/driver.h | 47 +
1 file changed
The GPIO controller operations has been split to be stored
on a separate struct gpio_chip_ops virtual function table.
Signed-off-by: Javier Martinez Canillas
---
drivers/gpio/gpio-twl4030.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-twl4030
The GPIO controller operations has been split to be stored
on a separate struct gpio_chip_ops virtual function table.
Signed-off-by: Javier Martinez Canillas
---
drivers/gpio/gpio-omap.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/gpio/gpio
Hello Alexandre,
Thanks a lot for your feedback.
On 04/10/2014 09:36 AM, Alexandre Courbot wrote:
> On Wed, Apr 9, 2014 at 3:20 AM, Javier Martinez Canillas
> wrote:
>> In the kernel there are basically two patterns to implement object
>> oriented code in C. You can either
Hello Andy,
On Thu, Apr 10, 2014 at 1:00 PM, Andy Shevchenko
wrote:
> On Thu, 2014-04-10 at 11:34 +0200, Javier Martinez Canillas wrote:
>> On 04/10/2014 09:36 AM, Alexandre Courbot wrote:
>> >
>> > "Since having the operations" maybe?
>> >
>&
Hello Doug,
On 06/17/2014 10:57 PM, Doug Anderson wrote:
> Javier,
>
> On Mon, Jun 16, 2014 at 11:02 AM, Javier Martinez Canillas
> wrote:
>> @@ -127,15 +175,48 @@ static int max77686_i2c_probe(struct i2c_client *i2c,
>> }
>> i2c_set_clie
ver added by Simon
>> Glass to the Chrome OS kernel 3.8 tree.
>>
>> Signed-off-by: Javier Martinez Canillas
>> ---
>>
>> Changes since v1:
>> - Remove unneeded check if num_regulators != MAX77802_MAX_REGULATORS.
>> - Fix .set_suspend_mode handler
Hello Lee,
On 06/18/2014 10:32 AM, Lee Jones wrote:
>> >> +config MFD_MAX77802
>> >> + tristate "Maxim Integrated MAX77802 PMIC Support"
>> >> + depends on I2C=y
>> >> + select MFD_CORE
>> >> + select REGMAP_I2C
>> >> + select REGMAP_IRQ
>> >> + select IRQ_DOMAIN
>> >> + help
>> >> + Say yes her
From: Doug Anderson
The max77686 includes an RTC that keeps power during suspend. It's
convenient to be able to use it as a wakeup source.
Signed-off-by: Doug Anderson
---
drivers/rtc/rtc-max77686.c | 28
1 file changed, 28 insertions(+)
diff --git a/drivers/rtc/
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
This patch adds support for the RTC and is based on a driver
added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas
---
drivers/rtc/Kconfig| 10 +
drivers/rtc/Makefile | 1
ks outputs.
Also, explain that the clocks identifiers are defined in a
header file that can be included by Device Tree source with
client nodes to avoid using magic numbers.
Signed-off-by: Javier Martinez Canillas
---
.../devicetree/bindings/clock/maxim,max77686.txt | 15 ++---
Clocks drivers for Maxim PMIC are very similar so they can
be converted to use the generic Maxim clock driver.
Also, while being there use module_platform_driver() helper
macro to eliminate more boilerplate code.
Signed-off-by: Javier Martinez Canillas
---
drivers/clk/Kconfig| 1
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout
(LDO) regulators. This patch adds support for all these regulators
found on the MAX77802 PMIC and is based on a driver added by Simon
Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas
---
Changes
Add Device Tree binding documentation for Maxim 77802 PMIC.
Signed-off-by: Javier Martinez Canillas
---
Changes since v2:
- Explain better the Dynamic Voltage Scaling (DVS) support in some Buck
regulators and the max77802,pmic-buck-{dvs,selb}-gpios properties.
Suggested by Mark Brown
-by: Javier Martinez Canillas
---
Changes since v2: None
Changes since v1:
- Use "regulators" for child node instead of "voltage-regulators" to be
consistent with other PMIC. Suggested by Mark Brown.
- Use regulators node names instead of the deprecated "regulato
Add Device Tree binding documentation for the clocks
outputs in the Maxim 77802 Power Management IC.
Signed-off-by: Javier Martinez Canillas
---
Changes since v2:
- Split the DT binding documentation in a separate patch.
.../devicetree/bindings/clock/maxim,max77802.txt | 42
The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with
Low Jitter Mode. This patch adds support for these two clocks.
Signed-off-by: Javier Martinez Canillas
---
Changes since v2: None
Changes since v1:
- Use module_platform_driver() instead of having init/exit functions
, clocks outputs and the RTC.
This patch adds the core support for MAX77802 PMIC and is based
on a driver added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas
---
Changes since v2:
- Split the DT binding docs in a separate patch and improve the
holding the regmap lock.
Signed-off-by: Javier Martinez Canillas
---
drivers/base/regmap/regmap.c | 34 ++
include/linux/regmap.h | 9 +
2 files changed, 43 insertions(+)
diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index
Maxim Integrated Power Management ICs are very similar with
regard to their clock outputs. Most of the clock drivers for
these chips are duplicating code and are simpler enough that
can be converted to use a generic driver to consolidate code
and avoid duplication.
Signed-off-by: Javier Martinez
This patch adds a dt-binding include for Maxim 77686
PMIC clock IDs that can be to be shared between the
clk-max77686 clock driver and DeviceTree source files.
Signed-off-by: Javier Martinez Canillas
---
drivers/clk/clk-max77686.c | 7 +--
include/dt-bindings/clock/maxim
interface.
The patch-set has been tested on both Daisy/Snow (max77686) and Peach
pit (max77802) Chromebooks and it's composed of the following patches:
Doug Anderson (1):
mfd: max77686: Allow the max77686 rtc to wakeup the system
Javier Martinez Canillas (13):
mfd: max77686: Convert to use regma
By using the generic IRQ support in the Register map API, it
is possible to get rid max77686-irq.c and simplify the code.
Suggested-by: Krzysztof Kozlowski
Signed-off-by: Javier Martinez Canillas
Acked-by: Lee Jones
Reviewed-by: Doug Anderson
Tested-by: Doug Anderson
---
Changes since v2
Hello Andreas,
On Fri, Jul 18, 2014 at 7:20 PM, Andreas Färber wrote:
>
> + memory {
> + reg = <0x4000 0x8000>;
> + };
> +
> + chosen {
> + };
> +
Is there a reason for an empty chosen node? Same for the Spring DTS.
Best regards,
Javier
--
To unsubs
Hello Doug,
On Fri, Jul 25, 2014 at 6:43 PM, Doug Anderson wrote:
> Javier,
>
> On Fri, Jul 25, 2014 at 9:35 AM, Javier Martinez Canillas
> wrote:
>> Hello Andreas,
>>
>> On Fri, Jul 18, 2014 at 7:20 PM, Andreas Färber wrote:
>>>
>>> +
Hello Mike,
On 07/26/2014 12:31 AM, Mike Turquette wrote:
> Quoting Javier Martinez Canillas (2014-07-14 04:35:56)
>> This series are based on drivers added by Simon Glass to the Chrome OS
>> kernel and adds support for the Maxim 77802 Power Management IC, their
>> regulators
Hello Rob,
On Fri, Jul 11, 2014 at 12:03 PM, Rob Jones wrote:
>
>
> On 11/07/14 01:35, Javier Martinez Canillas wrote:
>>
>> Hello Rob,
>>
>> On Thu, Jul 10, 2014 at 1:01 PM, Rob Jones
>> wrote:
>
>
>
>
>
>>>
>>> I will
Hello Tomasz,
On 07/11/2014 11:43 AM, Tomasz Figa wrote:
> Hi Javier,
>
> On 11.07.2014 03:45, Javier Martinez Canillas wrote:
>> On 07/10/2014 11:59 AM, amit daniel kachhap wrote:
>>> On Sat, Jul 5, 2014 at 1:54 AM, Javier Martinez Canillas
>>> wrote:
>
This series are based on drivers added by Simon Glass to the Chrome OS
kernel and adds support for the Maxim 77802 Power Management IC, their
regulators, clocks, RTC and i2c interface.
This is a v8 of the patch-set that addresses issues pointed out in v7.
Individual changes are added on each patch
Add Device Tree binding documentation for Maxim 77802 PMIC.
Signed-off-by: Javier Martinez Canillas
---
Changes since v7:
- Remove information about DVS since that will be added as a follow up.
Changes since v6: None
Changes since v5:
- Use max77686,* properties instead of max77802,* since
Add Device Tree binding documentation for the clocks
outputs in the Maxim 77802 Power Management IC.
Signed-off-by: Javier Martinez Canillas
---
Changes since v6: None
Changes since v5:
- Fix typo error in DT binding. Suggested by Andreas Farber.
- Add "clock-output-names" as a
.
Signed-off-by: Javier Martinez Canillas
Tested-by: Naveen Krishna Chatradhi
---
Changes since v7:
- Change Buck2 and 3 regulator name to "vdd_arm" and "vdd_int".
Suggested by Naveen Krishna Chatradhi.
- Remove DVS properties since this is going to be added as a follow u
This patch adds a dt-binding include for Maxim 77686
PMIC clock IDs that can be used by both the max77686
clock driver and Device Tree source files.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
Reviewed-by: Mike Turquette
---
Changes since v6: None
Changes since
, clocks outputs and the RTC.
This patch adds support for MAX77802 to the MAX77686 driver and is
based on a driver added to the Chrome OS kernel 3.8 by Simon Glass.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
Acked-by: Lee Jones
---
Changes since v7:
- Don't a
Clocks drivers for Maxim PMIC are very similar so they can
be converted to use the generic Maxim clock driver.
Also, while being there use module_platform_driver() helper
macro to eliminate more boilerplate code.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
This patch adds support for the RTC and is based on a driver
added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
---
Changes since v6:
- Remove unused code
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout
(LDO) regulators. This patch adds support for all these regulators
found on the MAX77802 PMIC and is based on a driver added by Simon
Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas
Tested-by: Naveen
up before the max77686 wakeup runs.
Signed-off-by: Doug Anderson
Reviewed-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
---
Changes since v6: None
Changes since v5:
- Fix $SUBJECT since the patch does not actually touch the mfd subsys.
Suggested by Lee Jones.
Changes sinc
driver was original merged in
commit fca1dd03 ("rtc: max77686: add Maxim 77686 driver").
So, since this code has never been built, let's just remove it.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
---
drivers/rtc/rtc-m
Maxim Integrated Power Management ICs are very similar with
regard to their clock outputs. Most of the clock drivers for
these chips are duplicating code and are simpler enough that
can be converted to use a generic driver to consolidate code
and avoid duplication.
Signed-off-by: Javier Martinez
ks outputs.
Also, explain that the clocks identifiers are defined in a
header file that can be included by Device Tree source with
client nodes to avoid using magic numbers.
Finally, add "clock-output-names" as an optional property
since now is supported by the clock driver.
Signed-off
The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with
Low Jitter Mode. This patch adds support for these two clocks.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
---
Changes since v6: None
Changes since v5: None
Changes since v4: None
Changes since v3
Hello Lee,
Thanks a lot for your feedback.
On 07/01/2014 05:15 PM, Lee Jones wrote:
> On Thu, 26 Jun 2014, Javier Martinez Canillas wrote:
>
>> Maxim MAX77802 is a power management chip that contains 10 high
>> efficiency Buck regulators, 32 Low-dropout (LDO) regulators u
Hello Mike,
On Wed, Jul 2, 2014 at 6:33 AM, Mike Turquette wrote:
> Quoting Peter Ujfalusi (2014-06-29 22:56:55)
>> Hi Javier,
>>
>> On 06/27/2014 09:23 PM, Javier Martinez Canillas wrote:
>> > Hello Peter,
>> >
>> > On Fri, Jun 27, 2014 at 8:
Hello Tushar,
Thanks a lot for your feedback.
On 07/02/2014 11:20 AM, Tushar Behera wrote:
> On 06/26/2014 11:45 PM, Javier Martinez Canillas wrote:
>> Peach pit and pi boards uses a Maxim 77802 power management
>> IC to drive regulators and its Real Time Clock. This patch
>
Hello Mike,
On 07/01/2014 07:26 PM, Mike Turquette wrote:
> Quoting Yadwinder Singh Brar (2014-06-29 21:01:36)
>> Hi Javier,
>>
>> On Thu, Jun 26, 2014 at 11:45 PM, Javier Martinez Canillas
>> wrote:
>> > Maxim Integrated Power Management ICs are very sim
Hello Mike,
On 07/01/2014 07:29 PM, Mike Turquette wrote:
> Quoting Javier Martinez Canillas (2014-06-26 11:15:36)
>> Like most clock drivers, the Maxim 77686 PMIC clock binding
>> follows the convention that the "#clock-cells" property is
>> used to specify
On Thu, Jul 3, 2014 at 6:06 PM, Sebastian Reichel wrote:
> Hi,
>
> On Thu, Jul 03, 2014 at 10:52:40AM -0500, Felipe Balbi wrote:
>> > DT is supposed to contain information about the hardware, so it
>> > should stay the same? I think there is no non-hackish way to decide
>>
>> compatible would chan
Hello Krzysztof,
Thanks a lot for your feedback.
On 06/26/2014 11:31 AM, Krzysztof Kozlowski wrote:
> Hi,
>
> Just a few nit-picks below but overall everything looks fine:
>
> Reviewed-by: Krzysztof Kozlowski
>
>
>> +
>> +static int max77802_i2c_probe(struct i2c_client *i2c,
>> +
Hello Krzysztof,
Thanks a lot for your feedback.
On 06/26/2014 12:08 PM, Krzysztof Kozlowski wrote:
> On śro, 2014-06-25 at 21:03 +0200, Javier Martinez Canillas wrote:
>> The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout
>> (LDO) regulators. This patch adds suppor
Hello Yadwinder,
Thanks a lot for your feedback.
On 06/26/2014 01:51 PM, Yadwinder Singh Brar wrote:
> Hi Javier,
>
> Sorry for jumping in late, but just one concern mentioned inline.
>
> [ .. ]
>
>> +
>> +static unsigned long max_gen_recalc_rate(struct clk_hw *hw,
>> +
Hello Naveen,
Thanks a lot for testing!
On 06/26/2014 03:32 PM, Naveen Krishna Ch wrote:
> Hello Javier,
>
> On 26 June 2014 00:33, Javier Martinez Canillas
> wrote:
>> MAX77802 is a PMIC that contains 10 high efficiency Buck regulators,
>> 32 Low-dropout (LDO) regula
Hello Naveen,
On Thu, Jun 26, 2014 at 2:19 PM, Naveen Krishna Chatradhi
wrote:
> This patchset does the following
> 1. Create a common dtsi file cros-exynos-peach.dtsi for
>exynos5420-peach-pit.dts and exynos5800-peach-pi.dts
There was some previous discussion in this list about what's the b
Hello Doug,
On 06/26/2014 06:12 PM, Doug Anderson wrote:
> Javier,
>
> On Thu, Jun 26, 2014 at 4:13 AM, Javier Martinez Canillas
> wrote:
>>>> +
>>>> +#ifdef CONFIG_PM_SLEEP
>>>> +static int max77802_suspend(struct device *dev)
>>>> +{
Hello Doug,
On 06/26/2014 06:29 PM, Doug Anderson wrote:
> Javier,
>
> On Thu, Jun 26, 2014 at 9:18 AM, Javier Martinez Canillas
> wrote:
>> Hello Doug,
>>
>> On 06/26/2014 06:12 PM, Doug Anderson wrote:
>>> Javier,
>>>
>>> On Thu, Jun
By using the generic IRQ support in the Register map API, it
is possible to get rid max77686-irq.c and simplify the code.
Suggested-by: Krzysztof Kozlowski
Signed-off-by: Javier Martinez Canillas
Acked-by: Lee Jones
Reviewed-by: Doug Anderson
Tested-by: Doug Anderson
---
Changes since v4
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
This patch adds support for the RTC and is based on a driver
added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas
---
Changes since v4: None
Changes since v3: None
drivers/rtc/Kconfig
, clocks outputs and the RTC.
This patch adds the core support for MAX77802 PMIC and is based
on a driver added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
Tested-by: Naveen Krishna Chatradhi
---
Changes since v4:
- Use
Clocks drivers for Maxim PMIC are very similar so they can
be converted to use the generic Maxim clock driver.
Also, while being there use module_platform_driver() helper
macro to eliminate more boilerplate code.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
Add Device Tree binding documentation for Maxim 77802 PMIC.
Signed-off-by: Javier Martinez Canillas
---
Changes since v4: None
Changes since v3: None
Changes since v2:
- Explain better the Dynamic Voltage Scaling (DVS) support in some Buck
regulators and the max77802,pmic-buck-{dvs,selb
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout
(LDO) regulators. This patch adds support for all these regulators
found on the MAX77802 PMIC and is based on a driver added by Simon
Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas
Tested-by: Naveen
.
Signed-off-by: Javier Martinez Canillas
Tested-by: Naveen Krishna Chatradhi
---
Changes since v4: None
Changes since v3:
- Add support for Exynos5800 based Peach pi board. Suggested by Doug Anderson.
- Model the actual regulators relationship instead of a simplistic model.
Suggested by Mark
Maxim Integrated Power Management ICs are very similar with
regard to their clock outputs. Most of the clock drivers for
these chips are duplicating code and are simpler enough that
can be converted to use a generic driver to consolidate code
and avoid duplication.
Signed-off-by: Javier Martinez
the regmap lock.
Signed-off-by: Javier Martinez Canillas
---
Changes since v4: None
Changes since v3: None
drivers/base/regmap/regmap.c | 34 ++
include/linux/regmap.h | 9 +
2 files changed, 43 insertions(+)
diff --git a/drivers/base/regmap
Add Device Tree binding documentation for the clocks
outputs in the Maxim 77802 Power Management IC.
Signed-off-by: Javier Martinez Canillas
---
Changes since v4: None
Changes since v3:
- Don't use the same clock driver name in clock-names since it's a consumer
concept and mos
The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with
Low Jitter Mode. This patch adds support for these two clocks.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
---
Changes since v4: None
Changes since v3: None
Changes since v2: None
Changes since v1
This patch adds a dt-binding include for Maxim 77686
PMIC clock IDs that can be to be shared between the
clk-max77686 clock driver and DeviceTree source files.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
---
Changes since v4: None
Changes since v3: None
drivers
up before the max77686 wakeup runs.
Signed-off-by: Doug Anderson
Reviewed-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
---
Changes since v4: None
Changes since v3:
- Keep the note that this patch needs another change due wakeup
ordering problems.
drivers/rtc/rtc-max77
ks outputs.
Also, explain that the clocks identifiers are defined in a
header file that can be included by Device Tree source with
client nodes to avoid using magic numbers.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
Reviewed-by: Doug Anderson
---
Changes sinc
oug Anderson (1):
mfd: max77686: Allow the max77686 rtc to wakeup the system
Javier Martinez Canillas (13):
mfd: max77686: Convert to use regmap_irq
clk: max77686: Add DT include for MAX77686 PMIC clock
clk: max77686: Improve Maxim 77686 PMIC clocks binding
clk: Add generic driver for Ma
Hello Andreas,
On 06/27/2014 09:48 AM, Andreas Färber wrote:
> Am 26.06.2014 20:15, schrieb Javier Martinez Canillas:
>> This patch adds a dt-binding include for Maxim 77686
>> PMIC clock IDs that can be to be shared between the
>
> "can be shared"?
>
As it s
Hello Andres,
Thanks a lot for your feedback.
On 06/27/2014 09:52 AM, Andreas Färber wrote:
> Am 26.06.2014 20:15, schrieb Javier Martinez Canillas:
>> Add Device Tree binding documentation for the clocks
>> outputs in the Maxim 77802 Power Management IC.
>>
>> Sig
Hello Andreas,
Thanks a lot for your feedback.
On 06/27/2014 10:06 AM, Andreas Färber wrote:
> Am 26.06.2014 20:15, schrieb Javier Martinez Canillas:
>> Add Device Tree binding documentation for Maxim 77802 PMIC.
>>
>> Signed-off-by: Javier Martinez Canillas
>>
Hello Andreas,
On 06/27/2014 10:26 AM, Andreas Färber wrote:
> Hi Javier,
>
> Am 27.06.2014 09:53, schrieb Javier Martinez Canillas:
>> Hello Andreas,
>>
>> On 06/27/2014 09:48 AM, Andreas Färber wrote:
>>> Am 26.06.2014 20:15, schrieb Javier Martinez Canilla
Hello Lee,
On 06/27/2014 11:21 AM, Lee Jones wrote:
> On Thu, 26 Jun 2014, Javier Martinez Canillas wrote:
>
>> From: Doug Anderson
>>
>> The max77686 includes an RTC that keeps power during suspend. It's
>> convenient to be able to use it as a wakeup
Hello Lee,
Thanks a lot for your feedback.
On 06/27/2014 11:26 AM, Lee Jones wrote:
> On Thu, 26 Jun 2014, Javier Martinez Canillas wrote:
>> The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout
>> (LDO) regulators. This patch adds support for all these regulators
Hello Peter,
On Fri, Jun 27, 2014 at 8:01 AM, Peter Ujfalusi wrote:
> Palmas class of devices can provide 32K clock(s) to be used by other devices
> on the board. Depending on the actual device the provided clocks can be:
> CLK32K_KG and CLK32K_KGAUDIO
> or only one:
> CLK32K_KG (TPS659039 for ex
Hello Yadwinder,
Thanks a lot for your feedback.
On 06/30/2014 06:01 AM, Yadwinder Singh Brar wrote:
> Hi Javier,
>
> On Thu, Jun 26, 2014 at 11:45 PM, Javier Martinez Canillas
> wrote:
>> Maxim Integrated Power Management ICs are very similar with
>> regard to their cl
Hello Russell,
Thanks a lot for your suggestion.
On 06/30/2014 01:35 PM, Russell King - ARM Linux wrote:
> On Mon, Jun 30, 2014 at 12:58:57PM +0200, Javier Martinez Canillas wrote:
>> >> + if (!max_gen->lookup)
>> >> + return ERR_PTR(-ENOMEM);
Hello Tushar,
On Tue, Jul 8, 2014 at 5:00 AM, Tushar Behera wrote:
>>>
>>> The u-boot version is a little different on my Peach-Pi as compared to
>>> the market release version. Not sure if that is making any difference.
>>>
>>> Peach # version
>>>
>>> U-Boot 2013.04 (Feb 13 2014 - 16:35:03) for
Hello Tushar,
On Wed, Jul 9, 2014 at 2:11 PM, Tushar Behera wrote:
> On 07/09/2014 03:44 PM, Javier Martinez Canillas wrote:
>> Hello Tushar,
>>
>> On Tue, Jul 8, 2014 at 5:00 AM, Tushar Behera wrote:
>>>>>
>>>>> The u-boot version is a littl
Hello Doug,
On Wed, Jul 9, 2014 at 6:01 PM, Doug Anderson wrote:
> Javier,
>
> On Wed, Jul 9, 2014 at 6:03 AM, Javier Martinez Canillas
> wrote:
>> Hello Tushar,
>>
>> On Wed, Jul 9, 2014 at 2:11 PM, Tushar Behera wrote:
>>> On 07/09/2014 03:44 PM, Jav
Hello Lee,
On 07/09/2014 04:52 PM, Lee Jones wrote:
> On Fri, 04 Jul 2014, Javier Martinez Canillas wrote:
>
>> The function max77802_i2c_parse_dt_pdata() should only be called
>> if there isn't already platform data for the device.
>>
>> Sign
Hello Lee,
Thanks a lot for your feedback.
On 07/09/2014 05:13 PM, Lee Jones wrote:
> I'd really like Linus Walleij to look over this if possible.
>
Ok, I'll cc Linus when posting the next version of the series.
> On Fri, 04 Jul 2014, Javier Martinez Canillas wrote:
>&g
Hello Lee,
On 07/09/2014 05:31 PM, Lee Jones wrote:
> On Fri, 04 Jul 2014, Javier Martinez Canillas wrote:
>> Maxim MAX77802 is a power management chip that contains 10 high
>> efficiency Buck regulators, 32 Low-dropout (LDO) regulators used
>> to power up application proce
Hello Rob,
On Thu, Jul 10, 2014 at 1:01 PM, Rob Jones wrote:
>
>
> On 10/07/14 10:21, Linus Walleij wrote:
>>
>> On Wed, Jul 9, 2014 at 1:18 PM, Rob Jones
>> wrote:
>>
>>> Please note that I submitted a patch on 02/07/14 to create this
>>> function which was acked by Linus Walleij on 05/07/14.
>
Hello Linus,
On 07/10/2014 11:46 AM, Linus Walleij wrote:
> On Fri, Jul 4, 2014 at 10:24 PM, Javier Martinez Canillas
> wrote:
>
>> Some regulators on the MAX77686 PMIC have Dynamic Voltage Scaling
>> (DVS) support that allows output voltage to change dynamically.
>
Hello Amit,
On 07/10/2014 11:59 AM, amit daniel kachhap wrote:
> On Sat, Jul 5, 2014 at 1:54 AM, Javier Martinez Canillas
> wrote:
>> Some regulators on the MAX77686 PMIC have Dynamic Voltage Scaling
>> (DVS) support that allows output voltage to change dynamically.
>>
Hello Amit,
On 07/10/2014 12:08 PM, amit daniel kachhap wrote:
> On Fri, Jul 4, 2014 at 3:25 PM, Javier Martinez Canillas
> wrote:
>> MAX77686 PMIC support Dyamic Voltage Scaling (DVS) on a set
>> of Buck regulators. A number of GPIO are connected to these
>> lines and
el.org/patch/4042751/> and the
> rest of the series has long since landed.
>
Looks good to me. Also since this patch makes optional to get an IRQ, the
following annoying message is not shown anymore:
[2.132944] tps65090-charger tps65090-charger: Unable to get charger irq = -6
Review
701 - 800 of 3499 matches
Mail list logo
