Re: [PATCH v2] net: dsa: ksz8795: adjust CPU link to host interface

2020-12-07 Thread Jean Pihet
Hi Andrew, On Tue, Dec 1, 2020 at 9:45 PM Andrew Lunn wrote: > > > Configure the host port of the switch to match the host interface > > settings. This is useful when the switch is directly connected to the > > host MAC interface. > > Why do you need this when no other board does? Why is your

Re: [PATCH v2] net: dsa: ksz8795: adjust CPU link to host interface

2020-12-07 Thread Jean Pihet
Hi Vladimir, On Tue, Dec 1, 2020 at 8:48 PM Vladimir Oltean wrote: > > Hi Jean, > > On Tue, Dec 01, 2020 at 07:58:01PM +0100, Jean Pihet wrote: > > Hi Andrew, > > > > On Tue, Dec 1, 2020 at 7:41 PM Andrew Lunn wrote: > > > > > > On Tue, De

Re: [PATCH v2] net: dsa: ksz8795: adjust CPU link to host interface

2020-12-01 Thread Jean Pihet
Hi Andrew, On Tue, Dec 1, 2020 at 7:41 PM Andrew Lunn wrote: > > On Tue, Dec 01, 2020 at 09:34:08AM +0100, Jean Pihet wrote: > > Add support for RGMII in 100 and 1000 Mbps. > > > > Adjust the CPU port settings from the host interface settings: interface > > MII ty

[PATCH v2] net: dsa: ksz8795: adjust CPU link to host interface

2020-12-01 Thread Jean Pihet
Add support for RGMII in 100 and 1000 Mbps. Adjust the CPU port settings from the host interface settings: interface MII type, speed, duplex. Signed-off-by: Jean Pihet --- drivers/net/dsa/microchip/ksz8795.c | 93 ++--- 1 file changed, 57 insertions(+), 36 deletions

Re: [PATCH 1/2] net: dsa: ksz: pad frame to 64 bytes for transmission

2020-11-29 Thread Jean Pihet
Andrew, On Sun, Nov 29, 2020 at 8:38 PM Andrew Lunn wrote: > > On Sun, Nov 29, 2020 at 08:34:27PM +0100, Jean Pihet wrote: > > Hi Andrew, > > > > On Sun, Nov 29, 2020 at 5:56 PM Andrew Lunn wrote: > > > > > > On Sun, Nov 29, 2020 at 11:23:59AM +010

Re: [PATCH 1/2] net: dsa: ksz: pad frame to 64 bytes for transmission

2020-11-29 Thread Jean Pihet
Andrew, On Sun, Nov 29, 2020 at 5:57 PM Andrew Lunn wrote: > > Hi Jean > > Please also include a patch 0/X which describes the patchset as a > whole. This will be used as the branch merge commit. Sure, will submit a v2 asap. Thx, Jean > >Andrew

Re: [PATCH 1/2] net: dsa: ksz: pad frame to 64 bytes for transmission

2020-11-29 Thread Jean Pihet
Hi Andrew, On Sun, Nov 29, 2020 at 5:56 PM Andrew Lunn wrote: > > On Sun, Nov 29, 2020 at 11:23:59AM +0100, Jean Pihet wrote: > > Some ethernet controllers (e.g. TI CPSW) pad the frames to a minimum > > of 64 bytes before the FCS is appended. This causes an issue with the >

[PATCH 2/2] net: dsa: ksz8795: adjust CPU link to host interface

2020-11-29 Thread Jean Pihet
Add support for RGMII in 100 and 1000 Mbps. Adjust the CPU port based on the host interface settings: interface MII type, speed, duplex. Signed-off-by: Jean Pihet --- drivers/net/dsa/microchip/ksz8795.c | 93 ++--- 1 file changed, 57 insertions(+), 36 deletions(-) diff

[PATCH 1/2] net: dsa: ksz: pad frame to 64 bytes for transmission

2020-11-29 Thread Jean Pihet
and the frame is passed for transmission. Signed-off-by: Jean Pihet --- net/dsa/tag_ksz.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/net/dsa/tag_ksz.c b/net/dsa/tag_ksz.c index 0a5aa982c60d..0074702dcbbc 100644 --- a/net/dsa/tag_ksz.c +++ b/net/dsa/tag_ksz.c

Re: [PATCH] tracing: Remove unused clock events

2017-10-13 Thread Jean Pihet
Hi Steven, On Thu, Oct 12, 2017 at 6:44 PM, Steven Rostedt wrote: > > [ Resending again, including linux...@vger.kernel.org this time ] > > From: Steven Rostedt (VMware) > > Commit 74704ac6 ("tracing, perf: Add more power related events") added > new

Re: [PATCH] tracing: Remove unused clock events

2017-10-13 Thread Jean Pihet
Hi Steven, On Thu, Oct 12, 2017 at 6:44 PM, Steven Rostedt wrote: > > [ Resending again, including linux...@vger.kernel.org this time ] > > From: Steven Rostedt (VMware) > > Commit 74704ac6 ("tracing, perf: Add more power related events") added > new events, among them were trace_clock_enable,

Re: [PATCH v5] arm64: perf: Fix callchain parse error with kernel tracepoint events

2015-05-20 Thread Jean Pihet
Hi Catalin, Will, On Tue, May 19, 2015 at 6:52 PM, Catalin Marinas wrote: > On Sun, May 10, 2015 at 11:07:40AM +, Hou Pengyang wrote: >> For ARM64, when tracing with tracepoint events, the IP and pstate are set >> to 0, preventing the perf code parsing the callchain and resolving the >>

Re: [PATCH v5] arm64: perf: Fix callchain parse error with kernel tracepoint events

2015-05-20 Thread Jean Pihet
Hi Catalin, Will, On Tue, May 19, 2015 at 6:52 PM, Catalin Marinas catalin.mari...@arm.com wrote: On Sun, May 10, 2015 at 11:07:40AM +, Hou Pengyang wrote: For ARM64, when tracing with tracepoint events, the IP and pstate are set to 0, preventing the perf code parsing the callchain and

Re: [PATCH 1/1] rasd: Use perf_evlist__open() instead of open coded

2014-10-14 Thread Jean Pihet
On 14 October 2014 17:17, Borislav Petkov wrote: > On Tue, Oct 14, 2014 at 04:22:13PM +0200, Jiri Olsa wrote: >> right.. is there more planned for RAS daemon to do? because at this >> point it looks to me more like new perf functionality (in trace or >> some other new command) >> >> > >> >

Re: [PATCH 1/1] rasd: Use perf_evlist__open() instead of open coded

2014-10-14 Thread Jean Pihet
On 14 October 2014 17:17, Borislav Petkov b...@alien8.de wrote: On Tue, Oct 14, 2014 at 04:22:13PM +0200, Jiri Olsa wrote: right.. is there more planned for RAS daemon to do? because at this point it looks to me more like new perf functionality (in trace or some other new command) Anyway,

Re: [PATCH 1/1] rasd: Use perf_evlist__open() instead of open coded

2014-10-13 Thread Jean Pihet
Hi Arnaldo, Borislav, On 10 October 2014 22:44, Borislav Petkov wrote: > On Fri, Oct 10, 2014 at 05:41:58PM -0300, Arnaldo Carvalho de Melo wrote: >> Right, stoopid me, no need for some specific tracepoint, just to see >> that whatever tp it is, it will show up in "rasd"'s event loop. Ok, I'll

Re: [PATCH 1/1] rasd: Use perf_evlist__open() instead of open coded

2014-10-13 Thread Jean Pihet
Hi Arnaldo, Borislav, On 10 October 2014 22:44, Borislav Petkov b...@alien8.de wrote: On Fri, Oct 10, 2014 at 05:41:58PM -0300, Arnaldo Carvalho de Melo wrote: Right, stoopid me, no need for some specific tracepoint, just to see that whatever tp it is, it will show up in rasd's event loop. Ok,

Re: [PATCH 1/1] rasd: Use perf_evlist__open() instead of open coded

2014-10-07 Thread Jean Pihet
Hi Arnaldo, On 6 October 2014 23:26, Arnaldo Carvalho de Melo wrote: > Heya, please check if this is OK. > > This was while looking the set of methods used by rasd, trying to reduce > it to the bare minimum. > > Perhaps even that cpu_map__new() one can be ditched, leaving to use the > default of

Re: [PATCH 1/1] rasd: Use perf_evlist__open() instead of open coded

2014-10-07 Thread Jean Pihet
Hi Arnaldo, On 6 October 2014 23:26, Arnaldo Carvalho de Melo a...@kernel.org wrote: Heya, please check if this is OK. This was while looking the set of methods used by rasd, trying to reduce it to the bare minimum. Perhaps even that cpu_map__new() one can be ditched, leaving to use the

Re: perf & rasd integration plan

2014-10-06 Thread Jean Pihet
Hi Arnaldo, On 6 October 2014 16:58, Arnaldo Carvalho de Melo wrote: > Em Mon, Oct 06, 2014 at 11:07:26AM +0200, Robert Richter escreveu: >> On 30.09.14 10:24:16, Arnaldo Carvalho de Melo wrote: >> > Em Tue, Sep 30, 2014 at 11:06:21AM +0200, Jean Pihet escreveu: >>

Re: perf & rasd integration plan

2014-10-06 Thread Jean Pihet
Hi, On 6 October 2014 11:07, Robert Richter wrote: > On 30.09.14 10:24:16, Arnaldo Carvalho de Melo wrote: >> Em Tue, Sep 30, 2014 at 11:06:21AM +0200, Jean Pihet escreveu: >> > The plan is to move the small and generic functions first: util, >> > xyarray, cpumap,

Re: perf & rasd integration plan

2014-10-06 Thread Jean Pihet
Hi Jiri, On 5 October 2014 20:24, Jiri Olsa wrote: > On Sun, Oct 05, 2014 at 07:48:01PM +0200, Borislav Petkov wrote: >> Top-posting on purpose: >> >> Btw, jolsa, if you get your LCE proposal for the perf splitting >> approved, please post the time here so people can come. > > yep, it got

Re: perf rasd integration plan

2014-10-06 Thread Jean Pihet
Hi Jiri, On 5 October 2014 20:24, Jiri Olsa jo...@redhat.com wrote: On Sun, Oct 05, 2014 at 07:48:01PM +0200, Borislav Petkov wrote: Top-posting on purpose: Btw, jolsa, if you get your LCE proposal for the perf splitting approved, please post the time here so people can come. yep, it got

Re: perf rasd integration plan

2014-10-06 Thread Jean Pihet
Hi, On 6 October 2014 11:07, Robert Richter r...@kernel.org wrote: On 30.09.14 10:24:16, Arnaldo Carvalho de Melo wrote: Em Tue, Sep 30, 2014 at 11:06:21AM +0200, Jean Pihet escreveu: The plan is to move the small and generic functions first: util, xyarray, cpumap, thread_map etc

Re: perf rasd integration plan

2014-10-06 Thread Jean Pihet
Hi Arnaldo, On 6 October 2014 16:58, Arnaldo Carvalho de Melo a...@kernel.org wrote: Em Mon, Oct 06, 2014 at 11:07:26AM +0200, Robert Richter escreveu: On 30.09.14 10:24:16, Arnaldo Carvalho de Melo wrote: Em Tue, Sep 30, 2014 at 11:06:21AM +0200, Jean Pihet escreveu: The plan is to move

perf & rasd integration plan

2014-09-30 Thread Jean Pihet
The RAS Deamon (rasd) as available at [1] and the development version at [2], allows to enable kernel tracepoints and outputs the tracepoints fields according to the kernel format. [1] https://git.kernel.org/cgit/utils/ras/rasd.git/ [2] https://git.linaro.org/people/jean.pihet/rasd.git rasd

perf rasd integration plan

2014-09-30 Thread Jean Pihet
The RAS Deamon (rasd) as available at [1] and the development version at [2], allows to enable kernel tracepoints and outputs the tracepoints fields according to the kernel format. [1] https://git.kernel.org/cgit/utils/ras/rasd.git/ [2] https://git.linaro.org/people/jean.pihet/rasd.git rasd

Re: [PATCH] perf tools: fix build breakage on arm and arm64 targets

2014-09-29 Thread Jean Pihet
Hi Will, On 26 September 2014 19:19, Sudeep Holla wrote: > > On 26/09/14 18:01, Will Deacon wrote: >> >> Attempting to build the perf tool on arm or arm64 targets results in the >> following failure: >> >> arch/arm/util/unwind-libunwind.c: In function ‘libunwind__arch_reg_id’: >>

Re: [PATCH] perf tools: fix build breakage on arm and arm64 targets

2014-09-29 Thread Jean Pihet
Hi Will, On 26 September 2014 19:19, Sudeep Holla sudeep.ho...@arm.com wrote: On 26/09/14 18:01, Will Deacon wrote: Attempting to build the perf tool on arm or arm64 targets results in the following failure: arch/arm/util/unwind-libunwind.c: In function ‘libunwind__arch_reg_id’:

Re: [PATCH 2/2] perf callchain: Use global caching provided by libunwind

2014-09-26 Thread Jean Pihet
Hi, On 26 September 2014 07:50, Namhyung Kim wrote: > Hi Jean, > > On Wed, 24 Sep 2014 15:45:57 +0200, Jean Pihet wrote: >> Hi! >> >> Here are the test results on ARMv7 for the 2 patches. The speedup is >> about x2.1 for identical unwinding output data. >

Re: [PATCH 2/2] perf callchain: Use global caching provided by libunwind

2014-09-26 Thread Jean Pihet
Hi, On 26 September 2014 07:50, Namhyung Kim namhy...@kernel.org wrote: Hi Jean, On Wed, 24 Sep 2014 15:45:57 +0200, Jean Pihet wrote: Hi! Here are the test results on ARMv7 for the 2 patches. The speedup is about x2.1 for identical unwinding output data. 'perf record --call-graph dwarf

Re: [PATCH 2/2] perf callchain: Use global caching provided by libunwind

2014-09-24 Thread Jean Pihet
s definitely speedup the unwinding. FWIW: Acked-by: Jean Pihet For info unwinding using libdw is about 5x faster: time perf.libdw.speedup report --sort symbol --call-graph --stdio 2&>1 > /dev/null real0m3.484s user0m2.360s sys0m1.070s Thanks, Jean On 24 September 2014 04:24,

Re: [PATCH 2/2] perf callchain: Use global caching provided by libunwind

2014-09-24 Thread Jean Pihet
. FWIW: Acked-by: Jean Pihet jean.pi...@linaro.org For info unwinding using libdw is about 5x faster: time perf.libdw.speedup report --sort symbol --call-graph --stdio 21 /dev/null real0m3.484s user0m2.360s sys0m1.070s Thanks, Jean On 24 September 2014 04:24, Namhyung Kim namhy

Re: [PATCH 1/1] tools/perf: add missing include debug.h for arm/arm64

2014-09-23 Thread Jean Pihet
esh the patch for ARM64 only? FWIW: Acked-by: Jean Pihet Thanks! > commit 84f5d36f4 (move pr_* debug macros into debug object): > > arch/arm/util/unwind-libunwind.c: In function 'libunwind__arch_reg_id': > arch/arm/util/unwind-libunwind.c:43:3: error: implicit declaration > o

Re: [PATCH 1/1] tools/perf: add missing include debug.h for arm/arm64

2014-09-23 Thread Jean Pihet
. Can you refresh the patch for ARM64 only? FWIW: Acked-by: Jean Pihet jean.pi...@linaro.org Thanks! commit 84f5d36f4 (move pr_* debug macros into debug object): arch/arm/util/unwind-libunwind.c: In function 'libunwind__arch_reg_id': arch/arm/util/unwind-libunwind.c:43:3: error: implicit

[PATCH 0/3] ARM: perf: allow tracing with kernel tracepoints events

2014-07-07 Thread Jean Pihet
), with unwinding using fp (--call-graph fp) and dwarf info (--call-graph dwarf). Jean Pihet (3): ARM: perf: Check that current->mm is alive before getting user callchain ARM: perf: disable the pagefault handler when reading from user space ARM: perf: allow tracing with kernel tracepoi

[PATCH 3/3] ARM: perf: allow tracing with kernel tracepoints events

2014-07-07 Thread Jean Pihet
riya on linaro-dev, cf. http://lists.linaro.org/pipermail/linaro-dev/2014-May/017151.html Signed-off-by: Jean Pihet Cc: Will Deacon Cc: Steve Capper Reported-by: Sneha Priya --- arch/arm/include/asm/perf_event.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/arch/arm/inc

[PATCH 2/3] ARM: perf: disable the pagefault handler when reading from user space

2014-07-07 Thread Jean Pihet
00 ebc08000 5b00: 007e ed7c4000 ed7c5b94 0014 ed7c5b2c c001a438 c0236c60 5b20: 0013 [] (__dabt_svc) from [] (__copy_from_user+0xa4/0x3a4) Signed-off-by: Jean Pihet Cc: Will Deacon Acked-by: Steve Capper --- arch/arm/kernel/perf_event.c | 9 +++-- 1

[PATCH 1/3] ARM: perf: Check that current->mm is alive before getting user callchain

2014-07-07 Thread Jean Pihet
An event may occur when an mm is already released. As per commit 20afc60f892d285fde179ead4b24e6a7938c2f1b 'x86, perf: Check that current->mm is alive before getting user callchain' Signed-off-by: Jean Pihet Cc: Will Deacon Acked-by: Will Deacon --- arch/arm/kernel/perf_event.c | 4

Re: [PATCH 3/3] ARM: perf: allow tracing with kernel tracepoints events

2014-07-07 Thread Jean Pihet
Will, On 3 July 2014 19:54, Will Deacon wrote: > On Fri, Jun 27, 2014 at 03:57:47PM +0100, Jean Pihet wrote: >> When tracing with tracepoints events the IP and CPSR are set to 0, >> preventing the perf code to resolve the symbols: >> >> ./perf record -e kmem:kmalloc

Re: [PATCH 2/3] ARM: perf: disable the pagefault handler when reading from user space

2014-07-07 Thread Jean Pihet
Hi Will, On 3 July 2014 19:52, Will Deacon wrote: > Hi Jean, > > On Fri, Jun 27, 2014 at 03:57:46PM +0100, Jean Pihet wrote: >> As done on other architectures (ARM64, x86, Sparc etc.). >> >> This prevents a deadlock on down_read in do_page_fault when unwinding

Re: [PATCH 2/3] ARM: perf: disable the pagefault handler when reading from user space

2014-07-07 Thread Jean Pihet
Hi Will, On 3 July 2014 19:52, Will Deacon will.dea...@arm.com wrote: Hi Jean, On Fri, Jun 27, 2014 at 03:57:46PM +0100, Jean Pihet wrote: As done on other architectures (ARM64, x86, Sparc etc.). This prevents a deadlock on down_read in do_page_fault when unwinding using fp and triggering

Re: [PATCH 3/3] ARM: perf: allow tracing with kernel tracepoints events

2014-07-07 Thread Jean Pihet
Will, On 3 July 2014 19:54, Will Deacon will.dea...@arm.com wrote: On Fri, Jun 27, 2014 at 03:57:47PM +0100, Jean Pihet wrote: When tracing with tracepoints events the IP and CPSR are set to 0, preventing the perf code to resolve the symbols: ./perf record -e kmem:kmalloc cal [ perf record

[PATCH 1/3] ARM: perf: Check that current-mm is alive before getting user callchain

2014-07-07 Thread Jean Pihet
An event may occur when an mm is already released. As per commit 20afc60f892d285fde179ead4b24e6a7938c2f1b 'x86, perf: Check that current-mm is alive before getting user callchain' Signed-off-by: Jean Pihet jean.pi...@linaro.org Cc: Will Deacon will.dea...@arm.com Acked-by: Will Deacon will.dea

[PATCH 2/3] ARM: perf: disable the pagefault handler when reading from user space

2014-07-07 Thread Jean Pihet
) from [c0236c60] (__copy_from_user+0xa4/0x3a4) Signed-off-by: Jean Pihet jean.pi...@linaro.org Cc: Will Deacon will.dea...@arm.com Acked-by: Steve Capper steve.cap...@linaro.org --- arch/arm/kernel/perf_event.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/arm

[PATCH 3/3] ARM: perf: allow tracing with kernel tracepoints events

2014-07-07 Thread Jean Pihet
Priya on linaro-dev, cf. http://lists.linaro.org/pipermail/linaro-dev/2014-May/017151.html Signed-off-by: Jean Pihet jean.pi...@linaro.org Cc: Will Deacon will.dea...@arm.com Cc: Steve Capper steve.cap...@linaro.org Reported-by: Sneha Priya sneha@hotmail.com --- arch/arm/include/asm

[PATCH 0/3] ARM: perf: allow tracing with kernel tracepoints events

2014-07-07 Thread Jean Pihet
tracepoint), with unwinding using fp (--call-graph fp) and dwarf info (--call-graph dwarf). Jean Pihet (3): ARM: perf: Check that current-mm is alive before getting user callchain ARM: perf: disable the pagefault handler when reading from user space ARM: perf: allow tracing with kernel

Re: crazy idea (was: Re: [PATCH] perf tool: Carve out ctype.h et al)

2014-06-30 Thread Jean Pihet
Hi Boris, -- added Fu Wei in the loop -- On 30 June 2014 09:07, Borislav Petkov wrote: > On Sat, Jun 28, 2014 at 01:28:19AM +0200, Borislav Petkov wrote: >> Ok, cool. So guys, can we apply this one so that I can continue with the >> next round? > > Ok, I had this crazy idea recently: > > How

Re: crazy idea (was: Re: [PATCH] perf tool: Carve out ctype.h et al)

2014-06-30 Thread Jean Pihet
Hi Boris, -- added Fu Wei in the loop -- On 30 June 2014 09:07, Borislav Petkov b...@alien8.de wrote: On Sat, Jun 28, 2014 at 01:28:19AM +0200, Borislav Petkov wrote: Ok, cool. So guys, can we apply this one so that I can continue with the next round? Ok, I had this crazy idea recently:

[PATCH 2/3] ARM: perf: disable the pagefault handler when reading from user space

2014-06-27 Thread Jean Pihet
2ff4 ec0fc000 ec0fc000 007e 3b20: ecbc2000 ecbc3bac 0014 ecbc3b44 c0019e78 c021ef44 0013 [] (__dabt_svc) from [] (__copy_from_user+0xa4/0x3a0) Signed-off-by: Jean Pihet Cc: Will Deacon --- arch/arm/kernel/perf_event.c | 9 +++-- 1 file changed, 7 ins

[PATCH 0/3] ARM: perf: allow tracing with kernel tracepoints events

2014-06-27 Thread Jean Pihet
- Robustify the user backtrace code, as done on other architectures. - Provide the symbols resolution when triggering from tracepoints. Tested with perf record and tracepoints triggering (-e ), with unwinding using fp (--call-graph fp) and dwarf info (--call-graph dwarf). Jean Pihet (3): ARM

[PATCH 1/3] ARM: perf: Check that current->mm is alive before getting user callchain

2014-06-27 Thread Jean Pihet
An event may occur when an mm is already released. As per commit 20afc60f892d285fde179ead4b24e6a7938c2f1b 'x86, perf: Check that current->mm is alive before getting user callchain' Signed-off-by: Jean Pihet Cc: Will Deacon --- arch/arm/kernel/perf_event.c | 4 1 file changed

[PATCH 3/3] ARM: perf: allow tracing with kernel tracepoints events

2014-06-27 Thread Jean Pihet
, fp and cpsr. Tested with perf record and tracepoints triggering (-e ), with unwinding using fp (--call-graph fp) and dwarf info (--call-graph dwarf). Reported by Sneha Priya on linaro-dev, cf. http://lists.linaro.org/pipermail/linaro-dev/2014-May/017151.html Signed-off-by: Jean Pihet Cc

Re: [PATCH] ARM: perf: allow tracing with kernel tracepoints events

2014-06-27 Thread Jean Pihet
Hi Will, On 26 June 2014 11:00, Will Deacon wrote: > On Wed, Jun 25, 2014 at 03:54:14PM +0100, Jean Pihet wrote: >> Hi Will, > > Hello, > >> On 25 June 2014 11:01, Will Deacon wrote: >> > On Fri, Jun 20, 2014 at 09:10:35AM +0100, Jean Pihet wrote: >> >&

Re: [PATCH] ARM: perf: allow tracing with kernel tracepoints events

2014-06-27 Thread Jean Pihet
Hi Will, On 26 June 2014 11:00, Will Deacon will.dea...@arm.com wrote: On Wed, Jun 25, 2014 at 03:54:14PM +0100, Jean Pihet wrote: Hi Will, Hello, On 25 June 2014 11:01, Will Deacon will.dea...@arm.com wrote: On Fri, Jun 20, 2014 at 09:10:35AM +0100, Jean Pihet wrote: On 18 June 2014 14

[PATCH 3/3] ARM: perf: allow tracing with kernel tracepoints events

2014-06-27 Thread Jean Pihet
, fp and cpsr. Tested with perf record and tracepoints triggering (-e tracepoint), with unwinding using fp (--call-graph fp) and dwarf info (--call-graph dwarf). Reported by Sneha Priya on linaro-dev, cf. http://lists.linaro.org/pipermail/linaro-dev/2014-May/017151.html Signed-off-by: Jean Pihet

[PATCH 1/3] ARM: perf: Check that current-mm is alive before getting user callchain

2014-06-27 Thread Jean Pihet
An event may occur when an mm is already released. As per commit 20afc60f892d285fde179ead4b24e6a7938c2f1b 'x86, perf: Check that current-mm is alive before getting user callchain' Signed-off-by: Jean Pihet jean.pi...@linaro.org Cc: Will Deacon will.dea...@arm.com --- arch/arm/kernel

[PATCH 0/3] ARM: perf: allow tracing with kernel tracepoints events

2014-06-27 Thread Jean Pihet
- Robustify the user backtrace code, as done on other architectures. - Provide the symbols resolution when triggering from tracepoints. Tested with perf record and tracepoints triggering (-e tracepoint), with unwinding using fp (--call-graph fp) and dwarf info (--call-graph dwarf). Jean Pihet

[PATCH 2/3] ARM: perf: disable the pagefault handler when reading from user space

2014-06-27 Thread Jean Pihet
: ecbc3b74 b6d72ff4 3b00: ffec b6d72ff4 ec0fc000 ec0fc000 007e 3b20: ecbc2000 ecbc3bac 0014 ecbc3b44 c0019e78 c021ef44 0013 [c00136b8] (__dabt_svc) from [c021ef44] (__copy_from_user+0xa4/0x3a0) Signed-off-by: Jean

Re: [PATCH] ARM: perf: allow tracing with kernel tracepoints events

2014-06-25 Thread Jean Pihet
Hi Will, On 25 June 2014 11:01, Will Deacon wrote: > On Fri, Jun 20, 2014 at 09:10:35AM +0100, Jean Pihet wrote: >> Hi Will, > > Hi Jean, > >> On 18 June 2014 14:53, Will Deacon wrote: >> > On Tue, Jun 17, 2014 at 06:11:05PM +0100, Jean Pihet wrote: >> >

Re: [PATCH] perf: fix arm64 build error

2014-06-25 Thread Jean Pihet
regs[PERF_REGS_MAX]; > ^ > > This patch adds a PEFF_REGS_MAX definition for arm64. s/PEFF_REGS_MAX/PERF_REGS_MAX > > Signed-off-by: Mark Salter Acked-by: Jean Pihet Thanks! Note: Do you have any performance figure with and without the caching code in perf? Jean > --- > tools/

Re: [PATCH] perf: fix arm64 build error

2014-06-25 Thread Jean Pihet
]; ^ This patch adds a PEFF_REGS_MAX definition for arm64. s/PEFF_REGS_MAX/PERF_REGS_MAX Signed-off-by: Mark Salter msal...@redhat.com Acked-by: Jean Pihet jean.pi...@linaro.org Thanks! Note: Do you have any performance figure with and without the caching code in perf? Jean --- tools

Re: [PATCH] ARM: perf: allow tracing with kernel tracepoints events

2014-06-25 Thread Jean Pihet
Hi Will, On 25 June 2014 11:01, Will Deacon will.dea...@arm.com wrote: On Fri, Jun 20, 2014 at 09:10:35AM +0100, Jean Pihet wrote: Hi Will, Hi Jean, On 18 June 2014 14:53, Will Deacon will.dea...@arm.com wrote: On Tue, Jun 17, 2014 at 06:11:05PM +0100, Jean Pihet wrote: Tested with perf

Re: [PATCH] ARM: perf: allow tracing with kernel tracepoints events

2014-06-20 Thread Jean Pihet
Hi Will, On 18 June 2014 14:53, Will Deacon wrote: > Hi Jean, > > On Tue, Jun 17, 2014 at 06:11:05PM +0100, Jean Pihet wrote: >> When tracing with tracepoints events the IP and CPSR are set to 0, >> preventing the perf code to resolve the symbols: >> >>

Re: [PATCH] ARM: perf: allow tracing with kernel tracepoints events

2014-06-20 Thread Jean Pihet
Hi Will, On 18 June 2014 14:53, Will Deacon will.dea...@arm.com wrote: Hi Jean, On Tue, Jun 17, 2014 at 06:11:05PM +0100, Jean Pihet wrote: When tracing with tracepoints events the IP and CPSR are set to 0, preventing the perf code to resolve the symbols: ./perf record -e kmem:kmalloc cal

[PATCH] ARM: perf: allow tracing with kernel tracepoints events

2014-06-17 Thread Jean Pihet
, fp and cpsr. Tested with perf record and tracepoints filtering (-e ), with unwinding using fp (--call-graph fp) and dwarf info (--call-graph dwarf). Reported by Sneha Priya on linaro-dev, cf. http://lists.linaro.org/pipermail/linaro-dev/2014-May/017151.html Signed-off-by: Jean Pihet Cc

[PATCH] ARM: perf: allow tracing with kernel tracepoints events

2014-06-17 Thread Jean Pihet
, fp and cpsr. Tested with perf record and tracepoints filtering (-e tracepoint), with unwinding using fp (--call-graph fp) and dwarf info (--call-graph dwarf). Reported by Sneha Priya on linaro-dev, cf. http://lists.linaro.org/pipermail/linaro-dev/2014-May/017151.html Signed-off-by: Jean Pihet

Re: [GIT PULL 00/14] perf/core improvements and fixes

2014-06-12 Thread Jean Pihet
Hi Jiri, On 12 June 2014 17:30, Jiri Olsa wrote: > hi Ingo, > please consider pulling > > thanks, > jirka > > The following changes since commit 7184062b94b4bfac08715fb786fd2df399c5d6ee: > > Merge tag 'perf-core-for-mingo' of > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into

Re: [PATCH] tools:perf: move tools/perf/util to tools/lib/perf_util

2014-06-12 Thread Jean Pihet
On 12 June 2014 14:49, Borislav Petkov wrote: > On Thu, Jun 12, 2014 at 09:34:32AM -0300, Arnaldo Carvalho de Melo wrote: >> Em Thu, Jun 12, 2014 at 10:26:42AM +0200, Jean Pihet escreveu: >> > This is a first move of the perf code into a set of libraries, which >> &g

Re: [PATCH] tools:perf: move tools/perf/util to tools/lib/perf_util

2014-06-12 Thread Jean Pihet
On 12 June 2014 14:49, Borislav Petkov b...@alien8.de wrote: On Thu, Jun 12, 2014 at 09:34:32AM -0300, Arnaldo Carvalho de Melo wrote: Em Thu, Jun 12, 2014 at 10:26:42AM +0200, Jean Pihet escreveu: This is a first move of the perf code into a set of libraries, which allow the implementation

Re: [GIT PULL 00/14] perf/core improvements and fixes

2014-06-12 Thread Jean Pihet
Hi Jiri, On 12 June 2014 17:30, Jiri Olsa jo...@kernel.org wrote: hi Ingo, please consider pulling thanks, jirka The following changes since commit 7184062b94b4bfac08715fb786fd2df399c5d6ee: Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux

Re: [PATCHv2 00/14] perf tools: Speedup DWARF unwind

2014-05-23 Thread Jean Pihet
app.), - libdw: no significant improvement (0-2% improvement). Cf. https://wiki.linaro.org/LEG/Engineering/TOOLS/perf-callstack-unwinding#Speed_improvement for more details. FWIW: Acked-by: Jean Pihet Regards, Jean > > thanks, > jirka > > On Thu, May 15, 2014 at 07:23:21PM +0200, Jiri

Re: [PATCHv2 00/14] perf tools: Speedup DWARF unwind

2014-05-23 Thread Jean Pihet
(the 'stress_bt' app.), - libdw: no significant improvement (0-2% improvement). Cf. https://wiki.linaro.org/LEG/Engineering/TOOLS/perf-callstack-unwinding#Speed_improvement for more details. FWIW: Acked-by: Jean Pihet jean.pi...@linaro.org Regards, Jean thanks, jirka On Thu, May 15, 2014 at 07:23:21PM

[tip:perf/core] perf tools: Add libdw DWARF post unwind support for ARM

2014-05-20 Thread tip-bot for Jean Pihet
Commit-ID: 97eac381b113932bd7bd4a5c3c68b18e9ff7a2a0 Gitweb: http://git.kernel.org/tip/97eac381b113932bd7bd4a5c3c68b18e9ff7a2a0 Author: Jean Pihet AuthorDate: Fri, 16 May 2014 10:41:12 +0200 Committer: Jiri Olsa CommitDate: Fri, 16 May 2014 11:39:29 +0200 perf tools: Add libdw DWARF

[tip:perf/core] perf tests: Add dwarf unwind test on ARM

2014-05-20 Thread tip-bot for Jean Pihet
Commit-ID: 90fa9deb32b908fb258225ab562c4ef7ae8dd35a Gitweb: http://git.kernel.org/tip/90fa9deb32b908fb258225ab562c4ef7ae8dd35a Author: Jean Pihet AuthorDate: Fri, 16 May 2014 10:41:11 +0200 Committer: Jiri Olsa CommitDate: Fri, 16 May 2014 11:39:18 +0200 perf tests: Add dwarf unwind

[tip:perf/core] perf tests: Introduce perf_regs_load function on ARM

2014-05-20 Thread tip-bot for Jean Pihet
Commit-ID: 3418f9667e8cc4070a86215e6c12baa5bc2f2799 Gitweb: http://git.kernel.org/tip/3418f9667e8cc4070a86215e6c12baa5bc2f2799 Author: Jean Pihet AuthorDate: Fri, 16 May 2014 10:41:10 +0200 Committer: Jiri Olsa CommitDate: Fri, 16 May 2014 11:39:05 +0200 perf tests: Introduce

[tip:perf/core] perf tools: Consolidate types.h for ARM and ARM64

2014-05-20 Thread tip-bot for Jean Pihet
Commit-ID: 21a8b756b84ecaa0b7f29199669c151e2ce5e723 Gitweb: http://git.kernel.org/tip/21a8b756b84ecaa0b7f29199669c151e2ce5e723 Author: Jean Pihet AuthorDate: Fri, 16 May 2014 10:41:09 +0200 Committer: Jiri Olsa CommitDate: Fri, 16 May 2014 11:38:57 +0200 perf tools: Consolidate

[tip:perf/core] perf tools: Consolidate types.h for ARM and ARM64

2014-05-20 Thread tip-bot for Jean Pihet
Commit-ID: 21a8b756b84ecaa0b7f29199669c151e2ce5e723 Gitweb: http://git.kernel.org/tip/21a8b756b84ecaa0b7f29199669c151e2ce5e723 Author: Jean Pihet jean.pi...@linaro.org AuthorDate: Fri, 16 May 2014 10:41:09 +0200 Committer: Jiri Olsa jo...@kernel.org CommitDate: Fri, 16 May 2014 11:38:57

[tip:perf/core] perf tests: Add dwarf unwind test on ARM

2014-05-20 Thread tip-bot for Jean Pihet
Commit-ID: 90fa9deb32b908fb258225ab562c4ef7ae8dd35a Gitweb: http://git.kernel.org/tip/90fa9deb32b908fb258225ab562c4ef7ae8dd35a Author: Jean Pihet jean.pi...@linaro.org AuthorDate: Fri, 16 May 2014 10:41:11 +0200 Committer: Jiri Olsa jo...@kernel.org CommitDate: Fri, 16 May 2014 11:39:18

[tip:perf/core] perf tools: Add libdw DWARF post unwind support for ARM

2014-05-20 Thread tip-bot for Jean Pihet
Commit-ID: 97eac381b113932bd7bd4a5c3c68b18e9ff7a2a0 Gitweb: http://git.kernel.org/tip/97eac381b113932bd7bd4a5c3c68b18e9ff7a2a0 Author: Jean Pihet jean.pi...@linaro.org AuthorDate: Fri, 16 May 2014 10:41:12 +0200 Committer: Jiri Olsa jo...@kernel.org CommitDate: Fri, 16 May 2014 11:39:29

[tip:perf/core] perf tests: Introduce perf_regs_load function on ARM

2014-05-20 Thread tip-bot for Jean Pihet
Commit-ID: 3418f9667e8cc4070a86215e6c12baa5bc2f2799 Gitweb: http://git.kernel.org/tip/3418f9667e8cc4070a86215e6c12baa5bc2f2799 Author: Jean Pihet jean.pi...@linaro.org AuthorDate: Fri, 16 May 2014 10:41:10 +0200 Committer: Jiri Olsa jo...@kernel.org CommitDate: Fri, 16 May 2014 11:39:05

Re: [PATCH] [RFC] ARM: perf: allow tracing with kernel tracepoints events

2014-05-19 Thread Jean Pihet
Hi Will, On 19 May 2014 17:39, Will Deacon wrote: > Hi Jean, > > On Fri, May 16, 2014 at 04:01:16PM +0100, Jean Pihet wrote: >> When tracing with tracepoints events the IP and CPSR are set to 0, >> preventing the perf code to resolve the symbols: >> >> ./perf rec

Re: [PATCH] [RFC] ARM: perf: allow tracing with kernel tracepoints events

2014-05-19 Thread Jean Pihet
Hi Will, On 19 May 2014 17:39, Will Deacon will.dea...@arm.com wrote: Hi Jean, On Fri, May 16, 2014 at 04:01:16PM +0100, Jean Pihet wrote: When tracing with tracepoints events the IP and CPSR are set to 0, preventing the perf code to resolve the symbols: ./perf record -e kmem:kmalloc cal

[PATCH] [RFC] ARM: perf: allow tracing with kernel tracepoints events

2014-05-16 Thread Jean Pihet
/arm/include/asm/kexec.h. Reported by Sneha Priya on linaro-dev, cf. http://lists.linaro.org/pipermail/linaro-dev/2014-May/017151.html Signed-off-by: Jean Pihet Cc: Will Deacon Reported-by: Sneha Priya --- arch/arm/include/asm/perf_event.h | 13 + 1 file changed, 13 insertions

[PATCH 3/4] perf tests: Add dwarf unwind test on ARM

2014-05-16 Thread Jean Pihet
for x86. Reviewed-by: Will Deacon Cc: Jiri Olsa Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Arnaldo Carvalho de Melo Cc: David Ahern Signed-off-by: Jean Pihet --- tools/perf/Makefile.perf | 2

[PATCH 1/4] tools: perf: consolidate types.h for ARM and ARM64

2014-05-16 Thread Jean Pihet
Prevents a build breakage since commit d944c4eebcf4c0d5e5d9728fec110cbf0047ad7f 'tools: Consolidate types.h' Signed-off-by: Jean Pihet --- tools/perf/arch/arm/include/perf_regs.h | 2 +- tools/perf/arch/arm64/include/perf_regs.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 4/4] perf tools: Add libdw DWARF post unwind support for ARM

2014-05-16 Thread Jean Pihet
Adding libdw DWARF post unwind support, which is part of elfutils-devel/libdw-dev package from version 0.158. The new code is contained in unwin-libdw.c object, and implements unwind__get_entries unwind interface function. Signed-off-by: Jean Pihet Reviewed-by: Will Deacon Cc: Jiri Olsa Cc

[PATCH 2/4] perf tests: Introduce perf_regs_load function on ARM

2014-05-16 Thread Jean Pihet
Introducing perf_regs_load function, which is going to be used for dwarf unwind test in following patches. It takes single argument as a pointer to the regs dump buffer and populates it with current registers values. Signed-off-by: Jean Pihet Reviewed-by: Will Deacon Cc: Corey Ashford Cc

[PATCH 4/4] perf tools: Add libdw DWARF post unwind support for ARM

2014-05-16 Thread Jean Pihet
Adding libdw DWARF post unwind support, which is part of elfutils-devel/libdw-dev package from version 0.158. The new code is contained in unwin-libdw.c object, and implements unwind__get_entries unwind interface function. Signed-off-by: Jean Pihet jean.pi...@linaro.org Reviewed-by: Will Deacon

[PATCH 2/4] perf tests: Introduce perf_regs_load function on ARM

2014-05-16 Thread Jean Pihet
Introducing perf_regs_load function, which is going to be used for dwarf unwind test in following patches. It takes single argument as a pointer to the regs dump buffer and populates it with current registers values. Signed-off-by: Jean Pihet jean.pi...@linaro.org Reviewed-by: Will Deacon

[PATCH 1/4] tools: perf: consolidate types.h for ARM and ARM64

2014-05-16 Thread Jean Pihet
Prevents a build breakage since commit d944c4eebcf4c0d5e5d9728fec110cbf0047ad7f 'tools: Consolidate types.h' Signed-off-by: Jean Pihet jean.pi...@linaro.org --- tools/perf/arch/arm/include/perf_regs.h | 2 +- tools/perf/arch/arm64/include/perf_regs.h | 2 +- 2 files changed, 2 insertions(+), 2

[PATCH 3/4] perf tests: Add dwarf unwind test on ARM

2014-05-16 Thread Jean Pihet
a.p.zijls...@chello.nl Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: David Ahern dsah...@gmail.com Signed-off-by: Jean Pihet jean.pi...@linaro.org --- tools/perf/Makefile.perf | 2 +- tools/perf/arch/arm/Makefile | 1 + tools/perf/arch/arm/include/perf_regs.h

[PATCH] [RFC] ARM: perf: allow tracing with kernel tracepoints events

2014-05-16 Thread Jean Pihet
/arm/include/asm/kexec.h. Reported by Sneha Priya on linaro-dev, cf. http://lists.linaro.org/pipermail/linaro-dev/2014-May/017151.html Signed-off-by: Jean Pihet jean.pi...@linaro.org Cc: Will Deacon will.dea...@arm.com Reported-by: Sneha Priya sneha@hotmail.com --- arch/arm/include/asm

Re: [PATCH 2/3] perf tests: Add dwarf unwind test on ARM

2014-05-07 Thread Jean Pihet
Hi Jiri, On 7 May 2014 14:06, Jiri Olsa wrote: > On Tue, May 06, 2014 at 05:26:18PM +0200, Jean Pihet wrote: > SNIP > > there's a memory leak of 'buf' already fixed fox x86: > > perf tests x86: Fix memory leak in sample_ustack() > commit 763d7f5f2718f085bab5a9e6330834

Re: [PATCH 3/3] perf tools: Add libdw DWARF post unwind support for ARM

2014-05-07 Thread Jean Pihet
On 7 May 2014 12:00, Will Deacon wrote: > On Wed, May 07, 2014 at 10:52:05AM +0100, Jean Pihet wrote: >> On 6 May 2014 19:56, Will Deacon wrote: >> > On Tue, May 06, 2014 at 04:26:19PM +0100, Jean Pihet wrote: >> >> Adding libdw DWARF post unwind support, which i

Re: [PATCH 3/3] perf tools: Add libdw DWARF post unwind support for ARM

2014-05-07 Thread Jean Pihet
On 6 May 2014 19:56, Will Deacon wrote: > On Tue, May 06, 2014 at 04:26:19PM +0100, Jean Pihet wrote: >> Adding libdw DWARF post unwind support, which is part >> of elfutils-devel/libdw-dev package from version 0.158. >> >> The new code is contained in unwin-libdw.

Re: [PATCH 3/3] perf tools: Add libdw DWARF post unwind support for ARM64

2014-05-07 Thread Jean Pihet
Hi Will, On Tue, May 6, 2014 at 7:52 PM, Will Deacon wrote: > On Tue, May 06, 2014 at 06:41:55PM +0100, Jean Pihet wrote: >> Hi Will, >> >> On 6 May 2014 19:00, Will Deacon wrote: >> > Hi Jean, >> > >> > On Tue, May 06, 2014 at 04:55:33PM +0100,

Re: [PATCH 3/3] perf tools: Add libdw DWARF post unwind support for ARM64

2014-05-07 Thread Jean Pihet
Hi Will, On Tue, May 6, 2014 at 7:52 PM, Will Deacon will.dea...@arm.com wrote: On Tue, May 06, 2014 at 06:41:55PM +0100, Jean Pihet wrote: Hi Will, On 6 May 2014 19:00, Will Deacon will.dea...@arm.com wrote: Hi Jean, On Tue, May 06, 2014 at 04:55:33PM +0100, Jean Pihet wrote: Adding

Re: [PATCH 3/3] perf tools: Add libdw DWARF post unwind support for ARM

2014-05-07 Thread Jean Pihet
On 6 May 2014 19:56, Will Deacon will.dea...@arm.com wrote: On Tue, May 06, 2014 at 04:26:19PM +0100, Jean Pihet wrote: Adding libdw DWARF post unwind support, which is part of elfutils-devel/libdw-dev package from version 0.158. The new code is contained in unwin-libdw.c object

Re: [PATCH 3/3] perf tools: Add libdw DWARF post unwind support for ARM

2014-05-07 Thread Jean Pihet
On 7 May 2014 12:00, Will Deacon will.dea...@arm.com wrote: On Wed, May 07, 2014 at 10:52:05AM +0100, Jean Pihet wrote: On 6 May 2014 19:56, Will Deacon will.dea...@arm.com wrote: On Tue, May 06, 2014 at 04:26:19PM +0100, Jean Pihet wrote: Adding libdw DWARF post unwind support, which

  1   2   3   4   5   >