Re: [PATCH] net #9

2001-05-29 Thread Jean Tourrilhes
On Tue, May 29, 2001 at 09:13:34PM -0400, Jeff Garzik wrote: This is standard kernel cleanup that makes the resulting image smaller. These patches have been going into all areas of the kernel for quite some time. This doesn't make it right. Ok, while we are on the topic :

Re: [PATCH] net #9

2001-05-29 Thread Jean Tourrilhes
On Tue, May 29, 2001 at 10:13:02PM -0400, Jeff Garzik wrote: *shrug* Well, if you want to go against the kernel standard that's fine with me. I won't put Andrzej's changes to your drivers upstream. You are going to continually see patches to clean that up, though, because it makes the end

2.4.2-ac3 and wavelan driver

2001-02-23 Thread Jean Tourrilhes
Hi Alan (and the others) A few notes related to you *-ac* patches, the IrDA stack and the Wavelan driver. First, IrDA : --- linux.vanilla/net/irda/irlap.cThu Feb 22 09:06:21 2001 +++ linux.ac/net/irda/irlap.c Wed Feb 21 11:55:26 2001 @@ -51,6 +51,7 @@ hashbin_t *irlap

Re: [patch] patch-2.4.2-irda1 (irda-usb)

2001-02-27 Thread Jean Tourrilhes
On Tue, Feb 27, 2001 at 01:58:11PM -0800, Greg KH wrote: On Tue, Feb 27, 2001 at 08:32:28PM +, Dag Brattli wrote: I'd recommend that this file be in the /drivers/usb directory, much like almost all other USB drivers are. Yes, but do we want to spread the IrDA code around? The same

Nasty bug in the IrDA stack

2001-03-02 Thread Jean Tourrilhes
Hi, I've found a really convoluted bug in the IrDA stack (spend the week chasing it). As it is not trivial, I would like you to check and comment on my description and my fix. My patch definitely fix the problem on the PC where I was seeing it, and I can't crash it

GlobeCom 2000 - Networking papers

2000-12-08 Thread Jean Tourrilhes
Hi, I was a GlobeCom 2 weeks ago, and I noticed a few articles relevant to Linux networking that you might be interested in reading... On ECN : -- Archan Misra, John Baras Teunis Ott. Generalised TCP Congestion Avoidance and its Effect on Bandwidth Sharing and

Re : [RFC-2] Configuring Synchronous Interfaces in Linux

2000-12-08 Thread Jean Tourrilhes
Alan wrote : struct wireless_physical struct wireless_80211 struct wireless_auth Please do not underestimate 802.11 (and others). Even two cards based on the same MAC controller can have very different way to

Wireless Extension update

2000-12-19 Thread Jean Tourrilhes
Hi Linus and Alan, This is a totally trivial update of the Wireless Extensions definition. It just adds a few more #define, so no troubles or pain expected. The patch attached applies cleanly to *both* 2.4.0-test12 and 2.2.18 (tested), and I would suggest including it in

Re: wavelan has fatal error with 2.4.0 (but worked in 2.4.0-test12)

2001-01-09 Thread Jean Tourrilhes
On Tue, Jan 09, 2001 at 07:17:01AM -0500, John Ruttenberg wrote: I get: Jan 9 07:04:51 mojo cardmgr[511]: socket 1: Digital RoamAbout/DS Jan 9 07:04:52 mojo cardmgr[511]: executing: 'modprobe wavelan_cs' Jan 9 07:04:52 mojo cardmgr[511]: +

Re: wavelan has fatal error with 2.4.0 (but worked in 2.4.0-test12)

2001-01-09 Thread Jean Tourrilhes
On Tue, Jan 09, 2001 at 05:13:42PM +, Alan Cox wrote: This is a bug with the definition of udelay(). Somebody tried to be too clever with udelay(), and the end result is that it breaks perfectly good and valid code. Therefore, it should be reported as such on LKML, a bug in

Re: wavelan has fatal error with 2.4.0 (but worked in 2.4.0-test12)

2001-01-09 Thread Jean Tourrilhes
On Tue, Jan 09, 2001 at 05:48:47PM +, Alan Cox wrote: It is a bug in the driver. Please check again the code and point me the invalid udelay(). You will realise that there is no delay in the driver that is longer than 100ms. The udelay limit is set a lot lower than 100mS.

Re: [RANT] Linux-IrDA status

2000-11-07 Thread Jean Tourrilhes
On Tue, Nov 07, 2000 at 08:24:38PM -0500, Jeff Garzik wrote: Take a look at http://www.uwsg.iu.edu/hypermail/linux/kernel/9908.0/0669.html This happened with ISDN. Slightly different situation, but similar. I'm familiar with that. The *BIG* difference is that Dag has always sent

Re: The IrDA patches !!! (+ more flames)

2000-11-09 Thread Jean Tourrilhes
On Thu, Nov 09, 2000 at 07:24:04PM -0800, Jean Tourrilhes wrote: I spent my full day going through my archives and splitting the big patch of Dag into lots of small patches (see attached). I'm glad I've got a big hard drive full of junk. By the way, while I'm in flaming mode

Re: The IrDA patches !!! (was Re: [RANT] Linux-IrDA status)

2000-11-11 Thread Jean Tourrilhes
On Sat, Nov 11, 2000 at 06:43:26PM -0800, Linus Torvalds wrote: Ok, thanks to the work of Jean, everything seems to be applied now. I'll make a test3 one of these days (probably tomorrow), please verify that everything looks happy. Linus Linus, Sorry to

orinoco_cs IrDA

2001-04-24 Thread Jean Tourrilhes
Hi Linus, I've got a question... I would like where to send my driver patches... One month ago, I sent a small update for the orinoco_cs driver and Wireless Extensions. I didn't put all the changes I had for orinoco_cs because I believe in small incremental updates

Re: orinoco_cs IrDA

2001-04-24 Thread Jean Tourrilhes
On Tue, Apr 24, 2001 at 08:47:30PM +0100, Alan Cox wrote: patch (without feedback), whereas Alan picked it up (if I remember correctly it was included in his 'patch-2.4.2-ac28'). So now, what should I do with the rest of my updates and the new one that have accumulated since ? Should

Re: orinoco_cs IrDA

2001-04-24 Thread Jean Tourrilhes
On Tue, Apr 24, 2001 at 03:15:08PM -0700, Jean Tourrilhes wrote: [...] Downloaded the patch again (patch-2.4.4-pre6), checked that it was complete, my patch is in. Oups ! Do I feel stupid... Let's finish this story. As indicated above, the first fragment of the patch I sent

Re: orinoco_cs IrDA

2001-04-24 Thread Jean Tourrilhes
On Tue, Apr 24, 2001 at 03:56:37PM -0700, Jean Tourrilhes wrote: On Tue, Apr 24, 2001 at 03:15:08PM -0700, Jean Tourrilhes wrote: [...] Downloaded the patch again (patch-2.4.4-pre6), checked that it was complete, my patch is in. Oups ! Do I feel stupid... Let's finish

Re: orinoco_cs IrDA

2001-04-24 Thread Jean Tourrilhes
On Tue, Apr 24, 2001 at 06:25:50PM -0700, Jean Tourrilhes wrote: Ok, now to the second chapter. These are all the changes accumulated since the patch I sent one month ago (cf previous e-mail). Changes : o more Prism2/Symbol compatibility goodies o

Re: [PATCH] net #9

2001-05-29 Thread Jean Tourrilhes
On Tue, May 29, 2001 at 09:47:19PM -0400, Jeff Garzik wrote: This is ANSI C standard stuff. If a static object with a scalar type is not explicitly initialized, it is initialized to zero by default. Sure we can get gcc to recognize that case, but why use gcc to work around code that

Re: [PATCH] net #9

2001-05-29 Thread Jean Tourrilhes
On Wed, May 30, 2001 at 02:48:24AM +0200, Andrzej Krzysztofowicz wrote: The following patch removes some zero initializers from statics Andrzej If I were you, I would fix gcc rather than making my code unreadable. I write source code in C rather than coding ASM in hex

Re : 16 potential locking bugs in 2.4.1 (wavelan patch attached)

2001-03-22 Thread Jean Tourrilhes
Andy Chou : Here are some more results from the MC project. These are 16 errors found in 2.4.1 related to inconsistent use of locks. As usual, if you can verify any of these or show that they are false positives, please let us know by CC'ing [EMAIL PROTECTED] -Andy Chou

Re: Re : [CHECKER] 28 potential interrupt errors

2001-03-22 Thread Jean Tourrilhes
On Thu, Mar 22, 2001 at 03:49:31PM -0800, Junfeng Yang wrote: Sometimes the line number reported by the checker is not correct. But if you go into the function, you can find the bug. Gotcha. It in fact indicate the error at the end of the function instead of the place where the error

Wireless Extension update...

2001-03-28 Thread Jean Tourrilhes
--- linux/include/linux/wireless.25.h Wed Mar 28 10:33:47 2001 +++ linux/include/linux/wireless.h Wed Mar 28 17:31:42 2001 @@ -1,7 +1,7 @@ /* * This file define a set of standard wireless extensions * - * Version : 9 16.10.99 + * Version : 11 28.3.01 * * Authors : Jean

[PATCH 2.6.20] pwc : Cisco VT Camera support

2007-03-15 Thread Jean Tourrilhes
Hi, I already sent this e-mail to Luc and on the pwc mailing list, and got no answer. I'm trying again with the hope that this patch would go in the kernel... I have a Cisco VT Camera, and it was just collecting dust. I decided to try connecting it to my Linux box at

[PATCH 2.6.20] kobject net ifindex + rename

2007-02-27 Thread Jean Tourrilhes
scripts, and on another system running udev. Have fun... Jean Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED] - diff -u -p linux/include/linux/kobject.j1.h linux/include/linux/kobject.h --- linux/include/linux/kobject.j1.h

Re: [PATCH 2.6.20] kobject net ifindex + rename

2007-02-28 Thread Jean Tourrilhes
On Wed, Feb 28, 2007 at 07:36:17AM -0800, Greg KH wrote: On Tue, Feb 27, 2007 at 05:27:41PM -0800, Jean Tourrilhes wrote: diff -u -p linux/drivers/base/class.j1.c linux/drivers/base/class.c --- linux/drivers/base/class.j1.c 2007-02-26 18:38:10.0 -0800 +++ linux/drivers/base

Re: [PATCH 2.6.20] kobject net ifindex + rename

2007-02-28 Thread Jean Tourrilhes
On Wed, Feb 28, 2007 at 10:34:37AM +0100, Jarek Poplawski wrote: On 28-02-2007 02:27, Jean Tourrilhes wrote: Hi all, ... Patch for 2.6.20 is attached. The patch was tested on a system running the hotplug scripts, and on another system running udev. Have fun

Re: [PATCH 2.6.20] kobject net ifindex + rename

2007-02-28 Thread Jean Tourrilhes
On Wed, Feb 28, 2007 at 10:16:05AM +0100, Johannes Berg wrote: Hi, Patch for 2.6.20 is attached. ... and in the meantime netdevices aren't class_device any more :) IOW, your patch isn't going to work any more. That's why I always specify the kernel version. I'll look into

Re: [PATCH 2.6.20] kobject net ifindex + rename

2007-02-28 Thread Jean Tourrilhes
On Wed, Feb 28, 2007 at 07:36:17AM -0800, Greg KH wrote: On Tue, Feb 27, 2007 at 05:27:41PM -0800, Jean Tourrilhes wrote: diff -u -p linux/drivers/base/class.j1.c linux/drivers/base/class.c --- linux/drivers/base/class.j1.c 2007-02-26 18:38:10.0 -0800 +++ linux/drivers/base

Re: [PATCH 2.6.20] kobject net ifindex + rename

2007-02-28 Thread Jean Tourrilhes
On Thu, Mar 01, 2007 at 01:37:46AM +0100, Johannes Berg wrote: On Wed, 2007-02-28 at 16:26 -0800, Jean Tourrilhes wrote: + /* This function is only used for network interface. +* Some hotplug package track interfaces by their name and +* therefore want to know when the name

Re: [PATCH 2.6.20] kobject net ifindex + rename

2007-03-01 Thread Jean Tourrilhes
On Thu, Mar 01, 2007 at 08:42:09AM +0100, Jarek Poplawski wrote: On Wed, Feb 28, 2007 at 10:45:41AM -0800, Jean Tourrilhes wrote: + + if ((size = 0) || (i = num_envp)) Btw.: 1. if size == 10 and snprintf returns 9 (without NULL) then n == 10 (with NULL), so isn't

Re: [IrDA] Oops with NULL deref in irda_device_set_media_busy

2005-04-05 Thread Jean Tourrilhes
On Tue, Apr 05, 2005 at 11:02:26AM +0200, Michal Rokos wrote: Hello, I've problems with IrDA - when debug is off, I'm getting oops for obvious reason... (I don't have a log, this is just rewrite from screen: EIP: irda_device_set_media_busy+0x15/0x40 [irda] ali_ircc_sir_receive+0x4a/0x70

Re: [IrDA] Oops with NULL deref in irda_device_set_media_busy

2005-04-06 Thread Jean Tourrilhes
On Wed, Apr 06, 2005 at 09:22:48AM +0200, Michal Rokos wrote: Hello again, I'm gonna provide more info this time... When I turn debug on, I get just Assertion failed! net/irda/irda_device.c:irda_device_set_media_busy:128 self != NULL The obvious reason is that I don't have

Re: [IrDA] Oops with NULL deref in irda_device_set_media_busy

2005-04-07 Thread Jean Tourrilhes
On Thu, Apr 07, 2005 at 08:22:52AM +0200, Michal Rokos wrote: Hello, On Wednesday 06 April 2005 18:49, Jean Tourrilhes wrote: Patch attached. and is working fine - of course. Thank you for patience. :) Michal No, thank you for pushing me harder ;-) Note that the comments

[PATCH 2.4] SIOCSIFNAME wildcard support

2005-02-03 Thread Jean Tourrilhes
Hi Marcelo, This patch adds wildcard support for the SIOCSIFNAME ioctl, like what was done in 2.6.1. SIOCSIFNAME allow a user space tool to change network interface names (such as nameif, ifrename, or ip link), this patch allow those tools to specify a pattern, such as eth%d or

[PATCH 2.4] Wireless Extension v17

2005-02-03 Thread Jean Tourrilhes
:48.0 -0800 @@ -1,10 +1,10 @@ /* * This file define a set of standard wireless extensions * - * Version : 16 2.4.03 + * Version : 17 21.6.04 * * Authors : Jean Tourrilhes - HPL - [EMAIL PROTECTED] - * Copyright (c) 1997-2002 Jean Tourrilhes, All Rights Reserved

[PATCH 2.4] SIOCSIFNAME wildcard support (resend)

2005-02-08 Thread Jean Tourrilhes
Hi Marcelo, I did not receive any feedback on this e-mail, so I assume it was lost on the way. Would you mind pushing that in 2.4.x ? Thanks... Jean - Forwarded message from jt - Subject: [PATCH 2.4] SIOCSIFNAME wildcard support E-mail: [EMAIL PROTECTED]

[PATCH 2.4] Wireless Extension v17 (resend)

2005-02-08 Thread Jean Tourrilhes
:44:48.0 -0800 @@ -1,10 +1,10 @@ /* * This file define a set of standard wireless extensions * - * Version : 16 2.4.03 + * Version : 17 21.6.04 * * Authors : Jean Tourrilhes - HPL - [EMAIL PROTECTED] - * Copyright (c) 1997-2002 Jean Tourrilhes, All Rights Reserved

Re: [PATCH 2.4] Wireless Extension v17 (resend)

2005-02-08 Thread Jean Tourrilhes
On Tue, Feb 08, 2005 at 04:01:16PM -0200, Marcelo Tosatti wrote: Hi Jean, I'm very ignorant about wireless but it doesnt appear to me that Wireless Extension v17 is a critical feature. You are right, it's not critical, and I was already thinking of not pushing WE-18 to you (the

Re: [PATCH 2.4] SIOCSIFNAME wildcard support (resend)

2005-02-08 Thread Jean Tourrilhes
On Tue, Feb 08, 2005 at 02:24:22PM -0800, David S. Miller wrote: On Tue, 8 Feb 2005 16:04:45 -0200 Marcelo Tosatti [EMAIL PROTECTED] wrote: On Tue, Feb 08, 2005 at 10:14:36AM -0800, Jean Tourrilhes wrote: Hi Marcelo, I did not receive any feedback on this e-mail, so I assume

Re: [PATCH 2.4] Wireless Extension v17 (resend)

2005-02-08 Thread Jean Tourrilhes
On Tue, Feb 08, 2005 at 04:41:46PM -0200, Marcelo Tosatti wrote: On Tue, Feb 08, 2005 at 01:51:12PM -0800, Jean Tourrilhes wrote: You are right, it's not critical, and I was already thinking of not pushing WE-18 to you (the WPA update). I'll stop updating 2.4.X with respect

Re: [PATCH 2.4] Wireless Extension v17 (resend)

2005-02-08 Thread Jean Tourrilhes
On Tue, Feb 08, 2005 at 05:51:29PM -0800, Chris Wright wrote: * Jean Tourrilhes ([EMAIL PROTECTED]) wrote: The first is the handling of spyoffset which is potentially unsafe. Unfortunately, the fix involve some API/infrastructure change, so is not transparent. Fortunately drivers

[PATCH 2.6.11] WE-18 (aka WPA)

2005-03-14 Thread Jean Tourrilhes
+++ linux-2.6.11-WE18/include/linux/wireless.h 2005-03-12 09:53:02.0 -0800 @@ -1,10 +1,10 @@ /* * This file define a set of standard wireless extensions * - * Version : 17 21.6.04 + * Version : 18 12.3.05 * * Authors : Jean Tourrilhes - HPL - [EMAIL PROTECTED

[PATCH 2.6 IrDA] support NSC PC8738x

2005-03-04 Thread Jean Tourrilhes
ir261_nsc_38x.diff : ~~ Original patch from Steffen Pingel o [FEATURE] support NSC PC8738x chipset (IBM x40 ...) Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED] diff -u -p linux/drivers/net/irda/nsc-ircc.d0.c linux/drivers/net/irda/nsc-ircc.c --- linux

[PATCH 2.6 IrDA] arbitrary lsap connect

2005-03-04 Thread Jean Tourrilhes
ir261_connect_lsap-2.diff : ~ Original patch from Iavor Fetvadjie o [FEATURE] allow IrDA socket to connect on arbitrary LSAPs Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED] diff -u -p linux/net/irda/af_irda.d0.c linux/net/irda/af_irda.c --- linux

[PATCH 2.6 IrDA] cleanup obsolete construct in IrCOMM

2005-03-04 Thread Jean Tourrilhes
ir261_ircomm_write_cleanup.diff : ~~~ o [FEATURE] cleanup some construct obsoleted by Linus's patch Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED] diff -u -p linux/net/irda/ircomm/ircomm_tty.d0.c linux/net/irda/ircomm/ircomm_tty.c --- linux/net/irda/ircomm

[PATCH 2.6 IrDA] Mark exit code properly in VIA driver

2005-03-04 Thread Jean Tourrilhes
irXXX_via_devexit.diff : ~~ Patch from Randy Dunlap o [CORRECT] Mark exit code properly in VIA driver Signed-off-by: Randy Dunlap [EMAIL PROTECTED] Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED] diff -Naurp ./drivers/net/irda/via-ircc.c

[PATCH 2.6 IrDA] remove unneeded EXPORT_SYMBOL's from irport.c

2005-03-04 Thread Jean Tourrilhes
irXXX_irport_exports.diff : ~ Patch from Adrian Bunk o [FEATURE] make needlessly global code static o [FEATURE] remove unneeded EXPORT_SYMBOL's from irport.c Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: Jean Tourrilhes [EMAIL

[PATCH 2.6 IrDA] stir4200 turnaround calculation fix

2005-03-04 Thread Jean Tourrilhes
ir261_stir_turn.diff : Patch from John K. Luebs o [CORRECT] Proper turnaround computations in the stir4200 driver o [CORRECT] Take care of Tx packet without IrDA metadata (speed) Signed-off-by: John K. Luebs [EMAIL PROTECTED] Signed-off-by: Jean

[PATCH 2.6 IrDA] irda-usb sysfs support

2005-03-04 Thread Jean Tourrilhes
-by: Jean Tourrilhes [EMAIL PROTECTED] diff -u -p linux/drivers/net/irda/irda-usb.d0.c linux/drivers/net/irda/irda-usb.c --- linux/drivers/net/irda/irda-usb.d0.cFri Mar 4 15:37:25 2005 +++ linux/drivers/net/irda/irda-usb.c Fri Mar 4 15:38:38 2005 @@ -998,7 +998,7 @@ static int

[PATCH 2.6 IrDA] fix IrNET poll with empty disco log

2005-03-04 Thread Jean Tourrilhes
ir261_irnet_poll_fix-2.diff : ~~~ o [CORRECT] poll would improperly exit when the discovery log was empty Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED] diff -u -p linux/net/irda/irnet/irnet_irda.j1.c linux/net/irda/irnet/irnet_irda.c --- linux/net/irda/irnet

IrDA patches for 2.6.12-rc1

2005-03-04 Thread Jean Tourrilhes
-off-by: Jean Tourrilhes [EMAIL PROTECTED] ir261_irda-usb_sysfs-kill_urb-2.diff : o [CORRECT] Forgot to convert a few usb_unlink_urb() in usb_kill_urb() Patch from John K. Luebs o [FEATURE] Proper sysfs support Signed-off-by: John

[BUG] MODULE_PARM conversions introduces bug in Wavelan driver

2005-01-18 Thread Jean Tourrilhes
Hi Rusty, (If you are not the culprit, please forward to the guilty party). The patch the the Wavelan driver that I quote below introduces a nice bug that can crash the kernel. Maybe you want to think about fixing it, or maybe I should revert the patch... As a

Re: [BUG] MODULE_PARM conversions introduces bug in Wavelan driver

2005-01-19 Thread Jean Tourrilhes
On Wed, Jan 19, 2005 at 01:42:33PM +1100, Rusty Russell wrote: On Tue, 2005-01-18 at 16:47 -0800, Jean Tourrilhes wrote: Hi Rusty, (If you are not the culprit, please forward to the guilty party). Almost certainly me. We gave people warning, we even marked MODULE_PARM

Re: net-irda-possible-cleanups.patch added to -mm tree

2005-08-17 Thread Jean Tourrilhes
On Tue, Aug 16, 2005 at 08:46:34PM -0700, David S. Miller wrote: I've put this into the net-2.6.14 tree. Great. Thanks ! Jean - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: 2.6.19-rc6-mm2

2006-11-28 Thread Jean Tourrilhes
On Tue, Nov 28, 2006 at 04:58:28PM -0800, Andrew Morton wrote: On Tue, 28 Nov 2006 19:24:45 -0500 Thomas Tuttle [EMAIL PROTECTED] wrote: 2. I'm not sure if this bug is in the kernel, wireless tools, or the ipw3945 driver, but I haven't changed the version of anything but the kernel.

Re: [PATCH] kthread: export park/unpark facility

2015-07-09 Thread Jean Tourrilhes
On Thu, Jul 09, 2015 at 10:05:02AM +0200, Thomas Gleixner wrote: This patch should definitely help most modules. And how exactly would this help modules? Putting kthread to sleep and waking them up later is slightly tricky : http://www.linuxjournal.com/article/8144

Re: [PATCH] kthread: export park/unpark facility

2015-07-09 Thread Jean Tourrilhes
On Thu, Jul 09, 2015 at 06:49:21PM +0200, Thomas Gleixner wrote: If you can come up with a proper use case, i.e. patch for a module, then we can certainly talk about the exports. But without a user it does not make any sense. My module is currently out of the tree, so obviously it

Re: [PATCH] kthread: export park/unpark facility

2015-07-09 Thread Jean Tourrilhes
On Wed, Jul 08, 2015 at 11:23:41PM -0400, Peter Hurley wrote: On 07/08/2015 08:40 PM, Jean Tourrilhes wrote: Hi, The kthread park/unpark facility is not used in the kernel kernel/smpboot.c ? Got me, I should have said hardly used. Sorry for the gross exageration

[PATCH] kthread: export park/unpark facility

2015-07-08 Thread Jean Tourrilhes
Hi, The kthread park/unpark facility is not used in the kernel, so one would assume that it's made for kernel modules. This patch should definitely help most modules. Patch untested, at your own risks... Regards, Jean Signed-off-by: Jean Tourrilhes j

Re: Possible race in nsc-ircc.ko

2017-08-25 Thread Jean Tourrilhes
On Fri, Aug 25, 2017 at 05:05:25PM +0300, Anton Volkov wrote: > Hello. > > While searching for races in the Linux kernel I've come across > "drivers/net/irda/nsc-ircc.ko" module. Here is a question that I came up > with while analyzing results. Lines are given using the info from Linux > v4.12. >

Re: [PATCH] net #9

2001-05-29 Thread Jean Tourrilhes
On Tue, May 29, 2001 at 09:13:34PM -0400, Jeff Garzik wrote: > > This is standard kernel cleanup that makes the resulting image smaller. > These patches have been going into all areas of the kernel for quite > some time. This doesn't make it right. Ok, while we are on the

Re: [PATCH] net #9

2001-05-29 Thread Jean Tourrilhes
On Tue, May 29, 2001 at 10:13:02PM -0400, Jeff Garzik wrote: > *shrug* Well, if you want to go against the kernel standard that's fine > with me. I won't put Andrzej's changes to your drivers upstream. You > are going to continually see patches to clean that up, though, because > it makes the

orinoco_cs & IrDA

2001-04-24 Thread Jean Tourrilhes
Hi Linus, I've got a question... I would like where to send my driver patches... One month ago, I sent a small update for the orinoco_cs driver and Wireless Extensions. I didn't put all the changes I had for orinoco_cs because I believe in small incremental updates

Re: orinoco_cs & IrDA

2001-04-24 Thread Jean Tourrilhes
On Tue, Apr 24, 2001 at 08:47:30PM +0100, Alan Cox wrote: > > patch (without feedback), whereas Alan picked it up (if I remember > > correctly it was included in his 'patch-2.4.2-ac28'). > > So now, what should I do with the rest of my updates and the > > new one that have accumulated since ?

Re: orinoco_cs & IrDA

2001-04-24 Thread Jean Tourrilhes
On Tue, Apr 24, 2001 at 03:15:08PM -0700, Jean Tourrilhes wrote: > [...] > Downloaded the patch again (patch-2.4.4-pre6), checked that it > was complete, my patch is in. Oups ! Do I feel stupid... Let's finish this story. As indicated above, the first fragment of the pat

Re: orinoco_cs & IrDA

2001-04-24 Thread Jean Tourrilhes
On Tue, Apr 24, 2001 at 03:56:37PM -0700, Jean Tourrilhes wrote: > On Tue, Apr 24, 2001 at 03:15:08PM -0700, Jean Tourrilhes wrote: > > > [...] > > Downloaded the patch again (patch-2.4.4-pre6), checked that it > > was complete, my patch is in. Oups ! Do I feel st

Re: orinoco_cs & IrDA

2001-04-24 Thread Jean Tourrilhes
On Tue, Apr 24, 2001 at 06:25:50PM -0700, Jean Tourrilhes wrote: > > Ok, now to the second chapter. These are all the changes > accumulated since the patch I sent one month ago (cf previous e-mail). > Changes : > o more Prism2/Symbol compat

2.4.2-ac3 and wavelan driver

2001-02-23 Thread Jean Tourrilhes
Hi Alan (and the others) A few notes related to you *-ac* patches, the IrDA stack and the Wavelan driver. First, IrDA : > --- linux.vanilla/net/irda/irlap.cThu Feb 22 09:06:21 2001 > +++ linux.ac/net/irda/irlap.c Wed Feb 21 11:55:26 2001 > @@ -51,6 +51,7 @@ > hashbin_t

Re: [patch] patch-2.4.2-irda1 (irda-usb)

2001-02-27 Thread Jean Tourrilhes
On Tue, Feb 27, 2001 at 01:58:11PM -0800, Greg KH wrote: > On Tue, Feb 27, 2001 at 08:32:28PM +, Dag Brattli wrote: > > > I'd recommend that this file be in the /drivers/usb directory, much like > > > almost all other USB drivers are. > > > > Yes, but do we want to spread the IrDA code

Nasty bug in the IrDA stack

2001-03-02 Thread Jean Tourrilhes
Hi, I've found a really convoluted bug in the IrDA stack (spend the week chasing it). As it is not trivial, I would like you to check and comment on my description and my fix. My patch definitely fix the problem on the PC where I was seeing it, and I can't crash it

Re : 16 potential locking bugs in 2.4.1 (wavelan patch attached)

2001-03-22 Thread Jean Tourrilhes
Andy Chou : > Here are some more results from the MC project. These are 16 errors found > in 2.4.1 related to inconsistent use of locks. As usual, if you can > verify any of these or show that they are false positives, please let us > know by CC'ing [EMAIL PROTECTED] > > -Andy Chou > >

Re : [CHECKER] 28 potential interrupt errors

2001-03-22 Thread Jean Tourrilhes
Junfeng Yang wrote : > Hi, > > Here are yet more results from the MC project. This checker looks for > inconsistent usage of interrupt functions. [...] > - > [BUG] error path > >

Re: Re : [CHECKER] 28 potential interrupt errors

2001-03-22 Thread Jean Tourrilhes
On Thu, Mar 22, 2001 at 03:49:31PM -0800, Junfeng Yang wrote: > > Sometimes the line number reported by the checker is not correct. > But if you go into the function, you can find the bug. Gotcha. It in fact indicate the error at the end of the function instead of the place where the

Re: [PATCH] net #9

2001-05-29 Thread Jean Tourrilhes
On Tue, May 29, 2001 at 09:47:19PM -0400, Jeff Garzik wrote: > > This is ANSI C standard stuff. If a static object with a scalar type is > not explicitly initialized, it is initialized to zero by default. > > Sure we can get gcc to recognize that case, but why use gcc to work > around code

Re: [PATCH] net #9

2001-05-29 Thread Jean Tourrilhes
On Wed, May 30, 2001 at 02:48:24AM +0200, Andrzej Krzysztofowicz wrote: > > The following patch removes some zero initializers from statics > > Andrzej If I were you, I would fix gcc rather than making my code unreadable. I write source code in C rather than coding ASM in hex

GlobeCom 2000 -> Networking papers

2000-12-08 Thread Jean Tourrilhes
Hi, I was a GlobeCom 2 weeks ago, and I noticed a few articles relevant to Linux networking that you might be interested in reading... On ECN : -- Archan Misra, John Baras & Teunis Ott. Generalised TCP Congestion Avoidance and its Effect on Bandwidth Sharing and

Re : Configuring synchronous interfaces in Linux

2000-12-08 Thread Jean Tourrilhes
Ivan Passos wrote : > For synchronous network interfaces, besides configuring network parameters > such as IP address, netmask, MTU, etc., the system should also configure > parameters specific to these sync i/f's, such as media (e.g V.35, X.21, > T1, E1), clock (internal or external, and

Re : [RFC-2] Configuring Synchronous Interfaces in Linux

2000-12-08 Thread Jean Tourrilhes
Alan wrote : > struct wireless_physical > struct wireless_80211 > struct wireless_auth Please do not underestimate 802.11 (and others). Even two cards based on the same MAC controller can have very different way

Wireless Extension update

2000-12-19 Thread Jean Tourrilhes
Hi Linus and Alan, This is a totally trivial update of the Wireless Extensions definition. It just adds a few more #define, so no troubles or pain expected. The patch attached applies cleanly to *both* 2.4.0-test12 and 2.2.18 (tested), and I would suggest including it in

Re: wavelan has fatal error with 2.4.0 (but worked in 2.4.0-test12)

2001-01-09 Thread Jean Tourrilhes
On Tue, Jan 09, 2001 at 07:17:01AM -0500, John Ruttenberg wrote: > I get: > > Jan 9 07:04:51 mojo cardmgr[511]: socket 1: Digital RoamAbout/DS > Jan 9 07:04:52 mojo cardmgr[511]: executing: 'modprobe wavelan_cs' > Jan 9 07:04:52 mojo cardmgr[511]: +

Re: wavelan has fatal error with 2.4.0 (but worked in 2.4.0-test12)

2001-01-09 Thread Jean Tourrilhes
On Tue, Jan 09, 2001 at 05:13:42PM +, Alan Cox wrote: > > This is a bug with the definition of udelay(). Somebody tried > > to be too clever with udelay(), and the end result is that it breaks > > perfectly good and valid code. > > Therefore, it should be reported as such on LKML, a

Re: wavelan has fatal error with 2.4.0 (but worked in 2.4.0-test12)

2001-01-09 Thread Jean Tourrilhes
On Tue, Jan 09, 2001 at 05:48:47PM +, Alan Cox wrote: > > > It is a bug in the driver. > > > > Please check again the code and point me the invalid > > udelay(). You will realise that there is no delay in the driver that > > is longer than 100ms. > > The udelay limit is set a lot lower

Re: [RANT] Linux-IrDA status

2000-11-07 Thread Jean Tourrilhes
On Tue, Nov 07, 2000 at 08:24:38PM -0500, Jeff Garzik wrote: > > Take a look at > http://www.uwsg.iu.edu/hypermail/linux/kernel/9908.0/0669.html This > happened with ISDN. Slightly different situation, but similar. I'm familiar with that. The *BIG* difference is that Dag has always

Re: The IrDA patches !!! (+ more flames)

2000-11-09 Thread Jean Tourrilhes
On Thu, Nov 09, 2000 at 07:24:04PM -0800, Jean Tourrilhes wrote: > > I spent my full day going through my archives and splitting > the big patch of Dag into lots of small patches (see attached). I'm > glad I've got a big hard drive full of junk. By the way, while I'

Re: The IrDA patches !!! (was Re: [RANT] Linux-IrDA status)

2000-11-10 Thread Jean Tourrilhes
On Fri, Nov 10, 2000 at 11:56:57AM -0800, Linus Torvalds wrote: > > When I say multiple mails, I mean multiple mails. NOT "26 attachements in > one mail". In fact, not a single attachment at all, please. Send me > patches as a regular text body, with the explanation at the top, and the > patch

Re: The IrDA patches !!! (was Re: [RANT] Linux-IrDA status)

2000-11-11 Thread Jean Tourrilhes
On Sat, Nov 11, 2000 at 06:43:26PM -0800, Linus Torvalds wrote: > > > Ok, thanks to the work of Jean, everything seems to be applied now. > > I'll make a test3 one of these days (probably tomorrow), please verify > that everything looks happy. > > Linus Linus,

Wireless Extension update...

2001-03-28 Thread Jean Tourrilhes
--- linux/include/linux/wireless.25.h Wed Mar 28 10:33:47 2001 +++ linux/include/linux/wireless.h Wed Mar 28 17:31:42 2001 @@ -1,7 +1,7 @@ /* * This file define a set of standard wireless extensions * - * Version : 9 16.10.99 + * Version : 11 28.3.01 * * Authors : Jean

Re: [IrDA] Oops with NULL deref in irda_device_set_media_busy

2005-04-05 Thread Jean Tourrilhes
On Tue, Apr 05, 2005 at 11:02:26AM +0200, Michal Rokos wrote: > Hello, > > I've problems with IrDA - when debug is off, I'm getting oops for obvious > reason... > (I don't have a log, this is just rewrite from screen: > EIP: irda_device_set_media_busy+0x15/0x40 [irda] >

Re: [IrDA] Oops with NULL deref in irda_device_set_media_busy

2005-04-06 Thread Jean Tourrilhes
On Wed, Apr 06, 2005 at 09:22:48AM +0200, Michal Rokos wrote: > Hello again, > > I'm gonna provide more info this time... > > > > When I turn debug on, I get just > > > Assertion failed! net/irda/irda_device.c:irda_device_set_media_busy:128 > > > self != NULL > > > > > > The obvious reason is

Re: [IrDA] Oops with NULL deref in irda_device_set_media_busy

2005-04-07 Thread Jean Tourrilhes
On Thu, Apr 07, 2005 at 08:22:52AM +0200, Michal Rokos wrote: > Hello, > > On Wednesday 06 April 2005 18:49, Jean Tourrilhes wrote: > > Patch attached. > > and is working fine - of course. > > Thank you for patience. :) > > Michal No, thank y

[PATCH 2.4] SIOCSIFNAME wildcard support

2005-02-03 Thread Jean Tourrilhes
Hi Marcelo, This patch adds wildcard support for the SIOCSIFNAME ioctl, like what was done in 2.6.1. SIOCSIFNAME allow a user space tool to change network interface names (such as nameif, ifrename, or ip link), this patch allow those tools to specify a pattern, such as "eth%d" or

[PATCH 2.4] Wireless Extension v17

2005-02-03 Thread Jean Tourrilhes
15:44:48.0 -0800 @@ -1,10 +1,10 @@ /* * This file define a set of standard wireless extensions * - * Version : 16 2.4.03 + * Version : 17 21.6.04 * * Authors : Jean Tourrilhes - HPL - <[EMAIL PROTECTED]> - * Copyright (c) 1997-2002 Jean Tourrilhes, All Rights Re

[PATCH 2.4] SIOCSIFNAME wildcard support (resend)

2005-02-08 Thread Jean Tourrilhes
Hi Marcelo, I did not receive any feedback on this e-mail, so I assume it was lost on the way. Would you mind pushing that in 2.4.x ? Thanks... Jean - Forwarded message from jt - Subject: [PATCH 2.4] SIOCSIFNAME wildcard support E-mail: [EMAIL PROTECTED]

[PATCH 2.4] Wireless Extension v17 (resend)

2005-02-08 Thread Jean Tourrilhes
2005-02-03 15:44:48.0 -0800 @@ -1,10 +1,10 @@ /* * This file define a set of standard wireless extensions * - * Version : 16 2.4.03 + * Version : 17 21.6.04 * * Authors : Jean Tourrilhes - HPL - <[EMAIL PROTECTED]> - * Copyright (c) 1997-2002 Jean Tourril

Re: [PATCH 2.4] Wireless Extension v17 (resend)

2005-02-08 Thread Jean Tourrilhes
On Tue, Feb 08, 2005 at 04:01:16PM -0200, Marcelo Tosatti wrote: > > Hi Jean, > > I'm very ignorant about wireless but it doesnt appear to me that "Wireless > Extension v17" > is a critical feature. You are right, it's not critical, and I was already thinking of not pushing WE-18 to

Re: [PATCH 2.4] SIOCSIFNAME wildcard support (resend)

2005-02-08 Thread Jean Tourrilhes
On Tue, Feb 08, 2005 at 02:24:22PM -0800, David S. Miller wrote: > On Tue, 8 Feb 2005 16:04:45 -0200 > Marcelo Tosatti <[EMAIL PROTECTED]> wrote: > > > On Tue, Feb 08, 2005 at 10:14:36AM -0800, Jean Tourrilhes wrote: > > > Hi Marcelo, > > > > > >

Re: [PATCH 2.4] Wireless Extension v17 (resend)

2005-02-08 Thread Jean Tourrilhes
On Tue, Feb 08, 2005 at 04:41:46PM -0200, Marcelo Tosatti wrote: > On Tue, Feb 08, 2005 at 01:51:12PM -0800, Jean Tourrilhes wrote: > > > > You are right, it's not critical, and I was already thinking > > of not pushing WE-18 to you (the WPA update). I'll stop updating 2

Re: [PATCH 2.4] Wireless Extension v17 (resend)

2005-02-08 Thread Jean Tourrilhes
On Tue, Feb 08, 2005 at 05:51:29PM -0800, Chris Wright wrote: > * Jean Tourrilhes ([EMAIL PROTECTED]) wrote: > > The first is the handling of spyoffset which is potentially > > unsafe. Unfortunately, the fix involve some API/infrastructure change, > > so is not transparent

  1   2   >