Re: [PATCH v3 -tip 5/5] AHCI: Support multiple MSIs

2012-10-02 Thread Jeff Garzik
On 10/02/2012 12:42 PM, Alexander Gordeev wrote: On Tue, Oct 02, 2012 at 07:09:29AM +0200, Ingo Molnar wrote: +irqreturn_t ahci_hw_interrupt(int irq, void *dev_instance) +{ + struct ata_port *ap_this = dev_instance; + struct ahci_port_priv *pp = ap_this-private_data; + struct

[git patches] libata fixes for 3.7

2012-10-02 Thread Jeff Garzik
@@ +/* + * Calxeda Highbank AHCI SATA platform driver + * Copyright 2012 Calxeda, Inc. + * + * based on the AHCI SATA platform driver by Jeff Garzik and Anton Vorontsov + * + * This program is free software; you can redistribute it and/or modify it + * under the terms and conditions of the GNU General

Re: [git patches] libata fixes for 3.7

2012-10-02 Thread Jeff Garzik
On 10/02/2012 03:44 PM, Michael Tokarev wrote: On 02.10.2012 23:40, Jeff Garzik wrote: Minor libata updates, nothing notable. 1) Apply -- and then revert -- the FUA feature. Caused disk corruption in linux-next, proving it cannot be turned on by default. Any details on that? Disk

[PATCH v0] Add SHA-3 hash algorithm

2012-10-02 Thread Jeff Garzik
Branch sha3 Repo git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/linux.git References: http://keccak.noekeon.org/ http://www.mjos.fi/dist/readable_keccak.tgz http://www.nist.gov/itl/csd/sha-100212.cfm Not-signed-off-by: Jeff Garzik jgar...@redhat.com crypto/Kconfig

Re: [PATCH v3 -tip 5/5] AHCI: Support multiple MSIs

2012-10-01 Thread Jeff Garzik
On 10/02/2012 12:21 AM, Bjorn Helgaas wrote: On Mon, Oct 1, 2012 at 9:04 PM, Jeff Garzik wrote: On 10/01/2012 04:13 AM, Alexander Gordeev wrote: Take advantage of multiple MSIs implementation on x86 - on systems with IRQ remapping AHCI ports not only get assigned separate MSI vectors

Re: [PATCH v3 -tip 5/5] AHCI: Support multiple MSIs

2012-10-01 Thread Jeff Garzik
|6 +++ drivers/ata/libahci.c | 118 ++--- 3 files changed, 205 insertions(+), 10 deletions(-) Acked-by: Jeff Garzik Normally, this amount of changes would -really- need to go through the libata tree. However, given the amount of dependencies

Re: [PATCH v3 -tip 5/5] AHCI: Support multiple MSIs

2012-10-01 Thread Jeff Garzik
-- drivers/ata/ahci.h|6 +++ drivers/ata/libahci.c | 118 ++--- 3 files changed, 205 insertions(+), 10 deletions(-) Acked-by: Jeff Garzik jgar...@redhat.com Normally, this amount of changes would -really- need to go through the libata tree. However

Re: [PATCH v3 -tip 5/5] AHCI: Support multiple MSIs

2012-10-01 Thread Jeff Garzik
On 10/02/2012 12:21 AM, Bjorn Helgaas wrote: On Mon, Oct 1, 2012 at 9:04 PM, Jeff Garzik jgar...@pobox.com wrote: On 10/01/2012 04:13 AM, Alexander Gordeev wrote: Take advantage of multiple MSIs implementation on x86 - on systems with IRQ remapping AHCI ports not only get assigned separate

Re: [SCSI PATCH] sd: max-retries becomes configurable

2012-09-26 Thread Jeff Garzik
On 09/25/2012 06:38 AM, James Bottomley wrote: On Tue, 2012-09-25 at 01:21 -0400, Jeff Garzik wrote: Can you be more specific about sysfs location? A runtime-writable (via sysfs!) module parameter for a module-wide default seemed appropriate. Well, if it's really important, the same thing

Re: [PATCH v2 -tip 5/5] AHCI: Support multiple MSIs

2012-09-26 Thread Jeff Garzik
On 09/03/2012 05:20 AM, Alexander Gordeev wrote: Take advantage of multiple MSIs implementation on x86 - on systems with IRQ remapping AHCI ports not only get assigned separate MSI vectors - but also separate IRQs. As result, interrupts generated by different ports could be serviced on different

Re: [PATCH v2 -tip 5/5] AHCI: Support multiple MSIs

2012-09-26 Thread Jeff Garzik
On 09/03/2012 05:20 AM, Alexander Gordeev wrote: Take advantage of multiple MSIs implementation on x86 - on systems with IRQ remapping AHCI ports not only get assigned separate MSI vectors - but also separate IRQs. As result, interrupts generated by different ports could be serviced on different

Re: [SCSI PATCH] sd: max-retries becomes configurable

2012-09-26 Thread Jeff Garzik
On 09/25/2012 06:38 AM, James Bottomley wrote: On Tue, 2012-09-25 at 01:21 -0400, Jeff Garzik wrote: Can you be more specific about sysfs location? A runtime-writable (via sysfs!) module parameter for a module-wide default seemed appropriate. Well, if it's really important, the same thing

Re: [SCSI PATCH] sd: max-retries becomes configurable

2012-09-24 Thread Jeff Garzik
On 09/25/2012 12:06 AM, James Bottomley wrote: On Mon, 2012-09-24 at 17:00 -0400, Jeff Garzik wrote: drivers/scsi/sd.c |4 drivers/scsi/sd.h |2 +- 2 files changed, 5 insertions(+), 1 deletion(-) I'm not opposed in principle to doing this (except that it should be a sysfs

Re: [PATCH] ahci: add a boot option to enable promise ahci

2012-09-24 Thread Jeff Garzik
On 09/23/2012 10:34 PM, Tony Hung - PTT 洪瑞嶸 wrote: > linux-3.2.0/drivers/ata/ahci.c: In function 'hptiop_host_request_callback': > > Use min_t(size_t, ...) to fix. > > Signed-off-by: Tony Hung > --- > > diff --git a/linux-3.2.0/drivers/ata/ahci.c b/linux-3.2.0/drivers/ata/ahci.c > ---

[SCSI PATCH] sd: max-retries becomes configurable

2012-09-24 Thread Jeff Garzik
drivers/scsi/sd.c |4 drivers/scsi/sd.h |2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 4df73e5..d15074b 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -92,6 +92,10 @@ MODULE_ALIAS_SCSI_DEVICE(TYPE_DISK);

[SCSI PATCH] sd: max-retries becomes configurable

2012-09-24 Thread Jeff Garzik
drivers/scsi/sd.c |4 drivers/scsi/sd.h |2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 4df73e5..d15074b 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -92,6 +92,10 @@ MODULE_ALIAS_SCSI_DEVICE(TYPE_DISK);

Re: [PATCH] ahci: add a boot option to enable promise ahci

2012-09-24 Thread Jeff Garzik
On 09/23/2012 10:34 PM, Tony Hung - PTT 洪瑞嶸 wrote: linux-3.2.0/drivers/ata/ahci.c: In function 'hptiop_host_request_callback': Use min_t(size_t, ...) to fix. Signed-off-by: Tony Hung tony.h...@tw.promise.com --- diff --git a/linux-3.2.0/drivers/ata/ahci.c

Re: [SCSI PATCH] sd: max-retries becomes configurable

2012-09-24 Thread Jeff Garzik
On 09/25/2012 12:06 AM, James Bottomley wrote: On Mon, 2012-09-24 at 17:00 -0400, Jeff Garzik wrote: drivers/scsi/sd.c |4 drivers/scsi/sd.h |2 +- 2 files changed, 5 insertions(+), 1 deletion(-) I'm not opposed in principle to doing this (except that it should be a sysfs

Re: linux-next: Tree for Sept 14 (sata_highhbank)

2012-09-14 Thread Jeff Garzik
On Fri, Sep 14, 2012 at 11:02 PM, Mark Langsdorf wrote: > Fix patch follows. Do I need to submit it as a separate patch or is this > sufficient? You appear to have submitted it as a separate patch just now ;p Will queue and push to libata-dev.git#upstream (and thus linux-next) Jeff -- To

Re: linux-next: Tree for Sept 14 (sata_highhbank)

2012-09-14 Thread Jeff Garzik
On Fri, Sep 14, 2012 at 11:02 PM, Mark Langsdorf mark.langsd...@calxeda.com wrote: Fix patch follows. Do I need to submit it as a separate patch or is this sufficient? You appear to have submitted it as a separate patch just now ;p Will queue and push to libata-dev.git#upstream (and thus

[git patches] libata new PCI IDs

2012-09-12 Thread Jeff Garzik
Please pull 7b4f6ecacb14f384adc1a5a67ad95eb082c02bd1 from git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git tags/upstream-linus to receive the following updates: drivers/ata/ahci.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) Alan Cox (2):

Re: [PATCH 2/2] [trivial] Documentation: broken URL in libata

2012-09-12 Thread Jeff Garzik
On 02/13/2012 12:22 PM, Randy Dunlap wrote: On 02/13/2012 01:09 AM, Michael Opdenacker wrote: Fix broken link to license text: http://www.opensource.org/licenses/osl-1.1.txt The text for version 1.1 of the Open Sofware license doesn't seem to be available anywhere on http://www.opensource.org/

Re: [PATCH 2/2] [trivial] Documentation: broken URL in libata

2012-09-12 Thread Jeff Garzik
On 02/13/2012 12:22 PM, Randy Dunlap wrote: On 02/13/2012 01:09 AM, Michael Opdenacker wrote: Fix broken link to license text: http://www.opensource.org/licenses/osl-1.1.txt The text for version 1.1 of the Open Sofware license doesn't seem to be available anywhere on http://www.opensource.org/

[git patches] libata new PCI IDs

2012-09-12 Thread Jeff Garzik
Please pull 7b4f6ecacb14f384adc1a5a67ad95eb082c02bd1 from git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git tags/upstream-linus to receive the following updates: drivers/ata/ahci.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) Alan Cox (2):

Re: [PATCH 15/16] ARM: samsung: move platform_data definitions

2012-09-11 Thread Jeff Garzik
Kim Cc: Kyungmin Park Cc: Ben Dooks Cc: Mark Brown Cc: Jeff Garzik Cc: Guenter Roeck Cc: "Wolfram Sang (embedded platforms)" Cc: Dmitry Torokhov Cc: Bryan Wu Cc: Richard Purdie Cc: Sylwester Nawrocki Cc: Mauro Carvalho Chehab Cc: Chris Ball Cc: David Woodhouse Cc: Grant

Re: [PATCH 15/16] ARM: samsung: move platform_data definitions

2012-09-11 Thread Jeff Garzik
Cc: Kukjin Kim kgene@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Ben Dooks ben-li...@fluff.org Cc: Mark Brown broo...@opensource.wolfsonmicro.com Cc: Jeff Garzik jgar...@pobox.com Cc: Guenter Roeck li...@roeck-us.net Cc: Wolfram Sang (embedded platforms) w.s...@pengutronix.de Cc

Re: Storage related regression in linux-next 20120824

2012-09-09 Thread Jeff Garzik
On 09/09/2012 04:36 PM, Hugh Dickins wrote: On Sun, Sep 9, 2012 at 1:28 PM, Jeff Garzik wrote: I'll send Linus a patch to disable. Thanks, but no, the change in question hasn't reached Linus yet, it's just a linux-next or mmotm thing - isn't it? Yep, libata-dev#upstream. Sorry, got my own

Re: [RFC][PATCH] libata: enable SATA disk fua detection on default

2012-09-09 Thread Jeff Garzik
On 09/09/2012 04:34 PM, Arvydas Sidorenko wrote: Meanwhile there already has a number of SATA disks that have supported this feature. So I think maybe we can enable it. Regards, Zheng Blindly enabling FUA by default in my opinion is not a good idea at all. I believe the focus should be on

Re: Storage related regression in linux-next 20120824

2012-09-09 Thread Jeff Garzik
That needs to modify initrd file. So it is inconvenient for administrator who needs to manage a huge number of servers. Signed-off-by: Zheng Liu Signed-off-by: Jeff Garzik diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 5eee1c1..c3fbdca 100644 --- a/drivers/

Re: Storage related regression in linux-next 20120824

2012-09-09 Thread Jeff Garzik
. That needs to modify initrd file. So it is inconvenient for administrator who needs to manage a huge number of servers. Signed-off-by: Zheng Liu wenqing...@taobao.com Signed-off-by: Jeff Garzik jgar...@redhat.com diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c

Re: [RFC][PATCH] libata: enable SATA disk fua detection on default

2012-09-09 Thread Jeff Garzik
On 09/09/2012 04:34 PM, Arvydas Sidorenko wrote: Meanwhile there already has a number of SATA disks that have supported this feature. So I think maybe we can enable it. Regards, Zheng Blindly enabling FUA by default in my opinion is not a good idea at all. I believe the focus should be on

Re: Storage related regression in linux-next 20120824

2012-09-09 Thread Jeff Garzik
On 09/09/2012 04:36 PM, Hugh Dickins wrote: On Sun, Sep 9, 2012 at 1:28 PM, Jeff Garzik jgar...@pobox.com wrote: I'll send Linus a patch to disable. Thanks, but no, the change in question hasn't reached Linus yet, it's just a linux-next or mmotm thing - isn't it? Yep, libata-dev#upstream

Re: Drop support for x86-32

2012-08-29 Thread Jeff Garzik
On Wed, Aug 29, 2012 at 7:03 PM, Mark Lord wrote: > On 12-08-26 10:15 AM, wbrana wrote: >> On 8/26/12, Mark Lord wrote: >>> Here are a couple of real scenarios you don't seem to have thought about. >>> A 32-bit kernel on a legacy (or even new) system in 2017 will still need >>> regular kernel

Re: Drop support for x86-32

2012-08-29 Thread Jeff Garzik
On Wed, Aug 29, 2012 at 7:03 PM, Mark Lord ker...@teksavvy.com wrote: On 12-08-26 10:15 AM, wbrana wrote: On 8/26/12, Mark Lord ker...@teksavvy.com wrote: Here are a couple of real scenarios you don't seem to have thought about. A 32-bit kernel on a legacy (or even new) system in 2017 will

Re: [PATCH] Remove CONFIG_EXPERIMENTAL

2012-08-28 Thread Jeff Garzik
On Mon, Aug 27, 2012 at 5:53 PM, Kees Cook wrote: > This config item has not carried much meaning for a while now and is > almost always enabled by default. Remove it and adjust various config > logic and documentation. It does have meaning... !CONFIG_EXPERIMENTAL means more stable. In the

Re: [PATCH] Remove CONFIG_EXPERIMENTAL

2012-08-28 Thread Jeff Garzik
On Mon, Aug 27, 2012 at 5:53 PM, Kees Cook keesc...@chromium.org wrote: This config item has not carried much meaning for a while now and is almost always enabled by default. Remove it and adjust various config logic and documentation. It does have meaning... !CONFIG_EXPERIMENTAL means more

Re: Storage related regression in linux-next 20120824

2012-08-27 Thread Jeff Garzik
On Mon, Aug 27, 2012 at 4:59 AM, Arvydas Sidorenko wrote: > linux-next 20120824 introduced regression on Mac mini 2011 - /root partition > gets mounted as read-only and it stays so even when trying to reboot into > previously working kernel. In order to make it work on older kernel again > `fsck`

Re: Storage related regression in linux-next 20120824

2012-08-27 Thread Jeff Garzik
On Mon, Aug 27, 2012 at 4:59 AM, Arvydas Sidorenko asi...@gmail.com wrote: linux-next 20120824 introduced regression on Mac mini 2011 - /root partition gets mounted as read-only and it stays so even when trying to reboot into previously working kernel. In order to make it work on older kernel

[git patches] libata fixes

2012-08-25 Thread Jeff Garzik
Arnd Hannemann (1): pata_atiixp: override cable detection on MSI E350DM-E33 James Ralston (2): ahci: Add Device IDs for Intel Lynx Point-LP PCH ata_piix: Add Device IDs for Intel Lynx Point-LP PCH Jeff Garzik (1): [libata] new quirk, lift bridge limits for Buffalo

[git patches] libata fixes

2012-08-25 Thread Jeff Garzik
Arnd Hannemann (1): pata_atiixp: override cable detection on MSI E350DM-E33 James Ralston (2): ahci: Add Device IDs for Intel Lynx Point-LP PCH ata_piix: Add Device IDs for Intel Lynx Point-LP PCH Jeff Garzik (1): [libata] new quirk, lift bridge limits for Buffalo

Re: [GIT PULL] tpmdd: TPM drivers, tpm-rng and fixes

2012-08-22 Thread Jeff Garzik
On 08/22/2012 05:52 PM, Kent Yoder wrote: Hi James, The following changes since commit 51b743fe87d7fb3dba7a2ff4a1fe23bb65dc2245: Merge tag 'v3.6-rc2' into next (2012-08-17 20:42:30 +1000) are available in the git repository at: git://github.com/shpedoikal/linux.git v3.6-rc2-tpmdd

Re: [PATCH v6 12/13] block: Add bio_clone_bioset(), bio_clone_kmalloc()

2012-08-22 Thread Jeff Garzik
() and bio_clone_kmalloc() as wrappers around it, making use of the functionality the last patch adedd. This will also help in a later patch changing how bio cloning works. Signed-off-by: Kent Overstreet CC: Jens Axboe CC: NeilBrown CC: Alasdair Kergon CC: Boaz Harrosh CC: Jeff Garzik --- block/blk-core.c

Re: [PATCH v6 12/13] block: Add bio_clone_bioset(), bio_clone_kmalloc()

2012-08-22 Thread Jeff Garzik
a...@redhat.com CC: Boaz Harrosh bharr...@panasas.com CC: Jeff Garzik j...@garzik.org --- block/blk-core.c | 8 +--- drivers/block/osdblk.c | 3 +-- drivers/md/dm.c| 4 ++-- drivers/md/md.c| 20 +--- fs/bio.c | 13 - fs/exofs/ore.c

Re: [GIT PULL] tpmdd: TPM drivers, tpm-rng and fixes

2012-08-22 Thread Jeff Garzik
On 08/22/2012 05:52 PM, Kent Yoder wrote: Hi James, The following changes since commit 51b743fe87d7fb3dba7a2ff4a1fe23bb65dc2245: Merge tag 'v3.6-rc2' into next (2012-08-17 20:42:30 +1000) are available in the git repository at: git://github.com/shpedoikal/linux.git v3.6-rc2-tpmdd

Re: [PATCH 0/2] ata: Updates for pata_octeon_cf driver.

2012-08-17 Thread Jeff Garzik
(-) patches 1 and 2 are Acked-by: Jeff Garzik -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v3 2/2] ata: implement MODE SELECT command

2012-08-17 Thread Jeff Garzik
MODE SELECT (for the caching page only) to the ATA SET FEATURES command. The set of changeable parameters answered by MODE SENSE is also adjusted accordingly. Cc: Sergei Shtylyov Cc: Jeff Garzik Signed-off-by: Paolo Bonzini --- v2->v3: ensure that only the first page of the sg l

Enabling FUA for SATA drives (was Re: [RFC][PATCH] libata: enable SATA disk fua detection on default)

2012-08-17 Thread Jeff Garzik
: Jeff Garzik Signed-off-by: Zheng Liu --- drivers/ata/libata-core.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 23763a1..3627251 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c

Re: [PATCH] libata: acpi: call ata_acpi_gtm during ata port init time

2012-08-17 Thread Jeff Garzik
On 08/15/2012 05:08 AM, Aaron Lu wrote: Commit 30dcf76acc695cbd2fa919e294670fe9552e16e7 mistakenly dropped the code to get an initial gtm for the IDE channel. This caused the following problem for Sergei: http://marc.info/?l=linux-kernel=134484963618457=2 Fix this by adding the call back in

Re: [PATCH 2/5] ata_piix: Add Device IDs for Intel Lynx Point-LP PCH

2012-08-17 Thread Jeff Garzik
On 08/09/2012 12:34 PM, james.d.rals...@intel.com wrote: From: James Ralston This patch adds the IDE-mode SATA Device IDs for the Intel Lynx Point-LP PCH Signed-off-by: James Ralston --- drivers/ata/ata_piix.c |8 1 files changed, 8 insertions(+), 0 deletions(-) applied

Re: [PATCH] pata_atiixp: override cable detection on MSI E350DM-E33

2012-08-17 Thread Jeff Garzik
On 08/17/2012 04:11 AM, Arnd Hannemann wrote: The mainboard MSI E350DM-E33 is advertised with 6 SATA ports. As it turns out, two of them seem to be driven by on-board SATA<->PATA converters. If a disk drive is connected to one of them kernel uses UDMA/33 mode due to cable detection: [

Re: [PATCH 1/5] ahci: Add Device IDs for Intel Lynx Point-LP PCH

2012-08-17 Thread Jeff Garzik
On 08/09/2012 12:02 PM, james.d.rals...@intel.com wrote: From: James Ralston This patch adds the AHCI-mode SATA Device IDs for the Intel Lynx Point-LP PCH Signed-off-by: James Ralston --- drivers/ata/ahci.c |8 1 files changed, 8 insertions(+), 0 deletions(-) applied --

Re: [PATCH] pata_atiixp: override cable detection on MSI E350DM-E33

2012-08-17 Thread Jeff Garzik
On 08/17/2012 04:11 AM, Arnd Hannemann wrote: The mainboard MSI E350DM-E33 is advertised with 6 SATA ports. As it turns out, two of them seem to be driven by on-board SATA-PATA converters. If a disk drive is connected to one of them kernel uses UDMA/33 mode due to cable detection: [

Re: [PATCH 1/5] ahci: Add Device IDs for Intel Lynx Point-LP PCH

2012-08-17 Thread Jeff Garzik
On 08/09/2012 12:02 PM, james.d.rals...@intel.com wrote: From: James Ralston james.d.rals...@intel.com This patch adds the AHCI-mode SATA Device IDs for the Intel Lynx Point-LP PCH Signed-off-by: James Ralston james.d.rals...@intel.com --- drivers/ata/ahci.c |8 1 files

Re: [PATCH 2/5] ata_piix: Add Device IDs for Intel Lynx Point-LP PCH

2012-08-17 Thread Jeff Garzik
On 08/09/2012 12:34 PM, james.d.rals...@intel.com wrote: From: James Ralston james.d.rals...@intel.com This patch adds the IDE-mode SATA Device IDs for the Intel Lynx Point-LP PCH Signed-off-by: James Ralston james.d.rals...@intel.com --- drivers/ata/ata_piix.c |8 1 files

Re: [PATCH] libata: acpi: call ata_acpi_gtm during ata port init time

2012-08-17 Thread Jeff Garzik
On 08/15/2012 05:08 AM, Aaron Lu wrote: Commit 30dcf76acc695cbd2fa919e294670fe9552e16e7 mistakenly dropped the code to get an initial gtm for the IDE channel. This caused the following problem for Sergei: http://marc.info/?l=linux-kernelm=134484963618457w=2 Fix this by adding the call back in

Enabling FUA for SATA drives (was Re: [RFC][PATCH] libata: enable SATA disk fua detection on default)

2012-08-17 Thread Jeff Garzik
number of servers. CC: Jeff Garzik j...@garzik.org Signed-off-by: Zheng Liu wenqing...@taobao.com --- drivers/ata/libata-core.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 23763a1..3627251 100644

Re: [PATCH v3 2/2] ata: implement MODE SELECT command

2012-08-17 Thread Jeff Garzik
MODE SELECT (for the caching page only) to the ATA SET FEATURES command. The set of changeable parameters answered by MODE SENSE is also adjusted accordingly. Cc: Sergei Shtylyov sshtyl...@mvista.com Cc: Jeff Garzik jgar...@pobox.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- v2-v3

Re: [PATCH 0/2] ata: Updates for pata_octeon_cf driver.

2012-08-17 Thread Jeff Garzik
insertions(+), 246 deletions(-) patches 1 and 2 are Acked-by: Jeff Garzik jgar...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [GIT PULL] Update LZO compression

2012-08-16 Thread Jeff Garzik
On 08/16/2012 12:20 PM, Andi Kleen wrote: If you think a little bit, I bet you could come up with a solution that operates at cacheline-aligned granularity, something that would be _even faster_ than simply fixing the code to do aligned accesses. Cache aligned compression is unlikely to

Re: [PATCH 0/5] x86, MSI, AHCI: Support multiple MSIs

2012-08-16 Thread Jeff Garzik
On 08/16/2012 10:45 AM, Alexander Gordeev wrote: Currently multiple MSI mode is limited to a single vector per device (at least on x86 and PPC). This series breathes life into pci_enable_msi_block() and makes it possible to set interrupt affinity for multiple IRQs, similarly to MSI-X. Yet, only

Re: [patch] [SCSI] mvsas: fix a && vs & bug

2012-08-16 Thread Jeff Garzik
On 08/16/2012 07:04 AM, Dan Carpenter wrote: The "1 << (slot_idx % 32)" condition is always true. The intent was to test a bit field here using bitwise AND. We do the test correctly a few lines later in the do while loop. Signed-off-by: Dan Carpenter Acked

Re: [GIT PULL] Update LZO compression

2012-08-16 Thread Jeff Garzik
On 08/16/2012 02:27 AM, Markus F.X.J. Oberhumer wrote: On 2012-08-15 16:45, Johannes Stezenbach wrote: On Wed, Aug 15, 2012 at 02:02:43PM +0200, Markus F.X.J. Oberhumer wrote: On 2012-08-14 14:39, Johannes Stezenbach wrote: On Tue, Aug 14, 2012 at 01:44:02AM +0200, Markus F.X.J. Oberhumer

Re: [GIT PULL] Update LZO compression

2012-08-16 Thread Jeff Garzik
On 08/16/2012 02:27 AM, Markus F.X.J. Oberhumer wrote: On 2012-08-15 16:45, Johannes Stezenbach wrote: On Wed, Aug 15, 2012 at 02:02:43PM +0200, Markus F.X.J. Oberhumer wrote: On 2012-08-14 14:39, Johannes Stezenbach wrote: On Tue, Aug 14, 2012 at 01:44:02AM +0200, Markus F.X.J. Oberhumer

Re: [patch] [SCSI] mvsas: fix a vs bug

2012-08-16 Thread Jeff Garzik
On 08/16/2012 07:04 AM, Dan Carpenter wrote: The 1 (slot_idx % 32) condition is always true. The intent was to test a bit field here using bitwise AND. We do the test correctly a few lines later in the do while loop. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Acked-by: Jeff

Re: [PATCH 0/5] x86, MSI, AHCI: Support multiple MSIs

2012-08-16 Thread Jeff Garzik
On 08/16/2012 10:45 AM, Alexander Gordeev wrote: Currently multiple MSI mode is limited to a single vector per device (at least on x86 and PPC). This series breathes life into pci_enable_msi_block() and makes it possible to set interrupt affinity for multiple IRQs, similarly to MSI-X. Yet, only

Re: [GIT PULL] Update LZO compression

2012-08-16 Thread Jeff Garzik
On 08/16/2012 12:20 PM, Andi Kleen wrote: If you think a little bit, I bet you could come up with a solution that operates at cacheline-aligned granularity, something that would be _even faster_ than simply fixing the code to do aligned accesses. Cache aligned compression is unlikely to

Re: [PATCH v4 4/7] scsi: sr: block events when runtime suspended

2012-08-03 Thread Jeff Garzik
On 08/03/2012 05:50 AM, Aaron Lu wrote: Hello, Not sure if I should use EXPORT_SYMBOL or EXPORT_SYMBOL_GPL, any comments? Typically you follow the pattern of similar exports in the file (or in the API, if no others are in the file). Jeff -- To unsubscribe from this list: send

Re: [PATCH v4 4/7] scsi: sr: block events when runtime suspended

2012-08-03 Thread Jeff Garzik
On 08/03/2012 05:50 AM, Aaron Lu wrote: Hello, Not sure if I should use EXPORT_SYMBOL or EXPORT_SYMBOL_GPL, any comments? Typically you follow the pattern of similar exports in the file (or in the API, if no others are in the file). Jeff -- To unsubscribe from this list: send

Re: [PATCH] NVMe: Add a character device for each nvme device

2012-07-27 Thread Jeff Garzik
On 07/27/2012 04:26 PM, Matthew Wilcox wrote: Maybe we should design such a mechanism, but maybe we shouldn't ... as we find common things to do, we tend to move those to sysfs, not ioctls, and the kinds of commands that are being sent here are essentially vendor-specific NVMe commands; it's not

Re: [PATCH] NVMe: Add a character device for each nvme device

2012-07-27 Thread Jeff Garzik
On 07/27/2012 02:12 PM, Matthew Wilcox wrote: On Fri, Jul 27, 2012 at 10:44:18AM -0600, Keith Busch wrote: Registers a character device for the nvme module and creates character files as /dev/nvmeN for each nvme device probed, where N is the device instance. The character devices support nvme

An Andre To Remember

2012-07-27 Thread Jeff Garzik
rock. Seek life. Life is so much more than code. Rest in peace Andre, Jeff Garzik friend and libata author PS. Remembering Andre website: http://hedrick4419.blogspot.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messa

An Andre To Remember

2012-07-27 Thread Jeff Garzik
in peace Andre, Jeff Garzik friend and libata author PS. Remembering Andre website: http://hedrick4419.blogspot.com/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] NVMe: Add a character device for each nvme device

2012-07-27 Thread Jeff Garzik
On 07/27/2012 02:12 PM, Matthew Wilcox wrote: On Fri, Jul 27, 2012 at 10:44:18AM -0600, Keith Busch wrote: Registers a character device for the nvme module and creates character files as /dev/nvmeN for each nvme device probed, where N is the device instance. The character devices support nvme

Re: [PATCH] NVMe: Add a character device for each nvme device

2012-07-27 Thread Jeff Garzik
On 07/27/2012 04:26 PM, Matthew Wilcox wrote: Maybe we should design such a mechanism, but maybe we shouldn't ... as we find common things to do, we tend to move those to sysfs, not ioctls, and the kinds of commands that are being sent here are essentially vendor-specific NVMe commands; it's not

Re: Andre Hedrick (anhedric) has died

2012-07-26 Thread Jeff Garzik
On 07/20/2012 12:39 AM, Nate Lawson wrote: Dear Linux hackers, Sorry for the intrusion on this technical list. I wanted to let Andre's fellow Linux developers know that he died this past weekend. For those that don't know him, Andre was an active developer for the ATA driver a while back. I

Re: [PATCH v3 0/7] ZPODD patches for scsi tree

2012-07-26 Thread Jeff Garzik
On 07/26/2012 10:41 AM, Aaron Lu wrote: On Thu, Jul 26, 2012 at 09:43:37AM -0400, Jeff Garzik wrote: On 07/26/2012 06:05 AM, Aaron Lu wrote: I can't set a flag in libata-acpi.c since a related function is missing in scsi-misc tree. Will fix this when 3.6-rc1 released. What does this mean

Re: [PATCH v2 0/2] ata: MODE SELECT implementation

2012-07-26 Thread Jeff Garzik
On 07/26/2012 03:25 AM, Paolo Bonzini wrote: Il 05/07/2012 11:40, Paolo Bonzini ha scritto: This is a revised version of the MODE SELECT implementation from yesterday, augmented with support for changeable parameter requests in MODE SENSE. Paolo Bonzini (2): ata: support MODE SENSE request

Re: [PATCH v3 0/7] ZPODD patches for scsi tree

2012-07-26 Thread Jeff Garzik
On 07/26/2012 06:05 AM, Aaron Lu wrote: v3: Rebase on top of scsi-misc tree; Add the sr related patches previously in Jeff's libata tree; Re-organize the sr patches. A problem for now: for patch scsi: sr: support zero power ODD(ZPODD) I can't set a flag in libata-acpi.c since a related function

Re: [PATCH v3 0/7] ZPODD patches for scsi tree

2012-07-26 Thread Jeff Garzik
On 07/26/2012 06:05 AM, Aaron Lu wrote: v3: Rebase on top of scsi-misc tree; Add the sr related patches previously in Jeff's libata tree; Re-organize the sr patches. A problem for now: for patch scsi: sr: support zero power ODD(ZPODD) I can't set a flag in libata-acpi.c since a related function

Re: [PATCH v2 0/2] ata: MODE SELECT implementation

2012-07-26 Thread Jeff Garzik
On 07/26/2012 03:25 AM, Paolo Bonzini wrote: Il 05/07/2012 11:40, Paolo Bonzini ha scritto: This is a revised version of the MODE SELECT implementation from yesterday, augmented with support for changeable parameter requests in MODE SENSE. Paolo Bonzini (2): ata: support MODE SENSE request

Re: [PATCH v3 0/7] ZPODD patches for scsi tree

2012-07-26 Thread Jeff Garzik
On 07/26/2012 10:41 AM, Aaron Lu wrote: On Thu, Jul 26, 2012 at 09:43:37AM -0400, Jeff Garzik wrote: On 07/26/2012 06:05 AM, Aaron Lu wrote: I can't set a flag in libata-acpi.c since a related function is missing in scsi-misc tree. Will fix this when 3.6-rc1 released. What does this mean

Re: Andre Hedrick (anhedric) has died

2012-07-26 Thread Jeff Garzik
On 07/20/2012 12:39 AM, Nate Lawson wrote: Dear Linux hackers, Sorry for the intrusion on this technical list. I wanted to let Andre's fellow Linux developers know that he died this past weekend. For those that don't know him, Andre was an active developer for the ATA driver a while back. I

Re: [git patches] libata updates

2012-07-25 Thread Jeff Garzik
On 07/25/2012 07:30 PM, Linus Torvalds wrote: On Wed, Jul 25, 2012 at 3:58 PM, Jeff Garzik wrote: What is the right course in when a post-merge change is needed? Just describe the issue and the required change. Than I can just do it as part of the merge, and now the whole series

Re: [git patches] libata updates

2012-07-25 Thread Jeff Garzik
On 07/25/2012 06:31 PM, Linus Torvalds wrote: On Wed, Jul 25, 2012 at 3:26 PM, Jeff Garzik wrote: Even so, separately, it still needed that post-merge compile fix. And that's yet another example of how *NOT* to do things. If the merge has errors like that, then they should be fixed up

Re: [git patches] libata updates

2012-07-25 Thread Jeff Garzik
On 07/25/2012 06:06 PM, Linus Torvalds wrote: On Wed, Jul 25, 2012 at 1:43 PM, Jeff Garzik wrote: On Wed, Jul 25, 2012 at 04:35:51PM -0400, Jeff Garzik wrote: Please pull 641589bff714f39b33ef1d7f02eaa009f2993b64 from git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git tags

Re: [git patches] libata updates

2012-07-25 Thread Jeff Garzik
On 07/25/2012 04:35 PM, Jeff Garzik wrote: Please pull 641589bff714f39b33ef1d7f02eaa009f2993b64 from git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git tags/upstream (text copied from the upstream-linus tag) Notable changes: * Updating libata to directly bind with ACPI

Re: [git patches] libata updates

2012-07-25 Thread Jeff Garzik
On Wed, Jul 25, 2012 at 04:35:51PM -0400, Jeff Garzik wrote: > Please pull 641589bff714f39b33ef1d7f02eaa009f2993b64 from > git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git > tags/upstream > Oh, I forgot to point out the merge commit, making my HEAD more recen

Re: [git patches] libata updates

2012-07-25 Thread Jeff Garzik
On Wed, Jul 25, 2012 at 04:35:51PM -0400, Jeff Garzik wrote: Please pull 641589bff714f39b33ef1d7f02eaa009f2993b64 from git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git tags/upstream Oh, I forgot to point out the merge commit, making my HEAD more recent than might

Re: [git patches] libata updates

2012-07-25 Thread Jeff Garzik
On 07/25/2012 04:35 PM, Jeff Garzik wrote: Please pull 641589bff714f39b33ef1d7f02eaa009f2993b64 from git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git tags/upstream (text copied from the upstream-linus tag) Notable changes: * Updating libata to directly bind with ACPI

Re: [git patches] libata updates

2012-07-25 Thread Jeff Garzik
On 07/25/2012 06:06 PM, Linus Torvalds wrote: On Wed, Jul 25, 2012 at 1:43 PM, Jeff Garzik j...@garzik.org wrote: On Wed, Jul 25, 2012 at 04:35:51PM -0400, Jeff Garzik wrote: Please pull 641589bff714f39b33ef1d7f02eaa009f2993b64 from git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata

Re: [git patches] libata updates

2012-07-25 Thread Jeff Garzik
On 07/25/2012 06:31 PM, Linus Torvalds wrote: On Wed, Jul 25, 2012 at 3:26 PM, Jeff Garzik jgar...@pobox.com wrote: Even so, separately, it still needed that post-merge compile fix. And that's yet another example of how *NOT* to do things. If the merge has errors like that, then they should

Re: [git patches] libata updates

2012-07-25 Thread Jeff Garzik
On 07/25/2012 07:30 PM, Linus Torvalds wrote: On Wed, Jul 25, 2012 at 3:58 PM, Jeff Garzik jgar...@pobox.com wrote: What is the right course in when a post-merge change is needed? Just describe the issue and the required change. Than I can just do it as part of the merge, and now the whole

Re: [PATCH 1/1] Drivers: hv: Change the hex constant to a decimal constant

2012-07-18 Thread Jeff Garzik
On 07/18/2012 06:57 PM, K. Y. Srinivasan wrote: The hex constant chosen for HV_LINUX_GUEST_ID_HI was offensive, update to use the decimal equivalent instead. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang Acked-by: Jeff Garzik -- To unsubscribe from this list: send the line

Re: [PATCH 1/1] Drivers: hv: Change the hex constant to a decimal constant

2012-07-18 Thread Jeff Garzik
On 07/18/2012 06:57 PM, K. Y. Srinivasan wrote: The hex constant chosen for HV_LINUX_GUEST_ID_HI was offensive, update to use the decimal equivalent instead. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Reviewed-by: Haiyang Zhang haiya...@microsoft.com Acked-by: Jeff Garzik jgar

Re: [PATCH] Rewrite Documentation/SubmittingPatches.

2012-07-13 Thread Jeff Garzik
On Fri, Jul 13, 2012 at 7:51 AM, Stefan Beller wrote: > This updates the documentation on how to create patches and send > these to the kernel mailing list. > > The documentation before was written in times before git was there, > so the crafting of the patch needed to be done manually by diff

Re: [PATCH] Rewrite Documentation/SubmittingPatches.

2012-07-13 Thread Jeff Garzik
On Fri, Jul 13, 2012 at 7:51 AM, Stefan Beller stefanbel...@googlemail.com wrote: This updates the documentation on how to create patches and send these to the kernel mailing list. The documentation before was written in times before git was there, so the crafting of the patch needed to be

Re: Proposal for "proper" durable fsync() and fdatasync()

2008-02-26 Thread Jeff Garzik
Jamie Lokier wrote: Jeff Garzik wrote: Nick Piggin wrote: Anyway, the idea of making fsync/fdatasync etc. safe by default is a good idea IMO, and is a bad bug that we don't do that :( Agreed... it's also disappointing that [unless I'm mistaken] you have to hack each filesystem to support

Re: Proposal for "proper" durable fsync() and fdatasync()

2008-02-26 Thread Jeff Garzik
Nick Piggin wrote: Anyway, the idea of making fsync/fdatasync etc. safe by default is a good idea IMO, and is a bad bug that we don't do that :( Agreed... it's also disappointing that [unless I'm mistaken] you have to hack each filesystem to support barriers. It seems far easier to make

Re: 2.6.24-git: kmap_atomic() WARN_ON()

2008-02-26 Thread Jeff Garzik
Ingo Molnar wrote: * Jeff Garzik <[EMAIL PROTECTED]> wrote: + unsigned long flags; + + local_irq_save(flags); hm, couldnt we attach the irq disabling to some spinlock, in a natural way? Explicit flags fiddling is a PITA once we do things like threaded irq handlers, -r

Re: [PATCH] sata_nv: fix nmi intr or system hanging in rhel4u6 adma.

2008-02-26 Thread Jeff Garzik
Robert Hancock wrote: Kuan Luo wrote: Hi, robert One customer reported that their system received a nmi interrupt after issuing "dd if=/dev/sdb of=/dev/null" on a defective disk in rhel4u6. I tested it and found that my system hung both in rhel4u6(2.6.9-67) and 2.6.24-rc7. The patch can work

<    1   2   3   4   5   6   7   8   9   10   >