On Tue, 10 Mar 2015 09:20:24 +0100
Daniel Wagner daniel.wag...@bmw-carit.de wrote:
Hi,
On 03/07/2015 03:00 PM, Jeff Layton wrote:
On Fri, 6 Mar 2015 08:53:30 +0100
Daniel Wagner daniel.wag...@bmw-carit.de wrote:
Hi,
Finally, I got a bigger machine and did a quick test round. I
for a potential problem in one of the lease
tracepoints.
Jeff Layton (1):
locks: fix generic_delete_lease tracepoint to use victim pointer
fs/locks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
Jeff Layton jlay
;
}
No objection to taking this patch in the near term if it helps, but we
had discussed over the summer just removing the NFS fault injection
framework.
Bruce, any objections to making that happen for v4.1?
--
Jeff Layton jeff.lay...@primarydata.com
--
To unsubscribe from this list: send
On Wed, 25 Mar 2015 11:08:56 -0400
J. Bruce Fields bfie...@fieldses.org wrote:
On Tue, Mar 24, 2015 at 06:44:20AM -0400, Jeff Layton wrote:
On Mon, 23 Mar 2015 22:58:05 -0400
Chengyu Song cson...@gatech.edu wrote:
debugfs_create_dir and debugfs_create_file may return -ENODEV when
On Thu, 26 Mar 2015 11:11:19 +0100
Daniel Wagner daniel.wag...@bmw-carit.de wrote:
Hi Jeff,
Sorry for the long delay. Was I week on holiday and the testing
took a bit longer than I expected.
On 03/14/2015 01:40 PM, Jeff Layton wrote:
On Tue, 10 Mar 2015 09:20:24 +0100
Daniel Wagner
.
Yan, Zheng (1):
locks: fix file_lock deletion inside loop
fs/locks.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--
Jeff Layton jlay...@poochiereds.net
pgpog4U9dIQfc.pgp
Description: OpenPGP digital signature
trond.mykleb...@primarydata.com
Cc: Oleg Nesterov onest...@redhat.com
Cc: Eric W. Biederman ebied...@xmission.com
Cc: Jeff Layton jeff.lay...@primarydata.com
---
include/linux/kmod.h |3 +
kernel/kmod.c| 179
++
2 files changed
On Wed, 1 Apr 2015 00:00:57 -0500
Steve French smfre...@gmail.com wrote:
On Tue, Mar 31, 2015 at 7:46 PM, Jeff Layton jlay...@poochiereds.net wrote:
On Fri, 27 Mar 2015 00:28:01 -0500
Steve French smfre...@gmail.com wrote:
null tcon is not likely in these paths in current
code
;
struct TCP_Server_Info *server;
struct cifs_ses *ses = tcon-ses;
Reviewed-by: Jeff Layton jlay...@poochiereds.net
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
: %d\n,
+ __func__, rc);
+ cifs_buf_release(smb_buffer);
+ return rc;
+ }
bcc_ptr += CIFS_AUTH_RESP_SIZE;
if (ses-capabilities CAP_UNICODE) {
Acked-by:
--
Jeff Layton jlay
*)(hdr-ProtocolId[0]) + *off;
else
return NULL;
}
Acked-by: Jeff Layton jlay...@poochiereds.net
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
);
+ cifs_stats_fail_inc(tcon, SMB2_IOCTL_HE);
goto ioctl_exit;
}
}
--
Jeff Layton jlay...@poochiereds.net
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
for using blocked_lock_lock to protect blocked_hash.
Signed-off-by: Daniel Wagner daniel.wag...@bmw-carit.de
Cc: Jeff Layton jlay...@poochiereds.net
Cc: J. Bruce Fields bfie...@fieldses.org
Cc: Alexander Viro v...@zeniv.linux.org.uk
---
fs/locks.c | 48
*caller_fl,
{
int i = 0;
+ lockdep_assert_held(blocked_lock_lock);
+
/*
* This deadlock detector can't reasonably detect deadlocks with
* FL_OFDLCK locks, since they aren't owned by a process, per-se.
Merged for v4.1.
--
Jeff Layton jeff.lay
On Mon, 2 Mar 2015 15:25:10 +0100
Daniel Wagner daniel.wag...@bmw-carit.de wrote:
Since following change
commit bd61e0a9c852de2d705b6f1bb2cc54c5774db570
Author: Jeff Layton jlay...@primarydata.com
Date: Fri Jan 16 15:05:55 2015 -0500
locks: convert posix locks to file_lock_context
file_lock_list and fl_link, fl_block and
fl_next allone. That means we need to define which file_lock_lglock is
used for all waiters. Luckely, fl_link_cpu can be reused for fl_block
and fl_next.
Signed-off-by: Daniel Wagner daniel.wag...@bmw-carit.de
Cc: Jeff Layton jlay...@poochiereds.net
Cc: J
over these patches. While I haven't looked at the fscache
code in quite a while, these all look reasonably sane to me (and it
looks like there are some good bugfixes in here).
Acked-by: Jeff Layton jeff.lay...@primarydata.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
On Mon, 2 Mar 2015 13:58:17 +0100
Daniel Wagner daniel.wag...@bmw-carit.de wrote:
On 02/27/2015 04:30 PM, Jeff Layton wrote:
On Fri, 27 Feb 2015 16:01:30 +0100
Daniel Wagner daniel.wag...@bmw-carit.de wrote:
On 02/24/2015 10:06 PM, Jeff Layton wrote:
On Tue, 24 Feb 2015 16:58:26 +0100
involved.
[...]
Cc: Alexander Viro v...@zeniv.linux.org.uk
Cc: Jeff Layton jlay...@poochiereds.net
Cc: J. Bruce Fields bfie...@fieldses.org
Cc: linux-fsde...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Daniel Wagner (4):
locks: Remove unnecessary IS_POSIX test
locks: Add lockdep
On Fri, 27 Feb 2015 16:01:30 +0100
Daniel Wagner daniel.wag...@bmw-carit.de wrote:
Sorry for the late response. Got dragged away.
On 02/24/2015 10:06 PM, Jeff Layton wrote:
On Tue, 24 Feb 2015 16:58:26 +0100
Daniel Wagner daniel.wag...@bmw-carit.de wrote:
On 02/20/2015 05:05 PM, Andi
On Wed, 4 Mar 2015 16:32:57 +0100
Daniel Wagner daniel.wag...@bmw-carit.de wrote:
On 03/04/2015 04:00 PM, Boaz Harrosh wrote:
On 03/04/2015 04:20 PM, Daniel Wagner wrote:
On 03/03/2015 01:55 AM, Jeff Layton wrote:
On Mon, 2 Mar 2015 15:25:12 +0100
Daniel Wagner daniel.wag...@bmw
On Wed, 4 Mar 2015 12:59:23 -0500
Jeff Layton jlay...@poochiereds.net wrote:
On Wed, 4 Mar 2015 16:32:57 +0100
Daniel Wagner daniel.wag...@bmw-carit.de wrote:
On 03/04/2015 04:00 PM, Boaz Harrosh wrote:
On 03/04/2015 04:20 PM, Daniel Wagner wrote:
On 03/03/2015 01:55 AM, Jeff Layton
On Wed, 4 Mar 2015 15:20:33 +0100
Daniel Wagner daniel.wag...@bmw-carit.de wrote:
On 03/03/2015 01:55 AM, Jeff Layton wrote:
On Mon, 2 Mar 2015 15:25:12 +0100
Daniel Wagner daniel.wag...@bmw-carit.de wrote:
The locks_insert/delete_block() functions are used for flock, posix
On Wed, 4 Mar 2015 16:01:36 -0500
Jeff Layton jlay...@poochiereds.net wrote:
On Wed, 4 Mar 2015 15:20:33 +0100
Daniel Wagner daniel.wag...@bmw-carit.de wrote:
On 03/03/2015 01:55 AM, Jeff Layton wrote:
On Mon, 2 Mar 2015 15:25:12 +0100
Daniel Wagner daniel.wag...@bmw-carit.de wrote
(as it always appeared that there
wasn't one).
Fixes: 8634b51f6ca2 (locks: convert lease handling to file_lock_context)
Reported-by: Daniel Wagner daniel.wag...@bmw-carit.de
Signed-off-by: Jeff Layton jeff.lay...@primarydata.com
---
fs/locks.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
and restoring file
locks.
Cc: Jonathan Corbet cor...@lwn.net
Cc: Alexander Viro v...@zeniv.linux.org.uk
Cc: Jeff Layton jlay...@poochiereds.net
Cc: J. Bruce Fields bfie...@fieldses.org
Cc: Andrew Morton a...@linux-foundation.org
Cc: Cyrill Gorcunov gorcu...@openvz.org
Cc: Pavel Emelyanov
On Thu, 5 Mar 2015 07:57:09 +0100
Daniel Wagner daniel.wag...@bmw-carit.de wrote:
Hi Jeff,
On 03/05/2015 01:06 AM, Jeff Layton wrote:
Commit 8634b51f6ca2 (locks: convert lease handling to file_lock_context)
introduced a regression in the handling of lease upgrade/downgrades
there might trump any benefit to
performance. Reading /proc/locks is a *very* rare activity in the big
scheme of things.
I do however like the idea of moving more to be protected by the
lglocks, and minimizing usage of the blocked_lock_lock.
--
Jeff Layton jlay...@poochiereds.net
--
To unsubscribe
to be for mount and propogating the information down from
mount to where we call the user mode helpers.
Hmmm. I'm a little confused here. Are you saying that the namespace for
nfsd's upcalls umh ought to be derived from the process that did the
initial mount of /proc/fs/nfsd ?
--
Jeff Layton jeff.lay
obviously not a real fix
for this problem, but it might help prove whether the above suspicion
is correct.
Thanks,
--
Jeff Layton jlay...@primarydata.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
On Tue, 13 Jan 2015 17:50:45 -0500
Sasha Levin sasha.le...@oracle.com wrote:
On 01/13/2015 04:44 PM, Jeff Layton wrote:
On Tue, 13 Jan 2015 00:11:37 -0500
Sasha Levin sasha.le...@oracle.com wrote:
Hey Jeff,
While fuzzing with trinity inside a KVM tools guest running the latest
(file, flock);
return rc;
}
(cc'ing Pavel since he wrote a lot of this code)
I think your patch looks correct -- if we (for instance) get a memory
allocation failure while trying to set the local lock then I think we
probably don't want to return success. So...
Acked-by: Jeff
and guidance.
--
Jeff Layton jeff.lay...@primarydata.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
: Remove unnecessary IS_POSIX test
locks: Add lockdep assertion for blocked_lock_lock
Jeff Layton (5):
locks: remove extraneous IS_POSIX and IS_FLOCK tests
locks: don't allocate a lock context for an F_UNLCK request
locks: change lm_get_owner and lm_put_owner prototypes
requirement
(with the caveat mentioned above).
--
Jeff Layton jlay...@poochiereds.net
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
than the two nits above...
Acked-by: Jeff Layton jeff.lay...@primarydata.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
On Mon, 06 Apr 2015 16:38:09 +0200
Arnd Bergmann a...@arndb.de wrote:
On Monday 06 April 2015 10:04:52 Jeff Layton wrote:
diff --git a/fs/lockd/svcsubs.c b/fs/lockd/svcsubs.c
index 665ef5a..a563ddb 100644
--- a/fs/lockd/svcsubs.c
+++ b/fs/lockd/svcsubs.c
@@ -31,7 +31,7
On Thu, 02 Apr 2015 10:42:46 -0400
Mark Salter msal...@redhat.com wrote:
This patch:
commit f895b252d4edf66b2895fb5a7b17a638665f3e1f
Author: Jeff Layton jlay...@primarydata.com
Date: Mon Nov 17 16:58:04 2014 -0500
sunrpc: eliminate RPC_DEBUG
It's always set
On Thu, 2 Apr 2015 11:58:13 -0400
Jeff Layton jeff.lay...@primarydata.com wrote:
On Thu, 02 Apr 2015 10:42:46 -0400
Mark Salter msal...@redhat.com wrote:
This patch:
commit f895b252d4edf66b2895fb5a7b17a638665f3e1f
Author: Jeff Layton jlay...@primarydata.com
Date: Mon Nov 17
: Chuck Lever chuck.le...@oracle.com
Signed-off-by: Jeff Layton jeff.lay...@primarydata.com
---
include/linux/sunrpc/xprt.h | 16 ++--
net/sunrpc/clnt.c | 4 ++--
net/sunrpc/xprtrdma/transport.c | 15 ++-
net/sunrpc/xprtsock.c | 31
is set up for
swapping and sk_clear_memalloc before releasing the socket if so.
Acked-by: Mel Gorman mgor...@suse.de
Signed-off-by: Jeff Layton jeff.lay...@primarydata.com
---
net/sunrpc/xprtsock.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
It's possible that we could race with a call to xs_reset_transport, in
which case the xprt-inet pointer could be zeroed out while we're
accessing it. Lock the xprt before we try to set memalloc on it.
Cc: Mel Gorman mgor...@suse.de
Signed-off-by: Jeff Layton jeff.lay...@primarydata.com
---
net
transition.
Cc: Mel Gorman mgor...@suse.de
Signed-off-by: Jeff Layton jeff.lay...@primarydata.com
---
include/linux/sunrpc/xprt.h | 5 +++--
net/sunrpc/clnt.c | 4 ++--
net/sunrpc/xprtsock.c | 38 +-
3 files changed, 30 insertions(+), 17 deletions
On Wed, 3 Jun 2015 13:07:34 -0400
Chuck Lever chuck.le...@oracle.com wrote:
On Jun 3, 2015, at 11:01 AM, Jeff Layton jlay...@poochiereds.net wrote:
On Wed, 3 Jun 2015 10:48:10 -0400
Trond Myklebust trond.mykleb...@primarydata.com wrote:
On Wed, Jun 3, 2015 at 10:43 AM, Jeff Layton
more selective with the RPC_TASK_SWAPPER
flag. If non-swapper and swapper clnts are sharing a xprt, then we only
need to flag the tasks from the swapper clnt with that flag.
Acked-by: Mel Gorman mgor...@suse.de
Reported-by: Jerome Marchand jmarc...@redhat.com
Signed-off-by: Jeff Layton jeff.lay
for races between swapon/swapoff, and reconnect or migration
events. That will take some careful thought that I haven't the time to
spend on at the moment. I don't think this set will make those races
any worse though.
Jeff Layton (5):
sunrpc: keep a count of swapfiles associated
. That will take some careful thought that I haven't the time to
spend on at the moment. I don't think this set will make those races
any worse though.
Jeff Layton (5):
sunrpc: keep a count of swapfiles associated with the rpc_clnt
sunrpc: make xprt-swapper an atomic_t
sunrpc: if we're closing down
transition.
Cc: Mel Gorman mgor...@suse.de
Signed-off-by: Jeff Layton jeff.lay...@primarydata.com
---
include/linux/sunrpc/xprt.h | 5 +++--
net/sunrpc/clnt.c | 4 ++--
net/sunrpc/xprtsock.c | 38 +-
3 files changed, 30 insertions(+), 17 deletions
more selective with the RPC_TASK_SWAPPER
flag. If non-swapper and swapper clnts are sharing a xprt, then we only
need to flag the tasks from the swapper clnt with that flag.
Acked-by: Mel Gorman mgor...@suse.de
Reported-by: Jerome Marchand jmarc...@redhat.com
Signed-off-by: Jeff Layton jeff.lay
is set up for
swapping and sk_clear_memalloc before releasing the socket if so.
Acked-by: Mel Gorman mgor...@suse.de
Signed-off-by: Jeff Layton jeff.lay...@primarydata.com
---
net/sunrpc/xprtsock.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
It's possible that we could race with a call to xs_reset_transport, in
which case the xprt-inet pointer could be zeroed out while we're
accessing it. Lock the xprt before we try to set memalloc on it.
Cc: Mel Gorman mgor...@suse.de
Signed-off-by: Jeff Layton jeff.lay...@primarydata.com
---
net
-by: Jeff Layton jeff.lay...@primarydata.com
---
include/linux/sunrpc/xprt.h | 16 ++--
net/sunrpc/clnt.c | 4 ++--
net/sunrpc/xprtrdma/transport.c | 15 ++-
net/sunrpc/xprtsock.c | 31 +--
4 files changed, 55 insertions
On Tue, 2 Jun 2015 13:40:26 +0100
Mel Gorman mgor...@suse.de wrote:
On Sat, May 30, 2015 at 08:03:12AM -0400, Jeff Layton wrote:
We currently increment the memalloc_socks counter if we have a xprt that
is associated with a swapfile. That socket can be replaced however
during a reconnect
On Wed, 3 Jun 2015 10:48:10 -0400
Trond Myklebust trond.mykleb...@primarydata.com wrote:
On Wed, Jun 3, 2015 at 10:43 AM, Jeff Layton jlay...@poochiereds.net wrote:
RDMA xprts don't have a sock_xprt, but an rdma_xprt, so the
xs_swapper_enable/disable functions will likely oops when fed
From: Mel Gorman mgor...@suse.de
Jeff Layton reported the following;
[ 74.232485] [ cut here ]
[ 74.233354] WARNING: CPU: 2 PID: 754 at net/core/sock.c:364
sk_clear_memalloc+0x51/0x80()
[ 74.234790] Modules linked in: cts rpcsec_gss_krb5 nfsv4 dns_resolver nfs
On Thu, 4 Jun 2015 14:08:30 +0100
Mel Gorman mgor...@suse.de wrote:
On Wed, Jun 03, 2015 at 10:32:00AM -0400, Jeff Layton wrote:
On Tue, 2 Jun 2015 13:40:26 +0100
Mel Gorman mgor...@suse.de wrote:
On Sat, May 30, 2015 at 08:03:12AM -0400, Jeff Layton wrote:
We currently increment
On Thu, 18 Jun 2015 21:08:43 -0400
Steven Rostedt rost...@goodmis.org wrote:
On Thu, 18 Jun 2015 18:50:51 -0400
Jeff Layton jlay...@poochiereds.net wrote:
The interesting bit here is that the sockets all seem to connect to port
55201 on the remote host, if I'm reading these traces
and that leaves
the port bound.
I'm travelling this weekend and am not set up to reproduce it to
confirm, but that does seem to be a plausible scenario.
--
Jeff Layton jlay...@poochiereds.net
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
Please read the FAQ at http
give some helpful info:
$ rpcinfo -p NFS servername
Also, what NFS version are you using to mount here? Your fstab entries
suggest that you're using the default version (for whatever distro this
is), but have you (e.g.) set up nfsmount.conf to default to v3 on this
box?
--
Jeff Layton jlay
From: Mel Gorman mgor...@suse.de
Jeff Layton reported the following;
[ 74.232485] [ cut here ]
[ 74.233354] WARNING: CPU: 2 PID: 754 at net/core/sock.c:364
sk_clear_memalloc+0x51/0x80()
[ 74.234790] Modules linked in: cts rpcsec_gss_krb5 nfsv4 dns_resolver nfs
On Tue, 26 May 2015 09:56:14 -0400
Jeff Layton jeff.lay...@primarydata.com wrote:
On Tue, 26 May 2015 15:20:46 +0200
Jerome Marchand jmarc...@redhat.com wrote:
Commit dad2b015 added an rcu read lock around the call to xs_swapper()
in nfs_activate()/deactivate(), which can sleep, thus
On Sat, 30 May 2015 13:55:44 -0400
Chuck Lever chuck.le...@oracle.com wrote:
Hi Jeff-
On May 30, 2015, at 8:03 AM, Jeff Layton jlay...@poochiereds.net wrote:
Split xs_swapper into enable/disable functions and eliminate the
enable flag.
Currently, it's racy if you have multiple
On Thu, 28 May 2015 09:26:19 +0100
Mel Gorman mgor...@suse.de wrote:
On Tue, May 26, 2015 at 09:29:29PM -0400, Jeff Layton wrote:
On Tue, 26 May 2015 09:56:14 -0400
Jeff Layton jeff.lay...@primarydata.com wrote:
On Tue, 26 May 2015 15:20:46 +0200
Jerome Marchand jmarc...@redhat.com
/0x76
[ 325.209248] ---[ end trace 13f1014b56e5e711 ]---
Jerome,
Can you test the attached patch and let me know if this fixes the
problem? If so, then I'll send it on officially to Trond.
Thanks,
--
Jeff Layton jeff.lay...@primarydata.com
From 527e41205915d605f68c356a636dfc12b7545b7b Mon Sep
On Thu, 28 May 2015 10:56:14 -0400
Trond Myklebust trond.mykleb...@primarydata.com wrote:
On Thu, May 28, 2015 at 10:20 AM, Jerome Marchand jmarc...@redhat.com wrote:
On 05/28/2015 01:53 PM, Jeff Layton wrote:
On Tue, 26 May 2015 15:20:46 +0200
Jerome Marchand jmarc...@redhat.com wrote
It's possible that we could race with a call to xs_reset_transport, in
which case the xprt-inet pointer could be zeroed out while we're
accessing it. Lock the xprt before we try to set memalloc on it.
Cc: Mel Gorman mgor...@suse.de
Signed-off-by: Jeff Layton jeff.lay...@primarydata.com
---
net
worse though.
Jeff Layton (4):
sunrpc: keep a count of swapfiles associated with the rpc_clnt
sunrpc: make xprt-swapper an atomic_t
sunrpc: if we're closing down a socket, clear memalloc on it first
sunrpc: lock xprt before trying to set memalloc on the sockets
fs/nfs/file.c
is set up for
swapping and sk_clear_memalloc before releasing the socket if so.
Cc: Mel Gorman mgor...@suse.de
Signed-off-by: Jeff Layton jeff.lay...@primarydata.com
---
net/sunrpc/xprtsock.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index
transition.
Cc: Mel Gorman mgor...@suse.de
Signed-off-by: Jeff Layton jeff.lay...@primarydata.com
---
include/linux/sunrpc/xprt.h | 5 +++--
net/sunrpc/clnt.c | 4 ++--
net/sunrpc/xprtsock.c | 38 +-
3 files changed, 30 insertions(+), 17 deletions
more selective with the RPC_TASK_SWAPPER
flag. If non-swapper and swapper clnts are sharing a xprt, then we only
need to flag the tasks from the swapper clnt with that flag.
Cc: Mel Gorman mgor...@suse.de
Reported-by: Jerome Marchand jmarc...@redhat.com
Signed-off-by: Jeff Layton jeff.lay
On Sat, 30 May 2015 08:03:13 -0400
Jeff Layton jlay...@poochiereds.net wrote:
It's possible that we could race with a call to xs_reset_transport, in
which case the xprt-inet pointer could be zeroed out while we're
accessing it. Lock the xprt before we try to set memalloc on it.
Cc: Mel
On Thu, 2 Jul 2015 08:00:26 -0400
Jeff Layton jlay...@poochiereds.net wrote:
On Thu, 2 Jul 2015 04:20:42 +0100
Al Viro v...@zeniv.linux.org.uk wrote:
On Wed, Jul 01, 2015 at 07:44:08PM +0100, Al Viro wrote:
Mismatched reply could also be a possibility, but only if we end up
to be using idr_alloc_cyclic instead.
That should ensure that it's only allocating values from within the
given range.
--
Jeff Layton jlay...@poochiereds.net
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo
On Thu, 2 Jul 2015 17:45:35 +0100
Al Viro v...@zeniv.linux.org.uk wrote:
On Thu, Jul 02, 2015 at 08:07:38AM -0400, Jeff Layton wrote:
Erm...and why is it passing in '0' to idr_alloc for the end value if it
can't deal with more than 16 bits? That seems like a plain old bug...
Because
On Thu, 2 Jul 2015 19:56:29 +0200
Dominique Martinet dominique.marti...@cea.fr wrote:
Jeff Layton wrote on Thu, Jul 02, 2015:
So p9_idpool_create should take an argument for the end value, and
then store that in a new field in p9_idpool. Then they can pass that in
as the end parm
it? It seems like
rpc_switch_client_transport ought to be swap deactivating the old one
and swap activating the new?
Mel, any thoughts?
--
Jeff Layton jeff.lay...@primarydata.com
pgp5TFUDlKZ_N.pgp
Description: OpenPGP digital signature
If the list_head is empty then we'll have called list_lru_from_kmem
for nothing. Move that call inside of the list_empty if block.
Cc: Vladimir Davydov vdavy...@parallels.com
Signed-off-by: Jeff Layton jeff.lay...@primarydata.com
---
mm/list_lru.c | 4 ++--
1 file changed, 2 insertions(+), 2
;
+ }
+ }
}
}
--
Jeff Layton jlay...@poochiereds.net
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
as well. Ordinarily I'd wait for
Trond to ACK this, but he's on holiday right now and the bug is rather
nasty. So I suggest we merge this and if he raises issues with it we
can sort it out when he gets back.
Jeff Layton (5
that all of the
objects are destroyed before destroying the cache. That's fairly
difficult to ensure with dedicated thread doing the destruction.
Signed-off-by: Jeff Layton <jeff.lay...@primarydata.com>
---
fs/notify/mark.c | 66 +---
i
ile.c | 13 +-
> fs/nfs/nfs4proc.c | 13 +-
> fs/ocfs2/locks.c |8 +++---
> include/linux/fs.h | 21 +++-
> 13 files changed, 53 insertions(+), 82 delet
ntries() wrong in some
way? Or is there some breakage in the workqueue or timer code?
--
Jeff Layton <jlay...@poochiereds.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Thu, 29 Oct 2015 10:31:13 -0400
Jeff Layton <jlay...@poochiereds.net> wrote:
> Our QA guys hit the following warning and oops today on a relatively
> recent upstream kernel. They were running a fairly busy NFSv3 I/O test
> against this server:
>
> [ 71.074180] NFSD: sta
On Mon, 2 Nov 2015 09:48:41 -1000
Chris Worley <chris.wor...@primarydata.com> wrote:
> On Sat, Oct 31, 2015 at 11:54 AM, Jeff Layton <jlay...@poochiereds.net> wrote:
> > On Sat, 31 Oct 2015 17:31:07 -0400
> > Tejun Heo <t...@kernel.org> wrote:
> ...
> &
On Sun, 1 Nov 2015 17:24:56 -0800
Linus Torvalds <torva...@linux-foundation.org> wrote:
> On Sun, Nov 1, 2015 at 5:21 PM, Jeff Layton <jlay...@poochiereds.net> wrote:
> >
> > File locking related changes for v4.3 (pile #1)
>
> I assume this was actually meant
On Sun, 1 Nov 2015 17:45:54 -0800
Linus Torvalds <torva...@linux-foundation.org> wrote:
> On Sun, Nov 1, 2015 at 5:41 PM, Jeff Layton <jlay...@poochiereds.net> wrote:
> >
> > Yes, indeed -- facepalm.
> >
> > Would you like me to push a new tag and send a new
locks_lock_inode_wait()
Move locks API users to locks_lock_inode_wait()
locks: cleanup posix_lock_inode_wait and flock_lock_inode_wait
Dmitry Vyukov (1):
fs: fix data races on inode->i_flctx
Jeff Layton (1):
locks: change tracepoint for generic_add_lease
drivers/staging/lus
On Sat, 31 Oct 2015 11:00:12 +0900
Tejun Heo <t...@kernel.org> wrote:
> (cc'ing Lai)
>
> Hello, Jeff.
>
> On Thu, Oct 29, 2015 at 01:58:36PM -0400, Jeff Layton wrote:
> > crash> p cache_cleaner
> > cache_cleaner = $12 = {
> > work = {
> &
On Mon, 2 Nov 2015 20:33:39 -0500
Jeff Layton <jlay...@poochiereds.net> wrote:
> On Mon, 2 Nov 2015 14:56:33 -0500
> Jeff Layton <jlay...@poochiereds.net> wrote:
>
> > On Mon, 2 Nov 2015 09:48:41 -1000
> > Chris Worley <chris.wor...@primarydata.com> wrote
ASK) | cpu;
> debug_activate(timer, timer->expires);
> internal_add_timer(base, timer);
Yes, thanks! That fixes my reproducer and Chris also said he was unable
to reproduce the bug after applying that patch. You can add this if you
like:
Tested-by: Jeff Layton <jlay...@poochi
On Mon, 2 Nov 2015 14:56:33 -0500
Jeff Layton <jlay...@poochiereds.net> wrote:
> On Mon, 2 Nov 2015 09:48:41 -1000
> Chris Worley <chris.wor...@primarydata.com> wrote:
>
> > On Sat, Oct 31, 2015 at 11:54 AM, Jeff Layton <jlay...@poochiereds.net>
> > wr
On Sat, 31 Oct 2015 17:31:07 -0400
Tejun Heo <t...@kernel.org> wrote:
> Hello, Jeff.
>
> On Sat, Oct 31, 2015 at 07:34:00AM -0400, Jeff Layton wrote:
> > > Heh, this one is tricky. Yeah, try_to_grab_pending() missing PENDING
> > > would explain the fail
On Mon, 2015-10-19 at 19:24 +0200, William Dauchy wrote:
> On Mon, Oct 19, 2015 at 6:53 PM, William Dauchy <wdau...@gmail.com>
> wrote:
> > On Mon, Oct 19, 2015 at 6:44 PM, Jeff Layton <
> > jlay...@poochiereds.net> wrote:
> > > This should
On Mon, 2015-10-19 at 17:18 +0200, William Dauchy wrote:
> Hello Dmitry,
>
> On Mon, Sep 21, 2015 at 1:44 PM, Jeff Layton <jlay...@poochiereds.net
> > wrote:
> > Ok, thanks for the explanation. Patch looks fine to me. I'll go
> > ahead
> > and merge it for v
addr=%pIScp flags=%s, __entry-xprt,
- (struct sockaddr *)__entry-ss,
- show_svc_xprt_flags(__entry-flags))
+ __entry-addr, show_svc_xprt_flags(__entry-flags))
);
TRACE_EVENT(svc_wake_up,
--
Jeff Layton jlay...@poochiereds.net
--
To unsubscribe from
,
- (struct sockaddr *)__entry-xprt-xpt_remote,
__entry-len,
- show_svc_xprt_flags(__entry-xprt-xpt_flags))
+ __entry-addr, __entry-len,
+ show_svc_xprt_flags(__entry-flags))
);
#endif /* _TRACE_SUNRPC_H */
--
Jeff Layton jlay...@poochiereds.net
On Wed, 26 Aug 2015 17:22:25 +0530
Pratyush Anand pan...@redhat.com wrote:
Hi Jeff,
Thanks for your review comments.
On 26/08/2015:06:31:03 AM, Jeff Layton wrote:
On Tue, 25 Aug 2015 11:34:19 +0530
Pratyush Anand pan...@redhat.com wrote:
TP_fast_assign(
__entry-xprt
))
+ (struct sockaddr *)__entry-ss,
+ __entry-len, show_svc_xprt_flags(__entry-flags))
);
#endif /* _TRACE_SUNRPC_H */
Looks good otherwise. Thanks for fixing this!
Reviewed-by: Jeff Layton jeff.lay...@primarydata.com
--
To unsubscribe from this list: send the line unsubscribe
that the list is empty and returns
immediately, even though the __fput for its file may not have run yet.
Close this by making flush_delayed_fput use flush_delayed_work instead,
which should just block until the workqueue job completes if it's
already running.
Signed-off-by: Jeff Layton <jeff.
On Tue, 1 Sep 2015 13:35:53 -0400
Jeff Layton <jlay...@poochiereds.net> wrote:
> I think there's a potential race in flush_delayed_fput. A kthread does
> an fput() and that file gets added to the list and the delayed work is
> scheduled. More than 1 jiffy passes, and the workque
1201 - 1300 of 4603 matches
Mail list logo
