On Sun, 8 Dec 2013 14:13:37 -0700
Tim Gardner t...@tpi.com wrote:
As suggested by Jeff Layton:
Now that I look though, it's clear to me that cifs_set_file_size is
just wrong. Currently it calls ops-set_path_size and if that fails
with certain error codes it tries to do
On Wed, 20 Nov 2013 14:50:32 -0500
J. Bruce Fields bfie...@fieldses.org wrote:
On Wed, Nov 20, 2013 at 11:45:04AM -0500, Jeff Layton wrote:
Due to some unfortunate history, POSIX locks have very strange and
unhelpful semantics. The thing that usually catches people by surprise
On Mon, 9 Dec 2013 12:41:56 -0700
Tim Gardner t...@tpi.com wrote:
As suggested by Jeff Layton:
Now that I look though, it's clear to me that cifs_set_file_size is
just wrong. Currently it calls ops-set_path_size and if that fails
with certain error codes it tries to do
some of the direct struct list_head
accesses with helper macros.
Acked-by: Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
they
might be able to zero in on this change as the culprit more easily.
Acked-by: Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
submounts, don't unhash ! */
+ if (check_submounts_and_drop(dentry) != 0)
+ goto out_valid;
+
dput(parent);
dfprintk(LOOKUPCACHE, NFS: %s(%s/%s) is invalid\n,
__func__, dentry-d_parent-d_name.name,
Acked-by: Jeff Layton jlay...@redhat.com
already do anyway.
Am I missing something obvious here?
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
On Wed, 26 Mar 2014 20:05:16 -0700
Andy Lutomirski l...@amacapital.net wrote:
On Wed, Mar 26, 2014 at 7:48 PM, Jeff Layton jlay...@redhat.com
wrote:
On Wed, 26 Mar 2014 17:23:24 -0700
Andy Lutomirski l...@amacapital.net wrote:
Hi various people who care about user-space NFS servers
will need to understand and document what we
expect to occur if someone does this new switch_creds(fd) call and then
subsequently calls something like setuid(), if only to ensure that we
don't get blindsided by it.
[1]: http://sourceware.org/ml/libc-help/2012-07/msg4.html
--
Jeff Layton jlay
On Thu, 27 Mar 2014 14:06:32 +0100
Florian Weimer fwei...@redhat.com wrote:
On 03/27/2014 02:02 PM, Jeff Layton wrote:
This interface does not address the long-term lack of POSIX
compliance in setuid and friends, which are required to be
process-global and not thread-specific
On Wed, 26 Mar 2014 20:25:35 -0700
Jeff Layton jlay...@redhat.com wrote:
On Wed, 26 Mar 2014 20:05:16 -0700
Andy Lutomirski l...@amacapital.net wrote:
On Wed, Mar 26, 2014 at 7:48 PM, Jeff Layton jlay...@redhat.com
wrote:
On Wed, 26 Mar 2014 17:23:24 -0700
Andy Lutomirski l
On Sun, 27 Apr 2014 14:51:25 +1000
NeilBrown ne...@suse.de wrote:
On Tue, 22 Apr 2014 06:54:36 +0200 Michael Kerrisk (man-pages)
mtk.manpa...@gmail.com wrote:
On 04/21/2014 11:15 PM, Stefan (metze) Metzmacher wrote:
Am 21.04.2014 21:55, schrieb Jeff Layton:
On Mon, 21 Apr 2014 21:39
and FMODE_WRITE must
correspond
--
Jeff Layton jlay...@poochiereds.net
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
...@primarydata.com
Signed-off-by: Jeff Layton jlay...@poochiereds.net
---
drivers/staging/lustre/lustre/llite/file.c | 17 ++---
fs/9p/vfs_file.c | 3 ---
fs/afs/flock.c | 4
fs/ceph/locks.c| 10
along with the
extended struct, or possibly a new syscall. Some of the samba folks
were interested in an async locking mechanism too, so something like
that could be added in conjunction with such an interface.
--
Jeff Layton jlay...@poochiereds.net
--
To unsubscribe from this list: send the line
and its state preserved.
Also note that all of the above just applies to the Linux knfsd. There
are many other servers in the field and they have different rules for
dropping state held by clients that have gone AWOL.
--
Jeff Layton jlay...@poochiereds.net
--
To unsubscribe from this list: send
several months.
--
Jeff Layton jlay...@poochiereds.net
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Signed-off-by: Jeff Layton jlay...@poochiereds.net
---
man2/fcntl.2 | 112 +--
1 file changed, 109 insertions(+), 3 deletions(-)
diff --git a/man2/fcntl.2 b/man2/fcntl.2
index d0154a6d9f42..8d119dfec24c 100644
--- a/man2/fcntl.2
+++ b/man2
, Jeff Layton wrote:
Signed-off-by: Jeff Layton jlay...@poochiereds.net
---
man2/fcntl.2 | 112
+--
1 file changed, 109 insertions(+), 3 deletions(-)
diff --git a/man2/fcntl.2 b/man2/fcntl.2
index d0154a6d9f42..8d119dfec24c
(remaining, PAGE_SIZE);
+ size_t copy = min_t(size_t, remaining, PAGE_SIZE);
size_t written = copy_page_to_iter(page, 0, copy, iter);
remaining -= written;
if (written copy iov_iter_count(iter) 0)
Reviewed-by: Jeff Layton jlay
Open file description locks have been merged into the Linux kernel for
v3.15. Add the appropriate command-value definitions and an update to
the manual that describes their usage.
ChangeLog:
2014-04-24 Jeff Layton jlay...@poochiereds.net
[BZ#16839]
* manual/llio.texi: add
On Sat, 3 May 2014 22:28:43 +0200
Fabian Frederick f...@skynet.be wrote:
Replace seq_printf where possible
Cc: Jeff Layton jlay...@redhat.com
Cc: Alexander Viro v...@zeniv.linux.org.uk
Cc: Andrew Morton a...@linux-foundation.org
Signed-off-by: Fabian Frederick f...@skynet.be
---
fs
to 8c836fa85bebfea26ceff024b5d1c518bf63f3d8:
MAINTAINERS: email address change for Jeff Layton (2014-04-30 13:28:17 -0400)
File locking related changes for v3.15 (pile #3)
- only an email address change to the MAINTAINERS file
On Sat, May 3, 2014 at 4:15 PM, Fabian Frederick f...@skynet.be wrote:
Replacing all __constant_foo to foo()
except in smb2status.h (1700 lines to update).
Cc: linux-c...@vger.kernel.org
Cc: Steve French sfre...@samba.org
Cc: Andrew Morton a...@linux-foundation.org
Signed-off-by: Fabian
On Mon, 5 May 2014 06:53:01 +0200
Fabian Frederick f...@skynet.be wrote:
On Sun, 4 May 2014 18:52:43 -0400
Jeff Layton jlay...@poochiereds.net wrote:
On Sat, May 3, 2014 at 4:15 PM, Fabian Frederick f...@skynet.be wrote:
Replacing all __constant_foo to foo()
except in smb2status.h
-1 allocations with GFP_NOWAIT is never
guaranteed to succeed and will have difficulty if memory is fragmented.
Yes. We made a similar fix to xprt_alloc_slot a while back. The RPC
engine has a mechanism to handle retrying these allocations, so this
warning isn't particularly helpful.
--
Jeff
v2: add a __break_lease tracepoint for non-blocking case
Recently, I needed these to help track down a softlockup when recalling a
delegation, but they might be helpful in other situations as well.
Cc: J. Bruce Fields bfie...@fieldses.org
Signed-off-by: Jeff Layton jlay...@poochiereds.net
the type bits in the
same way that Linux does. So if you end up mounting a different OS,
it's possible that the client will get that wrong...
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
On Thu, 3 Apr 2014 16:16:27 -0400
J. Bruce Fields bfie...@fieldses.org wrote:
On Thu, Apr 03, 2014 at 02:55:04PM -0400, Jeff Layton wrote:
On Thu, 03 Apr 2014 13:51:06 -0400
Mark Lord ml...@pobox.com wrote:
On 14-04-03 01:16 PM, J. Bruce Fields wrote:
On Thu, Apr 03, 2014 at 12:33
On Fri, 4 Apr 2014 09:58:43 -0400
J. Bruce Fields bfie...@fieldses.org wrote:
On Thu, Apr 03, 2014 at 07:21:46PM -0400, Jeff Layton wrote:
So according to the RFC you have to encode both the mode bits and the
ftype for v2. The type bits seem to be removed from the mode in NFSv3
though, so
On Fri, 4 Apr 2014 14:28:16 -0700
Linus Torvalds torva...@linux-foundation.org wrote:
On Mon, Mar 31, 2014 at 6:31 AM, Jeff Layton jlay...@redhat.com wrote:
The following changes since commit 29723adee11804b548903ddb1db666cf4a60f60e:
locks: make locks_mandatory_area check for file
://vger.kernel.org/majordomo-info.html
This was already tracked down earlier this week. Bruce has a patch
queued to fix it in his nfsd-next branch. See this thread from earlier
this week:
Subject: Re: linux-3.14 nfsd regression
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send
On Mon, 7 Apr 2014 11:37:06 +1000
Stephen Rothwell s...@canb.auug.org.au wrote:
Hi Jeff,
On Fri, 4 Apr 2014 20:56:24 -0400 Jeff Layton jlay...@redhat.com wrote:
Thanks for the feedback and for pulling this in anyway. I'll make sure
to do all of that on subsequent pull requests.
Also
On Mon, 7 Apr 2014 22:27:02 +1000
Stephen Rothwell s...@canb.auug.org.au wrote:
Hi Jeff,
On Mon, 7 Apr 2014 07:11:30 -0400 Jeff Layton jlay...@redhat.com wrote:
On Mon, 7 Apr 2014 11:37:06 +1000
Stephen Rothwell s...@canb.auug.org.au wrote:
On Fri, 4 Apr 2014 20:56:24 -0400 Jeff
in
-kernel config), load the RDMA client module:
+If the NFS/RDMA client was built as a module
+(CONFIG_SUNRPC_XPRT_RDMA_CLIENT=m in kernel config), load the RDMA client
+module:
$ modprobe xprtrdma.ko
Thanks, nice catch, I had forgotten about the docs...
Reviewed-by: Jeff
there is a conflicting lock before it can return anything.
If all you're objecting to is the change in verbiage on those two
pieces, then I'll back that part out in the interest of wrapping this
up.
I still think I'm correct though ;)
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from
that correctly.
For the other patches, I don't like the fact that we need to rename this
stuff at this late stage, but it should be settled now (hopefully).
Jeff Layton (3):
locks: allow __break_lease to sleep even when break_time
Open file description locks have been merged into the Linux kernel for
v3.15. Add the appropriate command-value definitions and an update to
the manual that describes their usage.
ChangeLog:
2014-04-24 Jeff Layton jlay...@redhat.com
[BZ#16839]
* manual/llio.texi: add section
matter here?
On 04/24/2014 02:15 PM, Jeff Layton wrote:
Open file description locks have been merged into the Linux kernel for
v3.15. Add the appropriate command-value definitions and an update to
the manual that describes their usage.
ChangeLog:
2014-04-24 Jeff Layton jlay
Open file description locks have been merged into the Linux kernel for
v3.15. Add the appropriate command-value definitions and an update to
the manual that describes their usage.
ChangeLog:
2014-04-24 Jeff Layton jlay...@redhat.com
[BZ#16839]
* manual/llio.texi: add section
Open file description locks have been merged into the Linux kernel for
v3.15. Add the appropriate command-value definitions and an update to
the manual that describes their usage.
ChangeLog:
2014-04-24 Jeff Layton jlay...@redhat.com
[BZ#16839]
* manual/llio.texi: add section
, and then if there are other changes
that are needed later, we can base patches on top of it?
On Thu, Apr 24, 2014 at 4:09 PM, Jeff Layton jlay...@redhat.com wrote:
Open file description locks have been merged into the Linux kernel for
v3.15. Add the appropriate command-value definitions
On Thu, 24 Apr 2014 17:34:35 +0200
Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote:
On Thu, Apr 24, 2014 at 5:11 PM, Jeff Layton jlay...@redhat.com wrote:
On Thu, 24 Apr 2014 17:07:11 +0200
Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote:
Jeff,
Please let us know
On Fri, 25 Apr 2014 05:57:39 -0400
J. Bruce Fields bfie...@fieldses.org wrote:
On Thu, Apr 24, 2014 at 07:45:57AM -0400, Jeff Layton wrote:
The following changes since commit 55101e2d6ce1c780f6ee8fee5f37306971aac6cd:
Merge git://git.kernel.org/pub/scm/virt/kvm/kvm (2014-04-14 16:21
FDLOCK
The rest of the renaming can wait until v3.16, since everything else
isn't visible outside of the kernel.
Cc: Michael Kerrisk mtk.manpa...@gmail.com
Signed-off-by: Jeff Layton jlay...@redhat.com
---
arch/arm/kernel/sys_oabi-compat.c | 6 +++---
fs/compat.c | 14
On Mon, 21 Apr 2014 12:10:04 -0400
Rich Felker dal...@libc.org wrote:
On Mon, Apr 21, 2014 at 04:23:54PM +0200, Michael Kerrisk (man-pages) wrote:
On 04/21/2014 04:02 PM, Rich Felker wrote:
On Mon, Apr 21, 2014 at 09:45:35AM -0400, Jeff Layton wrote:
File-private locks have been merged
these more visually distinct. I rather like the idea of changing
F_SETLKP to F_*_SETLK. The question is what to put in place of the
wildcard there, and that sort of hinges on the name...
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
On Mon, 21 Apr 2014 20:18:50 +0200
Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote:
Jeff,
On 04/21/2014 06:45 PM, Jeff Layton wrote:
On Mon, 21 Apr 2014 12:10:04 -0400
Rich Felker dal...@libc.org wrote:
On Mon, Apr 21, 2014 at 04:23:54PM +0200, Michael Kerrisk (man-pages
On Mon, 21 Apr 2014 14:48:29 -0400
Rich Felker dal...@libc.org wrote:
On Mon, Apr 21, 2014 at 02:32:38PM -0400, Jeff Layton wrote:
Fair enough. Assuming we kept file-description locks as a name, what
would you propose as new macro names?
I assume you meant, assume we kept the term
are in more agreement that I realized.)
Cheers,
Michael
So the motion is to call them open file description locks and change
the macros to read *_OFD_*. Does anyone object?
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
Cc: Carlos O'Donell car...@redhat.com
Cc: Stefan Metzmacher me...@samba.org
Cc: Andy Lutomirski l...@amacapital.net
Cc: Frank Filz ffilz...@mindspring.com
Cc: Theodore Ts'o ty...@mit.edu
Signed-off-by: Jeff Layton jlay...@redhat.com
---
arch/arm/kernel/sys_oabi-compat.c | 6 +++---
fs/compat.c
On Tue, 22 Apr 2014 17:45:31 +0300
Boaz Harrosh open...@gmail.com wrote:
On 04/22/2014 03:23 PM, Jeff Layton wrote:
We're going to have to live with these for a long time, so it's
important that we be happy with the names before we're stuck with them.
The consensus on the lists so far
for
v3.15. Add the appropriate command-value definitions and an update to
the manual that describes their usage.
ChangeLog:
2014-04-23 Jeff Layton jlay...@redhat.com
[BZ#16839]
* manual/llio.texi: add section about open file description locks
* sysdeps/unix/sysv/linux/bits
lock, then you don't get any lock
information back (l_type just gets reset to F_UNLCK).
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
On Tue, 15 Apr 2014 22:08:50 +0200
Michael Kerrisk (man-pages) mtk.manpa...@gmail.com wrote:
Hello Jeff,
On Thu, Jan 9, 2014 at 3:23 PM, Jeff Layton jlay...@redhat.com wrote:
Please don't merge this yet, as the kernel patches are still a work in
progress...
Now that this has hit
insertions(+), 149 deletions(-)
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org
-sk_xprt.xpt_flags);
p = (__be32 *)rqstp-rq_arg.head[0].iov_base;
calldir = p[1];
--
To unsubscribe from this list: send the line unsubscribe linux-nfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jeff
. For v3.15, this is the only part we'd
absolutely have to change before it ships. The rest I can fix up in
v3.16.
Does this sound like a reasonable set of changes to make? Does anyone
else have a better set of names they can suggest? Speak now, or forever
hold your peace!
--
Jeff Layton jlay
On Thu, 17 Apr 2014 00:42:13 +0200
Stefan (metze) Metzmacher me...@samba.org wrote:
Am 16.04.2014 22:00, schrieb Michael Kerrisk (man-pages):
[CC += Jeremy Allison]
On Wed, Apr 16, 2014 at 8:57 PM, Jeff Layton jlay...@redhat.com wrote:
Sorry to spam so many lists, but I think this needs
/Austin
lists? If yes, it might be worth also linking those folks into the
naming discussion..
Cheers,
Michael
Yes, good idea. The open bug is here:
http://austingroupbugs.net/view.php?id=768
I'll write something up there and see if they want to chime in on the
discussion.
--
Jeff
On Sun, 30 Mar 2014 09:03:29 -0400
Theodore Ts'o ty...@mit.edu wrote:
On Thu, Mar 27, 2014 at 07:08:02AM -0700, Jeff Layton wrote:
I had some time to think about this last night...
While using a fd to pass around credentials is convenient, the danger
is that it's pretty opaque. You have
- eliminate unneeded BUG() call
- merge of file-private lock implementation
--
Jeff Layton jlay...@redhat.com
signature.asc
Description: PGP signature
On Mon, 31 Mar 2014 14:06:01 -0400
Trond Myklebust trond.mykleb...@primarydata.com wrote:
On Mar 31, 2014, at 7:51, Jeff Layton jlay...@redhat.com wrote:
On Sun, 30 Mar 2014 09:03:29 -0400
Theodore Ts'o ty...@mit.edu wrote:
On Thu, Mar 27, 2014 at 07:08:02AM -0700, Jeff Layton wrote
From: Jeff Layton jlay...@poochiereds.net
Open file description locks have been merged into the Linux kernel for
v3.15. Add the appropriate command-value definitions and an update to
the manual that describes their usage.
ChangeLog:
2014-04-24 Jeff Layton jlay...@poochiereds.net
[BZ
From: Jeff Layton jlay...@poochiereds.net
Open file description locks have been merged into the Linux kernel for
v3.15. Add the appropriate command-value definitions and an update to
the manual that describes their usage.
ChangeLog:
2014-04-24 Jeff Layton jlay...@poochiereds.net
[BZ
.
Jeff Layton (2):
locks: add missing memory barrier in break_deleg
locks: set fl_owner for leases back to current-files
fs/locks.c | 2 +-
include/linux/fs.h | 6 ++
2 files changed, 7 insertions(+), 1 deletion(-)
--
Jeff Layton jlay...@poochiereds.net
= dentry;
- path-mnt = mntget(nd-path.mnt);
+ path-mnt = nd-path.mnt;
if (should_follow_link(dentry, nd-flags LOOKUP_FOLLOW))
return 1;
+ mntget(path-mnt);
follow_mount(path);
error = 0;
out:
Looks correct, I think...
Acked-by:
--
Jeff Layton jlay
(*lm_change)(struct file_lock **fl, int type);
};
--
Jeff Layton jlay...@poochiereds.net
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
From: Jeff Layton jlay...@poochiereds.net
Open file description locks have been merged into the Linux kernel for
v3.15. Add the appropriate command-value definitions and an update to
the manual that describes their usage.
ChangeLog:
2014-04-24 Jeff Layton jlay...@poochiereds.net
[BZ
On Tue, 8 Jul 2014 08:16:57 -0400
Jeff Layton jlay...@primarydata.com wrote:
From: Jeff Layton jlay...@poochiereds.net
Open file description locks have been merged into the Linux kernel for
v3.15. Add the appropriate command-value definitions and an update to
the manual that describes
From: Jeff Layton jlay...@poochiereds.net
Open file description locks have been merged into the Linux kernel for
v3.15. Add the appropriate command-value definitions and an update to
the manual that describes their usage.
ChangeLog:
2014-04-24 Jeff Layton jlay...@poochiereds.net
[BZ
sparse is throwing warnings when building sunrpc modules due to some
endianness shenanigans in ipv6.h. Sprinkle some endianness fixups to
silence them. These should all get fixed up at compile time, so I don't
think this will add any extra work to be done at runtime.
Signed-off-by: Jeff Layton
that to fetch the
pointer. Accessing current-real_cred directly is actually quite safe
since we know that they can't go away so this is mostly a cosmetic fixup
to silence sparse.
Signed-off-by: Jeff Layton jlay...@primarydata.com
---
fs/nfsd/auth.c | 2 +-
include/linux/cred.h | 9 +
2
.
Maybe not, I did it for completeness sake. I'll see if I can remove
that. The macros do the conversion at compile time though so it
shouldn't hurt anything either way.
--
Jeff Layton jlay...@primarydata.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
On Mon, 14 Jul 2014 08:25:46 -0400
Jeff Layton jlay...@primarydata.com wrote:
sparse is throwing warnings when building sunrpc modules due to some
endianness shenanigans in ipv6.h. Sprinkle some endianness fixups to
silence them. These should all get fixed up at compile time, so I don't
think
Fields (2):
locks: consolidate common code in the flock_to_posix_lock routines
locks: simplify overflow checking
Jeff Layton (11):
locks: close potential race between setlease and open
locks: clean up comment typo
locks: remove inline qualifier from fl_link manipulation functions
locks
. McKenney paul...@linux.vnet.ibm.com
Reported-by: Al Viro v...@zeniv.linux.org.uk
Signed-off-by: Jeff Layton jlay...@redhat.com
Signed-off-by: J. Bruce Fields bfie...@redhat.com
---
fs/locks.c | 75 --
include/linux/fs.h | 6 +
2 files
or on the same file descriptor.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/locks.c | 34 --
include/uapi/asm-generic/fcntl.h | 16
2 files changed, 48 insertions(+), 2 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
...to make sparse happy.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/locks.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/locks.c b/fs/locks.c
index 049a144..6084f5a 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -2430,6 +2430,7 @@ static int locks_show(struct seq_file *f, void
Move this check into flock64_to_posix_lock instead of duplicating it in
two places. This also fixes a minor wart in the code where we continue
referring to the struct flock after converting it to struct file_lock.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/locks.c | 46
-by: Jeff Layton jlay...@redhat.com
---
fs/file_table.c| 2 +-
fs/locks.c | 2 +-
include/linux/fs.h | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/file_table.c b/fs/file_table.c
index 5fff903..468543c 100644
--- a/fs/file_table.c
+++ b/fs/file_table.c
@@ -234,7
.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/locks.c | 9 ++---
include/linux/fs.h | 1 +
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index a217c2c..995583b 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -135,6 +135,7 @@
#define
. If fcntl(F_GETLK, ...) returns a lock set
with flock() then the l_pid member cannot be a process ID because the
lock is not held by a process as such.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/locks.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/locks.c b
in the file_lock instead.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/locks.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index 820322d..8180141 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -1905,14 +1905,15 @@ int fcntl_getlk(struct
end up
leaking something, but that's generally preferable to an immediate
panic.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/locks.c | 24 ++--
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index 6084f5a..dd30933 100644
--- a/fs
From: J. Bruce Fields bfie...@fieldses.org
Currently, there's a lot of copy and paste between the two. Add some
functions to do the initialization of the file_lock from values
passed in, and turn the flock/flock64 variants of those functions into
wrappers around them.
Signed-off-by: Jeff Layton
From: J. Bruce Fields bfie...@fieldses.org
Or maybe we don't actually care about indicating overflow in the 32-bit
case: sure we could fail if e.g. f_pos+start or f_pos+start+len would
exceed 32-bits, but do we really need to?
Signed-off-by: J. Bruce Fields bfie...@redhat.com
---
fs/locks.c |
It's best to let the compiler decide that.
Reported-by: Stephen Rothwell s...@canb.auug.org.au
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/locks.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index 5e28612..049a144 100644
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/locks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/locks.c b/fs/locks.c
index 2cfeea6..5e28612 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -581,7 +581,7 @@ static void locks_delete_block(struct file_lock *waiter
-by: Jeff Layton jlay...@redhat.com
---
Makefile | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Makefile b/Makefile
index 89cee86..fb76899 100644
--- a/Makefile
+++ b/Makefile
@@ -733,11 +733,11 @@ export mod_strip_cmd
# This shall be used by the dracut(8) tool while creating
use that info to make a
semi-intelligent decision based on that and what tools are installed.
...or maybe a separate env var for each one that it supports:
$INITRD_COMPRESS_LZ4
$INITRD_COMPRESS_BZIP2
$INITRD_COMPRESS_GZIP
...etc.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe
remove that
entire block in the Makefile (i.e. just revert PJP's patch?)
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
for the unwary...
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Tue, 29 Jul 2014 23:30:36 -0400
Carlos O'Donell car...@redhat.com wrote:
On 07/23/2014 02:21 PM, Jeff Layton wrote:
From: Jeff Layton jlay...@poochiereds.net
Thanks for resending. Sorry for the delay.
Your use of 3 different emails caused me to miss the recent
resends. That's my
at runtime.
Signed-off-by: Jeff Layton jlay...@primarydata.com
---
include/net/ipv6.h | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/include/net/ipv6.h b/include/net/ipv6.h
index 574337fe72dd..0535da61fe0b 100644
--- a/include/net/ipv6.h
+++ b/include/net/ipv6
/9aYh6usN6z2qJhbHgqM9EWcPL6jOrCwX4PbC1XjKHekpFN0t9oKQClx
qSPuweMQ7fP4IBd2Ke8L/QlyOVblAKSE7t+NdrjfzLmYPzyHTyfLABR/BI053to=
=/9FJ
-END PGP SIGNATURE-
--
Jeff Layton jlay...@poochiereds.net
signature.asc
Description: PGP signature
-- it just
happens to be the filesystem that most people notice it on.
On Fri, Aug 1, 2014 at 8:21 PM, Jeff Layton jlay...@poochiereds.net wrote:
On Fri, 1 Aug 2014 07:50:53 +1000
NeilBrown ne...@suse.de wrote:
On Thu, 31 Jul 2014 14:20:07 -0700 Ben Greear gree...@candelatech.com
wrote
in the lease handling code. Cleaning up the use of
the i_lock in the lease code is a larger project which we'll have to
tackle at some point, but there are some other cleanups that will
need to happen first.
Absent any objections, I'll plan to merge these for 3.18.
Jeff Layton (5):
locks: don't
Signed-off-by: Jeff Layton jlay...@primarydata.com
---
Documentation/filesystems/Locking | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Documentation/filesystems/Locking
b/Documentation/filesystems/Locking
index b18dd1779029..f1997e9da61f 100644
--- a/Documentation
There's no need to call locks_free_lock here while still holding the
i_lock. Defer that until the lock has been dropped.
Signed-off-by: Jeff Layton jlay...@primarydata.com
---
fs/locks.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
901 - 1000 of 4603 matches
Mail list logo
