Fixed several typos in the code examples given in
Documentation/usb/hotplug.txt.
- missing [] with array of struct usb_device_id
- checkpatch.pl warning: space between function name and parenthesis
- missing terminating ';'
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
Enclose the body of the multi-statement DGNC_VERIFY_BOARD macro inside a
do - while block as per Documentation/CodingStyle. Fixes 1 error found
by checkpatch.pl.
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
---
drivers/staging/dgnc/dgnc_sysfs.c | 20 +++-
1 file changed, 11
Place 'else' on same line as closing brace '}' as per
Documentation/CodingStyle. Fixes 1 error found by checkpatch.pl.
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
---
drivers/staging/xillybus/xillybus_core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers
, checkpatch.pl doesn't warn about these.
...
Cheers,
--
Jeremiah Mahler
jmmah...@gmail.com
http://github.com/jmahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
should assume it will be merged.
I missed that. A subject line like this would have been better.
staging: xillybus: place 'else' on same line as '}'
...
regards,
dan carpenter
Thanks,
--
Jeremiah Mahler
jmmah...@gmail.com
http://github.com/jmahler
--
To unsubscribe from this list: send
/ieee80211_module.c:297:13: warning:
symbol 'ieee80211_debug_exit' was not declared. Should it be static?
These functions are used outside of this file so using static will not
work. Fix the warning by declaring the functions in the header file,
ieee80211.h
Signed-off-by: Jeremiah Mahler jmmah
/ieee80211_module.c:297:13: warning:
symbol 'ieee80211_debug_exit' was not declared. Should it be static?
These functions are used outside of this file so using static will not
work. Fix the warning by declaring the functions in the header file,
ieee80211.h
Signed-off-by: Jeremiah Mahler jmmah
On Mon, Aug 11, 2014 at 10:11:13PM -0500, Joel Pelaez Jorge wrote:
El 11/08/14 a las 17:32, Greg Kroah-Hartman escibió:
On Mon, Aug 11, 2014 at 03:15:54PM -0700, Jeremiah Mahler wrote:
A sparse warning is generated about 'ieee80211_debug_init' and
'ieee80211_debug_exit' not being declared
these
prototypes from r8192U_core.c to ieee80211.h.
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Cc: Joel Pelaez Jorge joelpel...@gmail.com
Cc: Andrea Merello andrea.mere...@gmail.com
Cc: John W. Linville linvi...@tuxdriver.com
Cc: Joe Perches j
.
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
---
arch/x86/mm/tlb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
index 1fe3398..fff4a4c 100644
--- a/arch/x86/mm/tlb.c
+++ b/arch/x86/mm/tlb.c
@@ -174,7 +174,7 @@ void flush_tlb_current_task
Fix the documented sys location of tlb_single_page_flush_ceiling
which is under /sys/kernel/debug/... not /sys/debug/kernel/...
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
---
Documentation/x86/tlb.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/x86
, optimize the use of this variable by adding the __read_mostly
directive.
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
Suggested-by: David Rientjes rient...@google.com
---
Notes:
I like the suggestion from David Rientjes, to add __read_mostly.
Patch updated.
arch/x86/mm/tlb.c | 2
room for a few
replies without wrapping.
deprecated printk's have been replaced with proper methods.
Signed-off-by: Amber Thrall amber.rose.thr...@gmail.com
---
...
--
Jeremiah Mahler
jmmah...@gmail.com
http://github.com/jmahler
--
To unsubscribe from this list: send the line unsubscribe
dmitry.torok...@gmail.com
If I can provide any other information that would be of help let me know.
I will try out your new patchset if I get a chance.
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
the
string to where it is printed. Then switch from printk(KERN_INFO to
pr_info() for the lines that were changed.
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
---
net/can/af_can.c | 5 +
net/can/bcm.c| 4 +---
net/can/raw.c| 4 +---
3 files changed, 3 insertions(+), 10 deletions
Oliver,
On Sat, Nov 22, 2014 at 05:41:28PM +0100, Oliver Hartkopp wrote:
On 22.11.2014 08:42, Jeremiah Mahler wrote:
Several CAN modules use a design pattern with a banner[] variable at the
top which defines a string that is used once during init to print the
banner. The string is also
, then a suspend and resume,
the touchpad quit working. Attached is the dmesg after this sequence.
There is an oops with a trace in there that looks interesting...
[]
--
- Jeremiah Mahler
[0.00] Initializing cgroup subsys cpuset
[0.00] Initializing cgroup subsys cpu
[0.00
imagine the patch author, Joonsoo Kim, might have a better idea
why this is happening than I do. But if I can provide any information
or run any tests that might be of help just let me know.
--
Jeremiah Mahler
jmmah...@gmail.com
http://github.com/jmahler
--
To unsubscribe from this list: send
On Sun, Sep 28, 2014 at 11:38:51AM -0500, Christoph Lameter wrote:
On Sat, 27 Sep 2014, Jeremiah Mahler wrote:
I just encountered a problem on a Lenovo Carbon X1 where it will
suspend but won't resume. A bisect indicated that this patch
is causing the problem.
Could you please
should use
braces.
--
Jeremiah Mahler
jmmah...@gmail.com
http://github.com/jmahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
Tanya,
On Mon, Sep 29, 2014 at 07:46:34AM +0300, Tanya Brokhman wrote:
Hi Jeremiah,
On 9/28/2014 9:13 PM, Jeremiah Mahler wrote:
Tanya,
On Sun, Sep 28, 2014 at 09:37:00AM +0300, Tanya Brokhman wrote:
The need for performing read disturb is determined according to new
statistics
Joonsoo,
On Mon, Sep 29, 2014 at 04:44:18PM +0900, Joonsoo Kim wrote:
On Sat, Sep 27, 2014 at 11:24:49PM -0700, Jeremiah Mahler wrote:
On Thu, Aug 21, 2014 at 05:11:13PM +0900, Joonsoo Kim wrote:
Because of chicken and egg problem, initializaion of SLAB is really
complicated. We need
both the above patches resolves the build errors.
--
Jeremiah Mahler
jmmah...@gmail.com
http://github.com/jmahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
;
}
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
--
- Jeremiah Mahler
--
To unsubscribe from this list
/
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Wed, Dec 24, 2014 at 12:01:10AM +0800, Gmail wrote:
People say that is not a legal name, therefore I create this English name
sound like my real name.
I'm confused. So Ben Chan isn't your real name, just one you made up?
On Dec 23, 2014, at 11:57 PM, Jeremiah Mahler jmmah...@gmail.com
/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
+ DMM32AT_INTCLK_REG);
}
static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice
*s)
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Switch from MIN/MAX to min_t/max_t with a size_t type. The size_t type
was chosen because one operand is a size_t and all the others are
immediate integer values.
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
---
drivers/staging/lustre/lnet/lnet/router_proc.c | 2 +-
1 file changed, 1
Custom MIN/MAX operations are being used which are not as robust
as the built in min/max operations which will warn about potentially
problematic type comparisons.
For the simple cases, where no type warning is produced, simply
replace MIN/MAX with min/max.
Signed-off-by: Jeremiah Mahler jmmah
the built in min/max
functions.
Jeremiah Mahler (6):
staging: lustre: use min/max instead of MIN/MAX, simple cases
staging: lustre: replace MIN with min_t
staging: lustre: replace MIN/MAX with min_t/max_t
staging: lustre: replace MIN with min, cast (__kernel_size_t)
staging: lustre
Switch from MIN to min_t and remove the previous cast of the second
argument to int.
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
---
drivers/staging/lustre/lnet/lnet/lib-move.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/lnet/lib-move.c
-by: Jeremiah Mahler jmmah...@gmail.com
---
drivers/staging/lustre/lnet/lnet/lib-move.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/lib-move.c
b/drivers/staging/lustre/lnet/lnet/lib-move.c
index 706c5ee..76eb238 100644
--- a/drivers/staging
Remove all custom MIN/MAX and min_t operations since they are
no longer needed.
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
---
drivers/staging/lustre/include/linux/libcfs/libcfs_private.h | 8
drivers/staging/lustre/lustre/osc/osc_internal.h | 5 -
2 files changed
Switch from MIN to the built in min_t with the int type.
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c
b
: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line unsubscribe linux
/
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Improve the wording by changing it from is provide the to
is to give the.
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
---
Documentation/driver-model/bus.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/driver-model/bus.txt
b/Documentation/driver-model
lots of good tips.
https://www.youtube.com/watch?v=LLBrBBImJt4
Jeremiah Mahler jmmah...@gmail.com:
Alexander,
On Fri, Dec 26, 2014 at 06:38:59PM +0600, Alexander Kuleshov wrote:
Your description needs to be more specific than just coding style
fixes. What type of problems did you fix
enable its
backlight controls if the standard ACPI controls are not present.
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
---
drivers/gpu/drm/nouveau/nouveau_backlight.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c
b/drivers/gpu/drm/nouveau
Ilia,
On Fri, Dec 26, 2014 at 04:39:08PM -0500, Ilia Mirkin wrote:
On Fri, Dec 26, 2014 at 4:26 PM, Jeremiah Mahler jmmah...@gmail.com wrote:
If a display supports backlight control using the nouveau driver, and
also supports standard ACPI backlight control, there will be two sets
Fix several symbol '...' was not declared sparse warnings
for variables which are only used locally by declaring them static.
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
---
drivers/staging/lustre/lnet/selftest/framework.c | 2 +-
drivers/staging/lustre/lnet/selftest/rpc.c | 2
' - unexpected unlock
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
---
drivers/staging/lustre/lnet/selftest/rpc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/lustre/lnet/selftest/rpc.c
b/drivers/staging/lustre/lnet/selftest/rpc.c
index bb6aa2e..2e9094b 100644
--- a/drivers
These patches fix most of the undeclared and context imbalance
sparse warnings for the lustre code in the selftest/ directory.
Jeremiah Mahler (5):
staging: lustre: selftest: fix not declared by declaring in header
staging: lustre: selftest: fix not declared by declaring static
staging
' - unexpected unlock
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
---
drivers/staging/lustre/lnet/selftest/framework.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/selftest/framework.c
b/drivers/staging/lustre/lnet/selftest/framework.c
index 56b4ef4
' - unexpected unlock
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
---
drivers/staging/lustre/lnet/selftest/rpc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/lustre/lnet/selftest/rpc.c
b/drivers/staging/lustre/lnet/selftest/rpc.c
index 2e9094b..1f7d9a6 100644
--- a/drivers
Fix several symbol '...' was not declared sparse warnings which
are caused by global variables by declaring them in the header file.
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
---
drivers/staging/lustre/lnet/selftest/selftest.h | 12
1 file changed, 12 insertions(+)
diff
Hans,
On Sat, Dec 27, 2014 at 02:39:42PM +0100, Hans de Goede wrote:
Hi,
On 27-12-14 00:51, Jeremiah Mahler wrote:
Ilia,
On Fri, Dec 26, 2014 at 04:39:08PM -0500, Ilia Mirkin wrote:
On Fri, Dec 26, 2014 at 4:26 PM, Jeremiah Mahler jmmah...@gmail.com wrote:
If a display supports
deletions(-)
[...]
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
is redundant. I would have just said something to the effect of
fix three space prohibited errors
Signed-off-by: Jonas Lundqvist jo...@gannon.se
---
drivers/staging/line6/pcm.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[...]
--
- Jeremiah Mahler
--
To unsubscribe from
-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Looks good to me.
Reviewed-by: Jeremiah Mahler jmmah...@gmail.com
--
- Jeremiah Mahler
--
To unsubscribe from this list
at http://www.tux.org/lkml/
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
by using the correct variable name in cyapa_resume().
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
---
drivers/input/mouse/cyapa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c
index c84a9eb..d8d2ccb 100644
commuinty.
Thanks,
Dudley
-Original Message-
From: Jeremiah Mahler [mailto:jmmah...@gmail.com]
Sent: 2014?11?25? 18:07
To: Dudley Du
Cc: linux-kernel@vger.kernel.org
Subject: [BUG] [PATCH] next: cyapa: fix inop touchpad after resume on Acer
C720
On an Acer C720
Dudley,
On Wed, Nov 26, 2014 at 06:16:00AM +, Dudley Du wrote:
More info: I did all testings based on kernel 3.14.0 on Acer C70.
I am testing with linux-next 3.18-rc6 on an Acer C720.
http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/
Thanks,
Dudley
[]
--
- Jeremiah
try again with attached patch fix.
Thanks,
Dudley
-Original Message-
From: Jeremiah Mahler [mailto:jmmah...@gmail.com]
Sent: 2014?11?27? 4:03
To: Dudley Du
Cc: linux-kernel@vger.kernel.org
Subject: Re: [BUG] [PATCH] next: cyapa: fix inop touchpad after resume on
Acer
functionality, resubmit after an -EPROTO error, but change
message log level to debug instead of error so they are handled quietly
by default.
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
---
drivers/usb/serial/generic.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/usb
is
similar to pppd or slip, that cannot determine whether they should exit
until after the USB serial device is unplugged. Producing these error
messages for a normal use case is not helpful.
Jeremiah Mahler (2):
usb: serial: handle -EPROTO quietly in generic_read_bulk
usb: serial: handle -ENODEV
that
usb_serial_generic_submit_read_urb() handles quietly without an error.
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
---
drivers/usb/serial/generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/generic.c b/drivers/usb/serial/generic.c
index 98fe718
.
MODPOST 187 modules
CC drivers/input/mouse/cyapatp.mod.o
LDFINAL [M] drivers/input/mouse/cyapatp.ko
jeri@newt:~/linux-next
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
);
}
[...]
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
, platform_get_resource failed\n);
return -ENODEV;
}
data-reg_base = devm_ioremap(pdev-dev, r-start, PAGE_SIZE);
- if (data-reg_base == NULL)
+ if (!data-reg_base)
return -ENOMEM;
[...]
--
- Jeremiah Mahler
--
To unsubscribe from this list: send
must say I am surprised. I had no idea
checkpatch.pl could be even more pedantic than it already is :-)
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
that (mult_adj 0) limits the test to only positive
numbers. A positive number plus a positive number will never be less
than either of the two positive numbers. The test is always false.
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
. Lines: 21, 28 and 30.
Good find :)
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Xunlei,
On Tue, Dec 02, 2014 at 11:00:26PM +0800, Xunlei Pang wrote:
On 2 December 2014 at 17:32, Jeremiah Mahler jmmah...@gmail.com wrote:
John,
On Mon, Nov 24, 2014 at 08:35:45PM -0800, John Stultz wrote:
In commit 6067dc5a8c2b (time: Avoid possible NTP adjustment mult
@@ -1330,7
...@broadcom.com
Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org
Let me know if I can do anything else to help.
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
On Wed, Dec 03, 2014 at 12:36:55AM -0800, Jeremiah Mahler wrote:
all,
On Mon, Dec 01, 2014 at 08:34:05AM +0100, Arend van Spriel wrote:
On 01-12-14 08:19, Stephen Rothwell wrote:
Hi Greg,
Today's linux-next merge of the driver-core tree got a conflict in
drivers/net/wireless/ath
Arend,
On Wed, Dec 03, 2014 at 01:49:00PM +0100, Arend van Spriel wrote:
On 12/03/14 11:51, Jeremiah Mahler wrote:
On Wed, Dec 03, 2014 at 12:36:55AM -0800, Jeremiah Mahler wrote:
all,
On Mon, Dec 01, 2014 at 08:34:05AM +0100, Arend van Spriel wrote:
On 01-12-14 08:19, Stephen Rothwell
On Wed, Dec 03, 2014 at 01:06:59PM -0800, Jeremiah Mahler wrote:
Arend,
On Wed, Dec 03, 2014 at 01:49:00PM +0100, Arend van Spriel wrote:
On 12/03/14 11:51, Jeremiah Mahler wrote:
On Wed, Dec 03, 2014 at 12:36:55AM -0800, Jeremiah Mahler wrote:
all,
On Mon, Dec 01, 2014 at 08:34
any problems.
I will have a look and review them again.
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
of error. Although I would keep the series to just a few at first until
you are sure you are doing everything right.
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
;
}
[...]
When I run checkpatch.pl it doesn't find any errors and the parenthesis
haven't been removed. How are you running checkpatch.pl? Are you using
any extra options?
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
Karthik,
On Fri, Dec 19, 2014 at 10:16:18AM +0530, karthik nayak wrote:
On 12/19/2014 04:08 AM, Jeremiah Mahler wrote:
Karthik,
On Thu, Dec 18, 2014 at 02:50:11PM +0530, Karthik Nayak wrote:
As per checkpatch warning, removed an unnecessary else statement
proceeding an if statement
Aapo,
On Fri, Dec 19, 2014 at 12:37:16PM +0200, Aapo Vienamo wrote:
On Thu, Dec 18, 2014 at 02:45:01PM -0800, Jeremiah Mahler wrote:
Aapo,
On Thu, Dec 18, 2014 at 05:32:52PM +0200, Aapo Vienamo wrote:
This patch fixes a coding style issue found by the checkpatch.pl tool
},
};
I like the original version better here. The columns were lined up
nicely and it was easier to read.
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
should expect a direct regpair map
[2.486528] ath: Country alpha2 being used: 00
[2.486528] ath: Regpair used: 0x6c
[2.488258] cfg80211: World regulatory domain updated:
[2.488260] cfg80211: DFS Master region: unset
--
- Jeremiah Mahler
--
To unsubscribe from this list: send
this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line
for a normal use case is not helpful.
Changes in v2:
- Instead of handling -EPROTO specially, use dev_dbg instead of
dev_err like other drivers do.
Jeremiah Mahler (2):
usb: serial: handle -EPROTO quietly in generic_read_bulk
usb: serial: handle -ENODEV quietly
these messages for debugging. The generic driver treats these as
errors.
Change the default output for the generic serial driver from error to
debug.
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
---
drivers/usb/serial/generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
that
usb_serial_generic_submit_read_urb() handles quietly without an error.
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
---
drivers/usb/serial/generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/generic.c b/drivers/usb/serial/generic.c
index 2d7207b
Gangadhar,
On Sat, Dec 20, 2014 at 02:25:08PM +0530, Gangadhar wrote:
From: gangadharv gangs.freelan...@gmail.com
Fixed a Coding style issue.
The description needs to be more specific? What type of issue did you
fix? How did you find this issue?
[...]
--
- Jeremiah Mahler
Gangadhar,
On Sat, Dec 20, 2014 at 03:13:10PM +0530, Gangadhar V wrote:
Hi,
It is Space coding Style issue which i found when running
checkpatch.pl script on rtw_ap.c.
--Gangadhar V
On Sat, Dec 20, 2014 at 2:44 PM, Jeremiah Mahler jmmah...@gmail.com wrote:
Gangadhar,
On Sat, Dec 20
! :)
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Sergei,
On Sat, Dec 20, 2014 at 03:32:42PM +0300, Sergei Shtylyov wrote:
Hello.
On 12/20/2014 12:11 PM, Jeremiah Mahler wrote:
If a USB serial device driver, which is built using the generic serial
driver, is unplugged while there is an active program using the device,
Driver
of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
If you fix those few things there is nothing else that I would have a
complaint about.
--
- Jeremiah Mahler
--
To unsubscribe from this list
these as
errors.
Change the default output for the generic serial driver from error to
debug.
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
---
Notes:
Minor change just fixes the wording in the log message.
drivers/usb/serial/generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
);
+ __func__, psta-mac_id, raid, tx_ra_bitmap, arg);
/* bitmap[0:27] = tx_rate_bitmap */
/* bitmap[28:31]= Rate Adaptive id */
--
Gangadhar V
Looks good to me.
Reviewed-by: Jeremiah Mahler jmmah...@gmail.com
--
- Jeremiah Mahler
--
To unsubscribe from this list
) void
cumanascsi_setup(char *str, int *ints)
^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 39) {
^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 40) }
~/linux-next$
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
Please read the FAQ at http://www.tux.org/lkml/
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Looks good.
Reviewed-by: Jeremiah Mahler jmmah...@gmail.com
did this mistake get in there?
It looks like it was simply missed in commit 377f5bc00f7e1. All the
ones before and after were changed, but not this one.
Interestingly, if you go back to this commit and compile it, no error
is generated unless you enable sparse checks.
--
- Jeremiah Mahler
as
width, should I add a \(enter) where necessary?
The spacing in the code was fine. I was referring to your log message
(below).
And the blank line and two patch bit: understood, simple fix.
- Sage Vaillancourt
On Sun, Dec 21, 2014 at 2:12 AM, Jeremiah Mahler jmmah...@gmail.com wrote
in mind that white space fixes may be
considered code churn [1] in some parts of the kernel. The staging
area is much more welcoming of these sorts of changes.
[1]: https://lkml.org/lkml/2014/6/10/819
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
The usbmon documentation uses be reading until which is an unusual
wording. Change it to read until it which is more clear.
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
---
Documentation/usb/usbmon.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/usb
Signed-off-by: Jeremiah Mahler jmmah...@gmail.com
---
Documentation/usb/usbmon.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/usb/usbmon.txt b/Documentation/usb/usbmon.txt
index be2ccb9..28425f7 100644
--- a/Documentation/usb/usbmon.txt
+++ b/Documentation
KY Srinivasan,
On Mon, Dec 15, 2014 at 07:00:45AM +, KY Srinivasan wrote:
-Original Message-
From: Jeremiah Mahler [mailto:jmmah...@gmail.com]
Sent: Wednesday, December 10, 2014 6:10 PM
To: KY Srinivasan
Cc: gre...@linuxfoundation.org; linux-kernel@vger.kernel.org;
de
Dudley,
On Mon, Dec 15, 2014 at 06:31:25AM +, Dudley Du wrote:
Jeremiah,
Thanks for your review and comments.
I have updated v15 based on your comments and suggestions.
Could you help review again please.
Thank you very much,
Dudley
Will do.
[...]
--
- Jeremiah Mahler
1 - 100 of 536 matches
Mail list logo
