On Wednesday, December 31, 2014 12:50 PM, Aaron Lu wrote:
>
> It is useful to get the backlight device's pointer and use it to set
> backlight in some cases(the following patch will make use of it) so add
> the two APIs and export them.
>
> Signed-off-by: Aaron Lu
Acked-by:
Han jg1@samsung.com
Best regards,
Jingoo Han
---
drivers/video/backlight/backlight.c | 44
-
include/linux/backlight.h | 2 ++
2 files changed, 31 insertions(+), 15 deletions(-)
diff --git a/drivers/video/backlight/backlight.c
b
Acked-by: Jingoo Han jg1@samsung.com
Best regards,
Jingoo Han
---
drivers/acpi/video.c| 2 +-
drivers/video/backlight/backlight.c | 6 --
include/linux/backlight.h | 1 -
3 files changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/acpi/video.c b
On Thursday, December 18, 2014 2:48 PM, Gyungoh Yoo wrote:
>
> From: Gyungoh Yoo
>
> Signed-off-by: Gyungoh Yoo
Please add the following 'Acked-by's when you send this patch
next time.
Acked-by: Jingoo Han
Acked-by: Bryan Wu
Best regards,
Jingoo Han
> ---
> Changes v10:
_ERR(pcie->phy);
> + }
> + }
> +
> + /* Claim the GPIO for PRST# if available */
> + pcie->reset_gpio = of_get_named_gpio(np, "reset-gpio", 0);
> + if (!gpio_is_valid(pcie->reset_gpio))
> + dev_dbg(>dev, "No res
if a device that requires I/O region is connected to
PCIe slot of ST sti SoCs PCIe, what will happen?
It just prints error messages?
Best regards,
Jingoo Han
>
> Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
/O region is connected to
PCIe slot of ST sti SoCs PCIe, what will happen?
It just prints error messages?
Best regards,
Jingoo Han
Arnd
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
to the license_is_gpl_compatible(), the MODULE_LICENSE() string
for GPL v2 is GPL v2 not GPLv2.
Best regards,
Jingoo Han
--
1.9.1
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On Thursday, December 18, 2014 2:48 PM, Gyungoh Yoo wrote:
From: Gyungoh Yoo jack@skyworksinc.com
Signed-off-by: Gyungoh Yoo jack@skyworksinc.com
Please add the following 'Acked-by's when you send this patch
next time.
Acked-by: Jingoo Han jg1@samsung.com
Acked-by: Bryan Wu
ease let me know if it is OK to take this one into linux-pm.
>
> Does not seem to conflict with fbdev changes, so:
>
> Acked-by: Tomi Valkeinen
For drivers/video/fbdev/s3c-fb.c,
Acked-by: Jingoo Han
Best regards,
Jingoo Han
>
> Tomi
>
--
To unsubscribe from this
:
Acked-by: Tomi Valkeinen tomi.valkei...@ti.com
For drivers/video/fbdev/s3c-fb.c,
Acked-by: Jingoo Han jg1@samsung.com
Best regards,
Jingoo Han
Tomi
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1862,7 +1862,6 @@ F:drivers/net/wireless/b43legacy/
> >
> > BACKLIGHT CLASS/SUBSYSTEM
> > M: Jingoo Han
> > -M: Bryan Wu
> > M: Lee Jones
> > S: Maintained
> > F: drivers/video/backlight/
+1862,6 @@ F:drivers/net/wireless/b43legacy/
BACKLIGHT CLASS/SUBSYSTEM
M: Jingoo Han jg1@samsung.com
-M: Bryan Wu coolo...@gmail.com
M: Lee Jones lee.jo...@linaro.org
S: Maintained
F: drivers/video/backlight/
I'm just going to apply it I think.
Applied, thanks.
Hi Bryan
On Wednesday, December 03, 2014 4:05 PM, Gyungoh Yoo wrote:
>
> From: Gyungoh Yoo
>
> Signed-off-by: Gyungoh Yoo
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> Changes v10:
> Removed trivial get_brightness implementations
>
> Changes v9:
> Noth
new DT properties.
This is because DT can be handled as ABI. Thus, Ack from
DT maintainers is necessary for merging new DT properties,
even though other subsystem maintainers or reviews gave
Ack for this.
Best regards,
Jingoo Han
>
> >
> > > From: Gyungoh Yoo
&g
SKY81452_EN, 0);
> +}
> +
> +static int sky81452_bl_get_brightness(struct backlight_device *bd)
> +{
> + return bd->props.brightness;
> +}
Please remove sky81452_bl_get_brightness().
In the case of just returning 'props.brightness',
backglight core can also return 'props.bri
may now be changed to depend on
> CONFIG_PM.
>
> The alternative of CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME may be
> replaced with CONFIG_PM too.
>
> Make these changes in 2 files under drivers/input/.
>
> Signed-off-by: Rafael J. Wysocki
Reviewed-by: Jingoo Han
Best regards,
may now be changed to depend on
> CONFIG_PM.
>
> Replace CONFIG_PM_RUNTIME with CONFIG_PM in 4 files under
> gpu/drm/exynos/.
>
> Signed-off-by: Rafael J. Wysocki
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
> ---
>
> Note: This depends on commit b2b49ccbdd
the same to dp-phy
> > node.
> >
> > Signed-off-by: Vivek Gautam
> > Reviewed-by: Jingoo Han
> > Tested-by: Javier Martinez Canillas
> > Cc: Kukjin Kim
>
> Any opinions about $subject?
>
> This patch is -rc material since is needed after commit a5e
node.
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
Reviewed-by: Jingoo Han jg1@samsung.com
Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Cc: Kukjin Kim kg...@kernel.org
Any opinions about $subject?
This patch is -rc material since is needed after
now be changed to depend on
CONFIG_PM.
Replace CONFIG_PM_RUNTIME with CONFIG_PM in 4 files under
gpu/drm/exynos/.
Signed-off-by: Rafael J. Wysocki rafael.j.wyso...@intel.com
Reviewed-by: Jingoo Han jg1@samsung.com
Best regards,
Jingoo Han
---
Note: This depends on commit
now be changed to depend on
CONFIG_PM.
The alternative of CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME may be
replaced with CONFIG_PM too.
Make these changes in 2 files under drivers/input/.
Signed-off-by: Rafael J. Wysocki rafael.j.wyso...@intel.com
Reviewed-by: Jingoo Han jg1@samsung.com
even if get_brightness is not implemented
Others look good.
Thanks.
Best regards,
Jingoo Han
+
+static const struct backlight_ops sky81452_bl_ops = {
+ .update_status = sky81452_bl_update_status,
+ .get_brightness = sky81452_bl_get_brightness,
+};
+
+static ssize_t
.
This is because DT can be handled as ABI. Thus, Ack from
DT maintainers is necessary for merging new DT properties,
even though other subsystem maintainers or reviews gave
Ack for this.
Best regards,
Jingoo Han
From: Gyungoh Yoo jack@skyworksinc.com
Signed-off-by: Gyungoh Yoo jack
On Wednesday, December 03, 2014 4:05 PM, Gyungoh Yoo wrote:
From: Gyungoh Yoo jack@skyworksinc.com
Signed-off-by: Gyungoh Yoo jack@skyworksinc.com
Acked-by: Jingoo Han jg1@samsung.com
Best regards,
Jingoo Han
---
Changes v10:
Removed trivial get_brightness implementations
autam
> Cc: Inki Dae
> Cc: Jingoo Han
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
>
> Changes from V2:
> - Moved devm_phy_get() call out of exynos_dp_dt_parse_phydata() to
>exynos_dp_bind() function and,
>removed exynos_dp_dt_parse_phydata() fun
Cc: Inki Dae inki@samsung.com
Cc: Jingoo Han jg1@samsung.com
Acked-by: Jingoo Han jg1@samsung.com
Best regards,
Jingoo Han
---
Changes from V2:
- Moved devm_phy_get() call out of exynos_dp_dt_parse_phydata() to
exynos_dp_bind() function and,
removed
On Tuesday, November 11, 2014 11:37 PM, Daniel Baluta wrote:
>
> Files under include/linux/iio were not reported as part
> of the IIO subsystem.
>
> Reported-by: Cristina Ciocan
> Signed-off-by: Daniel Baluta
(+cc Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald)
Revie
On Thursday, October 30, 2014 10:24 PM, Vivek Gautam wrote:
>
> DP PHY now require pmu-system-controller to handle PMU register
> to control PHY's power isolation. Adding the same to dp-phy
> node.
>
> Signed-off-by: Vivek Gautam
> Cc: Jingoo Han
Reviewed-by: Jingoo Han
d long time ago.
However, it was not removed for DT compatibility.
I think that now these old DT properties can be removed.
I added some comments below.
>
> Signed-off-by: Vivek Gautam
> Cc: Inki Dae
> Cc: Jingoo Han
> ---
>
> Changes from V1:
> - Reworked error
, it was not removed for DT compatibility.
I think that now these old DT properties can be removed.
I added some comments below.
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
Cc: Inki Dae inki@samsung.com
Cc: Jingoo Han jg1@samsung.com
---
Changes from V1:
- Reworked error
On Thursday, October 30, 2014 10:24 PM, Vivek Gautam wrote:
DP PHY now require pmu-system-controller to handle PMU register
to control PHY's power isolation. Adding the same to dp-phy
node.
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
Cc: Jingoo Han jg1@samsung.com
Reviewed
, Peter Meerwald)
Reviewed-by: Jingoo Han jg1@samsung.com
Best regards,
Jingoo Han
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index b2f927b..ebb9c38 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4631,6 +4631,7 @@ L: linux
of_find_backlight_by_node stub-check to modules
Then, the one single patch will do as follows.
-#ifdef CONFIG_OF
+#if defined(CONFIG_OF) && (defined(CONFIG_BACKLIGHT_CLASS_DEVICE) || \
+ defined(CONFIG_BACKLIGHT_CLASS_DEVICE_MODULE))
In this case, I cannot find
) || \
+ defined(CONFIG_BACKLIGHT_CLASS_DEVICE_MODULE))
In this case, I cannot find any build errors.
Thank you.
Best regards,
Jingoo Han
... error.
Bear in mind that defined(CONFIG_BACKLIGHT_CLASS_DEVICE) is false if
it's built in as a module. Change to nested #ifdefs instead
prevent
> redefinition warnings when the backlight device class is compiled as module.
>
> Reported-by: kbuild test robot
> Signed-off-by: Heiko Stuebner
Acked-by: Jingoo Han
If there is no objection, I hope that this patch is merged.
Thank you.
Best regards,
Jingoo Han
> ---
>
when the backlight device class is compiled as module.
Reported-by: kbuild test robot
Signed-off-by: Heiko Stuebner he...@sntech.de
Acked-by: Jingoo Han jg1@samsung.com
If there is no objection, I hope that this patch is merged.
Thank you.
Best regards,
Jingoo Han
---
include/linux
patch looks good.
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> include/linux/backlight.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/backlight.h b/include/linux/backlight.h
> index adb14a8..d9cb644 100644
> --- a/in
.
Acked-by: Jingoo Han jg1@samsung.com
Best regards,
Jingoo Han
---
include/linux/backlight.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/backlight.h b/include/linux/backlight.h
index adb14a8..d9cb644 100644
--- a/include/linux/backlight.h
+++ b
codes:
>
> The use of devm_ioremap_resource() changes the return value:
> * -ENOMEM instead of -EIO in case of ioremap() failure,
> * -EINVAL instead of -ENODEV in case of platform_get_resource()
>failure.
>
> Signed-off-by: Michael Opdenacker
Reviewed-by: Jingoo Han
() failure,
* -EINVAL instead of -ENODEV in case of platform_get_resource()
failure.
Signed-off-by: Michael Opdenacker michael.opdenac...@free-electrons.com
Reviewed-by: Jingoo Han jg1@samsung.com
Best regards,
Jingoo Han
---
drivers/mtd/nand/orion_nand.c | 39
On Tuesday, October 07, 2014 2:01 PM, Gyungoh Yoo wrote:
>
If possible, please add more detailed commit message for this patch.
> Signed-off-by: Gyungoh Yoo
> ---
> drivers/video/backlight/Kconfig | 10 +
> drivers/video/backlight/Makefile | 1 +
>
On Tuesday, October 07, 2014 2:01 PM, Gyungoh Yoo wrote:
If possible, please add more detailed commit message for this patch.
Signed-off-by: Gyungoh Yoo jack@skyworksinc.com
---
drivers/video/backlight/Kconfig | 10 +
drivers/video/backlight/Makefile | 1 +
> Reported-by: Paul Bolle
> Signed-off-by: Sylwester Nawrocki
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> drivers/usb/host/Kconfig |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/Kconfig b/drivers/us
...@tiscali.nl
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Acked-by: Jingoo Han jg1@samsung.com
Best regards,
Jingoo Han
---
drivers/usb/host/Kconfig |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
ost drivers too.
>
> Signed-off-by: Vivek Gautam
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> drivers/usb/host/ohci-exynos.c | 89
> +++-
> 1 file changed, 24 insertions(+), 65 deletions(-)
>
> diff --git a/drivers/usb/hos
ost drivers too.
>
> Signed-off-by: Vivek Gautam
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> drivers/usb/host/ehci-exynos.c | 81
>
> 1 file changed, 23 insertions(+), 58 deletions(-)
>
> diff --git a/drivers/usb/hos
-off-by: Vivek Gautam gautam.vi...@samsung.com
Acked-by: Jingoo Han jg1@samsung.com
Best regards,
Jingoo Han
---
drivers/usb/host/ehci-exynos.c | 81
1 file changed, 23 insertions(+), 58 deletions(-)
diff --git a/drivers/usb/host/ehci
-off-by: Vivek Gautam gautam.vi...@samsung.com
Acked-by: Jingoo Han jg1@samsung.com
Best regards,
Jingoo Han
---
drivers/usb/host/ohci-exynos.c | 89
+++-
1 file changed, 24 insertions(+), 65 deletions(-)
diff --git a/drivers/usb/host/ohci
f (ret < 0) {
> + dev_err(pchip->dev, "i2c access fail to register\n");
> + return ret;
> + }
> +
> + return size;
> +}
> +
> +static DEVICE_ATTR(uni_mode, S_IWUSR, NULL, lm3509_uni_mode_store);
> +
> +/* update
'lm3509_bsub_get_brightness' callback function,
when it just returns 'props.brightness'.
Best regards,
Jingoo Han
+
+static int lm3509_backlight_register(struct lm3509_chip *pchip,
+ enum lm3509_leds ledno)
+{
+ struct backlight_properties props;
+
+ props.type
Huo/Bean Huo
Others look good.
Best regards,
Jingoo Han
> ---
> drivers/mtd/chips/cfi_cmdset_0002.c | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c
> b/drivers/mtd/chips/cfi_cmdset_0002.c
> index 5a4bfe3..9b0de91
/Bean Huo
Others look good.
Best regards,
Jingoo Han
---
drivers/mtd/chips/cfi_cmdset_0002.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c
b/drivers/mtd/chips/cfi_cmdset_0002.c
index 5a4bfe3..9b0de91 100644
--- a/drivers/mtd/chips
nos OHCI driver to hang on probe (as observed
> on Exynos5250 Arndale board). ]
I also agree with this patch, because dwc3 IPs of all Exynos SoCs
do not use "NOP USB Transceiver Driver". So, "usb_phy_generic" can be
removed from Exynos dwc3 driver.
Is there any reason to sup
Transceiver Driver. So, usb_phy_generic can be
removed from Exynos dwc3 driver.
Is there any reason to support 'usb_phy_generic' for Exynos dwc3?
If so, please let me know. Thank you.
Best regards,
Jingoo Han
Cc: Olof Johansson o...@lixom.net
Cc: Kukjin Kim kgene@samsung.com
Cc: Vivek
> + u32 addr, u32 data)
> +{
> + /* Write Address */
> + crport_handshake(phy_drd, EXYNOS5_DRD_PHYREG0_CR_DATA_IN(addr),
> + EXYNOS5_DRD_PHYREG0_CR_CAP_ADDR);
According to the guidance from H/W team, before calling crport_handsha
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han
Acked-by: Lee Jones
---
drivers/video/backlight/omap1_bl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/omap1_bl.c
b/drivers/video/backlight
Fixed the following checkpatch warning.
WARNING: else is not generally useful after a break or return
Suggested-by: Lee Jones
Signed-off-by: Jingoo Han
---
drivers/video/backlight/jornada720_lcd.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/video
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han
Acked-by: Lee Jones
---
drivers/video/backlight/wm831x_bl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/wm831x_bl.c
b/drivers/video/backlight
Fixed the following checkpatch warning.
WARNING: else is not generally useful after a break or return
Signed-off-by: Jingoo Han
Acked-by: Lee Jones
---
drivers/video/backlight/jornada720_bl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/backlight
Fixed the following checkpatch warning.
WARNING: else is not generally useful after a break or return
Signed-off-by: Jingoo Han
Acked-by: Lee Jones
---
drivers/video/backlight/s6e63m0.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/video/backlight
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han
Acked-by: Lee Jones
---
drivers/video/backlight/tdo24m.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/backlight/tdo24m.c b/drivers/video/backlight
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han
Acked-by: Lee Jones
---
drivers/video/backlight/pcf50633-backlight.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/pcf50633-backlight.c
b/drivers
Fixed the following checkpatch warning.
WARNING: else is not generally useful after a break or return
Signed-off-by: Jingoo Han
Acked-by: Lee Jones
---
drivers/video/backlight/lms501kf03.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/video
Fixed the following checkpatch warning.
WARNING: else is not generally useful after a break or return
Signed-off-by: Jingoo Han
Acked-by: Lee Jones
---
drivers/video/backlight/ams369fg06.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/backlight
Fixed the following checkpatch warning.
WARNING: void function return statements are not generally useful
Signed-off-by: Jingoo Han
Acked-by: Lee Jones
---
drivers/video/backlight/lm3639_bl.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video/backlight/lm3639_bl.c
b/drivers
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han
Acked-by: Lee Jones
---
drivers/video/backlight/lp855x_bl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/backlight/lp855x_bl.c
b/drivers/video/backlight
Fixed the following checkpatch warning.
WARNING: else is not generally useful after a break or return
Signed-off-by: Jingoo Han
Acked-by: Lee Jones
---
drivers/video/backlight/ili922x.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/video/backlight
Fixed the following checkpatch warning.
WARNING: else is not generally useful after a break or return
Signed-off-by: Jingoo Han
Acked-by: Lee Jones
---
drivers/video/backlight/ld9040.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/backlight/ld9040.c
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han
Acked-by: Lee Jones
---
drivers/video/backlight/corgi_lcd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/corgi_lcd.c
b/drivers/video/backlight
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han
Acked-by: Lee Jones
---
drivers/video/backlight/cr_bllcd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/cr_bllcd.c
b/drivers/video/backlight
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han
Acked-by: Lee Jones
---
drivers/video/backlight/adp8870_bl.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/video/backlight/adp8870_bl.c
b/drivers/video
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han
Acked-by: Lee Jones
---
drivers/video/backlight/adp8860_bl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/video/backlight/adp8860_bl.c
b/drivers/video
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han
Acked-by: Lee Jones
---
drivers/video/backlight/adp5520_bl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/adp5520_bl.c
b/drivers/video/backlight
Jones's Acked-by for 1~18th patches, except for 17th patch.
- Fixed 17th patch, per Lee Jones's feedback.
Jingoo Han (18)
backlight: adp5520: add blank line after declarations
backlight: adp8860: add blank line after declarations
backlight: adp8870: add blank line after
On Wednesday, August 27, 2014 1:28 AM, Lee Jones wrote:
> On Tue, 26 Aug 2014, Jingoo Han wrote:
>
> > Fixed the following checkpatch warning.
> >
> > WARNING: else is not generally useful after a break or return
> >
> > Signed-off-by: Jingoo Han
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han
---
drivers/video/backlight/omap1_bl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/omap1_bl.c
b/drivers/video/backlight/omap1_bl.c
index
Fixed the following checkpatch warning.
WARNING: else is not generally useful after a break or return
Signed-off-by: Jingoo Han
---
drivers/video/backlight/jornada720_lcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/backlight/jornada720_lcd.c
b
Fixed the following checkpatch warning.
WARNING: else is not generally useful after a break or return
Signed-off-by: Jingoo Han
---
drivers/video/backlight/jornada720_bl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/backlight/jornada720_bl.c
b
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han
---
drivers/video/backlight/wm831x_bl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/wm831x_bl.c
b/drivers/video/backlight/wm831x_bl.c
index
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han
---
drivers/video/backlight/pcf50633-backlight.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/pcf50633-backlight.c
b/drivers/video/backlight
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han
---
drivers/video/backlight/tdo24m.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/backlight/tdo24m.c b/drivers/video/backlight/tdo24m.c
index 908016fc5829
Fixed the following checkpatch warning.
WARNING: else is not generally useful after a break or return
Signed-off-by: Jingoo Han
---
drivers/video/backlight/s6e63m0.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/video/backlight/s6e63m0.c
b/drivers
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han
---
drivers/video/backlight/lp855x_bl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/backlight/lp855x_bl.c
b/drivers/video/backlight/lp855x_bl.c
index
Fixed the following checkpatch warning.
WARNING: else is not generally useful after a break or return
Signed-off-by: Jingoo Han
---
drivers/video/backlight/lms501kf03.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/video/backlight/lms501kf03.c
b
Fixed the following checkpatch warning.
WARNING: else is not generally useful after a break or return
Signed-off-by: Jingoo Han
---
drivers/video/backlight/ili922x.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/video/backlight/ili922x.c
b/drivers
Fixed the following checkpatch warning.
WARNING: else is not generally useful after a break or return
Signed-off-by: Jingoo Han
---
drivers/video/backlight/ld9040.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/backlight/ld9040.c b/drivers/video
Fixed the following checkpatch warning.
WARNING: void function return statements are not generally useful
Signed-off-by: Jingoo Han
---
drivers/video/backlight/lm3639_bl.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video/backlight/lm3639_bl.c
b/drivers/video/backlight
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han
---
drivers/video/backlight/corgi_lcd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/corgi_lcd.c
b/drivers/video/backlight/corgi_lcd.c
index
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han
---
drivers/video/backlight/cr_bllcd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/cr_bllcd.c
b/drivers/video/backlight/cr_bllcd.c
index
Fixed the following checkpatch warning.
WARNING: else is not generally useful after a break or return
Signed-off-by: Jingoo Han
---
drivers/video/backlight/ams369fg06.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/backlight/ams369fg06.c
b/drivers
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han
---
drivers/video/backlight/adp8870_bl.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/video/backlight/adp8870_bl.c
b/drivers/video/backlight/adp8870_bl.c
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han
---
drivers/video/backlight/adp8860_bl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/video/backlight/adp8860_bl.c
b/drivers/video/backlight/adp8860_bl.c
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han
---
drivers/video/backlight/adp5520_bl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/adp5520_bl.c
b/drivers/video/backlight/adp5520_bl.c
index
This patchset fixes checkpatch warnings as follows.
There is no functional change.
WARNING: Missing a blank line after declarations
WARNING: else is not generally useful after a break or return
WARNING: void function return statements are not generally useful
Jingoo Han (18
This patchset fixes checkpatch warnings as follows.
There is no functional change.
WARNING: Missing a blank line after declarations
WARNING: else is not generally useful after a break or return
WARNING: void function return statements are not generally useful
Jingoo Han (18
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/video/backlight/adp5520_bl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/adp5520_bl.c
b/drivers/video/backlight
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/video/backlight/adp8860_bl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/video/backlight/adp8860_bl.c
b/drivers/video
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/video/backlight/adp8870_bl.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/video/backlight/adp8870_bl.c
b/drivers/video
Fixed the following checkpatch warning.
WARNING: else is not generally useful after a break or return
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/video/backlight/ams369fg06.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/backlight
301 - 400 of 3732 matches
Mail list logo