[PATCH] fs: remove dead config CONFIG_HAS_COMPAT_EPOLL_EVENT symbol

2007-11-15 Thread Jiri Olsa
remove dead config CONFIG_HAS_COMPAT_EPOLL_EVENT symbol Signed-off-by: Jiri Olsa [EMAIL PROTECTED] --- fs/compat.c| 49 include/linux/compat.h |8 --- 2 files changed, 0 insertions(+), 57 deletions(-) diff --git a/fs

Re: [uml-devel] uml doesn't work on 2.6.24-rc2

2007-11-23 Thread Jiri Olsa
Hi, after applying following changes, the mainline is working for me. Jiri Olsa diff --git a/arch/um/Kconfig.i386 b/arch/um/Kconfig.i386 index e0ac74e..234fcb4 100644 --- a/arch/um/Kconfig.i386 +++ b/arch/um/Kconfig.i386 @@ -8,6 +8,13 @@ config UML_X86 bool default y +config

[PATCH 08/25] perf tests: Add attr record count test

2012-10-30 Thread Jiri Olsa
Adding test to validate perf_event_attr data for command: 'record -c 123' Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford

[PATCH 09/25] perf tests: Add attr record graph test

2012-10-30 Thread Jiri Olsa
Adding tests to validate perf_event_attr data for commands: 'record -g --' 'record -g fp 'record -g dwarf Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras

[PATCH 16/25] perf tests: Add attr record branch any test

2012-10-30 Thread Jiri Olsa
From: jo...@redhat.com jo...@redhat.com Adding test to validate perf_event_attr data for command: 'record -b' Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul

[PATCH 19/25] perf tests: Add attr stat no-inherit test

2012-10-30 Thread Jiri Olsa
Adding test to validate perf_event_attr data for command: 'stat -i' Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash

[PATCH 21/25] perf tests: Add attr stat event syntax group test

2012-10-30 Thread Jiri Olsa
Adding test to validate perf_event_attr data for command: 'stat -e {cycles,instructions}' Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc

[PATCH 00/25] perf test: Add perf_event_attr tests

2012-10-30 Thread Jiri Olsa
hi, this code tests the link between perf stat/record command line options and final perf_event_attr struct values. Also it tests the group fd linkage. Plus moving test related objects under 'test' directory. Attached patches: 01/25 perf tools: Remove BINDIR define from exec_cmd.o 02/25 perf

[PATCH 24/25] perf tests: Add attr tests under builtin test command

2012-10-30 Thread Jiri Olsa
The test attr suite is run only if it's run under perf source directory, or tests are found in installed path. Otherwise tests are omitted (notification is displayed) and finished as successful. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc

[PATCH 25/25] perf tests: Add documentation for attr tests

2012-10-30 Thread Jiri Olsa
Adding documentation for attr tests. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc

[PATCH 23/25] perf tests: Add attr stat default test

2012-10-30 Thread Jiri Olsa
From: jo...@redhat.com jo...@redhat.com Adding test to validate perf_event_attr data for commands: 'stat -d' 'stat -dd' 'stat -ddd' Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi

[PATCH 13/25] perf tests: Add attr record data test

2012-10-30 Thread Jiri Olsa
From: jo...@redhat.com jo...@redhat.com Adding test to validate perf_event_attr data for command: 'record -d' Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul

[PATCH 12/25] perf tests: Add attr record no-inherit test

2012-10-30 Thread Jiri Olsa
Adding test to validate perf_event_attr data for command: 'record -i' Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford

[PATCH 18/25] perf tests: Add attr stat basic test

2012-10-30 Thread Jiri Olsa
Adding test to validate perf_event_attr data for command: 'stat -e cycles' Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford

[PATCH 22/25] perf tests: Add attr stat default test

2012-10-30 Thread Jiri Olsa
From: jo...@redhat.com jo...@redhat.com Adding test to validate perf_event_attr data for command: 'stat' Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau

[PATCH 20/25] perf tests: Add attr stat group test

2012-10-30 Thread Jiri Olsa
Adding test to validate perf_event_attr data for command: 'stat --group -e cycles,instructions' Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau

[PATCH 17/25] perf tests: Add attr record branch filter tests

2012-10-30 Thread Jiri Olsa
From: jo...@redhat.com jo...@redhat.com Adding test to validate perf_event_attr data for command: 'record -j any' 'record -j any_call' 'record -j any_ret' 'record -j hv' 'record -j ind_call' 'record -j k' 'record -j u' Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho

[PATCH 14/25] perf tests: Add attr record raw test

2012-10-30 Thread Jiri Olsa
From: jo...@redhat.com jo...@redhat.com Adding test to validate perf_event_attr data for command: 'record -R' Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul

[PATCH 15/25] perf tests: Add attr record no delay test

2012-10-30 Thread Jiri Olsa
From: jo...@redhat.com jo...@redhat.com Adding test to validate perf_event_attr data for command: 'record -D' Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul

[PATCH 06/25] perf tests: Add attr record event syntax group test

2012-10-30 Thread Jiri Olsa
Adding test to validate perf_event_attr data for command: 'record group -e {cycles,instructions}' Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau

[PATCH 01/25] perf tools: Remove BINDIR define from exec_cmd.o compilation

2012-10-30 Thread Jiri Olsa
It's not needed. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis

[PATCH 10/25] perf tests: Add attr record period test

2012-10-30 Thread Jiri Olsa
Adding test to validate perf_event_attr data for command: 'record -c 100 -P' Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey

[PATCH 04/25] perf tests: Add attr record basic test

2012-10-30 Thread Jiri Olsa
Adding test to validate perf_event_attr data for command: 'record' Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash

[PATCH 11/25] perf tests: Add attr record no samples test

2012-10-30 Thread Jiri Olsa
Adding test to validate perf_event_attr data for command: 'record -n' Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford

[PATCH 07/25] perf tests: Add attr record freq test

2012-10-30 Thread Jiri Olsa
Adding test to validate perf_event_attr data for command: 'record -F 100' Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford

[PATCH 05/25] perf tests: Add attr record group test

2012-10-30 Thread Jiri Olsa
Adding test to validate perf_event_attr data for command: 'record --group -e cycles,instructions' Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau

[PATCH 03/25] perf tests: Add framework for automated perf_event_attr tests

2012-10-30 Thread Jiri Olsa
./tests/attr.py -d ./tests/attr/ -p ./perf -v Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc

Re: [PATCH 03/25] perf tests: Add framework for automated perf_event_attr tests

2012-10-30 Thread Jiri Olsa
On Tue, Oct 30, 2012 at 11:01:44PM +0100, Jiri Olsa wrote: Adding automated test to check event's perf_event_attr values. The idea is run perf session with kidnapping sys_perf_event_open function. For each sys_perf_event_open call we store the perf_event_attr data to the file to be checked

[PATCHv2 03/25] perf tests: Add framework for automated perf_event_attr tests

2012-10-31 Thread Jiri Olsa
On Wed, Oct 31, 2012 at 07:26:00AM -0700, Arnaldo Carvalho de Melo wrote: Em Wed, Oct 31, 2012 at 12:01:20AM +0100, Jiri Olsa escreveu: On Tue, Oct 30, 2012 at 11:01:44PM +0100, Jiri Olsa wrote: Adding automated test to check event's perf_event_attr values. SNIP + +void

Re: [PATCH 00/25] perf test: Add perf_event_attr tests

2012-11-01 Thread Jiri Olsa
On Thu, Nov 01, 2012 at 05:38:01PM -0300, Arnaldo Carvalho de Melo wrote: Em Tue, Oct 30, 2012 at 11:01:41PM +0100, Jiri Olsa escreveu: hi, this code tests the link between perf stat/record command line options and final perf_event_attr struct values. Also it tests the group fd linkage

Re: [PATCH 02/25] perf tests: Move test objects into 'tests' directory

2012-11-02 Thread Jiri Olsa
On Fri, Nov 02, 2012 at 10:48:57AM +0900, Namhyung Kim wrote: Hi Jiri, Despite its way to acme's tree, I'd like to leave a few comments. :) On Tue, 30 Oct 2012 23:01:43 +0100, Jiri Olsa wrote: Separating test objects into 'tests' directory. Signed-off-by: Jiri Olsa jo...@redhat.com

Re: [PATCHv2 03/25] perf tests: Add framework for automated perf_event_attr tests

2012-11-02 Thread Jiri Olsa
On Fri, Nov 02, 2012 at 11:18:56AM +0900, Namhyung Kim wrote: On Wed, 31 Oct 2012 15:52:47 +0100, Jiri Olsa wrote: Adding automated test to check event's perf_event_attr values. +#define WRITE_ASS(str, fmt, data) \ +do

Re: Current perf tool does not compile anymore on RHEL6

2012-09-24 Thread Jiri Olsa
On Tue, Sep 18, 2012 at 10:29:48AM -0700, Andi Kleen wrote: Presumably flex-2.5.35-8.el6.x86_64 doesn't support YY_EXTRA Problem started with commit 90e2b22dee908c13df256140a0d6527e3e8ea3f4 Author: Jiri Olsa jo...@redhat.com Date: Fri Jun 15 14:31:40 2012 +0800 perf/tool: Add

Re: Current perf tool does not compile anymore on RHEL6

2012-09-24 Thread Jiri Olsa
On Mon, Sep 24, 2012 at 12:28:04PM +0200, Jiri Olsa wrote: On Tue, Sep 18, 2012 at 10:29:48AM -0700, Andi Kleen wrote: Presumably flex-2.5.35-8.el6.x86_64 doesn't support YY_EXTRA Problem started with commit 90e2b22dee908c13df256140a0d6527e3e8ea3f4 Author: Jiri Olsa jo

[PATCH 12/14] perf diff: Add -F option to display formula for computation

2012-09-27 Thread Jiri Olsa
: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Namhyung Kim namhy...@kernel.org Signed-off-by: Jiri Olsa jo...@redhat.com --- tools/perf/Documentation/perf-diff.txt | 4 ++ tools/perf/builtin-diff.c | 67

[PATCH 09/14] perf diff: Add option to sort entries based on diff computation

2012-09-27 Thread Jiri Olsa
pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Namhyung Kim namhy...@kernel.org Signed-off-by: Jiri Olsa jo...@redhat.com --- tools/perf/Documentation/perf-diff.txt | 2 + tools/perf/builtin-diff.c | 137

[PATCH 04/14] perf tools: Removing hists pair argument from output path

2012-09-27 Thread Jiri Olsa
Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Namhyung Kim namhy...@kernel.org Signed-off-by: Jiri Olsa jo...@redhat.com --- tools/perf/builtin-diff.c | 3 +-- tools/perf/builtin-report.c | 2 +- tools/perf

[PATCH 03/14] perf hists: Separate overhead and baseline columns

2012-09-27 Thread Jiri Olsa
: Frederic Weisbecker fweis...@gmail.com Cc: Namhyung Kim namhy...@kernel.org Signed-off-by: Jiri Olsa jo...@redhat.com --- tools/perf/ui/hist.c | 74 ++ tools/perf/ui/stdio/hist.c | 11 +-- tools/perf/util/hist.h | 1 + 3 files changed, 58

[PATCH 02/14] perf diff: Refactor diff displacement possition info

2012-09-27 Thread Jiri Olsa
Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Namhyung Kim namhy...@kernel.org Signed-off-by: Jiri Olsa jo...@redhat.com --- tools/perf/builtin

[PATCHv2 00/14] perf diff: Factor diff command

2012-09-27 Thread Jiri Olsa
hi, this is v2 of diff command changes proposed in here: https://lkml.org/lkml/2012/9/6/344 It's now rebased on new hists hpp* interface plus few more additional changes. I'm still testing/using it to come up with some proved usability, but would be nice to have it in anyway. v2 changes: -

[PATCH 08/14] perf diff: Removing the total_period argument from output code

2012-09-27 Thread Jiri Olsa
Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Namhyung Kim namhy...@kernel.org Signed-off-by: Jiri Olsa jo...@redhat.com --- tools/perf/ui/browsers

[PATCH 10/14] perf diff: Add weighted diff computation way to compare hist entries

2012-09-27 Thread Jiri Olsa
Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Namhyung Kim namhy...@kernel.org Signed-off-by: Jiri Olsa jo...@redhat.com --- tools/perf/Documentation/perf-diff.txt | 15 - tools/perf/builtin-diff.c

[PATCH 01/14] perf hists: Add struct hists pointer to struct hist_entry

2012-09-27 Thread Jiri Olsa
Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Namhyung Kim namhy...@kernel.org Signed-off-by: Jiri Olsa jo...@redhat.com --- tools/perf/util/hist.c | 2 ++ tools/perf/util/sort.h | 1 + 2 files

[PATCH 06/14] perf tool: Add hpp interface to enable/disable hpp column

2012-09-27 Thread Jiri Olsa
: Namhyung Kim namhy...@kernel.org Signed-off-by: Jiri Olsa jo...@redhat.com --- tools/perf/builtin-diff.c | 18 +- tools/perf/builtin-report.c| 2 +- tools/perf/ui/browsers/hists.c | 2 +- tools/perf/ui/gtk/browser.c| 2 +- tools/perf/ui/hist.c | 15

[PATCH 07/14] perf diff: Add ratio computation way to compare hist entries

2012-09-27 Thread Jiri Olsa
Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Namhyung Kim namhy...@kernel.org Signed-off-by: Jiri Olsa jo...@redhat.com --- tools/perf/Documentation/perf-diff.txt | 33

[PATCH 14/14] perf diff: Display empty space for non paired samples

2012-09-27 Thread Jiri Olsa
: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Namhyung Kim namhy...@kernel.org Signed-off-by: Jiri Olsa jo...@redhat.com --- tools/perf/ui/hist.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff

[PATCH 11/14] perf diff: Add -p option to display period values for hist entries

2012-09-27 Thread Jiri Olsa
Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Namhyung Kim namhy...@kernel.org Signed-off-by: Jiri Olsa jo...@redhat.com --- tools/perf/Documentation/perf-diff.txt | 4 tools/perf/builtin-diff.c | 10

[PATCH 13/14] perf diff: Include samples without symbol in overall stats

2012-09-27 Thread Jiri Olsa
: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Namhyung Kim namhy...@kernel.org Signed-off-by: Jiri Olsa jo...@redhat.com --- tools/perf/builtin-diff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-diff.c b/tools/perf

[PATCH 05/14] perf diff: Add -b option for perf diff to display paired entries only

2012-09-27 Thread Jiri Olsa
Cc: Frederic Weisbecker fweis...@gmail.com Cc: Namhyung Kim namhy...@kernel.org Signed-off-by: Jiri Olsa jo...@redhat.com --- tools/perf/Documentation/perf-diff.txt | 4 tools/perf/builtin-diff.c | 31 +-- 2 files changed, 33 insertions(+), 2 deletions

Re: [PATCH 05/16] perf tools: Keep group information

2012-09-27 Thread Jiri Olsa
SNIP diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c index bf5d033ee1b4..3c52d0ab9270 100644 --- a/tools/perf/util/parse-events.c +++ b/tools/perf/util/parse-events.c @@ -830,6 +830,7 @@ int parse_events(struct perf_evlist *evlist, const char *str, if

Re: [PATCH] perf tool: Fix build for NO_DWARF=1 case

2012-10-03 Thread Jiri Olsa
On Tue, Oct 02, 2012 at 06:45:36PM -0300, Arnaldo Carvalho de Melo wrote: Em Tue, Oct 02, 2012 at 03:10:49PM +0200, Jiri Olsa escreveu: On Tue, Oct 02, 2012 at 07:39:23AM -0400, Ben Guthro wrote: Actually - I hadn't noticed these warnings before. After installing libdw-dev - the perf

[PATCHv3] perf x86_64: Fix rsp register for system call fast path

2012-10-03 Thread Jiri Olsa
On Tue, Oct 02, 2012 at 06:16:47PM +0200, Frederic Weisbecker wrote: On Tue, Oct 02, 2012 at 06:06:26PM +0200, Jiri Olsa wrote: On Tue, Oct 02, 2012 at 05:49:26PM +0200, Frederic Weisbecker wrote: On Tue, Oct 02, 2012 at 04:58:15PM +0200, Jiri Olsa wrote: SNIP could be.. I guess I

[PATCHv4] perf x86_64: Fix rsp register for system call fast path

2012-10-03 Thread Jiri Olsa
On Wed, Oct 03, 2012 at 02:35:05PM +0200, Frederic Weisbecker wrote: On Wed, Oct 03, 2012 at 02:29:47PM +0200, Jiri Olsa wrote: +#ifdef CONFIG_X86_64 +__weak void Only annotate with __weak the default implementation you want to be overriden. Here you want it to actually override

Re: [PATCHv4] perf x86_64: Fix rsp register for system call fast path

2012-10-03 Thread Jiri Olsa
On Wed, Oct 03, 2012 at 03:22:17PM +0200, Peter Zijlstra wrote: On Wed, 2012-10-03 at 15:13 +0200, Jiri Olsa wrote: @@ -1190,8 +1191,8 @@ static inline void perf_sample_data_init(struct perf_sample_data *data, data-raw = NULL; data-br_stack = NULL; data-period

Re: [PATCHv2 00/14] perf diff: Factor diff command

2012-10-03 Thread Jiri Olsa
On Wed, Oct 03, 2012 at 06:55:32PM +0200, Andi Kleen wrote: hm, I missed this one.. hopefully it should be no problem to add it Here's more issues I found (again no show stopper): And another issue (this one is more serious): I was trying to compare the same program with two

[PATCH 1/2] perf x86_64: Fix rsp register for system call fast path

2012-10-04 Thread Jiri Olsa
Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Arnaldo Carvalho de Melo a...@redhat.com Cc: Oleg Nesterov o...@redhat.com Signed-off-by: Jiri Olsa jo...@redhat.com --- arch/x86/kernel/cpu/perf_event.c | 37

[PATCH 2/2] perf: Simplify the sample's user regs/stack retrieval

2012-10-04 Thread Jiri Olsa
mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Arnaldo Carvalho de Melo a...@redhat.com Signed-off-by: Jiri Olsa jo...@redhat.com --- kernel/events/core.c | 64 - 1 files changed, 31 insertions(+), 33

[PATH 0/2] perf: x86_64 rsp related changes

2012-10-04 Thread Jiri Olsa
On Wed, Oct 03, 2012 at 03:30:07PM +0200, Jiri Olsa wrote: On Wed, Oct 03, 2012 at 03:22:17PM +0200, Peter Zijlstra wrote: On Wed, 2012-10-03 at 15:13 +0200, Jiri Olsa wrote: @@ -1190,8 +1191,8 @@ static inline void perf_sample_data_init(struct perf_sample_data *data, data-raw

[PATCH 8/8] perf diff: Display empty space for non paired samples

2012-10-05 Thread Jiri Olsa
: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Namhyung Kim namhy...@kernel.org Cc: Andi Kleen a...@firstfloor.org Signed-off-by: Jiri Olsa jo...@redhat.com --- tools/perf/ui/hist.c | 10 -- 1 file changed, 8

[PATCH 5/8] perf diff: Add -p option to display period values for hist entries

2012-10-05 Thread Jiri Olsa
Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Namhyung Kim namhy...@kernel.org Cc: Andi Kleen a...@firstfloor.org Signed-off-by: Jiri Olsa jo...@redhat.com --- tools/perf/Documentation/perf-diff.txt | 4 tools/perf

[PATCH 1/8] perf diff: Add -b option for perf diff to display paired entries only

2012-10-05 Thread Jiri Olsa
Cc: Frederic Weisbecker fweis...@gmail.com Cc: Namhyung Kim namhy...@kernel.org Cc: Andi Kleen a...@firstfloor.org Signed-off-by: Jiri Olsa jo...@redhat.com --- tools/perf/Documentation/perf-diff.txt | 4 tools/perf/builtin-diff.c | 31 +-- 2 files

[PATCHv3 0/8] perf diff: Factor diff command

2012-10-05 Thread Jiri Olsa
hi, this is v3 of diff command changes proposed in here: https://lkml.org/lkml/2012/9/6/344 Half of the previous patchset version (hists related) got already in together with changes of Namhyung Kim. This is what remained, plus additional small fixies from review. - small delta format changes

[PATCH 6/8] perf diff: Add -F option to display formula for computation

2012-10-05 Thread Jiri Olsa
: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Namhyung Kim namhy...@kernel.org Cc: Andi Kleen a...@firstfloor.org Signed-off-by: Jiri Olsa jo...@redhat.com --- tools/perf/Documentation/perf-diff.txt | 4 ++ tools/perf/builtin-diff.c | 67

[PATCH 2/8] perf diff: Add ratio computation way to compare hist entries

2012-10-05 Thread Jiri Olsa
Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Namhyung Kim namhy...@kernel.org Cc: Andi Kleen a...@firstfloor.org Signed-off-by: Jiri Olsa jo...@redhat.com --- tools/perf/Documentation/perf

[PATCH 4/8] perf diff: Add weighted diff computation way to compare hist entries

2012-10-05 Thread Jiri Olsa
Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Namhyung Kim namhy...@kernel.org Cc: Andi Kleen a...@firstfloor.org Signed-off-by: Jiri Olsa jo...@redhat.com --- tools/perf/Documentation/perf-diff.txt | 15

[PATCH 7/8] perf diff: Include samples without symbol in overall stats

2012-10-05 Thread Jiri Olsa
: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Namhyung Kim namhy...@kernel.org Cc: Andi Kleen a...@firstfloor.org Signed-off-by: Jiri Olsa jo...@redhat.com --- tools/perf/builtin-diff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools

[PATCH 3/8] perf diff: Add option to sort entries based on diff computation

2012-10-05 Thread Jiri Olsa
pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Namhyung Kim namhy...@kernel.org Cc: Andi Kleen a...@firstfloor.org Signed-off-by: Jiri Olsa jo...@redhat.com --- tools/perf/Documentation/perf-diff.txt | 2 + tools/perf/builtin-diff.c

Re: [PATCHv2 03/25] perf tests: Add framework for automated perf_event_attr tests

2012-11-05 Thread Jiri Olsa
On Mon, Nov 05, 2012 at 11:29:11AM -0300, Arnaldo Carvalho de Melo wrote: Em Fri, Nov 02, 2012 at 11:40:52AM +0100, Jiri Olsa escreveu: On Fri, Nov 02, 2012 at 11:18:56AM +0900, Namhyung Kim wrote: +e = Event(section, parser_items, base_items) +events[section

[PATCH 0/4] perf tests: Fixies for perf_event_attr tests

2012-11-05 Thread Jiri Olsa
hi, this patches address comments and some other small fixies. It's based on current Arnaldo's perf/core. Attached patches: 1/4 perf tests: Add attr stat basic test 2/4 perf tests: Factor attr tests WRITE_ASS macro 3/4 perf tests: Fix attr watermark field name typo 4/4 perf tests:

[PATCH 2/4] perf tests: Factor attr tests WRITE_ASS macro

2012-11-05 Thread Jiri Olsa
Changing WRITE_ASS macro per Namhyung's comments, so the main usage case takes only attr field name and format string. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul

[PATCH 1/4] perf tests: Add attr stat basic test

2012-11-05 Thread Jiri Olsa
Adding test to validate perf_event_attr data for command: 'stat -e cycles' Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford

[PATCH 3/4] perf tests: Fix attr watermark field name typo

2012-11-05 Thread Jiri Olsa
Currently the 'watermark' field is coded as 'watermask'. As the type is global through the framework and tests, the typo spawned no error. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi

[PATCH 4/4] perf tests: Removing 'optional' field

2012-11-05 Thread Jiri Olsa
Since we allow multiple values in event field assignment, there's no need for 'optional' field.. old version removal leftover. Adding some comments into attr.py script regarding the test event load. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc

[PATCH] perf tests: Move attr.py temp dir cleanup into finally section

2012-11-08 Thread Jiri Olsa
Currently if there's 'Unsup' exception raised, we do not clean up the temp directory. Solving this by adding 'finally' to make the cleanup in any case. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo

Re: [BUG] perf list: --help option not implemented

2012-10-19 Thread Jiri Olsa
On Fri, Oct 19, 2012 at 10:27:35AM +0200, Stephane Eranian wrote: Jiri, When I run perf list, I see: $ perf list .. rNNN [Raw hardware event descriptor] cpu/t1=v1[,t2=v2,t3 ...]/modifier [Raw hardware event

Re: [PATCH 1/2] perf tools: add event modifier to request exclusive PMU access

2012-10-19 Thread Jiri Olsa
On Fri, Oct 19, 2012 at 05:17:57PM +0200, Stephane Eranian wrote: On Fri, Oct 19, 2012 at 5:13 PM, Peter Zijlstra pet...@infradead.org wrote: On Fri, 2012-10-19 at 16:52 +0200, Stephane Eranian wrote: -modifier_event [ukhpGH]{1,8} +modifier_event [ukhpGHx]{1,8} wouldn't the max modifier

Re: [PATCH 1/2] perf tools: add event modifier to request exclusive PMU access

2012-10-19 Thread Jiri Olsa
On Fri, Oct 19, 2012 at 05:47:11PM +0200, Stephane Eranian wrote: On Fri, Oct 19, 2012 at 5:23 PM, Jiri Olsa jo...@redhat.com wrote: On Fri, Oct 19, 2012 at 05:17:57PM +0200, Stephane Eranian wrote: On Fri, Oct 19, 2012 at 5:13 PM, Peter Zijlstra pet...@infradead.org wrote: On Fri, 2012

Re: [PATCH 1/2] perf tools: add event modifier to request exclusive PMU access

2012-10-19 Thread Jiri Olsa
On Fri, Oct 19, 2012 at 08:46:10AM -0700, Andi Kleen wrote: That's what I thought too, but then I don't understand why it was at eight before and not seven: One instance of each letter, + a second for pp (precise=2). Or am I missing something here? The number is pretty useless imho

[PATCH 03/11] perf tool: Use PERF_EVENT_IOC_ID perf ioctl to read event id

2012-10-20 Thread Jiri Olsa
Changing the way we retrieve the event ID. Instead of parsing out the ID out of the read data, using the PERF_EVENT_IOC_ID ioctl. Keeping the old way in place to support kernels without PERF_EVENT_IOC_ID ioctl support. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo

[PATCH 04/11] perf tool: Add support for parsing PERF_SAMPLE_READ sample type

2012-10-20 Thread Jiri Olsa
-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Namhyung Kim

[PATCH 07/11] perf tool: Add PERF_SAMPLE_READ sample related processing

2012-10-20 Thread Jiri Olsa
samples for all the values contained within the 'struct sample_read'. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash

[PATCH 09/11] perf test: Add parse events tests for leader sampling

2012-10-20 Thread Jiri Olsa
Adding 2 more tests to the automated parse events suite for following event config: '{cycles,cache-misses,branch-misses}:S' '{instructions,branch-misses}:Su' Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls

[PATCH 11/11] perf record: Fix mmap error output condition

2012-10-20 Thread Jiri Olsa
condition. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com

[PATCH 05/11] perf tool: Fix event ID retrieval for group format read case

2012-10-20 Thread Jiri Olsa
We need to fail the event ID retrieval in case both following conditions are true: - we are on kernel with no PERF_EVENT_IOC_ID support - PERF_FORMAT_GROUP read format is set Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra

[PATCH 10/11] perf tool: Display period values for all group members

2012-10-20 Thread Jiri Olsa
% 12.58% 2680708 359 ls [kernel.kallsyms] [k] clear_page_c ... Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey

[PATCH 08/11] perf tool: Add 'S' event/group modifier to read sample value

2012-10-20 Thread Jiri Olsa
. $ perf record -e '{cycles,cache-misses}:S' ls Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc

[PATCH 01/11] perf: Add PERF_EVENT_IOC_ID ioctl to return event ID

2012-10-20 Thread Jiri Olsa
and there's no way to find out what ID belongs to our fd (if we are not group leader event). Adding a simple ioctl that returns event primary ID for given fd. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo

[PATCH 06/11] perf tool: Add perf_evlist__id2sid function to get event ID related data

2012-10-20 Thread Jiri Olsa
Adding perf_evlist__id2sid function to be able to get ID related data. This will be helpful for PERF_FORMAT_GROUP samples where we need to store ID related period value for each event. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter

[PATCH 02/11] perf: Do not get values from disabled counters in group format read

2012-10-20 Thread Jiri Olsa
type processing. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis

[PATCH 00/11] perf tool: Add PERF_SAMPLE_READ sample read support

2012-10-20 Thread Jiri Olsa
hi, adding support to read sample values through the PERF_SAMPLE_READ sample type. It's now possible to specify 'S' modifier for an event and get its sample value by PERF_SAMPLE_READ. For group the 'S' modifier will enable sampling only for the leader and read all the group member by

Re: [PATCH 00/11] perf tool: Add PERF_SAMPLE_READ sample read support

2012-10-22 Thread Jiri Olsa
On Mon, Oct 22, 2012 at 04:32:11PM +0900, Namhyung Kim wrote: Hi Jiri, It'd be better if you provide a git branch for this series. aaah right, I forgot to mention that.. ;) git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/linux.git perf/group2 thanks, jirka -- To unsubscribe from this

Re: [PATCH 00/11] perf tool: Add PERF_SAMPLE_READ sample read support

2012-10-22 Thread Jiri Olsa
On Sun, Oct 21, 2012 at 06:38:49PM +0200, Ingo Molnar wrote: * Jiri Olsa jo...@redhat.com wrote: hi, adding support to read sample values through the PERF_SAMPLE_READ sample type. It's now possible to specify 'S' modifier for an event and get its sample value by PERF_SAMPLE_READ

Re: [BUG] perf list: --help option not implemented

2012-10-22 Thread Jiri Olsa
On Mon, Oct 22, 2012 at 04:12:23PM +0900, Namhyung Kim wrote: Hi, On Fri, 19 Oct 2012 10:46:36 +0200, Jiri Olsa wrote: On Fri, Oct 19, 2012 at 10:27:35AM +0200, Stephane Eranian wrote: Jiri, When I run perf list, I see: $ perf list .. rNNN

Re: [PATCH 03/11] perf tool: Use PERF_EVENT_IOC_ID perf ioctl to read event id

2012-10-22 Thread Jiri Olsa
On Mon, Oct 22, 2012 at 04:57:24PM +0900, Namhyung Kim wrote: Hi, Just a minor nitpicking.. On Sat, 20 Oct 2012 16:33:11 +0200, Jiri Olsa wrote: Changing the way we retrieve the event ID. Instead of parsing out the ID out of the read data, using the PERF_EVENT_IOC_ID ioctl

Re: [PATCH 00/11] perf tool: Add PERF_SAMPLE_READ sample read support

2012-10-22 Thread Jiri Olsa
On Mon, Oct 22, 2012 at 05:53:32PM +0900, Namhyung Kim wrote: On Mon, 22 Oct 2012 09:53:05 +0200, Jiri Olsa wrote: On Mon, Oct 22, 2012 at 04:32:11PM +0900, Namhyung Kim wrote: It'd be better if you provide a git branch for this series. aaah right, I forgot to mention that.. ;) git

Re: [PATCH 09/11] perf test: Add parse events tests for leader sampling

2012-10-22 Thread Jiri Olsa
On Mon, Oct 22, 2012 at 05:58:22PM +0900, Namhyung Kim wrote: On Sat, 20 Oct 2012 16:33:17 +0200, Jiri Olsa wrote: Adding 2 more tests to the automated parse events suite for following event config: '{cycles,cache-misses,branch-misses}:S' '{instructions,branch-misses}:Su' [snip

Re: [PATCH 00/11] perf tool: Add PERF_SAMPLE_READ sample read support

2012-10-22 Thread Jiri Olsa
On Mon, Oct 22, 2012 at 05:51:01PM +0900, Namhyung Kim wrote: On Mon, 22 Oct 2012 10:09:31 +0200, Jiri Olsa wrote: On Sun, Oct 21, 2012 at 06:38:49PM +0200, Ingo Molnar wrote: # # Samples: 86 of event 'anon group { cycles, cache-misses }' # Event count (approx.): 34863674

Re: [PATCH 02/11] perf: Do not get values from disabled counters in group format read

2012-10-23 Thread Jiri Olsa
On Tue, Oct 23, 2012 at 06:13:09PM +0200, Peter Zijlstra wrote: On Sat, 2012-10-20 at 16:33 +0200, Jiri Olsa wrote: It's possible some of the counters in the group could be disabled when sampling member of the event group is reading the rest via PERF_SAMPLE_READ sample type processing

Re: [PATCH 02/11] perf: Do not get values from disabled counters in group format read

2012-10-24 Thread Jiri Olsa
On Wed, Oct 24, 2012 at 02:01:18PM +0200, Peter Zijlstra wrote: On Tue, 2012-10-23 at 18:50 +0200, Jiri Olsa wrote: On Tue, Oct 23, 2012 at 06:13:09PM +0200, Peter Zijlstra wrote: On Sat, 2012-10-20 at 16:33 +0200, Jiri Olsa wrote: It's possible some of the counters in the group could

Re: [PATCH 02/11] perf: Do not get values from disabled counters in group format read

2012-10-24 Thread Jiri Olsa
On Wed, Oct 24, 2012 at 02:14:06PM +0200, Jiri Olsa wrote: On Wed, Oct 24, 2012 at 02:01:18PM +0200, Peter Zijlstra wrote: SNIP Right, so I don't object to the patch per-se, I was just curious how you ran into it, because ISTR what you just said, we enable all this stuff together

  1   2   3   4   5   6   7   8   9   10   >