On Tue, 10 Nov 2020 15:43:36 +0100 Linus Walleij
wrote:
>
>
> On Mon, Nov 9, 2020 at 10:07 AM Jisheng Zhang
> wrote:
>
> > To remove similar errors as below for all snps dw gpio users:
> >
> > OF: /...gpio-port@0: could not find phandle
> >
> >
The SDHCI_PRESET_FOR_* registers are not set(all read as zeros), so
set the quirk.
Signed-off-by: Jisheng Zhang
---
drivers/mmc/host/sdhci-of-dwcmshc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c
b/drivers/mmc/host/sdhci-of-dwcmshc.c
index
We have removed the dw_pcie_ops always exists assumption in dwc
core driver, we can remove the useless dw_pcie_ops now.
Signed-off-by: Jisheng Zhang
---
drivers/pci/controller/dwc/pcie-al.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/pci/controller/dwc/pcie-al.c
b/drivers
Some designware based device driver especially host only driver may
work well with the default read_dbi/write_dbi/link_up implementation
in pcie-designware.c, thus remove the assumption to simplify those
drivers.
Since v1:
- rebase to the latest dwc-next
Jisheng Zhang (2):
PCI: dwc: Don't
Some designware based device driver especially host only driver may
work well with the default read_dbi/write_dbi/link_up implementation
in pcie-designware.c, thus remove the assumption to simplify those
drivers.
Signed-off-by: Jisheng Zhang
---
drivers/pci/controller/dwc/pcie-designware-ep.c
After we move dw_pcie_msi_init() into core -- dw_pcie_host_init(), the
MSI stops working after resume. Because dw_pcie_host_init() is only
called once during probe. To fix this issue, we move dw_pcie_msi_init()
to dw_pcie_setup_rc().
Signed-off-by: Jisheng Zhang
---
drivers/pci/controller/dwc
nish probing this timer driver after the clock driver is probed.
>
> Signed-off-by: Dinh Nguyen
Reviewed-by: Jisheng Zhang
> ---
> drivers/clocksource/dw_apb_timer_of.c | 86 ---
> 1 file changed, 51 insertions(+), 35 deletions(-)
>
> d
The REG_PORT is defined twice, so remove one of them.
Signed-off-by: Jisheng Zhang
---
drivers/net/wireless/marvell/mwifiex/sdio.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.h
b/drivers/net/wireless/marvell/mwifiex/sdio.h
index dec534a6ddb1
by: Hulk Robot
> Signed-off-by: Wang Hai
Reviewed-by Jisheng Zhang
> ---
> v1->v2: just add 'ret = xxx'
> drivers/pci/controller/dwc/pcie-designware-host.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-de
On Mon, 16 Nov 2020 21:50:23 +0800 Wang Hai wrote:
>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
good catch.
>
> Fixes: 07940c369a6b ("PCI: dwc: Fix MSI page leakage in suspend/resume")
> Reported-by: Hulk Robot
>
If the phy enables power saving technology, the dwmac's software reset
needs more time to complete, enlarge dma reset timeout to 20us.
Signed-off-by: Jisheng Zhang
---
drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
Use the devm_reset_control_get_optional() and devm_clk_get_optional()
rather than open coding them.
Signed-off-by: Jisheng Zhang
---
Since v1:
- keep wrapped as suggested by Jakub
.../ethernet/stmicro/stmmac/stmmac_platform.c | 22 ---
1 file changed, 9 insertions(+), 13
On Mon, 9 Nov 2020 11:57:13 -0800 Jakub Kicinski wrote:
>
>
> On Mon, 9 Nov 2020 16:09:10 +0800 Jisheng Zhang wrote:
> > @@ -596,14 +595,10 @@ stmmac_probe_config_dt(struct platform_device *pdev,
> > const char **mac)
> > dev_dbg(>dev, "
On Mon, 9 Nov 2020 10:34:14 + Russell King - ARM Linux admin wrote:
>
>
> On Mon, Nov 09, 2020 at 09:59:53AM +0800, Jisheng Zhang wrote:
> > diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c
> > b/drivers/usb/dwc3/dwc3-meson-g12a.c
> > index 417e05
This is to remove similar errors as below:
OF: /.../gpio-port@0: could not find phandle
Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
explained the reason of above errors well and added the generic
"ngpios" property, let's use it.
Signed-off-by: Jish
This is to remove similar errors as below:
OF: /.../gpio-port@0: could not find phandle
Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
explained the reason of above errors well and added the generic
"ngpios" property, let's use it.
Signed-off-by: Jish
This is to remove similar errors as below:
OF: /.../gpio-port@0: could not find phandle
Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
explained the reason of above errors well and added the generic
"ngpios" property, let's use it.
Signed-off-by: Jish
This is to remove similar errors as below:
OF: /.../gpio-port@0: could not find phandle
Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
explained the reason of above errors well and added the generic
"ngpios" property, let's use it.
Signed-off-by: Jish
This is to remove similar errors as below:
OF: /.../gpio-port@0: could not find phandle
Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
explained the reason of above errors well and added the generic
"ngpios" property, let's use it.
Signed-off-by: Jish
To remove similar errors as below for all snps dw gpio users:
OF: /...gpio-port@0: could not find phandle
Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
explained the reason of above errors well and added the generic
"ngpios" property, let's use i
This is to remove similar errors as below:
OF: /.../gpio-port@0: could not find phandle
Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
explained the reason of above errors well and added the generic
"ngpios" property, let's use it.
Signed-off-by: Jish
This is to remove similar errors as below:
OF: /.../gpio-port@0: could not find phandle
Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
explained the reason of above errors well and added the generic
"ngpios" property, let's use it.
Signed-off-by: Jish
This is to remove similar errors as below:
OF: /.../gpio-port@0: could not find phandle
Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
explained the reason of above errors well and added the generic
"ngpios" property, let's use it.
Signed-off-by: Jish
Use the devm_reset_control_get_optional() and devm_clk_get_optional()
rather than open coding them.
Signed-off-by: Jisheng Zhang
---
.../ethernet/stmicro/stmmac/stmmac_platform.c | 21 +++
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/drivers/net/ethernet
The return pointer of dwc_eth_dwmac_data's .probe isn't used, and
"probe" usually return int, so change the prototype to follow standard
way. Secondly, it can simplify the tegra_eqos_probe() code.
Signed-off-by: Jisheng Zhang
---
.../stmicro/stmmac/dwmac-dwc-qos-eth.c
usb.c | 4 +---
For phy-berlin-usb.c,
Reviewed-by: Jisheng Zhang
> drivers/phy/marvell/phy-mmp3-usb.c | 4 +---
> drivers/phy/marvell/phy-mvebu-sata.c | 4 +---
> drivers/phy/marvell/phy-pxa-28nm-hsic.c | 4 +---
> drivers/phy/marvell/phy-pxa-28nm-usb2.c | 4 +---
> dr
Use managed API devm_of_platform_populate() to simplify error and exit
code path.
Signed-off-by: Jisheng Zhang
---
drivers/usb/dwc3/dwc3-exynos.c | 2 +-
drivers/usb/dwc3/dwc3-keystone.c | 2 +-
drivers/usb/dwc3/dwc3-meson-g12a.c | 5 +
drivers/usb/dwc3/dwc3-of-simple.c | 4
The .config_aneg in microchip_t1 is genphy_config_aneg, so it's not
needed, because the phy core will call genphy_config_aneg() if the
.config_aneg is NULL.
Signed-off-by: Jisheng Zhang
---
drivers/net/phy/microchip_t1.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/phy
On Thu, 15 Oct 2020 15:08:33 +0100
Robin Murphy wrote:
>
>
> On 2020-10-15 10:52, Jisheng Zhang wrote:
> > On Thu, 15 Oct 2020 01:48:13 -0700
> > Saravana Kannan wrote:
> >
> >> On Thu, Oct 15, 2020 at 1:15 AM Jisheng Zhang
> >> wrote:
&
On Thu, 15 Oct 2020 01:48:13 -0700
Saravana Kannan wrote:
> On Thu, Oct 15, 2020 at 1:15 AM Jisheng Zhang
> wrote:
> >
> > On Wed, 14 Oct 2020 22:04:24 -0700 Saravana Kannan wrote:
> >
> > >
> > >
> > > On Wed, Oct 14, 2020 at 9:02 PM Jishe
ve command gives 51.3 MB/s
So it looks like sdhci-of-dwcmshc expects Version 4 Mode for Auto
CMD Auto Select. Fix the performance degradation by ensuring v4_mode
is true to use Auto CMD Auto Select.
Fixes: 427b6514d095 ("mmc: sdhci: Add Auto CMD Auto Select support")
Signed-off-by: Jisheng
On Wed, 14 Oct 2020 22:04:24 -0700 Saravana Kannan wrote:
>
>
> On Wed, Oct 14, 2020 at 9:02 PM Jisheng Zhang
> wrote:
> >
> > On Wed, 14 Oct 2020 10:29:36 -0700
> > Saravana Kannan wrote:
> >
> > >
> > >
> > > On Wed, Oct 14, 2
On Wed, 14 Oct 2020 10:29:36 -0700
Saravana Kannan wrote:
> CAUTION: Email originated externally, do not click links or open attachments
> unless you recognize the sender and know the content is safe.
>
>
> On Wed, Oct 14, 2020 at 4:12 AM Jisheng Zhang
> wrote:
> >
The compatible string is never used.
Signed-off-by: Jisheng Zhang
---
Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml | 5 -
1 file changed, 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml
b/Documentation/devicetree/bindings/gpio/snps
The compatible string is never used.
Signed-off-by: Jisheng Zhang
---
arch/arm/boot/dts/berlin2.dtsi | 6 --
arch/arm/boot/dts/berlin2cd.dtsi | 6 --
arch/arm/boot/dts/berlin2q.dtsi | 6 --
3 files changed, 18 deletions(-)
diff --git a/arch/arm/boot/dts/berlin2.dtsi b/arch/arm
The compatible string is never used.
Signed-off-by: Jisheng Zhang
---
arch/arm64/boot/dts/hisilicon/hip05.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hip05.dtsi
b/arch/arm64/boot/dts/hisilicon/hip05.dtsi
index bc49955360db..390225f8979c 100644
The compatible string is never used.
Signed-off-by: Jisheng Zhang
---
arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
index 9d7f19e97df7
The "snps,dw-apb-gpio-port" is never used.
Jisheng Zhang (8):
ARM: dts: berlin: Remove compatible string from dw apb gpio port
ARM: dts: socfpga: Remove compatible string from dw apb gpio port
arm64: dts: apm: remove compatible string from dw apb gpio port
arm64: dts: bitma
The compatible string is never used.
Signed-off-by: Jisheng Zhang
---
arch/arm64/boot/dts/synaptics/as370.dtsi | 2 --
arch/arm64/boot/dts/synaptics/berlin4ct.dtsi | 6 --
2 files changed, 8 deletions(-)
diff --git a/arch/arm64/boot/dts/synaptics/as370.dtsi
b/arch/arm64/boot/dts
The compatible string is never used.
Signed-off-by: Jisheng Zhang
---
arch/arm/boot/dts/socfpga.dtsi| 3 ---
arch/arm/boot/dts/socfpga_arria10.dtsi| 3 ---
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 2 --
3 files changed, 8 deletions(-)
diff --git
The compatible string is never used.
Signed-off-by: Jisheng Zhang
---
arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 1 -
arch/arm64/boot/dts/apm/apm-storm.dtsi | 1 -
2 files changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
b/arch/arm64/boot/dts/apm/apm
The compatible string is never used.
Signed-off-by: Jisheng Zhang
---
arch/arm64/boot/dts/bitmain/bm1880.dtsi | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm64/boot/dts/bitmain/bm1880.dtsi
b/arch/arm64/boot/dts/bitmain/bm1880.dtsi
index fa6e6905f588..f80373358bba 100644
Hi,
If set fw_devlink as on, any consumers of dw apb gpio won't probe.
The related dts looks like:
gpio0: gpio@2400 {
compatible = "snps,dw-apb-gpio";
#address-cells = <1>;
#size-cells = <0>;
porta: gpio-port@0 {
compatible = "snps,dw-apb-gpio-port";
Let the designware host take care the integrated msi init rather
than duplicate dw_pcie_msi_init() in each users.
Signed-off-by: Jisheng Zhang
---
Hi Vidya,
After V7, only this patch is left, others in v2 are not needed. There's one
more clean up chance -- we can also move dw_pcie_free_msi
If MSI is disabled, there's no need to program PCIE_MSI_INTR0_MASK
and PCIE_MSI_INTR0_ENABLE registers.
Signed-off-by: Jisheng Zhang
Reviewed-by: Rob Herring
Acked-by: Gustavo Pimentel
---
drivers/pci/controller/dwc/pcie-designware-host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
and the last patch. They could be
targeted to next. So will send out patches in a separate series.
Since v1:
- add proper error handling patches.
- solve the msi page leakage by moving dw_pcie_msi_init() from each
users to designware host
Jisheng Zhang (2):
PCI: dwc: Skip
() to dw_pcie_host_init().
Suggested-by: Rob Herring
Signed-off-by: Jisheng Zhang
Reviewed-by: Rob Herring
---
drivers/pci/controller/dwc/pci-dra7xx.c | 18 +-
.../pci/controller/dwc/pcie-designware-host.c | 33 ++-
drivers/pci/controller/dwc/pcie-designware.h | 2
On Thu, 8 Oct 2020 12:36:14 +0100 Lorenzo Pieralisi wrote:
>
> On Wed, Sep 30, 2020 at 09:12:05AM +0800, Jisheng Zhang wrote:
> > Fix two MSI issues. One to skip PCIE_MSI_INTR0* programming if MSI is
> > disabled, another to use an address in the driver data for MSI address,
If MSI is disabled, there's no need to program PCIE_MSI_INTR0_MASK
and PCIE_MSI_INTR0_ENABLE registers.
Signed-off-by: Jisheng Zhang
Reviewed-by: Rob Herring
Acked-by: Gustavo Pimentel
---
drivers/pci/controller/dwc/pcie-designware-host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
() to dw_pcie_host_init().
Suggested-by: Rob Herring
Signed-off-by: Jisheng Zhang
Reviewed-by: Rob Herring
---
drivers/pci/controller/dwc/pci-dra7xx.c | 18 +-
.../pci/controller/dwc/pcie-designware-host.c | 36 +--
drivers/pci/controller/dwc/pcie-designware.h | 2
in a separate series.
Since v1:
- add proper error handling patches.
- solve the msi page leakage by moving dw_pcie_msi_init() from each
users to designware host
Jisheng Zhang (2):
PCI: dwc: Skip PCIE_MSI_INTR0* programming if MSI is disabled
PCI: dwc: Fix MSI page leakage in suspend
On Tue, 6 Oct 2020 07:45:10 +0200
Heiner Kallweit wrote:
>
> On 05.10.2020 18:00, Florian Fainelli wrote:
> >
> >
> > On 10/5/2020 8:54 AM, Heiner Kallweit wrote:
> >> On 05.10.2020 17:41, Florian Fainelli wrote:
> >>>
> >>>
> &g
1 on v5.9-rc7?
Thanks
> FWIW, I acknowledge that the existing code does leak MSI target page
> every time system goes through suspend-resume sequence on Tegra194.
>
> Thanks,
> Vidya Sagar
>
> On 9/24/2020 4:35 PM, Jisheng Zhang wrote:
> > External email: Use caution
Convert m88e1318_get_wol() to use the well implemented phy_read_paged()
instead of open coding it.
Signed-off-by: Jisheng Zhang
---
drivers/net/phy/marvell.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
We have removed the dw_pcie_ops always exists assumption in dwc
core driver, we can remove the useless dw_pcie_ops now.
Signed-off-by: Jisheng Zhang
---
drivers/pci/controller/dwc/pci-imx6.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/pci/controller/dwc/pci-imx6.c
b/drivers
Some designware based device driver especially host only driver may
work well with the default read_dbi/write_dbi/link_up implementation
in pcie-designware.c, thus remove the assumption to simplify those
drivers.
Jisheng Zhang (3):
PCI: dwc: Don't assume the ops in dw_pcie always exists
PCI
Some designware based device driver especially host only driver may
work well with the default read_dbi/write_dbi/link_up implementation
in pcie-designware.c, thus remove the assumption to simplify those
drivers.
Signed-off-by: Jisheng Zhang
---
drivers/pci/controller/dwc/pcie-designware-ep.c
We have removed the dw_pcie_ops always exists assumption in dwc
core driver, we can remove the useless dw_pcie_ops now.
Signed-off-by: Jisheng Zhang
---
drivers/pci/controller/dwc/pcie-al.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/pci/controller/dwc/pcie-al.c
b/drivers
On Wed, 30 Sep 2020 13:23:29 -0700 Florian Fainelli wrote:
>
> On 9/30/2020 1:11 PM, Andrew Lunn wrote:
> > On Wed, Sep 30, 2020 at 01:07:19PM -0700, Florian Fainelli wrote:
> >>
> >>
> >> On 9/30/2020 12:09 PM, Andrew Lunn wrote:
> >>>
Hi,
A GE phy supports pad isolation which can save power in WOL mode. But once the
isolation is enabled, the MAC can't send/receive pkts to/from the phy because
the phy is "isolated". To make the PHY work normally, I need to move the
enabling isolation to suspend hook, so far so good. But the
Hi Marc,
On Tue, 29 Sep 2020 18:29:52 +0100 Marc Zyngier wrote:
>
>
> On 2020-09-24 12:06, Jisheng Zhang wrote:
> > We need to check alloc_page() succeed or not before continuing.
> >
> > Signed-off-by: Jisheng Zhang
> > ---
> > drivers/pci/co
handling patches.
- solve the msi page leakage by moving dw_pcie_msi_init() from each
users to designware host
Jisheng Zhang (2):
PCI: dwc: Skip PCIE_MSI_INTR0* programming if MSI is disabled
PCI: dwc: Fix MSI page leakage in suspend/resume
drivers/pci/controller/dwc/pci-dra7xx.c | 18
() to dw_pcie_host_init().
Signed-off-by: Jisheng Zhang
---
drivers/pci/controller/dwc/pci-dra7xx.c | 18 ++-
.../pci/controller/dwc/pcie-designware-host.c | 32 +--
drivers/pci/controller/dwc/pcie-designware.h | 2 +-
3 files changed, 34 insertions(+), 18 deletions
If MSI is disabled, there's no need to program PCIE_MSI_INTR0_MASK
and PCIE_MSI_INTR0_ENABLE registers.
Signed-off-by: Jisheng Zhang
Reviewed-by: Rob Herring
Acked-by: Gustavo Pimentel
---
drivers/pci/controller/dwc/pcie-designware-host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Hi Jon,
On Fri, 25 Sep 2020 09:53:45 +0100 Jon Hunter wrote:
>
> On 24/09/2020 12:05, Jisheng Zhang wrote:
> > Improve the msi code:
> > 1. Add proper error handling.
> > 2. Move dw_pcie_msi_init() from each users to designware host to solve
> > msi page leakage in
() to dw_pcie_host_init().
Signed-off-by: Jisheng Zhang
---
drivers/pci/controller/dwc/pci-dra7xx.c | 16 +-
.../pci/controller/dwc/pcie-designware-host.c | 32 +--
drivers/pci/controller/dwc/pcie-designware.h | 2 +-
3 files changed, 32 insertions(+), 18 deletions
If MSI is disabled, there's no need to program PCIE_MSI_INTR0_MASK
and PCIE_MSI_INTR0_ENABLE registers.
Signed-off-by: Jisheng Zhang
Reviewed-by: Rob Herring
Acked-by: Gustavo Pimentel
---
drivers/pci/controller/dwc/pcie-designware-host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
the msi page leakage by moving dw_pcie_msi_init() from each
users to designware host
Jisheng Zhang (2):
PCI: dwc: Skip PCIE_MSI_INTR0* programming if MSI is disabled
PCI: dwc: Fix MSI page leakage in suspend/resume
drivers/pci/controller/dwc/pci-dra7xx.c | 16 -
.../pci
On Fri, 25 Sep 2020 09:33:54 -0600 Rob Herring wrote:
>
> +Niklas
>
> On Fri, Sep 25, 2020 at 2:39 AM Jisheng Zhang
> wrote:
> >
> > There's no need to allocate a page for the MSI address, we could use
> > an address in the driver data.
> >
> > On
Hi,
On Fri, 25 Sep 2020 16:13:02 +0100 Jon Hunter wrote:
>
> Hi Jisheng,
>
> On 25/09/2020 10:27, Jisheng Zhang wrote:
>
> ...
>
> >> Could you please try below patch?
> >>
> >>
> >> diff --git a/drivers/pci/controller/dwc/pcie-
On Fri, 25 Sep 2020 17:17:12 +0800
Jisheng Zhang wrote:
> CAUTION: Email originated externally, do not click links or open attachments
> unless you recognize the sender and know the content is safe.
>
>
> Hi Jon,
>
> On Fri, 25 Sep 2020 09:53:45 +0100 Jon Hunter wrote:
&
Hi Jon,
On Fri, 25 Sep 2020 09:53:45 +0100 Jon Hunter wrote:
>
> On 24/09/2020 12:05, Jisheng Zhang wrote:
> > Improve the msi code:
> > 1. Add proper error handling.
> > 2. Move dw_pcie_msi_init() from each users to designware host to solve
> > m
; On Wed, 23 Sep 2020 at 08:28, Jisheng Zhang
> > wrote:
> > >
> > > Currently, dw_pcie_msi_init() allocates and maps page for msi, then
> > > program the PCIE_MSI_ADDR_LO and PCIE_MSI_ADDR_HI. The Root Complex
> > > may lose power during suspend-to-RAM, s
If MSI is disabled, there's no need to program PCIE_MSI_INTR0_MASK
and PCIE_MSI_INTR0_ENABLE registers.
Fixes: 7c5925afbc58 ("PCI: dwc: Move MSI IRQs allocation to IRQ
domainshierarchical API")
Signed-off-by: Jisheng Zhang
Acked-by: Gustavo Pimentel
---
drivers/pci/controlle
in a separate series.
Since v1:
- add proper error handling patches.
- solve the msi page leakage by moving dw_pcie_msi_init() from each
users to designware host
Jisheng Zhang (2):
PCI: dwc: Skip PCIE_MSI_INTR0* programming if MSI is disabled
PCI: dwc: Use an address in the driver data
is
leaked.
Fixes: 56e15a238d92 ("PCI: tegra: Add Tegra194 PCIe support")
Suggested-by: Rob Herring
Signed-off-by: Jisheng Zhang
---
.../pci/controller/dwc/pcie-designware-host.c | 22 ++-
drivers/pci/controller/dwc/pcie-designware.h | 1 -
2 files changed, 2 inserti
We need to check alloc_page() succeed or not before continuing.
Signed-off-by: Jisheng Zhang
---
drivers/pci/controller/dwc/pcie-designware-host.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c
b/drivers/pci/controller/dwc/pcie
If MSI is disabled, there's no need to program PCIE_MSI_INTR0_MASK
and PCIE_MSI_INTR0_ENABLE registers.
Signed-off-by: Jisheng Zhang
---
drivers/pci/controller/dwc/pcie-designware-host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/pcie
In dw_pcie_free_msi(), call dma_unmap_page() before freeing.
Signed-off-by: Jisheng Zhang
---
drivers/pci/controller/dwc/pcie-designware-host.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c
b/drivers/pci/controller
The dw_pcie_free_msi() does more things than freeing the msi page,
for example, remove irq domain etc., rename it as dw_pcie_msi_deinit.
Signed-off-by: Jisheng Zhang
---
drivers/pci/controller/dwc/pcie-designware-host.c | 6 +++---
drivers/pci/controller/dwc/pcie-designware.h | 4 ++--
2
to
dw_pcie_setup_rc(). After this moving, we solve the msi page leakage
as well.
Signed-off-by: Jisheng Zhang
---
drivers/pci/controller/dwc/pci-dra7xx.c | 1 +
drivers/pci/controller/dwc/pci-exynos.c | 2 --
drivers/pci/controller/dwc/pci-imx6.c | 3 ---
drivers/pci
to designware host
Jisheng Zhang (5):
PCI: dwc: Call dma_unmap_page() before freeing the msi page
PCI: dwc: Check alloc_page() return value
PCI: dwc: Rename dw_pcie_free_msi to dw_pcie_msi_deinit
PCI: dwc: Skip PCIE_MSI_INTR0* programming if MSI is disabled
PCI: dwc: Move dw_pcie_msi_init() from
Hi Rob,
On Wed, 23 Sep 2020 10:41:45 -0600 Rob Herring wrote:
>
> On Wed, Sep 23, 2020 at 12:27 AM Jisheng Zhang
> wrote:
> >
> > Currently, dw_pcie_msi_init() allocates and maps page for msi, then
> > program the PCIE_MSI_ADDR_LO and PCIE_MSI_ADDR_HI. The Root
) calls dw_pcie_msi_init() in resume path, the
previous msi page will be leaked.
Move the allocate and map msi page from dw_pcie_msi_init() to
dw_pcie_host_init() to fix this problem.
Fixes: 56e15a238d92 ("PCI: tegra: Add Tegra194 PCIe support")
Signed-off-by: Jisheng Zhang
---
d
Enable ALDPS(Advanced Link Down Power Saving) to save power when
link down.
Signed-off-by: Jisheng Zhang
---
Since v1:
- add what does ALDPS mean.
- replace magic number 0x18 with RTL8211F_PHYCR1 macro.
drivers/net/phy/realtek.c | 9 +
1 file changed, 9 insertions(+)
diff --git
Enable ALDPS function to save power when link down.
Signed-off-by: Jisheng Zhang
---
drivers/net/phy/realtek.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
index 95dbe5e8e1d8..961570186822 100644
--- a/drivers/net/phy
Convert the mp886x binding to DT schema format using json-schema.
Signed-off-by: Jisheng Zhang
---
.../devicetree/bindings/regulator/mp886x.txt | 31 --
.../bindings/regulator/mps,mp886x.yaml| 61 +++
2 files changed, 61 insertions(+), 31 deletions(-)
delete
As Rob suggested, use the "mps,switch-frequency-hz" instead of the
"mps,switch-frequency" for switch frequency. Fortunately, the switch
frequency support isn't released, so we can modify it now without
any concern.
Signed-off-by: Jisheng Zhang
---
Documentation/devicetre
Fix below warning when CONFIG_OF=n:
drivers/regulator/fan53555.c:439:34: warning: ‘fan53555_dt_ids’ defined but not
used [-Wunused-const-variable=]
439 | static const struct of_device_id fan53555_dt_ids[] = {
| ^~~
Signed-off-by: Jisheng
[] = {
| ^~~~
Signed-off-by: Jisheng Zhang
---
drivers/regulator/sy8106a-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/sy8106a-regulator.c
b/drivers/regulator/sy8106a-regulator.c
index e739e62b..c119f85259a5 100644
--- a/drivers/regulator/sy8106a-regulator.c
-by: Jisheng Zhang
---
drivers/regulator/tps65023-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/tps65023-regulator.c
b/drivers/regulator/tps65023-regulator.c
index 795d459ff3cf..f25806531c7e 100644
--- a/drivers/regulator/tps65023-regulator.c
Fix below warning when CONFIG_OF=n:
drivers/regulator/ltc3676.c:371:34: warning: ‘ltc3676_of_match’ defined but not
used [-Wunused-const-variable=]
371 | static const struct of_device_id ltc3676_of_match[] = {
| ^~~~
Signed-off-by: Jisheng
Fix below warning when CONFIG_OF=n:
drivers/regulator/pwm-regulator.c:393:34: warning: ‘pwm_of_match’ defined but
not used [-Wunused-const-variable=]
393 | static const struct of_device_id pwm_of_match[] = {
| ^~~~
Signed-off-by: Jisheng Zhang
Fix below warning when CONFIG_OF=n:
drivers/regulator/88pg86x.c:87:34: warning: ‘pg86x_dt_ids’ defined but not used
[-Wunused-const-variable=]
87 | static const struct of_device_id pg86x_dt_ids [] = {
| ^~~~
Signed-off-by: Jisheng Zhang
---
drivers
Fix below warning when CONFIG_OF=n:
drivers/regulator/max1586.c:204:34: warning: ‘max1586_of_match’ defined but not
used [-Wunused-const-variable=]
204 | static const struct of_device_id max1586_of_match[] = {
| ^~~~
Signed-off-by: Jisheng
[] = {
| ^~
Signed-off-by: Jisheng Zhang
---
drivers/regulator/qcom-rpmh-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/qcom-rpmh-regulator.c
b/drivers/regulator/qcom-rpmh-regulator.c
index 08dcc614efa7..d488325499a9 100644
--- a/drivers
Fix below warning when CONFIG_OF=n:
drivers/regulator/da9210-regulator.c:128:34: warning: ‘da9210_dt_ids’ defined
but not used [-Wunused-const-variable=]
128 | static const struct of_device_id da9210_dt_ids[] = {
| ^
Signed-off-by: Jisheng
/regulator/fixed.c:44:36: warning: ‘fixed_voltage_data’ defined but not
used [-Wunused-const-variable=]
44 | static const struct fixed_dev_type fixed_voltage_data = {
|^~
Signed-off-by: Jisheng Zhang
---
drivers/regulator/fixed.c | 16
[] = {
| ^~
Signed-off-by: Jisheng Zhang
---
drivers/regulator/stm32-booster.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/stm32-booster.c
b/drivers/regulator/stm32-booster.c
index 03f162ffd144..3136ea8a35d5 100644
--- a/drivers/regulator/stm32-booster.c
+++ b/drivers
-by: Jisheng Zhang
---
drivers/regulator/stm32-pwr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/stm32-pwr.c b/drivers/regulator/stm32-pwr.c
index e0e627b0106e..2a42acb7c24e 100644
--- a/drivers/regulator/stm32-pwr.c
+++ b/drivers/regulator/stm32-pwr.c
@@ -166,7
101 - 200 of 2741 matches
Mail list logo
