[PATCH] ib_core: Add missing device link to class device

2007-04-23 Thread Joachim Fenkes
Add the missing device link from /sys/class/infiniband/* to the actual device. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- sysfs.c |1 + 1 file changed, 1 insertion(+) --- linux-2.6.20/drivers/infiniband/core/sysfs.c.old2007-04-23 15:37:37.0 +0200 +++ linux-2.6.20

[PATCH] eHCA: Add Modify Port verb

2007-04-23 Thread Joachim Fenkes
Add Modify Port verb support to eHCA driver. ib_cm needs this to initialize properly. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- ehca_hca.c | 48 ++-- hcp_if.c | 24 hcp_if.h |4 3 files changed, 74

Re: [PATCH] ib_core: Add missing device link to class device

2007-04-24 Thread Joachim Fenkes
instead of repeating it in all the drivers. The respective lines could move out of the drivers in the future but won't hurt anyone until then. What's your take on this? Cheers, Joachim --- Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer IBM Deutschland Entwicklung GmbH

Re: [PATCH] eHCA: Add Modify Port verb

2007-04-24 Thread Joachim Fenkes
for the hint! Joachim --- Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Dev. 2) Schoenaicher Strasse 220 -- 71032 Boeblingen -- Germany eMail: [EMAIL PROTECTED] -- Phone: +49 7031 16 1239 - To unsubscribe

[PATCH] eHCA: Add Modify Port verb

2007-04-24 Thread Joachim Fenkes
Add Modify Port verb support to eHCA driver. ib_cm needs this to initialize properly. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- This is the shiny new version of this patch with proper locking. Tested and works. ehca_classes.h |1 + ehca_hca.c | 55

Re: [PATCH 1/2] ibmebus: dynamic addiiton/removal of adapters, uevent, root device based on struct device

2007-03-09 Thread Joachim Fenkes
escaped me. Sorry about that. I fixed the error and all warnings and will post a fresh set of patches right after this reply. If you could give the new patch another go and ack it if it works, I would be delighted! =) Thanks for pointing this out! Joachim --- Joachim Fenkes -- eHCA Linux

[PATCH 1/3] ibmebus: whitespace fixes

2007-03-09 Thread Joachim Fenkes
This fixes a lot of whitespace in ibmebus.[ch] Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- This patchset applies on top of a vanilla 2.6.20 kernel. No dependencies on other patches except for part 3/3. This is a repost of my earlier patchset and fixes a stupid compile error. arch

[PATCH 2/3] ibmebus: dynamic addition/removal of adapters, some code cleanup

2007-03-09 Thread Joachim Fenkes
attributes are now generated automagically by device_register() instead of by the ibmebus code, which saves a few compiler warnings about unused return codes. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- This is a repost of my earlier patch, fixing a stupid compile error and some warnings

[PATCH 3/3] ibmebus: uevent support

2007-03-09 Thread Joachim Fenkes
This adds uevent support to ibmebus using the generic of_device_uevent() function. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- I split this change into a separate patch because it depends on another patch against 2.6.20, submitted by Sylvain Munaut: http://patchwork.ozlabs.org/linuxppc

Re: [PATCH 2.6.21-rc1] ibmebus: Support dynamic addition and removal of adapters

2007-02-16 Thread Joachim Fenkes
even if the system booted with no LHEA nodes? Sure. Can we also have an attribute devspec that communicates the open firmware path through sysfs? This is already taken care of by of_device_register(). Cheers, Joachim --- Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer

Re: [PATCH 2.6.21-rc1] ibmebus: Support dynamic addition and removal of adapters

2007-02-16 Thread Joachim Fenkes
contains the location code property. So I think there's nothing preventing me from using your function. Thanks for pointing this out. Regards, Joachim --- Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer extraordinaire IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O

Re: [PATCH 2.6.21-rc1] ibmebus: Use of_device_uevent()

2007-02-17 Thread Joachim Fenkes
the code of of_device_uevent itself. Nice! Patch will follow. Thanks again, Joachim --- Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer extraordinaire IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Development 2) Schoenaicher Strasse 220 -- 71032 Boeblingen

Re: [PATCH 2.6.21-rc1] powerpc: Make of_device_uevent() compatible with ibmebus

2007-02-17 Thread Joachim Fenkes
devices are linked to dt nodes residing directly beneath /, so the mapping would fit. Cheers, Joachim --- Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer extraordinaire IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Development 2) Schoenaicher Strasse 220

Re: [PATCH 2.6.21-rc1] powerpc: Make of_device_uevent() compatible with ibmebus

2007-02-19 Thread Joachim Fenkes
a busless device, we wouldn't have a problem, but I doubt that is possible. Do you have any creative ideas? It's a generic problem with sysfs, I agree it somewhat sucks. With ya. Later, Joachim --- Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer extraordinaire IBM

[PATCH] ibmebus: change probe/remove interface from using loc-code to DT path

2007-03-22 Thread Joachim Fenkes
like this: echo /[EMAIL PROTECTED] /sys/bus/ibmebus/probe Remove the device like this: echo /[EMAIL PROTECTED] /sys/bus/ibmebus/remove Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- This patch applies on top of part 2/3 or 3/3 of my previous ibmebus patches, which are already

Re: [PATCH] ibmebus: change probe/remove interface from using loc-code to DT path

2007-03-22 Thread Joachim Fenkes
On Thursday 22 March 2007 17:00, Joachim Fenkes wrote: Example: Add a device /proc/device-tree/[EMAIL PROTECTED] to ibmebus like this: echo /[EMAIL PROTECTED] /sys/bus/ibmebus/probe Remove the device like this: echo /[EMAIL PROTECTED] /sys/bus/ibmebus/remove Of course, we

[PATCH] eHCA: Make scaling code also work without CPU hotplug

2007-03-22 Thread Joachim Fenkes
eHCA scaling code must not depend on register_cpu_notifier() if CONFIG_HOTPLUG_CPU is not set, so put all related code into #ifdefs. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- ehca_irq.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/infiniband/hw/ehca

[PATCH] ibmebus: newline fix

2007-03-27 Thread Joachim Fenkes
Stupid me forgot a newline in an error message. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- Applies on top of ibmebus: change probe/remove interface from using loc-code to DT path ibmebus.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -Nurp 03b.path/arch/powerpc

Re: [PATCH 2.6.21-rc1] ibmebus: Support dynamic addition and removal of adapters

2007-02-20 Thread Joachim Fenkes
will still be of_devices, of course. Regards, Joachim --- Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Dev. 2) Schoenaicher Strasse 220 -- 71032 Boeblingen -- Germany eMail: [EMAIL PROTECTED] -- Phone: +49

Re: [PATCH 08/12] IB/ehca: Replace get_paca()-paca_index by the more portable smp_processor_id()

2007-09-12 Thread Joachim Fenkes
On Tuesday 11 September 2007 16:51, Nathan Lynch wrote: - get_paca()-paca_index, __FUNCTION__, \ + smp_processor_id(), __FUNCTION__, \ I think I see these macros used in preemptible code (e.g. ehca_probe), where smp_processor_id()

[PATCH 08/12] IB/ehca: Replace get_paca()-paca_index by the more portable raw_smp_processor_id()

2007-09-12 Thread Joachim Fenkes
We can use raw_smp_processor_id() here because the processor ID is only used for debug output and may therefore be preemption-unsafe. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- This is the same patch, but with smp_processor_id() replaced by raw_smp_processor_id(), as kindly pointed out

Re: [PATCH] ehca_irq: Misc cpuinit section annotations and #ifdef cleanups

2007-09-12 Thread Joachim Fenkes
of this module, however, because these are no longer dropped unconditionally now.) Signed-off-by: Satyam Sharma [EMAIL PROTECTED] Looks okay to me. Acked-by: Joachim Fenkes [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: [PATCH] IB/ehca: Make sure user pages are from hugetlb before using MR large pages

2007-09-13 Thread Joachim Fenkes
Roland Dreier [EMAIL PROTECTED] wrote on 13.09.2007 06:33:45: -#define HCA_CAP_MR_PGSIZE_4K 1 -#define HCA_CAP_MR_PGSIZE_64K 2 -#define HCA_CAP_MR_PGSIZE_1M 4 -#define HCA_CAP_MR_PGSIZE_16M 8 +#define HCA_CAP_MR_PGSIZE_4K 0x8000 +#define HCA_CAP_MR_PGSIZE_64K 0x4000

[PATCH 0/3] IB/ehca: MR/MW fixes

2007-09-13 Thread Joachim Fenkes
the hugetlb flag in ehca_reg_user_mr() The patches should apply cleanly, in order, on top of my previous 12-patch set. Please review the changes and apply the patches for 2.6.24 if they are okay. Regards, Joachim -- Joachim Fenkes  --  eHCA Linux Driver Developer and Hardware Tamer IBM Deutschland

[PATCH 1/3] IB/ehca: Fix large page HW cap defines

2007-09-13 Thread Joachim Fenkes
From: Hoang-Nam Nguyen [EMAIL PROTECTED] Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_classes.h |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ehca_classes.h b/drivers/infiniband/hw/ehca

[PATCH 2/3] IB/umem: Add hugetlb flag to struct ib_umem

2007-09-13 Thread Joachim Fenkes
During ib_umem_get(), determine whether all pages from the memory region are hugetlb pages and report this in the hugetlb field. Low-level driver can use this information if they need it. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/core/umem.c | 20

[PATCH 3/3] IB/ehca: Make sure user pages are from hugetlb before using MR large pages

2007-09-13 Thread Joachim Fenkes
...because, on virtualized hardware like System p, we can't be sure that the physical pages behind them are contiguous. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_mrmw.c | 25 +++-- 1 files changed, 15 insertions(+), 10 deletions

Re: [PATCH 02/12] IB/ehca: Add 1 is not longer needed because of firmware interface change

2007-09-14 Thread Joachim Fenkes
Roland Dreier [EMAIL PROTECTED] wrote on 12.09.2007 22:21:54: What happens if someone runs the new driver with older firmware? Or what if someone upgrades the firmware without updating the driver? Thanks for pointing our noses to this. Your comment triggered some further internal discussions

[PATCH] IB/ehca: Serialize HCA-related hCalls on POWER5

2007-12-06 Thread Joachim Fenkes
-related hCalls on POWER5. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- We tested this patch, especially the autodetection, and it works okay. Please review and apply for 2.6.24-rc5 - thanks! drivers/infiniband/hw/ehca/ehca_main.c | 16 drivers/infiniband/hw/ehca

[PATCH] IB/ehca: Fix static rate regression

2007-11-22 Thread Joachim Fenkes
Wrong choice of port number caused modify_qp() to fail -- fixed. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- Please apply this for 2.6.24-rc4 as it fixes a regression introduced in rc3. Thanks! drivers/infiniband/hw/ehca/ehca_qp.c |4 ++-- 1 files changed, 2 insertions(+), 2

[PATCH] IB/ehca: Fix static rate if path faster than link

2007-11-28 Thread Joachim Fenkes
The formula would yield -1 for this, which is wrong in a bad way (max throttling). Clamp to 0, which is the correct value. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- This fixes another regression introduced in rc3. Please review and apply for 2.6.24-rc4. Thanks! drivers/infiniband/hw

Re: [PATCH] IB/ehca: Serialize HCA-related hCalls on POWER5

2007-12-07 Thread Joachim Fenkes
Roland Dreier [EMAIL PROTECTED] wrote on 06.12.2007 19:27:09: + ehca_lock_hcalls = !(cur_cpu_spec-cpu_user_features + PPC_FEATURE_ARCH_2_05); We already talked about this yesterday, but I still feel that checking the instruction

[PATCH] IB/ehca: Return correct #SGEs for SRQ

2007-12-10 Thread Joachim Fenkes
Firmware would round up the number of SGEs to four, because the WQE structure holds four SGEs. For SRQ, only three are supported, so return a fixed value instead. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- The patch will apply cleanly on top of Roland's git. Please review and apply

Re: [PATCH] IB/ehca: Serialize HCA-related hCalls on POWER5

2007-12-10 Thread Joachim Fenkes
On Monday 10 December 2007 00:22, Roland Dreier wrote: Fair enough... according to Documentation/infiniband/core_locking.txt, the only driver methods that cannot sleep are: [...] map_phys_fmr In fact, we do use hCalls there. Our hardware doesn't actually support FMRs, so we

Re: [PATCH] IB/ehca: Serialize HCA-related hCalls on POWER5

2007-12-10 Thread Joachim Fenkes
Hi, guys, We're taking this to the firmware architects at the moment, but they're not very fond of the idea of reporting the absence of bugs through capability flags, as this could quickly lead to the exhaustion of flag bits. We'll let the discussion stew for a bit, but if we don't get

[PATCH] IB/ehca: Serialize HCA-related hCalls if necessary

2007-12-10 Thread Joachim Fenkes
Several pSeries firmware versions share a rare locking issue in the HCA-related hCalls. Check for a feature flag that indicates the issue being fixed and serialize all HCA hCalls if not. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- This is the revised version of my previous patch, which

Re: [PATCH] IB/ehca: Serialize HCA-related hCalls on POWER5

2007-12-11 Thread Joachim Fenkes
Roland Dreier [EMAIL PROTECTED] wrote on 10.12.2007 22:47:37: It's a big problem. If you cannot implement FMRs in such a way that you can handling having map_phys_fmr being called in a context that can't sleep, then I think the only option is to remove your FMR support. That's kind of what

[PATCH] IB/ehca: Fix lock flag location, bump version number

2007-12-13 Thread Joachim Fenkes
Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- This addresses a comment of Roland and bumps the version number. If it's not too late, please apply for 2.6.24. Thanks! drivers/infiniband/hw/ehca/ehca_classes.h |1 + drivers/infiniband/hw/ehca/ehca_main.c|2 +- drivers/infiniband

Re: [ofa-general] Re: [ewg] Re: [PATCH] IB/ehca: Serialize HCA-related hCalls on POWER5

2007-12-13 Thread Joachim Fenkes
[EMAIL PROTECTED] wrote on 13.12.2007 20:22:49: On Dec 13, 2007 12:30 AM, Or Gerlitz [EMAIL PROTECTED] wrote: The current implementation of the open iscsi initiator makes sure to issue commands in thread (sleepable) context, see iscsi_xmitworker and references to it in

RE: [ofa-general] Re: [ewg] Re: [PATCH] IB/ehca: Serialize HCA-related hCalls on POWER5

2007-12-13 Thread Joachim Fenkes
Caitlin Bestler [EMAIL PROTECTED] wrote on 13.12.2007 22:08:34: To clarify, an FMR Work Request is simply posted to the SendQ like any other Work Request (of course the QP has to be privileged, or it will complete in error). An SQ Post should never block. This would require hardware support,

[PATCH 0/5] PowerPC: ibmebus refactoring and fixes

2007-09-25 Thread Joachim Fenkes
(-) -- Joachim Fenkes  --  eHCA Linux Driver Developer and Hardware Tamer IBM Deutschland Entwicklung GmbH  --  Dept. 3627 (I/O Firmware Dev. 2) Schoenaicher Strasse 220  --  71032 Boeblingen  --  Germany eMail: [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel

[PATCH 1/5] PowerPC: Move of_device allocation into of_device.[ch]

2007-09-25 Thread Joachim Fenkes
Extract generic of_device allocation code from of_platform_device_create() and move it into of_device.[ch], called of_device_alloc(). Also, there's now of_device_free() which puts the device node. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- include/asm-powerpc/of_device.h |4

[PATCH 3/5] ibmebus: Add device creation and bus probing based on of_device

2007-09-25 Thread Joachim Fenkes
, the devtree is matched against its matchlist. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- arch/powerpc/kernel/ibmebus.c | 97 ++--- 1 files changed, 81 insertions(+), 16 deletions(-) diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel

[PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

2007-09-25 Thread Joachim Fenkes
Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_classes.h |2 +- drivers/net/ehea/ehea.h |2 +- include/asm-powerpc/ibmebus.h | 38 +++ arch/powerpc/kernel/ibmebus.c | 28 ++- drivers

[PATCH 5/5] ibmebus: More speaking error return code in ibmebus_store_probe()

2007-09-25 Thread Joachim Fenkes
Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- arch/powerpc/kernel/ibmebus.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/ibmebus.c index 379472f..8c08a98 100644 --- a/arch/powerpc/kernel/ibmebus.c +++ b/arch

[PATCH 2/5] ibmebus: Remove bus match/probe/remove functions

2007-09-25 Thread Joachim Fenkes
ibmebus_{,un}register_driver() are replaced by dummy functions because ibmebus is temporarily unusable in this transitional state. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- arch/powerpc/kernel/ibmebus.c | 199 ++--- 1 files changed, 6 insertions

Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

2007-09-26 Thread Joachim Fenkes
Arnd Bergmann [EMAIL PROTECTED] wrote on 25.09.2007 16:42:40: This is missing a description, The description is ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers -- I thought that should be enough since the patch is rather straightforward. I can add a more

Re: [PATCH 3/5] ibmebus: Add device creation and bus probing based on of_device

2007-09-26 Thread Joachim Fenkes
+/* These devices will automatically be added to the bus during init */ +static struct of_device_id builtin_matches[] = { + { .name = lhca }, + { .compatible = IBM,lhca }, + { .name = lhea }, + { .compatible = IBM,lhea }, + {}, +}; + Hmm, do you have devices that

Re: [PATCH 2/5] ibmebus: Remove bus match/probe/remove functions

2007-09-26 Thread Joachim Fenkes
Arnd Bergmann [EMAIL PROTECTED] wrote on 25.09.2007 16:29:51: The description makes it sound like a git-bisect would get broken by this patch, which should never happen. If the patch indeed ends up with a broken kernel, it would be better to merge it with the later patch that fixes the code

Re: [PATCH 1/5] PowerPC: Move of_device allocation into of_device.[ch]

2007-09-26 Thread Joachim Fenkes
Arnd Bergmann [EMAIL PROTECTED] wrote on 25.09.2007 16:27:57: The patch looks good to me, especially since you did exactly what I suggested ;-) Yes, our discussions were very productive. Thanks and sorry I forgot to mention your input. Maybe the description should have another sentence in

[PATCH 0/5] [REPOST] PowerPC: ibmebus refactoring and fixes

2007-09-26 Thread Joachim Fenkes
|5 + 11 files changed, 228 insertions(+), 350 deletions(-) -- Joachim Fenkes  --  eHCA Linux Driver Developer and Hardware Tamer IBM Deutschland Entwicklung GmbH  --  Dept. 3627 (I/O Firmware Dev. 2) Schoenaicher Strasse 220  --  71032 Boeblingen  --  Germany eMail: [EMAIL PROTECTED

[PATCH 1/5] PowerPC: Move of_device allocation into of_device.[ch]

2007-09-26 Thread Joachim Fenkes
of reinventing the wheel. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- include/asm-powerpc/of_device.h |4 ++ include/linux/of_device.h |5 ++ arch/powerpc/kernel/of_device.c | 80 + arch/powerpc/kernel/of_platform.c | 70

[PATCH 2/5] ibmebus: Remove bus match/probe/remove functions

2007-09-26 Thread Joachim Fenkes
will be happy. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- arch/powerpc/kernel/ibmebus.c | 199 ++--- 1 files changed, 6 insertions(+), 193 deletions(-) diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/ibmebus.c index d6a38cd..cc80f84

[PATCH 3/5] ibmebus: Add device creation and bus probing based on of_device

2007-09-26 Thread Joachim Fenkes
, the devtree is matched against its matchlist. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- arch/powerpc/kernel/ibmebus.c | 100 +--- 1 files changed, 82 insertions(+), 18 deletions(-) diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel

[PATCH 5/5] ibmebus: More speaking error return code in ibmebus_store_probe()

2007-09-26 Thread Joachim Fenkes
Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- arch/powerpc/kernel/ibmebus.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/ibmebus.c index c1e2963..0bd186c 100644 --- a/arch/powerpc/kernel/ibmebus.c +++ b/arch

[PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

2007-09-26 Thread Joachim Fenkes
Replace struct ibmebus_dev and struct ibmebus_driver with struct of_device and struct of_platform_driver, respectively. Match the external ibmebus interface and drivers using it. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_classes.h |2 +- drivers/net

[PATCH 0/2] IB/ehca: Fixes for rc5

2007-08-31 Thread Joachim Fenkes
the changes and apply the patches for 2.6.23-rc5 if they are okay. Regards, Joachim -- Joachim Fenkes  --  eHCA Linux Driver Developer and Hardware Tamer IBM Deutschland Entwicklung GmbH  --  Dept. 3627 (I/O Firmware Dev. 2) Schoenaicher Strasse 220  --  71032 Boeblingen  --  Germany eMail

[PATCH 1/2] IB/ehca: fix Small QP regressions

2007-08-31 Thread Joachim Fenkes
From: Stefan Roscher [EMAIL PROTECTED] The new Small QP code had a few bugs that would also trigger for non-Small QPs. Fix them. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_qp.c | 10 ++ drivers/infiniband/hw/ehca/ipz_pt_fn.c |2 +- 2

[PATCH 2/2] IB/ehca: SRQ fixes to enable IPoIB CM

2007-08-31 Thread Joachim Fenkes
a) Report max_srq 0 if SRQ is supported b) Report last wqe reached event when base QP dies Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_hca.c | 10 +-- drivers/infiniband/hw/ehca/ehca_irq.c | 48 +--- 2 files changed, 38

Re: [PATCH 2.6.23] ibmebus: Prevent bus_id collisions

2007-08-31 Thread Joachim Fenkes
Hi, Arnd, The whole logic of dynamically adding and removing device is rather bogus, and it prevents autoloading of device drivers. of_platform_make_bus_id is the function that is responsible for creating unique names over there. The plaintiff makes a valid point. How about a staging

Re: [PATCH 2.6.23] ibmebus: Prevent bus_id collisions

2007-08-31 Thread Joachim Fenkes
The plaintiff makes a valid point. How about a staging approach: We put the patch as it is now into 2.6.23 so the problem is fixed, and I'll post a nice version with autoloading support and a generic of_make_bus_id function for 2.6.24. Agree? Ok, sounds fair. Can you make sure

[PATCH 00/12] IB/ehca: New features and fixes for 2.6.24

2007-09-11 Thread Joachim Fenkes
, against Roland's git. Please review the changes and apply the patches for 2.6.24 if they are okay. Regards, Joachim -- Joachim Fenkes  --  eHCA Linux Driver Developer and Hardware Tamer IBM Deutschland Entwicklung GmbH  --  Dept. 3627 (I/O Firmware Dev. 2) Schoenaicher Strasse 220  --  71032

[PATCH 01/12] IB/ehca: Small QP userspace support

2007-09-11 Thread Joachim Fenkes
From: Stefan Roscher [EMAIL PROTECTED] Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_qp.c |7 +++ drivers/infiniband/hw/ehca/ipz_pt_fn.c |1 + 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ehca_qp.c

[PATCH 02/12] IB/ehca: Add 1 is not longer needed because of firmware interface change

2007-09-11 Thread Joachim Fenkes
From: Stefan Roscher [EMAIL PROTECTED] Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/hcp_if.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/ehca/hcp_if.c b/drivers/infiniband/hw/ehca/hcp_if.c index 24f4541

[PATCH 03/12] IB/ehca: Support more than 4k QPs for userspace and kernelspace

2007-09-11 Thread Joachim Fenkes
From: Stefan Roscher [EMAIL PROTECTED] Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_cq.c |7 ++- drivers/infiniband/hw/ehca/ehca_main.c |2 +- drivers/infiniband/hw/ehca/ehca_qp.c |9 +++-- drivers/infiniband/hw/ehca

[PATCH 04/12] IB/ehca: Use remap_4k_pfn() to map firmware contexts to user space

2007-09-11 Thread Joachim Fenkes
address. For details about remap_4k_pfn(), see commit 721151d0 or http://patchwork.ozlabs.org/linuxppc/patch?id=10281 Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_classes.h |4 +++- drivers/infiniband/hw/ehca/ehca_cq.c |2 ++ drivers/infiniband

[PATCH 05/12] IB/ehca: Refactor hvcall tracing

2007-09-11 Thread Joachim Fenkes
Change hvcall trace output towards better readability: reg numbers instead of argument numbers, return code as signed decimal instead of unsigned hex. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/hcp_if.c | 57 ++ 1 files

[PATCH 06/12] IB/ehca: Print return codes as signed decimal integers

2007-09-11 Thread Joachim Fenkes
...because -12 is easier to read than FFF4. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_cq.c | 14 +++--- drivers/infiniband/hw/ehca/ehca_hca.c|2 +- drivers/infiniband/hw/ehca/ehca_main.c | 24 +- drivers/infiniband/hw/ehca

[PATCH 07/12] IB/ehca: ehca_gen_warn() should always print

2007-09-11 Thread Joachim Fenkes
Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_tools.h |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ehca_tools.h b/drivers/infiniband/hw/ehca/ehca_tools.h index 57c77a7..f9b264b 100644

[PATCH 09/12] IB/ehca: Add check for max #SGE to create_qp()

2007-09-11 Thread Joachim Fenkes
Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_qp.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ehca_qp.c b/drivers/infiniband/hw/ehca/ehca_qp.c index d2ab84a..7154f62 100644 --- a/drivers

[PATCH 08/12] IB/ehca: Replace get_paca()-paca_index by the more portable smp_processor_id()

2007-09-11 Thread Joachim Fenkes
Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_tools.h | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ehca_tools.h b/drivers/infiniband/hw/ehca/ehca_tools.h index f9b264b..863f972 100644

[PATCH 10/12] IB/ehca: Path migration support

2007-09-11 Thread Joachim Fenkes
Rectify some modify_qp() issues related to path migration. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_irq.c |4 +- drivers/infiniband/hw/ehca/ehca_qp.c | 90 - 2 files changed, 68 insertions(+), 26 deletions(-) diff

[PATCH 11/12] IB/ehca: Serialize MR alloc and MR free hvCalls

2007-09-11 Thread Joachim Fenkes
Some firmware levels exhibit a race condition between H_ALLOC_RESOURCE(MR) and H_FREE_RESOURCE(MR). Work around this problem by locking these hvCalls against each other. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/hcp_if.c | 28 +--- 1

[PATCH 12/12] IB/ehca: Bump version number and change its format

2007-09-11 Thread Joachim Fenkes
Nobody needed the SVNEHCA_ prefix anyway. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_main.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ehca_main.c b/drivers/infiniband/hw/ehca/ehca_main.c

[PATCH] IB/ehca: Make sure user pages are from hugetlb before using MR large pages

2007-09-12 Thread Joachim Fenkes
From: Hoang-Nam Nguyen [EMAIL PROTECTED] ...because, on virtualized hardware like System p, we can't be sure that the physical pages behind them are contiguous. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- Another patch for 2.6.24 that will apply cleanly on top of my previous patchset

Re: [PATCH 04/30] powerpc: Don't cast kmalloc return value in ibmebus.c

2007-08-23 Thread Joachim Fenkes
kmalloc() returns a void pointer so there is absolutely no need to cast it in ibmebus_chomp(). Signed-off-by: Jesper Juhl [EMAIL PROTECTED] Acked-By: Joachim Fenkes [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

[PATCH 2.6.23] ibmebus: Prevent bus_id collisions

2007-08-29 Thread Joachim Fenkes
Previously, ibmebus derived a device's bus_id from its location code. The location code is not guaranteed to be unique, so we might get bus_id collisions if two devices share the same location code. The OFDT full_name, however, is unique, so we use that instead. Signed-off-by: Joachim Fenkes

Re: [PATCH 2.6.23] ibmebus: Prevent bus_id collisions

2007-08-30 Thread Joachim Fenkes
Nathan Lynch [EMAIL PROTECTED] wrote on 29.08.2007 20:12:32: Previously, ibmebus derived a device's bus_id from its location code. The location code is not guaranteed to be unique, so we might get bus_id collisions if two devices share the same location code. The OFDT full_name,

Re: [PATCH 2.6.23] ibmebus: Prevent bus_id collisions

2007-08-31 Thread Joachim Fenkes
[EMAIL PROTECTED] (Linas Vepstas) wrote on 30.08.2007 23:28:16: On Thu, Aug 30, 2007 at 04:00:56PM +0200, Joachim Fenkes wrote: Plus, I rather like using the full_name since it also contains a descriptive name as opposed to being just nondescript numbers, helping the layman (ie user

[PATCH] IB/ehca: Properly report max #SRQs in query_device()

2007-08-09 Thread Joachim Fenkes
Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- This patch should apply cleanly on top of Stefan's recent patchset. Please review and apply for 2.6.23. Thanks. drivers/infiniband/hw/ehca/ehca_hca.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers

Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

2007-10-16 Thread Joachim Fenkes
and drivers using it. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] This is somewhat difficult as this patch touches files that are the responsibility of three different maintainers. �Is it possible to split the patch into three, one for each maintainer (possibly

[PATCH 0/5] IB/ehca: SRQ and MR/MW fixes

2007-10-16 Thread Joachim Fenkes
hca_cap_mr_pgsize and fixes a problem with ib_srp [5/5] enables large page MRs by default I built the patches on top of Roland's for-2.6.24 git branch. Please review and queue them for 2.6.24-rc1 if you're okay with them. Thanks! Cheers, Joachim -- Joachim Fenkes  --  eHCA Linux Driver Developer

[PATCH 1/5] IB/ehca: Supply QP token for SRQ base QPs

2007-10-16 Thread Joachim Fenkes
Because hardware reports the SRQ token in RWQEs of SRQ base QPs, supply the base QP token as SRQ token, so we can properly find the SRQ base QP. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_qp.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions

[PATCH 2/5] IB/ehca: Fix masking error in {,re}reg_phys_mr()

2007-10-16 Thread Joachim Fenkes
Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_mrmw.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ehca_mrmw.c b/drivers/infiniband/hw/ehca/ehca_mrmw.c index da88738..16c9efd 100644 --- a/drivers

[PATCH 3/5] IB/ehca: Fix ehca_encode_hwpage_size() and alloc_fmr()

2007-10-16 Thread Joachim Fenkes
Simplify ehca_encode_hwpage_size(), fixing an infinite loop for pgsize == 0 in the process. Fix the bug in alloc_fmr() that triggered the loop. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_mrmw.c | 15 --- 1 files changed, 4 insertions(+), 11

[PATCH 4/5] IB/ehca: Change meaning of hca_cap_mr_pgsize

2007-10-16 Thread Joachim Fenkes
ehca_shca.hca_cap_mr_pgsize now contains all supported page sizes ORed together. This makes some checks easier to code and understand, plus we can return this value verbatim in query_hca(), fixing a problem with SRP (reported by Anton Blanchard -- thanks!). Signed-off-by: Joachim Fenkes [EMAIL

[PATCH 5/5] IB/ehca: Enable large page MRs by default

2007-10-16 Thread Joachim Fenkes
Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ehca_main.c b/drivers/infiniband/hw/ehca/ehca_main.c index d477dc3..2f51c13 100644 --- a/drivers

Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

2007-10-17 Thread Joachim Fenkes
On Tuesday 16 October 2007 17:27, Stephen Rothwell wrote: One small change - I intend to remove the name and owner fields from struct of_platform_driver, so you should not bother initialising the name field and just initialise the name field of the embedded struct device_driver instead.

[PATCH 3/4] IB/ehca: Add port connection autodetect mode

2008-01-17 Thread Joachim Fenkes
From: Hoang-Nam Nguyen [EMAIL PROTECTED] This patch enhances ehca with a capability to autodetect the ports being connected physically. In order to utilize that function the module option nr_ports must be set to -1 (default is 2 - two ports). This feature is experimental and will made the default

[PATCH 2/4] IB/ehca: Define array to store SMI/GSI QPs

2008-01-17 Thread Joachim Fenkes
From: Hoang-Nam Nguyen hnguyen at de.ibm.com Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_classes.h |2 +- drivers/infiniband/hw/ehca/ehca_main.c|6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 0/4] IB/ehca: fixes, port connectivity autodetection, problem workaround

2008-01-17 Thread Joachim Fenkes
workaround The patches will apply, in order, on top of Roland's for-2.6.25 branch. Please review them and apply for 2.6.25 if you think they're okay. Thanks and regards, Joachim -- Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer IBM Deutschland Entwicklung GmbH -- Dept. 3627

[PATCH 1/4] IB/ehca: Remove CQ-QP-link before destroying QP in error path of create_qp()

2008-01-17 Thread Joachim Fenkes
From: Hoang-Nam Nguyen hnguyen at de.ibm.com Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_qp.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ehca_qp.c b/drivers/infiniband/hw/ehca/ehca_qp.c index

[PATCH 4/4] IB/ehca: Prevent RDMA-related connection failures

2008-01-17 Thread Joachim Fenkes
an empty (size 0) RDMA Read into the message stream every now and then if the consumer doesn't post them frequently enough. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_classes.h |5 ++ drivers/infiniband/hw/ehca/ehca_qp.c | 14 +++- drivers/infiniband

[PATCH] IB/ehca: Prevent sending UD packets to QP0

2008-01-24 Thread Joachim Fenkes
-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_reqs.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ehca_reqs.c b/drivers/infiniband/hw/ehca/ehca_reqs.c index 3aacc8c..2ce8cff 100644 --- a/drivers/infiniband/hw/ehca

[PATCH 2/2] IB/ehca: Add PMA support

2008-01-25 Thread Joachim Fenkes
From: Hoang-Nam Nguyen [EMAIL PROTECTED] This patch enables ehca to redirect any PMA queries to the actual PMA QP. Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] Reviewed-by: Joachim Fenkes [EMAIL PROTECTED] Reviewed-by: Christoph Raisch [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca

[PATCH 1/2] IB/ehca: Update sma_attr also in case of disruptive config change

2008-01-25 Thread Joachim Fenkes
Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_irq.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ehca_irq.c b/drivers/infiniband/hw/ehca/ehca_irq.c index 863b34f..b5ca94c 100644 --- a/drivers/infiniband

[PATCH 0/2] IB/ehca: PMA support and a minor fix

2008-01-25 Thread Joachim Fenkes
and apply for 2.6.25 if you think they're okay. Thanks and regards, Joachim -- Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Dev. 2) Schoenaicher Strasse 220 -- 71032 Boeblingen -- Germany eMail: [EMAIL

[PATCH 2/2] IB/ehca: Fix static rate calculation

2007-11-02 Thread Joachim Fenkes
The IPD formula was a little off and assumed a fixed physical link rate; fix the formula and query the actual physical link rate, now that we can get it. Also, refactor the calculation into a common function ehca_calc_ipd() and use that instead of duplicating code. Signed-off-by: Joachim Fenkes

[PATCH 0/2] IB/ehca: Return physical link information, fix static rate calculation

2007-11-02 Thread Joachim Fenkes
supported [2/2] fixes static rate calculation based on that info The patches will apply, in order, on top of Roland's for-2.6.24 branch. Please review them and apply for 2.6.24-rc2 if you think they're okay. Thanks and regards, Joachim -- Joachim Fenkes -- eHCA Linux Driver Developer and Hardware

[PATCH 1/2] IB/ehca: Return physical link information in query_port()

2007-11-02 Thread Joachim Fenkes
Newer firmware versions return physical port information to the partition, so hand that information to the consumer if it's present. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_hca.c | 20 ++-- drivers/infiniband/hw/ehca/hipz_hw.h |6

  1   2   3   >