Re: [PATCH 5/9] sched: prctl() core-scheduling interface

2021-04-17 Thread Joel Fernandes
On Wed, Apr 07, 2021 at 07:00:33PM +0200, Peter Zijlstra wrote: > On Thu, Apr 01, 2021 at 03:10:17PM +0200, Peter Zijlstra wrote: > > > Current hard-coded policies are: > > > > - a user can clear the cookie of any process they can set a cookie for. > >Lack of a cookie *might* be a security

Re: [PATCH 0/9] sched: Core scheduling interfaces

2021-04-17 Thread Joel Fernandes
On Tue, Apr 06, 2021 at 10:16:12AM -0400, Tejun Heo wrote: > Hello, > > On Mon, Apr 05, 2021 at 02:46:09PM -0400, Joel Fernandes wrote: > > Yeah, its at http://lore.kernel.org/r/20200822030155.ga414...@google.com > > as mentioned above, let me know if you need any more deta

Re: [PATCH 0/9] sched: Core scheduling interfaces

2021-04-05 Thread Joel Fernandes
Hi TJ, Peter, On Sun, Apr 4, 2021 at 7:39 PM Tejun Heo wrote: > > cc'ing Michal and Christian who've been spending some time on cgroup > interface issues recently and Li Zefan for cpuset. > > On Thu, Apr 01, 2021 at 03:10:12PM +0200, Peter Zijlstra wrote: > > The cgroup interface now uses a

[PATCH resend 7/8] Documentation: Add core scheduling documentation

2021-03-24 Thread Joel Fernandes (Google)
Signed-off-by: Joel Fernandes (Google) --- .../admin-guide/hw-vuln/core-scheduling.rst | 460 ++ Documentation/admin-guide/hw-vuln/index.rst | 1 + 2 files changed, 461 insertions(+) create mode 100644 Documentation/admin-guide/hw-vuln/core-scheduling.rst diff --git

[PATCH resend 3/8] sched: prctl() cookie manipulation for core scheduling

2021-03-24 Thread Joel Fernandes (Google)
From: chris hyser This patch provides support for setting, clearing and copying core scheduling 'task cookies' between threads (PID), processes (TGID), and process groups (PGID). The value of core scheduling isn't that tasks don't share a core, 'nosmt' can do that. The value lies in exploiting

[PATCH resend 6/8] kselftest: Add tests for core-sched interface

2021-03-24 Thread Joel Fernandes (Google)
Add a kselftest test to ensure that the core-sched interface is working correctly. Co-developed-by: Chris Hyser Signed-off-by: Chris Hyser Co-developed-by: Josh Don Signed-off-by: Josh Don Tested-by: Julien Desfossez Signed-off-by: Joel Fernandes (Google) Signed-off-by: chris hyser

[PATCH resend 8/8] sched: Debug bits...

2021-03-24 Thread Joel Fernandes (Google)
Tested-by: Julien Desfossez Not-Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/core.c | 40 +++- kernel/sched/fair.c | 12 2 files changed, 51 insertions(+), 1 deletion(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index

[PATCH resend 5/8] sched: cgroup cookie API for core scheduling

2021-03-24 Thread Joel Fernandes (Google)
From: Josh Don This adds the API to set/get the cookie for a given cgroup. This interface lives at cgroup/cpu.core_tag. The cgroup interface can be used to toggle a unique cookie value for all descendent tasks, preventing these tasks from sharing with any others. See

[PATCH resend 1/8] sched: migration changes for core scheduling

2021-03-24 Thread Joel Fernandes (Google)
the idlest CPU whose core cookie matches with task's cookie Signed-off-by: Aubrey Li Signed-off-by: Tim Chen Signed-off-by: Vineeth Remanan Pillai Signed-off-by: Joel Fernandes (Google) --- kernel/sched/fair.c | 29 ++ kernel/sched/sched.h | 73

[PATCH resend 2/8] sched: core scheduling tagging infrastructure

2021-03-24 Thread Joel Fernandes (Google)
. Core scheduler has extra overhead. Enable it only for machines with more than one SMT hardware thread. Co-developed-by: Chris Hyser Signed-off-by: Chris Hyser Co-developed-by: Joel Fernandes (Google) Signed-off-by: Joel Fernandes (Google) Tested-by: Julien Desfossez Signed-off-by: Julien

[PATCH resend 4/8] kselftest: Add test for core sched prctl interface

2021-03-24 Thread Joel Fernandes (Google)
From: chris hyser Provides a selftest and examples of using the interface. Signed-off-by: Chris Hyser Signed-off-by: Josh Don --- tools/testing/selftests/sched/.gitignore | 1 + tools/testing/selftests/sched/Makefile| 14 + tools/testing/selftests/sched/config | 1

[PATCH resend 0/8] Core sched remaining patches rebased

2021-03-24 Thread Joel Fernandes (Google)
(1): sched: migration changes for core scheduling Joel Fernandes (Google) (3): kselftest: Add tests for core-sched interface Documentation: Add core scheduling documentation sched: Debug bits... Josh Don (2): sched: core scheduling tagging infrastructure sched: cgroup cookie API for core

Re: [PATCH 0/6] Core scheduling remaining patches

2021-03-22 Thread Joel Fernandes
On Sat, Mar 20, 2021 at 04:40:20PM +0100, Peter Zijlstra wrote: > On Fri, Mar 19, 2021 at 04:32:47PM -0400, Joel Fernandes (Google) wrote: > > Enclosed is interface related core scheduling patches and one for migration. > > The main core scheduling patches were already pul

[PATCH 1/6] sched: migration changes for core scheduling

2021-03-19 Thread Joel Fernandes (Google)
-by: Tim Chen Signed-off-by: Vineeth Remanan Pillai Signed-off-by: Joel Fernandes (Google) --- kernel/sched/fair.c | 33 +--- kernel/sched/sched.h | 72 2 files changed, 101 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b

[PATCH 2/6] sched: tagging interface for core scheduling

2021-03-19 Thread Joel Fernandes (Google)
with more than one SMT hardware thread. Co-developed-by: Chris Hyser Signed-off-by: Chris Hyser Co-developed-by: Joel Fernandes (Google) Signed-off-by: Joel Fernandes (Google) Tested-by: Julien Desfossez Signed-off-by: Julien Desfossez Signed-off-by: Tim Chen Signed-off-by: Peter Zijlstra (Intel

[PATCH 3/6] sched: prctl() cookie manipulation for core scheduling.

2021-03-19 Thread Joel Fernandes (Google)
From: chris hyser This patch provides support for setting, clearing and copying core scheduling 'task cookies' between threads (PID), processes (TGID), and process groups (PGID). The value of core scheduling isn't that tasks don't share a core, 'nosmt' can do that. The value lies in exploiting

[PATCH 4/6] kselftest: Add tests for core-sched interface

2021-03-19 Thread Joel Fernandes (Google)
Add a kselftest test to ensure that the core-sched interface is working correctly. Co-developed-by: Chris Hyser Signed-off-by: Chris Hyser Co-developed-by: Josh Don Signed-off-by: Josh Don Tested-by: Julien Desfossez Signed-off-by: Joel Fernandes (Google) --- tools/testing/selftests/sched

[PATCH 5/6] Documentation: Add core scheduling documentation

2021-03-19 Thread Joel Fernandes (Google)
Signed-off-by: Joel Fernandes (Google) --- .../admin-guide/hw-vuln/core-scheduling.rst | 460 ++ Documentation/admin-guide/hw-vuln/index.rst | 1 + 2 files changed, 461 insertions(+) create mode 100644 Documentation/admin-guide/hw-vuln/core-scheduling.rst diff --git

[PATCH 6/6] sched: Debug bits...

2021-03-19 Thread Joel Fernandes (Google)
Tested-by: Julien Desfossez Not-Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/core.c | 40 +++- kernel/sched/fair.c | 9 + 2 files changed, 48 insertions(+), 1 deletion(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index

[PATCH 0/6] Core scheduling remaining patches

2021-03-19 Thread Joel Fernandes (Google)
From: Joel Fernandes Core-Scheduling === Enclosed is interface related core scheduling patches and one for migration. The main core scheduling patches were already pulled in by Peter with these bits left. Main changes are the simplification of the core cookie scheme, new prctl code

[tip: core/rcu] rcu/tree: Make rcu_do_batch count how many callbacks were executed

2021-02-15 Thread tip-bot2 for Joel Fernandes (Google)
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 6bc335828056f3b301a3deadda782de4e8f0db08 Gitweb: https://git.kernel.org/tip/6bc335828056f3b301a3deadda782de4e8f0db08 Author:Joel Fernandes (Google) AuthorDate:Tue, 03 Nov 2020 09:25:57 -05:00

[tip: core/rcu] rcu/segcblist: Add additional comments to explain smp_mb()

2021-02-12 Thread tip-bot2 for Joel Fernandes (Google)
The following commit has been merged into the core/rcu branch of tip: Commit-ID: c2e13112e830c06825339cbadf0b3bc2bdb9a716 Gitweb: https://git.kernel.org/tip/c2e13112e830c06825339cbadf0b3bc2bdb9a716 Author:Joel Fernandes (Google) AuthorDate:Tue, 03 Nov 2020 09:26:03 -05:00

[tip: core/rcu] rcu/segcblist: Add counters to segcblist datastructure

2021-02-12 Thread tip-bot2 for Joel Fernandes (Google)
The following commit has been merged into the core/rcu branch of tip: Commit-ID: ae5c2341ed3987bd434ed495bd4f3d8b2bc3e623 Gitweb: https://git.kernel.org/tip/ae5c2341ed3987bd434ed495bd4f3d8b2bc3e623 Author:Joel Fernandes (Google) AuthorDate:Wed, 23 Sep 2020 11:22:09 -04:00

[tip: core/rcu] rcu/segcblist: Add debug checks for segment lengths

2021-02-12 Thread tip-bot2 for Joel Fernandes (Google)
The following commit has been merged into the core/rcu branch of tip: Commit-ID: b4e6039e8af8c20dfbbdfcaebfcbd7c9d9ffe713 Gitweb: https://git.kernel.org/tip/b4e6039e8af8c20dfbbdfcaebfcbd7c9d9ffe713 Author:Joel Fernandes (Google) AuthorDate:Wed, 18 Nov 2020 11:15:41 -05:00

[tip: core/rcu] rcu/tree: segcblist: Remove redundant smp_mb()s

2021-02-12 Thread tip-bot2 for Joel Fernandes (Google)
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 68804cf1c905ce227e4e1d0bc252c216811c59fd Gitweb: https://git.kernel.org/tip/68804cf1c905ce227e4e1d0bc252c216811c59fd Author:Joel Fernandes (Google) AuthorDate:Wed, 14 Oct 2020 18:21:53 -04:00

[tip: core/rcu] rcu/trace: Add tracing for how segcb list changes

2021-02-12 Thread tip-bot2 for Joel Fernandes (Google)
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 3afe7fa535491ecd0382c3968dc2349602bff8a2 Gitweb: https://git.kernel.org/tip/3afe7fa535491ecd0382c3968dc2349602bff8a2 Author:Joel Fernandes (Google) AuthorDate:Sat, 14 Nov 2020 14:31:32 -05:00

Re: [PATCH v10 2/5] sched: CGroup tagging interface for core scheduling

2021-02-05 Thread Joel Fernandes
On Thu, Feb 04, 2021 at 03:52:53PM +0100, Peter Zijlstra wrote: > On Fri, Jan 22, 2021 at 08:17:01PM -0500, Joel Fernandes (Google) wrote: > > +static void sched_core_update_cookie(struct task_struct *p, unsigned long > > cookie, > > +enum s

Re: [PATCH v10 2/5] sched: CGroup tagging interface for core scheduling

2021-02-05 Thread Joel Fernandes
Hi Peter, On Thu, Feb 04, 2021 at 02:59:58PM +0100, Peter Zijlstra wrote: > On Wed, Feb 03, 2021 at 05:51:15PM +0100, Peter Zijlstra wrote: > > > > I'm slowly starting to go through this... > > > > On Fri, Jan 22, 2021 at 08:17:01PM -0500, Joel Fernandes (Google

Re: [PATCH] sched/fair: Rate limit calls to update_blocked_averages() for NOHZ

2021-02-03 Thread Joel Fernandes
ooks correct to me, I will further review it and await further reviews from others as well, and then backport the patch to our kernels. Thanks Vince and everyone! Tested-by: Joel Fernandes (Google) thanks, - Joel > --- > kernel/sched/fair.c | 32 +++- > 1

Re: [PATCH] sched/fair: Rate limit calls to update_blocked_averages() for NOHZ

2021-02-01 Thread Joel Fernandes
On Fri, Jan 29, 2021 at 5:33 AM Vincent Guittot wrote: [...] > > > > > So why is it a problem for you ? You are mentioning newly idle load > > > > > balance so I assume that your root problem is the scheduling delay > > > > > generated by the newly idle load balance which then calls > > > > >

Re: [PATCH] sched/fair: Rate limit calls to update_blocked_averages() for NOHZ

2021-01-28 Thread Joel Fernandes
Hi Vincent, On Thu, Jan 28, 2021 at 8:57 AM Vincent Guittot wrote: > > On Mon, Jan 25, 2021 at 03:42:41PM +0100, Vincent Guittot wrote: > > > On Fri, 22 Jan 2021 at 20:10, Joel Fernandes > > > wrote: > > > > On Fri, Jan 22, 2021 at 05:56:22PM +0100, Vincent

Re: [PATCH] sched/fair: Rate limit calls to update_blocked_averages() for NOHZ

2021-01-27 Thread Joel Fernandes
Hi Vincent, On Mon, Jan 25, 2021 at 03:42:41PM +0100, Vincent Guittot wrote: > On Fri, 22 Jan 2021 at 20:10, Joel Fernandes wrote: > > On Fri, Jan 22, 2021 at 05:56:22PM +0100, Vincent Guittot wrote: > > > On Fri, 22 Jan 2021 at 16:46, Joel Fernandes (Go

[PATCH v10 2/5] sched: CGroup tagging interface for core scheduling

2021-01-22 Thread Joel Fernandes (Google)
for now that avoids such complications. Core scheduler has extra overhead. Enable it only for core with more than one SMT hardware threads. Co-developed-by: Josh Don Co-developed-by: Chris Hyser Co-developed-by: Joel Fernandes (Google) Tested-by: Julien Desfossez Signed-off-by: Tim Chen

[PATCH v10 3/5] kselftest: Add tests for core-sched interface

2021-01-22 Thread Joel Fernandes (Google)
Add a kselftest test to ensure that the core-sched interface is working correctly. Co-developed-by: Chris Hyser Signed-off-by: Chris Hyser Tested-by: Julien Desfossez Reviewed-by: Josh Don Signed-off-by: Josh Don Signed-off-by: Chris Hyser Signed-off-by: Joel Fernandes (Google) --- tools

[PATCH v10 1/5] sched: migration changes for core scheduling

2021-01-22 Thread Joel Fernandes (Google)
-by: Tim Chen Signed-off-by: Vineeth Remanan Pillai Signed-off-by: Joel Fernandes (Google) --- kernel/sched/fair.c | 33 +--- kernel/sched/sched.h | 72 2 files changed, 101 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b

[PATCH v10 5/5] sched: Debug bits...

2021-01-22 Thread Joel Fernandes (Google)
Tested-by: Julien Desfossez Not-Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/core.c | 35 ++- kernel/sched/fair.c | 9 + 2 files changed, 43 insertions(+), 1 deletion(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index

[PATCH v10 4/5] Documentation: Add core scheduling documentation

2021-01-22 Thread Joel Fernandes (Google)
Signed-off-by: Joel Fernandes (Google) --- .../admin-guide/hw-vuln/core-scheduling.rst | 263 ++ Documentation/admin-guide/hw-vuln/index.rst | 1 + 2 files changed, 264 insertions(+) create mode 100644 Documentation/admin-guide/hw-vuln/core-scheduling.rst diff --git

[PATCH v10 0/5] Core scheduling remaining patches

2021-01-22 Thread Joel Fernandes (Google)
changes for core scheduling Joel Fernandes (Google) (3): kselftest: Add tests for core-sched interface Documentation: Add core scheduling documentation sched: Debug bits... Peter Zijlstra (1): sched: CGroup tagging interface for core scheduling .../admin-guide/hw-vuln/core-scheduling.rst | 263

Re: [PATCH] sched/fair: Rate limit calls to update_blocked_averages() for NOHZ

2021-01-22 Thread Joel Fernandes
On Fri, Jan 22, 2021 at 06:39:27PM +, Qais Yousef wrote: > On 01/22/21 17:56, Vincent Guittot wrote: > > > --- > > > kernel/sched/fair.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > > > index

Re: [PATCH] sched/fair: Rate limit calls to update_blocked_averages() for NOHZ

2021-01-22 Thread Joel Fernandes
Hi Vincent, Thanks for reply. Please see the replies below: On Fri, Jan 22, 2021 at 05:56:22PM +0100, Vincent Guittot wrote: > On Fri, 22 Jan 2021 at 16:46, Joel Fernandes (Google) > wrote: > > > > On an octacore ARM64 device running ChromeOS Linux kernel v5.4, I found > &

[PATCH] sched/fair: Rate limit calls to update_blocked_averages() for NOHZ

2021-01-22 Thread Joel Fernandes (Google)
) *99.0th: 717 (7 samples) 99.5th: 725 (2 samples) 99.9th: 725 (0 samples) Cc: Paul McKenney Cc: Frederic Weisbecker Suggested-by: Dietmar Eggeman Co-developed-by: Qais Yousef Signed-off-by: Qais Yousef Signed-off-by: Joel Fernandes (Google) --- kernel/sched/fair.c | 2

Re: [PATCH -tip 32/32] sched: Debug bits...

2021-01-15 Thread Joel Fernandes
On Tue, Dec 01, 2020 at 11:21:37AM +1100, Balbir Singh wrote: > On Tue, Nov 17, 2020 at 06:20:02PM -0500, Joel Fernandes (Google) wrote: > > Tested-by: Julien Desfossez > > Not-Signed-off-by: Peter Zijlstra (Intel) > > --- > > May be put it under a #ifdef CO

Re: [RFC][PATCH 0/4] arm64:kvm: teach guest sched that VCPUs can be preempted

2020-12-15 Thread Joel Fernandes
Hi Marc, Quentin, On Fri, Dec 11, 2020 at 4:34 AM Quentin Perret wrote: > > On Thursday 10 Dec 2020 at 08:45:22 (+), Marc Zyngier wrote: > > On 2020-12-10 01:39, Joel Fernandes wrote: > > > > [...] > > > > > > Quentin and I have discussed potential

Re: [PATCH -tip 23/32] sched: Add a per-thread core scheduling interface

2020-12-15 Thread Joel Fernandes
Hello Dhaval, On Tue, Dec 15, 2020 at 1:14 PM Dhaval Giani wrote: > > On 12/14/20 3:25 PM, Joel Fernandes wrote: > > >> No problem. That was there primarily for debugging. > > Ok. I squashed Josh's changes into this patch and several of my fixups. So > > there'

Re: [PATCH -tip 23/32] sched: Add a per-thread core scheduling interface

2020-12-14 Thread Joel Fernandes
On Mon, Dec 14, 2020 at 02:44:09PM -0500, chris hyser wrote: > On 12/14/20 2:31 PM, Joel Fernandes wrote: > > > diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c > > > index cffdfab..50c31f3 100644 > > > --- a/kernel/sched/debug.c > > > +++ b/kernel

Re: [PATCH -tip 23/32] sched: Add a per-thread core scheduling interface

2020-12-14 Thread Joel Fernandes
> diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c > index cffdfab..50c31f3 100644 > --- a/kernel/sched/debug.c > +++ b/kernel/sched/debug.c > @@ -1030,6 +1030,7 @@ void proc_sched_show_task(struct task_struct *p, struct > pid_namespace *ns, > > #ifdef CONFIG_SCHED_CORE >

Re: Energy-efficiency options within RCU

2020-12-14 Thread Joel Fernandes
On Thu, Dec 10, 2020 at 10:37:37AM -0800, Paul E. McKenney wrote: > Hello, Joel, > > In case you are -seriously- interested... ;-) I am always seriously interested :-). The issue becomes when life throws me a curveball. This was the year of curveballs :-) Thank you for your reply and I have

Re: [PATCH v12 00/31] Speculative page faults

2020-12-14 Thread Joel Fernandes
On Mon, Dec 14, 2020 at 10:36:29AM +0100, Laurent Dufour wrote: > Le 14/12/2020 à 03:03, Joel Fernandes a écrit : > > On Tue, Jul 07, 2020 at 01:31:37PM +0800, Chinwen Chang wrote: > > [..] > > > > > Hi Laurent, > > > > > > > > > > We

Re: [PATCH v12 00/31] Speculative page faults

2020-12-13 Thread Joel Fernandes
On Tue, Jul 07, 2020 at 01:31:37PM +0800, Chinwen Chang wrote: [..] > > > Hi Laurent, > > > > > > We merged SPF v11 and some patches from v12 into our platforms. After > > > several experiments, we observed SPF has obvious improvements on the > > > launch time of applications, especially for

[tip: core/rcu] rcu/tree: Add a warning if CPU being onlined did not report QS already

2020-12-13 Thread tip-bot2 for Joel Fernandes (Google)
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 9f866dac94292f93d3b6bf8dbe860a44b954e555 Gitweb: https://git.kernel.org/tip/9f866dac94292f93d3b6bf8dbe860a44b954e555 Author:Joel Fernandes (Google) AuthorDate:Tue, 29 Sep 2020 15:29:27 -04:00

[tip: core/rcu] rcu/tree: nocb: Avoid raising softirq for offloaded ready-to-execute CBs

2020-12-13 Thread tip-bot2 for Joel Fernandes (Google)
The following commit has been merged into the core/rcu branch of tip: Commit-ID: bd56e0a4a291bc9db2cbaddef20ec61a1aad4208 Gitweb: https://git.kernel.org/tip/bd56e0a4a291bc9db2cbaddef20ec61a1aad4208 Author:Joel Fernandes (Google) AuthorDate:Wed, 07 Oct 2020 13:50:36 -07:00

[tip: core/rcu] docs: Update RCU's hotplug requirements with a bit about design

2020-12-13 Thread tip-bot2 for Joel Fernandes (Google)
The following commit has been merged into the core/rcu branch of tip: Commit-ID: a043260740d5d6ec5be59c3fb595c719890a0b0b Gitweb: https://git.kernel.org/tip/a043260740d5d6ec5be59c3fb595c719890a0b0b Author:Joel Fernandes (Google) AuthorDate:Tue, 29 Sep 2020 15:29:28 -04:00

Re: [RFC][PATCH 0/4] arm64:kvm: teach guest sched that VCPUs can be preempted

2020-12-09 Thread Joel Fernandes
Hi Marc, nice to hear from you. On Wed, Dec 9, 2020 at 4:43 AM Marc Zyngier wrote: > > Hi all, > > On 2020-12-08 20:02, Joel Fernandes wrote: > > On Fri, Sep 11, 2020 at 4:58 AM Sergey Senozhatsky > > wrote: > >> > >> My apologies for the slow reply. &

Re: [RFC][PATCH 0/4] arm64:kvm: teach guest sched that VCPUs can be preempted

2020-12-08 Thread Joel Fernandes
On Fri, Sep 11, 2020 at 4:58 AM Sergey Senozhatsky wrote: > > My apologies for the slow reply. > > On (20/08/17 13:25), Marc Zyngier wrote: > > > > It really isn't the same thing at all. You are exposing PV spinlocks, > > while Sergey exposes preemption to vcpus. > > > > Correct, we see vcpu

Re: [PATCH -tip 22/32] sched: Split the cookie and setup per-task cookie on fork

2020-12-06 Thread Joel Fernandes
On Tue, Dec 01, 2020 at 08:20:50PM +0100, Peter Zijlstra wrote: > On Tue, Dec 01, 2020 at 02:11:33PM -0500, Joel Fernandes wrote: > > On Wed, Nov 25, 2020 at 12:15:41PM +0100, Peter Zijlstra wrote: > > > On Tue, Nov 17, 2020 at 06:19:52PM -0500, Joel Fernan

Re: [PATCH -tip 22/32] sched: Split the cookie and setup per-task cookie on fork

2020-12-06 Thread Joel Fernandes
Hi Peter, On Tue, Dec 01, 2020 at 08:34:51PM +0100, Peter Zijlstra wrote: > On Tue, Dec 01, 2020 at 02:20:28PM -0500, Joel Fernandes wrote: > > On Wed, Nov 25, 2020 at 12:10:14PM +0100, Peter Zijlstra wrote: > > > On Tue, Nov 17, 2020 at 06:19:52PM -0500, Joel Fernan

Re: [PATCH -tip 23/32] sched: Add a per-thread core scheduling interface

2020-12-06 Thread Joel Fernandes
On Wed, Dec 02, 2020 at 04:47:17PM -0500, Chris Hyser wrote: > On Tue, Nov 17, 2020 at 06:19:53PM -0500, Joel Fernandes (Google) wrote: > > Add a per-thread core scheduling interface which allows a thread to share a > > core with another thread, or have a core exclusi

Re: [PATCH v2] rcu/segcblist: Add debug checks for segment lengths

2020-12-02 Thread Joel Fernandes
On Tue, Dec 01, 2020 at 08:21:43PM -0800, Paul E. McKenney wrote: > On Tue, Dec 01, 2020 at 05:26:32PM -0500, Joel Fernandes wrote: > > On Thu, Nov 19, 2020 at 3:42 PM Joel Fernandes > > wrote: > > > > > > On Thu, Nov 19, 2020 at 12:16:15PM -0800, Paul E. McKen

Re: [PATCH v2] rcu/segcblist: Add debug checks for segment lengths

2020-12-01 Thread Joel Fernandes
On Thu, Nov 19, 2020 at 3:42 PM Joel Fernandes wrote: > > On Thu, Nov 19, 2020 at 12:16:15PM -0800, Paul E. McKenney wrote: > > On Thu, Nov 19, 2020 at 02:44:35PM -0500, Joel Fernandes wrote: > > > On Thu, Nov 19, 2020 at 2:22 PM Paul E. McKenney > > > wrote:

Re: [PATCH -tip 26/32] sched: Add a second-level tag for nested CGroup usecase

2020-12-01 Thread Joel Fernandes
Hi Peter, On Wed, Nov 25, 2020 at 02:42:37PM +0100, Peter Zijlstra wrote: > On Tue, Nov 17, 2020 at 06:19:56PM -0500, Joel Fernandes (Google) wrote: > > From: Josh Don > > > > Google has a usecase where the first level tag to tag a CGroup is not > > sufficient. So, a

Re: [PATCH -tip 23/32] sched: Add a per-thread core scheduling interface

2020-12-01 Thread Joel Fernandes
On Wed, Nov 25, 2020 at 02:08:08PM +0100, Peter Zijlstra wrote: > On Tue, Nov 17, 2020 at 06:19:53PM -0500, Joel Fernandes (Google) wrote: > > +/* Called from prctl interface: PR_SCHED_CORE_SHARE */ > > +int sched_core_share_pid(pid_t pid) > > +{ > > + struct task_st

Re: [PATCH -tip 22/32] sched: Split the cookie and setup per-task cookie on fork

2020-12-01 Thread Joel Fernandes
On Wed, Nov 25, 2020 at 12:10:14PM +0100, Peter Zijlstra wrote: > On Tue, Nov 17, 2020 at 06:19:52PM -0500, Joel Fernandes (Google) wrote: > > +void sched_core_tag_requeue(struct task_struct *p, unsigned long cookie, > > bool group) > > +{ > > + if

Re: [PATCH -tip 22/32] sched: Split the cookie and setup per-task cookie on fork

2020-12-01 Thread Joel Fernandes
On Wed, Nov 25, 2020 at 12:11:28PM +0100, Peter Zijlstra wrote: > On Tue, Nov 17, 2020 at 06:19:52PM -0500, Joel Fernandes (Google) wrote: > > > + * sched_core_tag_requeue - Common helper for all interfaces to set a > > cookie. > > sched_core_set_cookie() woul

Re: [PATCH -tip 22/32] sched: Split the cookie and setup per-task cookie on fork

2020-12-01 Thread Joel Fernandes
On Wed, Nov 25, 2020 at 12:15:41PM +0100, Peter Zijlstra wrote: > On Tue, Nov 17, 2020 at 06:19:52PM -0500, Joel Fernandes (Google) wrote: > > > +/* > > + * Ensure that the task has been requeued. The stopper ensures that the > > task cannot > > + * be migrated to

Re: [PATCH -tip 22/32] sched: Split the cookie and setup per-task cookie on fork

2020-12-01 Thread Joel Fernandes
On Wed, Nov 25, 2020 at 12:07:09PM +0100, Peter Zijlstra wrote: > On Tue, Nov 17, 2020 at 06:19:52PM -0500, Joel Fernandes (Google) wrote: > > Also, for the per-task cookie, it will get weird if we use pointers of any > > emphemeral objects. For this reason, introduce a refcount

Re: [PATCH -tip 22/32] sched: Split the cookie and setup per-task cookie on fork

2020-12-01 Thread Joel Fernandes
On Wed, Nov 25, 2020 at 02:03:22PM +0100, Peter Zijlstra wrote: > On Tue, Nov 17, 2020 at 06:19:52PM -0500, Joel Fernandes (Google) wrote: > > +static bool sched_core_get_task_cookie(unsigned long cookie) > > +{ > > + struct sched_core_cookie *ptr = (struct sched

Re: [PATCH -tip 22/32] sched: Split the cookie and setup per-task cookie on fork

2020-12-01 Thread Joel Fernandes
On Wed, Nov 25, 2020 at 01:54:47PM +0100, Peter Zijlstra wrote: > On Tue, Nov 17, 2020 at 06:19:52PM -0500, Joel Fernandes (Google) wrote: > > +/* Per-task interface */ > > +static unsigned long sched_core_alloc_task_cookie(void) > > +{ > > + st

Re: [PATCH -tip 19/32] entry/idle: Enter and exit kernel protection during idle entry and exit

2020-12-01 Thread Joel Fernandes
On Wed, Nov 25, 2020 at 09:49:08AM +0100, Peter Zijlstra wrote: > On Tue, Nov 24, 2020 at 01:03:43PM -0500, Joel Fernandes wrote: > > On Tue, Nov 24, 2020 at 05:13:35PM +0100, Peter Zijlstra wrote: > > > On Tue, Nov 17, 2020 at 06:19:49PM -0500, Joel Fernandes (Google) wrote:

Re: [PATCH -tip 18/32] kernel/entry: Add support for core-wide protection of kernel-mode

2020-12-01 Thread Joel Fernandes
On Wed, Nov 25, 2020 at 10:37:00AM +0100, Peter Zijlstra wrote: > On Tue, Nov 17, 2020 at 06:19:48PM -0500, Joel Fernandes (Google) wrote: > > Core-scheduling prevents hyperthreads in usermode from attacking each > > other, but it does not do anything about one of the hyperthrea

Re: [PATCH -tip 10/32] sched: Fix priority inversion of cookied task with sibling

2020-12-01 Thread Joel Fernandes
On Thu, Nov 26, 2020 at 10:05:19AM +1100, Balbir Singh wrote: > On Tue, Nov 24, 2020 at 01:30:38PM -0500, Joel Fernandes wrote: > > On Mon, Nov 23, 2020 at 09:41:23AM +1100, Balbir Singh wrote: > > > On Tue, Nov 17, 2020 at 06:19:40PM -0500, Joel Fernandes (Google) wrote: &

Re: [PATCH -tip 10/32] sched: Fix priority inversion of cookied task with sibling

2020-11-24 Thread Joel Fernandes
On Mon, Nov 23, 2020 at 09:41:23AM +1100, Balbir Singh wrote: > On Tue, Nov 17, 2020 at 06:19:40PM -0500, Joel Fernandes (Google) wrote: > > From: Peter Zijlstra > > > > The rationale is as follows. In the core-wide pick logic, even if > > need_sync == false, we ne

Re: [PATCH -tip 19/32] entry/idle: Enter and exit kernel protection during idle entry and exit

2020-11-24 Thread Joel Fernandes
On Tue, Nov 24, 2020 at 05:13:35PM +0100, Peter Zijlstra wrote: > On Tue, Nov 17, 2020 at 06:19:49PM -0500, Joel Fernandes (Google) wrote: > > Add a generic_idle_{enter,exit} helper function to enter and exit kernel > > protection when entering and exiting idle, respectively.

Re: [PATCH -tip 18/32] kernel/entry: Add support for core-wide protection of kernel-mode

2020-11-24 Thread Joel Fernandes
Hi Peter, On Tue, Nov 24, 2020 at 05:09:06PM +0100, Peter Zijlstra wrote: > On Tue, Nov 17, 2020 at 06:19:48PM -0500, Joel Fernandes (Google) wrote: > > Core-scheduling prevents hyperthreads in usermode from attacking each > > other, but it does not do anything about one of t

Re: [PATCH -tip 15/32] sched: Improve snapshotting of min_vruntime for CGroups

2020-11-24 Thread Joel Fernandes
Hi Peter, On Tue, Nov 24, 2020 at 11:27:41AM +0100, Peter Zijlstra wrote: > On Tue, Nov 17, 2020 at 06:19:45PM -0500, Joel Fernandes (Google) wrote: > > A previous patch improved cross-cpu vruntime comparison opertations in > > pick_next_task(). Improve it further for t

Re: [PATCH -tip 12/32] sched: Simplify the core pick loop for optimized case

2020-11-24 Thread Joel Fernandes
Hi Peter, On Tue, Nov 24, 2020 at 01:04:38PM +0100, Peter Zijlstra wrote: > On Tue, Nov 17, 2020 at 06:19:42PM -0500, Joel Fernandes (Google) wrote: > > + /* > > +* Optimize for common case where this CPU has no cookies > > +* and there are no cookied task

Re: [PATCH -tip 00/32] Core scheduling (v9)

2020-11-24 Thread Joel Fernandes
On Tue, Nov 24, 2020 at 6:48 AM Vincent Guittot wrote: > > Hi Joel, > > On Wed, 18 Nov 2020 at 00:20, Joel Fernandes (Google) > wrote: > > > > Core-Scheduling > > === > > Enclosed is series v9 of core scheduling. > > v9 is rebased on tip/

Re: [PATCH -tip 02/32] sched: Introduce sched_class::pick_task()

2020-11-20 Thread Joel Fernandes
On Fri, Nov 20, 2020 at 10:56:09AM +1100, Singh, Balbir wrote: [..] > > +#ifdef CONFIG_SMP > > +static struct task_struct *pick_task_fair(struct rq *rq) > > +{ > > + struct cfs_rq *cfs_rq = >cfs; > > + struct sched_entity *se; > > + > > + if (!cfs_rq->nr_running) > > + return

Re: [PATCH -tip 01/32] sched: Wrap rq::lock access

2020-11-20 Thread Joel Fernandes
On Fri, Nov 20, 2020 at 10:31:39AM +1100, Singh, Balbir wrote: > On 18/11/20 10:19 am, Joel Fernandes (Google) wrote: > > From: Peter Zijlstra > > > > In preparation of playing games with rq->lock, abstract the thing > > using an accessor. > > >

Re: [PATCH v2] rcu/segcblist: Add debug checks for segment lengths

2020-11-19 Thread Joel Fernandes
On Thu, Nov 19, 2020 at 12:16:15PM -0800, Paul E. McKenney wrote: > On Thu, Nov 19, 2020 at 02:44:35PM -0500, Joel Fernandes wrote: > > On Thu, Nov 19, 2020 at 2:22 PM Paul E. McKenney wrote: > > > > > > > On Wed, Nov 18, 2020 at 11:15:41AM -0500, Joel Fernandes

Re: [PATCH v2] rcu/segcblist: Add debug checks for segment lengths

2020-11-19 Thread Joel Fernandes
On Thu, Nov 19, 2020 at 2:22 PM Paul E. McKenney wrote: > > > > > On Wed, Nov 18, 2020 at 11:15:41AM -0500, Joel Fernandes (Google) > > > > > wrote: > > > > > > After rcu_do_batch(), add a check for whether the seglen counts > > > &g

Re: [PATCH v2] rcu/segcblist: Add debug checks for segment lengths

2020-11-19 Thread Joel Fernandes
On Wed, Nov 18, 2020 at 07:56:13PM -0800, Paul E. McKenney wrote: > On Wed, Nov 18, 2020 at 07:52:23PM -0800, Paul E. McKenney wrote: > > On Wed, Nov 18, 2020 at 12:13:35PM -0800, Paul E. McKenney wrote: > > > On Wed, Nov 18, 2020 at 11:15:41AM -0500, Joel Fernandes (Google) wr

[PATCH v2] rcu/segcblist: Add debug checks for segment lengths

2020-11-18 Thread Joel Fernandes (Google)
After rcu_do_batch(), add a check for whether the seglen counts went to zero if the list was indeed empty. Signed-off-by: Joel Fernandes (Google) --- v1->v2: Added more debug checks. kernel/rcu/rcu_segcblist.c | 12 kernel/rcu/rcu_segcblist.h | 3 +++ kernel/rcu/tre

[PATCH] rcu/segcblist: Add debug check for whether seglen is 0 for empty list

2020-11-18 Thread Joel Fernandes (Google)
After rcu_do_batch(), add a check for whether the seglen counts went to zero if the list was indeed empty. Signed-off-by: Joel Fernandes (Google) --- kernel/rcu/rcu_segcblist.c | 12 kernel/rcu/rcu_segcblist.h | 3 +++ kernel/rcu/tree.c | 1 + 3 files changed, 16

[PATCH -tip 09/32] sched/fair: Snapshot the min_vruntime of CPUs on force idle

2020-11-17 Thread Joel Fernandes (Google)
-off-by: Joel Fernandes (Google) --- kernel/sched/core.c | 33 - kernel/sched/fair.c | 40 kernel/sched/sched.h | 5 + 3 files changed, 65 insertions(+), 13 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched

[PATCH -tip 08/32] sched/fair: Fix forced idle sibling starvation corner case

2020-11-17 Thread Joel Fernandes (Google)
to schedule. Tested-by: Julien Desfossez Reviewed-by: Joel Fernandes (Google) Signed-off-by: Vineeth Pillai Signed-off-by: Julien Desfossez Signed-off-by: Joel Fernandes (Google) --- kernel/sched/core.c | 15 --- kernel/sched/fair.c | 40

[PATCH -tip 21/32] sched: CGroup tagging interface for core scheduling

2020-11-17 Thread Joel Fernandes (Google)
Pillai Signed-off-by: Joel Fernandes (Google) --- kernel/sched/core.c | 183 +-- kernel/sched/sched.h | 4 + 2 files changed, 181 insertions(+), 6 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 7f807a84cc30..b99a7493d590

[PATCH -tip 15/32] sched: Improve snapshotting of min_vruntime for CGroups

2020-11-17 Thread Joel Fernandes (Google)
. Reviewed-by: Vineeth Pillai Suggested-by: Peter Zijlstra (Intel) Signed-off-by: Joel Fernandes (Google) --- kernel/sched/core.c | 61 + kernel/sched/fair.c | 80 kernel/sched/sched.h | 7 +++- 3 files changed, 97

[PATCH -tip 19/32] entry/idle: Enter and exit kernel protection during idle entry and exit

2020-11-17 Thread Joel Fernandes (Google)
Add a generic_idle_{enter,exit} helper function to enter and exit kernel protection when entering and exiting idle, respectively. While at it, remove a stale RCU comment. Reviewed-by: Alexandre Chartre Tested-by: Julien Desfossez Signed-off-by: Joel Fernandes (Google) --- include/linux/entry

[PATCH -tip 32/32] sched: Debug bits...

2020-11-17 Thread Joel Fernandes (Google)
Tested-by: Julien Desfossez Not-Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/core.c | 35 ++- kernel/sched/fair.c | 9 + 2 files changed, 43 insertions(+), 1 deletion(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index

[PATCH -tip 31/32] sched: Add a coresched command line option

2020-11-17 Thread Joel Fernandes (Google)
defaults to 'secure' and can be overridden to 'on' if the user wants to enable coresched even if the HW is not vulnerable. 'off' would disable core scheduling in any case. Also add a sched_debug entry to indicate if core scheduling is turned on or not. Reviewed-by: Alexander Graf Signed-off-by: Joel

[PATCH -tip 30/32] Documentation: Add core scheduling documentation

2020-11-17 Thread Joel Fernandes (Google)
Document the usecases, design and interfaces for core scheduling. Co-developed-by: Vineeth Pillai Signed-off-by: Vineeth Pillai Tested-by: Julien Desfossez Reviewed-by: Randy Dunlap Signed-off-by: Joel Fernandes (Google) --- .../admin-guide/hw-vuln/core-scheduling.rst | 330

[PATCH -tip 13/32] sched: Trivial forced-newidle balancer

2020-11-17 Thread Joel Fernandes (Google)
Desfossez Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Joel Fernandes (Google) --- include/linux/sched.h | 1 + kernel/sched/core.c | 130 +- kernel/sched/idle.c | 1 + kernel/sched/sched.h | 6 ++ 4 files changed, 137 insertions(+), 1

[PATCH -tip 29/32] sched: Move core-scheduler interfacing code to a new file

2020-11-17 Thread Joel Fernandes (Google)
-by: Julien Desfossez Reviewed-by: Chris Hyser Signed-off-by: Chris Hyser Signed-off-by: Joel Fernandes (Google) --- kernel/sched/Makefile | 1 + kernel/sched/core.c| 809 +--- kernel/sched/coretag.c | 819 + kernel

[PATCH -tip 03/32] sched/fair: Fix pick_task_fair crashes due to empty rbtree

2020-11-17 Thread Joel Fernandes (Google)
ime. Suggested-by: Vineeth Remanan Pillai Signed-off-by: Peter Zijlstra Signed-off-by: Joel Fernandes (Google) --- kernel/sched/fair.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 12cf068eeec8..51483a00a755 100

[PATCH -tip 26/32] sched: Add a second-level tag for nested CGroup usecase

2020-11-17 Thread Joel Fernandes (Google)
. Reviewed-by: Joel Fernandes (Google) Signed-off-by: Josh Don Signed-off-by: Joel Fernandes (Google) --- include/linux/sched.h | 1 + kernel/sched/core.c | 120 +++--- kernel/sched/sched.h | 2 + 3 files changed, 103 insertions(+), 20 deletions(-) diff

[PATCH -tip 28/32] kselftest: Add tests for core-sched interface

2020-11-17 Thread Joel Fernandes (Google)
Add a kselftest test to ensure that the core-sched interface is working correctly. Tested-by: Julien Desfossez Reviewed-by: Josh Don Signed-off-by: Joel Fernandes (Google) --- tools/testing/selftests/sched/.gitignore | 1 + tools/testing/selftests/sched/Makefile| 14 + tools

[PATCH -tip 27/32] sched/debug: Add CGroup node for printing group cookie if SCHED_DEBUG

2020-11-17 Thread Joel Fernandes (Google)
This will be used by kselftest to verify the CGroup cookie value that is set by the CGroup interface. Reviewed-by: Josh Don Tested-by: Julien Desfossez Signed-off-by: Joel Fernandes (Google) --- kernel/sched/core.c | 31 +++ 1 file changed, 31 insertions(+) diff

[PATCH -tip 25/32] sched: Refactor core cookie into struct

2020-11-17 Thread Joel Fernandes (Google)
of existing core cookies so that multiple tasks may share the same core_cookie. This will be especially useful in the next patch, where the concept of cookie color is introduced. Reviewed-by: Joel Fernandes (Google) Signed-off-by: Josh Don Signed-off-by: Joel Fernandes (Google) --- kernel

[PATCH -tip 23/32] sched: Add a per-thread core scheduling interface

2020-11-17 Thread Joel Fernandes (Google)
the camera streaming frame rate by ~3%. Tested-by: Julien Desfossez Reviewed-by: Aubrey Li Co-developed-by: Chris Hyser Signed-off-by: Chris Hyser Signed-off-by: Joel Fernandes (Google) --- include/linux/sched.h| 1 + include/uapi/linux/prctl.h | 3 ++ kernel/sched/core.c

[PATCH -tip 24/32] sched: Release references to the per-task cookie on exit

2020-11-17 Thread Joel Fernandes (Google)
During exit, we have to free the references to a cookie that might be shared by many tasks. This commit therefore ensures when the task_struct is released, any references to cookies that it holds are also released. Reviewed-by: Chris Hyser Tested-by: Julien Desfossez Signed-off-by: Joel

  1   2   3   4   5   6   7   8   9   10   >