On Wed, Jun 24, 2015 at 12:08:50AM +0200, Stefan Agner wrote:
> On 2015-06-23 11:22, Johan Hovold wrote:
> > On Mon, Jun 22, 2015 at 10:11:35PM +0200, Stefan Agner wrote:
> >> On 2015-06-22 19:26, Johan Hovold wrote:
> >
> >> > Instead, hang the gpio chip dir
Hi Peter,
On Thu, Jun 25, 2015 at 01:16:56PM +0800, Peter Hung wrote:
> Hello Johan,
>
> Peter Hung 於 2015/6/15 上午 09:54 寫道:
> > This driver is for Fintek F81532/F81534 USB to Serial Ports IC.
> >
> > Features:
> > 1. F81534 is 1-to-4 & F81532 is 1-to-2 serial ports IC
> > 2. Support Baudrate fr
On Thu, Jun 25, 2015 at 05:21:01PM +0800, Peter Hung wrote:
> Hi Johan,
>
> Johan Hovold 於 2015/6/25 下午 04:06 寫道:
> > - As Greg already mentioned, you need to implement gpio support using
> > gpiolib, not a custom sysfs interface
> >
> > I don't have ti
On Thu, Jun 04, 2015 at 09:47:01AM -0700, John D. Blair wrote:
> From: "John D. Blair"
>
>
> Signed-off-by: John D. Blair
> ---
> drivers/usb/serial/cp210x.c |1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index 9031750e7
On Thu, Jun 04, 2015 at 01:18:19PM -0700, John D. Blair wrote:
> From: "John D. Blair"
>
> Added the USB serial device ID for the HubZ dual ZigBee
> and Z-Wave radio dongle.
>
> Signed-off-by: John D. Blair
Applied, thanks.
Johan
--
To unsubscribe from this list: send the line "unsubscribe li
[ Please avoid top-posting. ]
On Tue, Jun 02, 2015 at 02:49:30PM +0530, Abhishek bist wrote:
> Yes, I gone through this warning. It is because if i want to make this
> compilation warning free
> than i have to change the prototype of a open function pointer
> described in usb_serial_driver
> and c
On Wed, Jun 03, 2015 at 11:06:15AM -0700, John D. Blair wrote:
> From: "John D. Blair"
No commit message?
> Signed-off-by: John D. Blair
> ---
> drivers/usb/serial/cp210x.c |1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
>
On Sat, May 30, 2015 at 06:47:20PM +0530, Abhishek Bist wrote:
> While designing a usb to uart converter driver open function I am using
> usb_serial_generic_open, but wouldn't find need to pass tty as an argument.
> As it is not performing any task for further significance.
> So, This patch
On Mon, Jun 01, 2015 at 06:41:57AM +0530, Vaishali Thakkar wrote:
> Use the timer API function setup_timer instead of structure field
> assignments to initialize a timer.
>
> A simplified version of the Coccinelle semantic patch that performs
> this transformation is as follows:
>
> @change@
> ex
On Wed, Jun 10, 2015 at 06:08:09PM +0200, Claudio Cappelli wrote:
> From: Claudio Cappelli
>
> Add device Olivetti Olicard 300 (Network Connect: MT6225) - IDs 2020:4000.
>
> Signed-off-by: Claudio Cappelli
> Suggested-by: Lars Melin
>
> ---
>
> drivers/usb/serial/option.c |1 +
> 1 file
Hi Bartosz,
On Wed, Jun 10, 2015 at 04:34:21PM +0200, Bartosz Golaszewski wrote:
> When a GPIO expander device is removed - e.g. via i2c-adapter
> new_device/delete_device interface - with some GPIOs still requested,
> gpiochip_remove() function will emit a warning but remove the chip
> anyway.
>
On Mon, May 21, 2018 at 06:41:30PM +0200, Greg Kroah-Hartman wrote:
> On Mon, May 21, 2018 at 01:08:44PM +0200, Johan Hovold wrote:
> > Add missing const qualifiers to the termios hw-change helper parameters,
> > which is used by few USB serial drivers. This specifically allows
rtitz
> Tested-by: Thomas Martitz
> Signed-off-by: Rafael J. Wysocki
Reviewed-by: Johan Hovold
As already suggested elsewhere in the thread, I think a stable is
warranted too.
Thanks,
Johan
On Mon, May 21, 2018 at 08:48:32AM -0700, Tony Lindgren wrote:
> * Johan Hovold [180521 13:50]:
> > On Thu, May 17, 2018 at 10:10:38AM -0700, Tony Lindgren wrote:
> > > * Johan Hovold [180517 10:12]:
> > > Well in that case we should just stick with -1 value for the
On Thu, Mar 29, 2018 at 12:07:52AM +0800, Sanjeev Gupta wrote:
> All links checked, for those dead, I have replaced with copies on
> archive.org. For some, https is not supported, http has been
> kept.
>
> The git log says this was last done by Justin P. Mattock in 2010.
> Hi, Justin!
Not sure t
On Thu, Apr 26, 2018 at 06:40:46PM +0700, Lars Melin wrote:
> On 4/26/2018 18:39, Lars Melin wrote:
> > On 4/26/2018 18:19, Bjørn Mork wrote:
> >> Anyway, Qualcomm based designs are definitely handled by both drivers.
> >> Using qcserial only makes sense if the interface layout matches one of
> >>
On Thu, Apr 26, 2018 at 11:22:25PM +0700, Lars Melin wrote:
> On 4/26/2018 23:12, Johan Hovold wrote:
> > On Thu, Apr 26, 2018 at 06:40:46PM +0700, Lars Melin wrote:
> >> On 4/26/2018 18:39, Lars Melin wrote:
> >>> On 4/26/2018 18:19, Bjørn Mork wrote:
> >&g
On Thu, Apr 26, 2018 at 12:10:02PM +0200, H. Nikolaus Schaller wrote:
> > Am 25.04.2018 um 10:11 schrieb Johan Hovold :
> >
> > On Tue, Apr 24, 2018 at 09:44:08PM +0200, H. Nikolaus Schaller wrote:
> >
> >>> Am 24.04.2018 um 19:50 schrieb Johan Hovold :
&g
On Thu, Apr 26, 2018 at 02:12:32PM -0500, Dan Williams wrote:
> On Thu, 2018-04-26 at 18:29 +0200, Johan Hovold wrote:
> > On Thu, Apr 26, 2018 at 11:22:25PM +0700, Lars Melin wrote:
> > > On 4/26/2018 23:12, Johan Hovold wrote:
> > > > On Thu, Apr 26, 2018 at 06:4
On Sun, Apr 29, 2018 at 03:35:11PM +0200, Greg Kroah-Hartman wrote:
> I'll wait for the next resend of this series to review it again and
> consider merging it.
Thanks, I'll send a v2 sometime next week.
Johan
On Tue, May 01, 2018 at 09:05:42AM -0500, Rob Herring wrote:
> On Thu, Apr 26, 2018 at 4:10 AM, Johan Hovold wrote:
> > On Wed, Apr 25, 2018 at 01:16:58PM -0500, Rob Herring wrote:
> >> On Tue, Apr 24, 2018 at 11:34 AM, Johan Hovold wrote:
> >> > Add bin
On Sat, Apr 28, 2018 at 10:05:39AM +0530, Arvind Yadav wrote:
> Replace the manual validity checks for the GPIO with the
> gpio_is_valid().
>
> Signed-off-by: Arvind Yadav
> ---
> chnage in v2 :
> Returning invalid gpio as error instead of -ENODEV.
>
> drivers/staging/greybus/arche
On Wed, May 02, 2018 at 03:15:05PM +0530, Arvind Yadav wrote:
> On Wednesday 02 May 2018 02:13 PM, Johan Hovold wrote:
> > On Sat, Apr 28, 2018 at 10:05:39AM +0530, Arvind Yadav wrote:
> >> Replace the manual validity checks for the GPIO with the
> >> gpio_is_valid
gt; - pm_runtime_get_sync(dev);
> -
> return 0;
>
> err_resetc_assert:
Also note that there's currently a use-after-free in remove(), where
pm_runtime_put_sync() is called after the clocks have been put.
Something like the below (untested) patch should fix it.
Johan
On Fri, Jun 01, 2018 at 06:26:46PM +0200, Pavel Machek wrote:
> Hi!
>
> > > So you have serial line + pm + protocol type. Nothing GNSS specific
> > > really, it would be useful to (for example) say this is modem with AT
> > > commands. Or this is QMI modem.
> >
> > It's a matter of finding the ri
On Tue, Jun 05, 2018 at 11:02:36AM +0530, Viresh Kumar wrote:
> On 03-06-18, 08:52, Janani Sankara Babu wrote:
> > This patch replaces comparison of var to NULL with !var
> >
> > Signed-off-by: Janani Sankara Babu
> > ---
> > drivers/staging/greybus/core.c | 2 +-
> > 1 file changed, 1 insertion
On Wed, Jun 06, 2018 at 09:57:14AM -0400, Steven Rostedt wrote:
> On Wed, 6 Jun 2018 05:21:55 +0800
> kbuild test robot wrote:
>
> > Hi Changbin,
> >
> > Thank you for the patch! Perhaps something to improve:
> >
> > [auto build test WARNING on linus/master]
> > [also build test WARNING on v4.1
t move the allocation to probe() instead?
Also this doesn't look like something that requires atomic allocation in
the first place, GFP_KERNEL should do for the legacy suspend callback.
> return pinctrl_force_sleep(pcs->pctl);
> }
But for this fix, feel free to add:
Reviewed-by: Johan Hovold
Thanks,
Johan
On Wed, Jun 06, 2018 at 07:02:03PM +0300, Andy Shevchenko wrote:
> On Wed, Jun 6, 2018 at 4:43 PM, Colin King wrote:
> > From: Colin Ian King
> >
> > Currently saved_vals is being allocated and there is no check for
> > failed allocation (which is more likely than normal when using
> > GFP_ATOMIC
On Thu, Jun 07, 2018 at 09:47:18AM +0530, Viresh Kumar wrote:
> On 06-06-18, 14:26, Steven Rostedt wrote:
> > On Wed, 6 Jun 2018 16:26:00 +0200
> > Johan Hovold wrote:
> >
> > > Looks like the greybus code above is working as intended by checking for
> > >
On Thu, Jun 07, 2018 at 02:40:25PM +0530, Viresh Kumar wrote:
> On 07-06-18, 11:03, Bernd Petrovitsch wrote:
> > On Thu, 2018-06-07 at 14:08 +0530, Viresh Kumar wrote:
> > > On 07-06-18, 15:46, Du, Changbin wrote:
> > > > I think if the destination is not a null terminated string (If I
> > > > und
On Thu, Jun 07, 2018 at 05:12:51AM -0500, Alex Elder wrote:
> On 06/07/2018 04:19 AM, Viresh Kumar wrote:
> > On 07-06-18, 11:18, Johan Hovold wrote:
> >> If you want to work around the warning and think you can do it in some
> >> non-contrived way, then go for it.
>
cripts and services.
While the current interface is kept minimal, it could be extended using
IOCTLs, sysfs or uevents as needs and proper abstraction levels are
identified and determined (e.g. for device and feature identification).
Signed-off-by: Johan Hovold
---
MAINTAINERS | 6
(and this this is the main reason for not using the generic
serial implementation for this driver).
Note that timepulse-support is left unimplemented.
Signed-off-by: Johan Hovold
---
drivers/gnss/Kconfig | 12 ++
drivers/gnss/Makefile | 3 +
drivers/gnss/sirf.c | 415
slightly, but
the binding recommends using a common set of names.
Note that the wakeup gpio is not intended to be as a wakeup source, but
rather to detect the current power state of the device (active or
hibernate).
Signed-off-by: Johan Hovold
---
.../devicetree/bindings/gnss/sirfstar.txt | 38
simply means that the main supply is disabled in STANDBY and OFF.
Note that timepulse-support is not yet implemented.
Signed-off-by: Johan Hovold
---
drivers/gnss/Kconfig | 13 +
drivers/gnss/Makefile | 3 +
drivers/gnss/ubx.c| 133 ++
3 files
erial-based GPS device (using out-of-tree code). [ Let me know if
you've got any evalutation kits to spare. ]
Finally, note that documentation (including kerneldoc) remains to be
written, but hopefully this will not hinder review given that the
current interfaces are fairly self-describing.
Joh
Add binding for u-blox GNSS receivers.
Note that the u-blox product names encodes form factor (e.g. "neo"),
chipset (e.g. "8") and variant (e.g. "q"), but that only formfactor and
chipset is used for the compatible strings (for now).
Signed-off-by: Johan Hovold
---
, STANDBY and OFF.
Signed-off-by: Johan Hovold
---
drivers/gnss/Kconfig | 7 +
drivers/gnss/Makefile | 3 +
drivers/gnss/serial.c | 288 ++
drivers/gnss/serial.h | 47 +++
4 files changed, 345 insertions(+)
create mode 100644 drivers/gnss/serial.c
Describe generic properties for GNSS receivers.
Signed-off-by: Johan Hovold
---
.../devicetree/bindings/gnss/gnss.txt | 36 +++
MAINTAINERS | 1 +
2 files changed, 37 insertions(+)
create mode 100644 Documentation/devicetree/bindings
[ Adding some more people on CC. ]
On Tue, Apr 24, 2018 at 04:29:53PM +0800, Shrirang Bagul wrote:
> On systems using Intel Atom (Baytrail-I) SoC's, slave devices connected on
> HSUART1/2 ports are described by the ACPI BIOS as virtual hardware using
> HID's INT3511/INT3512 [1].
>
> As a conseque
On Tue, Apr 24, 2018 at 07:40:00PM +0200, H. Nikolaus Schaller wrote:
> Hi Johan,
>
> > Am 24.04.2018 um 18:34 schrieb Johan Hovold :
> > As proof-of-concept I have implemented drivers for receivers based on
> > two common GNSS chipsets (SiRFstar and u-blox), but due
On Wed, Apr 25, 2018 at 08:26:59AM +0200, Pavel Machek wrote:
> Hi!
>
> > This series adds a new subsystem for GNSS receivers (e.g. GPS
> > receivers).
> >
> > While GNSS receivers are typically accessed using a UART interface they
> > often also support other I/O interfaces such as I2C, SPI and
On Tue, Apr 24, 2018 at 10:13:19PM +0200, Pavel Machek wrote:
> Hi!
>
> > This series adds a new subsystem for GNSS receivers (e.g. GPS
> > receivers).
>
> Actually... I'd just call it GPS subsystem. Yes, GPS is a bit
> misleading, but so is GNSS. We'd like Loran to use similar interface,
> right
On Tue, Apr 24, 2018 at 10:59:48PM +0200, Andreas Kemnade wrote:
> On Tue, 24 Apr 2018 22:13:19 +0200
> Pavel Machek wrote:
>
> > Hi!
> >
> > > This series adds a new subsystem for GNSS receivers (e.g. GPS
> > > receivers).
> >
> > Actually... I'd just call it GPS subsystem. Yes, GPS is a bit
On Tue, Apr 24, 2018 at 11:16:38PM +0200, Hans de Goede wrote:
> Hi,
>
> On 24-04-18 19:18, Johan Hovold wrote:
> > [ Adding some more people on CC. ]
> >
> > On Tue, Apr 24, 2018 at 04:29:53PM +0800, Shrirang Bagul wrote:
> >> On systems using Intel At
On Tue, Apr 24, 2018 at 09:44:08PM +0200, H. Nikolaus Schaller wrote:
> > Am 24.04.2018 um 19:50 schrieb Johan Hovold :
> > I think it should be done the other way round (if I understand you
> > correctly), that is, by adding support for configurations were WAKEUP is
> &g
On Wed, Apr 25, 2018 at 11:00:47AM +0200, Rafael J. Wysocki wrote:
> On Wednesday, April 25, 2018 9:47:36 AM CEST Johan Hovold wrote:
> > On Tue, Apr 24, 2018 at 11:16:38PM +0200, Hans de Goede wrote:
> > > Hi,
> > >
> > > On 24-04-18 19:18, Johan Hovold wrot
On Wed, Apr 25, 2018 at 10:48:19AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 24, 2018 at 06:34:51PM +0200, Johan Hovold wrote:
> > This series adds a new subsystem for GNSS receivers (e.g. GPS
> > receivers).
>
> YEAH
>
> Thanks so much for doing this, great w
On Wed, Apr 25, 2018 at 10:56:49AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 24, 2018 at 06:34:52PM +0200, Johan Hovold wrote:
> > +#define GNSS_MINORS16
>
> Why only 16? Just have to start somewhere?
Yeah, a mostly arbitrarily picked number. I figured only developer
On Wed, Apr 25, 2018 at 10:57:49AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 24, 2018 at 06:34:54PM +0200, Johan Hovold wrote:
> > Add a generic serial GNSS driver (library) which provides a common
> > implementation for the gnss interface and power management (runtime and
>
On Wed, Apr 25, 2018 at 11:00:31AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 24, 2018 at 06:34:54PM +0200, Johan Hovold wrote:
> > +static inline void *gnss_serial_get_drvdata(struct gnss_serial *gserial)
> > +{
> > + return &gserial[1];
> > +}
>
> Oh
On Wed, Apr 25, 2018 at 12:56:45PM +0200, Johan Hovold wrote:
> On Wed, Apr 25, 2018 at 10:56:49AM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Apr 24, 2018 at 06:34:52PM +0200, Johan Hovold wrote:
> > > +static int gnss_open(struct inode *inode, struct file *file)
>
On Thu, Apr 26, 2018 at 02:28:31PM +0800, SZ Lin (林上智) wrote:
> This patch adds support for ublox R410M PID 0x90b2 USB modem to option
> driver, this module supports LTE Cat M1 / NB1.
>
> Interface layout:
> 0: QCDM/DIAG
> 1: ADB
> 2: AT
> 3: RMNET
>
> Signed-off-by: SZ Lin (林上智)
> Cc: stable
Make sure to free the rfkill device in case registration fails during
probe.
Fixes: 5e7ca3937fbe ("net: rfkill: gpio: convert to resource managed
allocation")
Cc: stable # 3.13
Cc: Heikki Krogerus
Signed-off-by: Johan Hovold
---
net/rfkill/rfkill-gpio.c | 7 ++-
1 file
On Thu, Apr 26, 2018 at 02:48:54PM +0700, Lars Melin wrote:
> On 4/26/2018 14:09, Johan Hovold wrote:
> > On Thu, Apr 26, 2018 at 02:28:31PM +0800, SZ Lin (林上智) wrote:
> >> This patch adds support for ublox R410M PID 0x90b2 USB modem to option
> >> driver, this modul
On Wed, Apr 25, 2018 at 01:16:58PM -0500, Rob Herring wrote:
> On Tue, Apr 24, 2018 at 11:34 AM, Johan Hovold wrote:
> > Add binding for u-blox GNSS receivers.
> >
> > Note that the u-blox product names encodes form factor (e.g. "neo"),
> > chipset (e.g. "
On Wed, Apr 25, 2018 at 01:25:26PM -0500, Rob Herring wrote:
> On Tue, Apr 24, 2018 at 11:34 AM, Johan Hovold wrote:
> > Add binding for SiRFstar-based GNSS receivers.
> >
> > Note that while four compatible-strings are initially added representing
> > devices which dif
On Tue, Apr 16, 2019 at 01:26:45PM +0200, Johan Hovold wrote:
> On Thu, Apr 11, 2019 at 12:54:12PM +0800, Young Xiao wrote:
> > From: Young Xiao
> >
> > The driver expects at least one valid endpoint. If given
> > malicious descriptors that specify 0 for the numbe
On Mon, Apr 15, 2019 at 08:09:59AM -0500, Pierre-Louis Bossart wrote:
>
> >>
> >> Signed-off-by: Pierre-Louis Bossart
> >> ---
> >> drivers/soundwire/Kconfig | 2 +-
> >> drivers/soundwire/bus.c| 87
> >> drivers/soundwire/bus.h| 16 +--
>
On Wed, Apr 17, 2019 at 06:19:50AM -0500, Alex Elder wrote:
> I'm not completely sure about the inline function, but on the no blank
> lines thing (and many other minor issues) "checkpatch.pl" is to blame.
> There are lots of examples of issues that checkpatch points out that are
> matters of opin
in v2:
> - Rebase on top of 47830c1127ef ("staging: greybus: power_supply: fix
> prop-descriptor request size")
Thanks for rebasing.
Reviewed-by: Johan Hovold
Johan
Update an obsolete comment referring to the termios_locked structure
which was removed over a decade ago by commit fe6e29fdb1a7 ("tty:
simplify ktermios allocation").
While at it, fix the "Thus" typo.
Signed-off-by: Johan Hovold
---
drivers/tty/tty_io.c | 2 +-
1 file
On Wed, Apr 17, 2019 at 12:18:22PM -0500, Pierre-Louis Bossart wrote:
>
> diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
> index 19c8efb9a5ee..84876a74874f 100644
> --- a/drivers/soundwire/Kconfig
> +++ b/drivers/soundwire/Kconfig
> @@ -4,7 +4,7 @@
> >>
Drop the RELEVANT_IFLAG() macro which hasn't been used at least since
the dawn of git.
Signed-off-by: Johan Hovold
---
drivers/tty/serial/cpm_uart/cpm_uart_core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/tty/serial/cpm_uart/cpm_uart_core.c
b/drivers/tty/serial/cpm
Drop the RELEVANT_IFLAG() macro which has never been used.
Cc: Samuel Iglesias Gonsalvez
Cc: Jens Taprogge
Signed-off-by: Johan Hovold
---
drivers/ipack/devices/ipoctal.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/ipack/devices/ipoctal.h b/drivers/ipack/devices/ipoctal.h
index
rest could go through Greg's tty tree.
Johan
Johan Hovold (3):
tty: simserial: drop unused iflag macro
tty: ipoctal: drop unused iflag macro
tty: cpm_uart: drop unused iflag macro
arch/ia64/hp/sim/simserial.c| 2 --
drivers/ipack/devices/ipoctal.h | 1 -
d
Drop the RELEVANT_IFLAG() macro which hasn't been used for over a
decade.
Cc: Tony Luck
Cc: Fenghua Yu
Signed-off-by: Johan Hovold
---
arch/ia64/hp/sim/simserial.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/ia64/hp/sim/simserial.c b/arch/ia64/hp/sim/simserial.c
On Thu, Jan 24, 2019 at 07:34:36AM +0100, Andreas Kemnade wrote:
> Some Wi2Wi devices do not have a wakeup output, so device state can
> only be indirectly detected by looking whether there is communication
> over the serial lines.
> This approach requires a report cycle set to a value less than 2
On Fri, Jan 25, 2019 at 08:43:10PM +0100, Andreas Kemnade wrote:
> The GTA04 has a w2sg0004 or w2sg0084 gps chip. Not detectable
> which one is mounted so use the compatibility entry for w2sg0004
> for all which will work for both.
>
> Signed-off-by: Andreas Kemnade
> ---
> w2sg0004 bindings (tog
On Sun, Jan 27, 2019 at 07:19:16PM +0100, Tomasz Duszynski wrote:
> Add device tree support for Plantower PMS7003 particulate matter sensor.
>
> Signed-off-by: Tomasz Duszynski
> ---
> .../iio/chemical/plantower,pms7003.txt| 19 +++
> 1 file changed, 19 insertions(+)
> c
ff-by: Johan Hovold
---
This reverts a commit that got into -rc3 despite not really fixing
anything.
Johan
drivers/tty/tty_port.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/tty/tty_port.c b/drivers/tty/tty_port.c
index a9e12b3bc31d..044c3cbdcfa4 1
On Wed, Apr 03, 2019 at 10:06:49AM +0200, Greg Kroah-Hartman wrote:
> On Wed, Apr 03, 2019 at 09:40:53AM +0200, Johan Hovold wrote:
> > This reverts commit f4e68d58cf2b20a581759bbc7228052534652673.
> >
> > TTY drivers using the tty-port abstraction all provide a pointer
On Thu, Mar 21, 2019 at 04:47:19PM +0100, Fabien Dessenne wrote:
> This driver exposes a standard tty interface on top of the rpmsg
> framework through the "rpmsg-tty-channel" rpmsg service.
>
> This driver supports multi-instances, offering a /dev/ttyRPMSGx entry
> per rpmsg endpoint.
>
> Signed
On Tue, Feb 26, 2019 at 05:07:10PM +, Mans Rullgard wrote:
> The SIMCom SIM5218 and compatible devices have 5 USB interfaces, only 4
> of which are serial ports. The fifth is a network interface supported
> by the qmi-wwan driver. Furthermore, the serial ports do not support
> modem control s
On Tue, Feb 26, 2019 at 03:41:07PM +0100, Greg Kroah-Hartman wrote:
> The dev_links_info structure has 4 bytes of padding at the end of it
> when embedded in struct device (which is the only place it lives). To
> help reduce the size of struct device pack this structure so we can take
> advantage
On Wed, Feb 27, 2019 at 10:31:04AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Feb 27, 2019 at 10:23:18AM +0100, Johan Hovold wrote:
> > On Tue, Feb 26, 2019 at 03:41:07PM +0100, Greg Kroah-Hartman wrote:
> > > The dev_links_info structure has 4 bytes of padding at the end of it
&
On Wed, Feb 27, 2019 at 10:54:24AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Feb 27, 2019 at 10:40:21AM +0100, Johan Hovold wrote:
> > On Wed, Feb 27, 2019 at 10:31:04AM +0100, Greg Kroah-Hartman wrote:
> > > On Wed, Feb 27, 2019 at 10:23:18AM +0100, Johan Hovold wrote:
>
Adding Bjørn.
On Wed, Feb 27, 2019 at 11:57:16AM +, Måns Rullgård wrote:
> Johan Hovold writes:
>
> > On Tue, Feb 26, 2019 at 05:07:10PM +, Mans Rullgard wrote:
> >> The SIMCom SIM5218 and compatible devices have 5 USB interfaces, only 4
> >> of which are
On Wed, Feb 27, 2019 at 01:06:45PM +0100, Greg Kroah-Hartman wrote:
> On Wed, Feb 27, 2019 at 11:59:51AM +0100, Johan Hovold wrote:
> Yeah, that is a good point, normally we use packed to keep padding from
> the middle of the structure from happening.
>
> I just don't like
On Fri, Feb 12, 2021 at 01:48:35PM +0530, Pritthijit Nath wrote:
> Fixed the spelling of 'transfered' to 'transferred'.
>
> Signed-off-by: Pritthijit Nath
> ---
> drivers/staging/greybus/hid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/hid.c
On Fri, Feb 12, 2021 at 02:51:30PM +0530, Viresh Kumar wrote:
> On 12-02-21, 10:17, Greg KH wrote:
> > On Fri, Feb 12, 2021 at 02:39:26PM +0530, Viresh Kumar wrote:
> > > On 12-02-21, 13:48, Pritthijit Nath wrote:
> > > > This change fixes a checkpatch CHECK style issue for "Alignment should
> > >
On Fri, Feb 12, 2021 at 03:25:29PM +0530, Viresh Kumar wrote:
> On 12-02-21, 10:52, Johan Hovold wrote:
> > But what will the checkpatch crew then work on?
>
> Lol..
>
> > Better staging than the rest of the kernel.
>
> [ /me wondering on who stops them from s
On Tue, Feb 23, 2021 at 10:02:08AM +, Pho Tran wrote:
> Similar to other CP210x devices, GPIO interfaces (gpiochip) should be
> supported for CP2108.
>
> CP2108 has 4 serial interfaces but only 1 set of GPIO pins are shared to all
> of those interfaces.
> So, just need to initialize GPIOs of
On Wed, Feb 24, 2021 at 05:29:47PM +0800, dingsen...@163.com wrote:
> From: dingsenjie
>
> Simplify the return expression.
This was done on purpose (keep error paths separate from success) so no
need to "simplify".
Johan
On Wed, Feb 10, 2021 at 11:28:20AM +0100, Stefan Ursella wrote:
> Without this quirk starting a video capture from the device often fails with
>
> kernel: uvcvideo: Failed to set UVC probe control : -110 (exp. 34).
> Signed-off-by: Stefan Ursella
> ---
> drivers/usb/core/quirks.c | 3 +++
> 1 fi
> Signed-off-by: Kees Cook
Acked-by: Johan Hovold
On Wed, Feb 10, 2021 at 10:28:36PM +0100, Pavel Machek wrote:
> Hi!
>
> > > > +config GNSS_MOTMDM
> > > > + tristate "Motorola Modem TS 27.010 serdev GNSS receiver support"
> > > > + depends on SERIAL_DEV_N_GSM
> > >
> > > You need to post this driver together with the serdev-ngsm dri
On Thu, Dec 10, 2020 at 02:39:10PM +0100, Johan Hovold wrote:
> Architectures that describe the CPU topology in devicetree and that do
> not have an identity mapping between physical and logical CPU ids need
> to override the default implementation of arch_match_cpu_phys_id().
>
>
n boot_command_line being set */
> void __init parse_early_param(void);
Looks good:
Reviewed-by: Johan Hovold
Johan
On Mon, Feb 08, 2021 at 03:31:48PM +0100, Uwe Kleine-König wrote:
> In a bus remove function the passed device is always valid, so there is
> no need to check for it being NULL.
>
> (Side note: The check for port being non-NULL is broken anyhow, because
> to_usb_serial_port() is a wrapper around c
The to_usb_serial_port() macro is implemented using container_of() so
there's no need to check for NULL.
Note that neither bus match() or probe() is ever called with a NULL
struct device pointer so the checks weren't just misplaced.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/
On Tue, Feb 09, 2021 at 12:30:42PM +0100, Michal Simek wrote:
> Based on
> https://lore.kernel.org/linux-arm-kernel/ycjv59g3tq2ha...@kroah.com/
> initialization should fail if any registration fails.
>
> Signed-off-by: Michal Simek
> ---
>
> drivers/usb/misc/usb3503.c | 8 ++--
> 1 file cha
On Mon, Feb 08, 2021 at 06:06:38PM +0100, Uwe Kleine-König wrote:
> On 2/8/21 4:48 PM, Johan Hovold wrote:
> > The to_usb_serial_port() macro is implemented using container_of() so
> > there's no need to check for NULL.
> >
> > Note that neither bus match() or pr
On Thu, Feb 25, 2021 at 07:04:05PM +0100, Mauro Carvalho Chehab wrote:
> Em Thu, 25 Feb 2021 18:58:20 +0100
> Mauro Carvalho Chehab escreveu:
> > While testing the xr_serial (as currently merged), I opted to apply
> > the patches on the top of vanilla Kernel 5.11 - as it sounds too risky
> > to u
Cc: Manivannan Sadhasivam
Signed-off-by: Johan Hovold
---
drivers/usb/serial/xr_serial.c | 25 -
1 file changed, 25 deletions(-)
diff --git a/drivers/usb/serial/xr_serial.c b/drivers/usb/serial/xr_serial.c
index 483d07dee19d..0ca04906da4b 100644
--- a/drivers/usb/serial/xr
ot+d27b4c8adbbff70fb...@syzkaller.appspotmail.com
Signed-off-by: Johan Hovold
---
drivers/gpio/gpiolib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index adf55db080d8..e1016bc8cf14 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpioli
4.6
Signed-off-by: Johan Hovold
---
drivers/gpio/gpiolib.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index e1016bc8cf14..42bdc55a15f9 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -475,8 +475,12 @@ EXPORT_
Here's a fix for a regression in 5.12 due to the new stub-driver hack,
and a fix for potential list corruption due to missing locking which has
been there since the introduction of the character-device interface in
4.6.
Johan
Johan Hovold (2):
gpio: fix NULL-deref-on-deregistration regre
while still being registered.
Fixes: 50154e29e5cc ("leds: lm3533: Use devm_led_classdev_register")
Cc: stable # 4.6
Cc: Amitoj Kaur Chawla
Signed-off-by: Johan Hovold
---
drivers/leds/leds-lm3533.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/dr
601 - 700 of 2817 matches
Mail list logo
