reat.
> ---
>
> From: Randy Dunlap <[EMAIL PROTECTED]>
>
> Output of a function or struct in html mode needs to include the short
> description from the function/struct name line in the output title line.
>
> Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]>
On Tue, 2007-02-13 at 18:13 +, Pavel Machek wrote:
> Yes... is there merged .git tree somewhere? I downloaded iwl git tree,
> but it did not contain d80211 stack. I'm now downloading wireless-dev
> git tree...
I would expect Intel to post patches some time soon to get into
wireless-dev.
joha
On Sat, 2007-01-27 at 07:08 -0500, Dan Williams wrote:
> I really, really don't know why ieee80211 uses , but it's a pain
> in the ass and should NOT be done for d80211. I don't know if we can
> ever remove it from ieee80211 though for backwards compat reasons.
Ugh. /me makes a note for the cfg8
On Wed, 2006-12-13 at 13:17 -0500, Michael Bommarito wrote:
> Attached is a patch that fixes this (the actual change is two lines
> but context provided in patch for review). The dmesg containing call
> trace is attached to the bugzilla entry above.
You forgot to attach the patch but IIRC it's b
On Sat, 2006-11-18 at 06:24 -0500, Joseph Fannin wrote:
> This sounds like what my laptop was doing in -rc5, though mine
> didn't take hours to start acting up.
>
> I *think* it was the MSI troubles, causing interrupts to get
> lost forever. Anyway, it went away in -rc6.
Hah, that's a l
I don't see any reason why this is a semaphore, convert.
Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
---
fs/sysfs/file.c | 13 +++--
fs/sysfs/inode.c |4 ++--
fs/sysfs/sysfs.h |2 +-
3 files changed, 10 insertions(+), 9 deletions(-)
--- wireless-dev.orig/fs/s
On Fri, 2007-07-06 at 10:29 -0700, Christoph Lameter wrote:
> On Thu, 5 Jul 2007, Johannes Berg wrote:
>
> > kmem_cache_open is static so shouldn't be exported.
> >
> > Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
>
> I already fixed that. Patch is i
On Fri, 2007-07-06 at 10:55 -0700, Christoph Lameter wrote:
> On Fri, 6 Jul 2007, Johannes Berg wrote:
>
> > > I already fixed that. Patch is in Andrew's tree.
> >
> > Oh good. I actually got build problems from that due to a powerpc64 gcc
> > bug so... :)
On Fri, 2007-07-06 at 13:57 -0700, Bret Towe wrote:
> On 7/6/07, Johannes Berg <[EMAIL PROTECTED]> wrote:
> > Oh good. I actually got build problems from that due to a powerpc64 gcc
> > bug so... :)
> this also looks to solve booting issue on a g4 mac mini also
Huh?
On Fri, 2007-07-06 at 16:53 +0400, Oleg Nesterov wrote:
> Yes, got it, but forgot to reply to myself. But thanks for your confirmation
> of my understanding.
:)
> I believe both patches are nice.
Is there anything I should be doing now to get these patches in?
johannes
signature.asc
Descript
On Wed, 2007-07-11 at 17:40 -0700, Mike Anderson wrote:
> The pid is a hold over from older code. If this will cause issue for other
> users I can switch to using nlmsg_multicast (genlmsg_multicast depending
> on the comment if I need to switch to the genl interface) and remove this
> code all tog
I recently experienced a lockup in the wireless code due to the
scenario described in patch 1 and wanted to have lockdep warn
about such scenarios as a way to catch such bugs in other
subsystems as well as to make sure we wouldn't get such things
ever again.
In discussions with Oleg and Ingo it tu
eudo-lock to each workqueue to make lockdep
warn about this scenario.
Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
Acked-by: Oleg Nesterov <[EMAIL PROTECTED]>
Acked-by: Ingo Molnar <[EMAIL PROTECTED]>
Acked-by: Peter Zijlstra <[EMAIL PROTECTED]>
---
quired L1 already. This patch adds a pseudo-lock to each
struct work_struct to make lockdep warn about this scenario.
Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
Acked-by: Oleg Nesterov <[EMAIL PROTECTED]>
Acked-by: Ingo Molnar <[EMAIL PROTECTED]>
Acked-by: Peter
Hi,
Good stuff :)
> + int idlecount; /* number of empty packets */
should probably use tabs here.
> + size = usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
> +ATP_GEYSER3_MODE_WRITE_REQUEST_ID,
> +USB_DIR_
Commit ef2ad80c7d255ed0449eda947c2d700635b7e0f5 breaks
krealloc(NULL, ...) badly, it BUG_ON()s.
This patch fixes it but the fix should probably be in mm/util.c because
the documentation says that krealloc(NULL, x, gfp) is equivalent to
kmalloc(x, gfp) and that's not true any more even after this p
On Wed, 2007-07-18 at 10:58 -0400, Chuck Ebbert wrote:
> On 07/17/2007 08:20 PM, Peter Osterlund wrote:
> > Current -git kernels sometimes lock up on my computer during boot. I
> > guess it happens about 10-20% of the time. I first saw this maybe a
> > week ago, but never with kernels <= 2.6.22.
>
eudo-lock to each workqueue to make lockdep
warn about this scenario.
Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
Acked-by: Oleg Nesterov <[EMAIL PROTECTED]>
Acked-by: Ingo Molnar <[EMAIL PROTECTED]>
Acked-by: Peter Zijlstra <[EMAIL PROTECTED]>
---
This one applies ag
On Thu, 2007-05-10 at 14:10 +0900, Simon Horman wrote:
> drivers/macintosh/Kconfig:112:warning: 'select' used by config symbol
> 'PMAC_APM_EMU' refer to undefined symbol 'SYS_SUPPORTS_APM_EMULATION'
Argh. Is that with ARCH=ppc? I keep forgetting that it still exists,
sorry.
johannes
signature
On Fri, 2007-05-11 at 10:22 +0900, Simon Horman wrote:
> Actually, it was with ARCH=ia64. I have a feeling that you can get
> it to show up quite easily with anything other than ARCH=powerpc.
Ick, I didn't know that drivers/macintosh was now included for all
arches! Hmm. That's a bit of a problem
[/me wonders why he was CC'ed]
> /* CLONE_VFORK: wait until the usermode helper has execve'd
>* successfully We need the data structures to stay around
>* until that is done. */
> - if (wait)
> + if (wait == UMH_WAIT_PROC)
> pid = kernel_thread(wait_for
Simon,
> I don't think that this is quite right, or at least it isn't quite the
> same as before.
Yeah, I think you're right.
> I think that was is below will toggle
> SYS_SUPPORTS_APM_EMULATION when PMAC_APM_EMU is selected,
> which I think is what you want. Is it also neccessary to
> add a de
On Mon, 2007-05-14 at 09:24 -0500, Kumar Gala wrote:
> this was my fix which looks pretty much the same.
[...]
Great, thanks.
johannes
signature.asc
Description: This is a digitally signed message part
s invoked (but hasn't locked yet.)
Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
---
I'm not sure if this is correct on SMP because then might it complain
that the fake lock is locked at the same time from multiple CPUs? I
haven't (on my quad G5), however, had it print out anyt
On Wed, 2007-06-27 at 20:40 +0200, Johannes Berg wrote:
> --- linux-2.6-git.orig/kernel/workqueue.c 2007-06-27 19:10:35.183199046
> +0200
> +++ linux-2.6-git/kernel/workqueue.c 2007-06-27 20:30:00.896667168 +0200
> @@ -61,8 +61,15 @@ struct workqueue_struct {
> c
On Thu, 2007-06-28 at 18:33 +0200, Johannes Berg wrote:
> I think I misunderstood how lockdep works because the output was
> actually wrong, should the key be part of the workqueue_struct as well?
No, that's not right either, but Arjan just helped me a bit with how
lockdep works an
On Sat, 2007-06-30 at 15:46 +0400, Oleg Nesterov wrote:
> On 06/30, Ingo Molnar wrote:
> >
> > On Thu, 2007-06-28 at 19:33 +0200, Johannes Berg wrote:
> > > No, that's not right either, but Arjan just helped me a bit with how
> > > lockdep works and I think
On Sun, 2007-07-01 at 22:20 +0200, Adrian Bunk wrote:
> This patch removes dead code introduced by
> commit 90a42210f275e1f828eb6c08bf8252c2d6a774e0 and spotted
> by the Coverity checker.
> --- linux-2.6.22-rc6-mm1/drivers/net/wireless/libertas/wext.c.old
> 2007-06-29 21:52:56.0 +0200
On Sat, 2007-06-30 at 15:46 +0400, Oleg Nesterov wrote:
[reordered a bit]
> And,
>
> > if (!list_empty(&cwq->worklist) || cwq->current_work !=
> > NULL) {
> > @@ -376,6 +388,8 @@ void fastcall flush_workqueue(struct wor
> > int cpu;
> >
> > might_sleep();
> > +
On Tue, 2007-07-03 at 14:56 +0200, Rafael J. Wysocki wrote:
> Still, can you please read this post from Alan Stern:
>
> https://lists.linux-foundation.org/pipermail/linux-pm/2007-June/012847.html
>
> ? I don't think I'm able to repeat the arguments given in there in a
> convincing way.
As I re
On Tue, 2007-07-03 at 16:51 +0200, Rafael J. Wysocki wrote:
> > His proposed solution (freezing tasks when they cross the kernel
> > boundary) helps for the s-t-r case, but in fact doesn't solve (1)
> > because devices can be suspended at runtime
>
> This is a different thing and a different infr
On Tue, 2007-07-03 at 10:50 -0400, Alan Stern wrote:
> Time for me to jump in.
:)
> USB already implements runtime PM. If a device is suspended at runtime
> and a task tries to access it, the device is automatically resumed.
> No problem there.
Right.
> The problem comes when the system is
Oleg,
Thanks for your comments. Shows how little I really understand the
workqueue API :)
On Tue, 2007-07-03 at 21:31 +0400, Oleg Nesterov wrote:
> > I think this could lead to false positives, but then I think we
> > shouldn't care about those. Let me explain. The thing is that with this
> > it
On Wed, 2007-07-04 at 16:52 +0400, Oleg Nesterov wrote:
> Yes. And no other work (except a barrier) can run before the caller of
> wait_on_work() is woken.
Alright, thanks. Yes, then what you proposed makes a lot of sense, I'll
implement it.
> Aha, now I see where I was confused. Yes, we can't a
On Wed, 2007-07-04 at 14:21 +0200, Ingo Molnar wrote:
> well, in this case the lock/unlock should nest perfectly (i.e. it should
> always be balanced perfectly), so indeed calling with nested==1 leads to
> stricter checking.
>
> non-nested unlocks occur when people do stuff like:
>
> spi
On Thu, 2007-07-05 at 10:45 +0200, Ingo Molnar wrote:
> > +#ifdef CONFIG_LOCKDEP
> > + /*
> > +* It is permissible to free the struct work_struct
> > +* from inside the function that is called from it,
> > +* this we need to take into account for lockd
On Thu, 2007-07-05 at 10:48 +0200, Ingo Molnar wrote:
> btw., small patch format comment: it would be useful (in the future) to
> send such combined patches as:
>
> [patch 0/2] general description
> [patch 1/2] first patch
> [patch 2/2] second patch
Sure, no problem. I usually do that automa
On Thu, 2007-07-05 at 10:53 +0200, Ingo Molnar wrote:
> > +#ifdef CONFIG_LOCKDEP
> > +/*
> > + * HACK! This really should call lockdep_init_map() but can't
> > + * because there's no requirement to initialise work structs
> > + * at runtime. This works because subclass == 0.
> > + *
> > + * NB: be
k already.
Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
---
I don't like the static initialiser for the lockdep_map but don't see a
better way to do it. It works because it does the same things
lockdep_init_map() does when subclass == 0.
I used my mac80211 example and cha
s invoked (but hasn't locked yet.)
Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
---
This should be uncontroversial but doesn't add any debugging
for the cancel_*_work() API.
include/linux/workqueue.h | 20 +---
kernel/workqueue.c| 19 +++
On Thu, 2007-07-05 at 11:01 +0200, Peter Zijlstra wrote:
> You could of course make this STATIC_LOCKDEP_MAP_INIT() and place it
> near lockdep_init_map() :-)
>
> That way it would be clear that changes to either ought to be reflected
> in the other.
Sure. I have to repost anyway :)
How about
+
On Thu, 2007-07-05 at 11:10 +0200, Peter Zijlstra wrote:
> > +/* both _name and _key must not be NULL */
Heh actually I got confused. The requirement that _key is not NULL comes
from the fact that I need to copy it for the workqueue stuff, not from
lockdep. Hence, only _name must be non-NULL, I'l
kmem_cache_open is static so shouldn't be exported.
Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
---
mm/slub.c |1 -
1 file changed, 1 deletion(-)
--- wireless-dev.orig/mm/slub.c 2007-07-05 11:35:51.555640003 +0200
+++ wireless-dev/mm/slub.c 2007-07-05 11:36:03.8956
I recently experienced a lockup in the wireless code due to the
scenario described in patch 1 and wanted to have lockdep warn
about such scenarios as a way to catch such bugs in other
subsystems as well as to make sure we wouldn't get such things
ever again.
In discussions with Oleg and Ingo it tu
eudo-lock to each workqueue to make lockdep
warn about this scenario.
Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
Cc: Oleg Nesterov <[EMAIL PROTECTED]>
Acked-by: Ingo Molnar <[EMAIL PROTECTED]>
Acked-by: Peter Zijlstra <[EMAIL PROTECTED]>
---
quired L1 already. This patch adds a pseudo-lock to each
struct work_struct to make lockdep warn about this scenario.
Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
Cc: Oleg Nesterov <[EMAIL PROTECTED]>
Acked-by: Ingo Molnar <[EMAIL PROTECTED]>
Acked-by: Peter Zijlstra <[E
On Thu, 2007-07-05 at 14:51 +0200, Rafael J. Wysocki wrote:
> > > Remember what I wrote a few minutes ago about khubd and ksuspend_usbd
> > > wanting to resume devices during a system suspend transition? This is
> > > exactly what happens when those threads aren't frozen.
> >
> > So, I wonder wh
On Thu, 2007-07-05 at 18:52 +0400, Oleg Nesterov wrote:
> So I agree with you, such recursion is indeed bad. Can we forbid this?
> In that case this patch is even more perfect :)
I haven't seen it complain in a few days so that probably means such
usage is rather rare :)
johannes
signature.asc
On Thu, 2007-07-05 at 19:36 +0400, Oleg Nesterov wrote:
> So, __WORK_INITIALIZER() uses work_struct itself as a "struct lock_class_key"
> ?
> How so?
Well, this is for work_structs that are static (not dynamically
allocated.) struct lock_class_key is just a single byte because its
whole purpose
The print_stack_trace macro in stacktrace.h has a wrong number of
arguments, fix it.
Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
---
include/linux/stacktrace.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6-git.orig/include/linux/stacktrace.h 2007-07-
When I started adding support for lockdep to 64-bit powerpc, I got a
lockdep_init_error and with this patch was able to pinpoint why and
where to put lockdep_init(). Let's support this generally for others
adding lockdep support to their architecture.
Signed-off-by: Johannes Berg &l
On Wed, 2007-05-23 at 07:37 -0500, Kumar Gala wrote:
> Was my patch ok, if so I'll push it up through my git tree to paul?
Yeah, looks fine to me, or will the ARCH=ppc folks then scream and want
that added to the Kconfig there as well?
johannes
signature.asc
Description: This is a digitally si
On Wed, 2007-05-23 at 09:14 -0500, Kumar Gala wrote:
> On Wed, 23 May 2007, Johannes Berg wrote:
>
> > On Wed, 2007-05-23 at 07:37 -0500, Kumar Gala wrote:
> >
> > > Was my patch ok, if so I'll push it up through my git tree to paul?
> >
> > Yeah, looks
disk mode.
Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
--- linux-2.6.orig/fs/partitions/Kconfig2007-03-15 11:04:20.785467186
+0100
+++ linux-2.6/fs/partitions/Kconfig 2007-03-15 11:05:14.505467186 +0100
@@ -235,5 +235,4 @@ config EFI_PARTITION
select CRC32
he
On Sat, 2007-05-05 at 14:21 +0200, Rafael J. Wysocki wrote:
>
> Power off the system instead of halting it if the 'platform' mode of
> hibernation
> has been requested, but hibernation_ops is not set.
Ehm, unless you made a mistake in the patch then that shouldn't be
possible.
johannes
signat
On Sat, 2007-05-05 at 15:50 +0200, Rafael J. Wysocki wrote:
> @@ -60,6 +60,9 @@ void hibernation_set_ops(struct hibernat
> }
> mutex_lock(&pm_mutex);
> hibernation_ops = ops;
> + if (ops)
> + hibernation_mode = HIBERNATION_PLATFORM;
else if (hibernation_m
On Mon, 2007-05-07 at 13:46 +0200, Johannes Berg wrote:
> On Sat, 2007-05-05 at 15:50 +0200, Rafael J. Wysocki wrote:
>
> > @@ -60,6 +60,9 @@ void hibernation_set_ops(struct hibernat
> > }
> > mutex_lock(&pm_mutex);
> > hibe
On Mon, 2007-05-07 at 23:35 +0200, Rafael J. Wysocki wrote:
> > Also, you could then simplify all the instances of
> > (hibernation_mode == HIBERNATION_PLATFORM && hibernation_ops)
> > to just
> > (hibernation_mode == HIBERNATION_PLATFORM)
> > in various if statements and other places.
>
> N
On Tue, 2007-04-10 at 18:20 +0530, Srinivasa Ds wrote:
> Below patch fixes this problem. please let me know comments on this.
+#include
Yeah, I heard about that change but didn't have a chance to check it out
yet. Patch looks good to me, of course.
johannes
signature.asc
Description: This i
On Tue, 2007-04-24 at 23:24 +0200, Pavel Machek wrote:
> I believe uswsusp user/kernel separation is clean enough. Kernel
> provides "snapshot image" and "resume image". (Thanks go to Rafael for
> very clean interface).
The interface isn't even 64/32-bit compatible...
johannes
signature.asc
De
On Thu, 2007-04-26 at 12:30 +0200, Pavel Machek wrote:
> On Thu 2007-04-26 12:17:12, Johannes Berg wrote:
> > On Tue, 2007-04-24 at 23:24 +0200, Pavel Machek wrote:
> >
> > > I believe uswsusp user/kernel separation is clean enough. Kernel
> > > provides &
On Wed, 2007-04-25 at 15:55 -0700, Linus Torvalds wrote:
> That's where I started: whole "suspend to disk" thing actually has _more_
> to do with "shutdown" than with "suspend".
From looking at pm_ops which I was recently working with a lot, it seems
that it was designed by somebody who was rea
On Thu, 2007-04-26 at 12:40 +0200, Pavel Machek wrote:
> Does this seem to help?
No idea, I haven't actually tried it yet, last time I tried uswsusp on
my 32/32 machine it didn't work due to endian problems that were
supposed to be resolved but I haven't had a chance to pick all the bits
together
On Thu, 2007-04-26 at 13:16 +0200, Pavel Machek wrote:
> This one should prevent ioctl numbers changing, too.
> -#define SNAPSHOT_ATOMIC_SNAPSHOT _IOW(SNAPSHOT_IOC_MAGIC, 3, void *)
> +#define SNAPSHOT_ATOMIC_SNAPSHOT _IOW(SNAPSHOT_IOC_MAGIC, 3, u32) /*
> void * */
Afaict that'll actual
On Thu, 2007-04-26 at 13:26 +0200, Pavel Machek wrote:
> Yes, probably will. The other option is to break existing 32-bit
> userspace, which is a bit more common AFAICT.
Judging from experience with the wext 32/64 bit fiasco it seems to be
rather uncommon to use 32-bit userspace on 64-bit machine
On Thu, 2007-04-26 at 13:30 +0200, Pavel Machek wrote:
> That code goes back to Patrick, AFAICT. (And yes, ACPI S3 and ACPI S4
> low-level enter is pretty similar).
But that doesn't excuse abusing the same interface, IMHO.
> Patches would be welcome
:) I'll see what I can do. Shouldn't be too h
By the way.
> diff --git a/kernel/power/power.h b/kernel/power/power.h
> index eb461b8..dc13af5 100644
> --- a/kernel/power/power.h
> +++ b/kernel/power/power.h
Don't these definitions need to be exported to userspace? That
definitely is not a header file for userspac
On Thu, 2007-04-26 at 13:30 +0200, Pavel Machek wrote:
> > From looking at pm_ops which I was recently working with a lot, it seems
> > that it was designed by somebody who was reading the ACPI documentation
> > and was otherwise pretty clueless, even at that level std tries to look
> > like suspe
On Thu, 2007-04-26 at 10:14 -0600, Chris Friesen wrote:
> Johannes Berg wrote:
>
> > Judging from experience with the wext 32/64 bit fiasco it seems to be
> > rather uncommon to use 32-bit userspace on 64-bit machines.
>
> I disagree...it's quite common. I think
On Thu, 2007-04-26 at 20:40 +0200, Rafael J. Wysocki wrote:
> > * it surfaces kernel implementation details about pm_ops and thus makes
> >the whole thing very fragile
>
> Can you elaborate?
Well it tells userspace about pm_ops->enter/prepare/finish etc.
Also, it seems that it needs a "rele
On Thu, 2007-04-26 at 21:02 +0200, Rafael J. Wysocki wrote:
> Yes. That's because we want to be able to repeat creating the image
> without closing the fd in some situations.
Oh yeah, I just checked and it's not in fact necessary. I'm just
confused.
> Still, we could use a global var 'platform_
On Fri, 2007-04-27 at 11:41 +0200, Johannes Berg wrote:
> No, because acpi doesn't know at build time whether it can actually do
> S4 or not.
Actually, you could probably do it by making some weak symbol for it
that only ACPI overrides, and then check in the ACPI code if S4
On Fri, 2007-04-27 at 12:18 +0200, Rafael J. Wysocki wrote:
> 1) We define platform_hibernation if CONFIG_ACPI is set.
Let's just define it always then in the common code so we don't have
even more magic bits platforms need to define even if they don't care at
all. And please don't put #ifdef CON
On Wed, 2007-04-25 at 22:31 +0200, Pavel Machek wrote:
> > So, the "suspend" and "resume" for the functions being called for that are
> > wrong, but then we call them with PMSG_FREEZE. ;-) Still, we could add
> > .freeze() and .thaw() callbacks for hibernation just fine. This wouldn't
> > even
On Fri, 2007-04-27 at 14:09 +0200, Rafael J. Wysocki wrote:
> Yes. Still, I'd like to rework your patch to deal with ACPI without
> introducing hibernate_ops . I'm going to do this later today if you don't
> mind. :-)
Not at all :) That's why I actually sent it out instead of just saying
"well
On Fri, 2007-04-27 at 14:40 +0200, Pavel Machek wrote:
> > Five callbacks are fine by me, especially if we can define reasonable
> > defaults
> > for the hibernation (and can we?).
>
> Well, we still can default to suspend(PMSG_FREEZE) for freeze(), and
> resume() for thaw(). Anything else is ju
On Fri, 2007-04-27 at 10:34 -0400, Alan Stern wrote:
> For the sake of argument, let's call the stages of STD and STR by these
> names (also noted are the current PSMG values):
>
> Suspend to disk:
> "prepare to create snapshot" (= FREEZE)
> "continue after snapshot" (= RESUME)
On Fri, 2007-04-27 at 16:39 +0200, Johannes Berg wrote:
> Good point. Though if we go for passing the interrupt-enable setting as
> an argument then many drivers will have the same
> "if (irqs_disabled()) return" code. Hm. I guess passing it isn't even
> strictly
On Fri, 2007-04-27 at 17:12 +0200, Rafael J. Wysocki wrote:
> How do we differentiate between post_snapshot() and post_restore()?
> I mean, after the restore we're entering the same code path as after the
> snapshot, so do we use a global var for this purpose?
That's pretty easy to do though, we
On Fri, 2007-04-27 at 17:20 +0200, Rafael J. Wysocki wrote:
> I think we can use 'stages' and pass them as arguments to the functions.
>
> In that case we can have two callbacks for the hibernation (I'd prefer to say
> 'hibernation' instead of 'suspend to disk' from now on), one 'quiesce'
> call
[adding linux-wireless to CC]
On Sun, 2007-03-04 at 16:08 -0600, Matt Mackall wrote:
> Recent kernels are having troubles with wireless for me. Two seemingly
> related problems:
I don't think they are related actually.
> a) NetworkManager seems oblivious to the existence of my IPW2200
This is d
On Sun, 2007-03-04 at 17:17 -0800, Greg KH wrote:
> > > This is due to the recent sysfs restructuring I think. IIRC the fix is
> > > to upgrade hal to a current git version.
> >
> > If that's the cause, the fix is to back out whatever was done to break
> > userspace. Breaking userspace is not ok.
On Tue, 2007-02-27 at 22:51 +0100, Rafael J. Wysocki wrote:
> For 2.6.21-rc1 I've invented the appended workaround (works for me, waiting
> for
> Johannes to confirm it works for him too), but I think we need something
> better
> for -mm and future kernels.
Finally I could get back to this but
roah-Hartman <[EMAIL PROTECTED]> (?)
> > commit 43cb76d91ee85f579a69d42bc8efc08bac560278 (?)
> > Handled-By : Johannes Berg <[EMAIL PROTECTED]>
> > Status : unknown
>
> I really think this is a CONFIG_SYSFS_DEPRECATED issue (not being set),
> but want to get Ma
On Mon, 2007-03-05 at 07:59 -0500, Theodore Tso wrote:
> (depending on whether we want to accomodate Debian's glacial
> release schedule).
I don't think Debian updates the kernel to some actual newer version
either.
johannes
signature.asc
Description: This is a digitally signed message part
On Mon, 2007-03-05 at 17:56 -0800, Greg KH wrote:
> Theory F: It broke because you are using NetworkManager for your
> network devices and the patches that fix this have not made it into a
> real release?
>
> I'm just guessing, but does anyone who is having this problem, NOT using
> NetworkManag
On Tue, 2007-03-06 at 21:31 +0100, Rafael J. Wysocki wrote:
> For now, we have decided to make the workqueues nonfreezable (the patch for
> that has already been merged, AFAICT).
It isn't in 2.6.21-rc3.
> > I wanted to adapt the BUG_ON(block IO not from suspend code)
> > patch from suspend2 but
ow is a copy.
If you want to put it anywhere here's my
Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
---
net/mac80211/debugfs.c | 20 ++--
net/mac80211/debugfs_sta.c |4
net/mac80211/ieee80211_i.h |4 ++--
net/mac80211/sta_info.h|2 ++
4 files
Jan,
Thanks for doing this.
> --- linux-2.6.21-mm_20070428.orig/sound/aoa/Kconfig
> +++ linux-2.6.21-mm_20070428/sound/aoa/Kconfig
> @@ -1,9 +1,12 @@
[...]
For the aoa bits this ends up having two "Apple Onboard Audio driver"
bits which is a bit confusing. How about this instead? SND_AOA was
pre
> For the aoa bits this ends up having two "Apple Onboard Audio driver"
> bits which is a bit confusing. How about this instead?
I can of course do that on top of your change instead if that's easier
to handle.
johannes
signature.asc
Description: This is a digitally signed message part
On Mon, 2007-04-30 at 16:45 +0200, Jan Engelhardt wrote:
> >+config SND_AOA_CORE
> >+tristate
>
> Why the extra AOA_CORE? Are there some options that require only AOA
> but not AOA_CORE?
Oh, I did the extra AOA_CORE so that AOA doesn't affect the build at all
and because it's useless to buil
useful if we ever write a
modem driver, but that's probably not going to happen.)
So for the aoa part:
Acked-by: Johannes Berg <[EMAIL PROTECTED]>
johannes
signature.asc
Description: This is a digitally signed message part
On Mon, 2016-06-13 at 23:21 +0200, Pavel Machek wrote:
>
> (Actually, "::wifi" is super confusing, I'd expect that to be a led
> that blinks when wifi is active.)
Agree with that, yeah, that'd be confusing.
> Well... "airplane" is quite confusing. I'd we use "rfkill" for
> disabling radios, and
On Wed, 2016-07-13 at 10:11 +, Machani, Yaniv wrote:
> On Wed, Jun 29, 2016 at 10:14:19, Johannes Berg wrote:
> > Cc: Hahn, Maital
> > Subject: Re: [PATCH 1/4] mac80211: mesh: flush stations before
> > beacons
> > are stopped
> >
> > On Tue, 2016-06
On Wed, 2016-07-13 at 14:44 +0300, Yaniv Machani wrote:
> From: Maital Hahn
>
> Some drivers (e.g. wl18xx) expect that the last stage in the
> de-initialization process will be stopping the beacons, similar to AP
> flow.
> Update ieee80211_stop_mesh() flow accordingly.
> As peers can be removed d
On Fri, 2016-07-22 at 14:26 +0900, Masashi Honma wrote:
> On 2016年07月14日 05:07, Yaniv Machani wrote:
> > +
> > + /* if channel width is 20MHz - configure HT capab
> > accordingly*/
> > + if (sdata->vif.bss_conf.chandef.width ==
> > NL80211_CHAN_WIDTH_20) {
> > + cap &= ~IEEE80211_HT_C
On Thu, 2016-08-04 at 14:31 -0700, John Stultz wrote:
> On Thu, Aug 4, 2016 at 5:43 AM, Maxim Altshul
> wrote:
> > - The variable is added to allow the driver an easy access
> > to it's own hw->priv when the op is invoked.
> >
> > - Change wlcore op accordingly.
> >
> > Signed-off-by: Maxim Alts
> - if (of_get_property(pdev->dev.of_node,
> - "little-endian", NULL))
> + if (of_property_read_bool(pdev->dev.of_node, "little-
> endian"))
> priv->is_little_endian = true;
> else
> priv->is_little_endian = false;
>
Perhaps, whil
On Fri, 2016-08-05 at 12:08 +0200, Julia Lawall wrote:
>
> Can I do the same for:
>
> if (of_property_read_bool(np, "phy-clk-valid"))
> pdata->check_phy_clk_valid = 1;
> else
> pdata->check_phy_clk_valid = 0;
>
> The type is not bool, but:
>
> inc
On Thu, 2016-08-04 at 15:43 +0300, Maxim Altshul wrote:
> - The variable is added to allow the driver an easy access
> to it's own hw->priv when the op is invoked.
>
> - Change wlcore op accordingly.
>
I'm applying this now, with a big BUT:
1) your changelog is crap - I've rewritten it to indica
201 - 300 of 1314 matches
Mail list logo
