Re: [PATCH] iio: core: centralize ioctl() calls to the main chardev

2020-11-14 Thread Jonathan Cameron
On Sat, 14 Nov 2020 15:30:23 + Jonathan Cameron wrote: > On Mon, 2 Nov 2020 08:59:57 +0200 > Alexandru Ardelean wrote: > > > On Fri, Sep 25, 2020 at 3:38 PM Jonathan Cameron wrote: > > > > > > On Thu, 24 Sep 2020 11:41:55 +0300 > > > Alexandru

Re: [PATCH] iio: core: centralize ioctl() calls to the main chardev

2020-11-14 Thread Jonathan Cameron
On Mon, 2 Nov 2020 08:59:57 +0200 Alexandru Ardelean wrote: > On Fri, Sep 25, 2020 at 3:38 PM Jonathan Cameron wrote: > > > > On Thu, 24 Sep 2020 11:41:55 +0300 > > Alexandru Ardelean wrote: > > > > > The aim of this is to improve a bit the organizatio

Re: Duplicated ABI entries - Was: Re: [PATCH v2 20/39] docs: ABI: testing: make the files compatible with ReST output

2020-11-14 Thread Jonathan Cameron
On Tue, 10 Nov 2020 08:26:58 +0100 Mauro Carvalho Chehab wrote: > Hi Jonathan, > > Em Sun, 8 Nov 2020 16:56:21 + > Jonathan Cameron escreveu: > > > > PS.: the IIO subsystem is the one that currently has more duplicated > > > ABI entries: > > >

Re: [PATCH v4 08/13] Documentation: ABI: add specific icm42600 documentation

2020-11-14 Thread Jonathan Cameron
On Mon, 22 Jun 2020 17:37:24 +0200 Jean-Baptiste Maneyrol wrote: > Hardware offset available as calibscale sysfs attributes are real > physical values exprimed in SI units. > > calibscale_available sysfs attributes represents the range of > acceptable values. > > Signed-off-by: Jean-Baptiste Ma

Re: [RFC PATCH 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

2020-11-13 Thread Jonathan Cameron
ocumentation/devicetree/bindings/iio/multiplexer/io-channel-mux.txt > F: drivers/iio/multiplexer/iio-mux.c > > +IIO SCMI BASED DRIVER > +M: Jyoti Bhayana > +L: linux-...@vger.kernel.org > +S: Maintained > +F: drivers/iio/scmi/scmi_iio.c > + > IIO SUBSYSTEM AND

Re: [RFC PATCH 1/4] ACPI: PPTT: Fix for a high level cache node detected in the low level

2020-11-09 Thread Jonathan Cameron
On Fri, 6 Nov 2020 19:33:45 + James Morse wrote: > Hi Shiju, Jonathan, > > On 05/11/2020 17:42, Shiju Jose wrote: > > From: Jonathan Cameron > > > > According to the following sections of the PPTT definition in the > > ACPI specification(V6.3), a high

Re: [PATCH v2 0/4] iio: adc: xilinx: use even more devres

2020-11-08 Thread Jonathan Cameron
On Mon, 2 Nov 2020 15:22:24 +0100 Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This is a follow-up to commit 750628c79bb1 ("iio: adc: xilinx-xadc: use > devm_krealloc()"). I noticed we can use even more devres helpers and entirely > drop the remove() callback. Given the generic n

Re: [PATCH v2 4/4] iio: adc: xilinx: use more devres helpers and remove remove()

2020-11-08 Thread Jonathan Cameron
On Mon, 2 Nov 2020 15:22:28 +0100 Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > In order to simplify resource management and error paths in probe() and > entirely drop the remove() callback - use devres helpers wherever > possible. Define devm actions for cancelling the delayed wo

Re: [PATCH v2 20/39] docs: ABI: testing: make the files compatible with ReST output

2020-11-08 Thread Jonathan Cameron
On Mon, 2 Nov 2020 15:42:50 +0100 Mauro Carvalho Chehab wrote: > Em Mon, 2 Nov 2020 13:46:41 +0100 > Greg Kroah-Hartman escreveu: > > > On Mon, Nov 02, 2020 at 12:04:36PM +0100, Fabrice Gasnier wrote: > > > On 10/30/20 11:09 AM, Mauro Carvalho Chehab wrote: > > > > Em Fri, 30 Oct 2020 10:

Re: [PATCH v7 0/3] iio: adc: mt6360: Add ADC driver for MT6360

2020-11-08 Thread Jonathan Cameron
On Sun, 1 Nov 2020 15:40:19 + Jonathan Cameron wrote: > On Tue, 20 Oct 2020 16:07:44 +0800 > Gene Chen wrote: > > > In-Reply-To: > > > > This patch series add MT6360 ADC support contains driver, testing document > > and binding document > > >

Re: [PATCH v7 1/5] iio: core: Add optional symbolic label to a device channel

2020-11-08 Thread Jonathan Cameron
On Sun, 1 Nov 2020 15:38:03 + Jonathan Cameron wrote: > On Mon, 28 Sep 2020 12:09:55 +0300 > Cristian Pop wrote: > > > If a label is defined in the device tree for this channel add that > > to the channel specific attributes. This is useful for userspace to >

Re: [PATCH] iio: light: fix kconfig dependency bug for VCNL4035

2020-11-08 Thread Jonathan Cameron
On Tue, 3 Nov 2020 01:35:24 +0300 Necip Fazil Yildiran wrote: > When VCNL4035 is enabled and IIO_BUFFER is disabled, it results in the > following Kbuild warning: > > WARNING: unmet direct dependencies detected for IIO_TRIGGERED_BUFFER > Depends on [n]: IIO [=y] && IIO_BUFFER [=n] > Selecte

Re: [PATCH v2] iio: adc: rockchip_saradc: fix missing clk_disable_unprepare() on error in rockchip_saradc_resume

2020-11-08 Thread Jonathan Cameron
On Tue, 3 Nov 2020 20:07:43 +0800 Qinglang Miao wrote: > Fix the missing clk_disable_unprepare() of info->pclk > before return from rockchip_saradc_resume in the error > handling case when fails to prepare and enable info->clk. > > Fixes: 44d6f2ef94f9 ("iio: adc: add driver for Rockchip saradc")

Re: [PATCH] iio/adc: ingenic: Fix AUX/VBAT readings when touchscreen is used

2020-11-08 Thread Jonathan Cameron
On Wed, 04 Nov 2020 23:25:12 +0100 Artur Rojek wrote: > Hi Paul, > > On 2020-11-03 21:12, Paul Cercueil wrote: > > When the command feature of the ADC is used, it is possible to program > > the ADC, and specify at each step what input should be processed, and > > in > > comparison to what refer

Re: [PATCH] iio/adc: ingenic: Fix battery VREF for JZ4770 SoC

2020-11-08 Thread Jonathan Cameron
On Thu, 05 Nov 2020 01:27:51 +0100 Artur Rojek wrote: > On 2020-11-05 01:09, Paul Cercueil wrote: > > Hi Artur, > > > > Le mer. 4 nov. 2020 à 23:29, Artur Rojek a > > écrit : > >> Hi Paul, > >> > >> On 2020-11-04 20:28, Paul Cercueil wrote: > >>> The reference voltage for the battery is c

Re: [PATCH] iio: adc: stm32-adc: dma transfers cleanup

2020-11-08 Thread Jonathan Cameron
On Thu, 5 Nov 2020 18:38:27 +0100 Fabrice Gasnier wrote: > On 11/5/20 3:29 PM, Olivier Moysan wrote: > > - Remove processing related to DMA in irq handler as this > > data transfer is managed directly in DMA callback. > > - Update comment in stm32_adc_set_watermark() function. > > > > Signed-off

Re: [PATCH v7 5/5] dt-bindings:iio:adc:adc.txt: Add documentation for channel label attribute

2020-11-08 Thread Jonathan Cameron
On Thu, 5 Nov 2020 11:37:18 -0600 Rob Herring wrote: > On Mon, 02 Nov 2020 16:20:00 +0200, Cristian Pop wrote: > > Optional attribute for better identification of the channels. > > > > Signed-off-by: Cristian Pop > > --- > > Changes in v7: > > - Add this extra commit > > Documentation/devicet

Re: [PATCH] iio: adc: stm32-adc: adapt clock duty cycle for proper operation

2020-11-08 Thread Jonathan Cameron
On Fri, 6 Nov 2020 17:57:26 +0100 Fabrice Gasnier wrote: > For proper operation, STM32 ADC should be used with a clock duty cycle > of 50%, in the range of 49% to 51%. Depending on the clock tree, divider > can be used in case clock duty cycle is out of this range. > In case clk_get_scaled_duty_c

Re: [PATCH] docs: ABI: testing: iio: stm32: remove re-introduced unsupported ABI

2020-11-08 Thread Jonathan Cameron
ally applied given I thought we'd flagged up those chunks in the patch as needing fixing. Acked-by: Jonathan Cameron > --- > .../ABI/testing/sysfs-bus-iio-timer-stm32 | 24 > -- > 1 file changed, 24 deletions(-) > > diff --git a/Documentation

Re: [PATCH] MAINTAINERS: Fix 'W:' prefix in Invensense IMU entry

2020-11-08 Thread Jonathan Cameron
On Sun, 8 Nov 2020 02:37:38 +0100 Jonathan Neuschäfer wrote: > The colon is missing, which can confuse scripts/parse-maintainers.pl. > > Signed-off-by: Jonathan Neuschäfer Applied. Thanks, Jonathan > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] Input: touchscreen: fix kconfig dependency bug for TOUCHSCREEN_ADC

2020-11-03 Thread Jonathan Cameron
istive ADC touchscreen") > Link: https://bugzilla.kernel.org/show_bug.cgi?id=209881 > Signed-off-by: Necip Fazil Yildiran Acked-by: Jonathan Cameron > --- > drivers/input/touchscreen/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/inp

Re: [RESEND PATCH v2] MAINTAINERS: add Dan Murphy as TP LP8xxx drivers maintainer

2020-11-02 Thread Jonathan Cameron
t driver, > - TI LP8727 charger driver, > - TI LP8788 MFD (ADC, LEDs, charger and regulator) drivers. > > Signed-off-by: Krzysztof Kozlowski > Cc: Dan Murphy > Acked-by: Dan Murphy > Acked-by: Jonathan Cameron > Acked-by: Sebastian Reichel Typo in pat

Re: [PATCH 01/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP

2020-11-01 Thread Jonathan Cameron
On Sun, 1 Nov 2020 06:47:35 +0800 Coiby Xu wrote: > On Sat, Oct 31, 2020 at 11:05:11AM +0000, Jonathan Cameron wrote: > >On Fri, 30 Oct 2020 22:34:10 +0800 > >Coiby Xu wrote: > > > >> On Thu, Oct 29, 2020 at 07:06:40PM +0200, Andy Shevchenko wrote: > &g

Re: [PATCH v2] counter/ti-eqep: Fix regmap max_register

2020-11-01 Thread Jonathan Cameron
On Sun, 25 Oct 2020 11:51:22 -0500 David Lechner wrote: > The values given were the offset of the register after the last > register instead of the actual last register in each range. Fix > by using the correct last register of each range. > > Fixes: f213729f6796 ("counter: new TI eQEP driver")

Re: [PATCH 1/1] iio: adc: stm32-adc: fix a regression when using dma and irq

2020-11-01 Thread Jonathan Cameron
On Wed, 21 Oct 2020 10:53:13 +0200 Olivier Moysan wrote: > Since overrun interrupt support has been added, there's a regression when > two ADCs are used at the same time, with: > - an ADC configured to use IRQs. EOCIE bit is set. The handler is normally > called in this case. > - an ADC configu

Re: [PATCH v7 0/3] iio: adc: mt6360: Add ADC driver for MT6360

2020-11-01 Thread Jonathan Cameron
On Tue, 20 Oct 2020 16:07:44 +0800 Gene Chen wrote: > In-Reply-To: > > This patch series add MT6360 ADC support contains driver, testing document > and binding document > Hi Gene, Other than that small edit needed in the dt binding this is stalled on the label code getting upstreamed into the

Re: [PATCH v7 1/5] iio: core: Add optional symbolic label to a device channel

2020-11-01 Thread Jonathan Cameron
On Mon, 28 Sep 2020 12:09:55 +0300 Cristian Pop wrote: > If a label is defined in the device tree for this channel add that > to the channel specific attributes. This is useful for userspace to > be able to identify an individual channel. > > Signed-off-by: Cristian Pop Hi Cristian, I think t

Re: [PATCH v7 1/3] dt-bindings: iio: adc: add bindings doc for MT6360 ADC

2020-11-01 Thread Jonathan Cameron
On Tue, 20 Oct 2020 16:07:45 +0800 Gene Chen wrote: > From: Gene Chen > > This change adds the binding doc for the MT6360 ADC. One thing I'd previously missed below. Jonathan > > Signed-off-by: Gene Chen > --- > .../bindings/iio/adc/mediatek,mt6360-adc.yaml | 34 > ++

Re: [PATCH] iio: remove unneeded break

2020-11-01 Thread Jonathan Cameron
On Tue, 20 Oct 2020 21:39:17 +0200 Martin Blumenstingl wrote: > On Mon, Oct 19, 2020 at 7:28 PM wrote: > > > > From: Tom Rix > > > > A break is not needed if it is preceded by a return > > > > Signed-off-by: Tom Rix > > --- > > drivers/iio/adc/meson_saradc.c | 2 -- > for meson_saradc.

Re: [PATCH v4] iio:light:tsl2563 use generic fw accessors

2020-11-01 Thread Jonathan Cameron
On Mon, 19 Oct 2020 02:05:52 +0530 Vaishnav M A wrote: > Replace of_property_read_u32() with device_property_read_u32(), > when reading the amstaos,cover-comp-gain.This opens up the > possibility of passing the properties during platform instantiation > of the device by a suitable populated struc

Re: [PATCH v4] iio: light: vcnl4035 add i2c_device_id

2020-11-01 Thread Jonathan Cameron
i2c adapter > created by greybus. > > Signed-off-by: Vaishnav M A Applied, Thanks, Jonathan > --- > v4: > -update commit message, add punctuation. > v3: > -modify commit message for readability > as suggested by Jonathan Cameron > v2: >

Re: [PATCH v4] iio: proximity: vl53l0x-i2c add i2c_device_id

2020-11-01 Thread Jonathan Cameron
ion > v3: > -modify commit message for readability >as suggested by Jonathan Cameron > v2: > -fix commit message > drivers/iio/proximity/vl53l0x-i2c.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/iio/proximity/vl53l0x-i2c.c

Re: [PATCH v3] iio: adc: mediatek: fix unset field

2020-11-01 Thread Jonathan Cameron
On Sun, 18 Oct 2020 21:46:44 +0200 Fabien Parent wrote: > dev_comp field is used in a couple of places but it is never set. This > results in kernel oops when dereferencing a NULL pointer. Set the > `dev_comp` field correctly in the probe function. > > Fixes: 6d97024dce23 ("iio: adc: mediatek: m

Re: [PATCH v3] iio: light: tsl2563 change of_property_read to device_property_read

2020-11-01 Thread Jonathan Cameron
On Sun, 18 Oct 2020 20:13:38 +0530 Vaishnav M A wrote: > Replace of_property_read_u32() with device_property_read_u32, > when reading the amstaos,cover-comp-gain.This opens up the > possibility of passing the properties during platform instantiation > of the device by a suitable populated struct

Re: [PATCH] iio: magnetometer: bmc150: remove unneeded semicolon

2020-11-01 Thread Jonathan Cameron
On Sat, 31 Oct 2020 06:43:19 -0700 t...@redhat.com wrote: > From: Tom Rix > > A semicolon is not needed after a switch statement. > > Signed-off-by: Tom Rix Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to poke at it. Thanks, Jonathan > --- > driver

Re: [PATCH] iio: pressure: bmp280: remove unneeded semicolon

2020-11-01 Thread Jonathan Cameron
On Sat, 31 Oct 2020 06:45:06 -0700 t...@redhat.com wrote: > From: Tom Rix > > A semicolon is not needed after a switch statement. > > Signed-off-by: Tom Rix Applied, Thanks, Jonathan > --- > drivers/iio/pressure/bmp280-regmap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [PATCH 4/5] iio: adc: xilinx: use devres for irq handling

2020-10-31 Thread Jonathan Cameron
On Fri, 30 Oct 2020 11:52:00 +0100 Bartosz Golaszewski wrote: > On Thu, Oct 29, 2020 at 4:41 PM Jonathan Cameron wrote: > > > > On Mon, 26 Oct 2020 14:36:08 +0100 > > Bartosz Golaszewski wrote: > > > > > From: Bartosz Golaszewski > > > > >

Re: [PATCH 01/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP

2020-10-31 Thread Jonathan Cameron
On Fri, 30 Oct 2020 22:34:10 +0800 Coiby Xu wrote: > On Thu, Oct 29, 2020 at 07:06:40PM +0200, Andy Shevchenko wrote: > >On Thu, Oct 29, 2020 at 4:42 PM Jonathan Cameron wrote: > >> On Thu, 29 Oct 2020 15:48:56 +0800 > >> Coiby Xu wrote: > > > >&

Re: [PATCH 4/5] iio: adc: xilinx: use devres for irq handling

2020-10-29 Thread Jonathan Cameron
On Mon, 26 Oct 2020 14:36:08 +0100 Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Further simplify the remove() callback and error paths in probe() by > using the managed variant of request_irq() as well as using a devm action > for cancelling the delayed work at driver detach. > >

Re: [PATCH v3 45/56] iio: fix a kernel-doc markup

2020-10-29 Thread Jonathan Cameron
On Fri, 23 Oct 2020 18:33:32 +0200 Mauro Carvalho Chehab wrote: > A function has a different name between their prototype > and its kernel-doc markup. > > Signed-off-by: Mauro Carvalho Chehab Applied to the togreg branch of iio.git. Thanks, Jonathan > --- > include/linux/iio/trigger.h | 2

Re: [PATCH 3/5] iio: adc: xilinx: use a devres action to disable and unprepare the clock

2020-10-29 Thread Jonathan Cameron
On Mon, 26 Oct 2020 14:36:07 +0100 Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > In order to simplify resource management and error paths in probe(), add > a devm action that calls clk_disable_unprepare() at driver detach. > > Signed-off-by: Bartosz Golaszewski > --- > drivers/i

Re: [PATCH] iio: adc: at91-sama5d2_adc: remove unneeded semicolon

2020-10-29 Thread Jonathan Cameron
On Tue, 27 Oct 2020 13:08:53 -0700 t...@redhat.com wrote: > From: Tom Rix > > A semicolon is not needed after a switch statement. > > Signed-off-by: Tom Rix Applied. Thanks, > --- > drivers/iio/adc/at91-sama5d2_adc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/d

Re: [PATCH] iio/adc: ingenic: remove unneeded semicolon

2020-10-29 Thread Jonathan Cameron
On Tue, 27 Oct 2020 13:11:28 -0700 t...@redhat.com wrote: > From: Tom Rix > > A semicolon is not needed after a switch statement. > > Signed-off-by: Tom Rix Hi Tom, Ideally this set of similar patches in one subsystem would have been as a series. Makes it easier to pick up with b4 and I'm la

Re: [PATCH] iio: light: apds9960: remove unneeded semicolon

2020-10-29 Thread Jonathan Cameron
On Tue, 27 Oct 2020 21:36:17 -0700 Matt Ranostay wrote: > On Tue, Oct 27, 2020 at 1:14 PM wrote: > > > > From: Tom Rix > > > > A semicolon is not needed after a switch statement. > > > > Acked-by: Matt Ranostay Applied to the togreg branch of iio.git. I'll push that out later as testing for

Re: [PATCH 20/33] docs: ABI: testing: make the files compatible with ReST output

2020-10-29 Thread Jonathan Cameron
I'm going to guess a rebase issue? Other than that Acked-by: Jonathan Cameron # for IIO > diff --git a/Documentation/ABI/testing/sysfs-bus-iio-timer-stm32 > b/Documentation/ABI/testing/sysfs-bus-iio-timer-stm32 > index b7259234ad70..a10a4de3e5fe 100644 > --- a/Documentation

Re: [PATCH 01/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP

2020-10-29 Thread Jonathan Cameron
On Thu, 29 Oct 2020 15:48:56 +0800 Coiby Xu wrote: > SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG. > > Signed-off-by: Coiby Xu Hi Coiby, Please put a cover letter on your next series explaining the context. In this particular case some of the replies you have gotten are ge

Re: [PATCH] dt-bindings: More whitespace clean-ups in schema files

2020-10-24 Thread Jonathan Cameron
ect.org > Cc: linux-...@vger.kernel.org > Cc: linux-...@lists.infradead.org > Cc: linux-ser...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Rob Herring Acked-by: Jonathan Cameron #for-iio > --- > .../display/bridge/toshiba,tc358775.yaml | 18

Re: [PATCH] arm64: NUMA: Kconfig: Increase max number of nodes

2020-10-21 Thread Jonathan Cameron
On Wed, 21 Oct 2020 09:43:21 +0530 Anshuman Khandual wrote: > On 10/20/2020 11:39 PM, Valentin Schneider wrote: > > > > Hi, > > > > Nit on the subject: this only increases the default, the max is still 2¹⁰. > > Agreed. > > > > > On 20/10/20 18:34, Vanshidhar Konda wrote: > >> The current

Re: [PATCH v9 12/15] PCI/RCEC: Add RCiEP's linked RCEC to AER/ERR

2020-10-20 Thread Jonathan Cameron
lley wrote: > >>>>>> From: Qiuxu Zhuo > >>>>>> > >>>>>> When attempting error recovery for an RCiEP associated with an > >>>>>> RCEC device, > >>>>>> there needs to be a w

Re: [RFC PATCH] topology: Represent clusters of CPUs within a die.

2020-10-19 Thread Jonathan Cameron
On Mon, 19 Oct 2020 16:51:06 +0100 Valentin Schneider wrote: > On 19/10/20 15:27, Jonathan Cameron wrote: > > On Mon, 19 Oct 2020 14:48:02 +0100 > > Valentin Schneider wrote: > >> > >> That's my queue to paste some of that stuff I've been rambling on

Re: [RFC PATCH] topology: Represent clusters of CPUs within a die.

2020-10-19 Thread Jonathan Cameron
On Mon, 19 Oct 2020 16:16:53 +0200 Morten Rasmussen wrote: > On Mon, Oct 19, 2020 at 02:41:57PM +0100, Jonathan Cameron wrote: > > On Mon, 19 Oct 2020 15:10:52 +0200 > > Morten Rasmussen wrote: > > > > > Hi Jonathan, > > > > > > On Mon, Oc

Re: [RFC PATCH] topology: Represent clusters of CPUs within a die.

2020-10-19 Thread Jonathan Cameron
On Mon, 19 Oct 2020 14:48:02 +0100 Valentin Schneider wrote: > +Cc Jeremy > > On 19/10/20 14:10, Morten Rasmussen wrote: > > Hi Jonathan, > > The problem I see is that the benefit of keeping tasks together due to > > the interconnect layout might vary significantly between systems. So if > > we

Re: [RFC PATCH] topology: Represent clusters of CPUs within a die.

2020-10-19 Thread Jonathan Cameron
On Mon, 19 Oct 2020 15:10:52 +0200 Morten Rasmussen wrote: > Hi Jonathan, > > On Mon, Oct 19, 2020 at 01:32:26PM +0100, Jonathan Cameron wrote: > > On Mon, 19 Oct 2020 12:35:22 +0200 > > Peter Zijlstra wrote: > > > > > On Fri, Oct 16, 2020 at 11:2

Re: [RFC PATCH] topology: Represent clusters of CPUs within a die.

2020-10-19 Thread Jonathan Cameron
On Mon, 19 Oct 2020 11:01:00 +0100 Sudeep Holla wrote: > +Morten Hi Sudeep, > > On Fri, Oct 16, 2020 at 11:27:02PM +0800, Jonathan Cameron wrote: > > Both ACPI and DT provide the ability to describe additional layers of > > topology between that of individual cores and hi

Re: [RFC PATCH] topology: Represent clusters of CPUs within a die.

2020-10-19 Thread Jonathan Cameron
On Mon, 19 Oct 2020 12:00:15 +0200 Brice Goglin wrote: > Le 16/10/2020 à 17:27, Jonathan Cameron a écrit : > > Both ACPI and DT provide the ability to describe additional layers of > > topology between that of individual cores and higher level constructs > > such as the le

Re: [RFC PATCH] topology: Represent clusters of CPUs within a die.

2020-10-19 Thread Jonathan Cameron
On Mon, 19 Oct 2020 12:35:22 +0200 Peter Zijlstra wrote: > On Fri, Oct 16, 2020 at 11:27:02PM +0800, Jonathan Cameron wrote: > > Both ACPI and DT provide the ability to describe additional layers of > > topology between that of individual cores and higher level constructs > &

Re: [RFC PATCH] topology: Represent clusters of CPUs within a die.

2020-10-19 Thread Jonathan Cameron
On Sat, 17 Oct 2020 08:44:25 +0200 Greg Kroah-Hartman wrote: > On Fri, Oct 16, 2020 at 11:27:02PM +0800, Jonathan Cameron wrote: > > Both ACPI and DT provide the ability to describe additional layers of > > topology between that of individual cores and higher level constructs

Re: [PATCH] counter/ti-eqep: Fix regmap max_register

2020-10-18 Thread Jonathan Cameron
On Fri, 16 Oct 2020 14:58:37 -0500 David Lechner wrote: > The values given were the offset of the register after the last > register instead of the actual last register in each range. Fix > by using the correct last register of each range. > > Signed-off-by: David Lechner Fixes tag please. Th

Re: [PATCH v2] iio: light: vcnl4035 add i2c_device_id

2020-10-18 Thread Jonathan Cameron
On Sun, 18 Oct 2020 09:06:02 +0530 Vaishnav M A wrote: > add i2c_device_id for the vcnl4035 driver so that > the device can be instantiated using i2c_new_client_device > or from userspace, useful in cases where device tree based > description is not possible now(Eg. a device on a gbphy i2c > adap

Re: [PATCH v2] iio: light: tsl2563 change of_property_read to device_property_read

2020-10-18 Thread Jonathan Cameron
On Sun, 18 Oct 2020 08:55:43 +0530 Vaishnav M A wrote: > replace the of_property_read_u32 for reading the amstaos,cover-comp-gain > property with device_property_read_u32,allows the driver to > get the properties information using the more generic device_property_* > helpers and opens the possibi

Re: [PATCH v2] iio: proximity: vl53l0x-i2c add i2c_device_id

2020-10-18 Thread Jonathan Cameron
On Sun, 18 Oct 2020 09:01:42 +0530 Vaishnav M A wrote: > add i2c_device_id for the vl53l0x-i2c driver so > that the device can be instantiated using i2c_new_client_device > or from userspace, useful in cases where device tree based description > is not possible now(Eg. a device on a gbphy i2c > a

Re: [PATCH v2] iio: light: tsl2563 change of_property_read to device_property_read

2020-10-18 Thread Jonathan Cameron
On Sun, 18 Oct 2020 08:55:43 +0530 Vaishnav M A wrote: > replace the of_property_read_u32 for reading the amstaos,cover-comp-gain > property with device_property_read_u32,allows the driver to > get the properties information using the more generic device_property_* > helpers and opens the possibi

Re: [PATCH] iio: light: vcnl4035 add i2c_device_id

2020-10-18 Thread Jonathan Cameron
On Sat, 17 Oct 2020 00:14:59 +0530 Vaishnav M A wrote: > This patch aims to add i2c_device_id for the > vcnl4035 driver, while going through the initial driver > submission patches, noticed that the i2c_device_id was removed > on suggestion (https://lore.kernel.org/patchwork/patch/970970/), > wil

Re: [PATCH v2] iio: proximity: as3935 change of_property_read to device_property_read

2020-10-18 Thread Jonathan Cameron
On Sun, 18 Oct 2020 08:47:32 +0530 Vaishnav M A wrote: A very similar change was made recently in 00fa493b9989 ("iio:proximity:as3935: Drop of_match_ptr and use generic fw accessors") https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=00fa493b99894b930e431c05a9dba294c5

Re: [PATCH] iio: light: tsl2563 change of_property_read to device_property_read

2020-10-18 Thread Jonathan Cameron
On Sat, 17 Oct 2020 00:04:27 +0530 Vaishnav M A wrote: > This patch aims to replace the of_property_read_u32 for reading > the amstaos,cover-comp-gain property with device_property_read_u32 > > Thanks and Regards, > Vaishnav M A Should keep this stuff about the --- to just the patch description

Re: [PATCH 3/3] iio: adc: aspeed: Setting ref_voltage in probe

2020-10-18 Thread Jonathan Cameron
On Tue, 13 Oct 2020 18:32:45 +0800 Billy Tsai wrote: > At ast2600 ref_voltage becomes configurable and this property is board > dependency. > > Signed-off-by: Billy Tsai dt-bindings: etc for the patch title. Look at naming of similar patches for a reference. > --- > .../devicetree/bindings

Re: [PATCH 2/3] iio: adc: aspeed: Modify driver for ast2600

2020-10-18 Thread Jonathan Cameron
On Tue, 13 Oct 2020 18:32:44 +0800 Billy Tsai wrote: Hi Billy, > This patch is used to handle the difference between ast2600 > and previous versions. Good to mention what they are. Not all of them are obvious (such as the reset change to being requested as shared). > > Signed-off-by: Billy Tsa

Re: [PATCH 1/3] iio: adc: aspeed: Orgnaize and add the define of adc

2020-10-18 Thread Jonathan Cameron
On Tue, 13 Oct 2020 18:32:43 +0800 Billy Tsai wrote: > This patch organizes the define of adc to multiple partitions > and adds the new bit field define for ast2600 driver. Should be 2 patch patches. If you need to do a reorg, do it first, then add new bits in a second patch. That way we are r

Re: [PATCH 1/2] dt-bindings: iio: adc: auxadc: add doc for MT8516 SoC

2020-10-18 Thread Jonathan Cameron
On Tue, 13 Oct 2020 08:00:25 +0200 Matthias Brugger wrote: > On 12/10/2020 22:52, Fabien Parent wrote: > > Add documentation for the auxadc binding for MT8516 SoC. > > > > Signed-off-by: Fabien Parent > > Reviewed-by: Matthias Brugger Applied to the togreg branch of iio.git and pushed out

Re: [PATCH] iio: adc: mediatek: fix unset field

2020-10-18 Thread Jonathan Cameron
On Tue, 13 Oct 2020 17:37:12 +0200 Matthias Brugger wrote: > On 12/10/2020 21:46, Fabien Parent wrote: > > dev_comp field is used in a couple of places but it is never set. This > > results in kernel oops when dereferencing a NULL pointer. Set the > > `dev_comp` field correctly in the probe funct

Re: [PATCH v2] iio:core: In map_array_register() cleanup in case of error

2020-10-18 Thread Jonathan Cameron
On Fri, 16 Oct 2020 18:09:48 +0300 Andy Shevchenko wrote: > On Sun, Oct 11, 2020 at 9:24 PM Lino Sanfilippo wrote: > > > > In function map_array_register() properly rewind in case of error. > > Furthermore remove the now superfluous initialization of "ret" with 0. > > > int iio_map_array_reg

[RFC PATCH] topology: Represent clusters of CPUs within a die.

2020-10-16 Thread Jonathan Cameron
https://github.com/hisilicon/hwloc/tree/linux-cluster Signed-off-by: Jonathan Cameron --- Documentation/admin-guide/cputopology.rst | 26 -- arch/arm64/kernel/topology.c | 2 + drivers/acpi/pptt.c | 60 +++ drivers/base/arch_topol

Re: [PATCH] iio:core: In map_array_register() cleanup in case of error

2020-10-11 Thread Jonathan Cameron
On Sun, 11 Oct 2020 14:41:20 +0200 Lino Sanfilippo wrote: > In function map_array_register() properly rewind in case of error. > Furthermore save an extra label by using a break instead of goto to leave > the concerning loop. > > Signed-off-by: Lino Sanfilippo Good spot. I'd rather we went wit

Re: [PATCH v3 3/3] dt-bindings: iio: dac: ad5686: add binding

2020-10-10 Thread Jonathan Cameron
On Tue, 29 Sep 2020 13:53:00 -0500 Rob Herring wrote: > On Thu, 24 Sep 2020 14:52:14 -0500, Michael Auchter wrote: > > Add a binding for AD5686 > > > > Signed-off-by: Michael Auchter > > --- > > Changes since v1: > > - Keep supported device sorted > > - fix adc -> dac typo in schema path > > si

Re: [PATCH v4 0/4] iio: adc: at91: misc driver cleanups

2020-10-10 Thread Jonathan Cameron
On Wed, 30 Sep 2020 16:50:44 +0300 Alexandru Ardelean wrote: > This whole thing started because the lkp bot haunted me for a while with > this build warning: > > >> drivers/iio/adc/at91_adc.c:1439:34: warning: unused variable > >> 'at91_adc_dt_ids' [-Wunused-const-variable] >static const s

Re: [PATCH v3] iio: adc: exynos: do not rely on 'users' counter in ISR

2020-10-10 Thread Jonathan Cameron
On Tue, 6 Oct 2020 14:55:09 -0700 dmitry.torok...@gmail.com wrote: > The order in which 'users' counter is decremented vs calling drivers' > close() method is implementation specific, and we should not rely on > it. Let's introduce driver private flag and use it to signal ISR > to exit when device

Re: [PATCH v3 0/6] iio: sx9310: Support setting various settings

2020-10-10 Thread Jonathan Cameron
On Tue, 6 Oct 2020 18:17:29 -0700 Stephen Boyd wrote: > I need to configure various settings such as thresholds, gain factors, > etc. on this device. Some settings matter at boot, while others can wait > for userspace to configure things. This patch series adds support to > set these various bit

Re: [PATCH] iio: dac: ad7303: remove platform data header

2020-10-10 Thread Jonathan Cameron
On Thu, 1 Oct 2020 17:10:04 +0300 Alexandru Ardelean wrote: > The information in the ad7303 platform_data header is unused, so it's dead > code. > This change removes it and it's inclusion from the driver. > > Signed-off-by: Alexandru Ardelean Applied. Thanks, Jonathan > --- > drivers/iio/da

Re: [PATCH] iio: accel: mma8452: Constify static struct attribute_group

2020-10-10 Thread Jonathan Cameron
On Thu, 1 Oct 2020 01:29:39 +0200 Rikard Falkeborn wrote: > The only usage of mma8452_event_attribute_group is to assign its address > to the event_attrs field in the iio_info struct, which is a const > pointer. Make it const to allow the compiler to put it in read-only > memory. This was the on

Re: [PATCH v2] iio: adc: ad7887: invert/rework external ref logic

2020-10-10 Thread Jonathan Cameron
On Fri, 2 Oct 2020 11:27:23 +0300 Alexandru Ardelean wrote: > This change inverts/reworks the logic to use an external reference via a > provided regulator. > > Now the driver tries to obtain a regulator. If one is found, then it is > used. The rest of the driver logic already checks if there is

Re: [PATCH] iio: adc: ad7298: rework external ref setup & remove platform data

2020-10-10 Thread Jonathan Cameron
On Thu, 1 Oct 2020 17:10:48 +0300 Alexandru Ardelean wrote: > This change removes the old platform data for ad7298. It is only used to > provide whether to use an external regulator as a reference. > > So, the logic is inverted a bit. The driver now tries to obtain a > regulator. If one is provi

Re: [LINUX PATCH v3] iio: core: Fix IIO_VAL_FRACTIONAL calculation for negative values

2020-10-10 Thread Jonathan Cameron
On Mon, 5 Oct 2020 08:05:16 -0700 Anand Ashok Dumbre wrote: > Fixes IIO_VAL_FRACTIONAL for case when the result is negative and > exponent is 0. > > example: if the result is -0.75, tmp0 will be 0 and tmp1 = 75 > This causes the output to lose sign because of %d in snprintf > which works for tm

Re: [PATCH v4 4/4] iio: adc: at91_adc: remove platform data and move defs in driver file

2020-10-10 Thread Jonathan Cameron
On Wed, 30 Sep 2020 16:05:55 +0200 Alexandre Belloni wrote: > On 30/09/2020 16:50:48+0300, Alexandru Ardelean wrote: > > The AT91 ADC driver no longer uses the 'at91_add_device_adc' platform data > > type. This is no longer used (at least in mainline boards). > > > > This change removes the plat

Re: [PATCH v6 0/3] iio: adc: mt6360: Add ADC driver for MT6360

2020-10-10 Thread Jonathan Cameron
On Thu, 1 Oct 2020 16:54:05 +0800 Gene Chen wrote: > This patch series add MT6360 ADC support contains driver, testing document > and binding document > > Gene Chen (2) > dt-bindings: iio: adc: add bindings doc for MT6360 ADC > Documentation: ABI: testing: mt6360: Add ADC sysfs guideline >

Re: [PATCH 4/4] dt-bindings: Explicitly allow additional properties in common schemas

2020-10-06 Thread Jonathan Cameron
alProperties. > > Signed-off-by: Rob Herring > Documentation/devicetree/bindings/iio/common.yaml| 2 ++ For IIO Acked-by: Jonathan Cameron > ...

Re: [PATCH 2/4] dt-bindings: Use 'additionalProperties' instead of 'unevaluatedProperties'

2020-10-06 Thread Jonathan Cameron
n a few cases, this means adding some missing property definitions of > which most are for SPI bus properties. 'unevaluatedProperties' is not going > to work for the SPI bus properties anyways as they are evaluated from the > parent node, not the SPI child node. > > Signed-off-

Re: [PATCH v3 14/14] iommu/amd: Adopt IO page table framework

2020-10-05 Thread Jonathan Cameron
On Sun, 4 Oct 2020 01:45:49 + Suravee Suthikulpanit wrote: > Switch to using IO page table framework for AMD IOMMU v1 page table. > > Signed-off-by: Suravee Suthikulpanit One minor thing inline. > --- > drivers/iommu/amd/iommu.c | 26 ++ > 1 file changed, 26 inse

Re: [PATCH] dt-bindings: Another round of adding missing 'additionalProperties'

2020-10-05 Thread Jonathan Cameron
> Cc: Shawn Guo > Cc: Bjorn Andersson > Cc: Baolin Wang > Cc: Guenter Roeck > Cc: Jonathan Cameron > Cc: Mauro Carvalho Chehab > Cc: Laurent Pinchart > Cc: Lee Jones > Cc: Ulf Hansson > Cc: "David S. Miller" > Cc: Bjorn Helgaas > Cc: Vinod Koul &g

Re: [PATCH v7 00/13] Add RCEC handling to PCI/AER

2020-10-01 Thread Jonathan Cameron
you fill in nextbusn = 0xff. > - Remove blank lines in pcie_link_rcec header. > - Fix indentation aer.c. > (Jonathan Cameron) > > - Relocate enabling of PME for RCECs to later RCEC handling additions to PME. > - Rename rcec_ext to rcec_ea. > - Remove rcec_cap as its use c

Re: [PATCH v7 06/13] PCI/ERR: Limit AER resets in pcie_do_recovery()

2020-10-01 Thread Jonathan Cameron
ing non-native use of RCECs > by firmware. So explicitly apply conditional logic > around these resets by limiting them to root ports and > downstream ports. > > Signed-off-by: Sean V Kelley Acked-by: Jonathan Cameron > --- > drivers/pci/pcie/err.c | 9 ++--- > 1

Re: [PATCH v7 05/13] PCI/ERR: Use "bridge" for clarity in pcie_do_recovery()

2020-10-01 Thread Jonathan Cameron
so benefit from some > simplification with use of pci_upstream_bridge() in place of > dev->bus->self. Reverse the pcie_do_recovery() conditional logic > and replace use of "dev" with "bridge" for greater clarity. > > Suggested-by: Bjorn Helgaas > Sig

Re: [PATCH v7 03/13] PCI/RCEC: Cache RCEC capabilities in pci_init_capabilities()

2020-10-01 Thread Jonathan Cameron
rce > reporting. See PCI Express Base Specification, version 5.0-1, > section 7.9.10. > > Suggested-by: Bjorn Helgaas > Co-developed-by: Qiuxu Zhuo > Signed-off-by: Qiuxu Zhuo > Signed-off-by: Sean V Kelley Reviewed-by: Jonathan Cameron > --- > drivers/pci/pci.h

Re: [PATCH v7 04/13] PCI/ERR: Rename reset_link() to reset_subordinate_device()

2020-10-01 Thread Jonathan Cameron
ge with the intent to reset the devices below it. > > Suggested-by: Bjorn Helgaas > Signed-off-by: Sean V Kelley Acked-by: Jonathan Cameron > --- > drivers/pci/pci.h | 2 +- > drivers/pci/pcie/err.c | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) >

[PATCH v12 6/6] docs: mm: numaperf.rst Add brief description for access class 1.

2020-09-30 Thread Jonathan Cameron
Try to make minimal changes to the document which already describes access class 0 in a generic fashion (including IO initiatiors that are not CPUs). Signed-off-by: Jonathan Cameron --- Documentation/admin-guide/mm/numaperf.rst | 8 1 file changed, 8 insertions(+) diff --git a

[PATCH v12 5/6] node: Add access1 class to represent CPU to memory characteristics

2020-09-30 Thread Jonathan Cameron
placement on CPUs to be performed so as to give optimal access characteristics to memory, even if that memory is for example attached to a GPU or similar and only accessible to the CPU via an appropriate bus. Suggested-by: Dan Willaims Signed-off-by: Jonathan Cameron --- drivers/acpi/numa/hmat.c

[PATCH v12 4/6] ACPI: HMAT: Fix handling of changes from ACPI 6.2 to ACPI 6.3

2020-09-30 Thread Jonathan Cameron
d and hence having a validity flag makes no sense. So the correct logic is to always assume the field is there. Current code assumes it never is. Signed-off-by: Jonathan Cameron --- drivers/acpi/numa/hmat.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/numa/hmat.c

[PATCH v12 3/6] ACPI: Let ACPI know we support Generic Initiator Affinity Structures

2020-09-30 Thread Jonathan Cameron
Until we tell ACPI that we support generic initiators, it will have to operate in fall back domain mode and all _PXM entries should be on existing non GI domains. This patch sets the relevant OSC bit to make that happen. Signed-off-by: Jonathan Cameron --- drivers/acpi/bus.c | 4

[PATCH v12 2/6] x86: Support Generic Initiator only proximity domains

2020-09-30 Thread Jonathan Cameron
In common with memoryless domains only register GI domains if the proximity node is not online. If a domain is already a memory containing domain, or a memoryless domain there is nothing to do just because it also contains a Generic Initiator. Signed-off-by: Jonathan Cameron --- v12: Update

[PATCH v12 1/6] ACPI: Support Generic Initiator only domains

2020-09-30 Thread Jonathan Cameron
associate these new domains with their nearest memory processing node. Signed-off-by: Jonathan Cameron --- drivers/acpi/numa/srat.c | 69 +++- drivers/base/node.c | 3 ++ include/linux/nodemask.h | 1 + 3 files changed, 72 insertions(+), 1 deletion(-) diff

[PATCH v12 0/6] ACPI: Support Generic Initiator proximity domains

2020-09-30 Thread Jonathan Cameron
andwidth 0 write_latency 9 power targets *empty* # as expected GI doesn't paticipate in access 1. uevent compact ... Jonathan Cameron (6): ACPI: Support Generic Initiator only domains x86: Support Generic I

<    2   3   4   5   6   7   8   9   10   11   >