Re: [PATCH v4 1/2] DT: iio: vadc: document dt binding

2014-11-05 Thread Jonathan Cameron
On 05/11/14 00:01, Hartmut Knaack wrote: Ivan T. Ivanov schrieb am 03.11.2014 16:24: From: Stanimir Varbanov svarba...@mm-sol.com Document DT binding for Qualcomm SPMI PMIC voltage ADC driver. Signed-off-by: Stanimir Varbanov svarba...@mm-sol.com Signed-off-by: Ivan T. Ivanov

Re: [PATCH v4 2/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-11-05 Thread Jonathan Cameron
On 05/11/14 13:57, Ivan T. Ivanov wrote: On Wed, 2014-11-05 at 13:09 +, Jonathan Cameron wrote: On 03/11/14 15:24, Ivan T. Ivanov wrote: From: Stanimir Varbanov svarba...@mm-sol.com The voltage ADC is peripheral of Qualcomm SPMI PMIC chips. It has 15 bits resolution and register space

Re: [PATCH v2 1/3] iio: exyno-adc: use syscon for PMU register access

2014-11-05 Thread Jonathan Cameron
On 28/10/14 12:31, Vivek Gautam wrote: Hi all, CC'ing Naveen's gmail id, since the Samsung id is invalid now. On Tue, Sep 16, 2014 at 2:28 PM, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: This patch updates the IIO based ADC driver to use syscon and regmap APIs to access and

Re: [PATCH v2 1/3] iio: exyno-adc: use syscon for PMU register access

2014-11-05 Thread Jonathan Cameron
On 16/09/14 09:58, Naveen Krishna Chatradhi wrote: This patch updates the IIO based ADC driver to use syscon and regmap APIs to access and use PMU registers instead of remapping the PMU registers in the driver. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com To:

Re: [PATCH v4 2/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-11-05 Thread Jonathan Cameron
On 05/11/14 15:01, Ivan T. Ivanov wrote: On Wed, 2014-11-05 at 14:06 +, Jonathan Cameron wrote: On 05/11/14 13:57, Ivan T. Ivanov wrote: On Wed, 2014-11-05 at 13:09 +, Jonathan Cameron wrote: On 03/11/14 15:24, Ivan T. Ivanov wrote: From: Stanimir Varbanov svarba...@mm-sol.com

Re: [PATCH v2 2/3] Documentation: dt-bindings: update exynos-adc.txt with syscon handle

2014-11-05 Thread Jonathan Cameron
On 16/09/14 09:58, Naveen Krishna Chatradhi wrote: This patch updates the DT bindings for ADC in exynos-adc.txt with the syscon phandle to the ADC nodes. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com To: devicet...@vger.kernel.org Applied to the togreg branch of iio.git -

Re: [PATCH v2 3/3] ARM: dts: exynos: Add sysreg phandle to ADC node

2014-11-05 Thread Jonathan Cameron
On 16/09/14 09:58, Naveen Krishna Chatradhi wrote: Instead of using the ADC_PHY register base address, use sysreg phandle in ADC node to control ADC_PHY configuration register. This patch adds syscon node for Exynos3250, Exynos4x12, Exynos5250, and Exynos5420, Exynos5800. Signed-off-by:

Re: [PATCH v2] iio: adc: exynos_adc: Add support for exynos7

2014-11-05 Thread Jonathan Cameron
On 01/11/14 08:25, Chanwoo Choi wrote: Hi Abhilash, On Sat, Nov 1, 2014 at 1:00 PM, Abhilash Kesavan a.kesa...@samsung.com wrote: The ADC on exynos7 is quite similar to ADCv2. The differences are as follows: - exynos7-adc has 8 input channels (as against 10 in ADCv2). -

Re: [PATCH v4] iio: iadc: Qualcomm SPMI PMIC current ADC driver

2014-11-05 Thread Jonathan Cameron
On 03/11/14 08:45, Ivan T. Ivanov wrote: On Fri, 2014-10-31 at 21:48 +0100, Peter Meerwald wrote: Ivan T. Ivanov schrieb am 22.10.2014 16:13: The current ADC is peripheral of Qualcomm SPMI PMIC chips. It has 16 bits resolution and register space inside PMIC accessible across SPMI bus. The

Re: [RFC PATCH 0/3] Introduce IIO interface for fingerprint sensors

2014-12-04 Thread Jonathan Cameron
On 04/12/14 13:00, Teodora Baluta wrote: This patchset adds support for fingerprint sensors through the IIO interface. This way userspace applications collect information in a uniform way. All processing would be done in the upper layers as suggested in [0]. In order to test out this

Re: [PATCH 3/4] iio: accel: kxcjk-1013: error handling when set mode fails

2014-12-06 Thread Jonathan Cameron
On 05/12/14 22:18, Irina Tirdea wrote: If there is an error in set mode at runtime resume, reset the state of the runtime usage count. If there is an error in set mode at runtime suspend, make sure the framework retries to suspend the device. Signed-off-by: Irina Tirdea

Re: [PATCH 1/4] iio: accel: kxcjk-1013: always power on device in resume

2014-12-06 Thread Jonathan Cameron
On 05/12/14 22:18, Irina Tirdea wrote: When the system resumes, it will first call system resume and then runtime suspend (if CONFIG_RUNTIME_PM is enabled). There is no need to conditionally power on the device in system resume, so always power it on and leave runtime suspend to power it off

Re: [PATCH 2/4] iio: accel: kxcjk-1013: only set power state if CONFIG_PM is defined

2014-12-06 Thread Jonathan Cameron
On 05/12/14 22:18, Irina Tirdea wrote: When CONFIG_PM is not defined and the driver tries to power off the device, kxcjk1013_set_power_state will call pm_runtime_put_autosuspend, which is not implemented (wil return -ENOSYS). Only call pm_runtime calls to change power state when CONFIG_PM

Re: [PATCH v3 2/5] iio: sensorhub: Add sensorhub bindings

2014-12-07 Thread Jonathan Cameron
On 05/12/14 19:54, Karol Wrona wrote: Add sensorhub bindings for sensorhub on Galaxy Gear 2. Change-Id: I4ee25aef33c21a4662de230841de9a8684f2c26b Signed-off-by: Karol Wrona k.wr...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Looks good to me. Comments inline. Note I

Re: [PATCH v3 5/5] iio: common: ssp_sensors: Add sensorhub gyroscope sensor

2014-12-07 Thread Jonathan Cameron
On 05/12/14 19:54, Karol Wrona wrote: This patch adds gyroscope iio driver which uses sensorhub as data provider. Change-Id: Ia16bc92159d062a29957de8e62ea3fefdcd7985a Signed-off-by: Karol Wrona k.wr...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com hmm. This is obviously

Re: [PATCH v3 3/5] iio: common: ssp_sensors: Add sensorhub iio commons

2014-12-07 Thread Jonathan Cameron
On 05/12/14 19:54, Karol Wrona wrote: This patch adds common library for sensorhub iio drivers. Change-Id: I1038cb31c051f7e8ffde696a4121518daa5af081 Signed-off-by: Karol Wrona k.wr...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Few minor bits inline. ---

Re: [PATCH v3 1/5] iio: common: ssp_sensors: Add sensorhub driver

2014-12-07 Thread Jonathan Cameron
On 05/12/14 19:54, Karol Wrona wrote: Sensorhub is MCU dedicated to collect data and manage several sensors. Sensorhub is a spi device which provides a layer for IIO devices. It provides some data parsing and common mechanism for sensorhub sensors. Adds common sensorhub library for

Re: [PATCH v3 4/5] iio: common: ssp_sensors: Add sensorhub accelerometer sensor

2014-12-07 Thread Jonathan Cameron
On 05/12/14 19:54, Karol Wrona wrote: This patch adds accelerometer iio driver which uses sensorhub as data provider. Change-Id: I4686741b7401ec5cbf4b5d0f2a5cc146fbe24d53 Signed-off-by: Karol Wrona k.wr...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com ---

Re: [PATCH 1/8] iio: core: Introduce CALORIES channel type

2015-01-01 Thread Jonathan Cameron
On 29/12/14 14:42, Tirdea, Irina wrote: -Original Message- From: linux-iio-ow...@vger.kernel.org [mailto:linux-iio-ow...@vger.kernel.org] On Behalf Of Jonathan Cameron Sent: 26 December, 2014 15:26 To: Tirdea, Irina; linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org

Re: [PATCH 3/8] iio: core: Introduce SPEED channel type

2015-01-01 Thread Jonathan Cameron
On 29/12/14 18:13, Tirdea, Irina wrote: -Original Message- From: Jonathan Cameron [mailto:ji...@kernel.org] Sent: 26 December, 2014 15:28 To: Tirdea, Irina; linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org; Dogaru, Vlad; Baluta, Daniel; Hartmut Knaack; Lars-Peter

Re: [PATCH 4/8] iio: core: Introduce IO_CHAN_INFO_CALIBWEIGHT

2015-01-01 Thread Jonathan Cameron
On 29/12/14 15:05, Tirdea, Irina wrote: -Original Message- From: Jonathan Cameron [mailto:ji...@kernel.org] Sent: 26 December, 2014 15:31 To: Tirdea, Irina; linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org; Dogaru, Vlad; Baluta, Daniel; Hartmut Knaack; Lars-Peter

Re: [PATCH 8/8] iio: add driver for Freescale MMA9553

2015-01-01 Thread Jonathan Cameron
On 19/12/14 22:57, Irina Tirdea wrote: Add support for Freescale MMA9553L Intelligent Pedometer Platform. The following functionalities are supported: - step counter (counts the number of steps using a HW register) - step detector (generates an iio event at every step the user takes) -

Re: [PATCH 7/8] iio: accel: mma9551: split driver to expose mma955x api

2015-01-01 Thread Jonathan Cameron
On 19/12/14 22:57, Irina Tirdea wrote: Freescale has the MMA955xL family of devices that use the same communication protocol (based on i2c messages): http://www.freescale.com/files/sensors/doc/data_sheet/MMA955xL.pdf. To support more devices from this family, we need to split the mma9551

Re: iio: dht11 Updates

2015-01-01 Thread Jonathan Cameron
On 02/12/14 23:32, Richard Weinberger wrote: Please see my current patches for your driver. As discussed in an earlier mail I'm testing with the DHT22 sensor only. With the IRQ changes I see 84 edges. I have also a question on your driver. Why you increment DHT11_DATA_BIT_LOW/timeres by one

Re: [PATCH v2 07/10] iio: core: Introduce IIO_CHAN_INFO_FILTER_OUTLIERS_THRESH and _PERIOD

2015-01-26 Thread Jonathan Cameron
On 26/01/15 14:40, Daniel Baluta wrote: On Mon, Jan 26, 2015 at 1:07 AM, Jonathan Cameron ji...@kernel.org wrote: On 11/01/15 19:10, Irina Tirdea wrote: The pedometer needs to filter out false steps that might be generated by tapping the foot, sitting, etc. To do that it computes the number

Re: [PATCH v2 08/10] iio: accel: mma9551: Add runtime pm support

2015-01-26 Thread Jonathan Cameron
On 11/01/15 19:10, Irina Tirdea wrote: Add support for runtime pm to reduce the power consumed by the device when not used. If CONFIG_PM is not enabled, the device will be powered on at init and only powered off on system suspend. If CONFIG_PM is enabled, runtime pm autosuspend is used:

Re: [PATCH v2 06/10] iio: core: Remove IIO_EV_TYPE_INSTANCE

2015-01-26 Thread Jonathan Cameron
On 11/01/15 19:10, Irina Tirdea wrote: By introducing IIO_EV_TYPE_CHANGE, IIO_EV_TYPE_INSTANCE becomes redundant. The effect of IIO_EV_TYPE_INSTANCE can be obtained by using IIO_EV_TYPE_CHANGE with IIO_EV_INFO_VALUE set to 1. Remove all instances of IIO_EV_TYPE_INSTANCE and replace them with

Re: [PATCH v2 09/10] iio: accel: mma9551: split driver to expose mma955x api

2015-01-26 Thread Jonathan Cameron
On 11/01/15 19:10, Irina Tirdea wrote: Freescale has the MMA955xL family of devices that use the same communication protocol (based on i2c messages): http://www.freescale.com/files/sensors/doc/data_sheet/MMA955xL.pdf. To support more devices from this family, we need to split the mma9551

Re: [PATCH] iio: imu: adis16400: Fix sign extension

2015-01-26 Thread Jonathan Cameron
On 23/01/15 08:56, Lars-Peter Clausen wrote: On 01/23/2015 12:34 AM, Rasmus Villemoes wrote: The intention is obviously to sign-extend a 12 bit quantity. But because of C's promotion rules, the assignment is equivalent to val16 = 0xfff;. Use the proper API for this. Signed-off-by: Rasmus

Re: [PATCH v2 10/10] iio: add driver for Freescale MMA9553

2015-01-26 Thread Jonathan Cameron
On 11/01/15 19:10, Irina Tirdea wrote: Add support for Freescale MMA9553L Intelligent Pedometer Platform. The following functionalities are supported: - step counter (counts the number of steps using a HW register) - step detector (generates an iio event at every step the user takes) -

Re: [PATCH] staging: iio: ad2s1200: Fix sign extension

2015-01-26 Thread Jonathan Cameron
On 23/01/15 08:56, Lars-Peter Clausen wrote: On 01/23/2015 12:09 AM, Rasmus Villemoes wrote: The line above makes vel a 12-bit quantity (st-rx[] is u8). The intention is to sign-extend vel using bit 11 as the sign bit. But because of C's promotion rules vel = (vel 4) 4; is actually a no-op,

Re: [PATCH 2/3] iio: qcom-spmi-iadc: cleanup wait_for_completion return handling

2015-02-04 Thread Jonathan Cameron
On 02/02/15 08:37, Nicholas Mc Guire wrote: This patch fixes two issues: * return type of wait_for_completion_timeout is unsigned long not int, rather than adding a dedicated variable the wait_for_completion_timeout is moved into the condition directly * the timeout of

Re: [PATCH 1/3] iio: vf610_adc: cleanup wait_for_completion return handling

2015-02-04 Thread Jonathan Cameron
On 02/02/15 08:35, Nicholas Mc Guire wrote: return type of wait_for_completion_timeout is unsigned long not int, this patch only fixes up the return handling. Signed-off-by: Nicholas Mc Guire hof...@osadl.org Applied to the togreg branch of iio.git which will at somepoint get pushed out as

Re: [PATCH] iio: gyro: bmg160: optimize i2c transfers in trigger handler

2015-02-04 Thread Jonathan Cameron
On 30/01/15 04:03, Viorel Suman wrote: Hi, You might need more space in values buffer, for more details please check the iio_push_to_buffers_with_timestamp description and implementation. Whilst that function is a little 'odd', this patch doesn't change the use of buffer (simply how it if

Re: [PATCH -next] iio/magnetometer: fix AK09911 dependencies

2015-02-04 Thread Jonathan Cameron
to `i2c_smbus_read_i2c_block_data' drivers/built-in.o:(.debug_addr+0x4dad4): undefined reference to `i2c_smbus_read_byte_data' Signed-off-by: Randy Dunlap rdun...@infradead.org Cc: Jonathan Cameron ji...@kernel.org Cc: Hartmut Knaack knaac...@gmx.de Cc: Lars-Peter Clausen l...@metafoo.de Cc: Peter Meerwald

Re: [PATCH] staging: iio: trigger: iio-trig-periodic-rtc: Change type in printf format string

2015-02-08 Thread Jonathan Cameron
On 27/01/15 21:32, Rickard Strandqvist wrote: Wrong type in printf format string, requires 'unsigned int' but the argument type is 'int' This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se Whilst you

Re: [PATCH] staging: iio: light: tsl2x7x_core: Change type in printf format string

2015-02-08 Thread Jonathan Cameron
On 27/01/15 22:20, Rickard Strandqvist wrote: Wrong type in printf format string, requires 'int' but the argument type is 'unsigned int' This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se Another one

Re: [PATCH] staging: iio: magnetometer: hmc5843_core: Change type in printf format string

2015-02-08 Thread Jonathan Cameron
On 27/01/15 22:21, Rickard Strandqvist wrote: Wrong type in printf format string, requires 'int' but the argument type is 'unsigned int' This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se This one is

Re: [PATCH] staging: iio: resolver: ad2s1210: Change type in printf format string

2015-02-08 Thread Jonathan Cameron
On 27/01/15 22:22, Rickard Strandqvist wrote: Wrong type in printf format string, requires 'int' but the argument type is 'unsigned int' This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se Finally one

Re: [PATCH] staging: iio: adc: mxs-lradc: Change type in printf format string

2015-02-08 Thread Jonathan Cameron
On 27/01/15 22:59, Marek Vasut wrote: On Tuesday, January 27, 2015 at 11:23:33 PM, Rickard Strandqvist wrote: Wrong type in printf format string, requires 'int' but the argument type is 'unsigned int' This was found using a static code analysis program called cppcheck Signed-off-by: Rickard

Re: [PATCH 1/1] Staging: iio: Coding Style Correction

2015-02-08 Thread Jonathan Cameron
On 08/02/15 08:04, Tolga Ceylan wrote: Indentation corrections in struct initializations and one line over 80 characters split into two lines Signed-off-by: Tolga Ceylan tolga.cey...@gmail.com Whilst I find it hard to be inspired by these sort of patches, you have presented the patch well and

Re: [PATCH] staging: iio: light: tsl2583: Change type in printf format string

2015-02-08 Thread Jonathan Cameron
On 27/01/15 22:19, Rickard Strandqvist wrote: Wrong type in printf format string, requires 'int' but the argument type is 'unsigned int' This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se This one is

Re: [PATCH] staging: iio: impedance-analyzer: ad5933: Change type in printf format string

2015-02-08 Thread Jonathan Cameron
On 27/01/15 22:18, Rickard Strandqvist wrote: Wrong type in printf format string, requires 'int' but the argument type is 'unsigned int' This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se Sorry, you

Re: [PATCH 1/1] Staging: iio: Coding style correction

2015-02-08 Thread Jonathan Cameron
On 08/02/15 07:40, Tolga Ceylan wrote: Line over 80 characters corrected Signed-off-by: Tolga Ceylan tolga.cey...@gmail.com Applied, again with an amended patch title to reflect the driver it is changing rather that simply the subsystem. --- drivers/staging/iio/meter/ade7854-i2c.c | 3 ++-

Re: [PATCH v3 3/5] iio: common: ssp_sensors: Add sensorhub iio commons

2015-01-14 Thread Jonathan Cameron
On 13/01/15 16:03, Karol Wrona wrote: [...] +EXPORT_SYMBOL(ssp_common_setup_buffer); diff --git a/drivers/iio/common/ssp_sensors/ssp_iio_sensor.h b/drivers/iio/common/ssp_sensors/ssp_iio_sensor.h new file mode 100644 index 000..4b79be0 --- /dev/null +++

Re: [PATCH v6 0/7] Add initial support for DA9150 Charger Fuel-Gauge IC

2015-01-21 Thread Jonathan Cameron
On 21 January 2015 16:52:50 GMT+00:00, Sebastian Reichel s...@kernel.org wrote: Hi, On Wed, Jan 21, 2015 at 03:46:25PM +, Adam Thomson wrote: This patch set adds initial support for the Dialog DA9150 Integrated Charger Fuel-Gauge IC. The device also provides GPIO and GPADC

Re: [PATCH] staging: iio: tsl2x7x_core: fix format string warnings

2015-01-21 Thread Jonathan Cameron
On 20/01/15 09:27, Asaf Vertz wrote: Fixed the following warnings (reported by cppcheck): [drivers/staging/iio/light/tsl2x7x_core.c:1150]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [drivers/staging/iio/light/tsl2x7x_core.c:1150]: (warning)

Re: [PATCH] staging: iio: tsl2583: fix format string warnings

2015-01-20 Thread Jonathan Cameron
On 20/01/15 10:43, Asaf Vertz wrote: Fixed the following warnings (reported by cppcheck): [drivers/staging/iio/light/tsl2583.c:695]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [drivers/staging/iio/light/tsl2583.c:695]: (warning) %d in format

Re: [PATCH] staging: iio: ad5933: fix format string warnings

2015-01-20 Thread Jonathan Cameron
On 20/01/15 08:52, Lars-Peter Clausen wrote: On 01/20/2015 08:25 AM, Asaf Vertz wrote: Fixed the following warnings (reported by cppcheck): [drivers/staging/iio/impedance-analyzer/ad5933.c:363]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.

Re: [PATCH v5 3/7] iio: Add support for DA9150 GPADC

2015-01-20 Thread Jonathan Cameron
On 14/01/15 11:30, Opensource [Adam Thomson] wrote: On January 10, 2015 22:19, Jonathan Cameron wrote: On 07/01/15 16:03, Opensource [Adam Thomson] wrote: On January 4, 2015 17:22, Jonathan Cameron wrote: On 22/12/14 16:51, Adam Thomson wrote: This patch adds support for DA9150 Charger

Re: [PATCH 1/3] iio: adc: vf610: use ADC clock within specification

2015-01-27 Thread Jonathan Cameron
On 20/01/15 16:02, Stefan Agner wrote: Depending on conversion mode used, the ADC clock (ADCK) needs to be below a maximum frequency. According to Vybrid's data sheet this is 20MHz for the low power conversion mode. The ADC clock is depending on input clock, which is the bus clock by

Re: [PATCH 1/3] iio: adc: vf610: use ADC clock within specification

2015-01-27 Thread Jonathan Cameron
On 27 January 2015 21:20:24 GMT+00:00, Stefan Agner ste...@agner.ch wrote: On 2015-01-27 21:59, Jonathan Cameron wrote: On 20/01/15 16:02, Stefan Agner wrote: Depending on conversion mode used, the ADC clock (ADCK) needs to be below a maximum frequency. According to Vybrid's data sheet

Re: [PATCH 2/3] iio: adc: vf610: implement configurable conversion modes

2015-01-27 Thread Jonathan Cameron
On 20/01/15 16:02, Stefan Agner wrote: Support configureable conversion mode through sysfs. So far, the mode used was low-power, which is enabled by default now. Beside that, the modes normal and high-speed are selectable as well. Use the new device tree property which specifies the maximum

Re: [PATCH 3/3] ARM: dts: add property for maximum ADC clock frequencies

2015-01-28 Thread Jonathan Cameron
On 20/01/15 16:02, Stefan Agner wrote: The ADC clock frequency is limited depending on modes used. Add device tree property which allow to set the mode used and the maximum frequency ratings for the instance. These allows to set the ADC clock to a frequency which is within specification

Re: [PATCH v5 2/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2015-01-28 Thread Jonathan Cameron
On 20/01/15 10:15, Ivan T. Ivanov wrote: From: Stanimir Varbanov svarba...@mm-sol.com The voltage ADC is peripheral of Qualcomm SPMI PMIC chips. It has 15bits resolution and register space inside PMIC accessible across SPMI bus. The vadc driver registers itself through IIO interface.

Re: [PATCH v5 1/2] DT: iio: vadc: document dt binding

2015-01-28 Thread Jonathan Cameron
On 20/01/15 10:15, Ivan T. Ivanov wrote: From: Stanimir Varbanov svarba...@mm-sol.com Document DT binding for Qualcomm SPMI PMIC voltage ADC driver. Signed-off-by: Stanimir Varbanov svarba...@mm-sol.com Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com Given the only changes since the

Re: [PATCH v5 2/5] iio: sensorhub: Add sensorhub bindings

2015-01-29 Thread Jonathan Cameron
On 28/01/15 14:05, Karol Wrona wrote: Add sensorhub bindings for sensorhub on Galaxy Gear 2. Signed-off-by: Karol Wrona k.wr...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com It's simple and hasn't changed in months, so applied to the togreg branch of iio.git. ---

Re: [PATCH v3 1/3] iio: core: Introduce IIO_CHAN_INFO_DEBOUNCE_COUNT and _TIME

2015-01-29 Thread Jonathan Cameron
On 27/01/15 18:41, Irina Tirdea wrote: The pedometer needs to filter out false steps that might be generated by tapping the foot, sitting, etc. To do that it computes the number of steps that occur in a given time and decides the user is moving only if this value is over a threshold. E.g.: the

Re: [PATCH v5 1/5] iio: common: ssp_sensors: Add sensorhub driver

2015-01-29 Thread Jonathan Cameron
On 28/01/15 14:05, Karol Wrona wrote: Sensorhub is MCU dedicated to collect data and manage several sensors. Sensorhub is a spi device which provides a layer for IIO devices. It provides some data parsing and common mechanism for sensorhub sensors. Adds common sensorhub library for

Re: [PATCH v5 3/5] iio: common: ssp_sensors: Add sensorhub iio commons

2015-01-29 Thread Jonathan Cameron
On 28/01/15 14:05, Karol Wrona wrote: This patch adds common library for sensorhub iio drivers. Signed-off-by: Karol Wrona k.wr...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Applied with the make file line brought forward from patch 1. Pushed out as testing for the

Re: [PATCH v5 4/5] iio: common: ssp_sensors: Add sensorhub accelerometer sensor

2015-01-29 Thread Jonathan Cameron
On 28/01/15 14:05, Karol Wrona wrote: This patch adds accelerometer iio driver which uses sensorhub as data provider. Signed-off-by: Karol Wrona k.wr...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Applied --- drivers/iio/accel/Makefile |1 +

Re: [PATCH v5 5/5] iio: common: ssp_sensors: Add sensorhub gyroscope sensor

2015-01-29 Thread Jonathan Cameron
On 28/01/15 14:05, Karol Wrona wrote: This patch adds gyroscope iio driver which uses sensorhub as data provider. Signed-off-by: Karol Wrona k.wr...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Applied. A nice driver - glad to have it in the tree! Jonathan ---

Re: [PATCH v5 1/5] iio: common: ssp_sensors: Add sensorhub driver

2015-01-29 Thread Jonathan Cameron
On 29/01/15 18:46, Karol Wrona wrote: On 01/29/2015 07:35 PM, Jonathan Cameron wrote: On 28/01/15 14:05, Karol Wrona wrote: Sensorhub is MCU dedicated to collect data and manage several sensors. Sensorhub is a spi device which provides a layer for IIO devices. It provides some data parsing

Re: [PATCH v3 2/3] iio: Documentation: Fix calibheight unit

2015-01-29 Thread Jonathan Cameron
On 27/01/15 18:41, Irina Tirdea wrote: Change calibheight unit from centimeters to meters to follow iio guidelines of using SI units. Signed-off-by: Irina Tirdea irina.tir...@intel.com Applied to the togreg branch of iio.git. Thanks, --- Documentation/ABI/testing/sysfs-bus-iio | 2 +- 1

Re: [PATCH v3 3/3] iio: add driver for Freescale MMA9553

2015-01-29 Thread Jonathan Cameron
On 27/01/15 18:41, Irina Tirdea wrote: Add support for Freescale MMA9553L Intelligent Pedometer Platform. The following functionalities are supported: - step counter (counts the number of steps using a HW register) - step detector (generates an iio event at every step the user takes) -

Re: [PATCH] iio: light: Add support for Capella CM3323 color/light sensor

2015-01-25 Thread Jonathan Cameron
On 22/01/15 10:10, Daniel Baluta wrote: Minimal implementation providing raw light intensity and illuminance readings. For illuminance user can compute lux values using raw readings and scale. This driver also supports CM3323E sensor chip. Cc: Kevin Tsai kt...@capellamicro.com

Re: [PATCH v2 3/3] X-Power AXP288 PMIC Fuel Gauge Driver

2015-01-25 Thread Jonathan Cameron
On 22/01/15 20:52, Todd Brandt wrote: New power_supply driver at driver/power which interfaces with the axp20x mfd driver as a cell. Provides battery info, monitors for changes, and generates alerts on temperature and capacity issues Signed-off-by: Todd Brandt todd.e.bra...@linux.intel.com

Re: [PATCH V3 1/1] iio: Added Capella cm3232 ambient light sensor driver.

2015-01-25 Thread Jonathan Cameron
On 16/01/15 01:41, Kevin Tsai wrote: CM3232 is an advanced ambient light sensor with I2C protocol interface. The I2C slave address is internally hardwired as 0x10 (7-bit). Writing to configure register is byte mode, but reading ALS register requests to use word mode for 16-bit resolution.

Re: [PATCH v2 01/10] iio: core: Introduce ENERGY channel type

2015-01-25 Thread Jonathan Cameron
On 11/01/15 19:10, Irina Tirdea wrote: Human activity sensors report the energy burnt by the user. One of this devices is Freescale's MMA9553L (http://www.freescale.com/files/sensors/doc/ref_manual/MMA9553LSWRM.pdf) that computes the number of calories based on weight and step rate.

Re: [PATCH v2 02/10] iio: core: Introduce DISTANCE channel type

2015-01-25 Thread Jonathan Cameron
On 11/01/15 19:10, Irina Tirdea wrote: Some devices export an estimation of the distance the user has covered since the last reset. One of this devices is Freescale's MMA9553L (http://www.freescale.com/files/sensors/doc/ref_manual/MMA9553LSWRM.pdf) that computes the distance based on the

Re: [PATCH v2 03/10] iio: core: Introduce IIO_VELOCITY and IIO_MOD_ROOT_SUM_SQUARED_X_Y_Z

2015-01-25 Thread Jonathan Cameron
On 11/01/15 19:10, Irina Tirdea wrote: Some devices export the current speed value of the user. One of this devices is Freescale's MMA9553L (http://www.freescale.com/files/sensors/doc/ref_manual/MMA9553LSWRM.pdf) that computes the speed of the user based on the number of steps and stride

Re: [PATCH v2 04/10] iio: core: Introduce IO_CHAN_INFO_CALIBWEIGHT

2015-01-25 Thread Jonathan Cameron
On 11/01/15 19:10, Irina Tirdea wrote: Some devices need the weight of the user to compute other parameters. One of this devices is Freescale's MMA9553L (http://www.freescale.com/files/sensors/doc/ref_manual/MMA9553LSWRM.pdf) that needs the weight of the user to compute the number of calories

Re: [PATCH v2 05/10] iio: core: Introduce CHANGE event type

2015-01-25 Thread Jonathan Cameron
On 11/01/15 19:10, Irina Tirdea wrote: A step detector will generate an interrupt each time N step are detected. A device that has such pedometer functionality is Freescale's MMA9553L: http://www.freescale.com/files/sensors/doc/ref_manual/MMA9553LSWRM.pdf. Introduce IIO_EV_TYPE_CHANGE event

Re: [PATCH v2 07/10] iio: core: Introduce IIO_CHAN_INFO_FILTER_OUTLIERS_THRESH and _PERIOD

2015-01-25 Thread Jonathan Cameron
On 11/01/15 19:10, Irina Tirdea wrote: The pedometer needs to filter out false steps that might be generated by tapping the foot, sitting, etc. To do that it computes the number of steps that occur in a given time and decides the user is moving only if this value is over a threshold. E.g.: the

Re: [PATCH v2] iio: imu: kmx61: Drop odr_bits from kmx61_samp_freq_table

2015-02-01 Thread Jonathan Cameron
On 05/01/15 23:00, Hartmut Knaack wrote: Daniel Baluta schrieb am 05.01.2015 um 10:21: odr_bits values are between 0 and 11, so we can use the index in kmx61_samp_freq_table instead of odr_bits structure member. Signed-off-by: Daniel Baluta daniel.bal...@intel.com Reviewed-by: Hartmut Knaack

RE: [PATCH v2 10/10] iio: add driver for Freescale MMA9553

2015-01-27 Thread Jonathan Cameron
On 27 January 2015 17:09:20 GMT+00:00, Tirdea, Irina irina.tir...@intel.com wrote: -Original Message- From: Jonathan Cameron [mailto:ji...@kernel.org] Sent: 26 January, 2015 22:44 To: Tirdea, Irina; linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org; Dogaru, Vlad; Baluta

Re: [PATCHv2 2/3,RESEND] iio: dht11: Add locking

2015-01-10 Thread Jonathan Cameron
On 07/01/15 12:18, Harald Geyer wrote: Make sure that the read function is not interrupted... From: Richard Weinberger rich...@nod.at Signed-off-by: Richard Weinberger rich...@nod.at Acked-by: Harald Geyer har...@ccbib.org Reviewed-by: Sanjeev Sharma sanjeev_sha...@mentor.com ---

Re: [PATCH V1 1/1] iio: Added Capella cm3232 ambient light sensor driver.

2015-01-10 Thread Jonathan Cameron
On 05/01/15 17:56, Joe Perches wrote: On Mon, 2015-01-05 at 19:50 +0200, Daniel Baluta wrote: On Mon, Jan 5, 2015 at 6:42 PM, Joe Perches j...@perches.com wrote: On Mon, 2015-01-05 at 16:20 +0200, Daniel Baluta wrote: On Mon, Jan 5, 2015 at 3:09 PM, Joe Perches j...@perches.com wrote: On Mon,

Re: [PATCHv2 1/3,RESEND] iio: dht11: Fix out-of-bounds read

2015-01-10 Thread Jonathan Cameron
On 07/01/15 12:15, Harald Geyer wrote: As we access i-1 we must not start with i=0. From: Richard Weinberger rich...@nod.at Signed-off-by: Richard Weinberger rich...@nod.at Acked-by: Hartmut Knaack knaac...@gmx.de Acked-by: Harald Geyer har...@ccbib.org Reviewed-by: Sanjeev Sharma

Re: [PATCH v5 3/7] iio: Add support for DA9150 GPADC

2015-01-10 Thread Jonathan Cameron
On 07/01/15 16:03, Opensource [Adam Thomson] wrote: On January 4, 2015 17:22, Jonathan Cameron wrote: On 22/12/14 16:51, Adam Thomson wrote: This patch adds support for DA9150 Charger Fuel-Gauge IC GPADC. Signed-off-by: Adam Thomson adam.thomson.opensou...@diasemi.com One last query from

Re: [PATCH 2/2] iio: Deselect IIO_TRIGGER for IIO_KFIFO_BUF

2015-01-10 Thread Jonathan Cameron
On 10/01/15 11:11, Lars-Peter Clausen wrote: On 01/08/2015 05:40 PM, Karol Wrona wrote: iio kfifo can be used without trigger support so there is no need to build it. Signed-off-by: Karol Wrona k.wr...@samsung.com Looks good, not sure why this was ever selected it in the first place.

Re: [RFC PATCH] iio: Add new operating mode for non triggered sw buffers

2015-01-10 Thread Jonathan Cameron
form hardware backend. Suggested-by: Jonathan Cameron ji...@kernel.org Signed-off-by: Karol Wrona k.wr...@samsung.com Looks good, thanks. Reviewed-by: Lars-Peter Clausen l...@metafoo.de Thanks for doing this. Applied to the togreg branch of iio.git - initially pushed out as testing

Re: [PATCH 1/2] iio: Add no-triggered buffer helper functions

2015-01-10 Thread Jonathan Cameron
On 10/01/15 11:10, Lars-Peter Clausen wrote: On 01/08/2015 05:40 PM, Karol Wrona wrote: These ones helps to create and manage iio_kfifo buffer when no-triggered buffer is used. [...] +int iio_notriggered_buffer_setup(struct iio_dev *indio_dev, + const struct

Re: [PATCH 8/8] iio: add driver for Freescale MMA9553

2015-01-11 Thread Jonathan Cameron
On 11/01/15 15:10, Tirdea, Irina wrote: -Original Message- From: Jonathan Cameron [mailto:ji...@kernel.org] Sent: 01 January, 2015 13:58 To: Tirdea, Irina; linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org; Dogaru, Vlad; Baluta, Daniel; Hartmut Knaack; Lars-Peter

Re: Revert e0922e5e3ccb78aa0152e93dfbd1755ac39c8582

2015-02-14 Thread Jonathan Cameron
On 12/02/15 20:23, Andrey Smirnov wrote: Hi Jonathan, Please revert patch e0922e5e3ccb78aa0152e93dfbd1755ac39c8582: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/iio/humidity/si7020.c?id=e0922e5e3ccb78aa0152e93dfbd1755ac39c8582 It incorrectly assumes that

Re: [PATCH] IIO: si7020: Allocate correct amount of memory in devm_iio_device_alloc

2015-02-14 Thread Jonathan Cameron
On 13/02/15 07:58, Andrey Smirnov wrote: Since only a pointer to struct i2c_client is stored in a private area of IIO device created by the driver there's no need to allocate sizeof(struct i2c_client) worth of storage. Signed-off-by: Andrey Smirnov andrew.smir...@gmail.com Applied to the

Re: [PATCH v2] iio: Export userspace IIO headers

2015-02-14 Thread Jonathan Cameron
/null +++ b/include/uapi/linux/iio/events.h @@ -0,0 +1,43 @@ +/* The industrial I/O - event passing to userspace + * + * Copyright (c) 2008-2011 Jonathan Cameron + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License

Re: [PATCH V4 1/1] iio: Updated Capella cm3232 ambient light sensor driver.

2015-02-14 Thread Jonathan Cameron
On 13/02/15 00:35, Kevin Tsai wrote: Added ACPI and Power Management support. Signed-off-by: Kevin Tsai kt...@capellamicro.com Hi Kevin, Please treat this as a new series, adding functionality to the driver that has already been merged. As such we are back to v1. Also make it clear what you

Re: [PATCH] iio: gp2ap020a00f: Use put_unaligned_le32

2015-02-14 Thread Jonathan Cameron
On 11/02/15 09:17, Vaishali Thakkar wrote: This patch introduces the use of function put_unaligned_le32. This is done using Coccinelle and semantic patch used is as follows: @@ identifier tmp; expression ptr; expression y,e; type T; @@ - tmp = cpu_to_le32(y); +... when != tmp -

Re: [PATCH] iio: gp2ap020a00f: Use put_unaligned_le32

2015-02-14 Thread Jonathan Cameron
On 14/02/15 11:59, Jonathan Cameron wrote: On 11/02/15 09:17, Vaishali Thakkar wrote: This patch introduces the use of function put_unaligned_le32. This is done using Coccinelle and semantic patch used is as follows: @@ identifier tmp; expression ptr; expression y,e; type T; @@ - tmp

Re: iio: dht11 Updates

2015-01-04 Thread Jonathan Cameron
On 02/01/15 11:28, Richard Weinberger wrote: Am 01.01.2015 um 22:18 schrieb har...@ccbib.org: Hi! On Thu, 01 Jan 2015 12:38:23 +, Jonathan Cameron ji...@kernel.org wrote: On 02/12/14 23:32, Richard Weinberger wrote: Please see my current patches for your driver. As discussed

Re: [PATCH RFC] iio: iadc: wait_for_completion_timeout time in jiffies

2015-01-04 Thread Jonathan Cameron
On 31/12/14 08:59, Nicholas Mc Guire wrote: The timeout value to wait_for_completion_timeout is in jiffies but the value being passed seems like it was intended to by microseconds Note that the timeout was extremely long thus it might be too short now. In any case it probably should be passed

Re: [PATCH v5 3/7] iio: Add support for DA9150 GPADC

2015-01-04 Thread Jonathan Cameron
to simple pins on the side of the chip. For those just drop the extname bit. Some of the channels you have here, definitely need them though. Drop those first 4 or convince me otherwise and add Acked-by: Jonathan Cameron ji...@kernel.org --- drivers/iio/adc/Kconfig| 9 + drivers/iio/adc

Re: [PATCH v5 5/7] power: Add support for DA9150 Charger

2015-01-04 Thread Jonathan Cameron
On 22/12/14 16:51, Adam Thomson wrote: This patch adds support for DA9150 Charger Fuel-Gauge IC Charger. Signed-off-by: Adam Thomson adam.thomson.opensou...@diasemi.com The IIO bits look fine, but your use of devm_free * doesn't... As a side note, looks like we could benefit from some array

Re: [PATCH 2/2] iio: Add nt133 I/O board support

2015-01-04 Thread Jonathan Cameron
On 26/11/14 21:45, George McCollister wrote: The NovaTech 133 I/O board is an expansion card for the NovaTech OrionLXm with 16 digital input channels and 4 digital output channels. Signed-off-by: George McCollister george.mccollis...@gmail.com A few comments inline. I understand where you

Re: [PATCH 01/10] iio: imu: kmx61: Save odr_bits for later use

2015-01-04 Thread Jonathan Cameron
On 01/01/15 13:45, Hartmut Knaack wrote: Daniel Baluta schrieb am 23.12.2014 um 14:22: Signed-off-by: Daniel Baluta daniel.bal...@intel.com Reviewed-by: Hartmut Knaack knaac...@gmx.de Applied to the togreg branch of iio.git - initially pushed out as testing for the autobuilders to play. ---

Re: [PATCH 02/10] iio: imu: kmx61: Don't ignore kmx61_set_power_state errors

2015-01-04 Thread Jonathan Cameron
On 01/01/15 13:45, Hartmut Knaack wrote: Daniel Baluta schrieb am 23.12.2014 um 14:22: ..except while in an error handler, where there is nothing to be done anyway. Signed-off-by: Daniel Baluta daniel.bal...@intel.com Reviewed-by: Hartmut Knaack knaac...@gmx.de Applied ---

Re: [PATCH 03/10] iio: imu: kmx61: Enhance error handling

2015-01-04 Thread Jonathan Cameron
On 01/01/15 13:47, Hartmut Knaack wrote: Daniel Baluta schrieb am 23.12.2014 um 14:22: This fixes parts of kmx61 error handling to make code easier to read and to be more consistent with IIO coding conventions: * prefer as single point for error handling instead of duplicating code

Re: [PATCH 04/10] iio: imu: kmx61: Fixup parameters alignment

2015-01-04 Thread Jonathan Cameron
On 01/01/15 13:47, Hartmut Knaack wrote: Daniel Baluta schrieb am 23.12.2014 um 14:22: Signed-off-by: Daniel Baluta daniel.bal...@intel.com Acked-by: Hartmut Knaack knaac...@gmx.de Applied. --- drivers/iio/imu/kmx61.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-)

Re: [PATCH 06/10] iio: imu: kmx61: Use false instead of 0 for ev_enable_state

2015-01-04 Thread Jonathan Cameron
On 01/01/15 13:50, Hartmut Knaack wrote: Daniel Baluta schrieb am 23.12.2014 um 14:22: Signed-off-by: Daniel Baluta daniel.bal...@intel.com Acked-by: Hartmut Knaack knaac...@gmx.de Applied --- drivers/iio/imu/kmx61.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

<    3   4   5   6   7   8   9   10   11   12   >