[PATCH net] net: stmmac: selftests: Flow Control test can also run with ASYM Pause

2019-09-19 Thread Jose Abreu
The Flow Control selftest is also available with ASYM Pause. Lets add this check to the test and fix eventual false positive failures. Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose

RE: [PATCH] [v2] net: stmmac: selftest: avoid large stack usage

2019-09-19 Thread Jose Abreu
Signed-off-by: Arnd Bergmann > --- > v2: simply configure function, based on feedback from Jose Looks good to me. Thanks for the fix :) Acked-by: Jose Abreu --- Thanks, Jose Miguel Abreu

[PATCH net 2/8] net: stmmac: xgmac: Detect Hash Table size dinamically

2019-09-27 Thread Jose Abreu
Since commit b8ef7020d6e5 ("net: stmmac: add support for hash table size 128/256 in dwmac4"), we can detect the Hash Table dinamically. Let's implement this feature in XGMAC cores and fix possible setups that don't support the maximum size for Hash Table. Signed-off-by:

[PATCH net 5/8] net: stmmac: Correctly take timestamp for PTPv2

2019-09-27 Thread Jose Abreu
The case for PTPV2_EVENT requires event packets to be captured so add this setting to the list of enabled captures. Fixes: 891434b18ec0 ("stmmac: add IEEE PTPv1 and PTPv2 support.") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "

[PATCH net 8/8] net: stmmac: xgmac: Fix RSS not writing all Keys to HW

2019-09-27 Thread Jose Abreu
The sizeof(cfg->key) is != ARRAY_SIZE(cfg->key). Fix it. Reported-by: kbuild test robot Reported-by: Nick Desaulniers Fixes: 76067459c686 ("net: stmmac: Implement RSS and enable it in XGMAC core") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc

[PATCH net 7/8] net: stmmac: xgmac: Disable the Timestamp interrupt by default

2019-09-27 Thread Jose Abreu
We don't use it anyway as XGMAC only supports polling for timestamp (in current SW implementation). This greatly reduces the system load by reducing the number of interrupts. Fixes: 2142754f8b9c ("net: stmmac: Add MAC related callbacks for XGMAC2") Signed-off-by: Jose Abreu -

[PATCH net 0/8] net: stmmac: Fixes for -net

2019-09-27 Thread Jose Abreu
Misc fixes for -net tree. More info in commit logs. --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: linux-arm-ker...@lists.infradead.org Cc: li

[PATCH net 4/8] net: stmmac: dwmac4: Always update the MAC Hash Filter

2019-09-27 Thread Jose Abreu
We need to always update the MAC Hash Filter so that previous entries are invalidated. Found out while running stmmac selftests. Fixes: b8ef7020d6e5 ("net: stmmac: add support for hash table size 128/256 in dwmac4") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexan

[PATCH net 1/8] net: stmmac: xgmac: Not all Unicast addresses may be available

2019-09-27 Thread Jose Abreu
Some setups may not have all Unicast addresses filters available. Let's check this before trying to setup filters. Fixes: 0efedbf11f07 ("net: stmmac: xgmac: Fix XGMAC selftests") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: &

[PATCH net 3/8] net: stmmac: selftests: Always use max DMA size in Jumbo Test

2019-09-27 Thread Jose Abreu
uot;net: stmmac: selftests: Add Jumbo Frame tests") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: linux-arm-ker...@lists.

[PATCH net 6/8] net: stmmac: Do not stop PHY if WoL is enabled

2019-09-27 Thread Jose Abreu
ed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: linux-arm-ker...@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/ne

[PATCH net] net: stmmac: selftests: Flow Control test can also run with ASYM Pause

2019-09-23 Thread Jose Abreu
From: Jose Abreu The Flow Control selftest is also available with ASYM Pause. Lets add this check to the test and fix eventual false positive failures. Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexan

RE: [PATCH net] net: stmmac: selftests: Flow Control test can also run with ASYM Pause

2019-09-23 Thread Jose Abreu
From: Jakub Kicinski Date: Sep/22/2019, 22:56:42 (UTC+00:00) > On Thu, 19 Sep 2019 12:09:49 +0200, Jose Abreu wrote: > > The Flow Control selftest is also available with ASYM Pause. Lets add > > this check to the test and fix eventual false positive failures. > > > >

RE: [PATCH net] net: stmmac: selftests: Flow Control test can also run with ASYM Pause

2019-09-23 Thread Jose Abreu
From: Jose Abreu Date: Sep/23/2019, 08:30:43 (UTC+00:00) > From: Jose Abreu > > The Flow Control selftest is also available with ASYM Pause. Lets add > this check to the test and fix eventual false positive failures. > > Fixes: 091810dbded9 ("net: stmmac: Intr

[PATCH net v2] net: stmmac: selftests: Flow Control test can also run with ASYM Pause

2019-09-23 Thread Jose Abreu
The Flow Control selftest is also available with ASYM Pause. Lets add this check to the test and fix eventual false positive failures. Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose

RE: [PATCH net-next 3/3] net: stmmac: Introducing support for Page Pool

2019-07-18 Thread Jose Abreu
From: Jon Hunter Date: Jul/17/2019, 19:58:53 (UTC+00:00) > I am seeing a boot regression on one of our Tegra boards with both > mainline and -next. Bisecting is pointing to this commit and reverting > this commit on top of mainline fixes the problem. Unfortunately, there > is not much of a backtr

RE: [PATCH net-next 3/3] net: stmmac: Introducing support for Page Pool

2019-07-18 Thread Jose Abreu
From: Jon Hunter Date: Jul/17/2019, 19:58:53 (UTC+00:00) > Let me know if you have any thoughts. Can you try attached patch ? --- Thanks, Jose Miguel Abreu 0001-net-stmmac-RX-Descriptors-need-to-be-clean-before-se.patch Description: 0001-net-stmmac-RX-Descriptors-need-to-be-clean-before-se.pa

RE: [EXT] [PATCH v2 1/5] scsi: ufs: Allow UFS 3.0 as a valid version

2020-04-30 Thread Jose Abreu
From: Bean Huo (beanhuo) Date: Apr/29/2020, 13:59:08 (UTC+00:00) > > > > @@ -8441,7 +8441,8 @@ int ufshcd_init(struct ufs_hba *hba, void > > > > __iomem *mmio_base, unsigned int irq) > > > > if ((hba->ufs_version != UFSHCI_VERSION_10) && > > > > (hba->ufs_version != UFSHCI_VER

RE: [PATCH] ARC: guard dsp early init against non ARCv2

2020-04-28 Thread Jose Abreu
From: Eugeniy Paltsev Date: Apr/28/2020, 19:50:24 (UTC+00:00) > As of today we guard early DSP init code with > ARC_AUX_DSP_BUILD (0x7A) BCR check to verify that we have > CPU with DSP configured. However that's not enough as in > ARCv1 CPU the same BCR (0x7A) is used for checking MUL/MAC > instr

RE: [EXT] [PATCH v2 1/5] scsi: ufs: Allow UFS 3.0 as a valid version

2020-04-28 Thread Jose Abreu
From: Bean Huo (beanhuo) Date: Apr/24/2020, 16:57:07 (UTC+00:00) > Hi, Jose > > > @@ -8441,7 +8441,8 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem > > *mmio_base, unsigned int irq) > > if ((hba->ufs_version != UFSHCI_VERSION_10) && > > (hba->ufs_version != UFSHCI_VERSION_11) &

RE: [PATCH net-next 2/2] net: phy: Add ability to debug RGMII connections

2019-10-16 Thread Jose Abreu
From: Florian Fainelli Date: Oct/15/2019, 23:49:53 (UTC+00:00) > The function phy_rgmii_debug_probe() could also be used by an Ethernet > controller during its selftests routines instead of open-coding that > part. I can add it to stmmac selftests then :) > +int phy_rgmii_debug_probe(struct phy

RE: [PATCH net-next 3/3] net: stmmac: Introducing support for Page Pool

2019-07-27 Thread Jose Abreu
From: Jon Hunter Date: Jul/26/2019, 15:11:00 (UTC+00:00) > > On 25/07/2019 16:12, Jose Abreu wrote: > > From: Jon Hunter > > Date: Jul/25/2019, 15:25:59 (UTC+00:00) > > > >> > >> On 25/07/2019 14:26, Jose Abreu wrote: > >> > >> ...

RE: [PATCH net-next 3/3] net: stmmac: Introducing support for Page Pool

2019-07-29 Thread Jose Abreu
From: Jose Abreu Date: Jul/27/2019, 16:56:37 (UTC+00:00) > From: Jon Hunter > Date: Jul/26/2019, 15:11:00 (UTC+00:00) > > > > > On 25/07/2019 16:12, Jose Abreu wrote: > > > From: Jon Hunter > > > Date: Jul/25/2019, 15:25:59 (UTC+00:00) > > >

RE: [PATCH net-next 3/3] net: stmmac: Introducing support for Page Pool

2019-07-29 Thread Jose Abreu
++ Catalin, Will (ARM64 Maintainers) From: Jon Hunter Date: Jul/29/2019, 11:55:18 (UTC+00:00) > > On 29/07/2019 09:16, Jose Abreu wrote: > > From: Jose Abreu > > Date: Jul/27/2019, 16:56:37 (UTC+00:00) > > > >> From: Jon Hunter > >&

RE: [PATCH net-next 3/3] net: stmmac: Introducing support for Page Pool

2019-07-29 Thread Jose Abreu
From: Robin Murphy Date: Jul/29/2019, 12:52:02 (UTC+00:00) > On 29/07/2019 12:29, Jose Abreu wrote: > > ++ Catalin, Will (ARM64 Maintainers) > > > > From: Jon Hunter > > Date: Jul/29/2019, 11:55:18 (UTC+00:00) > > > >> > >> On 29/07/2

Re: [net-next, PATCH] net: stmmac: use correct define to get rx timestamp on GMAC4

2019-02-14 Thread Jose Abreu
Hi Alexandre, On 2/14/2019 2:12 PM, Alexandre Torgue wrote: > In dwmac4_wrback_get_rx_timestamp_status we looking for a RX timestamp. > For that receive descriptors are handled and so we should use defines > related to receive descriptors. It'll no change the functional behavior > as RDES3_RDES1_V

Re: [net-next, PATCH] net: stmmac: use correct define to get rx timestamp on GMAC4

2019-02-14 Thread Jose Abreu
On 2/14/2019 3:00 PM, Alexandre Torgue wrote: > Hi Jose > > On 2/14/19 3:18 PM, Jose Abreu wrote: >> Hi Alexandre, >> >> On 2/14/2019 2:12 PM, Alexandre Torgue wrote: >>> In dwmac4_wrback_get_rx_timestamp_status we looking for a RX >>> timestamp. >

[PATCH net-next 0/3] net: stmmac: Performance improvements in Multi-Queue

2019-02-15 Thread Jose Abreu
Tested in XGMAC2 and GMAC5. I guess 1/3 can be backported but besides being a kind of "not that small" refactoring it's also for a scenario that no-one complained yet ... Advice ? Cc: Florian Fainelli Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torg

[PATCH net-next 3/3] net: stmmac: dwxgmac2: Also use TBU interrupt to clean TX path

2019-02-15 Thread Jose Abreu
interrupts that are enabled so, no event will be missed. In my tests withe XGMAC2 this increased performance. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 4 +++- d

[PATCH net-next 1/3] net: stmmac: Fix NAPI poll in TX path when in multi-queue

2019-02-15 Thread Jose Abreu
instances per each TX and RX queue, as suggested by Florian. Signed-off-by: Jose Abreu Cc: Florian Fainelli Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 5 +- drivers/net/ethernet/stmicro/stmmac

[PATCH net-next 2/3] net: stmmac: dwmac4: Also use TBU interrupt to clean TX path

2019-02-15 Thread Jose Abreu
interrupts that are enabled so, no event will be missed. In my tests with GMAC5 this increased performance. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/dwmac4_

[PATCH net-next v3 3/3] net: stmmac: dwxgmac2: Also use TBU interrupt to clean TX path

2019-02-19 Thread Jose Abreu
interrupts that are enabled so, no event will be missed. In my tests withe XGMAC2 this increased performance. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 4 +++- d

[PATCH net-next v3 1/3] net: stmmac: Fix NAPI poll in TX path when in multi-queue

2019-02-19 Thread Jose Abreu
instances per each TX and RX queue, as suggested by Florian. Changes from v2: - Only force restart transmission if there are pending packets Changes from v1: - Pass entire ring size to TX clean path (Florian) Signed-off-by: Jose Abreu Cc: Florian Fainelli Cc: Joao Pinto Cc: David

[PATCH net-next v3 0/3] net: stmmac: Performance improvements in Multi-Queue

2019-02-19 Thread Jose Abreu
Tested in XGMAC2 and GMAC5. Cc: Florian Fainelli Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Jose Abreu (3): net: stmmac: Fix NAPI poll in TX path when in multi-queue net: stmmac: dwmac4: Also use TBU interrupt to clean TX path net: stmmac: dwxgmac2

[PATCH net-next v3 2/3] net: stmmac: dwmac4: Also use TBU interrupt to clean TX path

2019-02-19 Thread Jose Abreu
interrupts that are enabled so, no event will be missed. In my tests with GMAC5 this increased performance. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/dwmac4_

Re: [PATCH 1/1] net: stmmac: implement the SIOCGHWTSTAMP ioctl

2019-01-18 Thread Jose Abreu
Hello Artem, Please specify in patch subject whether this is for -net or -net-next. More comments inline. On 1/17/2019 7:15 PM, Artem Panfilov wrote: > From: Tema > > This patch adds support for the SIOCGHWTSTAMP ioctl which enables user > processes to read the current hwtstamp_config settings

[PATCH net-next 07/11] net: stmmac: dwmac1000: Also pass control frames while in promisc mode

2019-05-08 Thread Jose Abreu
In order for the selftests to run the Flow Control selftest we need to also pass control frames to the stack. Pass this type of frames while in promiscuous mode. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net

[PATCH net-next 01/11] net: stmmac: Add MAC loopback callback to HWIF

2019-05-08 Thread Jose Abreu
In preparation for the addition of selftests support for stmmac we add a new callback to HWIF that can be used to set the controller in loopback mode. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro

[PATCH net-next 10/11] net: stmmac: Introduce selftests support

2019-05-08 Thread Jose Abreu
in the driver and helps in spotting mis-configuration of HW. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/Kconfig| 9 + drivers/net/ethernet/stmicro/stmmac/Makefile | 2

[PATCH net-next 11/11] net: stmmac: dwmac1000: Fix Hash Filter

2019-05-08 Thread Jose Abreu
In order for hash filter to work we need to set the HPF bit. Found out while running stmmac selftests. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 1 + 1 file changed, 1

[PATCH net-next 00/18] net: stmmac: Improvements and Selftests

2019-05-23 Thread Jose Abreu
Cc: Andrew Lunn Corentin Labbe (1): net: ethernet: stmmac: dwmac-sun8i: Enable control of loopback Jose Abreu (17): net: stmmac: Add MAC loopback callback to HWIF net: stmmac: dwmac100: Add MAC loopback support net: stmmac: dwmac1000: Add MAC loopback support net: stmmac: dwmac4/5

[PATCH net-next 04/18] net: stmmac: dwmac4/5: Add MAC loopback support

2019-05-23 Thread Jose Abreu
In preparation for the addition of stmmac selftests we implement the MAC loopback callback in dwmac4/5 cores. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/dwmac4.h

[PATCH net-next 01/18] net: stmmac: Add MAC loopback callback to HWIF

2019-05-23 Thread Jose Abreu
In preparation for the addition of selftests support for stmmac we add a new callback to HWIF that can be used to set the controller in loopback mode. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- drivers/net

[PATCH net-next 06/18] net: ethernet: stmmac: dwmac-sun8i: Enable control of loopback

2019-05-23 Thread Jose Abreu
From: Corentin Labbe This patch enable use of set_mac_loopback in dwmac-sun8i Signed-off-by: Corentin Labbe Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 13 + 1

[PATCH net-next 17/18] net: stmmac: dwmac4/5: Clear unused address entries

2019-05-23 Thread Jose Abreu
In case we don't use a given address entry we need to clear it because it could contain previous values that are no longer valid. Found out while running stmmac selftests. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- dr

[PATCH net-next 11/18] net: stmmac: Introduce selftests support

2019-05-23 Thread Jose Abreu
: - Change test_loopback to test_mac_loopback (Andrew) - Change timeout to retries (Andrew) - Add MC/UC filter tests (Andrew) - Only test in offline mode (Andrew) - Do not call phy_loopback twice (Alexandre) Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc

[PATCH net-next 08/18] net: stmmac: dwmac1000: Also pass control frames while in promisc mode

2019-05-23 Thread Jose Abreu
In order for the selftests to run the Flow Control selftest we need to also pass pause frames to the stack. Pass this type of frames while in promiscuous mode. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet

[PATCH net-next 18/18] net: stmmac: Prevent missing interrupts when running NAPI

2019-05-23 Thread Jose Abreu
When we trigger NAPI we are disabling interrupts but in case we receive or send a packet in the meantime, as interrupts are disabled, we will miss this event. Trigger both NAPI instances (RX and TX) when at least one event happens so that we don't miss any interrupts. Signed-off-by: Jose

[PATCH net-next 02/18] net: stmmac: dwmac100: Add MAC loopback support

2019-05-23 Thread Jose Abreu
In preparation for the addition of stmmac selftests we implement the MAC loopback callback in dwmac100 core. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/dwmac100_core.c

[PATCH net-next 14/18] net: stmmac: dwmac4/5: Fix Hash Filter

2019-05-23 Thread Jose Abreu
In order for hash filter to work we need to set the HPF bit. Fout out while running stmmac selftests Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 1 + drivers/net/ethernet

[PATCH net-next 12/18] net: stmmac: dwmac1000: Fix Hash Filter

2019-05-23 Thread Jose Abreu
In order for hash filter to work we need to set the HPF bit. Found out while running stmmac selftests. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 1 + 1 file changed, 1

[PATCH net-next 10/18] net: stmmac: dwxgmac2: Also pass control frames while in promisc mode

2019-05-23 Thread Jose Abreu
In order for the selftests to run the Flow Control selftest we need to also pass pause frames to the stack. Pass this type of frames while in promiscuous mode. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet

[PATCH net-next 07/18] net: stmmac: Switch MMC functions to HWIF callbacks

2019-05-23 Thread Jose Abreu
XGMAC has a different MMC module. Lets use HWIF callbacks for MMC module so that correct callbacks are automatically selected. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/common.h

[PATCH net-next 09/18] net: stmmac: dwmac4/5: Also pass control frames while in promisc mode

2019-05-23 Thread Jose Abreu
In order for the selftests to run the Flow Control selftest we need to also pass pause frames to the stack. Pass this type of frames while in promiscuous mode. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet

[PATCH net-next 13/18] net: stmmac: dwmac1000: Clear unused address entries

2019-05-23 Thread Jose Abreu
In case we don't use a given address entry we need to clear it because it could contain previous values that are no longer valid. Found out while running stmmac selftests. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- dr

[PATCH net-next 15/18] net: stmmac: dwmac4/5: Do not disable whole RX in dma_stop_rx()

2019-05-23 Thread Jose Abreu
We don't need to disable the whole RX when dma_stop_rx() is called because there may be the need of just disabling 1 DMA channel. This is also needed for stmmac Flow Control selftest. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre T

[PATCH net-next 16/18] net: stmmac: dwxgmac2: Do not disable whole RX in dma_stop_rx()

2019-05-23 Thread Jose Abreu
We don't need to disable the whole RX when dma_stop_rx() is called because there may be the need of just disabling 1 DMA channel. This is also needed for stmmac Flow Control selftest. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre T

[PATCH net-next 03/18] net: stmmac: dwmac1000: Add MAC loopback support

2019-05-23 Thread Jose Abreu
In preparation for the addition of stmmac selftests we implement the MAC loopback callback in dwmac1000 core. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c

[PATCH net-next 05/18] net: stmmac: dwxgmac2: Add MAC loopback support

2019-05-23 Thread Jose Abreu
In preparation for the addition of stmmac selftests we implement the MAC loopback callback in dwxgmac2 core. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h

[PATCH 1/2] ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node

2019-05-20 Thread Jose Abreu
GMAC controller on HSDK boards supports 256 Hash Table size so we need to add the multicast filter bins property. This allows for the Hash filter to work properly using stmmac driver. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: Rob Herring Cc: Mark Rutland Cc: Vineet Gupta Cc: Eugeniy

[PATCH 0/2] ARC: [plat-hsdk]: GMAC DT Bindings Improvements

2019-05-20 Thread Jose Abreu
Add two missing bindings. Cc: Joao Pinto Cc: Rob Herring Cc: Mark Rutland Cc: Vineet Gupta Cc: Eugeniy Paltsev Cc: Alexey Brodkin Jose Abreu (2): ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node ARC: [plat-hsdk]: Add missing FIFO size entry in GMAC node

[PATCH 2/2] ARC: [plat-hsdk]: Add missing FIFO size entry in GMAC node

2019-05-20 Thread Jose Abreu
Add the binding for RX/TX fifo size of GMAC node. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: Rob Herring Cc: Mark Rutland Cc: Vineet Gupta Cc: Eugeniy Paltsev Cc: Alexey Brodkin --- arch/arc/boot/dts/hsdk.dts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arc/boot/dts

RE: [PATCH net-next 00/18] net: stmmac: Improvements and Selftests

2019-05-24 Thread Jose Abreu
From: David Miller Date: Thu, May 23, 2019 at 17:18:14 > I'm reverting, this doesn't even build. Damn, sorry! I failed to notice that dev_set_rx_mode() is not exported :/ I will fix and resend! Thanks, Jose Miguel Abreu

[PATCH net-next v2 02/18] net: stmmac: dwmac100: Add MAC loopback support

2019-05-24 Thread Jose Abreu
In preparation for the addition of stmmac selftests we implement the MAC loopback callback in dwmac100 core. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/dwmac100_core.c | 13 + 1

[PATCH net-next v2 18/18] net: stmmac: Prevent missing interrupts when running NAPI

2019-05-24 Thread Jose Abreu
When we trigger NAPI we are disabling interrupts but in case we receive or send a packet in the meantime, as interrupts are disabled, we will miss this event. Trigger both NAPI instances (RX and TX) when at least one event happens so that we don't miss any interrupts. Signed-off-by: Jose

[PATCH net-next v2 04/18] net: stmmac: dwmac4/5: Add MAC loopback support

2019-05-24 Thread Jose Abreu
In preparation for the addition of stmmac selftests we implement the MAC loopback callback in dwmac4/5 cores. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 1 + drivers/net

[PATCH net-next v2 11/18] net: stmmac: Introduce selftests support

2019-05-24 Thread Jose Abreu
) - Do not call phy_loopback twice (Alexandre) Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe Cc: Andrew Lunn --- drivers/net/ethernet/stmicro/stmmac/Kconfig| 9 + drivers/net/ethernet/stmicro

[PATCH net-next v2 00/18] net: stmmac: Improvements and Selftests

2019-05-24 Thread Jose Abreu
Cc: Andrew Lunn Corentin Labbe (1): net: ethernet: stmmac: dwmac-sun8i: Enable control of loopback Jose Abreu (17): net: stmmac: Add MAC loopback callback to HWIF net: stmmac: dwmac100: Add MAC loopback support net: stmmac: dwmac1000: Add MAC loopback support net: stmmac: dwmac4/5

[PATCH net-next v2 16/18] net: stmmac: dwxgmac2: Do not disable whole RX in dma_stop_rx()

2019-05-24 Thread Jose Abreu
We don't need to disable the whole RX when dma_stop_rx() is called because there may be the need of just disabling 1 DMA channel. This is also needed for stmmac Flow Control selftest. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre T

[PATCH net-next v2 17/18] net: stmmac: dwmac4/5: Clear unused address entries

2019-05-24 Thread Jose Abreu
In case we don't use a given address entry we need to clear it because it could contain previous values that are no longer valid. Found out while running stmmac selftests. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- dr

[PATCH net-next v2 07/18] net: stmmac: Switch MMC functions to HWIF callbacks

2019-05-24 Thread Jose Abreu
XGMAC has a different MMC module. Lets use HWIF callbacks for MMC module so that correct callbacks are automatically selected. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/common.h

[PATCH net-next v2 08/18] net: stmmac: dwmac1000: Also pass control frames while in promisc mode

2019-05-24 Thread Jose Abreu
In order for the selftests to run the Flow Control selftest we need to also pass pause frames to the stack. Pass this type of frames while in promiscuous mode. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet

[PATCH net-next v2 15/18] net: stmmac: dwmac4/5: Do not disable whole RX in dma_stop_rx()

2019-05-24 Thread Jose Abreu
We don't need to disable the whole RX when dma_stop_rx() is called because there may be the need of just disabling 1 DMA channel. This is also needed for stmmac Flow Control selftest. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre T

[PATCH net-next v2 06/18] net: ethernet: stmmac: dwmac-sun8i: Enable control of loopback

2019-05-24 Thread Jose Abreu
From: Corentin Labbe This patch enable use of set_mac_loopback in dwmac-sun8i Signed-off-by: Corentin Labbe Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 13 + 1

[PATCH net-next v2 03/18] net: stmmac: dwmac1000: Add MAC loopback support

2019-05-24 Thread Jose Abreu
In preparation for the addition of stmmac selftests we implement the MAC loopback callback in dwmac1000 core. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 13

[PATCH net-next v2 14/18] net: stmmac: dwmac4/5: Fix Hash Filter

2019-05-24 Thread Jose Abreu
In order for hash filter to work we need to set the HPF bit. Fout out while running stmmac selftests Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 1 + drivers/net/ethernet

[PATCH net-next v2 10/18] net: stmmac: dwxgmac2: Also pass control frames while in promisc mode

2019-05-24 Thread Jose Abreu
In order for the selftests to run the Flow Control selftest we need to also pass pause frames to the stack. Pass this type of frames while in promiscuous mode. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet

[PATCH net-next v2 13/18] net: stmmac: dwmac1000: Clear unused address entries

2019-05-24 Thread Jose Abreu
In case we don't use a given address entry we need to clear it because it could contain previous values that are no longer valid. Found out while running stmmac selftests. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- dr

[PATCH net-next v2 09/18] net: stmmac: dwmac4/5: Also pass control frames while in promisc mode

2019-05-24 Thread Jose Abreu
In order for the selftests to run the Flow Control selftest we need to also pass pause frames to the stack. Pass this type of frames while in promiscuous mode. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet

[PATCH net-next v2 12/18] net: stmmac: dwmac1000: Fix Hash Filter

2019-05-24 Thread Jose Abreu
In order for hash filter to work we need to set the HPF bit. Found out while running stmmac selftests. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 1 + 1 file changed, 1

[PATCH net-next v2 05/18] net: stmmac: dwxgmac2: Add MAC loopback support

2019-05-24 Thread Jose Abreu
In preparation for the addition of stmmac selftests we implement the MAC loopback callback in dwxgmac2 core. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 1 + drivers/net

[PATCH net-next v2 01/18] net: stmmac: Add MAC loopback callback to HWIF

2019-05-24 Thread Jose Abreu
In preparation for the addition of selftests support for stmmac we add a new callback to HWIF that can be used to set the controller in loopback mode. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- drivers/net

RE: [v2, PATCH] net: stmmac: add support for hash table size 128/256 in dwmac4

2019-05-24 Thread Jose Abreu
From: biao huang Date: Fri, May 24, 2019 at 07:33:37 > any comments about this patch? Can you please test your series on top of this one [1] and let me know the output of : # ethtool -t eth0 Just to make sure that this patch does not introduce any regressions. The remaining ones of the series

RE: [v2, PATCH] net: stmmac: add support for hash table size 128/256 in dwmac4

2019-05-24 Thread Jose Abreu
From: biao huang Date: Fri, May 24, 2019 at 09:31:44 > On Fri, 2019-05-24 at 08:24 +0000, Jose Abreu wrote: > > From: biao huang > > Date: Fri, May 24, 2019 at 07:33:37 > > > > > any comments about this patch? > > > > Can you please test your ser

[RFC net-next v2 00/14] net: stmmac: Selftests

2019-05-14 Thread Jose Abreu
: stmmac: dwmac-sun8i: Enable control of loopback Jose Abreu (13): net: stmmac: Add MAC loopback callback to HWIF net: stmmac: dwmac100: Add MAC loopback support net: stmmac: dwmac1000: Add MAC loopback support net: stmmac: dwmac4/5: Add MAC loopback support net: stmmac: dwxgmac2: Add MAC

[RFC net-next v2 07/14] net: stmmac: Switch MMC functions to HWIF callbacks

2019-05-14 Thread Jose Abreu
XGMAC has a different MMC module. Lets use HWIF callbacks for MMC module so that correct callbacks are automatically selected. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac

[RFC net-next v2 12/14] net: stmmac: dwmac1000: Fix Hash Filter

2019-05-14 Thread Jose Abreu
In order for hash filter to work we need to set the HPF bit. Found out while running stmmac selftests. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 1

Re: [PATCH 1/6] net: stmmac: use correct DMA buffer size in the RX descriptor

2019-03-29 Thread Jose Abreu
On 3/27/2019 8:35 PM, Aaro Koskinen wrote: > From: Aaro Koskinen > > We always program the maximum DMA buffer size into the receive descriptor, > although the allocated size may be less. E.g. with the default MTU size > we allocate only 1536 bytes. If somebody sends us a bigger frame, then > memo

RE: [PATCH net-next v2 04/12] net: stmmac: Add Split Header support and enable it in XGMAC cores

2019-08-13 Thread Jose Abreu
++ Jakub From: David Miller Date: Aug/12/2019, 22:06:18 (UTC+00:00) > From: Jose Abreu > Date: Mon, 12 Aug 2019 11:44:03 +0200 > > > - Add performance info (David) > > Ummm... > > Whilst cpu utilization is interesting, I might be mainly interested in >

[PATCH net-next 00/12] net: stmmac: Improvements for -next

2019-08-09 Thread Jose Abreu
Couple of improvements for -next tree. More info in commit logs. --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: linux-arm-ker...@lists.infradead.org

[PATCH net-next v2 10/12] net: stmmac: xgmac: Add EEE support

2019-08-12 Thread Jose Abreu
Add support for EEE in XGMAC cores by implementing the necessary callbacks. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com

[PATCH net-next v2 00/12] net: stmmac: Improvements for -next

2019-08-12 Thread Jose Abreu
Couple of improvements for -next tree. More info in commit logs. --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: linux-arm-ker...@lists.infradead.org

[PATCH net-next v2 06/12] net: stmmac: dwxgmac: Add Flexible PPS support

2019-08-12 Thread Jose Abreu
Add the support for Flexible PPS in XGMAC cores. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: lin

[PATCH net-next v2 08/12] net: stmmac: Add support for SA Insertion/Replacement in XGMAC cores

2019-08-12 Thread Jose Abreu
Add the support for Source Address Insertion and Replacement in XGMAC cores. Two methods are supported: Descriptor based and register based. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coqueli

[PATCH net-next v2 12/12] net: stmmac: selftests: Add selftest for VLAN TX Offload

2019-08-12 Thread Jose Abreu
Add 2 new selftests for VLAN Insertion offloading. Tests are for inner and outer VLAN offloading. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-s

[PATCH net-next v2 11/12] net: stmmac: Add support for VLAN Insertion Offload

2019-08-12 Thread Jose Abreu
Adds the logic to insert a given VLAN ID in a packet. This is offloaded to HW and its descriptor based. For now, only XGMAC implements the necessary callbacks. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxim

[PATCH net-next v2 03/12] net: stmmac: xgmac: Correctly return that RX descriptor is not last one

2019-08-12 Thread Jose Abreu
Return the correct value when RX descriptor is not the last one. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: lin

[PATCH net-next v2 02/12] net: stmmac: Prepare to add Split Header support

2019-08-12 Thread Jose Abreu
In order to add Split Header support, stmmac_rx() needs to take into account that packet may be split accross multiple descriptors. Refactor the logic of this function in order to support this scenario. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu

[PATCH net-next v2 05/12] net: stmmac: Add a counter for Split Header packets

2019-08-12 Thread Jose Abreu
Add a counter that increments each time a packet with split header is received. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormre

[PATCH net-next v2 09/12] net: stmmac: selftests: Add tests for SA Insertion/Replacement

2019-08-12 Thread Jose Abreu
Add 4 new tests: - SA Insertion (register based) - SA Insertion (descriptor based) - SA Replacament (register based) - SA Replacement (descriptor based) Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "Da

<    1   2   3   4   5   6   7   8   9   >