[PATCH v5 05/10] drm: arcpgu: Use crtc->mode_valid() callback

this clock does not support all the needed ranges. Also, remove the atomic_check() callback as mode_valid() callback will be called before. Signed-off-by: Jose Abreu <joab...@synopsys.com> Reviewed-by: Alexey Brodkin <abrod...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.

[PATCH v5 08/10] drm/arm: malidp: Use crtc->mode_valid() callback

: Not even compiled tested Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Liviu Dudau <liviu.du...@arm.com> Cc: Brian Starkey <brian.star...@arm.com> Cc: David Airlie <airl...@l

[PATCH v5 10/10] drm: vc4: Use crtc->mode_valid() and encoder->mode_valid() callbacks

. NOTE: Not even compiled tested Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Eric Anholt <e...@anholt.net> Cc: David Airlie <airl...@linux.ie> --- drivers/gpu/drm/vc4/vc4_crtc

[PATCH v5 07/10] drm/bridge/synopsys: dw-hdmi: Use bridge->mode_valid() callback

validation. NOTE: Only compile tested NOTE 2: I also had to change the pdata declaration of mode_valid custom callback so that the passed modes are const. I also changed in the platforms I found. Not even compiled it though. Signed-off-by: Jose Abreu <joab...@synopsys.com> Acked-by: Neil Arm

[PATCH v5 09/10] drm/atmel-hlcdc: Use crtc->mode_valid() callback

: Not even compiled tested Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Boris Brezillon <boris.brezil...@free-electrons.com> Cc: David Airlie <airl...@linux.ie> --

[PATCH v4 01/10] drm: Add drm_{crtc/encoder/connector}_mode_valid()

Add a new helper to call crtc->mode_valid, connector->mode_valid and encoder->mode_valid callbacks. Suggested-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Jose Abreu <joab...@synopsys.com> Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch> Revie

[PATCH v4 07/10] drm/bridge/synopsys: dw-hdmi: Use bridge->mode_valid() callback

validation. NOTE: Only compile tested NOTE 2: I also had to change the pdata declaration of mode_valid custom callback so that the passed modes are const. I also changed in the platforms I found. Not even compiled it though. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha

[PATCH v4 04/10] drm: Use mode_valid() in atomic modeset

be accepted in every components. Signed-off-by: Jose Abreu <joab...@synopsys.com> Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@syno

[PATCH v4 03/10] drm: Use new mode_valid() helpers in connector probe helper

ode loops through all the connector's encodersXbridgesXcrtcs and calls the callback. If at least a valid encoderXbridgeXcrtc combination is found which accepts the mode then the function returns MODE_OK. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synops

[PATCH v4 08/10] drm/arm: malidp: Use crtc->mode_valid() callback

: Not even compiled tested Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Dave Airlie

[PATCH v4 06/10] drm/bridge: analogix-anx78xx: Use bridge->mode_valid() callback

: Only compile tested. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Dave Airlie

[PATCH v4 10/10] drm: vc4: Use crtc->mode_valid() and encoder->mode_valid() callbacks

. NOTE: Not even compiled tested Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Dav

[PATCH v4 05/10] drm: arc: Use crtc->mode_valid() callback

this clock does not support all the needed ranges. Also, remove the atomic_check() callback as mode_valid() callback will be called before. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.com>

[PATCH v4 00/10] Introduce new mode validation callbacks

ment it. [1] https://patchwork.kernel.org/patch/9702233/ [2] https://lists.freedesktop.org/archives/dri-devel/2017-May/141761.html Jose Abreu (10): drm: Add drm_{crtc/encoder/connector}_mode_valid() drm: Introduce drm_bridge_mode_valid() drm: Use new mode_valid() helpers in connector probe

[PATCH v4 02/10] drm: Introduce drm_bridge_mode_valid()

Introduce a new helper function which calls mode_valid() callback for all bridges in an encoder chain. Signed-off-by: Jose Abreu <joab...@synopsys.com> Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abro

[PATCH v4 09/10] drm/atmel-hlcdc: Use crtc->mode_valid() callback

: Not even compiled tested Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Dav

[PATCH 3/4] MAINTAINERS: Add entry for Synopsys Designware HDMI drivers

Add a entry for Synopsys Designware HDMI Receivers drivers and phys. Signed-off-by: Jose Abreu <joab...@synopsys.com> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 053c3bd..e798040 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1

[PATCH 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

sources might not be very stable at sending the video (i.e. we must react accordingly). Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk...@cis

[PATCH 1/4] [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver

. configuration functions) and the controller must provide read/write callbacks, as well as other specific functions. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk..

[PATCH 0/4] Synopsys Designware HDMI Video Capture Controller + PHY

several audio output interfaces). Jose Abreu (4): [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver [media] platform: Add Synopsys Designware HDMI RX Controller Driver MAINTAINERS: Add entry for Synopsys Designware HDMI drivers dt-bindings: media: Document Synopsys Designware

[PATCH 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

Document the bindings for the Synopsys Designware HDMI RX. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Rob Herring <robh...@kernel.org> --- .../devicetree/bindings/media/snps,dw-hdmi-rx.txt | 41 ++ 1 file changed, 41 insertions(+) create mode 100644 D

Re: [PATCH 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

Hi Hans, On 13-06-2017 11:01, Jose Abreu wrote: [snip] > Changes from RFC: > - Added support for HDCP 1.4 [snip] > + > +/* HDCP 1.4 */ > +#define DW_HDMI_HDCP14_BKSV_SIZE 2 > +#define DW_HDMI_HDCP14_KEYS_SIZE (2 * 40) > + > +struct dw_hdmi_hdcp1

Re: [PATCH 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

On 13-06-2017 11:54, Hans Verkuil wrote: > On 06/13/17 12:31, Hans Verkuil wrote: >> On 06/13/17 12:06, Jose Abreu wrote: >>> Hi Hans, >>> >>> >>> On 13-06-2017 11:01, Jose Abreu wrote: >>> >>> [snip] >>>> Changes from RF

Re: [PATCH] drm: bridge: synopsys/dw-hdmi: Provide default configuration function for HDMI 2.0 PHY

Hi Laurent, Sorry for the late reply! On 10-06-2017 09:50, Laurent Pinchart wrote: > Hi Jose, > > On Friday 09 Jun 2017 13:53:12 Jose Abreu wrote: >> On 09-06-2017 12:04, Jose Abreu wrote: >>> Currently HDMI 2.0 PHYs do not have a default configuration function. &g

[PATCH] drm: bridge: synopsys/dw-hdmi: Provide default configuration function for HDMI 2.0 PHY

prefer the pdata provided configuration function over the internal one. This patch is based on today's drm-misc-next branch. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Cc: Laurent Pinchart <laurent.pinchart+rene...@i

Re: [PATCH] drm: bridge: synopsys/dw-hdmi: Provide default configuration function for HDMI 2.0 PHY

Hi Mark, On 09-06-2017 12:04, Jose Abreu wrote: > Currently HDMI 2.0 PHYs do not have a default configuration function. > > As these PHYs have the same register layout as the 3D PHYs we can > safely use the default configuration function. I may have been a little to f

[PATCH v2 3/4] MAINTAINERS: Add entry for Synopsys Designware HDMI drivers

Add a entry for Synopsys Designware HDMI Receivers drivers and phys. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 053c3bd..e7

[PATCH v2 1/4] [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver

. configuration functions) and the controller must provide read/write callbacks, as well as other specific functions. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk..

[PATCH v2 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

sources might not be very stable at sending the video (i.e. we must react accordingly). Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk...@cis

[PATCH v2 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

Document the bindings for the Synopsys Designware HDMI RX. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Rob Herring <robh...@kernel.org> Cc: Mark Rutland <mark.rutl...@arm.com> Cc: Mauro Carvalho Chehab <mche...@kern

[PATCH v2 0/4] Synopsys Designware HDMI Video Capture Controller + PHY

several audio output interfaces). Version 2 is just a respin of the previous version with some minor bug fixes in the controller driver and I also added CEC support. This series was tested in a FPGA platform. Jose Abreu (4): [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver [media

Re: [PATCH v2 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

Hi Hans, On 16-06-2017 13:38, Hans Verkuil wrote: > Hi Jose, > > Just a quick review of the new CEC code: Thanks! > > On 06/16/17 12:07, Jose Abreu wrote: >> This is an initial submission for the Synopsys Designware HDMI RX >> Controller Driver. This driver int

Re: [PATCH v2 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

Hi Hans, On 16-06-2017 14:44, Hans Verkuil wrote: > >>> >>> + /* CEC */ + dw_dev->cec_adap = cec_allocate_adapter(_hdmi_cec_adap_ops, + dw_dev, dev_name(dev), CEC_CAP_TRANSMIT | + CEC_CAP_PHYS_ADDR | CEC_CAP_LOG_ADDRS, >>> Add CEC_CAP_RC

[PATCH v3 1/4] [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver

. configuration functions) and the controller must provide read/write callbacks, as well as other specific functions. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk..

[PATCH v3 3/4] MAINTAINERS: Add entry for Synopsys Designware HDMI drivers

Add a entry for Synopsys Designware HDMI Receivers drivers and phys. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 053c3bd..e7

[PATCH v3 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

Document the bindings for the Synopsys Designware HDMI RX. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Rob Herring <robh...@kernel.org> Cc: Mark Rutland <mark.rutl...@arm.com> Cc: Mauro Carvalho Chehab <mche...@k

[PATCH v3 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

sources might not be very stable at sending the video (i.e. we must react accordingly). Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk...@cis

[PATCH v3 0/4] Synopsys Designware HDMI Video Capture Controller + PHY

several audio output interfaces). Version 3 addresses review comments from Hans Verkuil regarding CEC and also uses a CEC notifier so that userspace does not have to manually set the CEC physical address. SCDC support was also implemented. This series was tested in a FPGA platform. Jose Abreu (4

Re: [PATCH v3 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

Hi Sylwester, Thanks again for the feedback! On 18-06-2017 19:04, Sylwester Nawrocki wrote: > On 06/16/2017 06:38 PM, Jose Abreu wrote: >> This is an initial submission for the Synopsys Designware HDMI RX >> Controller Driver. This driver interacts with a phy driver so that >

Re: [PATCH v3 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

Hi Sylwester, Thanks for the feedback! On 18-06-2017 18:34, Sylwester Nawrocki wrote: > Hi Jose, > > On 06/16/2017 06:38 PM, Jose Abreu wrote: >> Document the bindings for the Synopsys Designware HDMI RX. >> >> Signed-off-by: Jose Abreu <joab...@synopsys.com>

Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

Hi Daniel, On 03-05-2017 16:00, Daniel Vetter wrote: > On Wed, May 03, 2017 at 03:16:13PM +0100, Jose Abreu wrote: >> Hi Daniel, >> >> >> On 03-05-2017 07:19, Daniel Vetter wrote: >>> On Tue, May 2, 2017 at 11:29 AM, Jose Abreu <jose.ab...@synopsys.com&g

Re: [PATCH 2/5] drm: Use new mode_valid() helpers in connector probe helper

Hi Daniel, On 08-05-2017 08:50, Daniel Vetter wrote: > On Thu, May 04, 2017 at 03:11:39PM +0100, Jose Abreu wrote: >> This changes the connector probe helper function to use the new >> encoder->mode_valid() and crtc->mode_valid() helper callbacks to >> validate the mod

Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

Hi Daniel, On 02-05-2017 09:48, Daniel Vetter wrote: > On Wed, Apr 26, 2017 at 11:48:34AM +0100, Jose Abreu wrote: >> Some crtc's may have restrictions in the mode they can display. In >> this patch a new callback (crtc->mode_valid()) is introduced that >> is

Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

Hi Daniel, On 04-05-2017 11:21, Jose Abreu wrote: > Hi Daniel, > > > On 03-05-2017 16:00, Daniel Vetter wrote: >> On Wed, May 03, 2017 at 03:16:13PM +0100, Jose Abreu wrote: >>> Hi Daniel, >>> >>> >>> On 03-05-2017 07:19, Daniel Vetter w

[PATCH 5/5] drm: arc: Use crtc->mode_valid() callback

this clock does not support all the needed ranges. Also, remove the atomic_check() callback as mode_valid() callback will be called before. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.com>

[PATCH 3/5] drm: Introduce drm_bridge_mode_valid()

Introduce a new helper function which calls mode_valid() callback for all bridges in an encoder chain. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.com> Cc: Ville Syrjälä <ville.syrj..

[PATCH 2/5] drm: Use new mode_valid() helpers in connector probe helper

gh all the connector's encodersXcrtcs and calls the callback. If at least a valid encoderXcrtc combination is found which accepts the mode then the function returns MODE_OK. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abro

[PATCH 1/5] drm: Add crtc/encoder/bridge->mode_valid() callbacks

. Only the callbacks were implemented to simplify review process, following patches will make use of them. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.com> Cc: Ville Syrjälä <ville.syrj...@linux.

[PATCH 4/5] drm: Use mode_valid() in atomic modeset

be accepted in every components. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc:

[PATCH 0/5] Introduce new mode validation callbacks

e the new crtc->mode_valid() callback in arcpgu and remove the atomic_check() callback. [1] https://patchwork.kernel.org/patch/9702233/ Jose Abreu (5): drm: Add crtc/encoder/bridge->mode_valid() callbacks drm: Use new mode_valid() helpers in connector probe helper drm: Introduce drm_br

Re: [PATCH 2/5] drm: Use new mode_valid() helpers in connector probe helper

Hi Ville, On 04-05-2017 15:32, Ville Syrjälä wrote: > On Thu, May 04, 2017 at 03:11:39PM +0100, Jose Abreu wrote: >> This changes the connector probe helper function to use the new >> encoder->mode_valid() and crtc->mode_valid() helper callbacks to >> validate the mod

Re: [PATCH 4/5] drm: Use mode_valid() in atomic modeset

Hi Ville, On 04-05-2017 15:40, Ville Syrjälä wrote: > On Thu, May 04, 2017 at 03:11:41PM +0100, Jose Abreu wrote: >> This patches makes use of the new mode_valid() callbacks introduced >> previously to validate the full video pipeline when modesetting. >> >> This call

Re: [RESEND RFC PATCH 0/7] sun8i H3 HDMI glue driver for DW HDMI

Hi Jernej, On 20-09-2017 21:01, Jernej Skrabec wrote: > [added media mailing list due to CEC question] > > This patch series adds a HDMI glue driver for Allwinner H3 SoC. For now, only > video and CEC functionality is supported. Audio needs more tweaks. > > Series is based on the H3 DE2 patch

Re: [PATCH v8 0/5] Synopsys Designware HDMI Video Capture Controller + PHY

equested' since it depends >> on >> Sakari's subnotifier work. Once that is accepted I assume you'll make a v9 >> on top >> and then this can hopefully be merged. >> >> Regards, >> >> Hans >> >> On 10/07/17 17:46, Jose Abreu wrote: &

Re: [PATCH v2 04/11] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

++ Joao, ++ Luis Hi Hans, We will take a look into this. Thanks for pointing this out! Best Regards, Jose Miguel Abreu On 27-11-2017 12:01, Hans Verkuil wrote: > I'm CC-ing Jose Abreu from Synopsys to this. Jose, can you or a colleague take > a look at this as well? > > Jacob, I ha

Re: xf86-video-armada via UDL [was: Re: UDL's fbdev doesn't work for user-space apps]

Hi Alexey, On 04-12-2017 17:29, Alexey Brodkin wrote: > > Indeed, in case of kmscube etnaviv is a renderer while UDL > outputs the picture on the screen. Thats nice :) Ok, from your logs I was not able to see anything wrong. X server does not error exit and Prime seems to be working in DRM ...

Re: xf86-video-armada via UDL [was: Re: UDL's fbdev doesn't work for user-space apps]

On 04-12-2017 16:00, Alexey Brodkin wrote: > [30.763] (II) armada(0): etnaviv: Xv: using YUY2 format intermediate YUV > target > I'm wondering if this means that target format for UDL is YUV ... But anyway, I revisited your first email and noticed that you said kmscube runs fine. Is this

Re: [PATCH v10 4/4] [media] platform: Add Synopsys DesignWare HDMI RX Controller Driver

Hi Hans, On 13-12-2017 10:00, Hans Verkuil wrote: > On 12/12/17 17:02, Jose Abreu wrote: >> >>>> +static int dw_hdmi_s_routing(struct v4l2_subdev *sd, u32 input, u32 >>>> output, >>>> + u32 config) >>>

Re: [PATCH v10 4/4] [media] platform: Add Synopsys DesignWare HDMI RX Controller Driver

Hi Hans, On 13-12-2017 20:49, Hans Verkuil wrote: > On 13/12/17 15:00, Jose Abreu wrote: >> >> Indeed. I compared the values with the spec and they are not >> correct. Even hsync is wrong. I already corrected in the code the >> hsync but regarding interlace I'm n

Re: [PATCH AUTOSEL for 4.9 44/56] ASoC: dwc: Fix PIO mode initialization

On 15-11-2017 13:20, Mark Brown wrote: > > Why on earth would anyone use audio hardware without DMA in production > (or make it for that matter)? Not that it really matters. That was my thought while I was implementing this. I guess HW guys had their reasons. > Even if > there are users on

Re: [PATCH AUTOSEL for 4.9 44/56] ASoC: dwc: Fix PIO mode initialization

Hi Mark, On 15-11-2017 10:54, Mark Brown wrote: > On Wed, Nov 15, 2017 at 02:45:45AM +, alexander.le...@verizon.com wrote: > >> We can no longer rely on the return value of >> devm_snd_dmaengine_pcm_register(...) to check if the DMA >> handle is declared in the DT. >> Previously this check

Re: PROBLEM: Asus C201 video mode problems on HDMI hotplug (regression)

Hi Nick, On 01-12-2017 00:11, Nick Bowler wrote: > Hi, > > On 2017-11-27 22:30 -0500, Nick Bowler wrote: >> A note about the test setup: I had to remove the test equipment so I >> no longer have any information about the video mode from the sink side >> (like in the photos). Thus, with the

Re: PROBLEM: Asus C201 video mode problems on HDMI hotplug (regression)

On 03-12-2017 05:20, Nick Bowler wrote: > > Your patch changes things. With this applied on top of 4.15-rc1 > it is failing 100% of the time instead of only half of the time. Ok, it was a long shot anyway. > > I brought the original test equipment back to the setup so I can > see the video and

Re: UDL's fbdev doesn't work for user-space apps

Hi Alexey, On 04-12-2017 11:32, Alexey Brodkin wrote: > My first [probably incorrect] assumption is Xserver requires fbdev (/dev/fbX) > and it cannot use DRI video card natively. Is that correct? > > Xserver can use DRI directly, you need to enable modesetting driver in Xorg config or use the

Re: xf86-video-armada via UDL [was: Re: UDL's fbdev doesn't work for user-space apps]

On 04-12-2017 13:16, Alexey Brodkin wrote: > Option "kmsdev" "/dev/dri/card1" Which drm driver uses /dev/dri/card0? I'm seing drmOpen code and if you don't specify the busID it will fallback for the first card that matches "armada-drm" or "imx-drm" or "udl". > But if I swap

Re: xf86-video-armada via UDL [was: Re: UDL's fbdev doesn't work for user-space apps]

On 04-12-2017 14:53, Alexey Brodkin wrote: > Full log you may find below. Sorry but I meant /var/log/Xorg.0.log file.

[PATCH v9 3/4] [media] platform: Add Synopsys DesignWare HDMI RX PHY e405 Driver

. configuration functions) and the controller must provide read/write callbacks, as well as other specific functions. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Joao Pinto <jpi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk...@cis

[PATCH v9 0/4] Synopsys DesignWare HDMI Video Capture Controller + PHY

several audio output interfaces). Version 9 implements the work developed by Sakari Ailus regarding subdevices pipelines registration. This series was tested in a FPGA platform using an embedded platform called ARC AXS101. Jose Abreu (4): dt-bindings: media: Document Synopsys DesignWare HDMI RX

[PATCH v9 4/4] [media] platform: Add Synopsys DesignWare HDMI RX Controller Driver

sources might not be very stable at sending the video (i.e. we must react accordingly). Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Joao Pinto <jpi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk...@cis

[PATCH v9 1/4] dt-bindings: media: Document Synopsys DesignWare HDMI RX

Document the bindings for the Synopsys DesignWare HDMI RX. Signed-off-by: Jose Abreu <joab...@synopsys.com> Acked-by: Rob Herring <r...@kernel.org> (v8) Cc: Joao Pinto <jpi...@synopsys.com> Cc: Rob Herring <robh...@kernel.org> Cc: Mark Rutland <mark.rutl...@arm.com

[PATCH v9 2/4] MAINTAINERS: Add entry for Synopsys DesignWare HDMI drivers

Add an entry for Synopsys DesignWare HDMI Receivers drivers and phys. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Joao Pinto <jpi...@synopsys.com> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7a52a66..a1

Re: [PATCH v4 0/9] drm/i915: Implement HDCP

Hi Sean, On 07-12-2017 00:00, Sean Paul wrote: > Welcome to version 4 of the patchset. I think we're nearing the finish line > (hopefully) now. This set addresses the review feedback from v3. I applied > some > R-b's from v3 review, and converted others to Cc since other changes were made > to

Re: [PATCH v9 4/4] [media] platform: Add Synopsys DesignWare HDMI RX Controller Driver

Hi Hans, On 07-12-2017 12:33, Hans Verkuil wrote: > Hi Jose, > > Some (small) comments below: Thanks for the review! > > On 12/07/17 10:47, Jose Abreu wrote: >> This is an initial submission for the Synopsys DesignWare HDMI RX >> Controller Driver. This driver int

Re: [PATCH v2 net-next] net: stmmac: Add support for DWMAC5 with TSN features

Hi David, Florian, On 01-11-2017 11:48, David Miller wrote: > From: Jose Abreu <jose.ab...@synopsys.com> > Date: Fri, 27 Oct 2017 14:55:44 +0100 > >> This adds support for IP version 5 of DWMAC. The new introduced >> features are the Enhancements to Scheduled

[PATCH v10 4/4] [media] platform: Add Synopsys DesignWare HDMI RX Controller Driver

sources might not be very stable at sending the video (i.e. we must react accordingly). Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Joao Pinto <jpi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk...@cis

[PATCH v10 2/4] MAINTAINERS: Add entry for Synopsys DesignWare HDMI drivers

Add an entry for Synopsys DesignWare HDMI Receivers drivers and phys. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Joao Pinto <jpi...@synopsys.com> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7a52a66..a1

[PATCH v10 3/4] [media] platform: Add Synopsys DesignWare HDMI RX PHY e405 Driver

. configuration functions) and the controller must provide read/write callbacks, as well as other specific functions. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Joao Pinto <jpi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk...@cis

[PATCH v10 0/4] Synopsys DesignWare HDMI Video Capture Controller + PHY

several audio output interfaces). Version 10 addresses review comments from Hans Verkuil and from Philippe Ombredanne. This series was tested in a FPGA platform using an embedded platform called ARC AXS101. Jose Abreu (4): dt-bindings: media: Document Synopsys DesignWare HDMI RX MAINTAINERS: Add

[PATCH v10 1/4] dt-bindings: media: Document Synopsys DesignWare HDMI RX

Document the bindings for the Synopsys DesignWare HDMI RX. Signed-off-by: Jose Abreu <joab...@synopsys.com> Acked-by: Rob Herring <r...@kernel.org> (v8) Cc: Joao Pinto <jpi...@synopsys.com> Cc: Rob Herring <robh...@kernel.org> Cc: Mark Rutland <mark.rutl...@arm.com

Re: xf86-video-armada via UDL [was: Re: UDL's fbdev doesn't work for user-space apps]

On 05-12-2017 11:53, Alexey Brodkin wrote: > > From my note above about udl_drm_gem_mmap() being only used in case of Xserver > I barely may conclude anything. Given my lack of knowledge of DRM guts > especially > when it comes to complicated cases with DMA buffer exports/imports I cannot > say >

Re: [PATCH v10 4/4] [media] platform: Add Synopsys DesignWare HDMI RX Controller Driver

Hi Hans, On 12-12-2017 15:47, Hans Verkuil wrote: > Hi Jose, > > Some more comments: Thanks for the review! > > On 11/12/17 18:41, Jose Abreu wrote: >> This is an initial submission for the Synopsys DesignWare HDMI RX >> Controller Driver. This driver int

[PATCH net-next 1/2] net: stmmac: Add support for DWMAC5 with TSN features

transmission in this time window/slot. FPE: The IEEE802.1Qbu defines a mechanism which breaks interfering frames into smaller fragments shuch that we have a more efficient use of network bandwidth. This needs EST enabled. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: David S. Mill

[PATCH net-next 2/2] bindings: net: stmmac: Add documentation for TSN parameters

This adds the documentation for TSN feature EST and FP. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: David S. Miller <da...@davemloft.net> Cc: Joao Pinto <jpi...@synopsys.com> Cc: Giuseppe Cavallaro <peppe.cavall...@st.com> Cc: Alexandre Torgue <alexandre.tor

[PATCH net-next 0/2] net: stmmac: Support DWMAC5 and TSN

Hi, This adds support for a new IP version (5) of dwmac and for TSN features as defined by IEEE802.1Qbv-2015 and IEEE802.1Qbu. Please review. Best regards, Jose Miguel Abreu Jose Abreu (2): net: stmmac: Add support for DWMAC5 with TSN features bindings: net: stmmac: Add documentation

Re: [PATCH net-next 2/2] bindings: net: stmmac: Add documentation for TSN parameters

Hi Florian, On 25-10-2017 20:34, Florian Fainelli wrote: > On 10/25/2017 07:04 AM, Jose Abreu wrote: >> This adds the documentation for TSN feature EST and FP. >> >> Signed-off-by: Jose Abreu <joab...@synopsys.com> >> Cc: David S. Miller <da...@d

[PATCH net] net: stmmac: dwc-qos-eth: Fix typo in DT bindings parsing

According to DT bindings documentation we are expecting a property called "snps,read-requests" but we are parsing instead a property called "read,read-requests". This is clearly a typo. Fix it. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Joao Pinto <jpi

[PATCH net] net: stmmac: First Queue must always be in DCB mode

According to DWMAC databook the first queue operating mode must always be in DCB. As MTL_QUEUE_DCB = 1, we need to always set the first queue operating mode to DCB otherwise driver will think that queue is in AVB mode (because MTL_QUEUE_AVB = 0). Signed-off-by: Jose Abreu <joab...@synopsys.

Re: [PATCH net-next 2/2] bindings: net: stmmac: Add documentation for TSN parameters

Hi Andrew, On 26-10-2017 10:03, Andrew Lunn wrote: >> These parameters may also need to change in runtime depending on >> the scheduled traffic. Unfortunately, net subsystem does not yet >> support TSN so this will have to wait and for now we will use >> fixed parameters. > Hi Jose > > what you

Re: [PATCH net-next 2/2] bindings: net: stmmac: Add documentation for TSN parameters

Hi Andrew, On 26-10-2017 10:03, Andrew Lunn wrote: >> These parameters may also need to change in runtime depending on >> the scheduled traffic. Unfortunately, net subsystem does not yet >> support TSN so this will have to wait and for now we will use >> fixed parameters. > Hi Jose > > what you

Re: [BUG] net: stmmac: dwmac-sun8i broken in linux-next

Hi Corentin, On 16-05-2018 19:32, Corentin Labbe wrote: > Hello > > The dwmac-sun8i driver is broken in next-20180515, symptom are no RX and TX > errors as shown by ifconfig: > eth0: flags=4163 mtu 1500 > inet 192.168.1.204 netmask 255.255.255.0

Re: [PATCH net-next v2 2/2] drivers: net: Remove device_node checks with of_mdiobus_register()

| 12 +++- > drivers/net/ethernet/freescale/fec_main.c | 8 ++-- > drivers/net/ethernet/marvell/mvmdio.c | 5 + > drivers/net/ethernet/renesas/sh_eth.c | 11 +++ > drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 5 +-

Re: [PATCH] net: stmmac: Avoid VLA usage

i96Vm5hJ_19IJiuxx_p_Rzo2g-uHDKw=TBD6a7UY2VbpPmV9LOW_eHAyg8uPq1ZPDhq93VROTVE=4fvOST1HhWmZ4lThQe-dHCJYEXNOwey00BCXOWm8tKo= > > Signed-off-by: Kees Cook <keesc...@chromium.org> > I rather prefer the variables declaration in reverse-tree order, but thats just a minor pick. Reviewed-by: Jose Abreu <joab...@synopsys.com

Re: [PATCH] net: stmmac: Avoid VLA usage

On 02-05-2018 13:36, Kees Cook wrote: > On Wed, May 2, 2018 at 1:54 AM, Jose Abreu <jose.ab...@synopsys.com> wrote: >> Hi Kees, >> >> On 01-05-2018 22:01, Kees Cook wrote: >>> In the quest to remove all stack VLAs from the kernel[1], this switches

Re: [PATCH] net: dwc-xlgmac: fix xlgmac_xmit()'s return type

On 24-04-2018 14:17, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > > Signed-off-by: Luc

Re: [PATCH net] net: stmmac: First Queue must always be in DCB mode

Hi Bhadram, On 26-10-2017 11:51, Bhadram Varka wrote: > Hi Jose, > >> -Original Message- >> From: netdev-ow...@vger.kernel.org [mailto:netdev- >> ow...@vger.kernel.org] On Behalf Of Jose Abreu >> Sent: Thursday, October 26, 2017 2:37 PM >> To:

Re: [PATCH net-next 0/2] net: stmmac: Support DWMAC5 and TSN

Hi Jesus, On 26-10-2017 17:28, Jesus Sanchez-Palencia wrote: > Hi Jose, > > > On 10/25/2017 07:02 AM, Jose Abreu wrote: >> Hi, >> >> This adds support for a new IP version (5) of dwmac and for >> TSN features as defined by IEEE802.1Qbv-2015 and IEEE802.1Qbu

Re: [PATCH net-next 2/2] bindings: net: stmmac: Add documentation for TSN parameters

Hi Jesus, On 26-10-2017 17:23, Jesus Sanchez-Palencia wrote: > Hi Jose, > > > On 10/26/2017 03:08 AM, Jose Abreu wrote: >> Hi Andrew, >> >> On 26-10-2017 10:03, Andrew Lunn wrote: >>>> These parameters may also need to change in runtime depending on >

Re: [PATCH net-next 2/2] bindings: net: stmmac: Add documentation for TSN parameters

Hi Andrew, On 26-10-2017 22:56, Andrew Lunn wrote: >> About my patches, what I think would be better now would be to >> drop the configuration by DT and integrate the remaining >> configuration, letting the EST parameters be populated by SoC >> specific wrappers. > Hi Jose > > The problem with

Re: [PATCH net] net: stmmac: First Queue must always be in DCB mode

On 26-10-2017 15:44, Bhadram Varka wrote: > Hi Jose, > >> -Original Message----- >> From: Jose Abreu [mailto:jose.ab...@synopsys.com] >> Sent: Thursday, October 26, 2017 5:19 PM >> To: Bhadram Varka <vbhad...@nvidia.com>; net...@vger.kernel.org; >>

[PATCH net-next 1/3] net: stmmac: Add missing call to dev_kfree_skb()

When RX HW timestamp is enabled and a frame is discarded we are not freeing the skb but instead only setting to NULL the entry. Add a call to dev_kfree_skb_any() so that skb entry is correctly freed. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: David S. Miller <da...@davemlof

<    1   2   3   4   5   6   7   8   9   10   >