On Thu, 28 Dec 2017, Ingo Molnar wrote:
>
> * Julia Lawall wrote:
>
> >
> >
> > On Thu, 28 Dec 2017, Ingo Molnar wrote:
> >
> > >
> > > * Julia Lawall wrote:
> > >
> > > > > > [...] There does seem to be a few ca
On Mon, 1 Jan 2018, Aishwarya Pant wrote:
> Right now, the decription of the rtc and sysfs interfaces is in
> Documentation/rtc.txt. Since these are a part of the ABI, they should be
> in Documentation/ABI along with the rest.
>
> Signed-off-by: Aishwarya Pant
> ---
> Let me know if the contact
On Mon, 1 Jan 2018, Masahiro Yamada wrote:
> 2017-12-30 3:14 GMT+09:00 Jérémy Lefaure :
> > Rule r does not depend on rule i (which is the include of
> > linux/kernel.h) so the output should not depend on i in
> > org and report mode.
> >
> > Signed-off-by: Jé
On Sun, 31 Dec 2017, Himanshu Jha wrote:
> On Sun, Dec 31, 2017 at 07:46:09AM -0800, Joe Perches wrote:
> > On Sun, 2017-12-31 at 17:54 +0530, Himanshu Jha wrote:
> > > Use dma_zalloc_coherent for allocating zeroed
> > > memory and remove unnecessary memset function.
> > >
> > > Done using Cocci
On Fri, 29 Dec 2017, Jérémy Lefaure wrote:
> Rule r does not depend on rule i (which is the include of
> linux/kernel.h) so the output should not depend on i in
> org and report mode.
>
> Signed-off-by: Jérémy Lefaure
> Acked-by: Julia Lawall
Re-Acked-by: Julia Lawall
On Sat, 30 Dec 2017, Masahiro Yamada wrote:
> 2017-12-27 6:40 GMT+09:00 Himanshu Jha :
> > There are many instances where memory is allocated using regular
> > allocator
> > functions immediately followed by setting the allocated memory
> > to 0 value using memset.
> >
> > We already have zero m
On Fri, 29 Dec 2017, Jérémy Lefaure wrote:
> Hi,
>
> On Thu, 14 Sep 2017 13:21:13 +0200 (CEST)
> Julia Lawall wrote:
>
> > On Wed, 13 Sep 2017, Jérémy Lefaure wrote:
> >
> > > Rule r does not depend on rule i (which is the include of
> > > linux/k
Hello,
Many of the x86 pipeline.json files have the brief description "Total
execution stalls" for both CYCLE_ACTIVITY.CYCLES_NO_EXECUTE and
CYCLE_ACTIVITY.STALLS_TOTAL. Should the case for
CYCLE_ACTIVITY.CYCLES_NO_EXECUTE have a brief description that mentions
cycles? Some of the files do have
On Thu, 28 Dec 2017, Ingo Molnar wrote:
>
> * Julia Lawall wrote:
>
> >
> >
> > On Thu, 28 Dec 2017, Ingo Molnar wrote:
> >
> > >
> > > * Julia Lawall wrote:
> > >
> > > > > > [...] There does seem to be a few ca
On Thu, 28 Dec 2017, Ingo Molnar wrote:
>
> * Julia Lawall wrote:
>
> >
> >
> > On Thu, 28 Dec 2017, Ingo Molnar wrote:
> >
> > >
> > > * Julia Lawall wrote:
> > >
> > > > > > [...] There does seem to be a few ca
On Thu, 28 Dec 2017, Ingo Molnar wrote:
>
> * Julia Lawall wrote:
>
> > > > [...] There does seem to be a few cases where the field actually does
> > > > hold an
> > > > integer. I guess this is not a problem?
> > >
> > &
On Thu, 28 Dec 2017, Ingo Molnar wrote:
>
> * Julia Lawall wrote:
>
> >
> >
> > On Thu, 28 Dec 2017, Ingo Molnar wrote:
> >
> > >
> > > * Andy Shevchenko wrote:
> > >
> > > > On Thu, 2017-12-28 at 11:28 +0100, Ingo Mol
On Thu, 28 Dec 2017, Ingo Molnar wrote:
>
> * Andy Shevchenko wrote:
>
> > On Thu, 2017-12-28 at 11:28 +0100, Ingo Molnar wrote:
> > > * Andy Shevchenko wrote:
> > >
> > > > The annoying static analyzer follow up patches make a pain rather
> > > > then
> > > > fixing issues.
> > > >
> > > > Th
On Thu, 28 Dec 2017, Ingo Molnar wrote:
>
> * Julia Lawall wrote:
>
> >
> >
> > On Thu, 28 Dec 2017, Ingo Molnar wrote:
> >
> > >
> > > * Andy Shevchenko wrote:
> > >
> > > > The annoying static analyzer follow up patche
On Thu, 28 Dec 2017, Ingo Molnar wrote:
>
> * Andy Shevchenko wrote:
>
> > The annoying static analyzer follow up patches make a pain rather then
> > fixing issues.
> >
> > The one done by commit 276c87054751
> >
> > ("x86/platform/intel-mid: Make 'bt_sfi_data' const")
> >
> > made an obvious r
On Wed, 27 Dec 2017, Ji-Hun Kim wrote:
> Clean up checkpatch warning:
> CHECK: spaces preferred around that '-' (ctx:VxV)
>
> Signed-off-by: Ji-Hun Kim
> ---
> drivers/staging/iio/adc/ad7192.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/adc/ad71
On Wed, 27 Dec 2017, Michel Dänzer wrote:
> On 2017-12-27 03:51 PM, Julia Lawall wrote:
> > PP_ASSERT_WITH_CODE prints a newline at the end of the message string,
> > so the message string does not need to include a newline explicitly.
> > Done using Coccinelle.
> &g
DCCP_CRIT prints some other text and then a newline after the message
string, so the message string does not need to include a newline
explicitly. Done using Coccinelle.
Signed-off-by: Julia Lawall
---
net/dccp/ackvec.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
left as is.
Signed-off-by: Julia Lawall
---
drivers/block/DAC960.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c
index 442e777..89cd83a 100644
--- a/drivers/block/DAC960.c
+++ b/drivers/block/DAC960.c
@@ -1344,7 +1344,7
ext2_msg prints a newline at the end of the message string, so the message
string does not need to include a newline explicitly. Done using
Coccinelle.
Signed-off-by: Julia Lawall
---
fs/ext2/super.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext2/super.c b/fs
OVS_NLERR prints a newline at the end of the message string, so the
message string does not need to include a newline explicitly. Done
using Coccinelle.
Signed-off-by: Julia Lawall
---
net/openvswitch/conntrack.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net
Drop newline at the end of a message string when the printing function adds
a newline.
The complete semantic patch that detects this issue is as shown below
(http://coccinelle.lip6.fr/). It works in two phases - the first phase
counts how many uses of a function involve a newline and how many don
PP_ASSERT_WITH_CODE prints a newline at the end of the message string,
so the message string does not need to include a newline explicitly.
Done using Coccinelle.
Signed-off-by: Julia Lawall
---
I couldn't figure out how to configure the kernel to get any of this code
to compile.
driver
log_print prints a newline at the end of the message string, so
the message string does not need to include a newline explicitly.
Done using Coccinelle.
The two strings were additionally merged into one, for easier
grepping.
Signed-off-by: Julia Lawall
---
fs/dlm/plock.c |3 +--
1 file
hpfs_error prints a newline at the end of the message string, so the
message string does not need to include a newline explicitly. Done
using Coccinelle.
Signed-off-by: Julia Lawall
---
fs/hpfs/dnode.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/hpfs/dnode.c b
of the (.
Signed-off-by: Julia Lawall
---
tools/perf/tests/dso-data.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/tools/perf/tests/dso-data.c b/tools/perf/tests/dso-data.c
index 7f6c520..f514515 100644
--- a/tools/perf/tests/dso-data.c
+++ b/tools/perf/tests
DBF_DEV_EVENT prints a newline at the end of the message string,
so the message string does not need to include a newline explicitly.
Done using Coccinelle.
The two strings are also concatenated into one for easier grepping.
Signed-off-by: Julia Lawall
---
drivers/s390/block/dasd_diag.c
pvr2_trace prints a newline at the end of the message string, so the
message string does not need to include a newline explicitly. Done
using Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/media/usb/pvrusb2/pvrusb2-hdw.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
gpio_request uses its second argument as a label, so it doesn't seem
appropriate for it to have a newline. Done using Coccinelle.
Signed-off-by: Julia Lawall
---
arch/arm/mach-davinci/board-da850-evm.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm
hpsa_show_dev_msg prints other information and a newline after the
message string, so the message string does not need to include a
newline explicitly. Done using Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/scsi/hpsa.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
ome simple cases that are common and easy to validate
> /// Note in particular that there are no ...s in the rule, so all of the
> @@ -8,6 +8,7 @@
> // Confidence: High
> // Copyright: (C) 2009-2010 Julia Lawall, Nicolas Palix, DIKU. GPLv2.
> // Copyright: (C) 2009-2010 Gil
On Tue, 26 Dec 2017, Joe Perches wrote:
> On Tue, 2017-12-26 at 18:05 +0100, Julia Lawall wrote:
> > Inline macro for MODULE_LICENSE to make the license information easy to
> > find, eg with grep. Inline the other module-related macros at the same
> > time.
>
> Pe
On Tue, 26 Dec 2017, Joe Perches wrote:
> On Tue, 2017-12-26 at 18:05 +0100, Julia Lawall wrote:
> > Inline macro for MODULE_LICENSE to make the license information easy to
> > find, eg with grep. Inline the other module-related macros at the same
> > time.
> >
>
; expression e;
@@
#define i e
@@
declarer name MODULE_LICENSE;
identifier s.i;
expression s.e;
@@
MODULE_LICENSE(
- i
+ e
);
//
Signed-off-by: Julia Lawall
---
drivers/input/misc/keyspan_remote.c |9 +++--
drivers/input/tablet/acecad.c |9 +++--
drivers/input/tablet/hanwang.c
Inline macro for MODULE_LICENSE to make the license information easy to
find, eg with grep. Inline the other module-related macros at the same
time.
The complete semantic patch is as follows: (http://coccinelle.lip6.fr/)
//
@q@
declarer name MODULE_LICENSE;
identifier i;
constant c;
position p;
gt; +/// Use zeroing allocator rather than allocator followed by memset with 0
> ///
> /// This considers some simple cases that are common and easy to validate
> /// Note in particular that there are no ...s in the rule, so all of the
> @@ -8,6 +8,7 @@
> // Confidence: High
> // Copyright
On Wed, 20 Dec 2017, Joe Perches wrote:
> On Wed, 2017-12-20 at 10:59 +0100, Greg Kroah-Hartman wrote:
> > > > Why you didn't send that patch to the sysfs maintainer is a bit odd...
> > > > :)
> > >
> > > So here's an opportunity for you:
> > >
> > > The sysfs maintainer hasn't added include/l
On Sat, 16 Dec 2017, SF Markus Elfring wrote:
> >> Omit an extra message for a memory allocation failure in these functions.
> >
> > Because???
> >
> > Fix your commit message.
> >
> > Say _WHY_ should this be applied.
>
> I am still waiting for possibilities to improve also the corresponding
>
> diff --git a/Documentation/dev-tools/runchecks.rst
> b/Documentation/dev-tools/runchecks.rst
> new file mode 100644
> index 000..b25b3de
> --- /dev/null
> +++ b/Documentation/dev-tools/runchecks.rst
> @@ -0,0 +1,215 @@
> +.. Copyright 2017 Knut Omang
> +
> +Makefile support for running chec
On Wed, 6 Dec 2017, David Howells wrote:
> James Morris wrote:
>
> > I think a general cleanup in that function to make all of these follow the
> > pattern:
> >
> > if (something) {
> > key_ref = ERR_PTR(-error);
> > goto error;
> > }
> >
> > rather than uncondit
On Wed, 6 Dec 2017, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Wed, 6 Dec 2017 13:03:21 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring
> ---
> driver
On Tue, 5 Dec 2017, Julia Cartwright wrote:
> Now that the rx_fs_lock is no longer held across allocation, it's safe
> to use GFP_KERNEL for allocating new entries.
>
> This reverts commit 81da3bf6e3f88 ("net: macb: change GFP_KERNEL to
> GFP_ATOMIC").
>
&g
On Mon, 4 Dec 2017, Eduardo Valentin wrote:
> On Mon, Jul 17, 2017 at 04:42:38PM +0200, Julia Lawall wrote:
> >
> >
> > On Mon, 17 Jul 2017, Jon Hunter wrote:
> >
> > >
> > > On 15/07/17 09:42, Julia Lawall wrote:
> > > > Device no
Function gem_add_flow_filter called on line 2958 inside lock on line 2949
but uses GFP_KERNEL
Generated by: scripts/coccinelle/locks/call_kern.cocci
Fixes: ae8223de3df5 ("net: macb: Added support for RX filtering")
CC: Rafal Ozieblo
Signed-off-by: Julia Lawall
Signed-off-by: Fe
no, it isn't necessary.
Will someone take care of it? I'm just the 0-day proxy :)
julia
> On Tue, Nov 28, 2017 at 1:56 PM, Julia Lawall wrote:
> > This is a false positive, but I wonder if it is really necessary to put
> > the assignment in the conditional test
This is a false positive, but I wonder if it is really necessary to put
the assignment in the conditional test expression.
julia
-- Forwarded message --
Date: Tue, 28 Nov 2017 13:23:36 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: [PATCH] drm/nouveau
On Tue, 28 Nov 2017, SF Markus Elfring wrote:
> > How many times have I told you to include the reason for
> > your patches in your proposed commit message?
>
> It might be useful to look again.
>
>
> > Too often.
>
> I answered this feedback to some degree.
>
>
> > Many people do not know that
On Tue, 28 Nov 2017, SF Markus Elfring wrote:
> It seems that I got no responses so far for clarification requests
> according to the documentation in a direction I hoped for.
> >>>
> >>> That's because you are pretty unresponsive to direction.
> >>
> >> From which places did you get t
On Tue, 28 Nov 2017, SF Markus Elfring wrote:
> >> It seems that I got no responses so far for clarification requests
> >> according to the documentation in a direction I hoped for.
> >
> > That's because you are pretty unresponsive to direction.
>
> From which places did you get this impression
On Mon, 27 Nov 2017, Logan Gunthorpe wrote:
>
>
> On 27/11/17 11:57 AM, Joe Perches wrote:
> > It may or not be correct.
>
> It's absolutely not correct in that it either requires that a subsequent
> KERN_CONT/pr_cont or a '\n' at the end and it has neither.
>
> > Without inter-function call cod
On Mon, 27 Nov 2017, Joe Perches wrote:
> On Mon, 2017-11-27 at 07:08 +0100, Julia Lawall wrote:
> >
> > On Sun, 26 Nov 2017, Joe Perches wrote:
> >
> > > On Sun, 2017-11-26 at 23:44 +0100, Julia Lawall wrote:
> > > > My semantic patch and resul
On Mon, 27 Nov 2017, Joe Perches wrote:
> On Sun, 2017-11-26 at 23:40 -0700, Logan Gunthorpe wrote:
> >
> > On 26/11/17 11:34 PM, Julia Lawall wrote:
> > > It would probably be better not to mention the KERN_CONT possibility at
> > > all.
> >
> > Oh?
On Sun, 26 Nov 2017, Logan Gunthorpe wrote:
>
>
> On 26/11/17 11:42 PM, Julia Lawall wrote:
> > Although I guess that in that case the whole exercise is pointless?
> > Because every print will at runtime be followed by another print, which
> > will add either th
On Mon, 27 Nov 2017, Julia Lawall wrote:
>
>
> On Sun, 26 Nov 2017, Joe Perches wrote:
>
> > On Sun, 2017-11-26 at 19:17 +0100, Julia Lawall wrote:
> > > I just assume that a printk that has no KERN_ is adding a
> > > newline, which is my understanding of J
On Sun, 26 Nov 2017, Joe Perches wrote:
> On Sun, 2017-11-26 at 19:17 +0100, Julia Lawall wrote:
> > I just assume that a printk that has no KERN_ is adding a
> > newline, which is my understanding of Joe's comment.
>
> More precisely:
>
> Any printk without
On Sun, 26 Nov 2017, Logan Gunthorpe wrote:
>
>
> On 26/11/17 11:11 PM, Julia Lawall wrote:
> > I don't have a different warning if the string ends in a space. I have a
> > different warning when one possible control-flow path is fine and another
> > control-fl
On Sun, 26 Nov 2017, Logan Gunthorpe wrote:
>
>
> On 26/11/17 03:29 PM, Joe Perches wrote:
> > This proposal has a very high false positive rate.
>
> The only actual false positive you've pointed out is the one that is
> just incorrect in the wrong way (the author should have used a KERN_CONT
>
On Sun, 26 Nov 2017, Joe Perches wrote:
> On Sun, 2017-11-26 at 23:44 +0100, Julia Lawall wrote:
> > My semantic patch and results are below. The semantic patch has some
> > features that may or may not be desired:
> >
> > 1. It goes beyond printk, pr_xxx, dev_xxx,
On Sun, 26 Nov 2017, Logan Gunthorpe wrote:
>
>
> On 26/11/17 10:09 AM, Julia Lawall wrote:
> > I don't know. In any case, a Coccinelle script would get run by the 0-day
> > build testing service, which checks lots of trees. Perhaps both are
> > useful, sinc
On Sun, 26 Nov 2017, Logan Gunthorpe wrote:
>
>
> On 25/11/17 10:51 PM, Julia Lawall wrote:
> > I don't understand at all the second sentence. Are you staying with the
> > same call, or moving on to other calls? Also, it would be the call that
> > is sp
On Sat, 25 Nov 2017, Logan Gunthorpe wrote:
> Check for lines with a log function using a relatively strict regular
> expression catching only printk, dev_* and pr_* functions. Once
> one is found, accumulate further lines for any functions that
> are split over multiple lines.
I don't understa
On Fri, 24 Nov 2017, Adam Thomson wrote:
> On 23 November 2017 17:33, SF Markus Elfring wrote:
>
> > From: Markus Elfring
> > Date: Thu, 23 Nov 2017 17:56:54 +0100
> >
> > Omit an extra message for a memory allocation failure in this function.
>
> I'm not sure this is an extra message. We don't
On Thu, 23 Nov 2017, Greg Kroah-Hartman wrote:
> On Wed, Nov 22, 2017 at 10:20:49PM +0100, Julia Lawall wrote:
> >
> >
> > On Wed, 22 Nov 2017, Joe Perches wrote:
> >
> > > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote:
> > > > There
On Wed, 22 Nov 2017, Joe Perches wrote:
> On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote:
> > There is no need to #define the license of the driver, just put it in
> > the MODULE_LICENSE() line directly as a text string.
> >
> > This allows tools that check that the module license m
On Wed, 22 Nov 2017, Joe Perches wrote:
> On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote:
> > There is no need to #define the license of the driver, just put it in
> > the MODULE_LICENSE() line directly as a text string.
> >
> > This allows tools that check that the module license m
Function sbefifo_enq_xfr called inside lock from sbefifo_write_common but
uses GFP_KERNEL. Change to GFP_ATOMIC.
Generated by: scripts/coccinelle/locks/call_kern.cocci
Fixes: 0f8664fbfc9f ("drivers/fsi: sbefifo: Add miscdevice")
CC: Edward A. James
Signed-off-by: Julia Lawall
Sig
On Wed, 15 Nov 2017, Joe Perches wrote:
> On Wed, 2017-11-15 at 22:55 +0100, Julia Lawall wrote:
> > What version of Coccinelle do you have?
> > > I tried 1.0.4 and 1.0.6,
> > > but both failed.
> > For me, it also fails for 1.0.6. It should be OK for 1.0.7.
On Thu, 16 Nov 2017, Masahiro Yamada wrote:
> Hi Julia,
>
>
> 2017-11-15 23:51 GMT+09:00 Julia Lawall :
> >
> >
> > On Wed, 15 Nov 2017, Masahiro Yamada wrote:
> >
> >> Hi Julia,
> >>
> >>
> >> 2017-11-13 1:08 GMT+09:00 J
On Thu, 16 Nov 2017, Masahiro Yamada wrote:
> Hi Julia,
>
>
> 2017-11-15 23:51 GMT+09:00 Julia Lawall :
> >
> >
> > On Wed, 15 Nov 2017, Masahiro Yamada wrote:
> >
> >> Hi Julia,
> >>
> >>
> >> 2017-11-13 1:08 GMT+09:00 J
On Wed, 15 Nov 2017, Masahiro Yamada wrote:
> Hi Julia,
>
>
> 2017-11-13 1:08 GMT+09:00 Julia Lawall :
> > An initial rule just matching a function call makes it possible to focus
> > on one all at a time, which improves performance in complex functions with
> > mu
> > Can you try the following semantic patch (called eg nothing.cocci):
> >
> > @script:ocaml@
> > @@
> >
> > ()
> >
> > on any .c file, ie
> >
> > spatch --sp-file nothing.cocci test.c
> >
>
>
> Thanks for the simple test semantic patch!
>
>
>
> I noticed 1.0.4 is OK,
> but 1.0.5 is NG
>
> I gues
On Tue, 14 Nov 2017, Masahiro Yamada wrote:
> Hi Julia,
>
>
> 2017-11-14 18:07 GMT+09:00 Julia Lawall :
> >> coccicheck failed
> >> $ cat cocci-debug.txt
> >> /home/masahiro/bin/spatch -D report --no-show-diff --very-quiet
> >> --cocci-file
On Tue, 14 Nov 2017, Luis R. Rodriguez wrote:
> On Tue, Nov 14, 2017 at 06:04:49PM +0900, Masahiro Yamada wrote:
> > diff --git a/scripts/coccicheck b/scripts/coccicheck
> > index 040a8b1..7da82a1 100755
> > --- a/scripts/coccicheck
> > +++ b/scripts/coccicheck
> > @@ -70,6 +64,13 @@ if [ "$C" =
On Tue, 14 Nov 2017, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake in pr_err error message text
>
> Signed-off-by: Colin Ian King
> ---
> drivers/crypto/nx/nx-842-powernv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/n
On Tue, 14 Nov 2017, Masahiro Yamada wrote:
> The command "make -j8 C=1 CHECK=scripts/coccicheck COCCI=..." produces
> lots of "coccicheck failed" error messages.
>
> Julia Lawall explained the Coccinelle behavior as follows:
> "The problem on the Coccin
On Tue, 14 Nov 2017, Masahiro Yamada wrote:
> Hi Julia,
>
>
> 2017-11-14 18:49 GMT+09:00 Julia Lawall :
> >> +
> >> +# If -j option is given to Make, scripts/coccicheck runs in parallel.
> >> +# If coccinelle also runs in parallel, it
On Tue, 14 Nov 2017, Masahiro Yamada wrote:
> I do not think it is helpful to have a separate file just for the
> coccicheck help message. Merge scripts/Makefile.help into the
> top-level Makefile.
>
> Signed-off-by: Masahiro Yamada
Acked-by: Julia Lawall
Thanks!
>
> +
> +# If -j option is given to Make, scripts/coccicheck runs in parallel.
> +# If coccinelle also runs in parallel, it fails because multiple
> processes
> +# try to get access to the same subdirectory that stores stdout/stderr.
> +# No need to parallelize coccinelle in this cas
> coccicheck failed
> $ cat cocci-debug.txt
> /home/masahiro/bin/spatch -D report --no-show-diff --very-quiet
> --cocci-file scripts/coccinelle/null/badzero.cocci --dir . -I
> ./arch/x86/include -I ./arch/x86/include/generated -I ./include -I
> ./arch/x86/include/uapi -I ./arch/x86/include/generate
On Tue, 14 Nov 2017, Masahiro Yamada wrote:
> Hi Julia,
>
> 2017-11-14 1:45 GMT+09:00 Julia Lawall :
> >
> >
> > On Tue, 14 Nov 2017, Masahiro Yamada wrote:
> >
> >> Hi Julia,
> >>
> >>
> >> 2017-11-14 0:30 GMT+09:00 Julia La
On Tue, 14 Nov 2017, Masahiro Yamada wrote:
> Hi Julia, Jon,
>
> 2017-11-14 1:50 GMT+09:00 Julia Lawall :
> > The wiki is no longer available.
> >
> > Signed-off-by: Julia Lawall
> >
>
>
> Jon sent the doc pull request yesterday.
>
> I will p
The wiki is no longer available.
Signed-off-by: Julia Lawall
---
diff --git a/Documentation/dev-tools/coccinelle.rst
b/Documentation/dev-tools/coccinelle.rst
index 37e474f..94f41c2 100644
--- a/Documentation/dev-tools/coccinelle.rst
+++ b/Documentation/dev-tools/coccinelle.rst
@@ -33,9 +33,6
On Tue, 14 Nov 2017, Masahiro Yamada wrote:
> Hi Julia,
>
>
> 2017-11-14 0:30 GMT+09:00 Julia Lawall :
> >
> >
> > On Thu, 9 Nov 2017, Masahiro Yamada wrote:
> >
> >> The command "make -j8 C=1 CHECK=scripts/coccicheck" produces lots of
>
On Tue, 14 Nov 2017, Masahiro Yamada wrote:
> Hi Julia,
>
>
> 2017-11-11 16:30 GMT+09:00 Julia Lawall :
> >
> >
> > On Fri, 10 Nov 2017, Julia Lawall wrote:
> >
> >>
> >>
> >> On Thu, 9 Nov 2017, Masahiro Yamada wrote:
> >
On Thu, 9 Nov 2017, Masahiro Yamada wrote:
> The command "make -j8 C=1 CHECK=scripts/coccicheck" produces lots of
> "coccicheck failed" error messages.
>
> I do not know the coccinelle internals, but I guess --jobs does not
> work well if spatch is invoked from Make running in parallel.
> Disabl
results.
Running time is divided by 3 when applying this to the whole kernel on my
laptop with an Intel i5-6200U CPU.
Signed-off-by: Julia Lawall
---
v2: added SOB and fixed typos in the commit message
diff --git a/scripts/coccinelle/misc/orplus.cocci
b/scripts/coccinelle/misc/orplus.coc
Adding two #define constants is less common than performing & and |
operations on them, so put the addition first to reduce the set of cases
that have to be considered in detail. At the same time, add & and |
patterns for both arguments of +, to account for commutativity and obtain
more results.
sequence.
Signed-off-by: Julia Lawall
---
diff --git a/scripts/coccinelle/locks/flags.cocci
b/scripts/coccinelle/locks/flags.cocci
index debd70e..33f29a5 100644
--- a/scripts/coccinelle/locks/flags.cocci
+++ b/scripts/coccinelle/locks/flags.cocci
@@ -12,9 +12,9 @@ virtual context
virtual org
This just needs to find any reassignment of the loop iterator, and doesn't
need such a thing on all execution paths, so use exists on the first rule.
Signed-off-by: Julia Lawall
---
diff --git a/scripts/coccinelle/iterators/list_entry_update.cocci
b/scripts/coccinelle/iter
On Sun, 12 Nov 2017, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sun, 12 Nov 2017 10:56:19 +0100
>
> * Add a jump target so that a bit of exception handling can be better
> reused at the end of this function.
>
> This issue was detected by using the Coccinelle software.
>
> * Th
On Fri, 10 Nov 2017, Julia Lawall wrote:
>
>
> On Thu, 9 Nov 2017, Masahiro Yamada wrote:
>
> > The command "make -j8 C=1 CHECK=scripts/coccicheck" produces lots of
> > "coccicheck failed" error messages.
>
> The question is where parallelism
On Fri, 10 Nov 2017, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Fri, 10 Nov 2017 20:50:15 +0100
>
> Adjust jump targets so that a bit of exception handling can be better
> reused at the end of this function.
Unless there is a strong motivation for doing otherwise, the goal should
On Thu, 9 Nov 2017, Masahiro Yamada wrote:
> The command "make -j8 C=1 CHECK=scripts/coccicheck" produces lots of
> "coccicheck failed" error messages.
The question is where parallelism should be specified. Currently, make
coccicheck picks up the number of cores on the machine and passes that
On Tue, 7 Nov 2017, Masahiro Yamada wrote:
> 2017-10-26 16:22 GMT+09:00 Nicolas Palix (LIG) :
> > Le 26/10/17 à 06:55, Masahiro Yamada a écrit :
> >>
> >> If you run coccicheck with V=1 and COCCI=, you will see a strange
> >> path to the semantic patch file. For example, run the following:
> >>
On Tue, 7 Nov 2017, Masahiro Yamada wrote:
> 2017-08-23 22:11 GMT+09:00 Julia Lawall :
> > Allow messages about multiple timers.
> >
> > Signed-off-by: Julia Lawall
> >
> > ---
>
>
> Applied to linux-kbuild/misc.
Thanks!
julia
On Tue, 7 Nov 2017, Masahiro Yamada wrote:
> 2017-10-09 4:18 GMT+09:00 Julia Lawall :
> > This semantic patch detects duplicate arrays declared using BQ27XXX_DATA
> > within a single structure. It is currently specific to the file
> > drivers/power/supply/bq27xxx_bat
On Tue, 7 Nov 2017, Masahiro Yamada wrote:
> 2017-10-26 16:26 GMT+09:00 Nicolas Palix (LIG) :
> > Le 26/10/17 à 06:59, Julia Lawall a écrit :
> >>
> >>
> >>
> >> On Thu, 26 Oct 2017, Masahiro Yamada wrote:
> >>
> >>> Currently,
On Tue, 7 Nov 2017, Masahiro Yamada wrote:
> 2017-10-30 12:52 GMT+09:00 Julia Lawall :
> >
> >
> > On Mon, 30 Oct 2017, Masahiro Yamada wrote:
> >
> >> Hi Julia,
> >>
> >>
> >> 2017-10-29 8:43 GMT+09:00 Julia Lawall :
> >&
On Tue, 7 Nov 2017, Masahiro Yamada wrote:
> 2017-10-26 13:02 GMT+09:00 Julia Lawall :
> >
> >
> > On Thu, 26 Oct 2017, Masahiro Yamada wrote:
> >
> >> Hi Julia,
> >>
> >>
> >> 2017-10-15 18:55 GMT+09:00 Julia Lawall :
> &g
On Wed, 8 Nov 2017, Himanshu Jha wrote:
> On Tue, Nov 07, 2017 at 08:51:36PM +0100, Luis R. Rodriguez wrote:
> > On Sun, Nov 05, 2017 at 03:26:26AM +0530, Himanshu Jha wrote:
> > > Use vzalloc instead of vmalloc/memset to allocate memory filled with 0
> > > value.
> > >
> > > Done using Coccinel
901 - 1000 of 3793 matches
Mail list logo
