Re: [LSF/MM TOPIC NOTES] x86 ZONE_DMA love

2018-04-28 Thread Julia Lawall
On Sat, 28 Apr 2018, Luis R. Rodriguez wrote: > On Sat, Apr 28, 2018 at 01:42:21AM -0700, Christoph Hellwig wrote: > > On Fri, Apr 27, 2018 at 04:14:56PM +, Luis R. Rodriguez wrote: > > > Do we have a list of users for x86 with a small DMA mask? > > > Or, given that I'm not aware of a tool

[PATCH] mhi_bus: core: fix debugfs_simple_attr.cocci warnings

2018-04-28 Thread Julia Lawall
unsafe(). Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Fixes: ec8245f7a36f ("mhi_bus: core: Add support for MHI host interface") CC: Sujeev Dias <sd...@codeaurora.org> Signed-off-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Julia Lawall <

[PATCH] mhi_bus: core: fix memdup.cocci warnings

2018-04-28 Thread Julia Lawall
d-off-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- url: https://github.com/0day-ci/linux/commits/Sujeev-Dias/mhi_bus-core-Add-support-for-MHI-host-interface/20180428-065959 :: branch date: 3 hours ago :: commit date: 3 hours a

[PATCH] mhi_bus: core: fix semicolon.cocci warnings

2018-04-28 Thread Julia Lawall
From: Fengguang Wu Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: ec8245f7a36f ("mhi_bus: core: Add support for MHI host interface") CC: Sujeev Dias Signed-off-by: Fengguang Wu ---

[PATCH] mhi_bus: dev: netdev: fix debugfs_simple_attr.cocci warnings

2018-04-28 Thread Julia Lawall
unsafe(). Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Fixes: e693c860afd8 ("mhi_bus: dev: netdev: add network interface driver") CC: Sujeev Dias <sd...@codeaurora.org> Signed-off-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Julia

[PATCH] mhi_bus: controller: fix platform_no_drv_owner.cocci warnings

2018-04-28 Thread Julia Lawall
eaurora.org> Signed-off-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- url: https://github.com/0day-ci/linux/commits/Sujeev-Dias/mhi_bus-core-Add-support-for-MHI-host-interface/20180428-065959 :: branch date: 4 hours ago :: comm

[PATCH] mhi_bus: controller: fix debugfs_simple_attr.cocci warnings

2018-04-28 Thread Julia Lawall
unsafe(). Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Fixes: 6190c08efd64 ("mhi_bus: controller: MHI support for QCOM modems") CC: Sujeev Dias <sd...@codeaurora.org> Signed-off-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Julia Lawall <

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

2018-04-18 Thread Julia Lawall
On Wed, 18 Apr 2018, Joe Perches wrote: > On Thu, 2018-04-19 at 06:40 +0200, Julia Lawall wrote: > > > > On Wed, 18 Apr 2018, Joe Perches wrote: > > > > > On Tue, 2018-04-17 at 17:07 +0800, yuank...@codeaurora.org wrote: > > > > Hi julia, > >

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

2018-04-18 Thread Julia Lawall
On Wed, 18 Apr 2018, Joe Perches wrote: > On Tue, 2018-04-17 at 17:07 +0800, yuank...@codeaurora.org wrote: > > Hi julia, > > > > On 2018-04-15 05:19 AM, Julia Lawall wrote: > > > On Wed, 11 Apr 2018, Joe Perches wrote: > > > > > > > On

Re: [PATCH 08/12] mmc: reduce use of block bounce buffers (fwd)

2018-04-16 Thread Julia Lawall
There is a duplicated test on line 360. julia -- Forwarded message -- Date: Mon, 16 Apr 2018 23:04:18 +0800 From: kbuild test robot <l...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH 08/12] mmc: reduce use of block bounce

Re: [PATCH] drm: fix drm-get-put.cocci warnings

2018-04-16 Thread Julia Lawall
On Mon, 16 Apr 2018, Daniel Vetter wrote: > On Thu, Apr 12, 2018 at 07:54:10AM +0200, Julia Lawall wrote: > > From: Fengguang Wu <fengguang...@intel.com> > > > > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and > > drm_*_unrefer

Re: BUILD_BUG_ON_MSG

2018-04-15 Thread Julia Lawall
On Sun, 15 Apr 2018, Daniel Santos wrote: > Hello Julia, > > I'm CCing LKML on this so that others can be involved. > > > On 04/15/2018 12:43 AM, Julia Lawall wrote: > > Hello, > > > > I saw that you introduced BUILD_BUG_ON_MSG in the Linux kernel a few yea

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

2018-04-14 Thread Julia Lawall
On Wed, 11 Apr 2018, Joe Perches wrote: > On Thu, 2018-04-12 at 08:22 +0200, Julia Lawall wrote: > > On Wed, 11 Apr 2018, Joe Perches wrote: > > > On Wed, 2018-04-11 at 09:29 -0700, Andrew Morton wrote: > > > > We already have some 500 bools-in-structs >

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

2018-04-12 Thread Julia Lawall
On Wed, 11 Apr 2018, Joe Perches wrote: > On Thu, 2018-04-12 at 08:22 +0200, Julia Lawall wrote: > > On Wed, 11 Apr 2018, Joe Perches wrote: > > > On Wed, 2018-04-11 at 09:29 -0700, Andrew Morton wrote: > > > > We already have some 500 bools-in-structs >

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

2018-04-12 Thread Julia Lawall
On Wed, 11 Apr 2018, Joe Perches wrote: > (Adding Julia Lawall) > > On Wed, 2018-04-11 at 09:29 -0700, Andrew Morton wrote: > > We already have some 500 bools-in-structs > > I got at least triple that only in include/ > so I expect there are at probably an order >

[PATCH] drm: fix drm-get-put.cocci warnings

2018-04-11 Thread Julia Lawall
ng Wu <fengguang...@intel.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- tree: https://github.com/shenki/linux drm-v1 head: 9680ed7979d5d403c6bde36271a048d62c048180 commit: 6784ac15bc6889280522b04b97f1fb1208ee45e7 [23/27] drm: Add ASPEED GFX driver aspeed_gfx_drv.c |

[PATCH] drm: fix semicolon.cocci warnings

2018-04-11 Thread Julia Lawall
From: Fengguang Wu <fengguang...@intel.com> Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: 6784ac15bc68 ("drm: Add ASPEED GFX driver") Signed-off-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Julia Lawall

Re: [PATCH] staging: comedi: cb_pcidas64: fix alignment of function parameters

2018-04-10 Thread Julia Lawall
On Tue, 10 Apr 2018, Gabriel Francisco Mandaji wrote: > Fix most checkpatch.pl issues of type: > > CHECK: Alignment should match open parenthesis > > Signed-off-by: Gabriel Francisco Mandaji > --- > drivers/staging/comedi/drivers/cb_pcidas64.c | 6 +++--- > 1 file

[PATCH] drm: xlnx: pl_disp: fix odd_ptr_err.cocci warnings

2018-04-09 Thread Julia Lawall
gned-off-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v4.14 head: fe04d2ee0dfea6b5fdbb04f4f6dbcaa13bfd2fda commit: 742243a44a738b165f8da5cbdb6662139e85a5c5 [651/842] drm: xlnx

Re: [PATCH] selftests/ftrace: fix spelling mistake: "tiggers" -> "triggers"

2018-04-03 Thread Julia Lawall
On Tue, 3 Apr 2018, Steven Rostedt wrote: > On Tue, 3 Apr 2018 13:07:05 +0300 > Dan Carpenter wrote: > > > On Fri, Mar 30, 2018 at 09:51:21AM -0600, Shuah Khan wrote: > > > On 03/29/2018 12:04 PM, Steven Rostedt wrote: > > > > On Thu, 29 Mar 2018 11:54:28 -0600 > > >

Re: [PATCH] drm/amd/display: fix spelling mistake: "Usupported" -> "Unsupported"

2018-04-03 Thread Julia Lawall
On Tue, 3 Apr 2018, Jani Nikula wrote: > On Fri, 30 Mar 2018, Colin King wrote: > > From: Colin Ian King > > > > Trivial fix to spelling mistake in DRM_ERROR error message text > > Thanks for the patch. > > Please do consider limiting the

Re: [PATCH] gpio: fix ifnullfree.cocci warnings

2018-04-02 Thread Julia Lawall
On Mon, 2 Apr 2018, Lukas Wunner wrote: > On Fri, Mar 30, 2018 at 08:32:56AM +0200, Julia Lawall wrote: > > --- a/drivers/gpio/gpiolib.c > > +++ b/drivers/gpio/gpiolib.c > > @@ -2774,8 +2773,7 @@ int gpiod_get_array_value_complex(bool r > > trace_g

Re: [Cocci] [PATCH] crypto: cavium: zip: Remove unnecessary parentheses

2018-03-31 Thread Julia Lawall
On Sat, 31 Mar 2018, Varsha Rao wrote: > On Sat, Mar 31, 2018 at 11:48 AM, Julia Lawall wrote: > > On Thu, 29 Mar 2018, Varsha Rao wrote: > > > >> On Wed, Mar 28, 2018 at 11:41 PM, Joe Perches wrote: > >> > > >> > On Wed, 2018-03-28 at 23

Re: [Cocci] [PATCH] crypto: cavium: zip: Remove unnecessary parentheses

2018-03-31 Thread Julia Lawall
On Thu, 29 Mar 2018, Varsha Rao wrote: > On Wed, Mar 28, 2018 at 11:41 PM, Joe Perches wrote: > > > > On Wed, 2018-03-28 at 23:27, Varsha Rao wrote: > > > This patch fixes the clang warning of extraneous parentheses, with the > > > following coccinelle script. > > > > > > @@ > > > identifier i;

Re: [Cocci] [PATCH] crypto: cavium: zip: Remove unnecessary parentheses

2018-03-31 Thread Julia Lawall
On Fri, 30 Mar 2018, Joe Perches wrote: > On Thu, 2018-03-29 at 21:03 +0530, Varsha Rao wrote: > > On Wed, Mar 28, 2018 at 11:41 PM, Joe Perches wrote: > > > > > > On Wed, 2018-03-28 at 23:27, Varsha Rao wrote: > > > > This patch fixes the clang warning of extraneous parentheses, with the > > >

[PATCH] debugfs_simple_attr.cocci: add clarifying information

2018-03-30 Thread Julia Lawall
The referenced commit gives some information about the overhead reduced by this change. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci |2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/coccinelle/api/d

[PATCH] gpio: fix ifnullfree.cocci warnings (fwd)

2018-03-30 Thread Julia Lawall
...@intel.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- url: https://github.com/0day-ci/linux/commits/Laura-Abbott/gpio-Remove-VLA-from-gpiolib/20180330-065639 base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next gpiolib.c |9 +++--

Re: [kbuild-all] [PATCH] OPTIONAL: cpufreq/intel_pstate: fix debugfs_simple_attr.cocci warnings

2018-03-30 Thread Julia Lawall
On Fri, 30 Mar 2018, Nicolai Stange wrote: > Julia Lawall <julia.law...@lip6.fr> writes: > > > On Thu, 29 Mar 2018, Fabio Estevam wrote: > > > >> Hi Julia, > >> > >> On Thu, Mar 29, 2018 at 4:12 PM, Julia Lawall <julia.law...@lip6.fr>

Re: [kbuild-all] [PATCH] OPTIONAL: cpufreq/intel_pstate: fix debugfs_simple_attr.cocci warnings

2018-03-29 Thread Julia Lawall
On Thu, 29 Mar 2018, Fabio Estevam wrote: > Hi Julia, > > On Thu, Mar 29, 2018 at 4:12 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE > > for debugfs files. > > > > Sem

[PATCH] OPTIONAL: cpufreq/intel_pstate: fix debugfs_simple_attr.cocci warnings

2018-03-29 Thread Julia Lawall
by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Fixes: 9eec7989e762 ("OPTIONAL: cpufreq/intel_pstate: Expose LP controller parameters via debugfs.") CC: Francisco Jerez <curroje...@riseup.net> Signed-off-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: J

[PATCH] staging: wilc1000: fix memdup.cocci warnings

2018-03-26 Thread Julia Lawall
cripts/coccinelle/api/memdup.cocci Fixes: aaea2164bdff ("staging: wilc1000: check for kmalloc allocation failures") CC: Colin Ian King <colin.k...@canonical.com> Signed-off-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> ---

Re: [Outreachy kernel] [PATCH] gpu: drm: Use list_{next/prev}_entry instead of list_entry

2018-03-25 Thread Julia Lawall
On Sun, 25 Mar 2018, Arushi Singhal wrote: > > > On Mon, Mar 19, 2018 at 12:44 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Mon, 19 Mar 2018, Arushi Singhal wrote: > > > This patch replace list_entry with list_{next/prev}_entry as >

Re: [Outreachy kernel] [PATCH] gpu: drm: Use list_{next/prev}_entry instead of list_entry

2018-03-25 Thread Julia Lawall
On Sun, 25 Mar 2018, Arushi Singhal wrote: > > > On Mon, Mar 19, 2018 at 12:44 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Mon, 19 Mar 2018, Arushi Singhal wrote: > > > This patch replace list_entry with list_{next/prev}_entry as >

Re: [Outreachy kernel] Re: [PATCH] gpu: drm: Use list_first_entry instead of list_entry

2018-03-19 Thread Julia Lawall
On Mon, 19 Mar 2018, Christian König wrote: > Mhm, actually that patch isn't correct. What we grab get here is the next > entry, not the first one. > > We don't have an alias list_next_entry for list_first_entry? As compared to the semantic patch I proposed earlier today, it would seem that

Re: [Outreachy kernel] [PATCH] gpu: drm: Use list_{next/prev}_entry instead of list_entry

2018-03-19 Thread Julia Lawall
On Mon, 19 Mar 2018, Arushi Singhal wrote: > This patch replace list_entry with list_{next/prev}_entry as it makes > the code more clear to read. > Done using coccinelle: > > @@ > expression e1; > identifier e3; > type t; > @@ > ( > - list_entry(e1->e3.next,t,e3) > + list_next_entry(e1,e3) > |

Re: [PATCH v3] mfd: rk808: Add restart functionality (fwd)

2018-03-17 Thread Julia Lawall
It's not possible to do the dereferences on line 381 on a null rk808 value. julia -- Forwarded message -- Date: Sat, 17 Mar 2018 14:05:31 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [P

Re: [PATCH][RFC] kernel.h: provide array iterator

2018-03-16 Thread Julia Lawall
Le 16.03.2018 05:21, Kees Cook a écrit : On Thu, Mar 15, 2018 at 3:00 AM, Kieran Bingham wrote: Simplify array iteration with a helper to iterate each entry in an array. Utilise the existing ARRAY_SIZE macro to identify the length of the array and pointer

Re: [PATCH 2/2] mm: Add kvmalloc_ab_c and kvzalloc_struct

2018-03-13 Thread Julia Lawall
On Tue, 13 Mar 2018, Matthew Wilcox wrote: > On Tue, Mar 13, 2018 at 06:19:51PM +0100, Julia Lawall wrote: > > On Thu, 8 Mar 2018, Matthew Wilcox wrote: > > > On Thu, Mar 08, 2018 at 07:24:47AM +0100, Julia Lawall wrote: > > > > Thanks. So it's OK to replace km

Re: [PATCH 2/2] mm: Add kvmalloc_ab_c and kvzalloc_struct

2018-03-13 Thread Julia Lawall
On Thu, 8 Mar 2018, Matthew Wilcox wrote: > On Thu, Mar 08, 2018 at 07:24:47AM +0100, Julia Lawall wrote: > > On Wed, 7 Mar 2018, Matthew Wilcox wrote: > > > On Wed, Mar 07, 2018 at 10:18:21PM +0100, Julia Lawall wrote: > > > > > Otherwise, yes, please.

Re: [PATCH 2/2] mm: Add kvmalloc_ab_c and kvzalloc_struct

2018-03-08 Thread Julia Lawall
On Thu, 8 Mar 2018, Matthew Wilcox wrote: > On Thu, Mar 08, 2018 at 07:24:47AM +0100, Julia Lawall wrote: > > On Wed, 7 Mar 2018, Matthew Wilcox wrote: > > > On Wed, Mar 07, 2018 at 10:18:21PM +0100, Julia Lawall wrote: > > > > > Otherwise, yes, please.

Re: [PATCH 2/2] mm: Add kvmalloc_ab_c and kvzalloc_struct

2018-03-07 Thread Julia Lawall
On Wed, 7 Mar 2018, Matthew Wilcox wrote: > On Wed, Mar 07, 2018 at 10:18:21PM +0100, Julia Lawall wrote: > > > Otherwise, yes, please. We could build a coccinelle rule for > > > additional replacements... > > > > A potential semantic patch and the changes it

Re: [PATCH 2/2] mm: Add kvmalloc_ab_c and kvzalloc_struct

2018-03-07 Thread Julia Lawall
On Wed, 14 Feb 2018, Kees Cook wrote: > On Wed, Feb 14, 2018 at 10:26 AM, Matthew Wilcox wrote: > > From: Matthew Wilcox > > > > We have kvmalloc_array in order to safely allocate an array with a > > number of elements specified by userspace

Re: [Outreachy kernel] Re: [PATCH v2] net: ethernet: Drop unnecessary continue

2018-03-07 Thread Julia Lawall
On Wed, 7 Mar 2018, Arushi Singhal wrote: > > > On Wed, Mar 7, 2018 at 9:09 PM, David Miller wrote: > From: Arushi Singhal > Date: Sat, 3 Mar 2018 21:44:56 +0530 > > > Continue at the bottom of a loop are removed. >

Re: [Outreachy kernel] Re: [PATCH v3] staging: rtl8192u: Replace printk() with more standardize output format.

2018-03-07 Thread Julia Lawall
On Wed, 7 Mar 2018, Dan Carpenter wrote: > On Wed, Mar 07, 2018 at 04:09:09PM +0530, Arushi Singhal wrote: > > @@ -276,22 +276,22 @@ static int ieee80211_ccmp_decrypt(struct sk_buff > > *skb, int hdr_len, void *priv) > > keyidx = pos[3]; > > if (!(keyidx & (1 << 5))) { > >

[PATCH] PCI: fix semicolon.cocci warnings

2018-03-07 Thread Julia Lawall
From: Fengguang Wu <fengguang...@intel.com> Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Signed-off-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- tree: https://git.kernel.org/pub/scm/lin

Re: [Outreachy kernel] [PATCH v2] staging: rtl8192u: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-06 Thread Julia Lawall
On Tue, 6 Mar 2018, Arushi Singhal wrote: > > > On Mon, Mar 5, 2018 at 1:07 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Mon, 5 Mar 2018, Arushi Singhal wrote: > > > Replace printk having a log level with the appropriate > >

Re: [Outreachy kernel] Re: [PATCH] staging: irda: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-05 Thread Julia Lawall
On Mon, 5 Mar 2018, Arushi Singhal wrote: > > > On Mon, Mar 5, 2018 at 3:33 PM, Dan Carpenter > wrote: > On Mon, Mar 05, 2018 at 04:02:06AM +0530, Arushi Singhal wrote: > > Replace printk having a log level with the appropriate > >

Re: [Outreachy kernel] [PATCH v2] staging: rtl8192u: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-04 Thread Julia Lawall
On Mon, 5 Mar 2018, Arushi Singhal wrote: > Replace printk having a log level with the appropriate > net_*macro_ratelimited. > It's better to use actual device name as a prefix in error messages. I asked several questions about the above two lines, which as far as I can see haven't been

Re: [Outreachy kernel] [PATCH v2] staging: comedi: Replace "dont" with "don't

2018-03-04 Thread Julia Lawall
On Mon, 5 Mar 2018, Arushi Singhal wrote: > Replace "dont" with "don't". > "Dont" is not same as "Do not" or "Don't". > > Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> Acked-by: Julia Lawall &l

[PATCH] mtd: rawnand: vf610_nfc: fix returnvar.cocci warnings

2018-03-04 Thread Julia Lawall
From: Fengguang Wu <fengguang...@intel.com> Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci CC: Stefan Agner <ste...@agner.ch> Signed-off-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Julia Lawall <

Re: [Outreachy kernel] [PATCH v3] staging: ipx: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-04 Thread Julia Lawall
On Mon, 5 Mar 2018, Arushi Singhal wrote: > Replace printk having a log level with the appropriate > net_*macro_ratelimited. > It's better to use actual device name as a prefix in error messages. > > Signed-off-by: Arushi Singhal > --- > changes in v2 > *In v1

Re: [Outreachy kernel] [PATCH v2] staging: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-04 Thread Julia Lawall
On Mon, 5 Mar 2018, Arushi Singhal wrote: > Replace printk having a log level with the appropriate > net_*macro_ratelimited. Why did you choose this function? > It's better to use actual device name as a prefix in error messages. What does this message relate to. > Indentation is also

Re: [Outreachy kernel] [PATCH 0/3] staging: lustre: cleanup

2018-03-04 Thread Julia Lawall
t;to" > staging: lustre: Replace "dont" with "don't" For the series: Acked-by: Julia Lawall <julia.law...@lip6.fr> > > drivers/staging/lustre/lnet/libcfs/debug.c | 2 +- > drivers/staging/lustre/lustre/fld/fld_cache.c | 2 +- &

Re: [Outreachy kernel] [PATCH 0/3] staging: media: cleanup

2018-03-04 Thread Julia Lawall
On Sun, 4 Mar 2018, Arushi Singhal wrote: > Spellcheck the comments. > Remove the repeated, consecutive words with single word. For the series: Acked-by: Julia Lawall <julia.law...@lip6.fr> But please look out for things to change in the code, not just in the comments. julia

Re: [Outreachy kernel] [PATCH] staging: comedi: "dont" is changed to "don't"

2018-03-04 Thread Julia Lawall
On Sun, 4 Mar 2018, Arushi Singhal wrote: > "dont" is changed to "don't" in messages, "dont" is not correct > english. The change is fine, but please rewrite the commit log in the imperative. julia > > Signed-off-by: Arushi Singhal > --- >

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove unnecessary semicolon.

2018-03-03 Thread Julia Lawall
On Sun, 4 Mar 2018, Arushi Singhal wrote: > Remove unnecessary semicolon using semicolon.cocci Coccinelle script. > > Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > drivers/staging/rtl8723b

Re: [Outreachy kernel] [PATCH] staging: media: Remove unnecessary semicolon

2018-03-03 Thread Julia Lawall
On Sun, 4 Mar 2018, Arushi Singhal wrote: > Remove unnecessary semicolon found using semicolon.cocci Coccinelle > script. > > Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > .../media/atomis

Re: [Outreachy kernel] [PATCH] staging: rtlwifi: Remove nonessential semicolon

2018-03-03 Thread Julia Lawall
On Sun, 4 Mar 2018, Arushi Singhal wrote: > Remove non-essential semicolon after 'else' and 'switch' statements. Issue > found using semicolon.cocci Coccinelle script. > > Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> Acked-by: Julia Lawall <julia.law.

Re: [Outreachy kernel] [PATCH] infiniband: hw: Drop unnecessary continue

2018-03-03 Thread Julia Lawall
On Sat, 3 Mar 2018, Arushi Singhal wrote: > Continue at the bottom of a loop are removed. > Issue found using drop_continue.cocci Coccinelle script. > > Signed-off-by: Arushi Singhal > --- > drivers/infiniband/hw/qib/qib_init.c | 1 - > 1 file changed, 1

Re: [Outreachy kernel] [PATCH] net: ethernet: Drop unnecessary continue

2018-03-03 Thread Julia Lawall
On Sat, 3 Mar 2018, Arushi Singhal wrote: > Continue at the bottom of a loop are removed. > Issue found using drop_continue.cocci Coccinelle script. In each case you leave an if with a single statement in the branch. In that case the { } should be dropped too. julia > > Signed-off-by:

Re: [Outreachy kernel] [PATCH v2 0/6] staging: rtl8712: fix coding style issues

2018-03-02 Thread Julia Lawall
On Sat, 3 Mar 2018, Arushi Singhal wrote: > Fix issues found with checkpatch.pl to conform to the Linux > kernel coding style. For the series: Acked-by: Julia Lawall <julia.law...@lip6.fr> > > Changes in v2: > * From and Signed-off emails were not same in v1. >

[PATCH] mtd: rawnand: fix memdup.cocci warnings

2018-03-02 Thread Julia Lawall
From: Fengguang Wu <fengguang...@intel.com> Use kmemdup rather than duplicating its implementation Generated by: scripts/coccinelle/api/memdup.cocci Signed-off-by: Fengguang Wu <fengguang...@intel.com> Signed-off-buy: Julia Lawall <julia.law...@lip6.fr> --- tree:

Re: [Outreachy kernel] [PATCH] staging: rtl8712: match alignment with open parenthesis

2018-03-02 Thread Julia Lawall
On Fri, 2 Mar 2018, Arushi Singhal wrote: > This patch fixes the checks reported by checkpatch.pl for alignment > should match open parenthesis. > > Signed-off-by: Arushi Singhal Your Signed-off-by email address should be the same as the one in the From line. You

Re: [Outreachy kernel] [PATCH] staging: rtl8712: Fixed 'tabstop' coding style warning

2018-03-01 Thread Julia Lawall
he subject line and the diffstat just below. > > Signed-off-by: Arushi Singhal <arushising...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > drivers/staging/rtl8712/drv_types.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: test case against union aliasing

2018-02-27 Thread Julia Lawall
On Tue, 27 Feb 2018, Andy Shevchenko wrote: > Hi! > > It seems we have some code in kernel which utilizes (rightlessly for > now) union aliasing. > > So, can we create a test case against such? (Three steps: a) replace > union by struct keyword in data type in question, b) compile, c) run in >

Re: [PATCH v2] iio:dummy: Replace S_IWUSR by 0200

2018-02-21 Thread Julia Lawall
On Wed, 21 Feb 2018, Rodrigo Siqueira wrote: > This patch fixes the checkpatch.pl warning: > > drivers/iio/dummy/iio_dummy_evgen.c:151: WARNING: Symbolic permissions > 'S_IWUSR' are not preferred. Consider using octal permissions '0200'. I haven't studied up on it in great detail, but isn't

Re: [PATCH v3] rtc: isl12026: Add driver. (fwd)

2018-02-18 Thread Julia Lawall
The concern is about the code on line 400. I'm not seeing where num_written could go below 0, in any case. julia -- Forwarded message -- Date: Sun, 18 Feb 2018 20:54:49 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.la

Re: [PATCH] aoe: document sysfs interface

2018-02-17 Thread Julia Lawall
On Fri, 16 Feb 2018, Ed Cashin wrote: > On 02/16/2018 10:39 AM, Aishwarya Pant wrote: > > Documentation has been compiled from git commit logs and descriptions in > > Documentation/aoe/aoe.txt. This should be useful for scripting and > > tracking changes in the ABI. > ... > > +What:

Re: [PATCH 2/2] mm: Add kvmalloc_ab_c and kvzalloc_struct

2018-02-14 Thread Julia Lawall
On Wed, 14 Feb 2018, Kees Cook wrote: > On Wed, Feb 14, 2018 at 10:26 AM, Matthew Wilcox wrote: > > From: Matthew Wilcox > > > > We have kvmalloc_array in order to safely allocate an array with a > > number of elements specified by userspace

Re: [PATCH v4 5/5] dmaengine: mediatek: fix zalloc-simple.cocci warnings

2018-02-12 Thread Julia Lawall
On Tue, 13 Feb 2018, Vinod Koul wrote: > On Fri, Feb 09, 2018 at 03:55:58PM +0100, Julia Lawall wrote: > > > > > > - ring->txd = dma_alloc_coherent(hsdma2dev(hsdma), > > > > -

Re: [PATCH v4 5/5] dmaengine: mediatek: fix zalloc-simple.cocci warnings

2018-02-09 Thread Julia Lawall
erated by: scripts/coccinelle/api/alloc/zalloc-simple.cocci > > > > Fixes: c8e4b2e4ca21 ("dmaengine: mediatek: Add MediaTek High-Speed DMA > > controller for MT7622 and MT7623 SoC") > > Cc: Sean Wang <sean.w...@mediatek.com> > > Signed-off-by: Fenggu

Re: [PATCH] scripts/coccinelle/misc/shift.cocci: detect < or > that should be a shift

2018-02-08 Thread Julia Lawall
On Thu, 8 Feb 2018, Dan Carpenter wrote: > On Thu, Feb 08, 2018 at 01:53:54PM +0100, Julia Lawall wrote: > > This checks for a comparison using < or > between two constants, > > considering both explicit constants (1, 2, etc) and macros defined > > with #define. F

[PATCH] scripts/coccinelle/misc/shift.cocci: detect < or > that should be a shift

2018-02-08 Thread Julia Lawall
output for errors. Suggested-by: Dan Carpenter <dan.carpen...@oracle.com> Suggested-by: Wolfram Sang <wsa+rene...@sang-engineering.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- scripts/coccinelle/misc/shift.cocci | 89 1 file c

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

2018-02-06 Thread Julia Lawall
On Tue, 6 Feb 2018, Dan Carpenter wrote: > That found 4 that I think Wolfram's grep missed. > > arch/um/drivers/vector_user.h |2 -- > drivers/gpu/drm/mxsfb/mxsfb_regs.h|2 -- > drivers/video/fbdev/mxsfb.c |2 -- > include/drm/drm_scdc_helper.h

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

2018-02-06 Thread Julia Lawall
On Tue, 6 Feb 2018, Wolfram Sang wrote: > Hi Julia, > > > and got the results below. I can make a version for the kernel shortly. > > It should probably take care of right-shifting, too? I did that too but got no results. Perhaps right shifting constants is pretty uncommon. I can put that

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

2018-02-06 Thread Julia Lawall
On Tue, 6 Feb 2018, Dan Carpenter wrote: > On Tue, Feb 06, 2018 at 02:15:51PM +0100, Julia Lawall wrote: > > > > > > On Tue, 6 Feb 2018, Dan Carpenter wrote: > > > > > On Mon, Feb 05, 2018 at 09:09:57PM +0100, Wolfram Sang wrote: > > > > In

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

2018-02-06 Thread Julia Lawall
On Tue, 6 Feb 2018, Dan Carpenter wrote: > On Mon, Feb 05, 2018 at 09:09:57PM +0100, Wolfram Sang wrote: > > In one Renesas driver, I found a typo which turned an intended bit shift > > ('<<') > > into a comparison ('<'). Because this is a subtle issue, I looked tree wide > > for > > similar

Re: [GIT PULL] pin control bulk changes for v4.16

2018-02-05 Thread Julia Lawall
On Mon, 5 Feb 2018, Linus Walleij wrote: > On Mon, Feb 5, 2018 at 10:27 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > > On Mon, 5 Feb 2018, Linus Walleij wrote: > > >> We definitely need some better tooling to find these things, > >> using Ingo's

Re: [GIT PULL] pin control bulk changes for v4.16

2018-02-05 Thread Julia Lawall
On Mon, 5 Feb 2018, Linus Walleij wrote: > On Sat, Feb 3, 2018 at 1:51 AM, Linus Torvalds > wrote: > > On Fri, Feb 2, 2018 at 4:44 PM, Linus Torvalds > > wrote: > >> > >> Stupid patch attached. I don't know how much this helps the

Re: [PATCH] dmaengine: mediatek: fix zalloc-simple.cocci warnings

2018-02-03 Thread Julia Lawall
On Sat, 3 Feb 2018, Julia Lawall wrote: > From: Fengguang Wu <fengguang...@intel.com> > > Use zeroing allocator rather than allocator followed by memset with 0 > > Generated by: scripts/coccinelle/api/alloc/zalloc-simple.cocci > > Fixes: 73006a033ef0 ("dmaeng

[PATCH] dmaengine: mediatek: fix zalloc-simple.cocci warnings

2018-02-03 Thread Julia Lawall
23 SoC") CC: Sean Wang <sean.w...@mediatek.com> Signed-off-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- [auto build test WARNING on linus/master] [also build test WARNING on v4.15 next-20180202] [if your patch is applied to

[PATCH] coccinelle: deref_null: avoid useless computation

2018-02-03 Thread Julia Lawall
The effect of the rules ifm1, pr11, and pr12 is only used in the final rule, which depends on context && !org && !report. Thus these rules should only be performed in those circumstances. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- scripts/coccinelle/null/d

Re: cocci script for detecting alloc_apertures mem leak

2018-02-01 Thread Julia Lawall
On Thu, 1 Feb 2018, Mathieu Malaterre wrote: > Hi cocci gurus, > > I am wondering if coccinelle can handle detection of kzalloc mem leak > (within alloc_apertures call) ? Typically: > > $ cat drivers/video/fbdev/vesafb.c > static int vesafb_probe(struct platform_device *dev) > [...] >

Re: [PATCH] coccinelle: reduce false positives

2018-02-01 Thread Julia Lawall
Here are the results that are eliminated by my change: drivers/clk/axs10x/pll_clock.c:323:1-6 kfree(pll_clk); drivers/clk/clk-gpio.c:131:2-7 kfree(clk_gpio); drivers/clk/clk-hsdk-pll.c:410:1-6 kfree(pll_clk); drivers/clk/hisilicon/clk.c:97:1-6 kfree(clk_data); drivers/mfd/syscon.c:130:1-8

Re: Coccinelle: zalloc-simple: Delete function "kmem_cache_alloc" from SmPL rules

2018-02-01 Thread Julia Lawall
On Thu, 1 Feb 2018, SF Markus Elfring wrote: > >> The function "kmem_cache_alloc" was specified despite of the technical > >> detail that this function does not get a parameter passed which would > >> correspond to such a size information. > >> > >> Thus remove it from the first two SmPL rules

[PATCH] coccinelle: reduce false positives

2018-02-01 Thread Julia Lawall
Some files use both a non-devm allocation and a devm_allocation. Don't complain about a free when the same function contains a non-devm allocation. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- scripts/coccinelle/free/devm_free.cocci | 55 +++-

[PATCH] Coccinelle: coccicheck: fix typo

2018-02-01 Thread Julia Lawall
Correct spelling of "coccinelle". Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- scripts/coccicheck |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/coccicheck b/scripts/coccicheck index ecfac64..9fedca6 100755 --- a/scripts/cocciche

Re: [PATCH] Coccinelle: zalloc-simple: Delete function "kmem_cache_alloc" from SmPL rules

2018-02-01 Thread Julia Lawall
On Thu, 1 Feb 2018, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 1 Feb 2018 10:20:47 +0100 > > The deletion for a call of the function "memset" depends on > the specification that a size determination is passed by > the expression "E1". > The

Re: [v2] Coccinelle: zalloc-simple: Delete function “kmem_cache_alloc” from SmPL rules

2018-01-31 Thread Julia Lawall
On Wed, 31 Jan 2018, SF Markus Elfring wrote: > > I removed the blank line at EOF, > > then applied to linux-kbuild/misc. > > I have taken another look at this script for the semantic patch language. > I imagined that I could refactor the shown SmPL disjunctions a bit. > But I noticed then that

[PATCH] Coccinelle: memdup: drop spurious line

2018-01-27 Thread Julia Lawall
The kmemdup line in the non-patch case was left over from the added kmemdup line in the patch case. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- scripts/coccinelle/api/memdup.cocci |1 - 1 file changed, 1 deletion(-) diff --git a/scripts/coccinelle/api/memdup.cocci b/s

[PATCH] firmware: tegra: adjust tested variable

2018-01-27 Thread Julia Lawall
y = g(...); *if (e) S3 else S4 ) // Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/firmware/tegra/bpmp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/tegra/bpmp.c b/drivers/firmware/tegra/bpmp.c index a7f461f..96362b5 100644 --- a/driv

[PATCH] drm/radeon: adjust tested variable

2018-01-27 Thread Julia Lawall
y = g(...); *if (e) S3 else S4 ) // Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/gpu/drm/radeon/radeon_uvd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_uvd.c b/drivers/gpu/drm/radeon/radeon_uvd.c index d34d1cf..95

Re: [PATCH] Documentation/ABI: clean up sysfs-class-pktcdvd

2018-01-23 Thread Julia Lawall
On Tue, 23 Jan 2018, Aishwarya Pant wrote: > Clean up the sysfs documentation such that it is in the same format as > described in Documentation/ABI/README. Mainly, the patch moves the > attribute names to the 'What:' field. This might be useful for scripting > and tracking changes in the ABI.

Re: Coccinelle: zalloc-simple: Checking consequences from the usage of at signs in Python strings

2018-01-19 Thread Julia Lawall
On Fri, 19 Jan 2018, SF Markus Elfring wrote: > > I removed the blank line at EOF, > > then applied to linux-kbuild/misc. > > This script for the semantic patch language is using the at sign within string > literals for Python code. > > It is nice when this character seems to work also with the

Re: [Nouveau] [PATCH] fix drm-get-put.cocci warnings

2018-01-15 Thread Julia Lawall
On Mon, 15 Jan 2018, Thierry Reding wrote: > On Mon, Jan 15, 2018 at 01:47:07PM +0100, Julia Lawall wrote: > > From: Fengguang Wu <fengguang...@intel.com> > > > > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and > > drm_*_unrefer

[PATCH] fix drm-get-put.cocci warnings

2018-01-15 Thread Julia Lawall
From: Fengguang Wu <fengguang...@intel.com> Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and drm_*_unreference() helpers. Generated by: scripts/coccinelle/api/drm-get-put.cocci Signed-off-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Julia Lawal

Re: [PATCH v2] Coccinelle: kzalloc-simple: Rename kzalloc-simple to zalloc-simple

2018-01-14 Thread Julia Lawall
rs.sourceforge.net> > Signed-off-by: Himanshu Jha <himanshujha199...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> Thanks. > --- > v2: > -generated the patch using -M flag for renaming. > -Since Markus earlier worked on renaming this patch

Re: [PATCH] Coccinelle: ifnullfree: Trim the warning reported in report mode

2018-01-13 Thread Julia Lawall
t; > Signed-off-by: Himanshu Jha <himanshujha199...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > scripts/coccinelle/free/ifnullfree.cocci | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/coccinelle/free/

Re: [PATCH] Coccinelle: kzalloc-simple: Rename kzalloc-simple to zalloc-simple

2018-01-13 Thread Julia Lawall
@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > scripts/coccinelle/api/alloc/kzalloc-simple.cocci | 448 > -- > scripts/coccinelle/api/alloc/zalloc.cocci | 448 > ++ > 2 files changed, 448 insertio

Re: [PATCH] Coccinelle: alloc_cast: Add more memory allocating functions to the list

2018-01-13 Thread Julia Lawall
em, > etc which are used by Sparse in the static analysis of the code. > > Also remove two blank lines at EOF. > > Signed-off-by: Himanshu Jha <himanshujha199...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > scripts/coccinelle/api/alloc/alloc_cas

<    1   2   3   4   5   6   7   8   9   10   >