Re: Coccinelle: badzero.cocci failure

2017-11-15 Thread Julia Lawall
> > Can you try the following semantic patch (called eg nothing.cocci): > > > > @script:ocaml@ > > @@ > > > > () > > > > on any .c file, ie > > > > spatch --sp-file nothing.cocci test.c > > > > > Thanks for the simple test semantic patch! > > > > I noticed 1.0.4 is OK, > but 1.0.5 is NG > > I

Re: Coccinelle: badzero.cocci failure

2017-11-14 Thread Julia Lawall
On Tue, 14 Nov 2017, Masahiro Yamada wrote: > Hi Julia, > > > 2017-11-14 18:07 GMT+09:00 Julia Lawall <julia.law...@lip6.fr>: > >> coccicheck failed > >> $ cat cocci-debug.txt > >> /home/masahiro/bin/spatch -D report --no-show-diff --very-qu

Re: [Cocci] [PATCH v3] coccinelle: fix parallel build with CHECK=scripts/coccicheck

2017-11-14 Thread Julia Lawall
On Tue, 14 Nov 2017, Luis R. Rodriguez wrote: > On Tue, Nov 14, 2017 at 06:04:49PM +0900, Masahiro Yamada wrote: > > diff --git a/scripts/coccicheck b/scripts/coccicheck > > index 040a8b1..7da82a1 100755 > > --- a/scripts/coccicheck > > +++ b/scripts/coccicheck > > @@ -70,6 +64,13 @@ if [ "$C"

Re: [PATCH] crypto/nx: fix spelling mistake: "availavle" -> "available"

2017-11-14 Thread Julia Lawall
On Tue, 14 Nov 2017, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in pr_err error message text > > Signed-off-by: Colin Ian King > --- > drivers/crypto/nx/nx-842-powernv.c | 2 +- > 1 file changed, 1

Re: [PATCH v4] coccinelle: fix parallel build with CHECK=scripts/coccicheck

2017-11-14 Thread Julia Lawall
On Tue, 14 Nov 2017, Masahiro Yamada wrote: > The command "make -j8 C=1 CHECK=scripts/coccicheck COCCI=..." produces > lots of "coccicheck failed" error messages. > > Julia Lawall explained the Coccinelle behavior as follows: > "The problem on the Coccin

Re: [PATCH v3] coccinelle: fix parallel build with CHECK=scripts/coccicheck

2017-11-14 Thread Julia Lawall
On Tue, 14 Nov 2017, Masahiro Yamada wrote: > Hi Julia, > > > 2017-11-14 18:49 GMT+09:00 Julia Lawall <julia.law...@lip6.fr>: > >> + > >> +# If -j option is given to Make, scripts/coccicheck runs in parallel. > >> +# If coccinelle als

Re: [PATCH] kbuild: move coccicheck help in scripts/Makefile.help to top Makefile

2017-11-14 Thread Julia Lawall
On Tue, 14 Nov 2017, Masahiro Yamada wrote: > I do not think it is helpful to have a separate file just for the > coccicheck help message. Merge scripts/Makefile.help into the > top-level Makefile. > > Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> A

Re: [PATCH v3] coccinelle: fix parallel build with CHECK=scripts/coccicheck

2017-11-14 Thread Julia Lawall
> + > +# If -j option is given to Make, scripts/coccicheck runs in parallel. > +# If coccinelle also runs in parallel, it fails because multiple > processes > +# try to get access to the same subdirectory that stores stdout/stderr. > +# No need to parallelize coccinelle in this

Re: Coccinelle: badzero.cocci failure

2017-11-14 Thread Julia Lawall
> coccicheck failed > $ cat cocci-debug.txt > /home/masahiro/bin/spatch -D report --no-show-diff --very-quiet > --cocci-file scripts/coccinelle/null/badzero.cocci --dir . -I > ./arch/x86/include -I ./arch/x86/include/generated -I ./include -I > ./arch/x86/include/uapi -I

Re: [PATCH v2] coccinelle: fix parallel build with CHECK=scripts/coccicheck

2017-11-13 Thread Julia Lawall
On Tue, 14 Nov 2017, Masahiro Yamada wrote: > Hi Julia, > > 2017-11-14 1:45 GMT+09:00 Julia Lawall <julia.law...@lip6.fr>: > > > > > > On Tue, 14 Nov 2017, Masahiro Yamada wrote: > > > >> Hi Julia, > >> > >>

Re: [PATCH] docs: dev-tools: coccinelle: delete out of date wiki reference

2017-11-13 Thread Julia Lawall
On Tue, 14 Nov 2017, Masahiro Yamada wrote: > Hi Julia, Jon, > > 2017-11-14 1:50 GMT+09:00 Julia Lawall <julia.law...@lip6.fr>: > > The wiki is no longer available. > > > > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> > > > > > Jo

[PATCH] docs: dev-tools: coccinelle: delete out of date wiki reference

2017-11-13 Thread Julia Lawall
The wiki is no longer available. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- diff --git a/Documentation/dev-tools/coccinelle.rst b/Documentation/dev-tools/coccinelle.rst index 37e474f..94f41c2 100644 --- a/Documentation/dev-tools/coccinelle.rst +++ b/Documentation/dev

Re: [PATCH v2] coccinelle: fix parallel build with CHECK=scripts/coccicheck

2017-11-13 Thread Julia Lawall
On Tue, 14 Nov 2017, Masahiro Yamada wrote: > Hi Julia, > > > 2017-11-14 0:30 GMT+09:00 Julia Lawall <julia.law...@lip6.fr>: > > > > > > On Thu, 9 Nov 2017, Masahiro Yamada wrote: > > > >> The command "make -j8 C=1 CHECK=scripts/coc

Re: [Cocci] [PATCH v2] coccinelle: fix parallel build with CHECK=scripts/coccicheck

2017-11-13 Thread Julia Lawall
On Tue, 14 Nov 2017, Masahiro Yamada wrote: > Hi Julia, > > > 2017-11-11 16:30 GMT+09:00 Julia Lawall <julia.law...@lip6.fr>: > > > > > > On Fri, 10 Nov 2017, Julia Lawall wrote: > > > >> > >> > >> On Thu, 9 Nov 2017, Masah

Re: [PATCH v2] coccinelle: fix parallel build with CHECK=scripts/coccicheck

2017-11-13 Thread Julia Lawall
On Thu, 9 Nov 2017, Masahiro Yamada wrote: > The command "make -j8 C=1 CHECK=scripts/coccicheck" produces lots of > "coccicheck failed" error messages. > > I do not know the coccinelle internals, but I guess --jobs does not > work well if spatch is invoked from Make running in parallel. >

[PATCH v2] coccinelle: orplus: reorganize to improve performance

2017-11-12 Thread Julia Lawall
results. Running time is divided by 3 when applying this to the whole kernel on my laptop with an Intel i5-6200U CPU. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- v2: added SOB and fixed typos in the commit message diff --git a/scripts/coccinelle/misc/orplus.cocci b/scripts/c

[PATCH] coccinelle: orplus: reodganize to improve performance

2017-11-12 Thread Julia Lawall
Adding two #define constants is less common than performing & and | operations on them, so put the addition first to reduce the set of cases that have to be considered in detail. At the same time, add & and | patterns for both arguments of +, to account for commutativity and obtain more results.

[PATCH] coccinelle: flags.cocci: reorganize patterns to improve efficiency

2017-11-12 Thread Julia Lawall
sequence. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- diff --git a/scripts/coccinelle/locks/flags.cocci b/scripts/coccinelle/locks/flags.cocci index debd70e..33f29a5 100644 --- a/scripts/coccinelle/locks/flags.cocci +++ b/scripts/coccinelle/locks/flags.cocci @@ -12,9 +12,9 @@ v

[PATCH] coccinelle: use exists to improve efficiency

2017-11-12 Thread Julia Lawall
This just needs to find any reassignment of the loop iterator, and doesn't need such a thing on all execution paths, so use exists on the first rule. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- diff --git a/scripts/coccinelle/iterators/list_entry_update.cocci b/scripts/cocc

Re: [PATCH] ALSA: ak4531_codec: Use common error handling code in snd_ak4531_mixer()

2017-11-12 Thread Julia Lawall
On Sun, 12 Nov 2017, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 12 Nov 2017 10:56:19 +0100 > > * Add a jump target so that a bit of exception handling can be better > reused at the end of this function. > > This issue was detected by using

Re: [Cocci] [PATCH v2] coccinelle: fix parallel build with CHECK=scripts/coccicheck

2017-11-10 Thread Julia Lawall
On Fri, 10 Nov 2017, Julia Lawall wrote: > > > On Thu, 9 Nov 2017, Masahiro Yamada wrote: > > > The command "make -j8 C=1 CHECK=scripts/coccicheck" produces lots of > > "coccicheck failed" error messages. > > The question is where parallelism

Re: [PATCH 1/2] KEYS: trusted: Use common error handling code in trusted_update()

2017-11-10 Thread Julia Lawall
On Fri, 10 Nov 2017, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 10 Nov 2017 20:50:15 +0100 > > Adjust jump targets so that a bit of exception handling can be better > reused at the end of this function. Unless there is a strong motivation for

Re: [PATCH v2] coccinelle: fix parallel build with CHECK=scripts/coccicheck

2017-11-10 Thread Julia Lawall
On Thu, 9 Nov 2017, Masahiro Yamada wrote: > The command "make -j8 C=1 CHECK=scripts/coccicheck" produces lots of > "coccicheck failed" error messages. The question is where parallelism should be specified. Currently, make coccicheck picks up the number of cores on the machine and passes that

Re: [PATCH] coccinelle: fix verbose message about .cocci file being run

2017-11-08 Thread Julia Lawall
On Tue, 7 Nov 2017, Masahiro Yamada wrote: > 2017-10-26 16:22 GMT+09:00 Nicolas Palix (LIG) : > > Le 26/10/17 à 06:55, Masahiro Yamada a écrit : > >> > >> If you run coccicheck with V=1 and COCCI=, you will see a strange > >> path to the semantic patch file. For example,

Re: [PATCH] Coccinelle: setup_timer: improve messages from setup_timer

2017-11-08 Thread Julia Lawall
On Tue, 7 Nov 2017, Masahiro Yamada wrote: > 2017-08-23 22:11 GMT+09:00 Julia Lawall <julia.law...@lip6.fr>: > > Allow messages about multiple timers. > > > > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> > > > > --- > > > Applied to linux-kbuild/misc. Thanks! julia

Re: [PATCH 2/2] scripts: coccinelle: api: detect identical chip data arrays

2017-11-08 Thread Julia Lawall
On Tue, 7 Nov 2017, Masahiro Yamada wrote: > 2017-10-09 4:18 GMT+09:00 Julia Lawall <julia.law...@lip6.fr>: > > This semantic patch detects duplicate arrays declared using BQ27XXX_DATA > > within a single structure. It is currently specific to the file >

Re: [PATCH] coccinelle: grep Options and Requires fields more precisely

2017-11-08 Thread Julia Lawall
On Tue, 7 Nov 2017, Masahiro Yamada wrote: > 2017-10-26 16:26 GMT+09:00 Nicolas Palix (LIG) <nicolas.pa...@imag.fr>: > > Le 26/10/17 à 06:59, Julia Lawall a écrit : > >> > >> > >> > >> On Thu, 26 Oct 2017, Masahiro Yamada wrote: > >

Re: [PATCH] Coccinelle: use false positive annotation

2017-11-08 Thread Julia Lawall
On Tue, 7 Nov 2017, Masahiro Yamada wrote: > 2017-10-30 12:52 GMT+09:00 Julia Lawall <julia.law...@lip6.fr>: > > > > > > On Mon, 30 Oct 2017, Masahiro Yamada wrote: > > > >> Hi Julia, > >> > >> > >> 2017-10-29 8:43 GMT

Re: [PATCH] Coccinelle: make DEBUG_FILE option more useful

2017-11-08 Thread Julia Lawall
On Tue, 7 Nov 2017, Masahiro Yamada wrote: > 2017-10-26 13:02 GMT+09:00 Julia Lawall <julia.law...@lip6.fr>: > > > > > > On Thu, 26 Oct 2017, Masahiro Yamada wrote: > > > >> Hi Julia, > >> > >> > >> 2017-10-15 18:55 GMT+09:0

Re: [PATCH] scsi: Use vzalloc instead of vmalloc/memset

2017-11-07 Thread Julia Lawall
On Wed, 8 Nov 2017, Himanshu Jha wrote: > On Tue, Nov 07, 2017 at 08:51:36PM +0100, Luis R. Rodriguez wrote: > > On Sun, Nov 05, 2017 at 03:26:26AM +0530, Himanshu Jha wrote: > > > Use vzalloc instead of vmalloc/memset to allocate memory filled with 0 > > > value. > > > > > > Done using

Re: [patch v10 1/4] drivers: jtag: Add JTAG core driver (fwd)

2017-11-02 Thread Julia Lawall
It looks like the return on line 137 belongs after line 138. julia -- Forwarded message -- Date: Thu, 2 Nov 2017 21:02:22 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [patch v10 1/4] d

Re: Adjustments for a lot of function implementations

2017-10-30 Thread Julia Lawall
On Mon, 30 Oct 2017, SF Markus Elfring wrote: > > While we do not mind cleanup patches, the way you post them (one fix per > > file) > > I find it safer in this way while I was browsing through the landscape of > Linux > software components. > > > > is really annoying and takes us too much

Re: [PATCH] Coccinelle: use false positive annotation

2017-10-29 Thread Julia Lawall
On Mon, 30 Oct 2017, Masahiro Yamada wrote: > Hi Julia, > > > 2017-10-29 8:43 GMT+09:00 Julia Lawall <julia.law...@lip6.fr>: > > /// is to describe the semantic patch, while //# indicates reasons > > for false positives. > > > > Signed-

Re: [PATCH] [media] bdisp: remove redundant assignment to pix

2017-10-29 Thread Julia Lawall
On Sun, 29 Oct 2017, Colin King wrote: > From: Colin Ian King > > Pointer pix is being initialized to a value and a little later > being assigned the same value again. Remove the redundant second > duplicate assignment. Cleans up the clang warning: > >

[PATCH] Coccinelle: use false positive annotation

2017-10-28 Thread Julia Lawall
/// is to describe the semantic patch, while //# indicates reasons for false positives. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- scripts/coccinelle/misc/ifcol.cocci |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/coccinelle/misc/ifcol.co

Re: [PATCH] coccinelle: grep Options and Requires fields more precisely

2017-10-25 Thread Julia Lawall
;Requires:" in order to avoid accidental matching to what just happens > to appear in comment lines. > > Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> Thanks for checking on this! Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > > scripts/cocciche

Re: [PATCH] Coccinelle: make DEBUG_FILE option more useful

2017-10-25 Thread Julia Lawall
On Thu, 26 Oct 2017, Masahiro Yamada wrote: > Hi Julia, > > > 2017-10-15 18:55 GMT+09:00 Julia Lawall <julia.law...@lip6.fr>: > > Make coccicheck checked for the existence of DEBUG_FILE on each semantic > > patch, and bailed if it already existed. This meant t

Re: [PATCH v2 02/15] usb: gadget: make config_item_type structures const

2017-10-20 Thread Julia Lawall
On Thu, 19 Oct 2017, Laurent Pinchart wrote: > Hi Christoph, > > On Thursday, 19 October 2017 17:06:57 EEST Christoph Hellwig wrote: > > > Now we have 9 const instances of the config_item_type structure that are > > > identical, with only the .ct_owner field set. Should they be all merged > > >

Re: [Outreachy kernel] Re: [PATCH v2] Staging: rtl8188eu: core: rtw_ap: Use list_for_each_entry_safe

2017-10-18 Thread Julia Lawall
On Wed, 18 Oct 2017, Srishti Sharma wrote: > > > On Wed, Oct 18, 2017 at 8:29 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Wed, 18 Oct 2017, Srishti Sharma wrote: > > > > > > > On Wed, Oct 18, 2017 at 6:01 PM, Greg

Re: [Outreachy kernel] Re: [PATCH v2] Staging: rtl8188eu: core: rtw_ap: Use list_for_each_entry_safe

2017-10-18 Thread Julia Lawall
On Wed, 18 Oct 2017, Srishti Sharma wrote: > > > On Wed, Oct 18, 2017 at 6:01 PM, Greg KH wrote: > On Thu, Oct 05, 2017 at 03:16:42PM +0530, Srishti Sharma wrote: > > This is a cleanup patch and doesn't change runtime behavior. > It > >

RE: Adjusting further size determinations?

2017-10-18 Thread Julia Lawall
On Wed, 18 Oct 2017, David Laight wrote: > From: SF Markus Elfring > > Unpleasant consequences are possible in both cases. > > >> How much do you care to reduce the failure probability further? > > > > > > Zero. > > > > I am interested to improve the software situation a bit more here. > >

RE: char-TPM: Adjustments for ten function implementations

2017-10-18 Thread Julia Lawall
On Wed, 18 Oct 2017, alexander.stef...@infineon.com wrote: > > On Wed, 2017-10-18 at 11:00 +0200, SF Markus Elfring wrote: > > > > The printk removals do change the objects. > > > > > > > > The value of that type of change is only for resource limited systems. > > > > > > I imagine that such

Re: [PATCH 3/4] char/tpm: Improve a size determination in nine functions

2017-10-17 Thread Julia Lawall
On Tue, 17 Oct 2017, Mimi Zohar wrote: > On Tue, 2017-10-17 at 14:58 +0200, Julia Lawall wrote: > > > > On Tue, 17 Oct 2017, Mimi Zohar wrote: > > > > > On Tue, 2017-10-17 at 11:50 +, alexander.stef...@infineon.com > > > wrote: > > > &g

Re: [PATCH 1/2] CLK: SPEAr: make structure field and function argument as const

2017-10-17 Thread Julia Lawall
On Tue, 17 Oct 2017, Bhumika Goyal wrote: > Make the masks field of clk_aux structure const as it do not modify the > fields of the aux_clk_masks structure it points to. > > Make the struct aux_clk_masks *aux argument of the function > clk_register_aux as const as the argument is only stored in

Re: [PATCH 3/4] char/tpm: Improve a size determination in nine functions

2017-10-17 Thread Julia Lawall
On Tue, 17 Oct 2017, Mimi Zohar wrote: > On Tue, 2017-10-17 at 11:50 +, alexander.stef...@infineon.com > wrote: > > > > Replace the specification of data structures by pointer dereferences > > > > as the parameter for the operator "sizeof" to make the corresponding > > > > size > > > >

Re: [PATCH v2 00/15] make structure field, function arguments and structures const

2017-10-17 Thread Julia Lawall
On Tue, 17 Oct 2017, Greg KH wrote: > On Mon, Oct 16, 2017 at 05:18:39PM +0200, Bhumika Goyal wrote: > > Make the ci_type field and some function arguments as const. After this > > change, make config_item_type structures as const. > > > > * Changes in v2- Combine all the followup patches and

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

2017-10-17 Thread Julia Lawall
On Tue, 17 Oct 2017, Dan Carpenter wrote: > On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote: > > > > > > On Tue, 17 Oct 2017, Dan Carpenter wrote: > > > > > On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote: > > > > &g

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

2017-10-17 Thread Julia Lawall
On Tue, 17 Oct 2017, Dan Carpenter wrote: > On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote: > > > > A minor complaint: all commits are missing "Fixes:" tag. > > > > Fixes is only for bug fixes. These don't fix any bugs. 0-day seems to put Fixes for everything. Should they be

Re: [Ocfs2-devel] [PATCH] ocfs2/cluster: make config_item_type const

2017-10-15 Thread Julia Lawall
On Sun, 15 Oct 2017, Gang He wrote: > Hello Intel Kbuild team, > > You just upgrade GCC version when compiling the latest kernel? > Since these code looks a little old, I am sure that the related contributors > are still work on OCFS2 project. I'm not sure to understand the comment. The

[PATCH] Coccinelle: make DEBUG_FILE option more useful

2017-10-15 Thread Julia Lawall
a 2>> to append to the file on each semantic patch. Furthermore, the spatch command that is run for each semantic patch is also added to the DEBUG_FILE, to make clear what each stdout trace corresponds to. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- scripts/co

[PATCH] docs: dev-tools: correct Coccinelle version number

2017-10-15 Thread Julia Lawall
There is no Coccinelle version 1.2. 1.0.2 must be what was intended. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- Documentation/dev-tools/coccinelle.rst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/dev-tools/coccinelle.rst b/Documentati

Re: [Outreachy kernel] [PATCH v2 1/2] staging: atomisp2: cleanup null check on memory allocation

2017-10-14 Thread Julia Lawall
e_alloc_node\|kmalloc_node\|kzalloc_node\|devm_kzalloc\)(...) > ...when != p > > if ( > - p == NULL > + !p > ) s > else s1 > > Signed-off-by: Aishwarya Pant <aishp...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > > -- > Changes in atomisp2/css

Re: drivers/staging/rtlwifi/base.c:920:7-9: WARNING: possible condition with no effect (if == else)

2017-10-13 Thread Julia Lawall
On Fri, 13 Oct 2017, Larry Finger wrote: > Julia, > > On 10/13/2017 08:55 AM, Julia Lawall wrote: > > It seems that the then and else branches of the conditions on lines 920 > > and 932 are the same. > > I think line 923 should be using RTL_RC_VH

Re: [Outreachy kernel] [PATCH] Staging: speakup: Replace symbolic permissions with octal permissions

2017-10-13 Thread Julia Lawall
On Sat, 14 Oct 2017, Shreeya Patel wrote: > Resolve following checkpatch issue: > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. > Consider using octal permissions '0444'. > > Signed-off-by: Shreeya Patel > --- > drivers/staging/speakup/speakup_bns.c

Re: [Outreachy kernel] [PATCH v3] drm/amd/powerplay: Remove unnecessary cast on void pointer

2017-10-13 Thread Julia Lawall
On Sat, 14 Oct 2017, Harsha Sharma wrote: > Done with following coccinelle patch > > @r@ > expression x; > void* e; > type T; > identifier f; > @@ > ( > *((T *)e) > | > ((T *)x)[...] > | > ((T*)x)->f > | > > - (T*) > e > ) > > Signed-off-by: Harsha Sharma >

Re: [Outreachy kernel] [PATCH v2] drm/amd/powerplay: Remove unnecessary cast on void pointer

2017-10-13 Thread Julia Lawall
> @@ -3400,7 +3400,7 @@ static int smu7_read_sensor(struct pp_hwmgr *hwmgr, int > idx, > static int smu7_find_dpm_states_clocks_in_dpm_table(struct pp_hwmgr *hwmgr, > const void *input) > { > const struct phm_set_power_state_input *states = > - (const struct

Re: [PATCH] powerpc/eeh: make eeh_ops structures _ro_after_init

2017-10-13 Thread Julia Lawall
On Fri, 13 Oct 2017, Bhumika Goyal wrote: > These structures are passed to the eeh_ops_register function during the > initialization phase. There they get stored in a structure variable > which only makes function calls through function pointers. There is no > other usage of these eeh_ops

Re: [Outreachy kernel] [PATCH] drm/amd/powerplay: Remove unnecessary cast on void pointer

2017-10-13 Thread Julia Lawall
On Fri, 13 Oct 2017, Harsha Sharma wrote: > Done with following coccinelle patch > > @r@ > expression x; > void* e; > type T; > identifier f; > @@ > ( > *((T *)e) > | > ((T *)x)[...] > | > ((T*)x)->f > | > > - (T*) > e > ) > > Signed-off-by: Harsha Sharma >

Re: drivers/staging/rtlwifi/base.c:920:7-9: WARNING: possible condition with no effect (if == else)

2017-10-13 Thread Julia Lawall
It seems that the then and else branches of the conditions on lines 920 and 932 are the same. julia On Fri, 13 Oct 2017, kbuild test robot wrote: > CC: kbuild-...@01.org > CC: linux-kernel@vger.kernel.org > TO: Larry Finger > CC: "Greg Kroah-Hartman"

Re: [Outreachy kernel] [PATCH] drm: Replace kzalloc with kcalloc

2017-10-12 Thread Julia Lawall
On Fri, 13 Oct 2017, Harsha Sharma wrote: > Prefer kcalloc over kzalloc to allocate an array. > This patch fixes checkcpatch issue. > > Signed-off-by: Harsha Sharma > --- > drivers/gpu/drm/drm_crtc_helper.c | 4 ++-- > drivers/gpu/drm/drm_fb_helper.c| 2 +- >

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

2017-10-10 Thread Julia Lawall
On Tue, 10 Oct 2017, Levin, Alexander (Sasha Levin) wrote: > (Cc'ed Julia) > > On Mon, Oct 09, 2017 at 09:33:01AM -0700, Laura Abbott wrote: > >On 10/06/2017 08:10 PM, Levin, Alexander (Sasha Levin) wrote: > >> We are experimenting with using neural network to aid with patch > >> selection for

Re: [PATCH 0/2] detect identical chip data arrays

2017-10-09 Thread Julia Lawall
On Mon, 9 Oct 2017, Masahiro Yamada wrote: > 2017-10-09 5:44 GMT+09:00 Julia Lawall <julia.law...@lip6.fr>: > > > > > > On Sun, 8 Oct 2017, Sebastian Reichel wrote: > > > >> Hi, > >> > >> On Sun, Oct 08, 2017 at 09:18

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-09 Thread Julia Lawall
>> Also maybe the name of the script should include "bq27xxx_data"? > > > > > > > > OK > > > > > > > >> Few more comments below... > > > >> > > > >> On Sun, Oct 1, 2017 at 5:42 AM, Julia Lawall <ju

Re: [PATCH 0/2] detect identical chip data arrays

2017-10-08 Thread Julia Lawall
On Sun, 8 Oct 2017, Sebastian Reichel wrote: > Hi, > > On Sun, Oct 08, 2017 at 09:18:39PM +0200, Julia Lawall wrote: > > Rename battery.cocci as check_bq27xxx_data.cocci and adjust the warning > > messages to indicate that some structures are the same, in response to &

[PATCH 1/2] scripts: coccinelle: api: drop battery.cocci

2017-10-08 Thread Julia Lawall
Drop bettery.cocci as a more specific filename was preferred. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- scripts/coccinelle/api/battery.cocci | 161 --- 1 file changed, 161 deletions(-) diff --git a/scripts/coccinelle/api/battery.cocci b/s

[PATCH 2/2] scripts: coccinelle: api: detect identical chip data arrays

2017-10-08 Thread Julia Lawall
in the future. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- scripts/coccinelle/api/check_bq27xxx_data.cocci | 161 1 file changed, 161 insertions(+) diff --git a/scripts/coccinelle/api/check_bq27xxx_data.cocci b/scripts/coccinelle/api/check_bq27xxx_data.coc

[PATCH 0/2] detect identical chip data arrays

2017-10-08 Thread Julia Lawall
Rename battery.cocci as check_bq27xxx_data.cocci and adjust the warning messages to indicate that some structures are the same, in response to feedback from Liam Breck. Although check_bq27xxx_data.cocci says is requires Coccinelle 1.0.7, which is not yet released, it actually works with the

Re: [Outreachy kernel] [PATCH v2] Staging: rtl8723bs: core: rtw_cmd: Remove cast to pointer types in kfree

2017-10-07 Thread Julia Lawall
n't have enough type information. > > @r@ > type T,P; > T* x; > @@ > > kfree( > -(P *) > x ) > > Signed-off-by: Srishti Sharma <srishtis...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > Changes in v2: > -Do transformation l

Re: [Outreachy kernel] [PATCH v2] Staging: pi433: Fix the position of brace after if

2017-10-07 Thread Julia Lawall
; @@ > > if(... > - )@p1 > -{@p2 > +) { > ... > } > > Signed-off-by: Srishti Sharma <srishtis...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > Changes in v2: > -Improve commit message. > > drivers/staging/pi433/pi43

Re: [Outreachy kernel] [PATCH] Staging: rtl8723bs: core: rtw_cmd: Remove cast to pointer types in kfree

2017-10-07 Thread Julia Lawall
On Sun, 8 Oct 2017, Srishti Sharma wrote: > On Sat, Oct 7, 2017 at 11:42 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > > > > On Sat, 7 Oct 2017, Srishti Sharma wrote: > > > >> The cast to pointer types in kfree is not needed and can be dropp

Re: [Outreachy kernel] [PATCH] Staging: rtl8723bs: core: rtw_cmd: Remove cast to pointer types in kfree

2017-10-07 Thread Julia Lawall
On Sat, 7 Oct 2017, Srishti Sharma wrote: > The cast to pointer types in kfree is not needed and can be dropped. > Done using the following semantic by coccinelle. > > @r@ > type T,P; > T* x; > @@ > > kfree( > -(P *) > x ) > > Signed-off-by: Srishti Sharma > --- >

Re: [Outreachy kernel] [PATCH] Staging: pi433: Fix the position of brace after if

2017-10-07 Thread Julia Lawall
On Sat, 7 Oct 2017, Srishti Sharma wrote: > Fix the position of the brace after if when it is on the next line > or when there is no space between them. Done using the following > semantic patch by coccinelle. As far as I can see, in practice, you only move up { from the line below. There is

Re: [Outreachy kernel] [PATCH] Staging: rtlwifi: phydm: Use setup_timer

2017-10-07 Thread Julia Lawall
gt; @@ > > -init_timer(l); > +setup_timer(l,f,d); > ... > > ( > - l->function = f; > ... > - l->data = d; > | > - l->data = d; > ... > - l->function = f; > ) > > Signed-off-by: Srishti Sharma <srishtis...@gmail.com> Acked-by: Julia L

Re: [Outreachy kernel] [PATCH] Staging: media: atomisp: pci: Eliminate use of typedefs for struct

2017-10-07 Thread Julia Lawall
gt; ... > } > - T > ; > > @r3@ > type r1.T; > identifier p.T1; > @@ > > - T > + struct T1 > > Signed-off-by: Srishti Sharma <srishtis...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > .../media/atomisp/pci/atomisp2/css2400

Re: [PATCH 1/2] powerpc/platforms/cell: Delete an error message for a failed memory allocation in three functions

2017-10-05 Thread Julia Lawall
On Thu, 5 Oct 2017, Michal Suchánek wrote: > Hello, > > On Thu, 5 Oct 2017 21:36:26 +0200 > SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Thu, 5 Oct 2017 21:04:30 +0200 > > > > Omit extra messages for a memory

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Julia Lawall
On Thu, 5 Oct 2017, Joe Perches wrote: > On Thu, 2017-10-05 at 12:46 -0700, Liam Breck wrote: > > Hi Joe, > > > > On Thu, Oct 5, 2017 at 12:30 PM, Joe Perches <j...@perches.com> wrote: > > > On Thu, 2017-10-05 at 21:19 +0200, Julia Lawall wrote: > >

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Julia Lawall
On Thu, 5 Oct 2017, Joe Perches wrote: > On Thu, 2017-10-05 at 21:40 +0200, Julia Lawall wrote: > > On Thu, 5 Oct 2017, Joe Perches wrote: > > > btw: spatch 1.7 doesn't seem to have a tag in git > > > > > > From the script: > > > > > > /

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Julia Lawall
On Thu, 5 Oct 2017, Liam Breck wrote: > Hi Julia, > > On Thu, Oct 5, 2017 at 12:25 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > > > > On Thu, 5 Oct 2017, Liam Breck wrote: > > > >> Hi, sorry for slow reply... > >> >

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Julia Lawall
On Thu, 5 Oct 2017, Liam Breck wrote: > Hi Julia, > > On Thu, Oct 5, 2017 at 12:25 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > > > > On Thu, 5 Oct 2017, Liam Breck wrote: > > > >> Hi, sorry for slow reply... > >> >

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Julia Lawall
On Thu, 5 Oct 2017, Joe Perches wrote: > On Thu, 2017-10-05 at 21:19 +0200, Julia Lawall wrote: > > On Thu, 5 Oct 2017, Joe Perches wrote: > > > On Thu, 2017-10-05 at 21:13 +0200, Julia Lawall wrote: > > > > On Fri, 6 Oct 2017, Masahiro Yamada wrote: > > &g

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Julia Lawall
On Thu, 5 Oct 2017, Liam Breck wrote: > Hi Joe, > > On Thu, Oct 5, 2017 at 12:15 PM, Joe Perches <j...@perches.com> wrote: > > On Thu, 2017-10-05 at 21:13 +0200, Julia Lawall wrote: > >> > >> On Fri, 6 Oct 2017, Masahiro Yamada wrote: > >>

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Julia Lawall
he 0-day bot. > Also maybe the name of the script should include "bq27xxx_data"? OK > Few more comments below... > > On Sun, Oct 1, 2017 at 5:42 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > > This semantic patch detects duplicate arrays declared us

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Julia Lawall
On Thu, 5 Oct 2017, Joe Perches wrote: > On Thu, 2017-10-05 at 21:13 +0200, Julia Lawall wrote: > > > > On Fri, 6 Oct 2017, Masahiro Yamada wrote: > > > > > 2017-10-01 21:42 GMT+09:00 Julia Lawall <julia.law...@lip6.fr>: > > > > This semant

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Julia Lawall
On Fri, 6 Oct 2017, Masahiro Yamada wrote: > 2017-10-01 21:42 GMT+09:00 Julia Lawall <julia.law...@lip6.fr>: > > This semantic patch detects duplicate arrays declared using BQ27XXX_DATA > > within a single structure. It is currently specific to the file >

Re: [PATCH 1/5] cris: nand: Delete an error message for a failed memory allocation in crisv32_nand_flash_probe()

2017-10-04 Thread Julia Lawall
On Wed, 4 Oct 2017, Alexander Sverdlin wrote: > Hello Markus, > > On Wed, 4 Oct 2017 20:45:14 +0200 > SF Markus Elfring wrote: > > > Omit an extra message for a memory allocation failure in this function. > > > > This issue was detected by using the Coccinelle

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

2017-10-04 Thread Julia Lawall
On Wed, 4 Oct 2017, Srishti Sharma wrote: > On Wed, Oct 4, 2017 at 8:38 PM, Dan Carpenter <dan.carpen...@oracle.com> > wrote: > > On Wed, Oct 04, 2017 at 03:34:05PM +0200, Julia Lawall wrote: > >> Again, you have three patches on different files with the same subjec

Re: [Outreachy kernel] Re: [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

2017-10-04 Thread Julia Lawall
On Wed, 4 Oct 2017, Dan Carpenter wrote: > On Wed, Oct 04, 2017 at 03:39:30PM +0200, Julia Lawall wrote: > > > > > > On Wed, 4 Oct 2017, Dan Carpenter wrote: > > > > > On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote: > > > > Use lis

Re: [Outreachy kernel] Re: [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

2017-10-04 Thread Julia Lawall
On Wed, 4 Oct 2017, Dan Carpenter wrote: > On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote: > > Use list_for_each_entry_safe when the list elements may get deleted > > during traversal. > > This patch is fine as a cleanup but none of these are actually buggy. I'm not sure what

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

2017-10-04 Thread Julia Lawall
Again, you have three patches on different files with the same subject line. You could add the file name eg rtw_ap: to the subject line to make them unique. julia On Wed, 4 Oct 2017, Srishti Sharma wrote: > Use list_for_each_entry_safe to make the code more compact. Done > by the following

Re: [PATCH] [media] ov5645: I2C address change (fwd)

2017-10-04 Thread Julia Lawall
Hello, It seems that an unlock is missing on line 764. julia -- Forwarded message -- Date: Wed, 4 Oct 2017 05:59:09 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH] [media] ov5645:

Re: [Outreachy kernel] [PATCH] staging: rts5208: use usleep_range instead of udelay

2017-10-02 Thread Julia Lawall
On Mon, 2 Oct 2017, Keerthi Reddy wrote: > Since a its a slow device, allow a small range of 100 How do you know that it is a slow device? Try to make the commit log message more self contained, not a continuation of the subject line, and use the imperative. julia > > Signed-off-by: Keerthi

[PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-01 Thread Julia Lawall
This semantic patch detects duplicate arrays declared using BQ27XXX_DATA within a single structure. It is currently specific to the file drivers/power/supply/bq27xxx_battery.c. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- scripts/coccinelle/api/battery.cocci

Re: [Outreachy kernel] [PATCH 6/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

2017-09-30 Thread Julia Lawall
On Sat, 30 Sep 2017, Srishti Sharma wrote: > For variables of type struct list_head* use list_entry to access > current list element instead of using container_of. Done by the > following semantic patch by coccinelle. > > @r@ > struct list_head* l; > @@ > > -container_of > +list_entry >

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_entry instead of container_of

2017-09-30 Thread Julia Lawall
On Sat, 30 Sep 2017, Srishti Sharma wrote: > On Sat, Sep 30, 2017 at 11:36 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > > > > On Sat, 30 Sep 2017, Srishti Sharma wrote: > > > >> On Sat, Sep 30, 2017 at 10:35 AM, Julia

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_entry instead of container_of

2017-09-30 Thread Julia Lawall
On Sat, 30 Sep 2017, Srishti Sharma wrote: > On Sat, Sep 30, 2017 at 10:35 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > > > > On Sat, 30 Sep 2017, Srishti Sharma wrote: > > > >> For variables of the type struct list_head* use list_entry to ac

Re: [Outreachy kernel] [PATCH] Staging: rtl8723bs: Remove unnecessary comments.

2017-09-29 Thread Julia Lawall
On Sat, 30 Sep 2017, Shreeya Patel wrote: > On Fri, 2017-09-29 at 23:10 +0200, Julia Lawall wrote: > > > > On Sat, 30 Sep 2017, Shreeya Patel wrote: > > > > > > > > The comments regarding memset are not needed in the > > > files whic

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_entry instead of container_of

2017-09-29 Thread Julia Lawall
On Sat, 30 Sep 2017, Srishti Sharma wrote: > For variables of the type struct list_head* use list_entry to access > the current list element instead of using container_of. > Done using the following semantic patch by coccinelle. > > @r@ > identifier e; > struct list_head* l; > @@ > > <... when

Re: [Outreachy kernel] [PATCH] Staging: rtl8723bs: Remove unnecessary comments.

2017-09-29 Thread Julia Lawall
On Sat, 30 Sep 2017, Shreeya Patel wrote: > The comments regarding memset are not needed in the > files which have been modified since the necessary changes > are already there in the files. The comments don't look very useful, but I don't understand "since the necessary changes are alread

Re: [PATCH v2 02/10] pinctrl: axp209: add pinctrl features (fwd)

2017-09-29 Thread Julia Lawall
On Fri, 29 Sep 2017, Quentin Schulz wrote: > Hi Julia, > > On 29/09/2017 14:15, Julia Lawall wrote: > > I'm not sure that it is allowed to do krealloc on devm allocated data. > > See lins 468 and 485. > > > > Indeed, from a glance at the code, it does not look l

Re: [PATCH v2 02/10] pinctrl: axp209: add pinctrl features (fwd)

2017-09-29 Thread Julia Lawall
I'm not sure that it is allowed to do krealloc on devm allocated data. See lins 468 and 485. julia -- Forwarded message -- Date: Fri, 29 Sep 2017 20:00:03 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr>

<    1   2   3   4   5   6   7   8   9   10   >