On Fri, 17 Jul 2020, Denis Efremov wrote:
> Check for memset()/memzero_explicit() followed by kfree()/vfree()/kvfree().
>
> Signed-off-by: Denis Efremov
Applied.
> ---
> Changes in v2:
> - memset_explicit() added
> - kvfree_sensitive() added
> - forall added to r1
> - ... between memset
Unneeded warning message on failure of platform_get_irq.
julia
-- Forwarded message --
Date: Thu, 16 Jul 2020 08:05:55 +0800
From: kernel test robot
To: kbu...@lists.01.org
Cc: l...@intel.com, Julia Lawall
Subject: drivers/pci/controller/pci-v3-semi.c:808:2-9: line 808 is
On Tue, 14 Jul 2020, Suraj Upadhyay wrote:
> Remove the unnecessary label from dn_dev_ioctl() and make its error
> handling simpler to read.
>
> Signed-off-by: Suraj Upadhyay
> ---
> net/decnet/dn_dev.c | 8 +++-
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/net/decne
On Mon, 13 Jul 2020, Takashi Iwai wrote:
> On Mon, 13 Jul 2020 10:43:28 +0200,
> Julia Lawall wrote:
> >
> >
> >
> > On Mon, 13 Jul 2020, Takashi Iwai wrote:
> >
> > > On Wed, 08 Jul 2020 20:14:27 +0200,
> > > Dan Williams wrote:
&g
On Mon, 13 Jul 2020, Takashi Iwai wrote:
> On Wed, 08 Jul 2020 20:14:27 +0200,
> Dan Williams wrote:
> >
> > +Recommended replacements for 'blacklist/whitelist' are:
> > +'denylist / allowlist'
> > +'blocklist / passlist'
>
> I started looking through the tree now and noticed there are
-- Forwarded message --
Date: Sun, 12 Jul 2020 11:15:29 +0800
From: kernel test robot
To: kbu...@lists.01.org
Cc: l...@intel.com, Julia Lawall
Subject: drivers/gpu/drm/mediatek/mtk_dpi.c:721:2-9: line 721 is redundant
because platform_get_irq() already prints an error
CC
On Sun, 12 Jul 2020, Christophe JAILLET wrote:
> Le 12/07/2020 à 08:32, Joe Perches a écrit :
> > On Sun, 2020-07-12 at 08:29 +0200, Christophe JAILLET wrote:
> > > Le 11/07/2020 à 23:20, Joe Perches a écrit :
> > > > On Sat, 2020-07-11 at 22:49 +0200, Christophe JAILLET wrote:
> > > > > The wra
Hello,
Please check whether there should be an unlock before line 53.
julia
-- Forwarded message --
Date: Fri, 10 Jul 2020 19:00:10 +0800
From: kernel test robot
To: kbu...@lists.01.org
Cc: l...@intel.com, Julia Lawall
Subject: drivers/staging/wfx/hif_tx.c:53:2-8: preceding
On Tue, 7 Jul 2020, Joe Perches wrote:
> On Tue, 2020-07-07 at 14:06 -0600, Shuah Khan wrote:
> > On 7/7/20 1:52 PM, Gustavo A. R. Silva wrote:
> > > Replace the existing /* fall through */ comments and its variants with
> > > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessar
On Mon, 15 Jun 2020, Denis Efremov wrote:
> Check for memset()/memzero_explicit() followed by kfree()/vfree()/kvfree().
>
> Signed-off-by: Denis Efremov
> ---
> Changes in v2:
> - memset_explicit() added
> - kvfree_sensitive() added
> - forall added to r1
> - ... between memset and kfree a
Hello,
Please lines 5025 and 5038.
julia
-- Forwarded message --
Date: Tue, 7 Jul 2020 04:54:19 +0800
From: kernel test robot
To: kbu...@lists.01.org
Cc: l...@intel.com, Julia Lawall
Subject: drivers/scsi/mpt3sas/mpt3sas_base.c:5025:16-34: WARNING:
dma_alloc_coherent use
On Thu, 2 Jul 2020, Matthew Wilcox wrote:
> On Wed, Jul 01, 2020 at 07:52:58AM -0700, Randy Dunlap wrote:
> > On 7/1/20 6:32 AM, Markus Elfring wrote:
> > >>> How do you think about to use the following command variant
> > >>> for the adjustment of the software documentation?
> > >>>
> > >>> +
On Wed, 1 Jul 2020, Randy Dunlap wrote:
> From: Randy Dunlap
>
> Fix various typos etc. in dev-tools/coccinelle.rst:
>
> - punctuation, grammar, wording
Acked-by: Julia Lawall
Thanks!
julia
>
> Signed-off-by: Randy Dunlap
> Cc: Julia Lawall
> Cc: Gilles
On Mon, 29 Jun 2020, Randy Dunlap wrote:
> From: Randy Dunlap
>
> Fix various typos etc. in dev-tools/coccinelle.rst:
>
> - punctuation, grammar, wording
> - add "path/to/file.c" when using Coccinelle to check a single file
>
> Signed-off-by: Randy Dunlap
> As Coccinelle features get added some more advanced SmPL patches
> may require newer versions of Coccinelle. If an SmPL patch requires
> -at least a version of Coccinelle, this can be specified as follows,
> +at minimum version of Coccinelle, this can be specified as follows,
at -> a
thanks,
On Wed, 24 Jun 2020, j...@perches.com wrote:
> https://lore.kernel.org/patchwork/patch/649705/
>
> Any particular reason this wasn't applied?
>
> I ask because I added something similar recently to checkpatch.
It probably slipped through the cracks at the time the Coccinelle
scripts maintainer
On Tue, 23 Jun 2020, Denis Efremov wrote:
> Detect an opencoded expression that is used before or after
> array_size()/array3_size()/struct_size() to compute the same size.
>
> Signed-off-by: Denis Efremov
Applied, thanks.
julia
> ---
> Changes in v2:
> - python rules moved next to SmPL pa
On Wed, 24 Jun 2020, Rodolfo C Villordo wrote:
> On Wed, Jun 24, 2020 at 12:05:49PM +0200, Julia Lawall wrote:
> >
> >
> > On Wed, 24 Jun 2020, Rodolfo C. Villordo wrote:
> >
> > > Replace function and variables name from CamelCase style to snake_case
On Wed, 24 Jun 2020, Rodolfo C. Villordo wrote:
> Replace function and variables name from CamelCase style to snake_case style.
> Remove Hungarian notation.
>
> Signed-off-by: Rodolfo C. Villordo
> ---
> drivers/staging/vt6655/rxtx.c | 80 +--
> 1 file changed,
Fix the parameter names in the comment to correspond to those in the
function header.
Drop comments about return values when there is no return value.
Signed-off-by: Julia Lawall
---
v2: Fixed some spacing and punctuation issues noted by Joe Perches and Dan
Carpenter, and rechecked all the
It looks like the put_device (line 891) should be one line earlier.
julia
-- Forwarded message --
Date: Tue, 23 Jun 2020 15:26:47 +0800
From: kernel test robot
To: kbu...@lists.01.org
Cc: l...@intel.com, Julia Lawall
Subject: Re: [PATCH 16/22] gpiolib: cdev: add V2 uAPI
On Tue, 23 Jun 2020, Dan Carpenter wrote:
> On Tue, Jun 23, 2020 at 09:59:57AM +0200, Julia Lawall wrote:
> > > > diff --git a/drivers/crypto/bcm/spu.c b/drivers/crypto/bcm/spu.c
> > > []
> > > > @@ -519,7 +519,7 @@ u32 spum_assoc_resp_len(enum
On Mon, 22 Jun 2020, Joe Perches wrote:
> On Mon, 2020-06-22 at 21:37 +0200, Julia Lawall wrote:
> > Fix the parameter names in the comment to correspond to those in the
> > function header.
> >
> > Drop comments about return values when there is no return value.
I don't agree with any of these comments.
julia
On Tue, 23 Jun 2020, Markus Elfring wrote:
> > Changes in v2:
> …
> > - assignment operator used
>
> I prefer the distinction for the application of corresponding metavariables.
>
>
> > Changes in v3:
> …
> > - \(&E1\|&E2\) changed to &\(E1\|E2\)
Fix the parameter names in the comment to correspond to those in the
function header.
Drop comments about return values when there is no return value.
Signed-off-by: Julia Lawall
---
arch/arm/mach-omap2/omap-secure.c| 2 +-
arch/arm/mach-prima2/rtciobrg.c | 2
On Mon, 22 Jun 2020, Denis Efremov wrote:
> What do you think about removing duplicates warning from the rule?
>
> I mean this kind of warnings: "WARNING: same array_size (line {p1[0].line})"
>
> As for now, I think it's better to not disturb developers with this kind
> of things.
I agree. I
> I suggest to take another look at information from the section
> “2.4.3. Formatted string literals”.
> https://docs.python.org/3/reference/lexical_analysis.html#f-strings
>
> This software documentation provides the information “New in version 3.6”.
> Will such a detail trigger any more software
On Mon, 22 Jun 2020, Matthias Maennich wrote:
> On Thu, Jun 04, 2020 at 02:39:18PM -0600, Shuah Khan wrote:
> > On 6/4/20 1:31 PM, Julia Lawall wrote:
> > >
> > >
> > > On Thu, 4 Jun 2020, Matthias Maennich wrote:
> > >
> > > >
> +@script:python depends on report@
> +p1 << as_next.p1;
> +p2 << as_next.p2;
> +@@
> +
> +coccilib.report.print_report(p1[0],
> +f"WARNING: array_size is used down the code (line {p2[0].line}) to compute
> the same size")
I get python failures for all of these messages. I know nothing about
py
> +@as_next@
> +expression subE1 <= as.E1;
> +expression subE2 <= as.E2;
> +expression as.E1, as.E2, E3;
> +assignment operator aop;
> +position p1, p2;
> +@@
> +
> +* E1 * E2@p1
> + ... when != \(E1\|E2\|subE1\|subE2\) aop E3
> + when != &\(E1\|E2\|subE1\|subE2\)
You don't need E1 and E2 in
On Sat, 20 Jun 2020, Markus Elfring wrote:
> > The function kobject_init_and_add alloc memory like:
> > kobject_init_and_add->kobject_add_varg->kobject_set_name_vargs
> > ->kvasprintf_const->kstrdup_const->kstrdup->kmalloc_track_caller
> > ->kmalloc_slab, in err branch this memory not free. If u
On Sat, 20 Jun 2020, Bernard wrote:
>
>
> From: Julia Lawall
> Date: 2020-06-20 17:37:19
> To: Markus Elfring
> Cc: Bernard Zhao
> ,opensource.ker...@vivo.com,amd-...@lists.freedesktop.org,dri-de...@lists.freedesktop.org,kernel-janit...@vger.kernel.org,linux-kernel
On Sat, 20 Jun 2020, Markus Elfring wrote:
> > The function kobject_init_and_add alloc memory like:
> > kobject_init_and_add->kobject_add_varg->kobject_set_name_vargs
> > ->kvasprintf_const->kstrdup_const->kstrdup->kmalloc_track_caller
> > ->kmalloc_slab, in err branch this memory not free. If u
On Fri, 19 Jun 2020, Denis Efremov wrote:
> There is a typo in rule r2. Position p1 should be attached to kzalloc()
> call.
Clearly. Thanks. Applied.
julia
>
> Fixes: 29a36d4dec6c ("scripts/coccinelle: improve the coverage of some
> semantic patches")
> Signed-off-by: Denis Efremov
> --
On Thu, 18 Jun 2020, Kees Cook wrote:
> On Thu, Jun 18, 2020 at 09:56:18PM +0200, Julia Lawall wrote:
> > @@
> > identifier i,fld;
> > expression e;
> > @@
> >
> > \(\(i\|e.fld\|e->fld\) \& E\)
> >
> > The e will match all of the var
On Thu, 18 Jun 2020, Kees Cook wrote:
> On Wed, Jun 17, 2020 at 08:54:03PM +0200, Julia Lawall wrote:
> >
> >
> > On Wed, 17 Jun 2020, Kees Cook wrote:
> >
> > > On Mon, Jun 15, 2020 at 01:20:45PM +0300, Denis Efremov wrote:
>
mutex_unlock(&server->srv_mutex);
> /* Update # of requests on wire to server */
> add_credits(server, &credits, 0);
> return rc;
>
>
> From: J
...@lists.01.org
Cc: l...@intel.com, Julia Lawall
Subject: fs/cifs/transport.c:1284:2-8: preceding lock on line 1277
CC: kbuild-...@lists.01.org
CC: linux-kernel@vger.kernel.org
TO: Ronnie Sahlberg
CC: Steve French
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
On Wed, 17 Jun 2020, Denis Efremov wrote:
>
>
> On 6/17/20 11:30 PM, Julia Lawall wrote:
> >
> >
> > On Mon, 15 Jun 2020, Denis Efremov wrote:
> >
> >> Detect an opencoded expression that is used before or after
> >> array_size()/a
On Wed, 17 Jun 2020, Denis Efremov wrote:
>
>
> On 6/17/20 11:27 PM, Julia Lawall wrote:
> >
> >
> > On Mon, 15 Jun 2020, Denis Efremov wrote:
> >
> >> According to the documentation[1] show() methods of device attributes
> >> should return t
On Mon, 15 Jun 2020, Denis Efremov wrote:
> Check for memset()/memzero_explicit() followed by kfree()/vfree()/kvfree().
>
> Signed-off-by: Denis Efremov
> ---
> Changes in v2:
> - memset_explicit() added
> - kvfree_sensitive() added
> - forall added to r1
> - ... between memset and kfree a
On Mon, 15 Jun 2020, Denis Efremov wrote:
> Detect an opencoded expression that is used before or after
> array_size()/array3_size()/struct_size() to compute the same size.
This would benefit from the assignemnt operator metavariables as well.
Also, it could be better to put the python rules
On Mon, 15 Jun 2020, Denis Efremov wrote:
> According to the documentation[1] show() methods of device attributes
> should return the number of bytes printed into the buffer. This is
> the return value of scnprintf(). show() must not use snprintf()
> when formatting the value to be returned to
On Wed, 17 Jun 2020, Julia Lawall wrote:
>
>
> On Wed, 17 Jun 2020, Denis Efremov wrote:
>
> >
> > >
> > > Awesome! I'll take a look into this. :)
> > >
> > Here is another script for your #83 ticket.
> > Currently, it issues
On Wed, 17 Jun 2020, Denis Efremov wrote:
>
> >
> > Awesome! I'll take a look into this. :)
> >
> Here is another script for your #83 ticket.
> Currently, it issues 598 warnings.
>
> // SPDX-License-Identifier: GPL-2.0-only
> ///
> /// Check for missing overflow checks in allocation functions.
On Wed, 17 Jun 2020, Kees Cook wrote:
> On Mon, Jun 15, 2020 at 01:20:45PM +0300, Denis Efremov wrote:
> > +@as@
> > +expression E1, E2;
> > +@@
> > +
> > +array_size(E1, E2)
>
> BTW, is there a way yet in Coccinelle to match a fully qualified (?)
> identifier? For example, if I have two lines
On Mon, 15 Jun 2020, Markus Elfring wrote:
> > +// Confidence: High
>
> Would you like to add any suggestion for a possible patch message?
>
>
> …
> > +virtual report
> > +virtual org
> > +virtual context
> > +virtual patch
>
> +virtual report, org, context, patch
>
> Is such a SmPL code variant
test robot
Signed-off-by: Julia Lawall
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: 842221d073a88c9cd1aa01777c4b69020c28e7a4
commit: dc996261c060f06e1f20f580e203b81a4ddfe301 [16130/16374] ipc: convert
ipcs_idr to XArray
:: branch date: 17
On Sun, 14 Jun 2020, Randy Dunlap wrote:
> On 6/14/20 12:39 AM, Julia Lawall wrote:
> >
> >
> > On Sat, 13 Jun 2020, Randy Dunlap wrote:
> >
> >> Hi,
> >>
> >> OK, I've not used Coccinelle and now I am trying to use it.
> >>
On Sun, 14 Jun 2020, Denis Efremov wrote:
>
>
> On 6/5/20 11:51 PM, Julia Lawall wrote:
> > Also, there is no need to exceed 80 characters here. You can put a
> > newline in the middle of a \( ... \)
>
> It's required. Looks like it's impossible to break
On Sat, 13 Jun 2020, Randy Dunlap wrote:
> Hi,
>
> OK, I've not used Coccinelle and now I am trying to use it.
> It seems that I am having a few issues.
> The primary one is when I run spatch (via 'make coccicheck' in
> the kernel source tree), it tells me:
>
> Python error: No module named coc
From: kernel test robot
PTR_ERR should normally access the value just tested by IS_ERR
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
Fixes: 5b8516f3bedb ("crypto: sa2ul: Add crypto driver")
CC: Keerthy
Signed-off-by: kernel test robot
Signed-off-by: Julia Lawall
---
t
On Mon, 8 Jun 2020, Denis Efremov wrote:
> Check that the rule matches vmemdup_user implementation.
> memdup_user is out of scope because we are not matching
> kmalloc_track_caller() function.
Is this a bit over-enginered? More precisely, even if it is nice to check
that the API definition ha
Hello,
Does the lock taken on line 38 need to be released on line 53?
julia
-- Forwarded message --
Date: Tue, 9 Jun 2020 16:19:41 +0800
From: kernel test robot
To: kbu...@lists.01.org
Cc: l...@intel.com, Julia Lawall
Subject: drivers/staging/wfx/hif_tx.c:53:2-8: preceding
On Mon, 8 Jun 2020, Markus Elfring wrote:
> …
> +++ b/scripts/coccinelle/api/memdup_user.cocci
> @@ -39,6 +39,28 @@ …
> …
> > +@depends on patch@
> > +expression from,to,size;
> > +identifier l1,l2;
> > +@@
> > +
> > +- to = \(kvmalloc\|kvzalloc\)(size,\(GFP_KERNEL\|GFP_USER\));
> > ++ to = vm
On Mon, 8 Jun 2020, Dan Carpenter wrote:
> On Sun, May 31, 2020 at 03:11:27PM -0700, Joe Perches wrote:
> > (adding Dan Carpenter)
> >
> > On Sun, 2020-05-31 at 23:00 +0200, Christophe JAILLET wrote:
> > > 'swsusp_header_init()' is only called via 'core_initcall'.
> > > It can be marked as __ini
On Mon, 8 Jun 2020, Al Viro wrote:
> On Sun, Jun 07, 2020 at 10:41:56PM +, Rodolfo C. Villordo wrote:
> > Multiple line over 80 characters fixes by splitting in multiple lines.
> > Warning found by checkpatch.pl
>
> I doubt that checkpatch.pl can catch the real problems there:
>
> * Hungari
On Sat, 6 Jun 2020, Denis Efremov wrote:
>
>
> On 6/6/20 11:24 AM, Julia Lawall wrote:
> >
> >
> > On Sat, 30 May 2020, Denis Efremov wrote:
> >
> >> Match GFP_USER allocations with memdup_user.cocci rule.
> >> Commit 6c2c97a24f09 ("memdu
On Sat, 6 Jun 2020, Markus Elfring wrote:
> > +@choice@
> > +expression E, E1;
> > +position kok, vok;
> > +@@
> > +
> > +(
> > + if (...) {
> > +...
> > +E = \(kmalloc@kok\|…\)(...)
>
> Further implementation details from this SmPL script caught my software
> development attention.
>
>
On Sat, 6 Jun 2020, Markus Elfring wrote:
> >>> +E =
> >>> \(kmalloc@kok\|kzalloc@kok\|krealloc@kok\|kcalloc@kok\|kmalloc_node@kok\|kzalloc_node@kok\|kmalloc_array@kok\|kmalloc_array_node@kok\|kcalloc_node@kok\)(...)
> >>
> >> I would prefer an other coding style here.
> >>
> >> * Items fo
On Sat, 30 May 2020, Denis Efremov wrote:
> Add vmemdup_user() transformations to the memdup_user.cocci rule.
> Commit 50fd2f298bef ("new primitive: vmemdup_user()") introduced
> vmemdup_user(). The function uses kvmalloc with GPF_USER flag.
>
> Signed-off-by: Denis Efremov
> ---
> scripts/co
On Sat, 30 May 2020, Denis Efremov wrote:
> Match GFP_USER allocations with memdup_user.cocci rule.
> Commit 6c2c97a24f09 ("memdup_user(): switch to GFP_USER") switched
> memdup_user() from GFP_KERNEL to GFP_USER. In most cases it is still
> a good idea to use memdup_user() for GFP_KERNEL alloc
On Fri, 5 Jun 2020, Denis Efremov wrote:
> It looks like a good idea to add type cast, like:
>
> +// Ignore kzfree definition
> +// Ignore kasan test
> +@r depends on !patch && !(file in "lib/test_kasan.c") && !(file in
> "mm/slab_common.c") forall@
> +expression *E;
> +position p;
> +type T;
> > +E =
> > \(kmalloc@kok\|kzalloc@kok\|krealloc@kok\|kcalloc@kok\|kmalloc_node@kok\|kzalloc_node@kok\|kmalloc_array@kok\|kmalloc_array_node@kok\|kcalloc_node@kok\)(...)
>
> I would prefer an other coding style here.
>
> * Items for such SmPL disjunctions can be specified also on multiple lin
On Sat, 6 Jun 2020, Denis Efremov wrote:
> On 6/5/20 11:51 PM, Julia Lawall wrote:
> > Is there a strong reason for putting the choice rule first? It may make
> > things somewhat slower than necessary, if it matches in many places,
> > because the opportunity rule will h
On Fri, 5 Jun 2020, Denis Efremov wrote:
> Check that alloc and free types of functions match each other.
Is there a strong reason for putting the choice rule first? It may make
things somewhat slower than necessary, if it matches in many places,
because the opportunity rule will have to dete
On Fri, 5 Jun 2020, Heinrich Schuchardt wrote:
> Underline lengths should match the lengths of headings to avoid build
> warnings with Sphinx.
>
> Signed-off-by: Heinrich Schuchardt
Acked-by: Julia Lawall
Thanks for your help.
> ---
> Documentation/dev-tools/
On Thu, 4 Jun 2020, Denis Efremov wrote:
> Check for memset()/memset_explicit() with 0 followed by
> kfree()/vfree()/kvfree().
>
> Signed-off-by: Denis Efremov
> ---
> Changes in v2:
> - memset_explicit() added
> - kvfree_sensitive() added
> - forall added to r1
> - ... between memset and kfre
:python
> rule appears unrelated and odd, but this is the shortest I could come up
> with.
>
> Adjust scripts/nsdeps accordingly to set the nsdeps rule when run trough
> `make nsdeps`.
>
> Suggested-by: Julia Lawall
> Fixes: c7c4e29fb5a4 ("scripts: add_namespace: Fix
> After all it seems reasonable to me to add forall and memset_explicit rather
> than handle all these false positives. Something like this for v2?
>
> @r depends on !patch && !(file in "lib/test_kasan.c") && !(file in
> "mm/slab_common.c") forall@
> expression *E;
> position p;
> @@
>
> * \(memse
On Thu, 4 Jun 2020, Joe Perches wrote:
> On Thu, 2020-06-04 at 15:30 +0300, Dan Carpenter wrote:
> > On Thu, Jun 04, 2020 at 01:42:12PM +0200, Julia Lawall wrote:
> > > OK, I recall a discussion with Dan where he suggested that some things
> > > that were not ac
On Thu, 4 Jun 2020, Markus Elfring wrote:
> > Check for memset() with 0 followed by kfree().
>
> I suggest to simplify the SmPL code a bit like the following.
>
>
> > +virtual context
> > +virtual org
> > +virtual report
> > +virtual patch
>
> +virtual context, org, report, patch
This is pointl
On Thu, 4 Jun 2020, Denis Efremov wrote:
>
>
> On 6/4/20 5:15 PM, Julia Lawall wrote:
> > Did you try ... here but find that some subexpressions of E could be
> > modified in between?
>
> Yes, I tried to use "... when != E = E1 when != &E" and resul
On Thu, 4 Jun 2020, Denis Efremov wrote:
> Check for memset() with 0 followed by kfree().
>
> Signed-off-by: Denis Efremov
> ---
> Patches:
> 1. kzfree in drivers/w1 https://lkml.org/lkml/2020/6/4/438
> 2. kzfree in drivers/iommu/ https://lkml.org/lkml/2020/6/4/421
> 3. kzfree in drivers/scsi/
On Thu, 4 Jun 2020, Joe Perches wrote:
> On Thu, 2020-06-04 at 12:33 +0200, Julia Lawall wrote:
> >
> > On Thu, 4 Jun 2020, Joe Perches wrote:
> >
> > > On Thu, 2020-06-04 at 11:52 +0200, Julia Lawall wrote:
> > > > Should Fixes also be used
On Thu, 4 Jun 2020, Joe Perches wrote:
> On Thu, 2020-06-04 at 11:52 +0200, Julia Lawall wrote:
> > Should Fixes also be used when the change will make it hard to port other
> > fixes over it?
>
> If it's a logic defect or regression that's being fixed,
On Thu, 4 Jun 2020, Joe Perches wrote:
> On Thu, 2020-06-04 at 11:31 +0300, Dan Carpenter wrote:
> > On Thu, Jun 04, 2020 at 12:08:49AM +0200, Linus Walleij wrote:
> []
> > > Fixes means it fixes something that was wrong in that commit.
> > > That's all. Whether syntactic or semantic or regress
On Sat, 30 May 2020, Denis Efremov wrote:
> Match GFP_USER allocations with memdup_user.cocci rule.
> Commit 6c2c97a24f09 ("memdup_user(): switch to GFP_USER") switched
> memdup_user() from GFP_KERNEL to GFP_USER. In most cases it is still
> a good idea to use memdup_user() for GFP_KERNEL alloc
Hello,
This provides a patch, but it doesn't look like the right one. It looks
like the if test should be testing opp_table,
julia
On Fri, 22 May 2020, kbuild test robot wrote:
> From: kbuild test robot
>
> drivers/devfreq/governor_passive.c:336:7-13: inconsistent IS_ERR and PTR_ERR
> on lin
On Fri, 8 May 2020, Jeremy Kerr wrote:
> Hi Julia,
>
> > Other uses of &gang->aff_list_head, eg in spufs_assert_affinity, indicate
> > that the list elements have type spu_context, not spu as used here. Change
> > the type of tmp accordingly.
>
> Looks good to me; we could even use ctx there,
("[CELL] cell: add placement computation for scheduling of
affinity contexts")
Signed-off-by: Julia Lawall
---
arch/powerpc/platforms/cell/spufs/sched.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/powerpc/platforms/cell/spufs/sched.c
b/arch/powerpc/pla
On Fri, 8 May 2020, Peter Zijlstra wrote:
> On Thu, May 07, 2020 at 07:06:25PM +0800, Jason Yan wrote:
> > Fix the following coccicheck warning:
> >
> > kernel/sched/fair.c:9375:9-10: WARNING: return of 0/1 in function
> > 'voluntary_active_balance' with return type bool
>
> That's not a warnin
On Thu, 7 May 2020, Steven Rostedt wrote:
> On Thu, 7 May 2020 16:50:53 -0400
> Steven Rostedt wrote:
>
> > On Thu, 7 May 2020 21:30:08 +0200
> > Julia Lawall wrote:
> >
> > > Elsewhere in the file, the function trace_kprobe_has_same_kprobe uses
> &
ned-off-by: Julia Lawall
---
kernel/trace/trace_probe.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
index ab8b6436d53f..b8a928e925c7 100644
--- a/kernel/trace/trace_probe.c
+++ b/kernel/trace/trace_probe.c
@@ -1006
u/virtio: Add probe request")
Signed-off-by: Julia Lawall
---
drivers/iommu/virtio-iommu.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/virtio-iommu.c b/drivers/iommu/virtio-iommu.c
index d5cac4f46ca5..4e1d11af23c8 100644
--- a/drivers/iommu/virtio-iom
Hello,
Normally, the argument of kfree should not start with &.
julia
-- Forwarded message --
Date: Fri, 1 May 2020 06:07:26 +0800
From: kbuild test robot
To: kbu...@lists.01.org
Cc: l...@intel.com, Julia Lawall
Subject: Re: [PATCH 1/4] counter: Internalize sysfs inter
as the second argument.
Fixes: cb646e2b02b27 ("ptp: Added a clock driver for the National Semiconductor
PHYTER.")
Signed-off-by: Julia Lawall
---
Not tested.
drivers/net/phy/dp83640.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/dp83640.c b/dr
hile loop is not a isochronous pipe,
> iso_buffer still holds the previously deallocated buffer address and
> kfree tries to free wrong buffer address.
>
> Fixes: ea44d190764b ("usbip: Implement SG support to vhci-hcd and stub
> driver")
> Reported-by: kbuild test robot
&
hile loop is not a isochronous pipe,
> iso_buffer still holds the previously deallocated buffer address and
> kfree tries to free wrong buffer address.
>
> Fixes: ea44d190764b (“usbip: Implement SG support to vhci-hcd and stub
> driver”)
> Reported-by: kbuild test robot
> Report
On Mon, 21 Oct 2019, Suwan Kim wrote:
> On Sat, Oct 19, 2019 at 07:49:29PM +0200, Julia Lawall wrote:
> > Is it guaranteed that if usb_pipetype(urb->pipe) == PIPE_ISOCHRONOUS (line
> > 123) is true on one iteration, then it will be true on all iterations? If
> > not,
> btw2:
>
> I really dislike all the code inconsistencies and
> unnecessary code duplication with miscellaneous changes
> in the rtl staging drivers
>
> Horrid stuff.
I'm not sure what you mean by "miscellaneous changes". Do you mean that
all issues should be fixed for one file before moving
On Sun, 20 Oct 2019, Joe Perches wrote:
> On Sun, 2019-10-20 at 21:52 +0200, Julia Lawall wrote:
> > On Sun, 20 Oct 2019, Joe Perches wrote:
> []
> > > There's probably a generic cocci mechanism to check function
> > > prototypes and then remove uses of unne
On Sun, 20 Oct 2019, Joe Perches wrote:
> On Sun, 2019-10-20 at 22:17 +0300, Dan Carpenter wrote:
> > On Sat, Oct 19, 2019 at 01:02:31PM -0700, Joe Perches wrote:
> > > diff -u -p a/rtl8723bs/core/rtw_mlme_ext.c b/rtl8723bs/core/rtw_mlme_ext.c
> []
> > > @@ -1132,7 +1132,7 @@ unsigned int OnAut
On Sun, 20 Oct 2019, Joe Perches wrote:
> On Sun, 2019-10-20 at 22:17 +0300, Dan Carpenter wrote:
> > On Sat, Oct 19, 2019 at 01:02:31PM -0700, Joe Perches wrote:
> > > diff -u -p a/rtl8723bs/core/rtw_mlme_ext.c b/rtl8723bs/core/rtw_mlme_ext.c
> []
> > > @@ -1132,7 +1132,7 @@ unsigned int OnAut
On Sun, 20 Oct 2019, Dan Carpenter wrote:
> On Sat, Oct 19, 2019 at 01:02:31PM -0700, Joe Perches wrote:
> > diff -u -p a/rtl8723bs/core/rtw_mlme_ext.c b/rtl8723bs/core/rtw_mlme_ext.c
> > --- a/rtl8723bs/core/rtw_mlme_ext.c
> > +++ b/rtl8723bs/core/rtw_mlme_ext.c
> > @@ -1132,7 +1132,7 @@ unsig
Oct 2019 01:40:11 +0800
From: kbuild test robot
To: kbu...@lists.01.org
Cc: Julia Lawall
Subject: drivers/usb/usbip/vhci_tx.c:150:8-18: ERROR: reference preceded by free
on line 150
CC: kbuild-...@lists.01.org
CC: linux-kernel@vger.kernel.org
CC: "Greg Kroah-Hartman"
On Sat, 19 Oct 2019, Jules Irenge wrote:
>
>
> On Sat, 19 Oct 2019, Dan Carpenter wrote:
>
> > On Sat, Oct 19, 2019 at 03:07:15PM +0100, Jules Irenge wrote:
> > > diff --git a/drivers/staging/wfx/bh.c b/drivers/staging/wfx/bh.c
> > > index 3355183fc86c..573216b08042 100644
> > > --- a/drivers/s
t the review load for the maintainers is huge. As of now, more that 560
> patches have been sent, some of them obviously broken, as in:
>
> https://lore.kernel.org/lkml/9bbcce19c777583815c92ce3c2ff2...@www.loen.fr/
>
> Remove the script to reduce the spam.
OK.
Acked-by: Julia Lawall
&
> #ifndef VCHI_BULK_GRANULARITY
> # if __VCCOREVER__ >= 0x0400
> -# define VCHI_BULK_GRANULARITY 32 // Allows for the need to do cache
> cleans
> +#define VCHI_BULK_GRANULARITY 32 // Allows for the need of cache cleans
> # else
> # define VCHI_BULK_GRANULARITY 16
> #
On Tue, 15 Oct 2019, Wambui Karuga wrote:
> Remove unnecessary casts in pointer types passed to kfree.
>
> Signed-off-by: Wambui Karuga
Acked-by: Julia Lawall
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-
401 - 500 of 2888 matches
Mail list logo
