Re: [Outreachy kernel] [PATCH v2] drm/tegra: Replace dev_* with DRM_DEV_*

2017-09-24 Thread Julia Lawall
On Sun, 24 Sep 2017, Harsha Sharma wrote: > Replace all occurences of dev_info/err/dbg with DRM_DEV_INFO/ > ERROR/DEBUG as we have DRM_DEV_* variants of drm print macros > Done using following coccinelle semantic patch > > @r@ > @@ > > ( > -dev_info > +DRM_DEV_INFO > | > -dev_err >

Re: [Outreachy kernel] [PATCH] drm/tegra: Replace dev_* with DRM_DEV_*

2017-09-24 Thread Julia Lawall
On Sun, 24 Sep 2017, Harsha Sharma wrote: > Replace all occurences of dev_info/err/dbg with DRM_DEV_INFO/ > ERROR/DEBUG as we have DRM_DEV_* variants of drm print macros > Done using following coccinelle semantic patch Some calls after under comments. They could be dropped. Some calls appear

Re: [PATCH v2 01/31] coccinelle: Improve setup_timer.cocci matching

2017-09-23 Thread Julia Lawall
timer->field vs timer.field) > > Cc: Julia Lawall <julia.law...@lip6.fr> > Cc: Gilles Muller <gilles.mul...@lip6.fr> > Cc: Nicolas Palix <nicolas.pa...@imag.fr> > Cc: Michal Marek <mma...@suse.com> > Cc: co...@systeme.lip6.fr > Signed-off-by: Kees

Re: [media] spca500: Use common error handling code in spca500_synch310()

2017-09-22 Thread Julia Lawall
On Fri, 22 Sep 2017, SF Markus Elfring wrote: > >>return 0; > >> -error: > >> + > >> +report_failure: > >> + PERR("Set packet size: set interface error"); > >>return -EBUSY; > >> } > > > > Why change the label name? > > I find the suggested variant a bi better. > > > > They are both

Re: [PATCH] [media] spca500: Use common error handling code in spca500_synch310()

2017-09-22 Thread Julia Lawall
On Fri, 22 Sep 2017, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 22 Sep 2017 18:45:07 +0200 > > Adjust a jump target so that a bit of exception handling can be better > reused at the end of this function. > > This issue was detected by using the

Re: [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit

2017-09-22 Thread Julia Lawall
On Fri, 22 Sep 2017, Joe Perches wrote: > On Fri, 2017-09-22 at 12:06 +0200, Julia Lawall wrote: > > > > On Fri, 22 Sep 2017, Colin Ian King wrote: > > > > > On 22/09/17 11:03, Joe Perches wrote: > > > > On Fri, 2017-09-22 at 09:23 +0200, Julia Lawall

Re: [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit

2017-09-22 Thread Julia Lawall
On Fri, 22 Sep 2017, Colin Ian King wrote: > On 22/09/17 11:03, Joe Perches wrote: > > On Fri, 2017-09-22 at 09:23 +0200, Julia Lawall wrote: > >> > >> On Thu, 21 Sep 2017, Colin King wrote: > >> > >>> From: Colin Ian King <colin.k...@ca

Re: [Outreachy kernel] [PATCH v2] staging: vc04_services: Remove typedef struct

2017-09-22 Thread Julia Lawall
ruct > + T2 > { ... } > -T > ; > > @r3@ > type r1.T; > identifier c1.T2; > @@ > -T > +struct T2 > > Signed-off-by: Harsha Sharma <harshasharmai...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > Changes in v2: > -Co

Re: [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit

2017-09-22 Thread Julia Lawall
On Thu, 21 Sep 2017, Colin King wrote: > From: Colin Ian King > > Don't populate const array ac_to_fifo on the stack in an inlined > function, instead make it static. Makes the object code smaller > by over 800 bytes: > >text data bss dec hex

Re: [Outreachy kernel] [PATCH] staging: vc04_services: Remove typedef struct

2017-09-21 Thread Julia Lawall
On Fri, 22 Sep 2017, Harsha Sharma wrote: > Remove typedef from struct as linux-kernel coding style tends to > avoid using typedefs > > Done using following coccinelle semantic patch > > @r1@ > type T; > @@ > > typedef struct { ... } T; > > @script:python c1@ > T2; > T << r1.T; > @@ > if T[-2:]

Re: [Outreachy kernel] Re: [PATCH v2 1/2] include: linux: sysfs: Add __ATTR_NAMED macro

2017-09-21 Thread Julia Lawall
On Thu, 21 Sep 2017, Jonathan Cameron wrote: > On Mon, 18 Sep 2017 16:19:07 +0530 > Himanshi Jain wrote: > > > On Thu, Sep 14, 2017 at 2:20 AM, Jonathan Cameron > > wrote: > > > > > > > > > On 13 September 2017 12:23:31 GMT-07:00,

Re: [PATCH] powerpc: make irq_chip const, __initdata and __initconst

2017-09-20 Thread Julia Lawall
On Wed, 20 Sep 2017, Michael Ellerman wrote: > Bhumika Goyal writes: > > > Make ehv_pic_irq_chip, mpic_ipi_chip and mpic_tm_chip const as they are > > used only as a copy operation. This usage is during init, so make them > > __initconst too. > > Make mpic_ipi_chip

Re: [Outreachy kernel] [PATCH v2 2/2] Staging: dgnc: Remove unused fields in struct channel_t

2017-09-16 Thread Julia Lawall
On Sat, 16 Sep 2017, Srishti Sharma wrote: > Eliminate the fields that are not used and the comments > associated with them. > > Signed-off-by: Srishti Sharma <srishtis...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > Changes in v2: &

Re: [Outreachy kernel] [PATCH v2 1/2] Staging: dgnc: Remove unused fields in struct dgnc_board

2017-09-16 Thread Julia Lawall
On Sat, 16 Sep 2017, Srishti Sharma wrote: > Remove unused fields and comments associated with them in > the structure definition. > > Signed-off-by: Srishti Sharma <srishtis...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > Changes in v2: &

Re: [Outreachy kernel] [PATCH 0/2] Remove unused variables in structure definition

2017-09-16 Thread Julia Lawall
On Sat, 16 Sep 2017, Srishti Sharma wrote: > This patch series attempts to remove unused variables in structure > variables and the comments associated with them. Actually, I would say that a structure has fields, not variables. julia > > Srishti Sharma (2): > Staging: dgnc: Remove unused

Re: [Outreachy kernel] [PATCH] Staging: dgnc: Remove unused variables from structure definition

2017-09-16 Thread Julia Lawall
On Sat, 16 Sep 2017, Srishti Sharma wrote: > On Sat, Sep 16, 2017 at 5:20 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > > > > On Sat, 16 Sep 2017, Srishti Sharma wrote: > > > >> Some variables in the structure were unused and hence them and

Re: [Outreachy kernel] [PATCH] Staging: dgnc: Remove unused variables from structure definition

2017-09-16 Thread Julia Lawall
On Sat, 16 Sep 2017, Srishti Sharma wrote: > Some variables in the structure were unused and hence them and > the comments associated with them can be removed. How did you find these? The last two can easily be checked with grep, but that is ont the case for type. Actually there are two

Re: [Outreachy kernel] [PATCH] staging: lustre: lnet: Replace list_for_each with list_for_each_entry

2017-09-16 Thread Julia Lawall
pos is not initialized then there should be no other kinds of references either. The other possibility for initialization would be eg f(...,,...) You could be suspicious of in general. But anyway there is no in this code. julia > Signed-off-by: Haneen Mohammed <hamohammed...@gmail

Re: [Outreachy kernel] [PATCH] Staging: irda: Use !x instead of NULL comparison

2017-09-16 Thread Julia Lawall
kmalloc_array\|devm_ioremap\| > usb_alloc_urb\|alloc_netdev\|dev_alloc_skb\)(...)); > > ( > if(!E) >S > | > -if(E==NULL) > +if(!E) > S > ) > > Signed-off-by: Srishti Sharma <srishtis...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr>

Re: [Outreachy kernel] Re: [PATCH 2/2] Staging: irda: Remove parentheses on the right of assignment

2017-09-15 Thread Julia Lawall
On Fri, 15 Sep 2017, Joe Perches wrote: > On Sat, 2017-09-16 at 02:36 +0530, Srishti Sharma wrote: > > Parentheses are not needed on the right hand side of assignment > > statement in most cases. Done using the following semantic > > patch by coccinelle. > [] > > @@ > > identifier E,F,G,f; > >

Re: [Outreachy kernel] [PATCH v2] Staging: irda: Don't use assignment inside if statement

2017-09-15 Thread Julia Lawall
On Sat, 16 Sep 2017, Srishti Sharma wrote: > On Sat, Sep 16, 2017 at 1:30 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > > > > On Sat, 16 Sep 2017, Srishti Sharma wrote: > > > >> Write assignment statement outside the if statement. Do

Re: [Outreachy kernel] [PATCH v2] Staging: irda: Don't use assignment inside if statement

2017-09-15 Thread Julia Lawall
; S > > Signed-off-by: Srishti Sharma <srishtis...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > Changes in v2: > -Semicolon was missing in one of the statements of the > semantic patch > > drivers/staging/irda/drivers/irda-usb.c | 4 ++--

Re: [Outreachy kernel] [PATCH] Staging: irda: Don't use assignment inside if statement

2017-09-15 Thread Julia Lawall
On Sat, 16 Sep 2017, Srishti Sharma wrote: > Write assignment statement outside the if statement. Done using > the following semantic patch by coccinelle. > > @@ > identifier E; > expression F; > statement S; > @@ > > -if((E = F)) > +E = F The line above would need to end in a ; This ends up

Re: [Outreachy kernel] [PATCH] staging: rtlwifi: delete double assignment

2017-09-15 Thread Julia Lawall
On Fri, 15 Sep 2017, Harsha Sharma wrote: > Remove two adjacent assignments to the same location. > In practice, many such occurences are intentional but > this case don't seem to fall into that category. > Done using following coccinelle semantic patch > > @@ > expression e1,e2,e3; > @@ > > (

Re: [Outreachy kernel] [PATCH] gpu: drm: rockchip: Replace dev_* with DRM_DEV_*

2017-09-15 Thread Julia Lawall
@@ > > ( > -dev_info > +DRM_DEV_INFO > | > -dev_err > +DRM_DEV_ERROR > | > -dev_dbg > +DRM_DEV_DEBUG > ) > > Signed-off-by: Haneen Mohammed <hamohammed...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > drivers/gpu/drm/r

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove unused variable ret

2017-09-14 Thread Julia Lawall
On Thu, 14 Sep 2017, Harsha Sharma wrote: > Remove unused variable ret as it is not used anywhere. > Remove multiple blank lines. > Done using following coccinelle semantic patch > > @@ > type T; > identifier i; > constant C; > @@ > > ( > extern T i; > | > - T i; > <+... when != i > - i = C;

Re: [Outreachy kernel] [PATCH v2] Staging: ccree: Use kcalloc instead of kzalloc

2017-09-14 Thread Julia Lawall
tis...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > Changes in v2: > - eliminate parentheses around the first argument > > drivers/staging/ccree/ssi_sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dri

Re: [Outreachy kernel] [PATCH] Staging: ccree: Use kcalloc instead of kzalloc

2017-09-14 Thread Julia Lawall
On Thu, 14 Sep 2017, Srishti Sharma wrote: > Use kcalloc instead of kzalloc to check for overflow before > multiplication. Done using the following semantic patch by > coccinelle. > > http://coccinelle.lip6.fr/rules/kzalloc.cocci > > Signed-off-by: Srishti Sharma > --- >

Re: [Outreachy kernel] [PATCH] Staging: lustre: obdclass: Use kcalloc instead of kzalloc

2017-09-14 Thread Julia Lawall
tis...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > drivers/staging/lustre/lustre/obdclass/cl_object.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/obdclass/cl_object.c > b/drivers/staging

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Merge assignment with return

2017-09-14 Thread Julia Lawall
On Thu, 14 Sep 2017, Harsha Sharma wrote: > Merge assignment with return statement to directly return the value. > Done using following coccinelle semantic patch > > @@ > local idexpression ret; > expression e; > @@ > > -ret = > +return > e; >

Re: [PATCH 1/1] Coccinelle: array_size: report even if include is missing

2017-09-14 Thread Julia Lawall
On Wed, 13 Sep 2017, Jérémy Lefaure wrote: > Rule r does not depend on rule i (which is the include of > linux/kernel.h) so the output should not depend on i in > org and report mode. > > Signed-off-by: Jérémy Lefaure <jeremy.lefa...@lse.epita.fr> Acked-by: Julia Lawall

Re: [Outreachy kernel] [PATCH] staging: irda: Remove typedef struct

2017-09-14 Thread Julia Lawall
edef > struct > + T2 > { ... } > -T > ; > > @r3@ > type r1.T; > identifier c1.T2; > @@ > -T > +struct T2 > > Signed-off-by: Haneen Mohammed <hamohammed...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > drivers/staging/ird

Re: [Outreachy kernel] Re: [PATCH v2 1/2] include: linux: sysfs: Add __ATTR_NAMED macro

2017-09-13 Thread Julia Lawall
On Wed, 13 Sep 2017, Joe Perches wrote: > On Thu, 2017-09-14 at 00:43 +0300, Dan Carpenter wrote: > > He was exagerating a bit to call it a "static checker" warning... > > Not really. > > False positives and false negatives exist in just about > every static > checker. > > > It's just

Re: [Outreachy kernel] [PATCH v2 0/2] Rewrite the IIO_DEVICE_ATTR_NAMED API to pass name as string.

2017-09-13 Thread Julia Lawall
On Wed, 13 Sep 2017, Himanshi Jain wrote: > This patchset is to rewrite the IIO_DEVICE_ATTR_NAMED API to pass name > as string. You need to indicate what has changed in the v2, either here or in the individual patches. julia > > Himanshi Jain (2): > include: linux: sysfs: Add __ATTR_NAMED

Re: [Outreachy kernel] [PATCH] staging: wlan-ng: Replace pr_debug with netdev_dbg

2017-09-12 Thread Julia Lawall
. }; > > @@ > identifier r.i, r.s, rr.fld; > position r.p; > @@ > ( > -pr_err@p > +netdev_err > ( > + i->fld, > ...) > | > -pr_info@p > +netdev_info > ( > + i->fld, > ...) > | > -pr_debug@p > +netdev_dbg > ( > +

Re: [Outreachy kernel] [PATCH] Fixed IIO_DEVICE_ATTR_NAMED API to take name as a string and added "" around names

2017-09-12 Thread Julia Lawall
On Tue, 12 Sep 2017, himanshi wrote: > Thanks for the review Daniel! I will change the imperative mood for the commit > message once the other changes are finalised too and as suggested by Julia, > would try to make the description specific than general. > > I tried to think of adding subsystem

Re: [Outreachy kernel] [PATCH] Staging: media: atomisp: Merge assignment with return

2017-09-12 Thread Julia Lawall
e; > -return ret; > > Signed-off-by: Srishti Sharma <srishtis...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff

Re: [Outreachy kernel] [PATCH] Staging: media: atomisp: Merge assignment with return

2017-09-12 Thread Julia Lawall
e; > -return ret; > > Signed-off-by: Srishti Sharma <srishtis...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > drivers/staging/media/atomisp/i2c/ov5693/ov5693.c | 11 ++- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff -

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove unnecessary spaces

2017-09-12 Thread Julia Lawall
; > Signed-off-by: Harsha Sharma <harshasharmai...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > drivers/staging/rtl8723bs/os_dep/mlme_linux.c | 30 > +-- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff

Re: [Outreachy kernel] [PATCH v2 07/10] staging: rtl8723bs: Remove unneccesary space

2017-09-12 Thread Julia Lawall
It'sa small detail, but perhaps you could fix the spelling of unnecessary (1 c and 2 s's). julia On Tue, 12 Sep 2017, Harsha Sharma wrote: > Remove space between function name and open parenthesis '(' > Remove space before ';', '++', ',' > > Signed-off-by: Harsha Sharma

Re: [Outreachy kernel] [PATCH] Fixed IIO_DEVICE_ATTR_NAMED API to take name as a string and added "" around names

2017-09-12 Thread Julia Lawall
On Tue, 12 Sep 2017, Daniel Baluta wrote: > Hi Himanshi, > > On Tue, Sep 12, 2017 at 1:43 AM, Himanshi Jain > wrote: > > Fixed IIO_DEVICE_ATTR_NAMED API to take name as a > > string instead of implicit conversion to string using > > preprocessors. Added double quotes

Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

2017-09-11 Thread Julia Lawall
On Mon, 11 Sep 2017, Srishti Sharma wrote: > On Mon, Sep 11, 2017 at 9:34 PM, Greg KH wrote: > > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: > >> The use of volatile for the variable monitor_lock is unnecessary. > >> > >> Signed-off-by: Srishti

Re: [Outreachy kernel] [PATCH] Staging: ccree: Don't use volatile for monitor_lock

2017-09-11 Thread Julia Lawall
On Mon, 11 Sep 2017, Srishti Sharma wrote: > The use of volatile for the variable monitor_lock is unnecessary. You need to give more evidence of why this is the case. How is the variable used? I guess this comes from checkpatch, but checkpatch has only a local view of things, and doesn't

Re: [Outreachy kernel] [PATCH] Staging: rtl8712: Remove multiple blank lines

2017-09-11 Thread Julia Lawall
On Mon, 11 Sep 2017, Srishti Sharma wrote: > Remove extra blank line. > > Signed-off-by: Srishti Sharma <srishtis...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > drivers/staging/rtl8712/rtl8712_event.h | 1 - > 1 file changed, 1 deleti

Re: [Outreachy kernel] [PATCH 06/10] staging: rtl8723bs: Add space after ','

2017-09-11 Thread Julia Lawall
On Sun, 10 Sep 2017, Harsha Sharma wrote: > Space required after ',' > > Signed-off-by: Harsha Sharma <harshasharmai...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++-- > 1 fi

Re: [Outreachy kernel] [PATCH 05/10] staging: rtl8723bs: Add space between concatenated strings

2017-09-11 Thread Julia Lawall
On Sun, 10 Sep 2017, Harsha Sharma wrote: > Use spaces between concatenated strings Perhaps all the entry/exit ones could be dropped, and the ohters could be rewritten to use more standard kernel debugging functionalities. julia > > Signed-off-by: Harsha Sharma >

Re: [Outreachy kernel] [PATCH 04/10] staging: rtl8723bs: Remove unnecessary spaces at the start of line

2017-09-10 Thread Julia Lawall
On Sun, 10 Sep 2017, Harsha Sharma wrote: > No spaces at the start of a line > > Signed-off-by: Harsha Sharma <harshasharmai...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 +- > 1 file chang

Re: [Outreachy kernel] [PATCH 03/10] staging: rtl8723bs: Add spaces around '?', '==', '||', '!='

2017-09-10 Thread Julia Lawall
On Sun, 10 Sep 2017, Harsha Sharma wrote: > Use spaces around most binary operators > > Signed-off-by: Harsha Sharma <harshasharmai...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++

Re: [Outreachy kernel] [PATCH 01/10] staging: rtl8723bs: Add spaces around '='

2017-09-10 Thread Julia Lawall
On Sun, 10 Sep 2017, Harsha Sharma wrote: > Use one space around (on each side of) '=' operator > > Signed-off-by: Harsha Sharma <harshasharmai...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > drivers/staging/rtl8723bs/os_dep/os_intfs.c | 20 +++

Re: [Outreachy kernel] [PATCH 02/10] staging: rtl8723bs: Add spaces around '+', '|', '*'

2017-09-10 Thread Julia Lawall
On Sun, 10 Sep 2017, Harsha Sharma wrote: > Use one space around most binary operators > > Signed-off-by: Harsha Sharma <harshasharmai...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Add spaces around '=', '|', '<<'

2017-09-09 Thread Julia Lawall
red places in the same file, the patches should be in a series. julia > > Regards, > Harsha Sharma > > > On Sat, Sep 9, 2017 at 11:56 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Sat, 9 Sep 2017, Harsha Sharma wrote: > > > Use one s

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Add spaces around '=', '|', '<<'

2017-09-09 Thread Julia Lawall
On Sat, 9 Sep 2017, Harsha Sharma wrote: > Use one space around most binary operators > > Signed-off-by: Harsha Sharma > --- > drivers/staging/rtl8723bs/os_dep/os_intfs.c | 26 +- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff

Re: [Outreachy kernel] [PATCH v4] Staging: ccree: Merge assignment with return

2017-09-09 Thread Julia Lawall
t; Signed-off-by: Srishti Sharma <srishtis...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > Changes in v4: > -Edit commit message so that it respects 80 character limit > -Remove unneeded blank lines > -Remove declarations of variables that are not used

Re: [Outreachy kernel] [PATCH] staging: sm750fb: Remove extra blank lines

2017-09-09 Thread Julia Lawall
On Sat, 9 Sep 2017, Harsha Sharma wrote: > This was reported by checkpatch.pl > > Signed-off-by: Harsha Sharma <harshasharmai...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > drivers/staging/sm750fb/sm750_cursor.c | 4 > 1 file changed,

Re: [Outreachy kernel] [PATCH] Staging: ccree: Merge assignment with return

2017-09-09 Thread Julia Lawall
On Sat, 9 Sep 2017, Srishti Sharma wrote: > Merge the assignment and return statements to return the value > directly. Done using coccinelle. Coccinelle is not always perfect about pretty printing, so you have to watch out for it. > > @@ > local idexpression ret; > expression e; > @@ > > -ret

Re: [Outreachy kernel] Re: [PATCH] staging: unisys: visorbus: Declared char * array as static const

2017-09-09 Thread Julia Lawall
On Sat, 9 Sep 2017, Greg KH wrote: > On Sat, Sep 09, 2017 at 12:30:42PM +0530, Harsha Sharma wrote: > > State explicitly that individual entries in array will not change. > > > > Signed-off-by: Harsha Sharma > > --- > >

Re: [Outreachy kernel] [PATCH v2] Staging: ccree: Merge assignment with return

2017-09-09 Thread Julia Lawall
On Sat, 9 Sep 2017, Srishti Sharma wrote: > On Sat, Sep 9, 2017 at 2:28 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > > > > On Sat, 9 Sep 2017, Srishti Sharma wrote: > > > >> Merge the assignment and return statements to return the

Re: [Outreachy kernel] [PATCH v3] Staging: ccree: Merge assignment with return

2017-09-09 Thread Julia Lawall
On Sat, 9 Sep 2017, Srishti Sharma wrote: > Merge the assignment and return statements to return the value > directly. Done using coccinelle. > > @@ > local idexpression ret; > expression e; > @@ > > -ret = > +return > e; > -return ret; > > Signed-off-by: Srishti Sharma

Re: [Outreachy kernel] [PATCH v2] Staging: ccree: Merge assignment with return

2017-09-08 Thread Julia Lawall
On Sat, 9 Sep 2017, Srishti Sharma wrote: > Merge the assignment and return statements to return the value > directly. Done using coccinelle. > > @@ > local idexpression ret; > expression e; > @@ > > -ret = > +return > e; > -return ret; > > Signed-off-by: Srishti Sharma

Re: [Outreachy kernel] [PATCH] Staging: ccree: Merge assignment with return

2017-09-08 Thread Julia Lawall
On Sat, 9 Sep 2017, Srishti Sharma wrote: > On Sat, Sep 9, 2017 at 1:42 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > > > > On Sat, 9 Sep 2017, Srishti Sharma wrote: > > > >> Return the return value of a function directly, instead of first saving

Re: [Outreachy kernel] [PATCH] Staging: ccree: Merge assignment with return

2017-09-08 Thread Julia Lawall
On Sat, 9 Sep 2017, Srishti Sharma wrote: > Return the return value of a function directly, instead of first saving it in > a variable and then returning it. This change was made using the following Your commit message should respect the 80 character limit. The above is one very long line. >

Re: [Outreachy kernel] [PATCH v3] staging: typec: tcpm: Rewrite comparison to NULL pointer

2017-09-08 Thread Julia Lawall
On Fri, 8 Sep 2017, Harsha Sharma wrote: > Make code more concise and readable > > Signed-off-by: Harsha Sharma <harshasharmai...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > Change in v3: > -Change in subject and log message > Ch

Re: [Outreachy kernel] [PATCH v2] staging: typec: tcpm: Comparison to NULL pointer

2017-09-08 Thread Julia Lawall
Maybe "Rewrite comparison to NULL pointer" in the subject to include what was done, not just code was touched. On Fri, 8 Sep 2017, Harsha Sharma wrote: > Makes code more concise and readable Makes -> Make. Commit logs should be written in the imperative, like you are telling someone what to

Re: [Outreachy kernel] [PATCH] staging: typec: tcpm: Comparison to NULL changed as "!port->partner_altmode[pmdata->altmodes]"

2017-09-08 Thread Julia Lawall
On Fri, 8 Sep 2017, Harsha Sharma wrote: > Fixes coding style issue Good job on getting the From issue sorted out. The subject line change description is a bit verbose. One doesn't want to see the whole code, but rather the concept of what has changed. If you were going to tell someone

Re: [Outreachy kernel] [PATCH] Staging: media: omap4iss: Use WARN_ON() instead of BUG_ON().

2017-09-08 Thread Julia Lawall
On Fri, 8 Sep 2017, Srishti Sharma wrote: > Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel. > > Signed-off-by: Srishti Sharma > --- > drivers/staging/media/omap4iss/iss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Outreachy kernel] Re: [PATCH] Staging: iio: adc: Added Space around binary op.

2017-09-08 Thread Julia Lawall
On Fri, 8 Sep 2017, Lars-Peter Clausen wrote: > On 09/08/2017 11:59 AM, Julia Lawall wrote: > > > > > > On Fri, 8 Sep 2017, Lars-Peter Clausen wrote: > > > >> On 09/08/2017 11:32 AM, Jonathan Cameron wrote: > >>> On Fri, 8 Sep 2017 07

Re: [Outreachy kernel] Re: [PATCH] Staging: iio: adc: Added Space around binary op.

2017-09-08 Thread Julia Lawall
On Fri, 8 Sep 2017, Lars-Peter Clausen wrote: > On 09/08/2017 11:32 AM, Jonathan Cameron wrote: > > On Fri, 8 Sep 2017 07:29:06 +0100 > > Jonathan Cameron wrote: > > > >> On 8 September 2017 05:47:52 BST, Himanshi Jain > >> wrote: > >>>

Re: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo errors

2017-09-08 Thread Julia Lawall
On Fri, 8 Sep 2017, Dan Carpenter wrote: > On Fri, Sep 08, 2017 at 11:45:20AM +0200, Julia Lawall wrote: > > > > > > On Fri, 8 Sep 2017, harsha wrote: > > > > > From: Harsha Sharma <harshasharmai...@gmail.com> > > > > > > Fixes chec

Re: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo errors

2017-09-08 Thread Julia Lawall
On Fri, 8 Sep 2017, harsha wrote: > From: Harsha Sharma > > Fixes checkpatch warning -- "occured" and "succesfully" are misspelled > > Signed-off-by: Harsha Sharma > --- > Changes in v4: > -Correct the format of the subject. >

Re: [Outreachy kernel] [PATCH] staging: rt8712: xmit_linux: Avoid multiple assignments in a single line

2017-09-08 Thread Julia Lawall
ds, > Harsha Sharma > > On Fri, Sep 8, 2017 at 2:16 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Fri, 8 Sep 2017, harsha wrote: > > > Fixed coding style issue > > > > Signed-off-by: Harsha Sharma <harshasharmai...

Re: [Outreachy kernel] [PATCH] staging: rt8712: xmit_linux: Avoid multiple assignments in a single line

2017-09-08 Thread Julia Lawall
On Fri, 8 Sep 2017, harsha wrote: > Fixed coding style issue > > Signed-off-by: Harsha Sharma > --- > drivers/staging/rtl8712/xmit_linux.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8712/xmit_linux.c >

Re: [Outreachy kernel] [PATCH] staging: pi433: pi433_if: Fixes minor typo errors

2017-09-08 Thread Julia Lawall
The subject line above is still not what is shown with git log --oneline for this file. Also, this patch fixes a previous submission so it should be v2. I suggest to read through the tutorial carefully again to get these small details. julia On Fri, 8 Sep 2017, harsha wrote: > Fixes

Re: [Outreachy kernel] [PATCH] Staging: iio: adc: Added Space around binary op.

2017-09-08 Thread Julia Lawall
On Fri, 8 Sep 2017, Himanshi Jain wrote: > Added space around(one on each side of) binary I think that just around would be clear enough. In the previous patches on this file, found with git log --oneline, a subject line of staging: iio: ad7192: seems to be more popular when the patch affects

Re: [Outreachy kernel] [PATCH] Staging:pi433:pi433_if.c:Fixes minor typo errors

2017-09-07 Thread Julia Lawall
On Fri, 8 Sep 2017, harsha wrote: > Fixes checkpatch warning -- "occured" and "succesfully" are misspelled Thanks for the patch. The change looks ok, but the subject line is not. Use git log --oneline on the affected file to see what others have done. In general, you cannot guess what the

Re: [Outreachy kernel] [PATCH v5] Staging: ccree: Remove unused variable.

2017-09-07 Thread Julia Lawall
On Thu, 7 Sep 2017, Srishti Sharma wrote: > Remove the local variable inflight_counter as it is never used. > > Signed-off-by: Srishti Sharma <srishtis...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > Changes in v5: > - Correct the format of t

Re: [Outreachy kernel] [PATCH v4] Staging: ccree: ssi_cipher.c: Remove unused variable.

2017-09-07 Thread Julia Lawall
One last detail. The subject line above is not in the same format as that of all of the other subject lines one commits affecting this file. You can use git log --oneline to see what others have done. It is not really possible to guess correctly. However, one does not generally include the

Re: [Outreachy kernel] [PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable.

2017-09-06 Thread Julia Lawall
On Thu, 7 Sep 2017, Srishti Sharma wrote: > On Thu, Sep 7, 2017 at 2:47 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > > > > On Thu, 7 Sep 2017, Srishti Sharma wrote: > > > >> Remove local variable inflight_counter ,as it is nev

Re: [Outreachy kernel] [PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable.

2017-09-06 Thread Julia Lawall
On Thu, 7 Sep 2017, Srishti Sharma wrote: > Remove local variable inflight_counter ,as it is never used. "counter ,as" -> "counter, as" > Signed-off-by: Srishti Sharma > --- > Changes in v3: > - There was no longer a need to make the comment more comprehensible as >

Re: [Outreachy kernel] [PATCH v2] Staging: ccree: ssi_cipher.c: Make comment more comprehensible.

2017-09-06 Thread Julia Lawall
On Thu, 7 Sep 2017, Srishti Sharma wrote: > Edited comment to make it more comprehensible. > > Signed-off-by: Srishti Sharma > --- > Changes in v2: > - Make comment more comprehensible , instead of just correcting typos. > drivers/staging/ccree/ssi_cipher.c | 4 +++- >

Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: ssi_cipher.c: Correct spelling mistake.

2017-09-06 Thread Julia Lawall
On Wed, 6 Sep 2017, Srishti Sharma wrote: > > > On Thursday, September 7, 2017 at 12:54:49 AM UTC+5:30, Srishti Sharma > wrote: > Correct spelling of counter in comment . > > Signed-off-by: Srishti Sharma > --- >  

Re: [PATCH] ALSA: ac97c: Fix an error handling path in 'atmel_ac97c_probe()'

2017-08-31 Thread Julia Lawall
On Thu, 31 Aug 2017, Alexandre Belloni wrote: > Hi, > > On 31/08/2017 at 21:08:10 +0200, Christophe JAILLET wrote: > > Le 31/08/2017 à 12:38, Mark Brown a écrit : > > > On Thu, Aug 31, 2017 at 12:31:33PM +0200, Takashi Iwai wrote: > > > > > > > This is again a typical problem by such a trivial

Re: [alsa-devel] [PATCH] ALSA: ac97c: Fix an error handling path in 'atmel_ac97c_probe()'

2017-08-31 Thread Julia Lawall
On Thu, 31 Aug 2017, Alexandre Belloni wrote: > On 31/08/2017 at 06:40:42 +0200, Christophe JAILLET wrote: > > If 'clk_prepare_enable()' fails, we must release some resources before > > returning. Add a new label in the existing error handling path and 'goto' > > there. > > > > Fixes:

RE: [PATCH] Coccinelle: add atomic_as_refcounter script

2017-08-30 Thread Julia Lawall
ic_t. > > > > > > Signed-off-by: Elena Reshetova <elena.reshet...@intel.com> > > > > Acked-by: Julia Lawall <julia.law...@lip6.fr> > > Thank you very much Julia! What is the correct path to merge this? > I will resend with your acked-by, but

Re: [PATCH] Coccinelle: add atomic_as_refcounter script

2017-08-30 Thread Julia Lawall
On Wed, 30 Aug 2017, Elena Reshetova wrote: > atomic_as_refcounter.cocci script allows detecting > cases when refcount_t type and API should be used > instead of atomic_t. > > Signed-off-by: Elena Reshetova <elena.reshet...@intel.com> Acked-by: Julia Lawall

RE: [PATCH v3] provide rule for finding refcounters

2017-08-29 Thread Julia Lawall
On Tue, 29 Aug 2017, Reshetova, Elena wrote: > Hi, I am very sorry for the delayed reply. Finally unrigging my inbox :( > > > A few more small issues: > > > > When you deleted the disjunction, you kept the surrounding parentheses. > > you can drop them (lines 83 and 85). > > > > I guess that

Re: [Cocci] cocci: remove unnecessary casts of void * while avoiding casts with __user or __force ?

2017-08-28 Thread Julia Lawall
On Mon, 28 Aug 2017, Joe Perches wrote: > A simple cocci script that removes unnecessary casts of > a void * will also remove casts with __force or __user Unfortunately, attributes are currently not supported inside casts. This can be done in a hackish way (possible false negatives) as

[PATCH] Coccinelle: setup_timer: improve messages from setup_timer

2017-08-23 Thread Julia Lawall
Allow messages about multiple timers. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- scripts/coccinelle/api/setup_timer.cocci | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/scripts/coccinelle/api/setup_timer.cocci b/scripts/coccinel

Re: [PATCH] coccinelle: Improve setup_timer.cocci matching

2017-08-23 Thread Julia Lawall
On Tue, 22 Aug 2017, Kees Cook wrote: > This improves the patch mode of setup_timer.cocci. Several patterns were > missing: > - assignments-before-init_timer() cases > - limiting the .data case removal to the struct timer_list instance > - handling calls by dereference (timer->field vs

Re: [PATCH] input/keyboard: fix platform_no_drv_owner.cocci warnings

2017-08-20 Thread Julia Lawall
On Sun, 20 Aug 2017, Dmitry Torokhov wrote: > On Sun, Aug 20, 2017 at 11:19:38AM +0200, Julia Lawall wrote: > > No need to set .owner here. The core will do it. > > > > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci > > > > Fixes: 52cf59051

[PATCH] input/keyboard: fix platform_no_drv_owner.cocci warnings

2017-08-20 Thread Julia Lawall
No need to set .owner here. The core will do it. Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Fixes: 52cf590518d7 ("input/keyboard: Add support for Dollar Cove TI power button") Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Fenggua

Re: [PATCH] Coccinelle: add atomic_as_refcounter script

2017-08-17 Thread Julia Lawall
> +identifier fname =~ ".*free.*"; > +identifier fname2 =~ ".*destroy.*"; > +identifier fname3 =~ ".*del.*"; > +identifier fname4 =~ ".*queue_work.*"; > +identifier fname5 =~ ".*schedule_work.*"; > +identifier fname6 =~ ".*call_rcu.*"; Personally, I find the above regular expressions much easier

Re: [PATCH] Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile (fwd)

2017-08-17 Thread Julia Lawall
It is intentional that the code on lines 122 and 124 is the same? julia -- Forwarded message -- Date: Thu, 17 Aug 2017 09:18:50 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH]

Re: [PATCH v3] provide rule for finding refcounters

2017-08-16 Thread Julia Lawall
A few more small issues: When you deleted the disjunction, you kept the surrounding parentheses. you can drop them (lines 83 and 85). I guess that the "del" regular expression is supposed to be matching delete. But it also matches delayed, eg net/batman-adv/bridge_loop_avoidance.c:1495:8-27:

[PATCH 0/5] constify snd_soc_dai_ops structures

2017-08-15 Thread Julia Lawall
These snd_soc_dai_ops structures are only stored in the ops field of a snd_soc_dai_driver structure, which is const. Thus, the snd_soc_dai_ops structures can be const too. Done with the help of Coccinelle. --- sound/soc/blackfin/bf6xx-i2s.c|2 +- sound/soc/codecs/es8316.c |

[PATCH 4/5] ASoC: codecs: zx_aud96p22: constify snd_soc_dai_ops structures

2017-08-15 Thread Julia Lawall
These snd_soc_dai_ops structures are only stored in the ops field of a snd_soc_dai_driver structure, which is const. Thus, the snd_soc_dai_ops structures can be const too. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- sound/soc/codecs/zx_aud9

[PATCH 3/5] ASoC: codecs: es8316: constify snd_soc_dai_ops structures

2017-08-15 Thread Julia Lawall
These snd_soc_dai_ops structures are only stored in the ops field of a snd_soc_dai_driver structure, which is const. Thus, the snd_soc_dai_ops structures can be const too. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- sound/soc/codecs/es8316.c

[PATCH 2/5] ASoC: rockchip: constify snd_soc_dai_ops structures

2017-08-15 Thread Julia Lawall
These snd_soc_dai_ops structures are only stored in the ops field of a snd_soc_dai_driver structure, which is const. Thus, the snd_soc_dai_ops structures can be const too. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- sound/soc/ro

[PATCH 5/5] ASoC: spear: constify snd_soc_dai_ops structures

2017-08-15 Thread Julia Lawall
These snd_soc_dai_ops structures are only stored in the ops field of a snd_soc_dai_driver structure, which is const. Thus, the snd_soc_dai_ops structures can be const too. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- sound/soc/spear/spdi

[PATCH 1/5] ASoC: blackfin: constify snd_soc_dai_ops structures

2017-08-15 Thread Julia Lawall
These snd_soc_dai_ops structures are only stored in the ops field of a snd_soc_dai_driver structure, which is const. Thus, the snd_soc_dai_ops structures can be const too. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- sound/soc/blackfin/bf6xx

[PATCH 0/3] constify snd_rawmidi_ops structures

2017-08-15 Thread Julia Lawall
These snd_rawmidi_ops structures are only passed as the third argument of snd_rawmidi_set_ops. This argument is const, so the snd_rawmidi_ops structures can be const too. Done with the help of Coccinelle. --- drivers/hid/hid-prodikeys.c |2 +- drivers/usb/gadget/function/f_midi.c

<    1   2   3   4   5   6   7   8   9   10   >