Re: [PATCH v3 2/2] IB/mad: Use ID allocator routines to allocate agent number (fwd)

On Sun, 17 Jun 2018, jackm wrote: > On Sat, 16 Jun 2018 18:04:41 +0200 (CEST) > Julia Lawall wrote: > > > ib_mad_client_id is declared as u32, so it will not be < 0 (line 382). > > > > julia > > > Julia, your are correct. > However, I was under the im

Re: [PATCH v3 2/2] IB/mad: Use ID allocator routines to allocate agent number (fwd)

ib_mad_client_id is declared as u32, so it will not be < 0 (line 382). julia -- Forwarded message -- Date: Fri, 8 Jun 2018 08:49:57 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH v3 2/2] IB/mad: Use ID allocator routines to allocate ag

Re: [PATCH v3 2/2] IB/mad: Use ID allocator routines to allocate agent number (fwd)

ib_mad_client_id is declared as u32, so it will not be < 0 (line 382). julia -- Forwarded message -- Date: Fri, 8 Jun 2018 08:49:57 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH v3 2/2] IB/mad: Use ID allocator routines to allocate ag

Re: [PATCH] staging: rtl8192u: fix line over 80 characters

On Sat, 16 Jun 2018, Hyunil Kim wrote: > *fix checkpatch.pl warnings: > WARNING: line over 80 characters Describe what you do and why, rather than just saying "Fix". Often something can be fixed in multiple ways. julia > > Signed-off-by: Hyunil Kim > --- >

Re: [PATCH] staging: rtl8192u: fix line over 80 characters

On Sat, 16 Jun 2018, Hyunil Kim wrote: > *fix checkpatch.pl warnings: > WARNING: line over 80 characters Describe what you do and why, rather than just saying "Fix". Often something can be fixed in multiple ways. julia > > Signed-off-by: Hyunil Kim > --- >

[PATCH] RFC: bus: fix of_table.cocci warnings

From: kbuild test robot Make sure (of/i2c/platform)_device_id tables are NULL terminated Generated by: scripts/coccinelle/misc/of_table.cocci Fixes: 7d8c3a62781b ("RFC: bus: 96boards Low-Speed Connector") Signed-off-by: kbuild test robot Signed-off-by: Julia Lawall --- t

[PATCH] RFC: bus: fix of_table.cocci warnings

From: kbuild test robot Make sure (of/i2c/platform)_device_id tables are NULL terminated Generated by: scripts/coccinelle/misc/of_table.cocci Fixes: 7d8c3a62781b ("RFC: bus: 96boards Low-Speed Connector") Signed-off-by: kbuild test robot Signed-off-by: Julia Lawall --- t

[PATCH] RFC: bus: fix semicolon.cocci warnings

From: kbuild test robot Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: 7d8c3a62781b ("RFC: bus: 96boards Low-Speed Connector") Signed-off-by: kbuild test robot Signed-off-by: Julia Lawall --- tree: https://git.kernel.org/pub/scm/linux/

[PATCH] RFC: bus: fix semicolon.cocci warnings

From: kbuild test robot Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: 7d8c3a62781b ("RFC: bus: 96boards Low-Speed Connector") Signed-off-by: kbuild test robot Signed-off-by: Julia Lawall --- tree: https://git.kernel.org/pub/scm/linux/

[PATCH] mfd: kempld-core: constify variables that point to const structure

is as follows: (http://coccinelle.lip6.fr/) // @r@ identifier i,j; @@ const struct i j = { ... }; @ok@ identifier r.i; position p; @@ const struct i@p * @@ identifier r.i; position p != ok.p; @@ * struct i@p * // Signed-off-by: Julia Lawall --- drivers/mfd/kempld-core.c | 15 --- 1

[PATCH] mfd: kempld-core: constify variables that point to const structure

is as follows: (http://coccinelle.lip6.fr/) // @r@ identifier i,j; @@ const struct i j = { ... }; @ok@ identifier r.i; position p; @@ const struct i@p * @@ identifier r.i; position p != ok.p; @@ * struct i@p * // Signed-off-by: Julia Lawall --- drivers/mfd/kempld-core.c | 15 --- 1

[PATCH] parport: sunbpp: fix error return code

Return an error code on failure. Change leading spaces to tab on the first if. Problem found using Coccinelle. Signed-off-by: Julia Lawall --- drivers/parport/parport_sunbpp.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/parport/parport_sunbpp.c b

[PATCH] clocksource/drivers/stm32: fix error return code

Return an error code on failure. Problem found using Coccinelle. Signed-off-by: Julia Lawall --- drivers/clocksource/timer-stm32.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clocksource/timer-stm32.c b/drivers/clocksource/timer-stm32.c index e5cdc3a

[PATCH] parport: sunbpp: fix error return code

Return an error code on failure. Change leading spaces to tab on the first if. Problem found using Coccinelle. Signed-off-by: Julia Lawall --- drivers/parport/parport_sunbpp.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/parport/parport_sunbpp.c b

[PATCH] clocksource/drivers/stm32: fix error return code

Return an error code on failure. Problem found using Coccinelle. Signed-off-by: Julia Lawall --- drivers/clocksource/timer-stm32.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clocksource/timer-stm32.c b/drivers/clocksource/timer-stm32.c index e5cdc3a

[PATCH] staging: rtl8723bs: drop test

: (http://coccinelle.lip6.fr/) // @@ expression e,e1; @@ * e ? e1 : e1 // Signed-off-by: Julia Lawall --- drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers

[PATCH] staging: rtl8723bs: drop test

: (http://coccinelle.lip6.fr/) // @@ expression e,e1; @@ * e ? e1 : e1 // Signed-off-by: Julia Lawall --- drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers

Re: unnecessary test?

On Wed, 6 Jun 2018, Takashi Iwai wrote: > On Wed, 06 Jun 2018 14:39:05 +0200, > Julia Lawall wrote: > > > > In the file sound/pci/ctxfi/cthw20k1.c, the function daio_mgr_dao_init > > contains: > > > > set_field(>spoctl, SPOCTL_OS << (idx*8), >

Re: unnecessary test?

On Wed, 6 Jun 2018, Takashi Iwai wrote: > On Wed, 06 Jun 2018 14:39:05 +0200, > Julia Lawall wrote: > > > > In the file sound/pci/ctxfi/cthw20k1.c, the function daio_mgr_dao_init > > contains: > > > > set_field(>spoctl, SPOCTL_OS << (idx*8), >

Re: unnecessary test?

On Wed, 6 Jun 2018, Julia Lawall wrote: > In the file sound/pci/ctxfi/cthw20k1.c, the function daio_mgr_dao_init > contains: > > set_field(>spoctl, SPOCTL_OS << (idx*8), > ((conf >> 3) & 0x1) ? 2 : 2); /* Raw */ > > Could the second argument j

Re: unnecessary test?

On Wed, 6 Jun 2018, Julia Lawall wrote: > In the file sound/pci/ctxfi/cthw20k1.c, the function daio_mgr_dao_init > contains: > > set_field(>spoctl, SPOCTL_OS << (idx*8), > ((conf >> 3) & 0x1) ? 2 : 2); /* Raw */ > > Could the second argument j

unnecessary test?

In the file sound/pci/ctxfi/cthw20k1.c, the function daio_mgr_dao_init contains: set_field(>spoctl, SPOCTL_OS << (idx*8), ((conf >> 3) & 0x1) ? 2 : 2); /* Raw */ Could the second argument just be 2? It's true that the preceeding call contains conf >> ..., but in a more useful way, so

unnecessary test?

In the file sound/pci/ctxfi/cthw20k1.c, the function daio_mgr_dao_init contains: set_field(>spoctl, SPOCTL_OS << (idx*8), ((conf >> 3) & 0x1) ? 2 : 2); /* Raw */ Could the second argument just be 2? It's true that the preceeding call contains conf >> ..., but in a more useful way, so

Re: [PATCH] fsl/qe: ucc: copy and paste bug in ucc_get_tdm_sync_shift()

On Mon, 4 Jun 2018, Dan Carpenter wrote: > There is a copy and paste bug so we accidentally use the RX_ shift when > we're in TX_ mode. > > Fixes: bb8b2062aff3 ("fsl/qe: setup clock source for TDM mode") > Signed-off-by: Dan Carpenter > --- > Static analysis work. Not tested. This affects

Re: [PATCH] fsl/qe: ucc: copy and paste bug in ucc_get_tdm_sync_shift()

On Mon, 4 Jun 2018, Dan Carpenter wrote: > There is a copy and paste bug so we accidentally use the RX_ shift when > we're in TX_ mode. > > Fixes: bb8b2062aff3 ("fsl/qe: setup clock source for TDM mode") > Signed-off-by: Dan Carpenter > --- > Static analysis work. Not tested. This affects

[PATCH] udmabuf: fix odd_ptr_err.cocci warnings

From: kbuild test robot drivers/dma-buf/udmabuf.c:167:6-12: inconsistent IS_ERR and PTR_ERR on line 168. PTR_ERR should access the value just tested by IS_ERR Semantic patch information: There can be false positives in the patch case, where it is the call to IS_ERR

[PATCH] udmabuf: fix odd_ptr_err.cocci warnings

From: kbuild test robot drivers/dma-buf/udmabuf.c:167:6-12: inconsistent IS_ERR and PTR_ERR on line 168. PTR_ERR should access the value just tested by IS_ERR Semantic patch information: There can be false positives in the patch case, where it is the call to IS_ERR that is wrong. Generated

[PATCH 2/5] phy: add missing of_node_put

for_each_child_of_node; @@ for_each_child_of_node(root, child) { ... when != of_node_put(child) when != e = child + of_node_put(child); ? break; ... } ... when != child // Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/phy/hisilicon/phy-hisi-inno-usb2.c

[PATCH 2/5] phy: add missing of_node_put

for_each_child_of_node; @@ for_each_child_of_node(root, child) { ... when != of_node_put(child) when != e = child + of_node_put(child); ? break; ... } ... when != child // Signed-off-by: Julia Lawall --- drivers/phy/hisilicon/phy-hisi-inno-usb2.c |9 +++-- 1 file changed, 7

[PATCH 1/5] pinctrl: at91-pio4: add missing of_node_put

; @@ for_each_child_of_node(root, child) { ... when != of_node_put(child) when != e = child + of_node_put(child); ? break; ... } ... when != child // Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/pinctrl/pinctrl-at91-pio4.c |4 +++- 1 file changed, 3 inse

[PATCH 1/5] pinctrl: at91-pio4: add missing of_node_put

; @@ for_each_child_of_node(root, child) { ... when != of_node_put(child) when != e = child + of_node_put(child); ? break; ... } ... when != child // Signed-off-by: Julia Lawall --- drivers/pinctrl/pinctrl-at91-pio4.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion

[PATCH 5/5] drm/rockchip: lvds: add missing of_node_put

; @@ for_each_child_of_node(root, child) { ... when != of_node_put(child) when != e = child + of_node_put(child); ? break; ... } ... when != child // Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/gpu/drm/rockchip/rockchip_lvds.c |4 +++- 1 file chan

[PATCH 5/5] drm/rockchip: lvds: add missing of_node_put

; @@ for_each_child_of_node(root, child) { ... when != of_node_put(child) when != e = child + of_node_put(child); ? break; ... } ... when != child // Signed-off-by: Julia Lawall --- drivers/gpu/drm/rockchip/rockchip_lvds.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion

[PATCH 3/5] soc: ti: knav_dma: add missing of_node_put

; @@ for_each_child_of_node(root, child) { ... when != of_node_put(child) when != e = child + of_node_put(child); ? break; ... } ... when != child // Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/soc/ti/knav_dma.c |1 + 1 file changed, 1 insertion(+)

[PATCH 0/5] add missing of_node_put

The device node iterators perform an of_node_get on each iteration, so a jump out of the loop requires an of_node_put. --- drivers/gpu/drm/rockchip/rockchip_lvds.c |4 +++- drivers/pci/hotplug/pnv_php.c |8 ++-- drivers/phy/hisilicon/phy-hisi-inno-usb2.c |9

[PATCH 3/5] soc: ti: knav_dma: add missing of_node_put

; @@ for_each_child_of_node(root, child) { ... when != of_node_put(child) when != e = child + of_node_put(child); ? break; ... } ... when != child // Signed-off-by: Julia Lawall --- drivers/soc/ti/knav_dma.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/ti

[PATCH 0/5] add missing of_node_put

The device node iterators perform an of_node_get on each iteration, so a jump out of the loop requires an of_node_put. --- drivers/gpu/drm/rockchip/rockchip_lvds.c |4 +++- drivers/pci/hotplug/pnv_php.c |8 ++-- drivers/phy/hisilicon/phy-hisi-inno-usb2.c |9

[PATCH 4/5] pci/hotplug/pnv-php: add missing of_node_put

; @@ for_each_child_of_node(root, child) { ... when != of_node_put(child) when != e = child + of_node_put(child); ? break; ... } ... when != child // Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/pci/hotplug/pnv_php.c |8 ++-- 1 file changed, 6 inse

[PATCH 4/5] pci/hotplug/pnv-php: add missing of_node_put

; @@ for_each_child_of_node(root, child) { ... when != of_node_put(child) when != e = child + of_node_put(child); ? break; ... } ... when != child // Signed-off-by: Julia Lawall --- drivers/pci/hotplug/pnv_php.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions

[PATCH 1/3] i2c: mux: pca954x: merge calls to of_match_device and of_device_get_match_data

// Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/i2c/muxes/i2c-mux-pca954x.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c index 09bafd3..ced840f 100644 --- a/drivers/i2c

[PATCH 1/3] i2c: mux: pca954x: merge calls to of_match_device and of_device_get_match_data

// Signed-off-by: Julia Lawall --- drivers/i2c/muxes/i2c-mux-pca954x.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c index 09bafd3..ced840f 100644 --- a/drivers/i2c/muxes/i2c-mux-pca954x.c +++ b

[PATCH 0/3] merge calls to of_match_device and of_device_get_match_data

of_device_get_match_data calls of_match_device and fails if the latter fails, so both calls aren't needed. --- drivers/i2c/muxes/i2c-mux-pca954x.c |7 ++- drivers/iio/adc/max1363.c |8 ++-- drivers/iio/potentiometer/max5481.c |7 ++-

[PATCH 3/3] iio: potentiometer: merge calls to of_match_device and of_device_get_match_data

// Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/iio/potentiometer/max5481.c |7 ++- drivers/iio/potentiometer/mcp4018.c |7 ++- drivers/iio/potentiometer/mcp4531.c |7 ++- 3 files changed, 6 insertions(+), 15 deletions(-) diff --git a/drive

[PATCH 0/3] merge calls to of_match_device and of_device_get_match_data

of_device_get_match_data calls of_match_device and fails if the latter fails, so both calls aren't needed. --- drivers/i2c/muxes/i2c-mux-pca954x.c |7 ++- drivers/iio/adc/max1363.c |8 ++-- drivers/iio/potentiometer/max5481.c |7 ++-

[PATCH 3/3] iio: potentiometer: merge calls to of_match_device and of_device_get_match_data

// Signed-off-by: Julia Lawall --- drivers/iio/potentiometer/max5481.c |7 ++- drivers/iio/potentiometer/mcp4018.c |7 ++- drivers/iio/potentiometer/mcp4531.c |7 ++- 3 files changed, 6 insertions(+), 15 deletions(-) diff --git a/drivers/iio/potentiometer/mcp4018.c b/drivers

[PATCH] coccinelle: deref_null: improve performance

tested expression. Collecting them just once is sufficient and more efficient. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- scripts/coccinelle/null/deref_null.cocci | 40 +++ 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/s

[PATCH] coccinelle: mini_lock: improve performance

Replace <+... ...+> by ... when any. <+... ...+> is slow, and in some obscure cases involving backward jumps it doesn't force the unlock to actually come after the end of the if. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- scripts/coccinelle/locks/mini_lock.cocc

[PATCH] coccinelle: deref_null: improve performance

tested expression. Collecting them just once is sufficient and more efficient. Signed-off-by: Julia Lawall --- scripts/coccinelle/null/deref_null.cocci | 40 +++ 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/scripts/coccinelle/null

[PATCH] coccinelle: mini_lock: improve performance

Replace <+... ...+> by ... when any. <+... ...+> is slow, and in some obscure cases involving backward jumps it doesn't force the unlock to actually come after the end of the if. Signed-off-by: Julia Lawall --- scripts/coccinelle/locks/mini_lock.cocci |6 -- 1 fil

drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c:1001:52-53: asic_setup: first occurrence line 1004, second occurrence line 1031 (fwd)

The structure has two initializations of the field asic_setup. julia -- Forwarded message -- Date: Sat, 19 May 2018 02:35:04 +0800 From: kbuild test robot <l...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: drivers/gpu/drm/amd/pow

drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c:1001:52-53: asic_setup: first occurrence line 1004, second occurrence line 1031 (fwd)

The structure has two initializations of the field asic_setup. julia -- Forwarded message -- Date: Sat, 19 May 2018 02:35:04 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c:1001:52-53: asic_setup

[PATCH] drm/nouveau/kms/nv50-: fix drm-get-put.cocci warnings

0/") Signed-off-by: kbuild test robot <fengguang...@intel.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- tree: https://github.com/skeggsb/linux linux-4.18 head: 6c46d01f25bcf74608d09645c27c35c3f3940ebe commit: 30ed49b55b6e44e004c3095671e74fea93ee84cb [105/165] drm/

[PATCH] drm/nouveau/kms/nv50-: fix drm-get-put.cocci warnings

test robot Signed-off-by: Julia Lawall --- tree: https://github.com/skeggsb/linux linux-4.18 head: 6c46d01f25bcf74608d09645c27c35c3f3940ebe commit: 30ed49b55b6e44e004c3095671e74fea93ee84cb [105/165] drm/nouveau/kms/nv50-: move code underneath dispnv50/ disp.c |2 +- 1 file changed, 1

Re: [PATCH 2/3] media: staging: atomisp: Fix an error handling path in 'lm3554_probe()'

On Fri, 11 May 2018, Christophe JAILLET wrote: > The use of 'fail1' and 'fail2' is not correct. Reorder these calls to > branch at the right place of the error handling path. Maybe it would be good to improve the names at the same time? julia > > Signed-off-by: Christophe JAILLET

Re: [PATCH 2/3] media: staging: atomisp: Fix an error handling path in 'lm3554_probe()'

On Fri, 11 May 2018, Christophe JAILLET wrote: > The use of 'fail1' and 'fail2' is not correct. Reorder these calls to > branch at the right place of the error handling path. Maybe it would be good to improve the names at the same time? julia > > Signed-off-by: Christophe JAILLET > --- >

[PATCH] leds: lm3601x: fix semicolon.cocci warnings

...@intel.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- url: https://github.com/0day-ci/linux/commits/Dan-Murphy/dt-bindings-lm3601x-Introduce-the-lm3601x-driver/20180509-033939 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next :: branch date:

[PATCH] leds: lm3601x: fix semicolon.cocci warnings

From: Fengguang Wu Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: b550389fcb74 ("leds: lm3601x: Introduce the lm3601x LED driver") CC: Dan Murphy Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- url: https://github.com/0da

[PATCH v2] [media] pvrusb2: delete unneeded include

pvrusb2-video-v4l.h only declares pvr2_saa7115_subdev_update and includes pvrusb2-hdw-internal.h. pvrusb2-cx2584x-v4l.c does not use pvr2_saa7115_subdev_update and it explicitly includes pvrusb2-hdw-internal.h. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- v2: Make the subjec

[PATCH v2] [media] pvrusb2: delete unneeded include

pvrusb2-video-v4l.h only declares pvr2_saa7115_subdev_update and includes pvrusb2-hdw-internal.h. pvrusb2-cx2584x-v4l.c does not use pvr2_saa7115_subdev_update and it explicitly includes pvrusb2-hdw-internal.h. Signed-off-by: Julia Lawall --- v2: Make the subject line a bit less generic

[PATCH] [media] media: delete unneeded include

pvrusb2-video-v4l.h only declares pvr2_saa7115_subdev_update and includes pvrusb2-hdw-internal.h. pvrusb2-cx2584x-v4l.c does not use pvr2_saa7115_subdev_update and it explicitly includes pvrusb2-hdw-internal.h. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/media/usb/p

[PATCH] [media] media: delete unneeded include

pvrusb2-video-v4l.h only declares pvr2_saa7115_subdev_update and includes pvrusb2-hdw-internal.h. pvrusb2-cx2584x-v4l.c does not use pvr2_saa7115_subdev_update and it explicitly includes pvrusb2-hdw-internal.h. Signed-off-by: Julia Lawall --- drivers/media/usb/pvrusb2/pvrusb2-cx2584x-v4l.c

[PATCH] mwifiex: delete unneeded include

Nothing that is defined in 11ac.h is referenced in cmdevt.c. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/net/wireless/marvell/mwifiex/cmdevt.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/marvell/mwifiex/cmdevt.c b/drivers/net/wireless/m

[PATCH] mwifiex: delete unneeded include

Nothing that is defined in 11ac.h is referenced in cmdevt.c. Signed-off-by: Julia Lawall --- drivers/net/wireless/marvell/mwifiex/cmdevt.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/marvell/mwifiex/cmdevt.c b/drivers/net/wireless/marvell/mwifiex/cmdevt.c index

Re: [PATCH 2/2] mm: Add kvmalloc_ab_c and kvzalloc_struct

On Tue, 1 May 2018, Kees Cook wrote: > On Mon, Apr 30, 2018 at 2:29 PM, Rasmus Villemoes > wrote: > > On 2018-04-30 22:16, Matthew Wilcox wrote: > >> On Mon, Apr 30, 2018 at 12:02:14PM -0700, Kees Cook wrote: > >>> > >>> Getting the constant ordering right could be

Re: [PATCH 2/2] mm: Add kvmalloc_ab_c and kvzalloc_struct

On Tue, 1 May 2018, Kees Cook wrote: > On Mon, Apr 30, 2018 at 2:29 PM, Rasmus Villemoes > wrote: > > On 2018-04-30 22:16, Matthew Wilcox wrote: > >> On Mon, Apr 30, 2018 at 12:02:14PM -0700, Kees Cook wrote: > >>> > >>> Getting the constant ordering right could be part of the macro > >>>

Re: bug-introducing patches (or: -rc cycles suck)

On Mon, 30 Apr 2018, Sasha Levin wrote: > Working on AUTOSEL, it became even more obvious to me how difficult it is for > a patch to get a proper review. Maintainers found it difficult to keep up > with the upstream work for their subsystem, and reviewing additional -stable > patches put

Re: bug-introducing patches (or: -rc cycles suck)

On Mon, 30 Apr 2018, Sasha Levin wrote: > Working on AUTOSEL, it became even more obvious to me how difficult it is for > a patch to get a proper review. Maintainers found it difficult to keep up > with the upstream work for their subsystem, and reviewing additional -stable > patches put

Re: [LSF/MM TOPIC NOTES] x86 ZONE_DMA love

Here are some improved results, also taking into account the pci functions. julia too small: drivers/gpu/drm/i915/i915_drv.c:1138: 30 too small: drivers/hwtracing/coresight/coresight-tmc.c:335: 0 too small: drivers/media/pci/sta2x11/sta2x11_vip.c:859: 29 too small:

Re: [LSF/MM TOPIC NOTES] x86 ZONE_DMA love

Here are some improved results, also taking into account the pci functions. julia too small: drivers/gpu/drm/i915/i915_drv.c:1138: 30 too small: drivers/hwtracing/coresight/coresight-tmc.c:335: 0 too small: drivers/media/pci/sta2x11/sta2x11_vip.c:859: 29 too small:

Re: [LSF/MM TOPIC NOTES] x86 ZONE_DMA love

On Sat, 28 Apr 2018, Luis R. Rodriguez wrote: > On Sat, Apr 28, 2018 at 01:42:21AM -0700, Christoph Hellwig wrote: > > On Fri, Apr 27, 2018 at 04:14:56PM +, Luis R. Rodriguez wrote: > > > Do we have a list of users for x86 with a small DMA mask? > > > Or, given that I'm not aware of a tool

Re: [LSF/MM TOPIC NOTES] x86 ZONE_DMA love

On Sat, 28 Apr 2018, Luis R. Rodriguez wrote: > On Sat, Apr 28, 2018 at 01:42:21AM -0700, Christoph Hellwig wrote: > > On Fri, Apr 27, 2018 at 04:14:56PM +, Luis R. Rodriguez wrote: > > > Do we have a list of users for x86 with a small DMA mask? > > > Or, given that I'm not aware of a tool

[PATCH] mhi_bus: core: fix debugfs_simple_attr.cocci warnings

unsafe(). Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Fixes: ec8245f7a36f ("mhi_bus: core: Add support for MHI host interface") CC: Sujeev Dias <sd...@codeaurora.org> Signed-off-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Julia Lawall <

[PATCH] mhi_bus: core: fix debugfs_simple_attr.cocci warnings

/coccinelle/api/debugfs/debugfs_simple_attr.cocci Fixes: ec8245f7a36f ("mhi_bus: core: Add support for MHI host interface") CC: Sujeev Dias Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- url: https://github.com/0day-ci/linux/commits/Sujeev-Dias/mhi_bus-core-Add-support-fo

[PATCH] mhi_bus: core: fix memdup.cocci warnings

d-off-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- url: https://github.com/0day-ci/linux/commits/Sujeev-Dias/mhi_bus-core-Add-support-for-MHI-host-interface/20180428-065959 :: branch date: 3 hours ago :: commit date: 3 hours a

[PATCH] mhi_bus: core: fix memdup.cocci warnings

From: Fengguang Wu Use kmemdup rather than duplicating its implementation Generated by: scripts/coccinelle/api/memdup.cocci Fixes: ec8245f7a36f ("mhi_bus: core: Add support for MHI host interface") CC: Sujeev Dias Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall ---

[PATCH] mhi_bus: core: fix semicolon.cocci warnings

From: Fengguang Wu Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: ec8245f7a36f ("mhi_bus: core: Add support for MHI host interface") CC: Sujeev Dias Signed-off-by: Fengguang Wu ---

[PATCH] mhi_bus: core: fix semicolon.cocci warnings

From: Fengguang Wu Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: ec8245f7a36f ("mhi_bus: core: Add support for MHI host interface") CC: Sujeev Dias Signed-off-by: Fengguang Wu --- url:

[PATCH] mhi_bus: dev: netdev: fix debugfs_simple_attr.cocci warnings

unsafe(). Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Fixes: e693c860afd8 ("mhi_bus: dev: netdev: add network interface driver") CC: Sujeev Dias <sd...@codeaurora.org> Signed-off-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Julia

[PATCH] mhi_bus: dev: netdev: fix debugfs_simple_attr.cocci warnings

/coccinelle/api/debugfs/debugfs_simple_attr.cocci Fixes: e693c860afd8 ("mhi_bus: dev: netdev: add network interface driver") CC: Sujeev Dias Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- url: https://github.com/0day-ci/linux/commits/Sujeev-Dias/mhi_bus-core-Add-suppo

[PATCH] mhi_bus: controller: fix platform_no_drv_owner.cocci warnings

eaurora.org> Signed-off-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- url: https://github.com/0day-ci/linux/commits/Sujeev-Dias/mhi_bus-core-Add-support-for-MHI-host-interface/20180428-065959 :: branch date: 4 hours ago :: comm

[PATCH] mhi_bus: controller: fix platform_no_drv_owner.cocci warnings

From: Fengguang Wu Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Fixes: 6190c08efd64 ("mhi_bus: controller: MHI support for QCOM modems") CC: Sujeev Dias Signed-off-by: Fengguang Wu Signed-off

[PATCH] mhi_bus: controller: fix debugfs_simple_attr.cocci warnings

unsafe(). Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Fixes: 6190c08efd64 ("mhi_bus: controller: MHI support for QCOM modems") CC: Sujeev Dias <sd...@codeaurora.org> Signed-off-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Julia Lawall <

[PATCH] mhi_bus: controller: fix debugfs_simple_attr.cocci warnings

/coccinelle/api/debugfs/debugfs_simple_attr.cocci Fixes: 6190c08efd64 ("mhi_bus: controller: MHI support for QCOM modems") CC: Sujeev Dias Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- url: https://github.com/0day-ci/linux/commits/Sujeev-Dias/mhi_bus-core-Add-support-fo

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

On Wed, 18 Apr 2018, Joe Perches wrote: > On Thu, 2018-04-19 at 06:40 +0200, Julia Lawall wrote: > > > > On Wed, 18 Apr 2018, Joe Perches wrote: > > > > > On Tue, 2018-04-17 at 17:07 +0800, yuank...@codeaurora.org wrote: > > > > Hi julia, > >

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

On Wed, 18 Apr 2018, Joe Perches wrote: > On Thu, 2018-04-19 at 06:40 +0200, Julia Lawall wrote: > > > > On Wed, 18 Apr 2018, Joe Perches wrote: > > > > > On Tue, 2018-04-17 at 17:07 +0800, yuank...@codeaurora.org wrote: > > > > Hi julia, > >

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

On Wed, 18 Apr 2018, Joe Perches wrote: > On Tue, 2018-04-17 at 17:07 +0800, yuank...@codeaurora.org wrote: > > Hi julia, > > > > On 2018-04-15 05:19 AM, Julia Lawall wrote: > > > On Wed, 11 Apr 2018, Joe Perches wrote: > > > > > > > On

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

On Wed, 18 Apr 2018, Joe Perches wrote: > On Tue, 2018-04-17 at 17:07 +0800, yuank...@codeaurora.org wrote: > > Hi julia, > > > > On 2018-04-15 05:19 AM, Julia Lawall wrote: > > > On Wed, 11 Apr 2018, Joe Perches wrote: > > > > > > > On

Re: [PATCH 08/12] mmc: reduce use of block bounce buffers (fwd)

There is a duplicated test on line 360. julia -- Forwarded message -- Date: Mon, 16 Apr 2018 23:04:18 +0800 From: kbuild test robot <l...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH 08/12] mmc: reduce use of block bounce

Re: [PATCH 08/12] mmc: reduce use of block bounce buffers (fwd)

There is a duplicated test on line 360. julia -- Forwarded message -- Date: Mon, 16 Apr 2018 23:04:18 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH 08/12] mmc: reduce use of block bounce buffers CC: kbuild-...@01.org In-Reply

Re: [PATCH] drm: fix drm-get-put.cocci warnings

On Mon, 16 Apr 2018, Daniel Vetter wrote: > On Thu, Apr 12, 2018 at 07:54:10AM +0200, Julia Lawall wrote: > > From: Fengguang Wu <fengguang...@intel.com> > > > > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and > > drm_*_unrefer

Re: [PATCH] drm: fix drm-get-put.cocci warnings

On Mon, 16 Apr 2018, Daniel Vetter wrote: > On Thu, Apr 12, 2018 at 07:54:10AM +0200, Julia Lawall wrote: > > From: Fengguang Wu > > > > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and > > drm_*_unreference() helpers. > > > > G

Re: BUILD_BUG_ON_MSG

On Sun, 15 Apr 2018, Daniel Santos wrote: > Hello Julia, > > I'm CCing LKML on this so that others can be involved. > > > On 04/15/2018 12:43 AM, Julia Lawall wrote: > > Hello, > > > > I saw that you introduced BUILD_BUG_ON_MSG in the Linux kernel a few yea

Re: BUILD_BUG_ON_MSG

On Sun, 15 Apr 2018, Daniel Santos wrote: > Hello Julia, > > I'm CCing LKML on this so that others can be involved. > > > On 04/15/2018 12:43 AM, Julia Lawall wrote: > > Hello, > > > > I saw that you introduced BUILD_BUG_ON_MSG in the Linux kernel a few yea

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

On Wed, 11 Apr 2018, Joe Perches wrote: > On Thu, 2018-04-12 at 08:22 +0200, Julia Lawall wrote: > > On Wed, 11 Apr 2018, Joe Perches wrote: > > > On Wed, 2018-04-11 at 09:29 -0700, Andrew Morton wrote: > > > > We already have some 500 bools-in-structs >

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

On Wed, 11 Apr 2018, Joe Perches wrote: > On Thu, 2018-04-12 at 08:22 +0200, Julia Lawall wrote: > > On Wed, 11 Apr 2018, Joe Perches wrote: > > > On Wed, 2018-04-11 at 09:29 -0700, Andrew Morton wrote: > > > > We already have some 500 bools-in-structs >

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

On Wed, 11 Apr 2018, Joe Perches wrote: > On Thu, 2018-04-12 at 08:22 +0200, Julia Lawall wrote: > > On Wed, 11 Apr 2018, Joe Perches wrote: > > > On Wed, 2018-04-11 at 09:29 -0700, Andrew Morton wrote: > > > > We already have some 500 bools-in-structs >

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

On Wed, 11 Apr 2018, Joe Perches wrote: > On Thu, 2018-04-12 at 08:22 +0200, Julia Lawall wrote: > > On Wed, 11 Apr 2018, Joe Perches wrote: > > > On Wed, 2018-04-11 at 09:29 -0700, Andrew Morton wrote: > > > > We already have some 500 bools-in-structs >

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

On Wed, 11 Apr 2018, Joe Perches wrote: > (Adding Julia Lawall) > > On Wed, 2018-04-11 at 09:29 -0700, Andrew Morton wrote: > > We already have some 500 bools-in-structs > > I got at least triple that only in include/ > so I expect there are at probably an order >

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

On Wed, 11 Apr 2018, Joe Perches wrote: > (Adding Julia Lawall) > > On Wed, 2018-04-11 at 09:29 -0700, Andrew Morton wrote: > > We already have some 500 bools-in-structs > > I got at least triple that only in include/ > so I expect there are at probably an order >

[PATCH] drm: fix drm-get-put.cocci warnings

ng Wu <fengguang...@intel.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- tree: https://github.com/shenki/linux drm-v1 head: 9680ed7979d5d403c6bde36271a048d62c048180 commit: 6784ac15bc6889280522b04b97f1fb1208ee45e7 [23/27] drm: Add ASPEED GFX driver aspeed_gfx_drv.c |

<    4   5   6   7   8   9   10   11   12   13   >