Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing around '&'

2017-02-26 Thread Julia Lawall
On Sun, 26 Feb 2017, Scott Branden wrote: > > > On 17-02-26 01:56 PM, Joe Perches wrote: > > On Sun, 2017-02-26 at 20:40 +0100, Julia Lawall wrote: > > > On Sun, 26 Feb 2017, Joe Perches wrote: > > > > On Sun, 2017-02-26 at 19:59 +0100, Julia Lawall wrote

Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing around '&'

2017-02-26 Thread Julia Lawall
On Sun, 26 Feb 2017, Joe Perches wrote: > On Sun, 2017-02-26 at 19:03 +0100, Julia Lawall wrote: > > > > On Sun, 26 Feb 2017, Narcisa Ana Maria Vasile wrote: > > > > > This was reported by checkpatch.pl > > > > > > Signed-off-by: Narci

Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing around '&'

2017-02-26 Thread Julia Lawall
On Sun, 26 Feb 2017, Joe Perches wrote: > On Sun, 2017-02-26 at 19:59 +0100, Julia Lawall wrote: > > On Sun, 26 Feb 2017, Joe Perches wrote: > > > Mailing lists _should_ be copied on patch submissions. > > > > The idea of outreachy is that it should be a place

Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing around '&'

2017-02-26 Thread Julia Lawall
On Sun, 26 Feb 2017, Narcisa Ana Maria Vasile wrote: > This was reported by checkpatch.pl > > Signed-off-by: Narcisa Ana Maria Vasile <narcisaanamari...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> Actually, the outreachy tutorial says not to send patches t

Re: [Outreachy kernel] [PATCH v4 2/2] staging: ks7010: Unnecessary parentheses are removed.

2017-02-26 Thread Julia Lawall
On Sun, 26 Feb 2017, Arushi Singhal wrote: > Unnecessary parentheses are removed as reported by checkpatch.pl > to make coder nicer and to improve readability. > Also coding style is improved.For example:- > It's often nicer to read if &(foo[0]) is converted to foo like: >

Re: [Outreachy kernel] [PATCH v4 1/2] staging: ks7010: Unnecessary parentheses are removed.

2017-02-26 Thread Julia Lawall
On Sun, 26 Feb 2017, Arushi Singhal wrote: > Unnecessary parentheses are removed as reported by checkpatch.pl > to make coder nicer and to improve readability. > Also coding style is improved.For example:- > It's often nicer to read if &(foo[0]) is converted to foo like: >

Re: [Outreachy kernel] [PATCH v4] staging: xgifb: correct the multiple line dereference

2017-02-26 Thread Julia Lawall
On Sun, 26 Feb 2017, Arushi Singhal wrote: > Error was reported by checkpatch.pl as "Avoid multiple line > dereference".And If there is boolean operator then it is > fixed by Splitting line at boolean operator to satisfy coding > style. Please improve the commit message. Capital letters should

Re: [PATCH] ASoC: tegra: Remove unnecessary 'Block comments should align the * on each line' message

2017-02-25 Thread Julia Lawall
The subject line is not very accurate. You don't remove the message, in the sense of picking it up and putting it somewhere else. You adjust the code in some way such that the error no longer occurs. So it would be better to say what adjustment you have done. Something like line up *s in block

Re: [PATCH] ASoC: kirkwood: Add a blank line after declarations

2017-02-25 Thread Julia Lawall
On Sat, 25 Feb 2017, Anda-Alexandra Dorneanu wrote: > From: andadrn Drop the From line. The From line needs to match up with your Signed off by line. But the one generated by your mailer already does that, while the one you added does not. julia > > This was reported by

Re: [Outreachy kernel] [PATCH v4 1/3] staging: wilc1000: Rename struct tstrRSSI to rssi_history_buffer

2017-02-24 Thread Julia Lawall
On Fri, 24 Feb 2017, Tahia Khan wrote: > Rename struct tstrRSSI to rssi_history_buffer for clarity > and to remove camel casing. > > Signed-off-by: Tahia Khan <tahia.k...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > drivers/staging/w

Re: [Outreachy kernel] Re: [PATCH] staging: xgifb: function prototype argument should have an identifier name

2017-02-24 Thread Julia Lawall
On Sat, 25 Feb 2017, Arushi Singhal wrote: > > > On Fri, Feb 24, 2017 at 10:18 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Fri, 24 Feb 2017, Arushi Singhal wrote: > > > > > > > On Fri, Feb 24, 2017 a

Re: [Outreachy kernel] [PATCH] staging: ks7010: codes in the comments are removed

2017-02-24 Thread Julia Lawall
Remember to use the imperative and to make your subject lines as short as possible. Here the subject line could be "remove code in comments". julia On Sat, 25 Feb 2017, Arushi Singhal wrote: > Commenting Code Is a Bad Idea. > Comments are their to explain the code and how the code achieves its

Re: [Outreachy kernel] [PATCH v2] staging: xgifb: correct the multiple line dereference

2017-02-24 Thread Julia Lawall
On Sat, 25 Feb 2017, Arushi Singhal wrote: > Error was reported by checkpatch.pl as > WARNING: Avoid multiple line dereference... > And If there is boolean operator then it is fixed by Splitting line at > boolean operator.This is a coding style error. There is strange spacing and

Re: [Outreachy kernel] Re: [PATCH v2 3/3] staging: rtl8192u: Prefer using the BIT macro

2017-02-24 Thread Julia Lawall
On Fri, 24 Feb 2017, SIMRAN SINGHAL wrote: > > > On Friday, February 24, 2017 at 10:46:21 PM UTC+5:30, gregkh wrote: > On Fri, Feb 17, 2017 at 11:20:59PM +0530, simran singhal wrote: > > Replaces left shift operation (1 << d) by BIT(x) macro. > > > > Fix the

Re: [Outreachy kernel] Re: [PATCH] staging: xgifb: function prototype argument should have an identifier name

2017-02-24 Thread Julia Lawall
On Fri, 24 Feb 2017, Arushi Singhal wrote: > > > On Fri, Feb 24, 2017 at 10:01 PM, Greg Kroah-Hartman > wrote: > On Wed, Feb 22, 2017 at 04:49:19PM +0530, Arushi Singhal wrote: > > function prototype arguments like 'struct vb_device_info >

[PATCH] clk: zynqmp: fix itnull.cocci warnings

2017-02-23 Thread Julia Lawall
Iterator variable bound on line 220 cannot be NULL Generated by: scripts/coccinelle/iterators/itnull.cocci CC: Shubhrajyoti Datta <shubhrajyoti.da...@xilinx.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Fengguang Wu <fengguang...@intel.com>

Re: [Outreachy kernel] [PATCH v3 1/3] staging: wilc1000: Rename struct tstrRSSI to rssi_history_buffer

2017-02-23 Thread Julia Lawall
On Fri, 24 Feb 2017, Tahia Khan wrote: > Rename struct tstrRSSI to rssi_history_buffer for clarity and to remove camel > casing. Here the commit log messge line is definitely too long. julia > > Signed-off-by: Tahia Khan > --- >

Re: [Outreachy kernel] [PATCH v3 2/3] staging: wilc1000: Rename tstrRSSI members and change type of u8Full to bool

2017-02-23 Thread Julia Lawall
On Fri, 24 Feb 2017, Tahia Khan wrote: > Remove Hungarian notation and camel casing from all tstrRSSI members' names. > Additionally, change type of u8Full to bool since it only takes values 1 or 0. Acked-by: Julia Lawall <julia.law...@lip6.fr> Maybe the second line of the co

Re: [Outreachy kernel] [PATCH v3 3/3] staging: wilc1000: Rename network_info member str_rssi to rssi_history

2017-02-23 Thread Julia Lawall
On Fri, 24 Feb 2017, Tahia Khan wrote: > Change name of str_rssi to rssi_history within the network_info struct for > clarity. > > Signed-off-by: Tahia Khan <tahia.k...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> Good job at cutting up the patch in

fs/afs/rxrpc.c:187:17-21: ERROR: reference preceded by free on line 184 (fwd)

2017-02-23 Thread Julia Lawall
No idea if this is a problem. Maybe trace_afs_call is just using the address? julia -- Forwarded message -- Date: Thu, 23 Feb 2017 23:18:26 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: fs

Re: [Outreachy kernel] Re: [PATCH v2] staging: wilc1000: renames struct tstrRSSI and its members u8Index, u8Full

2017-02-23 Thread Julia Lawall
On Thu, 23 Feb 2017, 'Arend Van Spriel' via outreachy-kernel wrote: > On 23-2-2017 8:08, Julia Lawall wrote: > >> Thanks for the feedback Arend, I really appreciate it. I've decided to go > >> with > >> these changes in my follow-up patch reques

Re: [Outreachy kernel] Re: [PATCH v2] staging: wilc1000: renames struct tstrRSSI and its members u8Index, u8Full

2017-02-22 Thread Julia Lawall
> Thanks for the feedback Arend, I really appreciate it. I've decided to go with > these changes in my follow-up patch request: > > - rename tstrRSSI to 'rssi_history_buffer' as Aren suggested since it makes > the > purpose of the struct clear > - remove Hungarian notation from all tstrRSSI

Re: [PATCH v2] ncpfs: Remove cast from memory allocation

2017-02-22 Thread Julia Lawall
On Thu, 23 Feb 2017, Tobin C. Harding wrote: > Coccinelle emits WARNING: casting value returned by memory allocation > function to (struct ncp_inode_info *) is useless. > > Remove unnecessary cast. > > Changes since v1: > - Fix up typo Changes since v1 goes below the ---. When this ends up

Re: [Outreachy kernel] [PATCH v2 2/7] staging: most: Using macro DIV_ROUND_UP

2017-02-22 Thread Julia Lawall
On Wed, 22 Feb 2017, SIMRAN SINGHAL wrote: > > > On Wednesday, February 22, 2017 at 2:57:17 PM UTC+5:30, Julia Lawall wrote: > > @@ -117,7 +118,7 @@ static int alloc_dbr(u16 size) > >  return DBR_SIZE; /* out of memory */ > > >

Re: [Outreachy kernel] [PATCH v2 2/7] staging: most: Using macro DIV_ROUND_UP

2017-02-22 Thread Julia Lawall
> @@ -117,7 +118,7 @@ static int alloc_dbr(u16 size) > return DBR_SIZE; /* out of memory */ > > for (i = 0; i < DBR_MAP_SIZE; i++) { > - u32 const blocks = (size + DBR_BLOCK_SIZE - 1) / DBR_BLOCK_SIZE; > + u32 const blocks = DIV_ROUND_UP(size,

Re: [Outreachy kernel] [PATCH 2/7] staging: most: Using macro DIV_ROUND_UP

2017-02-21 Thread Julia Lawall
On Tue, 21 Feb 2017, SIMRAN SINGHAL wrote: > > > On Wednesday, February 22, 2017 at 1:28:52 AM UTC+5:30, Julia Lawall wrote: > > > On Wed, 22 Feb 2017, simran singhal wrote: > > > The macro DIV_ROUND_UP performs the computation (((n) + (d) - > 1)

Re: [Outreachy kernel] [PATCH v3] staging: xgifb: function definition argument should also have an identifier name

2017-02-21 Thread Julia Lawall
On Wed, 22 Feb 2017, Arushi Singhal wrote: > function definition argument like 'struct vb_device_info *','unsigned > long' etc. should also have an identifier name. Actually, this is not really clear. The definition of a function is the thing that has the actual code, like int foo(int x) {

Re: [Outreachy kernel] [PATCH] staging: wilc1000: renames struct tstrRSSI and its members u8Index, u8Full

2017-02-21 Thread Julia Lawall
On Tue, 21 Feb 2017, Tahia Khan wrote: > Fixes multiple camel case checks on struct tstrRSSI from checkpatch.pl: > > Avoid CamelCase: > Avoid CamelCase: > Avoid CamelCase: > > Signed-off-by: Tahia Khan > --- > drivers/staging/wilc1000/coreconfigurator.h | 8

Re: [Outreachy kernel] [PATCH 2/7] staging: most: Using macro DIV_ROUND_UP

2017-02-21 Thread Julia Lawall
On Wed, 22 Feb 2017, simran singhal wrote: > The macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /(d)). > It clarifies the divisor calculations. This occurence was detected using > the coccinelle script: > > @@ > expression e1; > expression e2; > @@ > ( > - ((e1) + e2 - 1) / (e2) >

Re: [Outreachy kernel] [PATCH v2] staging: xgifb: function definition argument should also have an identifier name'

2017-02-21 Thread Julia Lawall
On Wed, 22 Feb 2017, Arushi Singhal wrote: > function definition argument like 'struct vb_device_info *','unsigned > long' etc. should also have an identifier name. > > Signed-off-by: Arushi Singhal > Changes in v2: > - By mistake one irrelevant line was added

Re: [Outreachy kernel] [PATCH] staging: xgifb: function definition argument should have an identifier name

2017-02-21 Thread Julia Lawall
On Tue, 21 Feb 2017, Arushi Singhal wrote: > function definition argument like 'struct vb_device_info *','unsigned > long' etc. should have an identifier name. > > Signed-off-by: Arushi Singhal > --- > drivers/staging/xgifb/vb_setmode.h | 19

Re: [Outreachy kernel] [PATCH 4/6] staging: Drop useless initialisation

2017-02-21 Thread Julia Lawall
> Also, note that the above semantic patch is not completely safe, > because > the code could be, eg: > > int a = 0; > a = a + 1; > > In that case, the initialization of a would be needed.  You > should check > each case for this issue. > > > I have

Re: [Outreachy kernel] [PATCH] staging: xgifb: correct the multiple line dereference to fix coding stye errors

2017-02-21 Thread Julia Lawall
On Tue, 21 Feb 2017, Arushi Singhal wrote: > Error was reported by checkpatch.pl as > WARNING: Avoid multiple line dereference... > if there is boolean operator then it is fixed by Splitting line at > boolean operator. This is massively execeeding the 80 character boundary, and not for

Re: [Outreachy kernel] [PATCH 4/6] staging: Drop useless initialisation

2017-02-21 Thread Julia Lawall
On Tue, 21 Feb 2017, simran singhal wrote: > Removed initialisation of a varible if it is immediately reassigned. varible -> variable > > Changes were made using Coccinelle. > > @@ > type T; > constant C; > expression e; > identifier i; > @@ > > T i > - = C > ; > i = e; This is a big patch,

Re: [Outreachy kernel] [PATCH 2/2] staging: ks7010: Unnecessary parentheses are removed and also improved coding style.

2017-02-21 Thread Julia Lawall
On Tue, 21 Feb 2017, Arushi Singhal wrote: > Unnecessary parentheses are removed as reported by checkpatch.pl > to make coder nicer and to improve readability. > Also coding style is improved.For example:- > It's often nicer to read if &(foo[0]) is converted to foo like: >

Re: [Outreachy kernel] [PATCH v2 1/2] staging: ks7010: Unnecessary parentheses are removed and also improved coding style.

2017-02-21 Thread Julia Lawall
On Tue, 21 Feb 2017, Arushi Singhal wrote: > Unnecessary parentheses are removed as reported by checkpatch.pl > to make coder nicer and to improve readability. > Also coding style is improved.For example:- > It's often nicer to read if &(foo[0]) is converted to foo like: >

Re: [Outreachy kernel] [PATCH v2 3/6] staging: greybus: Remove unnecessary braces

2017-02-21 Thread Julia Lawall
On Tue, 21 Feb 2017, simran singhal wrote: > This patch removes braces for single statement blocks. The warning > was detected using checkpatch.pl. > Coccinelle was used to make the change. > > @@ > expression e,e1; > @@ > - if (e) { > + if (e) > e1; > - } > > Signed-off-by: simran singhal

Re: [Outreachy kernel] [PATCH v2 3/6] staging: greybus: Remove unnecessary braces

2017-02-21 Thread Julia Lawall
> > Signed-off-by: simran singhal <singhalsimr...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > > v2: >-I forgot to cc outreachy mailing list > > drivers/staging/greybus/audio_manager_sysfs.c | 3 +-- > drivers/staging/greybus/

Re: [Outreachy kernel] [PATCH 2/2] staging: ks7010: Unnecessary parentheses are removed.

2017-02-20 Thread Julia Lawall
On Sun, 19 Feb 2017, Arushi Singhal wrote: > > > On Monday, February 20, 2017 at 12:32:22 PM UTC+5:30, Julia Lawall wrote: > > > On Mon, 20 Feb 2017, Arushi Singhal wrote: > > > Unnecessary parentheses should be avoided as reported by > c

Re: [Outreachy kernel] [PATCH 2/2] staging: ks7010: Unnecessary parentheses are removed.

2017-02-19 Thread Julia Lawall
On Mon, 20 Feb 2017, Arushi Singhal wrote: > Unnecessary parentheses should be avoided as reported by checkpatch.pl. > Remove unnecessary parentheses, as reported by checkpatch as are nicer > to read.For example:- > It's often nicer to read if &(foo[0]) is converted to foo like: >

Re: [Outreachy kernel] Re: [PATCH 1/2] staging: ks7010: Unnecessary parentheses are removed.

2017-02-19 Thread Julia Lawall
On Sun, 19 Feb 2017, Joe Perches wrote: > On Sun, 2017-02-19 at 19:58 +0100, Julia Lawall wrote: > > On Sun, 19 Feb 2017, Joe Perches wrote: > > > On Sun, 2017-02-19 at 23:56 +0530, Arushi Singhal wrote: > > > > Unnecessary parentheses should be avoide

Re: [Outreachy kernel] Re: [PATCH 1/2] staging: ks7010: Unnecessary parentheses are removed.

2017-02-19 Thread Julia Lawall
On Sun, 19 Feb 2017, Joe Perches wrote: > On Sun, 2017-02-19 at 23:56 +0530, Arushi Singhal wrote: > > Unnecessary parentheses should be avoided as reported by checkpatch.pl. > > Remove unnecessary parentheses, as reported by checkpatch as are nicer > > to read.For example:- > > It's often

Re: [Outreachy kernel] [PATCH 1/2] staging: ks7010: Unnecessary parentheses are removed.

2017-02-19 Thread Julia Lawall
On Sun, 19 Feb 2017, Arushi Singhal wrote: > Unnecessary parentheses should be avoided as reported by checkpatch.pl. > Remove unnecessary parentheses, as reported by checkpatch as are nicer > to read.For example:- > It's often nicer to read if &(foo[0]) is converted to foo like: >

Re: [Outreachy kernel] [PATCH v2 2/2] staging: ks7010: Unnecessary parentheses should be avoided

2017-02-19 Thread Julia Lawall
On Sun, 19 Feb 2017, Arushi Singhal wrote: > Unnecessary parentheses should be avoided as reported by checkpatch.pl > > Signed-off-by: Arushi Singhal > --- If you send a v2 for a patch, then you need to say below the --- what the v2 changes. Also, you need to

Re: [Outreachy kernel] [PATCH v2 1/2] staging: ks7010: Unnecessary parentheses should be avoided

2017-02-19 Thread Julia Lawall
On Sun, 19 Feb 2017, Arushi Singhal wrote: > Unnecessary parentheses should be avoided as reported by checkpatch.pl The commit message should be written in a positive way, to say what you are doing, and not in a negative way, saying what you are avoiding. So here you could say "Remove

Re: [Outreachy kernel] Re: [PATCH] Staging: ks7010: There should be no spaces at the start of a line

2017-02-19 Thread Julia Lawall
On Sun, 19 Feb 2017, Arushi Singhal wrote: > > Hi Greg > I think we cannot indent the text otherwise, the print statement will be > different as it should be There are newlines in the printed string. I suspect that there is no need to print them all at once. Actually, your change removed

Re: [Outreachy kernel] [PATCH v2 1/6] staging: vt6655: Compress return logic

2017-02-18 Thread Julia Lawall
On Sun, 19 Feb 2017, simran singhal wrote: > gre...@linuxfoundation.org,de...@driverdev.osuosl.org,linux-kernel@vger.kernel.org,outreachy-ker...@googlegroups.com > Bcc: > Subject: [PATCH v2 1/6] staging: vt6655: Compress return logic > Reply-To: This didn't come out well. > > Simplify

Re: [Outreachy kernel] [PATCH 1/6] staging: vt6655: Compress return logic

2017-02-18 Thread Julia Lawall
On Sun, 19 Feb 2017, simran singhal wrote: > Simplify function returns by merging assignment and return into > one command line. > Found with Coccinelle > @@ > local idexpression ret; > expression e; > @@ > > -ret = > +return > e; > -return ret; > > Signed-off-by: simran singhal

Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, Joe Perches wrote: > On Sat, 2017-02-18 at 20:12 +0100, Julia Lawall wrote: > > On Sun, 19 Feb 2017, simran singhal wrote: > > > Extra parentheses were causing checkpatch issues > > > and were removed. > [] > > > diff --git a/dr

Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses

2017-02-18 Thread Julia Lawall
On Sun, 19 Feb 2017, simran singhal wrote: > Extra parentheses were causing checkpatch issues > and were removed. > > Signed-off-by: simran singhal > --- > drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-)

Re: [Outreachy kernel] [PATCH 3/6] staging: rtl8192e: Fix block comments warning

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, SIMRAN SINGHAL wrote: > > > On Saturday, February 18, 2017 at 9:46:48 PM UTC+5:30, Julia Lawall wrote: > > > On Sat, 18 Feb 2017, SIMRAN SINGHAL wrote: > > > > > > > On Saturday, February 18, 2017 at 9:00:51

Re: [Outreachy kernel] [PATCH] Staging: ks7010: There should be no spaces at the start of a line

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, Arushi Singhal wrote: > The following patch the checkpatch.pl warning: > drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the > start of a line > > Signed-off-by: Arushi Singhal > --- > drivers/staging/ks7010/ks_hostif.c |

Re: [Outreachy kernel] [PATCH 3/6] staging: rtl8192e: Fix block comments warning

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, SIMRAN SINGHAL wrote: > > > On Saturday, February 18, 2017 at 9:00:51 PM UTC+5:30, Julia Lawall wrote: > > > On Sat, 18 Feb 2017, simran singhal wrote: > > > Align * on a line, to conform to the kernal coding >

Re: [Outreachy kernel] [PATCH 4/6] staging: rtl8192e: Remove blank line after '{'

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, simran singhal wrote: > Remove blank line after opening brace to fix the > checkpatch issue blank lines aren't necessary after > a open brace '{'. > > Signed-off-by: simran singhal <singhalsimr...@gmail.com> Acked-by: Julia Lawall <julia.law...@li

Re: [Outreachy kernel] [PATCH 3/6] staging: rtl8192e: Fix block comments warning

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, simran singhal wrote: > Align * on a line, to conform to the kernal coding > style for block comments. It is not clear what is means to align * on a line. What line? What has been done is to add a space at the beginning of the line. But then the line goes over 80

Re: [Outreachy kernel] [PATCH] staging: xgifb: function definition argument should also have an identifier name'

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, Arushi Singhal wrote: > function definition argument 'struct vb_device_info *' and 'unsigned > long' should also have an identifier name. > > Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.

Re: [Outreachy kernel] [PATCH v2 1/6] staging: rtl8192e: Replaced comparison to NULL statements

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, simran singhal wrote: > This patch removes the explicit NULL comparison. This issue was found by > checkpatch. > > Signed-off-by: simran singhal <singhalsimr...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > >

Re: [PATCH v2 3/3] Make vmbus register arguments read-only (fwd)

2017-02-18 Thread Julia Lawall
It looks like brace are missing on the if on lines 1057-1059. julia -- Forwarded message -- Date: Sat, 18 Feb 2017 15:46:30 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH v2 3/3

Re: [Outreachy kernel] [PATCH] staging: xgifb: function definition argument should also have an identifier name'

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, Arushi Singhal wrote: > function definition argument 'struct vb_device_info *' and 'unsigned > long' should also have an identifier name. This could be a bit more clear as "Add variable names to function prototype parameter list." > > Signed-off-by: Arushi Singhal

Re: [Outreachy kernel] [PATCH 1/6] staging: rtl8192e: Replaced comparison to NULL statements

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, simran singhal wrote: > This patch corrects check generated by checkpatch.pl by There is not much information in the first line. Use the imperative: Replace comparisons to NULL by ... > replacing comparison to null statements with equivalent > statements in the form of

Re: [Outreachy kernel] [PATCH 2/6] staging: rtl8192e: Remove CamelCase

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, simran singhal wrote: > This patch renames pBA to pba to avoid camelcase. I think that this was tried in the last round and was rejected, because BA is meaningful. You also see BA in the name of a header file. The kind of camel case that one should remove is

Re: [Outreachy kernel] [PATCH v2 2/3] staging: rtl8192u: Fixed 'tabstop' coding style warning

2017-02-16 Thread Julia Lawall
On Fri, 17 Feb 2017, simran singhal wrote: > Replace a mix of tabs and spaces indentation by tabs only. > > Fixed checkpatch warning "Statements should start on a tabstop" in > rtl8192u module. > > Signed-off-by: simran singhal <singhalsimr...@gmail.com>

Re: [Outreachy kernel] [PATCH 3/3] staging: rtl8192u: Prefer using the BIT macro

2017-02-16 Thread Julia Lawall
On Fri, 17 Feb 2017, simran singhal wrote: > This is a nonfunctional change, declare register bit values with BIT() > helper macro. > > Fix the checkpatch.pl issue: > CHECK: Prefer using the BIT macro replacing > bit shifting on 1 with the BIT(x) macro. > > The BIT() macro will make all the

Re: [Outreachy kernel] [PATCH 2/3] staging: rtl8192u: Fixed 'tabstop' coding style warnings

2017-02-16 Thread Julia Lawall
The subject line says "warnings", but there seems to be only one. julia On Fri, 17 Feb 2017, simran singhal wrote: > Replace a mix of tabs and spaces indentation by tabs only. > > Fixed checkpatch warning "Statements should start on a tabstop" in > rtl8192u module. > > Signed-off-by: simran

Re: [Outreachy kernel] [PATCH 1/3] staging: rtl8192u: Replace symbolic permissions with octal permissions

2017-02-16 Thread Julia Lawall
On Fri, 17 Feb 2017, simran singhal wrote: > WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. > Consider using octal permissions '0644'. > This warning is detected by checkpatch.pl This one has all the pieces in the right place, but please redo with the suggestions on the

Re: [PATCH 2/3 staging-next] oom: Add notification for oom_score_adj (fwd)

2017-02-14 Thread Julia Lawall
It looks like an unlock is missing before line 1797. julia -- Forwarded message -- Date: Wed, 15 Feb 2017 03:07:29 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH 2/3 staging-ne

[PATCH v2] drm/amd/dc: resource: fix semicolon.cocci warnings (fwd)

2017-02-13 Thread Julia Lawall
Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Harry Wentland <harry.wentl...@amd.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Fengguang Wu <fengguang...@intel.com> --- v2: make subject line u

[PATCH v2] drm/amd/dc: dm_types: fix semicolon.cocci warnings

2017-02-13 Thread Julia Lawall
Remove unneeded semicolons. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Harry Wentland <harry.wentl...@amd.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Fengguang Wu <fengguang...@intel.com> --- v2: make subject line u

[PATCH] drm/amd/dc: hw_sequencer: fix semicolon.cocci warnings

2017-02-13 Thread Julia Lawall
Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Harry Wentland <harry.wentl...@amd.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Fengguang Wu <fengguang...@intel.com> --- tree: git://people.freedesktop.org/~a

[PATCH] drm/amd/dc: fix semicolon.cocci warnings

2017-02-13 Thread Julia Lawall
Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Harry Wentland <harry.wentl...@amd.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Fengguang Wu <fengguang...@intel.com> --- tree: git://people.freedesktop.org/~a

[PATCH] drm/amd/dc: fix semicolon.cocci warnings

2017-02-13 Thread Julia Lawall
Remove unneeded semicolons. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Harry Wentland <harry.wentl...@amd.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Fengguang Wu <fengguang...@intel.com> --- tree: git://people.freedesktop.org/~a

Re: [PATCH v4 1/1] DM: inplace compressed DM target (fwd)

2017-02-13 Thread Julia Lawall
On line 1759, since ret is unsigned it will not be less than 0. julia -- Forwarded message -- Date: Tue, 14 Feb 2017 09:00:39 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH v4 1/1]

[PATCH] rtlwifi: btcoexist: fix semicolon.cocci warnings

2017-02-09 Thread Julia Lawall
Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Larry Finger <larry.fin...@lwfinger.net> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Fengguang Wu <fengguang...@intel.com> --- halbtc8821a2ant.c |2 +- 1 file ch

[PATCH] tpm xen: drop unneeded chip variable

2017-02-05 Thread Julia Lawall
The call that used chip was dropped in 1f0f30e404b3. Drop the leftover declaration and initialization. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/char/tpm/xen-tpmfront.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/char/tpm/xen-tpmfront.c b/driver

Re: Staging: speakup - syle fix permissions to octal

2017-02-04 Thread Julia Lawall
On Sat, 4 Feb 2017, Joe Perches wrote: > On Sat, 2017-02-04 at 19:10 +0100, Julia Lawall wrote: > > > > On Fri, 3 Feb 2017, Joe Perches wrote: > > > > > (adding Julia Lawall) > > > > > > On Fri, 2017-02-03 at 20:44 -0800, Guenter Roeck wrote:

Re: Staging: speakup - syle fix permissions to octal

2017-02-04 Thread Julia Lawall
On Fri, 3 Feb 2017, Joe Perches wrote: > (adding Julia Lawall) > > On Fri, 2017-02-03 at 20:44 -0800, Guenter Roeck wrote: > > On Sat, Jan 28, 2017 at 07:05:09PM +1300, Derek Robson wrote: > > > A style fix across whole driver. > > > changed permissions to oc

Re: Staging: speakup - syle fix permissions to octal

2017-02-04 Thread Julia Lawall
On Sat, 4 Feb 2017, Guenter Roeck wrote: > On 02/04/2017 06:29 AM, Julia Lawall wrote: > > > > > > On Sat, 4 Feb 2017, Guenter Roeck wrote: > > > > > On 02/03/2017 11:27 PM, Joe Perches wrote: > > > > (adding Julia Lawall) > > > > &g

Re: Staging: speakup - syle fix permissions to octal

2017-02-04 Thread Julia Lawall
On Sat, 4 Feb 2017, Guenter Roeck wrote: > On 02/03/2017 11:27 PM, Joe Perches wrote: > > (adding Julia Lawall) > > > > On Fri, 2017-02-03 at 20:44 -0800, Guenter Roeck wrote: > > > On Sat, Jan 28, 2017 at 07:05:09PM +1300, Derek Robson wrote: > >

[PATCH] xfs: fix returnvar.cocci warnings

2017-01-26 Thread Julia Lawall
Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Signed-off-by: Fengguang Wu --- Is it correct to be returning 0 in the level == 0 case? dabtree.c |9 +++-- 1 file changed, 3 insertions(+), 6

Re: [v3 PATCH 05/10] x86/insn-kernel: Add support to resolve 16-bit addressing encodings (fwd)

2017-01-25 Thread Julia Lawall
Check the type of seg on line 267. julia -- Forwarded message -- Date: Thu, 26 Jan 2017 05:24:40 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [v3 PATCH 05/10] x86/insn-kernel: Add suppor

Re: [PATCH] nvdimm: constify device_type structures

2017-01-25 Thread Julia Lawall
On Wed, 25 Jan 2017, Joe Perches wrote: > On Wed, 2017-01-25 at 07:49 +0100, Julia Lawall wrote: > > What does the data column actually represent? I tried size on the .o file > > generated from: > > > > commit a65f0161f4d69d6738d4821e649448312cd818e2 >

Re: [PATCH] nvdimm: constify device_type structures

2017-01-24 Thread Julia Lawall
On Tue, 24 Jan 2017, Joe Perches wrote: > On Tue, 2017-01-24 at 18:40 -0800, Dan Williams wrote: > > On Tue, Jan 24, 2017 at 6:37 PM, Joe Perches wrote: > > > On Wed, 2017-01-25 at 00:54 +0530, Bhumika Goyal wrote: > > > > Declare device_type structure as const as it is only

Re: [PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn

2017-01-23 Thread Julia Lawall
On Sun, 22 Jan 2017, Joe Perches wrote: > On Sun, 2017-01-22 at 22:43 -0800, Joe Perches wrote: > > Two questions for Julia Lawall: > > > > o is there a better way to do this than repeat the blocks > > one for each replacement > > o can struct device * de

Re: [PATCH v1] sound: pci: ymfpci: ymfpci_main:- Handle return NULL error from ioremap_nocache

2017-01-22 Thread Julia Lawall
Some comments on the patch header: * No need to put v1 on a patch. If you are asked to revise it, then you can start with v2. * sound: pci: ymfpci: ymfpci_main is not the proper subject line for this file. Do git log --oneline and see what others have done. * There should not be a - after the

Re: [PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn

2017-01-22 Thread Julia Lawall
hwmon to convert in applesmc.c > > > > Perhaps a coccinelle script? > > > > Two questions for Julia Lawall: > > > > o is there a better way to do this than repeat the blocks > > one for each replacement > > o can struct device * dev be made an arbitrary id

[PATCH] eeprom: fix platform_no_drv_owner.cocci warnings

2017-01-20 Thread Julia Lawall
No need to set .owner here. The core will do it. Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Serge Semin <fancer.lan...@gmail.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Fengguang Wu <fengguang...@intel.com> --- tree: http

Re: [PATCH v5 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341 (fwd)

2017-01-20 Thread Julia Lawall
mv88e6xxx_6341_family is checked twice, on line 2606 and 2607. julia -- Forwarded message -- Date: Fri, 20 Jan 2017 19:38:12 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH v5 2

Re: [patch net-next] stmmac: indent an if statement

2017-01-17 Thread Julia Lawall
On Tue, 17 Jan 2017, Alexandre Torgue wrote: > Hi Julia > > On 01/16/2017 11:10 PM, Julia Lawall wrote: > > > > > > On Tue, 17 Jan 2017, Dan Carpenter wrote: > > > > > On Mon, Jan 16, 2017 at 10:46:22PM +0100, Julia Lawall wrote: > > > > &g

[PATCH] stmmac: add missing of_node_put

2017-01-17 Thread Julia Lawall
ust after the end of stmmac_remove_config_dt. Thus, add an of_node_put on plat->mdio_node in stmmac_remove_config_dt. It is possible that the field mdio_node is never initialized, but of_node_put is NULL-safe, so it is also safe to call of_node_put in that case. Signed-off-by: Julia Lawall <

Re: [patch net-next] stmmac: indent an if statement

2017-01-16 Thread Julia Lawall
On Tue, 17 Jan 2017, Dan Carpenter wrote: > On Mon, Jan 16, 2017 at 10:46:22PM +0100, Julia Lawall wrote: > > > > > > On Mon, 16 Jan 2017, Dan Carpenter wrote: > > > > > On Mon, Jan 16, 2017 at 12:19:24PM +0300, Dan Carpenter wrote: > > > > On Sun

Re: [patch net-next] stmmac: indent an if statement

2017-01-16 Thread Julia Lawall
On Mon, 16 Jan 2017, Dan Carpenter wrote: > On Mon, Jan 16, 2017 at 12:19:24PM +0300, Dan Carpenter wrote: > > On Sun, Jan 15, 2017 at 10:14:38PM -0500, David Miller wrote: > > > From: Dan Carpenter > > > Date: Thu, 12 Jan 2017 21:46:32 +0300 > > > > > > > The break

Re: [patch net-next] stmmac: indent an if statement

2017-01-12 Thread Julia Lawall
On Thu, 12 Jan 2017, Dan Carpenter wrote: > The break statement should be indented one more tab. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > index

Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user

2017-01-10 Thread Julia Lawall
I looked at the get_user part of the original script. It looks like most of the complexity is to deal with the possibility of the src location being expressed in two different ways between the two calls. Even if this happens in practice only for get_user, it would seem that it could happen for

Re: [RFC] coccicheck: add a test for repeat memory fetches

2017-01-10 Thread Julia Lawall
On Tue, 10 Jan 2017, Kees Cook wrote: > On Tue, Jan 10, 2017 at 1:14 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > OK, I have the impression that what you are looking for is the following, > > that currently does not seem to work well. Still maybe it gives an id

Re: [RFC] coccicheck: add a test for repeat memory fetches

2017-01-10 Thread Julia Lawall
OK, I have the impression that what you are looking for is the following, that currently does not seem to work well. Still maybe it gives an idea. The basic pattern is the following sequence: 1. copy_from_user 2. test on a field of the copied value 3. another copy_from_user 4. a use of the same

Re: [RFC] coccicheck: add a test for repeat memory fetches

2017-01-10 Thread Julia Lawall
On Tue, 10 Jan 2017, Kees Cook wrote: > On Tue, Jan 10, 2017 at 10:28 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > >> +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2159 > >> +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2257 > >> +./drivers/net

Re: [RFC] coccicheck: add a test for repeat memory fetches

2017-01-10 Thread Julia Lawall
> +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2159 > +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2257 > +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2302 > +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2342 > +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2365 >

Re: [RFC] coccicheck: add a test for repeat memory fetches

2017-01-10 Thread Julia Lawall
On Tue, 10 Jan 2017, Pengfei Wang wrote: > > > 在 2017年1月10日,下午2:06,Julia Lawall <julia.law...@lip6.fr> 写道: > > > > > > > > On Mon, 9 Jan 2017, Kees Cook wrote: > > > >> Okay, this adds a few tests, for people to examine. > >>

Re: [RFC] coccicheck: add a test for repeat memory fetches

2017-01-09 Thread Julia Lawall
On Mon, 9 Jan 2017, Kees Cook wrote: > Okay, this adds a few tests, for people to examine. > > reusercopy-cook.cocci: > My original test, with recent updates from Julia. > > reusercopy-wang.cocci: > This is Pengfei's test, but with heavily modified reporting to fit in the > kernel coccicheck

[PATCH] drivers: hwmon: fix platform_no_drv_owner.cocci warnings

2017-01-09 Thread Julia Lawall
Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Jaghathiswari Rankappagounder Natarajan <ja...@google.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Fengguang Wu <fenggua

<    5   6   7   8   9   10   11   12   13   14   >