[PATCH v3 1/2] net/xen-netfront: Correct printf format in xennet_get_responses

2015-06-04 Thread Julien Grall
rx-status is an int16_t, print it using %d rather than %u in order to have a meaningful value when the field is negative. Also use %d rather than %x for rx-offset. Signed-off-by: Julien Grall julien.gr...@citrix.com Reviewed-by: David Vrabel david.vra...@citrix.com Cc: Konrad Rzeszutek Wilk

[PATCH v3 0/2] net/xen: Clean up

2015-06-04 Thread Julien Grall
david.vra...@citrix.com Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com Cc: Boris Ostrovsky boris.ostrov...@oracle.com Cc: net...@vger.kernel.org [1] http://lkml.org/lkml/2015/5/14/533 Julien Grall (2): net/xen-netfront: Correct printf format in xennet_get_responses net/xen-netback: Remove unused

Re: [Xen-devel] [RFC 23/23] arm/xen: Add support for 64KB page granularity

2015-06-23 Thread Julien Grall
then: What about xen_remap_domain_mfn_array? I guess we don't support that use case on 64K guests? If so, I would appreaciate an assert and/or an error message. See https://lkml.org/lkml/2015/5/14/563 -- Julien Grall -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [RFC 23/23] arm/xen: Add support for 64KB page granularity

2015-06-23 Thread Julien Grall
this will be really useful. Feel free to send a patch for it. Regards, -- Julien Grall -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [Xen-devel] [RFC 09/23] arm/xen: Drop duplicate define mfn_to_virt

2015-06-23 Thread Julien Grall
Hi, On 23/06/15 14:25, Stefano Stabellini wrote: On Thu, 14 May 2015, Julien Grall wrote: From: Julien Grall julien.gr...@linaro.org Signed-off-by: Julien Grall julien.gr...@citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Reviewed-by: Stefano Stabellini stefano.stabell

Re: [Xen-devel] [RFC 22/23] xen/privcmd: Add support for Linux 64KB page granularity

2015-06-18 Thread Julien Grall
Hi David, On 19/05/15 16:39, David Vrabel wrote: On 14/05/15 18:01, Julien Grall wrote: The hypercall interface (as well as the toolstack) is always using 4KB page granularity. When the toolstack is asking for mapping a series of guest PFN in a batch, it expects to have the page map

[PATCH v4 2/3] net/xen-netback: Remove unused code in xenvif_rx_action

2015-06-16 Thread Julien Grall
The variables old_req_cons and ring_slots_used are assigned but never used since commit 1650d5455bd2dc6b5ee134bd6fc1a3236c266b5b xen-netback: always fully coalesce guest Rx packets. Signed-off-by: Julien Grall julien.gr...@citrix.com Acked-by: Wei Liu wei.l...@citrix.com Cc: Ian Campbell

[PATCH v4 1/3] net/xen-netfront: Correct printf format in xennet_get_responses

2015-06-16 Thread Julien Grall
rx-status is an int16_t, print it using %d rather than %u in order to have a meaningful value when the field is negative. Also use %u rather than %x for rx-offset. Signed-off-by: Julien Grall julien.gr...@citrix.com Reviewed-by: David Vrabel david.vra...@citrix.com Cc: Konrad Rzeszutek Wilk

[PATCH v4 0/3] net/xen: Clean up

2015-06-16 Thread Julien Grall
Hi, The first 2 patches was originally part of the the Xen 64KB series [1]. Although, I think they can go, assuming everything will be acked/reviewed, without waiting the rest of the 64KB series. The third patch as been added in this version. Regards, Julien Grall (3): net/xen-netfront

[PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format

2015-06-16 Thread Julien Grall
Append 0x to all %x in order to avoid while reading when there is other decimal value in the log. Also replace some of the hexadecimal print to decimal to uniformize the format with netfront. Signed-off-by: Julien Grall julien.gr...@citrix.com Cc: Wei Liu wei.l...@citrix.com Cc: Ian Campbell

[PATCH v5 2/3] net/xen-netback: Remove unused code in xenvif_rx_action

2015-06-17 Thread Julien Grall
The variables old_req_cons and ring_slots_used are assigned but never used since commit 1650d5455bd2dc6b5ee134bd6fc1a3236c266b5b xen-netback: always fully coalesce guest Rx packets. Signed-off-by: Julien Grall julien.gr...@citrix.com Acked-by: Wei Liu wei.l...@citrix.com Cc: Ian Campbell

[PATCH v5 1/3] net/xen-netfront: Correct printf format in xennet_get_responses

2015-06-17 Thread Julien Grall
rx-status is an int16_t, print it using %d rather than %u in order to have a meaningful value when the field is negative. Also use %u rather than %x for rx-offset. Signed-off-by: Julien Grall julien.gr...@citrix.com Reviewed-by: David Vrabel david.vra...@citrix.com Cc: Konrad Rzeszutek Wilk

[PATCH v5 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format

2015-06-17 Thread Julien Grall
Prepend 0x to all %x in order to avoid confusion while reading when there is other decimal value in the log. Also replace some of the hexadecimal print to decimal to uniformize the format with netfront. Signed-off-by: Julien Grall julien.gr...@citrix.com Acked-by: Ian Campbell ian.campb

[PATCH v5 0/3] net/xen: Clean up

2015-06-17 Thread Julien Grall
david.vra...@citrix.com Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com Cc: Boris Ostrovsky boris.ostrov...@oracle.com Cc: net...@vger.kernel.org [1] http://lkml.org/lkml/2015/5/14/533 Julien Grall (3): net/xen-netfront: Correct printf format in xennet_get_responses net/xen-netback: Remove unused

Re: [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format

2015-06-17 Thread Julien Grall
Hi Ian, On 17/06/2015 10:25, Ian Campbell wrote: On Tue, 2015-06-16 at 20:10 +0100, Julien Grall wrote: Append 0x to all %x in order to avoid while reading when there is other decimal value in the log. Also replace some of the hexadecimal print to decimal to uniformize the format

[PATCH v2 3/7] xen/grant-table: Remove unused macro SPP

2015-06-17 Thread Julien Grall
SPP was used by the grant table v2 code which has been removed in commit 438b33c7145ca8a5131a30c36d8f59bce119a19a xen/grant-table: remove support for V2 tables. Signed-off-by: Julien Grall julien.gr...@citrix.com Reviewed-by: David Vrabel david.vra...@citrix.com Cc: Konrad Rzeszutek Wilk konrad.w

[PATCH v2 5/7] block/xen-blkfront: Remove unused macro MAXIMUM_OUTSTANDING_BLOCK_REQS

2015-06-17 Thread Julien Grall
From: Julien Grall julien.gr...@linaro.org Signed-off-by: Julien Grall julien.gr...@citrix.com Acked-by: Roger Pau Monné roger@citrix.com Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com Cc: Boris Ostrovsky boris.ostrov...@oracle.com Cc: David Vrabel david.vra...@citrix.com --- Changes

[PATCH v2 4/7] arm/xen: Drop duplicate define mfn_to_virt

2015-06-17 Thread Julien Grall
From: Julien Grall julien.gr...@linaro.org Signed-off-by: Julien Grall julien.gr...@citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com --- arch/arm/include/asm/xen/page.h | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/include/asm/xen/page.h b/arch/arm/include/asm/xen

[PATCH v2 2/7] xen/xenbus: client: Fix call of virt_to_mfn in xenbus_grant_ring

2015-06-17 Thread Julien Grall
don't use it later. Signed-off-by: Julien Grall julien.gr...@citrix.com Reviewed-by: David Vrabel david.vra...@citrix.com Cc: Wei Liu wei.l...@citrix.com Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com Cc: Boris Ostrovsky boris.ostrov...@oracle.com --- Changes in v2: - Remove the cast

[PATCH v2 0/7] xen: Clean up

2015-06-17 Thread Julien Grall
stefano.stabell...@eu.citrix.com Cc: Wei Liu wei.l...@citrix.com Julien Grall (7): xen: Include xen/page.h rather than asm/xen/page.h xen/xenbus: client: Fix call of virt_to_mfn in xenbus_grant_ring xen/grant-table: Remove unused macro SPP arm/xen: Drop duplicate define mfn_to_virt block

[PATCH v2 1/7] xen: Include xen/page.h rather than asm/xen/page.h

2015-06-17 Thread Julien Grall
Using xen/page.h will be necessary later for using common xen page helpers. As xen/page.h already include asm/xen/page.h, always use the later. Signed-off-by: Julien Grall julien.gr...@citrix.com Reviewed-by: David Vrabel david.vra...@citrix.com Cc: Stefano Stabellini stefano.stabell

[PATCH v2 7/7] block/xen-blkback: s/nr_pages/nr_segs/

2015-06-17 Thread Julien Grall
From: Julien Grall julien.gr...@linaro.org Make the code less confusing to read now that Linux may not have the same page size as Xen. Signed-off-by: Julien Grall julien.gr...@citrix.com Acked-by: Roger Pau Monné roger@citrix.com Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com

[PATCH v2 6/7] block/xen-blkfront: Remove invalid comment

2015-06-17 Thread Julien Grall
From: Julien Grall julien.gr...@linaro.org Since commit b764915 xen-blkfront: use a different scatterlist for each request, biovec has been replaced by scatterlist when copying back the data during a completion request. Signed-off-by: Julien Grall julien.gr...@citrix.com Acked-by: Roger Pau

Re: [Xen-devel] [PATCH v2 1/2] net/xen-netfront: Correct printf format in xennet_get_responses

2015-06-04 Thread Julien Grall
On 04/06/15 13:46, David Vrabel wrote: On 04/06/15 13:45, Julien Grall wrote: On 03/06/15 18:06, Joe Perches wrote: On Wed, 2015-06-03 at 17:55 +0100, Julien Grall wrote: rx-status is an int16_t, print it using %d rather than %u in order to have a meaningful value when the field is negative

Re: [PATCH v2 1/2] net/xen-netfront: Correct printf format in xennet_get_responses

2015-06-04 Thread Julien Grall
On 03/06/15 18:06, Joe Perches wrote: On Wed, 2015-06-03 at 17:55 +0100, Julien Grall wrote: rx-status is an int16_t, print it using %d rather than %u in order to have a meaningful value when the field is negative. [] diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c

[PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6

2015-07-03 Thread Julien Grall
netdevice using ipv6 and bridge. Spotted while trying to destroy a Xen guest on the upstream Linux: unregister_netdevice: waiting for vif1.0 to become free. Usage count = 1 Signed-off-by: Julien Grall julien.gr...@citrix.com Cc: Bernhard Thaler bernhard.tha...@wvnet.at Cc: Pablo Neira Ayuso pa

Re: [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6

2015-07-06 Thread Julien Grall
Hi, On 03/07/15 21:42, Florian Westphal wrote: Julien Grall julien.gr...@citrix.com wrote: The commit efb6de9b4ba0092b2c55f6a52d16294a8a698edd netfilter: bridge: forward IPv6 fragmented packets introduced a new function br_validate_ipv6 which take a reference on the inet6 device. Although

Re: [Xen-devel] [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6

2015-07-06 Thread Julien Grall
On 06/07/15 12:19, Florian Westphal wrote: Julien Grall julien.gr...@citrix.com wrote: On 03/07/15 21:42, Florian Westphal wrote: I think it makes more sense to use __in6_dev_get() instead which doesn't take a reference. __in6_dev_get requires to hold rcu_read_lock or RTNL. My knowledge

Re: [Xen-devel] [RFC 21/23] net/xen-netback: Make it running on 64KB page granularity

2015-05-20 Thread Julien Grall
On 19/05/15 23:56, Julien Grall wrote: If you're wgetting from another host, I would suggest wgetting from Dom0 to limit the problem between Dom0 and DomU. Thanks to Wei, I was able to narrow the problem. It looks like the problem is not coming from netback but somewhere else down

Re: [Xen-devel] [RFC 21/23] net/xen-netback: Make it running on 64KB page granularity

2015-05-20 Thread Julien Grall
On 20/05/15 09:26, Wei Liu wrote: On Tue, May 19, 2015 at 11:56:39PM +0100, Julien Grall wrote: diff --git a/drivers/net/xen-netback/common.h b/drivers/net/xen-netback/common.h index 0eda6e9..c2a5402 100644 --- a/drivers/net/xen-netback/common.h +++ b/drivers/net/xen-netback/common.h

Re: [Xen-devel] [PATCH v4 2/2] xen/block: add multi-page ring support

2015-05-20 Thread Julien Grall
On 20/05/15 15:56, Roger Pau Monné wrote: El 20/05/15 a les 15.21, Julien Grall ha escrit: Hi, On 20/05/15 14:10, Bob Liu wrote: --- drivers/block/xen-blkback/blkback.c | 12 drivers/block/xen-blkback/common.h | 3 +- drivers/block/xen-blkback/xenbus.c | 85

Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page()

2015-08-19 Thread Julien Grall
is not enabled on my config. Reviewed-by: Julien Grall julien.gr...@citrix.com Regards, -- Julien Grall -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Xen-devel] [PATCH v3 00/20] xen/arm64: Add support for 64KB page

2015-08-19 Thread Julien Grall
. Regards, On 07/08/2015 09:46, Julien Grall wrote: Hi all, ARM64 Linux is supporting both 4KB and 64KB page granularity. Although, Xen hypercall interface and PV protocol are always based on 4KB page granularity. Any attempt to boot a Linux guest with 64KB pages enabled will result to a guest

Re: [Xen-devel] [PATCH v3 00/20] xen/arm64: Add support for 64KB page

2015-08-20 Thread Julien Grall
On 20/08/2015 03:11, David Vrabel wrote: On 20/08/15 01:40, Julien Grall wrote: Hi, Ping? I'm missing some reviews on block and netfront code. We'd like to see this series going in Linux 4.3. Some distributions plans to use this version for aarch64 support. If we miss it, we won't have any

[PATCH v3] xen/events: Support event channel rebind on ARM

2015-07-28 Thread Julien Grall
or not. It will always return 1 on ARM and keep the same behavior on x86. This is also allow us to drop the usage of xen_have_vector_callback entirely in the ARM code. Signed-off-by: Julien Grall julien.gr...@citrix.com Reviewed-by: David Vrabel david.vra...@citrix.com Cc: Stefano Stabellini stefano.stabell

[PATCH 2/8] xen: Make clear that swiotlb and biomerge are dealing with DMA address

2015-07-28 Thread Julien Grall
foreign page and another using Linux memory. Lastly, the helper mfn_to_local_pfn has been renamed to dnf_to_local_pfn given that the only usage was in swiotlb. Signed-off-by: Julien Grall julien.gr...@citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Russell King li

[PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-28 Thread Julien Grall
it. [1] Xen tree: e758ed14f390342513405dd766e874934573e6cb Signed-off-by: Julien Grall julien.gr...@citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Russell King li...@arm.linux.org.uk Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com Cc: Boris Ostrovsky boris.ostrov...@oracle.com

[PATCH 1/8] arm/xen: Remove helpers which are PV specific

2015-07-28 Thread Julien Grall
arbitrary_virt_to_machine is only used in PV specific code. Therefore we should never call the function. Add a BUG() in this helper and drop all the others. Signed-off-by: Julien Grall julien.gr...@citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Russell King li...@arm.linux.org.uk

[PATCH 5/8] xen/tmem: Use page_to_gfn rather than pfn_to_gfn

2015-07-28 Thread Julien Grall
All the caller of xen_tmem_{get,put}_page have a struct page * in hand and call pfn_to_gfn for the only benefits of these 2 functions. Rather than passing the pfn in parameter, pass directly the page and use directly page_to_gfn. Signed-off-by: Julien Grall julien.gr...@citrix.com Cc: Konrad

[PATCH 7/8] hvc/xen: Further s/MFN/GFN clean-up

2015-07-28 Thread Julien Grall
HVM_PARAM_CONSOLE_PFN is used to retrieved the console PFN for HVM guest. It returns a PFN (aka GFN) and not a MFN. Furthermore, use directly virt_to_gfn for both PV and HVM domain rather than doing a special case for each of the them. Signed-off-by: Julien Grall julien.gr...@citrix.com Cc: Greg

[PATCH 8/8] xen/privcmd: Further s/MFN/GFN/ clean-up

2015-07-28 Thread Julien Grall
foreign change has been left unchanged given that the userspace is using it. Nonetheless, add a comment to explain the expected value within the mfn field. Signed-off-by: Julien Grall julien.gr...@citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Russell King li...@arm.linux.org.uk

Re: [Xen-devel] [PATCH 2/8] xen: Make clear that swiotlb and biomerge are dealing with DMA address

2015-07-28 Thread Julien Grall
Hi David, On 28/07/15 16:52, David Vrabel wrote: On 28/07/15 16:02, Julien Grall wrote: +/* Pseudo-physical - DMA conversion */ +static inline unsigned long pfn_to_dfn(unsigned long pfn) Use BFN for bus frame number. This is the terminology that is used in the (proposed) pv-iommu

[PATCH 3/8] arm/xen: implement correctly pfn_to_mfn

2015-07-28 Thread Julien Grall
to rename pfn_to_mfn to a suitable name. Signed-off-by: Julien Grall julien.gr...@citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Russell King li...@arm.linux.org.uk Cc: linux-arm-ker...@lists.infradead.org --- arch/arm/include/asm/xen/page.h | 8 1 file changed, 8

[PATCH 0/8] Use correctly the Xen memory terminologies in Linux

2015-07-28 Thread Julien Grall
roger@citrix.com Cc: Russell King li...@arm.linux.org.uk Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Thomas Gleixner t...@linutronix.de Cc: Tomi Valkeinen tomi.valkei...@ti.com Cc: Wei Liu wei.l...@citrix.com Cc: x...@kernel.org Julien Grall (8): arm/xen: Remove helpers which

[PATCH 6/8] video/xen-fbfront: Further s/MFN/GFN clean-up

2015-07-28 Thread Julien Grall
The PV driver xen-fbfront is only dealing with GFN and not MFN. Rename all the occurence of MFN to GFN. Also take the opportunity to replace to usage of pfn_to_gfn by page_to_pfn. Signed-off-by: Julien Grall julien.gr...@citrix.com Cc: Jean-Christophe Plagniol-Villard plagn...@jcrosoft.com Cc

Re: [PATCH 0/8] Use correctly the Xen memory terminologies in Linux

2015-07-29 Thread Julien Grall
On 28/07/15 16:02, Julien Grall wrote: Hi all, This patch series aims to use the memory terminologies described in include/linux/mm.h [1] for Linux xen code. I mistakenly wrote the wrong include here. It should be include/xen/mm.h from the Xen tree: http://xenbits.xen.org/gitweb/?p=xen.git

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread Julien Grall
I'd suggest ...replace any reference to mfn with gfn... [...] Thanks for telling me the typoes. I will fix it in the next version of this series. Regards, -- Julien Grall -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread Julien Grall
Hi Boris, On 28/07/15 20:12, Boris Ostrovsky wrote: On 07/28/2015 11:02 AM, Julien Grall wrote: Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant, I suspect this is because the first support for Xen was for PV. This brough some misimplementation of helpers on ARM

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread Julien Grall
Hi Wei, On 29/07/15 11:13, Wei Liu wrote: On Tue, Jul 28, 2015 at 04:02:45PM +0100, Julien Grall wrote: [...] diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 7d50711..3b7b7c3 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread Julien Grall
On 28/07/15 18:16, David Vrabel wrote: On 28/07/15 16:02, Julien Grall wrote: Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant, I suspect this is because the first support for Xen was for PV. This brough some misimplementation of helpers on ARM and make

Re: [PATCH v2 2/8] xen: Make clear that swiotlb and biomerge are dealing with DMA address

2015-08-05 Thread Julien Grall
sending the patch. I will fix it in the next version. Aside from those and the commit message error: Reviewed-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Thank you! Regards, -- Julien Grall -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Julien Grall
Hi Boris, On 05/08/15 00:16, Boris Ostrovsky wrote: On 08/04/2015 02:12 PM, Julien Grall wrote: /* * We detect special mappings in one of two ways: @@ -217,9 +232,13 @@ static inline unsigned long bfn_to_local_pfn(unsigned long mfn) /* VIRT - MACHINE conversion */ #define

Re: [Xen-devel] [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Julien Grall
On 05/08/15 13:19, Boris Ostrovsky wrote: On 08/05/2015 06:51 AM, Julien Grall wrote: diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c index 09dc447..25e3cce 100644 --- a/drivers/video/fbdev/xen-fbfront.c +++ b/drivers/video/fbdev/xen-fbfront.c @@ -539,7

Re: [Xen-devel] [PATCH v2 02/20] xen: Introduce a function to split a Linux page into Xen page

2015-08-05 Thread Julien Grall
Hi David, On 24/07/15 11:10, David Vrabel wrote: On 24/07/15 10:54, Julien Grall wrote: On 24/07/15 10:31, David Vrabel wrote: On 09/07/15 21:42, Julien Grall wrote: The Xen interface is always using 4KB page. This means that a Linux page may be split across multiple Xen page when the page

Re: [Xen-devel] [PATCH v2 02/20] xen: Introduce a function to split a Linux page into Xen page

2015-08-05 Thread Julien Grall
concept. Regards, -- Julien Grall -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread Julien Grall
mfn == gfn */ for every use of mfn = pfn_to_gfn(...). Regards, -- Julien Grall -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [Xen-devel] [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-06 Thread Julien Grall
Hi, On 04/08/15 19:12, Julien Grall wrote: diff --git a/include/xen/page.h b/include/xen/page.h index c5ed20b..e7e1425 100644 --- a/include/xen/page.h +++ b/include/xen/page.h @@ -3,9 +3,9 @@ #include asm/xen/page.h -static inline unsigned long page_to_mfn(struct page *page

Re: [Xen-devel] [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-06 Thread Julien Grall
On 06/08/15 12:06, Stefano Stabellini wrote: On Thu, 6 Aug 2015, Julien Grall wrote: Hi, On 04/08/15 19:12, Julien Grall wrote: diff --git a/include/xen/page.h b/include/xen/page.h index c5ed20b..e7e1425 100644 --- a/include/xen/page.h +++ b/include/xen/page.h @@ -3,9 +3,9

[PATCH v2 2/8] xen: Make clear that swiotlb and biomerge are dealing with DMA address

2015-08-04 Thread Julien Grall
foreign page and another using Linux memory. Lastly, the helper mfn_to_local_pfn has been renamed to dnf_to_local_pfn given that the only usage was in swiotlb. Signed-off-by: Julien Grall julien.gr...@citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Russell King li

[PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-04 Thread Julien Grall
complex clean up will come in follow-up patches. [1] http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=e758ed14f390342513405dd766e874934573e6cb Signed-off-by: Julien Grall julien.gr...@citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Russell King li...@arm.linux.org.uk Cc

[PATCH v2 6/8] video/xen-fbfront: Further s/MFN/GFN clean-up

2015-08-04 Thread Julien Grall
The PV driver xen-fbfront is only dealing with GFN and not MFN. Rename all the occurence of MFN to GFN. Also take the opportunity to replace to usage of pfn_to_gfn by page_to_pfn. Signed-off-by: Julien Grall julien.gr...@citrix.com Reviewed-by: David Vrabel david.vra...@citrix.com Cc: Jean

[PATCH v2 7/8] hvc/xen: Further s/MFN/GFN clean-up

2015-08-04 Thread Julien Grall
HVM_PARAM_CONSOLE_PFN is used to retrieved the console PFN for HVM guest. It returns a PFN (aka GFN) and not a MFN. Furthermore, use directly virt_to_gfn for both PV and HVM domain rather than doing a special case for each of the them. Signed-off-by: Julien Grall julien.gr...@citrix.com Reviewed

[PATCH v2 3/8] arm/xen: implement correctly pfn_to_mfn

2015-08-04 Thread Julien Grall
to rename pfn_to_mfn to a suitable name. Signed-off-by: Julien Grall julien.gr...@citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Russell King li...@arm.linux.org.uk Cc: linux-arm-ker...@lists.infradead.org --- arch/arm/include/asm/xen/page.h | 8 1 file changed, 8

[PATCH v2 1/8] arm/xen: Remove helpers which are PV specific

2015-08-04 Thread Julien Grall
is only used in PV specific code. Therefore we should never call the function. Add a BUG() in this helper and drop all the others. Signed-off-by: Julien Grall julien.gr...@citrix.com Acked-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Russell King li...@arm.linux.org.uk Cc: linux-arm

Re: [Xen-devel] [PATCH 1/8] arm/xen: Remove helpers which are PV specific

2015-08-04 Thread Julien Grall
I really meant to say was that assimilated doesn't make sense in this context either. I think maybe what was meant is ARM guests are always HVM. Yes. I will update the commit message too. Regards, -- Julien Grall -- To unsubscribe from this list: send the line unsubscribe linux-kernel

[PATCH v2 0/8] Use correctly the Xen memory terminologies in Linux

2015-08-04 Thread Julien Grall
...@citrix.com Cc: x...@kernel.org Julien Grall (8): arm/xen: Remove helpers which are PV specific xen: Make clear that swiotlb and biomerge are dealing with DMA address arm/xen: implement correctly pfn_to_mfn xen: Use the correctly the Xen memory terminologies xen/tmem: Use page_to_gfn rather

[PATCH v2 8/8] xen/privcmd: Further s/MFN/GFN/ clean-up

2015-08-04 Thread Julien Grall
foreign change has been left unchanged given that the userspace is using it. Nonetheless, add a comment to explain the expected value within the mfn field. Signed-off-by: Julien Grall julien.gr...@citrix.com Reviewed-by: David Vrabel david.vra...@citrix.com Cc: Stefano Stabellini stefano.stabell

[PATCH v2 5/8] xen/tmem: Use page_to_gfn rather than pfn_to_gfn

2015-08-04 Thread Julien Grall
All the caller of xen_tmem_{get,put}_page have a struct page * in hand and call pfn_to_gfn for the only benefits of these 2 functions. Rather than passing the pfn in parameter, pass directly the page and use directly page_to_gfn. Signed-off-by: Julien Grall julien.gr...@citrix.com Cc: Konrad

[PATCH v3 8/9] xen/privcmd: Further s/MFN/GFN/ clean-up

2015-08-07 Thread Julien Grall
foreign change has been left unchanged given that the userspace is using it. Nonetheless, add a comment to explain the expected value within the mfn field. Signed-off-by: Julien Grall julien.gr...@citrix.com Reviewed-by: David Vrabel david.vra...@citrix.com --- Cc: Stefano Stabellini stefano.stabell

[PATCH v3 0/9] Use correctly the Xen memory terminologies

2015-08-07 Thread Julien Grall
...@vger.kernel.org Cc: Roger Pau Monné roger@citrix.com Cc: Russell King li...@arm.linux.org.uk Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Thomas Gleixner t...@linutronix.de Cc: Tomi Valkeinen tomi.valkei...@ti.com Cc: Wei Liu wei.l...@citrix.com Cc: x...@kernel.org Julien Grall (9

[PATCH v3 9/9] xen/xenbus: Rename the variable xen_store_mfn to xen_store_gfn

2015-08-07 Thread Julien Grall
The variable xen_store_mfn is effectively storing a GFN and not an MFN. Signed-off-by: Julien Grall julien.gr...@citrix.com --- Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com Cc: Boris Ostrovsky boris.ostrov...@oracle.com Cc: David Vrabel david.vra...@citrix.com I think

[PATCH v3 6/9] video/xen-fbfront: Further s/MFN/GFN clean-up

2015-08-07 Thread Julien Grall
The PV driver xen-fbfront is only dealing with GFN and not MFN. Rename all the occurence of MFN to GFN. Also take the opportunity to replace to usage of pfn_to_gfn by xen_page_to_gfn. Signed-off-by: Julien Grall julien.gr...@citrix.com Reviewed-by: David Vrabel david.vra...@citrix.com --- Cc

[PATCH v3 4/9] xen: Use correctly the Xen memory terminologies

2015-08-07 Thread Julien Grall
also the opportunity to simplify simple construction such as pfn_to_mfn(page_to_pfn(page)) into xen_page_to_gfn. More complex clean up will come in follow-up patches. [1] http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=e758ed14f390342513405dd766e874934573e6cb Signed-off-by: Julien Grall

[PATCH v3 1/9] arm/xen: Remove helpers which are PV specific

2015-08-07 Thread Julien Grall
is only used in PV specific code. Therefore we should never call the function. Add a BUG() in this helper and drop all the others. Signed-off-by: Julien Grall julien.gr...@citrix.com Acked-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- Cc: Russell King li...@arm.linux.org.uk Cc: linux

Re: [Xen-devel] [PATCH v5 0/6] xen/PMU: PMU support for Xen PV(H) guests

2015-08-07 Thread Julien Grall
-function-declaration] ret = HYPERVISOR_dom0_op(xs-op); ^ DOM0 op doesn't exists for ARM and xensyms is not even plumbed. I would make sure that XEN_SYMS is not enabled for ARM maybe adding the line below in the kconfig? depends on X86 XEN_DOM0 XENFS Regards, -- Julien Grall

[PATCH v3 7/9] hvc/xen: Further s/MFN/GFN clean-up

2015-08-07 Thread Julien Grall
HVM_PARAM_CONSOLE_PFN is used to retrieved the console PFN for HVM guest. It returns a PFN (aka GFN) and not a MFN. Furthermore, use directly virt_to_gfn for both PV and HVM domain rather than doing a special case for each of the them. Signed-off-by: Julien Grall julien.gr...@citrix.com Reviewed

[PATCH v3 2/9] xen: Make clear that swiotlb and biomerge are dealing with DMA address

2015-08-07 Thread Julien Grall
foreign page and another using Linux memory. Lastly, the helper mfn_to_local_pfn has been renamed to bfn_to_local_pfn given that the only usage was in swiotlb. Signed-off-by: Julien Grall julien.gr...@citrix.com Reviewed-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- Cc: Russell King

[PATCH v3 5/9] xen/tmem: Use xen_page_to_gfn rather than pfn_to_gfn

2015-08-07 Thread Julien Grall
All the caller of xen_tmem_{get,put}_page have a struct page * in hand and call pfn_to_gfn for the only benefits of these 2 functions. Rather than passing the pfn in parameter, pass directly the page and use directly xen_page_to_gfn. Signed-off-by: Julien Grall julien.gr...@citrix.com Reviewed

[PATCH v3 3/9] arm/xen: implement correctly pfn_to_mfn

2015-08-07 Thread Julien Grall
to rename pfn_to_mfn to a suitable name. Signed-off-by: Julien Grall julien.gr...@citrix.com Reviewed-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- Cc: Russell King li...@arm.linux.org.uk Cc: linux-arm-ker...@lists.infradead.org Changes in v3: - Typoes in the commit

[PATCH v3 14/20] xen/grant-table: Make it running on 64KB granularity

2015-08-07 Thread Julien Grall
with multiple grant. It will require some care with the {Set,Clear}ForeignPage macro. Note that no changes has been made in the x86 code because both Linux and Xen will only use 4KB page granularity. Signed-off-by: Julien Grall julien.gr...@citrix.com Reviewed-by: David Vrabel david.vra...@citrix.com Reviewed

[PATCH v3 18/20] net/xen-netback: Make it running on 64KB page granularity

2015-08-07 Thread Julien Grall
on the grant table code. Signed-off-by: Julien Grall julien.gr...@citrix.com --- Cc: Ian Campbell ian.campb...@citrix.com Cc: Wei Liu wei.l...@citrix.com Cc: net...@vger.kernel.org Improvement such as support of 64KB grant is not taken into consideration in this patch because we have

[PATCH v3 11/20] tty/hvc: xen: Use xen page definition

2015-08-07 Thread Julien Grall
The console ring is always based on the page granularity of Xen. Signed-off-by: Julien Grall julien.gr...@citrix.com Reviewed-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Jiri Slaby jsl...@suse.cz Cc: David Vrabel david.vra

[PATCH v3 02/20] arm/xen: Drop pte_mfn and mfn_pte

2015-08-07 Thread Julien Grall
They are not used in common code expect in one place in balloon.c which is only compiled when Linux is using PV MMU. It's not the case on ARM. Rather than worrying how to handle the 64KB case, drop them. Signed-off-by: Julien Grall julien.gr...@citrix.com --- Stefano Stabellini stefano.stabell

Re: [Xen-devel] [PATCH v3 00/20] xen/arm64: Add support for 64KB page

2015-08-07 Thread Julien Grall
On 07/08/15 17:46, Julien Grall wrote: Hi all, ARM64 Linux is supporting both 4KB and 64KB page granularity. Although, Xen hypercall interface and PV protocol are always based on 4KB page granularity. Any attempt to boot a Linux guest with 64KB pages enabled will result to a guest crash

[PATCH v3 06/20] block/xen-blkfront: Split blkif_queue_request in 2

2015-08-07 Thread Julien Grall
execution path, separate the function in 2. This will also remove one level of tabulation. Signed-off-by: Julien Grall julien.gr...@citrix.com Reviewed-by: Roger Pau Monné roger@citrix.com --- Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com Cc: Boris Ostrovsky boris.ostrov...@oracle.com Cc

[PATCH v3 01/20] net/xen-netback: xenvif_gop_frag_copy: move GSO check out of the loop

2015-08-07 Thread Julien Grall
The skb doesn't change within the function. Therefore it's only necessary to check if we need GSO once at the beginning. Signed-off-by: Julien Grall julien.gr...@citrix.com --- Cc: Ian Campbell ian.campb...@citrix.com Cc: Wei Liu wei.l...@citrix.com Cc: net...@vger.kernel.org Changes in v2

[PATCH v3 04/20] xen/grant: Introduce helpers to split a page into grant

2015-08-07 Thread Julien Grall
the compilation. Furthermore, only definition in interface/grant_table.h was required. Signed-off-by: Julien Grall julien.gr...@citrix.com --- Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com Cc: Boris Ostrovsky boris.ostrov...@oracle.com Cc: David Vrabel david.vra...@citrix.com Cc: Thomas Gleixner t

[PATCH v3 07/20] block/xen-blkfront: Store a page rather a pfn in the grant structure

2015-08-07 Thread Julien Grall
All the usage of the field pfn are done using the same idiom: pfn_to_page(grant-pfn) This will return always the same page. Store directly the page in the grant to clean up the code. Signed-off-by: Julien Grall julien.gr...@citrix.com Acked-by: Roger Pau Monné roger@citrix.com Reviewed

[PATCH v3 03/20] xen: Add Xen specific page definition

2015-08-07 Thread Julien Grall
definition. They have exactly the same name but prefixed with XEN_/xen_ prefix. Also modify xen_page_to_gfn to use new Xen page definition. Signed-off-by: Julien Grall julien.gr...@citrix.com Reviewed-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- Cc: Konrad Rzeszutek Wilk konrad.w

[PATCH v3 00/20] xen/arm64: Add support for 64KB page

2015-08-07 Thread Julien Grall
be found here: git://xenbits.xen.org/people/julieng/linux-arm.git branch xen-64k-v3 Comments, suggestions are welcomed. Sincerely yours, Cc: david.vra...@citrix.com Cc: konrad.w...@oracle.com Cc: boris.ostrov...@oracle.com Cc: wei.l...@citrix.com Cc: roger@citrix.com Julien Grall (20): net/xen

[PATCH v3 17/20] net/xen-netfront: Make it running on 64KB page granularity

2015-08-07 Thread Julien Grall
on the grant table code. Note that we allocate a Linux page for each rx skb but only the first 4KB is used. We may improve the memory usage by extending the size of the rx skb. Signed-off-by: Julien Grall julien.gr...@citrix.com --- Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com Cc: Boris Ostrovsky

[PATCH v3 20/20] arm/xen: Add support for 64KB page granularity

2015-08-07 Thread Julien Grall
page even though only the first 4KB is used. I don't think this is really important for now as it helps to have the pointer 4KB aligned (XENMEM_add_to_physmap is taking a Xen PFN). Signed-off-by: Julien Grall julien.gr...@citrix.com --- Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc

[PATCH v3 16/20] block/xen-blkback: Make it running on 64KB page granularity

2015-08-07 Thread Julien Grall
on the grant table code. Note that the grant table code is allocating a Linux page per grant which will result to waste 6OKB for every grant when Linux is using 64KB page granularity. This could be improved by sharing the page between multiple grants. Signed-off-by: Julien Grall julien.gr

[PATCH v3 12/20] xen/balloon: Don't rely on the page granularity is the same for Xen and Linux

2015-08-07 Thread Julien Grall
of the extent_order field to directly allocate/free chunk of the Linux page size. Note that PVMMU is only used for PV guest (which is x86) and the page granularity is always 4KB. Some BUILD_BUG_ON has been added to ensure that because the code has not been modified. Signed-off-by: Julien Grall

[PATCH v3 05/20] xen/grant: Add helper gnttab_page_grant_foreign_access_ref_one

2015-08-07 Thread Julien Grall
which result to page_mfn not being defined when necessary. Signed-off-by: Julien Grall julien.gr...@linaro.org Reviewed-by: David Vrabel david.vra...@citrix.com Reviewed-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com Cc: Boris Ostrovsky

[PATCH v3 08/20] block/xen-blkfront: split get_grant in 2

2015-08-07 Thread Julien Grall
to copy data from persistent grant or indirect grant. Avoid to set it for other use case as it will have no meaning given the page will be split in multiple grant. Provide 2 functions, to setup indirect grant, the other for bio page. Signed-off-by: Julien Grall julien.gr...@citrix.com --- Cc

[PATCH v3 09/20] xen/biomerge: Don't allow biovec to be merge when Linux is not using 4KB page

2015-08-07 Thread Julien Grall
-off-by: Julien Grall julien.gr...@citrix.com --- Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com Cc: Boris Ostrovsky boris.ostrov...@oracle.com Cc: David Vrabel david.vra...@citrix.com There is some ideas to check whether two biovec could be merged (see [1]) but it's not critical and can

[PATCH v3 15/20] block/xen-blkfront: Make it running on 64KB page granularity

2015-08-07 Thread Julien Grall
granularity). Futhermore, in the case of persistent grant we allocate one Linux page per grant although only the 4KB of the page will be effectively use. This could be improved by share the page with multiple grants. Signed-off-by: Julien Grall julien.gr...@citrix.com --- Cc: Konrad Rzeszutek

[PATCH v3 19/20] xen/privcmd: Add support for Linux 64KB page granularity

2015-08-07 Thread Julien Grall
will have to map multiple Xen PFN in a single Linux page. Note that this solution works on page granularity which is a multiple of 4KB. Signed-off-by: Julien Grall julien.gr...@citrix.com --- Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com Cc: Boris Ostrovsky boris.ostrov...@oracle.com Cc: David

[PATCH v3 13/20] xen/events: fifo: Make it running on 64KB granularity

2015-08-07 Thread Julien Grall
chunk). That would require more care when we fail to expand the event channel. Signed-off-by: Julien Grall julien.gr...@citrix.com Reviewed-by: David Vrabel david.vra...@citrix.com Reviewed-by: Stefano Stabellini stefano.stabell...@citrix.com --- Cc: Konrad Rzeszutek Wilk konrad.w

<    1   2   3   4   5   6   7   8   9   10   >