[PATCH] ALSA: hda - Fixing background noise on Dell Inspiron 3162

) Vendor Id: 0x10ec0255 Subsystem Id: 0x10280725 Revision Id: 0x12 No Modem Function Group found BugLink: http://bugs.launchpad.net/bugs/1549620 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- sound/pci/hda/patch_realtek.c | 8 1 file changed, 8 inse

[PATCH] ALSA: hda - Fix headphone noise on Dell XPS 13 9360

-Heng Feng <kai.heng.f...@canonical.com> --- sound/pci/hda/patch_realtek.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 002f153..10ca900 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/p

[PATCH] ALSA: hda - Fix headphone noise on Dell XPS 13 9360

The headphone has noise when playing sound or switching microphone sources. It uses the same codec on XPS 13 9350, but with different subsystem ID. Applying the fixup can solve the issue. Also, changing the model name to better differentiate models. Signed-off-by: Kai-Heng Feng <kai.hen

[PATCH] Bluetooth: btusb: Add support for 0cf3:e009

=01 Prot=01 Driver=btusb I: If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/bluetooth/btusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index c

[PATCH] ALSA: hda - Enable subwoofer on Dell Inspiron 7559

The subwoofer on Inspiron 7559 does not work originally. Applying a pin fixup can make it work. Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- sound/pci/hda/patch_realtek.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sou

Re: [PATCH] ALSA: hda - Enable subwoofer on Dell Inspiron 7559

On Tue, Aug 30, 2016 at 1:33 PM, Takashi Iwai <ti...@suse.de> wrote: > On Tue, 30 Aug 2016 07:27:41 +0200, > Kai-Heng Feng wrote: >> >> The subwoofer on Inspiron 7559 does not work originally. >> Applying a pin fixup can make it work. >> >> Signed-off-by:

[PATCH v2] ALSA: hda - Enable subwoofer on Dell Inspiron 7559

The subwoofer on Inspiron 7559 was disabled originally. Applying a pin fixup to node 0x1b can enable it and make it work. Old pin: 0x41f0 New pin: 0x90170151 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- sound/pci/hda/patch_realtek.c | 11 +++ 1 file chang

Re: [PATCH] ALSA: hda - Enable subwoofer on Dell Inspiron 7559

On Tue, Aug 30, 2016 at 3:05 PM, Takashi Iwai <ti...@suse.de> wrote: > On Tue, 30 Aug 2016 08:25:18 +0200, > Kai Heng Feng wrote: >> >> On Tue, Aug 30, 2016 at 1:33 PM, Takashi Iwai <ti...@suse.de> wrote: >> > On Tue, 30 Aug 2016 07:27:41 +0200, >> >

[PATCH] HID: alps: fix stick device not working after resume

The stick device does not work after resume, add U1_SP_ABS_MODE flag can make the device work after resume. Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/hid/hid-alps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-al

Re: [PATCH] HID: alps: fix stick device not working after resume

On Mon, Sep 19, 2016 at 8:37 PM, Jiri Kosina <ji...@kernel.org> wrote: > On Mon, 19 Sep 2016, Kai-Heng Feng wrote: > >> The stick device does not work after resume, add U1_SP_ABS_MODE flag can >> make the device work after resume. > > Do you happen to have any more

Re: [PATCH] HID: alps: fix stick device not working after resume

On Wed, Sep 21, 2016 at 8:00 PM, Jiri Kosina <ji...@kernel.org> wrote: > On Mon, 19 Sep 2016, Kai Heng Feng wrote: > >> >> The stick device does not work after resume, add U1_SP_ABS_MODE flag can >> >> make the device work after resume. >> > >&

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

Hi, On Wed, Nov 9, 2016 at 8:32 PM, Bjørn Mork wrote: > Oliver Neukum writes: > >> On Tue, 2016-11-08 at 13:44 -0500, Alan Stern wrote: >> >>> These problems could very well be caused by running at SuperSpeed >>> (USB-3) instead of high speed (USB-2). Yes, it's

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

Hi, On Mon, Nov 7, 2016 at 7:02 PM, Oliver Neukum <oneu...@suse.com> wrote: > On Fri, 2016-11-04 at 17:57 +0800, Kai-Heng Feng wrote: >> Sometimes cdc_mbim failed to probe if runtime pm is enabled: >> [9.305626] cdc_mbim: probe of 2-2:1.12 failed with error -22 >

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

On Mon, Nov 14, 2016 at 3:34 PM, Kai-Heng Feng <kai.heng.f...@canonical.com> wrote: > On Fri, Nov 11, 2016 at 10:44 PM, Mathias Nyman > <mathias.ny...@linux.intel.com> wrote: >> On 10.11.2016 13:22, Oliver Neukum wrote: >>> >>> On Thu, 2016-11-10 at 12

[PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

Sometimes cdc_mbim failed to probe if runtime pm is enabled: [9.305626] cdc_mbim: probe of 2-2:1.12 failed with error -22 This can be solved by increase its pm usage counter. Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/net/usb/usbnet.c | 7 ++- 1 file c

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

[snip] > Let me explain it in more detail. rt5670 need to set a serious of > registers to prevent the pop noise of powering up/down muting/ > unmuting headphone. That's what rt5670_hp_event() does. But, > what rt286_hp_power_event do is only mute/unmute headphone > which is done by "HPO L" and

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

On Tue, Mar 21, 2017 at 11:07 AM, Bard Liao <bardl...@realtek.com> wrote: >> -Original Message----- >> From: Kai-Heng Feng [mailto:kai.heng.f...@canonical.com] >> Sent: Monday, March 20, 2017 11:59 AM >> To: broo...@kernel.org >> Cc: lgirdw...@gmail.co

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

On Tue, Mar 21, 2017 at 1:26 AM, Mark Brown <broo...@kernel.org> wrote: > On Tue, Mar 21, 2017 at 12:23:53AM +0800, Kai-Heng Feng wrote: >> On Tue, Mar 21, 2017 at 12:06 AM, Mark Brown <broo...@kernel.org> wrote: > >> > As it says there "...and inserted

[PATCH v2] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

in will produce a loud crack sound. Set AMP_OUT_MUTE before power events can make the noise less noticeable. Link: https://bugzilla.kernel.org/show_bug.cgi?id=112611 Link: https://bugzilla.redhat.com/show_bug.cgi?id=1313434 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- sou

[PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

/show_bug.cgi?id=112611 Link: https://bugzilla.redhat.com/show_bug.cgi?id=1313434 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- sound/soc/codecs/rt286.c | 48 +--- 1 file changed, 45 insertions(+), 3 deletions(-) diff --git a/sound/soc/

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

On Tue, Mar 21, 2017 at 12:06 AM, Mark Brown <broo...@kernel.org> wrote: > On Mon, Mar 20, 2017 at 03:46:13PM +0000, Kai-Heng Feng wrote: >> On Mon, Mar 20, 2017 at 11:08 PM Mark Brown <broo...@kernel.org> wrote: > >> > As covered in Submitt

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

On Tue, Mar 21, 2017 at 4:59 PM, Bard Liao <bardl...@realtek.com> wrote: >> -Original Message----- >> From: Kai-Heng Feng [mailto:kai.heng.f...@canonical.com] >> Sent: Tuesday, March 21, 2017 1:39 PM >> To: Bard Liao >> Cc: broo...@kernel.org; lgirdw.

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

On Tue, Mar 21, 2017 at 5:15 PM, Bard Liao <bardl...@realtek.com> wrote: >> -Original Message----- >> From: Kai-Heng Feng [mailto:kai.heng.f...@canonical.com] >> Sent: Tuesday, March 21, 2017 1:26 PM >> To: Mark Brown >> Cc: Liam Girdwood; Bard Liao; Ode

[PATCH] ACPI / blacklist: add _REV quirk for Dell Inspiron 7537

The battery can only be detected after AC power adapter event. Adding the machine to acpi_rev_dmi_table[] can workaround this issue. BugLink: https://bugs.launchpad.net/bugs/1678590 Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=105721 Signed-off-by: Kai-Heng Feng <kai.hen

[PATCH] Input: i8042 - add noloop quirk for Dell Embedded Box PC 3000

The aux port does not get detected without noloop quirk, so external PS/2 mouse cannot work as result. The PS/2 mouse can work with this quirk. BugLink: https://bugs.launchpad.net/bugs/1591053 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/input/serio/i8042-x86ia

[PATCH] usb: quirks: Add no-lpm quirk for Moshi USB to Ethernet Adapter

The Realtek r8153 ethernet does not work on Genesys Logic hub, no-lpm quirk can make it work. Since another r8153 dongle at my hand does not have the issue, so add the quirk to the hub instead. Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/usb/core/quirks.c | 3

[PATCH] usb: quirks: add delay init quirk for Corsair Strafe RGB keyboard

the quirk for Corsair Strafe RGB. BugLink: https://bugs.launchpad.net/bugs/1678477 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/usb/core/quirks.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c index 574da2

[PATCH] Input: elan_i2c - add ELAN0608 to the ACPI table

Similar to commit 722c5ac708b4f ("Input: elan_i2c - add ELAN0605 to the ACPI table"), ELAN0608 should be handled by elan_i2c. This touchpad can be found in Lenovo ideapad 320-14IKB. BugLink: https://bugs.launchpad.net/bugs/1708852 Signed-off-by: Kai-Heng Feng <kai.heng.f...@

Re: [PATCH] Input: i8042 - add Gigabyte P57 to the keyboard reset table

On Wed, Jul 12, 2017 at 11:39 AM, Kai-Heng Feng <kai.heng.f...@canonical.com> wrote: > Similar to other Gigabyte laptops, the touchpad on P57 requires a > keyboard reset to detect Elantech touchpad correctly. > > BugLink: https://bugs.launchpad.net/bugs/1594214 > Signed-

[PATCH] Input: i8042 - add Gigabyte P57 to the keyboard reset table

Similar to other Gigabyte laptops, the touchpad on P57 requires a keyboard reset to detect Elantech touchpad correctly. BugLink: https://bugs.launchpad.net/bugs/1594214 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/input/serio/i8042-x86ia64io.h | 7 +++

Re: [PATCH v2] usb: quirks: Add no-lpm quirk for Moshi USB to Ethernet Adapter

On Tue, Aug 8, 2017 at 4:28 PM, Oliver Neukum <oneu...@suse.com> wrote: > Am Dienstag, den 08.08.2017, 14:32 +0800 schrieb Kai-Heng Feng: >> Moshi USB to Ethernet Adapter internally uses a Genesys Logic hub to >> connect to Realtek r8153. >> >> The Rea

[PATCH v2] usb: quirks: Add no-lpm quirk for Moshi USB to Ethernet Adapter

-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v2: Clarify that the adapter uses a hub internally. drivers/usb/core/quirks.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c index 3116edfcdc18..c96daf34431e 100644 --- a/d

[PATCH v3] usb: quirks: Add no-lpm quirk for Moshi USB to Ethernet Adapter

instead. Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v3: Update comment to reflect the quirk is for the hub. v2: Clarify that the adapter uses a hub internally. drivers/usb/core/quirks.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/core/quirks.c b/d

Re: [PATCH] thunderbolt: icm: Remove Apple check for Alpine Ridge

On Mon, Aug 7, 2017 at 3:51 PM, Mika Westerberg wrote: > At this point we should find out that the ICM is already running and the > function never calls pci2cio_write(). I guess you mean this code section: /* Check if the ICM firmware is already running

Re: [PATCH] thunderbolt: icm: Remove Apple check for Alpine Ridge

On Mon, Aug 7, 2017 at 3:02 PM, Mika Westerberg <mika.westerb...@linux.intel.com> wrote: > On Mon, Aug 07, 2017 at 02:50:49PM +0800, Kai-Heng Feng wrote: >> On Mon, Aug 7, 2017 at 12:49 PM, Kai-Heng Feng >> <kai.heng.f...@canonical.com> wrote: >> > In icm_a

Re: [PATCH] usb: quirks: Add no-lpm quirk for Moshi USB to Ethernet Adapter

On Mon, Aug 7, 2017 at 5:08 PM, Oliver Neukum <oneu...@suse.com> wrote: > Am Freitag, den 04.08.2017, 17:34 +0800 schrieb Kai-Heng Feng: >> The Realtek r8153 ethernet does not work on Genesys Logic hub, no-lpm >> quirk can make it work. > > So can you confirm it works wi

Re: [PATCH] thunderbolt: icm: Remove Apple check for Alpine Ridge

On Mon, Aug 7, 2017 at 12:49 PM, Kai-Heng Feng <kai.heng.f...@canonical.com> wrote: > In icm_ar_is_supported(), icm->upstream_port will be uninitialized if > the hardware is not an Apple one. > > The uninitialized icm->upstream_port will later be dereferenced in > pcie

[PATCH] usb: xhci: Renesas uPD720202 needs short TX quirk

? [77122.622952] handle_tx_event: 541 callbacks suppressed No more warning messages with XHCI_TRUST_TX_LENGTH applied. BugLink: https://bugs.launchpad.net/bugs/1710548 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/usb/host/xhci-pci.c | 4 +++- 1 file changed, 3 inse

Re: [PATCH] usb: xhci: Renesas uPD720202 needs short TX quirk

Hi, On Fri, Aug 18, 2017 at 3:22 PM, Felipe Balbi <felipe.ba...@linux.intel.com> wrote: > > hi, > > Kai-Heng Feng <kai.heng.f...@canonical.com> writes: >> When plugging Logitech C920 webcam, warning messages filled up dmesg: >> [77117.655018] xhci_hcd

[PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller

-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/usb/host/ehci-pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c index 93326974ff4b..616685f83954 100644 --- a/drivers/usb/host/ehci-pci.c +++ b/drivers/usb/host/ehci

Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller

On Tue, Jun 20, 2017 at 2:32 AM, Alan Stern wrote: > > It's possible that the test was invalid. Kai-Heng did not say whether > /sys/.../power/wakeup was set to "enabled" for both the EHCI controller > and the USB root hub beneath it, before the test was started. If >

Re: [PATCH] PCI: Workaround AMD EHCI controller PME bug

On Tue, Jun 20, 2017 at 2:01 AM, Bjorn Helgaas wrote: > > Applied (patch below) to pci/pm for v4.13, thanks! > > Note that I added parens because bitwise NOT is higher precedence than > bitwise shift right, and I think we want the shift before the NOT. Please > double-check.

[PATCH v4] platform/x86: dell-laptop: Fix bogus keyboard backlight sysfs interface

is supported only when at least two modes are present. Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v4: Change commit log - not all models have ON token. v3: Change the logic, there should be at least two modes present to claim it supports backlight. Suggested by Pali Rohá

[PATCH] nvme: explicitly disable APST on quirked devices

ot;to enable apst", so we can use the latter one to explicitly disable APST at initialiaztion. BugLink: https://bugs.launchpad.net/bugs/1699004 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/nvme/host/core.c | 25 + drivers/nvme/hos

Re: [PATCH] nvme: explicitly disable APST on quirked devices

On Sat, Jun 24, 2017 at 1:17 AM, Andy Lutomirski <l...@kernel.org> wrote: > On Thu, Jun 22, 2017 at 11:19 PM, Kai-Heng Feng > <kai.heng.f...@canonical.com> wrote: >> A user reports APST is enabled, even when the NVMe is quirked or with >> option "default_ps_m

Re: [PATCH v2] nvme: explicitly disable APST on quirked devices

On Tue, Jun 27, 2017 at 2:05 AM, Andy Lutomirski <l...@kernel.org> wrote: > On Mon, Jun 26, 2017 at 12:01 AM, Kai-Heng Feng > <kai.heng.f...@canonical.com> wrote: >> A user reports APST is enabled, even when the NVMe is quirked or with >> option "default_ps_m

[PATCH v2] nvme: explicitly disable APST on quirked devices

ot;to enable apst", so we can use the latter one to explicitly disable APST at initialiaztion. BugLink: https://bugs.launchpad.net/bugs/1699004 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v2: - Remove unnecessary check on device state. - Correct apst_enabled valu

[PATCH] pinctrl: amd: don't load pinctrl-amd on Gigabyte AM4 boards

On Gigabyte AM4 boards, pinctrl-amd generates tons of irq, makes the system not able to boot properly. Don't load the module until Gigabyte fixes the issue. BugLink: https://bugs.launchpad.net/bugs/1671360 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/pinctrl/p

Re: [PATCH] pinctrl: amd: don't load pinctrl-amd on Gigabyte AM4 boards

On Fri, May 26, 2017 at 6:09 PM, Thomas Gleixner <t...@linutronix.de> wrote: > On Thu, 25 May 2017, Kai-Heng Feng wrote: > >> On Gigabyte AM4 boards, pinctrl-amd generates tons of irq, makes the >> system not able to boot properly. >> >> Don't load the m

[PATCH 2/2] nvme: relax APST default max latency to 100ms

: A400 NVMe SanDisk 512GB ps3 : mp:0.0500W non-operational enlat:51000 exlat:1 rrt:0 rrl:0 rwt:0 rwl:0 idle_power:- active_power:- ps4 : mp:0.0055W non-operational enlat:100 exlat:10 rrt:0 rrl:0 rwt:0 rwl:0 idle_power:- active_power:- Signed-off-by: Kai-Heng Feng

[PATCH 1/2] nvme: only consider exit latency when choosing useful non-op power states

deciding power states to trainsit to. Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/nvme/host/core.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 0f9cc0c55e15..c07d8d

Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller

On Wed, Jun 14, 2017 at 1:28 AM, Bjorn Helgaas wrote: > > The lspci output [1] shows: > > 00:12.0 USB controller: Advanced Micro Devices, Inc. [AMD] FCH USB EHCI > Controller (rev 39) (prog-if 20 [EHCI]) > Capabilities: [c0] Power Management version 2 > Flags:

Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller

On Thu, Jun 15, 2017 at 2:55 AM, Alan Stern <st...@rowland.harvard.edu> wrote: > On Tue, 13 Jun 2017, Bjorn Helgaas wrote: > >> [+cc Rafael, linux-pm] >> >> On Tue, Jun 13, 2017 at 12:21:15PM +0800, Kai-Heng Feng wrote: >> > On Mon, Jun 12, 2017 at 10:18 PM

Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller

On Fri, Jun 9, 2017 at 10:43 PM, Alan Stern <st...@rowland.harvard.edu> wrote: > On Fri, 9 Jun 2017, Kai-Heng Feng wrote: > >> As Alan Stern points out [1], the PME signal is not enabled when >> controller is in D3, therefore it's not being woken up when ne

[PATCH] platform/x86: dell-laptop: Fix bogus keyboard backlight sysfs interface

backlight. Reports keyboard backlight is supported only when tokens other than KBD_LED_OFF_TOKEN can be found. Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/platform/x86/dell-laptop.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/platfo

Re: [PATCH] platform/x86: dell-laptop: Fix bogus keyboard backlight sysfs interface

On Fri, Jun 16, 2017 at 3:52 PM, Pali Rohár wrote: > Should not this check to be rather: > > (kbd_token_bits != 0 && (kbd_token_bits & BIT(KBD_LED_OFF_TOKEN)) != > BIT(KBD_LED_OFF_TOKEN)) > > To express that we have at least one token at it is different from >

[PATCH] PCI: Workaround AMD EHCI controller PME bug

(Appendix A2) Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- arch/x86/pci/fixup.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/x86/pci/fixup.c b/arch/x86/pci/fixup.c index 6d52b94f4bb9..0f71a908e262 100644 --- a/arch/x86/pci/fixup.c +++ b/arch/x

Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller

On Thu, Jun 15, 2017 at 10:12 PM, Alan Stern <st...@rowland.harvard.edu> wrote: > On Thu, 15 Jun 2017, Kai-Heng Feng wrote: > >> On Wed, Jun 14, 2017 at 1:28 AM, Bjorn Helgaas <helg...@kernel.org> wrote: >> > >> > The lspci output [1] shows: >>

Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller

On Fri, Jun 16, 2017 at 11:07 AM, Kai-Heng Feng <kai.heng.f...@canonical.com> wrote: > On Thu, Jun 15, 2017 at 10:12 PM, Alan Stern <st...@rowland.harvard.edu> > wrote: >> Those documents refer to a hardware bug with a workaround in the BIOS. >> Have you checked to

Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller

On Sat, Jun 17, 2017 at 1:30 AM, Alan Stern <st...@rowland.harvard.edu> wrote: > On Sat, 17 Jun 2017, Kai-Heng Feng wrote: > >> On Fri, Jun 16, 2017 at 11:07 AM, Kai-Heng Feng >> <kai.heng.f...@canonical.com> wrote: >> > On Thu, Jun 15, 2017 at 10:12 PM

Re: [PATCH v2] platform/x86: dell-laptop: Fix bogus keyboard backlight sysfs interface

On Mon, Jun 19, 2017 at 3:57 PM, Pali Rohár <pali.ro...@gmail.com> wrote: > On Monday 19 June 2017 15:36:29 Kai-Heng Feng wrote: >> Dell Latitude 3160 does not have keyboard backlight, but there is a >> sysfs interface for it, which does nothing at all. >> >> KBD_L

[PATCH v2] platform/x86: dell-laptop: Fix bogus keyboard backlight sysfs interface

-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v2: The only token can be found is actually KBD_LED_ON_TOKEN, which is BIT(5), instead of KBD_LED_OFF_TOKEN. Change commit log accordingly. Use token bit to make the intention more clear. Also consider kbd_mode_levels_count and kbd_info.

[PATCH v3] platform/x86: dell-laptop: Fix bogus keyboard backlight sysfs interface

-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v3: Change the logic, there should be at least two modes present to claim it supports backlight. Suggested by Pali Rohár. v2: The only token can be found is actually KBD_LED_ON_TOKEN, which is BIT(5), instead of KBD_LED_OFF_TOKEN. Change

Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller

; assert PME# from D3 when it should. For "lspci -vv" output, see > > http://marc.info/?l=linux-usb=149570231732519=2 > > On Mon, 12 Jun 2017, Kai-Heng Feng wrote: > >> On Mon, Jun 12, 2017 at 3:04 PM, Kai-Heng Feng >> <kai.heng.f...@canonical.com

Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller

On Mon, Jun 12, 2017 at 3:04 PM, Kai-Heng Feng <kai.heng.f...@canonical.com> wrote: > On Fri, Jun 9, 2017 at 10:43 PM, Alan Stern <st...@rowland.harvard.edu> wrote: >> On Fri, 9 Jun 2017, Kai-Heng Feng wrote: >> >> Is this really the right solution?

Re: [PATCH] firmware: add firmware to new device's devres list for second time cache

On Tue, Aug 22, 2017 at 12:52 AM, Kai-Heng Feng <kai.heng.f...@canonical.com> wrote: > Currently, firmware will only be chached if assign_firmware_buf() gets > called. > > When a device loses its power or a USB device gets plugged to another > port under suspend, request_firm

Re: [PATCH] Revert "xhci: Limit USB2 port wake support for AMD Promontory hosts"

On Mon, Aug 28, 2017 at 9:56 PM, Kai-Heng Feng <kai.heng.f...@canonical.com> wrote: > On Mon, Aug 28, 2017 at 6:14 PM, Mathias Nyman > <mathias.ny...@linux.intel.com> wrote: >> On 28.08.2017 12:29, Greg KH wrote: >> >> Adding more people who were involved in the

[PATCH] ALSA: usb-audio: Add sample rate quirk for Plantronics C310/C520-M

Like other Plantronics devices, C310 and C520-M do not support sample rate reading. Add them to the sample rate quirk accordingly. BugLink: https://bugs.launchpad.net/bugs/1708499 BugLink: https://bugs.launchpad.net/bugs/1709282 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.

[PATCH] ACPI / battery: add quirk for Asus GL502VSK and UX305LA

d.net/bugs/1482390 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/acpi/battery.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index 13e7b56e33ae..f9f008cf3da7 100644 --

Re: [PATCH resend] platform/x86: peaq-wmi: Add DMI check before binding to the WMI interface

Hi Hans, On Fri, Oct 6, 2017 at 2:04 AM, Hans de Goede <hdego...@redhat.com> wrote: > Hi All, > > This is a resend with Kai Heng Feng added to the Cc. Kai can you please > test this patch. This patch replaces yours, as many devices seem to be > affected so a whitelist is the

Re: [PATCH] firmware: add firmware to new device's devres list for second time cache

On Thu, Oct 5, 2017 at 5:17 AM, Luis R. Rodriguez <mcg...@kernel.org> wrote: > On Tue, Aug 22, 2017 at 03:52:46PM +0800, Kai-Heng Feng wrote: >> Currently, firmware will only be chached if assign_firmware_buf() gets >> called. > > True, but also more importantly we peg

Re: [PATCH] ALSA: usb-audio: Add sample rate quirk for Plantronics P610

Hi, On Fri, Oct 6, 2017 at 2:22 AM, Takashi Iwai <ti...@suse.de> wrote: > On Thu, 05 Oct 2017 20:04:06 +0200, > Kai-Heng Feng wrote: >> >> Like other Plantronics devices, P610 does not support sample >> rate reading. Apply sample rate quirk to it. >> >>

Re: btusb "firmware request while host is not available" at resume

Hi Luis, On Wed, Oct 4, 2017 at 8:20 AM, Luis R. Rodriguez wrote: > So please retest now that the revert happened: commit > f007cad159e99fa2acd3b2e9364fbb32ad28b971 ("Revert "firmware: add sanity check > on shutdown/suspend"). I can confirm the issue is gone after the commit.

[PATCH] ALSA: usb-audio: Add sample rate quirk for Plantronics P610

Like other Plantronics devices, P610 does not support sample rate reading. Apply sample rate quirk to it. BugLink: https://bugs.launchpad.net/bugs/1719853 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- sound/usb/quirks.c | 1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH] platform/x86: peaq-wmi: Blacklist Lenovo ideapad 700-15ISK

peaq-wmi on Lenovo ideapad 700-15ISK keeps sending KEY_SOUND, which makes user's repeated keys gets interrupted. The system does not have Dolby button, let's blacklist it. BugLink: https://bugs.launchpad.net/bugs/1720219 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- d

[PATCH 1/1] Revert "HID: multitouch: Support ALPS PTP stick with pid 0x120A"

This reverts commit fcaa4a07d2a4b541e91da7a55d8b3331f96d1865. As noted by Masaki [1], 0x120A + trackpoint will not be used in mass production machines, so remove the ID accordingly. [1] http://www.spinics.net/lists/linux-input/msg53222.html Signed-off-by: Kai-Heng Feng <kai.hen

Re: btusb "firmware request while host is not available" at resume

Hi Luis, On Thu, Sep 14, 2017 at 1:39 AM, Luis R. Rodriguez wrote: [snipped] > Would a fw_cache_hint(device, name_list) be reasonable then sometime *before* > suspend? All this would do is ask the firmware API to extend the fw cache > list with the entries. It would not load

[PATCH] Revert "xhci: Limit USB2 port wake support for AMD Promontory hosts"

fected, so revert the commit. Conflicts: drivers/usb/host/xhci-pci.c drivers/usb/host/xhci.h Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/usb/host/xhci-hub.c | 3 --- drivers/usb/host/xhci-pci.c | 12 drivers/usb/host/xhci.h | 2 +-

[PATCH] firmware: add firmware to new device's devres list for second time cache

time the system suspend, those firmware won't be cached. Hence, we should add the firmware name to the devres when the firmware is found in cache, to make the firmware cacheable next time. Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/base/firmware_class.c | 4 +

[PATCH v2 1/4] Bluetooth: btusb: Add firmware caching function for already patched Bluetooth chip

by calling request_firmware() even if the chip is already updated - now the firmware_class knows what to cache. In this case, we don't really need to wait for the firmware content, so we use the async version of request_firmware(). Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v2:

Re: [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C920-C

On Mon, Aug 21, 2017 at 6:03 PM, Dmitry Fleytman wrote: > Commit e0429362ab15 > ("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e") > introduced quirk to workaround an issue with some Logitech webcams. > > Apparently model C920-C has the same issue so applying

[PATCH 2/2] Bluetooth: btusb: ath3k: Cache firmware for already patched Bluetooth chip

by calling request_firmware() even if the chip is already updated - now the firmware_class knows what to cache. In this case, we don't really need to wait for the firmware content, so we use the async version of request_firmware(). Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- d

[PATCH 1/2] Bluetooth: btusb: ath3k: Decide firmware name before checking update status

Decide firmware name before checking patch update status. Firmware name is required for caching. Also, version information in btusb_setup_qca() is being calculated twice, reduce it to one. Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/bluetooth/ath3k.

Re: [PATCH 2/2] Bluetooth: btusb: ath3k: Cache firmware for already patched Bluetooth chip

ready updated - now the firmware_class knows what to cache. >> >> In this case, we don't really need to wait for the firmware content, so >> we use the async version of request_firmware(). >> >> Signed-off-by: Kai-Heng Feng <kai.

[PATCH v2 4/4] Bluetooth: ath3k: Cache firmware for Atheros Bluetooth

For Intel Bluetooth that downloads firmware based on patched status, it should still call request_firmware() once if download is not needed. Verified on DW1707 wireless module (0cf3:e005). Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v2: Split patches for different v

[PATCH v2 2/4] Bluetooth: btusb: Cache firmware for Intel Bluetooth

For Intel Bluetooth that downloads firmware based on patched status, it should still call request_firmware() once if download is not needed. Verified on Intel 7265 wireless module (8087:0a2a). Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v2: Split patches for different v

[PATCH v2 3/4] Bluetooth: btusb: Cache firmware for QCA Bluetooth

For QCA Bluetooth that downloads firmware based on patched status, it should still call request_firmware() once if download is not needed. Also, version information was converted twice, reduce it to one. Verified on DW1810 wireless module (0cf3:e009). Signed-off-by: Kai-Heng Feng <kai.hen

Re: [PATCH] Revert "xhci: Limit USB2 port wake support for AMD Promontory hosts"

On Mon, Aug 28, 2017 at 6:14 PM, Mathias Nyman <mathias.ny...@linux.intel.com> wrote: > On 28.08.2017 12:29, Greg KH wrote: >> >> On Tue, Aug 22, 2017 at 05:14:47PM +0800, Kai-Heng Feng wrote: >>> >>> This reverts commit dec08194ffeccfa1cf085906b53d301930eae

Re: [PATCH resend] platform/x86: peaq-wmi: Add DMI check before binding to the WMI interface

Hi, On Fri, Oct 6, 2017 at 12:23 PM, Kai-Heng Feng <kai.heng.f...@canonical.com> wrote: > Hi Hans, > > On Fri, Oct 6, 2017 at 2:04 AM, Hans de Goede <hdego...@redhat.com> wrote: >> Hi All, >> >> This is a resend with Kai Heng Feng added to the Cc. Kai can yo

Re: [PATCH] ACPI / battery: add quirk for Asus GL502VSK and UX305LA

On Fri, Sep 22, 2017 at 4:27 PM, Kai-Heng Feng <kai.heng.f...@canonical.com> wrote: > On Asus GL502VSK and UX305LA, ACPI incorrectly reports discharging when > battery is full and AC is plugged. > > However rate_now is correct under this circumstance, hence we can us

[PATCH 1/2] r8169: reinstate ALDPS for power saving

omieu <rom...@fr.zoreil.com> Cc: Hayes Wang <hayesw...@realtek.com> Cc: Jörg Otte <jrg.o...@gmail.com> Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/net/ethernet/realtek/r8169.c | 58 +--- 1 file changed, 48 insertions(+), 10

[PATCH 2/2] r8169: reinstate internal ASPM and clock request settings

: Francois Romieu <rom...@fr.zoreil.com> Cc: Hayes Wang <hayesw...@realtek.com> Cc: Jörg Otte <jrg.o...@gmail.com> Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/net/ethernet/realtek/r8169.c | 28 ++-- 1 file changed, 22 inserti

Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

> On 27 Nov 2017, at 11:13 PM, > wrote: > > This is quite surprising to me too. The externally plugged in r8153 dongle, > was it connected over type C port or over type A port? AFAIK Type C port is > actually Alpine ridge pass through

Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

> On 24 Nov 2017, at 4:28 PM, Greg KH wrote: > > The bcdDevice is different between the dock device and the "real" > device, why not use that? Yea, I’ll poke around and see if bcdDevice alone can be a good predicate. > Then there is still a bug. Who as ASMedia is

Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

> Also the MAC address is different, can you just trigger off of Dell's > MAC address space instead of the address space of the dongle device? A really good idea, never thought of this. Thanks for the hint :) Still, I need to ask Dell folks to get all the answers. Kai-Heng

Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

> On 23 Nov 2017, at 5:24 PM, Greg KH <gre...@linuxfoundation.org> wrote: > > On Thu, Nov 23, 2017 at 04:53:41PM +0800, Kai Heng Feng wrote: >> >> What I want to do here is to finding this connection: >> Realtek r8153 <-> SMSC hub (USD ID: 0424:5537)

Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

> On 23 Nov 2017, at 3:58 PM, Greg KH <gre...@linuxfoundation.org> wrote: > > On Thu, Nov 23, 2017 at 01:38:38AM -0500, Kai-Heng Feng wrote: >> r8153 on Dell TB dock corrupts rx packets. >> >> The root cause is not found yet, but disabling rx checksumming can &g

[PATCH] r8152: disable rx checksum offload on Dell TB dock

bugs/1729674 Cc: Mario Limonciello <mario.limoncie...@dell.com> Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/net/usb/r8152.c | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/r8152.c b/drive

Re: [PATCH 4.13 03/28] Bluetooth: btusb: fix QCA Rome suspend/resume

Hi, > On 16 Dec 2017, at 11:05 AM, Matthias Kaehlcke wrote: > stable branches are currently broken for BTUSB_QCA_ROME with USB > autosuspend enabled, since the above patch is not included (I only > checked v4.4 and v4.9), so we probably want to integrate it. Thanks for this

Re: [PATCH 4.13 03/28] Bluetooth: btusb: fix QCA Rome suspend/resume

Hi Brian, > On 19 Dec 2017, at 2:13 AM, Brian Norris wrote: > > Hi Greg, > > On Mon, Dec 18, 2017 at 12:43:48PM +0100, Greg Kroah-Hartman wrote: >> On Fri, Dec 15, 2017 at 07:05:39PM -0800, Matthias Kaehlcke wrote: >>> We identified the above patch as the culprit, in

  1   2   3   4   5   6   7   8   9   10   >