> On 23 Nov 2017, at 3:58 PM, Greg KH wrote:
>
> On Thu, Nov 23, 2017 at 01:38:38AM -0500, Kai-Heng Feng wrote:
>> r8153 on Dell TB dock corrupts rx packets.
>>
>> The root cause is not found yet, but disabling rx checksumming can
>> workaround the issue. We
> On 6 Dec 2017, at 10:10 PM, Greg KH wrote:
>
> On Wed, Dec 06, 2017 at 06:26:21PM +0800, Kai-Heng Feng wrote:
>> Trying quirks in usbcore needs to rebuild the driver or the entire
>> kernel if it's builtin. It can save a lot of time if usbcore has similar
>>
ELAN060C touchpad uses elan_i2c as its driver. It can be
found on Lenovo ideapad 320-14AST.
BugLink: https://bugs.launchpad.net/bugs/1727544
Signed-off-by: Kai-Heng Feng
---
drivers/input/mouse/elan_i2c_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/mouse
> On 23 Nov 2017, at 5:24 PM, Greg KH wrote:
>
> On Thu, Nov 23, 2017 at 04:53:41PM +0800, Kai Heng Feng wrote:
>>
>> What I want to do here is to finding this connection:
>> Realtek r8153 <-> SMSC hub (USD ID: 0424:5537) <->
>&g
> On 24 Nov 2017, at 4:28 PM, Greg KH wrote:
>
> The bcdDevice is different between the dock device and the "real"
> device, why not use that?
Yea, I’ll poke around and see if bcdDevice alone can be a good predicate.
> Then there is still a bug. Who as ASMedia is working on this, have they
> Also the MAC address is different, can you just trigger off of Dell's
> MAC address space instead of the address space of the dongle device?
A really good idea, never thought of this. Thanks for the hint :)
Still, I need to ask Dell folks to get all the answers.
Kai-Heng
R. Crudup
Fixes: 215a22ed31a1 ("ALSA: hda: Refactor codec PM to use direct-complete
optimization")
Signed-off-by: Kai-Heng Feng
---
v2:
- Use pm_runtime_force_*() helpers to avoid suspend/resume ping pong.
sound/pci/hda/hda_codec.c | 24 +++-
1 file changed, 7 inserti
On Tue, Jan 19, 2021 at 6:34 PM Greg Kroah-Hartman
wrote:
>
> On Tue, Jan 19, 2021 at 11:41:59AM +0200, Andy Shevchenko wrote:
> > On Tue, Jan 19, 2021 at 04:41:48PM +0800, Kai-Heng Feng wrote:
> > > On Tue, Jan 19, 2021 at 4:27 PM Greg Kroah-Hartman
> > > wrote
On Sat, Jan 9, 2021 at 12:25 AM Kai-Heng Feng
wrote:
>
> Commit 8765c5ba19490 ("ACPI / scan: Rework modalias creation when
> "compatible" is present") creates two modaliases for certain ACPI
> devices. However userspace (systemd-udevd in this case) assumes ueven
pull/18163
Cc: AceLan Kao
Cc: "Rafael J. Wysocki"
Cc: Greg Kroah-Hartman
Cc: Andy Shevchenko
Suggested-by: Mika Westerberg
Fixes: 8765c5ba1949 ("ACPI / scan: Rework modalias creation when "compatible"
is present")
Signed-off-by: Kai-Heng Feng
---
drivers/acpi/device_
On Mon, Jan 18, 2021 at 9:21 PM Takashi Iwai wrote:
>
> On Mon, 18 Jan 2021 14:09:36 +0100,
> Kai-Heng Feng wrote:
> >
> > HDA controller can't be runtime-suspended after commit 215a22ed31a1
> > ("ALSA: hda: Refactor codjc PM to use direct-complete optimiza
Hi,
On Mon, Jan 18, 2021 at 10:41 PM Benjamin Tissoires
wrote:
>
> Hi,
>
> On Mon, Jan 18, 2021 at 2:45 PM Kai-Heng Feng
> wrote:
> >
> > Palm ejection stops working on some Elan and Synaptics touchpad after
> > commit 40d5bb87377a ("HID: multitouch: enab
to keep PM
operations balanced.
Reported-by: Kenneth R. Crudup
Fixes: 215a22ed31a1 ("ALSA: hda: Refactor codec PM to use direct-complete
optimization")
Signed-off-by: Kai-Heng Feng
---
sound/pci/hda/hda_codec.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/sound/pci/hda/hda
ymore.
So also apply the quirk since MT_CLS_WIN_8_FORCE_MULTI_INPUT is
essentially MT_CLS_WIN_8.
Fixes: 40d5bb87377a ("HID: multitouch: enable multi-input as a quirk for some
devices")
Signed-off-by: Kai-Heng Feng
---
drivers/hid/hid-multitouch.c | 3 ++-
1 file changed, 2 insertions(+),
On Tue, Jan 19, 2021 at 1:45 AM Kai-Heng Feng
wrote:
>
> Hi,
>
> On Mon, Jan 18, 2021 at 10:41 PM Benjamin Tissoires
> wrote:
> >
> > Hi,
> >
> > On Mon, Jan 18, 2021 at 2:45 PM Kai-Heng Feng
> > wrote:
> > >
> > > Palm e
On Tue, Jan 5, 2021 at 9:00 PM Kai Vehmanen
wrote:
>
> Hi,
>
> On Mon, 4 Jan 2021, Kai-Heng Feng wrote:
>
> > Instead of queueing jackpoll_work, runtime resume the codec to let it
> > use different jack detection methods based on jackpoll_interval.
>
> hmm, but ja
On Wed, Aug 5, 2020 at 7:24 PM Kai-Heng Feng
wrote:
>
> Hi Tony,
>
> > On Aug 5, 2020, at 19:18, Tony Chuang wrote:
> >
> >> 8821CE with RFE 2 isn't supported:
> >> [ 12.404834] rtw_8821ce :02:00.0: rfe 2 isn't supported
> >> [ 12.40493
On Tue, Jan 5, 2021 at 8:28 PM Kai Vehmanen
wrote:
>
> Hey,
>
> On Mon, 4 Jan 2021, Kai-Heng Feng wrote:
>
> > System takes a very long time to suspend after commit 215a22ed31a1
> > ("ALSA: hda: Refactor codec PM to use direct-complete optimization"):
> &g
d/systemd/pull/18163
Fixes: 8765c5ba1949 ("ACPI / scan: Rework modalias creation when "compatible"
is present")
Signed-off-by: Kai-Heng Feng
---
v2:
Add a comment to document why it's changed.
drivers/acpi/device_sysfs.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion
d/systemd/pull/18163
Fixes: 8765c5ba1949 ("ACPI / scan: Rework modalias creation when "compatible"
is present")
Cc: AceLan Kao
Cc: "Rafael J. Wysocki"
Cc: Greg Kroah-Hartman ,
Cc: Mika Westerberg ,
Cc: Andy Shevchenko
Signed-off-by: Kai-Heng Feng
---
drivers/
On Tue, Jan 19, 2021 at 4:27 PM Greg Kroah-Hartman
wrote:
>
> On Tue, Jan 19, 2021 at 04:15:13PM +0800, Kai-Heng Feng wrote:
> > Commit 8765c5ba1949 ("ACPI / scan: Rework modalias creation when
> > "compatible" is present") may create two "MODALIAS
Hi Bjorn,
> On Oct 3, 2020, at 06:18, Bjorn Helgaas wrote:
>
> On Wed, Sep 30, 2020 at 04:24:54PM +0800, Kai-Heng Feng wrote:
>> BIOS may not be able to program ASPM for links behind VMD, prevent Intel
>> SoC from entering deeper power saving state.
>
> It's not a
> On Oct 6, 2020, at 03:19, Bjorn Helgaas wrote:
>
> [+cc Ian, who's also working on an ASPM issue]
>
> On Tue, Oct 06, 2020 at 02:40:32AM +0800, Kai-Heng Feng wrote:
>>> On Oct 3, 2020, at 06:18, Bjorn Helgaas wrote:
>>> On Wed, Sep 30, 2020 at 04:2
-by: Kai-Heng Feng
---
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
index acbd7eb66cbe
HP DreamColor panel, which is used by new HP ZBook Studio, needs to use
DPCD to control brightness.
Signed-off-by: Kai-Heng Feng
---
drivers/gpu/drm/drm_dp_helper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index
> On Apr 8, 2020, at 15:22, Jani Nikula wrote:
>
> On Tue, 07 Apr 2020, Kai-Heng Feng wrote:
>>> On Mar 27, 2020, at 19:03, Kai-Heng Feng
>>> wrote:
>>>
>>> Hi,
>>>
>>>> On Mar 23, 2020, at 13:35, Kai-Heng Feng
>&
> On Apr 8, 2020, at 15:23, Jani Nikula wrote:
>
> On Tue, 07 Apr 2020, Kai-Heng Feng wrote:
>> There's another Samsung OLED panel needs to use DPCD aux interface to
>> control backlight.
>
> Acked-by: Jani Nikula
David,
Can you please merge th
0x02 0x03* 0x04
Those pins were filtered out by commit 116dcde63806 ("ALSA: HDA: Remove
unconnected PCM devices for Intel HDMI"). However, jacks that support
detection won't have the issues the commit addresses.
So still add the pin if it supports jack detection.
Signed-off-by
> On Aug 4, 2020, at 17:04, Takashi Iwai wrote:
>
> On Tue, 04 Aug 2020 09:29:25 +0200,
> Kai-Heng Feng wrote:
>>
>> HDMI on some platforms doesn't enable audio support because its Port
>> Connectivity [31:30] is set to AC_JACK_PORT_NONE:
>> Node 0x05 [Pin
> On Aug 4, 2020, at 17:48, Takashi Iwai wrote:
>
> On Tue, 04 Aug 2020 11:31:59 +0200,
> Kai-Heng Feng wrote:
>>
>>
>>
>>> On Aug 4, 2020, at 17:04, Takashi Iwai wrote:
>>>
>>> On Tue, 04 Aug 2020 09:29:25 +0200,
>>> Kai
0x02 0x03* 0x04
For now, use a quirk to force connectivity based on SSID. If there are
more platforms affected by the same issue, we can eye for a more generic
solution.
Signed-off-by: Kai-Heng Feng
---
v2:
- Use a quirk list instead.
include/sound/hda_codec.h | 1 +
sound/pci/hda
0x02 0x03* 0x04
For now, use a quirk to force connectivity based on SSID. If there are
more platforms affected by the same issue, we can eye for a more generic
solution.
Signed-off-by: Kai-Heng Feng
---
v3:
- Move the flag into hdmi_spec.
v2:
- Use a quirk list instead.
sound/pci/hda
it to the RFE
default.
Signed-off-by: Kai-Heng Feng
---
drivers/net/wireless/realtek/rtw88/rtw8821c.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8821c.c
b/drivers/net/wireless/realtek/rtw88/rtw8821c.c
index d8863d8a5468..f7270d0f1d55 100644
Hi Tony,
> On Aug 5, 2020, at 19:18, Tony Chuang wrote:
>
>> 8821CE with RFE 2 isn't supported:
>> [ 12.404834] rtw_8821ce :02:00.0: rfe 2 isn't supported
>> [ 12.404937] rtw_8821ce :02:00.0: failed to setup chip efuse info
>> [ 12.404939] rtw_8821ce :02:00.0: failed to setup
Hi Vitaly,
> On Sep 30, 2020, at 14:54, Vitaly Lifshits wrote:
>
> On 9/29/2020 18:08, Kai-Heng Feng wrote:
>
> Hello Kai-Heng,
>>> On Sep 29, 2020, at 21:46, Neftin, Sasha wrote:
>>>
>>> Hello Kai-Heng,
>>> On 9/29/2020 16:31, Kai-Heng Feng
The USB device (0x17aa:0x1046) that support Lenovo P620 rear panel
line-in claim to support volume control, but it doens't seem to have an
AMP, so when line-in volume lowers below 80, nothing gets recorded
anymore.
Disable the volume control to workaround the issue.
Signed-off-by: Kai-Heng Feng
-Heng Feng
---
drivers/usb/host/xhci-hub.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
index c3554e37e09f..4e14e164cb68 100644
--- a/drivers/usb/host/xhci-hub.c
+++ b/drivers/usb/host/xhci-hub.c
Goodix touchpad fails to operate in I2C mode after system suspend.
According to the vendor, Windows is more forgiving and there's a 60ms
delay after SET_POWER ON command.
So let's do the same here, to workaround for the touchpads that depend
on the delay.
Signed-off-by: Kai-Heng Feng
Hi Hans,
> On Aug 11, 2020, at 00:13, Hans de Goede wrote:
>
> Hi,
>
> On 10-08-2020 16:29, Kai-Heng Feng wrote:
>> Goodix touchpad fails to operate in I2C mode after system suspend.
>> According to the vendor, Windows is more forgiving and there's a 60ms
>>
There's another HP desktop has buggy BIOS which flags the Port
Connectivity bit as no connection.
Apply force connectivity quirk to enable DP/HDMI audio.
Signed-off-by: Kai-Heng Feng
---
sound/pci/hda/patch_hdmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_hdmi.c b
Hi Sasha,
> On Sep 29, 2020, at 21:08, Neftin, Sasha wrote:
>
> On 9/28/2020 11:36, Kai-Heng Feng wrote:
>> We are seeing the following error after S3 resume:
>> [ 704.746874] e1000e :00:1f.6 eno1: Setting page 0x6020
>> [ 704.844232] e1000e :00:1f.6 eno1:
> On Sep 29, 2020, at 21:46, Neftin, Sasha wrote:
>
> Hello Kai-Heng,
> On 9/29/2020 16:31, Kai-Heng Feng wrote:
>> Hi Sasha,
>>> On Sep 29, 2020, at 21:08, Neftin, Sasha wrote:
>>>
>>> On 9/28/2020 11:36, Kai-Heng Feng wrote:
>>&
> On Sep 29, 2020, at 23:11, David Laight wrote:
>
>> Hope we finally have proper ME support under Linux?
>
> How about a way to disable it.
This will do, too :)
Kai-Heng
>
> David
>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1
> 1PT, UK
>
Platform firmware may not be able to access config space to program
ASPM. For instance, devices behind Intel VMD are not configured by the
BIOS.
So add a helper to let drivers have an option to enable ASPM.
Signed-off-by: Kai-Heng Feng
---
drivers/pci/pcie/aspm.c | 73
BIOS may not be able to program ASPM for links behind VMD, prevent Intel
SoC from entering deeper power saving state.
So enable ASPM for links behind VMD to increase battery life.
Signed-off-by: Kai-Heng Feng
---
drivers/pci/controller/vmd.c | 22 +-
1 file changed, 21
> On Oct 14, 2020, at 08:20, Chaitanya Kulkarni
> wrote:
>
> On 10/13/20 01:45, Kai-Heng Feng wrote:
>> Like commit 5611ec2b9814 ("nvme-pci: prevent SK hynix PC400 from using
>> Write Zeroes command"), Sandisk Skyhawk has the same issue:
>> [ 63
AUX_SET_CAP, that should be enough for us to control
> it.
Does the proper fix include dropping DP_QUIRK_FORCE_DPCD_BACKLIGHT entirely?
Kai-Heng
>
>
> On Wed, 2020-10-07 at 14:58 +0800, Kai-Heng Feng wrote:
>> HP DreamColor panel needs to be controlled via AUX interface. How
> On Oct 7, 2020, at 21:30, Bjorn Helgaas wrote:
>
> On Wed, Oct 07, 2020 at 12:26:19PM +0800, Kai-Heng Feng wrote:
>>> On Oct 6, 2020, at 03:19, Bjorn Helgaas wrote:
>>> On Tue, Oct 06, 2020 at 02:40:32AM +0800, Kai-Heng Feng wrote:
>>>>> On O
> On Sep 30, 2020, at 10:20, Jarkko Sakkinen
> wrote:
>
> On Tue, Sep 29, 2020 at 01:52:04PM -0400, Mimi Zohar wrote:
>> On Mon, 2020-09-28 at 22:16 +0800, Kai-Heng Feng wrote:
>>> Hi Jarkko,
>>>
>>>> On Sep 28, 2020, at 22:06, Jarkko Sakkin
Hi Ville,
> On Aug 27, 2020, at 12:24 AM, Ville Syrjälä
> wrote:
>
> On Wed, Aug 26, 2020 at 01:21:15PM +0800, Kai-Heng Feng wrote:
>> LSPCON only supports 8 bpc for RGB/YCbCr444.
>>
>> Set the correct bpp otherwise it renders blank screen.
>
> Hm
Hi,
> On Aug 11, 2020, at 17:53, Kai-Heng Feng wrote:
>
> There's another HP desktop has buggy BIOS which flags the Port
> Connectivity bit as no connection.
>
> Apply force connectivity quirk to enable DP/HDMI audio.
>
> Signed-off-by: Kai-Heng Feng
I guess this p
> On Aug 12, 2020, at 23:47, Takashi Iwai wrote:
>
> On Wed, 12 Aug 2020 17:43:27 +0200,
> Kai-Heng Feng wrote:
>>
>> Hi,
>>
>>> On Aug 11, 2020, at 17:53, Kai-Heng Feng
>>> wrote:
>>>
>>> There's another H
> On Aug 26, 2020, at 08:27, Brian Norris wrote:
>
> On Mon, Aug 24, 2020 at 2:32 AM Kai-Heng Feng
> wrote:
>>
>> Sometimes system freeze on cold/warm boot when rtw88 is probing.
>>
>> According to [1], platform firmware may not properly power manage
Signed-off-by: Kai-Heng Feng
---
drivers/gpu/drm/radeon/radeon_device.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/radeon/radeon_device.c
b/drivers/gpu/drm/radeon/radeon_device.c
index 266e3cbbd09b..df823b9ad79f 100644
--- a/drivers/gpu/drm/radeon/radeon_device.c
+++ b/d
> On Sep 1, 2020, at 22:19, Alex Deucher wrote:
>
> On Tue, Sep 1, 2020 at 3:32 AM Kai-Heng Feng
> wrote:
>>
>> Suspend with s2idle or by the following steps cause screen frozen:
>> # echo devices > /sys/power/pm_test
>> # echo freez
> On Sep 2, 2020, at 00:30, Alex Deucher wrote:
>
> On Tue, Sep 1, 2020 at 12:21 PM Kai-Heng Feng
> wrote:
>>
>>
>>
>>> On Sep 1, 2020, at 22:19, Alex Deucher wrote:
>>>
>>> On Tue, Sep 1, 2020 at 3:32 AM Kai-Heng Feng
>>>
,
wIndex = 0x1300, type = 4
[5.905418] usb 3-6: 19:0: cannot get min/max values for control 12 (id 19)
So turn off the FU to avoid the error.
Also, add specific card name for both devices, so userspace can easily
indentify both cards.
Signed-off-by: Kai-Heng Feng
---
sound/usb/mixer.c
If USB autosuspend is enabled, both front and rear panel can no longer
detect jack insertion.
Enable USB remote wakeup, i.e. needs_remote_wakeup = 1, doesn't help
either.
So disable USB autosuspend to prevent missing jack detection event.
Signed-off-by: Kai-Heng Feng
---
sound/usb/quirks
at shutdown
to prevent the issue from happening.
[1] https://bugzilla.kernel.org/show_bug.cgi?id=206411#c9
Signed-off-by: Kai-Heng Feng
---
drivers/net/wireless/realtek/rtw88/pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/realtek/rtw88/pci.c
b/drivers/net
On Lenovo P520, the front panel headset LED isn't lit up right now.
Realtek states that the LED needs to be enabled by ALC233's GPIO2, so
let's do it accordingly to light the LED up.
Signed-off-by: Kai-Heng Feng
---
sound/pci/hda/patch_realtek.c | 7 +++
1 file changed, 7 insertions
e jack plugging status.
The LED is always on under Windows, so we are doing the same here.
Kai-Heng
> I also prepared a patchset but my patchset has more code than yours, please
> take a look. :-)
>
> Thanks.
>
> Hui.
>
> On 2020/9/14 下午3:02, Kai-Heng Feng wrote:
>
This reverts commit 34dedd2a83b241ba6aeb290260313c65dc58660e.
According to Realtek, volume FU works for line-in.
I can confirm volume control works after device firmware is updated.
Signed-off-by: Kai-Heng Feng
---
sound/usb/mixer_maps.c | 1 -
1 file changed, 1 deletion(-)
diff --git
d to solve the problem.
Fixes: 215a22ed31a1 ("ALSA: hda: Refactor codec PM to use direct-complete
optimization")
Signed-off-by: Kai-Heng Feng
---
include/sound/hda_codec.h | 1 +
sound/pci/hda/hda_codec.c | 7 +++
sound/pci/hda/hda_generic.c | 1 +
3 files changed, 9 insertions(+)
On Sat, Dec 26, 2020 at 3:46 PM Takashi Iwai wrote:
>
> On Fri, 25 Dec 2020 17:47:23 +0100,
> Kai-Heng Feng wrote:
> >
> > Laptop with codec controlled LEDs takes a very long time to suspend
> > after commit 215a22ed31a1 ("ALSA: hda: Refactor codec PM to use
> On Dec 9, 2020, at 01:11, Heiner Kallweit wrote:
>
> Am 08.12.2020 um 09:25 schrieb Kai-Heng Feng:
>> If we use sysfs to disable L1 ASPM, then enable one L1 ASPM substate
>> again, all other substates will also be enabled too:
>>
>> link# grep . *
>&g
> On Dec 9, 2020, at 01:18, Heiner Kallweit wrote:
>
> Am 08.12.2020 um 09:25 schrieb Kai-Heng Feng:
>> If we are to use sysfs to change ASPM settings, we may want to override
>> the default ASPM policy.
>>
>> So use ASPM capability, instead of defa
> On Dec 8, 2020, at 18:17, Jarkko Sakkinen wrote:
>
> On Mon, Dec 07, 2020 at 12:42:53PM +0800, Kai-Heng Feng wrote:
>> Hi Jarkko,
>>
>> A user report that the system can only do S3 once. Subsequent S3 fails after
>> commit a3fbfae82b4c (&qu
y issue once .critical callbacks are added in thermal
drivers.
Tested-by: Kai-Heng Feng
> ---
> drivers/thermal/thermal_core.c | 42 +-
> include/linux/thermal.h| 3 +++
> 2 files changed, 29 insertions(+), 16 deletions(-)
>
> d
On Tue, Dec 22, 2020 at 1:56 AM Ilia Mirkin wrote:
>
> On Mon, Dec 21, 2020 at 11:33 AM Kai-Heng Feng
> wrote:
> >
> > [+Cc nouveau]
> >
> > On Fri, Dec 18, 2020 at 4:06 PM Takashi Iwai wrote:
> > [snip]
> > > > Quite possibly the
[+Cc Bjorn, Alan and linux-pci]
On Thu, Dec 17, 2020 at 12:57 AM Takashi Iwai wrote:
>
> On Wed, 16 Dec 2020 17:22:17 +0100,
> Takashi Iwai wrote:
> >
> > On Wed, 16 Dec 2020 17:07:45 +0100,
> > Kai-Heng Feng wrote:
> > >
> > > On Wed,
ssive
cooling method.
As int340x device isn't present under ACPI ThermalZone, override the
default .critical callback to prevent surprising thermal shutdown.
Signed-off-by: Kai-Heng Feng
---
drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 6 ++
.../thermal/intel/int340x_thermal/in
Like previous patch, the intel_pch_thermal device is not in ACPI
ThermalZone namespace, so a critical trip doesn't mean shutdown.
Override the default .critical callback to prevent surprising thermal
shutdoown.
Signed-off-by: Kai-Heng Feng
---
drivers/thermal/intel/intel_pch_thermal.c | 6
On Mon, Dec 21, 2020 at 9:59 PM Daniel Lezcano
wrote:
>
> On 21/12/2020 14:52, Kai-Heng Feng wrote:
> > We are seeing thermal shutdown on Intel based mobile workstations, the
> > shutdown happens during the first trip handle in
> > thermal_zone_device_registe
[+Cc nouveau]
On Fri, Dec 18, 2020 at 4:06 PM Takashi Iwai wrote:
[snip]
> > Quite possibly the system doesn't power up HDA controller when there's
> > no external monitor.
> > So when it's connected to external monitor, it's still needed for HDMI
> > audio.
> > Let me ask the user to confirm
On Tue, Dec 22, 2020 at 12:55 AM Srinivas Pandruvada
wrote:
>
> On Mon, 2020-12-21 at 21:52 +0800, Kai-Heng Feng wrote:
> > We are seeing thermal shutdown on Intel based mobile workstations,
> > the
> > shutdown happens during the first trip handle in
> >
On Tue, Dec 22, 2020 at 12:47 AM Takashi Iwai wrote:
[snip]
> But what happens if you plug the HDMI cable later and want to use the
> HDMI audio? It won't work with your fix, right?
No it won't.
It's possible to fix from nouveau, but it's at the mercy of Nvidia to
fix their proprietary driver,
ssive
cooling method.
As int340x device isn't present under ACPI ThermalZone, override the
default .critical callback to prevent surprising thermal shutdown.
Signed-off-by: Kai-Heng Feng
---
v2:
- Amend subject.
- Remove int3400 device.
.../thermal/intel/int340x_thermal/int340x_thermal_zone.c
Like previous patch, the intel_pch_thermal device is not in ACPI
ThermalZone namespace, so a critical trip doesn't mean shutdown.
Override the default .critical callback to prevent surprising thermal
shutdoown.
Signed-off-by: Kai-Heng Feng
---
v2:
- Amend subject.
drivers/thermal/intel
On Fri, Jan 1, 2021 at 4:07 PM Takashi Iwai wrote:
>
> On Thu, 31 Dec 2020 19:06:43 +0100,
> Kai-Heng Feng wrote:
> >
> > On Thu, Dec 31, 2020 at 6:55 PM Takashi Iwai wrote:
> > >
> > > On Tue, 29 Dec 2020 14:38:15 +0100,
> > > Kai-Heng Feng wrot
PM process.
Fixes: 215a22ed31a1 ("ALSA: hda: Refactor codec PM to use direct-complete
optimization")
Signed-off-by: Kai-Heng Feng
---
v2:
No change.
sound/soc/sof/intel/hda-dsp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/sof/intel/hda-dsp.c b/sou
ltek codec, we don't need any additional check for the resume.
Signed-off-by: Kai-Heng Feng
---
v2:
No change.
sound/soc/sof/intel/hda-codec.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/soc/sof/intel/hda-codec.c b/sound/soc/sof/intel/hda-codec.c
index 68
Modify hda_codec_jack_wake_enable() to also support disable WAKEEN.
In addition, this patch also moves the WAKEEN disablement call out of
hda_codec_jack_check() into hda_codec_jack_wake_enable().
This is a preparation for next patch.
No functional change intended.
Signed-off-by: Kai-Heng Feng
-by: Kai-Heng Feng
---
sound/pci/hda/hda_intel.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 6852668f1bcb..3fd920069268 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2328,7 +2328,7
On Tue, Dec 15, 2020 at 2:22 AM Matthew Garrett wrote:
>
> On Sun, Nov 29, 2020 at 9:36 PM Kai-Heng Feng
> wrote:
> >
> > We are seeing thermal shutdown on Intel based mobile workstations, the
> > shutdown happens during the first trip handle in
> > thermal_z
$ cat /sys/bus/pci/devices/:01:00.1/power/runtime_status
active
So mark there's no codec and continue probing to let runtime PM to work.
BugLink: https://bugs.launchpad.net/bugs/1907212
Signed-off-by: Kai-Heng Feng
---
sound/pci/hda/hda_intel.c | 2 +-
1 file changed, 1 insertion(+),
On Wed, Dec 16, 2020 at 11:41 PM Takashi Iwai wrote:
>
> On Wed, 16 Dec 2020 13:47:24 +0100,
> Kai-Heng Feng wrote:
> >
> > Similar to commit 9479e75fca37 ("ALSA: hda: Keep the controller
> > initialization even if no codecs found"), when codec probe fails,
On Wed, Dec 16, 2020 at 11:58 PM Takashi Iwai wrote:
>
> On Wed, 16 Dec 2020 16:50:20 +0100,
> Kai-Heng Feng wrote:
> >
> > On Wed, Dec 16, 2020 at 11:41 PM Takashi Iwai wrote:
> > >
> > > On Wed, 16 Dec 2020 13:47:24 +0100,
> > > Kai-He
On Sat, Dec 26, 2020 at 11:26 PM Heiner Kallweit wrote:
>
> On 17.11.2020 17:57, Rafael J. Wysocki wrote:
> > On Tue, Nov 17, 2020 at 5:38 PM Bjorn Helgaas wrote:
> >>
> >> [+to Rafael, author of the commit you mentioned,
> >> +cc Mika, Kai Heng, Lukas, linux-pm, linux-kernel]
> >>
> >> On Tue,
Modify hda_codec_jack_wake_enable() to also support disable WAKEEN.
This is a preparation for next patch.
No functional change intended.
Signed-off-by: Kai-Heng Feng
---
sound/soc/sof/intel/hda-codec.c | 16 +++-
sound/soc/sof/intel/hda-dsp.c | 6 --
sound/soc/sof/intel
PM process.
Fixes: 215a22ed31a1 ("ALSA: hda: Refactor codec PM to use direct-complete
optimization")
Signed-off-by: Kai-Heng Feng
---
sound/soc/sof/intel/hda-dsp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/sof/intel/hda-dsp.c b/sound/soc/sof/i
Pointstick and its left/right buttons on HP EliteBook 850 G7 need
multi-input quirk to work correctly.
Signed-off-by: Kai-Heng Feng
---
drivers/hid/hid-multitouch.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index
HP EliteBook 850 G7 uses the same GPIO pins as ALC285_FIXUP_HP_GPIO_LED
to enable mute and micmute LED. So apply the quirk to enable the LEDs.
Signed-off-by: Kai-Heng Feng
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound
"ALSA: hda: Refactor codec PM to use direct-complete
optimization")
Signed-off-by: Kai-Heng Feng
---
drivers/base/power/main.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
index 46793276598d..9c0e25a92ad0 100644
--- a/drive
On Thu, Dec 31, 2020 at 6:55 PM Takashi Iwai wrote:
>
> On Tue, 29 Dec 2020 14:38:15 +0100,
> Kai-Heng Feng wrote:
> >
> > System takes a very long time to suspend after commit 215a22ed31a1
> > ("ALSA: hda: Refactor codec PM to use direct-complete optimization&q
On Thu, Dec 31, 2020 at 6:52 PM Takashi Iwai wrote:
>
> On Tue, 29 Dec 2020 14:38:14 +0100,
> Kai-Heng Feng wrote:
> >
> > Modify hda_codec_jack_wake_enable() to also support disable WAKEEN.
> > This is a preparation for next patch.
> >
> > No functional
The code predates 2005, it should be unnecessary now as PCI core handles
MSI much better nowadays.
So stop PCI MSI mangling in suspend/resume callbacks.
Signed-off-by: Kai-Heng Feng
---
sound/pci/hda/hda_intel.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/sound/pci/hda
The broken jack detection should be fixed by commit a6e7d0a4bdb0 ("ALSA:
hda: fix jack detection with Realtek codecs when in D3"), let's try
enabling runtime PM by default again.
Signed-off-by: Kai-Heng Feng
---
sound/pci/hda/hda_intel.c | 1 +
1 file changed, 1 insertion(+)
diff --g
: hda: Workaround for spurious
wakeups on some Intel platforms") solves doesn't happen with this
patch.
Signed-off-by: Kai-Heng Feng
---
sound/pci/hda/hda_controller.h | 2 +-
sound/pci/hda/hda_intel.c | 39 --
2 files changed, 15 insertions(+), 26
core will suspend and resume the
device as normal.
- If codec is runtime-suspended, PM core will try to keep it suspended.
If it's still suspended after system resume, we use
hda_codec_pm_complete() to resume codec if it's needed.
Signed-off-by: Kai-Heng Feng
---
sound/pci/hda/hda_codec.c | 45
> On Oct 23, 2020, at 19:32, Takashi Iwai wrote:
>
> On Fri, 23 Oct 2020 12:23:35 +0200,
> Kai-Heng Feng wrote:
>>
>> +static void hda_codec_pm_complete(struct device *dev)
>> {
>> struct hda_codec *codec = dev_to_hda_codec(de
401 - 500 of 1093 matches
Mail list logo
