Re: [PATCH] fix OOM killing processes wrongly thought MPOL_BIND

2007-04-18 Thread KAMEZAWA Hiroyuki
in constrained_alloc(). thank you for catching bug. Acked-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED] Signed-off-by: Hugh Dickins [EMAIL PROTECTED] --- Perhaps appropriate for 2.6.20-stable too - regression since 2.6.19. mm/oom_kill.c |2 ++ 1 file changed, 2 insertions(+) --- 2.6.21-rc7/mm

Re: [PATCH]Fix parsing kernelcore boot option for ia64

2007-04-23 Thread KAMEZAWA Hiroyuki
On Mon, 23 Apr 2007 19:32:46 +0100 [EMAIL PROTECTED] (Mel Gorman) wrote: I wasn't even aware of this kernelcore thing. It's pretty nasty-looking. yet another reminder that this code hasn't been properly reviewed in the past year or three. Just now, I'm making memory-unplug patches

Re: [PATCH] mm: PageLRU can be non-atomic bit operation

2007-04-23 Thread KAMEZAWA Hiroyuki
On Tue, 24 Apr 2007 10:54:27 +0900 Hisashi Hifumi [EMAIL PROTECTED] wrote: In the case that changing the same bit concurrently, lock prefix or other spinlock is needed. But, I think that concurrent bit operation on different bits is just like OR operation , so lock prefix is not needed.

[RFC][PATCH] syctl for selecting global zonelist[] order

2007-04-24 Thread KAMEZAWA Hiroyuki
against 2.6.21-rc7.. works well. Signed-Off-By: KAMEZAWA Hiroyuki [EMAIL PROTECTED] Index: linux-2.6.21-rc7/kernel/sysctl.c === --- linux-2.6.21-rc7.orig/kernel/sysctl.c +++ linux-2.6.21-rc7/kernel/sysctl.c @@ -76,6 +76,9 @@ extern int

Re: [RFC][PATCH] syctl for selecting global zonelist[] order

2007-04-25 Thread KAMEZAWA Hiroyuki
On Wed, 25 Apr 2007 00:42:14 -0700 Andrew Morton [EMAIL PROTECTED] wrote: On Wed, 25 Apr 2007 12:19:46 +0900 KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: Make zonelist policy selectable from sysctl. Assume 2 node NUMA, only node(0) has ZONE_DMA (ZONE_DMA32). In this case, default

Re: mm: migrate_pages using

2007-03-14 Thread KAMEZAWA Hiroyuki
On Mon, 12 Mar 2007 19:57:58 +0100 Michal Hocko [EMAIL PROTECTED] wrote: What do you think about that. Is this way correct? If you are sure that your original pages is never freed while you are migrating it.maybe. -Kame - To unsubscribe from this list: send the line unsubscribe

[BUGFIX][PATCH] fixing placement of register stack under ulimit -s

2007-03-15 Thread KAMEZAWA Hiroyuki
expansion causes SEGV. This means that the user program can use only 1 page for its register stack. This patch fixes the above case by moving register stack to suitable place. Note) fixing page fault handler seems to be another way...but a bit complicated. Signed-off-by: KAMEZAWA Hiroyuki [EMAIL

Re: [BUGFIX][PATCH] fixing placement of register stack under ulimit -s

2007-03-15 Thread KAMEZAWA Hiroyuki
/15/07, KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: This patch fixes ia64's bug in ulimit -s handling. against 2.6.21-rc3. At first,the address of register stack is defined by this == ia64_set_rbs_bot() unsigned long stack_size = current-signal-rlim[RLIMIT_STACK].rlim_max -16

Re: [BUGFIX][PATCH] fixing placement of register stack under ulimit -s

2007-03-15 Thread KAMEZAWA Hiroyuki
On Fri, 16 Mar 2007 06:20:47 +0900 KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: On Thu, 15 Mar 2007 09:57:28 -0600 David Mosberger-Tang [EMAIL PROTECTED] wrote: But aren't you going to be limited to less than a page worth of register-backing store even with your patch applied because

Re: [BUGFIX][PATCH] fixing placement of register stack under ulimit -s

2007-03-15 Thread KAMEZAWA Hiroyuki
plz allow me to explain more. Why register-stack/memory-stack upside down is bad is a bit complicated. So...this is a test and result for explaining bug. This is a sample code and its result on 2.6.21-rc3. Note: base address of memory'stack can be randomly change. == sample code == [EMAIL

Re: thread stacks and strict vm overcommit accounting

2007-03-15 Thread KAMEZAWA Hiroyuki
On Thu, 15 Mar 2007 11:06:21 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Tue, 13 Mar 2007 18:33:20 +0200 Dan Aloni [EMAIL PROTECTED] wrote: Hello, This question is relevent to 2.6.20. I noticed that if the RSS for the stack size is say, 8MB, running a single-threaded process

[RFC] [PATCH] more support for memory-less-node.

2007-02-12 Thread KAMEZAWA Hiroyuki
node_memory_online_map for nodes which have memory. for_each_node_mask(nid, node_memory_online_map) walks all memory-ready-nodes. This mask is updated at node-hotplug ops. Signed-Off-By: KAMEZAWA Hiroyuki [EMAIL PROTECTED] Index: linux-2.6.20/include/linux/nodemask.h

Re: [RFC] [PATCH] more support for memory-less-node.

2007-02-13 Thread KAMEZAWA Hiroyuki
On Tue, 13 Feb 2007 09:29:49 +0100 Andi Kleen [EMAIL PROTECTED] wrote: In my understanding, a node is a block of cpu, memory, devices. and there could be cpu-only-node, memory-only-node, device-only-node... The trouble with this is that you'll need to harden large parts of code against

Re: [RFC] [PATCH] more support for memory-less-node.

2007-02-13 Thread KAMEZAWA Hiroyuki
On Tue, 13 Feb 2007 09:25:00 -0800 (PST) Christoph Lameter [EMAIL PROTECTED] wrote: On Tue, 13 Feb 2007, KAMEZAWA Hiroyuki wrote: NOD_DATA(nid) is always valid pointer if a node is online. NODE_DATA(nid)-present_pages can be 0 even if a node is online, I call this as memory-less-node

Re: [RFC] [PATCH] more support for memory-less-node.

2007-02-13 Thread KAMEZAWA Hiroyuki
On Tue, 13 Feb 2007 10:50:53 -0800 (PST) Christoph Lameter [EMAIL PROTECTED] wrote: On Tue, 13 Feb 2007, Martin J. Bligh wrote: What's wrong with just setting the existing counters like node_spanned_pages / node_present_pages to zero? Will this fix the breakage that Kame-san saw?

[PATCH] fix mempolicy's check on a system with memory-less-node take4

2007-02-14 Thread KAMEZAWA Hiroyuki
ambiguous void *pointer usage. - fixed warnings...misuse of PTR_ERR. Changelog: v1 - v2 - avoid extra pgdat scanningit is not necessary. tested on ia64/NUMA with memory-less-node. Signed-Off-By: KAMEZAWA Hiroyuki [EMAIL PROTECTED] Index: linux-2.6.20/mm/mempolicy.c

[Qeustion][Maybe BUG?] simaltaneous wait and SIGCHLD handling

2007-02-18 Thread KAMEZAWA Hiroyuki
Hi, From SUSv3, I expected SIGCHLD from dead processes (already reaped by wait(2)) should be cleared. But it seems that such situation is not handled in Linux. Here is a test program. set sigchld handler and call waitpid() in main(). == #include stdio.h #include sys/types.h #include sys/wait.h

Re: [PATCH] slab: ensure cache_alloc_refill terminates

2007-02-19 Thread KAMEZAWA Hiroyuki
On Mon, 19 Feb 2007 10:22:52 +0200 (EET) Pekka J Enberg [EMAIL PROTECTED] wrote: @@ -2987,6 +2987,14 @@ slabp = list_entry(entry, struct slab, list); check_slabp(cachep, slabp); check_spinlock_acquired(cachep); + + /* + *

Re: [RFC][PATCH][3/4] Add reclaim support

2007-02-19 Thread KAMEZAWA Hiroyuki
On Mon, 19 Feb 2007 12:20:42 +0530 Balbir Singh [EMAIL PROTECTED] wrote: +int memctlr_mm_overlimit(struct mm_struct *mm, void *sc_cont) +{ + struct container *cont; + struct memctlr *mem; + long usage, limit; + int ret = 1; + + if (!sc_cont) + goto out; +

[PATCH][ia64][1/2] bugfix stack layout upside-down

2007-03-22 Thread KAMEZAWA Hiroyuki
by adjusting register-stack. Signed-Off-By: KAMEZAWA Hiroyuki [EMAIL PROTECTED] Index: linux-2.6.21-rc4/arch/ia64/mm/init.c === --- linux-2.6.21-rc4.orig/arch/ia64/mm/init.c +++ linux-2.6.21-rc4/arch/ia64/mm/init.c @@ -155,7 +155,7

[PATCH][2/2] double stack limit (rfc)

2007-03-22 Thread KAMEZAWA Hiroyuki
because the memory stack uses the whole stack. How about this ? Signed-Off-By: KAMEZAWA Hiroyuki [EMAIL PROTECTED] Index: linux-2.6.21-rc4/arch/ia64/mm/init.c === --- linux-2.6.21-rc4.orig/arch/ia64/mm/init.c +++ linux-2.6.21-rc4

Re: [PATCH][2/2] double stack limit (rfc)

2007-03-22 Thread KAMEZAWA Hiroyuki
On Thu, 22 Mar 2007 21:56:03 -0700 Tony Luck [EMAIL PROTECTED] wrote: On 3/22/07, KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: I hear some people says that When I set stack-size-limit to 32M, I want to use 32M of memory stack... and register-stack expansion can fail because stack is used up

[PATCH] fix handling of SIGCHILD from reaped child

2007-02-20 Thread KAMEZAWA Hiroyuki
reaped process.) please review... works well on 2.6.20/ia64/NUMA environment and passed my easy test. Signed-Off-By: KAMEZAWA Hiroyuki [EMAIL PROTECTED] Index: linux-2.6.20-devel/kernel/signal.c === --- linux-2.6.20-devel.orig/kernel

Re: [PATCH] fix handling of SIGCHILD from reaped child

2007-02-20 Thread KAMEZAWA Hiroyuki
On Tue, 20 Feb 2007 17:22:57 +0300 Oleg Nesterov [EMAIL PROTECTED] wrote: I'd suggest to make a separate function, but not complicate collect_signal(). okay. I'll try again if people admit me to go ahead. --- linux-2.6.20-devel.orig/kernel/exit.c +++ linux-2.6.20-devel/kernel/exit.c @@

Re: [PATCH] fix handling of SIGCHILD from reaped child

2007-02-20 Thread KAMEZAWA Hiroyuki
On Tue, 20 Feb 2007 20:20:49 +0300 Oleg Nesterov [EMAIL PROTECTED] wrote: + clear_stale_sigchild(current, retval); But we are not checking that SIGCHLD is blocked? I'm sorry if I don't read SUSv3 correctly. SUSv3 doesn't define how we should do if SIGCHLD is not

Re: [PATCH] fix handling of SIGCHILD from reaped child

2007-02-20 Thread KAMEZAWA Hiroyuki
On Tue, 20 Feb 2007 15:10:07 -0800 (PST) Roland McGrath [EMAIL PROTECTED] wrote: I'm usually the stickler for anal POSIX compliance, but this is one thing that I did notice a while ago, realized Linux had never done it, and decided I didn't care. Okay, I don't think this is a big trouble.

Re: [rfc][patch] dynamic resizing dentry hash using RCU

2007-02-23 Thread KAMEZAWA Hiroyuki
On Fri, 23 Feb 2007 16:37:43 +0100 Nick Piggin [EMAIL PROTECTED] wrote: +static void dcache_hash_resize(unsigned int new_shift); +static void mod_nr_dentry(int mod) +{ + unsigned long dentry_size; + + dentry_stat.nr_dentry += mod; + + dentry_size = 1 dentry_hash-shift; +

Re: [RFC][PATCH 0/3] VM throttling: avoid blocking occasional writers

2007-02-23 Thread KAMEZAWA Hiroyuki
On Fri, 23 Feb 2007 21:03:37 +0900 Tomoki Sekiyama [EMAIL PROTECTED] wrote: Hi, I have observed a problem that write(2) can be blocked for a long time if a system has several disks and is under heavy I/O pressure. This patchset is to avoid the problem. Example of the probrem: There

Re: SLUB: The unqueued Slab allocator

2007-02-23 Thread KAMEZAWA Hiroyuki
On Thu, 22 Feb 2007 10:42:23 -0800 (PST) Christoph Lameter [EMAIL PROTECTED] wrote: G. Slab merging We often have slab caches with similar parameters. SLUB detects those on bootup and merges them into the corresponding general caches. This leads to more effective memory

Re: [RFC][PATCH 0/3] VM throttling: avoid blocking occasional writers

2007-02-26 Thread KAMEZAWA Hiroyuki
On Tue, 27 Feb 2007 09:50:16 +0900 Tomoki Sekiyama [EMAIL PROTECTED] wrote: Hi Kamezawa-san, thanks for your reply. KAMEZAWA Hiroyuki wrote: Interesting, but how about adjust this parameter like below instead of adding new control knob ?(this kind of knob is not easy to use

Re: The performance and behaviour of the anti-fragmentation related patches

2007-03-01 Thread KAMEZAWA Hiroyuki
On Thu, 1 Mar 2007 16:09:15 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Thu, 1 Mar 2007 10:12:50 + [EMAIL PROTECTED] (Mel Gorman) wrote: Any opinion on merging these patches into -mm for wider testing? I'm a little reluctant to make changes to -mm's core mm unless those

Re: The performance and behaviour of the anti-fragmentation related patches

2007-03-01 Thread KAMEZAWA Hiroyuki
On Thu, 1 Mar 2007 21:11:58 -0800 (PST) Linus Torvalds [EMAIL PROTECTED] wrote: The whole DRAM power story is a bedtime story for gullible children. Don't fall for it. It's not realistic. The hardware support for it DOES NOT EXIST today, and probably won't for several years. And the real fix

Re: The performance and behaviour of the anti-fragmentation related patches

2007-03-02 Thread KAMEZAWA Hiroyuki
there and anti-fragmentation on its own is good enough). Pages hot-added to ZONE_MOVABLE will always be reclaimable or migratable in the case of mlock(). Kamezawa Hiroyuki has indicated that his hot-remove patches also do something like ZONE_MOVABLE. I would hope that his patches could

Re: 2.6.21-rc2-mm2

2007-03-06 Thread KAMEZAWA Hiroyuki
On Tue, 6 Mar 2007 03:09:27 -0800 Andrew Morton [EMAIL PROTECTED] wrote: == Is mask always valid pointer ? I can only find two `struct irq_chip's in arch/ia64 and they both have a .mask. And a .unmask. So perhaps that is a misreading of what oopsed. There are no changes in

[BUGFIX][PATCH] fix NULL pointer in ia64/irq_chip-mask/unmask function

2007-03-06 Thread KAMEZAWA Hiroyuki
This patch fixes boot failure because irq_desc-mask() is NULL. - Added mask/unmask functions to ia64's irq desc function table. But I'm not sure this fix is correct or not. please review. - rename hw_interrupt_type to irq_chip. hw_interrupt_type is old name. Signed-Off-By: KAMEZAWA Hiroyuki

Re: [BUGFIX][PATCH] fix NULL pointer in ia64/irq_chip-mask/unmask function

2007-03-06 Thread KAMEZAWA Hiroyuki
On Tue, 6 Mar 2007 22:57:10 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Wed, 7 Mar 2007 15:23:17 +0900 KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: This patch fixes boot failure because irq_desc-mask() is NULL. - Added mask/unmask functions to ia64's irq desc function table

Re: [patch 06/19] split LRU lists into anon file sets

2008-01-07 Thread KAMEZAWA Hiroyuki
On Wed, 02 Jan 2008 17:41:50 -0500 linux-kernel@vger.kernel.org wrote: static void shrink_active_list(unsigned long nr_pages, struct zone *zone, - struct scan_control *sc, int priority) + struct scan_control *sc, int priority, int file)

Re: [patch 07/19] split anon file LRUs for memcontrol code

2008-01-07 Thread KAMEZAWA Hiroyuki
On Wed, 02 Jan 2008 17:41:51 -0500 linux-kernel@vger.kernel.org wrote: Index: linux-2.6.24-rc6-mm1/mm/vmscan.c === --- linux-2.6.24-rc6-mm1.orig/mm/vmscan.c 2008-01-02 15:55:55.0 -0500 +++

Re: [patch 07/19] (NEW) add some sanity checks to get_scan_ratio

2008-01-08 Thread KAMEZAWA Hiroyuki
On Tue, 08 Jan 2008 15:59:46 -0500 Rik van Riel [EMAIL PROTECTED] wrote: The access ratio based scan rate determination in get_scan_ratio works ok in most situations, but needs to be corrected in some corner cases: - if we run out of swap space, do not bother scanning the anon LRUs - if we

Re: [patch 03/19] define page_file_cache() function

2008-01-08 Thread KAMEZAWA Hiroyuki
On Tue, 8 Jan 2008 17:28:56 -0500 Rik van Riel [EMAIL PROTECTED] wrote: On Tue, 8 Jan 2008 14:18:40 -0800 (PST) Christoph Lameter [EMAIL PROTECTED] wrote: On Tue, 8 Jan 2008, Rik van Riel wrote: Define page_file_cache() function to answer the question: is page backed by a file?

Re: [patch 05/19] split LRU lists into anon file sets

2008-01-08 Thread KAMEZAWA Hiroyuki
I like this patch set thank you. On Tue, 08 Jan 2008 15:59:44 -0500 Rik van Riel [EMAIL PROTECTED] wrote: Index: linux-2.6.24-rc6-mm1/mm/memcontrol.c === --- linux-2.6.24-rc6-mm1.orig/mm/memcontrol.c 2008-01-07 11:55:09.0

Re: [patch 05/19] split LRU lists into anon file sets

2008-01-09 Thread KAMEZAWA Hiroyuki
On Tue, 08 Jan 2008 15:59:44 -0500 Rik van Riel [EMAIL PROTECTED] wrote: + rotate_sum = zone-recent_rotated_file + zone-recent_rotated_anon; + + /* Keep a floating average of RECENT references. */ + if (unlikely(rotate_sum min(anon, file))) { +

Re: [patch 05/19] split LRU lists into anon file sets

2008-01-09 Thread KAMEZAWA Hiroyuki
On Thu, 10 Jan 2008 07:51:33 +0530 Balbir Singh [EMAIL PROTECTED] wrote: #define PAGE_CGROUP_FLAG_CACHE (0x1) /* charged as cache */ #define PAGE_CGROUP_FLAG_ACTIVE (0x2)/* page is active in this cgroup */ +#define PAGE_CGROUP_FLAG_FILE(0x4) /* page is file system

Re: [patch 05/19] split LRU lists into anon file sets

2008-01-09 Thread KAMEZAWA Hiroyuki
On Thu, 10 Jan 2008 08:56:31 +0530 Balbir Singh [EMAIL PROTECTED] wrote: The control_type feature is gone. We still have cached page accounting, but we do not allow control of only RSS pages anymore. We need to control both RSS+cached pages. I do not understand your question about new

Re: [RFC][PATCH 4/5] memory_pressure_notify() caller

2008-01-14 Thread KAMEZAWA Hiroyuki
On Tue, 15 Jan 2008 11:37:48 +0900 KOSAKI Motohiro [EMAIL PROTECTED] wrote: Hi KAME, + notify_threshold = (zone-pages_high + + zone-lowmem_reserve[MAX_NR_ZONES-1]) * 2; + Why MAX_NR_ZONES-1 ? this is intent to max lowmem_reserve. Ah, my point is.. how about

Re: [PATCH] add page-mapping handling interface [1/35] interface definitions

2007-09-13 Thread KAMEZAWA Hiroyuki
On Thu, 13 Sep 2007 22:19:20 +0200 Richard Knutsson [EMAIL PROTECTED] wrote: +static inline int page_is_pagecache(struct page *page) Why return it as an 'int' instead of 'bool'? +{ + if (!page-mapping || (page-mapping PAGE_MAPPING_ANON)) + return 0; + return 1; +}

Re: [PATCH] CONFIG_ZONE_MOVABLE [2/2] config zone movable

2007-09-17 Thread KAMEZAWA Hiroyuki
On Mon, 17 Sep 2007 19:47:48 -0700 Andrew Morton [EMAIL PROTECTED] wrote: On Fri, 31 Aug 2007 19:14:15 +0900 KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: Makes ZONE_MOVABLE as configurable Based on zone_ifdef_cleanup_by_renumbering.patch This patch causes my old dual-pIII machine

Re: [PATCH] Hookup group-scheduler with task container infrastructure

2007-09-18 Thread KAMEZAWA Hiroyuki
On Mon, 10 Sep 2007 22:40:49 +0530 Srivatsa Vaddagiri [EMAIL PROTECTED] wrote: + tg-cfs_rq = kzalloc(sizeof(cfs_rq) * num_possible_cpus(), GFP_KERNEL); + if (!tg-cfs_rq) + goto err; + tg-se = kzalloc(sizeof(se) * num_possible_cpus(), GFP_KERNEL); + if (!tg-se) +

[PATCH] fix memory hot remove not configured case.

2007-09-18 Thread KAMEZAWA Hiroyuki
if there are requirements and testers. Signed-off-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED] --- arch/i386/mm/init.c|5 arch/ia64/mm/init.c|3 +- arch/powerpc/mm/mem.c | 45 - arch/sh/mm/init.c

Re: [PATCH] fix memory hot remove not configured case.

2007-09-18 Thread KAMEZAWA Hiroyuki
if there are requirements and testers. Signed-off-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED] --- arch/i386/mm/init.c|5 arch/ia64/mm/init.c|3 +- arch/powerpc/mm/mem.c | 45 - arch/sh/mm/init.c |6

[RFC][PATCH] page-mapping clarification [1/3] base functions

2007-09-19 Thread KAMEZAWA Hiroyuki
- renamed some functions. Signed-off-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED] --- include/linux/fs.h |6 +- include/linux/mm.h | 40 --- include/linux/page-cache.h | 118 + include/linux/swap.h |1 4 files

[RFC][PATCH] page-mapping clarification [2/3] changes in /mm

2007-09-19 Thread KAMEZAWA Hiroyuki
Make use of page-cache.h functions in /mm layer. Signed-off-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED] --- mm/filemap.c| 19 ++- mm/memory.c |5 +++-- mm/migrate.c|8 ++-- mm/page-writeback.c |4 ++-- mm/rmap.c | 36

[RFC][PATCH] page-mapping clarification [3/3] changes in /fs generic

2007-09-19 Thread KAMEZAWA Hiroyuki
Make use of page-cache.h in fs-generic layer. Signed-off-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED] --- fs/buffer.c | 43 ++- fs/fs-writeback.c |2 +- fs/libfs.c|2 +- fs/mpage.c| 13 +++-- 4 files changed, 31

Re: [05/17] vunmap: return page array

2007-09-19 Thread KAMEZAWA Hiroyuki
On Tue, 18 Sep 2007 20:36:10 -0700 Christoph Lameter [EMAIL PROTECTED] wrote: Make vunmap return the page array that was used at vmap. This is useful if one has no structures to track the page array but simply stores the virtual address somewhere. The disposition of the page array can be

Re: [05/17] vunmap: return page array

2007-09-19 Thread KAMEZAWA Hiroyuki
On Wed, 19 Sep 2007 15:15:58 -0700 (PDT) Christoph Lameter [EMAIL PROTECTED] wrote: On Wed, 19 Sep 2007, KAMEZAWA Hiroyuki wrote: Hmm, I don't like returning array which someone allocated in past and forgot. But that is exactly the point. There is no need to keep track

Re: 2.6.24-rc2-mm1 (memory hotplug x86_64/vmemmap fix)

2007-11-14 Thread KAMEZAWA Hiroyuki
, is this style acceptable ? Signed-off-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED] arch/x86/mm/init_64.c |2 +- arch/x86/mm/srat_64.c |1 + mm/sparse-vmemmap.c | 13 - mm/sparse.c | 12 ++-- 4 files changed, 24 insertions(+), 4 deletions(-) Index: linux-2.6.24

Re: 2.6.24-rc2-mm1 (memory hotplug x86_64/vmemmap fix)

2007-11-15 Thread KAMEZAWA Hiroyuki
On Thu, 15 Nov 2007 00:56:57 -0800 Andrew Morton [EMAIL PROTECTED] wrote: eek. What I now need to do with this patch is - Work out which patches in -mm it is actually fixing. - If that is more than one patch then split this patch up into multiple ones. - Stage the one or more fixup

Re: 2.6.24-rc2-mm1 (memory hotplug x86_64/vmemmap fix)

2007-11-15 Thread KAMEZAWA Hiroyuki
On Thu, 15 Nov 2007 09:39:15 + Andy Whitcroft [EMAIL PROTECTED] wrote: Can you explain this is bug for me. The routine was __init_refok and therefore ! __init and therefore always present. The logic there must guarentee it only calls the bootmem allocator in early boot, and the logic

[PATCH][2.6.24-rc2-mm1] memory hotplug x86_64 fix [0/3]

2007-11-15 Thread KAMEZAWA Hiroyuki
memory hotplug fix against 2.6.23-rc2-mm1. Changelog - Divided into 3 patches - dropped patch against mm/sparse.c ( This was my misunderstanding.) - merged Andy's suggestion. All patches are related to memory hotplug. [1/3] ... export memory_add_physaddr_to_nid to acpi memory hotplug [2/3]

[PATCH][2.6.24-rc2-mm1] memory hotplug x86_64 fix [1/3] memory_add_physaddr_to_nid export for acpi memhotplug.ko

2007-11-15 Thread KAMEZAWA Hiroyuki
Fix following reference error (when CONFIG_ACPI_HOTPLUG_MEMORY=m) == ERROR: memory_add_physaddr_to_nid [drivers/acpi/acpi_memhotplug.ko] undefined! == Changelog: - EXPORT_SYMBOL to EXPORT_SYMBOL_GPL. Signed-off-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED] arch/x86/mm/srat_64.c |1 + 1

[PATCH][2.6.24-rc2-mm1] memory hotplug x86_64 fix [3/3] fix section mismatch in init_memory_mapping

2007-11-15 Thread KAMEZAWA Hiroyuki
-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED] arch/x86/mm/init_64.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.24-rc2-mm1/arch/x86/mm/init_64.c === --- linux-2.6.24-rc2-mm1.orig/arch/x86/mm/init_64.c +++ linux

[PATCH][2.6.24-rc2-mm1] memory hotplug x86_64 fix [2/3] fix section mismatch in vmammap_allock_block

2007-11-15 Thread KAMEZAWA Hiroyuki
(). Signed-off-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED] mm/sparse-vmemmap.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) Index: linux-2.6.24-rc2-mm1/mm/sparse-vmemmap.c === --- linux-2.6.24-rc2-mm1.orig/mm/sparse

Re: [PATCH][2.6.24-rc2-mm1] memory hotplug x86_64 fix [2/3] fix section mismatch in vmammap_allock_block

2007-11-15 Thread KAMEZAWA Hiroyuki
On Thu, 15 Nov 2007 16:53:30 -0800 Andrew Morton [EMAIL PROTECTED] wrote: - return __alloc_bootmem_node(NODE_DATA(node), size, size, + return __earlyonly_bootmem_alloc(node, size, size, __pa(MAX_DMA_ADDRESS)); } AFACIT this is

Re: [PATCH][2.6.24-rc2-mm1] memory hotplug x86_64 fix [3/3] fix section mismatch in init_memory_mapping

2007-11-15 Thread KAMEZAWA Hiroyuki
On Thu, 15 Nov 2007 16:59:35 -0800 Andrew Morton [EMAIL PROTECTED] wrote: Index: linux-2.6.24-rc2-mm1/arch/x86/mm/init_64.c === --- linux-2.6.24-rc2-mm1.orig/arch/x86/mm/init_64.c +++

Re: [PATCH] ia64: Avoid unnecessary TLB flushes when allocating memory

2007-12-17 Thread KAMEZAWA Hiroyuki
On Thu, 13 Dec 2007 15:03:07 + + if (mm != active_mm) { + /* Restore region IDs for mm */ + if (mm active_mm) { + activate_context(mm); + } else { + flush_tlb_all(); +

Re: swapping in 2.6.24-rc5-git3

2007-12-17 Thread KAMEZAWA Hiroyuki
On Mon, 17 Dec 2007 14:17:26 +0100 Lukas Hejtmanek [EMAIL PROTECTED] wrote: Hello, does /proc/sys/vm/swappiness still work as expected? # /proc/sys/vm# cat swappiness 0 but scp-ing 2GB file causes many processes are swapped out due to increase of the file cache size. Why? This is

Re: swapping in 2.6.24-rc5-git3

2007-12-17 Thread KAMEZAWA Hiroyuki
On Tue, 18 Dec 2007 10:38:13 +0900 KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: Is there a way to avoid it except turning off the swap? Maybe...no. Ah, sorry. If too much dirty page by ftp is trouble, tuning /proc/sys/vm/dirty_ratio /proc/sys/vm/dirty_writeback/centisecs etc.. may work

Re: [PATCH] ia64: Avoid unnecessary TLB flushes when allocating memory

2007-12-17 Thread KAMEZAWA Hiroyuki
On Tue, 18 Dec 2007 01:00:15 -0500 Kyle McMartin [EMAIL PROTECTED] wrote: On Tue, Dec 18, 2007 at 10:05:45AM +0900, KAMEZAWA Hiroyuki wrote: On Thu, 13 Dec 2007 15:03:07 + + if (mm != active_mm) { + /* Restore region IDs for mm */ + if (mm

Re: [PATCH 0/2] memcgroup: work better with tmpfs

2007-12-18 Thread KAMEZAWA Hiroyuki
On Tue, 18 Dec 2007 22:19:22 + (GMT) Hugh Dickins [EMAIL PROTECTED] wrote: 1. Why is spin_lock_irqsave rather than spin_lock needed on mz-lru_lock? If it is needed, doesn't mem_cgroup_isolate_pages need to use it too? When I wrote a patch to treat lru_lock (it was not per-zone yet.), I got

Re: [PATCH] Memory controller use rcu_read_lock() in mem_cgroup_cache_charge()

2007-12-20 Thread KAMEZAWA Hiroyuki
= mem_cgroup_charge_common(page, mm, gfp_mask, MEM_CGROUP_CHARGE_TYPE_CACHE); - else - return 0; + css_put(mem-css); + return ret; } /* _ Seems reasonable to me. Acked-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED] Thanks, -Kame

Re: [RFC] [PATCH] Memory controller remove control_type feature

2007-12-20 Thread KAMEZAWA Hiroyuki
On Fri, 21 Dec 2007 00:23:58 +0530 Balbir Singh [EMAIL PROTECTED] wrote: Based on the discussion at http://lkml.org/lkml/2007/12/20/383, it was felt that control_type might not be a good thing to implement right away. We can add this flexibility at a later point when required.

Re: 2.6.24-rc3-mm2 (bugfix for memory cgroup per-zone-struct allocation.)

2007-11-29 Thread KAMEZAWA Hiroyuki
On Thu, 29 Nov 2007 16:25:33 -0500 Lee Schermerhorn [EMAIL PROTECTED] wrote: - pn = kmalloc_node(sizeof(*pn), GFP_KERNEL, node); + /* +* This routine is called against possible nodes. +* But it's BUG to call kmalloc() against offline node. +* +* TODO: this routine

Re: What can we do to get ready for memory controller merge in 2.6.25

2007-11-30 Thread KAMEZAWA Hiroyuki
On Fri, 30 Nov 2007 08:43:35 +0530 Balbir Singh [EMAIL PROTECTED] wrote: KAMEZAWA-San posted some test results on background reclaim and per zone reclaim I'd like to post some patches below in the next week. - throttling the number of callers of try_to_free_mem_cgroup_pages() - background

Re: What can we do to get ready for memory controller merge in 2.6.25

2007-12-05 Thread KAMEZAWA Hiroyuki
On Fri, 30 Nov 2007 19:11:14 +0900 KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: I'd like to post some patches below in the next week. - throttling the number of callers of try_to_free_mem_cgroup_pages() - background reclaim and high/low watermark. - some cleanups. I'd like to hold off

Re: 2.6.24-rc3-mm1

2007-11-20 Thread KAMEZAWA Hiroyuki
to make target `arch/ia64/lib/copy_page-export.o', needed by `arch/ia64/lib/built-in.o'. Stop. make: *** [arch/ia64/lib] Error 2 fix (for my config ?) is attached. = This was necessary to build. Signed-off-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED] arch/ia64/lib/Makefile |2 +- 1 file

Re: 2.6.24-rc3-mm1 (sync is slow ?)

2007-11-21 Thread KAMEZAWA Hiroyuki
On Wed, 21 Nov 2007 17:42:15 +0900 KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: Hi, Andrew I got following result in 'sync' command. It was too slow. (memory controller config is off ;) I attaches my .config. == [2.6.24-rc3-mm1] [EMAIL PROTECTED] ~]$ dd if=/dev/zero of=./tmpfile bs=4096

Re: 2.6.24-rc3-mm1 (sync is slow ?)

2007-11-21 Thread KAMEZAWA Hiroyuki
On Wed, 21 Nov 2007 00:49:09 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Wed, 21 Nov 2007 17:42:15 +0900 KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: Hi, Andrew I got following result in 'sync' command. It was too slow. (memory controller config is off ;) I attaches my .config

Re: 2.6.24-rc3-mm1 (sync is slow ?)

2007-11-25 Thread KAMEZAWA Hiroyuki
On Sat, 24 Nov 2007 19:04:34 +0100 Gabriel C [EMAIL PROTECTED] wrote: It seems OK here from a quick test (i386, ext3-on-IDE). Maybe device driver/block breakage? Try revert

[PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [0/10] introduction

2007-11-26 Thread KAMEZAWA Hiroyuki
Hi, this is per-zone/reclaim support patch set for memory controller (cgroup). Major changes from previous one is -- tested with 2.6.24-rc3-mm1 + ia64/NUMA -- applied comments. I did small test on real NUMA machine. My machine was ia64/8CPU/2Node NUMA. I tried to complile the kernel under 800M

[PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [1/10] add scan_global_lru macro

2007-11-26 Thread KAMEZAWA Hiroyuki
add macro scan_global_lru(). This is used to detect which scan_control scans global lru or mem_cgroup lru. And compiled to be static value (1) when memory controller is not configured. This may make the meaning obvious. Acked-by: Balbir Singh [EMAIL PROTECTED] Signed-off-by: KAMEZAWA Hiroyuki

[PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [2/10] nid/zid helper function for cgroup

2007-11-26 Thread KAMEZAWA Hiroyuki
Add macro to get node_id and zone_id of page_cgroup. Will be used in per-zone-xxx patches and others. Changelog: - returns zone_type instead of int. Signed-off-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED] mm/memcontrol.c | 10 ++ 1 file changed, 10 insertions(+) Index: linux-2.6.24-rc3

[PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [3/10] per-zone active inactive counter

2007-11-26 Thread KAMEZAWA Hiroyuki
-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED] mm/memcontrol.c | 164 +--- 1 file changed, 157 insertions(+), 7 deletions(-) Index: linux-2.6.24-rc3-mm1/mm/memcontrol.c === --- linux-2.6.24-rc3

[PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [4/10] calculate mapper_ratio per cgroup

2007-11-26 Thread KAMEZAWA Hiroyuki
Define function for calculating mapped_ratio in memory cgroup. Changelog V1-V2 - Fixed possible divide-by-zero bug. - Use long to avoid 64bit division on 32 bit system. and does necessary type casts. - Added comments. Signed-off-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED] include/linux

[PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [5/10] calculate active/inactive imbalance per cgroup

2007-11-26 Thread KAMEZAWA Hiroyuki
calculate active/inactive imbalance per memory cgroup. Changelog V1 - V2: - removed total (just count inactive and active) - fixed comment - fixed return type to be long. Signed-off-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED] include/linux/memcontrol.h |8 mm/memcontrol.c

[PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [6/10] remember reclaim priority in memory cgroup

2007-11-26 Thread KAMEZAWA Hiroyuki
Functions to remember reclaim priority per cgroup (as zone-prev_priority) Signed-off-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED] include/linux/memcontrol.h | 23 +++ mm/memcontrol.c| 20 2 files changed, 43 insertions(+) Index: linux-2.6.24

[PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [7/10] calculate the number of pages to be scanned per cgroup

2007-11-26 Thread KAMEZAWA Hiroyuki
Define function for calculating the number of scan target on each Zone/LRU. Changelog V1-V2. - fixed types of variable. Signed-off-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED] include/linux/memcontrol.h | 15 +++ mm/memcontrol.c| 33 + 2

[PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [8/10] modifies vmscan.c for isolate globa/cgroup lru activity

2007-11-26 Thread KAMEZAWA Hiroyuki
as zone-prev_priority. This value is used for calc reclaim_mapped. Changelog V1-V2: - merged calc_reclaim_mapped patch in previous version. Signed-off-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED] mm/vmscan.c | 326

[PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [9/10] per zone lru for cgroup

2007-11-26 Thread KAMEZAWA Hiroyuki
-active_list mz-inactive_list Changelog v1-v2 - merged to mem_cgroup_per_zone struct. - handle page migraiton. Signed-off-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED] mm/memcontrol.c | 63 ++-- 1 file changed, 39 insertions(+), 24 deletions

[PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [10/10] per-zone-lock for cgroup

2007-11-26 Thread KAMEZAWA Hiroyuki
(page_cgroup); mz-lru_lock Signed-off-by: KAMEZAWA hiroyuki [EMAIL PROTECTED] mm/memcontrol.c | 71 ++-- 1 file changed, 44 insertions(+), 27 deletions(-) Index: linux-2.6.24-rc3-mm1/mm/memcontrol.c

Re: [PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [3/10] per-zone active inactive counter

2007-11-28 Thread KAMEZAWA Hiroyuki
On Wed, 28 Nov 2007 16:19:59 -0500 Lee Schermerhorn [EMAIL PROTECTED] wrote: As soon as this loop hits the first non-existent node on my platform, I get a NULL pointer deref down in __alloc_pages. Stack trace below. Perhaps N_POSSIBLE should be N_HIGH_MEMORY? That would require handling

Re: [PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [3/10] per-zone active inactive counter

2007-11-28 Thread KAMEZAWA Hiroyuki
On Thu, 29 Nov 2007 10:37:02 +0900 KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: Maybe zonelists of NODE_DATA() is not initialized. you are right. I think N_HIGH_MEMORY will be suitable here...(I'll consider node-hotplug case later.) Thank you for test! Could you try this ? Thanks, -Kame

Re: [PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [3/10] per-zone active inactive counter

2007-11-28 Thread KAMEZAWA Hiroyuki
On Thu, 29 Nov 2007 11:24:06 +0900 KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: On Thu, 29 Nov 2007 10:37:02 +0900 KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: Maybe zonelists of NODE_DATA() is not initialized. you are right. I think N_HIGH_MEMORY will be suitable here...(I'll consider node

Re: 2.6.24-rc3-mm2

2007-11-28 Thread KAMEZAWA Hiroyuki
+per-zone-and-reclaim-enhancements-for-memory-controller-take-3-add-scan_global_lru-macro.patch +per-zone-and-reclaim-enhancements-for-memory-controller-take-3-nid-zid-helper-function-for-cgroup.patch

Re: [PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [3/10] per-zone active inactive counter

2007-11-28 Thread KAMEZAWA Hiroyuki
On Thu, 29 Nov 2007 12:19:37 +0900 (JST) [EMAIL PROTECTED] (YAMAMOTO Takashi) wrote: @@ -651,10 +758,11 @@ /* Avoid race with charge */ atomic_set(pc-ref_cnt, 0); if (clear_page_cgroup(page, pc) == pc) { + int active;

Re: [PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [3/10] per-zone active inactive counter

2007-11-28 Thread KAMEZAWA Hiroyuki
On Thu, 29 Nov 2007 12:33:28 +0900 (JST) [EMAIL PROTECTED] (YAMAMOTO Takashi) wrote: +static inline struct mem_cgroup_per_zone * +mem_cgroup_zoneinfo(struct mem_cgroup *mem, int nid, int zid) +{ + if (!mem-info.nodeinfo[nid]) can this be true? YAMAMOTO Takashi When I set

Re: 2.6.24-rc3-mm2 (bugfix for memory cgroup per-zone-struct allocation.)

2007-11-28 Thread KAMEZAWA Hiroyuki
On Thu, 29 Nov 2007 12:23:29 +0900 KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: I noticed CONFIG_NUMA + CONFIG_CGROUP_MEM_CONT + CONFIG_SLUB cannot boot because of my patch. (SLAB is ok.) I'll post workaround soon. == This is a fix. tested on my ia64/NUMA box both on SLAB/SLUB. This patch

[PATCH][for -mm] fix accounting in vmscan.c for memory controller

2007-12-10 Thread KAMEZAWA Hiroyuki
) pages. - under cgroup: use up to limit. I think 2 accountings, ALLOCSTALL and DIRECT should be accounted only under global lru scan. They are accounted against memory shortage at alloc_pages(). Signed-off-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED] mm/vmscan.c |6 -- 1 file changed, 4

[DOC][for -mm] update Documentation/controller/memory.txt

2007-12-10 Thread KAMEZAWA Hiroyuki
Balbir-san, could you review this update ? -- Documentation updates for memory controller. Signed-off-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED] Index: linux-2.6.24-rc4-mm1/Documentation/controllers/memory.txt === --- linux-2.6.24-rc4

Re: [PATCH][for -mm] fix accounting in vmscan.c for memory controller

2007-12-10 Thread KAMEZAWA Hiroyuki
On Tue, 11 Dec 2007 10:44:36 +0530 Balbir Singh [EMAIL PROTECTED] wrote: Looks good to me. Acked-by: Balbir Singh [EMAIL PROTECTED] TODO: 1. Should we have vm_events for the memory controller as well? May be in the longer term ALLOC_STALL is recoreded as failcnt, I think. I think

Re: [PATCH][for -mm] fix accounting in vmscan.c for memory controller

2007-12-11 Thread KAMEZAWA Hiroyuki
On Tue, 11 Dec 2007 11:26:44 +0900 KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: Without this, ALLOCSTALL and PGSCAN_DIRECT increases too much unless there is no memory shortage. Sorry, Without this, ALLOCSTALL and PGSCAN_DIRECT increases too much even

  1   2   3   4   5   6   7   8   9   10   >