Re: [PATCH 1/2] gpio: davinci: Move fetching IRQ to beginning of probe

2018-06-12 Thread J, KEERTHY
On 6/12/2018 6:39 PM, Linus Walleij wrote: On Wed, Jun 6, 2018 at 11:18 AM, Keerthy wrote: Currently IRQ resource fetching is done at the very end of probe. In case the of IRQ resource not being ready, we defer probe and need to revert prior changes. Hence move it to the beginning of the

[PATCH v3 1/2] gpio: davinci: Shuffle IRQ resource fetching from DT to beginning of probe

2018-06-12 Thread Keerthy
This is needed in case of PROBE_DEFER if IRQ resource is not yet ready. Signed-off-by: Keerthy --- Tested for GPIO Interrupts on da850-lcdk board. Changes in v3: Changed type of bank_irq to int from unsigned * Changed irqs type from unsigned to int drivers/gpio/gpio-davinci.c | 29

[PATCH v3 2/2] gpio: davinci: Do not assume continuous IRQ numbering

2018-06-12 Thread Keerthy
Currently the driver assumes that the interrupts are continuous and does platform_get_irq only once and assumes the rest are continuous, instead call platform_get_irq for all the interrupts and store them in an array for later use. Signed-off-by: Keerthy --- Tested for GPIO Interrupts on da850

Re: [PATCH v2 1/2] gpio: davinci: Shuffle IRQ resource fetching from DT to beginning of probe

2018-06-11 Thread Keerthy
On Tuesday 12 June 2018 11:15 AM, Alexander Stein wrote: > On Tuesday, June 12, 2018, 7:27:52 AM CEST Keerthy wrote: >> This is needed in case of PROBE_DEFER if IRQ resource is not yet ready. >> >> Signed-off-by: Keerthy >> --- >> [...] >> --- a/drive

[PATCH v2 2/2] gpio: davinci: Do not assume continuous IRQ numbering

2018-06-11 Thread Keerthy
Currently the driver assumes that the interrupts are continuous and does platform_get_irq only once and assumes the rest are continuous, instead call platform_get_irq for all the interrupts and store them in an array for later use. Signed-off-by: Keerthy --- Tested for GPIO Interrupts on da850

[PATCH v2 1/2] gpio: davinci: Shuffle IRQ resource fetching from DT to beginning of probe

2018-06-11 Thread Keerthy
This is needed in case of PROBE_DEFER if IRQ resource is not yet ready. Signed-off-by: Keerthy --- Tested for GPIO Interrupts on da850-lcdk and keystone-k2g-evm boards. No Changes in v2 drivers/gpio/gpio-davinci.c | 29 +++-- 1 file changed, 11 insertions(+), 18

[PATCH 2/2] gpio: davinci: Do not assume continuous IRQ numbering

2018-06-06 Thread Keerthy
Currently the driver assumes that the interrupts are continuous and does platform_get_irq only once and assumes the rest are continuous, instead call platform_get_irq for all the interrupts and store them in an array for later use. Signed-off-by: Keerthy --- Tested for GPIO Interrupts on da850

[PATCH 1/2] gpio: davinci: Move fetching IRQ to beginning of probe

2018-06-06 Thread Keerthy
Currently IRQ resource fetching is done at the very end of probe. In case the of IRQ resource not being ready, we defer probe and need to revert prior changes. Hence move it to the beginning of the probe so as to avoid reverting. Signed-off-by: Keerthy --- Tested for GPIO Interrupts on da850

[PATCH v2] ARM: dts: da850: Fix interrups property for gpio

2018-06-05 Thread Keerthy
The intc #interrupt-cells is equal to 1. Currently gpio node has 2 cells per IRQ which is wrong. Remove the additional cell for each of the interrupts. Signed-off-by: Keerthy Fixes: 2e38b946dc54 ("ARM: davinci: da850: add GPIO DT node") --- Changes in v2: * Fixed $Subject arch/ar

Re: [PATCH] ARM: davinci: da850: Fix interrups property for gpio

2018-06-05 Thread Keerthy
On Tuesday 05 June 2018 03:35 PM, Keerthy wrote: > The intc #interrupt-cells is equal to 1. Currently gpio > node has 2 cells per IRQ which is wrong. Remove the additional > cell for each of the interrupts. Just noticed $Subject is not quite right. I will fix and send a v2

[PATCH] ARM: davinci: da850: Fix interrups property for gpio

2018-06-05 Thread Keerthy
The intc #interrupt-cells is equal to 1. Currently gpio node has 2 cells per IRQ which is wrong. Remove the additional cell for each of the interrupts. Signed-off-by: Keerthy Fixes: 2e38b946dc54 ("ARM: davinci: da850: add GPIO DT node") --- arch/arm/boot/dts/da850.dtsi | 6 +---

Re: [PATCH 01/14] memory: ti-emif-sram: Add resume function to recopy sram code

2018-05-23 Thread Keerthy
On Monday 16 April 2018 03:59 PM, Keerthy wrote: > > > On Thursday 12 April 2018 10:14 PM, santosh.shilim...@oracle.com wrote: >> On 4/11/18 9:53 PM, Keerthy wrote: >>> From: Dave Gerlach >>> >>> After an RTC+DDR cycle we lose sram context so emif pm

Re: [PATCH 12/14] OMAP: CLK: CLKSRC: Add suspend resume hooks

2018-05-22 Thread Keerthy
On Thursday 12 April 2018 07:57 PM, Tony Lindgren wrote: > * Keerthy [180412 03:56]: >> Add the save and restore for clksrc as part of suspend and resume >> so that it saves the counter value and restores. This is needed in >> modes like rtc+ddr in self-refresh not doing

Re: [PATCH 0/4] ARM: dts: am437x boards: Correct (again) tps65218 irq type

2018-05-08 Thread Keerthy
On Tuesday 08 May 2018 07:46 PM, Tony Lindgren wrote: > * Peter Ujfalusi [180508 13:22]: >> Hi, >> >> While based on the datasheet of tps65218 the INT is low active, the GIC_SPI >> does not support anythin but IRQ_TYPE_LEVEL_HIGH or IRQ_TYPE_EDGE_RISING: >> >> [2.761814] genirq: Setting trig

Re: [PATCH v2] thermal: ti-soc-thermal: fix incorrect entry in omap5430_adc_to_temp[]

2018-05-02 Thread Keerthy
On Wednesday 02 May 2018 07:44 PM, Bartlomiej Zolnierkiewicz wrote: > Entry for Index 941 has one zero too much. Fix it. > Acked-by: Keerthy > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > v2: > - Fix patch description. > > drivers/thermal/ti-soc-thermal/oma

Re: [PATCH 0/4] ARM: dts: am437x boards: Correct tps65218 irq type

2018-04-23 Thread Keerthy
stingly the am437x-sk-evm had IRQ_TYPE_LEVEL_HIGH, which is not matching > with the datasheet. > > [1] http://www.ti.com/lit/ds/symlink/tps65218.pdf, page 8. For the series: Reviewed-by: Keerthy Also Boot tested on AM437X-GP-EVM with the patch 1 of the series and i do not see the erro

Re: [PATCH 01/14] memory: ti-emif-sram: Add resume function to recopy sram code

2018-04-18 Thread Keerthy
On Thursday 12 April 2018 10:14 PM, santosh.shilim...@oracle.com wrote: > On 4/11/18 9:53 PM, Keerthy wrote: >> From: Dave Gerlach >> >> After an RTC+DDR cycle we lose sram context so emif pm functions present >> in sram are lost. We can check if the first byte of

[PATCH] regulator: lp87565: Enable LP87565_BUCK_CTRL_1_FPWM_MP_0_2

2018-04-17 Thread Keerthy
Buck10 is a multi(dual) phase regulator. So as part of enabling it turn on the LP87565_BUCK_CTRL_1_FPWM_MP_0_2 bit which forces it to operate always in multiphase and forced-PWM operation mode. This helps improve the transient voltage response while switching OPP. Signed-off-by: Keerthy

[PATCH] regulator: lp87565: Add margin while populating ramp_delay

2018-04-17 Thread Keerthy
reduce the default ramp_delay populated in the descriptors also by 15%. Signed-off-by: Keerthy --- drivers/regulator/lp87565-regulator.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/regulator/lp87565-regulator.c b/drivers/regulator/lp87565

Re: [PATCH 01/14] memory: ti-emif-sram: Add resume function to recopy sram code

2018-04-16 Thread Keerthy
On Thursday 12 April 2018 10:14 PM, santosh.shilim...@oracle.com wrote: > On 4/11/18 9:53 PM, Keerthy wrote: >> From: Dave Gerlach >> >> After an RTC+DDR cycle we lose sram context so emif pm functions present >> in sram are lost. We can check if the first byte of

Re: [PATCH 08/14] ARM: OMAP2: Add functions to save and restore pinctrl context.

2018-04-12 Thread Keerthy
On Thursday 12 April 2018 07:46 PM, Tony Lindgren wrote: > Hi, > > * Keerthy [180412 03:56]: >> From: Russ Dill >> >> This adds a pair of context save/restore functions to save/restore the >> state of a set of pinctrl registers. This simplifies some of the

[PATCH 03/14] ARM: OMAP2+: omap_hwmod: Introduce HWMOD_NEEDS_REIDLE

2018-04-11 Thread Keerthy
removed to avoid any conflicts and allow the proper pm layer to handle things when a driver is present. Signed-off-by: Dave Gerlach Signed-off-by: Keerthy --- arch/arm/mach-omap2/omap_device.c | 50 arch/arm/mach-omap2/omap_device.h | 1 + arch/arm

[PATCH 01/14] memory: ti-emif-sram: Add resume function to recopy sram code

2018-04-11 Thread Keerthy
functions to the previous address to maintain PM functionality. Signed-off-by: Dave Gerlach Signed-off-by: Keerthy --- drivers/memory/ti-emif-pm.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/memory/ti-emif-pm.c b/drivers/memory/ti-emif-pm.c index 632651f

[PATCH 05/14] ARM: OMAP2: Add functions to save and restore powerdomain context

2018-04-11 Thread Keerthy
need to change memory retention states, so make sure the restored state is different from the current state before we wait for a transition. Signed-off-by: Keerthy Signed-off-by: Dave Gerlach Signed-off-by: Russ Dill --- arch/arm/mach-omap2/powerdomain.c | 60

[PATCH 08/14] ARM: OMAP2: Add functions to save and restore pinctrl context.

2018-04-11 Thread Keerthy
/restore. This will also be necessary for hibernation and RTC only sleep, as all pinctrl registers all lost. Signed-off-by: Russ Dill Signed-off-by: Keerthy --- drivers/pinctrl/core.c | 1 + drivers/pinctrl/core.h | 1 - drivers/pinctrl/pinctrl-single.c | 50

[PATCH 09/14] ARM: OMAP2: Drop the concept of certain power domains not being able to lose context.

2018-04-11 Thread Keerthy
From: Russ Dill It isn't much of a win, and with hibernation, everything loses context. So Drop the concept of certain power domains not being able to lose context. Signed-off-by: Russ Dill Signed-off-by: Keerthy --- arch/arm/mach-omap2/powerdomain.c

[PATCH 06/14] ARM: AM33XX: Add functions to save/restore am33xx control registers.

2018-04-11 Thread Keerthy
From: Russ Dill These registers are part of the wkup domain and are lost during RTC only suspend and also hibernation, so storing/restoring their state is necessary. Signed-off-by: Russ Dill Signed-off-by: Keerthy --- arch/arm/mach-omap2/control.c | 84

[PATCH 12/14] OMAP: CLK: CLKSRC: Add suspend resume hooks

2018-04-11 Thread Keerthy
Add the save and restore for clksrc as part of suspend and resume so that it saves the counter value and restores. This is needed in modes like rtc+ddr in self-refresh not doing this stalls the time. Signed-off-by: Keerthy --- arch/arm/mach-omap2/timer.c | 37

[PATCH 11/14] gpio: omap: Restore power_mode configuration at resume time

2018-04-11 Thread Keerthy
red during non off-mode operation. Signed-off-by: Dave Gerlach Signed-off-by: Keerthy --- drivers/gpio/gpio-omap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index 34fde30..84d664b 100644 --- a/drivers/gpio/gpio-omap.c +++ b/drivers

[PATCH 13/14] ARM: hwmod: RTC: Don't assume lock/unlock will be called with irq enabled

2018-04-11 Thread Keerthy
the proper IRQ configuration is maintained. Signed-off-by: Dave Gerlach Signed-off-by: Keerthy --- arch/arm/mach-omap2/omap_hwmod_reset.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/omap_hwmod_reset.c b/arch/arm/mach-omap2

[PATCH 10/14] gpio: omap: Drop the concept of gpio banks not being able to lose context.

2018-04-11 Thread Keerthy
From: Russ Dill It isn't much of a win, and with hibernation, everything loses context. Signed-off-by: Russ Dill Signed-off-by: Keerthy --- drivers/gpio/gpio-omap.c| 38 - include/linux/platform_data/gpio-omap.h | 1 - 2 files change

[PATCH 14/14] ARM: OMAP2+: prm44xx: Introduce context save/restore for am43 PRCM IO

2018-04-11 Thread Keerthy
DeepSleep after resuming. Signed-off-by: Dave Gerlach Signed-off-by: Keerthy --- arch/arm/mach-omap2/prm.h | 2 ++ arch/arm/mach-omap2/prm44xx.c | 29 + 2 files changed, 31 insertions(+) diff --git a/arch/arm/mach-omap2/prm.h b/arch/arm/mach-omap2/prm.h index f0fb508

[PATCH 02/14] ARM: OMAP2: Add functions to save and restore clockdomain context en-masse.

2018-04-11 Thread Keerthy
From: Russ Dill This is used to support suspend modes like RTC-only and hibernate where the state of the registers controlling clockdomains is lost. Signed-off-by: Russ Dill Signed-off-by: Dave Gerlach Signed-off-by: Keerthy --- arch/arm/mach-omap2/clockdomain.c | 46

[PATCH 07/14] ARM: AM43XX: Add functions to save/restore am43xx control registers

2018-04-11 Thread Keerthy
From: Tero Kristo These registers are part of the wkup domain and are lost during RTC only suspend and also hibernation, so storing/restoring their state is necessary. Signed-off-by: Tero Kristo Signed-off-by: Keerthy --- arch/arm/mach-omap2/control.c | 94

[PATCH 00/14] arm: OMAP: AM437X: Save restores patches for rtc mode with DDR In self-refresh

2018-04-11 Thread Keerthy
CM IO Keerthy (1): OMAP: CLK: CLKSRC: Add suspend resume hooks Russ Dill (7): ARM: OMAP2: Add functions to save and restore clockdomain context en-masse. ARM: OMAP2: Add functions to save and restore omap hwmod context en-masse. ARM: OMAP2: Add functions to save and restore powerd

[PATCH 04/14] ARM: OMAP2: Add functions to save and restore omap hwmod context en-masse.

2018-04-11 Thread Keerthy
described above. This can be prevented by calling _reidle on all hwmods that need it for any module that is being disabled to return to it's previous state. Signed-off-by: Dave Gerlach Signed-off-by: Russ Dill Signed-off-by: Keerthy --- arch/arm/mach-omap2/omap_hwmod.c

Re: [PATCH v11 04/10] clocksource: timer-ti-dm: Replace architecture

2018-02-22 Thread Keerthy
On Friday 23 February 2018 12:15 AM, Tony Lindgren wrote: > * Ladislav Michl [180222 10:58]: >> On Thu, Feb 15, 2018 at 11:31:45AM +0530, Keerthy wrote: >>> Replace architecture specific guard with clocksource guard. >>> >>> Signed-off-by: Keerthy >>&g

Re: [PATCH] mfd: tps65218: Reorder tps65218_regulator_id enum

2018-02-15 Thread Keerthy
rong regulator ID. This causes LDO1 to fail to > suspend in tps65218_pmic_set_suspend_disable due to not having anything > probes for its strobe value. Fix the order in the enum so the probe > function works as the update intended. Reviewed-by: Keerthy > > Fixes: 2dc4940360d4 ("

[PATCH v11 02/10] arm: omap: timer: Wrap the inline functions under OMAP2PLUS define

2018-02-14 Thread Keerthy
Wrap the inline functions under OMAP2PLUS/OMAP1 defines. This patch also inlines omap_dm_timer_get_fclk function for non OMAP1 Config. Signed-off-by: Keerthy Tested-by: Ladislav Michl Reviewed-by: Sebastian Reichel --- arch/arm/plat-omap/include/plat/dmtimer.h | 17 - 1 file

[PATCH v11 10/10] arm: omap: pdata-quirks: Remove unused timer pdata

2018-02-14 Thread Keerthy
Remove unused timer pdata. Signed-off-by: Keerthy Reviewed-by: Sebastian Reichel Tested-by: Ladislav Michl --- arch/arm/mach-omap2/pdata-quirks.c | 32 1 file changed, 32 deletions(-) diff --git a/arch/arm/mach-omap2/pdata-quirks.c b/arch/arm/mach-omap2

[PATCH v11 06/10] timer-ti-dm: Add timer ops to the platform data structure

2018-02-14 Thread Keerthy
Add timer ops to the platform data structure Signed-off-by: Keerthy Reviewed-by: Sebastian Reichel Tested-by: Ladislav Michl --- include/linux/platform_data/dmtimer-omap.h | 38 ++ 1 file changed, 38 insertions(+) diff --git a/include/linux/platform_data/dmtimer

[PATCH v11 09/10] pwm: pwm-omap-dmtimer: Adapt driver to utilize dmtimer pdata ops

2018-02-14 Thread Keerthy
Adapt driver to utilize dmtimer pdata ops instead of pdata-quirks. Signed-off-by: Keerthy Acked-by: Neil Armstrong Reviewed-by: Claudiu Beznea --- drivers/pwm/pwm-omap-dmtimer.c | 68 ++ 1 file changed, 42 insertions(+), 26 deletions(-) diff --git a

[PATCH v11 08/10] clocksource: timer-ti-dm: Hook device platform data if not already assigned

2018-02-14 Thread Keerthy
From: Ladislav Michl In the case of device tree boot the device platform data is usually NULL so hook the platform data obtained from the match. As part of un-constify the platform_data pointer. Signed-off-by: Ladislav Michl Signed-off-by: Keerthy Reviewed-by: Sebastian Reichel --- drivers

[PATCH v11 05/10] arm: OMAP: Move dmtimer driver out of plat-omap to drivers under clocksource

2018-02-14 Thread Keerthy
Move the dmtimer driver out of plat-omap to clocksource. So that non-omap devices also could use this. No Code changes done to the driver file only renamed to timer-ti-dm.c. Also removed the config dependencies for OMAP_DM_TIMER. Signed-off-by: Keerthy Reviewed-by: Sebastian Reichel Tested-by

[PATCH v11 01/10] clocksource: dmtimer: Remove all the exports

2018-02-14 Thread Keerthy
Remove all the unwanted exports from the driver Signed-off-by: Keerthy Reviewed-by: Sebastian Reichel Tested-by: Ladislav Michl --- arch/arm/plat-omap/dmtimer.c | 27 --- 1 file changed, 27 deletions(-) diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap

[PATCH v11 03/10] arm: omap: Move dmtimer.h out of plat-omap

2018-02-14 Thread Keerthy
The header file is currently under plat-omap directory under arch/omap. Move this out to an accessible place. No Code changes done to the header file and renamed to timer-ti-dm.h. Signed-off-by: Keerthy Reviewed-by: Sebastian Reichel Tested-by: Ladislav Michl --- arch/arm/mach-omap1/pm.c

[PATCH v11 07/10] clocksource: timer-ti-dm: Populate the timer ops to the pdata

2018-02-14 Thread Keerthy
Add the timer ops to the platform data Signed-off-by: Keerthy Reviewed-by: Sebastian Reichel Tested-by: Ladislav Michl --- drivers/clocksource/timer-ti-dm.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource

[PATCH v11 04/10] clocksource: timer-ti-dm: Replace architecture

2018-02-14 Thread Keerthy
Replace architecture specific guard with clocksource guard. Signed-off-by: Keerthy Replace architecture specific defines with clocksource --- include/clocksource/timer-ti-dm.h | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/include/clocksource/timer-ti-dm.h b

[PATCH v11 00/10] omap: dmtimer: Move driver out of plat-omap

2018-02-14 Thread Keerthy
header file under OMAP2PLUS * Added a new of helper function to fetch plat_data from of node. Keerthy (9): clocksource: dmtimer: Remove all the exports arm: omap: timer: Wrap the inline functions under OMAP2PLUS define arm: omap: Move dmtimer.h out of plat-omap clocksource: timer-ti-dm

Re: [PATCH v7 5/9] dmtimer: Add timer ops to the platform data structure

2018-02-13 Thread Keerthy
On Tuesday 13 February 2018 08:16 AM, Suman Anna wrote: > On 01/09/2018 12:23 AM, J, KEERTHY wrote: >> Add timer ops to the platform data structure >> >> Signed-off-by: Keerthy >> Reviewed-by: Sebastian Reichel >> Tested-by: Ladislav Michl >> --- &

Re: [PATCH v7 4/9] arm: OMAP: Move dmtimer driver out of plat-omap to drivers under clocksource

2018-02-13 Thread Keerthy
On Tuesday 13 February 2018 07:54 AM, Suman Anna wrote: > Hi Keerthy, > > On 01/09/2018 12:23 AM, J, KEERTHY wrote: >> Move the dmtimer driver out of plat-omap to clocksource. >> So that non-omap devices also could use this. > > What non-omap devices do you have

Re: [PATCH v7 3/9] arm: omap: Move dmtimer.h out of plat-omap

2018-02-13 Thread Keerthy
On Tuesday 13 February 2018 07:36 AM, Suman Anna wrote: > Hi Keerthy, > > On 01/09/2018 12:23 AM, J, KEERTHY wrote: >> The header file is currently under plat-omap directory >> under arch/omap. Move this out to an accessible place. >> >> No Code changes done to

Re: [PATCH v7 3/9] arm: omap: Move dmtimer.h out of plat-omap

2018-02-13 Thread Keerthy
On Tuesday 13 February 2018 08:39 PM, Tony Lindgren wrote: > * Suman Anna [180213 02:07]: >> On 01/09/2018 12:23 AM, J, KEERTHY wrote: >>> The header file is currently under plat-omap directory >>> under arch/omap. Move this out to an accessible place. >>&

[PATCH v10 8/9] pwm: pwm-omap-dmtimer: Adapt driver to utilize dmtimer pdata ops

2018-01-24 Thread Keerthy
Adapt driver to utilize dmtimer pdata ops instead of pdata-quirks. Signed-off-by: Keerthy Acked-by: Neil Armstrong Reviewed-by: Claudiu Beznea --- Changes in v10: * Corrected a return variable. Changes in v9: * Reorganized the place where of_node_put was called. Changes in v8

Re: [PATCH v9 8/9] pwm: pwm-omap-dmtimer: Adapt driver to utilize dmtimer pdata ops

2018-01-24 Thread Keerthy
On Wednesday 24 January 2018 04:49 PM, Keerthy wrote: > Adapt driver to utilize dmtimer pdata ops instead of pdata-quirks. > > Signed-off-by: Keerthy > Acked-by: Neil Armstrong > Reviewed-by: Claudiu Beznea > --- > Changes in v9: > > * Reorganized the place w

[PATCH v9 8/9] pwm: pwm-omap-dmtimer: Adapt driver to utilize dmtimer pdata ops

2018-01-24 Thread Keerthy
Adapt driver to utilize dmtimer pdata ops instead of pdata-quirks. Signed-off-by: Keerthy Acked-by: Neil Armstrong Reviewed-by: Claudiu Beznea --- Changes in v9: * Reorganized the place where of_node_put was called. Changes in v8: * Added of_node_put call in success case of probe. Boot

Re: [PATCH v8 8/9] pwm: pwm-omap-dmtimer: Adapt driver to utilize dmtimer pdata ops

2018-01-24 Thread Keerthy
On Wednesday 24 January 2018 12:54 PM, Ladislav Michl wrote: > Keerthy, > > On Wed, Jan 24, 2018 at 11:14:40AM +0530, Keerthy wrote: >> Adapt driver to utilize dmtimer pdata ops instead of pdata-quirks. >> >> Signed-off-by: Keerthy >> Acked-by: Neil Armstron

Re: [PATCH 2/3] pwm: pwm-omap-dmtimer: Fix frequency when using prescaler

2018-01-23 Thread Keerthy
On Wednesday 24 January 2018 10:56 AM, Keerthy wrote: > > > On Monday 22 January 2018 04:23 PM, Ladislav Michl wrote: >> Dear Claudiu, >> >> On Mon, Jan 22, 2018 at 11:17:08AM +0200, Claudiu Beznea wrote: >>> On 17.01.2018 23:47, Ladislav Michl wrote: &

[PATCH v8 8/9] pwm: pwm-omap-dmtimer: Adapt driver to utilize dmtimer pdata ops

2018-01-23 Thread Keerthy
Adapt driver to utilize dmtimer pdata ops instead of pdata-quirks. Signed-off-by: Keerthy Acked-by: Neil Armstrong Reviewed-by: Claudiu Beznea --- Changes in v8: * Added of_node_put call in success case of probe. Boot tested on am437x-gp-evm and dra7xx-evm. Also compile tested

Re: [PATCH 2/3] pwm: pwm-omap-dmtimer: Fix frequency when using prescaler

2018-01-23 Thread Keerthy
see. > > Based on you previous suggestions found here: > https://patchwork.kernel.org/patch/10140209/ > I'd say this fix belongs to patch which introduces of_node_put() in the error > path. I'll then rebase this patches on top of the fix. Agreed. I missed the success path as i assumed only error paths needed te of_node_put(). I will post v8 of this patch alone as other patches can be left untouched. Hope that is okay. Regards, Keerthy > > Thank you, > ladis >

Re: [PATCH, v3] arm: omap2: timer: fix a kmemleak caused in omap_get_timer_dt

2018-01-12 Thread Keerthy
On 1/13/2018 2:47 AM, Grygorii Strashko wrote: On 01/12/2018 03:08 PM, Tony Lindgren wrote: * Grygorii Strashko [180112 20:36]: Hi On 01/10/2018 10:54 PM, Qi Hou wrote: When more than one GP timers are used as kernel system timers and the corresponding nodes in device-tree are marked wit

Re: NFSroot regression in next with handle inode->i_version

2018-01-10 Thread Keerthy
f that doesn't help you. > > OK great, thanks for the update. I'll test again tomorrow and will > whine again if I'm seeing issues :) This fixes nfs boot for me on dra7-evm. Regards, Keerthy > > Regards, > > Tony > -- > To unsubscribe from this list: se

[PATCH v7 5/9] dmtimer: Add timer ops to the platform data structure

2018-01-08 Thread Keerthy
Add timer ops to the platform data structure Signed-off-by: Keerthy Reviewed-by: Sebastian Reichel Tested-by: Ladislav Michl --- include/linux/platform_data/dmtimer-omap.h | 38 ++ 1 file changed, 38 insertions(+) diff --git a/include/linux/platform_data/dmtimer

[PATCH v7 4/9] arm: OMAP: Move dmtimer driver out of plat-omap to drivers under clocksource

2018-01-08 Thread Keerthy
Move the dmtimer driver out of plat-omap to clocksource. So that non-omap devices also could use this. No Code changes done to the driver file only renamed to timer-dm.c. Also removed the config dependencies for OMAP_DM_TIMER. Signed-off-by: Keerthy Reviewed-by: Sebastian Reichel Tested-by

[PATCH v7 6/9] clocksource: dmtimer: Populate the timer ops to the pdata

2018-01-08 Thread Keerthy
Add the timer ops to the platform data Signed-off-by: Keerthy Reviewed-by: Sebastian Reichel Tested-by: Ladislav Michl --- drivers/clocksource/timer-dm.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/clocksource/timer-dm.c b/drivers/clocksource/timer

[PATCH v7 3/9] arm: omap: Move dmtimer.h out of plat-omap

2018-01-08 Thread Keerthy
The header file is currently under plat-omap directory under arch/omap. Move this out to an accessible place. No Code changes done to the header file. Signed-off-by: Keerthy Reviewed-by: Sebastian Reichel Tested-by: Ladislav Michl --- arch/arm/mach-omap1/pm.c

[PATCH v7 9/9] arm: omap: pdata-quirks: Remove unused timer pdata

2018-01-08 Thread Keerthy
Remove unused timer pdata. Signed-off-by: Keerthy Reviewed-by: Sebastian Reichel Tested-by: Ladislav Michl --- arch/arm/mach-omap2/pdata-quirks.c | 32 1 file changed, 32 deletions(-) diff --git a/arch/arm/mach-omap2/pdata-quirks.c b/arch/arm/mach-omap2

[PATCH v7 8/9] pwm: pwm-omap-dmtimer: Adapt driver to utilize dmtimer pdata ops

2018-01-08 Thread Keerthy
Adapt driver to utilize dmtimer pdata ops instead of pdata-quirks. Signed-off-by: Keerthy Acked-by: Neil Armstrong Reviewed-by: Claudiu Beznea --- drivers/pwm/pwm-omap-dmtimer.c | 68 ++ 1 file changed, 43 insertions(+), 25 deletions(-) diff --git a

[PATCH v7 1/9] clocksource: dmtimer: Remove all the exports

2018-01-08 Thread Keerthy
Remove all the unwanted exports from the driver Signed-off-by: Keerthy Reviewed-by: Sebastian Reichel Tested-by: Ladislav Michl --- arch/arm/plat-omap/dmtimer.c | 27 --- 1 file changed, 27 deletions(-) diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap

[PATCH v7 0/9] omap: dmtimer: Move driver out of plat-omap

2018-01-08 Thread Keerthy
* Added a new of helper function to fetch plat_data from of node. Keerthy (8): clocksource: dmtimer: Remove all the exports arm: omap: timer: Wrap the inline functions under OMAP2PLUS define arm: omap: Move dmtimer.h out of plat-omap arm: OMAP: Move dmtimer driver out of plat-omap to

[PATCH v7 2/9] arm: omap: timer: Wrap the inline functions under OMAP2PLUS define

2018-01-08 Thread Keerthy
Wrap the inline functions under OMAP2PLUS/OMAP1 defines. Signed-off-by: Keerthy Tested-by: Ladislav Michl --- arch/arm/plat-omap/include/plat/dmtimer.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/arm/plat-omap/include/plat/dmtimer.h b/arch/arm/plat-omap

[PATCH v7 7/9] clocksource: timer-dm: Hook device platform data if not already assigned

2018-01-08 Thread Keerthy
From: Ladislav Michl In the case of device tree boot the device platform data is usually NULL so hook the platform data obtained from the match. As part of un-constify the platform_data pointer. Signed-off-by: Ladislav Michl Signed-off-by: Keerthy --- drivers/clocksource/timer-dm.c | 10

Re: [PATCH v6 08/10] pwm: pwm-omap-dmtimer: Adapt driver to utilize dmtimer pdata ops

2018-01-08 Thread Keerthy
On 1/8/2018 8:17 PM, Claudiu Beznea wrote: On 08.01.2018 16:44, Neil Armstrong wrote: On 08/01/2018 15:33, Keerthy wrote: On Monday 08 January 2018 02:14 PM, Claudiu Beznea wrote: On 02.01.2018 12:09, Keerthy wrote: Adapt driver to utilize dmtimer pdata ops instead of pdata-quirks

Re: [PATCH v6 08/10] pwm: pwm-omap-dmtimer: Adapt driver to utilize dmtimer pdata ops

2018-01-08 Thread Keerthy
On Monday 08 January 2018 02:14 PM, Claudiu Beznea wrote: > > > On 02.01.2018 12:09, Keerthy wrote: >> Adapt driver to utilize dmtimer pdata ops instead of pdata-quirks. >> >> Signed-off-by: Keerthy >> Tested-by: Ladislav Michl >> ---

Re: [PATCH v6 00/10] omap: dmtimer: Move driver out of plat-omap

2018-01-07 Thread Keerthy
On 1/2/2018 3:39 PM, Keerthy wrote: The series moves dmtimer out of plat-omap to drivers/clocksource. The series also does a bunch of changes to pwm-omap-dmtimer code to adapt to the driver migration and clean up plat specific pdata-quirks and use the dmtimer platform data. Boot tested on

Re: [PATCH v6 10/10] clocksource: timer-dm: Check prescaler value

2018-01-07 Thread Keerthy
On 1/5/2018 4:17 AM, Ladislav Michl wrote: On Tue, Jan 02, 2018 at 03:39:59PM +0530, Keerthy wrote: From: Ladislav Michl Invalid prescaler value is silently ignored. Fix that by returning -EINVAL in such case. As invalid value disabled use of the prescaler, use -1 explicitely for that

[PATCH v6 10/10] clocksource: timer-dm: Check prescaler value

2018-01-02 Thread Keerthy
From: Ladislav Michl Invalid prescaler value is silently ignored. Fix that by returning -EINVAL in such case. As invalid value disabled use of the prescaler, use -1 explicitely for that purpose. Signed-off-by: Ladislav Michl --- drivers/clocksource/timer-dm.c | 3 +++ 1 file changed, 3 inserti

[PATCH v6 06/10] clocksource: dmtimer: Populate the timer ops to the pdata

2018-01-02 Thread Keerthy
Add the timer ops to the platform data Signed-off-by: Keerthy Reviewed-by: Sebastian Reichel Tested-by: Ladislav Michl --- drivers/clocksource/timer-dm.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/clocksource/timer-dm.c b/drivers/clocksource/timer

[PATCH v6 03/10] arm: omap: Move dmtimer.h out of plat-omap

2018-01-02 Thread Keerthy
The header file is currently under plat-omap directory under arch/omap. Move this out to an accessible place. No Code changes done to the header file. Signed-off-by: Keerthy Reviewed-by: Sebastian Reichel Tested-by: Ladislav Michl --- arch/arm/mach-omap1/pm.c

[PATCH v6 01/10] clocksource: dmtimer: Remove all the exports

2018-01-02 Thread Keerthy
Remove all the unwanted exports from the driver Signed-off-by: Keerthy Reviewed-by: Sebastian Reichel Tested-by: Ladislav Michl --- arch/arm/plat-omap/dmtimer.c | 27 --- 1 file changed, 27 deletions(-) diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap

[PATCH v6 09/10] arm: omap: pdata-quirks: Remove unused timer pdata

2018-01-02 Thread Keerthy
Remove unused timer pdata. Signed-off-by: Keerthy Reviewed-by: Sebastian Reichel Tested-by: Ladislav Michl --- arch/arm/mach-omap2/pdata-quirks.c | 32 1 file changed, 32 deletions(-) diff --git a/arch/arm/mach-omap2/pdata-quirks.c b/arch/arm/mach-omap2

[PATCH v6 04/10] arm: OMAP: Move dmtimer driver out of plat-omap to drivers under clocksource

2018-01-02 Thread Keerthy
Move the dmtimer driver out of plat-omap to clocksource. So that non-omap devices also could use this. No Code changes done to the driver file only renamed to timer-dm.c. Also removed the config dependencies for OMAP_DM_TIMER. Signed-off-by: Keerthy Reviewed-by: Sebastian Reichel Tested-by

[PATCH v6 08/10] pwm: pwm-omap-dmtimer: Adapt driver to utilize dmtimer pdata ops

2018-01-02 Thread Keerthy
Adapt driver to utilize dmtimer pdata ops instead of pdata-quirks. Signed-off-by: Keerthy Tested-by: Ladislav Michl --- drivers/pwm/pwm-omap-dmtimer.c | 39 ++- 1 file changed, 22 insertions(+), 17 deletions(-) diff --git a/drivers/pwm/pwm-omap-dmtimer.c b

[PATCH v6 07/10] clocksource: timer-dm: Hook device platform data if not already assigned

2018-01-02 Thread Keerthy
From: Ladislav Michl In the case of device tree boot the device platform data is usually NULL so hook the platform data obtained from the match. As part of un-constify the platform_data pointer. Signed-off-by: Ladislav Michl Signed-off-by: Keerthy --- drivers/clocksource/timer-dm.c | 10

[PATCH v6 05/10] dmtimer: Add timer ops to the platform data structure

2018-01-02 Thread Keerthy
Add timer ops to the platform data structure Signed-off-by: Keerthy Reviewed-by: Sebastian Reichel Tested-by: Ladislav Michl --- include/linux/platform_data/dmtimer-omap.h | 38 ++ 1 file changed, 38 insertions(+) diff --git a/include/linux/platform_data/dmtimer

[PATCH v6 00/10] omap: dmtimer: Move driver out of plat-omap

2018-01-02 Thread Keerthy
Changes from v3: * Reverted to v2 approach of using dev_get_platdata to fetch dmtimer ops. Changes from V2: * Wrapped the inline functions in header file under OMAP2PLUS * Added a new of helper function to fetch plat_data from of node. Keerthy (8): clocksource: dmtimer: Remove all the

[PATCH v6 02/10] arm: omap: timer: Wrap the inline functions under OMAP2PLUS define

2018-01-02 Thread Keerthy
Wrap the inline functions under OMAP2PLUS/OMAP1 defines. Signed-off-by: Keerthy Tested-by: Ladislav Michl --- arch/arm/plat-omap/include/plat/dmtimer.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/arm/plat-omap/include/plat/dmtimer.h b/arch/arm/plat-omap

Re: [PATCH] pci: dwc: pci-dra7xx: Make shutdown handler static

2017-12-20 Thread Keerthy
On Wednesday 20 December 2017 03:59 PM, Lorenzo Pieralisi wrote: > On Fri, Dec 01, 2017 at 04:53:14PM +, Lorenzo Pieralisi wrote: >> On Fri, Dec 01, 2017 at 10:43:53AM +0530, Keerthy wrote: >>> >>> >>> On Friday 01 December 2017 10:36 AM, Vignesh R wrot

Re: [PATCH v5 7/8] pwm: pwm-omap-dmtimer: Adapt driver to utilize dmtimer pdata ops

2017-12-19 Thread Keerthy
On Tuesday 19 December 2017 08:51 PM, Ladislav Michl wrote: > On Tue, Dec 19, 2017 at 01:55:48PM +0530, Keerthy wrote: >> On Tuesday 19 December 2017 10:28 AM, Keerthy wrote: >>> On Monday 18 December 2017 06:25 PM, Keerthy wrote: >>>> On Monday 18 December 2017

Re: [PATCH 1/2] clocksource: timer-dm: Make unexported functions static

2017-12-19 Thread Keerthy
or now want to keep the changes minimal. Some of the functions that you are removing in this patch might be needed and can be added for ops in future. So i will let this be separate patch. Thanks, Keerthy > > Signed-off-by: Ladislav Michl > --- > drivers/clocksourc

Re: [PATCH 2/2] clocksource: timer-dm: Check prescaler value

2017-12-19 Thread Keerthy
On Monday 18 December 2017 05:01 PM, Ladislav Michl wrote: > Invalid prescaler value is silently ignored. Fix that > by returning -EINVAL in such case. As invalid value > disabled use of the prescaler, use -1 explicitely for > that purpose. Thanks. I will post this as part of my migration series

Re: [PATCH v5 7/8] pwm: pwm-omap-dmtimer: Adapt driver to utilize dmtimer pdata ops

2017-12-19 Thread Keerthy
On Tuesday 19 December 2017 10:28 AM, Keerthy wrote: > > > On Monday 18 December 2017 06:25 PM, Keerthy wrote: >> >> >> On Monday 18 December 2017 03:01 PM, Ladislav Michl wrote: >>> Keerthy, >>> >>> On Tue, Dec 12, 2017 at 11:42:16AM +053

Re: [PATCH v5 7/8] pwm: pwm-omap-dmtimer: Adapt driver to utilize dmtimer pdata ops

2017-12-18 Thread Keerthy
On Monday 18 December 2017 06:25 PM, Keerthy wrote: > > > On Monday 18 December 2017 03:01 PM, Ladislav Michl wrote: >> Keerthy, >> >> On Tue, Dec 12, 2017 at 11:42:16AM +0530, Keerthy wrote: >>> Adapt driver to utilize dmtimer pdata ops instead of pdata-qu

Re: [PATCH v5 7/8] pwm: pwm-omap-dmtimer: Adapt driver to utilize dmtimer pdata ops

2017-12-18 Thread Keerthy
On Monday 18 December 2017 03:01 PM, Ladislav Michl wrote: > Keerthy, > > On Tue, Dec 12, 2017 at 11:42:16AM +0530, Keerthy wrote: >> Adapt driver to utilize dmtimer pdata ops instead of pdata-quirks. >> >> Signed-off-by: Keerthy >> --- >>

Re: [PATCH v5 0/8] omap: dmtimer: Move driver out of plat-omap

2017-12-18 Thread Keerthy
On Monday 18 December 2017 04:46 PM, Ladislav Michl wrote: > Keerthy, > > On Tue, Dec 12, 2017 at 11:42:09AM +0530, Keerthy wrote: >> The series moves dmtimer out of plat-omap to drivers/clocksource. >> The series also does a bunch of changes to pwm-omap-dmtimer code >

Re: [PATCH v5 1/8] clocksource: dmtimer: Remove all the exports

2017-12-12 Thread Keerthy
On Tuesday 12 December 2017 01:49 PM, Ladislav Michl wrote: > On Tue, Dec 12, 2017 at 01:38:04PM +0530, Keerthy wrote: >> On Tuesday 12 December 2017 01:31 PM, Ladislav Michl wrote: >>> On Tue, Dec 12, 2017 at 01:01:51PM +0530, Keerthy wrote: >>>> >>>>

Re: [PATCH v5 1/8] clocksource: dmtimer: Remove all the exports

2017-12-12 Thread Keerthy
On Tuesday 12 December 2017 01:31 PM, Ladislav Michl wrote: > On Tue, Dec 12, 2017 at 01:01:51PM +0530, Keerthy wrote: >> >> >> On Tuesday 12 December 2017 12:46 PM, Ladislav Michl wrote: >>> Keerthy, >>> >>> On Tue, Dec 12, 2017 at 11:42:10AM +0

Re: [PATCH v5 1/8] clocksource: dmtimer: Remove all the exports

2017-12-11 Thread Keerthy
On Tuesday 12 December 2017 12:46 PM, Ladislav Michl wrote: > Keerthy, > > On Tue, Dec 12, 2017 at 11:42:10AM +0530, Keerthy wrote: >> Remove all the unwanted exports from the driver > > I'm adding event capture capability to the pwm-omap driver and so far us

[PATCH v5 0/8] omap: dmtimer: Move driver out of plat-omap

2017-12-11 Thread Keerthy
inline functions in header file under OMAP2PLUS * Added a new of helper function to fetch plat_data from of node. Keerthy (8): clocksource: dmtimer: Remove all the exports arm: omap: timer: Wrap the inline functions under OMAP2PLUS define arm: omap: Move dmtimer.h out of plat-omap arm: OMAP

[PATCH v5 5/8] dmtimer: Add timer ops to the platform data structure

2017-12-11 Thread Keerthy
Add timer ops to the platform data structure Signed-off-by: Keerthy Reviewed-by: Sebastian Reichel --- Changes in v3: * Added Sebastian's Reviewed-by. Changes in v2: * No code changes in this v2 version. Only enhanced patch statistics for renames. include/linux/platform

<    1   2   3   4   5   6   7   8   9   10   >