[RFC][PATCH -mm take3 4/6][resend] using symlink for the net_device

2007-03-20 Thread Keiichi KII
From: Keiichi KII <[EMAIL PROTECTED]> We use symbolic link for net_device. The link in sysfs represents the corresponding network etherdevice. -+- /sys/class/misc/ |-+- netconsole/ |-+- port1/ | |--- id [r--r--r--] id | |--- net: [rw-r--r--] net_dev: eth

[RFC][PATCH -mm take3 5/6][resend] switch function of netpoll

2007-03-20 Thread Keiichi KII
From: Keiichi KII <[EMAIL PROTECTED]> This patch contains switch function of netpoll. If "enabled" attribute of certain port is '1', this port is used and the configurations of this port are uable to change. If "enabled" attribute of certain port is

[RFC][PATCH -mm take3 6/6][resend] add ioctls for adding/removing target

2007-03-20 Thread Keiichi KII
From: Keiichi KII <[EMAIL PROTECTED]> We add ioctls for adding/removing target. If we use NETCONSOLE_ADD_TARGET ioctl, we can dynamically add netconsole target. If we use NETCONSOLE_REMOVE_TARGET ioctl, we can dynamically remoe netconsole target. We attach a sample program for ioctl.

Re: [RFC][PATCH -mm take3 2/6][resend] support multiple logging

2007-03-22 Thread Keiichi KII
Alexey Dobriyan wrote: On 3/20/07, Keiichi KII <[EMAIL PROTECTED]> wrote: This patch contains the following changes for supporting multiple logging agents. +#define CONFIG_SEPARATOR ";" CONFIG_* is reserved for configuration options. Since you use it in only one place ju

Re: [RFC][PATCH -mm take3 6/6][resend] add ioctls for adding/removing target

2007-03-22 Thread Keiichi KII
Sorry, I sent the incomplete sample program. So, I send the complete one again. Any comments welcom. #include #include #include #include #include #include #include #include #include #include #define NETCONSOLE_DEV_NAME "/dev/netconsole" #define ARRAY_SIZE(x) (sizeof(x) /

[RFC][PATCH -mm take5 0/7] proposal for dynamic configurable netconsole

2007-06-13 Thread Keiichi KII
From: Keiichi KII <[EMAIL PROTECTED]> The netconsole is a very useful module for collecting kernel message under certain circumstances(e.g. disk logging fails, serial port is unavailable). But current netconsole is not flexible. For example, if you want to change ip address for logging

[RFC][PATCH -mm take5 1/7] marking __init

2007-06-13 Thread Keiichi KII
From: Keiichi KII <[EMAIL PROTECTED]> This patch contains the following cleanups. - add __init for initialization functions(option_setup() and init_netconsole()). Acked-by: Matt Mackall <[EMAIL PROTECTED]> Signed-off-by: Keiichi KII <[EMAIL PROTECTED]> Signed-off-by: Takay

[RFC][PATCH -mm take5 2/7] support multiple logging

2007-06-13 Thread Keiichi KII
From: Keiichi KII <[EMAIL PROTECTED]> This patch contains the following changes for supporting multiple logging agents. 1. extend netconsole to multiple netpolls To send kernel messages to multiple logging agents, extend netcosnole to be able to use multiple netpolls. Each netpoll

[RFC][PATCH -mm take5 3/7] add interface for netconsole using sysfs

2007-06-13 Thread Keiichi KII
From: Keiichi KII <[EMAIL PROTECTED]> This patch contains the following changes. create a sysfs entry for netconsole in /sys/class/misc. This entry has elements related to netconsole as follows. You can change configuration of netconsole(writable attributes such as IP address, port number

[RFC][PATCH -mm take5 4/7] using symlink for the net_device

2007-06-13 Thread Keiichi KII
From: Keiichi KII <[EMAIL PROTECTED]> We use symbolic link for net_device. The link in sysfs represents the corresponding network etherdevice. -+- /sys/class/misc/ |-+- netconsole/ |-+- port1/ | |--- id [r--r--r--] id | |--- net: [r--r--r--] net_dev: eth

[RFC][PATCH -mm take5 5/7] switch function of netpoll

2007-06-13 Thread Keiichi KII
From: Keiichi KII <[EMAIL PROTECTED]> This patch contains switch function of netpoll. If "enabled" attribute of certain port is '1', this port is used and the configurations of this port are unable to change. If "enabled" attribute of certain port is

[RFC][PATCH -mm take5 6/7] add ioctls for adding/removing target

2007-06-13 Thread Keiichi KII
From: Keiichi KII <[EMAIL PROTECTED]> We add ioctls for adding/removing target. If we use NETCONSOLE_ADD_TARGET ioctl, we can dynamically add netconsole target. If we use NETCONSOLE_REMOVE_TARGET ioctl, we can dynamically remoe netconsole target. We attach a sample program for ioctl.

[RFC][PATCH -mm take5 7/7] update documentation

2007-06-13 Thread Keiichi KII
From: Keiichi KII <[EMAIL PROTECTED]> update Documentation/networking/netconsole.txt - how to use sysfs for dynamic configurability - how to use ioctl for dynamic configurability Signed-off-by: Keiichi KII <[EMAIL PROTECTED]> --- Index: mm/Documentation/networking/ne

Re: [RFC][PATCH -mm take5 3/7] add interface for netconsole using sysfs

2007-06-19 Thread Keiichi KII
miscdev_configured; Is this really required? We just return with error if misc_register() fails during module init time itself, so it's not really useful ever, is it? You're right. It isn't required. Thanks -- Keiichi KII NEC Corporation OSS Platform Development Division E-mail: [EMAIL PROTECTED

Re: [RFC][PATCH -mm take5 4/7] using symlink for the net_device

2007-06-19 Thread Keiichi KII
his up, but I'm misplacing the abobe code? or it isn't appropriate about coding style? Thanks -- Keiichi KII NEC Corporation OSS Platform Development Division E-mail: [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [RFC][PATCH -mm take5 4/7] using symlink for the net_device

2007-06-19 Thread Keiichi KII
vice->kobj; nt->obj.ktype = _ktype; - return kobject_register(>obj); + retval = kobject_register(>obj); + name = make_netdev_class_name(nt->np.dev_name); + if (!name) + return -ENOMEM; Just call kasprintf() directly, why the obfuscation? I dre

Re: [RFC][PATCH -mm take5 6/7] add ioctls for adding/removing target

2007-06-19 Thread Keiichi KII
les. 4. Netlink does feel like overkill for this. Although newer generic netlink makes it easier. So, I implemented ioctls to add/remove port like this patch on the tty driver. But I'm going to search configfs. Thank you for you information. Thanks -- Keiichi KII NEC Corporation OSS Platf

Re: [RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-20 Thread Keiichi KII
and reviews. -- Keiichi KII NEC Corporation OSS Promotion Center E-mail: [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please re

Re: [RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-20 Thread Keiichi KII
Please include an update to Documentation/networking/netconsole.txt OK, I update the documnet for the added functions in next patches. Thank you for your comments. -- Keiichi KII NEC Corporation OSS Promotion Center E-mail: [EMAIL PROTECTED] - To unsubscribe from this list: send the line

Re: [RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-24 Thread Keiichi KII
On Fri, 20 Apr 2007 18:51:13 +0900 Keiichi KII <[EMAIL PROTECTED]> wrote: I started to do some cleanups and fixups here, but abandoned it when it was all getting a bit large. Here are some fixes against this patch: I'm going to fix my patches by following your reviews and send new p

Re: [RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-24 Thread Keiichi KII
procfs instead of sysfs to show the configurations of netconsole? If so, I have a question. I thought that "procfs use things related to process as far as possible". Is it no problem to use procfs here? -- Keiichi KII NEC Corporation OSS Promotion Center E-mail: [EMAIL

Re: [RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-25 Thread Keiichi KII
Thank you for your comments. Any comments very welcome. -- Keiichi KII NEC Corporation OSS Promotion Center E-mail: [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.

[RFC][PATCH -mm take4 1/6] marking __init

2007-04-18 Thread Keiichi KII
From: Keiichi KII <[EMAIL PROTECTED]> This patch contains the following cleanups. - add __init for initialization functions(option_setup() and init_netconsole()). Acked-by: Matt Mackall <[EMAIL PROTECTED]> Signed-off-by: Keiichi KII <[EMAIL PROTECTED]> Signed-off-by: Takay

[RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-18 Thread Keiichi KII
From: Keiichi KII <[EMAIL PROTECTED]> This patch contains the following changes for supporting multiple logging agents. 1. extend netconsole to multiple netpolls To send kernel messages to multiple logging agents, extend netcosnole to be able to use multiple netpolls. Each netpoll

[RFC][PATCH -mm take4 3/6] add interface for netconsole using sysfs

2007-04-18 Thread Keiichi KII
From: Keiichi KII <[EMAIL PROTECTED]> This patch contains the following changes. create a sysfs entry for netconsole in /sys/class/misc. This entry has elements related to netconsole as follows. You can change configuration of netconsole(writable attributes such as IP address, port number

[RFC][PATCH -mm take4 4/6] using symlink for the net_device

2007-04-18 Thread Keiichi KII
From: Keiichi KII <[EMAIL PROTECTED]> We use symbolic link for net_device. The link in sysfs represents the corresponding network etherdevice. -+- /sys/class/misc/ |-+- netconsole/ |-+- port1/ | |--- id [r--r--r--] id | |--- net: [rw-r--r--] net_dev: eth

[RFC][PATCH -mm take4 5/6] switch function of netpoll

2007-04-18 Thread Keiichi KII
From: Keiichi KII <[EMAIL PROTECTED]> This patch contains switch function of netpoll. If "enabled" attribute of certain port is '1', this port is used and the configurations of this port are uable to change. If "enabled" attribute of certain port is

[RFC][PATCH -mm take4 6/6] add ioctls for adding/removing target

2007-04-18 Thread Keiichi KII
From: Keiichi KII <[EMAIL PROTECTED]> We add ioctls for adding/removing target. If we use NETCONSOLE_ADD_TARGET ioctl, we can dynamically add netconsole target. If we use NETCONSOLE_REMOVE_TARGET ioctl, we can dynamically remoe netconsole target. We attach a sample program for ioctl.

[RFC][PATCH -mm take4 0/6] proposal for dynamic configurable netconsole

2007-04-18 Thread Keiichi KII
From: Keiichi KII <[EMAIL PROTECTED]> The netconsole is a very useful module for collecting kernel message under certain circumstances(e.g. disk logging fails, serial port is unavailable). But current netconsole is not flexible. For example, if you want to change ip address for logging

Re: [RFC][PATCH v2 -mm 0/9] netconsole: Multiple targets and dynamic reconfigurability

2007-07-11 Thread Keiichi KII
Hi Satyam, I'm going to test/review these patches and report the result of tests on IA64/x86 until this Friday. > [0/9] netconsole: Multiple targets and dynamic reconfigurability > > This patchset is a rework of the original idea and patches posted by > Keiichi Kii and Takayoshi Ko

Re: [PATCH v2 -mm 9/9] netconsole: Support dynamic reconfiguration using configfs

2007-07-12 Thread Keiichi KII
e_target_put(nt); > } > spin_unlock_irqrestore(_list_lock, flags); > } I created the following patch for performing some tests. If there is nothing wrong with the patch, I'm going to continue to test. Signed-off-by: Keiichi Kii <[EMAIL PROTECTED]> Index: mm/dr

Re: [RFC][PATCH -mm take5 4/7] using symlink for the net_device

2007-06-21 Thread Keiichi KII
ss_name() here. I'd definitely recommend not obfuscating this simple functionality here. I understand. The wrapper method such as make_netdev_class_name() isn't appropriate in this case. Thanks -- Keiichi KII NEC Corporation OSS Platform Development Division E-mail: [EMAIL PROTECTED] - To unsubscribe

Re: [RFC][PATCH -mm take5 6/7] add ioctls for adding/removing target

2007-06-21 Thread Keiichi KII
"eth0")? I'm going to search configfs and modify interface to configfs. Thanks -- Keiichi KII NEC Corporation OSS Platform Development Division E-mail: [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [RFC][PATCH -mm 0/9] netconsole: Multiple targets and dynamic reconfigurability

2007-07-04 Thread Keiichi KII
patch and submit them to this list again? Anybody could give me an advice? -- Keiichi KII NEC Corporation OSS Platform Development Division E-mail: [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTE

Re: [PATCH -mm 8/9] netconsole: Update documentation for dynamic reconfigurability

2007-07-05 Thread Keiichi KII
ave enough time now. So I will check your patches more specific at the weekend. Thanks -- Keiichi KII NEC Corporation OSS Platform Development Division E-mail: [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messag

[PATCH 1/2] fix typo in SubmittingPatches

2007-10-26 Thread Keiichi KII
From: Keiichi Kii <[EMAIL PROTECTED]> Fix typo. Signed-off-by: Keiichi Kii <[EMAIL PROTECTED]> Cc: Andy Whitcroft <[EMAIL PROTECTED]> --- Index: trunk/Documentation/SubmittingPatches === --- trunk.

[PATCH 2/2] add SubmittingPatches to Documentation/ja_JP

2007-10-26 Thread Keiichi KII
From: Keiichi Kii <[EMAIL PROTECTED]> This patch adds SubmittingPatches translated into Japanese to Documentation/ja_JP directory. I attach the patch because there is a possibility that MUA will change the character encoding sometimes. Signed-off-by: Keiichi KII <[EMAIL

[PATCH 0/2] Japanese translation of Documentation/SubmittingPatches

2007-10-26 Thread Keiichi KII
From: Keiichi Kii <[EMAIL PROTECTED]> Hi all, Currently, HOWTO and stable_api_nonsense.txt are included in Documentation/"each country"/ as policy documents. Greg K-H said the following in this thread: (http://www.uwsg.iu.edu/hypermail/linux/kernel/0706.1/0897.html) >

Re: [PATCH 2/2] add SubmittingPatches to Documentation/ja_JP

2007-10-26 Thread Keiichi KII
racter code because there was no probelm in my environment. But, I used mew as MUA and the patch was recognized as Ascii, not UTF-8. I think alternative based on your suggestions. Thanks --yoshfuji In article <[EMAIL PROTECTED]> (at Fri, 26 Oct 2007 15:55:24 +0900), Keiichi KII <[E

Re: [PATCH 1/2] fix typo in SubmittingPatches

2007-10-29 Thread Keiichi KII
t modify the moved code at all in the same patch which moves it. Tahnks for your point. I will fix this sentence as above. -- Keiichi KII NEC Corporation OSS Platform Development Division E-mail: [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in t

Re: [PATCH 1/2] fix typo in SubmittingPatches

2007-10-29 Thread Keiichi KII
From: Keiichi Kii <[EMAIL PROTECTED]> Greg, could you replace old patch with new one? Fix typo and insert " -- " between clauses. Signed-off-by: Keiichi Kii <[EMAIL PROTECTED]> Cc: Andy Whitcroft <[EMAIL PROTECTED]> --- Index: trunk/Doc

[PATCH] netconsole: avoid null pointer dereference at show_local_mac()

2008-02-15 Thread Keiichi KII
From: Keiichi KII <[EMAIL PROTECTED]> This patch avoids a null pointer dereference when we read local_mac for netconsole in configfs and shows default local mac address value. A null pointer dereference occurs when we call show_local_mac() via local_mac entry in configfs before we

<    1   2