From: Kenneth Westfield kwest...@codeaurora.org
As the representation of the DSP in the device
tree has changed from a required subnode to an
optional phandle, modify the test for DSP
existence in the LPASS CPU DAI driver,
accordingly.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
From: Kenneth Westfield kwest...@codeaurora.org
Define the LPASS platform driver, the LPASS
CPU DAI driver and the Storm machine driver
configurations, and how to build them.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw...@codeaurora.org
---
sound/soc
From: Kenneth Westfield kwest...@codeaurora.org
Model the Qualcomm Technologies LPASS hardware for
the ipq806x SOC.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw...@codeaurora.org
---
arch/arm/boot/dts/qcom-ipq8064.dtsi | 16
1 file
From: Kenneth Westfield kwest...@codeaurora.org
Add machine driver for the Storm board with the
IPQ806X SOC connected to the MAX98357A DAC.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw...@codeaurora.org
---
sound/soc/qcom/storm.c | 162
From: Kenneth Westfield kwest...@codeaurora.org
Allow for the Qualcomm Technologies ASoC drivers
to build.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw...@codeaurora.org
---
sound/soc/Kconfig | 1 +
sound/soc/Makefile | 1 +
2 files changed, 2
From: Kenneth Westfield kwest...@codeaurora.org
Change the representation of the audio DSP, in the
LPASS CPU bindings description, from a required
subnode to an optional phandle.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
---
Documentation/devicetree/bindings/sound/qcom,lpass
From: Kenneth Westfield kwest...@codeaurora.org
This patch series adds support for I2S audio playback on the Storm board, which
contains a Qualcomm Technologies ipq806x SOC and a Maxim max98357a DAC/amp.
The ipq806x SOC has audio-related hardware blocks in its low-power audio
subsystem (or LPASS
From: Kenneth Westfield kwest...@codeaurora.org
Add documentation to the sound directory of the
device-tree bindings for the soundcard of the
Storm board.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw...@codeaurora.org
---
Documentation/devicetree
On Thu, Mar 05, 2015 at 12:52:30PM -0600, Kumar Gala wrote:
On Mar 3, 2015, at 6:21 PM, Kenneth Westfield kwest...@codeaurora.org wrote:
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt
@@ -0,0 +1,49 @@
+* Qualcomm Technologies LPASS CPU DAI
+
+Required subnodes
counter. Add a new ops structure
for this type of clock so that we can set the rate properly.
Fixes: c99e515a92e9 clk: qcom: Add IPQ806X LPASS clock controller (LCC)
driver
Cc: Kenneth Westfield kwest...@codeaurora.org
Signed-off-by: Stephen Boyd sb...@codeaurora.org
---
Changes from v1
Cc: Kenneth Westfield kwest...@codeaurora.org
Signed-off-by: Stephen Boyd sb...@codeaurora.org
---
drivers/clk/qcom/lcc-ipq806x.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
Verified audio functionality on the Storm board (w/o SPDIF).
Tested-by: Kenneth Westfield
From: Kenneth Westfield kwest...@codeaurora.org
Add machine driver for the Storm board with the
IPQ806X SOC connected to the MAX98357A DAC.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw...@codeaurora.org
---
sound/soc/qcom/storm.c | 162
From: Kenneth Westfield kwest...@codeaurora.org
Define the LPASS platform driver, the LPASS
CPU DAI driver and the Storm machine driver
configurations, and how to build them.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw...@codeaurora.org
---
sound/soc
From: Kenneth Westfield kwest...@codeaurora.org
Add the CPU DAI driver for the Qualcomm
Technologies low-power audio subsystem (LPASS).
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw...@codeaurora.org
---
sound/soc/qcom/lpass-cpu.c | 510
From: Kenneth Westfield kwest...@codeaurora.org
Allow for the Qualcomm Technologies ASoC drivers
to build.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw...@codeaurora.org
---
sound/soc/Kconfig | 1 +
sound/soc/Makefile | 1 +
2 files changed, 2
From: Kenneth Westfield kwest...@codeaurora.org
Add platform driver for the Qualcomm Technologies
low-power audio subsystem (LPASS) ports.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw...@codeaurora.org
---
sound/soc/qcom/lpass-platform.c | 526
From: Kenneth Westfield kwest...@codeaurora.org
Add the LPASS header files for ipq806x SOC. This
includes the register definitions for the ipq806x
LPAIF, and the structure definition for the driver
data.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw
From: Kenneth Westfield kwest...@codeaurora.org
Add documentation to the sound directory of the
device-tree bindings for the QTi LPASS CPU DAI
device.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw...@codeaurora.org
---
.../devicetree/bindings/sound
From: Kenneth Westfield kwest...@codeaurora.org
Add the LPASS header files for ipq806x SOC. This
includes the register definitions for the ipq806x
LPAIF, and the structure definition for the driver
data.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw
From: Kenneth Westfield kwest...@codeaurora.org
This patch series adds support for I2S audio playback on the Storm board, which
contains a Qualcomm Technologies ipq806x SOC and a Maxim max98357a DAC/amp.
The ipq806x SOC has audio-related hardware blocks in its low-power audio
subsystem (or LPASS
From: Kenneth Westfield kwest...@codeaurora.org
Model the Qualcomm Technologies LPASS hardware for
the ipq806x SOC.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw...@codeaurora.org
---
arch/arm/boot/dts/qcom-ipq8064.dtsi | 26
From: Kenneth Westfield kwest...@codeaurora.org
Add documentation to the sound directory of the
device-tree bindings for the soundcard of the
Storm board.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw...@codeaurora.org
---
Documentation/devicetree
From: Kenneth Westfield kwest...@codeaurora.org
Add maintainers for the Qualcomm Technologies
sound drivers.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw...@codeaurora.org
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git
. Add a new ops structure
for this type of clock so that we can set the rate properly.
Fixes: c99e515a92e9 clk: qcom: Add IPQ806X LPASS clock controller (LCC)
driver
Cc: Kenneth Westfield kwest...@codeaurora.org
Signed-off-by: Stephen Boyd sb...@codeaurora.org
---
drivers/clk/qcom/clk-rcg.c
From: Kenneth Westfield kwest...@codeaurora.org
Define the LPASS platform driver, the LPASS
CPU DAI driver and the Storm machine driver
configurations, and how to build them.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw...@codeaurora.org
---
sound/soc
From: Kenneth Westfield kwest...@codeaurora.org
Add documentation to the sound directory of the
device-tree bindings for the soundcard of the
Storm board.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw...@codeaurora.org
---
Documentation/devicetree
From: Kenneth Westfield kwest...@codeaurora.org
Add platform driver for the Qualcomm Technologies
low-power audio subsystem (LPASS) ports.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw...@codeaurora.org
---
sound/soc/qcom/lpass-platform.c | 526
From: Kenneth Westfield kwest...@codeaurora.org
Allow for the Qualcomm Technologies ASoC drivers
to build.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw...@codeaurora.org
---
sound/soc/Kconfig | 1 +
sound/soc/Makefile | 1 +
2 files changed, 2
From: Kenneth Westfield kwest...@codeaurora.org
Model the Qualcomm Technologies LPASS hardware for
the ipq806x SOC.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw...@codeaurora.org
---
arch/arm/boot/dts/qcom-ipq8064.dtsi | 26
From: Kenneth Westfield kwest...@codeaurora.org
Use the standard naming convention for the codec DAI.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
---
based on next/topic/max98357a branch
sound/soc/codecs/max98357a.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
From: Kenneth Westfield kwest...@codeaurora.org
Add machine driver for the Storm board with the
IPQ806X SOC connected to the MAX98357A DAC.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw...@codeaurora.org
---
sound/soc/qcom/storm.c | 162
From: Kenneth Westfield kwest...@codeaurora.org
Add maintainers for the Qualcomm Technologies
sound drivers.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw...@codeaurora.org
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git
From: Kenneth Westfield kwest...@codeaurora.org
Add the CPU DAI driver for the Qualcomm
Technologies low-power audio subsystem (LPASS).
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw...@codeaurora.org
---
sound/soc/qcom/lpass-cpu.c | 508
From: Kenneth Westfield kwest...@codeaurora.org
This patch series adds support for I2S audio playback on the Storm board, which
contains a Qualcomm Technologies ipq806x SOC and a Maxim max98357a DAC/amp.
The ipq806x SOC has audio-related hardware blocks in its low-power audio
subsystem (or LPASS
From: Kenneth Westfield kwest...@codeaurora.org
Add documentation to the sound directory of the
device-tree bindings for the QTi LPASS CPU DAI
device.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw...@codeaurora.org
---
.../devicetree/bindings/sound
From: Kenneth Westfield kwest...@codeaurora.org
Add the LPASS header files for ipq806x SOC. This
includes the register definitions for the ipq806x
LPAIF, and the structure definition for the driver
data.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
Acked-by: Banajit Goswami bgosw
On Fri, Mar 06, 2015 at 10:07:01AM -0600, Kumar Gala wrote:
On Mar 5, 2015, at 7:51 PM, Kenneth Westfield kwest...@codeaurora.org wrote:
On Thu, Mar 05, 2015 at 12:52:30PM -0600, Kumar Gala wrote:
On Mar 3, 2015, at 6:21 PM, Kenneth Westfield kwest...@codeaurora.org
wrote:
+++ b
by Wednesday. Also, I posted
some comments, but Patrick should be posting his comments separately
later next week.
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from
*pdev);
+int lpass_cpu_dai_probe(struct snd_soc_dai *dai);
+extern struct snd_soc_dai_ops lpass_cpu_dai_ops;
Prefix with asoc_qcom_ to reduce chance of collisions.
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum
deletion(-)
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
deletions(-)
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
the interrupt sources before
getting/enabling the interrupt, i.e. do the regmap_write first, then
devm_request_irq.
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
should be reduced to 1-2).
Looking at patch 12, the internal DAI is labelled Headset and the
external DAI is labelled HDMI. I will check the spec to see if the QUAT
I2S port can handle multi-channel.
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc
On Sat, May 02, 2015 at 05:03:07PM -0700, Kenneth Westfield wrote:
On Thu, Apr 30, 2015 at 06:18:26PM +0100, Srinivas Kandagatla wrote:
This patch adds bindings for apq8016 machine driver.
On APQ8016 4 MI2S can be configured to different sinks like internal
codec/external codec
On Sat, May 02, 2015 at 04:57:38PM -0700, Kenneth Westfield wrote:
On Thu, Apr 30, 2015 at 06:16:53PM +0100, Srinivas Kandagatla wrote:
This patch tries to make the lpass driver more generic by moving the
ipq806x specific bits out of the cpu and platform driver, also allows
the
SOC
On Tue, May 05, 2015 at 12:17:23AM -0700, Srinivas Kandagatla wrote:
On 05/05/15 06:19, Kenneth Westfield wrote:
+enum lpaif_i2s_ports {
+ LPAIF_I2S_PORT_MIN = 0,
+
+ LPAIF_I2S_PORT_CODEC_SPK= 0,
+ LPAIF_I2S_PORT_CODEC_MIC= 1
On Sat, May 02, 2015 at 04:57:04PM -0700, Kenneth Westfield wrote:
On Thu, Apr 30, 2015 at 06:15:48PM +0100, Srinivas Kandagatla wrote:
Hi All,
This patchset adds apq8016 audio support into lpass driver. Existing
Lpass
driver can not be used as-it-is for apq8016 as it contains code
On Tue, May 05, 2015 at 12:17:01AM -0700, Srinivas Kandagatla wrote:
On 03/05/15 01:03, Kenneth Westfield wrote:
On Thu, Apr 30, 2015 at 06:18:26PM +0100, Srinivas Kandagatla wrote:
This patch adds bindings for apq8016 machine driver.
On APQ8016 4 MI2S can be configured to different sinks like
On Tue, May 05, 2015 at 12:16:46AM -0700, Srinivas Kandagatla wrote:
On 03/05/15 00:57, Kenneth Westfield wrote:
On Thu, Apr 30, 2015 at 06:16:53PM +0100, Srinivas Kandagatla wrote:
This patch tries to make the lpass driver more generic by moving the
ipq806x specific bits out of the cpu
On Tue, May 05, 2015 at 11:54:16PM -0700, Srinivas Kandagatla wrote:
Hi Kenneth,
On 06/05/15 06:47, Kenneth Westfield wrote:
I will test the patches and let you know by Wednesday. Also, I posted
some comments, but Patrick should be posting his comments separately
later next week
]));
}
NIT:
Perhaps make this a dev_warn or dev_notice log message, as it's no longer
really an error.
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from
the two comments on patches 5 and 6, everything else looks
fine to me.
Acked-by: Kenneth Westfield kwest...@codeaurora.org
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
,
+ %s() error getting mi2s-bit-clk: %ld\n,
+ __func__,
PTR_ERR(drvdata-mi2s_bit_clk[i]));
+ return PTR_ERR(drvdata-mi2s_bit_clk[dai_id]);
+ }
}
--
Kenneth Westfield
Qualcomm Innovation Center, Inc
;
+ }
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
-mi2s_bit_clk[i]);
}
}
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe
LPASS audio block in
+ APQ8016 SOC-based systems.
+ Say Y if you want to use audio devices on MI2S
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
);
+
+MODULE_DESCRIPTION(QTi LPASS CPU Driver);
+MODULE_LICENSE(GPL v2);
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line unsubscribe linux
, but this patch attempts to fix the actual issue.
Suggested-by: Lars-Peter Clausen l...@metafoo.de
Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org
---
Acked-by: Kenneth Westfield kwest...@codeaurora.org
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center
From: Kenneth Westfield kwest...@codeaurora.org
Rather than have each board define the same set of
dependencies; move the common dependencies to the
SND_SOC_QCOM parent config.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
---
sound/soc/qcom/Kconfig | 5 +++--
1 file changed, 3
From: Kenneth Westfield kwest...@codeaurora.org
Remove the SND_SOC_QCOM dependency from the variant
configs. The board configs, which select the
variants, already have this dependency.
Signed-off-by: Kenneth Westfield kwest...@codeaurora.org
---
sound/soc/qcom/Kconfig | 2 --
1 file changed, 2
From: Kenneth Westfield kwest...@codeaurora.org
Building with the following config options ...
CONFIG_COMPILE_TEST=y
# CONFIG_SND_SOC_QCOM is not set
CONFIG_SND_SOC_LPASS_IPQ806X=m
CONFIG_SND_SOC_STORM=m
... causes the following build warning:
warning: (SND_SOC_STORM) selects
From: Kenneth Westfield kwest...@codeaurora.org
Remove the dependency on SND_SOC_QCOM from the user-
invisible LPASS variant options. This will fix
randconfig build errors.
Reported-by: Jim Davis jim.ep...@gmail.com
Fixes: dc1ebd1811e9 (ASoC: qcom: Add apq8016 lpass driver support)
Fixes
>
>
> just one minor:
> the dev_warn() just before says: " error getting mi2s-osr-clk" may be it
> should be "warnig ..."
> That will make it more easy to rep for real error in a log.
"error [gs]etting" could be re-phrased to "could not [gs]et&qu
ERR(x) || ...) {
> ... when any
> when != IS_ERR(...)
> (
>PTR_ERR(x)
> |
> * PTR_ERR(y)
> )
> ... when any
> }
> //
>
> Signed-off-by: Julia Lawall <julia.law...@lip6.fr>
>
> ---
The patch itself looks good. Thanks.
Acked-by: Kenne
dev_warn(>dev,
> "%s() error getting mi2s-osr-clk: %ld\n",
> __func__,
> PTR_ERR(drvdata->mi2s_osr_clk[dai_id]));
> }
>
> Is that intentional?
Yes, tha
Disabling lock debugging due to kernel taint
> snd_soc_lpass_cpu: Unknown symbol regmap_write (err 0)
> snd_soc_lpass_cpu: Unknown symbol devm_kmalloc (err 0)
> ...
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandaga...@linaro.org>
> ---
Acked-by: Kenneth Westfield
ages(SNDRV_DMA_TYPE_DEV, dev, size,
> + >dma_buffer);
> if (ret) {
> - dev_err(soc_runtime->dev,
> - "%s() error writing to wrdmactl reg: %d\n",
> - __func__, ret);
> - goto capture_reg_err;
> + dev_err(dev, "can't alloc capture dma buffer\n");
Ditto.
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
r click and pop interrupt.
> + "hphl_cnp_int" - hphl click and pop interrupt
Please use labels that more closely match the HW spec:
"cdc_spk_cnp_int"
"cdc_spk_clip_int"
"cdc_spk_ocp_int"
"mbhc_ins_rem_det1"
"mbhc_but_rel_det"
"mbhc
On Tue, Jun 14, 2016 at 06:34:50AM -0700, Srinivas Kandagatla wrote:
> On 14/06/16 13:49, Kenneth Westfield wrote:
> >On Tue, Jun 14, 2016 at 09:30:03AM +0100, Srinivas Kandagatla wrote:
> >>- data = devm_kzalloc(soc_runtime->dev, sizeof(*data), GFP_KERNEL);
> >&
"ear_ocp_int",
> + "hphr_ocp_int",
> + "hphl_ocp_det",
> + "ear_cnp_int",
> + "hphr_cnp_int"
rate = TX_I2S_CTL_TX_I2S_FS_RATE_F_192_KHZ;
> + break;
Supported rates need to match (mentioned above).
> +static const struct snd_soc_dapm_route audio_map[] = {
Please use consistent name prefixes for variables
(msm8916_wcd_audio_map).
> +static struct snd_soc_dai_driver msm89
h of the register maps?
Srinivas,
Mark has a good point. Also, by having distinct devices and drivers;
you should make use of ASoC's supporting wrappers for regmap accesses.
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
if (IS_ERR_VALUE(data->wrdma_ch))
> + goto capture_alloc_err;
> +
> + drvdata->substream[data->wrdma_ch] = csubstream;
> +
> + ret = snd_dma_alloc_pages(SNDRV_DMA_TYPE_DEV,
> pcm->card->dev,
> + size, >dma_buffer);
> + if (ret)
> + goto capture_alloc_err;
... and here as well.
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
does cleanup the driver
> to make easy to add capture support.
>
> Most of these patches are acked by Kenneth.
>
> These patches are tested on DB410C with Headset Mic, secondary mic.
With the exception of patch 13 (ASoC: qcom: add mic support), apply my
ack to all remaining patches:
deletions(-)
As stated in my comments on patch 3 (ASoC: qcom: rename
rdmactl_audif_start to dmactrl_audif_start), I believe this change could
be combined with that patch. Or at the very least, have this patch be
sequenced directly after patch 3.
--
Kenneth Westfield
Qualcomm Innovation Center, I
lt;< LPAIF_I2SCTL_MICMODE_SHIFT)
> +#define LPAIF_I2SCTL_MICMODE_QUAD02 (6 << LPAIF_I2SCTL_MICMODE_SHIFT)
> +#define LPAIF_I2SCTL_MICMODE_6CH (7 << LPAIF_I2SCTL_MICMODE_SHIFT)
> +#define LPAIF_I2SCTL_MICMODE_8CH (8 << LPAIF_I2SCTL_MICMODE_SHIFT)
LPAIF_I2SCTL_MICMODE_QUAD02 shoul
ld be done in patch 3 (ASoC: qcom: rename
rdmactl_audif_start to dmactrl_audif_start). The build should
fail otherwise if bisecting between this patch and patch 3.
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
---
> sound/soc/qcom/lpass-cpu.c | 33 +++--
> 1 file changed, 31 insertions(+), 2 deletions(-)
Acked-by: Kenneth Westfield <kwest...@codeaurora.org>
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member o
int ret, rdma_port = pcm_data->i2s_port + v->dmactl_audif_start;
I was wondering why rdma_port had not been changed as well, until I saw
that in a later patch. Would it make sense to combine all changes
related to removing read-only indications from identifiers to one patch?
--
K
PAIF_DMACTL_WPSCNT_SHIFT)
> +#define LPAIF_DMACTL_WPSCNT_FOUR (3 << LPAIF_DMACTL_WPSCNT_SHIFT)
> +#define LPAIF_DMACTL_WPSCNT_SIX (5 << LPAIF_DMACTL_WPSCNT_SHIFT)
> +#define LPAIF_DMACTL_WPSCNT_EIGHT(7 << LPAIF_DMACTL_WPSCNT_SHIFT)
> +
> +#define LPAIF_DMACTL_A
return IPQ806X_LPAIF_RDMA_CHAN_MI2S;
> + else/* Capture not supported */
> + return -EINVAL;
> }
The comment could be read as "Capture not supported by hardware", which
isn't true. Maybe "Capture currently not implemented"?
--
Kenneth Westfie
4
> 1 file changed, 4 insertions(+)
Acked-by: Kenneth Westfield <kwest...@codeaurora.org>
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
* at different offset to ipq806x
>**/
> u32 dmactl_audif_start;
> + u32 wrdma_channel_start;
This patch should come before patch 6 (ASoC: qcom: ipq806x: add wrdma
related register offsets) as that patch references this field.
--
Kenneth Westfield
Qual
e changed, 11 insertions(+)
Acked-by: Kenneth Westfield <kwest...@codeaurora.org>
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
> Signed-off-by: Srinivas Kandagatla <srinivas.kandaga...@linaro.org>
> ---
> sound/soc/qcom/lpass-apq8016.c | 3 ++-
> sound/soc/qcom/lpass-ipq806x.c | 2 +-
> sound/soc/qcom/lpass.h | 2 +-
> 3 files changed, 4 insertions(+), 3 deletions(-)
Acked-by: Kennet
ivas Kandagatla <srinivas.kandaga...@linaro.org>
> ---
> sound/soc/qcom/lpass-cpu.c | 113 +++
> sound/soc/qcom/lpass-platform.c | 166
> +---
> 2 files changed, 204 insertions(+), 75 deletions(-)
Acked-by: Kennet
10 +++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
Acked-by: Kenneth Westfield <kwest...@codeaurora.org>
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
does cleanup the driver
> to make easy to add capture support.
>
> These patches are tested on DB410C with Headset Mic.
Thanks for posting this. I went through the changes, and it mostly
looks good minus some small, easy-to-fix nits.
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
Th
DRV_DMA_TYPE_DEV, pcm->card->dev,
> + size, >dma_buffer);
> if (ret)
> return ret;
>
Is there a particular reason for using the soundcard device (pcm-card->dev)
rather than the platform device (rt->platform->dev) for me
+++
> 1 file changed, 3 insertions(+)
Acked-by: Kenneth Westfield <kwest...@codeaurora.org>
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
result in below
> crash:
snip...
> Signed-off-by: Srinivas Kandagatla <srinivas.kandaga...@linaro.org>
> ---
LGTM.
Acked-by: Kenneth Westfield <kwest...@codeaurora.org>
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a m
> Signed-off-by: Srinivas Kandagatla <srinivas.kandaga...@linaro.org>
> ---
> sound/soc/qcom/lpass-platform.c | 53
> +
> 1 file changed, 17 insertions(+), 36 deletions(-)
Acked-by: Kenneth Westfield <kwest...@codeaurora.org>
--
Kenne
linaro.org>
> ---
> sound/soc/qcom/lpass-platform.c | 151
> ++--
> sound/soc/qcom/lpass.h | 1 -
> 2 files changed, 67 insertions(+), 85 deletions(-)
After you address Mark's comments:
Acked-by: Kenneth Westfield <kwest...@codeaurora.org>
--
Kenn
("ASoC: lpass-platform: Fix broken pcm data usage")
> Signed-off-by: Arnd Bergmann <a...@arndb.de>
> ---
> sound/soc/qcom/lpass-platform.c | 3 +++
> 1 file changed, 3 insertions(+)
Good catch.
Acked-by: Kenneth Westfield <kwest...@codeaurora.org>
--
Kenneth
switch back to the M/N counter. Add a new ops structure
> for this type of clock so that we can set the rate properly.
>
> Fixes: c99e515a92e9 "clk: qcom: Add IPQ806X LPASS clock controller (LCC)
> driver"
> Cc: Kenneth Westfield
> Signed-off-by: Stephen Boyd
> ---
>
From: Kenneth Westfield
Change the representation of the audio DSP, in the
LPASS CPU bindings description, from a required
subnode to an optional phandle.
Signed-off-by: Kenneth Westfield
---
Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt | 12 +++-
1 file changed, 3
From: Kenneth Westfield
As the representation of the DSP in the device
tree has changed from a required subnode to an
optional phandle, modify the test for DSP
existence in the LPASS CPU DAI driver,
accordingly.
Signed-off-by: Kenneth Westfield
---
sound/soc/qcom/lpass-cpu.c | 33
From: Kenneth Westfield
Add documentation to the sound directory of the
device-tree bindings for the soundcard of the
Storm board.
Signed-off-by: Kenneth Westfield
Acked-by: Banajit Goswami
---
Documentation/devicetree/bindings/sound/storm.txt | 23 +++
1 file changed, 23
From: Kenneth Westfield
This patch series adds support for I2S audio playback on the Storm board, which
contains a Qualcomm Technologies ipq806x SOC and a Maxim max98357a DAC/amp.
The ipq806x SOC has audio-related hardware blocks in its low-power audio
subsystem (or LPASS). One of the relevant
1 - 100 of 190 matches
Mail list logo
