Re: [PATCH 06/14] vrange: Add basic functions to purge volatile pages

2013-10-03 Thread Krzysztof Kozlowski
On śro, 2013-10-02 at 17:51 -0700, John Stultz wrote: > +static void try_to_discard_one(struct vrange_root *vroot, struct page *page, > + struct vm_area_struct *vma, unsigned long addr) > +{ > + struct mm_struct *mm = vma->vm_mm; > + pte_t *pte; > + pte_t pte

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-10-03 Thread Krzysztof Kozlowski
On wto, 2013-10-01 at 16:04 -0500, Seth Jennings wrote: > Yes, it is very similar. I'm beginning to like aspects of this patch > more as I explore this issue more. > > At first, I balked at the idea of yet another abstraction layer, but it > is very hard to avoid unless you want to completely col

Re: [RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-09-08 Thread Krzysztof Kozlowski
Hi Bob, On nie, 2013-09-08 at 17:04 +0800, Bob Liu wrote: > Hi Krzysztof, > > On 08/30/2013 04:42 PM, Krzysztof Kozlowski wrote: > > Use page reference counter for zbud pages. The ref counter replaces > > zbud_header.under_reclaim flag and ensures that zbud page wo

Re: [RFC PATCH 0/4] mm: migrate zbud pages

2013-09-08 Thread Krzysztof Kozlowski
On pią, 2013-09-06 at 12:30 -0500, Seth Jennings wrote: > On Fri, Aug 30, 2013 at 10:42:52AM +0200, Krzysztof Kozlowski wrote: > > Hi, > > > > Currently zbud pages are not movable and they cannot be allocated from CMA > > region. These patches add migration of zbu

Re: [RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-09-10 Thread Krzysztof Kozlowski
Hi, On pon, 2013-09-09 at 14:47 -0500, Seth Jennings wrote: > On Fri, Aug 30, 2013 at 10:42:53AM +0200, Krzysztof Kozlowski wrote: > > Use page reference counter for zbud pages. The ref counter replaces > > zbud_header.under_reclaim flag and ensures that zbud page won'

[PATCH v2 3/5] mm: use mapcount for identifying zbud pages

2013-09-11 Thread Krzysztof Kozlowski
Currently zbud pages do not have any flags set so it is not possible to identify them during migration or compaction. Implement PageZbud() by comparing page->_mapcount to -127 to distinguish pages allocated by zbud. Just like PageBuddy() is implemented. Signed-off-by: Krzysztof Kozlow

[PATCH v2 2/5] zbud: make freechunks a block local variable

2013-09-11 Thread Krzysztof Kozlowski
Move freechunks variable in zbud_free() and zbud_alloc() to block-level scope (from function scope). Signed-off-by: Krzysztof Kozlowski --- mm/zbud.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/mm/zbud.c b/mm/zbud.c index 3f4be72..1d5b26b 100644 --- a/mm/zbud.c

[PATCH v2 0/5] mm: migrate zbud pages

2013-09-11 Thread Krzysztof Kozlowski
This also removes the need of holding lock while call to put_zbud_page(). Best regards, Krzysztof Kozlowski Krzysztof Kozlowski (5): zbud: use page ref counter for zbud pages zbud: make freechunks a block local variable mm: use mapcount for identifying zbud pages mm: use indirect zbud handle and

[PATCH v2 4/5] mm: use indirect zbud handle and radix tree

2013-09-11 Thread Krzysztof Kozlowski
ry to address this problem by protecting handles from freeing. Also the call to zbud_unmap() in zswap_writeback_entry() was moved further - when the tree's lock could be obtained. Signed-off-by: Krzysztof Kozlowski --- include/linux/zbud.h |2 +- mm/zbud.c

[PATCH v2 1/5] zbud: use page ref counter for zbud pages

2013-09-11 Thread Krzysztof Kozlowski
eated and passed to zswap (in zbud_alloc()), - user-supplied eviction callback is called (in zbud_reclaim_page()). Signed-off-by: Krzysztof Kozlowski Signed-off-by: Tomasz Stanislawski Reviewed-by: Bob Liu --- mm/zbud.c | 117 + 1

[PATCH v2 5/5] mm: migrate zbud pages

2013-09-11 Thread Krzysztof Kozlowski
t can be replaced for example with pin page control subsystem: http://article.gmane.org/gmane.linux.kernel.mm/105308 In such case the zbud migration code (zbud_migrate_page()) can be safely re-used. Signed-off-by: Krzysztof Kozlowski --- include/linux/zbud.h |1 + mm/compaction.c |7

[PATCH] frontswap: enable call to invalidate area on swapoff

2013-10-07 Thread Krzysztof Kozlowski
frontswap_invalidate_area() so outside of locks (swap_lock and swap_info_struct->lock). This shouldn't be a problem as during swapon the frontswap_map_set() is called also outside of any locks. Signed-off-by: Krzysztof Kozlowski --- mm/swapfile.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH] frontswap: enable call to invalidate area on swapoff

2013-10-08 Thread Krzysztof Kozlowski
On pon, 2013-10-07 at 15:03 -0700, Andrew Morton wrote: > On Mon, 07 Oct 2013 17:25:41 +0200 Krzysztof Kozlowski > wrote: > > > During swapoff the frontswap_map was NULL-ified before calling > > frontswap_invalidate_area(). However the frontswap_invalidate_area

[PATCH v3 0/6] mm: migrate zbud pages

2013-10-08 Thread Krzysztof Kozlowski
3.11. 2. Updated documentation of zbud_reclaim_page() to match usage of zbud page reference counters. 3. Split from patch 2/4 trivial change of scope of freechunks var to separate patch (3/5) (suggested by Seth Jennings). Best regards, Krzysztof Kozlowski Krzysztof Kozlowski (6): zb

[PATCH v3 2/6] zbud: make freechunks a block local variable

2013-10-08 Thread Krzysztof Kozlowski
Move freechunks variable in zbud_free() and zbud_alloc() to block-level scope (from function scope). Signed-off-by: Krzysztof Kozlowski --- mm/zbud.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/mm/zbud.c b/mm/zbud.c index 7574289..e19f36a 100644 --- a/mm/zbud.c

[PATCH v3 3/6] mm: use mapcount for identifying zbud pages

2013-10-08 Thread Krzysztof Kozlowski
Currently zbud pages do not have any flags set so it is not possible to identify them during migration or compaction. Implement PageZbud() by comparing page->_mapcount to -127 to distinguish pages allocated by zbud. Just like PageBuddy() is implemented. Signed-off-by: Krzysztof Kozlow

[PATCH v3 6/6] mm: migrate zbud pages

2013-10-08 Thread Krzysztof Kozlowski
t can be replaced for example with pin page control subsystem: http://article.gmane.org/gmane.linux.kernel.mm/105308 In such case the zbud migration code (zbud_migrate_page()) can be safely re-used. Signed-off-by: Krzysztof Kozlowski --- include/linux/zbud.h |1 + mm/compaction.c |7

[PATCH v3 4/6] zbud: memset zbud_header to 0 during init

2013-10-08 Thread Krzysztof Kozlowski
memset zbud_header to 0 during init instead of manually assigning 0 to members. Currently only two members needs to be initialized to 0 but further patches will add more of them. Signed-off-by: Krzysztof Kozlowski --- mm/zbud.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH v3 5/6] zswap: replace tree in zswap with radix tree in zbud

2013-10-08 Thread Krzysztof Kozlowski
storing of duplicated pages (as it was in original zswap). 2. Use RCU for radix tree reads and updates. 3. Optimize locking in zbud_free_all(). 4. Iterate over LRU list instead of radix tree in zbud_free_all(). Signed-off-by: Krzysztof Kozlowski --- include/linux/zbud.h | 27 +++-

[PATCH v3 1/6] zbud: use page ref counter for zbud pages

2013-10-08 Thread Krzysztof Kozlowski
eated and passed to zswap (in zbud_alloc()), - user-supplied eviction callback is called (in zbud_reclaim_page()). Signed-off-by: Krzysztof Kozlowski Signed-off-by: Tomasz Stanislawski Reviewed-by: Bob Liu --- mm/zbud.c | 117 + 1

Re: [PATCH v3 1/6] zbud: use page ref counter for zbud pages

2013-10-09 Thread Krzysztof Kozlowski
On wto, 2013-10-08 at 15:43 -0500, Seth Jennings wrote: > On Tue, Oct 08, 2013 at 03:29:35PM +0200, Krzysztof Kozlowski wrote: > > Use page reference counter for zbud pages. The ref counter replaces > > zbud_header.under_reclaim flag and ensures that zbud page won't be free

Re: [PATCH v3 5/6] zswap: replace tree in zswap with radix tree in zbud

2013-10-10 Thread Krzysztof Kozlowski
On Wed, 2013-10-09 at 12:16 -0500, Seth Jennings wrote: > On Wed, Oct 09, 2013 at 10:30:22AM -0500, Seth Jennings wrote: > > In my approach, I was also looking at allowing the zbud pools to use > > HIGHMEM pages, since the handle is no longer an address. This requires > > the pages that are being

[RFC PATCH 0/4] mm: migrate zbud pages

2013-08-30 Thread Krzysztof Kozlowski
4] zbud: use page ref counter for zbud pages" * Add missing spin_unlock in zbud_reclaim_page(). * Decrease pool->pages_nr in zbud_free(), not when putting page. This also removes the need of holding lock while call to put_zbud_page(). Best regards, Krzysztof Kozlowski Krzysztof Kozlow

[RFC PATCH 2/4] mm: use mapcount for identifying zbud pages

2013-08-30 Thread Krzysztof Kozlowski
Currently zbud pages do not have any flags set so it is not possible to identify them during migration or compaction. Implement PageZbud() by comparing page->_mapcount to -127 to distinguish pages allocated by zbud. Just like PageBuddy() is implemented. Signed-off-by: Krzysztof Kozlow

[RFC PATCH 4/4] mm: migrate zbud pages

2013-08-30 Thread Krzysztof Kozlowski
aced for example with pin page control subsystem: http://article.gmane.org/gmane.linux.kernel.mm/105308 In such case the zbud migration code (zbud_migrate_page()) can be safely re-used. Signed-off-by: Krzysztof Kozlowski --- include/linux/zbud.h |1 + mm/compaction.c |7 +++ mm/m

[RFC PATCH 3/4] mm: use indirect zbud handle and radix tree

2013-08-30 Thread Krzysztof Kozlowski
r try to address this problem by protecting handles from freeing. Also the call to zbud_unmap() in zswap_writeback_entry() was moved further - when the tree's lock could be obtained. Signed-off-by: Krzysztof Kozlowski --- include/linux/zbud.h |2 +- mm/zbud.c

[RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-08-30 Thread Krzysztof Kozlowski
eated and passed to zswap (in zbud_alloc()), - user-supplied eviction callback is called (in zbud_reclaim_page()). Signed-off-by: Krzysztof Kozlowski Signed-off-by: Tomasz Stanislawski Reviewed-by: Bob Liu --- mm/zbud.c | 97 + 1

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-30 Thread Krzysztof Kozlowski
On pią, 2013-09-27 at 17:00 -0500, Seth Jennings wrote: > I have to say that when I first came up with the idea, I was thinking > the address space would be at the zswap layer and the radix slots would > hold zbud handles, not struct page pointers. > > However, as I have discovered today, this is

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-24 Thread Krzysztof Kozlowski
Hi, On pon, 2013-09-23 at 17:07 -0500, Seth Jennings wrote: > On Tue, Sep 17, 2013 at 02:59:24PM +0800, Bob Liu wrote: > > Mel mentioned several problems about zswap/zbud in thread "[PATCH v6 > > 0/5] zram/zsmalloc promotion". > > > > Like "it's clunky as hell and the layering between zswap and z

[RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-08-05 Thread Krzysztof Kozlowski
eated and passed to zswap (in zbud_alloc()), - user-supplied eviction callback is called (in zbud_reclaim_page()). Signed-off-by: Krzysztof Kozlowski Signed-off-by: Tomasz Stanislawski --- mm/zbud.c | 150 +++-- 1 file changed, 86 inser

[RFC PATCH 2/4] mm: split code for unusing swap entries from try_to_unuse

2013-08-05 Thread Krzysztof Kozlowski
Move out the code for unusing swap entries from loop in try_to_unuse() to separate function: try_to_unuse_swp_entry(). Export this new function in swapfile.h just like try_to_unuse() is exported. Signed-off-by: Krzysztof Kozlowski --- include/linux/swapfile.h |2 + mm/swapfile.c

[RFC PATCH 0/4] mm: reclaim zbud pages on migration and compaction

2013-08-05 Thread Krzysztof Kozlowski
with other solution. Best regards, Krzysztof Kozlowski Krzysztof Kozlowski (4): zbud: use page ref counter for zbud pages mm: split code for unusing swap entries from try_to_unuse mm: add zbud flag to page flags mm: reclaim zbud pages on migration and compaction include/linux/page

[RFC PATCH 3/4] mm: add zbud flag to page flags

2013-08-05 Thread Krzysztof Kozlowski
Add PageZbud flag to page flags to distinguish pages allocated in zbud. Currently these pages do not have any flags set. Signed-off-by: Krzysztof Kozlowski --- include/linux/page-flags.h | 12 mm/page_alloc.c|3 +++ mm/zbud.c |4 3 files

[RFC PATCH 4/4] mm: reclaim zbud pages on migration and compaction

2013-08-05 Thread Krzysztof Kozlowski
hand tries to write them back. Signed-off-by: Krzysztof Kozlowski --- include/linux/zbud.h | 11 +++- mm/compaction.c | 20 ++- mm/internal.h|1 + mm/page_alloc.c |6 ++ mm/zbud.c| 163 +++--- mm/zs

Re: [RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-08-06 Thread Krzysztof Kozlowski
Hi Bob, Thank you for review. On wto, 2013-08-06 at 17:00 +0800, Bob Liu wrote: > Nit picker, how about change the name to adjust_lists() or something > like this because we don't do any rebalancing. OK, I'll change it. Best regards, Krzysztof -- To unsubscribe from this list: send the line "

Re: [RFC PATCH 0/4] mm: reclaim zbud pages on migration and compaction

2013-08-06 Thread Krzysztof Kozlowski
On wto, 2013-08-06 at 17:16 +0800, Bob Liu wrote: > On 08/06/2013 02:42 PM, Krzysztof Kozlowski wrote: > > This reclaim process is different than zbud_reclaim_page(). It acts more > > like swapoff() by trying to unuse pages stored in zbud page and bring > > them back to

[PATCH] [TRIVIAL] ARM: msm: fix compilation error in gpiomux

2013-08-06 Thread Krzysztof Kozlowski
-by: Krzysztof Kozlowski --- arch/arm/mach-msm/gpiomux.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-msm/gpiomux.c b/arch/arm/mach-msm/gpiomux.c index 2b8e2d2..4110b82 100644 --- a/arch/arm/mach-msm/gpiomux.c +++ b/arch/arm/mach-msm/gpiomux.c @@ -21,7 +21,7

Re: [RFC PATCH 3/4] mm: add zbud flag to page flags

2013-08-07 Thread Krzysztof Kozlowski
On wto, 2013-08-06 at 09:58 -0700, Dave Hansen wrote: > On 08/05/2013 11:42 PM, Krzysztof Kozlowski wrote: > > +#ifdef CONFIG_ZBUD > > + /* Allocated by zbud. Flag is necessary to find zbud pages to unuse > > +* during migration/compaction. > > +*/ > >

Re: [RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-08-07 Thread Krzysztof Kozlowski
Hi Seth, On wto, 2013-08-06 at 13:51 -0500, Seth Jennings wrote: > I like the idea. I few things below. Also agree with Bob the > s/rebalance/adjust/ for rebalance_lists(). OK. > s/else if/if/ since the if above returns if true. Sure. > > + /* zbud_free() or zbud_alloc() */ > > +

Re: [PATCH] [TRIVIAL] ARM: msm: fix compilation error in gpiomux

2013-08-07 Thread Krzysztof Kozlowski
On śro, 2013-08-07 at 14:08 -0700, Stephen Boyd wrote: > On 08/07, David Brown wrote: > > On Wed, Aug 07, 2013 at 08:34:39AM +0200, Krzysztof Kozlowski wrote: > > >Fix compilation error in gpiomux (CONFIG_MSM_GPIOMUX=y): > > >arch/arm/mach-msm/gpiomux.c:24:13: e

Re: [RFC PATCH 3/4] mm: add zbud flag to page flags

2013-08-08 Thread Krzysztof Kozlowski
Hi, On wto, 2013-08-06 at 09:58 -0700, Dave Hansen wrote: > On 08/05/2013 11:42 PM, Krzysztof Kozlowski wrote: > > +#ifdef CONFIG_ZBUD > > + /* Allocated by zbud. Flag is necessary to find zbud pages to unuse > > +* during migration/compaction. > > +*/ &

[RFC PATCH v2 0/4] mm: reclaim zbud pages on migration and compaction

2013-08-09 Thread Krzysztof Kozlowski
file.c (this fixes hang when swapoff was interrupted e.g. by CTRL+C). Best regards, Krzysztof Kozlowski Krzysztof Kozlowski (4): zbud: use page ref counter for zbud pages mm: split code for unusing swap entries from try_to_unuse mm: use mapcount for identifying zbud pages mm: reclai

[RFC PATCH v2 2/4] mm: split code for unusing swap entries from try_to_unuse

2013-08-09 Thread Krzysztof Kozlowski
: Krzysztof Kozlowski --- include/linux/swapfile.h |2 + mm/swapfile.c| 356 -- 2 files changed, 189 insertions(+), 169 deletions(-) diff --git a/include/linux/swapfile.h b/include/linux/swapfile.h index e282624..68c24a7 100644 --- a

[RFC PATCH v2 4/4] mm: reclaim zbud pages on migration and compaction

2013-08-09 Thread Krzysztof Kozlowski
hand tries to write them back. Signed-off-by: Krzysztof Kozlowski --- include/linux/zbud.h | 11 +++- mm/compaction.c | 20 ++- mm/internal.h|1 + mm/page_alloc.c |6 ++ mm/zbud.c| 161 +++--- mm/zs

[RFC PATCH v2 3/4] mm: use mapcount for identifying zbud pages

2013-08-09 Thread Krzysztof Kozlowski
Currently zbud pages do not have any flags set so it is not possible to identify them during migration or compaction. Implement PageZbud() by comparing page->_mapcount to -127 to distinguish pages allocated by zbud. Just like PageBuddy() is implemented. Signed-off-by: Krzysztof Kozlow

[RFC PATCH v2 1/4] zbud: use page ref counter for zbud pages

2013-08-09 Thread Krzysztof Kozlowski
eated and passed to zswap (in zbud_alloc()), - user-supplied eviction callback is called (in zbud_reclaim_page()). Signed-off-by: Krzysztof Kozlowski Signed-off-by: Tomasz Stanislawski Reviewed-by: Bob Liu --- mm/zbud.c | 96 ++--- 1

Re: [RFC 0/3] Pin page control subsystem

2013-08-13 Thread Krzysztof Kozlowski
Hi Minchan, On wto, 2013-08-13 at 16:04 +0900, Minchan Kim wrote: > patch 2 introduce pinpage control > subsystem. So, subsystems want to control pinpage should implement own > pinpage_xxx functions because each subsystem would have other character > so what kinds of data structure for managing pi

Re: [PATCH] ARM: exynos_defconfig: Enable bus frequency scaling with DEVFREQ/DEVFREQ-Event

2016-07-21 Thread Krzysztof Kozlowski
s cycle - after my last pull request for v4.8 ten days ago. I won't be able to push anything more so it has to wait for v4.9. I'll pick it up after merge window. For the record: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH] ASoC: samsung: make audio interface/controller explicitly

2016-09-19 Thread Krzysztof Kozlowski
On Mon, Sep 19, 2016 at 09:21:54AM +0800, Ayaka wrote: > > > 從我的 iPad 傳送 > > > Krzysztof Kozlowski 於 2016年9月19日 上午2:09 寫道: > > > >> On Sun, Sep 18, 2016 at 11:12:34PM +0800, ayaka wrote: > >> > >> > >>> On 09/18/2016 10:42 PM,

Re: [GIT PULL 1/3] ARM: soc: exynos: Drivers for v4.9

2016-09-19 Thread Krzysztof Kozlowski
On Mon, Sep 19, 2016 at 05:02:40PM +0200, Arnd Bergmann wrote: > On Sunday, September 18, 2016 6:39:46 PM CEST Krzysztof Kozlowski wrote: > > Samsung drivers/soc update for v4.9: > > 1. Allow compile testing of exynos-mct clocksource driver on ARM64. > > 2. Document Exyn

Re: Re: linux-next: build failure after merge of the pm tree

2016-09-19 Thread Krzysztof Kozlowski
On Mon, Sep 19, 2016 at 07:37:24AM +, MyungJoo Ham wrote: > > On Wednesday, September 14, 2016 02:27:47 PM Stephen Rothwell wrote: > > > Hi Rafael, > > > > > > After merging the pm tree, today's linux-next build (powerpc allyesconfig) > > > failed like this: > > > > > > drivers/devfreq/tegra-

Re: [PATCH] ASoC: samsung: make audio interface/controller explicitly

2016-09-19 Thread Krzysztof Kozlowski
On Mon, Sep 19, 2016 at 11:51:58PM +0800, Randy Li wrote: > It is simple sound card time, we could assign different codec > to a interface without making a specific driver for it. The SPDIF > and I2S interface for Samsung would be possible used by simple-sound-card, > but not sure about the PCM. >

Re: [PATCH v3] ASoC: exynos: organize the asoc audio into a menu

2016-09-20 Thread Krzysztof Kozlowski
bout the PCM. > > Those S3C time entries are left alone as I don't think any new board > would need them. > > Signed-off-by: Randy Li > --- > sound/soc/samsung/Kconfig | 57 > --- > 1 file changed, 29 insertions(+)

Re: [PATCH 5/6] memory: samsung/exynos-srom: make it explicitly non-modular

2016-06-20 Thread Krzysztof Kozlowski
LE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Pankaj Dubey > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: linux-samsu

Re: [PATCH v9 2/4] power: reset: add reboot mode driver

2016-06-20 Thread Krzysztof Kozlowski
On 06/20/2016 08:38 AM, Andy Yan wrote: > This driver parses the reboot commands like "reboot bootloader" > and "reboot recovery" to get a boot mode described in the > device tree , then call the write interfae to store the boot > mode in some place like special register or sram, which can > be rea

Re: [PATCH v4 3/7] max8903: cleans up confusing relationship between dc_valid, dok and dcm.

2016-06-20 Thread Krzysztof Kozlowski
hen dc_valid is given. Whilst > allowing dcm to be optional. > > Signed-off-by: Chris Lapa Reviewed-by: Krzysztof Kozlowski BR. Krzysztof

Re: [PATCH v4 2/7] max8903: store pointer to pdata instead of copying it.

2016-06-20 Thread Krzysztof Kozlowski
--- > 1 file changed, 13 insertions(+), 7 deletions(-) The same as in #1. For the record: Reviewed-by: Krzysztof Kozlowski BR. Krzysztof

Re: [PATCH v4 1/7] max8903: adds documentation for device tree bindings.

2016-06-20 Thread Krzysztof Kozlowski
hris Lapa Reviewed-by: ... ... etc For the record: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v4 4/7] max8903: adds requesting of gpios.

2016-06-20 Thread Krzysztof Kozlowski
/max8903_charger.c | 136 > ++-- > 1 file changed, 102 insertions(+), 34 deletions(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v4 6/7] max8903: remove unnecessary 'out of memory' error message.

2016-06-20 Thread Krzysztof Kozlowski
On 06/20/2016 12:27 AM, Chris Lapa wrote: > From: Chris Lapa > > Remove the 'out of memory' error message as it is printed by the core. > > Signed-off-by: Chris Lapa The same as in #1, I already reviewed it. For the record: Reviewed-by: Krzysztof Kozlowski BR. Krzysztof

Re: [PATCH v4 5/7] max8903: removes non zero validity checks on gpios.

2016-06-20 Thread Krzysztof Kozlowski
ch in turn results in several of the error messages becoming > redundant and thus removed. > > Signed-off-by: Chris Lapa The same as in #1, I already reviewed it. For the record: Reviewed-by: Krzysztof Kozlowski BR. Krzysztof

Re: [PATCH v4 7/7] max8903: adds support for initiation via device tree

2016-06-20 Thread Krzysztof Kozlowski
On 06/20/2016 12:27 AM, Chris Lapa wrote: > From: Chris Lapa > > Adds support for device tree to setup a max8903 battery charger. DC and USB > validity are determined by looking the presence of the dok and uok gpios. > > Signed-off-by: Chris Lapa Reviewed-by: Krzysz

Re: [PATCH v9 2/4] power: reset: add reboot mode driver

2016-06-20 Thread Krzysztof Kozlowski
On 06/20/2016 10:28 AM, Andy Yan wrote: > Hi Krzysztof: > > On 2016年06月20日 16:09, Krzysztof Kozlowski wrote: >> On 06/20/2016 08:38 AM, Andy Yan wrote: >>> This driver parses the reboot commands like "reboot bootloader" >>> and "reboot recovery"

Re: [PATCH v9 2/4] power: reset: add reboot mode driver

2016-06-21 Thread Krzysztof Kozlowski
On 06/21/2016 08:16 AM, Andy Yan wrote: > I will remove the module related stuff in the next version. >>> Following his rationale, I think either this should be a tristate or the >>> module stuff should be removed. How about making it tristate? I think there isn't any obstacles for this driver b

Re: [PATCH v6 2/4] power: reset: add reboot mode driver

2016-06-21 Thread Krzysztof Kozlowski
On 06/21/2016 01:01 PM, Andy Yan wrote: (...) >>> +MODULE_AUTHOR("Andy Yan >> +MODULE_DESCRIPTION("System reboot mode driver"); >>> +MODULE_LICENSE("GPL v2"); >>> diff --git a/drivers/power/reset/reboot-mode.h >>> b/drivers/power/reset/reboot-mode.h >>> new file mode 100644 >>> index 000..44e

Re: [PATCH] ARM: dts: exynos: Add reboot reason support for Trats2

2016-09-22 Thread Krzysztof Kozlowski
Hi, Thanks for the patch, it is nice that someone did this! When I saw the syscon reboot mode driver, I though about such feature but never had time or will to implement it. Great job! Few comments below. On Thu, Sep 22, 2016 at 06:48:35PM +0200, Wolfgang Wiedmeyer wrote: > This allows to reboot

Re: [PATCH] ARM: dts: exynos: Add reboot reason support for Trats2

2016-09-22 Thread Krzysztof Kozlowski
On Thu, Sep 22, 2016 at 08:59:03PM +0200, Wolfgang Wiedmeyer wrote: > > Krzysztof Kozlowski writes: > > > On Thu, Sep 22, 2016 at 06:48:35PM +0200, Wolfgang Wiedmeyer wrote: > >> This allows to reboot the device into recovery mode and into the download > >> mode

Re: [PATCH] ARM: dts: exynos: Add reboot reason support for Trats2

2016-09-25 Thread Krzysztof Kozlowski
On Sat, Sep 24, 2016 at 11:04:49PM +0200, Wolfgang Wiedmeyer wrote: > > Krzysztof Kozlowski writes: > > > On Thu, Sep 22, 2016 at 08:59:03PM +0200, Wolfgang Wiedmeyer wrote: > >> > >> Krzysztof Kozlowski writes: > >> > >> > On Thu, Sep

Re: [PATCH 2/2] power: supply: max17042_battery: add technology property support

2016-09-26 Thread Krzysztof Kozlowski
On Sun, Sep 25, 2016 at 11:10:11PM +0200, Wolfgang Wiedmeyer wrote: > This patch reports the battery technology as Li-ion. > > Signed-off-by: Wolfgang Wiedmeyer > --- > drivers/power/max17042_battery.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/power/max17042_battery.c

Re: [PATCH 1/2] power: supply: max17042_battery: use VF SOC register for capacity property

2016-09-26 Thread Krzysztof Kozlowski
On Sun, Sep 25, 2016 at 11:10:10PM +0200, Wolfgang Wiedmeyer wrote: > The capacity property uses the RepSOC register to report the current state > of charge. This register did not provide a reliable SOC value during my > testing with the max17047 variant on a Galaxy S3 (Trats2/GT-I9300). The > repo

Re: [PATCH 2/2] power: supply: max17042_battery: add technology property support

2016-09-26 Thread Krzysztof Kozlowski
On Mon, Sep 26, 2016 at 02:56:44PM +0200, Wolfgang Wiedmeyer wrote: > > Krzysztof Kozlowski writes: > > > On Sun, Sep 25, 2016 at 11:10:11PM +0200, Wolfgang Wiedmeyer wrote: > >> This patch reports the battery technology as Li-ion. > >> >

Re: [PATCH] ARM: dts: exynos: Add reboot reason support for Trats2

2016-09-26 Thread Krzysztof Kozlowski
On Sun, Sep 25, 2016 at 09:34:45AM +0200, Krzysztof Kozlowski wrote: > On Sat, Sep 24, 2016 at 11:04:49PM +0200, Wolfgang Wiedmeyer wrote: > > > > Krzysztof Kozlowski writes: > > > > > On Thu, Sep 22, 2016 at 08:59:03PM +0200, Wolfgang Wiedmeyer wrote: > > &

Re: [PATCH 2/3] regulator: max77693: Also manipulate the fast charge current

2016-09-27 Thread Krzysztof Kozlowski
On Tue, Sep 27, 2016 at 01:31:09AM +0200, Wolfgang Wiedmeyer wrote: > For MAX77693, the fast charge current also needs to be manipulated for > proper charging. The fast charge current is only set in the case of > the MAX77693 type, as the MAX77843 properly manipulates the fast > charge current. Ar

Re: [PATCH 1/3] mfd: max77693: Add defines for charger current control

2016-09-27 Thread Krzysztof Kozlowski
On Tue, Sep 27, 2016 at 01:31:08AM +0200, Wolfgang Wiedmeyer wrote: > This prepares for an updated regulator and charger driver. The defines > are needed to set the maximum input current and the fast charge > current. > > Signed-off-by: Wolfgang Wiedmeyer This shouldn't be separate patch, becaus

Re: [PATCH 3/3] power_supply: max77693: Listen for cable events and enable charging

2016-09-27 Thread Krzysztof Kozlowski
"max77693-muic"; + }; + cable@1 { + cm-cable-name = "TA"; + cm-cable-extcon = "max77693-muic"; + }; + }; + }; + exynos-usbphy@125B { status = "okay"; }; Signed-off-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v4] ARM: dts: exynos: Enable HDMI for Arndale Octa board

2016-08-31 Thread Krzysztof Kozlowski
consume 1.0V LDO6 (PVDD_ANAIP_1V0) and HDMI oscillator >> requires 1.8V LDO7 (PVDD_ANAIP_1V8). >> >> * Support HDMI display data channel >> I2C #2 is assigned for the HDMI DDC. It enables the EDID access. >> >> Cc: Kukjin Kim >> Cc: Krzysztof Kozlowski &

[PATCH 7/9] ARM: dts: exynos: Use macros for GPIO configuration on exynos5260

2016-08-31 Thread Krzysztof Kozlowski
Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5260-pinctrl.dtsi | 184 ++--- arch/arm

[PATCH 5/9] ARM: dts: exynos: Use macros for GPIO configuration on exynos4x12

2016-08-31 Thread Krzysztof Kozlowski
Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 14 +- arch/arm/boot/dts/exynos4412

[PATCH 6/9] ARM: dts: exynos: Use macros for GPIO configuration on exynos5250

2016-08-31 Thread Krzysztof Kozlowski
Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 402 +- arch/arm

[PATCH 4/9] ARM: dts: exynos: Use macros for GPIO configuration on exynos4415

2016-08-31 Thread Krzysztof Kozlowski
Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos4415-pinctrl.dtsi | 286 +++--- 1 file

[PATCH 8/9] ARM: dts: exynos: Use macros for GPIO configuration on exynos5410

2016-08-31 Thread Krzysztof Kozlowski
Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5410-odroidxu.dts | 30 ++--- arch/arm/boot/dts/exynos5410

[PATCH 9/9] ARM: dts: exynos: Use macros for GPIO configuration on exynos542x/exynos5800

2016-08-31 Thread Krzysztof Kozlowski
Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5420-arndale-octa.dts | 6 +- arch/arm/boot/dts

[PATCH 3/9] ARM: dts: exynos: Use macros for GPIO configuration on exynos4210

2016-08-31 Thread Krzysztof Kozlowski
Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos4210-pinctrl.dtsi | 454 arch/arm

[PATCH 0/9] ARM: dts: exynos: Use macros for GPIO to make it more readable

2016-08-31 Thread Krzysztof Kozlowski
* sed -i -e 's/samsung,pin-function = <\(0x\)\?3>;$/samsung,pin-function = ;/' arch/arm/boot/dts/exynos* sed -i -e 's/samsung,pin-function = <3>;$/samsung,pin-function = ;/' arch/arm/boot/dts/exynos* sed -i -e 's/samsung,pin-function = <4>;$/samsung,pin-fu

[PATCH 2/9] ARM: dts: exynos: Use macros for GPIO configuration on exynos3250

2016-08-31 Thread Krzysztof Kozlowski
Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos3250-pinctrl.dtsi | 270 +++--- 1 file

[PATCH 1/9] ARM: dts: exynos: Add macros for GPIO configuration

2016-08-31 Thread Krzysztof Kozlowski
Add macros for replacing hard-coded GPIO configuration: pull up/down, drive strength and function. Although PIN_FUNC_SPC_2 does not bring much information about the function itself, it still is more descriptive then hard-coded number <2>. Signed-off-by: Krzysztof Kozlowski --- arch/ar

Re: [PATCH 1/9] ARM: dts: exynos: Add macros for GPIO configuration

2016-08-31 Thread Krzysztof Kozlowski
On 08/31/2016 02:42 PM, Arnd Bergmann wrote: > On Wednesday, August 31, 2016 2:13:25 PM CEST Krzysztof Kozlowski wrote: >> >> +#define PIN_PULL_NONE 0 >> +#define PIN_PULL_DOWN 1 >> +#define PIN_PULL_UP3 >> + >> +#defi

Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

2016-08-31 Thread Krzysztof Kozlowski
On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > This series removes the usage of the skeleton.dtsi in all the Exynos dts, > which allows to get rid of the DTC warnings about a mismatch between the > memory nodes' unit names and reg properties. > > Patches are pretty

Re: [PATCH 1/9] ARM: dts: exynos: Add macros for GPIO configuration

2016-08-31 Thread Krzysztof Kozlowski
On 08/31/2016 02:58 PM, Arnd Bergmann wrote: > On Wednesday, August 31, 2016 2:53:02 PM CEST Krzysztof Kozlowski wrote: >> On 08/31/2016 02:42 PM, Arnd Bergmann wrote: >>> On Wednesday, August 31, 2016 2:13:25 PM CEST Krzysztof Kozlowski wrote: >>>> >>

Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

2016-08-31 Thread Krzysztof Kozlowski
On Wed, Aug 31, 2016 at 02:14:33PM +0200, Javier Martinez Canillas wrote: > The skeleton.dtsi file was removed in ARM64 for different reasons as > explained in commit ("3ebee5a2e141 arm64: dts: kill skeleton.dtsi"). > > These also applies to ARM and it will also allow to get rid of the > following

Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

2016-08-31 Thread Krzysztof Kozlowski
On Wed, Aug 31, 2016 at 03:45:24PM +0200, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 08/31/2016 02:55 PM, Krzysztof Kozlowski wrote: > > On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote: > >> Hello Krzysztof, > >> > >> This series rem

Re: [RESEND PATCH 1/3] ARM: dts: Add TOPEET itop core board SCP package version

2016-08-31 Thread Krzysztof Kozlowski
On Wed, Aug 31, 2016 at 08:58:27PM +0800, Randy Li wrote: > The TOPEET itop is a samsung exnynos 4412 core board, which have > two package versions. This patch add the support for SCP version. > > Currently supported are USB3503A HSIC, USB OTG, eMMC, rtc and > PMIC. The future features are in the

[PATCH v2 02/10] ARM: dts: exynos: Use common macros for pinctrl configuration

2016-09-01 Thread Krzysztof Kozlowski
t;2>. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos3250-pinctrl.dtsi | 76 +++- arch/arm/boot/dts/exynos4210-pinctrl.dtsi | 2 + arch/arm/boot/dts/exynos4415-pinctrl.dtsi | 2 + arch/arm/boot/dts/exynos4x12-pinctrl.dtsi | 21 +++ arch/arm/boot/dts/exyn

[PATCH v2 00/10] pinctrl: exynos/samsung: Add header with values used for configuration

2016-09-01 Thread Krzysztof Kozlowski
tion = <4>;$/samsung,pin-function = ;/' arch/arm/boot/dts/exynos* sed -i -e 's/samsung,pin-function = <5>;$/samsung,pin-function = ;/' arch/arm/boot/dts/exynos* sed -i -e 's/samsung,pin-function = <6>;$/samsung,pin-function = ;/' arch/arm/boot/dts/exynos

[PATCH v2 03/10] ARM: dts: exynos: Use macros for pinctrl configuration on exynos3250

2016-09-01 Thread Krzysztof Kozlowski
Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos3250-pinctrl.dtsi | 270 +++--- 1 file

[PATCH v2 07/10] ARM: dts: exynos: Use macros for pinctrl configuration on exynos5250

2016-09-01 Thread Krzysztof Kozlowski
Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 402 +- arch/arm

[PATCH v2 09/10] ARM: dts: exynos: Use macros for pinctrl configuration on exynos5410

2016-09-01 Thread Krzysztof Kozlowski
Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5410-odroidxu.dts | 30 ++--- arch/arm/boot/dts/exynos5410

[PATCH v2 01/10] pinctrl: dt-bindings: samsung: Add header with values used for configuration

2016-09-01 Thread Krzysztof Kozlowski
and maintainable. Signed-off-by: Krzysztof Kozlowski --- MAINTAINERS | 1 + include/dt-bindings/pinctrl/samsung.h | 57 +++ 2 files changed, 58 insertions(+) create mode 100644 include/dt-bindings/pinctrl/samsung.h diff --git a

[PATCH v2 06/10] ARM: dts: exynos: Use macros for pinctrl configuration on exynos4415

2016-09-01 Thread Krzysztof Kozlowski
Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos4415-pinctrl.dtsi | 286 +++--- 1 file

[PATCH v2 10/10] ARM: dts: exynos: Use macros for pinctrl configuration on exynos542x/exynos5800

2016-09-01 Thread Krzysztof Kozlowski
Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5420-arndale-octa.dts | 6 +- arch/arm/boot/dts

  1   2   3   4   5   6   7   8   9   10   >