Re: [PATCH] regulator: mt6360: Fix missing IRQF_ONESHOT as only threaded handler

2021-04-16 Thread Krzysztof Kozlowski
On Fri, 16 Apr 2021 at 06:30, wrote: > > From: Guangqing Zhu > > Coccinelle noticed: > drivers/regulator/mt6360-regulator.c:386:8-33: ERROR: Threaded IRQ with no > primary handler requested without IRQF_ONESHOT This should be tested. There are several patches like this all over the tree so it lo

Re: [PATCH] rtc: Fix missing IRQF_ONESHOT as only threaded handler

2021-04-16 Thread Krzysztof Kozlowski
On 16/04/2021 04:19, zhuguangqin...@gmail.com wrote: > From: Guangqing Zhu > > Coccinelle noticed: > 1. drivers/rtc/rtc-s5m.c:810:7-32: ERROR: Threaded IRQ with no primary >handler requested without IRQF_ONESHOT > 2. drivers/rtc/rtc-rk808.c:441:7-32: ERROR: Threaded IRQ with no primary >h

Re: [PATCH] extcon: maxim: Fix missing IRQF_ONESHOT as only threaded handler

2021-04-16 Thread Krzysztof Kozlowski
On 15/04/2021 13:36, zhuguangqin...@gmail.com wrote: > From: Guangqing Zhu > > Coccinelle noticed: > 1. drivers/extcon/extcon-max14577.c:699:8-33: ERROR: Threaded IRQ with > no primary handler requested without IRQF_ONESHOT > 2. drivers/extcon/extcon-max77693.c:1143:8-33: ERROR: Threaded IRQ

[RFT 2/2] i2c: s3c2410: fix possible NULL pointer deref on read message after write

2021-04-15 Thread Krzysztof Kozlowski
e followed by jumping to end of function (acknowledging the interrupt and returning). This seems a reasonable choice also here since message buffer was entirely emptied. Addresses-Coverity: Explicit null dereferenced Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Krzysztof Kozlow

[PATCH 1/2] i2c: s3c2410: simplify getting of_device_id match data

2021-04-15 Thread Krzysztof Kozlowski
Use of_device_get_match_data() to make the code slightly smaller. Signed-off-by: Krzysztof Kozlowski --- drivers/i2c/busses/i2c-s3c2410.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c index

[PATCH v2 1/3] mmc: sdhci-s3c: simplify getting of_device_id match data

2021-04-15 Thread Krzysztof Kozlowski
Use of_device_get_match_data() to make the code slightly smaller and to remove the of_device_id table forward declaration. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Rewrite the commit msg as it is not a NULL pointer dereference. --- drivers/mmc/host/sdhci-s3c.c | 12

[PATCH v2 2/3] mmc: sdhci-s3c: correct kerneldoc of sdhci_s3c_drv_data

2021-04-15 Thread Krzysztof Kozlowski
Correct the name of sdhci_s3c_drv_data structure in kerneldoc: drivers/mmc/host/sdhci-s3c.c:143: warning: expecting prototype for struct sdhci_s3c_driver_data. Prototype was for struct sdhci_s3c_drv_data instead Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. None

[PATCH v2 3/3] mmc: sdhci-s3c: constify uses of driver/match data

2021-04-15 Thread Krzysztof Kozlowski
The driver data (struct sdhci_s3c_drv_data) stored in of_device_id table is allocated as const and used only in const-way. Skip unnecessary const-away casts and convert all users to work with pointer to const. This is both more logical and safer. Signed-off-by: Krzysztof Kozlowski

Re: [PATCH 1/3] mmc: sdhci-s3c: fix possible NULL pointer dereference when probed via platform

2021-04-15 Thread Krzysztof Kozlowski
On 14/04/2021 18:49, Sylwester Nawrocki wrote: > On 14.04.2021 17:25, Krzysztof Kozlowski wrote: >> On 14/04/2021 17:12, Krzysztof Kozlowski wrote: >>> The driver can be matched by legacy platform way or OF-device matching. >>> In the first case, of_match_node() can ret

[GIT PULL] memory: Second pull for v5.13

2021-04-14 Thread Krzysztof Kozlowski
. Krzysztof Kozlowski (2): memory: renesas-rpc-if: fix possible NULL pointer dereference of resource memory: samsung: exynos5422-dmc: handle clk_set_parent() failure Yong Wu (1): memory: mtk-smi: Add device-link between smi-larb and smi-common

Re: [PATCH v3 2/4] dt-bindings: arm: imx: Add i.mx6q DaSheng COM-9XX SBC

2021-04-14 Thread Krzysztof Kozlowski
ple multi-protocol RS232/RS485 Serial ports > - microSD socket > - 5V DC power input > - HDMI1.4a,1080p@60 > - RGMIIx1 Gigabit Ethernet > - CSI0x1, connect with ov2659 > > Signed-off-by: dillon min > Cc: Krzysztof Kozlowski > --- > v3: move 'ds,imx6q-

[PATCH 2/3] spi: s3c64xx: correct kerneldoc of s3c64xx_spi_port_config

2021-04-14 Thread Krzysztof Kozlowski
Correct the name of s3c64xx_spi_port_config structure in kerneldoc: drivers/spi/spi-s3c64xx.c:154: warning: expecting prototype for struct s3c64xx_spi_info. Prototype was for struct s3c64xx_spi_port_config instead Signed-off-by: Krzysztof Kozlowski --- drivers/spi/spi-s3c64xx.c | 2

[PATCH 3/3] spi: s3c64xx: constify driver/match data

2021-04-14 Thread Krzysztof Kozlowski
The match data (struct s3c64xx_spi_port_config) stored in of_device_id and platform_device_id tables is not modified by the driver and can be handled entirely in a const-way to increase the code safety. Signed-off-by: Krzysztof Kozlowski --- drivers/spi/spi-s3c64xx.c | 21

[PATCH 1/3] spi: s3c64xx: simplify getting of_device_id match data

2021-04-14 Thread Krzysztof Kozlowski
Use of_device_get_match_data() to make the code slightly smaller and to remove the of_device_id table forward declaration. Signed-off-by: Krzysztof Kozlowski --- drivers/spi/spi-s3c64xx.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b

Re: [PATCH 1/3] mmc: sdhci-s3c: fix possible NULL pointer dereference when probed via platform

2021-04-14 Thread Krzysztof Kozlowski
On 14/04/2021 17:12, Krzysztof Kozlowski wrote: > The driver can be matched by legacy platform way or OF-device matching. > In the first case, of_match_node() can return NULL, which immediately > would be dereferenced to get the match data. > > Addresses-Coverity: Dereference nu

Re: drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:306:26: sparse: sparse: incorrect type in argument 1 (different address spaces)

2021-04-14 Thread Krzysztof Kozlowski
On 14/04/2021 16:53, Andy Shevchenko wrote: > On Wed, Apr 14, 2021 at 10:21 AM kernel test robot wrote: >> >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >> master >> head: eebe426d32e1a10ac7c35f8ffab5f818c32a2454 >> commit: 8f28ca6bd8211214faf717677bbffe375c2a607

[PATCH 2/3] mmc: sdhci-s3c: correct kerneldoc of sdhci_s3c_drv_data

2021-04-14 Thread Krzysztof Kozlowski
Correct the name of sdhci_s3c_drv_data structure in kerneldoc: drivers/mmc/host/sdhci-s3c.c:143: warning: expecting prototype for struct sdhci_s3c_driver_data. Prototype was for struct sdhci_s3c_drv_data instead Signed-off-by: Krzysztof Kozlowski --- drivers/mmc/host/sdhci-s3c.c | 2

[PATCH 1/3] mmc: sdhci-s3c: fix possible NULL pointer dereference when probed via platform

2021-04-14 Thread Krzysztof Kozlowski
tree support") Signed-off-by: Krzysztof Kozlowski --- Not tested on HW, but the code should be equivalent (plus safer). drivers/mmc/host/sdhci-s3c.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s

[PATCH 3/3] mmc: sdhci-s3c: constify uses of driver/match data

2021-04-14 Thread Krzysztof Kozlowski
The driver data (struct sdhci_s3c_drv_data) stored in of_device_id table is allocated as const and used only in const-way. Skip unnecessary const-away casts and convert all users to work with pointer to const. This is both more logical and safer. Signed-off-by: Krzysztof Kozlowski --- drivers

Re: [PATCH v2 4/4] dt-bindings: add dasheng vendor prefix

2021-04-14 Thread Krzysztof Kozlowski
s(+) This should be the first patch in the series. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 1/4] dt-bindings: arm: imx: Add i.mx6q DaSheng COM-9XX SBC board dts support

2021-04-14 Thread Krzysztof Kozlowski
ple multi-protocol RS232/RS485 Serial ports > - microSD socket > - 5V DC power input > - HDMI1.4a,1080p@60 > - RGMIIx1 Gigabit Ethernet > - CSI0x1, connect with ov2659 > > Signed-off-by: dillon min > Cc: Krzysztof Kozlowski > --- > v2: no changes > > Documen

Re: [PATCH v1 1/3] dt-bindings: arm: imx: Add i.mx6q DaSheng COM-9XX SBC board dts support

2021-04-13 Thread Krzysztof Kozlowski
On 14/04/2021 08:13, dillon.min...@gmail.com wrote: > From: dillon min > > The DaSheng Com-9xx is and ARM based signle board computer (SBC) > featuring: > - i.MX6Q > - 2GiB LPDDR3 DRAM > - 8GiB eMMC 5.0 FLASH > - 4MiB SPI Flash > - USB 2.0 Host/Device > - Multiple multi-protocol RS232/RS485 Seria

Re: [PATCH] arm: mach-s3c: Remove unnecessary break

2021-04-13 Thread Krzysztof Kozlowski
On 09/04/2021 08:49, Wan Jiabing wrote: > There is a return above the break. > The break here is unnecessary. Remove it. > > Signed-off-by: Wan Jiabing > --- > arch/arm/mach-s3c/mach-rx1950.c | 1 - > 1 file changed, 1 deletion(-) Thanks, looks good but I do not plan another pull request in cur

Re: [PATCH] memory: samsung: exynos5422-dmc: handle clk_set_parent() failure

2021-04-13 Thread Krzysztof Kozlowski
On Wed, 7 Apr 2021 17:45:35 +0200, Krzysztof Kozlowski wrote: > clk_set_parent() can fail and ignoring such case could lead to invalid > clock setup for given frequency. Applied, thanks! [1/1] memory: samsung: exynos5422-dmc: handle clk_set_parent() failure

Re: (subset) [PATCH v5 00/16] Clean up "mediatek,larb"

2021-04-13 Thread Krzysztof Kozlowski
venc > > [...] Applied, thanks! [04/16] memory: mtk-smi: Add device-link between smi-larb and smi-common commit: 6ce2c05b21189eb17b3aa26720cc5841acf9dce8 Best regards, -- Krzysztof Kozlowski

Re: [PATCH] memory: renesas-rpc-if: fix possible NULL pointer dereference of resource

2021-04-13 Thread Krzysztof Kozlowski
On Wed, 7 Apr 2021 17:43:57 +0200, Krzysztof Kozlowski wrote: > The platform_get_resource_byname() can return NULL which would be > immediately dereferenced by resource_size(). Instead dereference it > after validating the resource. Applied, thanks! [1/1] memory: renesas-rpc-if: fix

Re: [PATCH v5 04/16] memory: mtk-smi: Add device-link between smi-larb and smi-common

2021-04-13 Thread Krzysztof Kozlowski
On 13/04/2021 08:04, Yong Wu wrote: > On Sat, 2021-04-10 at 14:40 +0200, Krzysztof Kozlowski wrote: >> On 10/04/2021 11:11, Yong Wu wrote: >>> Normally, If the smi-larb HW need work, we should enable the smi-common >>> HW power and clock firstly. >>> This pa

Re: [PATCH v5 14/16] memory: mtk-smi: Get rid of mtk_smi_larb_get/put

2021-04-13 Thread Krzysztof Kozlowski
Wu > Reviewed-by: Evan Green > --- > drivers/memory/mtk-smi.c | 14 -- > include/soc/mediatek/smi.h | 20 > 2 files changed, 34 deletions(-) > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

[PATCH] iio: adc: exynos: drop unneeded variable assignment

2021-04-10 Thread Krzysztof Kozlowski
The initialization of 'ret' variable in probe function is shortly after overwritten. This initialization is simply not used. Addresses-Coverity: Unused value Signed-off-by: Krzysztof Kozlowski --- drivers/iio/adc/exynos_adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

Re: [PATCH v5 04/16] memory: mtk-smi: Add device-link between smi-larb and smi-common

2021-04-10 Thread Krzysztof Kozlowski
- > 1 file changed, 10 insertions(+), 9 deletions(-) I understood this is a dependency for other patches, so: Acked-by: Krzysztof Kozlowski If I am wrong and I can take it via memory tree, let me know. Best regards, Krzysztof

[PATCH v3] dt-bindings: serial: samsung: include generic dtschema to match bluetooth child

2021-04-09 Thread Krzysztof Kozlowski
From: Krzysztof Kozlowski Include the generic serial.yaml dtschema so the child node like "bluetooth" will be properly matched: arch/arm/boot/dts/exynos4210-universal_c210.dt.yaml: serial@1380: 'bluetooth' does not match any of the regexes: 'pinctrl-[0-9]+&#

Re: [PATCH v2] dt-bindings: serial: samsung: include generic dtschema to match bluetooth child

2021-04-09 Thread Krzysztof Kozlowski
On 09/04/2021 18:09, Rob Herring wrote: > On Mon, Apr 05, 2021 at 07:21:19PM +0200, Krzysztof Kozlowski wrote: >> From: Krzysztof Kozlowski >> >> Include the generic serial.yaml dtschema so the child node like >> "bluetooh" will be properly matched: &

Re: [PATCH -next] hwrng: exynos - fix PM reference leak in exynos_trng_probe()

2021-04-08 Thread Krzysztof Kozlowski
On Fri, 9 Apr 2021 at 08:11, Ye Weihua wrote: > > pm_runtime_get_sync will increment pm usage counter even it failed. > Forgetting to putting operation will result in reference leak here. > Fix it by replacing it with pm_runtime_resume_and_get to keep usage > counter balanced. > > Reported-by: Hul

[PATCH] iommu: exynos: remove unneeded local variable initialization

2021-04-08 Thread Krzysztof Kozlowski
The initialization of 'fault_addr' local variable is not needed as it is shortly after overwritten. Addresses-Coverity: Unused value Signed-off-by: Krzysztof Kozlowski --- drivers/iommu/exynos-iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/io

[PATCH] pinctrl: samsung: use 'int' for register masks in Exynos

2021-04-08 Thread Krzysztof Kozlowski
value when calling writel(), 2. is actually error-prone because it might promote other operands to 64-bit. Addresses-Coverity: Unintentional integer overflow Signed-off-by: Krzysztof Kozlowski --- Not tested on ARM64. Dear Linus, Please apply it directly, I don't have any patches for Sa

Re: New 'make dtbs_check W=1' warnings

2021-04-08 Thread Krzysztof Kozlowski
On 08/04/2021 17:08, Arnd Bergmann wrote: > Greetings to all Arm platform maintainers, > > I've just gone through the DT merges I've received so far and, with a > little help from Rob, > managed to run 'make dtbs_check W=1' before and after, to see what > warnings we get. > The good news is that t

Re: [PATCH -next] clk: samsung: Remove redundant dev_err calls

2021-04-08 Thread Krzysztof Kozlowski
sung/clk-s5pv210-audss.c | 4 +--- > 2 files changed, 2 insertions(+), 6 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH] memory: atmel-sdramc: check of_device_get_match_data() return value

2021-04-07 Thread Krzysztof Kozlowski
On 07/04/2021 18:19, Alexandre Belloni wrote: > Hi, > > On 07/04/2021 17:44:47+0200, Krzysztof Kozlowski wrote: >> If the driver is probed, the of_device_get_match_data() should not >> return NULL, however for sanity check its return value. >> > > As you say,

[GIT PULL 1/2] memory: drivers for v5.13

2021-04-07 Thread Krzysztof Kozlowski
The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux-mem-ctrl.git tags/memory-controller-drv-5.13 for you to fetch changes u

[GIT PULL 2/2] memory: tegra for v5.13

2021-04-07 Thread Krzysztof Kozlowski
The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux-mem-ctrl.git tags/memory-controller-drv-tegra-5.13 for you to fetch cha

[PATCH] memory: samsung: exynos5422-dmc: handle clk_set_parent() failure

2021-04-07 Thread Krzysztof Kozlowski
clk_set_parent() can fail and ignoring such case could lead to invalid clock setup for given frequency. Addresses-Coverity: Unchecked return value Fixes: 6e7674c3c6df ("memory: Add DMC driver for Exynos5422") Signed-off-by: Krzysztof Kozlowski --- drivers/memory/samsung/exynos5422

[PATCH] memory: atmel-sdramc: check of_device_get_match_data() return value

2021-04-07 Thread Krzysztof Kozlowski
If the driver is probed, the of_device_get_match_data() should not return NULL, however for sanity check its return value. Addresses-Coverity: Dereference null return value Signed-off-by: Krzysztof Kozlowski --- drivers/memory/atmel-sdramc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[PATCH] memory: renesas-rpc-if: fix possible NULL pointer dereference of resource

2021-04-07 Thread Krzysztof Kozlowski
ned-off-by: Krzysztof Kozlowski --- drivers/memory/renesas-rpc-if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/memory/renesas-rpc-if.c b/drivers/memory/renesas-rpc-if.c index 8d36e221def1..45eed659b0c6 100644 --- a/drivers/memory/renesas-rpc-if.c +++ b/drivers/memory/renesa

Re: [PATCH -next] power: supply: s3c_adc_battery: fix possible use-after-free in s3c_adc_bat_remove()

2021-04-07 Thread Krzysztof Kozlowski
> drivers/power/supply/s3c_adc_battery.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

[PATCH] ASoC: simple-card: fix possible uninitialized single_cpu local variable

2021-04-07 Thread Krzysztof Kozlowski
alized and reporting success. Addresses-Coverity: Uninitialized scalar variable Fixes: 8f7f298a3337 ("ASoC: simple-card-utils: separate asoc_simple_card_parse_dai()") Signed-off-by: Krzysztof Kozlowski --- sound/soc/generic/audio-graph-card.c | 2 +- sound/soc/generic/simple-card.c | 2

Re: [PATCH] clk: socfpga: arria10: Fix memory leak of socfpga_clk on error return

2021-04-07 Thread Krzysztof Kozlowski
by: Colin Ian King > --- > drivers/clk/socfpga/clk-gate-a10.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [GIT PULL 1/3] ARM: dts: samsung: Pull for v5.13

2021-04-07 Thread Krzysztof Kozlowski
On 07/04/2021 08:58, Krzysztof Kozlowski wrote: > From: Krzysztof Kozlowski I still did not update all my tools for new email - this should be "From" my Canonical address. The tags are signed with the same key with @canonical.com UID. The latest key is already in kernel PGP k

[GIT PULL 3/3] ARM: samsung: mach/soc pull for v5.13

2021-04-06 Thread Krzysztof Kozlowski
From: Krzysztof Kozlowski The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-soc-5.13 for you to fetch

[GIT PULL 2/3] arm64: dts: exynos: Pull for v5.13

2021-04-06 Thread Krzysztof Kozlowski
From: Krzysztof Kozlowski The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-dt64-5.13 for you to

[GIT PULL 1/3] ARM: dts: samsung: Pull for v5.13

2021-04-06 Thread Krzysztof Kozlowski
From: Krzysztof Kozlowski The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-dt-5.13 for you to fetch

Re: [PATCH] ARM: exynos: correct kernel doc in platsmp

2021-04-06 Thread Krzysztof Kozlowski
On Mon, 5 Apr 2021 20:16:05 +0200, Krzysztof Kozlowski wrote: > Correct few kerneldoc issues, including W=1 compile warning: > > arch/arm/mach-exynos/platsmp.c:89: warning: > expecting prototype for exynos_core_power_down(). Prototype was for > exynos_cpu_power_down() i

Re: [PATCH 05/12] ARM: s3c: mini2440: Constify the software node

2021-04-06 Thread Krzysztof Kozlowski
an immutable branch, of course. > Sure, ack is possible (from my currently used email): Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 08/15] arm64: socfpga: merge Agilex and N5X into ARCH_INTEL_SOCFPGA

2021-04-06 Thread Krzysztof Kozlowski
On Tue, 6 Apr 2021 at 18:10, Guenter Roeck wrote: > > On Thu, Mar 11, 2021 at 04:25:38PM +0100, Krzysztof Kozlowski wrote: > > Agilex, N5X and Stratix 10 share all quite similar arm64 hard cores and > > SoC-part. Up to a point that N5X uses the same DTSI as Agilex. From &g

Re: [PATCH v2] nfc: s3fwrn5: remove unnecessary label

2021-04-06 Thread Krzysztof Kozlowski
replace > goto sentences and delete out label. > > Signed-off-by: wengjianfeng > --- > drivers/nfc/s3fwrn5/core.c | 12 > 1 file changed, 4 insertions(+), 8 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: linux-next: build warning after merge of the arm-soc tree

2021-04-05 Thread Krzysztof Kozlowski
On 06/04/2021 02:45, Stephen Rothwell wrote: > Hi all, > > After merging the arm-soc tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > drivers/clk/socfpga/clk-gate.c: In function 'socfpga_clk_recalc_rate': > drivers/clk/socfpga/clk-gate.c:102:7: warning: cast fro

[PATCH] ARM: exynos: correct kernel doc in platsmp

2021-04-05 Thread Krzysztof Kozlowski
Correct few kerneldoc issues, including W=1 compile warning: arch/arm/mach-exynos/platsmp.c:89: warning: expecting prototype for exynos_core_power_down(). Prototype was for exynos_cpu_power_down() instead Signed-off-by: Krzysztof Kozlowski --- arch/arm/mach-exynos/platsmp.c | 28

[PATCH] net: smsc911x: skip acpi_device_id table when !CONFIG_ACPI

2021-04-05 Thread Krzysztof Kozlowski
: Krzysztof Kozlowski --- drivers/net/ethernet/smsc/smsc911x.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c index 606c79de93a6..556a9790cdcf 100644 --- a/drivers/net/ethernet/smsc/smsc911x.c +++ b/drivers/net/ethernet

[PATCH] drm/exynos: correct exynos_drm_fimd kerneldoc

2021-04-05 Thread Krzysztof Kozlowski
Correct the kerneldoc of fimd_shadow_protect_win() to fix W=1 warnings: drivers/gpu/drm/exynos/exynos_drm_fimd.c:734: warning: expecting prototype for shadow_protect_win(). Prototype was for fimd_shadow_protect_win() instead Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/exynos

[PATCH] drm/panel: ld9040: reference spi_device_id table

2021-04-05 Thread Krzysztof Kozlowski
arily real case). Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/panel/panel-samsung-ld9040.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-samsung-ld9040.c b/drivers/gpu/drm/panel/panel-samsung-ld9040.c index f484147fc3a6..c4b388850a13 100644 --- a/dr

[PATCH] i2c: exynos5: correct top kerneldoc

2021-04-05 Thread Krzysztof Kozlowski
The top comment is not a kerneldoc, as W=1 build reports: drivers/i2c/busses/i2c-exynos5.c:39: warning: expecting prototype for i2c(). Prototype was for HSI2C_CTL() instead Signed-off-by: Krzysztof Kozlowski --- drivers/i2c/busses/i2c-exynos5.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2] dt-bindings: serial: samsung: include generic dtschema to match bluetooth child

2021-04-05 Thread Krzysztof Kozlowski
From: Krzysztof Kozlowski Include the generic serial.yaml dtschema so the child node like "bluetooh" will be properly matched: arch/arm/boot/dts/exynos4210-universal_c210.dt.yaml: serial@1380: 'bluetooth' does not match any of the regexes: 'pinctrl-[0-9]+&#

Re: [PATCH] memory: pl353: fix macro definition of ecc page_size for arm pl353 static memory controller

2021-04-05 Thread Krzysztof Kozlowski
ces with capital letter. Thanks. [1/1] memory: pl353: fix macro definition of ecc page_size for arm pl353 static memory controller commit: 25dcca7fedcd4e31cb368ad846bfd738c0c6307c Best regards, -- Krzysztof Kozlowski

Re: [PATCH] nfc: s3fwrn5: remove unnecessary label

2021-04-02 Thread Krzysztof Kozlowski
On 02/04/2021 14:15, samirweng1979 wrote: > From: wengjianfeng > > In function s3fwrn5_nci_post_setup, The variable ret is assigned to 0, > then goto out label, but just return ret in out label, so we use > return 0 to replace it. and other goto sentences are similar, we use > return sentences to

Re: [PATCH v2 0/6] NVIDIA Tegra memory improvements

2021-04-01 Thread Krzysztof Kozlowski
e9079520f4f95b17cd2 [6/6] memory: tegra: Print out info-level once per driver probe commit: 06949d1d9accbc7d3a029536650162bbca30151b Best regards, -- Krzysztof Kozlowski

Re: (subset) [PATCH v2 0/6] NVIDIA Tegra memory improvements

2021-04-01 Thread Krzysztof Kozlowski
7dc78fa61e1750ab31 Best regards, -- Krzysztof Kozlowski

Re: [PATCH v2 0/6] NVIDIA Tegra memory improvements

2021-04-01 Thread Krzysztof Kozlowski
On 31/03/2021 01:04, Dmitry Osipenko wrote: > Hi, > > This series replaces the raw voltage regulator with a power domain that > will be managing SoC core voltage. The core power domain patches are still > under review, but it's clear at this point that this is the way we will > implement the DVFS

Re: [PATCH -next] memory: fsl-corenet-cf: Remove redundant dev_err call in ccf_probe()

2021-04-01 Thread Krzysztof Kozlowski
commit: b11a188aef6d19fe3ca505831d9c627ef683476f Best regards, -- Krzysztof Kozlowski

Re: [PATCH 05/12] ARM: s3c: mini2440: Constify the software node

2021-04-01 Thread Krzysztof Kozlowski
On 29/03/2021 14:32, Heikki Krogerus wrote: > On Mon, Mar 29, 2021 at 12:58:41PM +0200, Krzysztof Kozlowski wrote: >> On 29/03/2021 12:50, Heikki Krogerus wrote: >>> Additional device properties are always just a part of a >>> software fwnode. If the device p

Re: [PATCH] usb: dwc3: exynos: fix incorrect kernel-doc comment syntax

2021-03-30 Thread Krzysztof Kozlowski
YNOS_MAX_CLOCKS() instead" > > Provide a simple fix by replacing this occurrence with general comment > format, i.e. '/*', to prevent kernel-doc from parsing it. One sentence with error log would be enough for such trivial change. Anyway: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v1 5/6] dt-bindings: memory: tegra20: emc: Convert to schema

2021-03-30 Thread Krzysztof Kozlowski
On 29/03/2021 21:46, Dmitry Osipenko wrote: > Convert Tegra20 External Memory Controller binding to schema. > > Signed-off-by: Dmitry Osipenko > --- > .../memory-controllers/nvidia,tegra20-emc.txt | 130 > .../nvidia,tegra20-emc.yaml | 294 ++ > 2 files

Re: [PATCH v1 4/6] dt-bindings: memory: tegra20: mc: Convert to schema

2021-03-30 Thread Krzysztof Kozlowski
On 29/03/2021 21:46, Dmitry Osipenko wrote: > Convert Tegra20 Memory Controller binding to schema. > > Signed-off-by: Dmitry Osipenko Thanks for the patch! Please see a comment below. > --- > .../memory-controllers/nvidia,tegra20-mc.txt | 40 -- > .../memory-controllers/nvidia,tegra20

Re: [PATCH 05/12] ARM: s3c: mini2440: Constify the software node

2021-03-29 Thread Krzysztof Kozlowski
On 29/03/2021 12:50, Heikki Krogerus wrote: > Additional device properties are always just a part of a > software fwnode. If the device properties are constant, the > software node can also be constant. > Hi, Thanks for your work. I did not get the cover letter nor other patches from this set an

Re: [PATCH v2] ARM: dts: exynos: Add front camera support to I9100

2021-03-28 Thread Krzysztof Kozlowski
Best regards, -- Krzysztof Kozlowski

Re: [PATCH] ARM: dts: exynos: Add front camera support to I9100

2021-03-26 Thread Krzysztof Kozlowski
On 26/03/2021 17:25, Timon Baetz wrote: > Add node for Samsung S5K5BAF CMOS image sensor and > enable the associated MIPI CSI-2 receiver node. > > Signed-off-by: Timon Baetz > --- > arch/arm/boot/dts/exynos4210-i9100.dts | 52 ++ > 1 file changed, 52 insertions(+) > > di

Re: [PATCH v1 1/2] memory: tegra20: Correct comment to MC_STAT registers writes

2021-03-26 Thread Krzysztof Kozlowski
On 25/03/2021 18:20, Dmitry Osipenko wrote: > 24.03.2021 00:04, Dmitry Osipenko пишет: >> The code was changed multiple times and the comment to MC_STAT >> registers writes became slightly outdated. The MC_STAT programming >> now isn't hardcoded to the "bandwidth" mode, let's clarify this in >> the

Re: [PATCH v1 1/2] memory: tegra20: Correct comment to MC_STAT registers writes

2021-03-26 Thread Krzysztof Kozlowski
e comment. Applied, thanks! [1/2] memory: tegra20: Correct comment to MC_STAT registers writes (no commit info) [2/2] memory: tegra20: Protect debug code with a lock (no commit info) Best regards, -- Krzysztof Kozlowski

Re: [PATCH] regulator: Use IRQF_ONESHOT

2021-03-25 Thread Krzysztof Kozlowski
On 23/03/2021 13:12, Jian Dong wrote: > From: Jian Dong > > Fixes coccicheck error: > > drivers/regulator/mt6360-regulator.c:388:8-33: ERROR: > drivers/regulator/pca9450-regulator.c:781:7-32: ERROR: > drivers/regulator/slg51000-regulator.c:480:8-33: ERROR: > drivers/regulator/qcom-labibb-regulat

Re: [PATCH] firmware: stratix10-svc: build only on 64-bit ARM

2021-03-22 Thread Krzysztof Kozlowski
On 22/03/2021 13:58, Richard Gong wrote: > > > On 3/22/21 3:26 AM, Krzysztof Kozlowski wrote: >> >> On 21/03/2021 22:09, Arnd Bergmann wrote: >>> On Sun, Mar 21, 2021 at 7:46 PM Krzysztof Kozlowski >>> wrote: >>>> >>>>

Re: [PATCH] firmware: stratix10-svc: build only on 64-bit ARM

2021-03-22 Thread Krzysztof Kozlowski
On 21/03/2021 22:09, Arnd Bergmann wrote: > On Sun, Mar 21, 2021 at 7:46 PM Krzysztof Kozlowski > wrote: >> >> The Stratix10 service layer and RCU drivers are useful only on >> Stratix10, so on ARMv8. Compile testing the RCU driver on 32-bit ARM >> fails: >

[PATCH] firmware: stratix10-svc: build only on 64-bit ARM

2021-03-21 Thread Krzysztof Kozlowski
sion = FIELD_GET(RSU_VERSION_MASK, Signed-off-by: Krzysztof Kozlowski Reported-by: kernel test robot --- Fix for commit in: https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git --- drivers/firmware/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/fi

Re: [PATCH v2] memory: tegra20: Add debug statistics

2021-03-21 Thread Krzysztof Kozlowski
intended to help with debugging of memory performance issues, it already > was proven to be useful by helping to improve memory bandwidth management > of the display driver. Applied, thanks! [1/1] memory: tegra20: Add debug statistics commit: 1ca59ca0afde17b75adc519858ccc30375cfad1d

Re: [PATCH 1/3] ARM: dts: exynos: replace deprecated NTC/Murata compatibles

2021-03-19 Thread Krzysztof Kozlowski
On Mon, 15 Mar 2021 13:43:11 +0100, Krzysztof Kozlowski wrote: > The compatibles with "ntc" vendor prefix become deprecated and "murata" > should be used. Applied, thanks! [1/3] ARM: dts: exynos: replace deprecated NTC/Murata compatibles commit: 61342bc64d03d88fb

Re: [PATCH][next] loop: Fix missing max_active argument in alloc_workqueue call

2021-03-19 Thread Krzysztof Kozlowski
On 19/03/2021 10:47, Dan Carpenter wrote: > On Thu, Mar 18, 2021 at 02:42:33PM -0600, Jens Axboe wrote: >> On 3/18/21 2:24 PM, Colin Ian King wrote: >>> On 18/03/2021 20:12, Jens Axboe wrote: On 3/18/21 9:16 AM, Colin King wrote: > From: Colin Ian King > > The 3rd argument to allo

Re: [PATCH][next] loop: Fix missing max_active argument in alloc_workqueue call

2021-03-19 Thread Krzysztof Kozlowski
On 18/03/2021 21:42, Jens Axboe wrote: > On 3/18/21 2:24 PM, Colin Ian King wrote: >> On 18/03/2021 20:12, Jens Axboe wrote: >>> On 3/18/21 9:16 AM, Colin King wrote: From: Colin Ian King The 3rd argument to alloc_workqueue should be the max_active count, however currently it i

Re: [PATCH v1] memory: tegra20: Add debug statistics

2021-03-18 Thread Krzysztof Kozlowski
On 18/03/2021 17:18, Dmitry Osipenko wrote: > 18.03.2021 18:23, Krzysztof Kozlowski пишет: > >>> + >>> + /* collect memory controller utilization percent for each client */ >>> + for (i = 0; i < mc->soc->num_clients; i += 2) { >

Re: [PATCH v1] memory: tegra20: Add debug statistics

2021-03-18 Thread Krzysztof Kozlowski
On 18/03/2021 12:55, Dmitry Osipenko wrote: > Add debug statistics collection support. The statistics is available > via debugfs in '/sys/kernel/debug/mc/stats', it shows percent of memory > controller utilization for each memory client. This information is > intended to help with debugging of memo

Re: [PATCH] MIPS: ralink: define stubs for clk_set_parent to fix compile testing

2021-03-17 Thread Krzysztof Kozlowski
On Wed, 17 Mar 2021 at 20:37, Dmitry Osipenko wrote: > > 17.03.2021 12:56, Krzysztof Kozlowski пишет: > > On 17/03/2021 10:52, Sergei Shtylyov wrote: > >> Hello! > >> > >> On 16.03.2021 20:57, Krzysztof Kozlowski wrote: > >> > >>> The

[PATCH v2] MIPS: ralink: define stubs for clk_set_parent to fix compile testing

2021-03-17 Thread Krzysztof Kozlowski
rence to `clk_get_parent' Reported-by: kernel test robot Signed-off-by: Krzysztof Kozlowski Acked-by: John Crispin --- Changes since v1: 1. Use EXPORT_SYMBOL_GPL like two other stubs in the file. 2. Add Ack --- arch/mips/ralink/clk.c | 14 ++ 1 file changed, 14 insertions(+)

Re: [PATCH] MIPS: ralink: define stubs for clk_set_parent to fix compile testing

2021-03-17 Thread Krzysztof Kozlowski
On 17/03/2021 10:52, Sergei Shtylyov wrote: > Hello! > > On 16.03.2021 20:57, Krzysztof Kozlowski wrote: > >> The Ralink MIPS platform does not use Common Clock Framework and does >> not define certain clock operations leading to compile test failures: >> >

Re: [PATCH] MIPS: ralink: define stubs for clk_set_parent to fix compile testing

2021-03-17 Thread Krzysztof Kozlowski
On 16/03/2021 22:58, Thomas Bogendoerfer wrote: > On Tue, Mar 16, 2021 at 06:57:25PM +0100, Krzysztof Kozlowski wrote: >> The Ralink MIPS platform does not use Common Clock Framework and does >> not define certain clock operations leading to compile test failures: >> >>

Re: [PATCH] MIPS: ralink: define stubs for clk_set_parent to fix compile testing

2021-03-17 Thread Krzysztof Kozlowski
On 17/03/2021 01:10, Dmitry Osipenko wrote: > 16.03.2021 20:57, Krzysztof Kozlowski пишет: >> The Ralink MIPS platform does not use Common Clock Framework and does >> not define certain clock operations leading to compile test failures: >> >> /usr/bin/mips-linux-

[PATCH] MIPS: ralink: define stubs for clk_set_parent to fix compile testing

2021-03-16 Thread Krzysztof Kozlowski
rence to `clk_get_parent' Reported-by: kernel test robot Signed-off-by: Krzysztof Kozlowski --- arch/mips/ralink/clk.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/mips/ralink/clk.c b/arch/mips/ralink/clk.c index 2f9d5acb38ea..8387177a47ef 100644 --- a/arch/mips/ra

Re: [PATCH v2] phy: tegra: depend on COMMON_CLK to fix compile tests

2021-03-16 Thread Krzysztof Kozlowski
On 16/03/2021 17:14, Dmitry Osipenko wrote: > 16.03.2021 18:51, Krzysztof Kozlowski пишет: >>>> >>>> But if COMMON_CLK is disabled, then include/linux/clk.h provides a stub >>>> for clk_get_parent(), meaning that MIPS has its own COMMON_CLK, no? >>>

Re: [PATCH v2] phy: tegra: depend on COMMON_CLK to fix compile tests

2021-03-16 Thread Krzysztof Kozlowski
On Tue, 16 Mar 2021 at 16:47, Krzysztof Kozlowski wrote: > > On Tue, 16 Mar 2021 at 16:43, Dmitry Osipenko wrote: > > > > 16.03.2021 10:55, Krzysztof Kozlowski пишет: > > > From: Krzysztof Kozlowski > > > > > > The Tegra USB PHY driver uses Common

Re: [PATCH v2] phy: tegra: depend on COMMON_CLK to fix compile tests

2021-03-16 Thread Krzysztof Kozlowski
On Tue, 16 Mar 2021 at 16:43, Dmitry Osipenko wrote: > > 16.03.2021 10:55, Krzysztof Kozlowski пишет: > > From: Krzysztof Kozlowski > > > > The Tegra USB PHY driver uses Common Clock Framework thus it cannot be > > built on platforms without it (e.g. compil

[tip: irq/core] genirq: Fix typos and misspellings in comments

2021-03-16 Thread tip-bot2 for Krzysztof Kozlowski
The following commit has been merged into the irq/core branch of tip: Commit-ID: 5c982c58752118b6c1f295024d3fda5ff22d3c52 Gitweb: https://git.kernel.org/tip/5c982c58752118b6c1f295024d3fda5ff22d3c52 Author:Krzysztof Kozlowski AuthorDate:Tue, 16 Mar 2021 11:02:05 +01:00

Re: [RESEND PATCH 01/42] mfd: arizona: use PLATFORM_DEVID_NONE

2021-03-16 Thread Krzysztof Kozlowski
On 28/10/2020 23:29, Krzysztof Kozlowski wrote: > Use PLATFORM_DEVID_NONE define instead of "-1" value because: > - it brings some meaning, > - it might point attention why auto device ID was not used. > > Signed-off-by: Krzysztof Kozlowski > Acked-by: Charles K

[RESEND PATCH] mfd: sec: initialize driver via module_platform_driver

2021-03-16 Thread Krzysztof Kozlowski
From: Krzysztof Kozlowski The driver was using subsys_initcall() because in old times deferred probe was not supported everywhere and specific ordering was needed. Since probe deferral works fine and specific ordering is discouraged (hides dependencies between drivers and couples their boot

Re: [PATCH] tty: serial: samsung_tty: remove spinlock flags in interrupt handlers

2021-03-16 Thread Krzysztof Kozlowski
On 16/03/2021 10:56, Johan Hovold wrote: > On Tue, Mar 16, 2021 at 10:47:53AM +0100, Krzysztof Kozlowski wrote: >> On 16/03/2021 10:02, Johan Hovold wrote: >>> On Mon, Mar 15, 2021 at 07:12:12PM +0100, Krzysztof Kozlowski wrote: >>>> Since interrupt handler is called

[PATCH] genirq: fix language typos

2021-03-16 Thread Krzysztof Kozlowski
Fix some language typos and misspellings in comments. No functional changes. Signed-off-by: Krzysztof Kozlowski --- kernel/irq/chip.c | 6 +++--- kernel/irq/ipi.c | 2 +- kernel/irq/manage.c| 6 +++--- kernel/irq/matrix.c| 2 +- kernel/irq/migration.c | 2 +- kernel/irq

<    1   2   3   4   5   6   7   8   9   10   >