Re: [PATCH] mfd: sec-core: Fix uninitialized 'regmap_rtc' on S2MPA01

2014-03-19 Thread Krzysztof Kozlowski
On Wed, 2014-03-19 at 13:57 +0530, Sachin Kamat wrote: On 18 March 2014 18:41, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: Initialize the 'regmap_rtc' on S2MPA01 to some sane value. Sane at least for S5M87X chipsets, not S2MPS/S2MPA but it won't be used because rtc-s5m driver does

Re: [PATCH 0/5] rtc: s5m: Add support for S2MPS14

2014-03-19 Thread Krzysztof Kozlowski
Dear Alessandro Zummo, I'm humbly reminding myself :). If these patches are OK can I have an Ack from you so Lee Jones could apply them to MFD tree? Best regards, Krzysztof Kozlowski On Fri, 2014-02-28 at 14:00 +0100, Krzysztof Kozlowski wrote: Hi, Few days ago I sent patches adding

[PATCH-next] mfd/rtc: s5m: Do not allocate RTC I2C dummy and regmap for unsupported chipsets

2014-03-19 Thread Krzysztof Kozlowski
-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/mfd/sec-core.c | 53 +-- drivers/rtc/rtc-s5m.c| 75 +++--- include/linux/mfd/samsung/core.h |3 -- 3 files changed, 71 insertions(+), 60 deletions(-) diff

Re: [PATCH] mfd: sec-core: Fix uninitialized 'regmap_rtc' on S2MPA01

2014-03-19 Thread Krzysztof Kozlowski
:342:45: warning: ‘regmap_rtc’ may be used uninitialized in this function [-Wuninitialized] Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/mfd/sec-core.c |7 +++ 1 file changed, 7 insertions(+) Please don't send patches in the middle of threads like

Re: [PATCH-next] mfd/rtc: s5m: Do not allocate RTC I2C dummy and regmap for unsupported chipsets

2014-03-19 Thread Krzysztof Kozlowski
driver will use proper regmap config for supported devices. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/mfd/sec-core.c | 53 +-- drivers/rtc/rtc-s5m.c| 75 +++--- include/linux

Re: [PATCH v3 2/3] mfd: sec-core: Add of_compatible strings for clock MFD cells

2014-03-19 Thread Krzysztof Kozlowski
On Tue, 2014-03-18 at 20:31 +, Lee Jones wrote: Add of_compatible strings for S5M8767 and S2MPS14 clock MFD cells. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/mfd/sec-core.c |3 +++ 1 file changed, 3 insertions(+) Applied with Tomasz' Reviewed

Re: [PATCH v3 1/3] clk: s2mps11: Add support for S2MPS14 clocks

2014-03-20 Thread Krzysztof Kozlowski
On Wed, 2014-03-19 at 12:11 -0700, Mike Turquette wrote: Quoting Krzysztof Kozlowski (2014-03-19 00:50:08) On Tue, 2014-03-18 at 17:16 -0700, Mike Turquette wrote: Quoting Krzysztof Kozlowski (2014-03-17 02:19:16) This patch adds support for S2MPS14 PMIC clocks (BT and AP

Re: [PATCH RFT] regulator: s5m8767: Convert to use regulator_[enable|disable|is_enabled]_regmap

2014-03-21 Thread Krzysztof Kozlowski
/s5m8767.c | 78 +++-- 1 file changed, 19 insertions(+), 59 deletions(-) Hi, Works and looks great, thanks! Tested on board with S5M8767. Tested-by: Krzysztof Kozlowski k.kozlow...@samsung.com Reviewed-by Krzysztof Kozlowski k.kozlow...@samsung.com Best

[PATCH 1/2] clk: s2mps11: Fix possible NULL pointer dereference

2014-03-21 Thread Krzysztof Kozlowski
If parent device does not have of_node set the s2mps11_clk_parse_dt() returned NULL. This NULL was later passed to of_clk_add_provider() which dereferenced it in pr_debug() call. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: sta...@vger.kernel.org --- drivers/clk/clk-s2mps11.c

[PATCH 2/2] clk: s2mps11: Use of_get_child_by_name

2014-03-21 Thread Krzysztof Kozlowski
of_find_node_by_name() walks over all nodes and can thus walk outside of the parent node. Use of_get_child_by_name() instead. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/clk/clk-s2mps11.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH-next 1/2] clk: s2mps11: Add missing of_node_put and of_clk_del_provider

2014-03-21 Thread Krzysztof Kozlowski
Add of_clk_del_provider to remove previously registered clock provider. Add of_node_put to decrement the ref count of clock nodes. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/clk/clk-s2mps11.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions

[PATCH-next 2/2] clk: s2mps11: Remove useless check for clk_table

2014-03-21 Thread Krzysztof Kozlowski
There is no need for checking if 'clk_table' is not NULL twice (first after allocation and second at the end of probe()). Also move allocation of this 'clk_table' to probe from s2mps11_clk_parse_dt as this is logical place for it. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com

[PATCH] frontswap: enable call to invalidate area on swapoff

2013-10-07 Thread Krzysztof Kozlowski
frontswap_invalidate_area() so outside of locks (swap_lock and swap_info_struct-lock). This shouldn't be a problem as during swapon the frontswap_map_set() is called also outside of any locks. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- mm/swapfile.c |2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] frontswap: enable call to invalidate area on swapoff

2013-10-08 Thread Krzysztof Kozlowski
On pon, 2013-10-07 at 15:03 -0700, Andrew Morton wrote: On Mon, 07 Oct 2013 17:25:41 +0200 Krzysztof Kozlowski k.kozlow...@samsung.com wrote: During swapoff the frontswap_map was NULL-ified before calling frontswap_invalidate_area(). However the frontswap_invalidate_area() exits early

[PATCH v3 0/6] mm: migrate zbud pages

2013-10-08 Thread Krzysztof Kozlowski
of zbud_reclaim_page() to match usage of zbud page reference counters. 3. Split from patch 2/4 trivial change of scope of freechunks var to separate patch (3/5) (suggested by Seth Jennings). Best regards, Krzysztof Kozlowski Krzysztof Kozlowski (6): zbud: use page ref counter for zbud pages

[PATCH v3 2/6] zbud: make freechunks a block local variable

2013-10-08 Thread Krzysztof Kozlowski
Move freechunks variable in zbud_free() and zbud_alloc() to block-level scope (from function scope). Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- mm/zbud.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/mm/zbud.c b/mm/zbud.c index 7574289..e19f36a

[PATCH v3 3/6] mm: use mapcount for identifying zbud pages

2013-10-08 Thread Krzysztof Kozlowski
Currently zbud pages do not have any flags set so it is not possible to identify them during migration or compaction. Implement PageZbud() by comparing page-_mapcount to -127 to distinguish pages allocated by zbud. Just like PageBuddy() is implemented. Signed-off-by: Krzysztof Kozlowski k.kozlow

[PATCH v3 6/6] mm: migrate zbud pages

2013-10-08 Thread Krzysztof Kozlowski
be replaced for example with pin page control subsystem: http://article.gmane.org/gmane.linux.kernel.mm/105308 In such case the zbud migration code (zbud_migrate_page()) can be safely re-used. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- include/linux/zbud.h |1 + mm/compaction.c

[PATCH v3 4/6] zbud: memset zbud_header to 0 during init

2013-10-08 Thread Krzysztof Kozlowski
memset zbud_header to 0 during init instead of manually assigning 0 to members. Currently only two members needs to be initialized to 0 but further patches will add more of them. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- mm/zbud.c |3 +-- 1 file changed, 1 insertion

[PATCH v3 5/6] zswap: replace tree in zswap with radix tree in zbud

2013-10-08 Thread Krzysztof Kozlowski
of duplicated pages (as it was in original zswap). 2. Use RCU for radix tree reads and updates. 3. Optimize locking in zbud_free_all(). 4. Iterate over LRU list instead of radix tree in zbud_free_all(). Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- include/linux/zbud.h | 27

[PATCH v3 1/6] zbud: use page ref counter for zbud pages

2013-10-08 Thread Krzysztof Kozlowski
and passed to zswap (in zbud_alloc()), - user-supplied eviction callback is called (in zbud_reclaim_page()). Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Reviewed-by: Bob Liu bob@oracle.com --- mm/zbud.c | 117

Re: [PATCH v3 1/6] zbud: use page ref counter for zbud pages

2013-10-09 Thread Krzysztof Kozlowski
On wto, 2013-10-08 at 15:43 -0500, Seth Jennings wrote: On Tue, Oct 08, 2013 at 03:29:35PM +0200, Krzysztof Kozlowski wrote: Use page reference counter for zbud pages. The ref counter replaces zbud_header.under_reclaim flag and ensures that zbud page won't be freed when zbud_free

Re: [PATCH v3 5/6] zswap: replace tree in zswap with radix tree in zbud

2013-10-10 Thread Krzysztof Kozlowski
On Wed, 2013-10-09 at 12:16 -0500, Seth Jennings wrote: On Wed, Oct 09, 2013 at 10:30:22AM -0500, Seth Jennings wrote: In my approach, I was also looking at allowing the zbud pools to use HIGHMEM pages, since the handle is no longer an address. This requires the pages that are being mapped

Re: [PATCH] frontswap: enable call to invalidate area on swapoff

2013-10-11 Thread Krzysztof Kozlowski
On Fri, 2013-10-11 at 10:23 +0800, Weijie Yang wrote: I am sorry to interrupt this topic, but I found an tiny issue near that: we can not set_blocksize(bdev, p-old_block_size); at the end of swapoff() because swap_info p may be reused by concurrent swapon called I think we need to save the

[PATCH] swap: fix set_blocksize race during swapon/swapoff

2013-10-11 Thread Krzysztof Kozlowski
Swapoff used old_block_size from swap_info which could be overwritten by concurrent swapon. Reported-by: Weijie Yang weijie.yang...@gmail.com Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- mm/swapfile.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mm

Re: [RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-09-09 Thread Krzysztof Kozlowski
Hi Bob, On nie, 2013-09-08 at 17:04 +0800, Bob Liu wrote: Hi Krzysztof, On 08/30/2013 04:42 PM, Krzysztof Kozlowski wrote: Use page reference counter for zbud pages. The ref counter replaces zbud_header.under_reclaim flag and ensures that zbud page won't be freed when zbud_free

Re: [RFC PATCH 0/4] mm: migrate zbud pages

2013-09-09 Thread Krzysztof Kozlowski
On pią, 2013-09-06 at 12:30 -0500, Seth Jennings wrote: On Fri, Aug 30, 2013 at 10:42:52AM +0200, Krzysztof Kozlowski wrote: Hi, Currently zbud pages are not movable and they cannot be allocated from CMA region. These patches add migration of zbud pages. Hey Krzysztof, Thanks

[RFC PATCH 0/4] mm: migrate zbud pages

2013-08-30 Thread Krzysztof Kozlowski
* Add missing spin_unlock in zbud_reclaim_page(). * Decrease pool-pages_nr in zbud_free(), not when putting page. This also removes the need of holding lock while call to put_zbud_page(). Best regards, Krzysztof Kozlowski Krzysztof Kozlowski (4): zbud: use page ref counter for zbud pages mm

[RFC PATCH 2/4] mm: use mapcount for identifying zbud pages

2013-08-30 Thread Krzysztof Kozlowski
Currently zbud pages do not have any flags set so it is not possible to identify them during migration or compaction. Implement PageZbud() by comparing page-_mapcount to -127 to distinguish pages allocated by zbud. Just like PageBuddy() is implemented. Signed-off-by: Krzysztof Kozlowski k.kozlow

[RFC PATCH 4/4] mm: migrate zbud pages

2013-08-30 Thread Krzysztof Kozlowski
for example with pin page control subsystem: http://article.gmane.org/gmane.linux.kernel.mm/105308 In such case the zbud migration code (zbud_migrate_page()) can be safely re-used. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- include/linux/zbud.h |1 + mm/compaction.c |7

[RFC PATCH 3/4] mm: use indirect zbud handle and radix tree

2013-08-30 Thread Krzysztof Kozlowski
to address this problem by protecting handles from freeing. Also the call to zbud_unmap() in zswap_writeback_entry() was moved further - when the tree's lock could be obtained. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- include/linux/zbud.h |2 +- mm/zbud.c| 313

[RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-08-30 Thread Krzysztof Kozlowski
and passed to zswap (in zbud_alloc()), - user-supplied eviction callback is called (in zbud_reclaim_page()). Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Reviewed-by: Bob Liu bob@oracle.com --- mm/zbud.c | 97

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-24 Thread Krzysztof Kozlowski
Hi, On pon, 2013-09-23 at 17:07 -0500, Seth Jennings wrote: On Tue, Sep 17, 2013 at 02:59:24PM +0800, Bob Liu wrote: Mel mentioned several problems about zswap/zbud in thread [PATCH v6 0/5] zram/zsmalloc promotion. Like it's clunky as hell and the layering between zswap and zbud is

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-30 Thread Krzysztof Kozlowski
On pią, 2013-09-27 at 17:00 -0500, Seth Jennings wrote: I have to say that when I first came up with the idea, I was thinking the address space would be at the zswap layer and the radix slots would hold zbud handles, not struct page pointers. However, as I have discovered today, this is

[PATCH v2] ARM: EXYNOS: SWRESET is needed to boot secondary CPU on Exynos3250

2014-06-06 Thread Krzysztof Kozlowski
mode. When booting the secondary CPU on Exynos3250 execute also software reset for core 1. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- Changes since v1: 1. Removed inline keyword and change if statement to early return as Tomasz

Re: [PATCH 0/5] Add Maxim 77802 PMIC support

2014-06-09 Thread Krzysztof Kozlowski
On pon, 2014-06-09 at 11:37 +0200, Javier Martinez Canillas wrote: MAX77802 is a PMIC that contains 10 high efficiency Buck regulators, 32 Low-dropout (LDO) regulators, two 32kHz buffered clock outputs, a Real-Time-Clock (RTC) and a I2C interface to program the individual regulators, clocks

Re: [PATCH 1/5] mfd: Add driver for Maxim 77802 Power Management IC

2014-06-09 Thread Krzysztof Kozlowski
On pon, 2014-06-09 at 11:37 +0200, Javier Martinez Canillas wrote: Maxim MAX77802 is a power management chip that contains 10 high efficiency Buck regulators, 32 Low-dropout (LDO) regulators used to power up application processors and peripherals, a 2-channel 32kHz clock outputs, a

Re: [PATCH 0/5] Add Maxim 77802 PMIC support

2014-06-10 Thread Krzysztof Kozlowski
On pon, 2014-06-09 at 09:04 -0700, Doug Anderson wrote: Krzystof, On Mon, Jun 9, 2014 at 3:16 AM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: On pon, 2014-06-09 at 11:37 +0200, Javier Martinez Canillas wrote: MAX77802 is a PMIC that contains 10 high efficiency Buck regulators, 32

Re: [PATCH 0/5] Add Maxim 77802 PMIC support

2014-06-10 Thread Krzysztof Kozlowski
On wto, 2014-06-10 at 00:55 +0200, Javier Martinez Canillas wrote: Hello Krzystof, Thanks a lot for your feedback. On 06/09/2014 06:04 PM, Doug Anderson wrote: Krzystof, On Mon, Jun 9, 2014 at 3:16 AM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: On pon, 2014-06-09 at 11:37

Re: [PATCH 2/5] regulator: max8952: Make of_device_id array const

2014-05-07 Thread Krzysztof Kozlowski
On śro, 2014-05-07 at 17:06 +0900, Jingoo Han wrote: Make of_device_id array const, because all OF functions handle it as const. Signed-off-by: Jingoo Han jg1@samsung.com --- drivers/regulator/max8952.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Krzysztof

Re: [PATCH v2 1/3] regulator: s2mps11: Fix accidental enable of buck6 ramp delay

2014-05-07 Thread Krzysztof Kozlowski
I forgot to CC the stable. Mark, if the patches are OK and if you'll apply them, could you add a CC stable to the commit msg? Best regards, Krzysztof On wto, 2014-05-06 at 08:37 +0200, Krzysztof Kozlowski wrote: S2MPS11 supports enabling/disabling ramp delay only for buck[2346]. Other bucks

[RFT PATCH] regulator: s2mpa01: Use correct register for buck[36] ramp delay

2014-05-07 Thread Krzysztof Kozlowski
instead of buck6 and vice versa). Cc: sta...@vger.kernel.org Fixes: f18792714608 (regulator: Add support for S2MPA01 regulator) Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/regulator/s2mpa01.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [RFT PATCH] regulator: s2mpa01: Use correct register for buck[36] ramp delay

2014-05-07 Thread Krzysztof Kozlowski
On śro, 2014-05-07 at 11:52 +0200, Krzysztof Kozlowski wrote: Buck1 and buck6 share the field (offset 4) in ramp delay register (S2MPA01_REG_RAMP1). The buck3 uses its own field in S2MPA01_REG_RAMP2 register, also at offset 4. The driver interchanged the registers for ramp delay of buck3

Re: [RESEND PATCH] ARM: EXYNOS: Fix the sequence of secondary CPU boot for Exynos3250

2014-06-11 Thread Krzysztof Kozlowski
On śro, 2014-06-11 at 01:57 +0200, Tomasz Figa wrote: On 11.06.2014 01:44, Chanwoo Choi wrote: On 06/11/2014 08:35 AM, Tomasz Figa wrote: Hi Chanwoo, On 11.06.2014 01:27, Chanwoo Choi wrote: This patch set AUTOWAKEUP_EN bit to ARM_CORE_CONFIGURATION register because Exynos3250 removes

Re: [PATCH v3 1/2] mfd: max77693: remove unnecessary wrapper functions

2014-05-21 Thread Krzysztof Kozlowski
On wto, 2014-05-20 at 19:56 +0100, Mark Brown wrote: On Tue, May 20, 2014 at 04:35:06PM +0100, Lee Jones wrote: Mark, In case you missed it (I know, top post, yada yada yada). We're just waiting on your Ack and I can apply the set: Can someone send me the patch as a normal

[PATCH v3 RESEND 2/2] mfd: max77693: handle IRQs using regmap

2014-05-21 Thread Krzysztof Kozlowski
...@samsung.com Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Acked-by: Lee Jones lee.jo...@linaro.org [For extcon part] Acked-by: Chanwoo Choi cw00.c...@samsung.com --- drivers/extcon/extcon-max77693.c | 3 +- drivers/mfd/Kconfig | 1 + drivers/mfd/Makefile

[PATCH v3 RESEND 1/2] mfd: max77693: remove unnecessary wrapper functions

2014-05-21 Thread Krzysztof Kozlowski
From: Robert Baldyga r.bald...@samsung.com This patch removes wrapper functions used to access regmap, and make driver using regmap_*() functions instead. Signed-off-by: Robert Baldyga r.bald...@samsung.com Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Acked-by: Lee Jones lee.jo

[PATCH v4 1/3] clk: s2mps11: Add missing of_node_put and of_clk_del_provider

2014-05-21 Thread Krzysztof Kozlowski
Add of_clk_del_provider to remove previously registered clock provider. Add of_node_put to decrement the ref count of clock nodes. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/clk/clk-s2mps11.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions

[PATCH v4 3/3] clk: s2mps11: Add support for S2MPS14 clocks

2014-05-21 Thread Krzysztof Kozlowski
This patch adds support for S2MPS14 PMIC clocks (BT and AP) to the s2mps11 clock driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Reviewed-by: Yadwinder Singh Brar yadi.b...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com Acked

[PATCH v4 0/3] clk: s2mps11: Fixes and add support for S2MPS14 clocks

2014-05-21 Thread Krzysztof Kozlowski
: Update driver description in Kconfig. 2. Patch 2/3: Add of_compatible to all MFD cells. 3. Add Yadwinder's Review-by. Best regards, Krzysztof Krzysztof Kozlowski (3): clk: s2mps11: Add missing of_node_put and of_clk_del_provider clk: s2mps11: Remove useless check for clk_table clk: s2mps11

[PATCH v4 2/3] clk: s2mps11: Remove useless check for clk_table

2014-05-21 Thread Krzysztof Kozlowski
There is no need for checking if 'clk_table' is not NULL twice (first after allocation and second at the end of probe()). Also move allocation of this 'clk_table' to probe from s2mps11_clk_parse_dt as this is logical place for it. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com

[PATCH] extcon: palmas: Make of_device_id array const

2014-05-23 Thread Krzysztof Kozlowski
Array of struct of_device_id may be be const as expected by of_match_table field. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Graeme Gregory g...@slimlogic.co.uk --- drivers/extcon/extcon-palmas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH] clk: samsung: Make of_device_id array const

2014-05-23 Thread Krzysztof Kozlowski
Array of struct of_device_id may be be const as expected by of_match_table field and of_find_matching_node_and_match() function. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/clk/samsung/clk-exynos4.c| 2 +- drivers/clk/samsung/clk-exynos5250.c | 2 +- drivers/clk

[PATCH on kgene/for-next] ARM: EXYNOS: Do not calculate boot address twice

2014-05-15 Thread Krzysztof Kozlowski
Commit b3205dea8fbf (ARM: EXYNOS: Map SYSRAM through generic DT bindings) introduced local variable boot_reg where boot address from cpu_boot_reg() call is stored. Re-use it instead calling cpu_boot_reg() again. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/mach-exynos

[PATCH] ARM: EXYNOS: SWRESET is needed to boot secondary CPU on Exynos3250

2014-05-15 Thread Krzysztof Kozlowski
mode. When booting the secondary CPU on Exynos3250 execute also software reset for core 1. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/mach-exynos/platsmp.c | 22 ++ arch/arm/mach-exynos/regs-pmu.h | 3 +++ 2 files changed, 25 insertions(+) diff

Re: [PATCH] clk: s2mps11: Simplify s2mps11_clk_probe unwind paths

2014-05-19 Thread Krzysztof Kozlowski
insertions(+), 10 deletions(-) Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Best regards, Krzysztof diff --git a/drivers/clk/clk-s2mps11.c b/drivers/clk/clk-s2mps11.c index f2f62a1b..aeaa61c 100644 --- a/drivers/clk/clk-s2mps11.c +++ b/drivers/clk/clk-s2mps11.c @@ -210,7 +210,7

Re: [PATCH 1/4] mfd: sec-core: Add support for S2MPU02 device

2014-05-29 Thread Krzysztof Kozlowski
+ drivers/mfd/sec-irq.c| 88 include/linux/mfd/samsung/core.h | 1 + include/linux/mfd/samsung/irq.h | 24 +++ 4 files changed, 132 insertions(+) Looks good! Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Best regards

Re: [PATCH 2/4] regulator: s2mps11: Add support S2MPU02 regulator device

2014-05-29 Thread Krzysztof Kozlowski
Hi Chanwoo, Few ideas below: On śro, 2014-05-28 at 20:10 +0900, Chanwoo Choi wrote: This patch add S2MPU02 regulator device to existing S2MPS11 device driver because of existing a litthe different between S2MPS1x and S2MPU02. The S2MPU02 Fix a typo and language: because of little

Re: [PATCH 3/4] regulator: s2mps11: Set offset to voltage hexadecimal code of S2MPU02 LDO regulators

2014-05-29 Thread Krzysztof Kozlowski
On śro, 2014-05-28 at 20:10 +0900, Chanwoo Choi wrote: From: Jonghwa Lee jonghwa3@samsung.com Different with s2mps1x series, s2mpus02's LDO has offset in voltage hexadecimal code, which is used as in selector in regulator subsystem. It means the value of minimum voltage is not start

Re: [PATCH 4/4] dt-bindings: mfd: s2mps11: Add support S2MPU02 PMIC

2014-05-29 Thread Krzysztof Kozlowski
Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Ian Campbell ijc+devicet...@hellion.org.uk Cc: Kumar Gala ga...@codeaurora.org Cc: Randy Dunlap rdun...@infradead.org Cc: Lee Jones lee.jo...@linaro.org Cc: Mark Brown broo...@linaro.org Cc: Krzysztof Kozlowski k.kozlow

Re: [PATCHv2 2/3] regulator: s2mps11: Add support S2MPU02 regulator device

2014-05-30 Thread Krzysztof Kozlowski
is not needed. You are actually returning EINVAL on wrong devices in switch above so: s2mps11-s2mps14_suspend_state |= (1 rdev_get_id(rdev)); would be safe and sufficient. Anyway: Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Best regards, Krzysztof -- To unsubscribe from this list

Re: [PATCH] ARM: EXYNOS: SWRESET is needed to boot secondary CPU on Exynos3250

2014-05-30 Thread Krzysztof Kozlowski
On czw, 2014-05-15 at 13:18 +0200, Krzysztof Kozlowski wrote: Without software reset the secondary CPU does not power up and exynos_boot_secondary() ends with pen_release equal to 1. This can be observed in dmesg: CPU1: failed to come online Brought up 1 CPUs SMP: Total

Re: [PATCH] ARM: exynos4212: hotplug: Fix CPU idle clock down after CPU1 off

2014-05-30 Thread Krzysztof Kozlowski
On wto, 2014-05-13 at 16:12 +0200, Krzysztof Kozlowski wrote: On Exynos4212 USE_DELAYED_RESET_ASSERTION must be set in ARM_CORE1_OPTION register during CPU power down. This is the proper way of powering down CPU. Additionally without this the CPU clock down won't work after powering down CPU1

Re: [PATCH] ARM: exynos4212: hotplug: Fix CPU idle clock down after CPU1 off

2014-05-30 Thread Krzysztof Kozlowski
On pią, 2014-05-30 at 13:50 +0200, Tomasz Figa wrote: Hi Krzysztof, On 13.05.2014 16:12, Krzysztof Kozlowski wrote: On Exynos4212 USE_DELAYED_RESET_ASSERTION must be set in ARM_CORE1_OPTION register during CPU power down. This is the proper way of powering down CPU. Additionally without

Re: [PATCH] ARM: exynos4212: hotplug: Fix CPU idle clock down after CPU1 off

2014-05-30 Thread Krzysztof Kozlowski
On pią, 2014-05-30 at 14:56 +0200, Tomasz Figa wrote: On 30.05.2014 14:46, Krzysztof Kozlowski wrote: On pią, 2014-05-30 at 13:50 +0200, Tomasz Figa wrote: Hi Krzysztof, On 13.05.2014 16:12, Krzysztof Kozlowski wrote: On Exynos4212 USE_DELAYED_RESET_ASSERTION must be set

[PATCH v2] ARM: exynos4: hotplug: Fix CPU idle clock down after CPU off

2014-06-02 Thread Krzysztof Kozlowski
by CPUfreq governor. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- Changes since v1: 1. Use delayed reset assertion on all Exynos4 family and all cores, not only on core 1 of Exynos4212. 2. Rebase on Tomasz Figa's patch: ARM: EXYNOS: Fix core ID used by platsmp and hotplug code

Re: [RFT PATCH] regulator: s2mpa01: Use correct register for buck[36] ramp delay

2014-05-23 Thread Krzysztof Kozlowski
, buck3 and buck6? I have prepared patches for merging s2mpa01 and s2mps11 but this one issue is holding them. Best regards, Krzysztof On śro, 2014-05-07 at 13:10 +0200, Krzysztof Kozlowski wrote: Hi Sachin, I'm looking at SM-N7505 JB Open source code and it seems that I was wrong - the ramp

[RESEND PATCH 2/2] power: max8925: Use of_get_child_by_name

2014-05-26 Thread Krzysztof Kozlowski
Use of_get_child_by_name to obtain reference to charger node instead of of_find_node_by_name which can walk outside of the parent node. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/power/max8925_power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[RESEND PATCH 1/2] power: max8925: Fix NULL ptr dereference on memory allocation failure

2014-05-26 Thread Krzysztof Kozlowski
Check the return value of devm_kzalloc() to fix possible NULL pointer dereference and properly exit the probe() on memory allocation failure. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/power/max8925_power.c | 5 - 1 file changed, 4 insertions(+), 1 deletion

[RESEND PATCH 0/5] charger/mfd: max14577: Part 2 of adding support for MAX77836

2014-05-26 Thread Krzysztof Kozlowski
: charger: max14577: Configure battery-dependent settings from DTS - 4/5: power: max17040: Add ID for MAX77836 Fuel Gauge block These patches were published for the first time around February 2014. Could you look at them? Below is original cover letter. Best regards, Krzysztof Kozlowski Cover

[RESEND PATCH 4/5] power: max17040: Add ID for MAX77836 Fuel Gauge block

2014-05-26 Thread Krzysztof Kozlowski
MAX77836 has the same Fuel Gauge as MAX17040/17048. The max17040 driver can be safely re-used. The patch adds MAX77836 ID to array of i2c_device_id. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Anton Vorontsov an...@enomsg.org Cc

[RESEND PATCH 1/5] charger: max14577: Add support for MAX77836 charger

2014-05-26 Thread Krzysztof Kozlowski
the driver maps them to one enum max14577_muic_charger_type. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Anton Vorontsov an...@enomsg.org Cc: Dmitry Eremin-Solenikov dbarysh...@gmail.com Cc: David Woodhouse dw...@infradead.org Acked

[RESEND PATCH 3/5] charger: max14577: Configure battery-dependent settings from DTS

2014-05-26 Thread Krzysztof Kozlowski
requires valid configuration data from DTS. In case of wrong configuration data it fails during probe. Patch adds of_compatible to the charger mfd cell in MFD driver core. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Dmitry Eremin-Solenikov

[RESEND PATCH 2/5] regulator/mfd: max14577: Export symbols for calculating charger current

2014-05-26 Thread Krzysztof Kozlowski
, MAX77836). Previously they were used only by the max14577 regulator driver. In next patch the charger driver will use them as well. Exporting them will reduce unnecessary code duplication. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Acked

[RESEND PATCH 5/5] devicetree: mfd: max14577: Add device tree bindings document

2014-05-26 Thread Krzysztof Kozlowski
Add document describing device tree bindings for MAX14577 MFD drivers: MFD core, extcon, regulator and charger. Both MAX14577 and MAX77836 chipsets are documented. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Tomasz Figa t.f

[PATCH v2] regulator: s2mpa01: Use correct register for buck1 ramp delay

2014-05-26 Thread Krzysztof Kozlowski
the ramp delay of buck1 was never set. Cc: sta...@vger.kernel.org Fixes: f18792714608 (regulator: Add support for S2MPA01 regulator) Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- Changes since v1: 1. Adjust the patch to match datasheet of S2MPA01. --- drivers/regulator/s2mpa01.c | 1

Re: [RFT PATCH] regulator: s2mpa01: Use correct register for buck[36] ramp delay

2014-05-26 Thread Krzysztof Kozlowski
On pon, 2014-05-26 at 13:37 +0530, Sachin Kamat wrote: Hi Krzysztof Apologies for the delay. I was on vacation during the early part of this month and got busy with some other stuff later and this mail fell through the cracks. On 23 May 2014 19:49, Krzysztof Kozlowski k.kozlow

[PATCH 0/3] regulator: merge s2mps11 and s2mpa01 drivers

2014-05-26 Thread Krzysztof Kozlowski
regards, Krzysztof Krzysztof Kozlowski (3): regulator: s2mps11: Refactor setting ramp delay regulator: s2mps11: Merge S2MPA01 driver regulator: s2mpa01: Remove driver because it was merged into s2mps11 Documentation/devicetree/bindings/mfd/s2mpa01.txt | 90 Documentation/devicetree

[PATCH 1/3] regulator: s2mps11: Refactor setting ramp delay

2014-05-26 Thread Krzysztof Kozlowski
not change as this patch only prepares for supporting S2MPA01 device. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/regulator/s2mps11.c | 210 ++-- 1 file changed, 144 insertions(+), 66 deletions(-) diff --git a/drivers/regulator

[PATCH 3/3] regulator: s2mpa01: Remove driver because it was merged into s2mps11

2014-05-26 Thread Krzysztof Kozlowski
The s2mpa01 regulator driver can be safely removed since it was merged into s2mps11 driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- Documentation/devicetree/bindings/mfd/s2mpa01.txt | 90 drivers/regulator/Kconfig | 7 - drivers/regulator

[PATCH 2/3] regulator: s2mps11: Merge S2MPA01 driver

2014-05-26 Thread Krzysztof Kozlowski
Add S2MPA01 support to the s2mps11 regulator driver. This obsoletes the s2mpa01 regulator driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- Documentation/devicetree/bindings/mfd/s2mps11.txt | 106 drivers/regulator/Kconfig | 4 +- drivers

Re: [PATCH 1/3] regulator: s2mps11: Refactor setting ramp delay

2014-05-27 Thread Krzysztof Kozlowski
On wto, 2014-05-27 at 11:56 +0530, Yadwinder Singh Brar wrote: Hi Krzysztof, On Mon, May 26, 2014 at 6:50 PM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: Prepare for merging the s2mpa01 regulator driver into s2mps11 by: 1. Adding common id for buck regulators. 2. Splitting

Re: [PATCH 2/3] regulator: s2mps11: Merge S2MPA01 driver

2014-05-27 Thread Krzysztof Kozlowski
On wto, 2014-05-27 at 12:00 +0530, Yadwinder Singh Brar wrote: On Mon, May 26, 2014 at 6:50 PM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: Add S2MPA01 support to the s2mps11 regulator driver. This obsoletes the s2mpa01 regulator driver. Signed-off-by: Krzysztof Kozlowski k.kozlow

[PATCH] ARM: multi_v7_defconfig: Enable clock and RTC driver for S2M and S5M

2014-05-28 Thread Krzysztof Kozlowski
The config enables already Samsung's PMIC-s MFD driver and regulators (S2MPS11 and S5M8767). Enable also drivers for rest of these PMIC-s features: clock and RTC. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/configs/multi_v7_defconfig | 2 ++ 1 file changed, 2

[PATCH] ARM: exynos_defconfig: Enable clock and RTC driver for S2M and S5M

2014-05-28 Thread Krzysztof Kozlowski
The config enables already Samsung's PMIC-s MFD driver and regulators (S2MPS11 and S5M8767). Enable also drivers for rest of these PMIC-s features: clock and RTC. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/configs/exynos_defconfig | 2 ++ 1 file changed, 2 insertions

[PATCH 01/16] mfd: max14577: Make mfd_cell array const

2014-05-13 Thread Krzysztof Kozlowski
mfd_add_devices() expects array of struct mfd_cell to be const. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/mfd/max14577.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c index 484d372a4892

[PATCH 13/16] mfd: as3711: Make of_device_id array const

2014-05-13 Thread Krzysztof Kozlowski
Array of struct of_device_id may be be const as expected by of_match_table field. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/mfd/as3711.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd

[PATCH 16/16] mfd: max8907: Make of_device_id array const

2014-05-13 Thread Krzysztof Kozlowski
Array of struct of_device_id may be be const as expected by of_match_table field. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/mfd/max8907.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/max8907.c b/drivers/mfd/max8907.c index

[PATCH 08/16] mfd: wm8400-core: Make mfd_cell array const

2014-05-13 Thread Krzysztof Kozlowski
mfd_add_devices() expects array of struct mfd_cell to be const. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Mark Brown broo...@linaro.org Cc: patc...@opensource.wolfsonmicro.com --- drivers/mfd/wm8400-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 15/16] mfd: max77693: Make of_device_id array const

2014-05-13 Thread Krzysztof Kozlowski
Array of struct of_device_id may be be const as expected by of_match_table field. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Chanwoo Choi cw00.c...@samsung.com --- drivers/mfd/max77693.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/max77693

[PATCH 09/16] mfd: sec-core: Make of_device_id array const

2014-05-13 Thread Krzysztof Kozlowski
Array of struct of_device_id may be be const as expected by both of_match_table field and of_match_node() call. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Sachin Kamat sachin.ka...@linaro.org Cc: Sangbeom Kim sbki...@samsung.com --- drivers/mfd/sec-core.c | 2 +- 1 file

[PATCH 12/16] mfd: max8997: Make of_device_id array const

2014-05-13 Thread Krzysztof Kozlowski
Array of struct of_device_id may be be const as expected by both of_match_table field and of_match_node() call. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/mfd/max8997.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/max8997.c b/drivers

[PATCH 03/16] mfd: ipaq-micro: Make mfd_cell array const

2014-05-13 Thread Krzysztof Kozlowski
mfd_add_devices() expects array of struct mfd_cell to be const. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Linus Walleij linus.wall...@linaro.org --- drivers/mfd/ipaq-micro.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/ipaq-micro.c b

[PATCH 02/16] mfd: max14577: Make of_device_id array const

2014-05-13 Thread Krzysztof Kozlowski
Array of struct of_device_id should be const as expected by both of_match_table field and of_match_device() call. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/mfd/max14577.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/max14577.c b

[PATCH 10/16] mfd: omap-usb-host: Make of_device_id array const

2014-05-13 Thread Krzysztof Kozlowski
Array of struct of_device_id may be be const as expected by of_platform_populate() call. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Roger Quadros rog...@ti.com --- drivers/mfd/omap-usb-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/omap

[PATCH 11/16] mfd: max8998: Make of_device_id array const

2014-05-13 Thread Krzysztof Kozlowski
Array of struct of_device_id may be be const as expected by both of_match_table field and of_match_node() call. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com --- drivers/mfd/max8998.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 14/16] mfd: max77686: Make of_device_id array const

2014-05-13 Thread Krzysztof Kozlowski
Array of struct of_device_id may be be const as expected by of_match_table field. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/mfd/max77686.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c index

[PATCH 07/16] mfd: rtsx_usb: Make mfd_cell array const

2014-05-13 Thread Krzysztof Kozlowski
mfd_add_devices() expects array of struct mfd_cell to be const. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Roger Tseng rogera...@realtek.com --- drivers/mfd/rtsx_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/rtsx_usb.c b/drivers/mfd

[PATCH 04/16] mfd: db8500-prcmu: Make mfd_cell array const

2014-05-13 Thread Krzysztof Kozlowski
mfd_add_devices() expects array of struct mfd_cell to be const. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Mattias Nilsson mattias.i.nils...@stericsson.com Cc: Linus Walleij linus.wall...@linaro.org Cc: linux-arm-ker...@lists.infradead.org --- drivers/mfd/db8500-prcmu.c | 2

[PATCH 06/16] mfd: lp3943: Make mfd_cell array const

2014-05-13 Thread Krzysztof Kozlowski
mfd_add_devices() expects array of struct mfd_cell to be const. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Milo Kim milo@ti.com --- drivers/mfd/lp3943.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/lp3943.c b/drivers/mfd/lp3943.c index

<    1   2   3   4   5   6   7   8   9   10   >