Re: [PATCH 3/3] drivers: remoteproc: add Versal and Versal-NET support

2024-03-18 Thread Krzysztof Kozlowski
On 19/03/2024 02:06, Tanmay Shah wrote: > > > On 3/17/24 1:55 PM, Krzysztof Kozlowski wrote: >> On 15/03/2024 22:15, Tanmay Shah wrote: >>> AMD-Xilinx Versal and Versal-NET are successor of ZynqMP platform. ZynqMP >>> remoteproc driver is mostly compati

Re: [PATCH v13 2/4] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings

2024-03-18 Thread Krzysztof Kozlowski
On 12/03/2024 13:13, Krzysztof Kozlowski wrote: > On 11/03/2024 18:59, Tanmay Shah wrote: >> From: Radhey Shyam Pandey >> >> Introduce bindings for TCM memory address space on AMD-xilinx Zynq >> UltraScale+ platform. It will help in defining TCM in device-tree >&

Re: [PATCH v13 2/4] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings

2024-03-18 Thread Krzysztof Kozlowski
On 11/03/2024 18:59, Tanmay Shah wrote: > From: Radhey Shyam Pandey > > Introduce bindings for TCM memory address space on AMD-xilinx Zynq > UltraScale+ platform. It will help in defining TCM in device-tree > and make it's access platform agnostic and data-driven. > > Tightly-coupled memories(TC

Re: [PATCH 2/3] dt-bindings: remoteproc: add Versal-NET platform

2024-03-18 Thread Krzysztof Kozlowski
On 19/03/2024 01:51, Tanmay Shah wrote: > Hello Krzysztof, > > Thanks for reviews. Please find my comments below. > > On 3/17/24 1:53 PM, Krzysztof Kozlowski wrote: >> On 15/03/2024 22:15, Tanmay Shah wrote: >>> AMD-Xilinx Versal-NET platform is successor of Ve

Re: [PATCH 1/3] dt-bindings: remoteproc: add Versal platform support

2024-03-18 Thread Krzysztof Kozlowski
On 19/03/2024 01:37, Tanmay Shah wrote: > Hello, > > Thanks for reviews, please find my comments below. > > On 3/17/24 9:50 AM, Conor Dooley wrote: >> On Fri, Mar 15, 2024 at 02:15:31PM -0700, Tanmay Shah wrote: >>> AMD-Xilinx Versal platform is successor of ZynqMP platform. Real-time >>> Process

Re: [PATCH 2/3] dt-bindings: remoteproc: add Versal-NET platform

2024-03-20 Thread Krzysztof Kozlowski
On 19/03/2024 15:42, Tanmay Shah wrote: > > > On 3/19/24 12:30 AM, Krzysztof Kozlowski wrote: >> On 19/03/2024 01:51, Tanmay Shah wrote: >>> Hello Krzysztof, >>> >>> Thanks for reviews. Please find my comments below. >>> >>> On 3/17/24

Re: [PATCH 2/3] dt-bindings: remoteproc: add Versal-NET platform

2024-03-21 Thread Krzysztof Kozlowski
On 20/03/2024 16:14, Tanmay Shah wrote: > > > On 3/20/24 2:40 AM, Krzysztof Kozlowski wrote: >> On 19/03/2024 15:42, Tanmay Shah wrote: >>> >>> >>> On 3/19/24 12:30 AM, Krzysztof Kozlowski wrote: >>>> On 19/03/2024 01:51, Tanmay Shah wrote:

Re: [PATCH 2/3] dt-bindings: remoteproc: add Versal-NET platform

2024-03-21 Thread Krzysztof Kozlowski
On 21/03/2024 16:13, Tanmay Shah wrote: > > > On 3/21/24 2:39 AM, Krzysztof Kozlowski wrote: >> On 20/03/2024 16:14, Tanmay Shah wrote: >>> >>> >>> On 3/20/24 2:40 AM, Krzysztof Kozlowski wrote: >>>> On 19/03/2024 15:42, Tanmay Shah w

Re: [PATCH 1/2] dt-bindings: arm: qcom: Add Motorola Moto G (2013)

2024-03-25 Thread Krzysztof Kozlowski
On 24/03/2024 15:03, Stanislav Jakubek wrote: > Document the Motorola Moto G (2013), which is a smartphone based > on the Qualcomm MSM8226 SoC. > > Signed-off-by: Stanislav Jakubek > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 1 + Acked-by: Krzysztof Kozlow

Re: [PATCH 1/3] dt-bindings: remoteproc: qcom,qcs404-cdsp-pil: Fix qcom,halt-regs definition

2024-04-07 Thread Krzysztof Kozlowski
> +- > 1 file changed, 5 insertions(+), 1 deletion(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/3] dt-bindings: remoteproc: qcom,sc7280-wpss-pil: Fix qcom,halt-regs definition

2024-04-07 Thread Krzysztof Kozlowski
On 07/04/2024 11:58, Luca Weiss wrote: > Set the 'items' correctly for the qcom,halt-regs property and update the > description to match what it should be. > > Signed-off-by: Luca Weiss > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 3/3] dt-bindings: remoteproc: qcom,sdm845-adsp-pil: Fix qcom,halt-regs definition

2024-04-07 Thread Krzysztof Kozlowski
> +- > 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCHv3 1/2] dt-bindings: usb: typec: anx7688: start a binding document

2024-04-08 Thread Krzysztof Kozlowski
On 08/04/2024 12:51, Pavel Machek wrote: > Add binding for anx7688 usb type-c bridge. I don't have a datasheet, > but I did best I could. > > Signed-off-by: Pavel Machek ... > + cabledet-gpios: > +maxItems: 1 > +description: GPIO controlling CABLE_DET (C3) pin. > + > + avdd10-supply:

Re: [PATCHv3 1/2] dt-bindings: usb: typec: anx7688: start a binding document

2024-04-08 Thread Krzysztof Kozlowski
On 08/04/2024 13:21, Pavel Machek wrote: > Hi! > >>> Add binding for anx7688 usb type-c bridge. I don't have a datasheet, >>> but I did best I could. >>> >>> Signed-off-by: Pavel Machek >> >> ... >> >>> + cabledet-gpios: >>> +maxItems: 1 >>> +description: GPIO controlling CABLE_DET (C3)

Re: [PATCHv3 1/2] dt-bindings: usb: typec: anx7688: start a binding document

2024-04-08 Thread Krzysztof Kozlowski
On 08/04/2024 13:52, Ondřej Jirman wrote: > On Mon, Apr 08, 2024 at 01:24:03PM GMT, Krzysztof Kozlowski wrote: >> On 08/04/2024 13:21, Pavel Machek wrote: >>> Hi! >>> >>>>> Add binding for anx7688 usb type-c bridge. I don't have a datasheet, >>

Re: [PATCHv3 1/2] dt-bindings: usb: typec: anx7688: start a binding document

2024-04-08 Thread Krzysztof Kozlowski
On 08/04/2024 13:51, Ondřej Jirman wrote: > Hi Krzysztof, > > On Mon, Apr 08, 2024 at 01:17:32PM GMT, Krzysztof Kozlowski wrote: >> On 08/04/2024 12:51, Pavel Machek wrote: >>> Add binding for anx7688 usb type-c bridge. I don't have a datasheet, >>> but I d

Re: [PATCHv3 1/2] dt-bindings: usb: typec: anx7688: start a binding document

2024-04-08 Thread Krzysztof Kozlowski
On 08/04/2024 14:48, Ondřej Jirman wrote: > On Mon, Apr 08, 2024 at 01:59:12PM GMT, Krzysztof Kozlowski wrote: >> On 08/04/2024 13:52, Ondřej Jirman wrote: >>> On Mon, Apr 08, 2024 at 01:24:03PM GMT, Krzysztof Kozlowski wrote: >>>> On 08/04/2024 13:21

Re: [PATCHv3 1/2] dt-bindings: usb: typec: anx7688: start a binding document

2024-04-08 Thread Krzysztof Kozlowski
On 08/04/2024 17:17, Ondřej Jirman wrote: > On Mon, Apr 08, 2024 at 03:27:00PM GMT, Krzysztof Kozlowski wrote: >> On 08/04/2024 14:48, Ondřej Jirman wrote: >>> Yeah, I understand where the confusion is. The driver is not for anx7688 >>> chip >>> really. The

Re: [PATCH] dt-bindings: iio: imu: mpu6050: Improve i2c-gate disallow list

2024-04-08 Thread Krzysztof Kozlowski
where the Linux driver explicitly > disallows support for the auxiliary bus ("inv_mpu_i2c_aux_bus"). Since > the driver is also based on "default: return true" this should scale > better into the future. > > Signed-off-by: Luca Weiss Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/2] dt-bindings: mailbox: qcom: Add MSM8974 APCS compatible

2024-04-08 Thread Krzysztof Kozlowski
On 08/04/2024 21:32, Luca Weiss wrote: > Add compatible for the Qualcomm MSM8974 APCS block. "... The block is already used in DTS, but without any SoC specific compatible." Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/2] dt-bindings: pinctrl: qcom,pmic-gpio: Allow gpio-hog nodes

2024-04-08 Thread Krzysztof Kozlowski
On 08/04/2024 20:36, Luca Weiss wrote: > On Montag, 8. April 2024 19:26:49 CEST Konrad Dybcio wrote: >> >> On 4/8/24 18:39, Luca Weiss wrote: >>> Allow specifying a GPIO hog, as already used on >>> qcom-msm8974-lge-nexus5-hammerhead.dts. >>> >>> Signed-off-by: Luca Weiss >>> --- >>> .../devicetr

Re: [PATCH v14 2/4] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings

2024-04-09 Thread Krzysztof Kozlowski
d dts w/o reg/reg-names works and stable ABI is maintained. > > It also extends the examples for TCM split and lockstep modes. > > Signed-off-by: Radhey Shyam Pandey > Signed-off-by: Tanmay Shah Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/2] ARM: dts: qcom: msm8974: Use proper compatible for APCS syscon

2024-04-09 Thread Krzysztof Kozlowski
On 08/04/2024 21:32, Luca Weiss wrote: > Use the apcs-kpss-global compatible for the APCS global mailbox block > found on this SoC. > > This also resolves a dt-binding checker warning: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom,pmic-gpio: Allow gpio-hog nodes

2024-04-09 Thread Krzysztof Kozlowski
e changed, 12 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 2/2] ARM: dts: qcom: msm8974-hammerhead: Update gpio hog node name

2024-04-09 Thread Krzysztof Kozlowski
On 09/04/2024 20:36, Luca Weiss wrote: > Follow the gpio-hog bindings and use otg-hog as node name. > > Signed-off-by: Luca Weiss > --- > arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: K

[PATCH] rpmsg: qcom_glink_ssr: fix module autoloading

2024-04-10 Thread Krzysztof Kozlowski
Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded based on the alias from of_device_id table. Signed-off-by: Krzysztof Kozlowski --- drivers/rpmsg/qcom_glink_ssr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rpmsg/qcom_glink_ssr.c b/drivers/rpmsg

Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP

2024-04-10 Thread Krzysztof Kozlowski
On 11/04/2024 05:37, olivia.wen wrote: > Under different applications, the MT8188 SCP can be used as single-core > or dual-core. > > Signed-off-by: olivia.wen Are you sure you use full name, not email login as name? > --- > Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 3 ++- > 1

Re: [PATCH 2/2] remoteproc: mediatek: Support MT8188 SCP core 1

2024-04-10 Thread Krzysztof Kozlowski
On 11/04/2024 05:37, olivia.wen wrote: > +}; > + > static const struct of_device_id mtk_scp_of_match[] = { > { .compatible = "mediatek,mt8183-scp", .data = &mt8183_of_data }, > { .compatible = "mediatek,mt8186-scp", .data = &mt8186_of_data }, > @@ -1323,6 +1362,7 @@ static const struct

Re: [PATCH 1/5] dt-bindings: mfd: add entry for Marvell 88PM886 PMIC

2024-04-11 Thread Krzysztof Kozlowski
On 31/03/2024 12:46, Karel Balej wrote: > Marvell 88PM886 is a PMIC with several subdevices such as onkey, > regulators or battery and charger. It comes in at least two revisions, > A0 and A1 -- only A1 is described here at the moment. > > Reviewed-by: Krzysztof Kozlowski > Si

Re: [PATCHv3 1/2] dt-bindings: usb: typec: anx7688: start a binding document

2024-04-11 Thread Krzysztof Kozlowski
On 10/04/2024 04:20, Ondřej Jirman wrote: > On Mon, Apr 08, 2024 at 10:12:30PM GMT, Krzysztof Kozlowski wrote: >> On 08/04/2024 17:17, Ondřej Jirman wrote: >>> >>> Now for things to not fail during suspend/resume based on PM callbacks >>> invocation order,

Re: [PATCH v2] dt-bindings: mfd: qcom,spmi-pmic: Add pbs to SPMI device types

2024-04-12 Thread Krzysztof Kozlowski
On 12/04/2024 16:22, Luca Weiss wrote: > Add the PBS (Programmable Boot Sequencer) to the list of devices. > > Reviewed-by: Bjorn Andersson > Signed-off-by: Luca Weiss > --- > Changes in v2: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/4] dt-bindings: iio: light: stk33xx: add regulator for vdd supply

2024-04-14 Thread Krzysztof Kozlowski
On 14/04/2024 19:57, Aren Moynihan wrote: > Signed-off-by: Aren Moynihan > --- Why? Please provide proper commit msg which will explain why you are doing it (e.g. say about hardware). Anyway empty commit msgs cannot be accepted. Best regards, Krzysztof

Re: [PATCH v2 1/2] dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP

2024-04-19 Thread Krzysztof Kozlowski
On 19/04/2024 10:42, Olivia Wen wrote: > From: "olivia.wen" > > Under different applications, the MT8188 SCP can be used as single-core > or dual-core. > > Signed-off-by: olivia.wen Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 1/6] dt-bindings: iio: light: stk33xx: add vdd and leda regulators

2024-04-23 Thread Krzysztof Kozlowski
On 24/04/2024 00:33, Aren Moynihan wrote: > stk3310 and stk3311 are typically connected to power supplies for the > chip (vdd) and the infrared LED (leda). Add properties so we can power > these up / down appropriately. > > Signed-off-by: Aren Moynihan > --- > Reviewed-by

Re: [PATCH RFC 1/2] dt-bindings: soc: qcom,smsm: Allow specifying mboxes instead of qcom,ipc

2024-05-19 Thread Krzysztof Kozlowski
On 15/05/2024 17:06, Luca Weiss wrote: > Hi Rob, > > Any feedback on the below topic? Can be explained in description, like mboxes: description: Each entry corresponds to one remote processor maxItems: 5 Best regards, Krzysztof

Re: [PATCH RFC 1/2] dt-bindings: soc: qcom,smsm: Allow specifying mboxes instead of qcom,ipc

2024-05-21 Thread Krzysztof Kozlowski
On 20/05/2024 17:11, Luca Weiss wrote: > Hi Krzysztof > > Ack, sounds good. > > Maybe also from you, any opinion between these two binding styles? > > So first using index of mboxes for the numbering, where for the known > usages the first element (and sometimes the 3rd - ipc-2) are empty <>. >

Re: [PATCH v5 2/7] dt-bindings: remoteproc: Add compatibility for TEE support

2024-05-21 Thread Krzysztof Kozlowski
On 21/05/2024 10:09, Arnaud Pouliquen wrote: > The "st,stm32mp1-m4-tee" compatible is utilized in a system configuration > where the Cortex-M4 firmware is loaded by the Trusted execution Environment > (TEE). > For instance, this compatible is used in both the Linux and OP-TEE > device-tree: > - In

Re: [PATCH 1/3] dt-bindings: i2c: qcom-cci: Document SC7280 compatible

2023-09-30 Thread Krzysztof Kozlowski
On 29/09/2023 10:01, Luca Weiss wrote: > Document the compatible for the CCI block found on SC7280 SoC. > > Signed-off-by: Luca Weiss > --- > Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/i2c/qc

Re: [PATCH 1/2] dt-bindings: mfd: qcom,spmi-pmic: Update gpio example

2023-09-30 Thread Krzysztof Kozlowski
On 29/09/2023 10:17, Luca Weiss wrote: > As per commit ea25d61b448a ("arm64: dts: qcom: Use plural _gpios node > label for PMIC gpios") all dts files now use the plural _gpios instead > of the singular _gpio as label. Update the schema example also to match. > > Signed-off-by: Luca Weiss > --- >

Re: [PATCH v2 1/2] dt-bindings: i2c: qcom-cci: Document SC7280 compatible

2023-10-02 Thread Krzysztof Kozlowski
On 02/10/2023 08:55, Luca Weiss wrote: > Document the compatible for the CCI block found on SC7280 SoC. > > Reviewed-by: Bryan O'Donoghue > Signed-off-by: Luca Weiss > --- Thanks, looks good now. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 1/2] dt-bindings: mfd: qcom,spmi-pmic: Drop unused labels from examples

2023-10-02 Thread Krzysztof Kozlowski
dts files to > use the plural _gpios label instead of the singular _gpio as label but > this example wasn't updated. But since we should just drop the label > alltogether, do that. > > Signed-off-by: Luca Weiss Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 2/2] arm64: dts: qcom: pm7250b: Use correct node name for gpios

2023-10-02 Thread Krzysztof Kozlowski
On 02/10/2023 09:00, Luca Weiss wrote: > Use gpio@ instead of pinctrl@ as that's the name expected by the > qcom,spmi-pmic.yaml schema. Update it to fix dt validation. > > Signed-off-by: Luca Weiss Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/7] dt-bindings: ufs: qcom: Add SC7180 compatible string

2023-10-09 Thread Krzysztof Kozlowski
On 07/10/2023 15:58, David Wronek wrote: > Document the compatible for the UFS found on SC7180. > > Signed-off-by: David Wronek > --- > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/7] dt-bindings: phy: Add QMP UFS PHY compatible for SC7180

2023-10-09 Thread Krzysztof Kozlowski
On 07/10/2023 15:58, David Wronek wrote: > Document the QMP UFS PHY compatible for SC7180 > > Signed-off-by: David Wronek > --- > .../devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git > a/Documentation/devicetree/bindings/phy/qc

Re: [PATCH 3/7] dt-bindings: arm: qcom: Add Xiaomi Redmi Note 9S

2023-10-09 Thread Krzysztof Kozlowski
On 07/10/2023 15:58, David Wronek wrote: > Document the Xiaomi Redmi Note 9S (curtana) smartphone, which is based > on the Qualcomm SM7125 SoC. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/3] dt-bindings: arm: qcom: Add HTC One Mini 2

2023-10-11 Thread Krzysztof Kozlowski
On 11/10/2023 19:02, Luca Weiss wrote: > Document the compatible for the MSM8926-based HTC One Mini 2 smartphone. > > Signed-off-by: Luca Weiss Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/3] dt-bindings: vendor-prefixes: document HTC Corporation

2023-10-11 Thread Krzysztof Kozlowski
On 11/10/2023 19:02, Luca Weiss wrote: > Add the vendor prefix for HTC (https://www.htc.com/). > > Signed-off-by: Luca Weiss > --- So it is the first HTC device in upstream? That's a surprise... Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/3] dt-bindings: watchdog: qcom-wdt: Add MSM8226 and MSM8974 compatibles

2023-10-11 Thread Krzysztof Kozlowski
On 11/10/2023 18:33, Luca Weiss wrote: > From: Matti Lehtimäki > > Add compatibles for the MSM8226 and MSM8974 platforms to the Qualcomm > watchdog binding. > > Signed-off-by: Matti Lehtimäki Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/4] iio: adc: Add PM7325 PMIC7 ADC bindings

2023-10-13 Thread Krzysztof Kozlowski
On 13/10/2023 10:09, Luca Weiss wrote: > Add the defines for the ADC channels found on the PM7325. The list is > taken from downstream msm-5.4 and adjusted for mainline. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` o

Re: [PATCH 1/4] iio: adc: Add PM7325 PMIC7 ADC bindings

2023-10-13 Thread Krzysztof Kozlowski
On 13/10/2023 10:54, Luca Weiss wrote: >> We expect the bindings to be dual licensed. What was the license of the >> original work? > > Yes, just GPL-2.0-only: > https://git.codelinaro.org/clo/la/kernel/msm-5.4/-/blob/LA.UM.9.14.1.r1-08600-QCM6490.QSSI13.0/include/dt-bindings/iio/qcom%2Cspmi-adc7-

Re: [PATCH 1/2] dt-bindings: usb: add NXP PTN36502 Type-C redriver bindings

2023-10-15 Thread Krzysztof Kozlowski
; Signed-off-by: Luca Weiss Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH] dt-bindings: arm: cpus: Add Qualcomm Kryo 465

2023-10-22 Thread Krzysztof Kozlowski
On 21/10/2023 09:16, David Wronek wrote: > Add a compatible for the Qualcomm Kryo 465 found in SM7125. > > Signed-off-by: David Wronek > --- > Documentation/devicetree/bindings/arm/cpus.yaml | 1 Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 1/4] ARM: dts: qcom: samsung-matisse-common: Add initial common device tree

2023-10-25 Thread Krzysztof Kozlowski
On 24/10/2023 22:33, Stefan Hansson wrote: > According to the dts from the kernel source code released by Samsung, > matissewifi and matisselte only have minor differences in hardware, so > use a shared dtsi to reduce duplicated code. Additionally, this should > make adding support for matisse3g ea

Re: [PATCH v2 2/4] dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE

2023-10-25 Thread Krzysztof Kozlowski
On 24/10/2023 22:33, Stefan Hansson wrote: > This documents Samsung Galaxy Tab 4 10.1 LTE (samsung,matisselte) > which is a tablet by Samsung based on the MSM8926 SoC. > > Signed-off-by: Stefan Hansson > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 1 + Revi

Re: [PATCH v2 4/4] ARM: dts: qcom: samsung-matisse-common: Add UART

2023-10-25 Thread Krzysztof Kozlowski
On 24/10/2023 22:33, Stefan Hansson wrote: > This was not enabled in the matisse-wifi tree. Your commit msg should explain why this should be enabled. > > Signed-off-by: Stefan Hansson > --- > .../boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi| 4 > 1 file changed, 4 insertion

Re: [PATCH v3 0/4] Add samsung-matisselte and common matisse dtsi

2023-10-25 Thread Krzysztof Kozlowski
On 25/10/2023 10:37, Stefan Hansson wrote: > This series adds a common samsung-matisse dtsi and reworks > samsung-matisse-wifi to use it, and introduces samsung-matisselte. I > choose matisselte over matisse-lte as this is how most other devices > (klte, s3ve3g) do it and it is the codename that Sa

Re: [PATCH v3 2/4] dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE

2023-10-25 Thread Krzysztof Kozlowski
On 25/10/2023 10:37, Stefan Hansson wrote: > This documents Samsung Galaxy Tab 4 10.1 LTE (samsung,matisselte) > which is a tablet by Samsung based on the MSM8926 SoC. > > Signed-off-by: Stefan Hansson > --- This is a friendly reminder during the review process. It looks like you received a tag

Re: [PATCH v3 1/4] ARM: dts: qcom: samsung-matisse-common: Add initial common device tree

2023-10-25 Thread Krzysztof Kozlowski
On 25/10/2023 10:37, Stefan Hansson wrote: > According to the dts from the kernel source code released by Samsung, > matissewifi and matisselte only have minor differences in hardware, so > use a shared dtsi to reduce duplicated code. Additionally, this should > make adding support for matisse3g ea

Re: [PATCH v3 0/4] Add samsung-matisselte and common matisse dtsi

2023-10-25 Thread Krzysztof Kozlowski
On 25/10/2023 10:52, Stefan Hansson wrote: > > > On 2023-10-25 10:48, Krzysztof Kozlowski wrote: >> On 25/10/2023 10:37, Stefan Hansson wrote: >>> This series adds a common samsung-matisse dtsi and reworks >>> samsung-matisse-wifi to use it, and introduces

Re: [PATCH 1/3] dt-bindings: remoteproc: qcom,sm8550-pas: document the SM8650 PAS

2023-10-27 Thread Krzysztof Kozlowski
On 25/10/2023 09:35, Neil Armstrong wrote: > Document the DSP Peripheral Authentication Service on the SM8650 Platform. > > Signed-off-by: Neil Armstrong > --- > .../bindings/remoteproc/qcom,sm8550-pas.yaml | 41 > +- > 1 file changed, 40 insertions(+), 1 deletion(-) >

Re: [PATCH v4 3/4] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE (SM-T535)

2023-10-27 Thread Krzysztof Kozlowski
> > Signed-off-by: Stefan Hansson Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v4 1/4] ARM: dts: qcom: samsung-matisse-common: Add initial common device tree

2023-10-27 Thread Krzysztof Kozlowski
-samsung-matisse-wifi.dts (85%) > copy arch/arm/boot/dts/qcom/{qcom-apq8026-samsung-matisse-wifi.dts => > qcom-msm8226-samsung-matisse-common.dtsi} (86%) Thanks. For me this diff is much more readable - I clearly see what was removed from final DTSI file thus what I should expect in DT

Re: [PATCH v4 4/4] ARM: dts: qcom: samsung-matisse-common: Add UART

2023-10-27 Thread Krzysztof Kozlowski
On 26/10/2023 15:24, Stefan Hansson wrote: > This was not enabled in the matisse-wifi tree. Without this, it is not > possible to use the USB port for serial debugging via a "Carkit debug > cable". > > Signed-off-by: Stefan Hansson Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/9] dt-bindings: remoteproc: qcom: sc7180-pas: Fix SC7280 MPSS PD-names

2023-10-28 Thread Krzysztof Kozlowski
7180-pas: split into > separate file") > Signed-off-by: Luca Weiss > --- > Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/9] arm64: dts: qcom: sc7280: Remove unused second MPSS reg

2023-10-28 Thread Krzysztof Kozlowski
compatible is used. > > Signed-off-by: Luca Weiss > --- > arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi | 2 ++ > arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +-- > 2 files changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 3/9] dt-bindings: remoteproc: qcom: sc7180-pas: Add SC7280 compatibles

2023-10-28 Thread Krzysztof Kozlowski
e changed, 21 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 6/9] arm64: dts: qcom: sc7280: Add ADSP node

2023-10-28 Thread Krzysztof Kozlowski
On 27/10/2023 16:20, Luca Weiss wrote: > Add the node for the ADSP found on the SC7280 SoC, using standard > Qualcomm firmware. > > Signed-off-by: Luca Weiss > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 7/9] arm64: dts: qcom: sc7280: Add CDSP node

2023-10-28 Thread Krzysztof Kozlowski
though I cannot be sure there. > > Signed-off-by: Luca Weiss > --- > arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi | 5 + > arch/arm64/boot/dts/qcom/sc7280.dtsi | 138 > + > 2 files changed, 143 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/2] dt-bindings: mwifiex: document use with the SD8777 chipset

2023-10-29 Thread Krzysztof Kozlowski
On 29/10/2023 12:08, Karel Balej wrote: > Document the corresponding compatible string for the use of this driver > with the Marvell SD8777 wireless chipset. > > Signed-off-by: Karel Balej > --- Acked-by: Krzysztof Kozlowski --- This is an automated instruction, just in cas

Re: [PATCH 1/3] dt-bindings: remoteproc: qcom,sm8550-pas: document the SM8650 PAS

2023-10-30 Thread Krzysztof Kozlowski
On 30/10/2023 09:29, Neil Armstrong wrote: > Ok, I fixed all that > >> >>> + - if: >>> + properties: >>> +compatible: >>> + enum: >>> +- qcom,sm8650-mpss-pas >>> +then: >> >> I am not sure if keeping it in the same binding as sm8550 avoids that >> much duplic

Re: [PATCH v2 1/3] dt-bindings: remoteproc: qcom,sm8550-pas: document the SM8650 PAS

2023-10-30 Thread Krzysztof Kozlowski
rtions(+), 1 deletion(-)' Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

[PATCH] dt-bindings: correct white-spaces in examples

2023-11-24 Thread Krzysztof Kozlowski
Use only one and exactly one space around '=' in DTS example. Signed-off-by: Krzysztof Kozlowski --- Merging idea: Rob's DT. Should apply cleanly on Rob's for-next. --- .../devicetree/bindings/auxdisplay/hit,hd44780.yaml | 2 +- .../devicetree/bindings/clock/bai

Re: [PATCH 2/3] arm64: dts: qcom: sm8250-xiaomi-elish: Sort ufs node

2023-11-24 Thread Krzysztof Kozlowski
On 24/11/2023 14:57, Jianhua Lu wrote: > ufs node isn't in a right place, 'f' is front of 's', so move it to > above usb node. Please not. If we change the order to match DTSI, then this patch would be wrong. Best regards, Krzysztof

Re: [PATCH] dt-bindings: arm: qcom: Fix up htc-memul compatible

2023-12-11 Thread Krzysztof Kozlowski
Mini 2") > Signed-off-by: Luca Weiss > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/2] dt-bindings: arm: qcom: Add Motorola Moto G 4G

2023-12-13 Thread Krzysztof Kozlowski
On 13/12/2023 21:33, André Apitzsch wrote: > Document the compatible for the MSM8926-based Motorola Moto G 4G smartphone. > > Signed-off-by: André Apitzsch > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/2] ARM: dts: qcom: msm8926-motorola-peregrine: Add initial device tree

2023-12-13 Thread Krzysztof Kozlowski
On 13/12/2023 21:33, André Apitzsch wrote: > This dts adds support for Motorola Moto G 4G released in 2013. > > Add a device tree with initial support for: > > - GPIO keys > - Hall sensor > - SDHCI > - Vibrator > > Signed-off-by: André Apitzsch > --- > arch/arm/boot/dts/qcom/Makefile

Re: [PATCH 1/3] dt-bindings: soc: qcom: qcom,pmic-glink: document QCM6490 compatible

2023-12-21 Thread Krzysztof Kozlowski
On 20/12/2023 11:02, Luca Weiss wrote: > Document the QCM6490 compatible used to describe the pmic glink on this > platform. > > Signed-off-by: Luca Weiss > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH RFC 1/2] dt-bindings: soc: qcom,smsm: Allow specifying mboxes instead of qcom,ipc

2024-05-21 Thread Krzysztof Kozlowski
On 21/05/2024 22:35, Luca Weiss wrote: > On Dienstag, 21. Mai 2024 10:58:07 MESZ Krzysztof Kozlowski wrote: >> On 20/05/2024 17:11, Luca Weiss wrote: >>> Hi Krzysztof >>> >>> Ack, sounds good. >>> >>> Maybe also from you, any opinion between

Re: [PATCH 2/5] dt-bindings: mailbox: qcom-ipcc: Add GPDSP0 and GPDSP1 clients

2024-05-22 Thread Krzysztof Kozlowski
On 22/05/2024 14:08, Bartosz Golaszewski wrote: > From: Tengfei Fan > > Add GPDSP0 and GPDSP1 clients for SA8775p platform. > > Signed-off-by: Tengfei Fan > Signed-off-by: Bartosz Golaszewski > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH RFC 1/2] dt-bindings: soc: qcom,smsm: Allow specifying mboxes instead of qcom,ipc

2024-05-22 Thread Krzysztof Kozlowski
On 22/05/2024 19:34, Luca Weiss wrote: > On Mittwoch, 22. Mai 2024 08:49:43 MESZ Krzysztof Kozlowski wrote: >> On 21/05/2024 22:35, Luca Weiss wrote: >>> On Dienstag, 21. Mai 2024 10:58:07 MESZ Krzysztof Kozlowski wrote: >>>> On 20/05/2024 17:11, Luca W

Re: [PATCH RFC 1/2] dt-bindings: soc: qcom,smsm: Allow specifying mboxes instead of qcom,ipc

2024-05-22 Thread Krzysztof Kozlowski
On 23/05/2024 08:16, Luca Weiss wrote: > On Donnerstag, 23. Mai 2024 08:02:13 MESZ Krzysztof Kozlowski wrote: >> On 22/05/2024 19:34, Luca Weiss wrote: >>> On Mittwoch, 22. Mai 2024 08:49:43 MESZ Krzysztof Kozlowski wrote: >>>> On 21/05/2024 22:35, Luca Weiss wrote: &

Re: [PATCH RFC 1/2] dt-bindings: soc: qcom,smsm: Allow specifying mboxes instead of qcom,ipc

2024-05-25 Thread Krzysztof Kozlowski
On 24/05/2024 19:55, Luca Weiss wrote: > On Donnerstag, 23. Mai 2024 08:19:11 MESZ Krzysztof Kozlowski wrote: >> On 23/05/2024 08:16, Luca Weiss wrote: >>> On Donnerstag, 23. Mai 2024 08:02:13 MESZ Krzysztof Kozlowski wrote: >>>> On 22/05/2024 19:34, Luca Weiss wro

Re: [PATCH v2 1/5] dt-bindings: remoteproc: qcom,sa8775p-pas: Document the SA8775p ADSP, CDSP and GPDSP

2024-05-27 Thread Krzysztof Kozlowski
On 27/05/2024 10:43, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Document the components used to boot the ADSP, CDSP0, CDSP1, GPDSP0 and > GPDSP1 on the SA8775p SoC. > > Co-developed-by: Tengfei Fan Missing SoB. > Signed-off-by: Bartosz Golaszewski ... > + > +allOf: > + -

Re: [PATCH v2 1/5] dt-bindings: remoteproc: qcom,sa8775p-pas: Document the SA8775p ADSP, CDSP and GPDSP

2024-05-28 Thread Krzysztof Kozlowski
On 28/05/2024 09:26, Bartosz Golaszewski wrote: > On Mon, May 27, 2024 at 10:56 AM Krzysztof Kozlowski wrote: >> >> On 27/05/2024 10:43, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski >>> >>> Document the components used to boot the ADSP,

Re: [PATCH v2] dt-bindings: remoteproc: k3-dsp: correct optional sram properties for AM62A SoCs

2024-05-31 Thread Krzysztof Kozlowski
On 30/05/2024 18:48, Hari Nagalla wrote: > The C7xv-dsp on AM62A have 32KB L1 I-cache and a 64KB L1 D-cache. It > does not have an addressable l1dram . So, remove this optional sram > property from the bindings to fix device tree build warnings. > > Signed-off-by: Hari Nagalla > --- > Changes fro

Re: [PATCH] arm64: dts: qcom: sm8550-samsung-q5q: fix typo

2024-05-31 Thread Krzysztof Kozlowski
uot;arm64: dts: qcom: sm8550: Add support for Samsung Galaxy Z Fold5") Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/2] dt-bindings: arm: qcom: add HTC One (M8)

2024-06-02 Thread Krzysztof Kozlowski
On 03/06/2024 08:28, Alexandre Messier via B4 Relay wrote: > From: Alexandre Messier > > Add a compatible for the HTC One (M8), which is based on the > MSM8974Pro SoC. > > Signed-off-by: Alexandre Messier > --- Acked-by: Krzysztof Kozlowski --- This is an automated

Re: [PATCH v3] dt-bindings: remoteproc: k3-dsp: correct optional sram properties for AM62A SoCs

2024-06-05 Thread Krzysztof Kozlowski
; --- > Changes in v3: > *) Use allOf keyword with separate ifs for each variant instead >of nested if/else conditions. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/1] dt-bindings: remoteproc: imx_rproc: add minItems for power-domain

2024-06-05 Thread Krzysztof Kozlowski
On 05/06/2024 21:34, Frank Li wrote: > "fsl,imx8qxp-cm4" just need 2 power domains. Keep the same restriction for > other compatible string. > > Signed-off-by: Frank Li > --- > > Notes: > pass dt_binding_check. > > make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 dt_binding_che

Re: [PATCH v3 1/5] dt-bindings: remoteproc: qcom,sa8775p-pas: Document the SA8775p ADSP, CDSP and GPDSP

2024-06-06 Thread Krzysztof Kozlowski
775p-pas.yaml | 160 > + > 1 file changed, 160 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/5] dt-bindings: remoteproc: qcom,sm8550-pas: document the SDX75 PAS

2024-06-06 Thread Krzysztof Kozlowski
On 06/06/2024 16:38, Naina Mehta wrote: > Document the MPSS Peripheral Authentication Service on SDX75 platform. > > Signed-off-by: Naina Mehta > --- > .../devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git > a/Documentation/devi

Re: [PATCH 3/5] arm64: dts: qcom: sdx75: add missing qlink_logging reserved memory for mpss

2024-06-06 Thread Krzysztof Kozlowski
On 06/06/2024 16:38, Naina Mehta wrote: > The qlink_logging memory region is also used by the modem firmware, > add it to reserved memory regions. > Also split MPSS DSM region into 2 separate regions. > > Signed-off-by: Naina Mehta > --- > arch/arm64/boot/dts/qcom/sdx75.dtsi | 17 +--

Re: [PATCH v2 1/2] dt-bindings: soc: qcom,smsm: Allow specifying mboxes instead of qcom,ipc

2024-06-07 Thread Krzysztof Kozlowski
he correct mailbox for each host. The old qcom,ipc-N properties map to > the mboxes property by index, starting at 0 since that's a valid SMSM > host also. > > Mark the older qcom,ipc-N as deprecated and update the example with > mboxes. > > Signed-off-by: Luca Weiss &g

Re: [PATCH v2 1/1] dt-bindings: remoteproc: imx_rproc: add minItems for power-domain

2024-06-07 Thread Krzysztof Kozlowski
On 06/06/2024 17:00, Frank Li wrote: > "fsl,imx8qxp-cm4" and "fsl,imx8qm-cm4" need minimum 2 power domains. Keep > the same restriction for other compatible string. > > Signed-off-by: Frank Li > --- > > Notes: > Change from v1 to v2 > - set minitem to 2 at top > - Add imx8qm compatib

Re: [PATCH v2 1/1] dt-bindings: remoteproc: imx_rproc: add minItems for power-domain

2024-06-10 Thread Krzysztof Kozlowski
On 07/06/2024 17:19, Frank Li wrote: > On Fri, Jun 07, 2024 at 09:32:26AM +0200, Krzysztof Kozlowski wrote: >> On 06/06/2024 17:00, Frank Li wrote: >>> "fsl,imx8qxp-cm4" and "fsl,imx8qm-cm4" need minimum 2 power domains. Keep >>> the same restriction

Re: [PATCH 1/7] dt-bindings: interconnect: Add Qualcomm MSM8976 DT bindings

2024-06-10 Thread Krzysztof Kozlowski
On 09/06/2024 20:20, Adam Skladowski wrote: > Add bindings for Qualcomm MSM8976 Network-On-Chip interconnect devices. > > Signed-off-by: Adam Skladowski A nit, subject: drop second/last, redundant "DT bindings". The "dt-bindings" prefix is already stating that these are bindings. See also: https

Re: [PATCH 2/7] interconnect: qcom: Add MSM8976 interconnect provider driver

2024-06-10 Thread Krzysztof Kozlowski
On 09/06/2024 20:20, Adam Skladowski wrote: > Add driver for interconnect busses found in MSM8976 based platforms. > The topology consists of four NoCs that are partially controlled > by a RPM processor. > > Signed-off-by: Adam Skladowski > + > +static const struct qcom_icc_desc msm8976_snoc_mm

Re: [PATCH 3/7] dt-bindings: interconnect: Add Qualcomm MSM8937 DT bindings

2024-06-10 Thread Krzysztof Kozlowski
On 09/06/2024 20:20, Adam Skladowski wrote: > Add bindings for Qualcomm MSM8937 Network-On-Chip interconnect devices. > > Signed-off-by: Adam Skladowski Since I expect resend, all trivial nits from patch #1 apply here as well. > --- > .../bindings/interconnect/qcom,msm8937.yaml | 81

Re: [PATCH 4/7] interconnect: qcom: Add MSM8937 interconnect provider driver

2024-06-10 Thread Krzysztof Kozlowski
On 09/06/2024 20:20, Adam Skladowski wrote: > Add driver for interconnect busses found in MSM8937 based platforms. > The topology consists of four NoCs that are partially controlled > by a RPM processor. > > Signed-off-by: Adam Skladowski > --- > + > +static const struct of_device_id msm8937_noc

Re: [PATCH 7/7] dt-bindings: interconnect: qcom: msm8939: Fix example

2024-06-10 Thread Krzysztof Kozlowski
On 09/06/2024 20:21, Adam Skladowski wrote: > For now example list snoc_mm as children of bimc which is obviously > not valid, change example and include rest of nocs in it. > > Fixes: 462baaf4c628 ("dt-bindings: interconnect: qcom: Fix and separate out > MSM8939") > Signed-off-by: Adam Skladowsk

<    4   5   6   7   8   9   10   11   12   13   >