Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: free irq before irq_dispose_mapping()

2014-12-01 Thread Lars-Peter Clausen
On 12/01/2014 07:48 PM, Timur Tabi wrote: On 12/01/2014 10:49 AM, Lars-Peter Clausen wrote: The driver creates the mapping by calling irq_of_parse_and_map(), so it also has to dispose the mapping. I agree with Markus, this does seem weird. It sounds like you're saying

Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: free irq before irq_dispose_mapping()

2014-12-01 Thread Lars-Peter Clausen
On 12/01/2014 05:51 PM, Timur Tabi wrote: On 12/01/2014 10:49 AM, Lars-Peter Clausen wrote: The driver creates the mapping by calling irq_of_parse_and_map(), so it also has to dispose the mapping. But the easy way out is to simply use platform_get_irq() instead of irq_of_parse_map(). In this

Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: free irq before irq_dispose_mapping()

2014-12-01 Thread Lars-Peter Clausen
On 12/01/2014 07:50 AM, Markus Pargmann wrote: [...] devm_request_irq() is used by other drivers too, this should not be a problem. Looking at the code it seems that irq_dispose_mapping may not be necessary with devm_request_irq(). So I think it would be better to remove irq_dispose_mapping() in

Re: [alsa-devel][PATCH] ASoC: wm8960: LRCM operation should after software reset

2014-11-26 Thread Lars-Peter Clausen
On 11/26/2014 12:02 PM, Zidan Wang wrote: When shared_lrclk is set, LRCM will be enabled. But the following software reset in wm8960_probe will reset it to the default state. So LRCM operation should after software reset. It's probably a better idea to move the reset (together with the other r

Re: [PATCH] regmap: provide dummy regmap_exit()

2014-11-25 Thread Lars-Peter Clausen
On 11/25/2014 09:21 PM, Olof Johansson wrote: Fixes build error: sound/soc/soc-core.c: In function 'snd_soc_component_exit_regmap': sound/soc/soc-core.c:2644:2: error: implicit declaration of function 'regmap_exit' [-Werror=implicit-function-declaration] regmap_exit(component->regmap); Due

Re: [PATCH v3] ASoC: Remove 'const' from the device_node pointers

2014-11-25 Thread Lars-Peter Clausen
On 11/25/2014 02:13 PM, Mark Brown wrote: On Tue, Nov 25, 2014 at 12:14:48PM +0100, Jean-Francois Moine wrote: As Russell King's explained it, there should not be pointers to struct device_node: "struct device_node is a ref-counted structure. That means if you store a reference to it, you sh

Re: [PATCH 1/2] dma: pl330: improve pl330_tx_status() function

2014-11-25 Thread Lars-Peter Clausen
On 11/25/2014 01:25 PM, Robert Baldyga wrote: [...] static enum dma_status pl330_tx_status(struct dma_chan *chan, dma_cookie_t cookie, struct dma_tx_state *txstate) { - return dma_cookie_status(chan, cookie, txstate); + enum dma_status ret; + unsigned long

Re: [alsa-devel][PATCH v2 1/2] ASoC: wm8960: Add device tree support

2014-11-20 Thread Lars-Peter Clausen
On 11/20/2014 09:41 AM, Zidan Wang wrote: [...][ +Optional properties: + - shared_lrclk: This is a boolean property. If present, the LRCM bit of + R24 (Additional control 2 ) gets set, indicating that ADCLRC and DACLRC + will be disabled only when ADC (Left and Right) and DAC (Left a

Re: [alsa-devel] [PATCH 1/4] regmap: ac97: Add generic AC'97 callbacks

2014-11-19 Thread Lars-Peter Clausen
On 11/18/2014 07:45 PM, Lars-Peter Clausen wrote: From: Mark Brown Use the recently added support for bus operations to provide a standard mapping for AC'97 register I/O. Signed-off-by: Mark Brown Signed-off-by: Lars-Peter Clausen Sorry for that. --- Changes from the original ve

[PATCH 3/4] ASoC: ad1980: Convert to regmap

2014-11-18 Thread Lars-Peter Clausen
This patch converts the ad1980 driver to use regmap for its IO. Signed-off-by: Lars-Peter Clausen --- sound/soc/codecs/Kconfig | 1 + sound/soc/codecs/ad1980.c | 141 -- 2 files changed, 88 insertions(+), 54 deletions(-) diff --git a/sound/soc

[PATCH 2/4] ASoC: Add helper functions for deferred regmap setup

2014-11-18 Thread Lars-Peter Clausen
dds a set of helper function to handle deferred regmap initialization as well as early regmap tear-down. Signed-off-by: Lars-Peter Clausen --- include/sound/soc.h | 35 +++ sound/soc/soc-core.c | 58 ++-- 2 files change

[PATCH 0/4] ASoC: AC'97 regmap support and conversion

2014-11-18 Thread Lars-Peter Clausen
sible to assign a regmap instance to ASoC CODEC (or component) after it has been registered. This is necessary since for AC'97 drivers we allocate the AC'97 device in the CODEC drivers probe callback. For now the series only converts the ad1980 driver, others might follow later. - Lar

[PATCH 1/4] regmap: ac97: Add generic AC'97 callbacks

2014-11-18 Thread Lars-Peter Clausen
From: Mark Brown Use the recently added support for bus operations to provide a standard mapping for AC'97 register I/O. Signed-off-by: Mark Brown --- Changes from the original version: * Add ac97_regmap_bus and made regmap_ac97_reg_{write,read} static * Use ac97->bus->ops inste

[PATCH 4/4] ASoC: ad1980: Remove ac97_read/ac97_write wrappers

2014-11-18 Thread Lars-Peter Clausen
Since the regmap conversion ac97_read/ac97_write are just simple wrappers around snd_soc_read/snd_soc_write. Use those instead directly and remove the wrappers. Signed-off-by: Lars-Peter Clausen --- sound/soc/codecs/ad1980.c | 36 1 file changed, 12

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-16 Thread Lars-Peter Clausen
On 11/16/2014 08:59 AM, Pavel Machek wrote: [...] + adp1653: adp1653@30 { + compatible = "ad,adp1653"; The Analog Devices vendor prefix is adi. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org M

Re: [alsa-devel] [PATCH 1/3] ASoC: twl4030: don't report EBUSY if no change requested.

2014-11-10 Thread Lars-Peter Clausen
On 11/10/2014 10:45 PM, NeilBrown wrote: On Mon, 10 Nov 2014 08:07:50 +0100 Lars-Peter Clausen wrote: On 11/10/2014 01:45 AM, NeilBrown wrote: diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c index b6b0cb399599..613b61cee081 100644 --- a/sound/soc/codecs/twl4030.c +++ b

Re: [alsa-devel] [PATCH 1/3] ASoC: twl4030: don't report EBUSY if no change requested.

2014-11-09 Thread Lars-Peter Clausen
On 11/10/2014 01:45 AM, NeilBrown wrote: diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c index b6b0cb399599..613b61cee081 100644 --- a/sound/soc/codecs/twl4030.c +++ b/sound/soc/codecs/twl4030.c @@ -957,6 +957,16 @@ static int snd_soc_put_twl4030_opmode_enum_double(struct sn

Re: [PATCH] iio:xilinx-xadc:xadc_read_raw INFO_OFFSET

2014-11-07 Thread Lars-Peter Clausen
On 11/07/2014 08:11 PM, Joshua Lamorie wrote: Added a condition for a read of IIO_CHAN_INFO_OFFSET to ensure that an offset is only provided for requests for XADC temperature. The previous assumption was that only requests for temperature would include a read of CHAN_INFO_OFFSET. However there is

Re: [alsa-devel] [PATCH 1/2] ASoC: tfa9879: New driver for NXP Semiconductors TFA9879 amplifier.

2014-11-06 Thread Lars-Peter Clausen
On 11/06/2014 01:54 PM, Peter Rosin wrote: [...] +#define TFA9879_REG(codec, reg, field, value) \ + snd_soc_update_bits(codec, TFA9879_ ## reg, \ + TFA9879_ ## field ## _MASK, \ +

Re: [alsa-devel] [PATCH 2/2] ASoC: tfa9879: Add bass and treble gain/freq controls.

2014-11-06 Thread Lars-Peter Clausen
On 11/06/2014 01:54 PM, Peter Rosin wrote: From: Peter Rosin Signed-off-by: Peter Rosin --- sound/soc/codecs/tfa9879.c | 16 1 file changed, 16 insertions(+) Is there any specific reason why this is separate and not part of the initial patch? -- To unsubscribe from t

Re: [PATCH v2] iio: inkern: Add of_xlate function to struct iio_info

2014-11-03 Thread Lars-Peter Clausen
On 11/03/2014 11:07 AM, Ivan T. Ivanov wrote: On Sat, 2014-10-25 at 11:04 +0100, Jonathan Cameron wrote: On 22/10/14 16:32, Lars-Peter Clausen wrote: On 10/22/2014 05:29 PM, Ivan T. Ivanov wrote: When #iio-cells is greater than '0', the driver could provide a custom of_xlate fun

Re: [alsa-devel] [PATCH] ASoC: add xtensa xtfpga I2S interface and platform

2014-10-28 Thread Lars-Peter Clausen
On 10/28/2014 05:04 PM, Mark Brown wrote: On Tue, Oct 28, 2014 at 04:58:24PM +0100, Lars-Peter Clausen wrote: On 10/27/2014 08:07 PM, Max Filippov wrote: + if (tx_active) { + if (i2s->tx_fifo_high < 256) + xtfpga_i2s_refill_fi

Re: [alsa-devel] [PATCH 00/11] Add AXD Audio Processing IP driver

2014-10-28 Thread Lars-Peter Clausen
On 10/28/2014 04:33 PM, Qais Yousef wrote: On 10/28/2014 02:54 PM, Lars-Peter Clausen wrote: On 10/28/2014 02:18 PM, Qais Yousef wrote: On 10/28/2014 11:55 AM, Clemens Ladisch wrote: Qais Yousef wrote: AXD Audio Processing IP performs audio decoding, encoding, mixing, equalisation

Re: [alsa-devel] [PATCH] ASoC: add xtensa xtfpga I2S interface and platform

2014-10-28 Thread Lars-Peter Clausen
On 10/27/2014 08:07 PM, Max Filippov wrote: A few minor things. [...] +static irqreturn_t xtfpga_i2s_interrupt(int irq, void *dev_id) +{ + struct xtfpga_i2s *i2s = dev_id; + struct snd_pcm_substream *tx_substream; + int tx_active; + unsigned int_status; + + regmap_

Re: [PATCH 00/11] Add AXD Audio Processing IP driver

2014-10-28 Thread Lars-Peter Clausen
On 10/28/2014 02:18 PM, Qais Yousef wrote: On 10/28/2014 11:55 AM, Clemens Ladisch wrote: Qais Yousef wrote: AXD Audio Processing IP performs audio decoding, encoding, mixing, equalisation, synchronisation and playback. What exactly do you mean with "synchronisation" and "playback"? Synchron

Re: [alsa-devel] [PATCH 00/11] Add AXD Audio Processing IP driver

2014-10-28 Thread Lars-Peter Clausen
On 10/28/2014 12:26 PM, Qais Yousef wrote: AXD Audio Processing IP performs audio decoding, encoding, mixing, equalisation, synchronisation and playback. This series adds the driver and DT binding document. [...] I added it to drivers/char as this is the best location I could think of at the mome

Re: [PATCH v2] Staging: iio: adc: fix line over 80 characters

2014-10-23 Thread Lars-Peter Clausen
On 10/22/2014 06:21 AM, Sudip Mukherjee wrote: On Tue, Oct 21, 2014 at 05:56:47PM -0500, Brian Vandre wrote: This fixes the 2 checkpatch.pl warnings: WARNING: line over 80 characters please check your patch with --strict option of checkpatch.pl , and you will get : "Alignment should match ope

Re: [PATCH v2] iio: inkern: Add of_xlate function to struct iio_info

2014-10-22 Thread Lars-Peter Clausen
1:1 mapped channels in IIO chips, and use it when driver did not provide custom implementation. Signed-off-by: Ivan T. Ivanov Reviewed-by: Lars-Peter Clausen Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@

Re: [alsa-devel] [PATCH] ASoC: rockchip-i2s: add rockchip-max98090 driver support

2014-10-21 Thread Lars-Peter Clausen
On 10/21/2014 01:31 PM, Jianqun wrote: This patch is to add support for rockchip board with max98090 codec. It also needs sound node in dt file. Tested on rockchip board based on rk3288. Signed-off-by: Jianqun --- sound/soc/rockchip/Kconfig | 13 + 1 file changed, 13 insertions(

Re: [PATCH] iio: inkern: Add of_xlate function to struct iio_dev

2014-10-18 Thread Lars-Peter Clausen
oaches are used elsewhere (gpio for example). Looks good to me: Reviewed-by: Lars-Peter Clausen When we initially added the DT support to IIO I was hoping that we can get away with just using the simple and generic xlate function for all devices. But it looks as if some more complex devic

Re: [PATCH] dmaengine: pl330: use subsys_initcall

2014-10-17 Thread Lars-Peter Clausen
On 10/17/2014 06:18 PM, Ray Jui wrote: On 10/17/2014 4:15 AM, Lars-Peter Clausen wrote: On 10/17/2014 09:35 AM, Vinod Koul wrote: On Fri, Oct 17, 2014 at 09:45:45AM +0200, Lars-Peter Clausen wrote: On 10/17/2014 02:48 AM, Ray Jui wrote: As part of subsystem that many slave drivers depend on

Re: [PATCH] dmaengine: pl330: use subsys_initcall

2014-10-17 Thread Lars-Peter Clausen
On 10/17/2014 09:35 AM, Vinod Koul wrote: On Fri, Oct 17, 2014 at 09:45:45AM +0200, Lars-Peter Clausen wrote: On 10/17/2014 02:48 AM, Ray Jui wrote: As part of subsystem that many slave drivers depend on, it's more appropriate for the pl330 DMA driver to be initialized at subsys_initcall

Re: [PATCH] dmaengine: pl330: use subsys_initcall

2014-10-17 Thread Lars-Peter Clausen
On 10/17/2014 02:48 AM, Ray Jui wrote: As part of subsystem that many slave drivers depend on, it's more appropriate for the pl330 DMA driver to be initialized at subsys_initcall than device_initcall Well, we do have -EPROBE_DEFER these days to handle these kinds of dependencies so we no longe

Re: [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api

2014-10-16 Thread Lars-Peter Clausen
On 10/14/2014 04:58 PM, Shuah Khan wrote: [...] switch (cmd) { case SNDRV_PCM_TRIGGER_START: + err = media_get_audio_tkn(&subs->dev->dev); + if (err == -EBUSY) { + dev_info(&subs->dev->dev, "%s device is busy\n", +

Re: [RESEND PATCH v2 1/4] dmaengine: pl330: Remove non-NULL check for pl330_submit_req parameters

2014-10-14 Thread Lars-Peter Clausen
On 10/14/2014 01:51 PM, Vinod Koul wrote: On Mon, Sep 29, 2014 at 02:42:18PM +0200, Krzysztof Kozlowski wrote: The pl330_submit_req() checked supplied 'struct pl330_thread thrd' and 'struct dma_pl330_desc desc' parameters for non-NULL. However these checks are useless because supplied arguments

Re: [PATCH 11/12] ASoC: txx9: use dmaengine_terminate_all() API

2014-10-11 Thread Lars-Peter Clausen
On 10/11/2014 05:40 PM, Vinod Koul wrote: The drivers should use dmaengine_terminate_all() API instead of accessing the device_control which will be deprecated soon I already send a similar patch a while ago. It is on it's way into 3.18. Signed-off-by: Vinod Koul -- To unsubscribe from thi

Re: [PATCH] iio: inkern: Add of_xlate function to struct iio_dev

2014-10-02 Thread Lars-Peter Clausen
On 10/02/2014 02:32 PM, Ivan T. Ivanov wrote: When #iio-cells is greater than '0', the driver could provide a custom of_xlate function that reads the *args* and returns the appropriate index in registered IIO channels array. Do you have an example of a device that doesn't want to use the defaul

Re: [PATCH] regmap: Allow read_reg_mask to be 0

2014-10-01 Thread Lars-Peter Clausen
On 10/01/2014 01:39 PM, Dan Murphy wrote: Lars On 09/30/2014 04:29 PM, Lars-Peter Clausen wrote: On 09/30/2014 11:18 PM, Dan Murphy wrote: Lars On 09/30/2014 04:03 PM, Lars-Peter Clausen wrote: On 09/30/2014 06:07 PM, Dan Murphy wrote: There may be spi devices that do not require a

Re: [PATCH] regmap: Allow read_reg_mask to be 0

2014-09-30 Thread Lars-Peter Clausen
On 09/30/2014 11:18 PM, Dan Murphy wrote: Lars On 09/30/2014 04:03 PM, Lars-Peter Clausen wrote: On 09/30/2014 06:07 PM, Dan Murphy wrote: There may be spi devices that do not require a register read mask to read the registers. Currently the code sets the read mask based on a non-zero value

Re: [PATCH] regmap: Allow read_reg_mask to be 0

2014-09-30 Thread Lars-Peter Clausen
On 09/30/2014 06:07 PM, Dan Murphy wrote: There may be spi devices that do not require a register read mask to read the registers. Currently the code sets the read mask based on a non-zero value passed in from the driver or if that value is 0 sets the read mask to 0x80. It only sets it to the

Re: [PATCH v2 1/3] ASoC: ssm2602: do not hardcode type to SSM2602

2014-09-29 Thread Lars-Peter Clausen
("ASoC: ssm2602: Split SPI and I2C code into different \ modules") Acked-by: Lars-Peter Clausen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v2 2/3] ASoC: ssm2602: add device tree bindings

2014-09-29 Thread Lars-Peter Clausen
Acked-by: Lars-Peter Clausen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2 3/3] ASoC: ssm2602: add support for 11.025kHz and 22.5kHz sample rates

2014-09-29 Thread Lars-Peter Clausen
On 09/29/2014 09:41 PM, Stefan Kristiansson wrote: This adds the necessary values to the constraint list and register values to the coefficient table in order to configure the device for 11.025kHz and 22.5kHz sample rates. Signed-off-by: Stefan Kristiansson Acked-by: Lars-Peter Clausen

Re: [PATCH 1/2] ASoC: ssm2602: add device tree bindings

2014-09-29 Thread Lars-Peter Clausen
On 09/29/2014 04:34 PM, Stefan Kristiansson wrote: On Mon, Sep 29, 2014 at 10:50:24AM +0200, Lars-Peter Clausen wrote: On 09/28/2014 09:57 AM, Stefan Kristiansson wrote: Allow the ssm2602/ssm2603/ssm2604 codec driver to be instantiated from the device tree. Also, add Kconfig prompts to allow

Re: [PATCH 2/2] ASoC: ssm2602: add support for 11.025kHz and 22.5kHz sample rates

2014-09-29 Thread Lars-Peter Clausen
On 09/28/2014 09:58 AM, Stefan Kristiansson wrote: This adds the necessary values to the constraint list and register values to the coefficient table in order to configure the device for 11.025kHz and 22.5kHz sample rates. Signed-off-by: Stefan Kristiansson Acked-by: Lars-Peter Clausen

Re: [PATCH 1/2] ASoC: ssm2602: add device tree bindings

2014-09-29 Thread Lars-Peter Clausen
On 09/28/2014 09:57 AM, Stefan Kristiansson wrote: Allow the ssm2602/ssm2603/ssm2604 codec driver to be instantiated from the device tree. Also, add Kconfig prompts to allow manual selection of both the I2C and SPI configuration versions of the driver. Signed-off-by: Stefan Kristiansson Look

Re: [PATCH] i2c: Add generic support passing secondary devices addresses

2014-09-22 Thread Lars-Peter Clausen
On 09/22/2014 03:45 PM, Mika Westerberg wrote: On Mon, Sep 22, 2014 at 03:27:36PM +0200, Lars-Peter Clausen wrote: On 09/22/2014 12:45 PM, Mika Westerberg wrote: On Fri, Sep 05, 2014 at 04:02:19PM +0200, Jean-Michel Hautbois wrote: Some I2C devices have multiple addresses assigned, for

Re: [PATCH] i2c: Add generic support passing secondary devices addresses

2014-09-22 Thread Lars-Peter Clausen
On 09/22/2014 12:45 PM, Mika Westerberg wrote: On Fri, Sep 05, 2014 at 04:02:19PM +0200, Jean-Michel Hautbois wrote: Some I2C devices have multiple addresses assigned, for example each address corresponding to a different internal register map page of the device. So far drivers which need suppor

Re: [PATCH] i2c: Add generic support passing secondary devices addresses

2014-09-21 Thread Lars-Peter Clausen
On 09/21/2014 07:49 PM, Wolfram Sang wrote: This raises the first question for me: Are the additional addresses configurable? Sadly, I can't find good documentation for the adv7604. Otherwise, if I know I have a adv7604 and know its addresses, this information should go into the driver and not

Re: [PATCH] i2c: Add generic support passing secondary devices addresses

2014-09-20 Thread Lars-Peter Clausen
On 09/20/2014 06:49 PM, Wolfram Sang wrote: On Fri, Sep 05, 2014 at 04:02:19PM +0200, Jean-Michel Hautbois wrote: Some I2C devices have multiple addresses assigned, for example each address corresponding to a different internal register map page of the device. So far drivers which need support f

Re: [PATCH] iio: adc: xilinx-xadc: assign auxiliary channels address correctly

2014-09-12 Thread Lars-Peter Clausen
On 09/11/2014 10:55 AM, Subbaraya Sundeep Bhatta wrote: This patch fixes incorrect logic for assigning address to auxiliary channels of xilinx xadc. Signed-off-by: Subbaraya Sundeep Bhatta Acked-by: Lars-Peter Clausen --- drivers/iio/adc/xilinx-xadc-core.c |2 +- 1 files changed, 1

Re: [PATCH 2/3] dmaengine: pl330: Fix NULL pointer dereference on probe failure

2014-09-05 Thread Lars-Peter Clausen
-Peter Clausen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 3/3] dmaengine: pl330: Fix NULL pointer dereference on driver unbind

2014-09-05 Thread Lars-Peter Clausen
On 09/05/2014 05:04 PM, Krzysztof Kozlowski wrote: [...] Signed-off-by: Krzysztof Kozlowski Reviewed-by: Lars-Peter Clausen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: [PATCH 1/3] dmaengine: pl330: Do not dereference pl330_thread pointer before non-NULL check

2014-09-05 Thread Lars-Peter Clausen
On 09/05/2014 05:04 PM, Krzysztof Kozlowski wrote: Do not dereference the 'struct pl330_thread *thrd' before the check for non-NULL value. This fixes following warning: drivers/dma/pl330.c:1376 pl330_submit_req() warn: variable dereferenced before check 'thrd' (see line 1367) I think we can j

Re: [RFC PATCH] dma: pl330: add Power Management support

2014-09-05 Thread Lars-Peter Clausen
On 09/05/2014 05:06 PM, Krzysztof Kozlowski wrote: [...] @@ -2168,11 +2199,23 @@ static void pl330_issue_pending(struct dma_chan *chan) { struct dma_pl330_chan *pch = to_pchan(chan); unsigned long flags; + bool power_up; spin_lock_irqsave(&pch->lock, flags); +

Re: [PATCH] regmap: Fix handling of volatile registers for format_write() chips

2014-08-26 Thread Lars-Peter Clausen
when checking volatility if there is no format_write() operation defined for the device. Signed-off-by: Mark Brown Tested-by: Lars-Peter Clausen Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kerne

Re: [PATCH] staging:iio: moved platform_data into include/linux/iio

2014-08-25 Thread Lars-Peter Clausen
On 08/25/2014 01:49 PM, Sharma, Sanjeev wrote: -Original Message- From: Lars-Peter Clausen [mailto:l...@metafoo.de] Sent: Monday, August 25, 2014 1:39 PM To: Sharma, Sanjeev; sanjeev sharma Cc: ji...@kernel.org; gregkh; linux-...@vger.kernel.org; devel; linux-kernel Subject: Re: [PATCH

Re: [PATCH] staging:iio: moved platform_data into include/linux/iio

2014-08-25 Thread Lars-Peter Clausen
A few of them are OK codestyle wise, but do have ABI issues which need to be resolved before they can be moved. - Lars Regards Sanjeev Sharma -Original Message- From: Lars-Peter Clausen [mailto:l...@metafoo.de] Sent: Wednesday, August 20, 2014 12:20 PM To: sanjeev sharma Cc: S

[PATCH] regmap: Fix regcache debugfs initialization

2014-08-24 Thread Lars-Peter Clausen
gcache are created in the debugfs root directory rather than the debugfs directory of the regmap instance. Fix this by adding a separate callback for the regcache debugfs initialization which will be called after the parent debugfs entry has been created. Signed-off-by: Lars-Peter Clausen --- drivers/b

Re: [PATCH] staging:iio: moved platform_data into include/linux/iio

2014-08-19 Thread Lars-Peter Clausen
On 08/20/2014 08:44 AM, sanjeev sharma wrote: Hi, This was the action item(TO-DO). IMO, it make sense to move into include/linux/iio because IIO complete subsystem may take some time. The code that is in staging is not supposed to 'leak' outside of staging. So either you move the driver as a

Re: [PATCH] staging:iio: moved platform_data into include/linux/iio

2014-08-19 Thread Lars-Peter Clausen
On 08/20/2014 08:41 AM, Sanjeev Sharma wrote: This is a patch to the iio which will move all platform_data into include/linux/iio. It should be moved together with the driver. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.k

Re: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA

2014-08-19 Thread Lars-Peter Clausen
On 08/19/2014 12:35 PM, Takashi Iwai wrote: At Tue, 19 Aug 2014 09:00:06 +, li.xi...@freescale.com wrote: How about the following : diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig index 5ae777a..d42f18c 100644 --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -15,7 +15

Re: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA

2014-08-19 Thread Lars-Peter Clausen
On 08/19/2014 10:36 AM, Lars-Peter Clausen wrote: On 08/19/2014 09:41 AM, Shengjiu Wang wrote: On Mon, Aug 18, 2014 at 06:52:46PM +0200, Lars-Peter Clausen wrote: On 08/18/2014 10:38 AM, Shengjiu Wang wrote: Build kernel with SND_SOC_IMC_PCM_DMA=m && SND_IMX_SOC=n leads the followi

Re: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA

2014-08-19 Thread Lars-Peter Clausen
On 08/19/2014 09:41 AM, Shengjiu Wang wrote: On Mon, Aug 18, 2014 at 06:52:46PM +0200, Lars-Peter Clausen wrote: On 08/18/2014 10:38 AM, Shengjiu Wang wrote: Build kernel with SND_SOC_IMC_PCM_DMA=m && SND_IMX_SOC=n leads the following error: sound/built-in.o: In function `fsl_s

Re: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA

2014-08-18 Thread Lars-Peter Clausen
On 08/18/2014 10:38 AM, Shengjiu Wang wrote: Build kernel with SND_SOC_IMC_PCM_DMA=m && SND_IMX_SOC=n leads the following error: sound/built-in.o: In function `fsl_sai_probe': fsl_sai.c:(.text+0x5f662): undefined reference to `imx_pcm_dma_init' sound/built-in.o: In function `fsl_esai_p

Re: [PATCH 1/1] IIO: Added write function in iio_buffer_fileops

2014-08-14 Thread Lars-Peter Clausen
On 08/13/2014 06:33 PM, Aniroop Mathur wrote: On Wed, Aug 13, 2014 at 8:18 PM, Lars-Peter Clausen wrote: On 08/13/2014 03:42 PM, Aniroop Mathur wrote: On Wed, Aug 13, 2014 at 2:38 PM, Lars-Peter Clausen wrote: On 08/13/2014 08:29 AM, a.mat...@samsung.com wrote: From: Aniroop Mathur

Re: [PATCH 1/1] IIO: Added write function in iio_buffer_fileops

2014-08-13 Thread Lars-Peter Clausen
On 08/13/2014 03:42 PM, Aniroop Mathur wrote: On Wed, Aug 13, 2014 at 2:38 PM, Lars-Peter Clausen wrote: On 08/13/2014 08:29 AM, a.mat...@samsung.com wrote: From: Aniroop Mathur Earlier, user space can only read from iio device node but cannot write to it. This patch adds write function in

Re: [PATCH 1/1] IIO: Added write function in iio_buffer_fileops

2014-08-13 Thread Lars-Peter Clausen
On 08/13/2014 08:29 AM, a.mat...@samsung.com wrote: From: Aniroop Mathur Earlier, user space can only read from iio device node but cannot write to it. This patch adds write function in iio buffer file operations, which will allow user-space applications/HAL to write the data to iio device node

Re: [PATCH] ASoC: dapm: Fix uninitialized variable in snd_soc_dapm_get_enum_double()

2014-08-11 Thread Lars-Peter Clausen
Yes, thanks. Acked-by: Lars-Peter Clausen Signed-off-by: Geert Uytterhoeven -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] Documentation: dmaengine: Add a documentation for the dma controller API

2014-08-04 Thread Lars-Peter Clausen
On 08/02/2014 05:13 PM, Maxime Ripard wrote: On Fri, Aug 01, 2014 at 08:09:17PM +0200, Lars-Peter Clausen wrote: On 08/01/2014 07:15 PM, Vinod Koul wrote: On Fri, Aug 01, 2014 at 10:57:07AM +0200, Maxime Ripard wrote: On Fri, Aug 01, 2014 at 10:00:10AM +0200, Lars-Peter Clausen wrote: On 07

Re: [PATCH] Documentation: dmaengine: Add a documentation for the dma controller API

2014-08-01 Thread Lars-Peter Clausen
On 08/01/2014 07:15 PM, Vinod Koul wrote: On Fri, Aug 01, 2014 at 10:57:07AM +0200, Maxime Ripard wrote: On Fri, Aug 01, 2014 at 10:00:10AM +0200, Lars-Peter Clausen wrote: On 07/31/2014 07:37 PM, Maxime Ripard wrote: On Thu, Jul 31, 2014 at 06:54:11PM +0200, Lars-Peter Clausen wrote: On 07

Re: [PATCH] Documentation: dmaengine: Add a documentation for the dma controller API

2014-08-01 Thread Lars-Peter Clausen
On 07/31/2014 07:37 PM, Maxime Ripard wrote: On Thu, Jul 31, 2014 at 06:54:11PM +0200, Lars-Peter Clausen wrote: On 07/31/2014 06:13 PM, Maxime Ripard wrote: [...] From what you're saying, and judging from the drivers that already implement it, can't it be moved directly to the

Re: [PATCH] Documentation: dmaengine: Add a documentation for the dma controller API

2014-07-31 Thread Lars-Peter Clausen
On 07/31/2014 06:13 PM, Maxime Ripard wrote: [...] From what you're saying, and judging from the drivers that already implement it, can't it be moved directly to the framework itself ? What exactly do you mean by moving it directly to the framework? The slave_caps API is part of the DMAengin

Re: [PATCH] Documentation: dmaengine: Add a documentation for the dma controller API

2014-07-31 Thread Lars-Peter Clausen
On 07/31/2014 09:44 AM, Maxime Ripard wrote: [...] - Having to set device_slave_caps or not? Yes. This should in my opinion be mandatory for new drivers. One of the issues with the DMAengine API is that it is really hard to write generic drivers that do not already know about the capabilit

Re: [PATCH v2 00/11] ARM: dts: zynq: Prepare Parallella

2014-07-28 Thread Lars-Peter Clausen
On 07/28/2014 06:17 PM, Andreas Färber wrote: Hi Lars-Peter, Am 25.07.2014 01:00, schrieb Andreas Färber: most notably I'm missing ADI ADV7513 and AXI-HDMI support [...] Cc: Lars-Peter Clausen (HDMI) Could you please enlighten us what the status of upstreaming ADV7511/ADV7513 suppo

Re: [PATCH v2 09/11] Documentation: devicetree: Fix ADI AXI SPDIF specification

2014-07-25 Thread Lars-Peter Clausen
On 07/25/2014 01:00 AM, Andreas Färber wrote: The specification requires compatible = "adi,axi-spdif-1.00.a" but driver and example and file name indicate "adi,axi-spdif-tx-1.00.a". Change the specification to match the implementation. Signed-off-by: Andreas Färber

Re: [PATCH 1/1] dmaengine: pl330: Check if the DMA descriptor is NULL

2014-07-21 Thread Lars-Peter Clausen
On 07/20/2014 07:58 PM, Javier Martinez Canillas wrote: Hello Lars-Peter, On 07/20/2014 04:18 PM, Lars-Peter Clausen wrote: On 07/19/2014 03:21 AM, Javier Martinez Canillas wrote: Commit 6079d38 ("dmaengine: pl330: Remove useless xfer_cb indirection") removed the __callback() func

Re: [PATCH 1/1] dmaengine: pl330: Check if the DMA descriptor is NULL

2014-07-20 Thread Lars-Peter Clausen
led. (It's wrong to try to complete a descriptor from terminal_all() in the first place, but that's a different issue) Signed-off-by: Javier Martinez Canillas Acked-by: Lars-Peter Clausen --- drivers/dma/pl330.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff

Re: [PATCH v5 1/2] iio: adc: add driver for Rockchip saradc

2014-07-20 Thread Lars-Peter Clausen
On 07/14/2014 10:43 PM, Heiko Stübner wrote: Looks really good overall. [...] +static int rockchip_saradc_read_raw(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + int *val, int *val2, long mask) +{ + stru

Re: [PATCH] checkpatch.pl: Remove --file option

2014-07-18 Thread Lars-Peter Clausen
On 07/17/2014 05:34 PM, Richard Weinberger wrote: [...] In order to deal with that bad habit let's remove the --file option and bring checkpatch.pl back to its original purpose. I don't think this is a good solution the problem and I'm not sure how successful it will actually be at fixing the

Re: [PATCH] staging: iio: adis16203: Use devm_iio_device_register

2014-07-17 Thread Lars-Peter Clausen
On 07/17/2014 10:40 PM, Himangi Saraogi wrote: This patch introduces the use of iio_device_register and does away with the call to the corressponding unregister function in the probe and remove functions of the driver respectively. Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall No, yo

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Lars-Peter Clausen
On 07/17/2014 11:20 AM, Arnd Bergmann wrote: On Thursday 17 July 2014 09:27:58 Chen Gang wrote: gfp_t gfp_mask, unsigned int order); extern void devm_free_pages(struct device *dev, unsigned long addr); +#ifdef CONFIG_HAS_IOMEM void __iomem *devm_ior

Re: [PATCH] dmaengine: jz4740: Fix GPL v2 license string typo

2014-07-16 Thread Lars-Peter Clausen
On 07/16/2014 01:24 AM, Bjorn Helgaas wrote: Per license_is_gpl_compatible(), the MODULE_LICENSE() string for GPL v2 is "GPL v2", not "GPLv2". Use "GPL v2" so this module doesn't taint the kernel. Signed-off-by: Bjorn Helgaas Acked-by: Lars-Peter Claus

Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread Lars-Peter Clausen
On 07/16/2014 01:39 PM, pramod.gurav@gmail.com wrote: From: Pramod Gurav REGMAP_SPMI module calls some functions from SPMI hence build breaks when SPMI is not enabled while compiling REGMAP_SPMI with below linker errors: drivers/built-in.o: In function `regmap_spmi_ext_read': :(.text+0x114

Re: question regarding drivers/staging/iio/adc/ad7280a.c

2014-07-16 Thread Lars-Peter Clausen
On 07/15/2014 07:31 PM, Jonathan Cameron wrote: On 14/07/14 21:31, Himangi Saraogi wrote: Hi, The code seems to have a memory leak. The function ad7280_attr_init calls kasprintf a number of times, which calls kmalloc (or more precisely kmalloc_track_caller), but this data does not ever seem to

Re: [PATCH v3 2/5] staging:iio:hmc5843: Split hmc5843.c to multiple files

2014-07-14 Thread Lars-Peter Clausen
On 07/08/2014 03:39 PM, Josef Gajdusek wrote: [...] diff --git a/drivers/staging/iio/magnetometer/Kconfig b/drivers/staging/iio/magnetometer/Kconfig index ad88d61..28c2612 100644 --- a/drivers/staging/iio/magnetometer/Kconfig +++ b/drivers/staging/iio/magnetometer/Kconfig @@ -5,15 +5,23 @@ menu

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-14 Thread Lars-Peter Clausen
On 07/14/2014 10:31 AM, Richard Weinberger wrote: Am 13.07.2014 22:17, schrieb Greg Kroah-Hartman: On Sun, Jul 13, 2014 at 09:33:38PM +0200, Richard Weinberger wrote: Maybe we could add COMPILE_TEST to the version string too? Just to detect such kernels fast in user bug reports... What kind o

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-13 Thread Lars-Peter Clausen
On 07/13/2014 04:03 PM, Richard Weinberger wrote: Am 13.07.2014 15:56, schrieb Lars-Peter Clausen: On 07/13/2014 03:40 PM, Richard Weinberger wrote: Am 13.07.2014 15:26, schrieb Lars-Peter Clausen: On 07/13/2014 11:45 AM, Richard Weinberger wrote: Am 13.07.2014 11:27, schrieb Lennox Wu: As

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-13 Thread Lars-Peter Clausen
On 07/13/2014 03:40 PM, Richard Weinberger wrote: Am 13.07.2014 15:26, schrieb Lars-Peter Clausen: On 07/13/2014 11:45 AM, Richard Weinberger wrote: Am 13.07.2014 11:27, schrieb Lennox Wu: As I said before, some configurations don't make sense. If such a configuration can be achieved

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-13 Thread Lars-Peter Clausen
On 07/13/2014 11:45 AM, Richard Weinberger wrote: Am 13.07.2014 11:27, schrieb Lennox Wu: As I said before, some configurations don't make sense. If such a configuration can be achieved using allmod/yesconfig it has to be fixed. Chen's fixes seem reasonable as not all architectures support io

Re: [alsa-devel] [PATCH] ASoC: sgtl5000: Use devm_ functions

2014-07-07 Thread Lars-Peter Clausen
On 07/07/2014 05:23 PM, Julia Lawall wrote: On Mon, 7 Jul 2014, Fabio Estevam wrote: On Mon, Jul 7, 2014 at 11:58 AM, Julia Lawall wrote: Nevertheless, there is already a call to devm_regulator_bulk_get in sgtl5000_enable_regulators which calls sgtl5000_replace_vddd_with_ldo which calls ld

Re: [PATCH v2] iio:trigger: Introduce the use of devm_kzalloc

2014-07-07 Thread Lars-Peter Clausen
On 07/07/2014 02:52 PM, Julia Lawall wrote: On Mon, 7 Jul 2014, Jonathan Cameron wrote: On 01/07/14 22:19, Himangi Saraogi wrote: This patch introduces the use of the managed version of kzalloc and removes the kfrees in the probe and remove functions. More return paths are added and the labels

Re: [PATCH v2] iio:trigger: Introduce the use of devm_kzalloc

2014-07-07 Thread Lars-Peter Clausen
-by: Himangi Saraogi Looks sane, but I'd like an ack or reviewed-by from someone as Analog for this one. cc'd Lars and Michael. Acked-by: Lars-Peter Clausen Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to major

Re: [PATCH] staging: iio: Introduce the use of devm_ioremap_resource

2014-07-07 Thread Lars-Peter Clausen
: Himangi Saraogi Acked-by: Julia Lawall Again, looks superficially fine, but I'd like an ack from someone at Analog ideally. Cc'd Lars Acked-by: Lars-Peter Clausen Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCH v2] mips: jz4740: rename usb_nop_xceiv to usb_phy_generic

2014-07-06 Thread Lars-Peter Clausen
kernel unaligned access while trying to dereference musb->xceiv->io_ops in musb_init_controller(). Signed-off-by: Apelete Seketeli Acked-by: Lars-Peter Clausen Ralf, the commit that caused this regression is in v3.16-rc1, can you queue this fix for v3.16-rcX? Thanks, - Lars -- To unsub

Re: [PATCH v3 0/5] ALSA/ASoC/dmaengine: Fix 3 bytes physical sample support

2014-07-03 Thread Lars-Peter Clausen
On 07/03/2014 06:51 AM, Peter Ujfalusi wrote: [...] First step is to add DMA_SLAVE_BUSWIDTH_3_BYTES to dma_slave_buswidth for engines and users to select 3 bytes as bus width. Followed by: In dmaengine_pcm_set_runtime_hwparams() we should check the slave_caps of the dma if it supports the give

Re: [PATCH v3 3/5] ASoC: generic-dmaengine-pcm: Prepare formats mask for valid physical sample sizes

2014-07-03 Thread Lars-Peter Clausen
at it supports 1, 2 and 4 bytes widths. Signed-off-by: Peter Ujfalusi Looks good, thanks. Acked-by: Lars-Peter Clausen --- I know that the format validation could be done like this: + if (bits > 0 && bits <=64 && !(bits % 8) && +

Re: [PATCH v3 4/5] ALSA: pcm_dmaengine: Correct support for 24bits physical sample widths

2014-07-03 Thread Lars-Peter Clausen
the DMA will be able to use this format. Signed-off-by: Peter Ujfalusi Acked-by: Lars-Peter Clausen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [alsa-devel] [PATCH v2 3/5] ASoC: generic-dmaengine-pcm: Prepare formats mask for valid physical sample sizes

2014-07-02 Thread Lars-Peter Clausen
On 07/02/2014 04:12 PM, Takashi Iwai wrote: At Wed, 02 Jul 2014 16:10:09 +0200, Lars-Peter Clausen wrote: On 07/02/2014 03:47 PM, Takashi Iwai wrote: [...] + /* +* Prepare formats mask for valid/allowed sample types. If the dma does +* not have support for the given

Re: [alsa-devel] [PATCH v2 3/5] ASoC: generic-dmaengine-pcm: Prepare formats mask for valid physical sample sizes

2014-07-02 Thread Lars-Peter Clausen
On 07/02/2014 03:47 PM, Takashi Iwai wrote: [...] + /* +* Prepare formats mask for valid/allowed sample types. If the dma does +* not have support for the given physical word size, it needs to be +* masked out so user space can not use the format which produces +

<    2   3   4   5   6   7   8   9   10   11   >