Re: [PATCH 05/19] staging: iio: Remove unnecessary externs

2015-08-15 Thread Lars-Peter Clausen
On 08/15/2015 09:57 PM, Jonathan Cameron wrote: On 11/08/15 19:43, Lars-Peter Clausen wrote: On 08/10/2015 11:51 PM, Joe Perches wrote: Using 'extern' is not necessary for function prototypes. Signed-off-by: Joe Perches j...@perches.com Acked-by: Lars-Peter Clausen l...@metafoo.de Applied

Re: [PATCH] gpiolib: irqchip: use different lockdep class for each gpio irqchip

2015-08-14 Thread Lars-Peter Clausen
On 08/14/2015 02:34 PM, Linus Walleij wrote: [...] > Every chip will get their own lock class on the heap. > > But I think it is a bit kludgy. > > Is it not possible to have the lock key in struct gpio_chip > be a real member instead of a pointer and get a per-chip > lock that way? > > (...) >

Re: [PATCH] gpiolib: irqchip: use different lockdep class for each gpio irqchip

2015-08-14 Thread Lars-Peter Clausen
On 08/14/2015 02:34 PM, Linus Walleij wrote: [...] Every chip will get their own lock class on the heap. But I think it is a bit kludgy. Is it not possible to have the lock key in struct gpio_chip be a real member instead of a pointer and get a per-chip lock that way? (...) struct

Re: [PATCH v2] staging: iio: hmc5843: Set iio name dynamically

2015-08-12 Thread Lars-Peter Clausen
nt. > > With this patch, the iio name will be the same as the i2c device name > > Signed-off-by: Yong Li Looks good. Reviewed-by: Lars-Peter Clausen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org

Re: [PATCH v4] iio: adc: xilinx-xadc: Push interrupts into hardirq context

2015-08-12 Thread Lars-Peter Clausen
4260 > T: 0 ( 2559) P:98 I:1000 C:241557018 Min: 11 Act: 18 Avg: 21 Max: 74 > T: 1 ( 2560) P:98 I:1500 C:161038006 Min: 10 Act: 21 Avg: 20 Max: 73 > > Signed-off-by: Xander Huff Looks good, thanks. Acked-by: Lars-Peter Clausen -- To unsubscribe from this list: send the line &

Re: [PATCH v3 0/6] iio: bmg160: Add SPI connection

2015-08-12 Thread Lars-Peter Clausen
Hi, Markus and Irina can you try to synchronize your efforts. This series will conflict with http://marc.info/?l=linux-iio=143938994602171=2 I think it would be best if the multi-read emulation support is added to regmap (which I think Markus' earlier series did). - Lars On 08/12/2015 04:50

Re: [PATCH v1] staging: iio: hmc5843: Set iio name dynamically based on i2c name

2015-08-12 Thread Lars-Peter Clausen
On 08/12/2015 10:20 AM, sdliy...@gmail.com wrote: > From: Yong Li > > Load the driver using the below command: > echo hmc5983 0x1e > /sys/bus/i2c/devices/i2c-?/new_device > > In sysfs, the iio name is hmc5843, however the i2c name is hmc5983, > they are inconsistent. > > With this patch, the

Re: [PATCH v4] iio: adc: xilinx-xadc: Push interrupts into hardirq context

2015-08-12 Thread Lars-Peter Clausen
:1500 C:161038006 Min: 10 Act: 21 Avg: 20 Max: 73 Signed-off-by: Xander Huff xander.h...@ni.com Looks good, thanks. Acked-by: Lars-Peter Clausen l...@metafoo.de -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v2] staging: iio: hmc5843: Set iio name dynamically

2015-08-12 Thread Lars-Peter Clausen
. With this patch, the iio name will be the same as the i2c device name Signed-off-by: Yong Li sdliy...@gmail.com Looks good. Reviewed-by: Lars-Peter Clausen l...@metafoo.de -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v3 0/6] iio: bmg160: Add SPI connection

2015-08-12 Thread Lars-Peter Clausen
Hi, Markus and Irina can you try to synchronize your efforts. This series will conflict with http://marc.info/?l=linux-iiom=143938994602171w=2 I think it would be best if the multi-read emulation support is added to regmap (which I think Markus' earlier series did). - Lars On 08/12/2015 04:50

Re: [PATCH v1] staging: iio: hmc5843: Set iio name dynamically based on i2c name

2015-08-12 Thread Lars-Peter Clausen
On 08/12/2015 10:20 AM, sdliy...@gmail.com wrote: From: Yong Li sdliy...@gmail.com Load the driver using the below command: echo hmc5983 0x1e /sys/bus/i2c/devices/i2c-?/new_device In sysfs, the iio name is hmc5843, however the i2c name is hmc5983, they are inconsistent. With this

Re: [PATCH 05/19] staging: iio: Remove unnecessary externs

2015-08-11 Thread Lars-Peter Clausen
On 08/10/2015 11:51 PM, Joe Perches wrote: > Using 'extern' is not necessary for function prototypes. > > Signed-off-by: Joe Perches Acked-by: Lars-Peter Clausen Thanks. > --- > drivers/staging/iio/meter/ade7854.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(

Re: [PATCH v3 1/7] iio: adc: hi8435: Holt HI-8435 threshold detector

2015-08-11 Thread Lars-Peter Clausen
On 08/08/2015 07:56 PM, Jonathan Cameron wrote: > On 29/07/15 13:56, Vladimir Barinov wrote: >> Add Holt threshold detector driver for HI-8435 chip >> >> Signed-off-by: Vladimir Barinov > Because it usually reads better that way, I review from the bottom. > Might make more sense if you read the

Re: [PATCH v3 1/7] iio: adc: hi8435: Holt HI-8435 threshold detector

2015-08-11 Thread Lars-Peter Clausen
On 08/08/2015 07:56 PM, Jonathan Cameron wrote: On 29/07/15 13:56, Vladimir Barinov wrote: Add Holt threshold detector driver for HI-8435 chip Signed-off-by: Vladimir Barinov vladimir.bari...@cogentembedded.com Because it usually reads better that way, I review from the bottom. Might make

Re: [PATCH 05/19] staging: iio: Remove unnecessary externs

2015-08-11 Thread Lars-Peter Clausen
On 08/10/2015 11:51 PM, Joe Perches wrote: Using 'extern' is not necessary for function prototypes. Signed-off-by: Joe Perches j...@perches.com Acked-by: Lars-Peter Clausen l...@metafoo.de Thanks. --- drivers/staging/iio/meter/ade7854.h | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH v3 5/7] iio: Support triggered events

2015-08-07 Thread Lars-Peter Clausen
Hi, On 07/29/2015 02:57 PM, Vladimir Barinov wrote: > Support triggered events. > > This is useful for chips that don't have their own interrupt sources. > It allows to use generic/standalone iio triggers for those drivers. > Thanks for the patch. Can you describe in more detail how

Re: [PATCH v3 4/7] iio: trigger: Add periodic polling to SYSFS trigger

2015-08-07 Thread Lars-Peter Clausen
On 07/29/2015 02:57 PM, Vladimir Barinov wrote: > Add periodic polling functionality to SYSFS trigger Daniel's hrtimer trigger should be used for this instead of modifying the sysfs trigger timer. See https://lkml.org/lkml/2015/5/8/367 He said he'll send out a new version shortly. - Lars -- To

Re: [PATCH v3 4/7] iio: trigger: Add periodic polling to SYSFS trigger

2015-08-07 Thread Lars-Peter Clausen
On 07/29/2015 02:57 PM, Vladimir Barinov wrote: Add periodic polling functionality to SYSFS trigger Daniel's hrtimer trigger should be used for this instead of modifying the sysfs trigger timer. See https://lkml.org/lkml/2015/5/8/367 He said he'll send out a new version shortly. - Lars -- To

Re: [PATCH v3 5/7] iio: Support triggered events

2015-08-07 Thread Lars-Peter Clausen
Hi, On 07/29/2015 02:57 PM, Vladimir Barinov wrote: Support triggered events. This is useful for chips that don't have their own interrupt sources. It allows to use generic/standalone iio triggers for those drivers. Thanks for the patch. Can you describe in more detail how

Re: [PATCH v3] iio: adc: xilinx-xadc: Push interrupts into threaded context

2015-08-04 Thread Lars-Peter Clausen
On 08/04/2015 07:34 AM, Shubhrajyoti Datta wrote: > On Fri, Jul 24, 2015 at 6:08 PM, Lars-Peter Clausen wrote: >> Hi, >> >> Sorry, but I don't think this patch has been sufficiently tested against a >> mainline kernel. The driver wont even probe the way it is right now

Re: [PATCH v3] iio: adc: xilinx-xadc: Push interrupts into threaded context

2015-08-04 Thread Lars-Peter Clausen
On 08/03/2015 10:18 PM, Xander Huff wrote: > On 7/24/2015 7:38 AM, Lars-Peter Clausen wrote: >> Hi, >> >> Sorry, but I don't think this patch has been sufficiently tested against a >> mainline kernel. The driver wont even probe the way it is right now. >> > Tha

Re: [PATCH V2] iio: declare struct to fix warning

2015-08-04 Thread Lars-Peter Clausen
On 08/04/2015 09:56 AM, Pengyu Ma wrote: > > > On 08/04/2015 03:54 PM, Lars-Peter Clausen wrote: >> On 08/04/2015 09:52 AM, Pengyu Ma wrote: >>> If this patch is fine, could somebody help me to merge into upstream kernel? >> It will be merged, don't worry. But thin

Re: [PATCH V2] iio: declare struct to fix warning

2015-08-04 Thread Lars-Peter Clausen
On 08/04/2015 09:52 AM, Pengyu Ma wrote: > If this patch is fine, could somebody help me to merge into upstream kernel? It will be merged, don't worry. But things typically take a bit longer than just a single day. > > Thanks, > Pengyu > > On 08/03/2015 10:39 AM, Pengyu Ma wrote: >> When

Re: [PATCH v3] iio: adc: xilinx-xadc: Push interrupts into threaded context

2015-08-04 Thread Lars-Peter Clausen
On 08/03/2015 10:18 PM, Xander Huff wrote: On 7/24/2015 7:38 AM, Lars-Peter Clausen wrote: Hi, Sorry, but I don't think this patch has been sufficiently tested against a mainline kernel. The driver wont even probe the way it is right now. Thanks for your responses. I'm not sure why

Re: [PATCH V2] iio: declare struct to fix warning

2015-08-04 Thread Lars-Peter Clausen
On 08/04/2015 09:52 AM, Pengyu Ma wrote: If this patch is fine, could somebody help me to merge into upstream kernel? It will be merged, don't worry. But things typically take a bit longer than just a single day. Thanks, Pengyu On 08/03/2015 10:39 AM, Pengyu Ma wrote: When compile iio

Re: [PATCH v3] iio: adc: xilinx-xadc: Push interrupts into threaded context

2015-08-04 Thread Lars-Peter Clausen
On 08/04/2015 07:34 AM, Shubhrajyoti Datta wrote: On Fri, Jul 24, 2015 at 6:08 PM, Lars-Peter Clausen l...@metafoo.de wrote: Hi, Sorry, but I don't think this patch has been sufficiently tested against a mainline kernel. The driver wont even probe the way it is right now. On 07/21/2015 01

Re: [PATCH V2] iio: declare struct to fix warning

2015-08-04 Thread Lars-Peter Clausen
On 08/04/2015 09:56 AM, Pengyu Ma wrote: On 08/04/2015 03:54 PM, Lars-Peter Clausen wrote: On 08/04/2015 09:52 AM, Pengyu Ma wrote: If this patch is fine, could somebody help me to merge into upstream kernel? It will be merged, don't worry. But things typically take a bit longer than just

Re: [PATCH 4/6] iio: event: Add missing fields in kernel docs

2015-08-03 Thread Lars-Peter Clausen
On 08/02/2015 09:43 PM, Hartmut Knaack wrote: > Jonathan Cameron schrieb am 02.08.2015 um 19:33: >> On 24/07/15 14:21, Cristina Opriceana wrote: >>> Fix kernel docs warnings by adding the missing fields, >>> each with its associated description. >>> >>> Signed-off-by: Cristina Opriceana >>

Re: [PATCH v4] DocBook: Add initial documentation for IIO

2015-08-03 Thread Lars-Peter Clausen
On 07/31/2015 04:04 PM, Daniel Baluta wrote: > This is intended to help developers faster find their way > inside the Industrial I/O core and reduce time spent on IIO > drivers development. > > Signed-off-by: Daniel Baluta Looks good to me. Thanks again. Reviewed-by: Lar

Re: [PATCH v4] DocBook: Add initial documentation for IIO

2015-08-03 Thread Lars-Peter Clausen
-Peter Clausen l...@metafoo.de -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 4/6] iio: event: Add missing fields in kernel docs

2015-08-03 Thread Lars-Peter Clausen
On 08/02/2015 09:43 PM, Hartmut Knaack wrote: Jonathan Cameron schrieb am 02.08.2015 um 19:33: On 24/07/15 14:21, Cristina Opriceana wrote: Fix kernel docs warnings by adding the missing fields, each with its associated description. Signed-off-by: Cristina Opriceana

Re: [PATCH] iio: declare struct to fix warning

2015-08-02 Thread Lars-Peter Clausen
On 07/30/2015 11:18 AM, Pengyu Ma wrote: > When compile iio related driver the following warning shown: > > include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger' > declared inside parameter list > int (*set_trigger_state)(struct iio_trigger *trig, bool state); > >

Re: [PATCH] iio: declare struct to fix warning

2015-08-02 Thread Lars-Peter Clausen
On 07/30/2015 11:18 AM, Pengyu Ma wrote: When compile iio related driver the following warning shown: include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger' declared inside parameter list int (*set_trigger_state)(struct iio_trigger *trig, bool state);

Re: [PATCH] mmc: sdhci-of-arasan: Get quirks from device tree

2015-07-27 Thread Lars-Peter Clausen
On 07/27/2015 10:04 AM, Shawn Lin wrote: This patch adds the interface to get quirks from dts, and there is no need to assign different quirks by condition statement of arasan IP version. Signed-off-by: Shawn Lin --- drivers/mmc/host/sdhci-of-arasan.c | 7 +++ 1 file changed, 7

Re: [PATCH] mmc: sdhci-of-arasan: Get quirks from device tree

2015-07-27 Thread Lars-Peter Clausen
On 07/27/2015 10:04 AM, Shawn Lin wrote: This patch adds the interface to get quirks from dts, and there is no need to assign different quirks by condition statement of arasan IP version. Signed-off-by: Shawn Lin shawn@rock-chips.com --- drivers/mmc/host/sdhci-of-arasan.c | 7 +++ 1

Re: Nokia N900 - audio TPA6130A2 problems

2015-07-25 Thread Lars-Peter Clausen
On 07/25/2015 12:28 PM, Pali Rohár wrote: Hello, sometimes after rebooting Nokia N900 initializing alsa audio fails. Here output from dmesg log when it happen: [6.925140] tpa6130a2 2-0060: Write failed [6.929534] tpa6130a2 2-0060: Failed to initialize chip [6.935272] tpa6130a2:

Re: Nokia N900 - audio TPA6130A2 problems

2015-07-25 Thread Lars-Peter Clausen
On 07/25/2015 12:28 PM, Pali Rohár wrote: Hello, sometimes after rebooting Nokia N900 initializing alsa audio fails. Here output from dmesg log when it happen: [6.925140] tpa6130a2 2-0060: Write failed [6.929534] tpa6130a2 2-0060: Failed to initialize chip [6.935272] tpa6130a2:

Re: [PATCH v2] DocBook: Add initial documentation for IIO

2015-07-24 Thread Lars-Peter Clausen
On 07/21/2015 10:43 AM, Daniel Baluta wrote: This is intended to help developers faster find their way inside the Industrial I/O core and reduce time spent on IIO drivers development. Signed-off-by: Daniel Baluta Thanks for doing this. diff --git a/Documentation/DocBook/iio.tmpl

Re: [PATCH v3] iio: adc: xilinx-xadc: Push interrupts into threaded context

2015-07-24 Thread Lars-Peter Clausen
Hi, Sorry, but I don't think this patch has been sufficiently tested against a mainline kernel. The driver wont even probe the way it is right now. On 07/21/2015 01:14 AM, Xander Huff wrote: The driver currently registers a pair of irq handlers using request_threaded_irq(), however the

Re: [PATCH v2] DocBook: Add initial documentation for IIO

2015-07-24 Thread Lars-Peter Clausen
On 07/21/2015 10:43 AM, Daniel Baluta wrote: This is intended to help developers faster find their way inside the Industrial I/O core and reduce time spent on IIO drivers development. Signed-off-by: Daniel Baluta daniel.bal...@intel.com Thanks for doing this. diff --git

Re: [PATCH v3] iio: adc: xilinx-xadc: Push interrupts into threaded context

2015-07-24 Thread Lars-Peter Clausen
Hi, Sorry, but I don't think this patch has been sufficiently tested against a mainline kernel. The driver wont even probe the way it is right now. On 07/21/2015 01:14 AM, Xander Huff wrote: The driver currently registers a pair of irq handlers using request_threaded_irq(), however the

Re: [PATCH] MIPS: Remove most of the custom gpio.h

2015-07-23 Thread Lars-Peter Clausen
On 07/22/2015 07:33 PM, Alban Bedel wrote: diff --git a/arch/mips/jz4740/gpio.c b/arch/mips/jz4740/gpio.c index 54c80d4..3dc500c 100644 --- a/arch/mips/jz4740/gpio.c +++ b/arch/mips/jz4740/gpio.c @@ -262,18 +262,6 @@ uint32_t jz_gpio_port_get_value(int port, uint32_t mask) }

Re: [PATCH] MIPS: Remove most of the custom gpio.h

2015-07-23 Thread Lars-Peter Clausen
On 07/22/2015 07:33 PM, Alban Bedel wrote: diff --git a/arch/mips/jz4740/gpio.c b/arch/mips/jz4740/gpio.c index 54c80d4..3dc500c 100644 --- a/arch/mips/jz4740/gpio.c +++ b/arch/mips/jz4740/gpio.c @@ -262,18 +262,6 @@ uint32_t jz_gpio_port_get_value(int port, uint32_t mask) }

Re: [PATCH] iio: Fix iio_validate_scan_mask_oneshot function name typo

2015-07-19 Thread Lars-Peter Clausen
On 07/19/2015 11:49 AM, Jonathan Cameron wrote: On 18/07/15 15:31, Cristina Opriceana wrote: Rename function to iio_validate_scan_mask_oneshot() since it's used to validate that only one channel is selected. Signed-off-by: Cristina Opriceana I'm sure Lars (who I think named it?) will come

Re: [PATCH] iio: Fix iio_validate_scan_mask_oneshot function name typo

2015-07-19 Thread Lars-Peter Clausen
On 07/19/2015 11:49 AM, Jonathan Cameron wrote: On 18/07/15 15:31, Cristina Opriceana wrote: Rename function to iio_validate_scan_mask_oneshot() since it's used to validate that only one channel is selected. Signed-off-by: Cristina Opriceana cristina.oprice...@gmail.com I'm sure Lars (who I

Re: [PATCH 0/4][RFC] regmap: add force write option

2015-07-02 Thread Lars-Peter Clausen
On 06/16/2015 10:51 AM, Kuninori Morimoto wrote: Hi Mark Current _regmap_update_bits() writes data to register if current value and write value was different. This means it doesn't write data if the value was same as current value. But, some device needs to write data even though it was same

Re: [PATCH 0/4][RFC] regmap: add force write option

2015-07-02 Thread Lars-Peter Clausen
On 06/16/2015 10:51 AM, Kuninori Morimoto wrote: Hi Mark Current _regmap_update_bits() writes data to register if current value and write value was different. This means it doesn't write data if the value was same as current value. But, some device needs to write data even though it was same

Re: [alsa-devel] [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep

2015-06-30 Thread Lars-Peter Clausen
On 06/30/2015 06:56 AM, Nicolas Boichat wrote: On Mon, Jun 29, 2015 at 04:34:11PM +0100, Mark Brown wrote: On Mon, Jun 29, 2015 at 04:18:11PM +0200, Lars-Peter Clausen wrote: Leaves us pretty much with only two options. Either add a lock key pointer to regmap_config which needs to be manually

Re: [PATCH] dmaengine: pl330: Really fix choppy sound because of wrong residue calculation

2015-06-30 Thread Lars-Peter Clausen
abriel so there is high chance that his issue is also fixed. However it is sad that I did not receive any reviews or tests from anyone, apparently no one cares enough about it :) . I care, I've had it in applied to my local tree for a while now. Without it audio does not work. Tested-by: Lars-Peter C

Re: [PATCH] dmaengine: pl330: Really fix choppy sound because of wrong residue calculation

2015-06-30 Thread Lars-Peter Clausen
for a while now. Without it audio does not work. Tested-by: Lars-Peter Clausen l...@metafoo.de -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [alsa-devel] [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep

2015-06-30 Thread Lars-Peter Clausen
On 06/30/2015 06:56 AM, Nicolas Boichat wrote: On Mon, Jun 29, 2015 at 04:34:11PM +0100, Mark Brown wrote: On Mon, Jun 29, 2015 at 04:18:11PM +0200, Lars-Peter Clausen wrote: Leaves us pretty much with only two options. Either add a lock key pointer to regmap_config which needs to be manually

Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep

2015-06-29 Thread Lars-Peter Clausen
On 06/29/2015 04:03 PM, Nicolas Boichat wrote: On Mon, Jun 29, 2015 at 8:59 PM, Lars-Peter Clausen wrote: On 06/29/2015 02:51 PM, Nicolas Boichat wrote: On Fri, Jun 26, 2015 at 11:16 AM, Nicolas Boichat wrote: On Fri, Jun 26, 2015 at 12:08 AM, Mark Brown wrote: [...] As far as I can

Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep

2015-06-29 Thread Lars-Peter Clausen
On 06/29/2015 02:51 PM, Nicolas Boichat wrote: On Fri, Jun 26, 2015 at 11:16 AM, Nicolas Boichat wrote: On Fri, Jun 26, 2015 at 12:08 AM, Mark Brown wrote: [...] As far as I can tell we're likely to end up needing a key per regmap or something similar. Since the number of lockdep classes

Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep

2015-06-29 Thread Lars-Peter Clausen
On 06/29/2015 02:51 PM, Nicolas Boichat wrote: On Fri, Jun 26, 2015 at 11:16 AM, Nicolas Boichat drink...@chromium.org wrote: On Fri, Jun 26, 2015 at 12:08 AM, Mark Brown broo...@kernel.org wrote: [...] As far as I can tell we're likely to end up needing a key per regmap or something similar.

Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep

2015-06-29 Thread Lars-Peter Clausen
On 06/29/2015 04:03 PM, Nicolas Boichat wrote: On Mon, Jun 29, 2015 at 8:59 PM, Lars-Peter Clausen l...@metafoo.de wrote: On 06/29/2015 02:51 PM, Nicolas Boichat wrote: On Fri, Jun 26, 2015 at 11:16 AM, Nicolas Boichat drink...@chromium.org wrote: On Fri, Jun 26, 2015 at 12:08 AM, Mark

Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep

2015-06-26 Thread Lars-Peter Clausen
On 06/26/2015 04:34 AM, Nicolas Boichat wrote: On Thu, Jun 25, 2015 at 11:59 PM, Lars-Peter Clausen wrote: [...] diff --git a/include/linux/regmap.h b/include/linux/regmap.h index 116655d..09aaaf5 100644 --- a/include/linux/regmap.h +++ b/include/linux/regmap.h @@ -135,6 +135,12 @@ typedef

Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep

2015-06-26 Thread Lars-Peter Clausen
On 06/26/2015 04:34 AM, Nicolas Boichat wrote: On Thu, Jun 25, 2015 at 11:59 PM, Lars-Peter Clausen l...@metafoo.de wrote: [...] diff --git a/include/linux/regmap.h b/include/linux/regmap.h index 116655d..09aaaf5 100644 --- a/include/linux/regmap.h +++ b/include/linux/regmap.h @@ -135,6

Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep

2015-06-25 Thread Lars-Peter Clausen
[...] diff --git a/include/linux/regmap.h b/include/linux/regmap.h index 116655d..09aaaf5 100644 --- a/include/linux/regmap.h +++ b/include/linux/regmap.h @@ -135,6 +135,12 @@ typedef void (*regmap_unlock)(void *); * @lock_arg: this field is passed as the only argument of lock/unlock *

Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep

2015-06-25 Thread Lars-Peter Clausen
On 06/25/2015 05:33 PM, Mark Brown wrote: On Thu, Jun 25, 2015 at 05:03:00PM +0200, Lars-Peter Clausen wrote: On 06/25/2015 03:21 PM, Arjan van de Ven wrote: wouldn't it be better to use the mutex_lock_nested() and co to explicitly express your hierarchy? That would require

Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep

2015-06-25 Thread Lars-Peter Clausen
On 06/25/2015 03:21 PM, Arjan van de Ven wrote: On 6/25/2015 2:35 AM, Nicolas Boichat wrote: From: Antti Palosaari Lockdep validator complains about recursive locking and deadlock when two different regmap instances are called in a nested order. That happens anytime a regmap read/write call

Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep

2015-06-25 Thread Lars-Peter Clausen
On 06/25/2015 03:21 PM, Arjan van de Ven wrote: On 6/25/2015 2:35 AM, Nicolas Boichat wrote: From: Antti Palosaari cr...@iki.fi Lockdep validator complains about recursive locking and deadlock when two different regmap instances are called in a nested order. That happens anytime a regmap

Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep

2015-06-25 Thread Lars-Peter Clausen
On 06/25/2015 05:33 PM, Mark Brown wrote: On Thu, Jun 25, 2015 at 05:03:00PM +0200, Lars-Peter Clausen wrote: On 06/25/2015 03:21 PM, Arjan van de Ven wrote: wouldn't it be better to use the mutex_lock_nested() and co to explicitly express your hierarchy? That would require

Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep

2015-06-25 Thread Lars-Peter Clausen
[...] diff --git a/include/linux/regmap.h b/include/linux/regmap.h index 116655d..09aaaf5 100644 --- a/include/linux/regmap.h +++ b/include/linux/regmap.h @@ -135,6 +135,12 @@ typedef void (*regmap_unlock)(void *); * @lock_arg: this field is passed as the only argument of lock/unlock *

Re: [PATCH] iio: Fix parameters in iio_triggered_buffer_setup

2015-06-22 Thread Lars-Peter Clausen
On 06/21/2015 03:57 PM, Daniel Baluta wrote: On Sun, Jun 14, 2015 at 1:20 PM, Jonathan Cameron wrote: On 11/06/15 13:06, Cristina Opriceana wrote: This patch renames the top half handler and the bottom half handler of iio_triggered_buffer_setup() in accordance with their usage. The names of

Re: [PATCH] iio: Fix parameters in iio_triggered_buffer_setup

2015-06-22 Thread Lars-Peter Clausen
On 06/21/2015 03:57 PM, Daniel Baluta wrote: On Sun, Jun 14, 2015 at 1:20 PM, Jonathan Cameron ji...@kernel.org wrote: On 11/06/15 13:06, Cristina Opriceana wrote: This patch renames the top half handler and the bottom half handler of iio_triggered_buffer_setup() in accordance with their

Re: [PATCH v2] media: i2c: ADV7604: Migrate to regmap

2015-06-19 Thread Lars-Peter Clausen
On 06/16/2015 10:38 AM, Pablo Anton wrote: This is a preliminary patch in order to add support for ALSA. It replaces all current i2c access with regmap. Looks pretty good. #define ADV76XX_REG(page, offset) (((page) << 8) | (offset)) @@ -633,13 +618,15 @@ static int

Re: [PATCH v2] media: i2c: ADV7604: Migrate to regmap

2015-06-19 Thread Lars-Peter Clausen
On 06/16/2015 10:38 AM, Pablo Anton wrote: This is a preliminary patch in order to add support for ALSA. It replaces all current i2c access with regmap. Looks pretty good. #define ADV76XX_REG(page, offset) (((page) 8) | (offset)) @@ -633,13 +618,15 @@ static int

Re: [PATCH 1/3] iio: adc: hi-843x: Holt HI-8435/8436/8437 descrete ADC

2015-06-18 Thread Lars-Peter Clausen
On 06/07/2015 06:11 PM, Jonathan Cameron wrote: On 01/06/15 13:20, Vladimir Barinov wrote: Add Holt descrete ADC driver for HI-8435/8436/8437 chips Signed-off-by: Vladimir Barinov Hmm. The main issue here is one man's discrete ADC is another man's configurable general purpose input device.

Re: [PATCH 1/3] iio: adc: hi-843x: Holt HI-8435/8436/8437 descrete ADC

2015-06-18 Thread Lars-Peter Clausen
On 06/07/2015 06:11 PM, Jonathan Cameron wrote: On 01/06/15 13:20, Vladimir Barinov wrote: Add Holt descrete ADC driver for HI-8435/8436/8437 chips Signed-off-by: Vladimir Barinov vladimir.bari...@cogentembedded.com Hmm. The main issue here is one man's discrete ADC is another man's

Re: [PATCH v2] iio: allow userspace to flush the hwfifo with non-blocking reads

2015-06-15 Thread Lars-Peter Clausen
getting his hands a lot dirtier in this area than I have recently! Looks good. Reviewed-by: Lars-Peter Clausen This seems a logical bit of API to me even without the desire to use it to force a flush. If we want whatever data is available now, we want that data now, not when the fifo gets

Re: [alsa-devel][PATCH] ASoC: wm8960: add two kcontrols to select ADC left/right channel source

2015-06-15 Thread Lars-Peter Clausen
On 06/15/2015 12:34 PM, Zidan Wang wrote: Add two kcontrols to select ADC left/right channel source, one to select the left channel source and one for the right channel source. Signed-off-by: Zidan Wang --- sound/soc/codecs/wm8960.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

Re: [alsa-devel][PATCH] ASoC: wm8960: add two kcontrols to select ADC left/right channel source

2015-06-15 Thread Lars-Peter Clausen
On 06/15/2015 12:34 PM, Zidan Wang wrote: Add two kcontrols to select ADC left/right channel source, one to select the left channel source and one for the right channel source. Signed-off-by: Zidan Wang zidan.w...@freescale.com --- sound/soc/codecs/wm8960.c | 7 +++ 1 file changed, 7

Re: [PATCH v2] iio: allow userspace to flush the hwfifo with non-blocking reads

2015-06-15 Thread Lars-Peter Clausen
to take a look as he's been getting his hands a lot dirtier in this area than I have recently! Looks good. Reviewed-by: Lars-Peter Clausen l...@metafoo.de This seems a logical bit of API to me even without the desire to use it to force a flush. If we want whatever data is available now, we

Re: [PATCH 1/1] iio:adc: XADC: Set offset explicitly to zero on voltage channels

2015-06-14 Thread Lars-Peter Clausen
On 06/14/2015 05:15 AM, Gergely Imreh wrote: On 14 June 2015 at 02:30, Jonathan Cameron wrote: On 11/06/15 09:22, Gergely Imreh wrote: The Xilinx XADC driver has both a temperature channel and 8 voltage channels. The voltage channels have no offset, but actually were still set the same offset

Re: [PATCH 1/1] iio:adc: XADC: Set offset explicitly to zero on voltage channels

2015-06-14 Thread Lars-Peter Clausen
On 06/14/2015 05:15 AM, Gergely Imreh wrote: On 14 June 2015 at 02:30, Jonathan Cameron ji...@kernel.org wrote: On 11/06/15 09:22, Gergely Imreh wrote: The Xilinx XADC driver has both a temperature channel and 8 voltage channels. The voltage channels have no offset, but actually were still set

Re: [PATCH 0/2] change "client->irq >= 0" to "client->irq > 0"

2015-06-03 Thread Lars-Peter Clausen
On 06/03/2015 01:02 PM, Alexandre Belloni wrote: On 03/06/2015 at 00:34:11 +0300, Octavian Purdila wrote : This fixes an issue introduces by commit dab472eb931b ("i2c / ACPI: Use 0 to indicate that device does not have interrupt assigned") where drivers will try to request IRQ 0 when no GpioInt

Re: [PATCH 0/2] change client-irq = 0 to client-irq 0

2015-06-03 Thread Lars-Peter Clausen
On 06/03/2015 01:02 PM, Alexandre Belloni wrote: On 03/06/2015 at 00:34:11 +0300, Octavian Purdila wrote : This fixes an issue introduces by commit dab472eb931b (i2c / ACPI: Use 0 to indicate that device does not have interrupt assigned) where drivers will try to request IRQ 0 when no GpioInt

Re: [PATCH 1/1] iio: Add iio_mod_light_uva, iio_mod_light_uvb, and iio_mod_light_uvc.

2015-05-29 Thread Lars-Peter Clausen
On 05/29/2015 10:04 AM, Kevin Tsai wrote: Add Ultraviolet(UV) support: UVA: 315 ~ 400 nm UVB: 280 ~ 315 nm UVC: 100 ~ 280 nm We need documentation for these new modifiers in Documentation/ABI/testing/sys-bus-iio. Otherwise looks ok. - Lars -- To unsubscribe from this list: send the line

Re: [PATCH 1/1] iio: Add iio_mod_light_uva, iio_mod_light_uvb, and iio_mod_light_uvc.

2015-05-29 Thread Lars-Peter Clausen
On 05/29/2015 10:04 AM, Kevin Tsai wrote: Add Ultraviolet(UV) support: UVA: 315 ~ 400 nm UVB: 280 ~ 315 nm UVC: 100 ~ 280 nm We need documentation for these new modifiers in Documentation/ABI/testing/sys-bus-iio. Otherwise looks ok. - Lars -- To unsubscribe from this list: send the line

Re: [RFC PATCH 0/2] Introduce PM runtime helper functions

2015-05-18 Thread Lars-Peter Clausen
On 05/18/2015 06:25 PM, Daniel Baluta wrote: Working on a new driver I noticed that there is a fair amount of duplicate code for adding PM runtime support. First patch refactors the PM runtime support in a new header introducing functions for setup/cleanup and set power state. Makes sense,

Re: [PATCH] iio: adc128s052: add support for adc122s021

2015-05-18 Thread Lars-Peter Clausen
--- a/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt +++ b/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt @@ -1,7 +1,7 @@ -* Texas Instruments' ADC128S052 ADC chip +* Texas Instruments' ADC128S052 and ADC122S021 ADC chip Required properties: - - compatible: Should be

Re: [PATCH] iio: adc128s052: add support for adc122s021

2015-05-18 Thread Lars-Peter Clausen
--- a/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt +++ b/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt @@ -1,7 +1,7 @@ -* Texas Instruments' ADC128S052 ADC chip +* Texas Instruments' ADC128S052 and ADC122S021 ADC chip Required properties: - - compatible: Should be

Re: [RFC PATCH 0/2] Introduce PM runtime helper functions

2015-05-18 Thread Lars-Peter Clausen
On 05/18/2015 06:25 PM, Daniel Baluta wrote: Working on a new driver I noticed that there is a fair amount of duplicate code for adding PM runtime support. First patch refactors the PM runtime support in a new header linux/iio/pm_runtime introducing functions for setup/cleanup and set power

Re: [alsa-devel] [PATCH 1/4] ASoC: rockchip: add rockchip machine driver

2015-05-15 Thread Lars-Peter Clausen
On 05/14/2015 01:11 AM, Dylan Reid wrote: On Wed, May 13, 2015 at 10:21 AM, Dylan Reid wrote: On Wed, May 13, 2015 at 9:42 AM, Mark Brown wrote: On Wed, May 13, 2015 at 09:23:01PM +0800, zhengxing wrote: On 2015年05月13日 03:22, Mark Brown wrote: Is it not possible to extend simple card to

Re: [alsa-devel] [PATCH 1/4] ASoC: rockchip: add rockchip machine driver

2015-05-15 Thread Lars-Peter Clausen
On 05/14/2015 01:11 AM, Dylan Reid wrote: On Wed, May 13, 2015 at 10:21 AM, Dylan Reid dgr...@chromium.org wrote: On Wed, May 13, 2015 at 9:42 AM, Mark Brown broo...@kernel.org wrote: On Wed, May 13, 2015 at 09:23:01PM +0800, zhengxing wrote: On 2015年05月13日 03:22, Mark Brown wrote: Is it

Re: [PATCH] ASoC: codecs-ac97: make selectable in config

2015-05-14 Thread Lars-Peter Clausen
On 05/14/2015 09:28 PM, Mark Brown wrote: On Thu, May 14, 2015 at 09:24:15PM +0200, Lars-Peter Clausen wrote: On 05/14/2015 09:10 PM, Mark Brown wrote: Does the select from SND_SOC_AC97_BUS actually happen if it is selected by SND_SOC_ALL_CODECS? That's the issue, if it works now it's

Re: [PATCH] ASoC: codecs-ac97: make selectable in config

2015-05-14 Thread Lars-Peter Clausen
On 05/14/2015 09:10 PM, Mark Brown wrote: On Thu, May 14, 2015 at 08:46:09PM +0200, Lars-Peter Clausen wrote: On 05/14/2015 07:53 PM, Mark Brown wrote: select doesn't respect dependencies, it'll just force on the selected symbol. The patch works fine, neither SND_SOC_AC97_BUS nor

Re: [PATCH] ASoC: codecs-ac97: make selectable in config

2015-05-14 Thread Lars-Peter Clausen
On 05/14/2015 07:53 PM, Mark Brown wrote: On Wed, May 13, 2015 at 10:57:24PM +0200, Maciej S. Szmigiero wrote: W dniu 12.05.2015 19:58, Mark Brown pisze: On Sun, May 10, 2015 at 12:12:04AM +0200, Maciej S. Szmigiero wrote: @@ -16,7 +16,7 @@ config SND_SOC_ALL_CODECS select

Re: [PATCH] ASoC: codecs-ac97: make selectable in config

2015-05-14 Thread Lars-Peter Clausen
On 05/14/2015 07:53 PM, Mark Brown wrote: On Wed, May 13, 2015 at 10:57:24PM +0200, Maciej S. Szmigiero wrote: W dniu 12.05.2015 19:58, Mark Brown pisze: On Sun, May 10, 2015 at 12:12:04AM +0200, Maciej S. Szmigiero wrote: @@ -16,7 +16,7 @@ config SND_SOC_ALL_CODECS select

Re: [PATCH] ASoC: codecs-ac97: make selectable in config

2015-05-14 Thread Lars-Peter Clausen
On 05/14/2015 09:10 PM, Mark Brown wrote: On Thu, May 14, 2015 at 08:46:09PM +0200, Lars-Peter Clausen wrote: On 05/14/2015 07:53 PM, Mark Brown wrote: select doesn't respect dependencies, it'll just force on the selected symbol. The patch works fine, neither SND_SOC_AC97_BUS nor

Re: [PATCH] ASoC: codecs-ac97: make selectable in config

2015-05-14 Thread Lars-Peter Clausen
On 05/14/2015 09:28 PM, Mark Brown wrote: On Thu, May 14, 2015 at 09:24:15PM +0200, Lars-Peter Clausen wrote: On 05/14/2015 09:10 PM, Mark Brown wrote: Does the select from SND_SOC_AC97_BUS actually happen if it is selected by SND_SOC_ALL_CODECS? That's the issue, if it works now it's

Re: [PATCH RFC 1/3] iio: Add symlink to triggers in the device's trigger folder

2015-05-13 Thread Lars-Peter Clausen
On 05/13/2015 08:05 PM, Lars-Peter Clausen wrote: On 05/13/2015 08:03 PM, Robert Dolca wrote: On Wed, May 13, 2015 at 8:42 PM, Jonathan Cameron wrote: On 13/05/15 08:28, Lars-Peter Clausen wrote: On 05/12/2015 09:06 PM, Jonathan Cameron wrote: On 12/05/15 17:56, Lars-Peter Clausen wrote

Re: [PATCH RFC 1/3] iio: Add symlink to triggers in the device's trigger folder

2015-05-13 Thread Lars-Peter Clausen
On 05/13/2015 08:03 PM, Robert Dolca wrote: On Wed, May 13, 2015 at 8:42 PM, Jonathan Cameron wrote: On 13/05/15 08:28, Lars-Peter Clausen wrote: On 05/12/2015 09:06 PM, Jonathan Cameron wrote: On 12/05/15 17:56, Lars-Peter Clausen wrote: On 05/08/2015 05:11 PM, Jonathan Cameron wrote

Re: [PATCH v6 0/4] Add initial configfs support for IIO

2015-05-13 Thread Lars-Peter Clausen
Hi, I'd like to go back to the issue of having one folder per trigger type and create triggers for a type in their respective folder. I'm not convinced that it is an intentional design restriction of configfs that we can't do this, but rather a case of it not being implemented because nobody

Re: [PATCH RFC 1/3] iio: Add symlink to triggers in the device's trigger folder

2015-05-13 Thread Lars-Peter Clausen
On 05/12/2015 09:06 PM, Jonathan Cameron wrote: On 12/05/15 17:56, Lars-Peter Clausen wrote: On 05/08/2015 05:11 PM, Jonathan Cameron wrote: On 16/04/15 05:01, Robert Dolca wrote: This patch adds a new function called iio_trigger_register_with_dev which is a wrapper for iio_trigger_register

Re: [PATCH v6 0/4] Add initial configfs support for IIO

2015-05-13 Thread Lars-Peter Clausen
Hi, I'd like to go back to the issue of having one folder per trigger type and create triggers for a type in their respective folder. I'm not convinced that it is an intentional design restriction of configfs that we can't do this, but rather a case of it not being implemented because nobody

Re: [PATCH RFC 1/3] iio: Add symlink to triggers in the device's trigger folder

2015-05-13 Thread Lars-Peter Clausen
On 05/13/2015 08:03 PM, Robert Dolca wrote: On Wed, May 13, 2015 at 8:42 PM, Jonathan Cameron ji...@kernel.org wrote: On 13/05/15 08:28, Lars-Peter Clausen wrote: On 05/12/2015 09:06 PM, Jonathan Cameron wrote: On 12/05/15 17:56, Lars-Peter Clausen wrote: On 05/08/2015 05:11 PM, Jonathan

Re: [PATCH RFC 1/3] iio: Add symlink to triggers in the device's trigger folder

2015-05-13 Thread Lars-Peter Clausen
On 05/13/2015 08:05 PM, Lars-Peter Clausen wrote: On 05/13/2015 08:03 PM, Robert Dolca wrote: On Wed, May 13, 2015 at 8:42 PM, Jonathan Cameron ji...@kernel.org wrote: On 13/05/15 08:28, Lars-Peter Clausen wrote: On 05/12/2015 09:06 PM, Jonathan Cameron wrote: On 12/05/15 17:56, Lars-Peter

Re: [PATCH RFC 1/3] iio: Add symlink to triggers in the device's trigger folder

2015-05-13 Thread Lars-Peter Clausen
On 05/12/2015 09:06 PM, Jonathan Cameron wrote: On 12/05/15 17:56, Lars-Peter Clausen wrote: On 05/08/2015 05:11 PM, Jonathan Cameron wrote: On 16/04/15 05:01, Robert Dolca wrote: This patch adds a new function called iio_trigger_register_with_dev which is a wrapper for iio_trigger_register

Re: [alsa-devel] [RFC PATCH 00/14] ASoC: qcom: add support to apq8016 audio

2015-05-12 Thread Lars-Peter Clausen
On 05/12/2015 12:21 PM, Srinivas Kandagatla wrote: + adding Lars On 12/05/15 05:06, Kenneth Westfield wrote: Srinivas, I was able to get audio working on the Storm board. There were several issues. First, the I2S control port was saved in the DAI driver id field (which was 4), but the DAI

<    4   5   6   7   8   9   10   11   12   13   >