Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-10-31 Thread Laura Abbott
On 10/31/2017 12:11 PM, Mark Brown wrote: > On Tue, Oct 31, 2017 at 12:03:35PM -0700, Laura Abbott wrote: > >> I'm not a fan of the platform bus but I have mixed feelings about >> creating a dedicated bus type. I guess if we really need a bus >> type we can

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-10-31 Thread Laura Abbott
On 10/23/2017 08:55 AM, Benjamin Gaignard wrote: > Instead a getting only one common device "/dev/ion" for > all the heaps this patch allow to create one device > entry ("/dev/ionX") per heap. > Getting an entry per heap could allow to set security rules > per heap and global ones for all heaps. >

Re: [PATCHv4 1/1] [tools/selftests]: android/ion: userspace test utility for ion buffer sharing

2017-10-30 Thread Laura Abbott
On 10/23/2017 04:26 PM, Pintu Agarwal wrote: This is a test utility to verify ION buffer sharing in user space between 2 independent processes. It uses unix domain socket (with SCM_RIGHTS) as IPC to transfer an FD to another process to share the same buffer. This utility demonstrates how ION buff

Re: [lkp-robot] [android/ion] 5fb70554d6: kernel_selftests.android.make_fail

2017-10-30 Thread Laura Abbott
On 10/30/2017 12:12 AM, Pintu Kumar wrote: > On Sun, Oct 29, 2017 at 7:51 PM, kernel test robot > wrote: >> >> FYI, we noticed the following commit (built with gcc-6): >> >> commit: 5fb70554d68e2ea032b6a28b082801d8b7b76cb8 ("android/ion: userspace >> test utility for ion buffer sharing") >> url:

[PATCH] Documentation: Add myself to the enforcement statement list

2017-10-18 Thread Laura Abbott
I already Acked the patch, add my name to the list as well. Signed-off-by: Laura Abbott --- Documentation/process/kernel-enforcement-statement.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/process/kernel-enforcement-statement.rst b/Documentation/process/kernel

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

2017-10-18 Thread Laura Abbott
On 09/27/2017 06:20 AM, Benjamin Gaignard wrote: > diff --git a/drivers/staging/android/ion/ion.c > b/drivers/staging/android/ion/ion.c > index 93e2c90..092b24c 100644 > --- a/drivers/staging/android/ion/ion.c > +++ b/drivers/staging/android/ion/ion.c > @@ -40,6 +40,8 @@ > > #include "ion.h" >

Re: [PATCHv3 1/1] [tools/selftests]: android/ion: userspace test utility for ion buffer sharing

2017-10-17 Thread Laura Abbott
On 10/14/2017 04:36 AM, Pintu Agarwal wrote: > This is a test utility to verify ION buffer sharing in user space > between 2 independent processes. > It uses unix domain socket (with SCM_RIGHTS) as IPC to transfer an FD to > another process to share the same buffer. > This utility demonstrates how

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

2017-10-16 Thread Laura Abbott
On 10/10/2017 02:11 AM, Mark Brown wrote: > On Mon, Oct 09, 2017 at 05:10:37PM -0700, Laura Abbott wrote: >> On 10/09/2017 03:08 PM, Mark Brown wrote: >>> On Mon, Oct 09, 2017 at 02:25:47PM -0700, Laura Abbott wrote: > >>>> Anyway, to move this forward I think

Re: [RFC PATCH 3/3] mm/map_contig: Add mmap(MAP_CONTIG) support

2017-10-16 Thread Laura Abbott
On 10/16/2017 01:32 PM, Mike Kravetz wrote: > On 10/16/2017 11:07 AM, Michal Hocko wrote: >> On Mon 16-10-17 10:43:38, Mike Kravetz wrote: >>> Just to be clear, the posix standard talks about a typed memory object. >>> The suggested implementation has one create a connection to the memory >>> objec

Re: [PATCH 00/11] KASan for arm

2017-10-11 Thread Laura Abbott
On 10/11/2017 02:36 PM, Florian Fainelli wrote: > On 10/11/2017 12:50 PM, Florian Fainelli wrote: >> On 10/11/2017 12:13 PM, Florian Fainelli wrote: >>> Hi Abbott, >>> >>> On 10/11/2017 01:22 AM, Abbott Liu wrote: Hi,all: These patches add arch specific code for kernel address sanitize

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

2017-10-09 Thread Laura Abbott
On 10/09/2017 03:08 PM, Mark Brown wrote: > On Mon, Oct 09, 2017 at 02:25:47PM -0700, Laura Abbott wrote: > >> Anyway, to move this forward I think we need to see a proof of concept >> of using selinux to protect access to specific heaps. > > Aren't Unix permissions

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

2017-10-09 Thread Laura Abbott
On 10/05/2017 06:06 AM, Benjamin Gaignard wrote: > 2017-10-04 12:17 GMT+02:00 Mark Brown : >> On Tue, Oct 03, 2017 at 04:08:30PM -0700, Sandeep Patil wrote: >> >>> It is entirely possible and easy in android/ueventd to create those nodes >>> under "/dev/ion/". (assuming the heap 'subsystem' for th

Re: [PATCHv2 1/1] [tools]: android/ion: userspace test utility for ion buffer sharing

2017-10-09 Thread Laura Abbott
On 10/09/2017 07:17 AM, Pintu Kumar wrote: > On Fri, Oct 6, 2017 at 7:58 PM, Pintu Kumar wrote: + + heap_type = ion_info->heap_type; + heap_size = ion_info->heap_size; + flag_type = ion_info->flag_type; + alloc_data.len = heap_size; + alloc_data.he

Re: [PATCH v5 1/2] staging: ion: simplify ioctl args checking function

2017-10-09 Thread Laura Abbott
eful. > May I ask you your point of view on those few lines ? > > Benjamin > Yes, this looks better. Acked-by: Laura Abbott >> Signed-off-by: Benjamin Gaignard >> --- >> drivers/staging/android/ion/ion-ioctl.c | 11 +-- >> 1 file changed, 5 insertion

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

2017-10-09 Thread Laura Abbott
On 10/06/2017 08:10 PM, Levin, Alexander (Sasha Levin) wrote: > On Fri, Oct 06, 2017 at 07:13:22PM +0100, Mark Rutland wrote: >> Hi Greg, >> >> On Fri, Oct 06, 2017 at 10:52:04AM +0200, Greg Kroah-Hartman wrote: >>> 4.9-stable review patch. If anyone has any objections, please let me know. >> >> I

Re: [PATCHv2 1/1] [tools]: android/ion: userspace test utility for ion buffer sharing

2017-10-04 Thread Laura Abbott
On 10/04/2017 04:29 AM, Pintu Kumar wrote: > The whole thing about this test is to share an FD over 2 independent > processes. > I think sharing an FD using fork() [parent/child] is not a real use > case scenarios. > Some people may not like the fork example. > Initially when I started with ION, I

Re: [RFC] mmap(MAP_CONTIG)

2017-10-04 Thread Laura Abbott
On 10/04/2017 10:08 AM, Mike Kravetz wrote: > On 10/04/2017 04:54 AM, Michal Nazarewicz wrote: >> On Tue, Oct 03 2017, Mike Kravetz wrote: >>> At Plumbers this year, Guy Shattah and Christoph Lameter gave a presentation >>> titled 'User space contiguous memory allocation for DMA' [1]. The slides >

Re: [PATCHv2 1/1] [tools]: android/ion: userspace test utility for ion buffer sharing

2017-10-03 Thread Laura Abbott
On 10/03/2017 09:48 AM, Pintu Agarwal wrote: > This is a test utility to verify ION buffer sharing in user space > between 2 independent processes. > It uses unix domain socket as IPC to transfer an FD to another process > and install it. > > This utility demonstrates how ION buffer sharing can be

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

2017-10-03 Thread Laura Abbott
On 10/03/2017 04:08 PM, Sandeep Patil wrote: > On Tue, Oct 03, 2017 at 02:42:32PM -0700, Laura Abbott wrote: >> On 10/03/2017 09:48 AM, Mark Brown wrote: >>> On Mon, Oct 02, 2017 at 11:07:48AM -0700, Laura Abbott wrote: >>> >>>> Thinking about this a bit mo

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

2017-10-03 Thread Laura Abbott
On 10/03/2017 09:48 AM, Mark Brown wrote: > On Mon, Oct 02, 2017 at 11:07:48AM -0700, Laura Abbott wrote: > >> Thinking about this a bit more, I'm not 100% sure if this >> will allow the security rules we want. Heap ids are assigned >> dynamically and therefore so w

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

2017-10-02 Thread Laura Abbott
On 09/27/2017 06:20 AM, Benjamin Gaignard wrote: > Instead a getting only one common device "/dev/ion" for > all the heaps this patch allow to create one device > entry ("/dev/ionX") per heap. > Getting an entry per heap could allow to set security rules > per heap and global ones for all heaps. >

Re: [PATCH 1/1] [tools]: android/ion: userspace test utility for ion buffer sharing

2017-09-26 Thread Laura Abbott
On 09/26/2017 11:08 AM, Pintu Agarwal wrote: This is a test utility to verify ION buffer sharing in user space between 2 independent processes. It uses unix domain socket as IPC to transfer an FD to another process and install it. This utility demonstrates how ION buffer sharing can be implement

Re: [PATCH v4 2/2] staging: ion: create one device entry per heap

2017-09-26 Thread Laura Abbott
On 09/26/2017 09:17 AM, Mark Brown wrote: On Tue, Sep 26, 2017 at 02:07:05PM +0200, Benjamin Gaignard wrote: version 4: - add a configuration flag to switch between legacy Ion misc device and one device per heap version. Should this be a switch or should it just be enabling and disabling t

Re: [PATCH v3 2/2] staging: ion: create one device entry per heap

2017-09-26 Thread Laura Abbott
On 09/25/2017 11:56 PM, Greg KH wrote: On Tue, Sep 26, 2017 at 07:09:14AM +0200, Daniel Vetter wrote: On Mon, Sep 25, 2017 at 11:26:27AM -0700, Laura Abbott wrote: On 09/20/2017 01:45 AM, Benjamin Gaignard wrote: Instead a getting one common device "/dev/ion" for all the heaps

Re: [PATCH v3 2/2] staging: ion: create one device entry per heap

2017-09-25 Thread Laura Abbott
On 09/20/2017 01:45 AM, Benjamin Gaignard wrote: Instead a getting one common device "/dev/ion" for all the heaps this patch allow to create one device entry ("/dev/ionX") per heap. Getting an entry per heap could allow to set security rules per heap and global ones for all heaps. Allocation req

Re: [PATCH v2 2/2] staging: ion: create one device entry per heap

2017-09-19 Thread Laura Abbott
On 09/19/2017 04:55 AM, Benjamin Gaignard wrote: 2017-09-19 13:02 GMT+02:00 Greg KH : On Tue, Sep 19, 2017 at 12:25:38PM +0200, Benjamin Gaignard wrote: Instead a getting one common device "/dev/ion" for all the heaps this patch allow to create one device entry ("/dev/ionX") per heap. Getting a

Re: Regression in virtio block driver with 4.13.2

2017-09-19 Thread Laura Abbott
On 09/17/2017 04:57 PM, Christoph Hellwig wrote: On Sat, Sep 16, 2017 at 04:16:06PM -0700, Laura Abbott wrote: Yes, the issue goes away when CONFIG_VIRTIO_BLK_SCSI is disabled. Ok, so it's probably related to follow ups to the scsi_request split. That being said, I would highly reco

Re: Regression in virtio block driver with 4.13.2

2017-09-16 Thread Laura Abbott
On 09/15/2017 10:37 AM, Christoph Hellwig wrote: On Fri, Sep 15, 2017 at 09:54:08AM -0700, Laura Abbott wrote: Hi, Fedora got a bug report on an early version of 4.13.2 https://paste.fedoraproject.org/paste/t-Yx23LN5QwJ7oPZLj3zrg Can you check if the issue goes away when you disable

Regression in virtio block driver with 4.13.2

2017-09-15 Thread Laura Abbott
Hi, Fedora got a bug report on an early version of 4.13.2 https://paste.fedoraproject.org/paste/t-Yx23LN5QwJ7oPZLj3zrg [5.913866] usercopy: kernel memory overwrite attempt detected to (null) () (16 bytes) [5.914199] [ cut here ] [5.914201] kernel BUG a

Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes bind port regression

2017-09-13 Thread Laura Abbott
On 09/12/2017 04:12 PM, Josef Bacik wrote: First I’m super sorry for the top post, I’m at plumbers and I forgot to upload my muttrc to my new cloud instance, so I’m screwed using outlook. I have a completely untested, uncompiled patch that I think will fix the problem, would you mind giving it

319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes bind port regression

2017-09-12 Thread Laura Abbott
Hi, Fedora got a bug report https://bugzilla.redhat.com/show_bug.cgi?id=1432684 of a regression with automatic spice port assignment. The libvirt team reduced this to the attached test case run as follows: In a separate terminal, qemu-kvm -vnc 127.0.0.1:0 to grab port 5900. Then do this: $

Re: nios2 crash due to 'init/main.c: extract early boot entropy from the passed cmdline'

2017-09-11 Thread Laura Abbott
On 09/11/2017 11:41 AM, Kees Cook wrote: On Mon, Sep 11, 2017 at 11:25 AM, Daniel Micay wrote: On Mon, 2017-09-11 at 10:35 -0700, Guenter Roeck wrote: On Mon, Sep 11, 2017 at 09:36:00AM -0700, Kees Cook wrote: On Sat, Sep 9, 2017 at 8:58 PM, Guenter Roeck wrote: Hi, I noticed that nios2 im

Re: [PATCH v6 09/11] arm64/mm: disable section/contiguous mappings if XPFO is enabled

2017-09-09 Thread Laura Abbott
On 09/07/2017 10:36 AM, Tycho Andersen wrote: > XPFO doesn't support section/contiguous mappings yet, so let's disable it > if XPFO is turned on. > > Thanks to Laura Abbot for the simplification from v5, and Mark Rutland for > pointing out we need NO_CONT_MAPPINGS too. > > CC: linux-arm-ker...@li

Re: [PATCH v6 03/11] mm, x86: Add support for eXclusive Page Frame Ownership (XPFO)

2017-09-09 Thread Laura Abbott
On 09/07/2017 10:36 AM, Tycho Andersen wrote: > +static inline struct xpfo *lookup_xpfo(struct page *page) > +{ > + struct page_ext *page_ext = lookup_page_ext(page); > + > + if (unlikely(!page_ext)) { > + WARN(1, "xpfo: failed to get page ext"); > + return NULL; > +

Re: [PATCH/RFC] ion: add movability support for page pools

2017-09-05 Thread Laura Abbott
On 09/05/2017 05:55 AM, Vitaly Wool wrote: > ion page pool may become quite large and scattered all around > the kernel memory area. These pages are actually not used so > moving them around to reduce fragmentation is quite cheap because > there's no need to copy their contents. > Can you give a

Re: [PATCH 1/3] mm/cma: manage the memory of the CMA area by using the ZONE_MOVABLE

2017-08-31 Thread Laura Abbott
On 08/31/2017 07:32 AM, Vlastimil Babka wrote: On 08/31/2017 03:40 AM, Joonsoo Kim wrote: On Tue, Aug 29, 2017 at 11:16:18AM +0200, Vlastimil Babka wrote: On 08/24/2017 08:36 AM, js1...@gmail.com wrote: From: Joonsoo Kim 0. History This patchset is the follow-up of the discussion about the

Re: [PATCH] Staging: Android: fix code style in ion_cma_heap.c

2017-08-24 Thread Laura Abbott
On 08/24/2017 08:40 AM, Abishek V Ashok wrote: > This is a patch to the ion_cma_heap.c file in > /drivers/staging/andrioid/ion that fixes a blank line and > kmalloc size warning found by the checkpatch.pl tool. > You've done two things in this patch, please stick to a single change per patch. >

Re: [kernel-hardening] [RFC] memory allocations in genalloc

2017-08-18 Thread Laura Abbott
On 08/17/2017 09:26 AM, Igor Stoppa wrote: > Foreword: > If I should direct this message to someone else, please let me know. > I couldn't get a clear idea, by looking at both MAINTAINERS and git blame. > > > > Hi, > > I'm currently trying to convert the SE Linux policy db into using a > pr

Re: New assembler warnings with binutils 2.29

2017-08-17 Thread Laura Abbott
On 08/14/2017 07:45 AM, Ramana Radhakrishnan wrote: > On Mon, Aug 14, 2017 at 11:34:45AM +0100, Catalin Marinas wrote: >>> >>> Any attempts to realias these to the correct meaning as per the AAPCS >>> continues to work from my limited testing of a prototype patch so far. >> >> This would be great.

[PATCHv3 0/2] Command line randomness

2017-08-16 Thread Laura Abbott
the passed cmdline Laura Abbott (1): init: Move stack canary initialization after setup_arch init/main.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) -- 2.13.0

[PATCHv3 1/2] init: Move stack canary initialization after setup_arch

2017-08-16 Thread Laura Abbott
From: Laura Abbott Stack canary intialization involves getting a random number. Getting this random number may involve accessing caches or other architectural specific features which are not available until after the architecture is setup. Move the stack canary initialization later to

[PATCHv3 2/2] extract early boot entropy from the passed cmdline

2017-08-16 Thread Laura Abbott
LL:85,1BLE:669,2BLL:0,2BLE:1777,SW:6,KL:8136). Signed-off-by: Daniel Micay [labbott: Line-wrapped command line] Signed-off-by: Laura Abbott --- v3: add_device_randomness comes before canary initialization, clarified comment. --- init/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ini

Re: [PATCHv2 2/2] extract early boot entropy from the passed cmdline

2017-08-16 Thread Laura Abbott
On 08/16/2017 03:48 PM, Kees Cook wrote: > On Wed, Aug 16, 2017 at 3:46 PM, Laura Abbott wrote: >> From: Daniel Micay >> >> Existing Android bootloaders usually pass data useful as early entropy >> on the kernel command-line. It may also be the case on other embedded

[PATCHv2 2/2] extract early boot entropy from the passed cmdline

2017-08-16 Thread Laura Abbott
LL:85,1BLE:669,2BLL:0,2BLE:1777,SW:6,KL:8136). Signed-off-by: Daniel Micay [labbott: Line-wrapped command line] Signed-off-by: Laura Abbott --- init/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/init/main.c b/init/main.c index 21d599eaad06..cb051aec46ef 100644 --- a/init/main.c +++ b/i

[PATCHv2 1/2] init: Move stack canary initialization after setup_arch

2017-08-16 Thread Laura Abbott
From: Laura Abbott Stack canary intialization involves getting a random number. Getting this random number may involve accessing caches or other architectural specific features which are not available until after the architecture is setup. Move the stack canary initialization later to accomodate

[PATCHv2 0/2] Command line randomness

2017-08-16 Thread Laura Abbott
. Thanks, Laura Daniel Micay (1): extract early boot entropy from the passed cmdline Laura Abbott (1): init: Move stack canary initialization after setup_arch init/main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.13.0

[PATCH] mm/vmalloc: Don't unconditonally use __GFP_HIGHMEM

2017-08-16 Thread Laura Abbott
MA32. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1482249 Fixes: 19809c2da28a ("mm, vmalloc: use __GFP_HIGHMEM implicitly") Signed-off-by: Laura Abbott --- mm/vmalloc.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/mm/vmalloc.c b/mm/vma

[PATCH] init: Move stack canary initialization after setup_arch

2017-08-16 Thread Laura Abbott
From: Laura Abbott Stack canary intialization involves getting a random number. Getting this random number may involve accessing caches or other architectural specific features which are not available until after the architecture is setup. Move the stack canary initialization later to accomodate

Re: [PATCHv2 00/14] arm64: VMAP_STACK support

2017-08-15 Thread Laura Abbott
de/asm/thread_info.h | 10 +-- > arch/arm64/kernel/entry.S | 121 > -- > arch/arm64/kernel/irq.c | 40 +- > arch/arm64/kernel/ptrace.c| 1 + > arch/arm64/kernel/smp.c | 2 +- >

Re: [PATCH v5 02/10] mm, x86: Add support for eXclusive Page Frame Ownership (XPFO)

2017-08-14 Thread Laura Abbott
On 08/09/2017 01:07 PM, Tycho Andersen wrote: +/* Update a single kernel page table entry */ +inline void set_kpte(void *kaddr, struct page *page, pgprot_t prot) +{ + unsigned int level; + pgprot_t msk_clr; + pte_t *pte = lookup_address((unsigned long)kaddr, &level); + + B

Re: [PATCH v5 02/10] mm, x86: Add support for eXclusive Page Frame Ownership (XPFO)

2017-08-14 Thread Laura Abbott
On 08/09/2017 01:07 PM, Tycho Andersen wrote: > diff --git a/mm/xpfo.c b/mm/xpfo.c > new file mode 100644 > index ..3cd45f68b5ad > --- /dev/null > +++ b/mm/xpfo.c > @@ -0,0 +1,208 @@ > +/* > + * Copyright (C) 2017 Hewlett Packard Enterprise Development, L.P. > + * Copyright (C) 2016 Bro

Re: [kernel-hardening] [PATCH v5 06/10] arm64/mm: Disable section mappings if XPFO is enabled

2017-08-14 Thread Laura Abbott
On 08/14/2017 09:22 AM, Tycho Andersen wrote: > On Sat, Aug 12, 2017 at 12:17:34PM +0100, Mark Rutland wrote: >> Hi, >> >> On Fri, Aug 11, 2017 at 03:13:02PM -0600, Tycho Andersen wrote: >>> On Fri, Aug 11, 2017 at 10:25:14AM -0700, Laura Abbott wrote: >>>&

Re: [kernel-hardening] [PATCH v5 00/10] Add support for eXclusive Page Frame Ownership

2017-08-11 Thread Laura Abbott
On 08/09/2017 01:07 PM, Tycho Andersen wrote: > Hi all, > > Here's a v5 of the XPFO set. Changes from v4 are: > > * huge pages support actually works now on x86 > * arm64 support, which boots on several different arm64 boards > * tests for hugepages support as well via LKDTM (thanks Kees for sugg

Re: [kernel-hardening] [PATCH v5 05/10] arm64/mm: Add support for XPFO

2017-08-11 Thread Laura Abbott
On 08/09/2017 01:07 PM, Tycho Andersen wrote: > From: Juerg Haefliger > > Enable support for eXclusive Page Frame Ownership (XPFO) for arm64 and > provide a hook for updating a single kernel page table entry (which is > required by the generic XPFO code). > > At the moment, only 64k page sizes a

Re: [kernel-hardening] [PATCH v5 06/10] arm64/mm: Disable section mappings if XPFO is enabled

2017-08-11 Thread Laura Abbott
On 08/09/2017 01:07 PM, Tycho Andersen wrote: > From: Juerg Haefliger > > XPFO (eXclusive Page Frame Ownership) doesn't support section mappings > yet, so disable it if XPFO is turned on. > > Signed-off-by: Juerg Haefliger > Tested-by: Tycho Andersen > --- > arch/arm64/mm/mmu.c | 14 +

New assembler warnings with binutils 2.29

2017-08-10 Thread Laura Abbott
Fedora rawhide recently upgraded to binutils 2.29 and this seems to produce new warnings: ./arch/arm64/include/asm/assembler.h: Assembler messages: ./arch/arm64/include/asm/assembler.h:125: Warning: ignoring attempt to redefine built-in register 'lr' This is /* * Register aliases. */ lr

Re: [PATCH] lkdtm: Test VMAP_STACK allocates leading/trailing guard pages

2017-08-07 Thread Laura Abbott
On 08/07/2017 03:00 PM, Mark Rutland wrote: > Hi, > > On Mon, Aug 07, 2017 at 01:39:48PM -0700, Kees Cook wrote: >> Two new tests STACK_GUARD_PAGE_LEADING and STACK_GUARD_PAGE_TRAILING >> attempt to read the byte before and after, respectively, of the current >> stack frame, which should fault und

Re: [RFC][PATCH] mm/slub.c: Allow poisoning to use the fast path

2017-08-07 Thread Laura Abbott
On 08/07/2017 11:03 AM, Christopher Lameter wrote: > On Mon, 7 Aug 2017, Laura Abbott wrote: > >>> Ok I see that the objects are initialized with poisoning and redzoning but >>> I do not see that there is fastpath code to actually check the values >>> before the

Re: [RFC][PATCH] mm/slub.c: Allow poisoning to use the fast path

2017-08-07 Thread Laura Abbott
On 08/07/2017 07:37 AM, Christopher Lameter wrote: > On Fri, 4 Aug 2017, Laura Abbott wrote: > >> All slub debug features currently disable the fast path completely. >> Some features such as consistency checks require this to allow taking of >> locks. Poisoning and red z

[RFC][PATCH] mm/slub.c: Allow poisoning to use the fast path

2017-08-04 Thread Laura Abbott
'fast' debugging options are enabled. The code will automatically revert to always using the slow path when 'slow' options are enabled. Signed-off-by: Laura Abbott --- This is a follow up from my previous proposal to add an alternate per-cpu list. The feedback was just add to

Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces

2017-07-28 Thread Laura Abbott
On 07/28/2017 07:23 AM, Tom Bogendoerfer wrote: > On Thu, Jul 27, 2017 at 03:39:58PM -0700, Laura Abbott wrote: >> I don't know the intricacies of the Mustang hardware but external >> aborts have been a symptom of missing clocks on other hardware. > > you are right,

Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces

2017-07-27 Thread Laura Abbott
On 07/27/2017 02:39 PM, Tom Bogendoerfer wrote: > On Thu, Jul 27, 2017 at 02:03:42PM -0700, Laura Abbott wrote: >> This change causes boot failures for me on my APM Mustang system running >> Fedora rawhide: >> >> [ 16.669089] Synchronous External Abort: synchronous ex

Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces

2017-07-27 Thread Laura Abbott
On 07/13/2017 01:57 AM, Thomas Bogendoerfer wrote: > From: Thomas Bogendoerfer > > This change fixes following problem > > [1.827940] xgene-enet: probe of 1f210030.ethernet failed with error -2 > > which leads to a missing ethernet interface (reproducable at least on > Gigabyte MP30-AR0 and

Re: [kernel-hardening] Re: [RFC PATCH 6/6] arm64: add VMAP_STACK and detect out-of-bounds SP

2017-07-20 Thread Laura Abbott
On 07/20/2017 10:30 AM, Ard Biesheuvel wrote: > On 20 July 2017 at 09:56, Ard Biesheuvel wrote: >> On 20 July 2017 at 09:36, James Morse wrote: >>> Hi Ard, >>> >>> On 20/07/17 06:35, Ard Biesheuvel wrote: >>>> On 20 July 2017 at 00:32, Laura Abbo

Re: [kernel-hardening] Re: [RFC PATCH 6/6] arm64: add VMAP_STACK and detect out-of-bounds SP

2017-07-18 Thread Laura Abbott
On 07/15/2017 05:03 PM, Ard Biesheuvel wrote: > On 14 July 2017 at 22:27, Mark Rutland wrote: >> On Fri, Jul 14, 2017 at 03:06:06PM +0100, Mark Rutland wrote: >>> On Fri, Jul 14, 2017 at 01:27:14PM +0100, Ard Biesheuvel wrote: On 14 July 2017 at 11:48, Ard Biesheuvel wrote: > On 14 July

Re: [RFC PATCH 1/4] Provide linux/set_memory.h

2017-06-29 Thread Laura Abbott
could pick up patch 1 (it's a nop by itself) and then we can send the > conversions separately later in the merge window? > Acked-by: Laura Abbott > cheers > > diff --git a/include/linux/set_memory.h b/include/linux/set_memory.h > new file mode 100644 > ind

Re: [PATCH] ARM: memblock limit must be pmd-aligned

2017-06-26 Thread Laura Abbott
On 06/26/2017 10:23 AM, Doug Berger wrote: > There is a path through the adjust_lowmem_bounds() routine where if all > memory regions start and end on pmd-aligned addresses the memblock_limit > will be set to arm_lowmem_limit. > > However, since arm_lowmem_limit can be affected by the vmalloc earl

Re: [PATCH 22/23] usercopy: split user-controlled slabs to separate caches

2017-06-20 Thread Laura Abbott
On 06/19/2017 04:36 PM, Kees Cook wrote: > From: David Windsor > > Some userspace APIs (e.g. ipc, seq_file) provide precise control over > the size of kernel kmallocs, which provides a trivial way to perform > heap overflow attacks where the attacker must control neighboring > allocations of a sp

Re: [PATCH] mm: Add SLUB free list pointer obfuscation

2017-06-20 Thread Laura Abbott
On 06/19/2017 08:01 PM, Kees Cook wrote: > This SLUB free list pointer obfuscation code is modified from Brad > Spengler/PaX Team's code in the last public patch of grsecurity/PaX based > on my understanding of the code. Changes or omissions from the original > code are mine and don't reflect the o

Re: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS - fix V8+ protocol handling (73 03 28)")

2017-06-19 Thread Laura Abbott
bs_params(dev1, ABS_MT_POSITION_Y, 0, priv->y_max, 0, 0); >> >> input_abs_set_res(dev1, ABS_MT_POSITION_X, priv->x_res); >> input_abs_set_res(dev1, ABS_MT_POSITION_Y, priv->y_res); >> >> For testing this code, I assigned an abnormal value to x

Re: [RFC][PATCH] slub: Introduce 'alternate' per cpu partial lists

2017-06-14 Thread Laura Abbott
On 06/13/2017 09:45 PM, Joonsoo Kim wrote: > On Thu, Jun 08, 2017 at 04:53:04PM -0700, Laura Abbott wrote: >> SLUB debugging features (poisoning, red zoning etc.) skip the fast path >> completely. This ensures there is a single place to do all checks and >> take any locks that

Re: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS - fix V8+ protocol handling (73 03 28)")

2017-06-14 Thread Laura Abbott
Laura > Best Regards, > Masaki Ota > -Original Message- > From: Laura Abbott [mailto:labb...@redhat.com] > Sent: Wednesday, June 07, 2017 1:59 AM > To: Paul Donohue > Cc: 太田 真喜 Masaki Ota ; Dmitry Torokhov > ; Pali Rohar ; Nick Fletcher > ; linux-in...@vger.ke

Lockdep splat with tc filter on 4.11

2017-06-13 Thread Laura Abbott
Hi, Fedora got a bug report https://bugzilla.redhat.com/show_bug.cgi?id=1459626 of a hang on 4.11.3 with lockdep splat: [ 129.100206] BUG: sleeping function called from invalid context at mm/slab.h:432 [ 129.100237] in_atomic(): 1, irqs_disabled(): 0, pid: 1793, name: tc [ 129.100239] 2 locks

Re: [PATCH 2/4] Protectable Memory Allocator

2017-06-09 Thread Laura Abbott
On 06/07/2017 05:35 AM, Igor Stoppa wrote: > The MMU available in many systems running Linux can often provide R/O > protection to the memory pages it handles. > > However, the MMU-based protection works efficiently only when said pages > contain only data that will not need further modifications.

Re: [PATCH 0/2] arm64: fix crash when reading /proc/kcore

2017-06-09 Thread Laura Abbott
el (2): > fs/proc: kcore: use kcore_list type to check for vmalloc/module > address > arm64: mm: select CONFIG_ARCH_PROC_KCORE_TEXT > > arch/arm64/Kconfig | 3 +++ > fs/proc/kcore.c| 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-) > Reviewed-by: Laura Abbo

[RFC][PATCH] slub: Introduce 'alternate' per cpu partial lists

2017-06-08 Thread Laura Abbott
path. Debugging that doesn't require locks (poisoning/red zoning) can happen on this path to avoid the penalty of always needing to go for the slow path. Signed-off-by: Laura Abbott --- This is a follow up to my previous proposal to speed up slub_debug=P https://marc.info/?l=linux-mm&m=1

Re: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS - fix V8+ protocol handling (73 03 28)")

2017-06-06 Thread Laura Abbott
27#c13 "Cursor movement seems to work, but there are intermittent two-finger scrolling issues on the right-hand side of the touchpad. There are no issues with cursor movement or two-finger scrolling on the left-hand side of the touchpad." > On Fri, Jun 02, 2017 at 10:54:52AM -070

Re: [PATCH 2/5] Protectable Memory Allocator

2017-06-06 Thread Laura Abbott
On 06/06/2017 04:34 AM, Igor Stoppa wrote: > On 06/06/17 09:25, Christoph Hellwig wrote: >> On Tue, Jun 06, 2017 at 01:44:32PM +0900, Tetsuo Handa wrote: > > [..] > >>> As far as I know, not all CONFIG_MMU=y architectures provide >>> set_memory_ro()/set_memory_rw(). You need to provide fallback f

[REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS - fix V8+ protocol handling (73 03 28)")

2017-06-02 Thread Laura Abbott
Hi, Fedora got a bug report https://bugzilla.redhat.com/show_bug.cgi?id=1447327 of a touchpad failure on a Dell Latitude E7370. Testing showed that the bad commit was commit e7348396c6d51b57c95c6646c390cd078e038e19 Author: Masaki Ota Date: Fri Mar 17 14:10:57 2017 -0700 Input: ALPS - fix

Re: [PATCH] staging: android: uapi: drop definitions of removed ION_IOC_{FREE,SHARE} ioctls

2017-05-30 Thread Laura Abbott
_IOWR(ION_IOC_MAGIC, 4, struct > ion_fd_data) > - > -/** > * DOC: ION_IOC_HEAP_QUERY - information about available heaps > * > * Takes an ion_heap_query structure and populates information about > Acked-by: Laura Abbott

Re: [PATCH 0/3] staging: android: ion: Minor clean ups and fixes

2017-05-17 Thread Laura Abbott
drivers/staging/android/uapi/ion.h | 6 -- > 3 files changed, 3 insertions(+), 31 deletions(-) > Acked-by: Laura Abbott

[PATCHv2] drm/prime: Forward declare struct device

2017-05-10 Thread Laura Abbott
de of this definition or declaration struct device *attach_dev); ^~ Forward declare it. Signed-off-by: Laura Abbott --- v2: Switch to foward declaration instead of including a header. --- include/drm/drm_prime.h | 2 ++ 1 file changed, 2 insertions(+) di

[PATCH] drm/prime: include device.h

2017-05-10 Thread Laura Abbott
outside of this definition or declaration struct device *attach_dev); ^~ Signed-off-by: Laura Abbott --- Sorry, missed sending this out --- include/drm/drm_prime.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_prime.h b/include/drm/d

[PATCH] ima: Add cgroups2 to the defaults list

2017-05-09 Thread Laura Abbott
cgroups2 is beginning to show up in wider usage. Add it to the default nomeasure/noappraise list like other filesystems. Signed-off-by: Laura Abbott --- security/integrity/ima/ima_policy.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/security/integrity/ima/ima_policy.c b/security

Re: ION changes in staging for 4.12

2017-05-09 Thread Laura Abbott
On 05/08/2017 05:18 PM, John Stultz wrote: > Hey Laura, >Wanted to check in on ION changes that landed in the staging merge > for 4.12... > > So with these changes, I can no longer get HiKey to boot to graphics. > We had previously been using the dummy ion driver, and I've added the > new conf

[tip:x86/urgent] x86/mm/32: Set the '__vmalloc_start_set' flag in initmem_init()

2017-05-08 Thread tip-bot for Laura Abbott
Commit-ID: 861ce4a3244c21b0af64f880d5bfe5e6e2fb9e4a Gitweb: http://git.kernel.org/tip/861ce4a3244c21b0af64f880d5bfe5e6e2fb9e4a Author: Laura Abbott AuthorDate: Mon, 8 May 2017 14:23:16 -0700 Committer: Ingo Molnar CommitDate: Tue, 9 May 2017 08:12:27 +0200 x86/mm/32: Set the

[PATCH] x86/mm: Set __vmalloc_start_set in numa_32.c

2017-05-08 Thread Laura Abbott
: use specific __vmalloc_start_set flag in __virt_addr_valid")q Reported-by: kbuild test robot Signed-off-by: Laura Abbott --- arch/x86/mm/numa_32.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/mm/numa_32.c b/arch/x86/mm/numa_32.c index 6b7ce62..aca6295 100644 --- a/arch/x86/

Re: [mm/usercopy] 517e1fbeb6: kernel BUG at arch/x86/mm/physaddr.c:78!

2017-05-08 Thread Laura Abbott
rvalds/linux.git master >> >> commit 517e1fbeb65f5eade8d14f46ac365db6c75aea9b >> Author: Laura Abbott >> AuthorDate: Tue Apr 4 14:09:00 2017 -0700 >> Commit: Kees Cook >> CommitDate: Wed Apr 5 12:30:18 2017 -0700 >> >> mm/usercopy: Drop extra is_

Re: RFC v2: post-init-read-only protection for data allocated dynamically

2017-05-08 Thread Laura Abbott
On 05/05/2017 03:42 AM, Igor Stoppa wrote: > On 04/05/17 19:49, Laura Abbott wrote: >> [adding kernel-hardening since I think there would be interest] > > thank you, I overlooked this > > >> BPF takes the approach of calling set_memory_ro to mark regions as >&

Re: [PATCH -next] staging/android/ion: remove useless document file

2017-05-08 Thread Laura Abbott
On 05/06/2017 02:49 AM, Yisheng Xie wrote: > From: Yisheng Xie > > After commit 9828282e33a0 ("staging: android: ion: Remove old platform > support"), the document about devicetree of ion is no need anymore, so > just remove it. > Acked-by: Laura Abbott

Re: [PATCH] ion: hisilicon: check the right value after ion_heap_create

2017-05-05 Thread Laura Abbott
On 05/04/2017 08:32 PM, Yisheng Xie wrote: > Hi Laura, > > On 2017/5/5 1:47, Laura Abbott wrote: >> On 05/04/2017 07:45 AM, Yisheng Xie wrote: >>> From: Yisheng Xie >>> >>> It should check ipdev->heaps[i] whether it is error or null instead of >&g

[PATCHv4 3/3] drm/vgem: Enable dmabuf import interfaces

2017-05-04 Thread Laura Abbott
Enable the GEM dma-buf import interfaces in addition to the export interfaces. This lets vgem be used as a test source for other allocators (e.g. Ion). Reviewed-by: Chris Wilson Signed-off-by: Laura Abbott --- v4: Use new drm_gem_prime_import_dev function --- drivers/gpu/drm/vgem/vgem_drv.c

[PATCHv4 2/3] drm/prime: Introduce drm_gem_prime_import_dev

2017-05-04 Thread Laura Abbott
The existing drm_gem_prime_import function uses the underlying struct device of a drm_device for attaching to a dma_buf. Some drivers (notably vgem) may not have an underlying device structure. Offer an alternate function to attach using any available device structure. Signed-off-by: Laura

[PATCHv4 0/3] dma_buf import support for vgem

2017-05-04 Thread Laura Abbott
Hi, This v4 of the series to add dma_buf import functions for vgem. This version primarily focuses on adding a new approach for an alternate dma_buf attach after platformdev was removed. Thanks, Laura Laura Abbott (3): drm/vgem: Add a dummy platform device drm/prime: Introduce

[PATCHv4 1/3] drm/vgem: Add a dummy platform device

2017-05-04 Thread Laura Abbott
The vgem driver is currently registered independent of any actual device. Some usage of the dmabuf APIs require an actual device structure to do anything. Register a dummy platform device for use with dmabuf. Reviewed-by: Chris Wilson Signed-off-by: Laura Abbott --- v4: Switch from the now

Re: [PATCH] ion: hisilicon: check the right value after ion_heap_create

2017-05-04 Thread Laura Abbott
On 05/04/2017 07:45 AM, Yisheng Xie wrote: > From: Yisheng Xie > > It should check ipdev->heaps[i] whether it is error or null instead of > ipdev->heaps, after ion_heap_create() for ipdev->heaps[i]. > > Signed-off-by: Yisheng Xie > --- > drivers/staging/android/ion/hisilicon/hi6220_ion.c | 2 +

Re: RFC v2: post-init-read-only protection for data allocated dynamically

2017-05-04 Thread Laura Abbott
[adding kernel-hardening since I think there would be interest] On 05/03/2017 05:06 AM, Igor Stoppa wrote: > Hello, > > please review my (longish) line of thoughts, below. > > I've restructured them so that they should be easier to follow. > > > Observations > > > * it is current

Re: [PATCHv3 2/3] drm/prime: Introduce drm_gem_prime_import_platform

2017-05-03 Thread Laura Abbott
On 05/03/2017 12:39 AM, Daniel Vetter wrote: > On Tue, May 02, 2017 at 09:22:13PM +0100, Chris Wilson wrote: >> On Tue, May 02, 2017 at 10:02:07AM -0700, Laura Abbott wrote: >>> /** >>> + * drm_gem_prime_import_platform - alternate implementation of the import

[PATCHv3 2/3] drm/prime: Introduce drm_gem_prime_import_platform

2017-05-02 Thread Laura Abbott
-...@lists.freedesktop.org Reviewed-by: Chris Wilson Signed-off-by: Laura Abbott --- v3: Rebase to drm-misc-next. Prototype moved to a new header file. Comments added for new function. Brought back drm_device->platformdev as it had been removed in 76adb460fd93 ("drm: Remove the struct dr

[PATCHv3 3/3] drm/vgem: Enable dmabuf import interfaces

2017-05-02 Thread Laura Abbott
Enable the GEM dma-buf import interfaces in addition to the export interfaces. This lets vgem be used as a test source for other allocators (e.g. Ion). Cc: intel-...@lists.freedesktop.org Reviewed-by: Chris Wilson Signed-off-by: Laura Abbott --- v3: Minor fixes suggested by Chris Wilson

<    1   2   3   4   5   6   7   8   9   10   >