Re: [PATCH V2] spi: tegra: add spi driver for SLINK controller

2012-10-29 Thread Laxman Dewangan
On Tuesday 30 October 2012 12:44 AM, Stephen Warren wrote: On 10/29/2012 11:18 AM, Laxman Dewangan wrote: Tegra20/Tegra30 supports the spi interface through its SLINK controller. Add spi driver for SLINK controller. diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig +config

Re: [PATCH V2] spi: tegra: add spi driver for SLINK controller

2012-10-29 Thread Laxman Dewangan
On Tuesday 30 October 2012 12:44 AM, Stephen Warren wrote: On 10/29/2012 11:18 AM, Laxman Dewangan wrote: Tegra20/Tegra30 supports the spi interface through its SLINK controller. Add spi driver for SLINK controller. diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig +config

[PATCH V3] spi: tegra: add spi driver for SLINK controller

2012-10-30 Thread Laxman Dewangan
Tegra20/Tegra30 supports the spi interface through its SLINK controller. Add spi driver for SLINK controller. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- Changes from V1: - Add dt file documentation. - Renames some of props to match with other driver. - Move clock control to run time

[PATCH V3 4/4] ARM: tegra: config: enable spi driver for Tegra SLINK controller

2012-10-30 Thread Laxman Dewangan
Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- No change from V1 and V2. arch/arm/configs/tegra_defconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/configs/tegra_defconfig b/arch/arm/configs/tegra_defconfig index fb29680..60e1b2e 100644

[PATCH V3 2/4] ARM: tegra: Add OF_DEV_AUXDATA for SLINK driver in board dt

2012-10-30 Thread Laxman Dewangan
Add OF_DEV_AUXDATA for slink driver for Tegra20 and Tegra30 board dt files. Set the parent clock of slink controller to PLLP and configure clock to 100MHz. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- Changes from V1: - Revert the changes in clock table to get the driver name. Changes

[PATCH V3 3/4] ARM: tegra: dts: cardhu: enable SLINK4

2012-10-30 Thread Laxman Dewangan
Enable SLINK4 in Tegra30 based platform Cardhu. Setting maximum spi frequency to 25MHz. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- Changes from V1: - rename the max freq prop to spi-max-frequency Changes from V2: - make node name to spi@ arch/arm/boot/dts/tegra30-cardhu.dtsi

[PATCH V3 0/4] ARM: tegra: Enable SLINK controller driver

2012-10-30 Thread Laxman Dewangan
the spi max frequency prop to spi-max-frequency. Changes from V2: - make node name to spi. - get rid of iomap.h. Laxman Dewangan (4): ARM: tegra: dts: add slink controller dt entry ARM: tegra: Add OF_DEV_AUXDATA for SLINK driver in board dt ARM: tegra: dts: cardhu: enable SLINK4 ARM: tegra

[PATCH V3 1/4] ARM: tegra: dts: add slink controller dt entry

2012-10-30 Thread Laxman Dewangan
Add slink controller details in the dts file of Tegra20 and Tegra30. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- Changes from V1: -rename the dma request prop to nvidia,dma-request-selector. Changes from V2: - Make node name as spi@. arch/arm/boot/dts/tegra20.dtsi | 41

Re: [PATCH 1/3] mfd: Convert tps6586x to irq_domain

2012-10-30 Thread Laxman Dewangan
: On Tue, Oct 09, 2012 at 11:34:47AM +0530, Laxman Dewangan wrote: The bit definitions are also different in status and mask register and yes, this will be again problem as we do in isr thread data-status_buf[i]= ~data-mask_buf[i]; So given the constraint, generic will not work here. OK, that's

Re: [PATCH 1/3] mfd: Convert tps6586x to irq_domain

2012-10-30 Thread Laxman Dewangan
: On Tue, Oct 09, 2012 at 11:34:47AM +0530, Laxman Dewangan wrote: The bit definitions are also different in status and mask register and yes, this will be again problem as we do in isr thread data-status_buf[i]= ~data-mask_buf[i]; So given the constraint, generic will not work here. OK, that's

Re: [PATCH V3] spi: tegra: add spi driver for SLINK controller

2012-10-31 Thread Laxman Dewangan
On Wednesday 31 October 2012 12:08 AM, Mark Brown wrote: * PGP Signed by an unknown key On Tue, Oct 30, 2012 at 12:34:05PM +0530, Laxman Dewangan wrote: Tegra20/Tegra30 supports the spi interface through its SLINK controller. Add spi driver for SLINK controller. Applied, thanks. Thank you

Re: [PATCH V3 0/4] ARM: tegra: Enable SLINK controller driver

2012-10-31 Thread Laxman Dewangan
On Wednesday 31 October 2012 01:59 AM, Stephen Warren wrote: On 10/30/2012 01:05 AM, Laxman Dewangan wrote: This series modify the dts file to add the slink addresses, make AUXDATA in board dt files, enable slink4 for tegra30-cardhu and enable slink controller defconfig. This series only

[PATCH V4 0/4] ARM: tegra: Enable SLINK controller driver

2012-10-31 Thread Laxman Dewangan
the spi max frequency prop to spi-max-frequency. Changes from V2: - make node name to spi. - get rid of iomap.h. Changes from V3: - Enable spi flash connected on slink4-cs1. - Enable require defconfigs. Laxman Dewangan (4): ARM: tegra: dts: add slink controller dt entry ARM: tegra: Add

[PATCH V4 0/4] ARM: tegra: Enable SLINK controller driver

2012-10-31 Thread Laxman Dewangan
the spi max frequency prop to spi-max-frequency. Changes from V2: - make node name to spi. - get rid of iomap.h. Changes from V3: - Enable spi flash connected on slink4-cs1. - Enable require defconfigs. Laxman Dewangan (4): ARM: tegra: dts: add slink controller dt entry ARM: tegra: Add

[PATCH V4 2/4] ARM: tegra: Add OF_DEV_AUXDATA for SLINK driver in board dt

2012-10-31 Thread Laxman Dewangan
Add OF_DEV_AUXDATA for slink driver for Tegra20 and Tegra30 board dt files. Set the parent clock of slink controller to PLLP and configure clock to 100MHz. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- Changes from V1: - Revert the changes in clock table to get the driver name. Changes

[PATCH V4 4/4] ARM: tegra: config: enable spi driver for Tegra SLINK controller

2012-10-31 Thread Laxman Dewangan
Also enable the MTD, MTD_M25P80 and MTD_CHAR driver to enable SPI flash. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- No change from V1 and V2. Changes from V2: - enable MTD, MTD_M25P80 and MTD_CHAR drivers. arch/arm/configs/tegra_defconfig |5 - 1 files changed, 4

[PATCH V4 3/4] ARM: tegra: dts: cardhu: enable SLINK4

2012-10-31 Thread Laxman Dewangan
Enable SLINK4 and connected device in Tegra30 based platform Cardhu. Setting maximum spi frequency to 25MHz. Spi serial flash is connected on CS1 of SLINK4 on cardhu platform. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- Changes from V1: - rename the max freq prop to spi-max-frequency

Re: [PATCH] regulator: core: Move regulator release to avoid deadlock

2012-10-31 Thread Laxman Dewangan
On Monday 29 October 2012 09:44 PM, Mark Brown wrote: * PGP Signed by an unknown key On Mon, Oct 29, 2012 at 09:33:33AM +, Charles Keepax wrote: regulator_put function was called whilst holding the regulator_list_mutex, which is also locked from regulator_put. This causes deadlock when

Re: [PATCH 2/2] dma: tegra20-apbdma: channel freeing correction

2012-10-31 Thread Laxman Dewangan
to handle_once_dma_done. This happens because tegra_dma_abort_all() won't be called on channel freeing if pending list is empty. Signed-off-by: Dmitry Osipenkodig...@gmail.com Looks good to me. Acked-by: Laxman Dewangan ldewan...@nvidia.com -- To unsubscribe from this list: send the line

Re: [PATCH 2/2] dma: tegra20-apbdma: channel freeing correction

2012-10-31 Thread Laxman Dewangan
to handle_once_dma_done. This happens because tegra_dma_abort_all() won't be called on channel freeing if pending list is empty. Signed-off-by: Dmitry Osipenkodig...@gmail.com Both patches looks good to me. Acked-by: Laxman Dewangan ldewan...@nvidia.com -- To unsubscribe from this list: send

Re: [PATCH V2] dma: tegra: avoid channel lock up after free

2012-10-31 Thread Laxman Dewangan
type checked before making allocations. Signed-off-by: Dmitry Osipenkodig...@gmail.com --- Looks good to me. Acked-by: Laxman Dewangan ldewan...@nvidia.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH V4 0/4] ARM: tegra: Enable SLINK controller driver

2012-10-31 Thread Laxman Dewangan
On Wednesday 31 October 2012 09:59 PM, Stephen Warren wrote: On 10/31/2012 03:02 AM, Laxman Dewangan wrote: This series modify the dts file to add the slink addresses, make AUXDATA in board dt files, enable slink4 for tegra30-cardhu and enable slink controller defconfig. I don't appear to have

Re: [PATCH V3 0/4] ARM: tegra: Enable SLINK controller driver

2012-10-31 Thread Laxman Dewangan
On Wednesday 31 October 2012 09:36 PM, Stephen Warren wrote: On 10/31/2012 02:51 AM, Laxman Dewangan wrote: I had forgotten about this from when I tested the older SPI driver that we ripped out; I had at least compared the registers between U-Boot and the kernel with that driver, so I'm pretty

Re: [PATCH V4 3/4] ARM: tegra: dts: cardhu: enable SLINK4

2012-10-31 Thread Laxman Dewangan
On Wednesday 31 October 2012 10:14 PM, Stephen Warren wrote: On 10/31/2012 03:02 AM, Laxman Dewangan wrote: Enable SLINK4 and connected device in Tegra30 based platform Cardhu. Setting maximum spi frequency to 25MHz. Spi serial flash is connected on CS1 of SLINK4 on cardhu platform. diff --git

Re: [PATCH V4 0/4] ARM: tegra: Enable SLINK controller driver

2012-10-31 Thread Laxman Dewangan
On Thursday 01 November 2012 12:46 AM, Stephen Warren wrote: On 10/31/2012 11:31 AM, Laxman Dewangan wrote: On Wednesday 31 October 2012 09:59 PM, Stephen Warren wrote: On 10/31/2012 03:02 AM, Laxman Dewangan wrote: This series modify the dts file to add the slink addresses, make AUXDATA

Re: regulator: tps51632: Seems current code doesn't properly support dvfs_step_20mV case

2012-11-01 Thread Laxman Dewangan
On Thursday 01 November 2012 12:18 PM, Axel Lin wrote: Hi Laxman, While reading the tps51632 driver, I found there is a dvfs_step_20mV setting in platform data. But seems current code doesn't properly handle the case when dvfs_step_20mV is true. I guess if pdata-dvfs_step_20mV is true, we

Re: [PATCH] regulator: Fix trivial typo for TPS51632 Kconfig help text

2012-11-01 Thread Laxman Dewangan
+ Step Down Driverless Controller Ooh no, silly typo. Acked-by: Laxman Dewangan ldewan...@nvidia.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH REPOST] i2c: tegra: set irq name as device name

2012-11-01 Thread Laxman Dewangan
When watching the irqs name of tegra i2c, all instances irq name shows as tegra_i2c. Passing the device name properly to have the irq names with instance like tegra-i2c.0, tegra-i2c.1 etc. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com Acked-by: Jean Delvare kh...@linux-fr.org --- Reposting

[PATCH V3 2/4] mfd: tps65910: use regmap irq framework for interrupt support

2012-11-02 Thread Laxman Dewangan
Implement irq support of tps65910 with regmap irq framework in place of implementing locally. This reduces the code size significantly and easy to maintain. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com Reviewed-by: Mark Brown broo...@opensource.wolfsonmicro.com --- No change from V1, just

[PATCH V3 3/4] mfd: tps65910: move interrupt implementation code to mfd file

2012-11-02 Thread Laxman Dewangan
In place of implementing the irq support in separate file, moving implementation to main mfd file. The irq files only contains the table and init steps only and does not need extra file to have this only for this purpose. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com Reviewed-by: Mark Brown

[PATCH V3 0/4] mfd: tps65910: use regmap irq framework for interrupt

2012-11-02 Thread Laxman Dewangan
in the regmap. - Add empty line if paragraph change in description. Changes from V2: - Remove the older 4th patch where API for getting irq_domain was added in regmap. It is already taken care by Mark B. Laxman Dewangan (4): mfd: tps65910: Initialize mfd devices after all initialization done

[PATCH V3 1/4] mfd: tps65910: Initialize mfd devices after all initialization done

2012-11-02 Thread Laxman Dewangan
Add sub devices of tps65910 after all initialization like interrupt, clock etc. is done. This will make sure that require data gets initialized properly before sub devices probe's get called. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com Reviewed-by: Mark Brown broo

[PATCH V3 4/4] mfd: tps65910: pass irq_domain when adding mfd sub devices

2012-11-02 Thread Laxman Dewangan
When adding the sub device tps65910-rtc, is it passed the IO resource IRQ for the interrupt number. This interrupt needs to map in the device irq domain. Pass the irq domain of device in mfd_add_devices() so that proper irq mapping can be done when adding the sub device RTC. Signed-off-by: Laxman

[PATCH REPOST 1/3] mfd: Convert tps6586x to irq_domain

2012-11-02 Thread Laxman Dewangan
-by: Laxman Dewangan ldewan...@nvidia.com Reviewed-by: Mark Brown broo...@opensource.wolfsonmicro.com --- Reposting in case of patch missed. Also added Reviewed by Mark as he already reviewed the patches. drivers/mfd/tps6586x.c | 91 ++--- include/linux/mfd

[PATCH REPOST 2/3] mfd: tps6586x: add irq io-resource for rtc sub driver

2012-11-02 Thread Laxman Dewangan
Add IRQ IORESOURCE for rtc sub driver of this device. The rtc driver can get the irq by calling platform_get_irq(). Signed-off-by: Laxman Dewangan ldewan...@nvidia.com Reviewed-by: Mark Brown broo...@opensource.wolfsonmicro.com --- Reposting in case of patch missed. Also added Reviewed by Mark

[PATCH 3/3] mfd: tps6586x: implement gpio_to_irq

2012-11-02 Thread Laxman Dewangan
The TPS6586x adds the interrupt of this device using linear mapping on irq domain. Hence, implement gpio_to_irq to get the irq number corresponding to TPS6586x GPIOs which is created dynamically. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com Reviewed-by: Mark Brown broo

[PATCH REPOST 0/3] mfd: tps6586x: Convert to irq domain

2012-11-02 Thread Laxman Dewangan
This patch series convert the irq implementation to use the irq domain. Accordingly, gpio driver and rtc registration is updated. Reposting the series and adding the reviwed by Mark and acked by Linus W for the respective patches. Laxman Dewangan (3): mfd: Convert tps6586x to irq_domain mfd

[REPOST/PATCH] mfd: tps65910: remove warning during dt node parsing

2012-09-26 Thread Laxman Dewangan
as follows: [0.384605] tps65910 4-002d: VMBCH-Threshold not specified [0.384616] tps65910 4-002d: VMBCH2-Threshold not specified Removing the warning message from driver. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- It seems orginal patch has been lost. Reposting it. drivers/mfd

[PATCH] dma: tegra: fix interrupt name issue with apb dma.

2012-10-03 Thread Laxman Dewangan
this pointer as the devname for irq registration to avoid change of name. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- drivers/dma/tegra20-apb-dma.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c index

[PATCH] dma: tegra: fix interrupt name issue with apb dma.

2012-10-03 Thread Laxman Dewangan
this pointer as the devname for irq registration to avoid change of name. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- Resending as mail was not delivered to a...@kernel.org. drivers/dma/tegra20-apb-dma.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH 0/5] regulator: tps65090: fix regulator registration and add external control support

2012-10-06 Thread Laxman Dewangan
5: Add support for extenal control for DCDC. Laxman Dewangan (5): regulator: tps65090: rename driver name and regulator name regulator; tps65090: Register all regulators in single probe call regulator: tps65090: Add support for LDO regulators regulator: tps65090: Add voltage out level

[PATCH 3/5] regulator: tps65090: Add support for LDO regulators

2012-10-06 Thread Laxman Dewangan
TPS65090 supports the two LDOs, LDO1 and LDO2. These are always ON regulators. The output on these LDOs are available once the input voltage available for these LDOs. Add support for these LDOs regulators. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- drivers/regulator/tps65090

[PATCH 1/5] regulator: tps65090: rename driver name and regulator name

2012-10-06 Thread Laxman Dewangan
To make the names proper and more appropriate: Rename the driver name from tps65090-regulator to tps65090-pmic. Rename the regulators from TPS65090_ID_* to TPS65090_REGULATOR_* Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- drivers/regulator/tps65090-regulator.c |8

[PATCH] regulator: TPS51632: Add tps51632 regulator driver

2012-10-06 Thread Laxman Dewangan
interfaces (through PWM) for dynamic control of the output voltage and current monitor telemetry. Add regulator driver for TPS51632. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- drivers/regulator/Kconfig| 11 + drivers/regulator/Makefile |1

[PATCH 4/5] regulator: tps65090: Add voltage out level in platform data

2012-10-06 Thread Laxman Dewangan
TPS65090's DCDCs and FETs act as switch and so output voltage can be enable or disable only. The output voltage of this regulators depends on the input voltage. Add the voltage parameter to tell the output voltage value of these rails. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com

[PATCH 5/5] regulator: tps65090: add external control support for DCDC

2012-10-06 Thread Laxman Dewangan
for passing the GPIO number. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- drivers/regulator/tps65090-regulator.c | 130 +++--- include/linux/regulator/tps65090-regulator.h |6 + 2 files changed, 122 insertions(+), 14 deletions(-) diff --git a/drivers/regulator

[PATCH 2/5] regulator; tps65090: Register all regulators in single probe call

2012-10-06 Thread Laxman Dewangan
. - Convert regulator init data to pointer type in platform data. - Add input supply name in regulator desc to provide input supply. - Separate desc information from driver information. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- drivers/regulator/tps65090-regulator.c | 137

[PATCH 1/5] mfd: add battery charger in tps65090 sub devs

2012-10-07 Thread Laxman Dewangan
TPS65090 supports the battery charging and hence adding the device name in the list of TPS65090 children. Also remove the tps65090-regulator as it duplicates with tps65090-pmic for regulator driver. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- drivers/mfd/tps65090.c |2 +- 1 files

[PATCH 3/5] mfd: tps65090: remove unused member of struct tps65090

2012-10-07 Thread Laxman Dewangan
Remove unused member from tps65090 data structure as these are not used. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- drivers/mfd/tps65090.c |6 +- include/linux/mfd/tps65090.h | 11 --- 2 files changed, 1 insertions(+), 16 deletions(-) diff --git a/drivers

[PATCH 0/5] mfd: tps65090: cleanups and use regmap-irq for interrupt support

2012-10-07 Thread Laxman Dewangan
This patch series cleanups the driver code by removing unused member, rearranging code and moving irq implementation to regmap-irq framework. Laxman Dewangan (5): mfd: add battery charger in tps65090 sub devs mfd: tps65090: add error prints when mem alloc failed mfd: tps65090: remove unused

[PATCH 5/5] mfd: tps65090: use regmap irq framework for interrupt support

2012-10-07 Thread Laxman Dewangan
Use the regmap irq framework for implementing TPS65090 interrupt support in place of implementing it locally. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- drivers/mfd/tps65090.c | 263 -- include/linux/mfd/tps65090.h | 23 +++- 2 files

[PATCH 4/5] mfd: tps65090: move register access APIs to header

2012-10-07 Thread Laxman Dewangan
Since tps65090 register is accessed via regmap, moving the register access APIs to header and making it as inline. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- drivers/mfd/tps65090.c | 34 -- include/linux/mfd/tps65090.h | 39

[PATCH 2/5] mfd: tps65090: add error prints when mem alloc failed

2012-10-07 Thread Laxman Dewangan
Add error prints when memory allocation failed for tps65090 data. Also cleanups the melloc arguments. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- drivers/mfd/tps65090.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/tps65090.c b/drivers/mfd

Re: [PATCH 4/5] mfd: tps65090: move register access APIs to header

2012-10-08 Thread Laxman Dewangan
On Monday 08 October 2012 11:07 AM, Venu Byravarasu wrote: -Original Message- From: Laxman Dewangan Sent: Sunday, October 07, 2012 8:52 PM To: sa...@linux.intel.com Cc: linux-kernel@vger.kernel.org; Venu Byravarasu; Laxman Dewangan Subject: [PATCH 4/5] mfd: tps65090: move register access

Re: [PATCH 3/5] mfd: tps65090: remove unused member of struct tps65090

2012-10-08 Thread Laxman Dewangan
On Monday 08 October 2012 11:10 AM, Venu Byravarasu wrote: -Original Message- From: Laxman Dewangan Sent: Sunday, October 07, 2012 8:52 PM To: sa...@linux.intel.com Cc: linux-kernel@vger.kernel.org; Venu Byravarasu; Laxman Dewangan Subject: [PATCH 3/5] mfd: tps65090: remove unused member

Re: [PATCH 5/5] regulator: tps65090: add external control support for DCDC

2012-10-08 Thread Laxman Dewangan
On Monday 08 October 2012 11:15 AM, Venu Byravarasu wrote: -Original Message- From: Laxman Dewangan Sent: Saturday, October 06, 2012 8:48 PM To: broo...@opensource.wolfsonmicro.com; l...@ti.com; sa...@linux.intel.com Cc: Venu Byravarasu; axel@gmail.com; linux-kernel@vger.kernel.org

Re: [PATCH 1/5] regulator: tps65090: rename driver name and regulator name

2012-10-08 Thread Laxman Dewangan
On Monday 08 October 2012 11:23 AM, Venu Byravarasu wrote: -Original Message- From: Laxman Dewangan Sent: Saturday, October 06, 2012 8:48 PM static struct platform_driver tps65090_regulator_driver = { .driver = { - .name = tps65090-regulator

Re: [PATCH 2/5] mfd: tps65090: add error prints when mem alloc failed

2012-10-08 Thread Laxman Dewangan
On Sunday 07 October 2012 09:43 PM, Joe Perches wrote: On Sun, 2012-10-07 at 20:52 +0530, Laxman Dewangan wrote: Add error prints when memory allocation failed for tps65090 data. Also cleanups the melloc arguments. The new dev_err is unnecessary. A dump_stack is already done on alloc failures

[PATCH 0/2] tps80031: Add mfd and regulator driver

2012-11-05 Thread Laxman Dewangan
Voltage Regulator/Battery Charger with Power Path from USB, 32K clock generator. Laxman Dewangan (2): mfd: add TI TPS80031 mfd core driver regulator: tps80031: add regulator driver for tps80031 drivers/mfd/Kconfig| 14 + drivers/mfd/Makefile |1

[PATCH 2/2] regulator: tps80031: add regulator driver for tps80031

2012-11-05 Thread Laxman Dewangan
-by: Laxman Dewangan ldewan...@nvidia.com --- drivers/regulator/Kconfig |9 + drivers/regulator/Makefile |1 + drivers/regulator/tps80031-regulator.c | 821 include/linux/mfd/tps80031.h | 55 +++ 4 files changed, 886

[PATCH 1/2] mfd: add TI TPS80031 mfd core driver

2012-11-05 Thread Laxman Dewangan
. Add the mfd core driver for TPS80031/TPS80032. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- drivers/mfd/Kconfig | 14 + drivers/mfd/Makefile |1 + drivers/mfd/tps80031.c | 580 ++ include/linux/mfd/tps80031.h | 569

Re: [PATCH 2/2] regulator: tps80031: add regulator driver for tps80031

2012-11-05 Thread Laxman Dewangan
Thanks for quickest review. On Monday 05 November 2012 04:12 PM, Mark Brown wrote: * PGP Signed by an unknown key On Mon, Nov 05, 2012 at 03:14:18PM +0530, Laxman Dewangan wrote: + switch (ri-device_flags) { + case 0: Should we be using different versions of the ops depending

[PATCH V2 0/2] tps80031: Add mfd and regulator driver

2012-11-05 Thread Laxman Dewangan
get voltage apis. - Remove -1 and +1 in vsel. - Correct the vbus ops for sw and hw based. Laxman Dewangan (2): mfd: add TI TPS80031 mfd core driver regulator: tps80031: add regulator driver for tps80031 drivers/mfd/Kconfig| 14 + drivers/mfd/Makefile

[PATCH V2 1/2] mfd: add TI TPS80031 mfd core driver

2012-11-05 Thread Laxman Dewangan
. Add the mfd core driver for TPS80031/TPS80032. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- Changes from V1: - remove the volatle api. - add regmap irq regardless of client-irq. - Correct the irq cleanups. - remove usage of irq_base. - remove suspend/resume - Correct acroym and ES

[PATCH V2 2/2] regulator: tps80031: add regulator driver for tps80031

2012-11-05 Thread Laxman Dewangan
-by: Laxman Dewangan ldewan...@nvidia.com --- Changes from V1: - Rewrite dcdc get voltage apis. - Remove -1 and +1 in vsel. - Correct the vbus ops for sw and hw based. drivers/regulator/Kconfig |9 + drivers/regulator/Makefile |1 + drivers/regulator/tps80031

Re: [PATCH 2/2] regulator: tps80031: add regulator driver for tps80031

2012-11-06 Thread Laxman Dewangan
On Tuesday 06 November 2012 01:46 PM, Mark Brown wrote: * PGP Signed by an unknown key On Mon, Nov 05, 2012 at 05:30:02PM +0530, Laxman Dewangan wrote: On Monday 05 November 2012 04:12 PM, Mark Brown wrote: I have single dcdc ops for all DCDC VIO, SMPS1 to 3. There is different

[PATCH] regulator: core: avoid memory access after freeing it

2012-11-06 Thread Laxman Dewangan
be called in locked context also to avoid the deadlock to address the above issue. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com Cc: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/regulator/core.c | 30 ++ 1 files changed, 18 insertions(+), 12 deletions

[PATCH 1/2] gpio: tegra: create irq mapping in gpio_to_irq

2012-11-07 Thread Laxman Dewangan
. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- drivers/gpio/gpio-tegra.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c index c7c175a..6c08613 100644 --- a/drivers/gpio/gpio-tegra.c +++ b/drivers/gpio/gpio

[PATCH 2/2] gpio: tegra: fix suspend/resume apis

2012-11-07 Thread Laxman Dewangan
if CONFIG_PM is used to protect system sleep callbacks then it may end up unreferenced if only runtime PM is enabled. - Fix the suspend/resume APIs declaration as per callback prototype. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- drivers/gpio/gpio-tegra.c | 18 +- 1

[PATCH V2] gpio: tegra: fix suspend/resume apis

2012-11-07 Thread Laxman Dewangan
if CONFIG_PM is used to protect system sleep callbacks then it may end up unreferenced if only runtime PM is enabled. - Fix the suspend/resume APIs declaration as per callback prototype. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com Acked-by: Stephen Warren swar...@nvidia.com --- Changes from

Re: [PATCH 1/2] gpio: tegra: create irq mapping in gpio_to_irq

2012-11-07 Thread Laxman Dewangan
On Wednesday 07 November 2012 10:38 PM, Stephen Warren wrote: On 11/07/2012 08:01 AM, Laxman Dewangan wrote: The gpio interrupts get mapped linearly and hence the mapping of irq need to be created by irq_create_mapping(). The function gpio_to_irq() returns the irq by irq_find_mapping() and so

[PATCH] gpio: tegra: read output value when gpio is set in direction_out

2012-11-07 Thread Laxman Dewangan
Read the output value when gpio is set for the output mode for gpio_get_value(). Reading input value in direction out does not give correct value. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- drivers/gpio/gpio-tegra.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions

Re: [PATCH 1/5] ARM: tegra: Add slink controller base address

2012-10-19 Thread Laxman Dewangan
On Friday 19 October 2012 04:09 AM, Stephen Warren wrote: On 10/18/2012 04:56 AM, Laxman Dewangan wrote: Add base address of all slink controller of Tegra20 and tegra30. Lets not add anything to iomap.h; we're trying to remove it. Instead, just put the raw address in the AUXDATA; I assume

Re: [PATCH 2/5] ARM: tegra: dts: add slink controller dt entry

2012-10-19 Thread Laxman Dewangan
On Friday 19 October 2012 04:11 AM, Stephen Warren wrote: On 10/18/2012 04:56 AM, Laxman Dewangan wrote: Add slink controller details in the dts file of Tegra20 and Tegra30. diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi + slink@7000d400

Re: [PATCH 3/5] ARM: tegra: fix clock entry of slink controller

2012-10-19 Thread Laxman Dewangan
On Friday 19 October 2012 04:13 AM, Stephen Warren wrote: The patch subject isn't entirely accurate here; this patch isn't just about fixing clock entries. OK, then will break in two patches. + OF_DEV_AUXDATA(nvidia,tegra20-slink, TEGRA_SLINK1_BASE, spi-tegra-slink.0, NULL),

[PATCH 0/3] mfd: tps6586x: Convert to irq domain

2012-10-08 Thread Laxman Dewangan
This patch series convert the irq implementation to use the irq domain. Accordingly, gpio driver and rtc registration is updated. Laxman Dewangan (3): mfd: Convert tps6586x to irq_domain mfd: tps6586x: add irq io-resource for rtc sub driver mfd: tps6586x: implement gpio_to_irq drivers

[PATCH 2/3] mfd: tps6586x: add irq io-resource for rtc sub driver

2012-10-08 Thread Laxman Dewangan
Add IRQ IORESOURCE for rtc sub driver of this device. The rtc driver can get the irq by calling platform_get_irq(). Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- drivers/mfd/tps6586x.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/drivers/mfd

[PATCH 1/3] mfd: Convert tps6586x to irq_domain

2012-10-08 Thread Laxman Dewangan
-by: Laxman Dewangan ldewan...@nvidia.com --- drivers/mfd/tps6586x.c | 91 ++--- include/linux/mfd/tps6586x.h |1 + 2 files changed, 67 insertions(+), 25 deletions(-) diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c index 4674643..2cdf1e6

[PATCH 3/3] mfd: tps6586x: implement gpio_to_irq

2012-10-08 Thread Laxman Dewangan
The TPS6586x adds the interrupt of this device using linear mapping on irq domain. Hence, implement gpio_to_irq to get the irq number corresponding to TPS6586x GPIOs which is created dynamically. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- drivers/gpio/gpio-tps6586x.c |9

Re: [PATCH 1/3] mfd: Convert tps6586x to irq_domain

2012-10-09 Thread Laxman Dewangan
On Tuesday 09 October 2012 11:36 AM, Mark Brown wrote: On Mon, Oct 08, 2012 at 09:43:23PM +0530, Laxman Dewangan wrote: Allocate the irq base if it base is not porvided i.e. in case of device tree invocation of this driver. Convert the tps6586x driver to irq domain, using a legacy IRQ mapping

Re: [PATCH 1/3] mfd: Convert tps6586x to irq_domain

2012-10-09 Thread Laxman Dewangan
On Tuesday 09 October 2012 11:53 AM, Mark Brown wrote: On Tue, Oct 09, 2012 at 11:18:24AM +0530, Laxman Dewangan wrote: On Tuesday 09 October 2012 11:36 AM, Mark Brown wrote: but can you convert to regmap_irq? Yes, the motivation was this when I started this cleanups but found that there is 4

Re: [PATCH] regulator: TPS51632: Add tps51632 regulator driver

2012-10-09 Thread Laxman Dewangan
On Tuesday 09 October 2012 11:44 AM, Mark Brown wrote: On Sat, Oct 06, 2012 at 08:47:46PM +0530, Laxman Dewangan wrote: Actually... + if (pdata-dvfs_step_20mV) + control |= TPS51632_DVFS_STEP_20; + tps-desc.uV_step = TPS51632_VOLATGE_STEP_10mV; Shouldn't

Re: [PATCH 2/5] regulator; tps65090: Register all regulators in single probe call

2012-10-09 Thread Laxman Dewangan
On Tuesday 09 October 2012 11:52 AM, Mark Brown wrote: On Sat, Oct 06, 2012 at 08:47:48PM +0530, Laxman Dewangan wrote: MFD drier registers the regulator driver once per device and Shouldn't this be the first commit in the series? Also... Ok, will make this as first commit. to allow

Re: [PATCH 5/5] regulator: tps65090: add external control support for DCDC

2012-10-09 Thread Laxman Dewangan
On Tuesday 09 October 2012 11:58 AM, Mark Brown wrote: On Sat, Oct 06, 2012 at 08:47:51PM +0530, Laxman Dewangan wrote: The TPS65090's DCDC outut can also be enable/disable through the external digital input signal. Add support for enable/disable either through register access via I2C

[PATCH V2 2/4] regulator: tps65090: rename driver name and regulator name

2012-10-09 Thread Laxman Dewangan
To make the names proper and more appropriate: Rename the driver name from tps65090-regulator to tps65090-pmic. Rename the regulators from TPS65090_ID_* to TPS65090_REGULATOR_* Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- Changes from V1: Make this as patch2 from older patch1

[PATCH V2 4/4] regulator: tps65090: add external control support for DCDC

2012-10-09 Thread Laxman Dewangan
for passing the GPIO number. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- Changes from V1: Simplify external control implemetation. drivers/regulator/tps65090-regulator.c | 77 +++ include/linux/mfd/tps65090.h |7 +++- 2 files changed, 63 insertions

[PATCH V2 0/4] regulator: tps65090: fix regulator registration and add external control support

2012-10-09 Thread Laxman Dewangan
and remove this file. Laxman Dewangan (4): regulator; tps65090: Register all regulators in single probe call regulator: tps65090: rename driver name and regulator name regulator: tps65090: Add support for LDO regulators regulator: tps65090: add external control support for DCDC drivers

[PATCH V2 3/4] regulator: tps65090: Add support for LDO regulators

2012-10-09 Thread Laxman Dewangan
TPS65090 supports the two LDOs, LDO1 and LDO2. These are always ON regulators. The output on these LDOs are available once the input voltage available for these LDOs. Add support for these LDOs regulators. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- Changes from V1: No change from

[PATCH V2 1/4] regulator; tps65090: Register all regulators in single probe call

2012-10-09 Thread Laxman Dewangan
external control bit to have control through register write. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- Changes from V1: - Move this change to Patch1 from older patch2. - Disable external control on init sequence. - Move content of tps65090-regualtor.h to mfd/tps65090.h. drivers

Re: [PATCH V2 4/4] regulator: tps65090: add external control support for DCDC

2012-10-09 Thread Laxman Dewangan
On Tuesday 09 October 2012 04:03 PM, Venu Byravarasu wrote: +static struct regulator_ops tps65090_ext_control_ops = { +}; What is the purpose of adding empty structure? We will not able to register regulator if there is no ops. In regulator register: if (regulator_desc-name == NULL ||

Re: [PATCH V2 4/4] regulator: tps65090: add external control support for DCDC

2012-10-09 Thread Laxman Dewangan
On Tuesday 09 October 2012 04:41 PM, Venu Byravarasu wrote: On Tuesday 09 October 2012 03:32 PM, Laxman Dewangan wrote: On Tuesday 09 October 2012 04:03 PM, Venu Byravarasu wrote: +static struct regulator_ops tps65090_ext_control_ops = { +}; What is the purpose of adding empty structure? We

[PATCH 0/5] mfd: tps65910: use regmap irq framework for interrupt

2012-10-09 Thread Laxman Dewangan
, clock and then mfd devices. - Export the irq domain handle from regmap to use in mfd driver. - Pass the irq domain in mfd_add_devices to have proper interrupt mapping for sub devices like RTC. Laxman Dewangan (5): mfd: tps65910: use regmap irq framework for interrupt support mfd: tps65910: move

[PATCH 1/5] mfd: tps65910: use regmap irq framework for interrupt support

2012-10-09 Thread Laxman Dewangan
Implement irq support of tps65910 with regmap irq framework in place of implementing locally. This reduces the code size significantly and easy to maintain. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- drivers/mfd/tps65910-irq.c | 375

[PATCH 2/5] mfd: tps65910: move interrupt implementation code to mfd file

2012-10-09 Thread Laxman Dewangan
In place of implementing the irq support in separate file, moving implementation to main mfd file. The irq files only contains the table and init steps only and does not need extra file to have this only for this purpose. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- drivers/mfd

[PATCH 5/5] mfd: tps65910: pass irq_domain when adding mfd sub devices

2012-10-09 Thread Laxman Dewangan
When adding the sub device tps65910-rtc, is it passed the IO resource IRQ for the interrupt number. This interrupt needs to map in the device irq domain. Pass the irq domain of device in mfd_add_devices() so that proper irq mapping can be done when adding the sub device RTC. Signed-off-by: Laxman

[PATCH 4/5] regmap: add API to get irq_domain from regmap irq

2012-10-09 Thread Laxman Dewangan
to be mapped properly with device irq domain. The mfd_add_devices() creates mapping when adding sub devices and for this it is require to have irq domain. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- drivers/base/regmap/regmap-irq.c | 16 include/linux/regmap.h |1

[PATCH 3/5] mfd: tps65910: Initialize mfd devices after all initialization done

2012-10-09 Thread Laxman Dewangan
Add sub devices of tps65910 after all initialization like interrupt, clock etc. is done. This will make sure that require data gets initialized properly before sub devices probe's get called. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- drivers/mfd/tps65910.c | 18

[PATCH V2 0/5]mfd: tps65910: use regmap irq framework for interrupt

2012-10-10 Thread Laxman Dewangan
in the regmap. - Add empty line if paragraph change in description. Laxman Dewangan (5): mfd: tps65910: Initialize mfd devices after all initialization done mfd: tps65910: use regmap irq framework for interrupt support mfd: tps65910: move interrupt implementation code to mfd file regmap: add

[PATCH V2 5/5] mfd: tps65910: pass irq_domain when adding mfd sub devices

2012-10-10 Thread Laxman Dewangan
When adding the sub device tps65910-rtc, is it passed the IO resource IRQ for the interrupt number. This interrupt needs to map in the device irq domain. Pass the irq domain of device in mfd_add_devices() so that proper irq mapping can be done when adding the sub device RTC. Signed-off-by: Laxman

[PATCH V2 3/5] mfd: tps65910: move interrupt implementation code to mfd file

2012-10-10 Thread Laxman Dewangan
In place of implementing the irq support in separate file, moving implementation to main mfd file. The irq files only contains the table and init steps only and does not need extra file to have this only for this purpose. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com Reviewed-by: Mark Brown

  1   2   3   4   5   6   7   8   9   10   >