Use devm_gpiochip_add_data() for GPIO registration and clean the
error path.
Signed-off-by: Laxman Dewangan
---
drivers/gpio/gpio-pcf857x.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/gpio/gpio-pcf857x.c b/drivers/gpio/gpio-pcf857x.c
index 709cd3f
Use devm_gpiochip_add_data() for GPIO registration and clean the
error path.
Signed-off-by: Laxman Dewangan
---
drivers/gpio/gpio-mvebu.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
index a5eacc1..11c6582
Use devm_gpiochip_add_data() for GPIO registration and clean the
error path.
Signed-off-by: Laxman Dewangan
---
drivers/gpio/gpio-mxc.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
index 7fd21cb..1b342a3 100644
--- a
Use devm_gpiochip_add_data() for GPIO registration and remove the
need of driver callback .remove.
Signed-off-by: Laxman Dewangan
---
drivers/gpio/gpio-octeon.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/gpio/gpio-octeon.c b/drivers/gpio/gpio-octeon.c
Use devm_gpiochip_add_data() for GPIO registration.
Signed-off-by: Laxman Dewangan
---
drivers/gpio/gpio-pca953x.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index 23196c5..b7fe5d5 100644
--- a/drivers/gpio
Use devm_gpiochip_add_data() for GPIO registration and remove the
need of driver callback .remove.
Signed-off-by: Laxman Dewangan
---
drivers/gpio/gpio-mc9s08dz60.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/gpio/gpio-mc9s08dz60.c b/drivers/gpio
Use devm_gpiochip_add_data() for GPIO registration and remove the
need of driver callback .remove.
Signed-off-by: Laxman Dewangan
---
drivers/gpio/gpio-generic.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/gpio/gpio-generic.c b/drivers/gpio/gpio
Use devm_gpiochip_add_data() for GPIO registration.
Signed-off-by: Laxman Dewangan
---
drivers/gpio/gpio-iop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-iop.c b/drivers/gpio/gpio-iop.c
index fb65e58..860c535 100644
--- a/drivers/gpio/gpio-iop.c
+++ b
Use devm_gpiochip_add_data() for GPIO registration.
Signed-off-by: Laxman Dewangan
---
drivers/gpio/gpio-ep93xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c
index ad27907..d054219 100644
--- a/drivers/gpio/gpio
Use devm_gpiochip_add_data() for GPIO registration and remove the
need of driver callback .remove.
Signed-off-by: Laxman Dewangan
---
drivers/gpio/gpio-kempld.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/gpio/gpio-kempld.c b/drivers/gpio/gpio
Use devm_gpiochip_add_data() for GPIO registration and remove the
need of driver callback .remove.
Signed-off-by: Laxman Dewangan
Cc: Support Opensource
---
drivers/gpio/gpio-da9055.c | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/drivers/gpio/gpio-da9055
Use devm_gpiochip_add_data() for GPIO registration and remove the
need of driver callback .remove.
Signed-off-by: Laxman Dewangan
---
drivers/gpio/gpio-da9052.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/gpio/gpio-da9052.c b/drivers/gpio/gpio-da9052
Use devm_gpiochip_add_data() for GPIO registration.
Signed-off-by: Laxman Dewangan
---
drivers/gpio/gpio-dln2.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/gpio/gpio-dln2.c b/drivers/gpio/gpio-dln2.c
index e11a7d1..f7a60a4 100644
--- a/drivers
Use devm_gpiochip_add_data() for GPIO registration and remove the
need of driver callback .remove.
Signed-off-by: Laxman Dewangan
---
drivers/gpio/gpio-cs5535.c | 20 +---
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/drivers/gpio/gpio-cs5535.c b/drivers/gpio
On Tuesday 16 February 2016 04:48 AM, Linus Walleij wrote:
On Thu, Feb 11, 2016 at 12:56 PM, Laxman Dewangan wrote:
MAXIM Semiconductor's PMIC, MAX77620/MAX20024 has 8 GPIO
pins. It also supports interrupts from these pins.
Add GPIO driver for these pins to control via GPIO APIs.
S
On Tuesday 16 February 2016 09:30 PM, Thierry Reding wrote:
On Thu, Feb 11, 2016 at 05:26:26PM +0530, Laxman Dewangan wrote:
Add SW support for MAXIM Semiconductor's Power Management
IC (PMIC) MAX77620/MAX20024. This PMIC supports DC-DC/LDOS, GPIOs,
RTC, watchdog, clocks etc.
Hi Laxman,
On Tuesday 16 February 2016 08:33 PM, Linus Walleij wrote:
On Mon, Feb 15, 2016 at 2:17 PM, Laxman Dewangan wrote:
Add device managed APIs devm_gpiochip_add_data() and
devm_gpiochip_remove() for the APIs gpiochip_add_data()
and gpiochip_remove().
This helps in reducing code in error path
Add device managed APIs devm_gpiochip_add_data() and
devm_gpiochip_remove() for the APIs gpiochip_add_data()
and gpiochip_remove().
This helps in reducing code in error path and sometimes
removal of .remove callback for driver unbind.
Signed-off-by: Laxman Dewangan
---
drivers/gpio/gpiolib.c
On Friday 12 February 2016 07:06 PM, Rob Herring wrote:
On Wed, Jan 6, 2016 at 10:07 AM, Laxman Dewangan wrote:
Enhanced transient response (ETR) will affect the configuration of CKADV.
+-maxim,junction-temp-warning: Junction temp warning on which device generates
+ warning
Maxim Semiconductor's PMIC MAX77620/MAX20024 has multiple
DCDCs and LDOs.
Add DT binding document to support these regulators via
regulator framework.
Signed-off-by: Laxman Dewangan
Acked-by: Rob Herring
---
Changes from V4:
- Separate out from regulator driver
Changes from V6:
- Sta
MAXIM Semiconductor's PMIC, MAX77620/MAX20024 has 8 GPIO
pins. It also supports interrupts from these pins.
Add GPIO driver for these pins to control via GPIO APIs.
Signed-off-by: Laxman Dewangan
Reviewed-by: Linus Walleij
---
Changes from V1:
- Use the gpiochip_add_data and get the chip
APIs.
Signed-off-by: Laxman Dewangan
Signed-off-by: Mallikarjun Kasoju
Reviewed-by: Krzysztof Kozlowski
---
Changes form V1:
- Cleanup code based on comment received on mfd/rtc.
- Avoid duplication on error message.
Changes form V2:
- Run coccicheck and checkpatch in strict mode for the alig
the device.
Signed-off-by: Laxman Dewangan
Signed-off-by: Mallikarjun Kasoju
Reviewed-by: Krzysztof Kozlowski
---
Changes from V1:
- Code cleanups per review from V1.
- Move register acccess APIs from header to c file.
- Remove some of non required variable, remove duplication in error message
Maxim Semiconductor's PMIC MAX77620/MAX20024 has 8 GPIO pins
which act as GPIO as well as special function mode.
Add DT binding document to configure pins in function mode as
well as pin configuration parameters.
Signed-off-by: Laxman Dewangan
Acked-by: Rob Herring
---
Changes fr
d-off-by: Laxman Dewangan
Reviewed-by: Linus Walleij
---
Changes from V1:
- Cleanup code based on comment received on mfd/rtc.
- Avoid duplication on error message.
Changes form V2:
- Run coccicheck and checkpatch in strict mode for the alignment.
- update based on api changes from core.
Changes
The MAXIM PMIC MAX77620 and MAX20024 are power management IC
which supports RTC, GPIO, DCDC/LDO regulators, interrupt,
watchdog etc.
Add DT binding document for the different functionality of
this device.
Signed-off-by: Laxman Dewangan
Acked-by: Rob Herring
---
Changes from V1:
- Added units
Maxim Semiconductor's PMIC MAX77620/MAX20024 has 8 GPIO pins
which act as GPIO as well as special function mode.
Add DT binding document to support these pins in GPIO
mode via GPIO framework.
Signed-off-by: Laxman Dewangan
Acked-by: Rob Herring
---
Changes from V4:
- Separate out from
regulators sub node.
Changes from V7:
- Used mfd defines, better describe the FPS sequence properties.
Laxman Dewangan (8):
mfd: add device-tree binding doc for PMIC max77620/max20024
mfd: max77620: add core driver for MAX77620/MAX20024
pinctrl: add DT binding doc for pincontrol of PM
On Thursday 11 February 2016 02:56 PM, Lee Jones wrote:
On Wed, 10 Feb 2016, Laxman Dewangan wrote:
sleep: <0/1>
0: sleep mode disable,
1: sleep mode enable.
Ideally yes. This is obviously going to be used again.
However;
- My fear is that it will get co
On Thursday 11 February 2016 02:40 PM, Lee Jones wrote:
On Wed, 10 Feb 2016, Laxman Dewangan wrote:
On Wednesday 10 February 2016 09:08 PM, Lee Jones wrote:
mfd: Provide MACRO to declare commonly defined MFD cell attributes
Cc: Laxman Dewangan
Signed-off-by: Lee Jones
Build passed with
On Wednesday 10 February 2016 09:08 PM, Lee Jones wrote:
mfd: Provide MACRO to declare commonly defined MFD cell attributes
Cc: Laxman Dewangan
Signed-off-by: Lee Jones
Build passed with this patch when using it.
Acked-by: Laxman Dewangan
Please let me know if you applying this. I
On Wednesday 10 February 2016 06:53 PM, Lee Jones wrote:
On Tue, 09 Feb 2016, Laxman Dewangan wrote:
On Tuesday 09 February 2016 09:12 PM, Lee Jones wrote:
On Sat, 30 Jan 2016, Laxman Dewangan wrote:
+ Normal mode also called as active mode on which all step-down
On Tuesday 09 February 2016 07:57 PM, Lee Jones wrote:
Cc: Laxman Dewangan
Signed-off-by: Lee Jones
---
include/linux/mfd/core.h | 32
1 file changed, 32 insertions(+)
diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h
index 27dac3f..dacdc49
ce there is less code on this path.
Signed-off-by: Laxman Dewangan
---
drivers/base/regmap/regmap-irq.c | 82
include/linux/regmap.h | 8
2 files changed, 90 insertions(+)
diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regma
On Tuesday 09 February 2016 09:12 PM, Lee Jones wrote:
On Sat, 30 Jan 2016, Laxman Dewangan wrote:
+ Normal mode also called as active mode on which all step-down
+ regulators, all linear regulators, GPIOs, and the 32kHz
+ oscillator are in normal active mode
Laxman Dewangan (5):
rtc: max77686: fix checkpatch error
rtc: max77686: use rtc regmap to access RTC registers
rtc: max77686: avoid reference of parent device info multiple places
mfd: max77686: do not set i2c client data for rtc i2c client
rtc: max77686: move initialisation of rtc regmap
Fix following check patch error in rtc-max77686 driver:
- Alignment should match open parenthesis.
- braces {} should be used on all arms of this statement.
- Prefer using the BIT macro
Signed-off-by: Laxman Dewangan
CC: Krzysztof Kozlowski
CC: Javier Martinez Canillas
Tested-by: Krzysztof
data for rtc i2c client.
Suggested-by: Krzysztof Kozlowski
Signed-off-by: Laxman Dewangan
CC: Krzysztof Kozlowski
CC: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
Tested-by: Javier Martinez Canillas
Reviewed-by: Javier Martinez Canillas
---
This is new in this series based on
Get rid of referring parent device info for register access
all the places by making regmap as part of max77686 rtc
device info. This will also remove the need of storing parent
device info in max77686 rtc device info as this is no more required.
Signed-off-by: Laxman Dewangan
CC: Krzysztof
rtc_regmap should be used to access all RTC registers instead
of parent regmap regardless of what chip or property have it.
This makes the register access uniform and extendible for other
chips.
Signed-off-by: Laxman Dewangan
CC: Krzysztof Kozlowski
CC: Javier Martinez Canillas
Tested-by
PMIC/devices from Maxim Semiconductor if they kept same RTC IP on
different PMIC. Some of examples as PMIC MAX77620, MAX20024 where
same RTC IP used and hence driver for these chips will use this
driver only for RTC support.
Suggested-by: Krzysztof Kozlowski
Signed-off-by: Laxman Dewangan
CC
On Tuesday 09 February 2016 07:57 PM, Lee Jones wrote:
+
+#define MFD_CELL_NAME(_name) \
+ { \
+ MFD_CELL_ALL(_name, NULL, NULL, 0, NULL, NULL) \
+ }
+
str
On Tuesday 09 February 2016 08:44 PM, Mark Brown wrote:
* PGP Signed by an unknown key
On Tue, Feb 09, 2016 at 10:27:22AM -0300, Javier Martinez Canillas wrote:
I believe this patch could be picked separately and not made part of
this series since is fixing a bug that happens on most drivers
Hi Mark,
I have taken care of all your previous comment on this patch.
Can you please review?
I got the macro from Lee's and spinning the V8 of this series so if
there is any thing, I can take care on my next version.
Thanks,
Laxman
On Saturday 30 January 2016 10:08 PM, Laxman Dew
On Tuesday 09 February 2016 06:57 PM, Javier Martinez Canillas wrote:
Hello Laxman,
On 02/09/2016 09:28 AM, Laxman Dewangan wrote:
It is require to dispose all virtual irq of hwirq on chip
created on given irq domain before removing this irq domain.
Hence dispose all mapped irqs before
rtc_regmap should be used to access all RTC registers instead
of parent regmap regardless of what chip or property have it.
This makes the register access uniform and extendible for other
chips.
Signed-off-by: Laxman Dewangan
CC: Krzysztof Kozlowski
CC: Javier Martinez Canillas
Tested-by
PMIC/devices from Maxim Semiconductor if they kept same RTC IP on
different PMIC. Some of examples as PMIC MAX77620, MAX20024 where
same RTC IP used and hence driver for these chips will use this
driver only for RTC support.
Suggested-by: Krzysztof Kozlowski
Signed-off-by: Laxman Dewangan
CC
Get rid of referring parent device info for register access
all the places by making regmap as part of max77686 rtc
device info. This will also remove the need of storing parent
device info in max77686 rtc device info as this is no more required.
Signed-off-by: Laxman Dewangan
CC: Krzysztof
data for rtc i2c client.
Suggested-by: Krzysztof Kozlowski
Signed-off-by: Laxman Dewangan
CC: Krzysztof Kozlowski
CC: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
Tested-by: Javier Martinez Canillas
Reviewed-by: Javier Martinez Canillas
---
This is new in this series based on
Fix following check patch error in rtc-max77686 driver:
- Alignment should match open parenthesis.
- braces {} should be used on all arms of this statement.
- Prefer using the BIT macro
Signed-off-by: Laxman Dewangan
CC: Krzysztof Kozlowski
CC: Javier Martinez Canillas
Tested-by: Krzysztof
suspend-resume after unbind/bind by unmapping virq in remove callback.
Changes from V5:
- Abandon the addition of new API in regmap-irq and add dispose of virq
in regmap_del_irq_chip().
Laxman Dewangan (6):
regmap: irq: dispose all virtual irq before removing domain
rtc: max77686: fix
It is require to dispose all virtual irq of hwirq on chip
created on given irq domain before removing this irq domain.
Hence dispose all mapped irqs before deleting the irq domains
in regmap_del_irq_chip();
Signed-off-by: Laxman Dewangan
---
This is new in series. Earlier patch for adding APIs
On Tuesday 09 February 2016 04:57 PM, Mark Brown wrote:
* PGP Signed by an unknown key
On Tue, Feb 09, 2016 at 02:38:28PM +0530, Laxman Dewangan wrote:
On Tuesday 09 February 2016 10:46 AM, Laxman Dewangan wrote:
Do we need to dispose all virtual irq in regmap_del_irq_chip() before
actually
On Tuesday 09 February 2016 10:46 AM, Laxman Dewangan wrote:
On Monday 08 February 2016 11:49 PM, Mark Brown wrote:
* PGP Signed by an unknown key
On Mon, Feb 08, 2016 at 10:26:20PM +0530, Laxman Dewangan wrote:
So fix need to go in the irq_domain_remove() to unamp before actually
On Monday 08 February 2016 11:49 PM, Mark Brown wrote:
* PGP Signed by an unknown key
On Mon, Feb 08, 2016 at 10:26:20PM +0530, Laxman Dewangan wrote:
So fix need to go in the irq_domain_remove() to unamp before actually
destroying the irq domain?
That's one option, but you could al
Adding Thomas in the discussion.
On Monday 08 February 2016 10:29 PM, Mark Brown wrote:
* PGP Signed by an unknown key
On Mon, Feb 08, 2016 at 10:08:28PM +0530, Laxman Dewangan wrote:
On Monday 08 February 2016 08:25 PM, Mark Brown wrote:
On Sat, Feb 06, 2016 at 08:07:22PM +0530, Laxman
On Monday 08 February 2016 08:25 PM, Mark Brown wrote:
* PGP Signed by an unknown key
On Sat, Feb 06, 2016 at 08:07:22PM +0530, Laxman Dewangan wrote:
Before removing irq domains, it is require to unmap all
mapped interrupt from that domain. Currently there is API
to map the interrupt on
Use for_each_available_child_of_node() for iterating over each
available child instead of iterating over each child and then
checking their status.
Signed-off-by: Laxman Dewangan
---
drivers/thermal/of-thermal.c | 18 +++---
1 file changed, 3 insertions(+), 15 deletions(-)
diff
device framework.
2. No need to release the i2c_client in error/remove path and hence
there is less code requirement.
Signed-off-by: Laxman Dewangan
---
drivers/i2c/i2c-core.c | 70 ++
include/linux/i2c.h| 6 +
2 files changed, 76
PMIC/devices from Maxim Semiconductor if they kept same RTC IP on
different PMIC. Some of examples as PMIC MAX77620, MAX20024 where
same RTC IP used and hence driver for these chips will use this
driver only for RTC support.
Suggested-by: Krzysztof Kozlowski
Signed-off-by: Laxman Dewangan
CC
On Saturday 06 February 2016 08:07 PM, Laxman Dewangan wrote:
- ret = devm_request_threaded_irq(&pdev->dev, info->virq, NULL,
- max77686_rtc_alarm_irq, 0,
- "rtc-alarm1", info);
- if (
Fix following check patch error in rtc-max77686 driver:
- Alignment should match open parenthesis.
- braces {} should be used on all arms of this statement.
- Prefer using the BIT macro
Signed-off-by: Laxman Dewangan
CC: Krzysztof Kozlowski
CC: Javier Martinez Canillas
Tested-by: Krzysztof
PMIC/devices from Maxim Semiconductor if they kept same RTC IP on
different PMIC. Some of examples as PMIC MAX77620, MAX20024 where
same RTC IP used and hence driver for these chips will use this
driver only for RTC support.
Suggested-by: Krzysztof Kozlowski
Signed-off-by: Laxman Dewangan
CC
rtc_regmap should be used to access all RTC registers instead
of parent regmap regardless of what chip or property have it.
This makes the register access uniform and extendible for other
chips.
Signed-off-by: Laxman Dewangan
CC: Krzysztof Kozlowski
CC: Javier Martinez Canillas
Tested-by
Before removing irq domains, it is require to unmap all
mapped interrupt from that domain. Currently there is API
to map the interrupt on chip as regmap_irq_get_virq() for
creating mapping. Add equivalent API to dispose the mapped
irq in irq domains.
Signed-off-by: Laxman Dewangan
CC: Krzysztof
Get rid of referring parent device info for register access
all the places by making regmap as part of max77686 rtc
device info. This will also remove the need of storing parent
device info in max77686 rtc device info as this is no more required.
Signed-off-by: Laxman Dewangan
CC: Krzysztof
data for rtc i2c client.
Suggested-by: Krzysztof Kozlowski
Signed-off-by: Laxman Dewangan
CC: Krzysztof Kozlowski
CC: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
Tested-by: Javier Martinez Canillas
Reviewed-by: Javier Martinez Canillas
---
This is new in this series based on
suspend-resume after unbind/bind by unmapping virq in remove callback.
Laxman Dewangan (6):
regmap: irq: add apis to unmap the mapped irq
rtc: max77686: fix checkpatch error
rtc: max77686: use rtc regmap to access RTC registers
rtc: max77686: avoid reference of parent device info multiple
On Saturday 06 February 2016 06:31 PM, Javier Martinez Canillas wrote:
Hello Laxman,
On 02/06/2016 03:29 AM, Laxman Dewangan wrote:
So the issue is that when we create mapping, we can not delete the
irq_chip.
I saw one function from irq framework irq_dispose_mapping(unsigned
int virq
Hi Javier,
'
On Saturday 06 February 2016 11:00 AM, Javier Martinez Canillas wrote:
Hello Laxman,
Sorry for not doing this before but today was a busy one.
Thanks for testing.
On 02/05/2016 11:37 AM, Laxman Dewangan wrote:
Hi Krzysztof, Javier,
3. Extension of
Hi Krzysztof, Javier,
On Thursday 04 February 2016 02:38 PM, Krzysztof Kozlowski wrote:
On 04.02.2016 15:58, Krzysztof Kozlowski wrote:
3. Can you try locally to not use devm_regmap_init_i2c() and just use
the regmap_init_i2c() and proper removal of this from error path and
remove callback?
I'
On Thursday 04 February 2016 02:38 PM, Krzysztof Kozlowski wrote:
On 04.02.2016 15:58, Krzysztof Kozlowski wrote:
On 04.02.2016 11:03, Laxman Dewangan wrote:
3. Can you try locally to not use devm_regmap_init_i2c() and just use
the regmap_init_i2c() and proper removal of this from error path
Hi Javier,
On Thursday 04 February 2016 07:33 AM, Laxman Dewangan wrote:
On Thursday 04 February 2016 05:40 AM, Krzysztof Kozlowski wrote:
On 03.02.2016 22:47, Laxman Dewangan wrote:
Changes from V2:
- Taken care of missed sequence for removing the resource.
- Fix the crash when doing
On Thursday 04 February 2016 05:40 AM, Krzysztof Kozlowski wrote:
On 03.02.2016 22:47, Laxman Dewangan wrote:
Changes from V2:
- Taken care of missed sequence for removing the resource.
- Fix the crash when doing unbind by using requested_threaded_irq()
instead of
which we got from V1.
- Remove changes from Kconfig.
- Maintain all register definition in max77686 private header and remove
the movement to rtc driver.
- Taken care of all comments on V1 from Krzysztof and Javier.
Changes from V2:
- Fix the issue of crash in unbind.
Laxman Dewangan (5):
rtc
Fix following check patch error in rtc-max77686 driver:
- Alignment should match open parenthesis.
- braces {} should be used on all arms of this statement.
- Prefer using the BIT macro
Signed-off-by: Laxman Dewangan
CC: Krzysztof Kozlowski
CC: Javier Martinez Canillas
Tested-by: Krzysztof
PMIC/devices from Maxim Semiconductor if they kept same RTC IP on
different PMIC. Some of examples as PMIC MAX77620, MAX20024 where
same RTC IP used and hence driver for these chips will use this
driver only for RTC support.
Suggested-by: Krzysztof Kozlowski
Signed-off-by: Laxman Dewangan
CC
Get rid of referring parent device info for register access
all the places by making regmap as part of max77686 rtc
device info. This will also remove the need of storing parent
device info in max77686 rtc device info as this is no more required.
Signed-off-by: Laxman Dewangan
CC: Krzysztof
data for rtc i2c client.
Suggested-by: Krzysztof Kozlowski
Signed-off-by: Laxman Dewangan
CC: Krzysztof Kozlowski
CC: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
Reviewed-by: Javier Martinez Canillas
---
This is new in this series based on review comment from V1.
Changes from
rtc_regmap should be used to access all RTC registers instead
of parent regmap regardless of what chip or property have it.
This makes the register access uniform and extendible for other
chips.
Signed-off-by: Laxman Dewangan
CC: Krzysztof Kozlowski
CC: Javier Martinez Canillas
Tested-by
On Wednesday 03 February 2016 04:52 PM, Krzysztof Kozlowski wrote:
On 03.02.2016 19:45, Krzysztof Kozlowski wrote:
On 03.02.2016 18:30, Laxman Dewangan wrote:
err_rtc:
+ if (info->rtc)
+ i2c_unregister_device(info->rtc);
+ regmap_del_irq_chip(info->rtc_
Get rid of referring parent device info for register access
all the places by making regmap as part of max77686 rtc
device info. This will also remove the need of storing parent
device info in max77686 rtc device info as this is no more required.
Signed-off-by: Laxman Dewangan
CC: Krzysztof
Fix following check patch error in rtc-max77686 driver:
- Alignment should match open parenthesis.
- braces {} should be used on all arms of this statement.
- Prefer using the BIT macro
Signed-off-by: Laxman Dewangan
CC: Krzysztof Kozlowski
CC: Javier Martinez Canillas
Tested-by: Krzysztof
rtc_regmap should be used to access all RTC registers instead
of parent regmap regardless of what chip or property have it.
This makes the register access uniform and extendible for other
chips.
Signed-off-by: Laxman Dewangan
CC: Krzysztof Kozlowski
CC: Javier Martinez Canillas
Tested-by
PMIC/devices from Maxim Semiconductor if they kept same RTC IP on
different PMIC. Some of examples as PMIC MAX77620, MAX20024 where
same RTC IP used and hence driver for these chips will use this
driver only for RTC support.
Suggested-by: Krzysztof Kozlowski
Signed-off-by: Laxman Dewangan
CC
: Krzysztof Kozlowski
Signed-off-by: Laxman Dewangan
CC: Krzysztof Kozlowski
CC: Javier Martinez Canillas
---
This is new in this series based on review comment from V1.
drivers/mfd/max77686.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
index
tag which we got from V1.
- Remove changes from Kconfig.
- Maintain all register definition in max77686 private header and remove
the movement to rtc driver.
- Taken care of all comments on V1 from Krzysztof and Javier.
Laxman Dewangan (5):
rtc: max77686: fix checkpatch error
rtc: max77686: use
Fix following check patch error in rtc-max77686 driver:
- Alignment should match open parenthesis.
- braces {} should be used on all arms of this statement.
- Prefer using the BIT macro
Signed-off-by: Laxman Dewangan
---
drivers/rtc/rtc-max77686.c | 25 +
1 file changed
Get rid of referring parent device info for register access
all the places by making regmap as part of max77686 rtc
device info. This will also remove the need of storing parent
device info in max77686 rtc device info as this is no more required.
Signed-off-by: Laxman Dewangan
---
drivers/rtc
the rtc-max77686 as independent driver from its
parent. Required information is passed through the device parent
which is generic and does not depends on any max77686 specific
header ifnromation.
CC: Krzysztof Mazur
CC: Javier Martinez Canillas
Laxman Dewangan (4):
rtc: max77686: fix
rtc_regmap should be used to access all RTC regsiters instead
of parent regmap regardless of what chip or property have it.
This makes the register access uniform and extendible for other
chips.
Signed-off-by: Laxman Dewangan
CC: Krzysztof Kozlowski
CC: Javier Martinez Canillas
---
drivers
To make RTC block of MAX77686/MAX77802 as independent driver,
move the registeration of i2c device, regmap for register access
and irq_chip for interrupt support inside the RTC driver.
Removed the same initialisation from mfd driver.
Signed-off-by: Laxman Dewangan
CC: Krzysztof Mazur
CC: Javier
On Monday 01 February 2016 02:32 PM, Lee Jones wrote:
On Mon, 01 Feb 2016, Laxman Dewangan wrote:
On Monday 01 February 2016 01:55 PM, Lee Jones wrote:
On Sat, 30 Jan 2016, Laxman Dewangan wrote:
This depends on patch
[PATCH V2] mfd: core: add macro for adding mfd cells
and due to absence
On Monday 01 February 2016 02:29 PM, Lee Jones wrote:
On Fri, 29 Jan 2016, Laxman Dewangan wrote:
Thanks Lee for review.
I will take care of most of stuff on next version of patch.
However, I have some query form your comment.
On Friday 29 January 2016 02:36 PM, Lee Jones wrote:
On Thu, 28
On Monday 01 February 2016 01:55 PM, Lee Jones wrote:
On Sat, 30 Jan 2016, Laxman Dewangan wrote:
This depends on patch
[PATCH V2] mfd: core: add macro for adding mfd cells
and due to absence of this patch, it reports the error.
If you have dependencies, why aren't they in this set?
-20160129]
[if your patch is applied to the wrong git tree, please drop us a note to help
improving the system]
url:
https://github.com/0day-ci/linux/commits/Laxman-Dewangan/Add-support-for-MAXIM-MAX77620-MAX20024-PMIC/20160131-005355
base:
https://git.kernel.org/pub/scm/linux/kernel/git
the device.
Signed-off-by: Laxman Dewangan
Signed-off-by: Mallikarjun Kasoju
Reviewed-by: Krzysztof Kozlowski
---
Changes from V1:
- Code cleanups per review from V1.
- Move register acccess APIs from header to c file.
- Remove some of non required variable, remove duplication in error message
Maxim Semiconductor's PMIC MAX77620/MAX20024 has multiple
DCDCs and LDOs.
Add DT binding document to support these regulators via
regulator framework.
Signed-off-by: Laxman Dewangan
Acked-by: Rob Herring
---
Changes from V4:
- Separate out from regulator driver
Changes from V6:
- Sta
APIs.
Signed-off-by: Laxman Dewangan
Signed-off-by: Mallikarjun Kasoju
Reviewed-by: Krzysztof Kozlowski
---
- Cleanup code based on comment received on mfd/rtc.
- Avoid duplication on error message.
Changes form V2:
- Run coccicheck and checkpatch in strict mode for the alignment.
- Ref
d-off-by: Laxman Dewangan
Reviewed-by: Linus Walleij
---
Changes from V1:
- Cleanup code based on comment received on mfd/rtc.
- Avoid duplication on error message.
Changes form V2:
- Run coccicheck and checkpatch in strict mode for the alignment.
- update based on api changes from core.
Changes
701 - 800 of 1816 matches
Mail list logo
