Hi Greg,
On 2013/5/17 8:34, Greg KH wrote:
> On Thu, May 09, 2013 at 12:58:11PM +0800, Libo Chen wrote:
>> From: Libo Chen
>>
>> When usb_create_hcd fail, we should call gxio_usb_host_destroy
>>
>> Signed-off-by: Libo Chen
>> ---
>> drivers/usb/
On 2013/5/15 19:55, Sergei Shtylyov wrote:
> Hello.
>
> On 15-05-2013 5:35, Libo Chen wrote:
>
>> when omap_get_control_dev fail, we should release relational platform_device
>
>s/fail/fails/, s/relational/related/?
>
>> Signed-off-by: Libo Chen
>
without this patch, gdrom_major will leak when gd.cd_info alloc faild
Signed-off-by: Libo Chen
---
drivers/cdrom/gdrom.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c
index 4afcb65..5980cb9 100644
--- a/drivers/cdrom
when gptu_r32 fail, we should put clk before return
Signed-off-by: Libo Chen
---
arch/mips/lantiq/xway/gptu.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/mips/lantiq/xway/gptu.c b/arch/mips/lantiq/xway/gptu.c
index 9861c86..4fa577c 100644
--- a/arch/mips
Add missing unregister tis_drv after register pdev fail
Signed-off-by: Libo Chen
---
drivers/char/tpm/tpm_tis.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index 8a41b6b..d5b0af4 100644
--- a/drivers
From: libo.c...@huawei.com
Sorry, I am not sure who this patch should be send to.
Libo Chen (2):
msm: iommu: add missing platform_device_unregister() in err case
msm: iommu: no need kfree before kzalloc successful
drivers/iommu/msm_iommu_dev.c | 8 +---
1 file changed, 5 insertions
From: libo.c...@huawei.com
We have registered msm_iommu_driver first, and need unregister it when
registered msm_iommu_ctx_driver fail
Signed-off-by: Libo Chen
---
drivers/iommu/msm_iommu_dev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iommu/msm_iommu_dev.c b/drivers/iommu
From: libo.c...@huawei.com
We don`t need to kfree drvdata before kzalloc successful
Signed-off-by: Libo Chen
---
drivers/iommu/msm_iommu_dev.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/iommu/msm_iommu_dev.c b/drivers/iommu/msm_iommu_dev.c
index 4351a2d
fix two wrong mem release
Libo Chen (2):
i2c: i2c-bfin-twi:don`t free peripheral before it`s init successful
i2c: pxa: no need release_mem_region before request_mem_region
successful
drivers/i2c/busses/i2c-bfin-twi.c |2 +-
drivers/i2c/busses/i2c-pxa.c |5 +++--
2 files
move release_mem_region above kfree(i2c) && below clk_put(i2c->clk)
Signed-off-by: Libo Chen
---
drivers/i2c/busses/i2c-pxa.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
index ea6d45d..318
down out_error_no_irq. When platform_get_irq fail, no need to free peripheral
Signed-off-by: Libo Chen
---
drivers/i2c/busses/i2c-bfin-twi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/busses/i2c-bfin-twi.c
b/drivers/i2c/busses/i2c-bfin-twi.c
index
ore
> info for symbol without prompts").
It works!
Tested-by: Libo Chen
>
> Reported-by: Borislav Petkov
> Signed-off-by: Li Zefan
> ---
> scripts/kconfig/menu.c | 16 ++--
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --gi
On 2013/5/7 10:59, Gu Zheng wrote:
> Hi libo,
>
> On 05/06/2013 09:11 PM, Libo Chen wrote:
>
>>
>> move release_mem_region above kfree(i2c) && below clk_put(i2c->clk)
>>
>> Signed-off-by: Libo Chen
>> ---
>> drivers/i2c/busses/i2c
fix four goto wrong tag, avoid memleak
Libo Chen (4):
usb: ehci-s5p: fix memleak when fallback to pdata
usb: isp1760-if: fix memleak when platform_get_resource fail
usb: ohci: fix goto wrong tag in err case
usb: tilegx: fix memleak when create hcd fail
drivers/usb/host/ehci-s5p.c
From: Libo Chen
When usb_create_hcd fail, we should call gxio_usb_host_destroy
Signed-off-by: Libo Chen
---
drivers/usb/host/ohci-tilegx.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ohci-tilegx.c b/drivers/usb/host/ohci-tilegx.c
index
From: Libo Chen
When platform_get_resource fail, we should release_mem_region
Signed-off-by: Libo Chen
---
drivers/usb/host/isp1760-if.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/isp1760-if.c b/drivers/usb/host/isp1760-if.c
index bbb791b
From: Libo Chen
When devm_usb_get_phy fail, we should free hcd
Signed-off-by: Libo Chen
---
drivers/usb/host/ehci-s5p.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/host/ehci-s5p.c b/drivers/usb/host/ehci-s5p.c
index 6357752..3fbab58 100644
From: Libo Chen
fix goto wrong tag in usb_hcd_nxp_probe
Signed-off-by: Libo Chen
---
drivers/usb/host/ohci-nxp.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c
index f4988fb..eb294a9 100644
fix goto wrong tag in usb_hcd_nxp_probe
Signed-off-by: Libo Chen
---
drivers/usb/host/ohci-nxp.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c
index f4988fb..eb294a9 100644
--- a/drivers/usb/host
When devm_usb_get_phy fail, we should free hcd
Signed-off-by: Libo Chen
---
drivers/usb/host/ehci-s5p.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/host/ehci-s5p.c b/drivers/usb/host/ehci-s5p.c
index 6357752..3fbab58 100644
--- a/drivers/usb/host/ehci
When platform_get_resource fail, we should release_mem_region
Signed-off-by: Libo Chen
---
drivers/usb/host/isp1760-if.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/isp1760-if.c b/drivers/usb/host/isp1760-if.c
index bbb791b..a13709e 100644
change address from "Libo Chen " to "Libo Chen
"
fix four goto wrong tag, avoid memleak
Libo Chen (4):
usb: ehci-s5p: fix memleak when devm_usb_get_phy fail
usb: isp1760-if: fix memleak when platform_get_resource fail
usb: ohci: fix goto wrong tag in err case
usb:
When usb_create_hcd fail, we should call gxio_usb_host_destroy
Signed-off-by: Libo Chen
---
drivers/usb/host/ohci-tilegx.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ohci-tilegx.c b/drivers/usb/host/ohci-tilegx.c
index 1ae7b28..5888fc4 100644
fix two wrong mem release
* Changelog from v1:
* exchange out_error_no_irq and out_error_pin_mux suggested by Sonic
* add some new tag , make code cleanly
Libo Chen (2):
i2c: i2c-bfin-twi: don`t free peripheral before it init successful
i2c: pxa: no need release_mem_region before
When kzalloc fail, there is no reason to release_mem_region
fix confuse tag, add new tag: emem, eirq, edt and make it cleanly
Signed-off-by: Libo Chen
---
drivers/i2c/busses/i2c-pxa.c | 13 -
1 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c
down out_error_no_irq. When platform_get_irq fail, no need to free peripheral
Signed-off-by: Libo Chen
---
drivers/i2c/busses/i2c-bfin-twi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/busses/i2c-bfin-twi.c
b/drivers/i2c/busses/i2c-bfin-twi.c
index
On 2013/5/9 16:33, Zhang, Sonic wrote:
> Hi Libo,
>
>> -Original Message-----
>> From: Libo Chen [mailto:libo.c...@huawei.com]
>> Sent: Thursday, May 09, 2013 4:27 PM
>> To: Zhang, Sonic; w...@the-dreams.de
>> Cc: uclinux-dist-de...@blackfin.uclin
On 2013/5/10 2:02, Chris Metcalf wrote:
> On 5/9/2013 2:08 AM, Libo Chen wrote:
>> When usb_create_hcd fail, we should call gxio_usb_host_destroy
>>
>> Signed-off-by: Libo Chen
>> ---
>> drivers/usb/host/ohci-tilegx.c |7 +--
>> 1 file
On 2013/5/10 9:09, Libo Chen wrote:
> On 2013/5/10 2:02, Chris Metcalf wrote:
>> On 5/9/2013 2:08 AM, Libo Chen wrote:
>>> When usb_create_hcd fail, we should call gxio_usb_host_destroy
>>>
>>> Signed-off-by: Libo Chen
>>> ---
>>> driv
fix goto wrong tag in usb_hcd_nxp_probe
* Changelog from v1:
* instead of all these statement labels suggested by Alan Stern
Signed-off-by: Libo Chen
---
drivers/usb/host/ohci-nxp.c | 46 +-
1 files changed, 23 insertions(+), 23 deletions(-)
diff
From: Libo Chen
set the owner of platform_driver, to ensure that the
caller of driver holds a module refernece
Signed-off-by: Libo Chen
---
drivers/usb/host/ehci-fsl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
index 3be3df2
From: Libo Chen
currently, when clk_get(NULL,"usb-device") fail, it does not
disable && put usb_bus_clock. It is incorrect.
this patch use new interface devm_xxx instead of xxx then
we no need to care about cleanup resource in err case that is boring
and reduce code size.
S
于 2013-5-11 18:15, Tomasz Figa 写道:
Hi Libo,
On Saturday 11 of May 2013 14:28:15 Libo Chen wrote:
>From: Libo Chen
The patch subject is slightly misleading. It suggests that the patch only
changes clock handling, but in fact the biggest part of the patch is
conversion to devm_ helpers.
On 2014/1/3 13:34, David Miller wrote:
> From: Libo Chen
> Date: Fri, 3 Jan 2014 11:11:04 +0800
>
>>
>> introduce backup_classid to struct skbuff,
>> we can use it to backup sk_classid when net_ns switch.
>>
>> Signed-off-by: Libo Chen
&g
On 2014/2/7 13:46, James Bottomley wrote:
> On Fri, 2014-02-07 at 09:22 +0900, Eiichi Tsukata wrote:
>> Currently, scsi error handling in scsi_io_completion() tries to
>> unconditionally requeue scsi command when device keeps some error state.
>> For example, UNIT_ATTENTION causes infinite retry
if skb->sk is NULL, we can try to restore from skb->bk_classid,
because we may have saved it.
Signed-off-by: Libo Chen
---
net/sched/cls_cgroup.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/net/sched/cls_cgroup.c b/net/sched/cls_cgroup.c
index d228a5d..6
it can save classid from skb->sk->sk_classid
to skb->bk_classid
Signed-off-by: Libo Chen
---
include/net/cls_cgroup.h | 11 +++
net/sched/cls_cgroup.c | 1 -
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/include/net/cls_cgroup.h b/include/net/cls_cgrou
introduce backup_classid to struct skbuff,
we can use it to backup sk_classid when net_ns switch.
Signed-off-by: Libo Chen
---
include/linux/skbuff.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index c5cd016..b76e871 100644
dev_forward_skb will clear skb->sk, so we need save classid
before that, otherwise the skb can not be under control by
net_cls.
Signed-off-by: Libo Chen
---
drivers/net/veth.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index 2ec2
()
in veth_xmit().
so I add backup_classid in struct sk_buffer to save classid
before dev_forward_skb(). In cls_cgroup_classify(), if skb->sk
is NULL, we can try to restore classid form skb->bk_classid.
Libo Chen (4):
net: introduce bk_classid to struct sk_buff
cls_cgroup: introduce a
On 2014/1/3 18:45, Sergei Shtylyov wrote:
> Hello.
>
> On 03-01-2014 7:11, Libo Chen wrote:
>
>> dev_forward_skb will clear skb->sk, so we need save classid
>> before that, otherwise the skb can not be under control by
>> net_cls.
>
>> Signed-off-by:
On 2014/1/3 13:20, Cong Wang wrote:
> On Thu, Jan 2, 2014 at 7:11 PM, Libo Chen wrote:
>> Hi guys,
>>
>> Now, lxc created with veth can not be under control by
>> cls_cgroup.
>>
>> the former discussion:
>> http://lkml.indiana.edu/hypermail/linux/ker
On 2014/1/3 14:21, John Fastabend wrote:
> On 01/02/2014 09:34 PM, David Miller wrote:
>> From: Libo Chen
>> Date: Fri, 3 Jan 2014 11:11:04 +0800
>>
>>>
>>> introduce backup_classid to struct skbuff,
>>> we can use it to backup sk_classid when
yes
On 2014/1/6 16:42, Gao feng wrote:
> On 01/06/2014 03:54 PM, Libo Chen wrote:
>> On 2014/1/3 13:20, Cong Wang wrote:
>>> On Thu, Jan 2, 2014 at 7:11 PM, Libo Chen
>>> wrote:
>>>> Hi guys,
>>>>
>>>> Now, lx
On 2013/6/18 7:30, Samuel Ortiz wrote:
> Hi Libo,
>
>
> On Mon, May 27, 2013 at 10:28:56AM +0800, Libo Chen wrote:
>> use module_pci_driver instead of init/exit, make code clean.
>>
>> Signed-off-by: Libo Chen
>> ---
>> drivers/mfd/lpc_ich.c |
I found a lot of mistakes using struct platform_driver without owner
so I make a macro instead of the function platform_driver_register.
It can set owner in it, then guys don`t care about module owner again.
Signed-off-by: Libo Chen
---
drivers/base/platform.c |8 +---
include
use module_pci_driver instead of init/exit, make code clean.
Signed-off-by: Libo Chen
---
drivers/scsi/dmx3191d.c | 13 +
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/drivers/scsi/dmx3191d.c b/drivers/scsi/dmx3191d.c
old mode 100644
new mode 100755
index 4b0dd8c
use module_pci_driver instead of init/exit, make code clean.
Signed-off-by: Libo Chen
---
drivers/pci/ioapic.c | 13 +
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/drivers/pci/ioapic.c b/drivers/pci/ioapic.c
index 3c6bbdd..1b90579 100644
--- a/drivers/pci
use module_pci_driver instead of init/exit, make code clean.
Signed-off-by: Libo Chen
---
drivers/memstick/host/r592.c | 13 +
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/drivers/memstick/host/r592.c b/drivers/memstick/host/r592.c
index 9718661..1b6e913 100644
use module_pci_driver instead of init/exit, make code clean.
Signed-off-by: Libo Chen
---
drivers/ide/delkin_cb.c | 13 +
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/drivers/ide/delkin_cb.c b/drivers/ide/delkin_cb.c
index 7e27d32..300daab 100644
--- a/drivers
use module_pci_driver instead of init/exit, make code clean.
Signed-off-by: Libo Chen
---
drivers/scsi/mvumi.c | 20 +---
1 files changed, 1 insertions(+), 19 deletions(-)
diff --git a/drivers/scsi/mvumi.c b/drivers/scsi/mvumi.c
old mode 100644
new mode 100755
index c3601b5
use module_pci_driver instead of init/exit, make code clean.
---
drivers/scsi/a100u2w.c | 12 +---
1 files changed, 1 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/a100u2w.c b/drivers/scsi/a100u2w.c
old mode 100644
new mode 100755
index 0163457..db3710f
---
use module_pci_driver instead of init/exit, make code clean.
Signed-off-by: Libo Chen
---
drivers/net/irda/donauboe.c | 15 +--
1 files changed, 1 insertions(+), 14 deletions(-)
diff --git a/drivers/net/irda/donauboe.c b/drivers/net/irda/donauboe.c
old mode 100644
new mode 100755
use module_pci_driver instead of init/exit, make code clean.
Signed-off-by: Libo Chen
---
drivers/scsi/initio.c | 13 +
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c
old mode 100644
new mode 100755
index 280d5af
use module_pci_driver instead of init/exit, make code clean
Signed-off-by: Libo Chen
---
drivers/ptp/ptp_pch.c | 18 +-
1 files changed, 1 insertions(+), 17 deletions(-)
diff --git a/drivers/ptp/ptp_pch.c b/drivers/ptp/ptp_pch.c
index bea9451..e63ca00 100644
--- a/drivers/ptp
use module_pci_driver instead of init/exit, make code clean.
Signed-off-by: Libo Chen
---
drivers/mfd/lpc_ich.c | 13 +
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
index 9f12f91..06431df 100644
--- a/drivers/mfd
use module_pci_driver instead of init/exit, make code clean
Signed-off-by: Libo Chen
---
drivers/media/pci/mantis/mantis_cards.c | 13 +
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/drivers/media/pci/mantis/mantis_cards.c
b/drivers/media/pci/mantis
use module_pci_driver instead of init/exit, make code clean.
Signed-off-by: Libo Chen
---
drivers/platform/x86/intel_ips.c | 13 +
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c
index 5051aa9
use module_pci_driver instead of init/exit, make code clean.
Signed-off-by: Libo Chen
---
drivers/media/pci/pluto2/pluto2.c | 13 +
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/drivers/media/pci/pluto2/pluto2.c
b/drivers/media/pci/pluto2/pluto2.c
index 2290fae
use module_pci_driver instead of init/exit, make code clean.
Signed-off-by: Libo Chen
---
drivers/pcmcia/pd6729.c | 13 +
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/drivers/pcmcia/pd6729.c b/drivers/pcmcia/pd6729.c
index b29d97e..9a7fc88 100644
--- a/drivers
use module_pci_driver instead of init/exit, make code clean.
Signed-off-by: Libo Chen
---
drivers/pcmcia/yenta_socket.c | 16 +---
1 files changed, 1 insertions(+), 15 deletions(-)
diff --git a/drivers/pcmcia/yenta_socket.c b/drivers/pcmcia/yenta_socket.c
index 6b4ff09..dc18a3a
use module_pci_driver instead of init/exit, make code clean
Signed-off-by: Libo Chen
---
drivers/media/radio/radio-maxiradio.c | 13 +
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/drivers/media/radio/radio-maxiradio.c
b/drivers/media/radio/radio-maxiradio.c
use module_pci_driver instead of init/exit, make code clean.
Signed-off-by: Libo Chen
---
drivers/media/pci/b2c2/flexcop-pci.c | 13 +
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/drivers/media/pci/b2c2/flexcop-pci.c
b/drivers/media/pci/b2c2/flexcop-pci.c
index
use module_pci_driver instead of init/exit, make code clean.
Signed-off-by: Libo Chen
---
drivers/media/pci/pt1/pt1.c | 15 +--
1 files changed, 1 insertions(+), 14 deletions(-)
diff --git a/drivers/media/pci/pt1/pt1.c b/drivers/media/pci/pt1/pt1.c
index e921108..75ce142 100644
use module_pci_driver instead of init/exit, make code clean.
Signed-off-by: Libo Chen
---
drivers/memstick/host/jmb38x_ms.c | 13 +
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/drivers/memstick/host/jmb38x_ms.c
b/drivers/memstick/host/jmb38x_ms.c
index c37d375
use module_pci_driver instead of init/exit, make code clean.
Signed-off-by: Libo Chen
---
drivers/atm/he.c | 13 +
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/drivers/atm/he.c b/drivers/atm/he.c
index 507362a..80f9743 100644
--- a/drivers/atm/he.c
+++ b/drivers
use module_pci_driver instead of init/exit, make code clean.
Signed-off-by: Libo Chen
---
drivers/uwb/whci.c | 13 +
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/drivers/uwb/whci.c b/drivers/uwb/whci.c
index f48093e..deeeba4 100644
--- a/drivers/uwb/whci.c
+++ b
use module_pci_driver instead of init/exit, make code clean.
Signed-off-by: Libo Chen
---
drivers/media/pci/mantis/hopper_cards.c | 13 +
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/drivers/media/pci/mantis/hopper_cards.c
b/drivers/media/pci/mantis
use module_pci_driver instead of init/exit, make code clean.
Signed-off-by: Libo Chen
---
drivers/media/pci/dm1105/dm1105.c | 13 +
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/drivers/media/pci/dm1105/dm1105.c
b/drivers/media/pci/dm1105/dm1105.c
index 026767b
sorry, only 24!
On 2013/5/27 10:28, Libo Chen wrote:
> use module_pci_driver instead of init/exit, make code clean.
>
> Libo Chen (25):
> drivers/scsi/a100u2w: Convert to module_pci_driver replace init/exit
> drivers/scsi/dc395x: Convert to module_pci_driver
> dri
use module_pci_driver instead of init/exit, make code clean.
Signed-off-by: Libo Chen
---
drivers/scsi/dc395x.c | 24 +---
1 files changed, 1 insertions(+), 23 deletions(-)
diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
old mode 100644
new mode 100755
index
use module_pci_driver instead of init/exit, make code clean.
Signed-off-by: Libo Chen
---
drivers/scsi/a100u2w.c | 12 +---
1 files changed, 1 insertions(+), 11 deletions(-)
* add "Signed-off-by: Libo Chen "
diff --git a/drivers/scsi/a100u2w.c b/drivers/scsi/a100u2w.
On 2013/5/27 14:38, James Bottomley wrote:
> On Mon, 2013-05-27 at 10:28 +0800, Libo Chen wrote:
>> use module_pci_driver instead of init/exit, make code clean.
>
> For the ancient drivers, like this, the principal is that we really
> don't touch except for tested bug fixes. Fo
thanks for your review. I will update later.
Libo
On 2013/5/24 11:19, Sachin Kamat wrote:
> On 23 May 2013 17:30, Libo Chen wrote:
>> peripheral_request_list has got free if any one faild, so no need to free
>> again in err case.
>> aovid this, convert them to devm_*
On 2013/5/25 20:22, Greg KH wrote:
> On Sat, May 25, 2013 at 12:40:50PM +0800, Libo Chen wrote:
>>
>> I found a lot of mistakes using struct platform_driver without owner
>> so I make a macro instead of the function platform_driver_register.
>> It can set owner in it,
On 2013/5/28 20:27, Joerg Roedel wrote:
> On Wed, May 22, 2013 at 01:58:39PM +0800, Libo Chen wrote:
>>>
>>> This patch merge two patch that I sended before:
>>> 1. msm: iommu: add missing platform_device_unregister() in err case
>>> 2. msm: iommu:
ping...
On 2013/5/22 11:51, Libo Chen wrote:
>
> mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its
> member.
>
> Signed-off-by: Libo Chen
> Acked-by: Rafał Miłecki
> ---
> drivers/mtd/devices/bcm47xxsflash.c | 2 +-
> 1 file changed,
ping...
On 2013/5/22 11:30, Libo Chen wrote:
>
> when omap_get_control_dev faild, we should release related platform_device
>
> * Changelog from v1:
> * fix spell: s/fail/fails/, s/relational/related/ , thank Sergei
>
>
> Signed-off-by: Libo Chen
> ---
>
On 2013/5/28 23:34, Andy Shevchenko wrote:
> No go.
>
> Check the 4b7e450fb5cefb5865c77999a675330206ab3b8a
> And update you tree, please.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
It had been changed :(
Thanks,
Libo
--
To unsubscribe from this list: send the line "unsubscribe
when platform_driver_register broken, we should unregister ucc_uart_driver
Signed-off-by: Libo chen
---
drivers/tty/serial/ucc_uart.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c
index 7355303..f86f447
On 2013/5/28 23:29, Andy Shevchenko wrote:
> This is good fix, but I rather prefer not to see it in this shape.
> See comments below.
>
> On Wed, May 22, 2013 at 6:51 AM, Libo Chen
> wrote:
>>
>> mtd is just member of bcm47xxsflash, so we should free bcm47x
On 2013/5/29 1:40, Sergei Shtylyov wrote:
> Hello.
>
> On 22-05-2013 7:30, Libo Chen wrote:
>
>> when omap_get_control_dev faild, we should release related platform_device
>
>> * Changelog from v1:
>> * fix spell: s/fail/fails/, s/relational/related/ , t
On 2013/5/29 23:03, Tomas Henzl wrote:
> On 05/24/2013 11:40 AM, Libo Chen wrote:
>> we should check kzalloc, avoid to hit oops
>>
>> Signed-off-by: Libo Chen
>> ---
>> drivers/scsi/megaraid.c |4
>> 1 files changed, 4 insertions(+), 0 deletions(-)
mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its
member.
So I use devm_kazlloc instead of kazlloc to avoid it.
* Changelog:
convert to devm_kzalloc
Signed-off-by: Libo chen
Suggested-by: Andy Shevchenko
---
drivers/mtd/devices/bcm47xxsflash.c | 16
convert to module_platform_driver instead of init/exit
Suggested-by: Andy Shevchenko
Signed-off-by: Libo chen
---
drivers/mtd/devices/bcm47xxsflash.c | 20 +---
1 files changed, 1 insertions(+), 19 deletions(-)
diff --git a/drivers/mtd/devices/bcm47xxsflash.c
b/drivers/mtd
On 2013/5/30 9:38, Libo Chen wrote:
> On 2013/5/29 23:03, Tomas Henzl wrote:
>> On 05/24/2013 11:40 AM, Libo Chen wrote:
>>> we should check kzalloc, avoid to hit oops
>>>
>>> Signed-off-by: Libo Chen
>>> ---
>>> drivers/scsi/megaraid.
On 2013/5/29 17:33, Gu Zheng wrote:
>>From 4d4caa16f3886ae910ad6dfe13353fc836f546cc Mon Sep 17 00:00:00 2001
> From: Gu Zheng
> Date: Wed, 29 May 2013 17:34:22 +0900
> Subject: [PATCH] driver/scsi: Introduce a help function local_time_seconds()
> to simplify the getting time stamp operation
>
we should check kzalloc, avoid to hit oops
Change from v1:
- put kzalloc outside of mutex
Signed-off-by: Libo Chen
---
drivers/scsi/megaraid.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
index 846f475
On 2013/6/4 20:14, Tomas Henzl wrote:
> On 06/04/2013 11:33 AM, Libo Chen wrote:
>> we should check kzalloc, avoid to hit oops
>>
>> Change from v1:
>> - put kzalloc outside of mutex
>>
>> Signed-off-by: Libo Chen
>
> Your patch looks fine to me:
于 2013-5-17 17:43, Wolfram Sang 写道:
On Thu, May 09, 2013 at 04:27:22PM +0800, Libo Chen wrote:
>fix two wrong mem release
>
>* Changelog from v1:
> * exchange out_error_no_irq and out_error_pin_mux suggested by
Sonic
> * add some new tag , make code cleanly
Thanks for th
"repost with Jens Axboe added" suggest by Tejun Heo
without this patch, gdrom_major will leak when gd.cd_info alloc faild
Signed-off-by: Libo Chen
---
drivers/cdrom/gdrom.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/cdrom/gdrom.c b/dri
1. fix two visible mistakes:
* when load_scm_model_init faild, we should call
platform_device_del(msipf_device)
* msipf_attribute_group should be remove in err case
2. change some tags, give them real meaning.
Signed-off-by: Libo Chen
---
drivers/platform/x86/msi-laptop.c | 24
fix memleak or invalite point acesss about x86 platform drivers
Libo Chen (3):
x86: msi-laptop: fix memleak
x86: asus-laptop: fix invalid point access
x86 platform drivers: fix gpio leak
drivers/platform/x86/asus-laptop.c | 1 -
drivers/platform/x86/intel_pmic_gpio.c | 5
when request_irq faild, we should release gpiochip
Signed-off-by: Libo Chen
---
drivers/platform/x86/intel_pmic_gpio.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
mode change 100644 => 100755 drivers/platform/x86/intel_pmic_gpio.c
diff --git a/drivers/platform/
asus->name is null or point to const string,so it is not suitable to kfree it.
Signed-off-by: Libo Chen
---
drivers/platform/x86/asus-laptop.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/asus-laptop.c
b/drivers/platform/x86/asus-laptop.c
index 0eea09c..8e26
set the owner of platform_driver, to ensure that the
caller of driver holds a module refernece
Signed-off-by: Libo Chen
---
drivers/usb/renesas_usbhs/common.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/renesas_usbhs/common.c
b/drivers/usb/renesas_usbhs
set the owner of platform_driver, to ensure that the
caller of driver holds a module refernece
Signed-off-by: Libo Chen
---
drivers/net/ethernet/natsemi/xtsonic.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/natsemi/xtsonic.c
b/drivers/net
set the owner of platform_driver, to ensure that the
caller of driver holds a module refernece
Signed-off-by: Libo Chen
---
drivers/usb/dwc3/core.c|1 +
drivers/usb/dwc3/dwc3-exynos.c |1 +
drivers/usb/dwc3/dwc3-omap.c |1 +
3 files changed, 3 insertions(+), 0 deletions
set the owner of platform_driver, to ensure that the
caller of driver holds a module refernece
Signed-off-by: Libo Chen
---
drivers/usb/gadget/r8a66597-udc.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/gadget/r8a66597-udc.c
b/drivers/usb/gadget/r8a66597
set the owner of platform_driver, to ensure that the
caller of driver holds a module refernece
Signed-off-by: Libo Chen
---
drivers/net/wan/ixp4xx_hss.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wan/ixp4xx_hss.c b/drivers/net/wan/ixp4xx_hss.c
index
301 - 400 of 468 matches
Mail list logo
