by:
bridge: disable snooping if there is no querier (b00589af3b04)
Reported-by: Paul Bolle pebo...@tiscali.nl
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
net/bridge/br_multicast.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/br_multicast.c b/net/bridge
Response Delay of the querier is added to
give multicast responses enough time to arrive and to be learned from
before disabling the flooding behaviour again.
Signed-off-by: Linus Lüssing linus.luess...@web.de
Looks good, applied, thanks Linus.
0) This patch is part of v3.11-rc4
On Mon, Aug 05, 2013 at 03:42:22PM -0700, Stephen Hemminger wrote:
On Tue, 6 Aug 2013 00:32:05 +0200
Linus Lüssing linus.luess...@web.de wrote:
Currently we are reading an uninitialized value for the max_delay
variable when snooping an MLD query message of invalid length and would
of the querier is added to
give multicast responses enough time to arrive and to be learned from
before disabling the flooding behaviour again.
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
net/bridge/br_device.c|3 ++-
net/bridge/br_input.c |3 ++-
net/bridge/br_multicast.c | 41
of the querier is added to
give multicast responses enough time to arrive and to be learned from
before disabling the flooding behaviour again.
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
v2: added missing, empty br_multicast_querier_exists() to avoid
build failures if CONFIG_BRIDGE_IGMP_SNOOPING
On Thu, Jul 25, 2013 at 09:01:40AM -0700, Stephen Hemminger wrote:
On Thu, 25 Jul 2013 15:56:20 +0200
Linus Lüssing linus.luess...@web.de wrote:
+static void br_multicast_update_querier_timer(struct net_bridge *br,
+ unsigned long max_delay
On Fri, Jul 26, 2013 at 11:19:00PM +0100, Adam Baker wrote:
On 25/07/13 14:56, Linus Lüssing wrote:
If there is no querier on a link then we won't get periodic reports and
therefore won't be able to learn about multicast listeners behind ports,
potentially leading to lost multicast packets
by using separate timers for the snooped IGMP and MLD queries
as well as separate timers for our internal IGMP and MLD queriers.
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
net/bridge/br_device.c|2 +-
net/bridge/br_input.c |2 +-
net/bridge/br_mdb.c | 14 +-
net
(bridge: Only flood unregistered groups
to routers) did for IPv4, let's do the same for IPv6 with the same
reasoning.
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
net/bridge/br_multicast.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/net/bridge
of the querier is added to
give multicast responses enough time to arrive and to be learned from
before disabling the flooding behaviour again.
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
v3: changed type of multicast_querier_delay_time from
atomic64_t to unsigned long
v2: added missing, empty
9f00b2e7cf241fa389733d41b615efdaa2cb0f5b.
---
CC: Cong Wang amw...@redhat.com
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
net/bridge/br_mdb.c |2 +-
net/bridge/br_multicast.c | 47 ++---
net/bridge/br_private.h |1 -
3 files changed, 28
about these listeners.
Reported-by: Jan Stancek jstan...@redhat.com
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
net/bridge/br_multicast.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index ef66365..fb0e36f 100644
On Tue, Mar 04, 2014 at 10:06:14AM +0100, Hannes Frederic Sowa wrote:
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index ef66365..fb0e36f 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -1235,6 +1235,12 @@ static int
for multicast traffic as the
bridge did not learn about these listeners.
Reported-by: Jan Stancek jstan...@redhat.com
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
net/bridge/br_multicast.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/net/bridge/br_multicast.c b/net
traffic as the bridge did not learn
about these listeners.
With this patch the snooping code is enabled upon receiving valid,
general queries only.
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
net/bridge/br_multicast.c |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff
for multicast traffic as the
bridge did not learn about these listeners.
Reported-by: Jan Stancek jstan...@redhat.com
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
v2: simplified is_general_query variable assignment (thanks Cong!)
net/bridge/br_multicast.c | 19 +++
1 file
traffic as the bridge did not learn
about these listeners.
With this patch the snooping code is enabled upon receiving valid,
general queries only.
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
v2: unchanged
net/bridge/br_multicast.c |8 +---
1 file changed, 5 insertions(+), 3
On Mon, Mar 10, 2014 at 11:56:00PM +0100, Hannes Frederic Sowa wrote:
On Mon, Mar 10, 2014 at 10:25:25PM +0100, Linus Lüssing wrote:
br_multicast_query_received(br, port, br-ip6_querier,
- !ipv6_addr_any(ip6h-saddr), max_delay
)
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
net/bridge/br_multicast.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index 81f2389..d6448e3 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge
The multicast snooping code should have matured enough to be safely
applicable to IPv6 link-local multicast addresses (excluding the
link-local all nodes address, ff02::1), too.
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
net/bridge/br_mdb.c |3 ++-
net/bridge/br_multicast.c
(bridge: Only flood unregistered groups
to routers) did for IPv4, let's do the same for IPv6 with the same
reasoning.
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
net/bridge/br_multicast.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/net/bridge
Hi,
Here are two, small feature changes I would like to submit to increase
the usefulness of the multicast snooping of the bridge code.
The first patch is an unaltered one I had submitted before, but since it
got no feedback I'm resubmitting it here for net-next. With the recently
added patch to
by using separate timers for the snooped IGMP and MLD queries
as well as separate timers for our internal IGMP and MLD queriers.
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
net/bridge/br_device.c|2 +-
net/bridge/br_input.c |2 +-
net/bridge/br_mdb.c | 14 ++-
net
Hi,
When trying to perform a forceful unload of an ipv6 kernel module
on a 3.10 kernel then I'm getting a kernel panic with the attached
trace.
Is this supposed to happen due to the '-f' option or is this a bug
in the ipv6 code?
Cheers, Linus
-
[ 279.909335] Bridge firewalling registered
Hi Herbert,
Were there any reasons I might not be aware of which prevented you
from adding the same change you introduced in
bridge: Only flood unregistered groups to routers for IPv6, too?
If not and if no one else comes up with any objection, then I'd
still be happy if this patch could find
On Thu, Jun 05, 2014 at 12:43:11AM -0700, David Miller wrote:
From: Linus Lüssing linus.luess...@web.de
Date: Mon, 2 Jun 2014 20:42:15 +0200
Changes in v3:
* use EXPORT_SYMBOL_GPL() instead of EXPORT_SYMBOL()
This is not a sufficient header posting.
You must also describe
the
struct bridge_mcast_querier but for storing information about the
selected querier (no matter if our own or a foreign querier).
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
net/bridge/br_mdb.c |4 +-
net/bridge/br_multicast.c | 169
Adding bridge support to the batman-adv multicast optimization requires
batman-adv knowing about the existence of bridged-in IGMP/MLD queriers
to be able to reliably serve any multicast listener behind this same
bridge.
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
include/linux
net_device itself.
Adding bridge support to the batman-adv multicast optimization requires
batman-adv knowing about the existence of bridged-in multicast
listeners to be able to reliably serve them with multicast packets.
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
include/linux
the currently selected one. This slight optimization is
supposed to make it more RFC compliant (but is rather uncritical and
therefore probably not necessary to be queued for stable kernels).
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
net/bridge/br_multicast.c | 101
The first patch is simply a cosmetic patch. So far I (and maybe others
too?) have been regularly confusing these two structs, therefore I'd
suggest renaming them and therefore making the follow-up patches easier
to understand and nicer to fit in.
The second patch fixes a minor issue, but probably
-by: Linus Lüssing linus.luess...@web.de
---
net/bridge/br_multicast.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index cd3cf39..876e5fb 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -1373,6 +1373,8 @@ static
)
Reported-by: kbuild test robot fengguang...@intel.com
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
net/bridge/br_multicast.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index 876e5fb..abfa0b65 100644
--- a/net/bridge
Once my last patchset got applied, I got slapped by an automatic smatch
and build bot. Here are two patches fixing the according issues, a potential
null pointer dereference and a compile error when compiling without IPv6.
[PATCH 1/2] is probably not the ideal solution - the assignment of the
net_device itself.
Adding bridge support to the batman-adv multicast optimization requires
batman-adv knowing about the existence of bridged-in multicast
listeners to be able to reliably serve them with multicast packets.
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
include/linux
Hi,
The first patch is simply a cosmetic patch. So far I (and maybe others
too?) have been regularly confusing these two structs, therefore I'd
suggest renaming them and therefore making the follow-up patches easier
to understand and nicer to fit in.
The second patch fixes a minor issue, but
the currently selected one. This slight optimization is
supposed to make it more RFC compliant (but is rather uncritical and
therefore probably not necessary to be queued for stable kernels).
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
net/bridge/br_multicast.c | 101
the
struct bridge_mcast_querier but for storing information about the
selected querier (no matter if our own or a foreign querier).
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
net/bridge/br_mdb.c |4 +-
net/bridge/br_multicast.c | 169
Adding bridge support to the batman-adv multicast optimization requires
batman-adv knowing about the existence of bridged-in IGMP/MLD queriers
to be able to reliably serve any multicast listener behind this same
bridge.
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
include/linux
net_device itself.
Adding bridge support to the batman-adv multicast optimization requires
batman-adv knowing about the existence of bridged-in multicast
listeners to be able to reliably serve them with multicast packets.
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
include/linux
the
struct bridge_mcast_querier but for storing information about the
selected querier (no matter if our own or a foreign querier).
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
net/bridge/br_mdb.c |4 +-
net/bridge/br_multicast.c | 169
Adding bridge support to the batman-adv multicast optimization requires
batman-adv knowing about the existence of bridged-in IGMP/MLD queriers
to be able to reliably serve any multicast listener behind this same
bridge.
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
include/linux
Changes in v2:
* fix a nasty typo in PATCH 1/4, br_multicast_update_query_timer():
br-multicast_query_interval vs. br-multicast_querier_interval
= this accidentally reduced the other querier present timer
from 255 to 125 seconds
* fix a typo in PATCH 2/4, br_ip{4,6}_multicast_query():
the currently selected one. This slight optimization is
supposed to make it more RFC compliant (but is rather uncritical and
therefore probably not necessary to be queued for stable kernels).
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
net/bridge/br_multicast.c | 101
net_device itself.
Adding bridge support to the batman-adv multicast optimization requires
batman-adv knowing about the existence of bridged-in multicast
listeners to be able to reliably serve them with multicast packets.
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
include/linux
the
struct bridge_mcast_querier but for storing information about the
selected querier (no matter if our own or a foreign querier).
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
net/bridge/br_mdb.c |4 +-
net/bridge/br_multicast.c | 169
Adding bridge support to the batman-adv multicast optimization requires
batman-adv knowing about the existence of bridged-in IGMP/MLD queriers
to be able to reliably serve any multicast listener behind this same
bridge.
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
include/linux
the currently selected one. This slight optimization is
supposed to make it more RFC compliant (but is rather uncritical and
therefore probably not necessary to be queued for stable kernels).
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
net/bridge/br_multicast.c | 101
Changes in v3:
* use EXPORT_SYMBOL_GPL() instead of EXPORT_SYMBOL()
Cheers
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
On Wed, Apr 23, 2014 at 02:47:48PM -0400, David Miller wrote:
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -1282,8 +1282,7 @@ static int br_ip6_multicast_query(struct net_bridge
*br,
goto out;
}
- br_multicast_query_received(br, port,
-by: Hannes Frederic Sowa han...@stressinduktion.org
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
net/bridge/br_multicast.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index 7b757b5..d2c3aae 100644
--- a/net
Hi,
Some people pointed out to me that it might be helpful to add stubs for
the newly added multicast exports. That way e.g. batman-adv should continue
to be compile and useable without having to have a kernel compiled
with bridge code in the future. This is what the first patch is supposed
to
in the
future.
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
include/linux/if_bridge.h |6 ++
net/bridge/br_multicast.c | 37 +
2 files changed, 43 insertions(+)
diff --git a/include/linux/if_bridge.h b/include/linux/if_bridge.h
index e0c575c
To make users (e.g. batman-adv soon) load- and runnable even if the
bridge was compiled without snooping capabilities - or even if the
kernel was compiled without any bridge code at all.
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
include/linux/if_bridge.h | 14 ++
1
::0001, \
IPv6 priority=0x0, Next Header=0
Signed-off-by: Linus Lüssing linus.luess...@web.de
---
net/bridge/br_multicast.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index 7751c92..9d02e6c 100644
On Mon, Sep 22, 2014 at 01:32:44AM +0200, Linus Lüssing wrote:
Ebtables on the OUTPUT chain (NF_BR_LOCAL_OUT) would not work as expected
for both locally generated IGMP and MLD queries. The IP header specific
filter options are off by 14 Bytes for netfilter (actual output on
interfaces is fine
On Mon, Nov 03, 2014 at 06:01:46AM +0800, Herbert Xu wrote:
On Mon, Sep 22, 2014 at 01:32:44AM +0200, Linus Lüssing wrote:
Signed-off-by: Linus Lüssing linus.luess...@web.de
Acked-by: Herbert Xu herb...@gondor.apana.org.au
Hi David,
are there any unanswered questions left?
Cheers, Linus
On Tue, Feb 10, 2015 at 04:59:09PM +0300, Vasily Averin wrote:
I'm trying to fix ICMPv6 processing broken in OpenVZ after rebase to last
RHEL6u6 kernel.
After some unclear manipulation bridge begins to forward icmp6 NS (fe02::1)
into wrong port,
and at present I do not found the reason of
Hi Vasily,
On Tue, Feb 10, 2015 at 11:44:29AM +0300, Vasily Averin wrote:
This patch prevent forwarding of ICMPv6 in bridges,
so containers/VMs with virtual eth adapters connected in local bridge cannot
ping each other via ipv6 (but can do it via ipv4)
If a host wants to receive packets,
messages is now only done if necessary, just like the
IGMP part always did).
Finally, these IGMP and MLD message validation functions are exported so
that not only the bridge can use it but batman-adv later, too.
Signed-off-by: Linus Lüssing linus.luess...@c0d3.blue
---
include/linux/igmp.h |1
Let's use these new, neat helpers.
Signed-off-by: Linus Lüssing linus.luess...@c0d3.blue
---
net/bridge/br_multicast.c | 28
1 file changed, 4 insertions(+), 24 deletions(-)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index 4b6722f..b52f4cb
The multicast optimizations in batman-adv are yet only usable and
enabled in non-bridged scenarios. To be able to support bridged setups
batman-adv needs to be able to detect IGMP/MLD queriers and reports on
mesh nodes without bridges, too. See the following link for details:
The multicast optimizations in batman-adv are yet only usable and
enabled in non-bridged scenarios. To be able to support bridged setups
batman-adv needs to be able to detect IGMP/MLD queriers and reports on
mesh nodes without bridges, too. See the following link for details:
messages is now only done if necessary, just like the
IGMP part always did).
Finally, these IGMP and MLD message validation functions are exported so
that not only the bridge can use it but batman-adv later, too.
Signed-off-by: Linus Lüssing linus.luess...@c0d3.blue
---
include/linux/igmp.h |1
Let's use these new, neat helpers.
Signed-off-by: Linus Lüssing linus.luess...@c0d3.blue
---
net/bridge/br_multicast.c | 28
1 file changed, 4 insertions(+), 24 deletions(-)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index 4b6722f..b52f4cb
)
Reported-by: kbuild test robot fengguang...@intel.com
Signed-off-by: Linus Lüssing linus.luess...@c0d3.blue
---
net/core/skbuff.c |2 +-
net/ipv6/mcast_snoop.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 1e4278a
On Fri, Apr 10, 2015 at 07:46:39PM +0200, Linus Lüssing wrote:
diff --git a/net/ipv6/mcast_snoop.c b/net/ipv6/mcast_snoop.c
new file mode 100644
index 000..95b34c0
--- /dev/null
+++ b/net/ipv6/mcast_snoop.c
@@ -0,0 +1,198 @@
+/* Copyright (C) 2015: Linus Lüssing linus.luess...@c0d3.blue
even if the according bridge (port) is down, just like other
other bridge (port) attributes allow too.
Signed-off-by: Linus Lüssing linus.luess...@c0d3.blue
---
I'm currently a little unsure about a few things (that's why I'm sending
this as an RFC):
* For i=br_multicast_init(), e
.
But since br_multicast_init() doesn't start any timers and only sets
default values and initializes timers it should be save to reconfigure
the default values after that, before things actually get active after
the bridge is set up.
Signed-off-by: Linus Lüssing linus.luess...@c0d3.blue
---
Changelog v3
On Thu, May 21, 2015 at 11:49:21AM +0800, Herbert Xu wrote:
The timer operations are all supposed to be idempotent. So enabling
a port twice or stopping it twice should be OK.
Oki doki.
* Might calls to br_multicast_add_router() via br_multicast_enable_port()
cause unintended
even if the according bridge (port) is down, just like other
other bridge (port) attributes allow too.
Signed-off-by: Linus Lüssing linus.luess...@c0d3.blue
---
Changelog:
* [RFC PATCH net-next] - [PATCH net-next]
net/bridge/br_multicast.c | 15 ++-
1 file changed, 2 insertions
.
But since br_multicast_init() doesn't start any timers and only sets
default values and initializes timers it should be save to reconfigure
the default values after that, before things actually get active after
the bridge is set up.
Signed-off-by: Linus Lüssing linus.luess...@c0d3.blue
---
Changelog v2
of ipv6_mc_check_mld() / ip_mc_check_igmp() now needs to
additionally check whether the returned skb_trimmed is a clone.
Fixes: 9afd85c9e455 (net: Export IGMP/MLD message validation code)
Reported-by: Brenden Blanco bbla...@plumgrid.com
Signed-off-by: Linus Lüssing linus.luess...@c0d3.blue
---
net
Powalowski <tobias.powalow...@googlemail.com>
Tested-by: Tobias Powalowski <tobias.powalow...@googlemail.com>
Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue>
---
net/bridge/br_multicast.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/bridge/br_multicast.c
Hi Greg,
On Thu, Oct 01, 2015 at 11:31:51AM +0200, Greg Kroah-Hartman wrote:
> 4.1-stable review patch. If anyone has any objections, please let me know.
[...]
> Fixes: 9afd85c9e455 ("net: Export IGMP/MLD message validation code")
While it shouldn't(tm) break anything on 4.1, there's no need to
On Mon, Jun 13, 2016 at 07:36:37PM +0100, Ben Hutchings wrote:
> 3.16.36-rc1 review patch. If anyone has any objections, please let me know.
>
Hi Ben,
This one looks weird. The version you added for 3.2.81-rc1 looked
better.
Cheers, Linus
> --
>
> From
ddress assinged to the bridge
> and returns a false state for the local querier in
> __br_multicast_querier_exists().
Acked-by: Linus Lüssing <linus.luess...@c0d3.blue>
On Fri, Jun 24, 2016 at 12:35:18PM +0200, Daniel Danzberger wrote:
> The bridge is falsly dropping ipv6 mulitcast packets if there is:
> 1. No ipv6 address assigned on the brigde.
> 2. No external mld querier present.
> 3. The internal querier enabled.
>
> When the bridge fails to build mld
lticast_rcv+0x5dc/0xd00)
[ 44.060077] [<803b2c98>] (br_multicast_rcv) from [<803aa510>]
(br_handle_frame_finish+0xac/0x51c)
[...]
Fixes: 9afd85c9e455 ("net: Export IGMP/MLD message validation code")
Reported-by: Álvaro Fernández Rojas <nolt...@gmail.com>
Signed-off-by: Linus
lticast_rcv+0x5dc/0xd00)
[ 44.060077] [<803b2c98>] (br_multicast_rcv) from [<803aa510>]
(br_handle_frame_finish+0xac/0x51c)
[...]
Fixes: 9afd85c9e455 ("net: Export IGMP/MLD message validation code")
Reported-by: Álvaro Fernández Rojas <nolt...@gmail.com>
Signed-off-by: Lin
On Thu, Feb 18, 2016 at 01:51:34PM +0100, Steinar H. Gunderson wrote:
> On Mon, Feb 15, 2016 at 03:07:06AM +0100, Linus Lüssing wrote:
> > Steinar, can you check whether this fixes the bridge issues you reported on
> > bugzilla #99081? Not quite sure whether it is the same as your
sh+0xac/0x51c)
[...]
Fixes: 9afd85c9e455 ("net: Export IGMP/MLD message validation code")
Reported-by: Álvaro Fernández Rojas <nolt...@gmail.com>
Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue>
---
Steinar, can you check whether this fixes the bridge issues you reporte
this by taking the offset between IP and IGMP/MLD header into
account, too.
Fixes: 9afd85c9e455 ("net: Export IGMP/MLD message validation code")
Reported-by: Simon Wunderlich <s...@simonwunderlich.de>
Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue>
---
net/bridge
this by taking the offset between IP and IGMP/MLD header into
account, too.
Fixes: 9afd85c9e455 ("net: Export IGMP/MLD message validation code")
Reported-by: Simon Wunderlich <s...@simonwunderlich.de>
Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue>
---
v2: changed "i
On Tue, May 03, 2016 at 01:26:23PM -0700, Stephen Hemminger wrote:
> On Tue, 3 May 2016 22:18:54 +0200
> Linus Lüssing <linus.luess...@c0d3.blue> wrote:
>
> > diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
> > index 03661d9..7105cdf 100644
> >
On Tue, Jun 28, 2016 at 08:04:42AM -0400, David Miller wrote:
> From: Linus Lüssing <linus.luess...@c0d3.blue>
> [...]
> > Fixes: 1d81d4c3dd88 ("bridge: check return value of ipv6_dev_get_saddr()")
>
> You're missing an initial 'd' in that SHA1-ID.
>
>
For one thing, summarizes all non-umlaut versions into the umlaut one
(Linus Luessing -> Linus Lüssing).
For another, maps obosolete email addresses to the current @c0d3.blue
one.
Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue>
---
.mailmap | 2 ++
1 file changed, 2 insertions
tch fixes this by always resending MLD reports when an interface
change happens, for instance from NO-CARRIER to CARRIER state.
Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue>
---
Initial problem report was sent to the bridge mailing list a while ago:
- https://lists.linuxfounda
kau <n...@nbd.name>
[linus.luess...@c0d3.blue: various bug + style fixes, commit message]
Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue>
---
This feature is used and enabled by default in OpenWRT and LEDE for AP
interfaces for more than a year now to allow both a more robust
On Wed, Feb 15, 2017 at 10:41:34PM +, Ben Hutchings wrote:
> 3.2.85-rc1 review patch. If anyone has any objections, please let me know.
>
> --
>
> From: Linus Lüssing <linus.luess...@c0d3.blue>
>
> commit 9799c50372b23ed774791bdb87d700f
.@c0d3.blue: various bug + style fixes, commit message]
Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue>
---
This feature is used and enabled by default in OpenWRT and LEDE for AP
interfaces for more than a year now to allow both a more robust multicast
delivery and multicast at highe
kau <n...@nbd.name>
[linus.luess...@c0d3.blue: various bug + style fixes, commit message]
Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue>
---
This feature is used and enabled by default in OpenWRT and LEDE for AP
interfaces for more than a year now to allow both a more robust
kau <n...@nbd.name>
[linus.luess...@c0d3.blue: various bug + style fixes, commit message]
Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue>
---
This feature is used and enabled by default in OpenWRT and LEDE for AP
interfaces for more than a year now to allow both a more robust
This allows modules using this function (currently: batman-adv) to
compile even if cfg80211 is not built at all, thus relaxing
dependencies.
Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue>
---
include/net/cfg80211.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/inclu
On Mon, Oct 17, 2016 at 11:39:04AM +0200, Johannes Berg wrote:
> On Mon, 2016-10-17 at 00:39 +0200, Linus Lüssing wrote:
> > For mac80211_hwsim interfaces, suggest to use wpa_supplicant with the
> > more modern, netlink based driver instead of wext.
>
> Makes sense, applie
For mac80211_hwsim interfaces, suggest to use wpa_supplicant with the more
modern, netlink based driver instead of wext.
Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue>
---
Actually, I wasn't even able to make a connection with the configuration
files and information pr
On Mon, Jan 09, 2017 at 10:42:46PM +0100, Johannes Berg wrote:
> On Mon, 2017-01-09 at 22:33 +0100, Linus Lüssing wrote:
> > On Mon, Jan 09, 2017 at 01:44:03PM +0100, Johannes Berg wrote:
> > >
> > > > > A host SHOULD silently discard a datagr
On Mon, Jan 09, 2017 at 12:44:19PM +0100, M. Braun wrote:
> Am 09.01.2017 um 09:08 schrieb Johannes Berg:
> > Does it make sense to implement the two in separate layers though?
> >
> > Clearly, this part needs to be implemented in the bridge layer due to
> > the snooping knowledge, but the code
On Mon, Jan 09, 2017 at 01:30:32PM -0800, Stephen Hemminger wrote:
> I wonder if MAC80211 should be doing IGMP snooping and not bridge
> in this environment.
In the long term, yes. For now, not quite sure.
I personally like to go for simple solutions first :).
On Fri, Jan 06, 2017 at 07:13:56PM -0800, Stephen Hemminger wrote:
> On Mon, 2 Jan 2017 20:32:14 +0100
> Linus Lüssing <linus.luess...@c0d3.blue> wrote:
>
> > This feature is intended for interface types which have a more reliable
> > and/or efficient way to d
1 - 100 of 269 matches
Mail list logo
