Re: [PATCH 0/8] memory: emif: miscellaneous bug fixes for EMIF driver

2013-03-16 Thread Lokesh Vutla
On Friday 15 March 2013 11:38 PM, Greg KH wrote: On Mon, Mar 11, 2013 at 10:35:57AM +0530, Lokesh Vutla wrote: This series resolves a few minor issues for EMIF driver. Tested all patches on OMAP4430-sdp. Patch : memory: emif: setup LP settings on freq update is tested on a local tree, since

[PATCH V2 0/8] memory: emif: miscellaneous bug fixes for EMIF driver

2013-03-16 Thread Lokesh Vutla
Strashko (1): memory: emif: errata i743: Prohibit usage of Power-Down mode Lokesh Vutla (2): memory: emif: Fix the lpmode timeout calculation memory: emif: Load the correct custom config values from dt Nishanth Menon (3): memory: emif: handle overflow for timing for LP mode memory: emif

[PATCH V2 1/8] memory: emif: Fix the lpmode timeout calculation

2013-03-16 Thread Lokesh Vutla
The driver tries to round up the specified timeout cycles to the next power of 2 value. This should be done defore updating timeout variable. Correcting this here. Reported-by: Nishanth Menon n...@ti.com Signed-off-by: Lokesh Vutla lokeshvu...@ti.com Acked-by: Santosh Shilimkar santosh.shilim

[PATCH V2 7/8] memory: emif: errata i743: Prohibit usage of Power-Down mode

2013-03-16 Thread Lokesh Vutla
used in OMAP4 Soc's. Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com Signed-off-by: Vitaly Chernooky vitaly.cherno...@ti.com Signed-off-by: Oleksandr Dmytryshyn oleksandr.dmytrys...@ti.com Signed-off-by: Lokesh Vutla lokeshvu...@ti.com Acked-by: Santosh Shilimkar santosh.shilim...@ti.com

[PATCH V2 3/8] memory: emif: handle overflow for timing for LP mode

2013-03-16 Thread Lokesh Vutla
From: Nishanth Menon n...@ti.com In case the custom timings provide values which overflow the maximum possible field value, warn and use maximum permissible value. Signed-off-by: Nishanth Menon n...@ti.com Signed-off-by: Lokesh Vutla lokeshvu...@ti.com Acked-by: Santosh Shilimkar santosh.shilim

[PATCH V2 6/8] memory: emif: Fix the incorrect 'size' parameter in memcpy

2013-03-16 Thread Lokesh Vutla
-by: Oleksandr Dmytryshyn oleksandr.dmytrys...@ti.com Signed-off-by: Lokesh Vutla lokeshvu...@ti.com Acked-by: Santosh Shilimkar santosh.shilim...@ti.com --- Changes since V1: Updated $subject drivers/memory/emif.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/memory

[PATCH V2 8/8] memory: emif: Load the correct custom config values from dt

2013-03-16 Thread Lokesh Vutla
-by: Lokesh Vutla lokeshvu...@ti.com Acked-by: Santosh Shilimkar santosh.shilim...@ti.com --- Changes since V1: No changes drivers/memory/emif.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c index 9b27c2b..475174a 100644

[PATCH V2 5/8] memory: emif: use restart if power_off not present when out of spec

2013-03-16 Thread Lokesh Vutla
. NOTE: This is not the safest option, but safer than leaving the system in unstable conditions. Signed-off-by: Nishanth Menon n...@ti.com Signed-off-by: Lokesh Vutla lokeshvu...@ti.com Acked-by: Santosh Shilimkar santosh.shilim...@ti.com --- Changes since V1: Added a new extra line before

[PATCH V2 4/8] memory: emif: Handle devices which are not rated for 85C

2013-03-16 Thread Lokesh Vutla
n...@ti.com Signed-off-by: Lokesh Vutla lokeshvu...@ti.com Acked-by: Santosh Shilimkar santosh.shilim...@ti.com --- Changes since V1: No changes drivers/memory/emif.c | 27 +++ include/linux/platform_data/emif_plat.h |1 + 2 files changed, 28

[PATCH V2 2/8] memory: emif: setup LP settings on freq update

2013-03-16 Thread Lokesh Vutla
Signed-off-by: Ambresh K ambr...@ti.com Signed-off-by: Lokesh Vutla lokeshvu...@ti.com Acked-by: Santosh Shilimkar santosh.shilim...@ti.com --- Changes since V1: No changes drivers/memory/emif.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c

[PATCH 1/8] memory: emif: Correct the lpmode timeout calculation

2013-03-10 Thread Lokesh Vutla
The driver tries to round up the specified timeout cycles to the next power of 2 value. But this is done wrongly. Correcting this here. Reported-by: Nishanth Menon n...@ti.com Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/memory/emif.c |4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 0/8] memory: emif: miscellaneous bug fixes for EMIF driver

2013-03-10 Thread Lokesh Vutla
Strashko (1): memory: emif: errata i743: Prohibit usage of Power-Down mode Lokesh Vutla (2): memory: emif: Correct the lpmode timeout calculation memory: emif: Load the correct custom config values from dt Nishanth Menon (3): memory: emif: handle overflow for timing for LP mode memory

[PATCH 5/8] memory: emif: use restart if power_off not present when out of spec

2013-03-10 Thread Lokesh Vutla
. NOTE: This is not the safest option, but safer than leaving the system in unstable conditions. Signed-off-by: Nishanth Menon n...@ti.com Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/memory/emif.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git

[PATCH 6/8] memory: emif: fix timings initialization issue

2013-03-10 Thread Lokesh Vutla
-by: Oleksandr Dmytryshyn oleksandr.dmytrys...@ti.com Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/memory/emif.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c index 02a94fc..f75806a 100644 --- a/drivers/memory/emif.c

[PATCH 8/8] memory: emif: Load the correct custom config values from dt

2013-03-10 Thread Lokesh Vutla
-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/memory/emif.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c index 119503a..4866f1b 100644 --- a/drivers/memory/emif.c +++ b/drivers/memory/emif.c @@ -1258,7 +1258,7 @@ static void

[PATCH 3/8] memory: emif: handle overflow for timing for LP mode

2013-03-10 Thread Lokesh Vutla
From: Nishanth Menon n...@ti.com In case the custom timings provide values which overflow the maximum possible field value, warn and use maximum permissible value. Signed-off-by: Nishanth Menon n...@ti.com Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/memory/emif.c | 36

[PATCH 2/8] memory: emif: setup LP settings on freq update

2013-03-10 Thread Lokesh Vutla
Signed-off-by: Ambresh K ambr...@ti.com Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/memory/emif.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c index 622638c..16f5089 100644 --- a/drivers/memory/emif.c +++ b/drivers/memory/emif.c

[PATCH 4/8] memory: emif: Handle devices which are not rated for 85C

2013-03-10 Thread Lokesh Vutla
n...@ti.com Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/memory/emif.c | 27 +++ include/linux/platform_data/emif_plat.h |1 + 2 files changed, 28 insertions(+) diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c index 37e0c77

[PATCH 7/8] memory: emif: errata i743: Prohibit usage of Power-Down mode

2013-03-10 Thread Lokesh Vutla
grygorii.stras...@ti.com Signed-off-by: Vitaly Chernooky vitaly.cherno...@ti.com Signed-off-by: Oleksandr Dmytryshyn oleksandr.dmytrys...@ti.com Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/memory/emif.c | 35 +++ 1 file changed, 35 insertions(+) diff

Re: [PATCH 7/8] memory: emif: errata i743: Prohibit usage of Power-Down mode

2013-03-11 Thread Lokesh Vutla
Hi, On Monday 11 March 2013 11:20 AM, Santosh Shilimkar wrote: On Monday 11 March 2013 10:36 AM, Lokesh Vutla wrote: From: Grygorii Strashko grygorii.stras...@ti.com ERRATA DESCRIPTION : The EMIF supports power-down state for low power. The EMIF automatically puts the SDRAM into power-down

[PATCH] ARM: hw_breakpoint: Enable debug powerdown only if system supports 'has_ossr'

2013-03-13 Thread Lokesh Vutla
to avoid the mentioned issue. Cc: Dietmar Eggemann dietmar.eggem...@arm.com Cc: Will Deacon will.dea...@arm.com Reported-by: Santosh Shilimkar santosh.shilim...@ti.com Acked-by: Santosh Shilimkar santosh.shilim...@ti.com Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- arch/arm/kernel

Re: [PATCH] ARM: hw_breakpoint: Enable debug powerdown only if system supports 'has_ossr'

2013-03-13 Thread Lokesh Vutla
Hi Dietmar, On Wednesday 13 March 2013 05:35 PM, Dietmar Eggemann wrote: On 13/03/13 06:52, Lokesh Vutla wrote: Commit {9a6eb31 ARM: hw_breakpoint: Debug powerdown support for self-hosted debug} introduces debug powerdown support for self-hosted debug. While merging the patch 'has_ossr' check

Re: [PATCH v2 04/14] crypto: omap-aes: Simplify DMA usage by using direct SGs

2013-08-20 Thread Lokesh Vutla
Hi Joel, On Sunday 18 August 2013 08:12 AM, Joel Fernandes wrote: In early version of this driver, assumptions were made such as DMA layer requires contiguous buffers etc. Due to this, new buffers were allocated, mapped and used for DMA. These assumptions are no longer true and DMAEngine

[PATCH] ARM: dts: remove previously generated .dtb files on clean

2013-06-27 Thread Lokesh Vutla
*.dtb used to be generated in the *arch/arm/boot* directory which is different from where it is generated now. Current rules delete the previously generated files only for *make dtbs*. Let distclean delete all the generated dtb files. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com Signed-off

Re: [PATCH V4 2/2] arm: dts: dra7: add crossbar device binding

2014-07-10 Thread Lokesh Vutla
Hi Tony, On Wednesday 09 July 2014 09:14 PM, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [140626 03:28]: * Sricharan R r.sricha...@ti.com [140626 01:36]: Hi Tony, On Thursday 26 June 2014 01:14 PM, Tony Lindgren wrote: * Sricharan R r.sricha...@ti.com [140626 00:29]: From: R

Re: [PATCH 2/2] ARM: DRA7: hwmod: Add dra74x and dra72x specific ocp interface lists

2014-07-22 Thread Lokesh Vutla
Hi Nishanth, On Tuesday 22 July 2014 10:20 PM, Nishanth Menon wrote: On 07/16/2014 03:36 AM, Lokesh Vutla wrote: From: Rajendra Nayak rna...@ti.com To deal with IPs which are specific to dra74x and dra72x, maintain seperate ocp interface lists, while keeping the common list for all common IPs

Re: [PATCH 0/2] ARM: DRA7: hwmod: Add dra74x and dra72x specific ocp interface lists

2014-07-22 Thread Lokesh Vutla
Hi Nishanth, On Tuesday 22 July 2014 10:15 PM, Nishanth Menon wrote: On 07/16/2014 03:36 AM, Lokesh Vutla wrote: This series add seperate ocp interface lists that are specific to dra74x and dra72x, and moving USB OTG SS4 to dra74x only since its not present in dra72x. Without this USB OTG SS4

Re: [PATCH 0/2] ARM: dts: dra72-evm: Add i2c1 and tps65917 nodes

2014-07-28 Thread Lokesh Vutla
On Monday 28 July 2014 11:48 AM, Keerthy wrote: The patch series adds i2c1 and tps65917 and related nodes. The patch series is boot tested on DRA72-EVM. Thanks to Lokesh lokeshvu...@ti.com for testing the series. For booting, this is dependent on recent hwmod fix patch series posted by me:

[PATCH 1/2] ARM: DRA7: Add support for soc_is_dra74x() and soc_is_dra72x() varients

2014-07-16 Thread Lokesh Vutla
From: Rajendra Nayak rna...@ti.com Use the corresponding compatibles to identify the devices. Signed-off-by: Rajendra Nayak rna...@ti.com Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- arch/arm/mach-omap2/soc.h |7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/mach

[PATCH 2/2] ARM: DRA7: hwmod: Add dra74x and dra72x specific ocp interface lists

2014-07-16 Thread Lokesh Vutla
. The dra72x only list is empty for now and a placeholder for future hwmod additions which are specific to dra72x. Fixes: d904b38 ARM: DRA7: hwmod: Add SYSCONFIG for usb_otg_ss Reported-by: Keerthy j-keer...@ti.com Signed-off-by: Rajendra Nayak rna...@ti.com Signed-off-by: Lokesh Vutla lokeshvu...@ti.com

[PATCH 0/2] ARM: DRA7: hwmod: Add dra74x and dra72x specific ocp interface lists

2014-07-16 Thread Lokesh Vutla
This series add seperate ocp interface lists that are specific to dra74x and dra72x, and moving USB OTG SS4 to dra74x only since its not present in dra72x. Without this USB OTG SS4 hwmod gives an abort on dra72x. Adding support for soc_is_dra74x() and soc_is_dra72x() in order to differentiate

Re: [PATCH 2/2] ARM: DRA7: hwmod: Add dra74x and dra72x specific ocp interface lists

2014-07-25 Thread Lokesh Vutla
Hi Nishanth, On Tuesday 22 July 2014 10:20 PM, Nishanth Menon wrote: On 07/16/2014 03:36 AM, Lokesh Vutla wrote: From: Rajendra Nayak rna...@ti.com To deal with IPs which are specific to dra74x and dra72x, maintain seperate ocp interface lists, while keeping the common list for all common IPs

Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2014-12-18 Thread Lokesh Vutla
access that checks the module ready state has nothing to do with module's SYSCONFIG or mpu_rt_port. Yes, makes sense. This patch looks good to me. Tested this on AM437x-gp-evm. Tested-by: Lokesh Vutla lokeshvu...@ti.com May be good idea to warn every time if enabling of module is failed? Unrelated

Re: [PATCH 2/2] ARM: omap5/dra7xx: Fix counter frequency drift for AM572x errata i856.

2014-12-16 Thread Lokesh Vutla
Hi Lennart, On Sunday 14 December 2014 10:15 AM, Lennart Sorensen wrote: On Fri, Dec 12, 2014 at 05:08:56PM -0500, Lennart Sorensen wrote: Errata i856 for the AM572x (DRA7xx) points out that the 32.768KHz external crystal is not enabled at power up. Instead the CPU falls back to using an

Re: [PATCH 1/2] ARM: omap5/dra7xx: Fix frequency typos.

2014-12-16 Thread Lokesh Vutla
Hi Len, On Saturday 13 December 2014 03:38 AM, Lennart Sorensen wrote: The switch statement of the possible list of SYSCLK1 frequencies is missing a 0 in 4 out of the 7 frequencies. Indeed a good catch !! Reviewed-by: Lokesh Vutla lokeshvu...@ti.com Thanks and regards, Lokesh Signed-off

Re: [PATCH V2 2/2] ARM: dra7xx: Fix counter frequency drift for AM572x errata i856.

2014-12-17 Thread Lokesh Vutla
* 375 / 2 or SYSCLK1 * 75 / 244. Looks good to me. Tested this on DRA7 evm. Tested-by: Lokesh Vutla lokeshvu...@ti.com Thanks and regards, Lokesh Signed-off-by: Len Sorensen lsore...@csclub.uwaterloo.ca --- arch/arm/mach-omap2/control.h |4 arch/arm/mach-omap2/timer.c | 36

Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2015-01-06 Thread Lokesh Vutla
Hi Paul, On Tuesday 06 January 2015 07:34 AM, Paul Walmsley wrote: Roger, Lokesh, could you try this one instead? Yep, the below patch works on AM437x. Boot logs here: http://paste.ubuntu.com/9680938/ Thanks and regards, Lokesh It passes all the basic tests here except it does not boot on

Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2015-01-05 Thread Lokesh Vutla
Hi Paul, On Saturday 03 January 2015 02:40 AM, Paul Walmsley wrote: + Suman, lakml Hi Roger On Thu, 18 Dec 2014, Roger Quadros wrote: Fixing up Paul's email id. cheers, -roger On 18/12/14 17:49, Roger Quadros wrote: There are quite a few hwmods that don't have sysconfig register

[PATCH] crypto: omap-sham: Check for HIGHMEM before mapping SG pages

2015-03-30 Thread Lokesh Vutla
if they are HIGHMEM before accessing) Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-sham.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index 3c76696..ace5852 100644 --- a/drivers/crypto/omap

[PATCH] crypto: omap-aes: Fix support for unequal lengths

2015-03-30 Thread Lokesh Vutla
a single element SG list for this buffer with length as the total bytes to crypt, which is similar thing that is done in case of unaligned lengths. Fixes: 6242332ff2f3 (crypto: omap-aes - Add support for cases of unaligned lengths) Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto

[PATCH] crypto: omap-sham: Use pm_runtime_irq_safe()

2015-03-30 Thread Lokesh Vutla
: scheduling while atomic: kworker/0:2/2676/0x0100 Add pm_runtime_irq_safe() to avoid this. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-sham.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index ace5852..81ed511

[PATCH 2/3] rtc: omap: Update Kconfig for OMAP RTC

2015-03-31 Thread Lokesh Vutla
RTC is present in AM43xx and DRA7xx also. Updating the Kconfig to depend on ARCH_OMAP or ARCH_DAVINCI Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/rtc/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index

[PATCH 3/3] rtc: omap: use module_platform_driver

2015-03-31 Thread Lokesh Vutla
module_platform_driver_probe() prevents driver from requesting probe deferral. So using module_platform_drive() to support probe deferral. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/rtc/rtc-omap.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 0/3] rtc: omap: Fix misc bugs

2015-03-31 Thread Lokesh Vutla
This patch series fixes miscellaneous bugs in OMAP RTC driver. Tested on DRA72-evm with an out of tree patch for RTC hwmod. Logs: http://pastebin.ubuntu.com/10716566/ Lokesh Vutla (3): rtc: omap: Unlock and Lock rtc registers before and after register writes rtc: omap: Update Kconfig

[PATCH 1/3] rtc: omap: Unlock and Lock rtc registers before and after register writes

2015-03-31 Thread Lokesh Vutla
and leaves it enabled until the rtc driver removal. This eliminates the idea of preventing spurious writes when RTC driver is loaded. So implement rtc lock and unlock functions before and after register writes. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- - This is as advised by Paul

[PATCH v2] crypto: omap-sham: Add the offset of sg page to vaddr

2015-04-02 Thread Lokesh Vutla
-by: Lokesh Vutla lokeshvu...@ti.com --- - Tested on BBB. Logs below. Without this patch: http://pastebin.ubuntu.com/10722994/ With this patch: http://pastebin.ubuntu.com/10722992/ drivers/crypto/omap-sham.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/omap-sham.c b

Re: [PATCH] crypto: omap-sham: Check for HIGHMEM before mapping SG pages

2015-04-02 Thread Lokesh Vutla
Hi Herbert, On Wednesday 01 April 2015 07:48 PM, Herbert Xu wrote: On Tue, Mar 31, 2015 at 09:52:23AM +0530, Lokesh Vutla wrote: Commit 26a05489ee0e (crypto: omap-sham - Map SG pages if they are HIGHMEM before accessing) says that HIGHMEM pages may not be mapped so we must kmap them before

Re: [rtc-linux] [PATCH 1/3] rtc: omap: Unlock and Lock rtc registers before and after register writes

2015-04-02 Thread Lokesh Vutla
Hi, On Wednesday 01 April 2015 09:22 PM, Alexandre Belloni wrote: Hi, On 01/04/2015 at 11:24:56 +0530, Lokesh Vutla wrote : RTC module contains a kicker mechanism to prevent any spurious writes from changing the register values. This mechanism requires two MMR writes to the KICK0 and KICK1

[PATCH v2 1/3] rtc: omap: Unlock and Lock rtc registers before and after register writes

2015-04-02 Thread Lokesh Vutla
and leaves it enabled until the rtc driver removal. This eliminates the idea of preventing spurious writes when RTC driver is loaded. So implement rtc lock and unlock functions before and after register writes. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- -- This is as advised by Paul

[PATCH v2 0/3] rtc: omap: Fix misc bugs

2015-04-02 Thread Lokesh Vutla
This patch series fixes miscellaneous bugs in OMAP RTC driver. Tested on BeagleBone-Black. Logs: http://pastebin.ubuntu.com/10723287/ V1 patches can be seen here: http://www.mail-archive.com/linux-omap%40vger.kernel.org/msg115839.html Lokesh Vutla (3): rtc: omap: Unlock and Lock rtc

[PATCH v3 1/3] rtc: omap: Unlock and Lock rtc registers before and after register writes

2015-04-02 Thread Lokesh Vutla
and leaves it enabled until the rtc driver removal. This eliminates the idea of preventing spurious writes when RTC driver is loaded. So implement rtc lock and unlock functions before and after register writes. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com Acked-by: Alexandre Belloni

[PATCH v2 2/3] rtc: omap: Update Kconfig for OMAP RTC

2015-04-02 Thread Lokesh Vutla
RTC is present in AM43xx and DRA7xx also. Updating the Kconfig to depend on ARCH_OMAP or ARCH_DAVINCI Signed-off-by: Lokesh Vutla lokeshvu...@ti.com Acked-by: Alexandre Belloni alexandre.bell...@free-electrons.com --- drivers/rtc/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[PATCH v2 3/3] rtc: omap: use module_platform_driver

2015-04-02 Thread Lokesh Vutla
module_platform_driver_probe() prevents driver from requesting probe deferral. So using module_platform_drive() to support probe deferral. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com Acked-by: Alexandre Belloni alexandre.bell...@free-electrons.com --- drivers/rtc/rtc-omap.c | 5 +++-- 1 file

Re: [PATCH v2 1/3] rtc: omap: Unlock and Lock rtc registers before and after register writes

2015-04-02 Thread Lokesh Vutla
On Thursday 02 April 2015 06:03 PM, Alexandre Belloni wrote: On 02/04/2015 at 16:39:09 +0530, Lokesh Vutla wrote : [..snip..] } +static inline void am3352_rtc_unlock(struct omap_rtc *rtc) +{ +rtc_writel(rtc, OMAP_RTC_KICK0_REG, KICK0_VALUE); +rtc_writel(rtc, OMAP_RTC_KICK1_REG

[PATCH 09/10] crypto: omap-aes: gcm: Add support for PIO mode

2015-07-01 Thread Lokesh Vutla
Add support for PIO mode for GCM mode. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-aes-gcm.c | 10 ++ drivers/crypto/omap-aes.c | 24 ++-- drivers/crypto/omap-aes.h |3 ++- 3 files changed, 26 insertions(+), 11 deletions

[PATCH 02/10] crypto: omap-aes: Fix configuring of AES mode

2015-07-01 Thread Lokesh Vutla
AES_CTRL_REG is used to configure AES mode. Before configuring any mode we need to make sure all other modes are reset or else driver will misbehave. So mask all modes before configuring any AES mode. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-aes.c | 13

[PATCH 10/10] crypto: tcrypt: Added speed tests for Async AEAD crypto alogrithms

2015-07-01 Thread Lokesh Vutla
Adding simple speed tests for a range of block sizes for Async AEAD crypto algorithms. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- crypto/tcrypt.c | 233 +++ crypto/tcrypt.h |1 + 2 files changed, 234 insertions(+) diff --git

[PATCH 03/10] crypto: aead: Add aead_request_cast() api

2015-07-01 Thread Lokesh Vutla
Add aead_request_cast() api to get pointer to aead_request from cryto_async_request. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- include/linux/crypto.h |6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/crypto.h b/include/linux/crypto.h index 10df5d2..20fac3d

[PATCH 04/10] crypto: omap-aes: Use BIT() macro

2015-07-01 Thread Lokesh Vutla
Use BIT()/GENMASK() macros for all register definitions instead of hand-writing bit masks. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-aes.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/crypto/omap

[PATCH 05/10] crypto: omap-aes: Add support for GCM mode

2015-07-01 Thread Lokesh Vutla
OMAP AES hw supports aes gcm mode. Adding support for GCM mode in omap-aes driver. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/Makefile |3 +- drivers/crypto/omap-aes-gcm.c | 304 + drivers/crypto/omap-aes.c | 238

[PATCH 08/10] crypto: omap-aes: gmc: Add algo info

2015-07-01 Thread Lokesh Vutla
Now the driver supports gcm mode, add omap-aes-gcm algo info to omap-aes driver. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-aes.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index

[PATCH 07/10] crypto: omap-aes: gcm: Add support for unaligned lengths

2015-07-01 Thread Lokesh Vutla
Check if the inputs are not aligned, if not process the input before starting the hw acceleration. Similarly after completition of hw acceleration. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-aes-gcm.c | 82 + 1 file changed

[PATCH 06/10] crypto: omap-aes: gcm: Handle inputs properly

2015-07-01 Thread Lokesh Vutla
Its not necessary that assoc data and plain text is passed always. Add these checks before processing the input. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-aes-gcm.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git

[PATCH 01/10] crypto: omap-aes: Add support for lengths not aligned with AES_BLOCK_SIZE

2015-07-01 Thread Lokesh Vutla
for inputs not aligned with AES_BLOCK_SIZE. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-aes.c | 33 - 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index 9a28b7e..a923101

[PATCH 00/10] crypto: omap-aes: Add support for GCM mode

2015-07-01 Thread Lokesh Vutla
This series does some basic cleanup and adds support for AES GCM mode for omap aes driver. Also adds a test case for async aead algos. Tested on BeagelBoneBlack: http://pastebin.ubuntu.com/11808341/ Lokesh Vutla (10): crypto: omap-aes: Add support for lengths not aligned

Re: [PATCH 05/10] crypto: omap-aes: Add support for GCM mode

2015-07-02 Thread Lokesh Vutla
On Thursday 02 July 2015 01:34 PM, Felipe Balbi wrote: On Thu, Jul 02, 2015 at 10:48:35AM +0530, Lokesh Vutla wrote: OMAP AES hw supports aes gcm mode. here you refer to it as 'gcm' Will update it in next revision. Adding support for GCM mode in omap-aes driver. while here

Re: [PATCH 02/10] crypto: omap-aes: Fix configuring of AES mode

2015-07-02 Thread Lokesh Vutla
On Thursday 02 July 2015 01:27 PM, Felipe Balbi wrote: On Thu, Jul 02, 2015 at 10:48:32AM +0530, Lokesh Vutla wrote: AES_CTRL_REG is used to configure AES mode. Before configuring any mode we need to make sure all other modes are reset or else driver will misbehave. So mask all modes before

Re: [PATCH 08/10] crypto: omap-aes: gmc: Add algo info

2015-07-02 Thread Lokesh Vutla
On Thursday 02 July 2015 01:30 PM, Stephan Mueller wrote: Am Donnerstag, 2. Juli 2015, 10:48:38 schrieb Lokesh Vutla: Hi Lokesh, Now the driver supports gcm mode, add omap-aes-gcm algo info to omap-aes driver. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-aes.c

Re: [PATCH 03/10] crypto: aead: Add aead_request_cast() api

2015-07-02 Thread Lokesh Vutla
On Thursday 02 July 2015 01:28 PM, Felipe Balbi wrote: On Thu, Jul 02, 2015 at 10:48:33AM +0530, Lokesh Vutla wrote: Add aead_request_cast() api to get pointer to aead_request from cryto_async_request. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- include/linux/crypto.h |6

Re: [PATCH 09/10] crypto: omap-aes: gcm: Add support for PIO mode

2015-07-02 Thread Lokesh Vutla
On Thursday 02 July 2015 01:36 PM, Felipe Balbi wrote: On Thu, Jul 02, 2015 at 10:48:39AM +0530, Lokesh Vutla wrote: Add support for PIO mode for GCM mode. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com why do you require PIO ? Is there any situation where DMA can't be used? What would

Re: [PATCH 01/10] crypto: omap-aes: Add support for lengths not aligned with AES_BLOCK_SIZE

2015-07-02 Thread Lokesh Vutla
On Thursday 02 July 2015 01:23 PM, Felipe Balbi wrote: On Thu, Jul 02, 2015 at 10:48:31AM +0530, Lokesh Vutla wrote: OMAP AES driver returns an error if the data is not aligned with AES_BLOCK_SIZE bytes. But OMAP AES hw allows data input upto 1 byte aligned, but still zeros are to be appended

Re: [PATCH 06/10] crypto: omap-aes: gcm: Handle inputs properly

2015-07-02 Thread Lokesh Vutla
On Thursday 02 July 2015 01:34 PM, Felipe Balbi wrote: On Thu, Jul 02, 2015 at 10:48:36AM +0530, Lokesh Vutla wrote: Its not necessary that assoc data and plain text is passed always. Add these checks before processing the input. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com why can't

[PATCH] crypto: omap-des: Fix unmapping of dma channels

2015-07-02 Thread Lokesh Vutla
) [4.328500] [c004a840] (irq_exit) from [c000f9ac] (handle_IRQ+0x50/0xb0) [4.335589] [c000f9ac] (handle_IRQ) from [c0008688] (gic_handle_irq+0x28/0x5c) Removing the duplicate call to dma_unmap_sg(). Reported-by: Tomi Valkeinen tomi.valkei...@ti.com Signed-off-by: Lokesh Vutla lokeshvu...@ti.com

Re: [PATCH 08/10] crypto: omap-aes: gmc: Add algo info

2015-07-06 Thread Lokesh Vutla
Hi, On Monday 06 July 2015 01:05 PM, Herbert Xu wrote: On Thu, Jul 02, 2015 at 10:48:38AM +0530, Lokesh Vutla wrote: Now the driver supports gcm mode, add omap-aes-gcm algo info to omap-aes driver. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com You're using the old AEAD interface. We

Re: [PATCH 10/10] crypto: tcrypt: Added speed tests for Async AEAD crypto alogrithms

2015-07-06 Thread Lokesh Vutla
Hi, On Monday 06 July 2015 01:14 PM, Herbert Xu wrote: On Thu, Jul 02, 2015 at 10:48:40AM +0530, Lokesh Vutla wrote: Adding simple speed tests for a range of block sizes for Async AEAD crypto algorithms. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com What's wrong with the existing AEAD

[PATCH v2 1/7] crypto: omap-aes: Fix CTR mode

2015-07-07 Thread Lokesh Vutla
is not aligned with AES_BLOCK_SIZE. Adding support for omap-aes driver for inputs with length not aligned with AES_BLOCK_SIZE. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-aes.c | 33 - 1 file changed, 16 insertions(+), 17 deletions(-) diff

Re: [PATCH] mmc: omap_hsmmc: fix initialization order of mmc block devices

2015-10-13 Thread Lokesh Vutla
On Tuesday 13 October 2015 01:14 PM, Heiko Schocher wrote: > Hello Lokesh, > > Am 13.10.2015 um 08:46 schrieb Lokesh Vutla: >> +Nishanth, >> >> On Tuesday 13 October 2015 10:59 AM, Heiko Schocher wrote: >>> On embedded devices, often there is a combination of

Re: [PATCH] mmc: omap_hsmmc: fix initialization order of mmc block devices

2015-10-13 Thread Lokesh Vutla
+Nishanth, On Tuesday 13 October 2015 10:59 AM, Heiko Schocher wrote: > On embedded devices, often there is a combination of > removable mmc devices (e.g. MMC/SD cards) and hard > wired ones (e.g. eMMC). Depending on the hardware > configuration, the 'mmcblkN' node might change if > the removable

Re: [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data

2015-10-13 Thread Lokesh Vutla
On Tuesday 13 October 2015 07:14 PM, Franklin S Cooper Jr wrote: > ELM address information is provided by device tree. No longer need > to include this information within hwmod. Reviewed-by: Lokesh Vutla <lokeshvu...@ti.com> Thanks and regards, Lokesh > > Signed-off-by: Fr

Re: [PATCH v2 6/7] crypto: omap-aes: Add support for GCM mode

2015-07-08 Thread Lokesh Vutla
On Wednesday 08 July 2015 01:23 PM, Herbert Xu wrote: On Wed, Jul 08, 2015 at 03:48:05PM +0800, Herbert Xu wrote: On Wed, Jul 08, 2015 at 12:29:47PM +0530, Lokesh Vutla wrote: + if (req-assoclen + req-cryptlen == 0) { + scatterwalk_map_and_copy(ctx-auth_tag, req-dst, 0, authlen

Re: [PATCH v2 6/7] crypto: omap-aes: Add support for GCM mode

2015-07-08 Thread Lokesh Vutla
On Wednesday 08 July 2015 01:18 PM, Herbert Xu wrote: On Wed, Jul 08, 2015 at 12:29:47PM +0530, Lokesh Vutla wrote: + if (req-assoclen + req-cryptlen == 0) { + scatterwalk_map_and_copy(ctx-auth_tag, req-dst, 0, authlen, + 1); + return 0

[PATCH v2 4/7] crypto: omap-aes: Use BIT() macro

2015-07-07 Thread Lokesh Vutla
Use BIT()/GENMASK() macros for all register definitions instead of hand-writing bit masks. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-aes.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/crypto/omap

[PATCH v2 0/7] crypto: omap-aes: Add support for GCM mode

2015-07-07 Thread Lokesh Vutla
This series does some basic cleanup and adds support for AES GCM mode for omap aes driver. Changes since v1: - Switched GCM to new AEAD interface Lokesh Vutla (7): crypto: omap-aes: Fix CTR mode crypto: omap-aes: Increase priority of hw accelerator crypto: omap-aes: Fix configuring of AES

[PATCH v2 3/7] crypto: omap-aes: Fix configuring of AES mode

2015-07-07 Thread Lokesh Vutla
AES_CTRL_REG is used to configure AES mode. Before configuring any mode we need to make sure all other modes are reset or else driver will misbehave. So mask all modes before configuring any AES mode. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-aes.c | 13

[PATCH v2 2/7] crypto: omap-aes: Increase priority of hw accelerator

2015-07-07 Thread Lokesh Vutla
Increasing the priority of omap-aes hw algos, in order to take precedence over sw algos. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-aes.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c

[PATCH v2 7/7] crypto: tcrypt: Fix AEAD speed tests

2015-07-07 Thread Lokesh Vutla
The AEAD speed tests doesn't do a wait_for_completition, if the return value is EINPROGRESS or EBUSY. Fixing it here. Also add a test case for gcm(aes). Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- crypto/tcrypt.c | 65 ++--- 1 file

[PATCH v2 5/7] crypto: aead: Add aead_request_cast() api

2015-07-07 Thread Lokesh Vutla
Add aead_request_cast() api to get pointer to aead_request from cryto_async_request. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- include/crypto/internal/aead.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/crypto/internal/aead.h b/include/crypto/internal/aead.h index

[PATCH v2 6/7] crypto: omap-aes: Add support for GCM mode

2015-07-07 Thread Lokesh Vutla
OMAP AES hw supports AES-GCM mode. Adding support for GCM mode in omap-aes driver. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/Kconfig| 1 + drivers/crypto/Makefile | 3 +- drivers/crypto/omap-aes-gcm.c | 376

Re: [PATCH v2 6/7] crypto: omap-aes: Add support for GCM mode

2015-07-08 Thread Lokesh Vutla
On Wednesday 08 July 2015 09:48 AM, Herbert Xu wrote: On Tue, Jul 07, 2015 at 09:01:48PM +0530, Lokesh Vutla wrote: +static int omap_aes_gcm_copy_buffers(struct omap_aes_dev *dd, + struct aead_request *req) +{ +void *buf_in; +int pages, alen, clen

Re: [PATCH v2 5/7] crypto: aead: Add aead_request_cast() api

2015-07-08 Thread Lokesh Vutla
On Wednesday 08 July 2015 09:26 AM, Herbert Xu wrote: On Tue, Jul 07, 2015 at 09:01:47PM +0530, Lokesh Vutla wrote: Add aead_request_cast() api to get pointer to aead_request from cryto_async_request. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- include/crypto/internal/aead.h | 6

Re: [PATCH v2 6/7] crypto: omap-aes: Add support for GCM mode

2015-07-10 Thread Lokesh Vutla
Hi Herbert, On Wednesday 08 July 2015 09:48 AM, Herbert Xu wrote: On Tue, Jul 07, 2015 at 09:01:48PM +0530, Lokesh Vutla wrote: +static int omap_aes_gcm_copy_buffers(struct omap_aes_dev *dd, + struct aead_request *req) [..snip..] +static int do_encrypt_iv

[PATCH v3] crypto: omap-aes: Add support for GCM mode

2015-09-15 Thread Lokesh Vutla
OMAP AES hw supports AES-GCM mode. Adding support for GCM and RFC4106 GCM mode in omap-aes driver. Signed-off-by: Lokesh Vutla <lokeshvu...@ti.com> --- Tested on BeagleBone-Black: http://pastebin.ubuntu.com/12417512/ Changes since v1: - Addressed comments by Herbert. Previously poste

Re: [PATCH 1/2] arm: dra7: Add hwmod entry for i2c6

2016-05-25 Thread Lokesh Vutla
On Wednesday 25 May 2016 06:23 PM, Ravikumar Kattekola wrote: > dra72x device has i2c6 controller. > Adding hwmod definition for the same. > > Reference DRA72x TRM [ SPRUHP2Q ] > > Signed-off-by: Ravikumar Kattekola > --- > arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23

Re: [PATCH v3] arm: omap2: remove redundant multiplatform checks

2016-04-06 Thread Lokesh Vutla
a > silent option and all machines selecting this option are multiplatform > devices. As a consequence checks for CONFIG_ARCH_MULTIPLATFORM as well > as CONFIG_ARCH_OMAP2PLUS within that directory are superfluous and can > be removed. Reviewed-by: Lokesh Vutla <lokeshvu...@ti.com> Thanks and regards, Lokesh

Re: [PATCH v2] arm: omap2: remove redundant multiplatform checks

2016-04-05 Thread Lokesh Vutla
On Wednesday 06 April 2016 04:05 AM, Jonas Rabenstein wrote: > The directory arch/arm/mach-omap2 is only selected for compilation if > CONFIG_ARCH_OMAP2PLUS is selected. CONFIG_ARCH_OMAP2PLUS itself is a > silent option and all machines selecting this option are multiplatform > devices. As a

Re: [PATCH 3/3] ARM: configs: keystone: Enable PINCTRL_SINGLE Config

2016-05-23 Thread Lokesh Vutla
On Monday 23 May 2016 05:59 PM, Keerthy wrote: > keystone-k2l devices use pinmux and are compliant with PINCTRL_SINGLE. > Hence enable the config option. > > Signed-off-by: Keerthy A similar patch[1] is already posted. [1]https://patchwork.kernel.org/patch/8958091/ Thanks

Re: [PATCH 2/3] arm: mach-keystone: Enable PINCTRL config

2016-05-23 Thread Lokesh Vutla
On Monday 23 May 2016 05:59 PM, Keerthy wrote: > keystone-k2l uses pinmux and is compliant with PINCTRL_SINGLE > which depends on PINCTRL. Hence enable PINCTRL. > > Signed-off-by: Keerthy > --- > arch/arm/mach-keystone/Kconfig | 1 + > 1 file changed, 1 insertion(+) > >

Re: [PATCH v2 0/3] AM57/DRA7 Clock Tree DTSI Fix-ups

2016-05-02 Thread Lokesh Vutla
ed for a few of the clocks and their resulting > frequencies. Tested on my DRA74-evm. Tested-by: Lokesh Vutla <lokeshvu...@ti.com> Thanks and regards, Lokesh > > v2 Changes: > * Rebased on linux-next as requested by Tony Lindgren > * Eliminated previous patch 2 as ano

Re: [PATCH v2] initramfs: finish fput() before accessing any binary from initramfs

2017-02-01 Thread Lokesh Vutla
Hi All, On Tuesday 24 January 2017 11:06 AM, Lokesh Vutla wrote: > commit 4a9d4b024a31 ("switch fput to task_work_add") implements a > schedule_work() for completing fput(), but did not guarantee calling > __fput() after unpacking initramfs. Because of this, there is a > p

Re: [PATCH v2] initramfs: finish fput() before accessing any binary from initramfs

2017-02-01 Thread Lokesh Vutla
On Wednesday 01 February 2017 05:58 PM, Al Viro wrote: > On Tue, Jan 24, 2017 at 11:06:36AM +0530, Lokesh Vutla wrote: >> commit 4a9d4b024a31 ("switch fput to task_work_add") implements a >> schedule_work() for completing fput(), but did not guarantee calling &g

  1   2   3   4   5   6   >