Re: [PATCH v4 00/12] PCI: aardvark: Fix support for Turris MOX and Compex wifi cards

2020-05-18 Thread Lorenzo Pieralisi
On Mon, May 18, 2020 at 12:30:04PM +0200, Pali Rohár wrote: > On Sunday 17 May 2020 17:57:02 Gregory CLEMENT wrote: > > Hello, > > > > > Hello, > > > > > > On Thu, 30 Apr 2020 10:06:13 +0200 > > > Pali Rohár wrote: > > > > > >> Marek Behún (5): > > >> PCI: aardvark: Improve link training > >

Re: [PATCH v3] ACPI/IORT: Fix PMCG node always look for a single ID mapping.

2020-05-14 Thread Lorenzo Pieralisi
Address Hanjun and Robin's comments. > > drivers/acpi/arm64/iort.c | 5 + > 1 file changed, 5 insertions(+) Acked-by: Lorenzo Pieralisi > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > index ed3d2d1..12bb70e 100644 > --- a/drivers/acpi/arm64/i

Re: [PATCH v8 0/4] USB: pci-quirks: Add Raspberry Pi 4 quirk

2020-05-13 Thread Lorenzo Pieralisi
On Tue, May 05, 2020 at 06:13:13PM +0200, Nicolas Saenz Julienne wrote: > On the Raspberry Pi 4, after a PCI reset, VL805's firmware may either be > loaded directly from an EEPROM or, if not present, by the SoC's > co-processor, VideoCore. This series adds support for the later. > > Note that

Re: [PATCH v4 00/12] PCI: aardvark: Fix support for Turris MOX and Compex wifi cards

2020-05-13 Thread Lorenzo Pieralisi
On Wed, May 13, 2020 at 01:16:51PM +0200, Pali Rohár wrote: > On Thursday 30 April 2020 10:06:13 Pali Rohár wrote: > > Hello, > > > > this is the fourth version of the patch series for Armada 3720 PCIe > > controller (aardvark). It's main purpose is to fix some bugs regarding > > buggy ath10k

Re: [PATCH v8 0/4] USB: pci-quirks: Add Raspberry Pi 4 quirk

2020-05-13 Thread Lorenzo Pieralisi
On Tue, May 05, 2020 at 06:13:13PM +0200, Nicolas Saenz Julienne wrote: > On the Raspberry Pi 4, after a PCI reset, VL805's firmware may either be > loaded directly from an EEPROM or, if not present, by the SoC's > co-processor, VideoCore. This series adds support for the later. > > Note that

Re: [PATCH] PCI: dwc: Program outbound ATU upper limit register

2020-05-12 Thread Lorenzo Pieralisi
On Wed, Apr 01, 2020 at 04:58:13PM -0700, Alan Mikhak wrote: > From: Alan Mikhak > > Function dw_pcie_prog_outbound_atu_unroll() does not program the upper > 32-bit ATU limit register. Since ATU programming functions limit the > size of the translated region to 4GB by using a u32 size parameter,

Re: [PATCH] ACPI/IORT: Fix PMCG node always look for a single ID mapping.

2020-05-12 Thread Lorenzo Pieralisi
On Mon, May 11, 2020 at 01:22:56PM -0700, Tuan Phan wrote: > PMCG node can have zero ID mapping if its overflow interrupt > is wire based. The code to parse PMCG node can not assume it will > have a single ID mapping. > > Signed-off-by: Tuan Phan > --- > drivers/acpi/arm64/iort.c | 4 +++- > 1

Re: [PATCH v8 4/4] USB: pci-quirks: Add Raspberry Pi 4 quirk

2020-05-11 Thread Lorenzo Pieralisi
On Tue, May 05, 2020 at 06:13:17PM +0200, Nicolas Saenz Julienne wrote: > On the Raspberry Pi 4, after a PCI reset, VL805's firmware may either be > loaded directly from an EEPROM or, if not present, by the SoC's > VideoCore. Inform VideoCore that VL805 was just reset. > > Also, as this creates a

Re: [PATCH v2 RESEND] MAINTAINERS: correct typo in new NXP LAYERSCAPE GEN4

2020-05-11 Thread Lorenzo Pieralisi
On Wed, May 06, 2020 at 07:21:30AM +0200, Lukas Bulwahn wrote: > Commit 3edeb49525bb ("dt-bindings: PCI: Add NXP Layerscape SoCs PCIe Gen4 > controller") includes a new entry in MAINTAINERS, but slipped in a typo in > one of the file entries. > > Hence, since then, ./scripts/get_maintainer.pl

Re: [PATCH v3 0/2] Fix PCI HyperV device error handling

2020-05-11 Thread Lorenzo Pieralisi
ated. Thanks Lorenzo Pieralisi for the review and > suggestions, as well as Michael Kelley's contribution to the commit > log. > > Thanks, > Wei > > > Wei Hu (2): > PCI: hv: Fix the PCI HyperV probe failure path to release resource > properly > PCI: hv:

Re: [PATCH v3 2/2] PCI: hv: Retry PCI bus D0 entry when the first attempt failed with invalid device state

2020-05-11 Thread Lorenzo Pieralisi
On Thu, May 07, 2020 at 01:03:00PM +0800, Wei Hu wrote: > In the case of kdump, the PCI device was not cleanly shut down > before the kdump kernel starts. This causes the initial > attempt of entering D0 state in the kdump kernel to fail with > invalid device state returned from Hyper-V host. >

Re: [PATCH v3 0/4] PCI: brcmstb: Some minor fixes/features

2020-05-11 Thread Lorenzo Pieralisi
On Thu, May 07, 2020 at 04:15:39PM -0400, Jim Quinlan wrote: > v3 -- A change was submitted to [1] to make 'aspm-no-l0s' a general > property for PCIe devices. As such, the STB PCIe YAML file > merely notes that it may be used. > > v2 -- Dropped commit concerning CRS. >--

Re: [PATCH] PCI: brcmstb: Assert fundamental reset on initialization

2020-05-11 Thread Lorenzo Pieralisi
On Thu, May 07, 2020 at 07:20:20PM +0200, Nicolas Saenz Julienne wrote: > While preparing the driver for upstream this detail was missed. > > If not asserted during the initialization process, devices connected on > the bus will not be made aware of the internal reset happening. This, >

Re: [PATCH v10 0/8] Add endpoint driver for R-Car PCIe controller

2020-05-11 Thread Lorenzo Pieralisi
On Thu, May 07, 2020 at 01:33:11PM +0100, Lad Prabhakar wrote: > Hi All, > > This patch series adds support for endpoint driver for R-Car PCIe controller > on > R-Car/RZ-G2x SoC's, this also extends the epf framework to handle multiple > windows > supported by the controller for mapping PCI

Re: [PATCH] PCI: amlogic: meson: Don't use FAST_LINK_MODE to set up link

2020-05-11 Thread Lorenzo Pieralisi
On Wed, Apr 29, 2020 at 05:42:30PM +0100, Marc Zyngier wrote: > My vim3l board stubbornly refuses to play ball with a bog > standard PCIe switch (ASM1184e), spitting all kind of errors > ranging from link never coming up to crazy things like downstream > ports falling off the face of the planet. >

Re: [PATCH] PCI: tegra: Fix reporting GPIO error value

2020-05-11 Thread Lorenzo Pieralisi
On Tue, Apr 14, 2020 at 12:25:12PM +0200, Pali Rohár wrote: > Error code is stored in rp->reset_gpio and not in err variable. > > Signed-off-by: Pali Rohár > --- > drivers/pci/controller/pci-tegra.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to pci/tegra, thanks.

Re: [PATCH v2 1/2] PCI: hv: Fix the PCI HyperV probe failure path to release resource properly

2020-05-06 Thread Lorenzo Pieralisi
On Wed, May 06, 2020 at 02:55:17PM +, Michael Kelley wrote: [...] > > Hv_pci_bus_exit() calls hv_send_resources_released() to release all child > > resources. > > These child resources were allocated in hv_send_resources_allocated(). > > Hv_send_resources_allocated() could fail in the

Re: [PATCH v2 1/2] PCI: hv: Fix the PCI HyperV probe failure path to release resource properly

2020-05-06 Thread Lorenzo Pieralisi
On Wed, May 06, 2020 at 05:36:46AM +, Wei Hu wrote: > Hi Lorenzo, > > Thanks for your review. Please see my comments inline. > > > -Original Message- > > From: Lorenzo Pieralisi > > Sent: Tuesday, May 5, 2020 11:03 PM > > To: Wei Hu &

Re: [PATCH v2 2/2] PCI: hv: Retry PCI bus D0 entry when the first attempt failed with invalid device state

2020-05-05 Thread Lorenzo Pieralisi
On Fri, May 01, 2020 at 01:37:28PM +0800, Wei Hu wrote: > In the case of kdump, the PCI device was not cleanly shut down > before the kdump kernel starts. This causes the initial > attempt of entering D0 state in the kdump kernel to fail with > invalid device state returned from Hyper-V host. >

Re: [PATCH v2 1/2] PCI: hv: Fix the PCI HyperV probe failure path to release resource properly

2020-05-05 Thread Lorenzo Pieralisi
On Fri, May 01, 2020 at 01:36:17PM +0800, Wei Hu wrote: > Some error cases in hv_pci_probe() were not handled. Fix these error > paths to release the resourses and clean up the state properly. This patch does more than that. It adds a variable to store the number of slots actually allocated - I

Re: [PATCH] PCI: dwc: Fix inner MSI IRQ domain registration

2020-05-05 Thread Lorenzo Pieralisi
On Fri, May 01, 2020 at 12:39:21PM +0100, Marc Zyngier wrote: > On a system that uses the internal DWC MSI widget, I get this > warning from debugfs when CONFIG_GENERIC_IRQ_DEBUGFS is selected: > > debugfs: File ':soc:pcie@fc00' in directory 'domains' already present! > > This is due to

Re: [PATCH] PCI: altera: clean up indentation issue on a return statement

2020-05-05 Thread Lorenzo Pieralisi
On Fri, Mar 27, 2020 at 01:45:56PM +, Colin King wrote: > From: Colin Ian King > > A return statment is indented incorrectly, remove extraneous space. > > Signed-off-by: Colin Ian King > --- > drivers/pci/controller/pcie-altera.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v2] PCI: endpoint: functions/pci-epf-test: Avoid DMA release when DMA is unsupported

2020-05-05 Thread Lorenzo Pieralisi
On Wed, Apr 22, 2020 at 04:24:47PM +0900, Kunihiko Hayashi wrote: > When unbinding pci_epf_test, pci_epf_test_clean_dma_chan() is called in > pci_epf_test_unbind() even though epf_test->dma_supported is false. > As a result, dma_release_channel() will occur null pointer access because > dma_chan

Re: [PATCH] PCI: v3-semi: Fix a memory leak in some error handling paths in 'v3_pci_probe()'

2020-05-05 Thread Lorenzo Pieralisi
On Sat, Apr 18, 2020 at 10:16:37AM +0200, Christophe JAILLET wrote: > IF we fails somewhere in 'v3_pci_probe()', we need to free 'host'. > Use the managed version of 'pci_alloc_host_bridge()' to do that easily. > The use of managed resources is already widely used in this driver. > > Fixes:

Re: [PATCH] PCI: dwc: intel: make intel_pcie_cpu_addr() static

2020-05-05 Thread Lorenzo Pieralisi
On Wed, Apr 15, 2020 at 04:49:53PM +0800, Jason Yan wrote: > Fix the following sparse warning: > > drivers/pci/controller/dwc/pcie-intel-gw.c:456:5: warning: symbol > 'intel_pcie_cpu_addr' was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: Jason Yan > --- >

Re: [PATCH] PCI: dwc: Program outbound ATU upper limit register

2020-05-05 Thread Lorenzo Pieralisi
On Wed, Apr 01, 2020 at 04:58:13PM -0700, Alan Mikhak wrote: > From: Alan Mikhak > > Function dw_pcie_prog_outbound_atu_unroll() does not program the upper > 32-bit ATU limit register. Since ATU programming functions limit the > size of the translated region to 4GB by using a u32 size parameter,

Re: [PATCH -next v2] PCI: dwc: Make hisi_pcie_platform_ops static

2020-05-05 Thread Lorenzo Pieralisi
On Thu, Apr 23, 2020 at 11:18:03AM +0800, Zou Wei wrote: > Fix the following sparse warning: > > drivers/pci/controller/dwc/pcie-hisi.c:365:21: warning: > symbol 'hisi_pcie_platform_ops' was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: Zou Wei > --- >

Re: [PATCH] PCI: dwc: clean up computing of msix_tbl

2020-05-05 Thread Lorenzo Pieralisi
ded > addr is (void *) already. > > objdump -d shows no difference after this patch. > > Signed-off-by: Jiri Slaby > Cc: Kishon Vijay Abraham I > Cc: Lorenzo Pieralisi > --- > drivers/pci/controller/dwc/pcie-designware-ep.c | 6 +- > 1 file changed, 1 inserti

Re: [PATCH v9 0/8] Add endpoint driver for R-Car PCIe controller

2020-05-05 Thread Lorenzo Pieralisi
On Thu, Apr 30, 2020 at 09:43:20AM +0100, Lad, Prabhakar wrote: > Hi Kishon, > > On Thu, Apr 23, 2020 at 7:23 PM Lad Prabhakar > wrote: > > > > Hi All, > > > > This patch series adds support for endpoint driver for R-Car PCIe > > controller on > > R-Car/RZ-G2x SoC's, this also extends the epf

Re: [PATCH v2 4/4] PCI: cadence: Fix to read 32-bit Vendor ID/Device ID property from DT

2020-05-04 Thread Lorenzo Pieralisi
On Mon, May 04, 2020 at 02:22:30PM +0530, Kishon Vijay Abraham I wrote: > Hi Lorenzo, > > On 5/1/2020 8:41 PM, Lorenzo Pieralisi wrote: > > On Fri, Apr 17, 2020 at 05:13:22PM +0530, Kishon Vijay Abraham I wrote: > >> The PCI Bus Binding specification (IEEE Std 1

Re: [PATCH v2 4/4] PCI: cadence: Fix to read 32-bit Vendor ID/Device ID property from DT

2020-05-01 Thread Lorenzo Pieralisi
On Fri, Apr 17, 2020 at 05:13:22PM +0530, Kishon Vijay Abraham I wrote: > The PCI Bus Binding specification (IEEE Std 1275-1994 Revision 2.1 [1]) > defines both Vendor ID and Device ID to be 32-bits. Fix > pcie-cadence-host.c driver to read 32-bit Vendor ID and Device ID > properties from device

Re: [PATCH v2 2/4] PCI: cadence: Use "dma-ranges" instead of "cdns,no-bar-match-nbits" property

2020-05-01 Thread Lorenzo Pieralisi
[+Robin - to check on dma-ranges intepretation] I would need RobH and Robin to review this. Also, An ACK from Tom is required - for the whole series. On Fri, Apr 17, 2020 at 05:13:20PM +0530, Kishon Vijay Abraham I wrote: > Cadence PCIe core driver (host mode) uses "cdns,no-bar-match-nbits" >

Re: [PATCH 1/1] PCI: iproc: Invalidate PAXB address mapping before programming it

2019-10-21 Thread Lorenzo Pieralisi
On Thu, Oct 17, 2019 at 07:57:56PM +0530, Abhishek Shah wrote: > Hi Lorenzo, > > Please see my comments inline: > > On Tue, Oct 15, 2019 at 10:13 PM Lorenzo Pieralisi > wrote: > > > > On Fri, Sep 06, 2019 at 09:28:13AM +0530, Abhishek Shah wrote: > > > I

Re: [PATCH 1/2] PCI: tegra: Fix CLKREQ dependency programming

2019-10-18 Thread Lorenzo Pieralisi
On Sat, Oct 05, 2019 at 10:12:11PM +0530, Vidya Sagar wrote: > Corrects the programming to provide REFCLK to the downstream device > when there is no CLKREQ sideband signal routing present from root port > to the endpont. > > Signed-off-by: Vidya Sagar > --- >

Re: [PATCH] MAINTAINERS: Add Marek and Shimoda-san as R-Car PCIE co-maintainers

2019-10-17 Thread Lorenzo Pieralisi
On Wed, Oct 16, 2019 at 02:02:49PM +0200, Simon Horman wrote: > At the end of the v5.3 upstream development cycle I stepped down > from my role at Renesas. > > Pass maintainership of the R-Car PCIE to Marek and Shimoda-san. > > Signed-off-by: Simon Horman > --- > MAINTAINERS | 3 ++- > 1 file

Re: [PATCH] MAINTAINERS: Add Marek and Shimoda-san as R-Car PCIE co-maintainers

2019-10-17 Thread Lorenzo Pieralisi
On Wed, Oct 16, 2019 at 02:02:49PM +0200, Simon Horman wrote: > At the end of the v5.3 upstream development cycle I stepped down > from my role at Renesas. > > Pass maintainership of the R-Car PCIE to Marek and Shimoda-san. > > Signed-off-by: Simon Horman > --- > MAINTAINERS | 3 ++- > 1 file

Re: [PATCH] PCI: mvebu: mvebu_pcie_map_registers __iomem fix

2019-10-17 Thread Lorenzo Pieralisi
n > expression (different address spaces) > drivers/pci/controller/pci-mvebu.c:716:31:expected void [noderef] > * > drivers/pci/controller/pci-mvebu.c:716:31:got void * > > Signed-off-by: Ben Dooks > --- > Cc: Thomas Petazzoni > Cc: Jason Cooper > Cc:

Re: [PATCH] PCI: mvebu: make mvebu_pci_bridge_emul_ops static

2019-10-17 Thread Lorenzo Pieralisi
ci_bridge_emul_ops' was not declared. Should it be static? > > Signed-off-by: Ben Dooks > --- > Cc: Thomas Petazzoni > Cc: Jason Cooper > Cc: Lorenzo Pieralisi > Cc: Andrew Murray > Cc: Bjorn Helgaas > Cc: linux-...@vger.kernel.org > Cc: linux-arm-ker...@lists.

Re: [PATCH] pci: iproc-msi: fix __iomem annotation in decode_msi_hwirq()

2019-10-17 Thread Lorenzo Pieralisi
n > argument 1 (different address spaces) > drivers/pci/controller/pcie-iproc-msi.c:301:17:expected void const > volatile [noderef] *addr > drivers/pci/controller/pcie-iproc-msi.c:301:17:got unsigned int > [usertype] *[assigned] msg > > Signed-off-by: Ben Dooks

Re: [PATCH v2 1/6] dt-bindings: pci: Update iProc PCI binding for INTx support

2019-10-16 Thread Lorenzo Pieralisi
On Wed, Aug 28, 2019 at 02:24:43PM +0530, Srinath Mannam wrote: > From: Ray Jui > > Update the iProc PCIe binding document for better modeling of the legacy > interrupt (INTx) support > > Signed-off-by: Ray Jui > Signed-off-by: Srinath Mannam > --- >

Re: [PATCH v2 0/6] PAXB INTx support with proper model

2019-10-16 Thread Lorenzo Pieralisi
On Tue, Oct 15, 2019 at 10:28:24AM -0700, Florian Fainelli wrote: > On 9/4/19 10:16 AM, Florian Fainelli wrote: > > On 8/28/19 1:54 AM, Srinath Mannam wrote: > >> This patch series adds PCIe legacy interrupt (INTx) support to the iProc > >> PCIe driver by modeling it with its own IRQ domain. All 4

Re: [PATCH] PCI: dwc: Use PTR_ERR_OR_ZERO() in five functions

2019-10-15 Thread Lorenzo Pieralisi
On Fri, Sep 06, 2019 at 08:50:07PM +0200, Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 6 Sep 2019 20:40:06 +0200 > > Simplify these function implementations by using a known function. > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > Signed-off-by: Markus Elfring > --- >

Re: [PATCH 1/1] PCI: iproc: Invalidate PAXB address mapping before programming it

2019-10-15 Thread Lorenzo Pieralisi
On Fri, Sep 06, 2019 at 09:28:13AM +0530, Abhishek Shah wrote: > Invalidate PAXB inbound/outbound address mapping each time before > programming it. This is helpful for the cases where we need to > reprogram inbound/outbound address mapping without resetting PAXB. > kexec kernel is one such

Re: [PATCH] PCI: dwc: fix find_next_bit() usage

2019-10-15 Thread Lorenzo Pieralisi
On Wed, Sep 04, 2019 at 06:03:38PM +0200, Niklas Cassel wrote: > find_next_bit() takes a parameter of size long, and performs arithmetic > that assumes that the argument is of size long. > > Therefore we cannot pass a u32, since this will cause find_next_bit() > to read outside the stack buffer

Re: [PATCH v3] PCI: mobiveil: Fix csr_read/write build issue

2019-10-15 Thread Lorenzo Pieralisi
t;csr_write" > passed 4 arguments, but takes just 2 > static void csr_write(struct mobiveil_pcie *pcie, u32 val, u32 off, size_t > size) > > Cc: Hou Zhiqiang > Cc: Lorenzo Pieralisi > Cc: Minghuan Lian > Cc: Subrahmanya Lingappa > Cc: Andrew Murray &

Re: [PATCH v2] PCI: endpoint: Cast the page number to phys_addr_t

2019-10-15 Thread Lorenzo Pieralisi
On Wed, Oct 09, 2019 at 10:06:56AM -0700, Alan Mikhak wrote: > From: Alan Mikhak > > Modify pci_epc_mem_alloc_addr() to cast the variable 'pageno' > from type 'int' to 'phys_addr_t' before shifting left. This > cast is needed to avoid treating bit 31 of 'pageno' as the > sign bit which would

Re: [PATCH v2 0/6] arm64: dts: meson-g12: add support for PCIe

2019-10-15 Thread Lorenzo Pieralisi
On Mon, Sep 16, 2019 at 02:50:16PM +0200, Neil Armstrong wrote: > This patchset : > - updates the Amlogic PCI bindings for G12A > - reworks the Amlogic PCIe driver to make use of the > G12a USB3+PCIe Combo PHY instead of directly writing in > the PHY register > - adds the necessary operations to

Re: [PATCH v3] PCI: aardvark: Don't rely on jiffies while holding spinlock

2019-10-15 Thread Lorenzo Pieralisi
On Fri, Sep 27, 2019 at 10:55:02AM +0200, Remi Pommarel wrote: > advk_pcie_wait_pio() can be called while holding a spinlock (from > pci_bus_read_config_dword()), then depends on jiffies in order to > timeout while polling on PIO state registers. In the case the PIO > transaction failed, the

Re: [PATCH v3] PCI: aardvark: Fix PCI_EXP_RTCTL register configuration

2019-10-15 Thread Lorenzo Pieralisi
On Fri, Jun 14, 2019 at 12:10:59PM +0200, Remi Pommarel wrote: > PCI_EXP_RTCTL is used to activate PME interrupt only, so writing into it > should not modify other interrupts' mask. The ISR mask polarity was also > inverted, when PCI_EXP_RTCTL_PMEIE is set PCIE_MSG_PM_PME_MASK mask bit > should

Re: [PATCH v2] PCI: aardvark: Wait for endpoint to be ready before training link

2019-10-15 Thread Lorenzo Pieralisi
On Wed, May 22, 2019 at 11:33:50PM +0200, Remi Pommarel wrote: > When configuring pcie reset pin from gpio (e.g. initially set by > u-boot) to pcie function this pin goes low for a brief moment > asserting the PERST# signal. Thus connected device enters fundamental > reset process and link

Re: [PATCH v3] PCI: aardvark: Use LTSSM state to build link training flag

2019-10-14 Thread Lorenzo Pieralisi
On Wed, May 22, 2019 at 11:33:51PM +0200, Remi Pommarel wrote: > Aardvark's PCI_EXP_LNKSTA_LT flag in its link status register is not > implemented and does not reflect the actual link training state (the > flag is always set to 0). In order to support link re-training feature > this flag has to

Re: [PATCH v2] PCI: aardvark: Wait for endpoint to be ready before training link

2019-10-14 Thread Lorenzo Pieralisi
On Tue, Aug 06, 2019 at 08:49:46PM +0200, Remi Pommarel wrote: > On Wed, May 22, 2019 at 11:33:50PM +0200, Remi Pommarel wrote: > > When configuring pcie reset pin from gpio (e.g. initially set by > > u-boot) to pcie function this pin goes low for a brief moment > > asserting the PERST# signal.

Re: [PATCH v2] PCI: dwc: Add support to add GEN3 related equalization quirks

2019-10-14 Thread Lorenzo Pieralisi
On Mon, Oct 14, 2019 at 12:48:29PM +0530, Pankaj Dubey wrote: > From: Anvesh Salveru > > In some platforms, PCIe PHY may have issues which will prevent linkup > to happen in GEN3 or higher speed. In case equalization fails, link will > fallback to GEN1. > > DesignWare controller gives

Re: [PATCH v3] PCI: aardvark: Use LTSSM state to build link training flag

2019-10-14 Thread Lorenzo Pieralisi
On Sun, Oct 13, 2019 at 11:34:15AM +0100, Marc Zyngier wrote: > On Tue, 1 Oct 2019 09:05:46 +0100 > Andrew Murray wrote: > > Hi Lorenzo, > > > On Mon, Sep 30, 2019 at 06:52:30PM +0200, Remi Pommarel wrote: > > > On Mon, Sep 30, 2019 at 04:40:18PM +0100, Andrew Murray wrote: > > > > On Wed,

Re: [PATCH 2/4] PCI: hv: Add the support of hibernation

2019-09-26 Thread Lorenzo Pieralisi
On Wed, Sep 11, 2019 at 11:38:20PM +, Dexuan Cui wrote: > Implement the suspend/resume callbacks for hibernation. > > hv_pci_suspend() needs to prevent any new work from being queued: a later > patch will address this issue. I don't see why you have two separate patches, the second one

Re: [PATCH 4/4] PCI: hv: Change pci_protocol_version to per-hbus

2019-09-26 Thread Lorenzo Pieralisi
On Wed, Sep 11, 2019 at 11:38:23PM +, Dexuan Cui wrote: > A VM can have multiple hbus. It looks incorrect for the second hbus's > hv_pci_protocol_negotiation() to set the global variable > 'pci_protocol_version' (which was set by the first hbus), even if the > same value is written. > >

Re: pci: endpoint test BUG

2019-09-23 Thread Lorenzo Pieralisi
jj/pci-epf-uaf.txt > > ... > > From: Hillf Danton > > To: Bjorn Helgaas > > Cc: linux-pci , > > LKML , > > Randy Dunlap , > > Al Viro , > > Dan Carpenter , > > Lorenzo Pieralisi , > >

Re: pci: endpoint test BUG

2019-09-20 Thread Lorenzo Pieralisi
On Tue, Sep 17, 2019 at 11:10:37AM +0530, Kishon Vijay Abraham I wrote: > > On 16/09/19 4:52 PM, Lorenzo Pieralisi wrote: > > On Mon, Sep 16, 2019 at 10:06:30AM +0800, Hillf Danton wrote: > >> > >> On Sun, 15 Sep 2019 09:34:37 -0700 > >>> > >>

Re: [PATCH] PCI: tegra: include linux/pinctrl/consumer.h

2019-09-20 Thread Lorenzo Pieralisi
On Fri, Sep 20, 2019 at 04:07:14PM +0100, Andrew Murray wrote: > On Fri, Sep 20, 2019 at 04:55:05PM +0200, Arnd Bergmann wrote: > > Without this, we can run into a build failure: > > > > drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit > > declaration of function

Re: [PATCH v2 -next] PCI: tegra: Add missing include file

2019-09-20 Thread Lorenzo Pieralisi
On Fri, Sep 20, 2019 at 06:39:25PM +0800, YueHaibing wrote: > Fix build error without CONFIG_PINCTRL > > drivers/pci/controller/dwc/pcie-tegra194.c: In function tegra_pcie_config_rp: > drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit > declaration of function

Re: [PATCH 0/2] VMD fixes for v5.4

2019-09-18 Thread Lorenzo Pieralisi
On Mon, Sep 16, 2019 at 07:54:33AM -0600, Jon Derrick wrote: > Hi Lorenzo, Bjorn, Keith, > > Please consider the following patches for 5.4 inclusion. > > These will apply to 5.2 stable. 4.19 has a few feature deps so I will instead > follow-up with a backport. > > Jon Derrick (2): > PCI: vmd:

Re: [PATCH 2/2] PCI: vmd: Fix shadow offsets to reflect spec changes

2019-09-17 Thread Lorenzo Pieralisi
On Tue, Sep 17, 2019 at 03:51:39PM +, Derrick, Jonathan wrote: [...] > Sorry for the confusion. > > These changes only affect systems with VMD devices with 8086:28C0 > device IDs, but these won't be production hardware for some time. > > Systems with VMD devices exist in the wild with

Re: [PATCH 2/2] PCI: vmd: Fix shadow offsets to reflect spec changes

2019-09-17 Thread Lorenzo Pieralisi
On Tue, Sep 17, 2019 at 02:45:03PM +, Derrick, Jonathan wrote: > On Tue, 2019-09-17 at 15:05 +0100, Lorenzo Pieralisi wrote: > > On Tue, Sep 17, 2019 at 01:55:59PM +, Derrick, Jonathan wrote: > > > On Tue, 2019-09-17 at 11:41 +0100, Lorenzo Pieralisi wrote: > >

Re: [PATCH 2/2] PCI: vmd: Fix shadow offsets to reflect spec changes

2019-09-17 Thread Lorenzo Pieralisi
On Tue, Sep 17, 2019 at 01:55:59PM +, Derrick, Jonathan wrote: > On Tue, 2019-09-17 at 11:41 +0100, Lorenzo Pieralisi wrote: > > On Mon, Sep 16, 2019 at 07:54:35AM -0600, Jon Derrick wrote: > > > The shadow offset scratchpad was moved to 0x2000-0x2010. Update the >

Re: [PATCH 2/2] PCI: vmd: Fix shadow offsets to reflect spec changes

2019-09-17 Thread Lorenzo Pieralisi
On Mon, Sep 16, 2019 at 07:54:35AM -0600, Jon Derrick wrote: > The shadow offset scratchpad was moved to 0x2000-0x2010. Update the > location to get the correct shadow offset. Hi Jon, what does "was moved" mean ? Would this code still work on previous HW ? We must make sure that the address

Re: pci: endpoint test BUG

2019-09-16 Thread Lorenzo Pieralisi
On Mon, Sep 16, 2019 at 10:06:30AM +0800, Hillf Danton wrote: > > On Sun, 15 Sep 2019 09:34:37 -0700 > > > > Kernel is 5.3-rc8 on x86_64. > > > > Loading and removing the pci-epf-test module causes a BUG. > > > > > > [40928.435755] calling pci_epf_test_init+0x0/0x1000 [pci_epf_test] @ 12132

[PATCH] MAINTAINERS: Add PCI native host/endpoint controllers designated reviewer

2019-09-13 Thread Lorenzo Pieralisi
Add Andrew Murray as designated reviewer for PCI native host and endpoint controller drivers. Signed-off-by: Lorenzo Pieralisi Cc: Andrew Murray Cc: Bjorn Helgaas --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 783569e3c4b4..08d97988034d

Re: [PATCH v6 4/7] PCI: Add quirk to disable MSI-X support for Amazon's Annapurna Labs Root Port

2019-09-13 Thread Lorenzo Pieralisi
On Thu, Sep 12, 2019 at 04:00:42PM +0300, Jonathan Chocron wrote: > The Root Port (identified by [1c36:0031]) doesn't support MSI-X. On some > platforms it is configured to not advertise the capability at all, while > on others it (mistakenly) does. This causes a panic during > initialization by

Re: [PATCH v5 4/7] PCI: Add quirk to disable MSI-X support for Amazon's Annapurna Labs Root Port

2019-09-10 Thread Lorenzo Pieralisi
On Sat, Sep 07, 2019 at 11:55:42AM -0500, Bjorn Helgaas wrote: > s/Add quirk to disable/Disable/ in subject > > On Thu, Sep 05, 2019 at 05:00:18PM +0300, Jonathan Chocron wrote: > > The Root Port (identified by [1c36:0031]) doesn't support MSI-X. On some > > platforms it is configured to not

Re: linux-next: Signed-off-by missing for commit in the pci tree

2019-09-10 Thread Lorenzo Pieralisi
On Mon, Sep 09, 2019 at 11:10:06PM +, Haiyang Zhang wrote: > > > > -Original Message- > > From: Lorenzo Pieralisi > > Sent: Wednesday, August 21, 2019 5:03 AM > > To: Stephen Rothwell > > Cc: Bjorn Helgaas ; Linux Next Mailing List > n...

Re: [PATCH v5 0/7] Amazon's Annapurna Labs DT-based PCIe host controller driver

2019-09-05 Thread Lorenzo Pieralisi
On Thu, Sep 05, 2019 at 05:00:14PM +0300, Jonathan Chocron wrote: > This series adds support for Amazon's Annapurna Labs DT-based PCIe host > controller driver. > Additionally, it adds 3 quirks (ACS, VPD and MSI-X) and 2 generic DWC patches. > > Changes since v4: > - Moved the HEADER_TYPE

Re: [PATCH V4 0/6] PCI: tegra: Enable PCIe C5 controller of Tegra194 in p2972-0000 platform

2019-09-05 Thread Lorenzo Pieralisi
On Thu, Sep 05, 2019 at 04:15:47PM +0530, Vidya Sagar wrote: > This patch series enables Tegra194's C5 controller which owns x16 slot in > p2972- platform. C5 controller's PERST# and CLKREQ# are not configured as > output and bi-directional signals by default and hence they need to be >

Re: [PATCH V3 0/6] PCI: tegra: Enable PCIe C5 controller of Tegra194 in p2972-0000 platform

2019-09-05 Thread Lorenzo Pieralisi
On Thu, Sep 05, 2019 at 01:44:46PM +0530, Vidya Sagar wrote: > Hi Lorenzo / Bjorn, > Can you please review this series? > I have Reviewed-by and Acked-by from Rob, Thierry and Andrew already. Rebase it on top of my pci/tegra branch (it does not apply), resend it and I will merge it. Thanks,

Re: [PATCH v3] PCI: hv: Make functions static

2019-09-04 Thread Lorenzo Pieralisi
an ; Haiyang Zhang > > ; Stephen Hemminger > > ; Sasha Levin ; Lorenzo > > Pieralisi ; linux-...@vger.kernel.org; linux- > > ker...@vger.kernel.org; linux-hyp...@vger.kernel.org > > Subject: [PATCH v3] PCI: hv: Make functions static > > > > Functions

Re: [PATCH] PCI: aardvark: Don't rely on jiffies while holding spinlock

2019-09-02 Thread Lorenzo Pieralisi
On Sun, Sep 01, 2019 at 04:23:03PM +0200, Remi Pommarel wrote: > advk_pcie_wait_pio() can be called while holding a spinlock (from > pci_bus_read_config_dword()), then depends on jiffies in order to > timeout while polling on PIO state registers. In the case the PIO > transaction failed, the

Re: [PATCH v4 0/7] Amazon's Annapurna Labs DT-based PCIe host controller driver

2019-09-02 Thread Lorenzo Pieralisi
On Wed, Aug 21, 2019 at 06:35:40PM +0300, Jonathan Chocron wrote: > This series adds support for Amazon's Annapurna Labs DT-based PCIe host > controller driver. > Additionally, it adds 3 quirks (ACS, VPD and MSI-X) and 2 generic DWC patches. > > Changes since v3: > - Removed PATCH 8/8 since the

Re: linux-next: build failure after merge of the pci tree

2019-08-31 Thread Lorenzo Pieralisi
On Sat, Aug 31, 2019 at 09:51:05AM +0530, Vidya Sagar wrote: > On 8/30/2019 6:00 PM, Bjorn Helgaas wrote: > > [+cc Krzysztof] > > > > On Thu, Aug 29, 2019 at 10:23 PM Stephen Rothwell > > wrote: > > > > > > Hi all, > > > > > > After merging the pci tree, today's linux-next build (x86_64

Re: *_pcie_establish_link() usage

2019-08-28 Thread Lorenzo Pieralisi
On Wed, Aug 28, 2019 at 08:00:56AM -0500, Bjorn Helgaas wrote: > On Thu, Aug 01, 2019 at 04:25:29PM -0500, Bjorn Helgaas wrote: > > Hi, > > > > I got the following dmesg log from Fawad [1]: > > > > imx6q-pcie 1ffc000.pcie: host bridge /soc/pcie@1ffc000 ranges: > > imx6q-pcie 1ffc000.pcie:

Re: [PATCH] PCI: tegra: Don't print an error on -EPROBE_DEFER

2019-08-23 Thread Lorenzo Pieralisi
On Fri, Aug 23, 2019 at 08:48:32PM +0530, Vidya Sagar wrote: > APIs like devm_regulator_get() and devm_phy_get() have the potential to > return -EPROBE_DEFER when the respective sub-systems are not ready yet. > So avoid printing an error message as .probe() will be tried out again > at a later

Re: [PATCH] PCI: dwc: Use dev_info() instead of dev_err()

2019-08-23 Thread Lorenzo Pieralisi
On Fri, Aug 23, 2019 at 08:46:18PM +0530, Vidya Sagar wrote: > When a platform has an open PCIe slot, not having a device connected to > it doesn't have to result in a dev_err() print saying that the link is > not up but a dev_info() would suffice. > > Signed-off-by: Vidya Sagar > --- >

Re: [PATCH v4 1/3] dt-bindings: pci: layerscape-pci: add compatible strings "fsl,ls1028a-pcie"

2019-08-23 Thread Lorenzo Pieralisi
On Fri, Aug 23, 2019 at 04:26:41PM +0800, Xiaowei Bao wrote: > Add the PCIe compatible string for LS1028A > > Signed-off-by: Xiaowei Bao > Signed-off-by: Hou Zhiqiang > Reviewed-by: Rob Herring > --- > v2: > - No change. > v3: > - No change. > v4: > - No change. > >

Re: [PATCHv2 0/4] Layerscape: Remove num-lanes property from PCIe nodes

2019-08-23 Thread Lorenzo Pieralisi
On Tue, Aug 20, 2019 at 07:28:37AM +, Z.q. Hou wrote: > From: Hou Zhiqiang > > On FSL Layerscape SoCs, the number of lanes assigned to PCIe > controller is not fixed, it is determined by the selected > SerDes protocol. The current num-lanes indicates the max lanes > PCIe controller can

Re: [PATCHv2 0/4] Layerscape: Remove num-lanes property from PCIe nodes

2019-08-23 Thread Lorenzo Pieralisi
On Fri, Aug 23, 2019 at 10:44:25AM +0100, Andrew Murray wrote: > On Thu, Aug 22, 2019 at 05:48:15PM +0100, Lorenzo Pieralisi wrote: > > On Tue, Aug 20, 2019 at 07:28:37AM +, Z.q. Hou wrote: > > > From: Hou Zhiqiang > > > > > > On FSL Layerscape SoCs,

Re: [PATCHv2 1/4] dt-bindings: PCI: designware: Remove the num-lanes from Required properties

2019-08-22 Thread Lorenzo Pieralisi
On Tue, Aug 20, 2019 at 07:28:43AM +, Z.q. Hou wrote: > From: Hou Zhiqiang > > The num-lanes is not a mandatory property, e.g. on FSL > Layerscape SoCs, the PCIe link training is completed > automatically base on the selected SerDes protocol, it > doesn't need the num-lanes to set-up the

Re: [PATCHv2 0/4] Layerscape: Remove num-lanes property from PCIe nodes

2019-08-22 Thread Lorenzo Pieralisi
On Tue, Aug 20, 2019 at 07:28:37AM +, Z.q. Hou wrote: > From: Hou Zhiqiang > > On FSL Layerscape SoCs, the number of lanes assigned to PCIe > controller is not fixed, it is determined by the selected > SerDes protocol. The current num-lanes indicates the max lanes > PCIe controller can

Re: [PATCHv7] PCI: mobiveil: Fix the CPU base address setup in inbound window

2019-08-21 Thread Lorenzo Pieralisi
On Sat, Jul 13, 2019 at 10:11:29PM +0800, Hou Zhiqiang wrote: > The current code erroneously sets-up the CPU base address with > parameter 'pci_addr', which is passed to initialize the PCI > base address of the inbound window, and the upper 32-bit of the > CPU base address of the inbound window is

Re: [PATCH][next] PCI: tegra: tegra194: fix phy_count less than zero check

2019-08-21 Thread Lorenzo Pieralisi
On Wed, Aug 21, 2019 at 01:01:23PM +0100, Colin King wrote: > From: Colin Ian King > > The check for pcie->phy_count < 0 is always false because phy_count > is an unsigned int and can never be less than zero. Fix this by > assigning ret to the return from of_property_count_strings and > checking

Re: linux-next: Signed-off-by missing for commit in the pci tree

2019-08-21 Thread Lorenzo Pieralisi
On Wed, Aug 21, 2019 at 07:19:39AM +1000, Stephen Rothwell wrote: > Hi all, > > Commit > > c4a29fbba415 ("PCI: hv: Use bytes 4 and 5 from instance ID as the PCI > domain numbers") > > is missing a Signed-off-by from its committer. > > Also, all the tags should be kept together, please.

Re: [PATCH v6,1/2] PCI: hv: Detect and fix Hyper-V PCI domain number collision

2019-08-20 Thread Lorenzo Pieralisi
On Thu, Aug 15, 2019 at 05:01:37PM +, Haiyang Zhang wrote: > Currently in Azure cloud, for passthrough devices, the host sets the device > instance ID's bytes 8 - 15 to a value derived from the host HWID, which is > the same on all devices in a VM. So, the device instance ID's bytes 8 and 9 >

Re: [PATCH v6,1/2] PCI: hv: Detect and fix Hyper-V PCI domain number collision

2019-08-16 Thread Lorenzo Pieralisi
On Thu, Aug 15, 2019 at 05:01:37PM +, Haiyang Zhang wrote: > Currently in Azure cloud, for passthrough devices, the host sets the device > instance ID's bytes 8 - 15 to a value derived from the host HWID, which is > the same on all devices in a VM. So, the device instance ID's bytes 8 and 9 >

Re: [PATCH v5,1/2] PCI: hv: Detect and fix Hyper-V PCI domain number collision

2019-08-15 Thread Lorenzo Pieralisi
On Wed, Aug 14, 2019 at 03:52:15PM +, Haiyang Zhang wrote: > Currently in Azure cloud, for passthrough devices, the host sets the device > instance ID's bytes 8 - 15 to a value derived from the host HWID, which is > the same on all devices in a VM. So, the device instance ID's bytes 8 and 9 >

Re: [PATCH RESEND v8] PCI: imx6: limit DBI register length

2019-08-15 Thread Lorenzo Pieralisi
On Fri, Jul 26, 2019 at 04:40:07PM +0200, Stefan Agner wrote: > Define the length of the DBI registers and limit config space to its > length. This makes sure that the kernel does not access registers > beyond that point, avoiding the following abort on a i.MX 6Quad: > # cat

Re: [PATCH] PCI: pci-hyperv: fix build errors on non-SYSFS config

2019-08-15 Thread Lorenzo Pieralisi
On Fri, Jul 12, 2019 at 08:53:19AM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > Fix build errors when building almost-allmodconfig but with SYSFS > not set (not enabled). Fixes these build errors: > > ERROR: "pci_destroy_slot" [drivers/pci/controller/pci-hyperv.ko] undefined! > ERROR:

Re: [PATCH] PCI: pci-hyperv: fix build errors on non-SYSFS config

2019-08-14 Thread Lorenzo Pieralisi
On Tue, Jul 23, 2019 at 04:21:07PM -0500, Bjorn Helgaas wrote: > On Sat, Jul 13, 2019 at 11:03:53AM -0400, Sasha Levin wrote: [...] > > > > v3: corrected Fixes: tag [Dexuan Cui ] > > > > This is the Microsoft-preferred version of the patch. > > > > > > > > drivers/pci/Kconfig |2 +- > >

Re: [PATCHv6 1/2] PCI: layerscape: Add the bar_fixed_64bit property in EP driver.

2019-08-14 Thread Lorenzo Pieralisi
On Wed, Aug 14, 2019 at 09:48:00AM +, Xiaowei Bao wrote: > > > > -Original Message- > > From: Lorenzo Pieralisi > > Sent: 2019年8月14日 17:30 > > To: Xiaowei Bao > > Cc: M.h. Lian ; Mingkai Hu > > ; Roy Zang ; > > bhelg...@goog

Re: [PATCHv6 1/2] PCI: layerscape: Add the bar_fixed_64bit property in EP driver.

2019-08-14 Thread Lorenzo Pieralisi
I asked you to remove the period at the end of the patch $SUBJECT and you did not, either you do not read what I write or explain me what's going on. On Wed, Aug 14, 2019 at 10:03:29AM +0800, Xiaowei Bao wrote: > The PCIe controller of layerscape just have 4 BARs, BAR0 and BAR1 > is 32bit, BAR2

Re: [PATCH V16 00/13] PCI: tegra: Add Tegra194 PCIe support

2019-08-13 Thread Lorenzo Pieralisi
On Tue, Aug 13, 2019 at 05:06:14PM +0530, Vidya Sagar wrote: > Tegra194 has six PCIe controllers based on Synopsys DesignWare core. > There are two Universal PHY (UPHY) blocks with each supporting 12(HSIO: > Hisg Speed IO) and 8(NVHS: NVIDIA High Speed) lanes respectively. > Controllers:0~4 use

Re: [PATCH v3] PCI: hv: Detect and fix Hyper-V PCI domain number collision

2019-08-13 Thread Lorenzo Pieralisi
On Tue, Aug 13, 2019 at 12:55:59PM +, Haiyang Zhang wrote: > > > > -Original Message- > > From: Lorenzo Pieralisi > > Sent: Tuesday, August 13, 2019 6:14 AM > > To: Haiyang Zhang > > Cc: sas...@kernel.org; bhelg...@google.com; linu

Re: [PATCH V15 13/13] PCI: tegra: Add Tegra194 PCIe support

2019-08-13 Thread Lorenzo Pieralisi
Some style comments - we have time to fix them. On Fri, Aug 09, 2019 at 10:16:09AM +0530, Vidya Sagar wrote: [...] I do not know why up to here the line spacing is OK and here you started cramming code all together :) Just a matter of consistency, thanks for fixing them up. > +static void

Re: [PATCH] PCI: hv: Fix build error without CONFIG_SYSFS

2019-08-13 Thread Lorenzo Pieralisi
On Sat, Jun 15, 2019 at 02:48:24PM +0800, Yuehaibing wrote: > +cc Lorenzo Pieralisi Can we drop this patch and merge: https://patchwork.ozlabs.org/patch/1131444/ instead ? Thanks, Lorenzo > > On 2019/6/15 14:18, Yuehaibing wrote: > > > > On 2019/6/2 6:59, Michael Ke

<    1   2   3   4   5   6   7   8   9   10   >