[PATCH v6 5/7] [media] marvell-ccic/mmp: add devicetree support

2019-05-28 Thread Lubomir Rintel
The platform data is actually not used anywhere (along with the CSI support) and should be safe to remove. Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek --- Changes since v1: - s/This are/These are/ in a comment .../media/platform/marvell-ccic/mmp-driver.c | 36 ++- 1

[PATCH v6 7/7] [media] marvell-ccic: provide a clock for the sensor

2019-05-28 Thread Lubomir Rintel
that the sensor can ask us to enable the clock. Note that this is pretty dumb at the moment: the clock is hardwired to a particular frequency and parent. It was always the case. Signed-off-by: Lubomir Rintel --- Changes since v3: - Do not enable the clock on register() now that the sensor can turn

[PATCH v6 6/7] [media] marvell-ccic: use async notifier to get the sensor

2019-05-28 Thread Lubomir Rintel
). Signed-off-by: Lubomir Rintel --- Changes since v2: - Moved a typo fix hunk that was accidentally in the following patch here, to unbreak build. .../media/platform/marvell-ccic/cafe-driver.c | 49 -- .../media/platform/marvell-ccic/mcam-core.c | 161 -- .../media/platform

Re: [PATCH -next 0/2] Platform: OLPC: Fix two randbuild error

2019-05-28 Thread Lubomir Rintel
dd INPUT dependencies > > drivers/platform/olpc/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Thanks. Both patches: Reviewed-by: Lubomir Rintel

Re: [PATCH v5 02/10] [media] marvell-ccic: fix DMA s/g desc number calculation

2019-06-19 Thread Lubomir Rintel
On Fri, 2019-06-14 at 11:41 +0200, Jacopo Mondi wrote: > Hi Lubomir, > > On Sun, May 05, 2019 at 04:00:23PM +0200, Lubomir Rintel wrote: > > The commit d790b7eda953 ("[media] vb2-dma-sg: move dma_(un)map_sg here") > > left dma_desc_nent unset. It previou

[PATCH RESEND] mfd: cs5535-mfd: remove ifdef OLPC noise

2019-06-20 Thread Lubomir Rintel
provides machine_is_olpc() stub for CONFIG_OLPC=n, compiler should just optimize the unneeded bits away. Signed-off-by: Lubomir Rintel --- drivers/mfd/cs5535-mfd.c | 24 +++- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/drivers/mfd/cs5535-mfd.c b/drivers

Re: [PATCH v6 5/7] [media] marvell-ccic/mmp: add devicetree support

2019-06-20 Thread Lubomir Rintel
On Thu, 2019-06-20 at 14:35 +0300, Sakari Ailus wrote: > Ping? > > Lubomir: I'm applying the set now, but please addres Jacopo's comment. > Thanks. Hi, I'm wondering if you could wait a couple of minutes? I've tested the patch set on my machine last night and I was about to submit the updated

[PATCH v2] dt-bindings: phy-pxa-usb: add bindings

2019-06-20 Thread Lubomir Rintel
This is the PHY chip for USB OTG on PXA platforms. Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek --- This remained unapplied, despite the driver being in already. Changes since v1: - Cosmetic and wording fixes .../devicetree/bindings/phy/phy-pxa-usb.txt| 18 ++ 1

[PATCH] ARM: multi_v7_defconfig: enable MMP2 platform

2019-06-20 Thread Lubomir Rintel
Marvell MMP/PXA/MMP2 platforms seem to be excluded from the defconfig for no good reasons. Enable the DT-based boards and the modules for their peripherals. Signed-off-by: Lubomir Rintel --- arch/arm/configs/multi_v7_defconfig | 11 +++ 1 file changed, 11 insertions(+) diff --git

[PATCH 3/5] ARM: dts: mmp2: rename the USB PHY node

2019-06-20 Thread Lubomir Rintel
This device is not an OTG phy, it's a regular USB HS phy. Follow the generic node name recommendation, and rename it to "usb-phy". Signed-off-by: Lubomir Rintel --- arch/arm/boot/dts/mmp2.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/m

[PATCH 0/5] ARM: dts: mmp2: devicetree updates

2019-06-20 Thread Lubomir Rintel
Hi, Here's a couple of updates for the MMP2 SoC devicetree files. They're pretty much independent of each other, can be applied in any order. Lubo

[PATCH 1/5] ARM: dts: mmp2: trivial whitespace fix

2019-06-20 Thread Lubomir Rintel
A missing space before a curly brace. Signed-off-by: Lubomir Rintel --- arch/arm/boot/dts/mmp2.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/mmp2.dtsi b/arch/arm/boot/dts/mmp2.dtsi index b6f40743e07b..50b6c38b39cc 100644 --- a/arch/arm/boot/dts/mmp2

[PATCH 2/5] ARM: dts: mmp2: fix the SPI nodes

2019-06-20 Thread Lubomir Rintel
The SPI bus has a single address cell and not size cells. Also, dtc thinks the SPI nodes are preferrably called "spi" and it is right to think so. Signed-off-by: Lubomir Rintel --- arch/arm/boot/dts/mmp2.dtsi | 16 1 file changed, 12 insertions(+), 4 deletions(-)

[PATCH 5/5] ARM: dts: mmp2: specify reg-shift for the UARTs

2019-06-20 Thread Lubomir Rintel
This makes the 8250_of driver happy. There are two more drivers in the tree that bind to mrvl,mmp-uart compatibles: pxa and 8250_pxa and neither of them requires the reg-shift property, assuming it's always 2. Signed-off-by: Lubomir Rintel --- arch/arm/boot/dts/mmp2.dtsi | 4 1 file

[PATCH 4/5] ARM: dts: mmp2: add camera interfaces

2019-06-20 Thread Lubomir Rintel
Signed-off-by: Lubomir Rintel --- arch/arm/boot/dts/mmp2.dtsi | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm/boot/dts/mmp2.dtsi b/arch/arm/boot/dts/mmp2.dtsi index 21432cb9143f..68b547077323 100644 --- a/arch/arm/boot/dts/mmp2.dtsi +++ b/arch/arm/boot/dts

[PATCH] irqchip/mmp: do not use of_address_to_resource() to get mux regs

2019-06-20 Thread Lubomir Rintel
_to_resource() won't work. We should treat the values as mere integers as opposed to bus addresses. Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek --- Changes since v4 of "MMP platform fixes" set - Add a comment, as suggested by Pavel --- drivers/irqchip/irq-mmp.c | 20 ++

[PATCH RESEND] mmc: core: try to use an id from the devicetree

2019-06-20 Thread Lubomir Rintel
If there's a mmc* alias in the device tree, take the device number from it, so that we end up with a device name that matches the alias. Signed-off-by: Lubomir Rintel --- drivers/mmc/core/host.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/core/host.c b

Re: [PATCH v2 2/2] mfd: ene-kb3930: Add driver for ENE KB3930 Embedded Controller

2020-05-04 Thread Lubomir Rintel
Hi, thanks for your review. There are some inline responses below. Where I'm not responding it means that I'll be just fixing what you've pointed out. On Wed, Apr 29, 2020 at 07:00:37AM +0100, Lee Jones wrote: > On Sat, 25 Apr 2020, Lubomir Rintel wrote: > > > This driver pro

Re: [PATCH v2 3/3] ARM: mmp: Replace by

2020-05-05 Thread Lubomir Rintel
On Tue, May 05, 2020 at 05:45:36PM +0200, Geert Uytterhoeven wrote: > The Marvell MMP platform code is not a clock provider, and just needs to > call of_clk_init(). > > Hence it can include instead of . > > Signed-off-by: Geert Uytterhoeven > Reviewed-by: Stephen Boy

[RESEND PATCH v2 2/3] dt-bindings: phy: Allow BSD licensing of marvell,mmp3-hsic-phy.yaml

2020-05-09 Thread Lubomir Rintel
I wrote this binding and I'm fine with it being GPL + BSD dual-licensed, as is recommended for new DT bindings. Signed-off-by: Lubomir Rintel --- .../devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation

[RESEND PATCH v2 0/3] phy: Add USB HSIC PHY driver for Marvell MMP3 SoC

2020-05-09 Thread Lubomir Rintel
please consider applying this patch set. It adds the HSIC PHY driver for Marvell MMP3 along with related DT binding changes (added since v1). Thank you, Lubo

[RESEND PATCH v2 1/3] dt-bindings: phy: Drop reset-gpios from marvell,mmp3-hsic-phy

2020-05-09 Thread Lubomir Rintel
This has been added in error -- the PHY block doesn't have a reset pin. Signed-off-by: Lubomir Rintel --- .../devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml | 7 --- 1 file changed, 7 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml b

[RESEND PATCH v2 3/3] phy: Add USB HSIC PHY driver for Marvell MMP3 SoC

2020-05-09 Thread Lubomir Rintel
Add PHY driver for the HSICs found on Marvell MMP3 SoC. The driver is rather straightforward -- the PHY essentially just needs to be enabled. Signed-off-by: Lubomir Rintel --- Changes since v1: - Explicitely cast drvdata pointer to make sparse happy drivers/phy/marvell/Kconfig | 12

[PATCH 1/3] drm/etnaviv: Fix error path on failure to enable bus clk

2020-05-13 Thread Lubomir Rintel
Since commit 65f037e8e908 ("drm/etnaviv: add support for slave interface clock") the reg clock is enabled before the bus clock and we need to undo its enablement on error. Fixes: 65f037e8e908 ("drm/etnaviv: add support for slave interface clock") Signed-off-by: Lubomir Rint

[PATCH 3/3] drm/etnaviv: Simplify clock enable/disable

2020-05-13 Thread Lubomir Rintel
All the NULL checks are pointless, clk_*() routines already deal with NULL just fine. Signed-off-by: Lubomir Rintel --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 53 ++- 1 file changed, 19 insertions(+), 34 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c

[no subject]

2020-05-13 Thread Lubomir Rintel
Hi, please consider applying patches that are chained to this message. They make getting/enabling the clocks in the etnaviv driver slightly nicer, first two also fix potential problems. Thanks Lubo

[PATCH 2/3] drm/etnaviv: Don't ignore errors on getting clocks

2020-05-13 Thread Lubomir Rintel
There might be good reasons why the getting a clock failed. To treat the clocks as optional we're specifically only interested in ignoring -ENOENT, and devm_clk_get_optional() does just that. Signed-off-by: Lubomir Rintel --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 16 1 file

[PATCH] drm/etnaviv: Fix the pm_domain lookup

2020-05-13 Thread Lubomir Rintel
res match more than one domain. This tries to remedy it. Tested with kmscube with mesa 20 on ome machine with GC860 and another with GC2000 + GC300 pair. Signed-off-by: Lubomir Rintel --- drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --

Re: [PATCH 44/46] ARM: mmp: remove tavorevb board support

2019-10-19 Thread Lubomir Rintel
s a third board named TavorEVB in the Kconfig description, > but this refers to the "TTC_DKB" machine. The two are clearly > related, so I change the Kconfig description to just list both > names. > > Cc: Lubomir Rintel > Signed-off-by: Arnd Bergmann Reviewed-by: Lubomir

Re: [PATCH v2 0/9] Simplify MFD Core

2019-10-21 Thread Lubomir Rintel
On Mon, 2019-10-21 at 13:29 +0200, Arnd Bergmann wrote: > On Mon, Oct 21, 2019 at 12:58 PM Lee Jones wrote: > > MFD currently has one over-complicated user. CS5535 uses a mixture of > > cell cloning, reference counting and subsystem-level call-backs to > > achieve its goal of requesting an IO

Re: [PATCH v2 0/9] Simplify MFD Core

2019-10-21 Thread Lubomir Rintel
On Mon, 2019-10-21 at 12:53 +0100, Lee Jones wrote: > On Mon, 21 Oct 2019, Lubomir Rintel wrote: > > > On Mon, 2019-10-21 at 13:29 +0200, Arnd Bergmann wrote: > > > On Mon, Oct 21, 2019 at 12:58 PM Lee Jones wrote: > > > > MFD currently has one over-complic

[PATCH v2 00/10] clk: mmp2: Enable Audio and GPU on MMP2 and MMP3

2020-05-11 Thread Lubomir Rintel
Hi, please consider applying this patch set for 5.8. The goal is to add support for various clocks used by the GPUs and Audio subsystem MMP2 and MMP3-based machines. Probably the most significant part is that this adds support for runtime PM domains which is managed by the same PMU hardware as

[PATCH v2 03/10] dt-bindings: marvell,mmp2: Add clock id for the I2S clocks

2020-05-11 Thread Lubomir Rintel
There are two of these on a MMP2. Signed-off-by: Lubomir Rintel Acked-by: Rob Herring --- Changes since v1: - Rob's ack include/dt-bindings/clock/marvell,mmp2.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/dt-bindings/clock/marvell,mmp2.h b/include/dt-bindings/clock/marvell

[PATCH v2 01/10] clk: mmp: frac: Do not lose last 4 digits of precision

2020-05-11 Thread Lubomir Rintel
. Maybe also elsewhere, now that since commit ea56ad60260e ("clk: mmp2: Stop pretending PLL outputs are constant") the parent rates are more precise and no longer rounded to 1s. Signed-off-by: Lubomir Rintel --- drivers/clk/mmp/clk-frac.c | 24 1 file c

[PATCH v2 07/10] clk: mmp2: Add the I2C clocks

2020-05-11 Thread Lubomir Rintel
A pair of fractional clock sources for PLLs and gates. Signed-off-by: Lubomir Rintel --- drivers/clk/mmp/clk-of-mmp2.c | 46 +++ 1 file changed, 46 insertions(+) diff --git a/drivers/clk/mmp/clk-of-mmp2.c b/drivers/clk/mmp/clk-of-mmp2.c index ac88ea99b7c6

[PATCH v2 09/10] dt-bindings: marvell,mmp2: Add ids for the power domains

2020-05-11 Thread Lubomir Rintel
On MMP2 the audio and GPU blocks are on separate power islands. On MMP3 the camera block's power is also controlled separately. Add the numbers that we could use to refer to the power domains for respective power islands from the device tree. Signed-off-by: Lubomir Rintel Acked-by: Rob Herring

[PATCH v2 08/10] clk: mmp2: Add the audio clock

2020-05-11 Thread Lubomir Rintel
This clocks the Audio block. Signed-off-by: Lubomir Rintel --- drivers/clk/mmp/clk-of-mmp2.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/clk/mmp/clk-of-mmp2.c b/drivers/clk/mmp/clk-of-mmp2.c index dcdff06a698a..c686c16fca82 100644 --- a/drivers/clk/mmp/clk-of-mmp2.c +++ b

[PATCH v2 10/10] clk: mmp2: Add support for power islands

2020-05-11 Thread Lubomir Rintel
and the SSPA. Signed-off-by: Lubomir Rintel --- arch/arm/mach-mmp/Kconfig | 2 + drivers/clk/mmp/Makefile | 2 +- drivers/clk/mmp/clk-of-mmp2.c | 42 + drivers/clk/mmp/clk.h | 10 +++ drivers/clk/mmp/pwr-island.c | 115 ++ 5 files

[PATCH v2 05/10] clk: mmp2: Move thermal register defines up a bit

2020-05-11 Thread Lubomir Rintel
A trivial change to keep the sorting sane. The APBC registers are happier when they are grouped together, instead of mixed with the APMU ones. Signed-off-by: Lubomir Rintel --- drivers/clk/mmp/clk-of-mmp2.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk

[PATCH v2 06/10] clk: mmp2: Rename mmp2_pll_init() to mmp2_main_clk_init()

2020-05-11 Thread Lubomir Rintel
This is a trivial rename for a routine that registers more clock sources than the PLLs -- there's also a XO. Signed-off-by: Lubomir Rintel --- drivers/clk/mmp/clk-of-mmp2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/mmp/clk-of-mmp2.c b/drivers/clk/mmp

[PATCH v2 02/10] clk: mmp: frac: Allow setting bits other than the numerator/denominator

2020-05-11 Thread Lubomir Rintel
For the I2S fractional clocks, there are more bits that need to be set for the clock to run. Their actual meaning is unknown. Signed-off-by: Lubomir Rintel --- drivers/clk/mmp/clk-frac.c | 3 +++ drivers/clk/mmp/clk.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/clk/mmp

[PATCH v2 04/10] dt-bindings: marvell,mmp2: Add clock id for the Audio clock

2020-05-11 Thread Lubomir Rintel
This clocks the Audio block. Signed-off-by: Lubomir Rintel Acked-by: Rob Herring --- Changes since v1: - Rob's ack include/dt-bindings/clock/marvell,mmp2.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/dt-bindings/clock/marvell,mmp2.h b/include/dt-bindings/clock/marvell,mmp2.h

[PATCH 0/2] MMP2 Audio clock controller driver

2020-05-11 Thread Lubomir Rintel
Hi, please consider applying this patch set. It contains a driver for the audio clock generator on Marvell MMP2 along with the DT bindings. Currently the I2S driver (mmp2-sspa) doesn't have support for DT and is not able to get clocks from this driver. The patch set to address that will be sent

[PATCH 2/2] clk: mmp2: Add audio clock controller driver

2020-05-11 Thread Lubomir Rintel
This is a driver for a block that generates master and bit clocks for the I2S interface. It's separate from the PMUs that generate clocks for the peripherals. Signed-off-by: Lubomir Rintel --- drivers/clk/Kconfig | 6 + drivers/clk/mmp/Makefile| 1 + drivers/clk/mmp/clk-audio.c

[PATCH 1/2] dt-bindings: sound: Add Marvell MMP Audio Clock Controller binding

2020-05-11 Thread Lubomir Rintel
This describes the bindings for a controller that generates master and bit clocks for the I2S interface. Signed-off-by: Lubomir Rintel --- .../clock/marvell,mmp2-audio-clock.yaml | 73 +++ .../dt-bindings/clock/marvell,mmp2-audio.h| 8 ++ 2 files changed, 81

[PATCH 01/11] ASoC: mmp-sspa: Flip SNDRV_PCM_FMTBIT_S24_3LE on

2020-05-11 Thread Lubomir Rintel
The hw_params() callback handles the 3-byte format, not SNDRV_PCM_FMTBIT_S24_LE. Signed-off-by: Lubomir Rintel --- sound/soc/pxa/mmp-sspa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/pxa/mmp-sspa.c b/sound/soc/pxa/mmp-sspa.c index 3548a2634a63..1ca6afe464c4

[PATCH 11/11] ASoC: mmp-sspa: Add Device Tree support

2020-05-11 Thread Lubomir Rintel
For this reason, mmp_sspa_write_reg() and mmp_sspa_read_reg() are replaced with direct calls to I/O routines. Tested on a MMP2-based OLPC XO-1.75 laptop with rt5631 coded, mmp_tdma DMA engine and MMP2 clock controller glued together with audio-graph-card. Signed-off-by: Lubomir Rintel --- sound/soc/pxa

[PATCH 04/11] ASoC: mmp-sspa: Get rid of dma_params and phys_base

2020-05-11 Thread Lubomir Rintel
of the DMA transfer by phys_base. Firstly, it's never set and is always zero. Secondly, the hardware actually ignores it, at least on a MMP2 and MMP3. Signed-off-by: Lubomir Rintel --- sound/soc/pxa/mmp-sspa.c | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions

[PATCH 06/11] ASoC: mmp-sspa: Remove the embedded struct ssp_device

2020-05-11 Thread Lubomir Rintel
The "serial port" it represents is actually a SPI controller -- it's not clear why would the audio serial interface embed it. We're only using the mmio_base and clk fields. Signed-off-by: Lubomir Rintel --- sound/soc/pxa/mmp-sspa.c | 129 ++- 1 fi

[PATCH 09/11] ASoC: mmp-sspa: Set appropriate bus format for given bit width

2020-05-11 Thread Lubomir Rintel
is not available. Signed-off-by: Lubomir Rintel --- sound/soc/pxa/mmp-sspa.c | 40 sound/soc/pxa/mmp-sspa.h | 2 ++ 2 files changed, 30 insertions(+), 12 deletions(-) diff --git a/sound/soc/pxa/mmp-sspa.c b/sound/soc/pxa/mmp-sspa.c index 9cb17c4fb0c8..86277471974a

[PATCH 07/11] ASoC: mmp-sspa: Prepare/unprepare the clocks

2020-05-11 Thread Lubomir Rintel
The driver enables the clocks without preparing them and disables without unpreparing afterwards. Fix that. Signed-off-by: Lubomir Rintel --- sound/soc/pxa/mmp-sspa.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/soc/pxa/mmp-sspa.c b/sound/soc/pxa/mmp

[PATCH 03/11] ASoC: mmp-sspa: A trivial typo fix

2020-05-11 Thread Lubomir Rintel
"Transmit", not "Tansmit". Signed-off-by: Lubomir Rintel --- sound/soc/pxa/mmp-sspa.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/pxa/mmp-sspa.h b/sound/soc/pxa/mmp-sspa.h index 7d1b7c7325df..611063a7af68 100644 --- a/sound/soc/pxa/mmp-ss

[PATCH 10/11] dt-bindings: sound: Add Marvell MMP SSPA binding

2020-05-11 Thread Lubomir Rintel
Add binding documentation for the audio serial port interface (I2S) on Marvell MMP SoCs. Signed-off-by: Lubomir Rintel --- .../bindings/sound/marvell,mmp-sspa.yaml | 122 ++ 1 file changed, 122 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound

[PATCH 08/11] ASoC: mmp-sspa: Add support for the runtime power management

2020-05-11 Thread Lubomir Rintel
Only turn on the Audio island when it's in use. This requires keeping track of control register contents instead of reloading them back from hardware, because they're lost when the power is off. Signed-off-by: Lubomir Rintel --- sound/soc/pxa/mmp-sspa.c | 126

[PATCH 05/11] ASoC: mmp-sspa: Add support for soc-generic-dmaengine-pcm

2020-05-11 Thread Lubomir Rintel
seem to make it through for reasons unknown to me. Signed-off-by: Lubomir Rintel --- sound/soc/pxa/mmp-sspa.c | 57 1 file changed, 57 insertions(+) diff --git a/sound/soc/pxa/mmp-sspa.c b/sound/soc/pxa/mmp-sspa.c index 421ffa9fa7b1..6e4b63d0c589 100644

[PATCH 02/11] ASoC: mmp-sspa: Drop S20_3LE case

2020-05-11 Thread Lubomir Rintel
It does nothing, because the corresponding bit s not flipped on in .formats and the audio SRAM DMA engine is not able to handle 20-bit transfers anyway. Signed-off-by: Lubomir Rintel --- sound/soc/pxa/mmp-sspa.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sound/soc/pxa/mmp-sspa.c b

[PATCH 00/11] Make sound work on DT-based MMP2 machines

2020-05-11 Thread Lubomir Rintel
Hi, this patch set reworks the mmp-sspa driver to work on a device tree based MMP2 machines. My motivation is to make sound work on a MMP2-based OLPC XO-1.75 laptop. Note that currently the driver is pretty much orphaned -- it is not used by any boards and nothing in tree provides the necessary

Re: [PATCH 07/11] ASoC: mmp-sspa: Prepare/unprepare the clocks

2020-05-12 Thread Lubomir Rintel
On Tue, May 12, 2020 at 01:45:20PM +0100, Mark Brown wrote: > On Mon, May 11, 2020 at 11:01:30PM +0200, Lubomir Rintel wrote: > > The driver enables the clocks without preparing them and disables > > without unpreparing afterwards. Fix that. > > This fix should've been ear

Re: [PATCH 19/28] dt-bindings: mmc: Convert sdhci-pxa to json-schema

2020-05-17 Thread Lubomir Rintel
On Wed, Mar 18, 2020 at 04:37:55PM -0600, Rob Herring wrote: > On Tue, Mar 17, 2020 at 3:40 AM Lubomir Rintel wrote: > > > > Convert the sdhci-pxa binding to DT schema format using json-schema. > > Ignore what my bot said, I see you addressed that earlier in the series. &g

Re: [PATCH 21/28] dt-bindings: gpio: Convert mrvl-gpio to json-schema

2020-05-17 Thread Lubomir Rintel
On Fri, Mar 27, 2020 at 01:28:20PM -0600, Rob Herring wrote: > On Tue, Mar 17, 2020 at 10:39:15AM +0100, Lubomir Rintel wrote: > > This converts the mrvl-gpio binding to DT schema format using json-schema. > > > > Various fixes were done during the conversion, such as addin

Re: [PATCH 23/28] dt-bindings: interrupt-controller: Convert mrvl,intc to json-schema

2020-05-17 Thread Lubomir Rintel
On Fri, Mar 27, 2020 at 01:42:07PM -0600, Rob Herring wrote: > On Tue, Mar 17, 2020 at 10:39:17AM +0100, Lubomir Rintel wrote: > > Convert the mrvl,intc binding to DT schema format using json-schema. > > > > Signed-off-by: Lubomir Rintel > > --- > > .../i

Re: [PATCH 24/28] dt-bindings: media: Convert marvell,mmp2-ccic to json-schema

2020-05-17 Thread Lubomir Rintel
On Fri, Mar 27, 2020 at 01:46:37PM -0600, Rob Herring wrote: > On Tue, Mar 17, 2020 at 10:39:18AM +0100, Lubomir Rintel wrote: > > Convert the marvell,mmp2-ccic binding to DT schema format using > > json-schema. > > > > Signed-off-by: Lubomir Rintel > > --- >

Re: [PATCH 25/28] dt-bindings: rtc: Convert sa1100-rtc to json-schema

2020-05-17 Thread Lubomir Rintel
On Fri, Mar 27, 2020 at 01:49:02PM -0600, Rob Herring wrote: > On Tue, Mar 17, 2020 at 10:39:19AM +0100, Lubomir Rintel wrote: > > Convert the sa1100-rtc binding to DT schema format using json-schema. > > > > Signed-off-by: Lubomir Rintel > > --- > > .../devic

Re: [PATCH 26/28] dt-bindings: spi: Convert spi-pxa2xx to json-schema

2020-05-17 Thread Lubomir Rintel
On Fri, Mar 27, 2020 at 01:52:39PM -0600, Rob Herring wrote: > On Tue, Mar 17, 2020 at 10:39:20AM +0100, Lubomir Rintel wrote: > > A straightforward conversion of the the spi-pxa2xx binding to DT schema > > format using json-schema. > > > > Signed-off-by: Lubomir Rintel

Re: [PATCH 28/28] dt-bindings: usb: Convert ehci-mv to json-schema

2020-05-17 Thread Lubomir Rintel
On Fri, Mar 27, 2020 at 01:55:20PM -0600, Rob Herring wrote: > On Tue, Mar 17, 2020 at 10:39:22AM +0100, Lubomir Rintel wrote: > > A straightforward conversion of the ehci-mv binding to DT schema format > > using json-schema. > > > > Signed-off-by: Lubomir Rintel

[PATCH v6 0/2] mfd: Add ENE KB3930 Embedded Controller driver

2020-07-09 Thread Lubomir Rintel
Hi, please consider applying the patches chained to this message. It's the sixth version of the driver for the ENE KB3930 Embedded Controller. This addresses responses to the fifth version of the set. Detailed change logs are in the individual patch descriptions. One thing that I was asked to

[PATCH v6 2/2] mfd: ene-kb3930: Add driver for ENE KB3930 Embedded Controller

2020-07-09 Thread Lubomir Rintel
platform, it registers the appropriate cells. Signed-off-by: Lubomir Rintel --- Changes since v5: - Clarify the command in kb3930_off() - Remove an extraneous comment above the call to devm_mfd_add_devices() - s/pm_power_off == NULL/!pm_power_off/ Changes since v3: - Clarify that the power-off

[PATCH v6 1/2] dt-bindings: mfd: Add ENE KB3930 Embedded Controller binding

2020-07-09 Thread Lubomir Rintel
Add binding document for the ENE KB3930 Embedded Controller. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v5: - s/a I2C bus/an I2C bus/ Changes since v4: - Collected Rob's Reviewed-by Changes since v1: - Addressed binding validation failure --- .../devicetree

Re: [PATCH v5 1/2] dt-bindings: mfd: Add ENE KB3930 Embedded Controller binding

2020-06-22 Thread Lubomir Rintel
On Mon, Jun 22, 2020 at 07:53:50AM +0100, Lee Jones wrote: > On Wed, 17 Jun 2020, Lubomir Rintel wrote: > > > Add binding document for the ENE KB3930 Embedded Controller. > > > > Signed-off-by: Lubomir Rintel > > Reviewed-by: Rob Herring > > > > --- &

Re: [PATCH v2 RESEND] MAINTAINERS: rectify MMP SUPPORT after moving cputype.h

2020-06-19 Thread Lubomir Rintel
; T: git git://git.kernel.org/pub/scm/linux/kernel/git/lkundrak/linux-mmp.git > F: arch/arm/boot/dts/mmp* > F: arch/arm/mach-mmp/ > -F: linux/soc/mmp/ > +F: include/linux/soc/mmp/ > > MMP USB PHY DRIVERS > R: Lubomir Rintel > -- > 2.17.1 >

Re: [PATCH] MAINTAINERS: fix incorrect directory reference

2020-06-19 Thread Lubomir Rintel
cm/linux/kernel/git/lkundrak/linux-mmp.git > F: arch/arm/boot/dts/mmp* > F: arch/arm/mach-mmp/ > -F: linux/soc/mmp/ > +F: include/linux/soc/mmp/ > > MMP USB PHY DRIVERS > R: Lubomir Rintel > -- > 2.27.0 >

[RESEND PATCH] media: marvell-ccic: Add support for runtime PM

2020-05-20 Thread Lubomir Rintel
On MMP3, the camera block lives on na separate power island. We want to turn it off if the CCIC is not in use to conserve power. Signed-off-by: Lubomir Rintel --- drivers/media/platform/marvell-ccic/mcam-core.c | 3 +++ drivers/media/platform/marvell-ccic/mmp-driver.c | 12 2

[PATCH v3 0/2] mfd: Add ENE KB3930 Embedded Controller driver

2020-05-20 Thread Lubomir Rintel
Hi, please consider applying the patches chained to this message. It's the third version of the driver for the ENE KB3930 Embedded Controller. This version attempts to address the issues pointed out in review of v2. A more detailed change log it in the patch description of patch 2/2. Thanks,

[PATCH v3 2/2] mfd: ene-kb3930: Add driver for ENE KB3930 Embedded Controller

2020-05-20 Thread Lubomir Rintel
platform, it registers the appropriate cells. Signed-off-by: Lubomir Rintel --- Changes since v2: - Sort the includes - s/EC_MODEL_ID/EC_MODEL/ - Add a couple of clarifying comments - Use #defines for values used in poweroff routine - Remove priority from a restart notifier block - s/priv/ddata

[PATCH v3 1/2] dt-bindings: mfd: Add ENE KB3930 Embedded Controller binding

2020-05-20 Thread Lubomir Rintel
Add binding document for the ENE KB3930 Embedded Controller. Signed-off-by: Lubomir Rintel --- Changes since v1: - Addressed binding validation failure .../devicetree/bindings/mfd/ene-kb3930.yaml | 55 +++ 1 file changed, 55 insertions(+) create mode 100644 Documentation

[PATCH v2 1/9] dt-bindings: mmc: Convert sdhci-pxa to json-schema

2020-05-21 Thread Lubomir Rintel
Convert the sdhci-pxa binding to DT schema format using json-schema. At the same time, fix a couple of issues with the examples discovered by the validation tool -- a semicolon instead of a comma and wrong node names. Signed-off-by: Lubomir Rintel --- Changes since v1: - move reg-names items

[PATCH 0/9] DT: Improve validation for Marvell SoCs

2020-05-21 Thread Lubomir Rintel
Hi, chained to this message is a second version of remaining patches from the first spin of the "DT: Improve validation for Marvell SoCs" [1] patch set. [1] https://lore.kernel.org/lkml/20200317093922.20785-1-lkund...@v3.sk/ I've attempted to address the review of the v1, each patch includes a

[PATCH v2 7/9] dt-bindings: spi: Convert spi-pxa2xx to json-schema

2020-05-21 Thread Lubomir Rintel
A straightforward conversion of the the spi-pxa2xx binding to DT schema format using json-schema. Signed-off-by: Lubomir Rintel --- Changes since v1: - Drop #address-cells and #size-cells - s/GPL-2.0-or-later/GPL-2.0-only/ .../bindings/spi/marvell,mmp2-ssp.yaml| 56

[PATCH v2 5/9] dt-bindings: media: Convert marvell,mmp2-ccic to json-schema

2020-05-21 Thread Lubomir Rintel
robably a clock for the sensor and it would belong in the sensor node. Signed-off-by: Lubomir Rintel --- Changes since v1: - Fix indentation - Drop clocks other than "axi" - s/GPL-2.0-or-later/GPL-2.0-only/ .../bindings/media/marvell,mmp2-ccic.txt | 50 -- .../bindin

[PATCH v2 3/9] dt-bindings: i2c: Convert i2c-pxa to json-schema

2020-05-21 Thread Lubomir Rintel
ing to do and indeed nobody seems to have been doing that. There also was "Recommended properties" section that included optional as well as mandatory properties. Missing mandatory properties were added to the example. Signed-off-by: Lubomir Rintel --- Changes since v1: - Add default G

[PATCH v2 2/9] dt-bindings: gpio: Convert mrvl-gpio to json-schema

2020-05-21 Thread Lubomir Rintel
in the tree, but it doesn't end up in any actual DTB file. In any case -- the schema merely copies whatever was in the original binding document, so it's hopefully no more wrong that the original. Signed-off-by: Lubomir Rintel --- Changes since v1: - Drop marvell,pxa1928-gpio - Drop ranges from example

[PATCH v2 9/9] dt-bindings: usb: Convert ehci-mv to json-schema

2020-05-21 Thread Lubomir Rintel
A straightforward conversion of the ehci-mv binding to DT schema format using json-schema. Signed-off-by: Lubomir Rintel --- Changes since v1: - s/GPL-2.0-or-later/GPL-2.0-only/ .../devicetree/bindings/usb/ehci-mv.txt | 23 --- .../bindings/usb/marvell,pxau2o-ehci.yaml | 60

[PATCH v2 4/9] dt-bindings: interrupt-controller: Convert mrvl,intc to json-schema

2020-05-21 Thread Lubomir Rintel
Convert the mrvl,intc binding to DT schema format using json-schema. Signed-off-by: Lubomir Rintel --- Changes since v1: - Move minItems/maxItems to main reg property definition from the conditional one - Drop the condition for marvell,orion-intc - Add default GPL-2.0-only license tag - Fill

[PATCH v2 6/9] dt-bindings: rtc: Convert sa1100-rtc to json-schema

2020-05-21 Thread Lubomir Rintel
Convert the sa1100-rtc binding to DT schema format using json-schema. While add that, add clocks and resets that are actually used. Signed-off-by: Lubomir Rintel --- Changes since v1: - Remove interrupts/maxItems - Mention clocks and resets in the patch description - Add default GPL-2.0-only

[PATCH v2 8/9] dt-bindings: timer: Convert mrvl,mmp-timer to json-schema

2020-05-21 Thread Lubomir Rintel
A straightforward conversion of the mrvl,mmp-timer binding to DT schema format using json-schema. Signed-off-by: Lubomir Rintel --- Changes since v1: - Add default GPL-2.0-only license tag - Fill in maintainers from MAINTAINERS file .../bindings/timer/mrvl,mmp-timer.txt | 17

[PATCH v4 0/2] mfd: Add ENE KB3930 Embedded Controller driver

2020-05-21 Thread Lubomir Rintel
Hi, please consider applying the patches chained to this message. It's the fourth version of the driver for the ENE KB3930 Embedded Controller. This version attempts to address the issues pointed out in review of v3. A more detailed change log it in the patch description of patch 2/2. Thanks,

[PATCH v4 1/2] dt-bindings: mfd: Add ENE KB3930 Embedded Controller binding

2020-05-21 Thread Lubomir Rintel
Add binding document for the ENE KB3930 Embedded Controller. Signed-off-by: Lubomir Rintel --- Changes since v1: - Addressed binding validation failure --- .../devicetree/bindings/mfd/ene-kb3930.yaml | 55 +++ 1 file changed, 55 insertions(+) create mode 100644 Documentation

[PATCH v4 2/2] mfd: ene-kb3930: Add driver for ENE KB3930 Embedded Controller

2020-05-21 Thread Lubomir Rintel
platform, it registers the appropriate cells. Signed-off-by: Lubomir Rintel --- Changes since v3: - Clarify that the power-off function is provided by this driver while LEDS_ARIEL is necessary to drive the leds in Kconfig help text - s/kb3930_power_off/kb3930_pm_power_off/, s/global_kb3930

[PATCH] i2c: pxa: don't error out if there's no pinctrl

2020-06-02 Thread Lubomir Rintel
The bus recovery patch regresses on OLPC XO-1.75 that has no pinctrl in its DT. Fixes: 7c9ec2c52518 ("i2c: pxa: implement generic i2c bus recovery")' Signed-off-by: Lubomir Rintel --- drivers/i2c/busses/i2c-pxa.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/i2c/busses

[PATCH 02/13] ARM: dts: mmp2-olpc-xo-1-75: Delete #address-cells from ssp3

2020-06-16 Thread Lubomir Rintel
-olpc-xo-1-75.dt.yaml: spi@d4037000: '#address-cells' is a dependency of '#size-cells' Signed-off-by: Lubomir Rintel --- arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts b/arch/arm/boot/dts

[PATCH 01/13] ARM: dts: mmp2-olpc-xo-1-75: Fix camera I2C node validation

2020-06-16 Thread Lubomir Rintel
documented as deprecated, but got dropped in commit 0175ce4a58d6 ("dt-bindings: i2c: Convert i2c-gpio binding to json-schema"). It's probably best kept forgotten though. Signed-off-by: Lubomir Rintel --- arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts | 6 +++--- 1 file changed, 3 insert

[PATCH 04/13] ARM: dts: mmp2: Extend the MPMU reg range

2020-06-16 Thread Lubomir Rintel
The ACGR register is at the offset of 0x1024, beyond the 4k originally assigned to the MPMU range. Signed-off-by: Lubomir Rintel --- arch/arm/boot/dts/mmp2.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/mmp2.dtsi b/arch/arm/boot/dts/mmp2.dtsi index

[PATCH 03/13] ARM: dts: mmp2: Add #power-domain-cells to /clocks

2020-06-16 Thread Lubomir Rintel
The power management unit, described by the soc_clocks node, controls the power to the peripherals by the means of power domains with a single cell -- the domain number. Signed-off-by: Lubomir Rintel --- arch/arm/boot/dts/mmp2.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm

[PATCH 06/13] ARM: dts: mmp2: Add DMA nodes

2020-06-16 Thread Lubomir Rintel
There is a 16-channel peripheral DMA controller along with two-channel audio DMA engines. Signed-off-by: Lubomir Rintel --- arch/arm/boot/dts/mmp2.dtsi | 26 ++ 1 file changed, 26 insertions(+) diff --git a/arch/arm/boot/dts/mmp2.dtsi b/arch/arm/boot/dts/mmp2.dtsi index

[PATCH 10/13] ARM: dts: mmp2: Add the GPU

2020-06-16 Thread Lubomir Rintel
There's a GC860 2D + 3D core. Signed-off-by: Lubomir Rintel --- arch/arm/boot/dts/mmp2.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/mmp2.dtsi b/arch/arm/boot/dts/mmp2.dtsi index 31592acd3ef4f..445bdcd50b9ed 100644 --- a/arch/arm/boot/dts/mmp2.dtsi

[PATCH 07/13] ARM: dts: mmp2: Add Audio Clock controller

2020-06-16 Thread Lubomir Rintel
This device generates the audio codec master clock and bit clock. Signed-off-by: Lubomir Rintel --- arch/arm/boot/dts/mmp2.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/mmp2.dtsi b/arch/arm/boot/dts/mmp2.dtsi index b349f4f35706b..dd7fba65799ea 100644

[PATCH 12/13] ARM: dts: mmp3: Add the GPU

2020-06-16 Thread Lubomir Rintel
There's a GC2000 3D core accompanied by a GC300 2D core. Signed-off-by: Lubomir Rintel --- arch/arm/boot/dts/mmp3.dtsi | 25 + 1 file changed, 25 insertions(+) diff --git a/arch/arm/boot/dts/mmp3.dtsi b/arch/arm/boot/dts/mmp3.dtsi index 57231d49d9386..cc4efd0efabd2

[PATCH 13/13] MMP DTS updates for 5.9

2020-06-16 Thread Lubomir Rintel
Hi, chained to this message is a patch set I hope would end up queued into soc/arm/dt for 5.9. It applies cleanly on top of v5.8-rc1. I've checked I'm not adding new validation errors and booted the v5.8-rc1 kernels with appended DTBs on the XO-1.75 and Dell Ariel board. Lubo

[PATCH 05/13] ARM: dts: mmp2: Add Audio SRAM

2020-06-16 Thread Lubomir Rintel
This memory is region is where the two-channel audio DMA can pump sound samples into the SSPA's internal FIFO. Signed-off-by: Lubomir Rintel --- arch/arm/boot/dts/mmp2.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/mmp2.dtsi b/arch/arm/boot/dts/mmp2.dtsi

[PATCH 11/13] ARM: dts: mmp2-olpc-xo-1-75: Enable the GPU

2020-06-16 Thread Lubomir Rintel
Enable the 3D + 2D (GC860) GPU core. Signed-off-by: Lubomir Rintel --- arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts b/arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts index 5f1da58550987..f1a41152e9dd7 100644

<    3   4   5   6   7   8   9   10   11   12   >